[08:20:55] <addshore>	 YuviPanda: Dashiki!
[08:21:01] <addshore>	 apparently thats the in thing...
[08:35:30] <aude>	 addshore: https://www.mediawiki.org/wiki/Compatibility :)
[09:15:05] <JeroenDeDauw>	 addshore: AHHHHHHHHHH https://github.com/wmde/WikibaseDataModelServices/pull/67
[09:26:07] <JeroenDeDauw>	 aude: did this commit in which you made property suggester compatible with latest wikibase.git and DM Services get through already?
[09:26:53] <aude>	 JeroenDeDauw: i think so
[09:33:56] <frimelle>	 hoo https://gerrit.wikimedia.org/r/#/c/232780/
[09:34:28] <hoo>	 got it
[09:36:41] <Thiemo_WMDE>	 Announcing the winner of the "Longest Class Name in the Code Base" award (excluding tests): https://gerrit.wikimedia.org/r/#/c/205097/5/repo/includes/LanguageFallbackLabelDescriptionLookupFactory.php
[09:40:43] <JeroenDeDauw>	 That name is longer than the contents of the class :)
[09:45:05] <JeroenDeDauw>	 hoo: http://img.ctrlv.in/img/15/09/16/55f93a13ddf92.jpg ???
[09:45:25] <JeroenDeDauw>	 hoo: whats with the second argument there?
[09:45:28] <JeroenDeDauw>	 CP error?
[09:46:14] <hoo>	 ugh... where's that?
[10:00:21] <JeroenDeDauw>	 hoo: EntityDataFormatProviderTest
[10:05:33] <hoo>	 JeroenDeDauw: Will have a look, thanks
[10:06:27] <JeroenDeDauw>	 err
[10:06:32] <JeroenDeDauw>	 hoo: im about to submit a thing
[10:07:05] <hoo>	 I can't remember writing that... I think I c&p it when splitting up the class
[10:07:07] <JeroenDeDauw>	 hoo: https://gerrit.wikimedia.org/r/#/c/238707/
[10:07:21] <JeroenDeDauw>	 hoo: looks like bracket confusion or something
[10:07:32] <JeroenDeDauw>	 pinging you just to be sure there is not some magic I don't understand there
[10:13:44] <aude>	 it's a kitten! https://en.wikipedia.org/wiki/User:Aude :)
[10:14:10] <aude>	 https://sv.wikipedia.org/wiki/Anv%C3%A4ndare:Aude
[10:16:59] <aude>	 Lydia_WMDE: https://sv.wikipedia.org/wiki/Anv%C3%A4ndare:Aude
[11:22:05] <JeroenDeDauw>	 benestar: rage merge merge merge https://github.com/wmde/WikibaseDataModelServices/pull/67
[11:22:12] <JeroenDeDauw>	 hoo|away: addshore ^
[11:23:01] <JeroenDeDauw>	 legoktm: https://gerrit.wikimedia.org/r/#/c/236592/
[11:23:23] <jzerebecki>	 YuviPanda: that was one of the options, but they say it is deprecated but still supported and the hip thing is now dashiki. a different question is if people actually follow my suggestion...
[11:24:21] <addshore>	 shiny or dashiki! ;)
[11:24:39] <addshore>	 I keep wanting to call it grashiki...
[12:03:44] <benestar>	 JeroenDeDauw: merged
[12:18:50] <JeroenDeDauw>	 benestar: \o/
[12:18:53] <JeroenDeDauw>	 !nyan | benestar 
[12:18:53] <wm-bot>	 benestar: ~=[,,_,,]:3
[12:19:09] <benestar>	 :)
[12:20:16] <JeroenDeDauw>	 benestar: did you want to make any breaking changes in DMS?
[12:21:10] <benestar>	 I can't think of any but maybe someone else wants?
[12:21:50] <JeroenDeDauw>	 benestar: doubt it
[12:22:18] <JeroenDeDauw>	 anyway https://github.com/wmde/WikibaseDataModelServices/pull/68
[13:34:57] <JeroenDeDauw>	 benestar: guess introducing this new lib in DMS does not make much sense, since at present esentially all stuff that would use it is in WB.git
[13:35:20] <benestar>	 k
[14:13:29] <hoo>	 JeroenDeDauw: Will you go ahead and tag DMS 3.0.0?
[14:18:28] <aude>	 Lydia_WMDE: all the things that are instance of https://www.wikidata.org/wiki/Q459297 (in fawiki)
[14:39:29] <JeroenDeDauw>	 hoo: sure
[14:49:50] <JeroenDeDauw>	 hoo: https://gerrit.wikimedia.org/r/#/c/238754/
[14:53:42] <JeroenDeDauw>	 hoo: once that is merged I'll rebase the other stuff on it
[14:55:21] <hoo>	 JeroenDeDauw: Ok, will have a look at the changes
[14:55:46] <JeroenDeDauw>	 hoo: huh? what changes?
[14:56:10] <hoo>	 JeroenDeDauw: The changes in DMS... just want to look out for breaking changes
[14:56:41] <JeroenDeDauw>	 hoo: we where not using the stuff that got removed...
[14:56:49] <JeroenDeDauw>	 Good to double check tho
[14:57:14] * aude reminds to think of the quality extensions and property suggester 
[14:57:33] <aude>	 good to know that the breaking changes are
[14:57:37] <aude>	 wbat
[14:57:41] <aude>	 what*
[14:59:42] <hoo>	 aude: Yes
[15:01:22] <JeroenDeDauw>	 hoo: we actually ought to not benefit from doing such a manual check - if using the new version breaks stuff, the tests should catch that
[15:02:21] <hoo>	 They should
[15:04:25] <hoo>	 But we don't even run the build tests for these kinds of changes
[15:21:55] <hoo>	 JeroenDeDauw: https://integration.wikimedia.org/ci/job/mwext-WikibaseQualityConstraints-repo-tests-sqlite-zend/74/console mh
[16:15:19] <legoktm>	 JeroenDeDauw: looks like addshore beat me
[18:01:02] <JeroenDeDauw>	 legoktm: yeah, I know, pesky addshore is pesky
[18:01:08] <addshore>	 ;)
[18:05:48] <JeroenDeDauw>	 addshore: delete the codes! https://gerrit.wikimedia.org/r/#/c/238130/
[21:30:05] <benestar>	 gah
[21:30:19] <benestar>	 can it be that the order of parameters matters in the api when using generator stuff? =O
[21:30:30] <benestar>	 aude addshore --^
[21:33:08] <benestar>	 forget about it all, I got a param wrong
[22:51:33] <yuvipanda>	 jzerebecki: heh, good luck