[03:20:12] JOIN [08:19:52] addshore: hey, already around? :) [08:19:57] yup [08:20:12] addshore: I got another idea for the slotty stuff [08:20:15] =o [08:20:19] fire away! [08:20:28] instead of having objects with slots we might also pass a callback to the serializer [08:20:35] a SlotFactory [08:20:45] and the slots are dynamically fetched during serialization [08:20:55] hmmmmm [08:21:00] this way we completely avoid touching the value objects or implementing new ones [08:21:26] perhaps, we need to make sure we have somewhere that we are strict with the schema / layout of the slots [08:21:32] but generally that sounds okay! [08:21:39] we could register decorators for each value object (eg a DerivedValuesDecorator for Snaks [08:21:40] fancy drafting a draft? ;) [08:21:43] sure [08:21:47] :D [08:33:09] addshore: should extra values always be in their own array? [08:33:32] who knows ;P [08:33:33] so eg for sitelinks, do we want "extra-values": { "url": "https://foo" } [08:33:51] I will leave the option to modify the whole serialization [08:33:57] though that seems to be a bit evil :S [08:37:10] well, I think the slots could be in the general serialization, but we dont want to be able to touch stuff that is already there / set [08:40:37] addshore: hmm, so use array_merge? [08:40:47] perhaps [08:41:45] looks a bit better :) [08:56:53] addshore: https://github.com/wmde/WikibaseDataModelSerialization/pull/171/files [09:05:36] benestar: generally looks nice imo [09:05:51] :) [10:50:16] !merge 235063 | addshore [10:50:16] addshore: merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/235063/ [10:53:47] will try and have a look in a bit! [10:54:12] cool [11:29:27] You are admin identified by name .*@wikimedia/-revi [11:29:27] @whoami [11:29:36] heh, still here :o [11:53:20] I've added you to the retrospective meeting as well. you don't need to attend there today except you want, I'm already in the hangout for the planning meeting.. just poke [11:53:35] benestar|cloud: ^^ [12:00:57] Tobi_WMDE_SW: in it [12:01:40] Thiemo_WMDE: T109705 [12:01:44] https://phabricator.wikimedia.org/T109705 [12:03:24] benestar: which one? [12:03:27] Tobi_WMDE_SW: which hangout are you in? [12:03:28] the 14 or 1430 one? [12:03:39] I was in both but didn't find you [12:03:45] joining the 1430 one now [12:03:54] k [13:44:54] Lydia_WMDE: https://phabricator.wikimedia.org/T109232 isn't really a duplicate. This happens on every item, not just big items [16:47:56] aude: where is the best documentation for the dispatcher stuff? [16:49:03] like what? [16:49:51] when running the script with --help, it explains the options [16:50:28] then there is https://wikitech.wikimedia.org/wiki/How_to_deploy_Wikidata_code#Update_cron_jobs [16:50:38] if we actually want to change how it is run [16:51:25] * aude goes to update the page [16:55:36] just curious but why was it not somehow integrated with the job queue stuff? [16:59:03] addshore: there is a task for that [16:59:30] suppose that the whole thing is an ugly mess, but think maybe we can finally get that done soon [17:00:25] addshore: was there a fix for "LuaSandbox: Scribunto_LuaSandboxTests::testArgumentParsingTime" ? [17:01:29] addshore: https://github.com/wmde/WikibaseDataModel/pull/551 [17:01:32] benestar|cloud: ^ [17:01:43] aude: LuaSandbox: Scribunto_LuaSandboxTests::testArgumentParsingTime ? [17:01:46] did I look at that? [17:02:14] addshore: benestar|cloud I'd like to revert https://github.com/wmde/WikibaseDataModelServices/commit/66df0d70eac52bca51272ec96964f643af38227b, though first need that release to happen [17:02:38] sounds familiar [17:02:47] https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension-zend/584/console [17:03:41] oh wait, I remeber now [17:03:43] I touched something Scribunto ish, but I think it was a different issue [17:04:14] oh [17:05:00] wat. A task created by john :D https://phabricator.wikimedia.org/T48248 [17:05:28] aude: https://gerrit.wikimedia.org/r/#/q/status:merged+project:mediawiki/extensions/Scribunto,n,z [17:05:37] see the last thing I merged in there, thats what I touched [17:06:08] specifically https://gerrit.wikimedia.org/r/#/c/233891/ which was merged onto the branches but not master, so think this is a different issue [17:07:07] ok [17:08:59] jenkins approves on recheck [17:11:54] * aude makes a task for it, in case someone can look [18:11:59] Amir1: difficult one, marked as human by you... https://nl.wikipedia.org/wiki/Troje_IV-V [18:16:47] aude: did you move the usage stats page? wanted to show dennyvrandecic :D [18:20:57] Lydia_WMDE: labs was broken yesterday :( [18:21:03] * aude tries to restart it again [18:22:03] thanks [18:22:06] dennyvrandecic: ^ [18:22:36] looking forward to see it :) [18:23:14] Lydia_WMDE: fixed [18:23:20] \o/ [18:23:21] yay, thanks aude [18:23:37] still need to generate pretty graphs for it [18:23:49] dennyvrandecic detected [18:23:56] hi JeroenDeDauw [18:24:16] aude: explanation for the columns? [18:25:11] sitelinks: i guess, how many pages are connected via sitelinks? [18:25:18] labels: how many labels from wd are used [18:25:21] title? [18:25:34] other: how many other statements from wd are use [18:25:40] any vs total: ? [18:26:10] any as i understand it: they load the whole entity and we can't tell what is used [18:27:12] ok, so other is how many entites are being referenced? [18:27:35] don't remember what other was - needs a legend :D [18:27:52] :D [18:28:16] I usually always make these minimalistic sites myself, now I see how much it bites :D [18:28:22] lol [18:32:19] heh [18:32:52] https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/docs/usagetracking.wiki [18:33:13] so, think T = sitelink [18:34:10] (sitelink's page title) [18:51:29] addshore: aaaah https://github.com/wmde/WikibaseDataModel/pull/551 [19:03:06] sjoerddebruin: hey :) [19:03:48] I check that [19:03:48] I don [19:03:48] *I don't know what's this [19:04:09] but maybe categorization is wrong [20:46:56] WARNING: Http response status 503 [20:46:56] WARNING: Non-JSON response received from server wikidata:wikidata; the server may be down. [20:46:56] WARNING: Waiting 5 seconds before retrying. [21:20:52] we are having an increasing lag on the wikidata site, is anyone aware? [22:59:39] benestar|cloud: rebaseeeeeeeeeeeee https://gerrit.wikimedia.org/r/#/c/235063/ [23:00:25] dennyvrandecic: yeah, there is some panicing going on ;p [23:05:35] JeroenDeDauw: kk