[10:39:27] https://www.mediawiki.org/wiki/Extension:Article_Placeholder \o/ [10:40:43] :O [14:28:16] Do we still not have Meta-Wiki sitelinks? [16:44:01] !merge 228755 [16:44:01] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/228755/ [16:44:11] I love that bot [17:02:26] hoo: merged, I looked at that this morning but pparently didnt click the button [17:02:44] :) [17:03:07] hoo: https://gerrit.wikimedia.org/r/#/c/227436/ might be ready now ;) [17:06:41] Looking :) [17:07:41] if it is then I am super happy! ;) [17:12:16] also hoo, https://gerrit.wikimedia.org/r/#/c/228841/, cherry picked from the branch (and poked slightly) [17:12:42] Oh that, yes [17:12:52] Going for food, will do CR after that [17:13:12] ;) [17:14:42] * aude populating usage tracking for enwiki :) [17:14:55] but it's sloooooooooow [17:15:26] :D [17:15:46] cheers for the fix for that aude ! stupid mw doing things late and in an odd order.... [17:16:05] by that I mean the think you just +2ed ;) [17:16:06] * aude hopes we can get rid of raw mode in wikibases [17:16:09] wikibase* [17:18:23] we will [17:18:53] but it needs a breaking api change, and possibly a change to core :/ https://gerrit.wikimedia.org/r/#/c/227686/ [17:19:57] :/ [17:37:57] addshore: Urgent enough for a backport? [17:38:05] Or are we backporting anyway (what?) [17:38:29] hoo: well, a few fatals an hour, BP would mean we could probably fix it for the next branch! :) [17:39:33] If it's worth the hassle [17:39:35] ok [17:39:45] Anything else? aude Lydia_WMDE ? [17:40:00] addshore: it means that Parser targetLanguage is $wgLang [17:40:15] which can be stubuserlang [17:40:40] hoo: i am not backporting now, but if we need something.... [17:40:43] can it be? its documented as always being Language [17:41:03] addshore: in some other places, we simply unstub [17:41:21] https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/3e1de68805adb8a9d7d66a0bfd33272b0deaf8d6/client/includes/Hooks/ParserOutputUpdateHookHandlers.php#L47 [17:41:26] mhhhm, would be nice to find where core is going wrong though [17:41:27] i don't know why it's a problem now though [17:41:32] yeah [17:41:34] or some extension [17:41:51] addshore: Unstub and log with backtrace [17:42:07] yeh, will do [17:45:32] * aude eats [18:02:32] addshore: my 2 follow ups also need manual rebase >_> [18:02:41] addshore: you doing the rebase now? [18:02:49] Yeh, Ill rebase the things :) [18:02:50] I'm reviewing the thing in my IDE now [18:02:55] k [18:03:12] http://cdn.meme.am/instances/63164403.jpg [18:07:05] aaaaaaaaaaaaaaaaaa [18:14:37] Is there a new dump yet? [18:14:51] aude: Lydia_WMDE: Anything to add for the backport? If not, I'll prepare to backport addshore's patch [18:15:22] hoo: i don't have anything [18:15:54] hoo: we could easily 'fix' https://phabricator.wikimedia.org/T104609 [18:16:18] it's needlessly spamming the logs, but doesn't fix the underlying issue [18:16:38] aude: mh [18:16:51] We would need a backtrace there, I guess [18:18:40] aude: ^ Will you create the patch for that? [18:18:45] I can as well [18:18:49] just need to know [18:19:18] that thidoing [18:19:20] doing* [18:19:42] i assume the underlying issue is that new items and properties have no i [18:19:43] d [18:20:10] (at that point) [18:20:12] But they should have by the time we create a parseroutput for them [18:20:16] shouldn't they? [18:20:32] i don't think [18:20:38] I checked entity creation locally (via the special page and via the api) and both didn't hit that bug [18:20:38] they get an id when saved [18:21:14] We AFAIR only call that method post save, so that's probably not the issue [18:23:51] aude: We also already have a title by the time that function is called [18:24:02] looking [18:24:12] The only caller is in EntityContent [18:24:13] hoo: all rebased! :) [18:24:19] and that caller gets a Title [18:25:51] hoo: do you have spam blacklist installed? :) [18:26:21] that makes a difference :o [18:26:36] No, have it disabled in my LocalSettings [18:26:43] PRobably because it broke tests [18:26:47] yeah, it does [18:29:00] addshore: where is that part that you wanted to have reviewed extra well now? [18:30:26] well, its the language fallback stuff in the output [18:30:30] *looks* [18:30:50] addshore: EntityAccessor is now kinda mostly being a factory [18:30:56] https://gerrit.wikimedia.org/r/#/c/228874/ [18:30:58] hoo: ^ [18:31:46] JeroenDeDauw: basically the third param that is passed to ClientEntitySerializer on construction [18:31:59] aude: ok... that sounds evil [18:32:02] infact, the second 2 params.... [18:32:04] Is there a bug about that [18:32:08] gotta dash now! [18:32:10] also what the hell is it using as title? [18:32:47] hoo: i'm sure there is a bug [18:32:51] we've had this issue before [18:33:06] Yeah, I can remember something along these lines before [18:33:35] probably Special:NewItem [18:33:40] iirc [18:34:38] e.g. https://phabricator.wikimedia.org/T75133 [18:35:00] that's in tests though [18:37:29] * aude has filed that bug 3 times apparently [18:38:52] !review | [18:38:52] https://bit.ly/wdrieview [18:38:57] >_> [18:38:59] https://gerrit.wikimedia.org/r/#/c/228870/ [18:43:41] * hoo rages [18:43:48] gerrit :S [18:44:03] oh, addshore reused change ids :D [18:44:18] ? :O [18:44:24] ??? [18:44:56] addshore: Your patch for backport had the same change id the earlier patch against the branch had [18:44:56] I reused change ids? :P [18:45:11] hoo: yus :O, it was the same 'change' [18:45:33] hoo: are you advocating us to be wastefull with change ids and use a new one FOR EVERY COMMIT?! [18:45:47] YAY, now all the dependencies for removing the libserializer have +2s xD [18:45:49] WOOOOO!!! [18:46:03] addshore: I'm going to submit some follow ups soon [18:46:05] JeroenDeDauw: Peak change id is coming soon! [18:46:35] hoo: consequences will never be the same! [18:47:04] some real evil magic going on here I think https://github.com/silverstripe/silverstripe-framework/blob/3.2/core/Object.php#L38 [18:47:10] IDE says not used [18:47:16] * JeroenDeDauw smells reflection abuse [18:50:52] YAYAYAYA merged!!! [18:52:13] addshore: you gonna fix https://gerrit.wikimedia.org/r/#/c/227688/ ? [18:56:22] JeroenDeDauw: I couldnt see what was wrong at a first glance, doesnt fail locally for me >.> [18:56:28] and jenkins is super helpfull with 0 output.... [18:56:52] also passed for bene and he couldnt see the issue :/ [18:57:03] another pair of eyes would be great! ;) [18:57:39] I can look at it [18:57:55] only yesterday I fixed my test vm [19:04:08] git pull [19:04:33] 75 files changed, 502 insertions(+), 6370 deletions(-) [19:04:45] hoo: that'd be great [19:04:53] I don't have my WB tests running locally ATM [19:16:17] That thing needs a rebase btw [19:16:17] addshore: hoo: I''l rebase it now [19:18:39] rebased [19:23:39] Found 2 issues, amended now [19:26:26] Fixed it! [19:26:29] addshore: hoo [19:27:14] https://gerrit.wikimedia.org/r/#/c/227688/17..18/client/includes/store/AddUsagesForPageJob.php [19:27:17] And the next file [19:35:49] Well, if someonething breaks now, we'll know it was one of those several thousands of lines that got changed :) [19:57:15] addshore: ping [20:19:24] addshore: https://github.com/wmde/WikibaseDataModel/pull/529 [20:26:55] sigh [20:27:09] now Wikibase Qulity is no longer installable, since of course it still depends on master... [20:41:41] JeroenDeDauw: If you need to adopt wikibase quality stuff, you need to do that for master and the v1 branches [20:41:43] just FYI [20:42:07] for both [20:42:09] ???! [20:42:21] yeah :/ [20:42:28] v1 is deployed [20:42:35] but we plan to switch to master at some point [20:42:39] needs some work though [20:42:48] >_> [20:43:24] And was that rule always followed, or is v1 more capable feature wise than master? [20:44:01] master is more capable [20:44:05] good [20:44:21] But the occasionally didn't fix things on master that are fixed on v1 [20:44:22] Do you know if the students are still doing anything? [20:44:25] so it's a bit of a mess [20:44:31] >_> [20:44:38] They wanted to, but I didn't see anything recently [20:45:16] Might have helped to not force them to use gerrit [20:45:40] No, I don't think so [20:45:45] the security review was the problem [20:45:54] so they decided to cut a branch with a smaller feature set [20:45:58] and... :( [20:46:26] That was a comment on them not doing anything, not on the branch mess [20:47:17] mh [20:47:28] I think they got along quite well with gerrit, I was surprise even [20:47:32] * surprised [20:47:39] k [20:48:21] Are there any real plans to fix the branch mess, or to fix the lack of versioning? [20:48:45] Nothing beyond we have tickets for that [20:51:29] Typical... this stuff should not have been deployed in such a state [20:52:13] One of the extensions is not deployed at all [20:52:39] it needs a bit of time, but I don't think there are problems which can't be solved within a few days [20:52:49] hoo: well, I made this one installable again, though it looks like the CI is kinda broken https://gerrit.wikimedia.org/r/#/c/228970/ [20:53:39] grrr... ci :/ [20:54:00] Has Wikibase master been changed to 4.0 yet? [20:55:21] yeah it has [20:59:47] 20:58:55 - The requested package wikibase/data-model ~4.0 could not be found. [20:59:49] wtf [21:00:12] forced merge the npm thing now [21:50:26] hoo: https://github.com/wmde/WikidataBuildResources/pull/33 [21:50:52] jzerebecki: Have the commits been pushed? [21:50:59] hoo: yes [21:56:16] jzerebecki: are the github repos readonly? [21:56:31] benestar: nope [21:56:48] should be or at least they should get a notice in the description [21:58:26] benestar: it has the standard description which says it is only a mirror. how can you make a public repo read only? [21:58:33] benestar: https://github.com/wikimedia/mediawiki-extensions-WikimediaBadges [23:58:42] revieeeeeeeeeeeew https://github.com/wmde/WikibaseDataModel/pull/531