[01:41:33] <nikki>	 hmph... it seems I can't middle click coordinate links in some wikipedias any more, it just treats it like a left click, but it still works in other wikipedias
[01:42:54] <nikki>	 does anyone know what changed there? or whether that's been reported somewhere already?
[01:59:01] <Reguyla>	 No sorry I hadn't heard anything about that
[01:59:53] <Reguyla>	 Krenair, is this anything you have heard about?
[02:00:08] <Krenair>	 no
[02:04:22] <nikki>	 also weird, it seems it works in firefox but not chromium
[09:09:26] <Jonas_WMDE>	 aude: it is the focus patch - the focus is set to page and then the tab brings the focus to collapse
[10:52:10] <jem>	 Lydia_WMDE: around?
[10:53:18] <frimelle>	 Hey, I got a bit confused about the wikidata mailinglists, since it seems like both are used (?) - so wikidata-l as well as wikidata@lists.wikimedia
[10:53:40] <nikki>	 isn't wikidata-l just a redirect to wikidata now/
[10:53:41] <nikki>	 ?
[10:54:11] <frimelle>	 Yep, right, okay, thanks. That makes sense.
[10:54:32] <nikki>	 yeah, https://lists.wikimedia.org/pipermail/wikidata/2015-May/006128.html
[10:54:45] <frimelle>	 But it isn't the other way, right? So if you're on wikidata-l you won't see the mails coming from wikidata?
[10:55:06] * nikki doesn't know enough to answer that
[10:55:53] <frimelle>	 Okay, I was just wondering, nothing important ;) anyway, thank you!
[11:29:28] <frimelle>	 I know, this might sound like another ridiculous question, but did my Mail make it through to you on the wikidata list? :)
[11:31:28] <jem>	 frimelle: I guess it's about "Merging items creates redirect now", so yes
[11:33:00] <frimelle>	 \o/ Thanks!
[11:33:10] <jem>	 Np :)
[12:42:50] <addshore>	 *waves a pull request around https://github.com/wmde/WikibaseInternalSerialization/pull/82 *
[13:06:57] <aude>	 moin!
[13:09:12] <benestar>	 addshore: DM 4.0 isn't released yet?
[13:09:51] <benestar>	 how can you still use DM 4.0 in that pull request and travis succeeds?
[13:10:10] <addshore>	 it has been released benestar =o
[13:10:22] <addshore>	 morning aude !
[13:11:19] <addshore>	 benestar: what was our alternative for getBestStatementPerProperty ? O_o
[13:11:49] <benestar>	 but the release looks very strange here: https://github.com/wmde/WikibaseDataModel/releases
[13:12:15] <addshore>	 fixed it, thats just because it was tagged but hadnt been given a title on github
[13:12:44] <benestar>	 ah, now I also got the mail
[13:13:04] <benestar>	 addshore: you should've merged https://github.com/wmde/WikibaseDataModel/pull/518 though before -.-
[13:13:21] <addshore>	 we can just merge it after and do another release ;)
[13:13:47] <benestar>	 yes, lets do 42.0.0 right away
[13:14:08] <addshore>	 ;)
[13:15:12] <benestar>	 do we have a task for displaying statements grouped by rank on phabricator?
[13:15:51] <addshore>	 not that I know of bre
[13:15:52] <addshore>	 benestar: 
[13:19:05] <benestar>	 addshore: found it: https://phabricator.wikimedia.org/T87327
[13:19:36] <addshore>	 awesome, thats the only thing blocking using dm4
[13:20:26] <benestar>	 addshore: what is the only thing?
[13:21:00] <addshore>	 well, a replacement for getBestStatementPerProperty right?
[13:21:14] <benestar>	 addshore: that method isn't used anywhere
[13:21:31] <addshore>	 used in TruthyStatementRdfBuilder
[13:21:44] <addshore>	 and FullStatementRdfBuilder
[13:22:50] <benestar>	 o.O PHPStorm doesn't find those usages ...
[13:23:10] <benestar>	 oh, it's in StatementList :
[13:23:12] <benestar>	 :P
[13:23:32] * benestar will fix that
[13:26:09] <addshore>	 =]
[13:30:41] <addshore>	 just waiting for packagist to realise 1.5.0 of internal serialization exists >.>
[13:30:50] <addshore>	 then I think I have a patch for Wikibase to use DM4 ready
[13:45:34] <addshore>	 yeh aude, someone just needs to move the code over :P
[13:45:47] <addshore>	 I tried a force push but obviously cant ;)
[13:46:05] <aude>	 apparently jan has permission
[13:46:10] <aude>	 can poke later
[14:11:29] <addshore>	 benestar: yay, random failing test in client somewhere for this dm4 patch
[14:11:38] <addshore>	 https://integration.wikimedia.org/ci/job/mwext-Wikibase-client-tests-mysql-hhvm/3063/consoleFull
[14:12:00] <benestar>	 o.O
[14:12:32] <benestar>	 addshore: cannot look at the patch as it seems to be a draft
[14:12:49] <addshore>	 benestar: try again ;)
[14:14:27] <addshore>	 everything seems to be passing locally just fine ;)
[14:23:05] <benestar>	 addshore: trying on my machine now
[14:29:46] <addshore>	 benestar: reordered them for you ;) still fails :(
[14:32:02] <benestar>	 addshore: thanks :)
[14:32:15] <benestar>	 I'm investigating but composer is on strike -.-
[14:33:25] <benestar>	 Fatal error: Call to undefined method Mock_IDatabase_820b3b15::startAtomic() in C:\xampp\htdocs\mediawiki\w\extensions\Wikibase\client\includes\store\sql\ConsistentReadConnectionMan
[14:33:25] <benestar>	 ager.php on line 118
[14:33:28] <benestar>	 addshore: --^
[14:33:41] <addshore>	 >.>
[14:34:06] <addshore>	 something got merged in core ? O_o? or whut
[14:34:12] <benestar>	 not sure how that could work on your local machine :P
[14:34:27] <addshore>	 I didnt pull core
[14:34:31] <benestar>	 me neither
[14:35:33] <addshore>	 wait, and core hasnt changed...
[14:35:35] <benestar>	 maybe it's unrelated and tests are broken on my machine at all
[14:35:43] <addshore>	 well, pull core and run it again
[14:35:54] <addshore>	 thats something I fixed about 27 days ago
[14:35:56] * benestar checks on Wikibase master
[14:36:23] <benestar>	 also occurs on master
[14:36:32] <addshore>	 pull core! ;)
[14:36:35] <benestar>	 will do
[14:36:40] <benestar>	 but that takes ages :P
[14:38:15] <addshore>	 relevant change in Wikibase was https://github.com/wikimedia/mediawiki-extensions-Wikibase/commit/93a4cc197d940f7a9e0c68835afe6924b2fc20c0#diff-6cbea56c7e3d1746e742111290cdf71c and https://github.com/wikimedia/mediawiki/commit/6e283d394f31ce24470006f09271db2f21a7f0e7 in core
[14:42:10] <benestar>	 yes, I remember
[14:43:05] <benestar>	 now I get strange errors but they are shown by PHPUnit ...
[14:43:22] <benestar>	 so not like the random exit of the program on jenkins
[14:43:44] <JeroenDeDauw>	 My IRC is totally full of addshore's and benestars
[14:43:49] <JeroenDeDauw>	 djeeez
[14:43:52] <addshore>	 :D
[14:43:59] <addshore>	 benestar: what fails do you get? =o
[14:44:02] <addshore>	  / errors
[14:44:11] * nikki dilutes JeroenDeDauw's irc a bit
[14:44:33] <benestar>	 Wikibase\Client\Tests\Hooks\BeforePageDisplayHandlerTest::testHandleTitleNotExist_NoWikibaseLinks with data set #0 (array(), array(), true, array(), NULL, true) MWException: ResourceLoader duplicate registration error. Another module has already been registered as jquery.i18n
[14:44:40] <benestar>	 perhaps some wrong config
[14:45:11] <addshore>	 nah, think you need to pull ULS too
[14:45:17] <addshore>	 or disable it ;)
[14:45:19] <benestar>	 and 1) Wikibase\Lib\Test\PidLockTest::testPidLock with data set #0 ('mediawiki')strpos(): Empty needle
[14:45:27] <addshore>	 yeh benestar I get those!
[15:08:15] <addshore>	 aude: fixed that PS at the begining of the chain! :)
[15:08:44] <aude>	 addshore: yay
[15:09:00] <aude>	 will look again when i'm done w/ usage tracking or have a minute
[15:09:53] <addshore>	 epic, that was a good spot! :P its stupid, the xml output currently returns empty elements, and the other formats dont :D cant wait to kill it all at the end of the chain!
[15:10:27] <aude>	 aaah
[15:10:40] <aude>	 insanity!
[15:23:59] <benestar>	 addshore: https://github.com/wmde/WikibaseDataModel/pull/518 can be merged now ;)
[15:24:42] <addshore>	 *waits for tests*
[15:24:45] <benestar>	 sure
[15:25:02] <benestar>	 addshore: how should DerivedPropertyValueSnaks be serialized?
[15:25:16] <benestar>	 the slots just added to the object or as an extra "slots" key?
[15:28:14] <addshore>	 benestar: not sure ;)
[15:28:51] <addshore>	 I think the slots just added to the object, perhaps
[15:29:07] <addshore>	 Still, I dont know how these things easily will fit into the serialization component
[15:29:25] <addshore>	 we have the same issue with the TypedSnak thing
[15:30:10] <benestar>	 yes, I'll just add an instanceof check for now
[15:30:22] <addshore>	 to where?
[15:30:35] <benestar>	 we should however improve this, and use a DispatchableSerializer
[15:30:39] <benestar>	 SnakSerializer
[15:31:03] <addshore>	 mhhhm
[15:31:29] <addshore>	 but again thats basically useless as we never serialize individual snaks, only when part of a statement etc
[15:31:46] <addshore>	 and we have no way to add typed or slotty snaks (which dont extend snak) into statements etc.
[15:34:08] <benestar>	 addshore: true
[15:38:21] <addshore>	 and thats why we aren't using typed snaks yet :P
[15:42:54] <benestar>	 addshore: what do you think? https://github.com/wmde/WikibaseDataModelSerialization/pull/162
[15:43:18] <addshore>	 already added my 1 though comment ;)
[15:43:47] <benestar>	 just saw it :)
[15:43:58] <addshore>	 as the derived thing extends snak in theroy we can do something like ->addDerivedValuesToEntitySnaks( $entity )
[15:44:31] <addshore>	 not sure how tidy that would be in practise
[15:44:54] <benestar>	 addshore: you mean before passing it to the serialization? 
[15:45:00] <benestar>	 I think that's the idea :P
[15:45:13] <addshore>	 yes
[15:45:15] <benestar>	 another option would be to use an interface SnakTypeAssigner
[15:45:20] <benestar>	 or DerivedValuesAssigner
[15:45:45] <addshore>	 we should also do the same thing for filtering language codes, sitelinks etc
[15:46:00] <addshore>	 potentially even props of an entity :/
[16:10:16] <Hussain>	 Hello everyone 
[16:10:43] <Guest34928>	 I had a question on WDQ can anyone help me please ?
[16:11:30] <Guest34928>	 is there any wikidata expert here ?
[16:12:58] <nikki>	 just ask, if someone can help, they will
[16:17:40] <Guest34928>	 HELOOOOOOOO
[16:19:20] <Guest34928>	 OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO
[16:19:28] <Guest34928>	 OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO
[16:19:33] <Guest34928>	 OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO
[16:19:36] <Guest34928>	 OOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO
[16:19:59] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP 
[16:19:59] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:00] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:01] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:05] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:06] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:07] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:22] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:22] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:23] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:23] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:24] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:24] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:25] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:25] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:26] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:20:26] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:24:34] <addshore>	 Guest34928: just ask your question!
[16:25:03] <Guest34928>	 I need help on WDQ (Wikidata Query) 
[16:25:19] <Guest34928>	 I know how to query items but I don't know how to retrieve values .
[16:25:29] <Guest34928>	 like names of items , etc 
[16:28:24] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:28:24] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:28:25] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:28:28] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:28:29] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:28:30] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:28:38] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:28:39] <Guest34928>	 HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP HELP
[16:32:29] <benestar>	 addshore: added some patches on DataModel to get rid of Entity
[16:32:39] <benestar>	 just hit merge :P
[16:33:38] <Seeker>	 Hi
[16:34:25] <Guest74556>	 How can I retrieve values from wikidata ?
[16:36:30] <addshore>	 heh JohnFLewis I tried that then realised I dont have ops in this channel ;)
[16:36:51] <addshore>	 Guest74556: which values? either the API, Dumps or Queries
[16:37:07] <JohnFLewis>	 addshore: <s>un</s>lucky you ;)
[16:37:25] <Guest74556>	 https://wdq.wmflabs.org/api?q=claim[31:(TREE[12280][][279])]%20AND%20claim[177:1653]
[16:39:47] <addshore>	 Guest74556: then to get values youd need to do an api call
[16:39:59] <addshore>	 eg https://www.wikidata.org/w/api.php?action=wbgetentities&ids=Q64|Q77
[16:45:36] <addshore>	 Or there is SPARQL too :)
[18:20:05] <Tpt>	 There are on Wikidata quite a lot of date with precision <= 9 (year) that are in the format 01-01T00-00-00Z. Is it something wanted or is it a bug that should be solved?
[18:21:06] <Tpt>	 Sorry, "01-01T00:00:00Z"
[18:44:30] <jzerebecki>	 Tpt: if it contains no year that is invalid
[18:47:35] <Tpt>	 sorry, I wanted to say that the timestamp is like 1967-01-01T00:00:00Z
[18:47:49] <Tpt>	 and not 1967-00-00T00:00:00Z
[18:48:07] <Tpt>	 as dates created using the UI
[18:57:22] <jzerebecki>	 Tpt: 1967-00-00 is invalid, but we accept it and probably correct it in the formatter
[18:58:01] <Tpt>	 jzerebecki: are you sure, this kind of datas are created by the current Wikidata UI since the beggining.
[19:00:06] <Tpt>	 In the data model spec "the month, day and time will be set to zero if they are unknown"
[19:00:44] <Tpt>	 https://www.mediawiki.org/wiki/Wikibase/DataModel#Dates_and_times
[19:05:56] <jzerebecki>	 Tpt: no idea who added that, but it is still invalid. and yes month 00 and day 00 are widespread on wikidata. the date and time datatype is a mess. that setence in the data model doesn't give some special meaning. precision still determines if there is meaning to e.g. the month.
[19:07:04] <Tpt>	 I think it was there since the beggining. I remind to have seen it in 2013
[19:07:17] <Tpt>	 I'll open a bug about it
[20:32:34] <multichill>	 Who broke the lua modules :-(
[20:32:44] <aude>	 ?
[20:32:48] <aude>	 where?
[20:33:15] <aude>	 oh, i see
[20:33:26] <multichill>	 EVERYWHERE! :P
[20:33:57] <aude>	 legoktm: ^
[20:34:01] <multichill>	 aude: https://www.wikidata.org/wiki/Module:Arguments <- wtf
[20:34:08] <multichill>	 Looks like parsed as wikitext, not LUA
[20:34:13] <aude>	 i think it has the wrong contentn model
[20:34:15] <aude>	 yeah
[20:34:40] <aude>	 legoktm maybe have been poking at it, generally
[20:34:40] <multichill>	 https://www.wikidata.org/w/index.php?title=Module:Arguments&action=info <- auw
[20:35:17] <multichill>	 https://phabricator.wikimedia.org/T107340
[20:35:30] <aude>	 thanks
[20:35:52] <legoktm>	 looking
[20:35:57] <aude>	 thanks legoktm 
[20:36:30] <multichill>	 aude / legoktm https://phabricator.wikimedia.org/T107340 I guess?
[20:36:46] <legoktm>	 do we know when this broke?
[20:37:23] <multichill>	 Last 24 hours?
[20:37:29] <aude>	 legoktm: it affects the main page
[20:37:37] <legoktm>	 hm
[20:37:39] <aude>	 i didn't notice  the issue before but sure someone would have
[20:39:23] <legoktm>	 http://fpaste.org/249567/2358143/raw/
[20:39:37] <legoktm>	 fixed for now
[20:39:40] <legoktm>	 ohhhh
[20:39:41] <legoktm>	 ok
[20:39:47] <legoktm>	 I think this was always broken
[20:40:13] <legoktm>	 and https://gerrit.wikimedia.org/r/#/c/160605/ exposed it
[20:40:18] <legoktm>	 which just went out in today's train 
[20:41:23] <aude>	 thanks legoktm 
[20:41:27] <multichill>	 Thanks, only https://www.wikidata.org/wiki/Module:RFBOT/testcases seems to be left broken
[20:41:45] <multichill>	 https://www.wikidata.org/w/index.php?title=Module:RFBOT/testcases&action=edit <- nice fatals
[20:41:49] <multichill>	 Fatality!
[20:42:11] <aude>	 :/
[20:42:12] <legoktm>	 o.O
[20:42:17] * aude looks
[20:42:39] <legoktm>	 probably revision/title content model mis-match
[20:43:22] <legoktm>	 yeah
[20:43:33] <legoktm>	 title is wikitext when it should be module
[20:43:40] <aude>	 Format text/x-wiki is not supported for content model Scribunto
[20:44:27] <legoktm>	 fixed
[20:44:43] <multichill>	 legoktm: FAIL @ https://www.wikidata.org/wiki/Module:Open_RfAs/doc
[20:44:54] <multichill>	 Lot's of them at https://www.wikidata.org/w/index.php?title=Category:Scribunto_modules_with_errors
[20:44:55] <legoktm>	 hmm
[20:45:01] <legoktm>	 I think my script was too agressive.
[20:45:23] <legoktm>	 are /doc pages supposed to have a content model of Scribunto?
[20:45:27] <legoktm>	 or are they supposed to be wikitext?
[20:46:00] <multichill>	 Wikitext
[20:46:20] <multichill>	 I think all the Module:<bla>/<something> are wikitext
[20:46:30] <multichill>	 But I'm not sure
[20:46:45] <multichill>	 Just loop over https://www.wikidata.org/w/index.php?title=Category:Scribunto_modules_with_errors and change all pages with / in it to wikitext again
[20:47:43] <multichill>	 We seem to have 135 modules with a / in the name legoktm
[20:48:26] <legoktm>	 yeah, it's a little more complicated
[20:48:31] <legoktm>	 we have to update the revision rows too.
[20:48:33] <legoktm>	 gah
[20:48:51] <multichill>	 Good luck
[20:49:31] <legoktm>	 so /doc is wikitext
[20:49:49] <multichill>	 legoktm: MariaDB [wikidatawiki_p]> SELECT page_title FROm page WHERE page_namespace=828 AND page_title LIKE '%/%' limit 150;
[20:50:19] <multichill>	 Some of these are wikitext and some submodules. pffff
[20:50:19] <legoktm>	 it's only /doc
[20:50:24] <legoktm>	 sigh.
[20:50:35] <multichill>	 I see stuff like /testcases
[20:50:43] <legoktm>	 hmm.
[20:51:28] <multichill>	 Other stuff like https://www.wikidata.org/wiki/Module:Wikidata/Globes should be scribunto
[20:52:40] <multichill>	 legoktm: Force an update on all the / pages. Than loop over the category with scribunto errors, that's probably all wikitext by than
[21:00:26] <legoktm>	 multichill: does https://people.wikimedia.org/~legoktm/wd_modules.txt look right?
[21:03:39] <jackmcbarn>	 <legoktm> I think this was always broken <legoktm> and https://gerrit.wikimedia.org/r/#/c/160605/ exposed it <-- correct
[21:04:07] <multichill>	 legoktm: I think so
[21:04:57] <multichill>	 JohnFLewis: Andy is being very aggresive again at https://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard#Disruption_at_Template:Authority_control_properties , maybe you can talk some sense into him?
[21:06:25] <JohnFLewis>	 multichill: I'm stepping back really. I've told Kolja to avoid calling him a spammer as its a two-way street as Kolja imho is purposeful aggravating him now.
[21:07:58] <multichill>	 I can't look into someones head
[21:09:19] <jackmcbarn>	 oh crap, i did https://www.wikidata.org/w/index.php?title=Module_talk:RFBOT/testcases&action=history and now i can't edit it
[21:12:36] <multichill>	 jackmcbarn: Dude! Why did you move it to the wrong namespace?
[21:12:53] <multichill>	 Now legoktm has to fix it again ;-)
[21:13:01] <multichill>	 legoktm: Another nice fatal at https://www.wikidata.org/w/index.php?title=Module_talk:RFBOT/testcases&action=edit
[21:14:09] <jackmcbarn>	 multichill: i didn't
[21:14:18] <jackmcbarn>	 i moved it to the *right* namespace
[21:14:21] <jackmcbarn>	 it's the content model that's wrong
[21:14:50] <multichill>	 jackmcbarn: You moved it to the talk namespace, that's not the right one
[21:14:55] <jackmcbarn>	 yes it is
[21:15:09] <jackmcbarn>	 module:*/testcases is for Lua testing code, and the wikitext that runs the tests goes at module talk
[21:15:09] <multichill>	 It's the talk namespace, not the testcases namespace 
[21:15:46] <jackmcbarn>	 wikitext test cases belong in talk
[21:15:58] <multichill>	 jackmcbarn: No, see for example https://en.wikipedia.org/wiki/Template:NRHP_row/testcases
[21:16:08] <jackmcbarn>	 for templates that's not true, but for modules it is
[21:16:17] <jackmcbarn>	 look how enwiki does all its module test cases
[21:16:22] <multichill>	 Or https://en.wikipedia.org/wiki/Module:Authority_control/sandbox/testcases
[21:16:31] <jackmcbarn>	 exactly
[21:16:32] <multichill>	 https://en.wikipedia.org/wiki/Wikipedia:Lua#Unit_testing
[21:16:41] <multichill>	 By convention, unit tests for a module like Module:Bananas are placed in Module:Bananas/testcases
[21:16:41] <jackmcbarn>	 the enwiki module you linked proves my point
[21:16:46] <jackmcbarn>	 yes, the Lua test cases are
[21:16:50] <jackmcbarn>	 the wikitext to run the test cases goes in Module_talk
[21:16:59] <multichill>	 No, it's in the moduel namespace
[21:17:13] <jackmcbarn>	 look at https://en.wikipedia.org/wiki/Module:Arguments/testcases and https://en.wikipedia.org/wiki/Module_talk:Arguments/testcases
[21:17:18] <multichill>	 Oh, you have two?]
[21:17:25] <jackmcbarn>	 they're two parts of the same thing
[21:17:30] <jackmcbarn>	 lua part in Module and wikitext part in Module_talk
[21:17:44] <jackmcbarn>	 the page i moved was the wikitext part, so it belongs in Module_talk
[21:18:00] <multichill>	 That's confusing!
[21:18:06] <jackmcbarn>	 that's how modules have always been
[21:18:24] <multichill>	 Brrrr, talk page abuse
[21:21:45] <multichill>	 jackmcbarn: Thanks for the explanation, I should really dive into the wonderful world of LUA some day.....
[21:21:50] <jackmcbarn>	 np
[21:22:13] <legoktm>	 ok so,
[21:22:26] <legoktm>	 https://people.wikimedia.org/~legoktm/wd_modules_log.txt is all done now
[21:22:30] <legoktm>	 are things still broken?
[21:22:45] <legoktm>	 just the testcases page?
[21:23:02] <legoktm>	 jackmcbarn: do I need to fix /testcases?
[21:23:08] <jackmcbarn>	 yes, it should be changed to wikitext
[21:23:51] <multichill>	 legoktm: Probably should make a new bug for the moving of  module pages with content model scribunto to other namespaces that it gives a fatal
[21:23:54] <multichill>	 I'm going to bed
[21:23:56] <multichill>	 later
[21:24:19] <legoktm>	 multichill: I fixed that, it hasn't been deployed yet :)
[21:24:36] <multichill>	 Good job!
[21:27:05] <Nemo_bis>	 Reading https://docs.google.com/document/d/1pxp3JS72odvUc2PYn3-0gwXY-8WrmJhzbcKm9wnNueM/edit?pli=1
[21:27:09] <Nemo_bis>	 Wrong window
[22:18:03] <jackmcbarn>	 legoktm: can you fix that one page?
[22:19:15] <legoktm>	 gah yeah sorry, got distracted
[22:26:53] <legoktm>	 jackmcbarn: fixed
[22:27:17] <jackmcbarn>	 looks good
[22:28:37] <legoktm>	 ok so, now time to run it on all other projects
[22:29:25] <jackmcbarn>	 legoktm: we should probably add a sanity test to make sure it looks like lua
[22:29:35] <jackmcbarn>	 to avoid what happened to that stupid testcases page happening on a mass scale elsewhere
[22:30:08] <legoktm>	 jackmcbarn: if you can come up with a php snippet, I can stick it in my script :)
[22:30:28] <jackmcbarn>	 legoktm: can you post the script as it is now btw?
[22:32:02] <legoktm>	 jackmcbarn: http://fpaste.org/249604/14382091/raw/
[22:32:19] <legoktm>	 it was originally written for one off changes, then I added in fixing the entire module namespace :|
[22:41:17] <jackmcbarn>	 i think i've got it; testing it now...
[22:42:15] <legoktm>	 jackmcbarn: we could just check that it's valid lua syntax?
[22:42:21] <jackmcbarn>	 that's what i'm doing; pretty much
[22:42:23] <legoktm>	 I just remembered we have that checking now.
[22:42:25] <legoktm>	 okay :D
[22:44:12] <jackmcbarn>	 legoktm: http://fpaste.org/249606/20984214/ are the 2 changed functions
[22:44:48] <jackmcbarn>	 (note that those are hardcoded to work for modules; you shouldn't keep those in this for other use)
[22:45:16] <legoktm>	 yeah, I'll just make this changeContentModel3.php ;)
[22:48:11] <legoktm>	 running in dry-run mode right now
[22:49:02] <jackmcbarn>	 i don't see provisions for a dry-run mode in that script
[22:49:14] <legoktm>	 jackmcbarn: I comment out the $page->doEditContent() part :P
[22:51:00] <jackmcbarn>	 can you paste the logs of it, if there are any "Not valid Scribunto" messages?
[22:55:42] <legoktm>	 sure, I just have to spot-check that there are no private wikis in that output >.>
[22:56:02] <legoktm>	 it's at kkwiki right now
[22:56:35] <jackmcbarn>	 private wikis have secret information in the names of their modules?
[22:56:38] <jackmcbarn>	 :P
[22:57:21] <legoktm>	 who knows
[23:13:02] <legoktm>	 jackmcbarn: no invalid modules
[23:13:10] <jackmcbarn>	 in ANY of the wikis?
[23:13:15] <legoktm>	 yeah
[23:13:16] <legoktm>	 :D
[23:13:28] * jackmcbarn finds that a bit hard to believe, but ok...
[23:13:41] <hoo>	 A group can have two music brainz ids leading to the exact same content.. what
[23:13:58] <legoktm>	 hoo: which group?
[23:14:21] <hoo>	 A got it... seems one is the canonical one, the other some sort of redirect
[23:14:28] <hoo>	 https://www.wikidata.org/wiki/Q323803
[23:14:42] <hoo>	 (you need the primary sources tool enabled to see the second id)
[23:14:54] <hoo>	 https://musicbrainz.org/artist/411a1f3c-fe92-46bf-84ff-05f41466d4cd https://musicbrainz.org/artist/5de80871-f721-4c7c-b0c5-4ad0d350c232
[23:15:26] <hoo>	 The 5d… one seems to be the "right" one given the links even from the 411a… one point to that id
[23:17:36] <legoktm>	 might want to ask in #musicbrainz
[23:17:53] <hoo>	 I'm pretty sure by now
[23:18:07] <legoktm>	 ok :)
[23:18:14] <hoo>	 but still, they could make that a little more obvious :P
[23:19:25] <legoktm>	 jackmcbarn: ok, running it now
[23:26:41] <jackmcbarn>	 any wikidata admins around?
[23:27:11] <legoktm>	 hoo is.
[23:27:53] <hoo>	 huh?
[23:27:58] <jackmcbarn>	 hoo: can you delete https://www.wikidata.org/wiki/Module:IDs/doc and then move https://www.wikidata.org/wiki/Module:IDs/doc/doc to Module:IDs/doc ?
[23:29:30] <hoo>	 done
[23:29:54] <jackmcbarn>	 thanks
[23:30:04] <legoktm>	 https://it.wikisource.org/wiki/Modulo:Dati/Bettinelli_-_Opere_edite_e_inedite,_Tomo_7,_1799.djvu o.o
[23:39:11] <legoktm>	 jackmcbarn: aaaand done.
[23:39:40] <legoktm>	 435 modules fixed