[01:50:59] merge please, fixes CI: https://gerrit.wikimedia.org/r/#/c/227390/ [01:52:19] looking [01:53:16] * aude grabs the chocolate [01:53:25] +2ed [01:53:28] :) [01:53:33] aude: Oh noes :D [01:53:41] Chocolate :D [01:53:46] * aude shares [01:56:19] :) [01:57:54] * aude off for the evening now [09:17:17] aude: did the branch get done? ;) [09:20:34] haha, *reads email* now I see you have ;) [10:55:28] hello, any idea of why https://en.wikipedia.org/wiki/Fast_Ethernet does not link with its wikidata item? [10:55:41] it's not showing interwikies [10:57:14] It is for me :O [10:57:18] https://usercontent.irccloud-cdn.com/file/r9Wy1bJ4/ [10:57:19] It does here. [10:57:24] https://www.wikidata.org/wiki/Q546389 [10:58:09] yes, but can you see those interwikies on the English article? at the left side [10:58:15] yes [10:58:19] hmmm [10:58:25] that is a screenshot from the english article ;) [10:58:35] ohh I see [10:58:47] it's strange, I cannot see them [10:58:55] very odd =o [10:59:45] UAwiki: any "interesting" gadgets / user scripts enabled? [11:00:04] (or any errors in the browser's developer console?) [11:00:19] andre__: not really, maybe it's something on my browser, my old Opera 12 hehe [11:00:36] or some user script, but not a wikipedia script [11:01:29] I disabled user scripts but nothing happens, but in Firefox it seems to be OK [11:04:12] well thanks addshore and andre__, at least you can see those interwikies, I just see that odd thing in that article [11:04:25] cheers, bye :) [12:30:48] wahhaha Jonas_WMDE CFisch_WMDE that bug looks, interested [12:31:40] ^^ [12:38:16] https://gerrit.wikimedia.org/r/#/c/227442/ [13:07:26] * aude waves [13:39:36] * addshore waves [14:13:04] aude: soooo close to getting rid of the lib serializers [14:13:31] just got usage in the client EntityAccessor class and in the ParserOutputJsConfigBuilder to get rid of! [14:17:07] :) [14:17:45] EntityAccessor is prooving troublesome though [14:18:21] CFisch_WMDE: is jonas around today (or tomorrow)? [14:18:41] aude: >> Jonas_WMDE (looks like he is here) ;) [14:19:36] doesn't have to be today but https://phabricator.wikimedia.org/T107063 could use attention [14:20:01] soonish [14:21:02] right, looks like I have to use a bit of ResultBuilder in clinet... [14:21:08] hmmmmmmmmm, how to make this not ugly [14:21:34] ugh [14:21:58] it doesn't belong in result builder then [14:22:03] imho [14:22:51] aude: https://gerrit.wikimedia.org/r/#/c/227436/1/repo/includes/api/ResultBuilder.php [14:23:14] its the getEntityArray method I factored out there, just cant really think of where it should go or what it should be called... [14:23:53] EntityArrayilizer? :P [14:23:58] xD [14:24:12] I was thinking of factoring some stuff out into an ArrayBuilder [14:24:17] sounds ok [14:24:31] which is odd, its almost a SerializationBuilder / Extender / Poker [14:26:50] :o [14:27:29] * aude has thousands of items and all the properties of wikidata imported to my wiki :) [14:27:38] ay! [14:27:40] yay! [14:27:47] need to make it add badges and qualifiers, etc. [14:30:33] aude: Jonas is here today and I think also tomorrow ;-) [14:30:46] gell Jonas_WMDE ? [14:33:19] I am here [14:35:02] aude: I could always make EntityAccessor do internal api class to wbgetentities..... [14:35:18] Jonas_WMDE: do you think https://phabricator.wikimedia.org/T107063 is easy to fix? [14:35:25] but I have no idea how much that thing is used :p [14:35:27] or can you or anyone else even reproduce the issue? [14:35:48] addshore: afaik, entity accessor is used in lua [14:35:53] yeh :/ [14:35:56] so needs to be super performant [14:36:01] bah! [14:36:13] I can not reproduce the tab isssue [14:36:18] Jonas_WMDE: interesting [14:36:21] right, im just going to factor this 1 method out then, bah! [14:36:45] bah, but thats a gazillion things, BAH [14:36:50] :/ [14:37:11] Jonas_WMDE: i can locally also (using chrome) [14:37:12] and when you select a site the focus is going to select page [14:37:35] aude: this is basically the alternate :P https://gerrit.wikimedia.org/r/#/c/227266/ but factoring those things into lib instead of repo, even though only 1 is used in client, bah! [14:37:37] so ugly [14:37:41] Jonas_WMDE: i select with tab [14:39:07] i also have trouble picking eswiki [14:39:12] (not a new issue) [14:40:05] it's a DanielK_WMDE ! [14:40:13] itsa DanielK_WMDE ! [14:40:26] :) [14:40:45] aude: could we do a hangout where you share your screen and you explain me the problem [14:41:37] i can make a screen cast [14:42:52] cool [14:46:49] basically, i type "t" + "r" (for turkish, e.g.) + "tab" [14:47:06] and should select trwiki [14:47:31] i type "e" + "s" + "tab" and it picks "eowiki" (first in the list) instead of "eswiki" [14:47:44] it's almost impossible to pick eswiki (but not a new problem) [14:49:35] on http://wikidata.beta.wmflabs.org/wiki/Q73319 ? [14:50:10] on anything [14:50:54] on beta there is no tr and es wiki as far as I can see [14:51:22] on localhost if I type es it selects eo wiki and then focus page selection [14:52:40] same with tr [14:54:01] https://phabricator.wikimedia.org/T107063 [14:54:14] probably is no trwiki [14:54:26] this is locally but same thing happened on beta [14:54:45] oh, not sure phabricator likes my file :/ [14:57:26] https://vimeo.com/134736579 (it's processing) [14:57:53] there is "es" on beta [14:59:13] Jonas_WMDE: also if i type "e" then down arrow and select "eowiki" [14:59:15] then tab [15:03:14] ok I get it [15:03:33] what about pressing enter? [15:04:22] Jonas_WMDE: that works [15:05:49] is that satisfying? [15:07:27] it's ok but is different from how i enter statements [15:10:05] shall I still have a look at the tab order? [15:10:26] the behaviour on beta is really counterintuitive to me, tabbing forward goes to collapse, tabbing back from collapse goes to the page selector [15:12:28] compare with https://test.wikidata.org/wiki/Q22 [15:12:43] Jonas_WMDE: which has old code [15:13:03] i think it's worth to fix (i could take a look later perhaps, if you don't have time) [15:13:21] test is older [15:13:26] I could have a look tomorrow [15:14:06] Jonas_WMDE: exactly... test has the old code [15:14:09] still* [15:14:33] I mode 2 changes to this [15:14:36] made [15:14:52] yep [15:15:03] https://gerrit.wikimedia.org/r/226276 [15:15:06] it's nice with the collapse feature [15:15:07] How to searh for categories with searcher? Always the result is " There were no results matching the query." [15:15:19] generally (except the tab order) [15:15:28] https://gerrit.wikimedia.org/r/224037 [15:15:45] its a core feature [15:16:23] thanks for the links [15:16:57] I can not explain why it messes up the tab order [15:17:08] doesn't look obvious to me [15:18:40] * aude goes to look at usage tracking now [15:19:02] So I will have look tomorrow [15:19:23] ok [15:19:40] hm. beta also behaves weirdly for me if I try to change the language, like if I type "es", press enter, tab backwards, press "e", it selects english and appears to lose the focus [15:20:40] nikki: in site links? [15:20:45] yeah [15:21:02] ok [15:24:18] that's in chromium, the same happens in firefox except I don't have to press enter because typing "es" selects "esperanto" automatically [16:15:26] hi @ all :) [16:24:24] addshore: rdf tests still dont work for me on Windows :'( [16:24:32] =io [16:24:34] =o [16:24:36] windows? [16:24:40] yes [16:25:20] I thought addshore fixed all issues [16:25:29] well, I fixed the 1 issue I ran into :P [16:25:55] maybe there are more places =o [16:25:59] aude: yeah, what are those crazy people talking about?! [16:31:33] sooooo close to the end [16:31:54] addshore: found 'em, fixing [16:34:07] * points franticly at https://gerrit.wikimedia.org/r/#/c/227472/ * [16:34:12] JeroenDeDauw: benestar aude ^^ [16:34:41] * benestar hugs addshore [16:34:53] and the tests pass!! mwahhahahahaaaa [16:35:02] +0, -6035 o.O [16:35:14] haha, so lets just merge everything ^^ [16:35:26] yeh, but that patch is at the end of a 20 patch long chain (not including the ones that have already been merged.....) [16:35:48] I know, still a looong way to go [16:36:15] addshore: I'm going to decline this one https://phabricator.wikimedia.org/T98863 as we found a workaround [16:36:32] addshore: \o/ [16:39:53] addshore: why are you just deleting all our code? you evil person! [16:40:09] addshore: you in Berlin next week? [16:40:12] rm -rf . [16:40:25] that's what addshore is doing all the time :P [16:40:26] rm -rf benestar [16:40:50] JeroenDeDauw: I was trying to get you back for this... [16:40:51] https://github.com/wmde/WikibaseDatabase/pull/48 [16:41:03] I didn't realise lib serialization was so small though :/ [16:41:25] addshore: :D [16:41:34] addshore: "small" [16:41:38] JeroenDeDauw: not next week, the week after I believe! :) (for like 4 weeks I think) [16:42:01] the change out of the chain that needs the most review is probably this one https://gerrit.wikimedia.org/r/#/c/227436/8 [16:42:02] addshore: I removed over 9k lines in that commit, so I still win moar [16:42:15] Or pehraps not, since you included a nyan in your commit msg :| [16:42:30] addshore: is the chain still blocked on deply stuff? [16:42:30] :FD [16:42:35] *deploy [16:42:37] JeroenDeDauw: nope, not any more :) [16:42:55] its all 'ready to go' [16:43:15] * aude hopes we don't have to backport any bug fixes [16:43:24] addshore: in case you are already here in the weekend of the 8th doodle.com/efff2a5zqhb7t2cy [16:43:49] aude: just backport addshore and he'll fix all the bugs in the old code [16:55:27] addshore: the "little" code you removed is still 1.5x the size of the whole of Wikibase DataModel Services at this point [16:55:41] :D [17:00:05] addshore: benestar [17:00:07] https://github.com/wmde/WikibaseDataModel/pull/517 [17:00:09] https://github.com/wmde/WikibaseDataModelServices/pull/12 [17:00:53] JeroenDeDauw: did you check how far we are with moving away from Entity? [17:04:03] benestar: still some way to go [17:04:26] Though I still think this is not really all that relevant for this release if you don't have the time to work on it anyway [17:04:44] I did talk with Jonas about the new FooBarProvider interfaces [17:05:18] He was quite reluctant to thouhg, since he thinks we have more pressing and more clear issues to resolve [17:05:32] Which he has mostly convinced me of [17:05:57] addshore: will has a look at your chain o doom soon [17:06:06] haha [17:11:00] benestar|cloud: do you object to https://github.com/wmde/WikibaseDataModel/pull/517 ? [17:40:14] JeroenDeDauw: I want to know how Entity is still used in Wikibase.git to decide if we should remove the relevant methods and the whole class. [17:41:34] hoo|away: I also had this draft https://gerrit.wikimedia.org/r/#/c/227266/ [17:41:37] benestar: How about keeping the breaking changes in 4.0 limited to the moving of these classes to the new component and putting additional breaking changes into their own release? [17:42:12] JeroenDeDauw: if it doesn't matter to do a 5.0 release 2 weeks after that sure [17:43:23] I sneezed and merged https://github.com/wmde/WikibaseDataModel/pull/517 [17:43:32] and yes we can do a 5.0 release 2 weeks after :) [17:44:18] feels ugly to me but well :S [17:44:27] the datamodel isn't stable yet :P [17:45:52] * JeroenDeDauw refrains from implying that it's benestar that is not stable [17:45:54] :) [17:49:22] JeroenDeDauw: btw I just realized that removing the Entity stuff depends on addshore's commit chain ... [17:50:50] benestar: yeah.... [17:50:58] benestar: you could also cause a merge conflict [17:51:14] oh noes :P [17:51:22] benestar: I recommend against that if addshore knows where you live tho [17:51:58] https://usercontent.irccloud-cdn.com/file/PFWXrNr6/irccloudcapture37617979.jpg [17:51:59] 4 down 17 to go ;) [17:53:22] JeroenDeDauw: remove Entity::copy in 4.0 pls? [17:56:30] benestar: does my final chain remove all the uses? [17:56:43] *change [17:57:00] addshore: yes [17:57:03] afaik [18:00:45] addshore: where is the beginning of this chain? [18:01:09] addshore: whats this evil bord? [18:02:11] JeroenDeDauw: the tail is moving as we merge moar patches [18:02:30] benestar: you merging ATM? [18:02:42] merged one, legoktm merged another [18:03:02] so much to review. [18:05:00] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/225897/ [18:05:05] thats the start [18:05:25] legoktm: over half the stuff was already merged last week ;) this is just the tail end [18:06:51] addshore: https://github.com/wmde/WikibaseDataModelServices/pull/12 [18:16:49] addshore: oh no! https://gerrit.wikimedia.org/r/#/c/227209/ [18:20:13] JeroenDeDauw: getLegacyDeserializer sounds more intuitive than getInternalDeserializer... [18:20:59] benestar: it contains both the current and the legacy deserializers [18:21:08] hoi [18:21:13] hey multichill :) [18:21:53] benestar: if that where not the case, then I concur with legacy, as done here https://github.com/wmde/WikibaseInternalSerialization/tree/master/src [18:22:23] yeah, I see [18:24:03] Lydia_WMDE: Could you discus https://www.wikidata.org/wiki/Wikidata:Project_chat#Freebase_migration:_what_should_we_do_with_unemployment_rate_.28P1198.29_and_population_.28P1082.29 in the team at some point? [18:24:20] Would suck if a lot of items would get too large and we run into scaling problems :-( [18:25:41] multichill: one idea is to only show the preferred and maybe 3 to 5 normal ranked values per default and have an "expand" option available [18:25:59] I think this will come at least with the redesign, we need it earlier perhaps though [18:26:05] yeh JeroenDeDauw benestar I'll just undo those renames, I just overlooked what was being used in there [18:26:15] thanks addshore :) [18:26:16] The scaling problem is probably two parts: 1. Storage of the item. 2. Interface of the item [18:26:35] multichill: storage should never be a problem [18:26:40] Storage shouldn't be a problem, unless each value has a huge reference [18:27:00] hey hoo \o/ [18:27:01] benestar: multichill I was thinking the same... its not storage that is the issue, its how we retrieve stuff [18:27:02] Germany only was a problem because it had excessive (in size) references [18:27:41] Retrieving the page yes. Assume you have a 10MB MediaWiki page. I'm pretty sure you'll run into problems somewhere when you try to open that one [18:28:12] The limit for pages as such is 16MiB AFAIR [18:28:20] Even if you don't, you do not want to download 10MB for a single page, esp when on mobile [18:28:21] But hhvm will ahve trouble before that [18:28:28] store parts of an item as subpages, haha, jk jk... [18:29:00] Anyway. That's why I think it makes sense you talk about it before someone adds this amount of data :P [18:29:05] * JeroenDeDauw stores addshore as addshore/0 addshore/1 addshore/2 addshore/3 ... [18:29:14] mwhaahahaa [18:29:28] Q64/statement/GUID ;) [18:29:31] This is actually an interesting question [18:29:32] addshore gets split o.O [18:29:41] benestar: you need more of me ;) [18:29:47] explode( 'addshore' ) [18:29:53] splitting it up into various contents also does not really work to well [18:30:10] hoo: don't spoil the fun! [18:30:11] * benestar agrees [18:30:19] with me of course [18:30:53] * hoo has some crazy ideas about that... but those are actually crazy :P [18:30:57] But they might work :D [18:30:59] muhahahaha [18:31:09] well, it depends what you load and how you load / need to load it ;) [18:31:16] Sure [18:31:50] For pure loading we will want to use a document database at some point (ElasticSearch...), but primary storage is a different concern [18:32:00] Stuff still needs to work in MW [18:33:07] hoo: why? just make Wikibase independent of MW, use OAuth [18:33:36] yeaaaaaaaaaaaaaaaaaaaaaaaaah [18:34:03] Yay, rewrite time :D [18:34:05] benestar: "just" [18:34:26] hoo: you are a witness to benestar volunteering to do this by next week [18:34:26] * hoo votes to rewrite in an exotic language [18:35:00] hoo: wait... you did not find all of PHP's "loveliness" exotic enough? [18:35:30] Yeah, PHP is good... but why stop there if we can have even more wtfs [18:44:08] addshore: you know, a lot of people would like access in the format of Q64/P123 [18:44:25] or better yet /enwiki/Berlin/Population [18:44:45] err, "en" [18:47:23] addshore: https://github.com/wmde/WikibaseDataModelSerialization/pull/161 [19:05:11] JeroenDeDauw: also Q64/label/en Q78/descriptions Q90/statement/GUID/references Q123/sitelink/enwiki/badges etc. l( [19:05:40] addshore: [19:05:41] yeah [19:05:57] I did write out a draft once for basically 2 api modules.... wget and wbset, that did everything [19:05:59] Which would be a lot earsier without the MW UI and API [19:06:04] yeh [19:06:21] I don't think you can do this nicely with the MW API at all, since its not REST [19:06:52] rm -rf ui :) [19:07:19] wikidata.org/base/get/item/Q64/sitelink/dewiki/badges [19:07:55] there's the restbase thing though that might work for us [19:08:00] wikidata.org/base/get/item/Q64/statement/P64/datavalue [19:08:15] aude: restbase thing? link? [19:08:16] supports wikitext only now (afaik) but don't see why it can't wrk for wikibase [19:08:20] aude: yeh, definitely worth a look at [19:08:25] https://www.mediawiki.org/wiki/RESTBase [19:08:29] https://www.mediawiki.org/wiki/RESTBase [19:08:30] uses cassandra [19:08:58] it's not primary storage of wikitext but used for retrieval (e.g. by visual editor / parsoid) [19:47:14] benestar|cloud: JeroenDeDauw ammended https://gerrit.wikimedia.org/r/227209 [19:53:30] infact im going to poke it again.... [20:02:50] jzerebecki: thanks for approving the date patch. Maybe you want to take a look into other RDF ones too? :) [20:07:28] SMalyshev: will do [20:08:05] jzerebecki: thanks!