[01:13:16] hello there [11:43:46] so quiet [11:46:22] addshore: thanks re bot :) [11:46:36] no worries, just got to wait for people to reply now :) [11:47:01] yeah [11:49:36] *wonders where everyone else is* :P [11:51:37] Jonas_WMDE: if you are curios, the most important thing thatwould be epic to get reviewed for me is https://github.com/wmde/WikibaseDataModelSerialization/pull/152 :D [11:51:59] It's the reason most of my patches on gerrit currently look like they are failing the tests as they require a new version ;) [11:53:58] I could do a pair review with you or jeroen [11:54:36] also Lydia_WMDE FYI we will need to tell the community about https://gerrit.wikimedia.org/r/#/c/225903/ ;) (I have added it to the weekly summary) But I plan on deprecating & removing it as fast as possible ;) [11:55:07] Jonas_WMDE: probably a good idea to do a review with JeroenDeDauw if he is around! (as I wrote it) :) He has also already looked at it [12:00:38] addshore: ok [12:10:42] * sjoerddebruin pokes addshore for no reason [12:10:46] =o [12:17:00] Jonas_WMDE: https://github.com/wmde/WikibaseDataModelSerialization/pull/155 ;) [12:21:51] hey all [12:22:13] is it possible to get wikipedia article title translations from wikidata ? [12:36:11] Hm, too late. [12:59:26] * aude waves :) [13:06:10] aude: ! :D [13:08:29] all the serializations :o [13:09:07] yus [13:09:44] aude: https://github.com/wmde/WikibaseDataModelSerialization/pull/152 ;) [13:10:55] interesting [13:55:19] aude: Doing backports? [13:57:01] if anyone is https://gerrit.wikimedia.org/r/#/c/225903/ might be worthy of a backport (to give people more time) [13:57:24] ;) [14:00:28] addshore: mh [14:00:40] I don't fully get the commit summary, I think [14:00:59] How would implementing something like "SerializationOptions::OPT_GROUP_BY_PROPERTIES" help? [14:01:10] I think that's what we do per default, no? [14:01:37] Yes, so my plan is to remove the "ungroupedlist" option [14:02:08] Yeah... but your commit summary says that implementing something like that constant would help [14:02:12] I just don't get that part [14:02:27] maybe you want to clarify... then I cann +2 [14:02:48] Ahh, so SerializationOptions::OPT_GROUP_BY_PROPERTIES is in WIkibase currently [14:02:54] defaults to true [14:03:27] there is no option at all in the DM serializers, we could implement something similar there, but probably no point as the feature is barely used [14:03:30] https://logstash.wikimedia.org/#/dashboard/temp/AU63scYgs2oZVZyjfrS2 [14:04:07] Btw, we don't need to add the fancy feature usage stuff for such things, I can just grep the api access logs [14:04:15] That's probably less work [14:04:34] ahhh, now I know that I'll ask you next time! ;) [14:05:07] silly addshore, y u make 3 commits? https://github.com/wmde/WikibaseDataModelSerialization/pull/155 [14:05:12] infact, it would be epic to get a grep on it for the past how ever long the logs are :D [14:07:12] hoo: i think so [14:08:39] addshore: hoo i think the ungrouped had something to do with sorting claims in the ui [14:08:42] afaik [14:08:50] since we don't do that currently, it is unused [14:09:35] mh… why would that really be used for sorting in the UI? [14:10:19] or i might be confused [14:12:19] got to go... battery giving up [14:12:41] aude: Will you be there for the deploy? [14:12:44] Or shall I? [14:12:49] hoo: what deploy? [14:12:56] train [14:13:03] do we have a new branch? [14:14:44] nope [14:15:04] we'll branch on Monday, though [14:16:39] aude: ?? [14:16:47] hoo: ok [14:17:00] * aude is probably around but don't think we need to be [14:17:10] for today's deploy [14:17:51] Yeah, it's probably fine [14:18:05] But (rarely) stuff breaks [14:18:13] like the ULS thing right before Wikimania [14:18:22] anyway, cu [14:18:31] I'll probably idle on IRC, just in case [14:18:36] but not sure, yet [14:18:54] ok [14:23:07] addshore: https://gerrit.wikimedia.org/r/#/c/225903/ can go out next week (wednesday) [14:23:15] with mention in deploy notes and weekly summary [14:26:38] aude: will you swat the azb commit? [14:31:01] aude: awesome [14:32:00] jzerebecki: yes [14:46:17] JeroenDeDauw: y u no re review https://github.com/wmde/WikibaseDataModelSerialization/pull/152 [14:47:19] addshore: cause Jonas_WMDE wanted to pair review that and he is now talking to Fish [14:47:28] ahhh :) [14:47:45] addshore: I'll look at it in the evening provbably [14:47:53] Need to leave the office for 2h or so in 15 min [14:48:54] addshore: if you are bored and want to play with a fully DI MW extension, you can haz https://github.com/JeroenDeDauw/SubPageList/issues/3 ;p [14:50:36] That thing actually uses DataValues ;p [14:51:34] okay JeroenDeDauw, the next release of DMseirlization blocks most of my further work on remivng libserializer code :P (at least from resultbuilder) [14:51:50] and haha, that issue looks, fun.. [14:52:27] addshore: you can already work against the dev version of the next rel no? [14:52:46] That is a bit more cumbersome though should avoid you from being totally blocked [14:53:02] hmm, well I guess I would need another branch anlias, as the code I need isnt in dev-master [14:53:14] oh [14:53:28] and yeh, not totally blocked, I can test lcoally but jenkins seems unable to install "myBranchname as 0.7.0" [14:53:30] hold on, then this is not going to work [14:53:47] *1.7.0 ... [14:54:00] see my PS1 of https://gerrit.wikimedia.org/r/#/c/226503/1/composer.json [15:08:01] yeh JeroenDeDauw I couldnt tell if it was the branch alias messing it up or now, as afaik "dev-optionalSnakHashes as 1.7.0" should have worked [15:08:18] but https://integration.wikimedia.org/ci/job/mwext-Wikibase-repo-tests-sqlite-hhvm/2724/console [17:09:56] eww, wikidata uses the horrible {{int:lang}} hack? [17:23:31] ? [18:42:01] addshore: some weird word order in that readme [18:42:08] Added parameter to `newSnakListSerializer` called `$serializeSnaksWithHash` [18:42:32] y u no "Added `$serializeSnaksWithHash` parameter to `newSnakListSerializer`"? [18:57:18] JeroenDeDauw: http://i0.kym-cdn.com/entries/icons/original/000/005/124/hC3AE2E25.jpeg [19:09:14] addshore: merged [19:12:05] JeroenDeDauw: yay ;) [19:14:27] addshore: wanna update the release notes etc for the 1.7 rel? [19:14:42] yes, want me to remove the yoda speak? ;) [19:19:34] w/e [19:19:49] JeroenDeDauw: https://github.com/wmde/WikibaseDataModelSerialization/pull/159 [19:30:48] addshore: ^ [19:31:05] lovely! :D [19:31:24] addshore: Did you install http://www.faforever.com/ yet? ;p [19:31:32] not yet :P [19:37:34] bad addshore [19:38:13] bah, why is this test failing on jenkins and passing localyllyy [19:38:16] bah1!!!121 [19:40:05] <3 [19:52:11] Could someone clean https://www.wikidata.org/wiki/Special:Contributions/Flylaowai that is mostly spam imho. [19:52:56] Only Garberson seems unnotable. [19:53:40] LunaMetrics has a Wikipedia-page, CEO seems notable then. [19:54:12] But they all make the same mistake every time: saying that the company is the CEO of a person. ;) [19:56:23] Tpt: Deleted Garberson, other items seems notable it seems. [19:56:42] Ignore my language. ;) [19:56:55] Thank you [19:57:11] sjoerddebruin: don't worry, I was already ignoring you [19:57:18] JeroenDeDauw: Love you too. [20:01:53] yaya JeroenDeDauw, massive chain all rebased ;) [20:51:20] cheers aude! [20:51:39] :) [20:56:35] what happened to the rebase button? [20:57:29] its not merged yet :P [20:57:44] oh [20:58:03] jenks is very usy :D [20:58:07] *busy [20:58:13] :/ [21:04:14] merged ;) [21:07:06] * jzerebecki was bad and did a task tagged easy without thinking about it [21:08:08] *goes to rebase his chain*....... [22:06:12] * jzerebecki launches some tactial mexican kittens at JeroenDeDauw