[07:30:46] Good morning Amir11 , connection acting up? [07:31:56] good morning to you too multichill :) [11:13:58] multichill: https://www.dropbox.com/s/tpdft23yes1ysm1/Schermafdruk%202015-07-05%2013.13.54.png?dl=0 :/ [11:14:17] Seems the Brooklyn batch. [11:14:34] Yeah, I ran into one of those just now [12:07:52] MGChecker: Please fix your connection or leave this channel. [12:12:16] * nikki doesn't understand how the interface decides what counts as "malformed input" [12:13:01] it finally accepted it the third time I tried >_< [12:20:31] Mostly spaces and hidden unicode characters [12:20:50] but there weren't either of those :/ [12:21:02] Oh? [12:24:58] yeah, I'm in the middle of marking various ipa vowels and was adding the ipa for them, which is a single character, so I typed them, pressed enter, and noooo, it's malformed [12:27:43] There are some on-wiki "protections" beyond what Wikibase provides, too [12:28:15] You could also hit a abuse filter yes. [12:28:48] that wouldn't explain why it works if I try again (or twice more) though, would it? [14:13:16] benestar, hows it going? :P [14:13:44] addshore: very fun, Jakob is here as well ;) [14:13:51] ahhh! nice! :) [15:12:20] addshore: so benestar showed up just in time to merge all your things! [15:12:50] !nyan | nyan [15:12:50] nyan: ~=[,,_,,]:3 [15:12:52] wait... how is "nyan" not already in use on freenode [15:13:01] xD [15:13:04] register it [15:25:43] *goes to break WikibaseQuality* :O * [15:25:55] Please not :D [15:27:10] meh, 2 of 3 of them are using ApiWikibase >.> which I was just about to nuke :D [15:27:11] addshore: yeah, just get your ass online on http://www.faforever.com/ and stop breaking things during the weekend (except hostile units and bases that is) [15:27:35] addshore: yeah, they looked at our code as an example on how to do things >_> [15:27:51] PropertySuggester doesnt use it! [15:27:53] Even created their own little version of Wikibase Lib [15:28:33] nyan: But we all love Wikibase lib... don't we? [15:28:40] :/ [15:28:57] *goes to publisize another 5 or so patches... [15:29:06] * nyan launches a nuke at hoo [15:29:09] no wait [15:29:14] nooooo! [15:29:24] kill all of the things! [15:29:36] addshore: Remember that they use v1 right now [15:29:42] so that needs to be fixed up [15:30:01] hoo: yeh, will backport the fixes [15:30:03] Also v1 must be compatible with our last branch and preferably with the next one [15:30:13] it should all be copy and paste stuff [15:30:22] also>> https://usercontent.irccloud-cdn.com/file/xnU6OqCU/ [15:30:24] Is it forward comptabily? [15:30:30] hoo: yes [15:30:35] \o/ [15:31:15] huzzah \o/ [15:31:46] Systemd-logind eathing my cpu is not exactly helping my notebook to not overheat ... [15:41:12] addshore: https://gerrit.wikimedia.org/r/#/c/222895/ [16:02:54] addshore: how to fix that? https://phabricator.wikimedia.org/T98850 [16:02:58] it's a nasty blocker [16:05:44] * multichill is puzzled by https://www.wikidata.org/w/index.php?title=Q20643524&type=revision&diff=226612977&oldid=226470893 [16:06:10] Where did that 's come from? :S [16:06:55] multichill: I think they are imported by bot [16:07:09] https://www.wikidata.org/w/index.php?title=Q20643524&action=history <- I'm not a bot [16:07:09] oh, you created that item o.O [16:07:30] So I tried to reproduce it. I either took it from https://commons.wikimedia.org/w/index.php?title=File:Paul_Sandby_-_Windsor_Castle-_The_Round_Tower,_Royal_Court_and_Devil%27s_Tower_from_the_Black_Rod_-_Google_Art_Project.jpg&oldid=127531637 [16:07:40] or http://www.ngv.vic.gov.au/explore/collection/work/27671/ [16:07:55] No luck reproducing it on test [16:08:47] benestar: https://test.wikidata.org/wiki/Special:Contributions/Multichill <- all options are ok [16:10:25] multichill: you perhaps pasted the string in the form with the HTML escaped character [16:10:39] https://test.wikidata.org/w/index.php?title=Q1385&action=history <- html doesn't get escaped in summaries [16:10:41] hoo: --^ [16:11:18] uhm [16:11:27] Where did you get that from benestar? [16:12:31] oh cool hoo WikibaseQuality v1 doesnt have an api and thus doesnt use ApiWikibase thus no backport there :P [16:13:12] multichill, did you use Visual Editor? VE often adds extra stuff like that [16:13:23] Nope, I'm VE-free [16:13:25] hoo: no escaping of &xxx; stuff in summaries [16:13:36] https://test.wikidata.org/w/index.php?title=Q1389&action=history https://test.wikidata.org/w/index.php?title=Q1388&action=history [16:14:19] https://test.wikidata.org/wiki/Special:RecentChanges is starting to look interesting [16:14:20] benestar: Yeah, that makes sense [16:18:09] * guillom waves at multichill. [16:18:32] hi guillom, getting ready for Mexico? [16:18:57] multichill: Spending my work days preparing my work presentations, and my week-ends preparing my volunteer presentations. So, yes! Will you be there? [16:20:00] Yes, I'll be there! Also preparing a presentation. [16:20:12] Great :) [16:31:09] hoo: only 1 patch to BP I think [16:32:51] Ok, nice [16:55:45] benestar: jzerebecki addshore https://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [16:56:50] oh hi nyan [16:57:00] !nyan | lazowik [16:57:00] lazowik: ~=[,,_,,]:3 [16:57:09] !nyan | nyan [16:57:09] nyan: ~=[,,_,,]:3 [16:57:16] !nyan | ~=[,,_,,]:3 [16:57:16] ~=[,,_,,]:3: ~=[,,_,,]:3 [16:57:28] !nyan !nyan !nyan | !nyan [16:57:28] !nyan: ~=[,,_,,]:3 [16:57:31] nyan: Pizzabrötchen gefüllt (8 Stück) 6,49 one! [16:57:31] :C [16:58:11] addshore: what dip? [16:58:17] bbq? ;) [16:58:25] also, you just picked this because its the most expensive thing you can afford right? [16:58:29] drop the dip [16:58:37] omfg >_> how could I forget the bbq [16:58:38] beat? [16:59:01] loool [16:59:05] now the order is 14.99 [16:59:09] min order is 15.00 [16:59:11] >_> [16:59:25] … [16:59:40] lazowik: you also want some food? [16:59:49] You need to come pick it up at the wmde office tho [16:59:55] damn [16:59:59] nyan: wait [17:00:08] nyan: DO NOT WAIT! [17:00:15] gimme pizzabrötchen with tzatziki [17:00:28] benestar: y u at wmde? [17:00:58] benestar: which ones? [17:01:02] * lazowik wonders what has he written [17:01:13] normal [17:01:38] * lazowik|afk *puff* [17:01:50] benestar: i can haz bitcoins now? [17:02:01] * benestar doesn't have bitcoinns [17:02:13] you can give me bitcoins, then I can give you bitcoins [17:02:23] benestar: right [17:02:35] benestar: if you pay the food person, then me and addshore can send you bitcoins [17:02:47] just make a wallet on coinbase.com [17:03:09] yus ;) [17:03:22] neither of us have enough monye nyan ;) [17:03:29] but i have bitcoins! [17:03:30] ask jan :P [17:03:35] I need money in the train tomorrow [17:03:44] benestar does not have enough cash? [17:04:15] enough for my stuff but not for all of you :P [18:02:16] addshore: long commit chain much? [18:02:23] only about 15 :O [18:02:54] guh [18:03:05] addshore: "help class" is also not nice [18:03:19] Though better than base class as dumping ground for common code [18:04:12] addshore: this looks very unchoesive https://gerrit.wikimedia.org/r/#/c/222772/12/repo/includes/api/ApiHelperFactory.php [18:06:26] Not sure this test makes it easier to change the code. https://gerrit.wikimedia.org/r/#/c/222772/12/repo/tests/phpunit/includes/api/EntitySaverHelperTest.php [18:06:41] Yeah, it will catch some breakage, though also binds to the implementation [18:07:30] yeh, ideally I want to kill EntitySaveHelper some more [18:09:13] I think one of the ugliest things about the save stuff is the fact that it is using EditEntity [18:09:35] Which requires all of the things [18:10:00] 6 services, context, user and entity and baserev ;) [18:11:04] it could probably be refactord to not include the user, newEntity and baseRev in the constructor though, that would tidy things up :/ [18:11:19] Yeah... I should talk our overlords into creating a prize for whoever manages to refactor EditEntity away in a sane way and not go mad in the process [18:11:27] xD [18:11:43] Maybe we need another shrine [18:12:42] EditEntity is..... just ewww :d [18:27:26] addshore: you put an evil behaviour change into your commit chain! https://gerrit.wikimedia.org/r/#/c/222900/ [18:27:54] perhaps benestar can review that one? [18:28:43] how is that one evil? [18:29:03] well, yes slight behaviour change i guess :/ [18:29:24] addshore: its evil in that I have to open my IDE and look at all that stuff ;p [18:29:51] haha :p [18:31:21] null is just something getEntityRevision and everything else never expected :/ terrible its been like that for so long! [18:32:05] essentially, the editing api modules should always use master [19:37:27] hoo: around still? :D [19:37:41] yes [19:39:23] ahah, was going to point you toward https://gerrit.wikimedia.org/r/#/c/222900/ just merged [19:39:43] might cause more master reads, but only for the api modules listed in that diff, so don't see it causing any issu [19:39:45] *issue [19:40:04] I thought it changed more api modules than that.. :) [19:41:41] addshore: If it causes master reads only for write actions, that's fine [19:41:53] yup :0 [19:41:53] actually we want to read from master, if we plan to alter stuff [19:41:55] :) [19:42:15] Don't believe that was over looked for so long! [19:53:09] JeroenDeDauw: https://gerrit.wikimedia.org/r/#/c/222943 makes EntitySaveHelper a bit nicer ;) [19:53:13] film time! [22:39:47] JohnFLewis: feel like inviting me to -admin ? [23:04:38] matanya: sure [23:04:54] thanks [23:05:33] (done so, join :)) [23:05:46] done, thanks!