[08:10:39] 10Wikidata, 10Datasets-General-or-Unknown, 6Labs, 10Labs-Infrastructure, and 2 others: Add Wikidata json dumps to labs in /public/dumps - https://phabricator.wikimedia.org/T100885#1344896 (10ArielGlenn) ...waiting for folks to get legacy/symlink/etc stuff sorted out on the changeset and I'll be happy to me... [08:33:23] (03CR) 10Jonaskeutel: [C: 032 V: 032] Serialization of entity ids is now escaped correctly. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/216405 (https://phabricator.wikimedia.org/T101308) (owner: 10Soeren.oldag) [08:34:46] (03CR) 10Dominic.sauer: [C: 032 V: 032] Reformatted all files. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216085 (owner: 10Soeren.oldag) [08:35:16] (03CR) 10Dominic.sauer: [C: 032 V: 032] Reformatted all files. [extensions/WikidataQuality] (v1) - 10https://gerrit.wikimedia.org/r/216087 (owner: 10Soeren.oldag) [08:36:02] (03CR) 10jenkins-bot: [V: 04-1] Reformatted all files. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216085 (owner: 10Soeren.oldag) [09:23:12] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06specificReturns from 14df94af3 to 142f16959: 02http://git.io/vvoc5 [09:23:12] 13WikibaseDataModelSerialization/06specificReturns 142f16959 15Thiemo Mättig: Fix overly unspecific return object tags [09:32:05] [13Serialization] 15thiemowmde 04force-pushed 06bootstrap from 14c58237e to 141677549: 02http://git.io/jd1F [09:32:05] 13Serialization/06bootstrap 141677549 15Thiemo Mättig: Drop composer update from test bootstrap [09:33:50] [13Common] 15thiemowmde 04force-pushed 06030 from 14d13de71 to 1487df31b: 02http://git.io/hAzs [09:33:50] 13Common/06030 1487df31b 15Thiemo Mättig: Prepare 1.0.0 release [09:37:14] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06constructors3 from 14a6fc404 to 14bce19d8: 02http://git.io/vv2cD [09:37:14] 13WikibaseDataModel/06constructors3 14bce19d8 15Thiemo Mättig: Rework ...List constructors [09:38:52] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [09:38:59] [13Time] 15thiemowmde 04force-pushed 06timeFormatterCal2 from 1441762f1 to 149151de5: 02http://git.io/pQaF [09:38:59] 13Time/06timeFormatterCal2 149151de5 15Thiemo Mättig: Major rewrite of TimeFormatter [09:39:25] 10Wikidata, 10Wikidata-Quality-Constraints: Ex: WikibaseQualityConstraints - remove or sanitize regex for FormatChecker - https://phabricator.wikimedia.org/T101467#1345173 (10Jonaskeutel) We read about this and understand it's problematic, but we still have no idea how to fix this issue. For concerns about the... [09:40:04] (03CR) 10Addshore: [C: 032] Use WikibaseRepo::getRedirectCreator in CreateRedirect [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216518 (owner: 10Hoo man) [09:40:20] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [09:44:23] (03PS3) 10Addshore: Fix behaviour of EntityRevisionLookup::getLatestRevisionId implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216514 (https://phabricator.wikimedia.org/T101625) (owner: 10Hoo man) [09:57:30] (03PS2) 10Dominic.sauer: Add changes related to adding relative path for icons on item page [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/216111 [09:58:12] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-06-02: UsageTracking: Use new ParserCacheSaveComplete hook to track usage info. - https://phabricator.wikimedia.org/T99512#1345189 (10Addshore) [09:58:15] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-05-05, 3Wikidata-Sprint-2015-06-02: UsageTracking: split the "update" operation for usage entries into "add" and "prune". - https://phabricator.wikimedia.org/T99513#1345187 (10Addshore) 5Open>3Resolved [09:58:29] (03CR) 10Dominic.sauer: [C: 032 V: 032] "Can not merge :(" [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/216089 (owner: 10Soeren.oldag) [09:58:53] (03CR) 10Dominic.sauer: [C: 032 V: 032] "Can not merge :(" [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/216083 (owner: 10Soeren.oldag) [09:59:30] (03CR) 10Dominic.sauer: [C: 032 V: 032] Reformatted all files. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/216088 (owner: 10Soeren.oldag) [09:59:51] (03CR) 10Dominic.sauer: [C: 032 V: 032] Reformatted all files. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/216084 (owner: 10Soeren.oldag) [10:00:08] (03CR) 10Dominic.sauer: "Can not merge :(" [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/216084 (owner: 10Soeren.oldag) [10:00:14] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-06-08T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/216627 [10:00:48] (03CR) 10Dominic.sauer: "Can not merge :(" [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/215670 (owner: 10Soeren.oldag) [10:03:25] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015-06-08T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/216627 (owner: 10WikidataBuilder) [10:04:37] (03PS2) 10Thiemo Mättig (WMDE): Update Wikibase to use DataValues JavaScript 0.7.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215899 (owner: 10Aude) [10:05:08] (03CR) 10jenkins-bot: [V: 04-1] Update Wikibase to use DataValues JavaScript 0.7.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215899 (owner: 10Aude) [10:14:29] (03PS2) 10Dominic.sauer: Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 [10:15:18] (03CR) 10jenkins-bot: [V: 04-1] Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 (owner: 10Dominic.sauer) [10:19:16] (03CR) 10Addshore: [C: 04-1] Fix behaviour of EntityRevisionLookup::getLatestRevisionId implementations (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216514 (https://phabricator.wikimedia.org/T101625) (owner: 10Hoo man) [10:20:21] (03CR) 10Soeren.oldag: [C: 032 V: 032] Add changes related to adding relative path for icons on item page [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/216113 (owner: 10Dominic.sauer) [10:20:49] (03CR) 10Soeren.oldag: [C: 032 V: 032] Add changes related to adding relative path for icons on item page [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/216111 (owner: 10Dominic.sauer) [10:23:57] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Update revision id for termbox placeholder during doEditUpdates (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203074 (owner: 10Aude) [10:26:35] 10Wikidata, 7Tracking: Use Wikibase/DataModel 3.0 (tracking) - https://phabricator.wikimedia.org/T96602#1345209 (10Tobi_WMDE_SW) [10:26:38] 10Wikibase-DataModel, 10Wikidata: Release Wikibase DataModel 3.0 - https://phabricator.wikimedia.org/T100947#1345206 (10Tobi_WMDE_SW) 5Open>3Resolved a:3Tobi_WMDE_SW Has been done: https://github.com/wmde/WikibaseDataModel/releases/tag/3.0.0 [10:27:50] (03CR) 10Addshore: [C: 04-2] "indeed, needs to go into WikidataBuildResources" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/216359 (owner: 10Legoktm) [10:29:28] (03PS32) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [10:35:36] addshore: can you try poking hoo on irc again about your questions on https://gerrit.wikimedia.org/r/#/c/215585/ ? if he's showing up here today.. [10:35:49] Tobi_WMDE_SW: will do [10:36:21] addshore: ariel is happy to merge once we've sorted out stuff with the symlinks.. [10:38:38] (03PS33) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [10:38:57] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [10:41:34] (03CR) 10Addshore: [C: 032] "This area still needs more work / fixing." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [10:41:41] addshore: hmmmmm https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Undo_edits_via_API - when you have a minute could you check? [10:41:52] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [10:41:57] Lydia_WMDE: looking [10:42:00] thx [10:43:17] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [10:45:09] (03Merged) 10jenkins-bot: Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [10:45:58] oh Lydia_WMDE thats annoying [10:46:14] https://usercontent.irccloud-cdn.com/file/kwGAPZhv/ [10:46:22] I'm guessing before this didn't happen [10:46:54] addshore: hmmmm [10:47:00] our fault? [10:47:09] no, it'll be a change in core [10:50:08] addshore: merci :) [10:50:36] [13WikibaseDataModel] 15Benestar closed pull request #495: Also allow a Snak parameter in Statement (062.6.x...06statementconstructor) 02http://git.io/vkFg8 [10:51:54] Lydia_WMDE: now you nevertheless released DM 3.0? o.O [10:52:23] benestar: yeah... [10:52:28] communication ftw [10:54:47] (03PS34) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [10:55:00] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [10:56:15] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [10:57:26] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [10:58:09] [13WikibaseDataModelSerialization] 15Benestar 04force-pushed 06dm3.0 from 14a494d0b to 149a45e41: 02http://git.io/vkF8f [10:58:09] 13WikibaseDataModelSerialization/06dm3.0 149a45e41 15Bene: Adapt .travis.yml to DM 3.0 [10:58:42] addshore: https://github.com/wmde/WikibaseDataModelSerialization/pull/132 <- meeerge :D [10:59:18] Lydia_WMDE: I'm just preparing the adaption for DM 3.0 in other repos so that it gets used there at least [11:01:45] (03PS35) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:01:55] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:02:07] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:03:06] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:03:36] (03PS3) 10Dominic.sauer: Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 [11:04:18] (03CR) 10jenkins-bot: [V: 04-1] Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 (owner: 10Dominic.sauer) [11:07:08] benestar: ok :) did you see the patches Thiemo already made? [11:07:24] Lydia_WMDE: yeah, addshore just merged one [11:07:30] k [11:07:36] I built some on top of that one [11:07:46] * benestar hopes addshore will also merge them [11:07:46] cool [11:07:51] hehe [11:07:56] I think today is going to be mainly a review day for me :p [11:08:06] (03PS4) 10Dominic.sauer: Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 [11:08:09] and I'll look at that undo issue Lydia_WMDE [11:08:17] thx! [11:08:54] (03CR) 10jenkins-bot: [V: 04-1] Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 (owner: 10Dominic.sauer) [11:11:36] addshore: I can also do reviews for your things if you ping me :) [11:11:42] * benestar likes review deals ^^ [11:11:55] xD Not really got anything up, unless you want to review some Java [11:11:55] (03PS5) 10Dominic.sauer: Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 [11:12:11] https://github.com/wmde/wikidata-analysis/pull/6 [11:12:50] (03PS36) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:12:56] (03CR) 10jenkins-bot: [V: 04-1] Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 (owner: 10Dominic.sauer) [11:13:07] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:13:11] (03PS6) 10Dominic.sauer: Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 [11:13:13] (03PS37) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:13:18] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:13:41] (03CR) 10jenkins-bot: [V: 04-1] Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 (owner: 10Dominic.sauer) [11:14:22] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:14:27] Lydia_WMDE: did you make a ticket for the undo thing? [11:14:32] 10Wikidata, 10Wikidata-Query-Service: Add autocompletion to the SPARQL ui to allow entering items by typing their label - https://phabricator.wikimedia.org/T101693#1345268 (10Bene) 3NEW [11:14:34] not yet no [11:15:05] want me to make one after lunch? [11:16:44] yeh, so the change that broke undoing i believe is https://github.com/wikimedia/mediawiki/commit/2513086ec16150431cc9a62aaf6f09711f838c46#diff-6f2c5a046a3c34fcf75412e444924f55 [11:16:59] just looking more at what the best path probvably is now [11:17:09] cool [11:17:46] [13wikidata-analysis] 15Benestar comment on pull request #6 141d8d694: -this 02http://git.io/vI4eW [11:18:23] (03CR) 10Soeren.oldag: [C: 032 V: 032] Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 (owner: 10Dominic.sauer) [11:18:44] Lydia_WMDE: Ill make the issue now actually [11:18:54] ok :) [11:18:57] (03CR) 10jenkins-bot: [V: 04-1] Add relative path for icons on item page [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/216112 (owner: 10Dominic.sauer) [11:19:01] * Lydia_WMDE fights with mail backlog [11:19:57] :O [11:20:28] addshore: you just create json files in Java and then create png files in python? o.O [11:20:30] (03PS38) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:20:36] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:20:48] benestar: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Special:ItemByTitle_in_Scribunto <- do you know? [11:20:54] benestar: yus ;p [11:21:11] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:21:21] Lydia_WMDE: looking [11:21:51] thx [11:22:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Undoing wikibase edits via API is no longer possible - https://phabricator.wikimedia.org/T101694#1345280 (10Addshore) 3NEW [11:22:41] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:23:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Replace stuff in WikibaseRepo hooks with mechanism in core for disabling direct editing of content types - https://phabricator.wikimedia.org/T96382#1345288 (10Addshore) The core patch means that edits to wikibase items can no longer be undone through the A... [11:24:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Undoing wikibase edits via API is no longer possible - https://phabricator.wikimedia.org/T101694#1345290 (10Addshore) [11:25:41] (03PS39) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:26:11] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:27:30] cookies for addshore and benestar :D [11:27:49] :D [11:27:50] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:28:38] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:31:26] (03PS40) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:32:00] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:32:36] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:33:56] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:36:42] (03PS41) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:37:38] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:37:40] (03PS42) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:37:48] Lydia_WMDE: that evaluation by the Foundation is kinda weird [11:37:53] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:38:00] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:38:30] (03PS43) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:40:30] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:43:34] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:44:22] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:50:33] hmmm benestar $statement->setGuid [11:51:05] doesnt exist =o [11:51:26] oh wait, yes it does, just my IDE was being super slow [11:51:39] suuuuppppepeerrr slow [11:51:44] (03PS44) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [11:51:49] :O [11:51:54] well nvm ;) [11:52:23] (03CR) 10Paladox: "Please recheck." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:58:29] [13WikibaseDataModelSerialization] 15addshore pushed 1 new commit to 06master: 02http://git.io/vI4Yh [11:58:29] 13WikibaseDataModelSerialization/06master 143f58329 15addshore: Merge pull request #132 from wmde/dm3.0... [11:58:38] [13WikibaseDataModelSerialization] 15addshore 04deleted 06dm3.0 at 149a45e41: 02http://git.io/vI4Oe [11:59:04] [13WikibaseDataModelSerialization] 15addshore closed pull request #115: Switch from DataModel 2.x to 3.x (06master...06dm3) 02http://git.io/hbqn [11:59:16] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [11:59:16] addshore: \o/ [11:59:33] how often do you plan to write "recheck" today? :P [11:59:38] lots :/ [11:59:46] you can join in too! ;p [12:00:11] (03CR) 10jenkins-bot: [V: 04-1] Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [12:04:10] [13Time] 15addshore closed pull request #42: Unify names of time precision constants (06master...06precisionConsts) 02http://git.io/xM75 [12:13:29] addshore: if you tweet http://addshore.com/2015/06/wikidata-map-19-months-on/ i'll retweet :) (don't want to retweet the tweet to daniel) [12:14:32] The Netherlands are the best. <3 [12:14:50] (03PS1) 10Thiemo Mättig (WMDE): Rename ChangeOpClaimRemove to ChangeOpStatementRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216659 (https://phabricator.wikimedia.org/T87388) [12:15:59] sjoerddebruin: :P streets!... [12:16:04] [13WikibaseDataModelSerialization] 15Benestar pushed 1 new commit to 06master: 02http://git.io/vI4nc [12:16:04] 13WikibaseDataModelSerialization/06master 14399c5b7 15Bene*: Update branch alias [12:16:20] Lydia_WMDE: And monuments! [12:16:25] true [12:16:33] addshore: thx :P [12:16:34] Lydia_WMDE: https://twitter.com/addshore/status/607883862862139392 [12:16:44] my phone ringed already ;-) [12:16:48] ;) [12:18:11] I'm having problems with adding a P31 or P279 to https://www.wikidata.org/wiki/Q40837 [12:18:42] P360 doesn't seem valid to me. [12:24:11] (03PS2) 10Thiemo Mättig (WMDE): Rename ChangeOpClaimRemove to ChangeOpStatementRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216659 (https://phabricator.wikimedia.org/T87388) [12:29:21] DanielK_WMDE_: https://phabricator.wikimedia.org/T101399 [12:38:11] [13WikibaseInternalSerialization] 15Benestar created 06dm3.0 (+1 new commit): 02http://git.io/vI4BV [12:38:11] 13WikibaseInternalSerialization/06dm3.0 142ad7f1d 15Bene: Adapt DataModel 3.0 and DataModelSerialization 1.4 [12:38:49] [13WikibaseInternalSerialization] 15Benestar opened pull request #71: Adapt DataModel 3.0 and DataModelSerialization 1.4 (06master...06dm3.0) 02http://git.io/vI4BX [12:39:34] (03PS4) 10Bene: [DNM] Use StatementList::removeStatementsWithGuid in ChangeOpClaimRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209279 [12:41:02] (03CR) 10jenkins-bot: [V: 04-1] [DNM] Use StatementList::removeStatementsWithGuid in ChangeOpClaimRemove [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209279 (owner: 10Bene) [12:41:16] wmde/WikibaseInternalSerialization/dm3.0/2ad7f1d : Bene The build failed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/65880843 [12:46:24] [13WikibaseInternalSerialization] 15Benestar 04force-pushed 06dm3.0 from 142ad7f1d to 1485aa7cf: 02http://git.io/vI40Q [12:46:24] 13WikibaseInternalSerialization/06dm3.0 1485aa7cf 15Bene: Adapt DataModel 3.0 and DataModelSerialization 1.4 [12:50:01] [13WikibaseInternalSerialization] 15Benestar pushed 1 new commit to 06dm3.0: 02http://git.io/vI4u8 [12:50:01] 13WikibaseInternalSerialization/06dm3.0 148417032 15Bene: Update release notes [12:50:04] wmde/WikibaseInternalSerialization/dm3.0/85aa7cf : Bene The build is still failing. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/65881751 [12:51:41] [13WikibaseInternalSerialization] 15Benestar 04force-pushed 06dm3.0 from 148417032 to 147974c92: 02http://git.io/vI40Q [12:51:41] 13WikibaseInternalSerialization/06dm3.0 147974c92 15Bene: Update release notes [12:52:07] wmde/WikibaseInternalSerialization/dm3.0/8417032 : Bene The build is still failing. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/65882189 [12:54:21] wmde/WikibaseInternalSerialization/dm3.0/7974c92 : Bene The build is still failing. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/65882403 [13:00:03] [13Time] 15thiemowmde 04force-pushed 06timeFormatterCal2 from 149151de5 to 14920474f: 02http://git.io/pQaF [13:00:03] 13Time/06timeFormatterCal2 14920474f 15Thiemo Mättig: Major rewrite of TimeFormatter [13:06:59] (03PS1) 10Tamslo: CommonsLinkChecker uses commons db for files now [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/216664 (https://phabricator.wikimedia.org/T101468) [13:08:25] [13WikibaseDataModelSerialization] 15thiemowmde 04deleted 06dm3 at 14fd44246: 02http://git.io/vI4oL [13:09:47] (03CR) 10Andreasburmeister: [C: 032 V: 032] tooltips now clickable and hoverable via javascript [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/214580 (owner: 10Dimitri.schmidt) [13:13:11] (03CR) 10Daniel Kinzler: [C: 04-1] "I have to say that it makes me rather uncomfortable that EntityRevisionLookup::getLatestRevisionId shoud return the revision ID of a redir" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216514 (https://phabricator.wikimedia.org/T101625) (owner: 10Hoo man) [13:14:05] (03PS1) 10JanZerebecki: Delete subscriptions to create fixture before test. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216666 (https://phabricator.wikimedia.org/T101399) [13:16:40] [13WikibaseInternalSerialization] 15Benestar closed pull request #70: Add missing exceptions to {Claim|Entity}Deserializer (06master...06nonArrays) 02http://git.io/vJ1Zp [13:19:42] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/vI4i1 [13:19:42] 13ValueView/06master 148eeeaa9 15Thiemo Mättig: Update README.md [13:21:33] [13ValueView] 15thiemowmde 04force-pushed 06datavalues070 from 14ff4bb3c to 142ebeed1: 02http://git.io/xd8k [13:21:33] 13ValueView/06datavalues070 142ebeed1 15snaterlicious: Removed time.js dependencies [13:25:04] (03CR) 10Addshore: "Would it be worth renaming all of the claim changeops in a single commit?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216659 (https://phabricator.wikimedia.org/T87388) (owner: 10Thiemo Mättig (WMDE)) [13:25:59] [13ValueView] 15thiemowmde 04force-pushed 06undeserializable-expert from 146de797b to 149f72fcc: 02http://git.io/vTwMv [13:25:59] 13ValueView/06undeserializable-expert 149f72fcc 15aude: Implement UnDeserializableValue expert [13:28:36] [13WikibaseInternalSerialization] 15Benestar 04force-pushed 06dm3.0 from 147974c92 to 148175099: 02http://git.io/vI40Q [13:28:36] 13WikibaseInternalSerialization/06dm3.0 148175099 15Bene: Update release notes [13:29:46] [13ValueView] 15thiemowmde 04force-pushed 06rmdisabled from 142b1b506 to 141c7cd02: 02http://git.io/xMIR [13:29:46] 13ValueView/06rmdisabled 141c7cd02 15snaterlicious: Removed inefficient mocking of native jQuery.Widget functionality... [13:30:53] wmde/WikibaseInternalSerialization/dm3.0/8175099 : Bene The build is still failing. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/65886800 [13:32:12] (03CR) 10Daniel Kinzler: [C: 032] T98809: add owl property types to the properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215984 (owner: 10Smalyshev) [13:32:56] [13ValueView] 15thiemowmde created 06constant (+1 new commit): 02http://git.io/vI4Dc [13:32:56] 13ValueView/06constant 149ff3693 15Thiemo Mättig: Remove deprecated constant [13:33:11] [13ValueView] 15thiemowmde opened pull request #172: Remove deprecated constant (06master...06constant) 02http://git.io/vI4DB [13:34:28] (03PS1) 10Dominic.sauer: Fix tests and set new threshold [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/216670 [13:35:14] (03CR) 10Daniel Kinzler: [C: 032] Much simpler usage aspect intersection calculation (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212406 (owner: 10Thiemo Mättig (WMDE)) [13:35:38] (03Merged) 10jenkins-bot: T98809: add owl property types to the properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215984 (owner: 10Smalyshev) [13:36:37] (03PS10) 10Daniel Kinzler: Track fallback languages used via parser function. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209753 (https://phabricator.wikimedia.org/T93056) [13:36:47] (03PS9) 10Daniel Kinzler: Track label usage with fallback from Lua. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/210051 (https://phabricator.wikimedia.org/T93056) [13:37:03] (03PS3) 10Daniel Kinzler: Track usages on ParserCacheSaveComplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215660 (https://phabricator.wikimedia.org/T99512) [13:38:53] (03Merged) 10jenkins-bot: Much simpler usage aspect intersection calculation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212406 (owner: 10Thiemo Mättig (WMDE)) [13:40:00] (03CR) 10Daniel Kinzler: [C: 032] Use WikibaseRepo::getRedirectCreator in CreateRedirect [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216518 (owner: 10Hoo man) [13:40:18] (03PS2) 10Daniel Kinzler: Use WikibaseRepo::getRedirectCreator in CreateRedirect [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216518 (owner: 10Hoo man) [13:40:51] wikimedia/mediawiki-extensions-Wikibase/master/c299b06 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65888036 [13:48:35] addshore: https://github.com/wmde/WikibaseInternalSerialization/pull/71 [13:48:37] tests fail but I don't know why, I didn't touch the file in question [13:48:37] *looks* [13:48:38] (03PS1) 10Dominic.sauer: Fix tests and set new threshold [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/216674 [13:48:39] [13WikibaseInternalSerialization] 15thiemowmde created 06slDesDocs (+1 new commit): 02http://git.io/vI4H0 [13:48:39] 13WikibaseInternalSerialization/06slDesDocs 14612f648 15Thiemo Mättig: Add missing class docs to LegacySiteLinkListDeserializer [13:48:39] ty [13:48:39] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #72: Add missing class docs to LegacySiteLinkListDeserializer (06master...06slDesDocs) 02http://git.io/vI4H2 [13:48:41] (03CR) 10Daniel Kinzler: [C: 032] Delete subscriptions to create fixture before test. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216666 (https://phabricator.wikimedia.org/T101399) (owner: 10JanZerebecki) [13:48:42] [13WikibaseInternalSerialization] 15thiemowmde 04force-pushed 06entity from 14608f17a to 149deb0ed: 02http://git.io/vI4Qq [13:48:42] 13WikibaseInternalSerialization/06entity 149deb0ed 15jeroendedauw: Use EntityDocument instead of Entity [13:48:43] wmde/WikibaseInternalSerialization/slDesDocs/612f648 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/65889149 [13:48:43] (03PS2) 10Dominic.sauer: Fix tests and set new threshold [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/216674 [13:48:44] (03Merged) 10jenkins-bot: Delete subscriptions to create fixture before test. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/216666 (https://phabricator.wikimedia.org/T101399) (owner: 10JanZerebecki) [13:48:44] wikimedia/mediawiki-extensions-Wikibase/master/081b680 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65888622 [13:48:45] [13WikibaseInternalSerialization] 15JeroenDeDauw comment on pull request #72 14612f648: This comment does not add info that is not already clear from the signature and the return statement, or cannot be understood by static code analysis tools without it. 02http://git.io/vI47s [13:48:45] [13WikibaseInternalSerialization] 15JeroenDeDauw 04deleted 06slDesDocs at 14612f648: 02http://git.io/vI47B [13:48:46] [13WikibaseInternalSerialization] 15thiemowmde 04force-pushed 06doNotStore from 1466388c1 to 14bb028f1: 02http://git.io/vI476 [13:48:46] 13WikibaseInternalSerialization/06doNotStore 14bb028f1 15Thiemo Mättig: Do not store serialization during deserialization [13:49:48] benestar: phpmd failures [13:49:48] [13WikibaseInternalSerialization] 15JeroenDeDauw comment on pull request #71 148175099: Not sure this works. If you want to modify the stability, then the syntax is `@modifier`. The branch alias for master is `1.4.x-dev`, though I'm not sure usage of this will be allowed without also decreasing the min stability. 02http://git.io/vI45J [13:49:49] =o [14:00:13] yeah, very strange [14:00:16] cant find the coupling rule in https://github.com/wmde/WikibaseInternalSerialization/blob/master/phpmd.xml though [14:00:16] wikimedia/mediawiki-extensions-Wikibase/master/89e0c87 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65889690 [14:00:16] [13WikibaseInternalSerialization] 15thiemowmde comment on pull request #72 14612f648: Could have been `string[]|array[] $siteLinkArray`. 02http://git.io/vI4dm [14:00:17] [13WikibaseDataModelSerialization] 15Benestar closed pull request #119: Replace Snaks interface with SnakList (06master...06removeSnaks) 02http://git.io/vfQ4P [14:00:18] [13WikibaseDataModelSerialization] 15thiemowmde created 06removeSnaks (+1 new commit): 02http://git.io/vI4Fc [14:00:18] 13WikibaseDataModelSerialization/06removeSnaks 14381f6b7 15Thiemo Mättig: Remove Snaks interface [14:00:18] [13WikibaseDataModelSerialization] 15thiemowmde reopened pull request #119: Replace Snaks interface with SnakList (06master...06removeSnaks) 02http://git.io/vfQ4P [14:00:18] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06removeSnaks from 14381f6b7 to 14f2e595c: 02http://git.io/vJrIl [14:00:18] 13WikibaseDataModelSerialization/06removeSnaks 14f2e595c 15Thiemo Mättig: Remove Snaks interface [14:00:18] wmde/WikibaseDataModelSerialization/removeSnaks/381f6b7 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/65890831 [14:00:19] addshore: apperently it's some default [14:00:19] benestar: Thiemo_WMDE: ahhhh, stop making comments already. Like this my review queue grows at the same rate as I'm going through it! :<| [14:00:19] [13WikibaseDataModelSerialization] 15Benestar created 06release1.4 (+1 new commit): 02http://git.io/vI4FF [14:00:19] 13WikibaseDataModelSerialization/06release1.4 14f833987 15Bene: 1.4 release [14:00:19] !nyan | addshore [14:00:19] 04Error: Command “nyan” not recognized. Please review and correct what you’ve written. [14:00:19] addshore: ~=[,,_,,]:3 [14:00:19] benestar: interesting, as the coupling either looks the same or better :P [14:00:19] wtf, who broke the !nyan command?! [14:00:19] !nyan JeroenDeDauw [14:00:19] 04Error: Command “nyan” not recognized. Please review and correct what you’ve written. [14:00:19] http://phpmd.org/rules/design.html#couplingbetweenobjects [14:00:19] whahaha [14:00:19] @ping [14:00:19] addshore: pong [14:00:20] ~=[,,_,,]:3 [14:00:20] !ping [14:00:20] addshore: pong [14:00:20] wm-bot, why are you so dead [14:00:20] !nyan is test [14:00:20] 04Error: Command “nyan” not recognized. Please review and correct what you’ve written. [14:00:20] This key already exist - remove it, if you want to change it [14:00:20] wmde/WikibaseDataModelSerialization/release1.4/f833987 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/65891080 [14:00:21] benestar: addshore Talking about phpmd... please to support https://github.com/phpmd/phpmd/pull/273 [14:00:21] wmde/WikibaseInternalSerialization/master/3420c23 : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/65889748 [14:00:21] benestar: addshore And this one https://github.com/phpmd/phpmd/pull/257 [14:00:21] [13WikibaseDataModelSerialization] 15Benestar closed pull request #119: Replace Snaks interface with SnakList (06master...06removeSnaks) 02http://git.io/vfQ4P [14:00:32] mwhahahaa, wm-bot lives! [14:01:22] !lydia [14:01:22] \o/ [14:01:22] 04Error: Command “lydia” not recognized. Please review and correct what you’ve written. [14:01:25] xD [14:01:32] \o/ [14:01:33] :P [14:01:36] hi Lydia_WMDE :D [14:01:43] ;-) [14:02:14] AsimovBot: stfu [14:02:14] 04Error: Command “stfu” not recognized. Please review and correct what you’ve written. [14:06:06] [13WikibaseDataModelSerialization] 15Benestar opened pull request #133: 1.4 release (06master...06release1.4) 02http://git.io/vI4AL [14:06:08] axax [14:06:08] [13WikibaseInternalSerialization] 15Benestar comment on pull request #71 148175099: Just merge https://github.com/wmde/WikibaseDataModelSerialization/pull/133 and avoid this issue :D 02http://git.io/vI4Au [14:06:19] [13WikibaseDataModelSerialization] 15Benestar 04force-pushed 06release1.4 from 14f833987 to 14519315c: 02http://git.io/vI4xQ [14:06:19] 13WikibaseDataModelSerialization/06release1.4 14519315c 15Bene: 1.4 release [14:10:33] !lydia [14:10:33] 04Error: Command “lydia” not recognized. Please review and correct what you’ve written. [14:10:33] \o/ [14:10:33] :( [14:10:34] 10Wikibase-Internal-Serialization, 10Wikidata, 10DataValues, 7Performance: Deserializers should not store serialization in private properties - https://phabricator.wikimedia.org/T98124#1345602 (10JeroenDeDauw) I do not agree with the motivations outlined here as outlined in my comment on the pull request:... [14:11:52] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06release1.4: 02http://git.io/vI4j2 [14:11:52] 13WikibaseDataModelSerialization/06release1.4 14a06100b 15Jeroen De Dauw: Update README.md...