[07:20:46] (03CR) 10Bene: "I think we should do the siteSub thing in another patch and don't make this one bigger. Furthermore, I wonder what's the difference betwee" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) (owner: 10Bene) [08:21:45] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06rel30: 02http://git.io/vIeLC [08:21:45] 13WikibaseDataModel/06rel30 147fe957f 15Thiemo Mättig: Update RELEASE-NOTES.md [08:22:01] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/vIeL8 [08:22:01] 13WikibaseDataModel/06master 14f48f644 15Thiemo Mättig: Merge pull request #465 from wmde/rel30... [08:23:51] wmde/WikibaseDataModel/rel30/7fe957f : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/65366762 [08:28:12] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06settersAreSetters from 14db1d4b8 to 141e3d483: 02http://git.io/vIeqU [08:28:12] 13WikibaseDataModel/06settersAreSetters 141e3d483 15Thiemo Mättig: Do not return anything from Entity setters [09:35:02] (03CR) 10Daniel Kinzler: [C: 04-1] "there may actually be multiple tacking tables with different names." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176356 (owner: 10Thiemo Mättig (WMDE)) [09:48:47] [13wikidata-analysis] 15addshore opened pull request #6: Addshore rewrite (06master...06addshoreRewrite) 02http://git.io/vIe2W [09:48:48] aude: https://github.com/wmde/wikidata-analysis/pull/6 ;p [10:00:16] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-06-04T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/215873 [10:00:46] interesting jzerebecki and aude its the same test that fails on travis and jenkins [10:02:28] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/65306940 [10:02:36] it says "could not create new page" [10:03:22] https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/jobs/65306948 is completely different issue [10:03:25] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015-06-04T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/215873 (owner: 10WikidataBuilder) [10:11:02] (03CR) 10Aude: "I think contentSub might work, though we would probably want to tweak the styles." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) (owner: 10Bene) [10:13:18] DanielK_WMDE_: commenting on merged revision works in diffusion together with the audit extension of phabricator. howto: go to diffusion, select the repo, like: https://phabricator.wikimedia.org/diffusion/EWQL/repository/master/ ; go to a commit like: https://phabricator.wikimedia.org/rEWQL1b99f8a353214a5a0731b5b02d31c053f2d9362f ; click on a line number, save comment, submit at bottom where it says "audit commit". [10:28:27] interessting, UsageTrackingIntegrationTest::testUpdateUsageOnTemplateChange is failing locally for me [10:29:09] addshore: o_O [10:29:13] how does it fail? [10:29:38] both Q22 and Q33 show up in the array that is checked [10:29:41] addshore: that'S the test that's also failing ion the build. at least the same test class, anyway [10:29:56] oh, no, that's a completely different failure [10:29:56] hmmm... ran it 3 times, pass, fail, pass [10:29:57] and strange [10:30:01] o_O [10:30:16] running the whole class though and everything else passes [10:30:22] timing issue? with transactions? shouldn't happen... [10:30:30] what db are you using? [10:30:56] mysql currently [10:31:24] seems to be consistently passing now. [10:31:38] me too. huh. this is odd. external caches should be disabled for test runs. what gives? [10:34:39] (03CR) 10Daniel Kinzler: [C: 032] "*sigh*" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215633 (owner: 10Aude) [10:37:04] https://www.irccloud.com/pastebin/uVNoo12h/ [10:37:29] running all tests for client/includes [10:37:45] (03Merged) 10jenkins-bot: Add @group Database tag to tests that access the database [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215633 (owner: 10Aude) [10:38:52] (03CR) 10Daniel Kinzler: [C: 032] T98810: add specific types for extended values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215690 (owner: 10Smalyshev) [10:40:56] wikimedia/mediawiki-extensions-Wikibase/master/479060c : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65384762 [10:41:45] (03CR) 10Daniel Kinzler: [C: 04-1] Display badges on the other project sidebar (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/213340 (https://phabricator.wikimedia.org/T73887) (owner: 10Tpt) [10:41:49] (03Merged) 10jenkins-bot: T98810: add specific types for extended values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215690 (owner: 10Smalyshev) [10:43:09] addshore: uhh... purging is based on timestamps. it will fail if two edits are done in the same second, so the tracking entriy for Q22 would be kept. [10:43:40] so the tests are running too fast? I did see the sleep in there [10:43:41] addshore: there are sleep() calls in the test case to avoid this. but maybe sleeping for one second isn't quite enough.... [10:43:53] or it's missing a sleep() call in some critical place [10:44:18] i hate this. wfTimestamp should just return fake timestamps when in test mode [10:44:27] increment by one second for every call. [10:44:32] no more sleep [10:44:37] DanielK_WMDE_: We could probably do that [10:44:46] *looks* [10:45:22] well, some code calls time() directly, and would get out of whack [10:45:37] so the "time mock" would have to be enabled/disabled for each test case [10:45:54] the way wfTimestamp works is rather silly, btw [10:49:46] wikimedia/mediawiki-extensions-Wikibase/master/e0cc089 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65385261 [11:02:13] (03PS1) 10Thiemo Mättig (WMDE): Enable PHPCS sniff Generic.ControlStructures [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215877 [11:02:32] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [11:02:36] (03PS12) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 [11:02:46] I have changed Wikibase to run the standard `npm` jo [11:02:47] b [11:03:41] =o [11:03:49] it passes! [11:04:17] https://integration.wikimedia.org/ci/job/mwext-Wikibase-npm/ is now gone [11:04:34] next is WikidataQuality [11:06:02] we should remove the -zend jobs from Wikibase [11:06:07] and only run them on gate-and-submit [11:06:30] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [11:06:40] (03PS1) 10Thiemo Mättig (WMDE): Enable PHPCS sniff Generic.Formatting.DisallowMultipleStatements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215878 [11:07:31] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/215879 [11:07:51] hashar: looks like we will want phpcs running too? https://gerrit.wikimedia.org/r/#/c/215877/1 << Thiemo_WMDE [11:08:38] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/215879 (owner: 10Hashar) [11:09:08] addshore: probably, though I think the idea is to run that via composer [11:09:14] ie composer install && composer test [11:14:23] (03CR) 10Addshore: "We should avoid merging any of these until phpcs is actually tested by jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215877 (owner: 10Thiemo Mättig (WMDE)) [11:27:30] arh [11:27:37] what is your guys generic Phabricator project? [11:27:44] I filled a task to 'Wikidata' [11:27:51] but I really meant mediawiki/extensions/Wikibase [11:28:25] https://phabricator.wikimedia.org/T101382 -- Only run Wikibase Zend Jenkins jobs on gate-and-submit [11:46:29] (03PS1) 10Purodha: Fix typo in message text. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/215882 [11:58:15] (03PS1) 10Thiemo Mättig (WMDE): Enable PHPCS sniff Generic.Functions.OpeningFunctionBraceKernighanRitchie [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215886 [11:58:23] hashar: I added the projects for the repo9s there [12:00:37] (03PS5) 10Thiemo Mättig (WMDE): Start fixing whitespace formatting according to phpcs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/210077 [12:01:22] (03CR) 10Soeren.oldag: [C: 032 V: 032] Fix typo in message text. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/215882 (owner: 10Purodha) [12:02:14] addshore: thank you! [12:03:34] (03CR) 10Thiemo Mättig (WMDE): "Why should we "avoid" merging patches that fix issues? What does that mean?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215877 (owner: 10Thiemo Mättig (WMDE)) [12:04:02] hashar: project = wikidata is always ok [12:04:17] if needed, someone will add additional projects [12:05:31] (03PS2) 10Addshore: Track usages on ParserCacheSaveComplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215660 (https://phabricator.wikimedia.org/T99512) (owner: 10Daniel Kinzler) [12:12:19] (03CR) 10Addshore: [C: 031] Track usages on ParserCacheSaveComplete [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215660 (https://phabricator.wikimedia.org/T99512) (owner: 10Daniel Kinzler) [12:12:52] (03PS10) 10Addshore: Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [12:14:37] (03PS1) 10Daniel Kinzler: UsageTrackingIntegrationTest: Always try to delete test pages before creating them [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215889 [12:14:41] jzerebecki: --^ [12:15:22] (03CR) 10JanZerebecki: [C: 032] UsageTrackingIntegrationTest: Always try to delete test pages before creating them [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215889 (owner: 10Daniel Kinzler) [12:18:29] (03PS1) 10Jonaskeutel: escape sql and validate batchSize parameter [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/215892 [12:18:31] (03Merged) 10jenkins-bot: UsageTrackingIntegrationTest: Always try to delete test pages before creating them [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215889 (owner: 10Daniel Kinzler) [12:26:03] (03Abandoned) 10JanZerebecki: New Wikidata Build - 2015-06-04T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/215873 (owner: 10WikidataBuilder) [12:26:24] (03Abandoned) 10JanZerebecki: New Wikidata Build - 2015-06-03T16:36:23+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/215648 (owner: 10WikidataBuilder) [12:27:57] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-06-04T12:27:47+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/215895 [12:31:07] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015-06-04T12:27:47+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/215895 (owner: 10WikidataBuilder) [12:33:24] (03PS3) 10Thiemo Mättig (WMDE): Much simpler usage aspect intersection calculation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212406 [12:36:43] (03CR) 10jenkins-bot: [V: 04-1] Much simpler usage aspect intersection calculation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212406 (owner: 10Thiemo Mättig (WMDE)) [12:40:55] wikimedia/mediawiki-extensions-Wikibase/master/b7449ec : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65395471 [12:42:13] (03PS1) 10Daniel Kinzler: [DNM] Patch current master directly on top of blank repo. [extensions/WikidataQuality] (REVIEW) - 10https://gerrit.wikimedia.org/r/215897 [12:43:39] (03CR) 10jenkins-bot: [V: 04-1] [DNM] Patch current master directly on top of blank repo. [extensions/WikidataQuality] (REVIEW) - 10https://gerrit.wikimedia.org/r/215897 (owner: 10Daniel Kinzler) [12:44:31] (03PS4) 10Thiemo Mättig (WMDE): Simplify SnakList.merge() calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190216 [12:44:40] wikimedia/mediawiki-extensions-Wikibase/master/b7449ec : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65395471 [12:44:57] (03CR) 10Soeren.oldag: [C: 032 V: 032] Some i18n fixes. Modified index on wbqev_external_data. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/215672 (owner: 10Soeren.oldag) [12:46:33] (03PS1) 10Soeren.oldag: Use HtmlForm for security reasons. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/215898 [12:51:39] [13Time] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/vIv8z [12:51:40] 13Time/06master 1465edc81 15Thiemo Mättig: Update README.md [12:53:36] failing test: https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension-zend/312/console [12:55:27] [13Time] 15thiemowmde 04force-pushed 06precisionConsts from 142a7aec9 to 141d2df7c: 02http://git.io/hYuZ [12:55:27] 13Time/06precisionConsts 141d2df7c 15Thiemo Mättig: Unify names of time precision constants [13:00:24] (03PS3) 10Aude: Update Wikibase to use DataValues JavaScript 0.7.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212515 [13:00:57] (03CR) 10jenkins-bot: [V: 04-1] Update Wikibase to use DataValues JavaScript 0.7.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212515 (owner: 10Aude) [13:03:17] (03CR) 10Dominic.sauer: [C: 032 V: 032] Permitted users can now manage exceptions on special page. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/215670 (owner: 10Soeren.oldag) [13:03:19] (03CR) 10jenkins-bot: [V: 04-1] Permitted users can now manage exceptions on special page. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/215670 (owner: 10Soeren.oldag) [13:20:30] (03PS4) 10Aude: Use UnDeserializableValue expert for handling such values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212515 (https://phabricator.wikimedia.org/T92975) [13:20:32] (03PS1) 10Aude: Update Wikibase to use DataValues JavaScript 0.7.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215899 [13:21:06] (03CR) 10jenkins-bot: [V: 04-1] Use UnDeserializableValue expert for handling such values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212515 (https://phabricator.wikimedia.org/T92975) (owner: 10Aude) [13:22:27] [13wikidata-analysis] 15addshore pushed 1 new commit to 06addshoreRewrite: 02http://git.io/vIvwr [13:22:27] 13wikidata-analysis/06addshoreRewrite 141f296c7 15addshore: Re structure java stuff, enables mvn compiling... [13:22:27] (03CR) 10jenkins-bot: [V: 04-1] Update Wikibase to use DataValues JavaScript 0.7.0 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215899 (owner: 10Aude) [13:30:47] [13wikidata-analysis] 15addshore pushed 1 new commit to 06addshoreRewrite: 02http://git.io/vIv6k [13:30:47] 13wikidata-analysis/06addshoreRewrite 14c2b7b22 15addshore: Make maven build to java 1.7 [13:43:13] [13wikidata-analysis] 15addshore 04force-pushed 06addshoreRewrite from 14c2b7b22 to 141d8d694: 02http://git.io/vk5LF [13:43:13] 13wikidata-analysis/06addshoreRewrite 141d8d694 15addshore: Make maven build to java 1.7 and inc main class [13:51:17] are the lua errors at https://www.wikidata.org/wiki/Wikidata:List_of_properties/all a known thing? [13:51:33] also, hi! :-) [13:52:55] edsu: it's known. too many (expensive) scribunto calls on the page [13:53:52] (03PS2) 10Soeren.oldag: Use HtmlForm for security reasons. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/215898 [13:54:10] https://phabricator.wikimedia.org/T99120 (related) [13:54:21] aude: thx, somewhat related how about the errors at the top of the page here: https://www.wikidata.org/wiki/User:Joshbaumgartner/property_available_summary/1900-1999 [13:54:30] probably [13:54:33] oh [13:54:39] no idea [13:56:32] I guess the template it's using doesn't create a proper table row if the property doesn't exist [13:57:02] but I'm not sure what the #invoke syntax on https://www.wikidata.org/w/index.php?title=Template:List_of_properties/Row&action=edit is [13:57:33] (03PS1) 10Soeren.oldag: Use HtmlForm for security reasons. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/215904 [13:58:03] oh, I suppose that's probably https://www.wikidata.org/wiki/Module:LoP_row? [13:58:28] [13Time] 15thiemowmde 04force-pushed 06timeFormatterCal2 from 14b2f350a to 1441762f1: 02http://git.io/pQaF [13:58:28] 13Time/06timeFormatterCal2 1441762f1 15Thiemo Mättig: Major rewrite of TimeFormatter [14:00:47] (03PS1) 10Soeren.oldag: Use HtmlForm for security reasons. [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/215905 [14:06:56] (03PS1) 10Soeren.oldag: Use HtmlForm for security reasons. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/215906 [14:12:10] (03PS1) 10Soeren.oldag: Use HtmlForm for security reasons. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/215907 [14:12:46] so [14:12:55] lets drop zend jobs from Wikibase extension :-} [14:13:29] https://gerrit.wikimedia.org/r/#/c/215880/2/zuul/layout.yaml,unified [14:16:40] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [14:16:44] (03PS13) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 [14:16:56] (03CR) 10Hashar: "check zend" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [14:20:05] bye bye zend jobs https://phabricator.wikimedia.org/T101382#1337483 [14:20:21] (03PS4) 10Thiemo Mättig (WMDE): Much simpler usage aspect intersection calculation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/212406 [14:20:39] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/70395 (owner: 10Hashar) [14:20:45] (03PS5) 10Thiemo Mättig (WMDE): Remove broken unlocalization from MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) [14:22:41] (03CR) 10Dominic.sauer: [C: 032 V: 032] Use HtmlForm for security reasons. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/215898 (owner: 10Soeren.oldag) [14:22:49] (03CR) 10jenkins-bot: [V: 04-1] Remove broken unlocalization from MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) (owner: 10Thiemo Mättig (WMDE)) [14:24:16] (03CR) 10Dominic.sauer: [C: 032 V: 032] Use HtmlForm for security reasons. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/215907 (owner: 10Soeren.oldag) [14:24:53] (03Abandoned) 10Dominic.sauer: Use HtmlForm for security reasons. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/215904 (owner: 10Soeren.oldag) [14:25:49] (03CR) 10Dominic.sauer: [C: 032 V: 032] Use HtmlForm for security reasons. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/215906 (owner: 10Soeren.oldag) [14:27:19] (03CR) 10Dominic.sauer: [C: 032 V: 032] Use HtmlForm for security reasons. [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/215905 (owner: 10Soeren.oldag) [14:30:37] (03CR) 10Daniel Kinzler: [C: 04-1] "Initial pass with lots of comments and questions. I didn't look at the test cases yet." (0381 comments) [extensions/WikidataQuality] (REVIEW) - 10https://gerrit.wikimedia.org/r/215897 (owner: 10Daniel Kinzler) [14:31:01] (03PS2) 10Daniel Kinzler: [DNM] Patch current master directly on top of blank repo. [extensions/WikidataQuality] (REVIEW) - 10https://gerrit.wikimedia.org/r/215897 (https://bugzilla.wikimedia.org/100991) [14:31:24] (03PS3) 10Daniel Kinzler: [DNM] Patch current master directly on top of blank repo. [extensions/WikidataQuality] (REVIEW) - 10https://gerrit.wikimedia.org/r/215897 (https://phabricator.wikimedia.org/T100991) [14:32:55] (03CR) 10jenkins-bot: [V: 04-1] [DNM] Patch current master directly on top of blank repo. [extensions/WikidataQuality] (REVIEW) - 10https://gerrit.wikimedia.org/r/215897 (https://phabricator.wikimedia.org/T100991) (owner: 10Daniel Kinzler) [15:29:09] (03PS15) 10Sumit: WikidataPageBanner client-side image loading [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/212512 (https://phabricator.wikimedia.org/T98031) [15:33:18] (03CR) 10Sumit: WikidataPageBanner client-side image loading (032 comments) [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/212512 (https://phabricator.wikimedia.org/T98031) (owner: 10Sumit) [15:41:13] (03PS26) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [15:51:21] (03PS27) 10Paladox: Wikibase Repo: Add extension.json, empty PHP entry point [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) [15:51:43] (03CR) 10Paladox: "Please recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/211384 (https://phabricator.wikimedia.org/T88258) (owner: 10Paladox) [16:14:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1337875 (10Lydia_Pintscher) I tried to add John Katz to the ticket but couldn't find his username. Can someone who knows please do? IMHO the following... [16:16:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1337885 (10Lydia_Pintscher) Ah Jon - not John. Sorry... [16:29:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1337952 (10Lydia_Pintscher) https://www.wikidata.org/wiki/Wikidata:Project_chat#Coming_to_a_decision_for_usage_instructions_in_descriptions [16:45:32] (03PS1) 10Smalyshev: add new value types to ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215934 [16:46:17] (03PS2) 10Smalyshev: add new value types to ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215934 [16:47:14] (03PS3) 10Smalyshev: add new value types to ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215934 [18:04:44] Thiemo_WMDE: https://gist.github.com/jenseng/ec8ea234145936f19a7d [18:04:47] look for OrigXMLHttpRequest [18:20:47] (03CR) 10Daniel Kinzler: [C: 032] add new value types to ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215934 (owner: 10Smalyshev) [18:26:46] (03Merged) 10jenkins-bot: add new value types to ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215934 (owner: 10Smalyshev) [18:32:41] wikimedia/mediawiki-extensions-Wikibase/master/4a59688 : Stanislav Malyshev The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65452992 [18:35:36] wikimedia/mediawiki-extensions-Wikibase/master/4a59688 : Stanislav Malyshev The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65452992 [18:38:11] wikimedia/mediawiki-extensions-Wikibase/master/4a59688 : Stanislav Malyshev The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/65452992 [18:53:03] (03CR) 10Jdlrobson: WikidataPageBanner client-side image loading (032 comments) [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/212512 (https://phabricator.wikimedia.org/T98031) (owner: 10Sumit) [19:17:28] (03PS16) 10Sumit: WikidataPageBanner client-side image loading [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/212512 (https://phabricator.wikimedia.org/T98031) [19:19:11] (03PS17) 10Sumit: WikidataPageBanner client-side image loading [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/212512 (https://phabricator.wikimedia.org/T98031) [19:30:13] the property suggestions don't seem to work properly when adding a qualifier at the same time as adding a statement, it seems to show suggestions for new statements, not suggestions for appropriate qualifiers, is that known? [19:30:29] (it works fine if I save the statement and then edit it to add the qualifier) [19:50:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1338640 (10aude) @Lydia_Pintscher "it is already developed for Android" (you mean iOS?) android is coming also. agree that it makes sense to see how i... [19:51:28] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1338642 (10Lydia_Pintscher) @aude Doh! Yeah iOS of course. [20:00:39] Hm, don't know if the one who added the item on Wikidata is lazy... But, it describes the two kinds of hipsters. Most projects have separate articles. https://hu.wikipedia.org/wiki/Hipszter [20:04:52] oh, that problem again [20:05:33] We do this then, right? https://www.wikidata.org/w/index.php?title=Q20035654&type=revision&diff=221165153&oldid=221143581 [20:05:54] is benestar|cloud's bot not running? I thought it usually updated the rfd page when people merge/delete stuff [20:06:01] we? I run away screaming :P [20:06:07] Yeah, he's already notified. [20:06:25] nikki: Well, it's better than merging with a wrong article. [20:06:31] item* [20:06:47] oh, yes, of course. I'm just being silly :) [20:08:19] Patrolling new items again, feels like alone again... [20:11:35] you're not entirely alone! I've been looking at recent changes too (generally not new items though, mostly just reverting bad changes to statements) [20:12:00] I'm wondering if people are just adding random articles or fill in gibberish to get to a "empty" item. https://www.wikidata.org/w/index.php?title=Q20030124&action=history [20:15:13] nikki: i think that suggester problem is not known yet. [20:15:34] It is known I think. [20:15:36] Let me search [20:17:09] Hm, weird. I thought we've had one. [20:17:15] But, should it be listed on Phab or https://github.com/Wikidata-lib/PropertySuggester ? [21:28:34] nikki: but runs again :D [21:28:42] thanks for pinging [21:28:49] yay! thanks [21:30:01] is there an explanation of the difference between monolingual and multilingual text somewhere, by the way? [21:30:55] I get the difference between strings and monolingual text, but I'm totally confused by monolingual text versus multilingual text [21:37:12] (03PS1) 10Smalyshev: Make types more specific [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215977 [22:01:07] sjoerddebruin: preferably Phab [22:02:15] i think there is no way to prevent creation of new issues on a github repo except disabling issues which also prevents access to old ones :( [22:03:12] (03PS1) 10Smalyshev: T98809: add owl property types to the properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/215984 [23:19:29] 10Wikidata, 6Wikisource, 3Wikidata-Sprint-2015-06-02: Wikidata badges for Wikisource for validation status - https://phabricator.wikimedia.org/T97014#1339494 (10Billinghurst) "Featured text" would be one that English Wikisource would utilise and has a long history of use, and equates with the FA componentry... [23:19:32] 10Wikidata, 6Wikisource, 3Wikidata-Sprint-2015-06-02: Wikidata badges for Wikisource for validation status - https://phabricator.wikimedia.org/T97014#1339495 (10Billinghurst) "Featured text" would be one that English Wikisource would utilise and has a long history of use, and equates with the FA componentry... [23:38:55] 10Wikidata, 10Security-Reviews, 10Wikidata-Quality-Constraints: Ex: WikibaseQualityConstraints - remove or sanitize regex for FormatChecker - https://phabricator.wikimedia.org/T101467#1339633 (10csteipp) 3NEW [23:44:48] 10Wikidata, 10Security-Reviews, 10Wikidata-Quality-Constraints: Ex: WikibaseQualityConstraints - CommonsLinkChecker makes unsafe connections - https://phabricator.wikimedia.org/T101468#1339672 (10csteipp) 3NEW [23:47:15] 10Wikidata, 10Security-Reviews, 10Wikidata-Quality-Constraints: T101468: Ex: WikibaseQualityConstraints - CommonsLinkChecker should sanitize / escape user input in urls - https://phabricator.wikimedia.org/T101469#1339691 (10csteipp) 3NEW [23:47:54] 10Wikidata, 10Security-Reviews, 10Wikidata-Quality-Constraints: Security review of Wikibase-Quality-Constraints - https://phabricator.wikimedia.org/T99355#1339704 (10csteipp) [23:53:51] 10Wikidata, 10Security-Reviews, 10Wikidata-Quality-Constraints: Security review of Wikibase-Quality-Constraints - https://phabricator.wikimedia.org/T99355#1339735 (10csteipp) I'm done with the initial review. All the blockers need to get resolved before this is closed. [23:54:07] 10Wikidata, 10Security-Reviews, 10Wikidata-Quality-Constraints: Ex: WikibaseQualityConstraints - CommonsLinkChecker should sanitize / escape user input in urls - https://phabricator.wikimedia.org/T101469#1339737 (10csteipp) [23:57:48] 10Wikidata, 10Wikidata-Quality-Constraints: Ex: WikibaseQualityConstraints - CommonsLinkChecker should sanitize / escape user input in urls - https://phabricator.wikimedia.org/T101469#1339750 (10csteipp) [23:58:07] 10Wikidata, 10Wikidata-Quality-Constraints: Ex: WikibaseQualityConstraints - CommonsLinkChecker makes unsafe connections - https://phabricator.wikimedia.org/T101468#1339751 (10csteipp) [23:58:20] 10Wikidata, 10Wikidata-Quality-Constraints: Ex: WikibaseQualityConstraints - remove or sanitize regex for FormatChecker - https://phabricator.wikimedia.org/T101467#1339753 (10csteipp) [23:58:44] 10Wikidata, 10Wikidata-Quality-Constraints: Ex:WikidataQualityConstraints - EntityId::getSerialization() is not guaranteed to be safe for HTML - https://phabricator.wikimedia.org/T101308#1339759 (10csteipp) [23:59:03] 10Wikidata, 10Wikidata-Quality-Constraints: Ex:WikidataQualityConstraints - (hardening) escape sql closer to the output. - https://phabricator.wikimedia.org/T101305#1339762 (10csteipp) [23:59:17] 10Wikidata, 10Wikidata-Quality-Constraints: Document architectural decisions for WikidataQuality extensions - https://phabricator.wikimedia.org/T101303#1339765 (10csteipp)