[00:36:06] 10Wikidata, 3Wikidata-Sprint-2015-04-21: Deploy subscription tracking to Wikidata - https://phabricator.wikimedia.org/T96682#1259520 (10aude) 5Open>3Resolved [00:36:07] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking, 7notice: Track Wikidata entity usage on client pages - https://phabricator.wikimedia.org/T49288#1259521 (10aude) [00:38:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1259533 (10Deskana) >>! In T97566#1256581, @Lydia_Pintscher wrote: > * Agree that usage information should not go into the descriptions. Existing descrip... [00:39:16] (03PS1) 10Aude: Wait for slaves in BulkSubscriptionUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208860 [04:06:33] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/208896 [04:10:38] (03CR) 10jenkins-bot: [V: 04-1] jenkins job validation, do not submit [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/208896 (owner: 10Legoktm) [04:11:00] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/208896 (owner: 10Legoktm) [06:24:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1259794 (10Lydia_Pintscher) It is not just about the time of my team. It is about the effort we're putting on the community as well to maintain this info... [08:35:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Better support for exact values in Quantity DataType - https://phabricator.wikimedia.org/T68580#1259887 (10daniel) @Smalyshev yes, see T72341 [08:40:42] (03PS1) 10Jonaskeutel: fix wrong autocompletion for use Statement in ConstraintChecker [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208915 [08:42:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Quantity datatype (tracking) - https://phabricator.wikimedia.org/T56318#1259896 (10daniel) [08:45:22] (03PS2) 10Jonaskeutel: fix wrong autocompletion for use Statement in ConstraintChecker [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208915 [08:51:05] (03CR) 10Dominic.sauer: [C: 032 V: 032] Fixed some scrutinizer issues. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208608 (owner: 10Soeren.oldag) [08:51:41] (03CR) 10Andreasburmeister: [C: 032 V: 032] fix wrong autocompletion for use Statement in ConstraintChecker [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208915 (owner: 10Jonaskeutel) [08:52:35] (03PS1) 10Soeren.oldag: Minor fixes for some comparers. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208919 [08:54:50] (03CR) 10Dominic.sauer: [C: 032 V: 032] Minor fixes for some comparers. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208919 (owner: 10Soeren.oldag) [09:09:53] (03PS1) 10Jonaskeutel: add ConstraintRepositoy [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208922 [09:29:35] [13WikibaseDataModelSerialization] 15Benestar closed pull request #130: Remove redundant typehint (06master...06claim-statement-typehint) 02http://git.io/vJKfW [09:31:08] (03CR) 10Bene: "Any updates on this patch?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) (owner: 10Bene) [09:31:14] (03CR) 10Bene: "Any updates on this patch?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203874 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [09:31:30] (03CR) 10Jeroen De Dauw: "What is the -1 for?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208121 (owner: 10Jeroen De Dauw) [09:32:15] jzerebecki: pfffft, y u no fun? [09:32:38] DanielK_WMDE: can you comment on this approach? https://gerrit.wikimedia.org/r/#/c/205097/1 [09:33:31] (03Abandoned) 10Jeroen De Dauw: Remove commented out code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208129 (owner: 10Jeroen De Dauw) [09:33:45] 10Wikidata, 3Wikidata-Sprint-2015-04-21: Deploy Google's primary sources tool to beta and test.wikidata - https://phabricator.wikimedia.org/T95289#1259956 (10Lydia_Pintscher) We picked this up and it is on the board but it was never added to the sprint in phabricator... [09:34:24] (03PS2) 10Jeroen De Dauw: Stop using deprecated method in SpecialSetSiteLinkTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208141 [09:35:01] (03PS2) 10Jeroen De Dauw: Use SettingsArray rather than Settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208140 [09:35:49] (03PS2) 10Jeroen De Dauw: Remove not needed call to Item::newEmpty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208152 [09:36:25] (03PS2) 10Jeroen De Dauw: Do not type hint using deprecated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208142 [09:36:29] (03CR) 10jenkins-bot: [V: 04-1] Do not type hint using deprecated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208142 (owner: 10Jeroen De Dauw) [09:37:05] (03CR) 10Jeroen De Dauw: "Because it got back an Iterator that does have a count method" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208147 (owner: 10Jeroen De Dauw) [09:37:48] (03PS2) 10Jeroen De Dauw: Stop using deprecated method in SiteLinkCommentCreatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208151 [09:38:25] (03PS2) 10Jeroen De Dauw: Add type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208156 [09:39:41] (03CR) 10Jeroen De Dauw: Remove presumably dead code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208620 (owner: 10Jeroen De Dauw) [09:40:52] (03Abandoned) 10Jeroen De Dauw: Add missing imports in OutputPageEntityIdReader [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208092 (owner: 10Jeroen De Dauw) [09:41:43] Apparently -1 are now sticky? [09:41:55] (03PS3) 10Jeroen De Dauw: Add type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208156 [09:41:57] (03PS3) 10Jeroen De Dauw: Remove not needed call to Item::newEmpty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208152 [09:42:31] (03Abandoned) 10Jeroen De Dauw: Do not type hint using deprecated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208142 (owner: 10Jeroen De Dauw) [09:45:56] (03PS2) 10Jeroen De Dauw: Remove presumably dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208620 [09:47:59] (03PS3) 10Jeroen De Dauw: Remove presumably dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208620 [10:00:17] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-05-05T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/208925 [10:15:06] [13WikibaseInternalSerialization] 15thiemowmde created 06trivial (+1 new commit): 02http://git.io/vJXKK [10:15:06] 13WikibaseInternalSerialization/06trivial 14dab8669 15Thiemo Mättig: More specific param type hints in Deserializers [10:17:53] wmde/WikibaseInternalSerialization/trivial/dab8669 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/61282143 [10:19:34] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #67: More specific param type hints in Deserializers (06master...06trivial) 02http://git.io/vJXis [10:19:59] [13Time] 15brightbyte comment on pull request #66 148051a30: Marking them as Gregorian doesn't make any more sense. It just doesn't matter. So, for consistency, it's easier to just assume anything before 1582 is Julian.... 02http://git.io/vJXiC [10:21:30] [13Time] 15brightbyte comment on pull request #66 148051a30: This test case is supposed to test that the calendar given as part of the input is used. If the input is Year 1, Julian would be assumed anyway, so the test would be inconclusive. To check whether the explicit calendar is actually used, we have to take a year that isn't Julian per default. 02http://git.io/vJXiS [10:21:57] [13WikibaseInternalSerialization] 15thiemowmde created 06legacyEntityDeserializer (+1 new commit): 02http://git.io/vJXiF [10:21:57] 13WikibaseInternalSerialization/06legacyEntityDeserializer 14ecaee02 15Thiemo Mättig: Add missing test for LegacyEntityDeserializer [10:22:41] [13Time] 15brightbyte comment on pull request #66 148051a30: Not sure why I removed this, maybe I just moved it? I'll check. 02http://git.io/vJXPL [10:23:11] [13WikibaseInternalSerialization] 15thiemowmde 04force-pushed 06legacyEntityDeserializer from 14ecaee02 to 1452a68ec: 02http://git.io/vJXPc [10:23:11] 13WikibaseInternalSerialization/06legacyEntityDeserializer 1452a68ec 15Thiemo Mättig: Add missing test for LegacyEntityDeserializer [10:23:37] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #68: Add missing exception to LegacyEntityDeserializer (06master...06legacyEntityDeserializer) 02http://git.io/vJXPB [10:23:52] [13Time] 15brightbyte comment on pull request #66 148051a30: And I see no reason to mark them as Gregorian. That just makes the heuristic more complex, more surprising, and less consistent with existing conventions. 02http://git.io/vJXPV [10:23:58] wmde/WikibaseInternalSerialization/legacyEntityDeserializer/ecaee02 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/61282885 [10:24:38] [13Time] 15brightbyte comment on pull request #66 148051a30: Probably :) 02http://git.io/vJXPF [10:25:19] [13Time] 15brightbyte comment on pull request #66 148051a30: Can do, but why? 02http://git.io/vJXX3 [10:25:38] [13WikibaseInternalSerialization] 15thiemowmde created 06doNotStore (+1 new commit): 02http://git.io/vJXXc [10:25:38] 13WikibaseInternalSerialization/06doNotStore 1466388c1 15Thiemo Mättig: Do not store serialization during deserialization [10:25:50] wmde/WikibaseInternalSerialization/legacyEntityDeserializer/52a68ec : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/61283064 [10:26:08] [13Time] 15brightbyte comment on pull request #66 148051a30: Ooops, you are right! 02http://git.io/vJXX0 [10:28:13] wmde/WikibaseInternalSerialization/doNotStore/66388c1 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/61283322 [10:28:19] 10Wikibase-Internal-Serialization, 10Wikidata, 10DataValues, 7Performance: Deserializers should not store serialization in private properties - https://phabricator.wikimedia.org/T98124#1260062 (10thiemowmde) 3NEW [10:31:00] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #69: [WIP] Do not store serialization during deserialization (06master...06doNotStore) 02http://git.io/vJX1N [10:31:05] 10Wikibase-Internal-Serialization, 10Wikidata, 10DataValues, 7Performance: Deserializers should not store serialization in private properties - https://phabricator.wikimedia.org/T98124#1260070 (10thiemowmde) WIP: https://github.com/wmde/WikibaseInternalSerialization/pull/69 [10:38:51] [13WikibaseInternalSerialization] 15Benestar pushed 1 new commit to 06master: 02http://git.io/vJXyq [10:38:51] 13WikibaseInternalSerialization/06master 14dd675a2 15Bene*: Merge pull request #68 from wmde/legacyEntityDeserializer... [10:46:21] [13WikibaseDataModel] 15Benestar 04force-pushed 06mutable-statementlist from 14f963e8c to 14b46257c: 02http://git.io/vJX9s [10:46:21] 13WikibaseDataModel/06mutable-statementlist 14b46257c 15Bene: Add mutable methods to StatementList [10:46:51] [13Time] 15brightbyte comment on pull request #66 148051a30: Because otherwise, the test would be redundant. We are trying to test that the Julian calendar in the options takes precedence over the "guessed" year. So the input has to be a year that does not default to Julian. 02http://git.io/vJX98 [10:47:51] JeroenDeDauw: u no funny much? [10:48:05] [13WikibaseDataModel] 15Benestar 04force-pushed 06mutable-statementlist from 14b46257c to 142edc952: 02http://git.io/vJX9s [10:48:05] 13WikibaseDataModel/06mutable-statementlist 142edc952 15Bene: Add mutable methods to StatementList [10:48:25] [13Time] 15brightbyte comment on pull request #66 148051a30: Seems like I actually duplicated that test case, the -00000000001 was added below. But I changed it back to make the diff look cleaner. 02http://git.io/vJX9D [10:48:29] wmde/WikibaseDataModel/mutable-statementlist/b46257c : Bene The build was broken. http://travis-ci.org/wmde/WikibaseDataModel/builds/61285534 [10:50:36] [13Time] 15brightbyte pushed 1 new commit to 06GuessCalendar-T75272: 02http://git.io/vJXHB [10:50:36] 13Time/06GuessCalendar-T75272 1431047ce 15daniel: Minor fixes for the calendar guess. [10:52:22] (03CR) 10JanZerebecki: [C: 032] Remove presumably dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208620 (owner: 10Jeroen De Dauw) [10:55:17] (03Merged) 10jenkins-bot: Remove presumably dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208620 (owner: 10Jeroen De Dauw) [10:57:33] 10Wikidata, 10MediaWiki-API, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-07: Update Wikidata for ApiResult rewrite - https://phabricator.wikimedia.org/T91073#1260106 (10JanZerebecki) If someone were to maintain a 1.25 version of Wikibase, then yes. I know of no one who wants to use it though. [11:21:32] jzerebecki: :'( [11:21:59] jzerebecki: you are totally sabotaging an improved version of the commit song Henning made [12:18:35] [13WikibaseInternalSerialization] 15thiemowmde created 06nonArrays (+1 new commit): 02http://git.io/vJ1Z5 [12:18:35] 13WikibaseInternalSerialization/06nonArrays 1469010a3 15Thiemo Mättig: Add missing exceptions to {Claim|Entity}Deserializer [12:18:55] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #70: Add missing exceptions to {Claim|Entity}Deserializer (06master...06nonArrays) 02http://git.io/vJ1Zp [12:21:25] JeroenDeDauw: we can make Thiemo happy and leave the non-sparse guarantee in StatementList::toArray [12:21:54] if we simply call array_values when *removing* a Statement, it won't cost much performance and lets this guarantee be valid [12:21:58] so all happy, right? :D [12:22:42] [13Time] 15thiemowmde comment on pull request #66 1431047ce: I disagree. Magically turning dates into Julian for years where Julian did not even existed is surprising. 02http://git.io/vJ1nA [12:23:11] [13Time] 15thiemowmde comment on pull request #66 1431047ce: To make the test independent from code it should not depend on. 02http://git.io/vJ1cT [12:24:30] (03PS1) 10Soeren.oldag: Adopted composer.json. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/208940 [12:24:32] (03CR) 10jenkins-bot: [V: 04-1] Adopted composer.json. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/208940 (owner: 10Soeren.oldag) [12:25:26] wmde/WikibaseInternalSerialization/nonArrays/69010a3 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/61295453 [12:27:27] (03Abandoned) 10Soeren.oldag: Adopted composer.json. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/208940 (owner: 10Soeren.oldag) [12:31:09] * aude waves [12:31:25] hoo: so far, subscription tracking looks good :) [12:32:13] (03PS1) 10Soeren.oldag: Adopted composer.json. [extensions/WikidataQuality] (v1) - 10https://gerrit.wikimedia.org/r/208942 [12:32:45] hi aude :) [12:32:47] Awesome [12:32:57] :) [12:33:00] I saw no alerts or follow ups, so I assume stuff is fine [12:33:03] it is [12:33:17] we'll add some more wikis tomorrow with usage + subscription tracking [12:33:20] per the deployment calendar [12:33:33] Ok [12:33:41] and more when i come back next week [12:33:41] (03PS1) 10Dominic.sauer: Add status for partial compliance. CompareResult has now a status (returned by comparer) instead of a mismatch boolean. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/208943 [12:34:00] Did you figure whether we can enable the subscription tracking w/o usage tracking? [12:34:16] i think we can but might ask daniel to be sure [12:34:26] (03PS1) 10Soeren.oldag: Adopted composer.json. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208944 [12:34:30] (03Abandoned) 10Dominic.sauer: Add status for partial compliance. CompareResult has now a status (returned by comparer) instead of a mismatch boolean. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/208943 (owner: 10Dominic.sauer) [12:34:32] as long as it is sitelinks+subscriptions [12:35:36] (03PS1) 10Soeren.oldag: Adopted composer.json. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/208945 [12:36:53] (03PS1) 10Soeren.oldag: Adopted composer.json. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208946 [12:37:10] (03PS1) 10Dominic.sauer: Add status for partial compliance. CompareResult has now a status (returned by comparer) instead of a mismatch boolean. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208948 [12:37:41] (03PS1) 10Soeren.oldag: Adopted composer.json. [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/208949 [12:42:44] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MediaWiki-API, 7Need-volunteer: Implement UnconnectedPages in the api - https://phabricator.wikimedia.org/T51137#1260309 (10XXN) p:5Normal>3High [12:43:24] 10Wikibase-DataModel, 10Wikidata: Add a method to remove statements - https://phabricator.wikimedia.org/T78299#1260313 (10thiemowmde) 5Open>3declined a:3thiemowmde [12:44:24] (03CR) 10Soeren.oldag: [C: 032 V: 032] Adopted composer.json. [extensions/WikidataQuality] (v1) - 10https://gerrit.wikimedia.org/r/208942 (owner: 10Soeren.oldag) [12:45:15] (03PS1) 10Soeren.oldag: Adopted composer.json. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/208950 [12:45:40] (03CR) 10Soeren.oldag: [C: 032 V: 032] Adopted composer.json. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/208950 (owner: 10Soeren.oldag) [12:46:12] (03CR) 10Soeren.oldag: [C: 032 V: 032] Adopted composer.json. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208946 (owner: 10Soeren.oldag) [12:46:26] (03CR) 10Soeren.oldag: [C: 032 V: 032] Adopted composer.json. [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/208949 (owner: 10Soeren.oldag) [12:46:57] (03CR) 10Soeren.oldag: [C: 032 V: 032] Adopted composer.json. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208944 (owner: 10Soeren.oldag) [12:47:17] (03CR) 10Soeren.oldag: [C: 032 V: 032] Adopted composer.json. [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/208945 (owner: 10Soeren.oldag) [12:50:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Time-Parser should detect most likely calendar - https://phabricator.wikimedia.org/T75272#1260315 (10Tobi_WMDE_SW) [12:50:41] 10Wikidata, 3Wikidata-Sprint-2015-04-21: JS time widget: add option to let the backend choose the correct calendar - https://phabricator.wikimedia.org/T96685#1260316 (10Tobi_WMDE_SW) [12:52:48] (03CR) 10Bene: [C: 04-1] Major update of ChangeOpsClaim[Remove] to get rid of Claims (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [12:54:09] 10Wikidata, 3Wikidata-Sprint-2015-04-21: Refactor Special:SpecialItemDisambiguation and the SearchEntities api to share code - https://phabricator.wikimedia.org/T96684#1260319 (10thiemowmde) [12:56:07] anyone know how capable wikidata queries are eventually going to be? [12:57:21] 10Wikidata, 3Wikidata-Sprint-2015-04-21: Refactor Special:SpecialItemDisambiguation and the SearchEntities api to share code - https://phabricator.wikimedia.org/T96684#1260326 (10thiemowmde) What is this ticket about? The two already share all code via `TermSqlIndex`. There is a little bit of set up in both cl... [12:57:57] 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: JS time widget: add option to let the backend choose the correct calendar - https://phabricator.wikimedia.org/T96685#1260327 (10Tobi_WMDE_SW) [12:59:16] 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Put sources of datamodel diagrams into the respective code repositories - https://phabricator.wikimedia.org/T96679#1260329 (10Tobi_WMDE_SW) [13:00:52] specifically, will it at some point be possible to retrieve all entities where, say, [ sum( enddate qualifier - startdate qualifier of residence (P551) statements where value has country (P17) = X ) > ( death date - birth date ) / 2 ] (or, in simple English, all people who lived in X for the majority of their lives)? [13:03:25] 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Deploy Google's primary sources tool to beta and test.wikidata - https://phabricator.wikimedia.org/T95289#1260334 (10Tobi_WMDE_SW) [13:03:42] 10Wikidata, 10Wikidata-Quality-External-Validation, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Setup CI for WikidataQualityExternalValidation - https://phabricator.wikimedia.org/T97528#1260335 (10Tobi_WMDE_SW) [13:03:54] 10Wikidata, 10Wikidata-Quality-Constraints, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Setup CI for WikidataQualityConstraints - https://phabricator.wikimedia.org/T97527#1260336 (10Tobi_WMDE_SW) [13:05:38] 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Review and polish new version of data model primer - https://phabricator.wikimedia.org/T96681#1260338 (10Tobi_WMDE_SW) [13:05:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Documentation, 3Wikidata-Sprint-2015-04-07, and 2 others: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1260340 (10Tobi_WMDE_SW) [13:06:31] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Usage tracking update / purging on edit and re-parse - https://phabricator.wikimedia.org/T96373#1260346 (10Tobi_WMDE_SW) [13:06:59] 10Wikidata, 10Wikimedia-Extension-setup, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Install Graph extension on beta Wikidata - https://phabricator.wikimedia.org/T97993#1260349 (10JanZerebecki) [13:07:01] (03CR) 10Thiemo Mättig (WMDE): "The OCP violation is not introduced by this patch. Please remove your -1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [13:08:49] (03CR) 10Bene: "I cannot find any `instanceof Item` or `instanceof Property` conditions in the existing code so this got somehow worse in this patch." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [13:10:56] (03PS10) 10Thiemo Mättig (WMDE): Edit References along with Statement [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190799 (https://phabricator.wikimedia.org/T87759) (owner: 10Henning Snater) [13:26:28] 10Wikidata, 10Datasets-General-or-Unknown, 6operations, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21: Wikidata dumps contain old-style serialization. - https://phabricator.wikimedia.org/T74348#1260398 (10JanZerebecki) a:5hoo>3daniel What pattern can one search for to find old serialization? [13:28:58] 10Wikibase-DataModel-Serialization, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1260403 (10JanZerebecki) 5Open>3Resolved [13:29:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Support new types of Entities in Wikibase Repository - https://phabricator.wikimedia.org/T75496#1260404 (10JanZerebecki) [13:30:00] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Replace ClaimsSerializer by StatementListSerializer - https://phabricator.wikimedia.org/T78650#1260405 (10JanZerebecki) 5Open>3Resolved [13:31:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21: Decide on implement of Unit Selector widget - https://phabricator.wikimedia.org/T77982#1260406 (10Tobi_WMDE_SW) [13:31:57] 10Wikidata, 10Wikimedia-Extension-setup, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Install Graph extension on beta Wikidata - https://phabricator.wikimedia.org/T97993#1260408 (10JanZerebecki) a:3JanZerebecki [13:35:19] (03CR) 10JanZerebecki: [C: 032] Add empty span for indicators to the snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207449 (https://phabricator.wikimedia.org/T95403) (owner: 10Thiemo Mättig (WMDE)) [13:36:36] 10Wikidata, 10Wikidata-Quality, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Setup CI for WikidataQuality - https://phabricator.wikimedia.org/T97529#1260415 (10Tobi_WMDE_SW) [13:36:45] 10Wikidata, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Fix browsertests for rank-, snaktype- and badge-selectors - https://phabricator.wikimedia.org/T95291#1260416 (10Tobi_WMDE_SW) [13:36:52] 10Wikidata, 7Schema-change, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Deploy schema changes to wbc_entity_usage table on wikidatawiki - https://phabricator.wikimedia.org/T95179#1260417 (10Tobi_WMDE_SW) [13:37:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Investigation: UI breaks on UnDeserializable value. - https://phabricator.wikimedia.org/T92975#1260418 (10Tobi_WMDE_SW) [13:37:20] 10Wikidata, 10Datasets-General-or-Unknown, 6operations, 3Wikidata-Sprint-2015-04-07, and 2 others: Wikidata dumps contain old-style serialization. - https://phabricator.wikimedia.org/T74348#1260419 (10Tobi_WMDE_SW) a:5daniel>3hoo [13:37:26] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Database query error on [[Special:UnconnectedPages]] - https://phabricator.wikimedia.org/T74696#1260421 (10Tobi_WMDE_SW) [13:39:22] (03Merged) 10jenkins-bot: Add empty span for indicators to the snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207449 (https://phabricator.wikimedia.org/T95403) (owner: 10Thiemo Mättig (WMDE)) [13:39:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Decide on implement of Unit Selector widget - https://phabricator.wikimedia.org/T77982#1260433 (10Tobi_WMDE_SW) [13:41:22] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Wikidata-Sprint-2015-05-05: Implement tracking of label use per parser target language - https://phabricator.wikimedia.org/T93055#1260437 (10Tobi_WMDE_SW) [13:41:33] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Wikidata-Sprint-2015-05-05: Include fallback languages in label tracking. - https://phabricator.wikimedia.org/T93056#1260439 (10Tobi_WMDE_SW) [13:42:19] 10Wikidata, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Comparison of the existing Wikidata RDF dumps - https://phabricator.wikimedia.org/T95316#1260443 (10Tobi_WMDE_SW) [13:42:26] 10Wikidata, 10Wikimedia-Extension-setup, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Install Graph extension on beta Wikidata - https://phabricator.wikimedia.org/T97993#1260444 (10Tobi_WMDE_SW) [13:48:32] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06dm3 from 14eb0754a to 14b49b8b4: 02http://git.io/hbqQ [13:48:32] 13WikibaseDataModelSerialization/06dm3 14b49b8b4 15jeroendedauw: Switch from DataModel 2.x to 3.x [13:49:38] wmde/WikibaseDataModelSerialization/dm3/b49b8b4 : jeroendedauw The build was broken. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/61307564 [13:54:14] (03CR) 10Jeroen De Dauw: Major update of ChangeOpsClaim[Remove] to get rid of Claims (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [13:54:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Regression, 3Wikidata-Sprint-2015-05-05: property label doesn't scroll with viewport anymore - https://phabricator.wikimedia.org/T94588#1260476 (10Tobi_WMDE_SW) [13:54:39] 10Wikidata, 3Wikidata-Sprint-2015-05-05: Create place to put common Wikibase services - https://phabricator.wikimedia.org/T93741#1260478 (10Tobi_WMDE_SW) [13:56:28] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Add methods to remove Statements a StatementList - https://phabricator.wikimedia.org/T98143#1260480 (10Bene) 3NEW [13:57:31] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #470 142edc952: As far as I can tell, the equivalent method in `Claims` is actually never used. Removing a Statement by GUID is however something currently done, with this commit proving we have use for such a method: https://gerrit.wikimedia.org/r/#/c/204511/ 02http://git.io/vJ1pL [13:58:15] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Add methods to remove Statements from a StatementList - https://phabricator.wikimedia.org/T98143#1260490 (10Bene) [13:58:30] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Add methods to remove Statements from a StatementList - https://phabricator.wikimedia.org/T98143#1260480 (10Bene) a:3Bene [14:01:21] [13WikibaseDataModel] 15Benestar comment on pull request #470 142edc952: Ok, so this should rather be a `removeByGuid` method I see now. I will update the PR accordingly. Thanks for the notice Jeroen :-) 02http://git.io/vJ1jt [14:03:46] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #470 142edc952: Actually I think it is best to create a dedicated PR for adding that method and one for the `clear` one. So a -2 for one method does not block the other 02http://git.io/vJMeo [14:08:09] [13WikibaseDataModel] 15Benestar comment on pull request #470 142edc952: Agreed. 02http://git.io/vJMJn [14:09:38] jzerebecki: https://gerrit.wikimedia.org/r/#/c/208121/ ??????????????? [14:10:28] (03CR) 10Thiemo Mättig (WMDE): "An OCP violation is not bound to an "instanceof" in the code. Please remove your -1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [14:10:32] [13WikibaseDataModel] 15Benestar 04force-pushed 06mutable-statementlist from 142edc952 to 145cc1982: 02http://git.io/vJX9s [14:10:32] 13WikibaseDataModel/06mutable-statementlist 145cc1982 15Bene: Add removeStatementsByGuid and hasStatementWithGuid [14:13:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Entity pages should link to machine readable version using tags in the html head - https://phabricator.wikimedia.org/T96298#1260555 (10Tobi_WMDE_SW) [14:13:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Include redirects in RDF rendering. - https://phabricator.wikimedia.org/T69033#1260557 (10Tobi_WMDE_SW) [14:15:56] [13WikibaseDataModel] 15Benestar closed pull request #470: Add removeStatementsByGuid and hasStatementWithGuid to StatementList (06master...06mutable-statementlist) 02http://git.io/vJ61s [14:17:22] JeroenDeDauw: did you see my comment on the patch? [14:18:20] jzerebecki: no? [14:18:27] jzerebecki: you sure you submitted it? [14:21:01] [13WikibaseDataModel] 15Benestar created 06removestatementswithguid (+1 new commit): 02http://git.io/vJMqL [14:21:01] 13WikibaseDataModel/06removestatementswithguid 14a5b3592 15Bene: Add StatementList::removeStatementsWithGuid [14:21:11] [13WikibaseDataModel] 15Benestar opened pull request #471: Add StatementList::removeStatementsWithGuid (06master...06removestatementswithguid) 02http://git.io/vJMqW [14:21:41] benestar: byGuid ;p [14:21:53] oh :O [14:21:54] nowait [14:21:55] (03CR) 10Sumit: "Minor issues I'll fix in a follow up" (032 comments) [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/208096 (https://phabricator.wikimedia.org/T94772) (owner: 10Sumit) [14:22:16] getFirstStatementByGuid [14:22:39] getWithPropertyId [14:22:40] ... [14:22:52] Thought we had settled on "by" for this class tho [14:22:58] Think it does not matter a lot tho [14:23:12] SInce you will look at removeStatement anyway [14:23:18] Lydia_WMDE: around? [14:23:21] getWithUniqueMainSnaks getWithPropertyId [14:23:27] getWithRank [14:23:58] wmde/WikibaseDataModel/removestatementswithguid/a5b3592 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/61312088 [14:24:33] JeroenDeDauw: i think ...with... is used more widely [14:24:41] (03CR) 10Jeroen De Dauw: "Are you unhappy with the message? Think it's inaccurate? I'm not sure how it is bad. Please either point out the issue or provide an alter" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208121 (owner: 10Jeroen De Dauw) [14:25:03] so perhaps we should rather rename getFirstStatementByGuid to getFirstStatementWithGuid [14:26:43] [13WikibaseDataModel] 15Benestar created 06getfirststatementwithguid (+1 new commit): 02http://git.io/vJMYV [14:26:43] 13WikibaseDataModel/06getfirststatementwithguid 142b7b0eb 15Bene: Use With instead of By for consistency in this class [14:28:34] [13WikibaseDataModel] 15Benestar opened pull request #472: Use With instead of By for consistency in this class (06master...06getfirststatementwithguid) 02http://git.io/vJMOZ [14:29:27] JeroenDeDauw: it was submitted with my -1, i'll copy it here: "The comment is somewhat right, EntityId does not provide that function." [14:29:50] wmde/WikibaseDataModel/getfirststatementwithguid/2b7b0eb : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/61313046 [14:31:19] gah.... [14:31:27] jzerebecki: I do not understand what that means [14:31:35] * aude is misspelling "snacks" now [14:31:35] How is it somewhat wrong then? [14:31:39] aude: around now [14:31:49] Lydia_WMDE: did you see my mail? [14:32:06] aude: looking now [14:33:51] ok [14:34:32] aude: about arbitrary access? i think we are good to go for a first wiki. i'll check with daniel quickly when he is back to make sure it is all good from his side too [14:34:48] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Add methods to remove Statements from a StatementList - https://phabricator.wikimedia.org/T98143#1260641 (10thiemowmde) p:5Triage>3Low I disagree that "we need" such a method. None of the proposed changes does solve the u... [14:34:49] Lydia_WMDE: i would like to to arbitrary access on monday [14:34:58] only usage tracking tomorrow [14:35:02] ok [14:35:09] * aude is not around all day tomorrow [14:35:09] then i need to prepare messaging [14:35:21] and we should announce that a bit in advance [14:35:22] JeroenDeDauw: doh! i was reading the diff inverted. [14:35:27] per my mail, i was thinking hewiki + fawiki + enwikivoyage this time [14:35:31] 10Wikibase-DataModel, 10Wikidata: Add methods to remove Statements from a StatementList - https://phabricator.wikimedia.org/T98143#1260647 (10thiemowmde) [14:35:33] since they are not quite as big [14:35:40] aude: for usage tracking? ok [14:35:46] aude: and for arbitrary access on monday? [14:35:47] ok [14:35:59] for monday, nlwiki and frwikisource? [14:36:24] ok from my side [14:36:28] + more usage tracking, maybe start enabling then for a sister project (e.g. all of wikisource) [14:36:32] (03CR) 10JanZerebecki: [C: 032] "I read the diff inverted so your patch fixes my comment :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208121 (owner: 10Jeroen De Dauw) [14:36:52] i think we should do arbitrary access alone the first time [14:36:55] ok [14:36:56] in case something blows up [14:36:58] ok? [14:36:59] k [14:37:04] (03CR) 10JanZerebecki: "s/fixes/notes as a comment/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208121 (owner: 10Jeroen De Dauw) [14:37:18] and then next batch can be all of wikisource [14:37:21] ok [14:37:42] * aude wants to get it all done by wikimania (e.g. mid-june when i am gone) [14:37:51] *nod* [14:37:55] makes sense [14:38:13] anyway, i am off for a few hours [14:38:17] cya :) [14:38:18] [13WikibaseDataModel] 15thiemowmde comment on pull request #471 14a5b3592: This is not a getter, why does it return anything? 02http://git.io/vJMZz [14:38:21] will try to be back for deployment [14:38:25] ok [14:38:26] [13WikibaseDataModel] 15thiemowmde comment on pull request #471 14a5b3592: `string|null` 02http://git.io/vJMZa [14:40:29] [13WikibaseDataModel] 15thiemowmde comment on pull request #471 14a5b3592: Inconsistent naming, see `StatementByGuidMap`. 02http://git.io/vJMnW [14:41:20] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #471 14a5b3592: Yep, should not do the return... 02http://git.io/vJMn5 [14:43:17] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #471 14a5b3592: Please create dedicated test method for different behaviours.... 02http://git.io/vJMc6 [14:43:50] jzerebecki: facepalm dot yaypeg [14:48:33] (03PS1) 10Sumit: WikidataPageBanner minor issues fixed [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/208961 [14:50:20] (03PS2) 10Sumit: WikidataPageBanner minor issues fixed [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/208961 [14:53:45] [13WikibaseDataModel] 15Benestar 04force-pushed 06removestatementswithguid from 14a5b3592 to 14ae12202: 02http://git.io/vJMBL [14:53:46] 13WikibaseDataModel/06removestatementswithguid 14ae12202 15Bene: Add StatementList::removeStatementsWithGuid [14:53:46] (03PS1) 10Soeren.oldag: Added wikibase dependency. [extensions/WikidataQuality] (v1) - 10https://gerrit.wikimedia.org/r/208963 [14:53:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Server-side rendering for all property links in the JS UI - https://phabricator.wikimedia.org/T88426#1260708 (10thiemowmde) Possibly relevant line of code: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/view/res... [14:54:15] (03CR) 10Andreasburmeister: [C: 032 V: 032] add ConstraintRepositoy (031 comment) [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208922 (owner: 10Jonaskeutel) [14:54:34] (03PS1) 10Soeren.oldag: Added git repository to composer.json. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208964 [14:54:50] (03PS1) 10Soeren.oldag: Added git repository to composer.json. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208965 [14:54:55] (03PS1) 10Jonaskeutel: introducing the Constraint class [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208966 [14:55:15] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Add methods to remove Statements from a StatementList - https://phabricator.wikimedia.org/T98143#1260713 (10Bene) I actually guess I understand the problem and the issue is described in this task very clear. [14:55:17] (03CR) 10Soeren.oldag: [C: 032 V: 031] Added wikibase dependency. [extensions/WikidataQuality] (v1) - 10https://gerrit.wikimedia.org/r/208963 (owner: 10Soeren.oldag) [14:55:29] (03CR) 10Soeren.oldag: [C: 032 V: 031] Added git repository to composer.json. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208964 (owner: 10Soeren.oldag) [14:55:38] (03CR) 10Soeren.oldag: [V: 032] Added git repository to composer.json. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208964 (owner: 10Soeren.oldag) [14:55:51] (03CR) 10Soeren.oldag: [C: 032 V: 032] Added git repository to composer.json. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208965 (owner: 10Soeren.oldag) [14:55:56] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21: Add methods to remove Statements from a StatementList - https://phabricator.wikimedia.org/T98143#1260715 (10Bene) p:5Low>3Normal [14:58:10] (03CR) 10Bene: [C: 031] "Looks good, one nitpick." (031 comment) [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/208961 (owner: 10Sumit) [15:00:00] (03PS1) 10Soeren.oldag: Now using anonymous git url. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208968 [15:00:16] (03PS1) 10Soeren.oldag: Now using anonymous git url. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208969 [15:00:48] (03CR) 10Soeren.oldag: [C: 032 V: 032] Now using anonymous git url. [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208969 (owner: 10Soeren.oldag) [15:00:55] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vJMuG [15:00:55] 13WikibaseDataModel/06master 14a25d095 15Jeroen De Dauw: Merge pull request #471 from wmde/removestatementswithguid... [15:00:56] (03CR) 10Soeren.oldag: [C: 032 V: 032] Now using anonymous git url. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/208968 (owner: 10Soeren.oldag) [15:02:58] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06master: 02http://git.io/vJMzC [15:02:58] 13WikibaseDataModel/06master 14ff9e037 15Bene*: Added StatementList::removeStatementsWithGuid [15:04:19] [13WikibaseDataModel] 15Benestar closed pull request #472: Use With instead of By for consistency in this class (06master...06getfirststatementwithguid) 02http://git.io/vJMOZ [15:04:34] [13WikibaseDataModel] 15Benestar reopened pull request #472: Use With instead of By for consistency in this class (06master...06getfirststatementwithguid) 02http://git.io/vJMOZ [15:08:37] [13WikibaseDataModel] 15JeroenDeDauw created 06addtest (+1 new commit): 02http://git.io/vJM21 [15:08:37] 13WikibaseDataModel/06addtest 1449180fd 15jeroendedauw: Add extra test for statement by guid removal method [15:10:29] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/vJMaK [15:10:29] 13WikibaseDataModel/06master 142b7b0eb 15Bene: Use With instead of By for consistency in this class [15:10:29] 13WikibaseDataModel/06master 14714f512 15Jeroen De Dauw: Merge pull request #472 from wmde/getfirststatementwithguid... [15:10:50] benestar: https://github.com/wmde/WikibaseDataModel/pull/473 [15:12:42] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vJMVi [15:12:42] 13WikibaseDataModel/06master 1469f6c6c 15jeroendedauw: Update release notes... [15:13:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Better support for exact values in Quantity DataType - https://phabricator.wikimedia.org/T68580#1260738 (10Izno) There needs to be a precision unknown or precision unspecified as default, not any arbitrary value, +-1, +-0, or any other number. That's the m... [15:14:37] (03PS2) 10Jonaskeutel: introducing the Constraint class [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208966 [15:18:00] [13WikibaseDataModel] 15Benestar closed pull request #455: Add `setStatements` to `StatementListProvider` (06master...06setstatements) 02http://git.io/vfURl [15:18:35] [13WikibaseDataModel] 15Benestar 04deleted 06setstatements at 145f73dbb: 02http://git.io/vJMK6 [15:27:09] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06master: 02http://git.io/vJMMq [15:27:09] 13WikibaseDataModel/06master 143cd4d1e 15Bene*: Merge pull request #473 from wmde/addtest... [15:34:02] (03CR) 10JanZerebecki: [C: 032] New Wikidata Build - 2015-05-05T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/208925 (owner: 10WikidataBuilder) [15:37:36] (03Merged) 10jenkins-bot: New Wikidata Build - 2015-05-05T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/208925 (owner: 10WikidataBuilder) [15:38:44] (03PS1) 10Gilles: Explicitly define module position [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208982 (https://phabricator.wikimedia.org/T97410) [16:09:46] 10Wikidata, 10Gather, 6Mobile-Web: setHTMLTitle to empty string or false should prevent rendering of H1 on page - https://phabricator.wikimedia.org/T97891#1260860 (10Florian) >>! In T97891#1258140, @Jdlrobson wrote: > Do we have an appropriate project for skin architecture @matmarex? #mediawiki-interface ? :) [16:21:36] (03PS1) 10Daniel Kinzler: Introduce EntityRedirectLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208989 (https://bugzilla.wikimedia.org/69033) [16:30:40] (03PS1) 10Daniel Kinzler: Move getRedirectForEntityId to EntityRedirectLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208992 [16:59:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Create a new datatype "count" similar to "quantity". - https://phabricator.wikimedia.org/T72341#1261003 (10Smalyshev) With regard to RDF export, it would be nice if changing property would generate some kind of recentchanges entry, so that the importing to... [17:02:00] (03PS2) 10Daniel Kinzler: Introduce EntityRedirectLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208989 (https://bugzilla.wikimedia.org/69033) [17:03:12] (03PS2) 10Daniel Kinzler: Move getRedirectForEntityId to EntityRedirectLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208992 [17:04:39] 10Wikidata, 6Release-Engineering, 7Composer: enable use of production deployed autoloader for extensions that is created by composer - https://phabricator.wikimedia.org/T97560#1261011 (10JanZerebecki) [17:06:15] 10Wikidata, 6Release-Engineering, 7Composer: enable use of a composer created autoloader in extensions deployed to production - https://phabricator.wikimedia.org/T97560#1261023 (10JanZerebecki) [17:19:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Create a new datatype "count" similar to "quantity". - https://phabricator.wikimedia.org/T72341#1261058 (10JanZerebecki) Yes, if we do such changes to the datatype of a property they really need to be record like an edit (with an entry in recentchanges and... [17:25:30] (03CR) 10JanZerebecki: [C: 032] Remove not needed call to Item::newEmpty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208152 (owner: 10Jeroen De Dauw) [17:25:53] (03CR) 10JanZerebecki: [C: 032] Add type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208156 (owner: 10Jeroen De Dauw) [17:26:36] (03CR) 10JanZerebecki: [C: 032] Stop using deprecated method in SiteLinkCommentCreatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208151 (owner: 10Jeroen De Dauw) [17:26:59] 10Wikidata: Split EntityDataSerializationService into EntityDataSerializers and an EntityDataSerializerFactory - https://phabricator.wikimedia.org/T98169#1261083 (10daniel) [17:27:08] (03CR) 10JanZerebecki: [C: 032] Iterator does not have a count method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208147 (owner: 10Jeroen De Dauw) [17:28:20] Lydia_WMDE: You can add the Frick Collection and the Brooklyn Museum to the weekly report. Both have their paintings on Wikidata now :-) [17:28:49] multichill: \o/ [17:28:58] multichill: you can also add them yourself if you want to btw [17:30:27] (03CR) 10JanZerebecki: [C: 032] Use SettingsArray rather than Settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208140 (owner: 10Jeroen De Dauw) [17:30:35] (03Merged) 10jenkins-bot: Remove not needed call to Item::newEmpty [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208152 (owner: 10Jeroen De Dauw) [17:31:42] (03CR) 10JanZerebecki: [C: 032] Stop using deprecated method in SpecialSetSiteLinkTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208141 (owner: 10Jeroen De Dauw) [17:33:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Decide on implementation of Unit Selector widget - https://phabricator.wikimedia.org/T77982#1261105 (10Tobi_WMDE_SW) [17:33:07] JeroenDeDauw: was tempted to -1 that one with: my comment was not addressed, commit message is still not funny enough :P [17:33:30] (03Merged) 10jenkins-bot: Add type hint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208156 (owner: 10Jeroen De Dauw) [17:33:33] (03Merged) 10jenkins-bot: Stop using deprecated method in SiteLinkCommentCreatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208151 (owner: 10Jeroen De Dauw) [17:33:36] (03Merged) 10jenkins-bot: Iterator does not have a count method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208147 (owner: 10Jeroen De Dauw) [17:36:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Implement Unit Selector widget - https://phabricator.wikimedia.org/T98172#1261111 (10Tobi_WMDE_SW) 3NEW [17:37:27] (03Merged) 10jenkins-bot: Use SettingsArray rather than Settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208140 (owner: 10Jeroen De Dauw) [17:37:31] (03Merged) 10jenkins-bot: Stop using deprecated method in SpecialSetSiteLinkTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208141 (owner: 10Jeroen De Dauw) [17:38:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: QuantityValueParser: Allow unit to be specified via options - https://phabricator.wikimedia.org/T77981#1261121 (10Tobi_WMDE_SW) [17:38:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Decide on implementation of Unit Selector widget - https://phabricator.wikimedia.org/T77982#1261119 (10Tobi_WMDE_SW) [17:38:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Implement Unit Selector widget - https://phabricator.wikimedia.org/T98172#1261111 (10Tobi_WMDE_SW) [17:38:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Decide on implementation of Unit Selector widget - https://phabricator.wikimedia.org/T77982#833300 (10Tobi_WMDE_SW) [17:38:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: QuantityValueParser: Allow unit to be specified via options - https://phabricator.wikimedia.org/T77981#833288 (10Tobi_WMDE_SW) [17:48:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-07, and 2 others: Allow simultaneous editing of mainsnak and references - https://phabricator.wikimedia.org/T87759#1261161 (10Tobi_WMDE_SW) [17:49:18] 10Wikidata, 3Wikidata-Sprint-2015-05-05: [RFC] Create place to put common Wikibase services - https://phabricator.wikimedia.org/T93741#1261174 (10Tobi_WMDE_SW) [17:49:47] (03PS1) 10Daniel Kinzler: Include incomung redirects in RDF output of Special:EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209012 (https://bugzilla.wikimedia.org/69033) [17:49:51] 10Wikidata, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Put sources of datamodel diagrams into the respective code repositories - https://phabricator.wikimedia.org/T96679#1261182 (10Tobi_WMDE_SW) a:5Snaterlicious>3None [17:51:56] (03PS2) 10Daniel Kinzler: Include incoming redirects in RDF output of Special:EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209012 (https://bugzilla.wikimedia.org/69033) [17:59:38] [13WikibaseDataModel] 15thiemowmde comment on pull request #471 14ae12202: Why did you removed the `array_values`? Now this messes with the indexes. 02http://git.io/vJyIz [18:00:38] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Create a special page to query for badges - https://phabricator.wikimedia.org/T72209#1261389 (10Lydia_Pintscher) Sorry I missed this. Ricordisamoa: What would you configure with this? [18:01:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Create a special page to query for badges - https://phabricator.wikimedia.org/T72209#1261402 (10Lydia_Pintscher) Helder: Bene was working on the task that is blocking this one. So some progress is being made. [18:06:41] 10Wikibase-DataModel, 10Wikidata: Fix inconsistent With vs. By naming in DataModel - https://phabricator.wikimedia.org/T98180#1261527 (10thiemowmde) 3NEW [18:07:46] (03CR) 10Smalyshev: Introduce EntityRedirectLookup interface (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208989 (https://bugzilla.wikimedia.org/69033) (owner: 10Daniel Kinzler) [18:08:29] 10Wikibase-DataModel, 10Wikidata: Fix inconsistent With vs. By naming in DataModel - https://phabricator.wikimedia.org/T98180#1261557 (10thiemowmde) [18:08:31] 10Wikidata, 7Tracking: Use Wikibase/DataModel 3.0 (tracking) - https://phabricator.wikimedia.org/T96602#1261556 (10thiemowmde) [18:08:32] multichill: done https://www.wikidata.org/w/index.php?title=Wikidata:Status_updates/Next&diff=214357204&oldid=214312159 [18:12:49] [13WikibaseDataModel] 15thiemowmde comment on pull request #473 1449180fd: "Presen"? 02http://git.io/vJy3c [18:13:08] (03CR) 10Smalyshev: [C: 032] Introduce EntityRedirectLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208989 (https://bugzilla.wikimedia.org/69033) (owner: 10Daniel Kinzler) [18:13:09] [13WikibaseDataModel] 15thiemowmde comment on pull request #473 1449180fd: "Mulitple"? And merged? What type of code review is that? 02http://git.io/vJy30 [18:16:25] (03Merged) 10jenkins-bot: Introduce EntityRedirectLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208989 (https://bugzilla.wikimedia.org/69033) (owner: 10Daniel Kinzler) [18:17:23] 10Wikidata, 10Datasets-General-or-Unknown, 6operations, 3Wikidata-Sprint-2015-04-07, and 2 others: Wikidata dumps contain old-style serialization. - https://phabricator.wikimedia.org/T74348#1261805 (10daniel) @JanZerebecki: Redirects are serialized like this: {"entity":"Q23","redirect":"Q42"} Old style... [18:17:32] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06revert-459-toarray from 1462c3547 to 14abfbbb7: 02http://git.io/vJyZW [18:17:32] 13WikibaseDataModel/06revert-459-toarray 14f4c3e06 15Thiemo Mättig: Revert "Alter guarantees provided by StatementList::toArray" [18:17:32] 13WikibaseDataModel/06revert-459-toarray 14abfbbb7 15Thiemo Mättig: Fix method introduced in #471 [18:18:55] (03CR) 10Daniel Kinzler: Introduce EntityRedirectLookup interface (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208989 (https://bugzilla.wikimedia.org/69033) (owner: 10Daniel Kinzler) [18:19:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: ErrorException from line 584 of EntityHandler.php - https://phabricator.wikimedia.org/T98182#1261812 (10aude) 3NEW [18:20:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: ErrorException from line 584 of EntityHandler.php - https://phabricator.wikimedia.org/T98182#1261823 (10aude) but is easily reproducable [18:23:34] 10Wikidata, 10Datasets-General-or-Unknown, 6operations, 3Wikidata-Sprint-2015-04-07, and 2 others: Wikidata dumps contain old-style serialization. - https://phabricator.wikimedia.org/T74348#1261851 (10daniel) Btw, if someone can tell me where to find a full history dump of wikidata, I'd be happy to check t... [18:25:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: ErrorException from line 584 of EntityHandler.php - https://phabricator.wikimedia.org/T98182#1261857 (10aude) any undo on an item causes this if the "title=Q##" is omitted from the url. e.g. http://www.wikidata.org/w/index.php?action=edit&undoafter=21007... [18:31:47] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: UsageTrackerException from line 130 of SqlUsageTracker.php - https://phabricator.wikimedia.org/T98186#1261902 (10aude) 3NEW [18:32:06] hmmm.... bugs [18:32:25] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: UsageTrackerException from line 130 of SqlUsageTracker.php - https://phabricator.wikimedia.org/T98186#1261911 (10aude) p:5Triage>3High [18:33:39] can't save pages :( [18:34:18] suspect it has to do with the schema change not applied [18:38:33] (03CR) 10Smalyshev: [C: 032] Move getRedirectForEntityId to EntityRedirectLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208992 (owner: 10Daniel Kinzler) [18:42:15] (03Merged) 10jenkins-bot: Move getRedirectForEntityId to EntityRedirectLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208992 (owner: 10Daniel Kinzler) [18:44:42] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: UsageTrackerException from line 130 of SqlUsageTracker.php - https://phabricator.wikimedia.org/T98186#1261953 (10aude) can reproduce Exception Caught: A database error has occurred. Did you forget to run maintenance/update.php after upgrading? See: https://w... [18:51:41] (03PS1) 10Aude: Check if eu_touched field exists [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) [18:56:56] (03PS2) 10Aude: Check if eu_touched field exists [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) [18:57:21] DanielK_WMDE_: jzerebecki ^ [18:58:34] aude: why would we want to populate the table before aplying the schema update? [18:58:46] * DanielK_WMDE_ is about to leave the office [18:59:25] DanielK_WMDE_: what are you talking about? [18:59:49] this is just for saving pages that have usage tracking already [18:59:53] worked yesterday [19:00:00] worked an hour ago [19:00:20] (03CR) 10jenkins-bot: [V: 04-1] Check if eu_touched field exists [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) (owner: 10Aude) [19:00:21] wikidata is the only wiki that doesn't have the schema update yet :( [19:00:25] aude: oh, this is not the schema updater. sorry [19:00:26] gah...... jenkins [19:00:28] yeah [19:00:38] will look at it tomorrow [19:00:45] DanielK_WMDE_: needs to be backported now [19:00:50] but someone else can review [19:01:10] need to see why jenkins is complaining anyway [19:01:13] backported? i don't see the change on master [19:01:16] qunit [19:01:24] DanielK_WMDE_: i didn't put it there yet [19:01:43] branch only now [19:01:56] maybe the schema change gets applied this week (hopefully) and we don't need it on master [19:02:29] aude: fieldExists is expensive. This patch calls it a *lot* [19:02:37] it runs a query every time, afaik [19:03:10] :/ [19:03:18] oh shit, not even against the schema [19:03:19] it runs this->query( "SELECT * FROM $table LIMIT 1", __METHOD__, true ); [19:03:36] i could make a setting if you prefer [19:03:48] * aude hates yet more settings [19:03:50] * jzerebecki is fixing that jenkins slave which made it -1 [19:03:50] but if it's better [19:03:56] jzerebecki: thanks [19:03:57] yea... but i assumed we'd deploy the schema change before the code [19:04:07] DanielK_WMDE_: apparently not [19:04:16] *sigh* [19:04:23] * aude needs to poke sean again [19:04:41] idk why it takes so long [19:04:55] aude: at least remember whether we have the field inside the updater object [19:05:01] ok [19:05:08] that already reduces the number of queries by an order of magnitude or two [19:05:13] ok [19:05:48] could also go into accellerator cache, but don't ask me how to best do that. also, a lot of overkill of a temp hack [19:05:55] ok for the branch, but not for master [19:07:13] (03PS1) 10Aude: Check if eu_touched field exists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209033 (https://phabricator.wikimedia.org/T98186) [19:07:17] there [19:07:35] * aude just needs it fixed now [19:07:43] and will more urgently poke sean [19:07:44] (03CR) 10JanZerebecki: "Jenkins failure was unrelated and caused by old state on that slave, which I removed. Should work again." [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) (owner: 10Aude) [19:08:19] * aude verified manually [19:10:47] (03CR) 10Smalyshev: "Bug: link in message seems to be leading to something totally unrelated." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209012 (https://bugzilla.wikimedia.org/69033) (owner: 10Daniel Kinzler) [19:11:02] 10Wikidata, 7Schema-change, 3Wikidata-Sprint-2015-04-07, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Deploy schema changes to wbc_entity_usage table on wikidatawiki - https://phabricator.wikimedia.org/T95179#1262045 (10aude) this is becoming more urgent. we had T98186 due to the schema cha... [19:11:50] gah [19:12:18] (03PS3) 10Daniel Kinzler: Include incoming redirects in RDF output of Special:EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209012 (https://phabricator.wikimedia.org/T69033) [19:12:33] aude: can you update https://gerrit.wikimedia.org/r/#/c/209029 with the variant from master then i'd merge, as DanielK_WMDE_ doesn't want it on master [19:12:35] somehow i submitted it to master [19:13:11] (03PS3) 10Aude: Check if eu_touched field exists [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) [19:13:49] (03CR) 10Aude: [C: 04-2] "branch only for now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209033 (https://phabricator.wikimedia.org/T98186) (owner: 10Aude) [19:14:55] (03CR) 10Smalyshev: Include incoming redirects in RDF output of Special:EntityData (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209012 (https://phabricator.wikimedia.org/T69033) (owner: 10Daniel Kinzler) [19:15:28] (03CR) 10JanZerebecki: [C: 031] "Please merge." [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) (owner: 10Aude) [19:15:37] (03CR) 10Daniel Kinzler: [C: 031] Check if eu_touched field exists [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) (owner: 10Aude) [19:15:38] 10Wikidata, 10DataValues: Date parser does not allow February 29, 1700 (Julian) - https://phabricator.wikimedia.org/T98194#1262067 (10thiemowmde) 3NEW [19:15:43] ok :) [19:15:44] thanks [19:16:08] (03CR) 10Aude: [C: 032] "per code review" [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) (owner: 10Aude) [19:16:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3Wikidata-Sprint-2015-04-21, 3Wikidata-Sprint-2015-05-05: Time-Parser should detect most likely calendar - https://phabricator.wikimedia.org/T75272#756075 (10thiemowmde) The guessing algorithm must be in line with the formatter we... [19:16:27] * jzerebecki out [19:16:31] ok [19:16:40] i think that's the only important issue [19:16:49] ok, going offline now [19:16:52] thanks aude! [19:17:13] see you! [19:19:15] (03Merged) 10jenkins-bot: Check if eu_touched field exists [extensions/Wikibase] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209029 (https://phabricator.wikimedia.org/T98186) (owner: 10Aude) [19:19:53] (03CR) 10Smalyshev: Include incoming redirects in RDF output of Special:EntityData (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209012 (https://phabricator.wikimedia.org/T69033) (owner: 10Daniel Kinzler) [19:21:17] (03CR) 10Smalyshev: [C: 031] "looks ok, some small typos" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209012 (https://phabricator.wikimedia.org/T69033) (owner: 10Daniel Kinzler) [19:23:29] (03PS1) 10Aude: Update Wikidata, check for schema change in UsageTableUpdater [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209037 [19:24:17] (03CR) 10Aude: [C: 032] Update Wikidata, check for schema change in UsageTableUpdater [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209037 (owner: 10Aude) [19:27:36] (03Merged) 10jenkins-bot: Update Wikidata, check for schema change in UsageTableUpdater [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/209037 (owner: 10Aude) [19:32:01] (03CR) 10Aude: "ideally want this before we deploy this further tomorrow." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208860 (owner: 10Aude) [19:42:26] deployed! [19:42:35] problem should be fixed now [19:43:25] hmmm [19:43:31] oh [19:43:36] one sec [19:45:09] fixed now [19:47:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review: UsageTrackerException from line 130 of SqlUsageTracker.php - https://phabricator.wikimedia.org/T98186#1262203 (10aude) 5Open>3Resolved [19:47:44] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review: UsageTrackerException from line 130 of SqlUsageTracker.php - https://phabricator.wikimedia.org/T98186#1261902 (10aude) a:3aude [19:47:58] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Wikidata-Sprint-2015-05-05: UsageTrackerException from line 130 of SqlUsageTracker.php - https://phabricator.wikimedia.org/T98186#1261902 (10aude) [19:48:15] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Wikidata-Sprint-2015-05-05: UsageTrackerException from line 130 of SqlUsageTracker.php - https://phabricator.wikimedia.org/T98186#1261902 (10aude) we deployed the fix and i can verify that the problem is resolved [19:52:53] * aude back in ~30 min [19:58:26] [13WikibaseDataModel] 15Benestar comment on pull request #473 1449180fd: Do you know about this? http://dan.hersam.com/2005/01/27/reading-jumbled-letters/ 02http://git.io/vJSUH [20:15:22] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #473 1449180fd: @thiemowmde even if you spot such typos in a case similar to this one, IMO you are wasting everyone's time by -1'ing and not just merging and then fixing it yourself 02http://git.io/vJSmR [20:17:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Widget to edit badges should use language fallback - https://phabricator.wikimedia.org/T98208#1262349 (10Bene) 3NEW [20:19:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Widget to edit badges should use language fallback - https://phabricator.wikimedia.org/T98208#1262358 (10Bene) [20:19:05] 10Wikidata: Handle requests for customized client icons for badges - https://phabricator.wikimedia.org/T85721#1262359 (10Bene) [20:19:08] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikidata.org, 7Need-volunteer, 7Tracking: Wikibase badges (tracking) - https://phabricator.wikimedia.org/T42810#1262357 (10Bene) [20:19:40] (03PS1) 10Anomie: Don't use both setContentValue() and META_BC_SUBELEMENTS on the same key [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/209056 (https://phabricator.wikimedia.org/T98185) [20:21:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Widget to edit badges should use language fallback - https://phabricator.wikimedia.org/T98208#1262374 (10Lydia_Pintscher) Adrian worked on this. Not sure where he left off. [20:21:54] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vJS3R [20:21:54] 13WikibaseDataModel/06master 14444914f 15jeroendedauw: Fix typos in test method names [20:28:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1262380 (10Deskana) >>! In T97566#1259794, @Lydia_Pintscher wrote: > It is not just about the time of my team. It is about the effort we're putting on th... [20:52:37] wikimedia/mediawiki-extensions-Wikibase/wmf/1.26wmf4/eedce83 : aude The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/61355720 [21:01:07] (03CR) 10Jdlrobson: [C: 032 V: 032] WikidataPageBanner minor issues fixed [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/208961 (owner: 10Sumit) [22:16:45] 10Wikidata, 3Roadmap, 7notice: Deploy usage tracking to fawiki, hewiki, and enwikivoyage - https://phabricator.wikimedia.org/T98237#1262779 (10aude) 3NEW a:3aude [22:18:47] 10Wikidata, 3Roadmap, 7notice: Deploy arbitrary access to nlwiki and frwikisource - https://phabricator.wikimedia.org/T98238#1262791 (10aude) 3NEW a:3aude [22:19:16] 10Wikidata, 3Roadmap, 7notice: Deploy arbitrary access to nlwiki and frwikisource - https://phabricator.wikimedia.org/T98238#1262800 (10aude) [22:20:26] 10Wikidata, 3Roadmap, 7notice: Deploy usage tracking to fawiki, hewiki, and enwikivoyage - https://phabricator.wikimedia.org/T98237#1262806 (10aude) [22:20:28] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking, 7notice: Track Wikidata entity usage on client pages - https://phabricator.wikimedia.org/T49288#1262805 (10aude) [22:23:38] 10Wikidata, 3Roadmap, 7notice: Deploy usage tracking to all wikisource projects - https://phabricator.wikimedia.org/T98240#1262818 (10aude) 3NEW [22:24:24] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking, 7notice: Track Wikidata entity usage on client pages - https://phabricator.wikimedia.org/T49288#1262827 (10aude) [22:24:26] 10Wikidata, 3Roadmap, 7notice: Deploy usage tracking to all wikisource projects - https://phabricator.wikimedia.org/T98240#1262828 (10aude) [23:01:15] 10Wikidata, 3Roadmap, 7notice: Deploy usage tracking to all wikisource projects - https://phabricator.wikimedia.org/T98240#1262971 (10aude) [23:01:54] * hoo rages about country restrictions on websites [23:02:57] I should have a VPN in the US :P [23:03:30] oh noes [23:07:11] * aude has tentatively scheduled deployment of usage tracking to wikisource + wikivoyage + wikiquote [23:08:46] 10Wikidata, 3Roadmap, 7notice: Deploy usage tracking to Wikiquote projects - https://phabricator.wikimedia.org/T98247#1262992 (10aude) 3NEW [23:09:32] 10Wikidata, 3Roadmap, 7notice: Deploy usage tracking to Wikivoyage projects - https://phabricator.wikimedia.org/T98248#1263001 (10aude) 3NEW [23:10:11] :) [23:11:07] 10Wikidata, 3Roadmap, 7notice: Deploy arbitrary access to fawiki, hewiki and enwikivoyage - https://phabricator.wikimedia.org/T98249#1263010 (10aude) 3NEW [23:11:20] that's all for now [23:11:30] until end of may, assuming no problems [23:21:17] 10Wikidata, 3Roadmap, 7notice: Deploy usage tracking to all Wikisource projects - https://phabricator.wikimedia.org/T98240#1263064 (10aude) [23:37:18] Dump creation is way faster now with entity prefetching :) [23:38:46] yay [23:50:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: MWException from line 192 from EntityHandler.php: Can not make an empty EntityContent, since we require at least an ID to be set. - https://phabricator.wikimedia.org/T98264#1263238 (10aude) 3NEW