[06:09:58] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04deleted 06statementserializer at 149c1e9f5: 02http://git.io/vJGBK [06:25:26] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #120 14db67076: This is going to break when we switch to DataModel 3.x. Which is why I think we should first do #115 02http://git.io/vJG0D [06:28:05] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #120 14db67076: I spend some time wondering why we have a list of lists here. Having some kind of hint that these are grouped by property id would be nice. Which also makes me wonder if we should just accept statements with a property id different than that of the list they are in. Though that is not something to change here if this just re-implements the current code. 02htt [06:56:49] [13WikibaseDataModelSerialization] 15Benestar comment on pull request #120 14db67076: Sure, however, it can also be fixed in #115 thus imo the order of both patches doesn't really matter. 02http://git.io/vJGaH [06:58:36] [13WikibaseDataModelSerialization] 15Benestar comment on pull request #120 14db67076: It indeed just reflects the current serialization format. I'm not sure if we should enforce statements grouped by property id in the serializatoin though if it is not done in the DataModel. This is a more general question but we should stay consistent and either do this grouping in Items/Properties as well or don't force it in the serialization. 02http://git.io/v [07:17:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Filter-bar for statements - https://phabricator.wikimedia.org/T87326#1251450 (10Lydia_Pintscher) p:5Normal>3Low Lowering priority given that the gadget solves the immediate need. [08:35:23] [13WikibaseDataModelSerialization] 15Benestar pushed 1 new commit to 06usestatementlistserializer: 02http://git.io/vJGbQ [08:35:23] 13WikibaseDataModelSerialization/06usestatementlistserializer 14259e00c 15Bene: Revert claims -> statements rename for b/c [08:36:26] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06snakList0 from 14f1a5e25 to 1410cd438: 02http://git.io/vJGbp [08:36:26] 13WikibaseDataModel/06snakList0 1410cd438 15Thiemo Mättig: Remove Snaks interface [08:36:51] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06snakList0 from 1410cd438 to 149435e22: 02http://git.io/vJGbp [08:36:51] 13WikibaseDataModel/06snakList0 149435e22 15Thiemo Mättig: Remove Snaks interface [08:37:01] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06snakList0 at 149435e22: 02http://git.io/vJGNT [08:37:41] wmde/WikibaseDataModel/snakList0/10cd438 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/60808099 [08:38:05] wmde/WikibaseDataModel/snakList0/9435e22 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/60808213 [08:38:22] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vJGNu [08:38:22] 13WikibaseDataModel/06master 146d0dd8e 15Jeroen De Dauw: Update RELEASE-NOTES.md... [09:19:06] My Wikidata Images project on no.wiki (adding images by finding them on WIkidata) which I launched yesterday, was so succesfull the project is not testing automatically adding Wikidata images to their templates https://no.wikipedia.org/w/index.php?title=Wik [09:19:15] https://no.wikipedia.org/w/index.php?title=Wikipedia:Torget&oldid=13967812 [09:19:31] (03CR) 10Jeroen De Dauw: Use mocks in HtmlTimeFormatterTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197115 (owner: 10Thiemo Mättig (WMDE)) [09:19:37] *now testing [09:20:05] and I think I may have to cancel adding images soon, because the images will already be in the articles automaticaly [09:22:56] (03CR) 10Jeroen De Dauw: "Needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202704 (owner: 10Thiemo Mättig (WMDE)) [09:23:11] (03CR) 10Jeroen De Dauw: "Needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204472 (owner: 10Thiemo Mättig (WMDE)) [09:25:06] (03CR) 10Jeroen De Dauw: [C: 031] Refactor badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200144 (owner: 10Adrian Lang) [09:28:55] [13WikibaseDataModel] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/vJZLR [09:28:55] 13WikibaseDataModel/06master 14a95f1ea 15Thiemo Mättig: Drop long deprecated Property::newEmpty [09:28:55] 13WikibaseDataModel/06master 14440a46a 15Jeroen De Dauw: Merge pull request #425 from wmde/emptyProp... [09:32:37] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06rel30 from 1428bc521 to 14d974eba: 02http://git.io/vJZtr [09:32:37] 13WikibaseDataModel/06rel30 14d974eba 15jeroendedauw: 3.0.0 release [09:49:07] [13WikibaseDataModelSerialization] 15Benestar created 06fingerprintdeserializer (+1 new commit): 02http://git.io/vJZ3D [09:49:07] 13WikibaseDataModelSerialization/06fingerprintdeserializer 14893d8fc 15Bene: Introduce and use FingerprintDeserializer [09:49:49] wmde/WikibaseDataModelSerialization/fingerprintdeserializer/893d8fc : Bene The build failed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/60813939 [09:50:26] [13WikibaseDataModelSerialization] 15Benestar opened pull request #122: Introduce and use FingerprintDeserializer (06master...06fingerprintdeserializer) 02http://git.io/vJZsW [09:52:00] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06cs (+1 new commit): 02http://git.io/vJZsS [09:52:00] 13WikibaseInternalSerialization/06cs 140050aa5 15jeroendedauw: CS improvements... [09:52:15] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #60: CS improvements (06master...06cs) 02http://git.io/vJZsQ [09:52:39] [13WikibaseDataModelSerialization] 15Benestar pushed 1 new commit to 06fingerprintdeserializer: 02http://git.io/vJZsN [09:52:39] 13WikibaseDataModelSerialization/06fingerprintdeserializer 14353eb06 15Bene: Fix testSerializeThrowsUnsupportedObjectException supporting non-dispatchable Deserializers [09:53:36] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-05-05: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1251526 (10Bene) [09:54:01] wmde/WikibaseInternalSerialization/cs/0050aa5 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/60814284 [09:54:08] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1250487 (10Bene) [09:54:50] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Replace ClaimsSerializer by StatementListSerializer - https://phabricator.wikimedia.org/T78650#1251530 (10Bene) [09:55:03] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1251532 (10Bene) a:3Bene [09:55:13] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Replace ClaimsSerializer by StatementListSerializer - https://phabricator.wikimedia.org/T78650#1251533 (10Bene) a:3Bene [09:55:16] wmde/WikibaseDataModelSerialization/fingerprintdeserializer/353eb06 : Bene The build was fixed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/60814348 [10:01:02] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-05-01T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/208081 [10:01:37] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06msg (+1 new commit): 02http://git.io/vJZnr [10:01:37] 13WikibaseInternalSerialization/06msg 14dfcdd6b 15jeroendedauw: Use provided $fileName parameter to enhance error message [10:02:02] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06csconfig (+1 new commit): 02http://git.io/vJZnD [10:02:02] 13WikibaseInternalSerialization/06csconfig 147649b69 15jeroendedauw: Ingore Generic.CodeAnalysis.EmptyStatement.DetectedCATCH error [10:03:09] [13WikibaseInternalSerialization] 15JeroenDeDauw created 06dep (+1 new commit): 02http://git.io/vJZcJ [10:03:09] 13WikibaseInternalSerialization/06dep 1478f3461 15jeroendedauw: Stop using deprecated alias in LegacyItemDeserializer [10:03:17] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #62: Ingore Generic.CodeAnalysis.EmptyStatement.DetectedCATCH error (06master...06csconfig) 02http://git.io/vJZcI [10:03:47] wmde/WikibaseInternalSerialization/msg/dfcdd6b : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/60815036 [10:04:47] wmde/WikibaseInternalSerialization/csconfig/7649b69 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/60815052 [10:05:42] wmde/WikibaseInternalSerialization/dep/78f3461 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/60815183 [10:10:12] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1251538 (10JeroenDeDauw) [10:10:14] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Support new types of Entities in Wikibase Client - https://phabricator.wikimedia.org/T76019#1251540 (10JeroenDeDauw) [10:10:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Support new types of Entities in Wikibase Repository - https://phabricator.wikimedia.org/T75496#1251539 (10JeroenDeDauw) [10:10:28] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Support new types of Entities in Wikibase Client - https://phabricator.wikimedia.org/T76019#788271 (10JeroenDeDauw) [10:10:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Support new types of Entities in Wikibase Repository - https://phabricator.wikimedia.org/T75496#753383 (10JeroenDeDauw) [10:10:49] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1250487 (10JeroenDeDauw) [10:10:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Support new types of Entities in Wikibase Repository - https://phabricator.wikimedia.org/T75496#753383 (10JeroenDeDauw) [10:16:43] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1251549 (10JeroenDeDauw) You are right about there being OCP violations that need fixing. Currently there is this EntityDeserializer, with ItemDeserializer and Pr... [10:19:04] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04deleted 06fingerprintdeserializer at 14353eb06: 02http://git.io/vJZ4w [10:26:17] benestar: \o/ for tackling the OCP stuffs [10:26:42] benestar: you can haz easy reviews https://github.com/wmde/WikibaseInternalSerialization/pulls [10:29:14] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vJZEN [10:29:14] 13WikibaseInternalSerialization/06master 147253f68 15Jeroen De Dauw: Update composer.json... [11:04:06] [13WikibaseDataModelSerialization] 15Benestar 04force-pushed 06usestatementlistserializer from 14259e00c to 142bd9baa: 02http://git.io/vJZiC [11:04:06] 13WikibaseDataModelSerialization/06usestatementlistserializer 142bd9baa 15Bene: Use StatementListSerializer where appropriate [11:05:17] JeroenDeDauw: squashed the commits, it is no one [11:05:59] [13WikibaseInternalSerialization] 15Benestar pushed 1 new commit to 06master: 02http://git.io/vJZiF [11:05:59] 13WikibaseInternalSerialization/06master 14dd8f4d1 15Bene*: Merge pull request #63 from wmde/dep... [11:06:39] *now [11:07:25] [13WikibaseInternalSerialization] 15Benestar pushed 1 new commit to 06master: 02http://git.io/vJZPn [11:07:25] 13WikibaseInternalSerialization/06master 141610443 15Bene*: Merge pull request #61 from wmde/msg... [11:09:10] [13WikibaseInternalSerialization] 15Benestar closed pull request #60: CS improvements (06master...06cs) 02http://git.io/vJZsQ [11:14:10] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1251589 (10Bene) We already have the `DispatchableDeserializer` and `DispatchableSerializer` which do exactly that: You can pass an Entity object and it detects th... [11:24:13] [13WikibaseInternalSerialization] 15JeroenDeDauw closed pull request #62: Ingore Generic.CodeAnalysis.EmptyStatement.DetectedCATCH error (06master...06csconfig) 02http://git.io/vJZcI [11:25:28] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #64: Have TravisCI run the ci command, not just the tests (06master...06travis) 02http://git.io/vJZyQ [11:27:46] wmde/WikibaseInternalSerialization/travis/fd8455e : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/60821978 [11:30:24] 10Wikibase-DataModel-Serialization, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Remove EntityDeserializer - https://phabricator.wikimedia.org/T97706#1251591 (10JeroenDeDauw) You are correct - since we have DispatchableSerializer, we do not need to have an EntityDeserializer class to be able to have an "entity d... [11:32:41] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04deleted 06usestatementlistserializer at 142bd9baa: 02http://git.io/vJZQe [11:35:02] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #120 14bc6203b: It's more work though :) 02http://git.io/vJZQD [11:48:09] (03PS1) 10Jeroen De Dauw: Use EntityDocument instead of Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208087 [11:49:22] (03CR) 10Jeroen De Dauw: [C: 032] Switch travis to use hhvm instead of hhvm-nightly [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207975 (owner: 10Aude) [11:52:53] (03PS1) 10Jeroen De Dauw: Update type hint to what the callers expect [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208090 [11:54:33] (03PS1) 10Jeroen De Dauw: Fix type hint in getExceptionLocalizers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208091 [11:55:33] (03PS1) 10Jeroen De Dauw: Add missing imports in OutputPageEntityIdReader [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208092 [11:56:37] (03PS1) 10Jeroen De Dauw: Add missing return tag in SpecialPageLinker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208093 [11:59:14] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vJZxF [11:59:14] 13WikibaseInternalSerialization/06master 1415ac681 15Jeroen De Dauw: Update README.md... [11:59:44] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vJZpf [11:59:44] 13WikibaseDataModelSerialization/06master 149e4389d 15Jeroen De Dauw: Update README.md... [12:08:47] (03PS1) 10Jeroen De Dauw: Stop using Claims and Entity in RemoveClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208094 [12:12:00] (03CR) 10jenkins-bot: [V: 04-1] Stop using Claims and Entity in RemoveClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208094 (owner: 10Jeroen De Dauw) [12:13:31] wikimedia/mediawiki-extensions-Wikibase/master/115a4f8 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60823830 [12:16:37] (03PS1) 10Jeroen De Dauw: Do not pass a whole list of claims to ClaimSummaryBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208095 [12:20:01] (03CR) 10jenkins-bot: [V: 04-1] Do not pass a whole list of claims to ClaimSummaryBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208095 (owner: 10Jeroen De Dauw) [12:21:06] (03PS2) 10Jeroen De Dauw: Do not pass a whole list of claims to ClaimSummaryBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208095 [12:21:49] (03PS1) 10Sumit: PageBanner: Static banner placeholder created [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/208096 (https://phabricator.wikimedia.org/T94772) [12:22:46] (03PS2) 10Jeroen De Dauw: Stop using Claims and Entity in RemoveClaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208094 [12:25:07] (03CR) 10Sumit: "If the hooking mechanism does not look good, and there's a better approach, let me know, initially I used what I found best at the moment " [extensions/WikidataPageBanner] - 10https://gerrit.wikimedia.org/r/208096 (https://phabricator.wikimedia.org/T94772) (owner: 10Sumit) [12:29:37] (03PS1) 10Jeroen De Dauw: Do not give Client access to Repository settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208097 [12:30:56] (03PS1) 10Jeroen De Dauw: Do not give RepoAccessModule access to Client settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208098 [12:33:12] (03PS1) 10Jeroen De Dauw: Do not use deprecated Settings::singleton in SqlEntityInfoBuilderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208099 [12:34:15] (03PS1) 10Jeroen De Dauw: Do not give Repository access to Client settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208100 [13:11:54] [13WikibaseDataModelSerialization] 15Benestar comment on pull request #120 14bc6203b: I can adjust your PR if you prefer to safe you time ;-) 02http://git.io/vJnlt [13:22:31] [13WikibaseDataModelSerialization] 15Benestar pushed 4 new commits to 06statementlistserializer: 02http://git.io/vJnB9 [13:22:31] 13WikibaseDataModelSerialization/06statementlistserializer 141fba7f5 15Bene: Created StatementListSerializer and StatementListDeserializer [13:22:31] 13WikibaseDataModelSerialization/06statementlistserializer 143826818 15Bene: Create tests for StatementListSerializer [13:22:31] 13WikibaseDataModelSerialization/06statementlistserializer 142663375 15Bene: Fix tests [14:41:04] 10Wikidata, 10Wikimedia-Language-setup, 10Wikimedia-Site-requests, 6operations, 5Patch-For-Review: Create Wikipedia Konkani - https://phabricator.wikimedia.org/T96468#1251881 (10Krenair) So before we create this wiki, we need those translations to be approved and deployed, right? [15:23:30] JeroenDeDauw: meeeerge :D [15:23:34] https://github.com/wmde/WikibaseDataModelSerialization/pull/120 [15:58:26] Lydia_WMDE: Are you looking into improving special:unconnectedpages? [16:09:14] (03CR) 10JanZerebecki: [C: 032] New Wikidata Build - 2015-05-01T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/208081 (owner: 10WikidataBuilder) [16:12:39] (03Merged) 10jenkins-bot: New Wikidata Build - 2015-05-01T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/208081 (owner: 10WikidataBuilder) [16:27:26] (03PS1) 10Andreasburmeister: worked on job for evaluation [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/208118 [16:40:48] benestar: panic [16:41:59] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04deleted 06statementlistserializer at 14bc4df2f: 02http://git.io/vJcpH [16:42:01] benestar: mergeeeeeeeeeeeeeeed [16:53:20] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04force-pushed 06dm3 from 14cbe8fd0 to 1472b4109: 02http://git.io/hbqQ [16:53:20] 13WikibaseDataModelSerialization/06dm3 1460b6775 15jeroendedauw: Switch from DataModel 2.x to 3.x [16:53:20] 13WikibaseDataModelSerialization/06dm3 1472b4109 15jeroendedauw: Update release notes [16:53:51] benestar: mergeeeeeeeeeeee ^ [16:54:01] Then we can finally start using the new constructs [16:57:46] (03PS1) 10Jeroen De Dauw: Have EntityRevision use EntityDocument [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208120 [16:59:39] (03PS1) 10Jeroen De Dauw: Add fixes indicating bad assumptions on entity id format [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208121 [17:03:45] (03PS1) 10Jeroen De Dauw: Fix OCP violation in EntityChangeFactory and stop using deprecated method and class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208122 [17:04:31] benestar: just ignore the scrutinizer failure [17:07:08] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04force-pushed 06dm3 from 1472b4109 to 14eb0754a: 02http://git.io/hbqQ [17:07:08] 13WikibaseDataModelSerialization/06dm3 14eb0754a 15jeroendedauw: Update release notes [17:10:24] (03PS1) 10Jeroen De Dauw: Use UtfNormal\Validator rather than deprecated UtfNormal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208124 [17:21:33] (03PS1) 10Jeroen De Dauw: Have EntityHolder use EntityDocument [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208126 [17:28:41] (03PS1) 10Jeroen De Dauw: Remove commented out code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208129 [17:30:39] (03PS1) 10Jeroen De Dauw: Remove @ignore tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208130 [17:31:30] (03PS1) 10Jeroen De Dauw: Remove unused import [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208131 [17:31:49] (03PS1) 10Jeroen De Dauw: Remove dead variable [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208132 [17:32:39] (03PS1) 10Jeroen De Dauw: Remove unused parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208133 [17:34:48] 10MediaWiki-extensions-WikibaseRepository: Add UserMerge support to WikibaseRepo - https://phabricator.wikimedia.org/T69780#1252505 (10Krinkle) [17:37:30] (03PS1) 10Jeroen De Dauw: Stop using getClaims method and add type doc for local var [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208136 [17:42:13] (03PS1) 10Jeroen De Dauw: Remove assumption that all entities have claims from SetClaimValueTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208138 [17:44:26] (03PS1) 10Jeroen De Dauw: after of this commit remember do a git reset hard [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208140 [17:47:29] (03PS1) 10Jeroen De Dauw: One does not simply merge into master [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208141 [17:48:45] (03PS1) 10Jeroen De Dauw: To be honest, I do not quite remember everything I changed here today. But it is all good, I tell ya. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208142 [17:49:44] (03PS1) 10Jeroen De Dauw: Remove unused imports in Client tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208143 [17:51:41] (03PS1) 10Jeroen De Dauw: Remove dead code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208144 [17:55:12] (03PS1) 10Jeroen De Dauw: Make return docs of getAffectedUsagesByPage not lie [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208145 [17:56:19] (03PS1) 10Jeroen De Dauw: Iterator does not have a count method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208147 [17:58:36] (03PS1) 10Jeroen De Dauw: Stop using deprecated MediaWikiSite::newFromGlobalId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208149 [17:59:36] (03PS1) 10Jeroen De Dauw: apparently i did something… [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208151 [18:00:45] (03PS1) 10Jeroen De Dauw: Obligatory placeholder commit message [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208152 [18:02:43] DanielK_WMDE: could to take a look at https://gerrit.wikimedia.org/r/#/c/208000/ ? [18:03:32] DanielK_WMDE: it looks like there are more chars that wikidata allows in URLs but Blazegraph does not. I tried to capture them all [18:04:01] (03PS1) 10Jeroen De Dauw: The last time I tried this the monkey didnt survive. Lets hope it works better this time. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208156 [18:08:25] (03PS1) 10Jeroen De Dauw: Suspect we are no longer using this [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208157 [18:13:05] (03PS1) 10Jeroen De Dauw: Move service construction code to factory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208160 [18:16:17] benestar: did you died? [18:24:45] anybody knows why getHash for value returns 128-bit hash but getHash for reference retrusn 160 bit hash? [18:24:59] is there any meaning to it or it's just random thing? [18:25:15] s/retrusn/returns/ [18:31:38] JeroenDeDauw: sry, was afk [18:31:51] which patches do you want me to review merge? [18:37:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1252910 (10Jdlrobson) This seems out of scope now, given there is an editing team. The upload image button functionality is currently disable... [18:40:10] [13WikibaseDataModelSerialization] 15Benestar created 06releasenotes (+1 new commit): 02http://git.io/vJCxX [18:40:10] 13WikibaseDataModelSerialization/06releasenotes 14ce239e3 15Bene: Move release notes into their own file and reorder some sections... [18:40:25] [13WikibaseDataModelSerialization] 15Benestar opened pull request #123: Move release notes into their own file and reorder some sections (06master...06releasenotes) 02http://git.io/vJCx9 [18:41:21] wmde/WikibaseDataModelSerialization/releasenotes/ce239e3 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/60873676 [18:41:36] wmde/WikibaseDataModelSerialization/releasenotes/ce239e3 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/60873676 [18:44:22] trying to add a sitelink on an item with lots of existing ones is painfully slow :( [18:51:07] benestar: this one https://github.com/wmde/WikibaseDataModelSerialization/pull/115 [18:51:14] I rebased it [18:54:21] SMalyshev: that's probably random [18:55:06] (03CR) 10Legoktm: [C: 032] Use UtfNormal\Validator rather than deprecated UtfNormal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208124 (owner: 10Jeroen De Dauw) [18:58:11] (03Merged) 10jenkins-bot: Use UtfNormal\Validator rather than deprecated UtfNormal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208124 (owner: 10Jeroen De Dauw) [19:03:54] (03CR) 10Daniel Kinzler: [C: 032] T97694: encode more characters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208000 (owner: 10Smalyshev) [19:14:22] (03Merged) 10jenkins-bot: T97694: encode more characters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/208000 (owner: 10Smalyshev) [19:24:59] 10Wikidata, 10MobileFrontend-Feature-requests, 3Google-Summer-of-Code-2015: drop-down TOC for wikivoyage banners - https://phabricator.wikimedia.org/T97839#1253155 (10Sumit) 3NEW a:3Sumit [19:25:06] wikimedia/mediawiki-extensions-Wikibase/master/3376c69 : jeroendedauw The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60876040 [19:31:39] JeroenDeDauw: ok, thanks [19:32:38] wikimedia/mediawiki-extensions-Wikibase/master/0d19f79 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60877937 [19:34:16] 10Wikidata, 10MobileFrontend-Feature-requests, 10WikidataPageBanner, 3Google-Summer-of-Code-2015: drop-down TOC for wikivoyage banners - https://phabricator.wikimedia.org/T97839#1253202 (10Sumit) [19:35:23] 10Wikidata, 10MobileFrontend-Feature-requests, 10WikidataPageBanner, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129487 (10Sumit) [20:33:21] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service, 5Patch-For-Review: RDF import fails if object URL has | in it - https://phabricator.wikimedia.org/T97694#1253402 (10Smalyshev) 5Open>3Resolved [21:03:39] [13WikibaseDataModelSerialization] 15Benestar created 06claimsserializer (+1 new commit): 02http://git.io/vJlfo [21:03:39] 13WikibaseDataModelSerialization/06claimsserializer 144917157 15Bene: Remove ClaimsSerializer and ClaimsDeserializer completely [21:04:12] [13WikibaseDataModelSerialization] 15Benestar opened pull request #124: Remove ClaimsSerializer and ClaimsDeserializer completely (06master...06claimsserializer) 02http://git.io/vJlfF [21:04:52] wmde/WikibaseDataModelSerialization/claimsserializer/4917157 : Bene The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/60891560 [21:23:12] Lydia_WMDE: tour items start to confuse admins :-/ [21:29:57] 10Wikidata, 10DataValues: Force or fix Packagist update trigger or get rid of Packagist dependency - https://phabricator.wikimedia.org/T96659#1253554 (10JanZerebecki) p:5Unbreak!>3Normal [21:36:43] They are confusing. [22:01:02] 10Wikidata, 10DataValues: Force or fix Packagist update trigger or get rid of Packagist dependency - https://phabricator.wikimedia.org/T96659#1253633 (10JanZerebecki) I'm all for getting rid of packagist.org for anything that is involved in developing and building for production wikidata.org for reliability an... [22:39:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7JavaScript, 7Performance, 7Regression: edit/cancel with many existing sitelinks is too slow - https://phabricator.wikimedia.org/T97868#1253703 (10JanZerebecki) 3NEW [22:40:23] nikki: created https://phabricator.wikimedia.org/T97868 to track that [22:40:50] thanks :)