[00:26:59] aude: Are you here to follow up on your changes in case I have nit picks? [00:27:05] I don't want to block you on these [00:27:13] but would be nice to see them fixed, I guess [00:32:59] (03CR) 10Hoo man: [C: 04-1] "Mostly nit picks" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 (owner: 10Aude) [00:34:38] (03CR) 10Hoo man: [C: 032] Fix variable name in ChangesSubscriptionTableBuilder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207288 (owner: 10Aude) [00:40:02] hoo: yeah [00:40:07] :) [00:40:15] * aude is ready to enable usage tracking on frwikisource [00:41:01] (03CR) 10Hoo man: [C: 032] "Queries from the phabricator paste look fine :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207292 (https://phabricator.wikimedia.org/T97440) (owner: 10Aude) [00:41:49] Will you do backports? If so there's two more changes I/we want it [00:47:01] (03CR) 10Hoo man: "Well, supporting this makes the behavior inconsistent between installations (especially if uniqueness violation detection is based up on t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206851 (owner: 10Hoo man) [00:50:40] [13WikibaseSerializationJavaScript] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/vJef3 [00:50:40] 13WikibaseSerializationJavaScript/06master 141b4b99a 15Marius Hoch: Merge pull request #18 from wmde/functionNames... [00:51:43] [13WikibaseDataModelJavaScript] 15mariushoch 04deleted 06functionNames at 14c034fbc: 02http://git.io/vJefV [00:52:26] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #306 14b0e2d38: Two simple methods here would be less code, less complexity and more clarity 02http://git.io/vJefi [00:52:35] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vJefD [00:52:35] 13WikibaseDataModel/06master 14dd8b1f4 15Jeroen De Dauw: Merge pull request #306 from wmde/newMethods... [00:54:06] wmde/WikibaseDataModelJavaScript/master/8c1f8f2 : Marius Hoch The build was broken. http://travis-ci.org/wmde/WikibaseDataModelJavaScript/builds/60468269 [00:54:56] [13WikibaseDataModelJavaScript] 15mariushoch created 06fixJshint (+1 new commit): 02http://git.io/vJeJq [00:54:56] 13WikibaseDataModelJavaScript/06fixJshint 14b778ce7 15Marius Hoch: wb.datamodel.Group: Fix jshint error "Confusing use of '!'" [00:55:11] [13WikibaseDataModelJavaScript] 15mariushoch opened pull request #31: wb.datamodel.Group: Fix jshint error "Confusing use of '!'" (06master...06fixJshint) 02http://git.io/vJeJ3 [00:56:20] wmde/WikibaseDataModel/master/dd8b1f4 : Jeroen De Dauw The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/60468341 [00:57:56] JeroenDeDauw: Easy one, fixes travis: https://github.com/wmde/WikibaseDataModelJavaScript/pull/31 [00:58:32] wmde/WikibaseDataModel/master/dd8b1f4 : Jeroen De Dauw The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/60468341 [01:00:04] wmde/WikibaseDataModel/master/dd8b1f4 : Jeroen De Dauw The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/60468341 [01:02:45] [13WikibaseDataModelJavaScript] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/vJeTk [01:02:45] 13WikibaseDataModelJavaScript/06master 1444a5932 15Thiemo Mättig: Remove mw.ext.dataValues [01:02:45] 13WikibaseDataModelJavaScript/06master 148744f6f 15Marius Hoch: Merge pull request #27 from wmde/mwExt... [01:02:55] (03PS3) 10Aude: Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 [01:04:09] (03CR) 10Aude: Add some (optional) verbosity to ChangesSubscriptionTableBuilder (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 (owner: 10Aude) [01:05:07] wmde/WikibaseDataModelJavaScript/master/8744f6f : Marius Hoch The build is still failing. http://travis-ci.org/wmde/WikibaseDataModelJavaScript/builds/60469125 [01:06:00] (03CR) 10jenkins-bot: [V: 04-1] Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 (owner: 10Aude) [01:06:33] aaah [01:07:04] Oh, that's because you made it non-verbose there [01:07:14] gah [01:07:17] I think [01:07:47] mh, no [01:09:08] (03CR) 10Hoo man: Add some (optional) verbosity to ChangesSubscriptionTableBuilder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 (owner: 10Aude) [01:12:09] (03PS4) 10Aude: Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 [01:12:51] aude: Why did you remove $this->loadBalancer = $loadBalancer; ? [01:12:57] Also see my comment from PS3 [01:13:02] (03PS5) 10Aude: Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 [01:13:10] gah [01:15:08] (03PS6) 10Aude: Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 [01:15:09] there [01:15:44] (03CR) 10Hoo man: [C: 032] Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 (owner: 10Aude) [01:15:47] Ah :) [01:15:52] yay [01:17:38] (03CR) 10Aude: Fix variable name in ChangesSubscriptionTableBuilder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207288 (owner: 10Aude) [01:17:44] (03PS2) 10Aude: Fix variable name in ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207288 [01:17:51] (03PS3) 10Aude: Base continuation on row id for populating subscriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207292 (https://phabricator.wikimedia.org/T97440) [01:19:06] aude: Will you backport these? [01:19:35] sure [01:19:58] Ok, there's two more things, I'll cherry pick them for you [01:20:14] (03Merged) 10jenkins-bot: Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207171 (owner: 10Aude) [01:20:33] (03PS1) 10Hoo man: Remove keydown event from property selector input [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207348 (https://phabricator.wikimedia.org/T96466) [01:20:40] :) [01:20:41] Lydia is ok with that [01:20:48] I asked her [01:20:49] * aude was hoping so [01:20:59] (03PS1) 10Hoo man: Only prefetch entities we will actually load in DumpGenerator [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207349 [01:20:59] can reproduce the bug now, with certain keyboard actions [01:21:06] On Wikidata? [01:21:07] and confirm the fix [01:21:09] yes [01:21:15] Ok, I only tested locally [01:21:21] like tab and then go back to the property [01:21:32] and select again [01:21:32] But various people reported, so I assume it's important [01:21:36] it is [01:22:44] populating usage tracking is going quick [01:22:57] should be ready to enable on nlwiki shortly [01:23:02] (03CR) 10Hoo man: Fix variable name in ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207288 (owner: 10Aude) [01:23:08] (03CR) 10Hoo man: [C: 032] Fix variable name in ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207288 (owner: 10Aude) [01:23:13] kicking jenkins [01:23:21] :/ [01:23:26] (03CR) 10Hoo man: Base continuation on row id for populating subscriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207292 (https://phabricator.wikimedia.org/T97440) (owner: 10Aude) [01:23:35] (03CR) 10Hoo man: [C: 032] Base continuation on row id for populating subscriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207292 (https://phabricator.wikimedia.org/T97440) (owner: 10Aude) [01:23:50] It seems to not start a gate and submit if you rebase and the change has a +2 [01:24:01] yeah [01:24:32] Want to merge https://github.com/wmde/WikibaseDataModelJavaScript/pull/31 ? Easy one [01:24:47] lookin [01:24:47] especially as the comment confirms this is the behaviour we want [01:24:47] g [01:25:48] done [01:26:00] [13WikibaseDataModelJavaScript] 15filbertkm 04deleted 06fixJshint at 14b778ce7: 02http://git.io/vJetH [01:26:04] :) [01:26:07] (03Merged) 10jenkins-bot: Fix variable name in ChangesSubscriptionTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207288 (owner: 10Aude) [01:26:25] when i am done with usage tracking, then will do branch stuff [01:26:41] (03Merged) 10jenkins-bot: Base continuation on row id for populating subscriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207292 (https://phabricator.wikimedia.org/T97440) (owner: 10Aude) [01:29:30] wikimedia/mediawiki-extensions-Wikibase/master/a5e92f2 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60470911 [01:29:42] huh [01:29:51] oh [01:30:27] DB connection error: No such file or directory () [01:30:29] :/ [01:30:34] Unrelated, but awry [01:31:04] :( [01:31:29] looks like it's been broken https://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60262254 [01:33:14] [13Time] 15mariushoch comment on pull request #61 14420728d: Out of curiosity: Why 62s? (Consistent with above, so this is ok, just wondering... leap seconds?) 02http://git.io/vJemJ [01:33:22] [13Time] 15mariushoch closed pull request #61: Fix private method name in TimeValue (06master...06normalize) 02http://git.io/vvyJ7 [01:35:26] wikimedia/mediawiki-extensions-Wikibase/master/e7c0348 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60470952 [01:35:51] Weird... the newer php versions don't have a problem to connect [01:36:02] so probably not a travis set up thing [01:36:05] mh [01:36:10] not nice [01:37:08] https://travis-ci.org/wikimedia/mediawiki/jobs/60443345 [01:37:15] So core seems to run into the same problem [01:37:18] wikimedia/mediawiki-extensions-Wikibase/master/aefcf23 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60470514 [01:37:23] but no one cares for that :( [01:38:28] aude: do you need anything else reviewed or so? [01:38:35] If not I think I'll call it a day in a bit [01:39:29] hoo: i think everything is good [01:39:35] (except travis) [01:40:16] might put the backport things up at swat tomorrow [01:40:27] probably [01:41:50] Ok, wont be around for early swat tomorrow, but I guess you are [01:41:55] yeah [01:41:58] Nice [01:42:03] wikimedia/mediawiki-extensions-Wikibase/master/e7c0348 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60470952 [01:42:07] i'll have to figure out deployment time [01:42:20] * aude supposed to go out in the evening [01:42:35] but can arrange to be around somehow [01:42:47] I'm going to be at home from 5:30 CEST on [01:42:52] ok [01:44:31] good night :) [01:44:35] good night [01:45:27] !nyan [01:45:27] ~=[,,_,,]:3 [01:45:44] aude: why are you still up? Crazy person [01:46:10] JeroenDeDauw: evil time zones :) [01:47:18] aude: you are in Berlin right? [01:47:24] no :) [01:49:02] * aude enjoying super fast speeds to eqiad :) [01:49:38] aude: download/upload ALL the cats! [01:49:44] heh [02:27:02] (03PS1) 10Aude: Wait for slaves per insert batch in EntityUsageTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207364 [02:27:04] (03PS1) 10Aude: Use bulk insert for adding entity usage rows [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207365 [02:30:41] (03PS1) 10Aude: Fix typo in UsageTableUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207366 [03:04:28] wikimedia/mediawiki-extensions-Wikibase/wmf/1.26wmf4/e7c0348 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60476519 [03:05:51] (03PS1) 10Aude: New deployment branch - wmf/1.26wmf4 [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207370 [03:06:28] (03CR) 10Aude: "still needs property suggester tagged and updated" [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207370 (owner: 10Aude) [03:08:07] (03CR) 10Aude: [C: 032] Remove keydown event from property selector input [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207348 (https://phabricator.wikimedia.org/T96466) (owner: 10Hoo man) [03:08:25] (03CR) 10Aude: [C: 032] Only prefetch entities we will actually load in DumpGenerator [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207349 (owner: 10Hoo man) [03:08:57] (03PS1) 10Aude: Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207371 [03:09:12] (03PS1) 10Aude: Fix variable name in ChangesSubscriptionTableBuilder [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207372 [03:09:24] (03PS1) 10Aude: Base continuation on row id for populating subscriptions [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207373 (https://phabricator.wikimedia.org/T97440) [03:09:50] (03CR) 10jenkins-bot: [V: 04-1] New deployment branch - wmf/1.26wmf4 [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207370 (owner: 10Aude) [03:12:50] (03Merged) 10jenkins-bot: Remove keydown event from property selector input [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207348 (https://phabricator.wikimedia.org/T96466) (owner: 10Hoo man) [03:13:30] (03Merged) 10jenkins-bot: Only prefetch entities we will actually load in DumpGenerator [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207349 (owner: 10Hoo man) [03:15:54] wikimedia/mediawiki-extensions-Wikibase/wmf/1.26wmf2/06a00df : aude The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60477847 [03:18:47] wikimedia/mediawiki-extensions-Wikibase/wmf/1.26wmf2/26cee13 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60477885 [03:22:23] wikimedia/mediawiki-extensions-Wikibase/wmf/1.26wmf2/26cee13 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60477885 [03:33:48] (03CR) 10Aude: [C: 032] Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207371 (owner: 10Aude) [03:34:03] (03CR) 10Aude: [C: 032] Base continuation on row id for populating subscriptions [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207373 (https://phabricator.wikimedia.org/T97440) (owner: 10Aude) [03:34:17] (03CR) 10Aude: [C: 032] Fix variable name in ChangesSubscriptionTableBuilder [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207372 (owner: 10Aude) [03:37:04] (03Merged) 10jenkins-bot: Add some (optional) verbosity to ChangesSubscriptionTableBuilder [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207371 (owner: 10Aude) [03:37:16] (03Merged) 10jenkins-bot: Base continuation on row id for populating subscriptions [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207373 (https://phabricator.wikimedia.org/T97440) (owner: 10Aude) [03:37:41] (03Merged) 10jenkins-bot: Fix variable name in ChangesSubscriptionTableBuilder [extensions/Wikibase] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207372 (owner: 10Aude) [03:40:13] wikimedia/mediawiki-extensions-Wikibase/wmf/1.26wmf2/7e2d32e : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60479560 [03:46:12] (03PS1) 10Aude: Update Wikidata - fixes for subscription table script, dumps, and entering statements [extensions/Wikidata] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207375 [03:46:55] (03PS2) 10Aude: Update Wikidata - fixes for subscriptions script, dumps, and entering statements [extensions/Wikidata] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207375 [03:47:04] wikimedia/mediawiki-extensions-Wikibase/wmf/1.26wmf2/3a3d674 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60479592 [08:01:58] Lydia_WMDE: Would it be possible to do https://phabricator.wikimedia.org/T95403 (the empty divs) soon? We'd like to start with implementing the UI :) [08:02:28] tamslo: will talk to thiemo today [08:08:01] [13WikibaseDataModel] 15thiemowmde created 06guidTests (+1 new commit): 02http://git.io/vJvO5 [08:08:01] 13WikibaseDataModel/06guidTests 14a4e87f4 15Thiemo Mättig: Rework invalid GUID tests [08:08:25] (03CR) 10Jonaskeutel: [C: 032 V: 032] Split CheckResultToViolationTranslator [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/206792 (owner: 10Dominic.sauer) [08:08:36] [13WikibaseDataModel] 15thiemowmde opened pull request #468: Rework invalid GUID tests (06master...06guidTests) 02http://git.io/vJv3I [08:09:36] [13WikibaseDataModel] 15thiemowmde comment on pull request #306 14b0e2d38: True. I was not happy with this provider too. See #468. 02http://git.io/vJv3W [08:10:27] wmde/WikibaseDataModel/guidTests/a4e87f4 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/60499474 [08:10:42] Lydia_WMDE: thanks :) [08:17:14] (03CR) 10Jonaskeutel: fixed no/somevalue crashes in checkresult (031 comment) [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/207056 (owner: 10Andreasburmeister) [08:24:47] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06mw_selenium_1.0: 02http://git.io/vJvno [08:24:47] 13WikidataBrowserTests/06mw_selenium_1.0 143ed8520 15WMDE-Fisch: gemfile update to limit mw_selenium to 1.1.0 [08:30:36] (03CR) 10Dominic.sauer: Refactor DumpMetaInformation as pure value class, using DumpMetaInformationStore and DumpMetaInformationLookup (032 comments) [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/207049 (owner: 10Dominic.sauer) [08:46:43] (03CR) 10Tamslo: Refactor DumpMetaInformation as pure value class, using DumpMetaInformationStore and DumpMetaInformationLookup (032 comments) [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/207049 (owner: 10Dominic.sauer) [08:47:27] (03PS5) 10Tamslo: Refactor DumpMetaInformation as pure value class, using DumpMetaInformationStore and DumpMetaInformationLookup [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/207049 (owner: 10Dominic.sauer) [08:54:39] (03CR) 10Dominic.sauer: [C: 032 V: 032] Refactor DumpMetaInformation as pure value class, using DumpMetaInformationStore and DumpMetaInformationLookup [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/207049 (owner: 10Dominic.sauer) [08:58:45] [13Time] 15thiemowmde comment on pull request #61 14420728d: I can't find the original source but certain sources hint ["that sometimes, but very rarely, a particular minute will contain 59, 61, or 62 seconds."](https://books.google.de/books?id=4MQlic6zkuAC&pg=PA293&dq="62 seconds") Which means the limit should be 61 and not 62, right? I will fill a Phabricator ticket for this. 02http://git.io/vJv09 [09:08:22] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06mw_selenium_1.0: 02http://git.io/vJvzo [09:08:22] 13WikidataBrowserTests/06mw_selenium_1.0 14e364690 15WMDE-Fisch: replaced missing "visits" [09:15:02] CFisch_WMDE: I have changed WikidataTester/WB_REPO_PASSWORD [09:15:10] Lydia_WMDE: where is the Lydia_WMDE? How many millions of moneys do I owe you now? [09:15:29] CFisch_WMDE: looks like everything works fine https://integration.wikimedia.org/ci/job/browsertests-Wikidata-SmokeTests-linux-firefox-sauce-T89343-DEBUG/ [09:15:46] CFisch_WMDE: I will let you know the new password today during our pairing session [09:15:47] (03PS1) 10Soeren.oldag: Fixed wrong merging. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/207399 [09:15:58] zeljkof: ok nice thanks [09:17:04] (03CR) 10Tamslo: [C: 032 V: 032] Fixed wrong merging. [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/207399 (owner: 10Soeren.oldag) [09:17:54] zeljkof: wait, as I see it the scenario you used does not use the login :-) [09:18:24] CFisch_WMDE: it failed the first time because it logs in via the API [09:18:35] CFisch_WMDE: take a look at the first job run [09:18:38] ah .. true [09:18:54] ok :-> [09:19:01] I did not know which one logs in, could not find any @login cucumber tags [09:19:18] feel free to test with a scenario that logs in via the web interface [09:19:25] you should be able to edit the job [09:19:39] jupp I will run another test [09:19:51] zeljkof-away: see you later [09:20:08] I will be back in an hour or two, if anything is broken we can fix it then [09:35:07] JeroenDeDauw: you owe me 22 euro. in cash in euros please ;-) [09:35:15] Thiemo_WMDE: https://phabricator.wikimedia.org/T95403 [09:40:40] (03PS1) 10Tamslo: Correct merge errors [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/207407 [09:44:24] (03CR) 10Soeren.oldag: [C: 032 V: 032] Correct merge errors [extensions/WikidataQualityExternalValidation] (v1) - 10https://gerrit.wikimedia.org/r/207407 (owner: 10Tamslo) [09:45:04] (03CR) 10Tobias Gritschacher: [C: 032] Wrap descriptions in entitytermsforlanguageview instead of using ellipsis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200316 (https://phabricator.wikimedia.org/T93807) (owner: 10Ricordisamoa) [09:46:02] [13Time] 15thiemowmde comment on pull request #61 14420728d: I should have benchmarked this before. The bottleneck is the regex (~100ms for 50000 strings). The difference between the two regexes is not measurable. The additional comparison (no matter if the type cast is done implicitly via `$hour > 23` or explicitly via `(int)$hour`) adds ~10ms. `intval` should be avoided since it's ~5 times slower. 02http://git.io/vJvMm [09:48:47] (03Merged) 10jenkins-bot: Wrap descriptions in entitytermsforlanguageview instead of using ellipsis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200316 (https://phabricator.wikimedia.org/T93807) (owner: 10Ricordisamoa) [09:59:46] wikimedia/mediawiki-extensions-Wikibase/master/9c03b46 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60511608 [10:01:26] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-04-29T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/207410 [10:04:19] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015-04-29T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/207410 (owner: 10WikidataBuilder) [10:11:03] (03CR) 10JanZerebecki: [C: 032 V: 032] "Same as before." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/207410 (owner: 10WikidataBuilder) [10:11:48] [13Time] 15thiemowmde created 06intval (+1 new commit): 02http://git.io/vJv5K [10:11:48] 13Time/06intval 1455c51bf 15Thiemo Mättig: Replace intval() with faster (int) cast [10:11:59] [13Time] 15thiemowmde opened pull request #63: Replace intval() with faster (int) cast (06master...06intval) 02http://git.io/vJv5M [10:19:37] [13Number] 15thiemowmde created 06intval (+1 new commit): 02http://git.io/vJvFH [10:19:37] 13Number/06intval 141ff40cb 15Thiemo Mättig: Replace intval() with faster (int) cast [10:23:26] [13Number] 15thiemowmde opened pull request #30: Replace intval() with faster (int) cast (06master...06intval) 02http://git.io/vJvNY [10:24:57] Tobi_WMDE_SW: https://github.com/Wikidata-lib/PropertySuggester/pull/126 [10:41:50] Lydia_WMDE: pfffft [10:42:14] Lydia_WMDE: why do you hate freedom so much? [10:43:17] http://www.unsertirol24.com/2015/04/26/probiere-es-aus-erraet-der-test-woher-du-kommst/ [10:51:29] jzerebecki: any idea why this is failing..? [10:51:40] master build is green [10:52:23] Tobi_WMDE_SW: broken travis is broken: "DB connection error: Can't connect to local MySQL server" [10:52:29] Thiemo_WMDE: I did that some days ago and it got it exactly right [11:01:00] JeroenDeDauw: you know what's wrong there? [11:01:06] https://github.com/Wikidata-lib/PropertySuggester/pull/126 [11:05:56] Tobi_WMDE_SW: huh? [11:07:47] JeroenDeDauw: what jzerebecki wrote.. [11:08:12] Looks like its just the MySQL builds [11:08:20] Guessing something in MW changed [11:08:34] Bet that if you have it pull 1.25 it'll pass [11:14:30] /zzzzzz [12:26:03] (03PS1) 10Thiemo Mättig (WMDE): Replace intval() with faster (int) cast [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207425 [12:29:48] DanielK_WMDE: I've added yesterdays discussion notes to https://phabricator.wikimedia.org/T89005 [12:30:03] (03PS3) 10Daniel Kinzler: Add support for redirect handling to RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206169 [12:30:06] think that was the correct ticket.. [12:30:27] (03CR) 10Daniel Kinzler: Add support for redirect handling to RdfBuilder (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206169 (owner: 10Daniel Kinzler) [12:31:09] Thiemo_WMDE: what about this? https://gerrit.wikimedia.org/r/#/c/204501/ [12:31:17] i replied to your comments. do you want to maintain the cr-1? [12:31:39] (03PS1) 10Thiemo Mättig (WMDE): Remove unnecessary intval() and add missing (int) casts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207428 [12:32:06] Thiemo_WMDE: and your follow-up needs a rebase+ [12:32:59] (03PS5) 10Daniel Kinzler: Language fallback for badge labels in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204540 [12:33:14] jzerebecki: would you review that? ---^ [12:38:59] (03CR) 10Daniel Kinzler: "Looks ok, but do we need this change? Is this fixing an actual problem? Repeated inserts inside a transaction (atomic section) are batched" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207365 (owner: 10Aude) [12:42:12] (03CR) 10Daniel Kinzler: [C: 032] Wait for slaves per insert batch in EntityUsageTableBuilder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207364 (owner: 10Aude) [12:45:35] (03Merged) 10jenkins-bot: Wait for slaves per insert batch in EntityUsageTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207364 (owner: 10Aude) [12:49:38] (03CR) 10Daniel Kinzler: "I agree with Marius: there's no point in keeping flags only needed for schema migration around forever. It's just clutter, and confusing." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206851 (owner: 10Hoo man) [12:49:57] wikimedia/mediawiki-extensions-Wikibase/master/7df5afd : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60531208 [13:10:32] (03PS1) 10JanZerebecki: Add jscs and jshint config. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/207434 [13:16:05] jzerebecki: I've created https://phabricator.wikimedia.org/T97528 and https://phabricator.wikimedia.org/T97527 [13:16:14] I add them to the sprint, ok? [13:24:26] (03CR) 10Soeren.oldag: [C: 032 V: 031] Add jscs and jshint config. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/207434 (owner: 10JanZerebecki) [13:24:36] (03Merged) 10jenkins-bot: Add jscs and jshint config. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/207434 (owner: 10JanZerebecki) [13:25:19] (03CR) 10Tobias Gritschacher: "Part of T97529" [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/207434 (owner: 10JanZerebecki) [13:27:25] Tobi_WMDE_SW: thx [13:33:45] wikimedia/mediawiki-extensions-Wikibase/master/7df5afd : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60531208 [13:36:18] * aude is going to merge https://github.com/Wikidata-lib/PropertySuggester/pull/126 [13:36:31] think it's just issues with travis [13:39:49] poking a little more at travis [13:40:27] (03PS1) 10Thiemo Mättig (WMDE): Rework regular expressions for performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207439 [13:42:01] filbertkm/mediawiki-extensions-Wikibase/master/7df5afd : jenkins-bot The build has errored. http://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/builds/60538403 [13:42:14] (03PS1) 10Thiemo Mättig (WMDE): Clean up DispatchStats class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207441 [14:20:15] (03CR) 10Daniel Kinzler: [C: 032] T95441: represent novalue in the same way as WDTK (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206955 (owner: 10Smalyshev) [14:22:32] (03PS1) 10Thiemo Mättig (WMDE): Make label view multiline by default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207446 [14:23:13] (03CR) 10jenkins-bot: [V: 04-1] T95441: represent novalue in the same way as WDTK [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206955 (owner: 10Smalyshev) [14:24:38] (03CR) 10Aude: [C: 032] Update Wikidata - fixes for subscriptions script, dumps, and entering statements [extensions/Wikidata] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207375 (owner: 10Aude) [14:27:57] (03Merged) 10jenkins-bot: Update Wikidata - fixes for subscriptions script, dumps, and entering statements [extensions/Wikidata] (wmf/1.26wmf2) - 10https://gerrit.wikimedia.org/r/207375 (owner: 10Aude) [14:32:27] (03PS1) 10Jonaskeutel: refactor ConstraintChecker [extensions/WikidataQualityConstraints] (v1) - 10https://gerrit.wikimedia.org/r/207447 [14:41:06] (03PS2) 10Aude: New deployment branch - wmf/1.26wmf4 [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207370 [14:41:55] (03PS1) 10Thiemo Mättig (WMDE): Add empty span for indicators to the snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207449 (https://phabricator.wikimedia.org/T95403) [14:43:21] [13WikidataBuildResources] 15filbertkm created 06suggester (+1 new commit): 02http://git.io/vJJwF [14:43:21] 13WikidataBuildResources/06suggester 1441756e0 15aude: Update PropertySuggester version to 2.2.0... [14:44:13] [13WikidataBuildResources] 15filbertkm opened pull request #26: Update PropertySuggester version to 2.2.0 (06master...06suggester) 02http://git.io/vJJrn [14:45:24] jzerebecki: around (or anyone)? [14:45:36] * aude prefers not to self merge https://github.com/wmde/WikidataBuildResources/pull/26 [14:45:40] although it is super trivial [14:46:15] aude: i can merge it, if i know what that update entails [14:46:24] [13WikidataBuildResources] 15JanZerebecki 04deleted 06suggester at 1441756e0: 02http://git.io/vJJoG [14:46:25] DanielK_WMDE: too late :) [14:46:28] thanks jzerebecki [14:46:32] oh noes [14:46:32] yw [14:48:02] (03PS3) 10Daniel Kinzler: Add redirect handling to RdfDumpGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206170 [14:48:12] (03PS4) 10Daniel Kinzler: Add support for redirect handling to RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206169 [14:48:19] (03PS4) 10Daniel Kinzler: Add redirect handling to RdfDumpGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206170 [14:48:24] SMalyshev: --^ [15:02:01] (03CR) 10Aude: [C: 032] New deployment branch - wmf/1.26wmf4 [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207370 (owner: 10Aude) [15:05:18] (03Merged) 10jenkins-bot: New deployment branch - wmf/1.26wmf4 [extensions/Wikidata] (wmf/1.26wmf4) - 10https://gerrit.wikimedia.org/r/207370 (owner: 10Aude) [15:11:23] [13Time] 15thiemowmde created 06leapSeconds (+1 new commit): 02http://git.io/vJJQ7 [15:11:23] 13Time/06leapSeconds 140a84338 15Thiemo Mättig: Fix allowed leap seconds range [15:16:23] [13Time] 15thiemowmde opened pull request #64: Fix allowed leap seconds range (06master...06leapSeconds) 02http://git.io/vJJFR [15:28:55] [13Time] 15thiemowmde created 06calendarConstants (+1 new commit): 02http://git.io/vJJj8 [15:28:55] 13Time/06calendarConstants 144339d85 15Thiemo Mättig: Move calendar model constants to TimeValue [15:36:31] (03PS1) 10Tamslo: Implemented basic API for violations [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/207464 [15:44:03] [13Time] 15thiemowmde opened pull request #65: Move calendar model constants to TimeValue (06master...06calendarConstants) 02http://git.io/vJULG [15:46:16] (03PS2) 10Tamslo: Implemented basic API for violations [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/207464 (https://phabricator.wikimedia.org/T97428) [15:52:51] [13WikimediaBadges] 15thiemowmde closed pull request #17: Explicitly define module position (06master...06patch-1) 02http://git.io/vfAKA [15:56:17] [13WikimediaBadges] 15thiemowmde created 06bottom (+1 new commit): 02http://git.io/vJU32 [15:56:17] 13WikimediaBadges/06bottom 14255c814 15Thiemo Mättig: Change module loading position from top to bottom [15:56:32] [13WikimediaBadges] 15thiemowmde opened pull request #18: Change module loading position from top to bottom (06master...06bottom) 02http://git.io/vJU3M [15:56:59] (03CR) 10Daniel Kinzler: "The code looks ok on a first glance, but I didn't check closely. There is one naming issue that bothers me." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206734 (owner: 10Hoo man) [15:57:37] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1 for the naming issue. Some feedback about the caching concept would be good, too." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206734 (owner: 10Hoo man) [15:58:57] [13Wikidata.org] 15thiemowmde created 06bottom (+1 new commit): 02http://git.io/vJUGe [15:58:57] 13Wikidata.org/06bottom 14e55cb4f 15Thiemo Mättig: Change module loading position from top to bottom [15:59:42] [13Wikidata.org] 15thiemowmde opened pull request #23: Change module loading position from top to bottom (06master...06bottom) 02http://git.io/vJUGu [16:18:08] (03CR) 10Daniel Kinzler: "Well, it's now blocked on T97126, no? Or do you think the performance issue isn't that bad, and we should risk deploying it without prefet" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [16:20:39] (03PS1) 10Lucie Kaffee: Clarify message on Special:EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207482 [16:21:57] (03PS2) 10Lucie Kaffee: Clarify message on Special:EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207482 (https://phabricator.wikimedia.org/T91215) [16:21:59] (03CR) 10Daniel Kinzler: [C: 031] "The code looks good, only holding back because of performance considerations. We'd need at least a deployment note to watch out for a poss" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [16:22:50] (03CR) 10Daniel Kinzler: [C: 032] Clarify message on Special:EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207482 (https://phabricator.wikimedia.org/T91215) (owner: 10Lucie Kaffee) [16:25:59] (03Merged) 10jenkins-bot: Clarify message on Special:EntityData [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207482 (https://phabricator.wikimedia.org/T91215) (owner: 10Lucie Kaffee) [16:29:39] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/204501/ [16:41:28] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Well, then." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206851 (owner: 10Hoo man) [16:50:03] (03PS14) 10Daniel Kinzler: Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 [16:50:50] bd808: i'm trying out composer-merge-plugin and i'm wondering how to then create and include the autoload stuff from the extensions? [16:51:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Had a chat with Daniel. The function names are not perfect but I do not have a better idea." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 (owner: 10Daniel Kinzler) [16:54:05] (03Merged) 10jenkins-bot: Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 (owner: 10Daniel Kinzler) [17:01:49] aude: any idea about my question^^? [17:05:33] jzerebecki: https://getcomposer.org/doc/04-schema.md#config (there is the vendor-dir config option) [17:05:47] but might not work for extensions, since it's a special type of thing (vs. a library) [17:07:54] https://github.com/composer/installers/blob/master/src/Composer/Installers/MediaWikiInstaller.php [17:08:02] aude: i mean usually running composer in the extension genereates their autoloader, but composer-merge-plugin does not merge that, so no autoloader will be generated for the extension, only for core itself. so how to genereate it? [17:08:59] jzerebecki: composer-merge-plugin will put the merged requirements into $IP/vendor and its autoloader [17:09:31] bd808: even for things of mediawiki-extension type? [17:09:32] bd808: yes only of the requirements, but not those that are in the included composer.json [17:09:36] that's not how it worked for me :( [17:10:07] jzerebecki: i run composer install / update in core root director [17:10:09] y [17:10:14] "not those that are in the included"? I'm not following [17:10:56] * aude is confused [17:11:15] Are you talking about using require in $IP/composer.local.json or something else? [17:12:19] bd808: say i add "extensions/*/composer.json" to mergeplugin.include of core, then have extensions/Wikibase checked out which has a composer.json; for the dependencies declared in Wikibase it works fine, but what about the autoload stuff in there? [17:13:08] jzerebecki: wasn't a problem for me but don't think idid it that way [17:13:40] unfortunately it's on my old laptop and can't remember exactly what i did [17:14:24] jzerebecki: ah. right. That doesn't work completely I don't think. There is some discussion at -- https://github.com/wikimedia/composer-merge-plugin/issues/18 [17:14:26] oh, i put everything in composer.local.json [17:14:42] more explicitly [17:14:43] it should work the way aude said ^ [17:14:44] aude: you included WikidataBuildResrouces, so Wikibase etc will be added as dependencies which should work fine [17:14:53] that's what i did [17:15:01] treating build resources as an extension [17:15:06] ah ok now i get it [17:15:13] * aude would call it "Wikidata" [17:15:23] or whatever [17:15:38] aude: so you added a requirement on WikidataBuildResources ? [17:15:54] bd808: the problem i have is that extensions get installed int he extensions directory alongside non-composer stuff [17:16:10] it kind of works for me but imagine maybe we don't want it that way in production [17:16:21] jzerebecki: i did [17:16:32] we are never going to use this for extension installs in production [17:16:46] bd808: but "Wikidata" depends on other extensions [17:16:58] as if they are libraries sort of (but are not) [17:17:30] we could just change the type of package they are [17:17:34] the ones that really are libraries should be turned into libraries [17:17:38] yeah [17:17:47] bd808: and if we remove the dependencies on extensions then we are back at the autoloader problem [17:18:33] * aude is off to eat [17:19:05] The point of composer-merge-plugin was not to fix wikidata or be used on the WMF cluster. It's for external installs that want to add optional libraries (eg Monolog) and/or install extensions via composer [17:19:34] which is tricky once we started actually using composer.json in core [17:19:58] there would be dirty diffs on git update or the file being repaced by a tarball unpack [17:20:24] so we made this "also load these things" side door [17:22:09] bd808: too bad :( are there plans to make extensions that use composer to build their autoloader supported in production? [17:22:38] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Time-Parser should detect most likely calendar - https://phabricator.wikimedia.org/T75272#1246112 (10daniel) a:3daniel [17:23:00] bd808: or the case of multiple extensions in production depending on the same lib via composer? [17:23:45] jzerebecki: we have mediawiki/vendor.git for prod [17:23:55] it has to be managed and reviewed manually [17:24:16] that's where we would need to manage the libraries [17:24:53] Running composer for prod without human review won't get by the Ops team [17:25:04] Or the security team [17:27:38] bd808: i'm not suggesting that we run composer on deployment. how would you include the dependencies of Wikibase in vendor.git and also create the autoloader for Wikibase to be commited in vendor.git? [17:30:45] jzerebecki: I'm honestly not sure. Wikibase and SMW are "different" and I've not tried to understand them [17:31:18] wikimedia/mediawiki-extensions-Wikibase/master/488f4b6 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60563426 [17:38:52] bd808: there are mediawiki extensions that depend on wikibase. those and wikibase and core depend on libs, some of those dependencies overlap. all 4 things have autoloader-prefixes which need to be put into a optimally combined or alternativeley multiple chained autoloaders. [17:40:14] bd808: currently we solve this by making our own build similar to how vendor.git is made. [17:40:44] (03PS2) 10Smalyshev: T95441: represent novalue in the same way as WDTK [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206955 [17:41:58] jzerebecki: *nod* SMW is similar too except for wikitech nobody has made the jump and we are just pinned to an old version that doesn't need composer [17:43:08] bd808: it would be nice to find a solution for everyone for production and then switch to wikibase being like everyone else [17:43:28] it's worth talking about for sure. [17:44:03] but? [17:44:12] not my job? ;) [17:44:48] There is a solution for every extension except SMW and Wikidata today [17:45:10] bd808: as long as they don't use composer [17:45:28] 10Wikidata: update Wikibase ontology schema (owl) - https://phabricator.wikimedia.org/T97522#1246190 (10Smalyshev) Oh, cool, we do have this file already! I was just thinking about where to introduce it. I have some initial work for it, will add a patch a bit later. [17:46:27] bd808: whose job is it? [17:46:39] release engineering? [17:47:36] we do have some extensions in WMF prod that use composer to bring in external libs but they don't use composer to build the core extension autoloader [17:48:10] for these the external libs are in mediawiki/vendor.git [17:56:59] DanielK_WMDE: some questions about the redirect patches. I see that the code supports adding redirects, but in fact neither in dumps not in flavor=dump redirects actually appear [17:57:11] DanielK_WMDE: was that the intent to add them in the next patch? [17:58:22] SMalyshev: when a redirect is referenced, it should already appear in the output of Special:EntityData [17:58:36] DanielK_WMDE: it doesn't for me... [17:58:44] hm.... it should... [17:59:08] if it doesn't, that would be a bug. [17:59:38] As to dumps, redirects are currently not included in the ID stream. We'd need to add an option for including them there. [17:59:55] DanielK_WMDE: from the code, I'm not sure how... which part is supposed to call addEntityRedirect? [18:00:01] SMalyshev: also, when directly requesting data for a redirect, the redirect info should be in the output of EntityData, along with the actual data [18:00:33] DanielK_WMDE: right now there's only data for target, I think the redirect is resolved before it gets to RdfBuilder, as it happened before [18:00:39] it's called in the catch() clause in addReferencedEntities, and in RdfDumpGenerator [18:01:13] SMalyshev: ah, right, if the EntityLookup that is passed in already resolved entities, this would never happen. [18:01:43] i concentrated on the places where UnresolvedRedirectExceptions could arise. I didn't look through the entire call stack. [18:01:54] we should write down which use cas3es we need to cover. [18:02:04] DanielK_WMDE: that's what seems to happen now. resolveMentionedEntities only happens for mentioned ones, and only in some modes, not for original ones [18:02:21] for original, it seems to use the resolving lookup, outside of the builder [18:02:38] like: redirect requested directly from EntityData, redirect encountered when resolving a referenced entity, including redirects when generating Rdf dumps [18:03:14] hm, stubs for referenced entities hsould be included per default. they used to be included by the old code, IIRC [18:03:41] I'll add the description to T69033 [18:03:42] btw, i'll go offline soon, but i'll be back on in about three hours, fir the RFC chat [18:03:52] thanks [18:40:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3Wikidata-Sprint-2015-04-21: Include redirects in RDF rendering. - https://phabricator.wikimedia.org/T69033#1246418 (10Smalyshev) The cases we're looking for in RDF, assuming Q6 is a redirect to Q4: 1. If the output is for /wiki/Special:EntityData/Q6.rd... [18:41:00] (03CR) 10Smalyshev: [C: 04-1] "Does not show owl:sameAs in Special:EntityData. Please see https://phabricator.wikimedia.org/T69033 for requirements." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206169 (owner: 10Daniel Kinzler) [18:50:04] (03CR) 10Smalyshev: [C: 032] "Self+2 since Daniel +2ed earlier." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206955 (owner: 10Smalyshev) [19:04:55] (03Merged) 10jenkins-bot: T95441: represent novalue in the same way as WDTK [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/206955 (owner: 10Smalyshev) [19:11:29] 10Wikidata, 6Release-Engineering: enable use of production deployed autoloader for extensions that is created by composer - https://phabricator.wikimedia.org/T97560#1246532 (10JanZerebecki) 3NEW [19:13:49] 10Wikidata: Use composer-merge-plugin to include Wikidata components in mediawiki-vendor - https://phabricator.wikimedia.org/T95663#1246562 (10JanZerebecki) [19:13:50] 10Wikidata, 6Release-Engineering: enable use of production deployed autoloader for extensions that is created by composer - https://phabricator.wikimedia.org/T97560#1246563 (10JanZerebecki) [19:16:34] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service, 5Patch-For-Review: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1246586 (10Smalyshev) 5Open>3Resolved [19:18:09] wikimedia/mediawiki-extensions-Wikibase/master/a5e1424 : Stanislav Malyshev The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60584720 [19:20:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1246616 (10kaldari) 3NEW [19:20:50] hoo: around? [19:21:32] Yes [19:21:38] ok [19:21:56] * aude needs to go for an hour or 1 1/2 hours if that is ok [19:22:08] i think it's unlikely there is anything we need to do for deployment this time [19:22:23] I'll be around, need to do stuff for university anyway [19:22:25] and it won't be done with scap that quick [19:22:27] ok [19:22:53] oh... and i am populating subscriptions [19:22:59] * aude checks how it's doing [19:23:06] on terbium? [19:23:16] yeah [19:23:22] not any problems and looks almost done [19:23:51] suppose we can enable use of it when i am online again [19:24:13] 19:23:03: Populating subscription table: inserted 300 subscriptions, continuing at item #16653153. [19:24:36] started 3 hours ago, and pretty quick [19:24:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1246653 (10Mhurd) {F158660} {F158661} {F158662} {F158666} {F158667} [19:25:15] i could stop it and restart or i think it's okay to let it continue running [19:27:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1246657 (10Mhurd) @deskana @tfinc Tomasz and Dan, I tagged you because this issue is pretty central to search / discovery. [19:29:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1246670 (10Deskana) Thanks for filing this report. I'd like to see this tackled fairly soon so that our users don't have to keep having this irrelevant i... [19:30:10] hoo: i can wait until the script is done [19:30:14] 10Wikidata, 6Release-Engineering, 7Composer: enable use of production deployed autoloader for extensions that is created by composer - https://phabricator.wikimedia.org/T97560#1246671 (10bd808) [19:30:51] Ok, doubt you need to, though [19:31:08] i think it's another 10 minutes [19:39:48] (03CR) 10Hoo man: "I don't think we should block this one on T97126 while we still have the links on watchlists etc. altered. I agree it's bad, but I guess i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [19:40:52] * aude is off [19:41:03] the script is nearly done :) [19:42:03] ok [19:59:27] 10Wikidata: Add input fields to Special:EntityDatat - https://phabricator.wikimedia.org/T97542#1246859 (10Nemo_bis) [19:59:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Clarify message on Special:EntityData - https://phabricator.wikimedia.org/T91215#1246857 (10Nemo_bis) 5Open>3Resolved > serving different content (formats) from the same URL is a Bad Thing But this is exactly what I saw happening, before I knew of the... [20:21:48] 10Wikidata: Behavior switch __EXPECT_UNCONNECTED_PAGE__ - https://phabricator.wikimedia.org/T97577#1246921 (10jeblad) 3NEW [20:57:53] (03PS1) 10Smalyshev: Add more documentation to OWL ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207632 [20:58:38] (03PS2) 10Smalyshev: T97522: Add more documentation to OWL ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/207632 [21:06:57] * aude back [21:07:35] You didn't miss anything :P [21:08:20] yay [21:08:26] * aude is around for an hour [21:09:02] then back again after that (~30 min later) [21:09:06] Ok [21:09:16] I plan to go to bed somewhat early today [21:09:40] But can be here till 00:30 or even 1:00 CEST, if needed [21:11:06] ok [21:13:05] i am not sur eabout enabling subscription tracking just yet [21:13:17] * aude is tethering [21:14:28] i see the script is done and maybe put it up at swat [21:23:04] Lydia_WMDE: on the Dutch Wikipedia we use the Special:UnconnectedPages intensively to see which pages still needs to be added to Wikidata [21:25:20] hoo: actually, i think we need to enable this stuff first on test.wikidata [21:25:28] I've been using it on some of the rather small wikipedias to see which pages aren't linked to wikidata yet [21:25:46] also the link in the sidebar for linking a page to wikidata seems to have broken [21:25:55] then wikidata tomorrow, if it's ok or monday [21:26:56] Yeah, going for test first sounds good [21:27:15] :) [21:27:32] will put it in swat and won't be tethering at that time [21:30:07] it works better to have a link to Wikidata under the title of an article [21:30:14] a gadget does do that for me [21:32:26] oh, I wasn't very clear... I mean the link where you can add sitelinks, which pops up a dialog where you can search for a page on another wikipedia... I've been using it to link pages to existing wikidata pages, but now the search results are all weird, rather than one page on each row, there's one letter of the page name on each row [21:33:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Apps: Add an instruction field for Wikidata items - https://phabricator.wikimedia.org/T97566#1247153 (10kaldari) If a new field is added, it should also be included in the pop-up suggestions when adding claims within Wikidata. [21:33:13] I never use it, I found it not handy [21:34:08] wikimedia/mediawiki-extensions-Wikibase/master/3dd4331 : Translation updater bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/60599466 [21:35:16] do you just link them from the wikidata page itself? [21:37:33] nikki: Will have a look, thanks for letting me know [21:41:43] Ok, can reproduce :( [21:45:58] hoo: oh noes :( [21:46:07] sounds very strange [21:46:19] It is [21:47:10] Did we update ValueView? [21:50:15] oO [21:50:27] The API format changed [21:50:28] wtf [21:50:35] I don't think that should happen [21:50:39] whaaaaat? [21:51:30] Seems like the opensearch api is return different stuff, will investigate [21:51:32] but looks weird [21:52:43] we made some compatibility patch but think they pertained only to tests afaik [21:52:58] this is probably something else [21:53:00] I got a fix, was easy to fix [21:53:04] ok :) [21:53:13] But I'm not sure we should [21:53:28] :/ [21:53:29] Might be that it's a core issue [21:53:41] * The root node and various other nodes will now always be an object in formats 271 [21:53:42] such as json that distinguish between arrays and objects. 272 [21:53:42] * Except for action=opensearch where the spec requires an array. [21:53:46] From release notes [22:04:34] aude: Ok, seems this is not our problem... [22:04:58] ok [22:06:05] All this stuff doesn't have tests :( [22:06:44] aaaaaah [22:06:55] * aude back in ~30 minutes [22:07:01] in time for swat, for sure [22:07:06] Ok, I'll be around till then at least [22:07:24] later [22:12:59] (03CR) 10Addshore: "Will happily amend this, just need to find the time." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204747 (https://phabricator.wikimedia.org/T63811) (owner: 10Addshore) [22:13:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7Need-volunteer, and 3 others: When using wbgetclaims in the API no lastrevid is given - https://phabricator.wikimedia.org/T63811#1247325 (10Addshore) Will happily amend this, just need to find the time. [22:16:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase applies bot flag to edits via the UI - https://phabricator.wikimedia.org/T96129#1247354 (10Addshore) This should also be checked in special pages [22:27:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase applies bot flag to edits via the UI - https://phabricator.wikimedia.org/T96129#1247405 (10hoo) I introduced this back in ec84cbe76740d779a15b70e87481d7e6020e16bb in order to make thing consistent with MediaWiki. If the behaviour in MediaWiki chan... [22:30:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase applies bot flag to edits via the UI - https://phabricator.wikimedia.org/T96129#1247408 (10Legoktm) The behavior in core hasn't changed [22:39:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase applies bot flag to edits via the UI - https://phabricator.wikimedia.org/T96129#1247416 (10hoo) >>! In T96129#1247408, @Legoktm wrote: > The behavior in core hasn't changed You're right, I just checked this... as said above, I don't think we shou... [22:50:59] * aude back [23:02:40] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: add info if langlink is stored at repository or local - https://phabricator.wikimedia.org/T43345#1247643 (10Nemo_bis) Uh. https://lists.wikimedia.org/pipermail/wikidata-l/2015-April/005993.html