[02:31:19] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1214643 (10NiharikaKohli) @Jdlrobson, @Nicolas_Raoul Not sure you're getting the melange emails. We need your... [02:39:19] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1214646 (10Nicolas_Raoul) I was receiving many emails about totally unrelated projects so I unsubscribed, thi... [02:51:44] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1214652 (10NiharikaKohli) @Nicolas_Raoul This is a one time thing, I believe. You can see the relevant discus... [06:16:16] (03PS1) 10Smalyshev: Create mechanism to handle redirects in entity revision lookups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204710 [06:18:18] (03CR) 10jenkins-bot: [V: 04-1] Create mechanism to handle redirects in entity revision lookups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204710 (owner: 10Smalyshev) [06:22:47] (03PS2) 10Smalyshev: Create mechanism to handle redirects in entity revision lookups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204710 [06:25:47] (03CR) 10jenkins-bot: [V: 04-1] Create mechanism to handle redirects in entity revision lookups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204710 (owner: 10Smalyshev) [06:27:33] (03PS3) 10Smalyshev: Create mechanism to handle redirects in entity revision lookups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204710 [07:12:12] (03PS1) 10Smalyshev: Make RDF dump redirects in short form as owl:sameAs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204711 [07:18:46] (03CR) 10Smalyshev: "Tests are not there yet, will add if the general idea is OK." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204711 (owner: 10Smalyshev) [07:47:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 7Documentation, and 2 others: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1214822 (10Snaterlicious) Please see https://www.mediawiki.org/wiki/User:Henning_(WMDE)/Wikibase/Data_... [07:48:56] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #116 14df94af3: It's not true. A few lines below the code returns an `Entity`. 02http://git.io/vvDOx [07:56:26] (03PS4) 10Thiemo Mättig (WMDE): Make stuff in SetClaimTest private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 [07:58:43] (03PS2) 10Thiemo Mättig (WMDE): Prefer WebRequest::getCheck if possible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204236 [08:06:00] (03PS2) 10Thiemo Mättig (WMDE): Prepare RDF test data for new data-values/time release [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204258 (https://phabricator.wikimedia.org/T96135) [08:34:54] (03PS4) 10Thiemo Mättig (WMDE): Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) [08:38:19] (03CR) 10jenkins-bot: [V: 04-1] Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [08:50:01] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I tried and it works as expected. But I wonder: whats the benefit of this? Now I can search for all items that do *not* have a sitelink to" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204529 (owner: 10Bene) [09:39:44] (03CR) 10Aude: "there is siteSub and contentSub. suppose those are why the "padding" is there between the h1 and mw-content-text." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) (owner: 10Bene) [09:52:15] (03CR) 10Thiemo Mättig (WMDE): "DNM because this was meant as a replacement for *older* code, as I explained in the release notes. Don't you read release notes?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202453 (https://phabricator.wikimedia.org/T78290) (owner: 10Thiemo Mättig (WMDE)) [10:01:54] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-04-17T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/204736 [10:12:52] 10Wikidata, 7Technical-Debt: Clean up usage of ApiResult in tests and ResultBuilder - https://phabricator.wikimedia.org/T96353#1214944 (10daniel) [10:13:13] Duesendrunk: hey, did you think about how to provide a way in WikibaseRepo for getting a LanguageFallback? [10:13:28] 10Wikidata: aufter entry remove no saving possbile - https://phabricator.wikimedia.org/T96354#1214945 (10Conny) 3NEW [10:15:21] (03CR) 10Daniel Kinzler: [C: 032] Update ApiResult handling for mediawiki/core change I7b37295e (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197383 (https://phabricator.wikimedia.org/T91073) (owner: 10Anomie) [10:18:25] hehe, so apparently redirect loops are allowed! [10:18:54] Thiemo_WMDE, jzerebecki: the guy in the middle http://nb.xiandos.info/Fil:The_Three_Amigos.jpg [10:18:58] (03Merged) 10jenkins-bot: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197383 (https://phabricator.wikimedia.org/T91073) (owner: 10Anomie) [10:19:04] oops, should change my nick :) [10:19:11] Hi DanielK_WMDE !: ) [10:19:12] all better now ;) [10:19:24] hey addshore! [10:19:28] got a quick question for you if youve got 3 mins? :) [10:20:11] I'v just written Special:EntityRedirect, and just writing the tests and looking at all the lovely new special page tests, but I need to be able to resolve redirects in MockRepository [10:20:46] addshore: uuuhhhhh [10:20:49] suggestions on how I should implement that? ? [10:20:58] addshore: what does Special:EntityRedirect actually do?... [10:21:13] make redirects between 2 entities (same as the api module) [10:21:21] 10Wikidata: after entry remove no saving possbile - https://phabricator.wikimedia.org/T96354#1214957 (10Conny) [10:21:59] addshore: oh, it *creates* a redirect, I see [10:22:25] addshore: MockRepo doesn't resolve redirects itself, but if you need a resolving lookup, wrap a RedirectResolvingEntityLookup around the MockRepo [10:22:29] Yes, I could probably call it CreateEntityRedirect, but I thought just calling it CreateRedirect would seem a bit off [10:22:45] addshore: Special:RedirectEntity? [10:22:47] addshore: what about RedirectEntities? [10:22:53] :P [10:22:55] ;) [10:23:03] hehe, I'll do that ;p [10:23:44] addshore: next task: MergeEntities :P [10:23:51] mhhhm :P [10:23:53] wow, EditPage no longer uses ApiEditPage [10:24:14] oh [10:24:20] DanielK_WMDE: btw, this is the code mostly used for term fetching I guess: https://phabricator.wikimedia.org/P529 [10:24:42] ApiEditPage uses EditPage :P [10:24:53] benestar: yes. we should wrap that nicely somewhere [10:24:58] in WikibaseRepo? [10:25:10] benestar: i don't know, come up with something pretty :) [10:25:14] heh [10:25:16] ;) [10:25:43] (03CR) 10JanZerebecki: [C: 032] New Wikidata Build - 2015-04-17T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/204736 (owner: 10WikidataBuilder) [10:25:57] basically, if you can replace all the places where we have this code now with calling your now thing, without it being awkward, you got it right. [10:28:49] (03Merged) 10jenkins-bot: New Wikidata Build - 2015-04-17T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/204736 (owner: 10WikidataBuilder) [10:32:55] ahh DanielK_WMDE that wouldnt work as things like RedirectCreationInteractor require something implementing EntityRevisionLookup whereas RedirectResolvingEntityLookup implements EntityLookup :P [10:33:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 7Documentation, and 2 others: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1214970 (10daniel) @Snaterlicious Oh nice! I haven't read the document in detail yet, but from a first... [10:34:06] addshore: EntityRevisionLookup does not resolve redirects, the interface contract sais so. [10:35:02] addshore: you can make an abject that loks like an EntityRevisionLookup and resolves redirects, but doesn't implement the interface, using an EntityRedirectResolvingDecorator [10:35:15] [13WikibaseDataModel] 15thiemowmde created 06moreBits (+1 new commit): 02http://git.io/vvDx5 [10:35:15] 13WikibaseDataModel/06moreBits 1402dee43 15Thiemo Mättig: Minor code styling bits [10:35:30] "Implementations of this method must not silently resolve redirects." [10:36:21] addshore: why would RedirectCreationInteractor want something that resolves redirects anyway? [10:36:49] [13WikibaseDataModel] 15thiemowmde opened pull request #447: Minor code styling bits (06master...06moreBits) 02http://git.io/vvDpn [10:37:03] 10Wikidata, 10MediaWiki-API, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Update Wikidata for ApiResult rewrite - https://phabricator.wikimedia.org/T91073#1214972 (10daniel) 5Open>3Resolved a:3daniel [10:37:27] DanielK_WMDE: I think my head is being burried by all the things that have changed lo [10:37:28] ;p [10:37:57] of course its actually EntityModificationTestHelper::getEntity I need to resolved redirects... [10:38:34] but yes, I should be able to just wrap it in RedirectResolvingEntityLookup in my test class and be happy it works :D [10:38:42] wmde/WikibaseDataModel/moreBits/02dee43 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58888596 [10:42:23] [13WikibaseDataModel] 15thiemowmde created 06getSetClaims (+1 new commit): 02http://git.io/vvDh9 [10:42:23] 13WikibaseDataModel/06getSetClaims 142ad82d9 15Thiemo Mättig: Drop getClaims/setClaims from all Entity classes [10:44:10] [13WikibaseDataModel] 15thiemowmde opened pull request #448: [DNM] Drop getClaims/setClaims from all Entity classes (06master...06getSetClaims) 02http://git.io/vvDjY [10:46:02] (03PS2) 10Tamslo: Another code cleanup [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204498 [10:46:30] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Remove deprecated claim methods from Entity - https://phabricator.wikimedia.org/T78290#1214992 (10thiemowmde) * https://github.com/wmde/WikibaseDataModel/pull/448 removes the last claim method from Entity. * I'm not sure if... [10:46:37] wmde/WikibaseDataModel/getSetClaims/2ad82d9 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58889193 [10:50:49] [13Time] 15thiemowmde comment on pull request #57 148565ded: Do you want me to change this? 02http://git.io/vvyvf [10:53:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Performance, 10Wikidata-Sprint-2015-04-07: Prefetch labels on history pages - https://phabricator.wikimedia.org/T95672#1214997 (10daniel) For the record, now that the hook exists in core, we still need code that hooks in and does the pre-fetching. [10:54:40] addshore: being happy that it works is always a good plan ;) [10:54:47] :D [10:55:35] EntityModificationTestHelper.... ugh [10:57:23] hehe DanielK_WMDE :P [10:57:32] lets see if I remember how to commit to gerrit... [10:59:41] (03PS1) 10Addshore: Create Special:RedirectEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204742 (https://phabricator.wikimedia.org/T87114) [11:01:51] woop woop! [11:02:51] [13Time] 15thiemowmde created 06normalize (+1 new commit): 02http://git.io/vvyJ6 [11:02:51] 13Time/06normalize 14420728d 15Thiemo Mättig: Fix private method name in TimeValue [11:03:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review: SpecialPage for wbcreateredirect - https://phabricator.wikimedia.org/T87114#1215002 (10Addshore) a:3Addshore [11:03:32] [13Time] 15thiemowmde opened pull request #61: Fix private method name in TimeValue (06master...06normalize) 02http://git.io/vvyJ7 [11:05:16] (03CR) 10Addshore: Create Special:RedirectEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204742 (https://phabricator.wikimedia.org/T87114) (owner: 10Addshore) [11:07:24] (03CR) 10Jonaskeutel: [C: 032 V: 031] Another code cleanup [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204498 (owner: 10Tamslo) [11:07:27] [13Time] 15thiemowmde 04force-pushed 06formatterConsts from 14e89d3cd to 1471fc45f: 02http://git.io/jdbV [11:07:27] 13Time/06formatterConsts 1471fc45f 15Thiemo Mättig: Stop using formatter constants in parsers [11:09:34] [13Time] 15thiemowmde comment on pull request #54 1471fc45f: #49 contains a major refactoring of this. I did not wanted to repeat everything, this patch here contains only very basic stuff. 02http://git.io/vvyTl [11:10:57] (03CR) 10Daniel Kinzler: Language fallback for badge labels in SpecialSetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204540 (owner: 10Daniel Kinzler) [11:12:35] [13Time] 15thiemowmde 04force-pushed 06070 from 142198cd2 to 1447f31c2: 02http://git.io/hVFy [11:12:35] 13Time/06070 1447f31c2 15Thiemo Mättig: Prepare 0.7.0 release [11:12:41] (03PS2) 10Daniel Kinzler: Language fallback for badge labels in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204540 [11:13:16] (03PS2) 10Tamslo: Consistency tweaks [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203191 (owner: 10Raimond Spekking) [11:13:48] DanielK_WMDE: how can I mock the LanguageFallbackChainFactory in tests? Or should I just use WikibaseRepo::getDefaultInstance() for that purpose? [11:14:36] or maybe just new LanguageFallbackChainFactory() [11:14:54] benestar: just use the global instance for now, mocking that thing is rather nasty. and the global instance is stateless and doesn't use much config [11:15:04] (03CR) 10Jonaskeutel: [C: 032 V: 031] Consistency tweaks [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203191 (owner: 10Raimond Spekking) [11:17:18] [13Time] 15thiemowmde 04force-pushed 06precisionConsts from 140820e34 to 1450969eb: 02http://git.io/hYuZ [11:17:18] 13Time/06precisionConsts 1450969eb 15Thiemo Mättig: Unify names of time precision constants [11:19:48] DanielK_WMDE: and is there a mock for TermLookup? I think that would be quite handy [11:23:52] (03CR) 10Bene: [C: 04-1] "See inline comment. That case won't occur in production perhaps but should still be fixed." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204540 (owner: 10Daniel Kinzler) [11:24:38] [13Time] 15thiemowmde 04force-pushed 06timeFormatterCal2 from 1436bdc1b to 14ff8bb83: 02http://git.io/pQaF [11:24:38] 13Time/06timeFormatterCal2 14ff8bb83 15Thiemo Mättig: Fix outdated calendar logic in TimeFormatter [11:27:05] [13WikibaseDataModel] 15addshore created 06catchInvalidEntityIdInClaimGuidParser (+1 new commit): 02http://git.io/vvyt5 [11:27:05] 13WikibaseDataModel/06catchInvalidEntityIdInClaimGuidParser 14a01a1bf 15addshore: Catch exception for invalid EntityId in GUID parser... [11:27:48] [13WikibaseDataModel] 15addshore opened pull request #449: Catch exception for invalid EntityId in GUID parser (06master...06catchInvalidEntityIdInClaimGuidParser) 02http://git.io/vvyqT [11:29:07] [13Time] 15thiemowmde 04force-pushed 06timeFormatterCal2 from 14ff8bb83 to 14d2ce3a8: 02http://git.io/pQaF [11:29:07] 13Time/06timeFormatterCal2 14d2ce3a8 15Thiemo Mättig: Fix outdated calendar logic in TimeFormatter [11:30:24] wmde/WikibaseDataModel/catchInvalidEntityIdInClaimGuidParser/a01a1bf : addshore The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58893269 [11:34:41] (03PS1) 10Addshore: Catch ClaimGuidParsingException in SetClaim api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) [11:36:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 5Patch-For-Review: wbsetclaim does not catch exceptions thrown in GUID parsing - https://phabricator.wikimedia.org/T89100#1215038 (10Addshore) To be fixed this requires: - The Gerrit change https://gerrit.wikimedia.org/r/204746 to be merged... [11:36:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 5Patch-For-Review: wbsetclaim does not catch exceptions thrown in GUID parsing - https://phabricator.wikimedia.org/T89100#1215039 (10Addshore) a:3Addshore [11:40:21] Fix all of the bugs! [11:40:39] :) [11:41:04] * aude making more tests for EditPage [11:41:19] :D [11:42:37] (03PS10) 10Bene: Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) [11:43:40] DanielK_WMDE I've implemented language fallback there but did not find a nice solution to wrap those things yet :/ [11:44:10] What I think would be useful is a service class where you put a language and a list of entity ids and you get the labels/descriptions back [11:44:15] (03PS2) 10Daniel Kinzler: Introduce DedupeBag. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204486 [11:44:25] (03CR) 10jenkins-bot: [V: 04-1] Introduce DedupeBag. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204486 (owner: 10Daniel Kinzler) [11:44:37] so one does not have to care about prefetching and language fallbacks at all in the first place [11:45:17] not sure how to call such a class though [11:45:28] aude addshore : have any idea? --^ [11:46:23] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Almost +2, but formatting is not so nice and I have a suggestion." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [11:46:25] (03PS11) 10Bene: Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) [11:46:46] (03PS2) 10Daniel Kinzler: Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 [11:46:54] (03CR) 10jenkins-bot: [V: 04-1] Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 (owner: 10Daniel Kinzler) [11:47:32] benestar: i think TermLookup does that [11:47:48] afaik [11:48:12] aude: that's just an interface... [11:48:34] I want to have language fallback chain, prefetching in a termbuffer and maybe even formatting in one class [11:48:38] so that it becomes more reusable [11:50:59] hm [11:51:20] what is the use case? [11:53:03] (03CR) 10Bene: "re Thiemo" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [11:53:28] aude: We have a list of entity ids and want to render them nicely [11:53:40] for example on Special query pages [11:53:48] or to render badges [11:55:03] (03PS1) 10Addshore: Add lastrevid to result of wbgetclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204747 (https://phabricator.wikimedia.org/T63811) [11:55:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7Need-volunteer, 5Patch-For-Review: When using wbgetclaims in the API no lastrevid is given - https://phabricator.wikimedia.org/T63811#1215068 (10Addshore) a:3Addshore [11:55:40] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "This is consistent to the getSiteLinksForItem( ItemId $itemId ) method in the same interface. Should be merged as it is in my opinion. If " (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [11:57:38] (03CR) 10Addshore: Catch ClaimGuidParsingException in SetClaim api (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [11:58:00] (03CR) 10jenkins-bot: [V: 04-1] Add lastrevid to result of wbgetclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204747 (https://phabricator.wikimedia.org/T63811) (owner: 10Addshore) [12:00:05] (03CR) 10Thiemo Mättig (WMDE): Catch ClaimGuidParsingException in SetClaim api (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:00:55] (03CR) 10Addshore: Catch ClaimGuidParsingException in SetClaim api (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:01:00] (03CR) 10Thiemo Mättig (WMDE): Catch ClaimGuidParsingException in SetClaim api (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:05:36] (03PS2) 10Addshore: Add lastrevid to result of wbgetclaims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204747 (https://phabricator.wikimedia.org/T63811) [12:13:36] (03PS2) 10Addshore: Catch ClaimGuidParsingException in SetClaim api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) [12:14:37] Zuul will have some kind of interruption soonish [12:14:52] =o [12:14:54] :D [12:19:01] 10Wikidata: after entry remove no saving possbile - https://phabricator.wikimedia.org/T96354#1215112 (10Aklapper) Thanks for taking the time to report this! What does "not possible to save changes" mean exactly? Is something greyed out? Does nothing happen after you click some button? Do you get some error mess... [12:22:01] (03PS2) 10Addshore: Drop dead code and narrow interfaces in WikibaseApiTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202704 (owner: 10Thiemo Mättig (WMDE)) [12:23:50] (03PS16) 10Daniel Kinzler: Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) [12:24:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Catch ClaimGuidParsingException in SetClaim api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:24:28] (03PS3) 10Thiemo Mättig (WMDE): Drop unused use clauses from client/lib/repo/view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204472 [12:26:54] (03PS3) 10Daniel Kinzler: Introduce DedupeBag. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204486 [12:27:18] zuul should be back now [12:27:22] (03PS3) 10Daniel Kinzler: Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 [12:28:52] (03PS1) 10Bene: Implement language fallback in SpecialWikibaseQueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204752 [12:30:15] [13WikibaseDataModel] 15brightbyte 04deleted 06catchInvalidEntityIdInClaimGuidParser at 14a01a1bf: 02http://git.io/vvyEv [12:30:16] (03CR) 10jenkins-bot: [V: 04-1] Introduce DedupeBag. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204486 (owner: 10Daniel Kinzler) [12:31:07] (03CR) 10Daniel Kinzler: "bah, i was too late :/" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:31:13] Thiemo_WMDE: --^ [12:31:42] (03PS2) 10Bene: Implement language fallback in SpecialWikibaseQueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204752 [12:33:15] (03CR) 10Addshore: Catch ClaimGuidParsingException in SetClaim api (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:33:39] DanielK_WMDE: ^^ [12:35:55] (03CR) 10jenkins-bot: [V: 04-1] Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 (owner: 10Daniel Kinzler) [12:37:13] (03CR) 10jenkins-bot: [V: 04-1] Implement language fallback in SpecialWikibaseQueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204752 (owner: 10Bene) [12:40:34] (03PS3) 10Bene: Implement language fallback in SpecialWikibaseQueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204752 [12:40:46] I got to edit more on Wikidata [12:41:02] yes [12:42:12] (03CR) 10Daniel Kinzler: Catch ClaimGuidParsingException in SetClaim api (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:43:28] Adipose: go right ahead :) [12:43:46] :P I will! [12:44:07] (03PS4) 10Daniel Kinzler: Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 [12:45:18] (03PS4) 10Daniel Kinzler: Introduce DedupeBag. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204486 [12:45:26] (03PS3) 10Addshore: Catch ClaimGuidParsingException in SetClaim api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) [12:46:00] and of course Jenkins decided to be deadlocked so I hve to resrtart it :) [12:46:12] :D [12:46:36] hashar: I do like the new UI on the zuul status page! [12:48:53] (03PS5) 10Thiemo Mättig (WMDE): Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) [12:49:30] (03CR) 10Daniel Kinzler: [C: 032] Catch ClaimGuidParsingException in SetClaim api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:51:45] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202704 (owner: 10Thiemo Mättig (WMDE)) [12:52:13] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) (owner: 10Daniel Kinzler) [12:52:36] (03CR) 10Addshore: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204472 (owner: 10Thiemo Mättig (WMDE)) [12:54:28] (03Merged) 10jenkins-bot: Catch ClaimGuidParsingException in SetClaim api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204746 (https://phabricator.wikimedia.org/T89100) (owner: 10Addshore) [12:55:22] many small edits https://www.wikidata.org/w/index.php?title=Q19787822&diff=prev&oldid=211144109 or few "large" edits https://www.wikidata.org/w/index.php?title=Q1001102&diff=211144578&oldid=162830053? [12:55:52] addshore: yeah krinkle worked hard on it [12:56:08] addshore: he integrated the UI from upstream ! [12:56:27] hmm [12:56:39] for some reason phplint fails on the Wikibase extension [12:56:48] (03CR) 10jenkins-bot: [V: 04-1] Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) (owner: 10Daniel Kinzler) [12:56:59] (03CR) 10Addshore: [C: 031] Make stuff in SetClaimTest private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 (owner: 10Thiemo Mättig (WMDE)) [12:58:52] DanielK_WMDE: php -l repo/includes/rdf/RdfBuilder.php yields PHP Parse error: syntax error, unexpected '*', expecting T_FUNCTION in repo/includes/rdf/RdfBuilder.php on line 276 [12:59:01] (03CR) 10Addshore: [C: 032] Fix non-existing ConnectionManager class name in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204475 (owner: 10Thiemo Mättig (WMDE)) [12:59:08] DanielK_WMDE: that is using php 5.3 [13:02:21] (03Merged) 10jenkins-bot: Fix non-existing ConnectionManager class name in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204475 (owner: 10Thiemo Mättig (WMDE)) [13:02:33] (03CR) 10jenkins-bot: [V: 04-1] Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 (owner: 10Daniel Kinzler) [13:09:57] (03CR) 10Daniel Kinzler: [C: 032] "I'd rather get rid of EntityTestHelper instead of sinking time into fixing unused code." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202453 (https://phabricator.wikimedia.org/T78290) (owner: 10Thiemo Mättig (WMDE)) [13:10:08] addshore: --^ [13:10:37] hehe :P [13:13:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 5Patch-For-Review: wbsetclaim does not catch exceptions thrown in GUID parsing - https://phabricator.wikimedia.org/T89100#1215168 (10daniel) @addshore is this resolved now? [13:13:40] (03Merged) 10jenkins-bot: [DNM] Drop unused EntityTestHelper::getTestEntity() method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202453 (https://phabricator.wikimedia.org/T78290) (owner: 10Thiemo Mättig (WMDE)) [13:13:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 5Patch-For-Review: wbsetclaim does not catch exceptions thrown in GUID parsing - https://phabricator.wikimedia.org/T89100#1215170 (10Addshore) It will be once the new version of https://github.com/wmde/WikibaseDataModel is used :) [13:25:37] (03CR) 10Raimond Spekking: "What are you doing with the translations here? Please never touch translations, only en.json and qqq.json." [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204498 (owner: 10Tamslo) [13:25:51] (03PS1) 10Addshore: Add redirect info to wbgetentities result [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204758 (https://phabricator.wikimedia.org/T88902) [13:26:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: action=wbgetentities should contain information about redirect resolving - https://phabricator.wikimedia.org/T88902#1215218 (10Addshore) a:3Addshore [13:27:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Create a PHP service interface for accessing entity redirects - https://phabricator.wikimedia.org/T96364#1215231 (10daniel) 3NEW [13:29:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1215249 (10daniel) [13:29:26] 10Wikidata: JSON should (optionally) contain expanded/normalized values. - https://phabricator.wikimedia.org/T89005#1215248 (10daniel) [13:34:08] (03CR) 10Raimond Spekking: "I see you have not really touched it, it is more a shadow of https://gerrit.wikimedia.org/r/#/c/204604/ , the export of yesterday." [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204498 (owner: 10Tamslo) [13:36:16] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Create infrastructure for optionally putting normalized values into JSON - https://phabricator.wikimedia.org/T93747#1215274 (10daniel) [13:39:00] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service, 5Patch-For-Review: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1215284 (10daniel) @Smalyshev perhaps instead of a special value, use a special predicate for novalue/somevalue. Then novalue would behave just like... [13:41:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: action=wbgetentities should contain information about redirect resolving - https://phabricator.wikimedia.org/T88902#1215292 (10JanZerebecki) [13:42:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1215297 (10daniel) The thumbnail URL should probably not be part of the data value as such. I propo... [13:50:30] (03PS1) 10Tamslo: Baseline commit [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/204761 [13:55:07] (03PS1) 10Tamslo: Baseline commit [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/204762 [14:04:16] (03PS2) 10Tamslo: Baseline commit [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/204762 [14:04:28] 10Wikidata: after entry remove no saving possible - https://phabricator.wikimedia.org/T96354#1215334 (10Aklapper) [14:05:18] (03CR) 10Tamslo: [C: 032 V: 032] Baseline commit [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/204762 (owner: 10Tamslo) [14:06:32] 10Wikidata: after entry remove no saving possible - https://phabricator.wikimedia.org/T96354#1215344 (10Conny) Save "button" is greyed out. [14:11:53] (03CR) 10JanZerebecki: Fix language fallback in value formatters (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203189 (https://phabricator.wikimedia.org/T94563) (owner: 10Daniel Kinzler) [14:12:20] (03CR) 10JanZerebecki: [C: 032] Fix language fallback in value formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203189 (https://phabricator.wikimedia.org/T94563) (owner: 10Daniel Kinzler) [14:12:57] (03PS2) 10Aude: Batch deletions in pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203371 (https://phabricator.wikimedia.org/T95707) [14:15:39] (03Merged) 10jenkins-bot: Fix language fallback in value formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203189 (https://phabricator.wikimedia.org/T94563) (owner: 10Daniel Kinzler) [14:20:55] (03CR) 10Aude: "this stuff still needs tests but prefer to do in follow up so the changes here are more clear" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203371 (https://phabricator.wikimedia.org/T95707) (owner: 10Aude) [14:32:40] (03Draft2) 10Addshore: Implement EditFilterHookRunner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204768 [14:33:58] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Usage tracking update / purging on edit and re-parse - https://phabricator.wikimedia.org/T96373#1215432 (10daniel) 3NEW [14:34:56] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Track "touched" timestamp for each entry in the usage tracking table. - https://phabricator.wikimedia.org/T96374#1215438 (10daniel) 3NEW [14:35:08] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Track "touched" timestamp for each entry in the usage tracking table. - https://phabricator.wikimedia.org/T96374#1215438 (10daniel) [14:35:21] (03PS3) 10Daniel Kinzler: Track page-touched via UsageTracker. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204060 (https://phabricator.wikimedia.org/T96374) [14:36:53] yay EditFilter! [14:37:08] >_< [14:38:58] (03CR) 10Aude: "EditFilter is a recurring problem, when comes to integration with other extensions and this code sometimes not being run by jenkins / not " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204768 (owner: 10Addshore) [14:40:11] aude: yeh, I want to get the hook running on redirect creations, so need to use this code in the RedirectInteractor, hence factoring it out [14:40:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1215458 (10daniel) [14:40:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Support language fallbacks in wbformatvalue - https://phabricator.wikimedia.org/T94563#1215457 (10daniel) 5Open>3Resolved [14:40:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Server-side rendering for all property links in the JS UI - https://phabricator.wikimedia.org/T88426#1215459 (10daniel) [14:40:24] addshore: i see [14:40:24] will write some tests.... (apparently there were none? :O) :P [14:40:45] there might be some but then not sure they get run always [14:40:56] :) [14:41:13] * aude sometimes only finds bugs by having abusefilter, spam blacklist enabled [14:42:07] That's why I usually disable spam blacklist [14:42:51] some extensions i have if ( !defined( 'MW_PHPUNIT_TEST' ) ) { then require extension } [14:43:01] i don't think spamblacklist is one of them though [14:43:14] it's central auth and beta features :/ [15:06:17] (03PS3) 10Addshore: Implement EditFilterHookRunner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204768 [15:07:14] (03CR) 10Addshore: "Indeed Aude!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204768 (owner: 10Addshore) [15:13:08] it's a hoo :) [15:14:19] Yep [15:16:02] aude: Property: is no content namespace on Wikidata :O [15:16:21] Yeah [15:16:35] I manually added it to the searched namespace at some point due to that [15:18:49] hoo: what means manually? [15:19:14] Well, I added it to the list explicitly (because it's not a content namespace) [15:19:15] AFAIR [15:20:21] * benestar will prepare a patch for mediawiki-config [15:20:29] hoo: or better include it in Wikibase directly? [15:20:51] doing it via configuration is fine [15:20:59] We just have to check all side effects [15:21:04] yeah [15:21:14] you can also undo the manual listing in wgSerachNamespaces then [15:21:26] I'm though not sure if Wikibase shouldn't include it per default [15:22:02] I'm not sure we consider it content, actually [15:22:10] category pages also aren't content [15:22:15] Lydia_WMDE might know [15:31:33] (03PS1) 10Tamslo: Split extensions [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204784 [15:32:03] (03CR) 10jenkins-bot: [V: 04-1] Split extensions [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204784 (owner: 10Tamslo) [15:35:12] (03PS1) 10Aude: Split code out of pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204786 [15:35:56] (03PS2) 10Tamslo: Baseline commit [extensions/WikidataQualityConstraints] - 10https://gerrit.wikimedia.org/r/204761 [15:36:50] (03CR) 10jenkins-bot: [V: 04-1] Split code out of pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204786 (owner: 10Aude) [15:38:04] * aude hates php 5.3 [15:39:39] (03PS2) 10Aude: Split code out of pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204786 [15:40:24] (03CR) 10JanZerebecki: [C: 04-1] "Looks good, except the unused option is still there. Should there still be a different limit than batch for the entire script run?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203371 (https://phabricator.wikimedia.org/T95707) (owner: 10Aude) [15:41:06] (03CR) 10jenkins-bot: [V: 04-1] Split code out of pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204786 (owner: 10Aude) [15:41:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MediaWiki-extensions-AbuseFilter, 7Need-volunteer: AbuseFilter doesn't log creating redirects in mainspace - https://phabricator.wikimedia.org/T72715#1215616 (10Addshore) a:3Addshore [15:42:50] (03CR) 10JanZerebecki: "(Probably not, as there are time options to not prune.)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203371 (https://phabricator.wikimedia.org/T95707) (owner: 10Aude) [15:43:59] (03PS3) 10Aude: Split code out of pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204786 [15:44:01] (03PS3) 10Aude: Batch deletions in pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203371 (https://phabricator.wikimedia.org/T95707) [15:44:55] (03CR) 10Aude: "I think batch size together with the other options are sufficient for this script." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203371 (https://phabricator.wikimedia.org/T95707) (owner: 10Aude) [15:46:44] (03PS1) 10Tamslo: Adapted composer.json and inserted translations [extensions/WikidataQualityExternalValidation] - 10https://gerrit.wikimedia.org/r/204789 [15:54:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Replace stuff in WikibaseRepo hooks with mechanism in core for disabling direct editing of content types - https://phabricator.wikimedia.org/T96382#1215671 (10aude) 3NEW a:3aude [15:54:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Replace stuff in WikibaseRepo hooks with mechanism in core for disabling direct editing of content types - https://phabricator.wikimedia.org/T96382#1215679 (10aude) [15:57:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Replace stuff in WikibaseRepo hooks with mechanism in core for disabling direct editing of content types - https://phabricator.wikimedia.org/T96382#1215685 (10aude) first step is to add the mechanism in... [15:59:38] (03PS4) 10Addshore: Implement EditFilterHookRunner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204768 (https://phabricator.wikimedia.org/T72715) [15:59:40] (03PS1) 10Addshore: Run EditFilterHooks in RedirectCreationInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204790 (https://phabricator.wikimedia.org/T72715) [16:03:54] (03PS2) 10Addshore: Run EditFilterHooks in RedirectCreationInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204790 (https://phabricator.wikimedia.org/T72715) [16:08:50] (03CR) 10JanZerebecki: [C: 032] Batch deletions in pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203371 (https://phabricator.wikimedia.org/T95707) (owner: 10Aude) [16:12:08] (03Merged) 10jenkins-bot: Batch deletions in pruneChanges script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203371 (https://phabricator.wikimedia.org/T95707) (owner: 10Aude) [16:26:33] (03CR) 10Bene: "The use case is that somebody wants to create an article which does not exist in a wiki but has articles on other languages' Wikipedias." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204529 (owner: 10Bene) [16:35:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Automatically drop redundant sitelink to redirect when merging in wbmergeitems api module - https://phabricator.wikimedia.org/T85347#1215810 (10Addshore) a:3Addshore [16:36:15] (03CR) 10Hoo man: "@Bene: But that would require the result to only include items that have at least one sitelink, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204529 (owner: 10Bene) [16:36:17] (03CR) 10Bene: "Code looks good, though I didn't test this locally yet. Please add test cases that the redirect doesn't get created when an EditFilter fo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204790 (https://phabricator.wikimedia.org/T72715) (owner: 10Addshore) [16:36:34] jzerebecki: DanielK_WMDE http://harddawn.com/why-are-cats-immune-to-chemtrails/ [16:38:25] (03CR) 10Bene: Run EditFilterHooks in RedirectCreationInteractor (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204790 (https://phabricator.wikimedia.org/T72715) (owner: 10Addshore) [16:39:25] jzerebecki: DanielK_WMDE so there is just one result for nyancat on commons... https://commons.wikimedia.org/w/index.php?search=nyancat&title=Special%3ASearch&go=Go&uselang=en [16:45:04] jzerebecki: I looked up my phone problems btw... it's actually a (known) software problem only happening with a very rare mainboard revision :P [17:01:28] (03CR) 10Hoo man: [C: 04-1] "Some nitpicks, looks good :)" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204786 (owner: 10Aude) [17:07:40] hoo|away: is there a software fix? [17:10:57] (03CR) 10Daniel Kinzler: "Normalizing needs an API call to the client wiki. We'd do that for every conflicting sitelinks, so up to about 800 or so. That can take lo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204811 (https://phabricator.wikimedia.org/T85347) (owner: 10Addshore) [17:13:36] (03CR) 10Addshore: "No, the alternative is a user has to do the same requests / more." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204811 (https://phabricator.wikimedia.org/T85347) (owner: 10Addshore) [17:14:21] (03PS17) 10Daniel Kinzler: Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) [17:16:06] (03CR) 10Daniel Kinzler: Language fallback for badge labels in SpecialSetSiteLink (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204540 (owner: 10Daniel Kinzler) [17:17:32] (03CR) 10Daniel Kinzler: "My idea would be to abort after the first mismatch." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204811 (https://phabricator.wikimedia.org/T85347) (owner: 10Addshore) [17:17:34] (03CR) 10jenkins-bot: [V: 04-1] Drop redundant sitelinks when merging items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204811 (https://phabricator.wikimedia.org/T85347) (owner: 10Addshore) [17:17:43] DanielK_WMDE: good idea! :) [17:19:51] JeroenDeDauw: use a clean room reimplementation https://commons.wikimedia.org/wiki/File:Nyan_tomcat.gif [17:22:15] or some nsfw human cosplays [17:24:30] jzerebecki: :D [17:24:49] jzerebecki: yeah, Sandra did not mention the image has to be SFW :D [17:24:58] (03PS3) 10Daniel Kinzler: Language fallback for badge labels in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204540 [17:29:10] JeroenDeDauw: haha https://commons.wikimedia.org/wiki/File:Skrillex_live_in_Berlin.jpg has an image of the real nyancat projected on stage, though a bit cut off [17:29:16] (03PS5) 10Daniel Kinzler: Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 [17:30:25] (03PS3) 10Addshore: Run EditFilterHooks in RedirectCreationInteractor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204790 (https://phabricator.wikimedia.org/T72715) [17:31:10] EditFilterHooksRunner )-; [17:31:42] (03PS5) 10Daniel Kinzler: Introduce DedupeBag. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204486 [17:33:51] (03PS2) 10Addshore: Drop redundant sitelinks when merging items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204811 (https://phabricator.wikimedia.org/T85347) [17:34:28] (03CR) 10Addshore: "As an exception if thrown every time there is a miss-match it will already abort on the first failure." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204811 (https://phabricator.wikimedia.org/T85347) (owner: 10Addshore) [17:34:41] DanielK_WMDE: don't like EditFilterHooksRunner? :P [17:37:45] addshore: projects.haykranen.nl/java/ [17:38:05] :P [17:38:10] thanks, benestar ;) [17:38:56] RunnerHookFilterEdit? :P [17:42:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: AbuseFilter warnings not triggered when creating an item - https://phabricator.wikimedia.org/T47537#1216128 (10Addshore) I just checked the code path and it looks looks like this should be working.. SpecialNewEntity::execute SpecialWiki... [17:42:23] jzerebecki: guess I could take a picture of the window here [17:44:07] would probably work [17:46:38] JeroenDeDauw: "there would be an image of nyancat here if nyancat where freely licensed and not trademarked" [17:47:34] jzerebecki: or just ~=[,,_,,]:3 ? [17:48:54] render it pixelated or with a pixel-font [18:13:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Redirects - Try to detect and auto fix double redirects before they happen - https://phabricator.wikimedia.org/T71167#1216284 (10Addshore) Well AFAIK the software now doesn't allow for redirecting to a redirect, a RedirectCreationExcepti... [19:17:40] (03CR) 10Hoo man: [C: 04-1] "(Untested)" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204752 (owner: 10Bene) [19:38:14] (03CR) 10Hoo man: [C: 032] "While I can see aude's concerns (form an earlier PS) this is just putting the status quo into php doc, so ok for now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 (owner: 10Thiemo Mättig (WMDE)) [21:00:35] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service, 5Patch-For-Review: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1217005 (10Smalyshev) The problem with special predicates is that right now we already have 8 types of predicates. Adding novalue ones would mean tak... [22:08:31] (03PS2) 10Tamslo: Split extensions [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204784 [22:29:26] (03CR) 10Hoo man: [C: 04-1] "I have a few nitpicks... nice to finally see this happen." (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204811 (https://phabricator.wikimedia.org/T85347) (owner: 10Addshore) [22:31:09] (03PS2) 10Daniel Kinzler: Making sub-writer behavior more robust. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204953 [22:50:41] (03CR) 10Hoo man: [C: 04-1] Implement EditFilterHookRunner (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204768 (https://phabricator.wikimedia.org/T72715) (owner: 10Addshore) [22:57:34] (03CR) 10Hoo man: [C: 04-1] "I have a few nit picks, but should be fine (only had a quick look given the -1 on the underlying change)." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204790 (https://phabricator.wikimedia.org/T72715) (owner: 10Addshore) [22:57:42] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vv7TY [22:57:42] 13WikibaseDataModel/06master 142c6435d 15Jeroen De Dauw: Merge pull request #447 from wmde/moreBits... [23:09:46] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #116 14df94af3: Then it is true, since Entity is a subtype of EntityDocument. 02http://git.io/vv7I8 [23:10:39] (03CR) 10Hoo man: [C: 04-1] "No blockers (despite the missing qqq)" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [23:11:52] (03CR) 10Hoo man: Create a new special page to list properties by data type (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [23:15:47] (03CR) 10Jeroen De Dauw: [C: 04-1] Implement EditFilterHookRunner (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204768 (https://phabricator.wikimedia.org/T72715) (owner: 10Addshore) [23:25:34] (03CR) 10Jeroen De Dauw: "Return of the Addshore!" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204768 (https://phabricator.wikimedia.org/T72715) (owner: 10Addshore) [23:26:14] hoo: djeez, reviewing code that is so bound to MediaWiki is odd [23:28:17] yeah [23:28:46] Quite surprised we still don't have a separation between unit and integartion tests [23:28:48] wtf [23:30:42] Yeah [23:30:54] We have a phpunit subfolder only [23:31:04] which is a split by technology, not by type [23:31:30] should keep js and php seperate tho [23:31:33] Also the namespaces of the tests are messed all over the place [23:31:58] that's not ideal, though not important compared to other issues we have [23:32:11] the ns being messed up don't cause fail in other places [23:32:32] yeah [23:32:36] not having seperation between unit and integration is in that people are less likely to pay attention to the difference when writing code or reviewing it [23:32:52] Katie has done some work on at least tagging the tests that need the database [23:40:40] 10Wikidata: Separate unit tests from integration tests - https://phabricator.wikimedia.org/T96458#1217440 (10JeroenDeDauw) 3NEW [23:40:47] hoo: ^ [23:42:08] 10Wikidata: Separate unit tests from integration tests - https://phabricator.wikimedia.org/T96458#1217456 (10JeroenDeDauw) [23:46:19] (03CR) 10Hoo man: [C: 04-1] Add redirect info to wbgetentities result (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204758 (https://phabricator.wikimedia.org/T88902) (owner: 10Addshore) [23:47:57] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Separate unit tests from integration tests - https://phabricator.wikimedia.org/T96458#1217498 (10hoo) [23:48:06] JeroenDeDauw: Thanks :) [23:48:38] Guess we need to ahve a clear definition of integration/unit tests beforehand [23:48:46] and not just what people think [23:52:26] hoo: will clarify [23:58:55] hmmm... actually a single rule might be enough to determine if someone can quality as unit test [23:59:10] "Is not affected by configuration (such as MediaWiki config, database config or Wikibase settings)" [23:59:58] Mh [23:59:59] That includes all cases where one depends on framework state and construction ones own object graph