[01:08:40] (03PS5) 10Catrope: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197383 (https://phabricator.wikimedia.org/T91073) (owner: 10Anomie) [01:08:59] 10Wikidata, 10MediaWiki-API, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Update Wikidata for ApiResult rewrite - https://phabricator.wikimedia.org/T91073#1211171 (10Jdforrester-WMF) [01:09:10] 10Wikidata, 10MediaWiki-API, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Update Wikidata for ApiResult rewrite - https://phabricator.wikimedia.org/T91073#1073637 (10Jdforrester-WMF) [01:24:56] (03CR) 10jenkins-bot: [V: 04-1] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197383 (https://phabricator.wikimedia.org/T91073) (owner: 10Anomie) [03:15:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Availability-Team, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: batch deletions in pruneChanges script - https://phabricator.wikimedia.org/T95707#1211361 (10aaron) A few minor log entries: 2015-04-15 07:45:01 terbium wikidatawiki: Query affecte... [06:57:37] (03CR) 10Hoo man: [C: 04-1] Always reset the badgeItems setting in tests (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203355 (owner: 10Bene) [07:34:09] 10Wikidata, 10Wikidata-Quality: dumps - https://phabricator.wikimedia.org/T88677#1211662 (10Tamslo) [07:34:11] 10Wikidata, 10Wikidata-Quality: evaluate additional GND-dumps - https://phabricator.wikimedia.org/T88678#1211661 (10Tamslo) 5Open>3Resolved [08:04:18] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06specificReturns from 14ce845e4 to 14df94af3: 02http://git.io/vvoc5 [08:04:18] 13WikibaseDataModelSerialization/06specificReturns 14df94af3 15Thiemo Mättig: Fix overly unspecific return object tags [08:05:32] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #116 14df94af3: I tried but it's not that easy. The whole class depends on Entity. Please merge this and try to phase out Entity in an other patch. 02http://git.io/vvoCU [08:12:06] [13WikibaseDataModel] 15thiemowmde comment on pull request #443 14bb25ce5: Define "sane". PHPUnit does not add much magic on top of PHP's. It delegates the object comparison to PHP. We already run into horrifying problems when comparing list objects that extend one of PHP's classes. I'm very alarmed whenever I see something like this. I will not merge this PR. 02http://git.io/vvoWy [08:18:21] [13WikibaseSerializationJavaScript] 15mariushoch 04deleted 06testNsDepends at 140ef5a75: 02http://git.io/vvo8S [08:19:23] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06refListFromObj from 141468210 to 1439553d4: 02http://git.io/vvo4B [08:19:23] 13WikibaseDataModel/06refListFromObj 1439553d4 15Thiemo Mättig: Add test to construct ReferenceList from ReferenceList [08:26:23] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06snaksEmpty from 14d7d5da0 to 14a6d07d2: 02http://git.io/vvoRo [08:26:23] 13WikibaseDataModel/06snaksEmpty 14a6d07d2 15Thiemo Mättig: Not all Snaks implementations do have an isEmpty [08:28:23] (03CR) 10Hoo man: [C: 032] Avoid constructing message keys if not necesarry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203867 (owner: 10Thiemo Mättig (WMDE)) [08:31:18] [13Wikiba.se] 15Benestar created 06proper-dom-headings (+1 new commit): 02http://git.io/vvoEf [08:31:18] 13Wikiba.se/06proper-dom-headings 1412e3151 15Bene*: User proper dom headings for "Resources"... [08:35:37] (03CR) 10jenkins-bot: [V: 04-1] Avoid constructing message keys if not necesarry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203867 (owner: 10Thiemo Mättig (WMDE)) [08:36:09] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06constructors3 from 141e05594 to 141de33f4: 02http://git.io/vv2cD [08:36:09] 13WikibaseDataModel/06constructors3 141de33f4 15Thiemo Mättig: Rework ...List constructors [08:41:02] (03PS13) 10Daniel Kinzler: Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) [08:41:10] (03CR) 10jenkins-bot: [V: 04-1] Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) (owner: 10Daniel Kinzler) [08:42:04] (03CR) 10Hoo man: [C: 04-1] "Looks good despite" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [08:42:37] (03CR) 10Hoo man: [V: 04-1] "Also needs a manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [08:55:35] [13WikibaseDataModel] 15thiemowmde created 06minorSmell (+1 new commit): 02http://git.io/vvoVF [08:55:35] 13WikibaseDataModel/06minorSmell 1404c5d08 15Thiemo Mättig: Fix minor code smell issues [08:56:56] [13WikibaseDataModel] 15thiemowmde opened pull request #445: Fix minor code smell issues (06master...06minorSmell) 02http://git.io/vvowZ [08:58:51] [13Wikiba.se] 15thiemowmde 04deleted 06proper-dom-headings at 1412e3151: 02http://git.io/vvowj [08:59:49] (03PS7) 10Bene: Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) [09:01:38] (03PS8) 10Bene: Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) [09:04:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: add a new datatype for identifiers - https://phabricator.wikimedia.org/T95682#1211753 (10Bene) [09:04:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: JSON should (optionally) contain full URIs for referenced external entities - https://phabricator.wikimedia.org/T73992#1211752 (10Bene) [09:06:44] wmde/WikibaseDataModel/constructors3/1de33f4 : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58721477 [09:08:18] (03PS1) 10Tamslo: Code Cleanup for External Validation [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204471 [09:10:19] (03CR) 10jenkins-bot: [V: 04-1] Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [09:13:23] (03PS1) 10Thiemo Mättig (WMDE): Drop unused use clauses from client/lib/repo/view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204472 [09:15:13] jenkins seems broken :/ [09:16:04] wmde/WikibaseDataModel/minorSmell/04c5d08 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58723696 [09:18:17] benestar: for one thing, i think anomie's api changes got merged [09:18:38] don't know if it is related [09:18:43] aude: those introducing static methods everywhere? :'( [09:19:13] apparently [09:20:04] (03CR) 10jenkins-bot: [V: 04-1] Drop unused use clauses from client/lib/repo/view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204472 (owner: 10Thiemo Mättig (WMDE)) [09:20:24] * aude gets failures now [09:20:56] gnah [09:21:05] why do they do so evil things on core? [09:21:09] :( [09:23:34] aude: perhaps replacing '*' by 0 in api results should work [09:23:44] * benestar tries [09:28:12] ugh {"warnings":{"wbsetsitelink":{"warnings":"Unrecognized value for parameter 'badges': Q6"}}, [09:28:20] aude: apperently that is the new syntax :O [09:31:00] (03PS2) 10Tamslo: Code Cleanup for External Validation [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204471 [09:31:04] some of https://gerrit.wikimedia.org/r/#/c/197383/ might fix some issues [09:31:07] * aude not really sure [09:35:49] (03CR) 10Soeren.oldag: [C: 032 V: 031] Code Cleanup for External Validation [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204471 (owner: 10Tamslo) [09:36:38] (03Merged) 10jenkins-bot: Code Cleanup for External Validation [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204471 (owner: 10Tamslo) [09:40:33] (03PS14) 10Daniel Kinzler: Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) [09:40:41] (03CR) 10jenkins-bot: [V: 04-1] Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) (owner: 10Daniel Kinzler) [09:46:42] (03PS1) 10Thiemo Mättig (WMDE): Drop dead class properties, variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204474 [09:49:07] (03PS1) 10Thiemo Mättig (WMDE): Fix non-existing ConnectionManager class name in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204475 [09:50:17] (03PS1) 10Thiemo Mättig (WMDE): Specific return types in MockClientStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204476 [09:50:51] (03PS1) 10Thiemo Mättig (WMDE): Split mock creation in UnDeserializableValueFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204478 [09:52:24] (03PS1) 10Thiemo Mättig (WMDE): Fix type warning snippets all over the code base [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204479 [09:56:06] (03CR) 10jenkins-bot: [V: 04-1] Drop dead class properties, variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204474 (owner: 10Thiemo Mättig (WMDE)) [09:57:21] (03PS2) 10Thiemo Mättig (WMDE): Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [09:58:18] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Bene, I think this is a formatter issue and unrelated to this class." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [09:58:57] (03CR) 10jenkins-bot: [V: 04-1] Fix non-existing ConnectionManager class name in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204475 (owner: 10Thiemo Mättig (WMDE)) [09:59:32] (03CR) 10jenkins-bot: [V: 04-1] Split mock creation in UnDeserializableValueFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204478 (owner: 10Thiemo Mättig (WMDE)) [10:01:40] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-04-16T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/204480 [10:01:44] (03CR) 10jenkins-bot: [V: 04-1] Specific return types in MockClientStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204476 (owner: 10Thiemo Mättig (WMDE)) [10:05:37] (03CR) 10jenkins-bot: [V: 04-1] Fix type warning snippets all over the code base [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204479 (owner: 10Thiemo Mättig (WMDE)) [10:09:15] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015-04-16T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/204480 (owner: 10WikidataBuilder) [10:11:19] (03CR) 10jenkins-bot: [V: 04-1] Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [10:15:04] hi folks, question: is there a way to find counts (decreasing, highest first) of how many languages have articles that en.wiki does not have? [10:15:33] I'm thinking it would be a good way to find subjects I could create articles about at en.wiki [10:20:03] (03PS15) 10Daniel Kinzler: Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) [10:20:40] (03CR) 10Daniel Kinzler: "PS14 addresses several of the comments on PS3" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) (owner: 10Daniel Kinzler) [10:26:58] (03CR) 10jenkins-bot: [V: 04-1] Split RdfBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) (owner: 10Daniel Kinzler) [10:32:01] (03CR) 10Bene: [C: 032] Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [10:33:08] (03CR) 10JanZerebecki: [C: 032 V: 032] "Was broken by a change in core, so submitting despite jenkins as this won't break any more than already is." [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/204480 (owner: 10WikidataBuilder) [10:33:38] nobody? [10:39:31] (03CR) 10jenkins-bot: [V: 04-1] Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [10:55:13] norbert: i think there was a tool for this. can you check Wikidata:Tools? if you don't find one there i suggest asking on Wikidata:Project chat [10:55:21] if no-one here knows [11:00:49] (03PS1) 10Daniel Kinzler: Introduce DedupeBag. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204486 [11:04:41] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review: Deprecate and remove Claims class - https://phabricator.wikimedia.org/T78281#1211915 (10thiemowmde) In case you wonder, the discussion of this ticket continues on GitHub: https://github.com/wmde/WikibaseDataModel/issues/157#issuecomment-93708324 [11:10:32] (03CR) 10jenkins-bot: [V: 04-1] Introduce DedupeBag. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204486 (owner: 10Daniel Kinzler) [11:28:25] aude: any progress on fixing jenkins? [11:56:39] Lydia_WMDE norbert: perhaps https://www.wikidata.org/wiki/Special:ItemsWithoutSitelinks could/should be extended by such a functionality [11:57:07] perhaps, yes [12:12:56] (03PS1) 10Tamslo: Fix specialpage type hints [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204493 [12:13:59] how is that ordered [12:14:19] #2 is "Indian Wedding Cards" with Q19803258, weird [12:20:26] (03CR) 10Soeren.oldag: [C: 032 V: 031] Fix specialpage type hints [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204493 (owner: 10Tamslo) [12:23:23] Lydia_WMDE: did what you suggested http://www.wikidata.org/wiki/Wikidata_talk:Tools#Idea:_numerically_sorted_overview_of_the_total_number_of_interwiki_sitelinks_per_article [12:23:35] because I don't think a tool or page exists for this [12:23:37] (03Merged) 10jenkins-bot: Fix specialpage type hints [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204493 (owner: 10Tamslo) [12:23:59] cool .) [12:27:47] Lydia_WMDE: oh, the code already supports that :O [12:28:01] I will create a form on top of the special page to select a site :D [12:28:02] (also added an example) [12:28:09] benestar: sweet [12:28:22] Lydia_WMDE: dropdown or free text input for the site? [12:28:28] * benestar tends to free text [12:28:31] benestar: it was my idea :) [12:28:41] norbert: I know ;) [12:28:57] benestar: on some special pages we had a selector with text input for the site id [12:29:01] but that broke [12:29:07] :(( [12:29:09] and i think aude looked into it over the last days [12:29:13] i think this would be best here too [12:29:19] baseically like the item selector but for sites [12:29:45] I'm super curious what will be at the top (most interwiki sitelinks but no en.wiki) [12:31:57] (03PS1) 10Tamslo: Small refactoring [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204495 [12:34:59] (03CR) 10Soeren.oldag: [C: 032 V: 031] Small refactoring [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204495 (owner: 10Tamslo) [12:35:33] (03Merged) 10jenkins-bot: Small refactoring [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204495 (owner: 10Tamslo) [12:51:12] 10Wikidata, 10MediaWiki-API, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Update Wikidata for ApiResult rewrite - https://phabricator.wikimedia.org/T91073#1211999 (10Tobi_WMDE_SW) a:3aude [12:51:31] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Remove deprecated claim methods from Entity - https://phabricator.wikimedia.org/T78290#1212001 (10Tobi_WMDE_SW) a:3thiemowmde [12:52:52] benestar: any thoughts on the time frame; is it something you'll be able to code? [12:53:29] (03PS1) 10Tamslo: Another code cleanup [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204498 [12:54:19] norbert: I'm just working on it, will be finished today perhaps [12:54:27] neat [12:54:34] however, it has to go through code review and will have to wait for the next deployment [12:54:39] so perhaps a month or so? [12:54:43] auch :P [12:56:25] Lydia_WMDE: when is the next deployment btw? [12:56:27] benestar, Lydia_WMDE https://tools.wmflabs.org/wikidata-terminator/?list&mode=tx [12:57:17] benestar: should be next week [12:57:37] I do not fully understand that page, but someone linked to it and it appears to be related to what we talked about [12:57:41] 10Wikidata, 10MediaWiki-API, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Update Wikidata for ApiResult rewrite - https://phabricator.wikimedia.org/T91073#1212005 (10Tobi_WMDE_SW) a:5aude>3None [12:58:21] or rather, it's exactly what we talked about except the page is incorrect? [12:58:35] I mean, why would it list, for example, China [12:59:52] I really don't know enough about it all to judge the quality and how on-topic it is [13:00:39] oh, that's weird [13:00:45] https://als.wikipedia.org/wiki/China really does not list en.wiki [13:02:20] how come https://en.wikipedia.org/wiki/China has all the links while the others don't see en.wiki? [13:11:58] norbert: strange indeed. The database has an entry for the link to en:China on Q148. [13:12:04] aude: any idea? [13:13:22] (03PS1) 10Daniel Kinzler: Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 [13:13:55] i don't see the issue [13:14:08] https://als.wikipedia.org/wiki/Volksrepublik_China has enwiki link [13:14:54] oh, i see, als has two articles [13:15:18] the other one is about Q29520 [13:15:23] ah [13:15:31] norbert: --^ [13:15:35] ah, yeah [13:16:14] aude: that doesn't exist in english :) [13:18:18] just people https://tools.wmflabs.org/wikidata-terminator/?list&mode=tx&q=claim[31:5] [13:18:22] (03CR) 10jenkins-bot: [V: 04-1] Introduce MentionedEntityTracker for tracking mentioned interfaces. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204501 (owner: 10Daniel Kinzler) [13:18:24] quite interesting [13:24:41] (03PS1) 10Dominic.sauer: add qqx as language and add some matchers [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204502 [13:33:38] aude: Guten Tag. Of course the Zuul layout change complains :( https://gerrit.wikimedia.org/r/#/c/204029/ [13:33:49] what did i do wrong? [13:34:01] some yaml error apparently https://integration.wikimedia.org/ci/job/tox-py27/885/console [13:34:06] :( [13:34:08] :00:28.022 ParserError: while parsing a block mapping [13:34:08] 00:00:28.022 in "/mnt/jenkins-workspace/workspace/tox-py27/tests/../zuul/layout.yaml", line 225, column 11 [13:34:08] 00:00:28.022 expected , but found '-' [13:34:08] 00:00:28.023 in "/mnt/jenkins-workspace/workspace/tox-py27/tests/../zuul/layout.yaml", line 276, column 11 [13:34:23] aude: yeah you are missing a space in the indentation [13:34:54] :( [13:35:10] yeah I wish my editor had a syntax check for that [13:35:15] it happens to me often :( [13:35:17] or [13:35:21] it often happens to me [13:35:39] * hashar shakes English words and generate new sentences [13:35:50] new patch [13:36:27] once we have isolated instances to run code, we will dish out those black/white lists [13:36:37] good :) [13:37:53] it is good to see interns joining in! [13:38:00] :) [13:38:06] not using github for this [13:38:14] maybe the can rewrite wikibase / mediawiki to python? [13:38:22] heh [13:46:04] deployed! [13:48:27] (03CR) 10Daniel Kinzler: Fix parsing of quantities with scientific notation (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [13:51:14] (03PS3) 10Daniel Kinzler: Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) [13:51:59] (03PS1) 10Aude: Update Wikidata tests for core api changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204510 [13:52:24] (03PS2) 10Aude: Update Wikidata tests for core api changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204510 (https://phabricator.wikimedia.org/T91073) [14:01:09] (03PS1) 10Thiemo Mättig (WMDE): Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) [14:01:20] (03CR) 10jenkins-bot: [V: 04-1] Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [14:02:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: separate out entity selector for 3rd party usage - https://phabricator.wikimedia.org/T96247#1212117 (10Lydia_Pintscher) 3NEW [14:03:30] (03CR) 10Daniel Kinzler: [C: 032] "The _idx attributes in the XML output are somewhat strange, but extra attributes shouldn't hurt. And we really need to fix Jenkins." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204510 (https://phabricator.wikimedia.org/T91073) (owner: 10Aude) [14:03:54] (03CR) 10Anomie: "There may be some overlap here with I847a4a5a." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204510 (https://phabricator.wikimedia.org/T91073) (owner: 10Aude) [14:05:53] (03CR) 10Aude: "there might be, but don't think that covers everything here." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204510 (https://phabricator.wikimedia.org/T91073) (owner: 10Aude) [14:13:36] (03CR) 10Anomie: "Going to try" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204510 (https://phabricator.wikimedia.org/T91073) (owner: 10Aude) [14:15:00] (03Merged) 10jenkins-bot: Update Wikidata tests for core api changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204510 (https://phabricator.wikimedia.org/T91073) (owner: 10Aude) [14:15:08] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Daniel, I can't reproduce the error you are describing. Please recheck and post the error message you get. Otherwise I will merge this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [14:17:28] aude: SQL question: is it possible to get the count of occurences of a value in a table which is joined to another table? [14:18:19] i think so [14:18:40] sounds scary though... depends what it is [14:19:54] aude: I want to get the list of items without sitelinks for a specific site ordered by the count of sitelinks the item has [14:20:00] (03PS6) 10Daniel Kinzler: Update ApiResult handling for mediawiki/core change I7b37295e [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197383 (https://phabricator.wikimedia.org/T91073) (owner: 10Anomie) [14:20:21] (03CR) 10Thiemo Mättig (WMDE): Fix parsing of quantities with scientific notation (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [14:20:32] aude: whats done at the moment is joining wb_items_per_site against wb_entity_per_page [14:21:30] (03CR) 10jenkins-bot: [V: 04-1] Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [14:25:50] 10Wikidata, 7Easy: Edit button keeps fixed positioned after canceling - https://phabricator.wikimedia.org/T96248#1212147 (10Fomafix) 3NEW [14:27:27] (03CR) 10jenkins-bot: [V: 04-1] Update ApiResult handling for mediawiki/core change I7b37295e [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197383 (https://phabricator.wikimedia.org/T91073) (owner: 10Anomie) [14:29:40] (03CR) 10Daniel Kinzler: [C: 031] "@thiemo: CR+1 for your changes to the test." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [14:29:48] (03CR) 10Daniel Kinzler: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [14:38:46] DanielK_WMDE_ as jenkins is broken shall I submit your patch anyways? [14:39:27] benestar: it's no longer broken [14:39:32] the patch is actually failing a test [14:39:58] oh, I see [14:40:05] will fixc [14:40:44] what? [14:41:57] ah, not my patch [14:42:11] (03CR) 10Bene: Fix parsing of quantities with scientific notation (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [14:43:09] (03CR) 10Bene: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [14:52:18] Thiemo_WMDE: [-+]?[0123456789,\.]+(?:(?:[eE]|x10\^)[-+]?[0123456789]+)? [14:52:32] Thiemo_WMDE: the problem is that i'm getting a match for group 1 [14:52:42] there should not be a group one, right? [14:52:47] what am i missing? [14:53:08] (03CR) 10Aude: "i think the change is sensible to do." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) (owner: 10Bene) [14:54:06] DanielK_WMDE_: are you sure it's not group 0? [14:54:12] yes. [14:54:26] (03CR) 10Aude: "if the spacing between description and label can be adjusted some, then think I could (personally, in my opinion) be okay with the changes" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) (owner: 10Bene) [14:55:13] aude: maybe move the edit button in the line with the "In other languages" toggle? [14:55:37] especially because that's the area which gets actually edited [14:55:48] i actually had proposed that :) [14:56:01] but there were some issue with how i did it [14:56:10] and the current situation was okayish [14:56:10] (03PS4) 10Daniel Kinzler: Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) [14:56:18] benestar: let's see if this one works now. [14:56:59] DanielK_WMDE_: did you read "Add sth like 123+456 to catch missing e/E" ? [14:57:11] https://gerrit.wikimedia.org/r/#/c/196011/ [14:58:00] benestar: as a test case? [14:58:03] yes [14:58:08] will do [14:59:12] aude: that's exactly what I wrote, right? :D [14:59:16] benestar: '1+1' is already tested as invalid input, is that sufficient? [14:59:20] ywH [14:59:24] YEAH [14:59:26] gah [14:59:32] DanielK_WMDE_: yes, missed that :/ [15:00:04] it's in the QuantityParserTest. Will add it to the unlocalizer test [15:00:06] think what i did made it sticky there [15:00:09] when scrolling [15:00:24] might work to just put it there and have sticky [15:00:37] aude: what was the problem there? [15:00:44] simply removing the top: 0 works for me ^^ [15:01:03] (03PS5) 10Daniel Kinzler: Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) [15:01:03] * aude looks [15:02:45] benestar: that sort of works [15:02:50] haha [15:03:14] the vertical alignment is slightly off for me and maybe we want to right align it more [15:03:32] aude: the magic of simplicity ;) [15:03:39] heh [15:03:51] where i put it is good in my opinion, except for the vertical alignment [15:04:14] and thiemo's comments in my patch are reasonable [15:08:26] aude: anyways, my patch does neither solve not increase that problem and is thus not directly dependent on your patch, right? [15:08:32] *nore [15:09:37] benestar: it moves the edit button, but can be solved separately perhaps [15:10:20] tweaking the design like this imho needs more input from others, also [15:10:21] agree [15:10:43] imho it's sane [15:11:37] since I fixed the javascript context, it's really sane imo [15:11:37] :) [15:11:37] the rare case that one of my patches is sane :O [15:11:37] :PP [15:11:39] heh [15:11:53] we might also need selenium tests updated [15:11:58] * benestar mostly commits evil stuff [15:12:04] that would be a separate task [15:12:09] aude: where are they located? [15:12:23] https://github.com/wmde/WikidataBrowserTests [15:17:39] (03CR) 10Bene: [C: 032] Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [15:17:50] DanielK_WMDE_ merged now finally :D [15:18:14] after local testing [15:19:29] (03CR) 10Thiemo Mättig (WMDE): "I did a manual test. Works fine. I did not looked at the code in detail. I wonder: is there a way to split this into more than 1 patche? S" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [15:24:18] (03PS2) 10Thiemo Mättig (WMDE): Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) [15:24:28] (03PS2) 10Thiemo Mättig (WMDE): Fix type warning snippets all over the code base [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204479 [15:24:42] (03PS2) 10Thiemo Mättig (WMDE): Specific return types in MockClientStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204476 [15:24:48] (03PS2) 10Thiemo Mättig (WMDE): Split mock creation in UnDeserializableValueFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204478 [15:24:54] (03PS2) 10Thiemo Mättig (WMDE): Fix non-existing ConnectionManager class name in DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204475 [15:24:59] (03PS2) 10Thiemo Mättig (WMDE): Drop dead class properties, variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204474 [15:25:06] (03PS2) 10Thiemo Mättig (WMDE): Drop unused use clauses from client/lib/repo/view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204472 [15:25:16] (03PS2) 10Thiemo Mättig (WMDE): Avoid constructing message keys if not necesarry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203867 [15:25:55] Lucie_WMDE: https://www.wikidata.org/wiki/Wikidata:Bots [15:26:01] there is a list of bots [15:27:54] Think we need a list of lists [15:29:34] (03Merged) 10jenkins-bot: Fix parsing of quantities with scientific notation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204242 (https://phabricator.wikimedia.org/T67436) (owner: 10Daniel Kinzler) [15:29:42] https://www.wikidata.org/w/api.php?action=query&list=allusers&group=bots [15:30:03] https://www.wikidata.org/w/api.php?action=query&list=allusers&group=bots&aulimit=200&format=json [15:30:13] doesnt' work [15:30:54] https://www.wikidata.org/w/api.php?action=query&list=allusers&augroup=bot [15:31:00] there [15:32:02] https://www.wikidata.org/w/api.php?action=query&list=allusers&augroup=bot&aulimit=200&format=json [15:33:06] DanielK_WMDE_: isn't that https://phabricator.wikimedia.org/T95672 already? or am i missing something? [15:33:40] maybe, but maybe it's a 2-part task [15:33:48] 1) the add the hook [15:33:50] 2) use it [15:40:46] wikimedia/mediawiki-extensions-Wikibase/master/cc781b2 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/58770839 [15:40:56] huh [15:40:59] gerrit is down... [15:42:28] back again, but grrrit-wm seems to be upset nwo [15:42:54] grrrit-wm help [15:42:59] I am running http://meta.wikimedia.org/wiki/WM-Bot version wikimedia bot v. 2.6.4.0 [libirc v. 1.0.3] my source code is licensed under GPL and located at https://github.com/benapetr/wikimedia-bot I will be very happy if you fix my bugs or implement new features [15:42:59] @help [15:44:48] [13Time] 15thiemowmde created 06moveFromLib (+1 new commit): 02http://git.io/vvinr [15:44:48] 13Time/06moveFromLib 148a9b571 15Thiemo Mättig: Move MonthNameUnlocalizer and PhpDateTimeParser from WB.git [15:46:01] * benestar gives grrrit-wm a cookie [15:47:37] [13Time] 15thiemowmde opened pull request #60: Move MonthNameUnlocalizer and PhpDateTimeParser from WB.git (06master...06moveFromLib) 02http://git.io/vvicN [15:48:33] 10Wikidata, 10DataValues, 5Patch-For-Review: Release data-values/time 0.7 - https://phabricator.wikimedia.org/T96137#1212458 (10thiemowmde) [15:51:28] 10Wikidata, 10Continuous-Integration: Add Wikidata to Jenkins job mediawiki-extensions-hhvm - https://phabricator.wikimedia.org/T96264#1212470 (10JanZerebecki) 3NEW [15:54:12] 10Wikidata, 10Continuous-Integration: Add Wikidata to Jenkins job mediawiki-extensions-hhvm - https://phabricator.wikimedia.org/T96264#1212470 (10JanZerebecki) Make sure to avoid problems like in T95897. [15:57:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Performance, 10Wikidata-Sprint-2015-04-07: Prefetch labels on history pages - https://phabricator.wikimedia.org/T95672#1212538 (10daniel) [15:58:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Performance, 10Wikidata-Sprint-2015-04-07: Prefetch labels on history pages - https://phabricator.wikimedia.org/T95672#1197290 (10daniel) Blocked on core patch that introduces the hook we'll use to trigger the pre-fetching: Ie10ef99154d [16:03:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Performance, 10Wikidata-Sprint-2015-04-07: Prefetch labels on history pages - https://phabricator.wikimedia.org/T95672#1212574 (10Lydia_Pintscher) [16:04:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Cannot enter power of ten for quantity datatype - https://phabricator.wikimedia.org/T67436#1212579 (10daniel) 5Open>3Resolved [16:04:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Quantity datatype (tracking) - https://phabricator.wikimedia.org/T56318#1212580 (10daniel) [16:07:00] 10Wikidata, 10Continuous-Integration, 10Wikidata-Sprint-2015-04-07: the changed job configuration extension-unittests -> extension-unittests-generic for Wikidata.git makes it not run all tests and fail - https://phabricator.wikimedia.org/T95897#1212599 (10JanZerebecki) p:5High>3Normal [16:19:12] it's a dennyvrandecic :D [16:19:12] benestar: indeed! :) [16:22:52] [13WikibaseDataModel] 15Benestar pushed 1 new commit to 06master: 02http://git.io/vviik [16:22:52] 13WikibaseDataModel/06master 14b1e9b3b 15Bene*: Merge pull request #445 from wmde/minorSmell... [16:23:00] [13WikibaseDataModel] 15Benestar 04deleted 06minorSmell at 1404c5d08: 02http://git.io/vviiq [16:39:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Image thumbnail urls should be included where applicable in wikidata API response for commonsMedia - https://phabricator.wikimedia.org/T76827#1212694 (10Jdlrobson) [16:42:28] benestar: https://gerrit.wikimedia.org/r/#/c/204540/ [16:42:30] [13WikidataBrowserTests] 15Benestar created 06label-in-firstHeading (+1 new commit): 02http://git.io/vviHh [16:42:30] 13WikidataBrowserTests/06label-in-firstHeading 14cb5e40a 15Bene: Check that label is in firstHeading... [16:42:58] [13WikidataBrowserTests] 15Benestar opened pull request #72: Check that label is in firstHeading (06master...06label-in-firstHeading) 02http://git.io/vviQV [16:44:42] DanielK_WMDE_: great, will test asap :) [16:45:09] aude: I tried to adapt the dom changes in the browser tests: https://github.com/wmde/WikidataBrowserTests/pull/72 [16:45:32] is the syntax etc correct? I have no idea of ruby tbh ^^ [16:47:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 10Wikidata-Sprint-2015-04-07: not possible to remove sitelinks using Special:SetSitelink - https://phabricator.wikimedia.org/T64707#1212729 (10Bene) 5Open>3Resolved [16:53:24] benestar: aude is on the road [17:02:38] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Remove deprecated claim methods from Entity - https://phabricator.wikimedia.org/T78290#1212797 (10daniel) One of the patches is marked [DNM] for some reason: https://gerrit.wikimedia.org/r/#/c/202453/ Also, are there additi... [17:07:18] [13Time] 15brightbyte closed pull request #47: Add more cases to the CalendarModelParser (06master...06calParser) 02http://git.io/xhg2 [17:10:38] [13Time] 15brightbyte comment on pull request #54 14e89d3cd: Just make the arguments to the test function optional. Much more obvious than this post-processing here. 02http://git.io/vvPUn [17:12:24] [13Time] 15brightbyte comment on pull request #57 148565ded: "normalize", not "validate", since it returns the value in normalized form. 02http://git.io/vvPTM [17:12:41] [13Time] 15brightbyte closed pull request #57: More TimeValue tests (06master...06tvAgain) 02http://git.io/jDpJ [17:16:54] wikimedia/mediawiki-extensions-Wikibase/master/1ba907a : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/58780247 [17:18:33] [13Time] 15brightbyte closed pull request #59: Remove misleading calendar model output (06master...06nonGreg) 02http://git.io/vvW5e [17:21:38] [13Time] 15brightbyte pushed 1 new commit to 06master: 02http://git.io/vvPtp [17:21:38] 13Time/06master 14b11d2e7 15Daniel Kinzler: Merge pull request #60 from DataValues/moveFromLib... [17:22:28] 10Wikidata, 10DataValues, 5Patch-For-Review: Release data-values/time 0.7 - https://phabricator.wikimedia.org/T96137#1212896 (10daniel) [17:23:42] 10Wikidata, 10DataValues, 5Patch-For-Review: Release data-values/time 0.7 - https://phabricator.wikimedia.org/T96137#1209163 (10daniel) I merged most of the patches, PR49 is still pending review, and PR54 needs a rebase, but seems fine otherwise. [18:06:15] wikimedia/mediawiki-extensions-Wikibase/master/fea69d4 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/58784201 [18:06:57] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: language fallback - https://phabricator.wikimedia.org/T76216#1213163 (10JanZerebecki) [18:07:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: add language fallback to entity search/suggester (wbsearchentities) - https://phabricator.wikimedia.org/T76150#1213162 (10JanZerebecki) 5Open>3Resolved [18:07:54] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Support language fallbacks in wbformatvalue - https://phabricator.wikimedia.org/T94563#1213171 (10JanZerebecki) a:3daniel [19:55:05] (03CR) 10Soeren.oldag: [C: 031 V: 032] add qqx as language and add some matchers [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204502 (owner: 10Dominic.sauer) [19:55:24] (03CR) 10Soeren.oldag: [C: 032 V: 031] add qqx as language and add some matchers [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204502 (owner: 10Dominic.sauer) [19:55:54] (03Merged) 10jenkins-bot: add qqx as language and add some matchers [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204502 (owner: 10Dominic.sauer) [19:56:30] (03CR) 10Soeren.oldag: [C: 032 V: 031] Another code cleanup [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204498 (owner: 10Tamslo) [19:56:32] (03CR) 10jenkins-bot: [V: 04-1] Another code cleanup [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204498 (owner: 10Tamslo) [20:14:53] (03CR) 10Raimond Spekking: "i18n review" (031 comment) [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/204502 (owner: 10Dominic.sauer) [20:45:14] (03CR) 10Bene: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203867 (owner: 10Thiemo Mättig (WMDE)) [20:50:27] (03CR) 10Bene: [C: 032] Avoid constructing message keys if not necesarry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203867 (owner: 10Thiemo Mättig (WMDE)) [20:53:41] (03Merged) 10jenkins-bot: Avoid constructing message keys if not necesarry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203867 (owner: 10Thiemo Mättig (WMDE)) [20:55:05] DanielK_WMDE_: still here? [20:55:35] 10Wikidata: Entity pages should link to machine readable version using tags in the html head - https://phabricator.wikimedia.org/T96298#1213652 (10daniel) 3NEW [20:56:02] Seems so [20:56:42] benestar: hm, slightly drunk, though :P [20:56:45] what's up? [20:56:52] haha [20:57:06] WikibaseRepo::getEntityIdHtmlLinkFormatterFactory() is actually private [20:57:16] can I make it public for usage in Special:ListProperties? [20:58:00] benestar: check if there is a better way first. but in general that should be fine. add a test case if you make it public, please [20:58:11] ok [20:58:39] the magic label injector stuff is scary :/ [20:59:23] benestar: i have also been wandering whether we should have a shorthand for getting a standard fallback chain [20:59:40] maybe adding a getter for that to WikibaseRepo would be better than exposing the factory [20:59:48] yeah [20:59:52] Yeah, thought about that as well [21:00:02] when reviewing the getentities change [21:00:12] lots of code duplication caused by all those LanguageFallbackChainFactory usages [21:00:15] that would reduce the risk that we use fallback chains with different flags set all over the place [21:00:21] +1 [21:00:52] Duesendrunk: do I get it right, that TermBuffer should be called once before the results are displayed for performance reasons? [21:01:23] we could still have a parameter for the fallback mode, with a sensible default. [21:01:28] benestar: yea [21:03:12] that blows up my simple special page quite a lot :/ [21:03:22] special pages need lots of refactoring [21:03:29] benestar: check out BufferingTermLookup [21:03:29] * benestar notes to himself [21:04:51] catering to performance often makes code less elegant. [21:05:11] in order to take shortcuts, the abstraction has to be a bit leaky... [21:06:08] Duesendrunk: hmm, LanguageFallbackChainFactory::newFromContext vs ::newFromLanguage [21:07:05] Why doesn't wd_auto_desc_wd_always_show = true ; work anymore? [21:07:34] Oh, now it works -_- [21:08:10] Duesendrunk playing a Duesenberg guitar in Düsseldorf? [21:09:44] lazowik: i'd have to take a Duesenplane [21:09:53] oh, right [21:10:22] also, I'd head for Duisburg ;) [21:10:25] (03CR) 10Hoo man: [C: 032] Add getPropertyInfoForDataType to PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204535 (owner: 10Bene) [21:10:45] at least it would be the same timezone, so you wouldn't have a Duesenlag [21:10:55] :D [21:11:37] oh, it's getEntityIdHtmlLinkFormatterFactory not getEntityIdHtmlLinkFormatter :((( [21:12:41] argh, I'm lost in the forest of factories [21:12:48] i wonder why... WikibaseRepo knows how to get a LabelDescriptionLookup, right? [21:13:08] when did we introduce this java style? :P [21:13:10] * lazowik just put Duesen into google translate and realised the unintended pun [21:13:18] Duesendrunk: Nope, it doesn't [21:13:19] benestar: we should expose them less. If we do not *need* to pass them around, WikibaseRepo should use the factory, not expose it [21:13:22] benestar: forest of factories? :D [21:13:34] hoo: ah, that's why, then [21:13:39] lazowik: indeed :P [21:13:50] (03Merged) 10jenkins-bot: Add getPropertyInfoForDataType to PropertyInfoStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204535 (owner: 10Bene) [21:13:50] lazowik: for an unintended pun it was quite good :D [21:14:12] yeah, I kinda surprised myself :p [21:14:28] hoo: ah, but is has getTermLookup() [21:15:32] found in java: SimpleBeanFactoryAwareAspectInstanceFactory [21:15:50] benestar: i guess it would be use useful for WikibaseRepo to have a getLanguageFallbackLabelLookup method, at least. Or even one for getting an EntityidHtmlLinkFormatter. [21:16:03] I can't think clearly enough right not to find the best level of abstraction :) [21:16:04] (03CR) 10Hoo man: [C: 032] Fix some issues in SpecialWikibaseQueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204533 (owner: 10Bene) [21:16:13] Yes, but we have to take care that WikibaseRepo won't explode by providing too many shortcuts [21:17:54] benestar: yes, it should be split. All UI related stuff should be separate. And more things should move to Store. [21:18:17] maybe even create another class like store for other things [21:18:28] for UI things, yes [21:19:00] LabelLookup is kind of Store *and* UI, thought [21:19:05] (03Merged) 10jenkins-bot: Fix some issues in SpecialWikibaseQueryPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204533 (owner: 10Bene) [21:21:54] (03CR) 10Hoo man: [C: 032] Fix type warning snippets all over the code base [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204479 (owner: 10Thiemo Mättig (WMDE)) [21:24:38] (03CR) 10Hoo man: [V: 04-1] "Looks good, needs manual rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204236 (owner: 10Thiemo Mättig (WMDE)) [21:25:04] (03Merged) 10jenkins-bot: Fix type warning snippets all over the code base [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204479 (owner: 10Thiemo Mättig (WMDE)) [21:29:27] Duesendrunk: that's what I looked for :D http://projects.haykranen.nl/java/ [21:29:41] hoo --^ [21:29:46] gn8 [21:30:18] oO [21:30:21] good night [21:30:25] oh, that makes life so much easier! [21:30:32] i'll use that a lot :D [21:30:51] InstanceParameterModelProccesor! We need that! [22:00:44] (03CR) 10Bene: "As mentioned in irc the edit button should be moved to another place anyways (next to the "In other languages" toggle afaik) so that shoul" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) (owner: 10Bene) [22:14:17] (03PS1) 10Hoo man: Use Scribunto's libraryUtil.check* functions to verify types [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204644 [22:43:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Include redirects in RDF rendering. - https://phabricator.wikimedia.org/T69033#1214107 (10Smalyshev) [22:56:42] (03CR) 10Hoo man: "Just for the record: The query this produces isn't (significantly) worse than what we already have (and what we already have is bad as it " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204529 (owner: 10Bene) [22:59:55] (03CR) 10Hoo man: [C: 04-1] "Didn't spot this initially" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 (owner: 10Thiemo Mättig (WMDE)) [23:06:57] question: what is the relationship between entities and redirects? Is there an easy way to know if certain entity is a redirect and to where? [23:07:01] (03CR) 10Hoo man: Show labels in edit summaries on history/diff pages (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [23:07:31] (03PS4) 10Hoo man: Show labels in edit summaries on history/diff pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) [23:07:45] (03CR) 10Hoo man: "Changed order of checks, per Daniel" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [23:10:34] (03CR) 10Hoo man: "Thiemo: Do you have any opinion here? I can change the return doc, if there's an agreement to do that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [23:35:25] (03PS3) 10Jeroen De Dauw: Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [23:39:34] (03CR) 10jenkins-bot: [V: 04-1] Major update of ChangeOpsClaim[Remove] to get rid of Claims [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [23:43:58] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06snaksEmpty at 14a6d07d2: 02http://git.io/vv1HJ [23:45:33] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #443: Use assertEquals for comparing reference lists in test (06refListFromObj...06refListEq) 02http://git.io/vv2kL [23:47:49] (03CR) 10Jeroen De Dauw: "Broke tests..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/204511 (https://phabricator.wikimedia.org/T78281) (owner: 10Thiemo Mättig (WMDE)) [23:50:57] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #116 14df94af3: What do you mean with it not being that easy? What problem occurs when using this type hint? 02http://git.io/vv1QN