[08:17:02] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyProp from 140adf354 to 14c20edce: 02http://git.io/vee0v [08:17:02] 13WikibaseDataModel/06emptyProp 14c20edce 15Thiemo Mättig: Drop long deprecated Property::newEmpty [08:18:01] (03Abandoned) 10Tamslo: Began to implement violations table [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203067 (owner: 10Tamslo) [08:34:35] [13WikibaseDataModel] 15thiemowmde created 06addClaimIndex (+1 new commit): 02http://git.io/vvOf9 [08:34:35] 13WikibaseDataModel/06addClaimIndex 14dcf592f 15Thiemo Mättig: Drop index parameter from Claims::addClaim [08:36:15] [13WikibaseDataModel] 15thiemowmde opened pull request #435: Drop index parameter from Claims::addClaim (06master...06addClaimIndex) 02http://git.io/vvOJc [08:38:14] wmde/WikibaseDataModel/addClaimIndex/dcf592f : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58238700 [08:45:08] [13WikibaseDataModel] 15thiemowmde created 06deprecateClaims (+1 new commit): 02http://git.io/vvOkY [08:45:08] 13WikibaseDataModel/06deprecateClaims 147042994 15Thiemo Mättig: Deprecate all public methods in Claims [08:46:42] [13WikibaseDataModel] 15thiemowmde opened pull request #436: Deprecate all public methods in Claims (06master...06deprecateClaims) 02http://git.io/vvOkK [08:49:33] wmde/WikibaseDataModel/deprecateClaims/7042994 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58239639 [08:53:47] [13WikibaseDataModel] 15thiemowmde created 06removeClaim2 (+1 new commit): 02http://git.io/vvOtP [08:53:47] 13WikibaseDataModel/06removeClaim2 145ee6719 15Thiemo Mättig: Drop unused Claims::removeClaim [08:54:50] Lydia_WMDE: I've tried a few things with mobile and it turns out that our javascript depends on modules like jquery.tipsy which are not supported for mobile [08:54:54] [13WikibaseDataModel] 15thiemowmde opened pull request #437: Drop unused Claims::removeClaim (06master...06removeClaim2) 02http://git.io/vvOqU [08:57:34] wmde/WikibaseDataModel/removeClaim2/5ee6719 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58240394 [09:05:04] lol https://m.wikidata.org/wiki/Q15388284#/editor/0 [09:06:21] (03PS1) 10Tamslo: Began to implement violations table [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203792 [09:06:23] (03CR) 10jenkins-bot: [V: 04-1] Began to implement violations table [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203792 (owner: 10Tamslo) [09:09:27] (03Abandoned) 10Tamslo: Began to implement violations table [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203792 (owner: 10Tamslo) [09:13:11] [13WikibaseDataModel] 15thiemowmde created 06hasClaim (+1 new commit): 02http://git.io/vvOGZ [09:13:11] 13WikibaseDataModel/06hasClaim 14f422388 15Thiemo Mättig: Drop Claims::hasClaim [09:13:23] [13WikidataBrowserTests] 15WMDE-Fisch comment on pull request #68 14e212c44: Yes RuboCop is set up and normally it should check that by default. I experimented with adding the corresponding parameters to the .rubocop,yml. But RuboCop sill passes even with the violation. ... strange. Could a bug in RuboCop... 02http://git.io/vvOGW [09:13:33] [13WikibaseDataModel] 15thiemowmde opened pull request #438: Drop Claims::hasClaim (06master...06hasClaim) 02http://git.io/vvOGB [09:14:28] benestar: :( [09:16:42] wmde/WikibaseDataModel/hasClaim/f422388 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58241928 [09:16:43] [13WikidataBrowserTests] 15WMDE-Fisch created 06rubocop_update (+1 new commit): 02http://git.io/vvOZV [09:16:43] 13WikidataBrowserTests/06rubocop_update 14011b3ca 15WMDE-Fisch: updated RuboCop and added base configuration... [09:17:23] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #70: updated RuboCop and added base configuration (06master...06rubocop_update) 02http://git.io/vvOZQ [09:23:22] (03PS1) 10Thiemo Mättig (WMDE): Make stuff in SetClaimTest private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 [09:32:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Hovercards, 7Need-volunteer, 5Patch-For-Review: Make Hovercards work on Wikidata item links - https://phabricator.wikimedia.org/T69434#1202384 (10Lydia_Pintscher) @samb: @bene made it work with a local hack. [09:34:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: new formatter to format identifiers as URLs - https://phabricator.wikimedia.org/T95684#1202387 (10Lydia_Pintscher) @bugreporter: Ah that is good to know. Thanks for bringing it up. [09:36:18] (03PS1) 10Thiemo Mättig (WMDE): Replace last remaining Claims::hasClaim call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203795 [09:40:10] (03PS1) 10Andreasburmeister: changed parameter of special pages to upper case [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203797 [09:43:04] (03CR) 10Jonaskeutel: [C: 032 V: 032] changed parameter of special pages to upper case [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203797 (owner: 10Andreasburmeister) [09:52:55] Lydia_WMDE: would a read only mobile view already help a bit? [10:00:20] benestar: yes that's what john has been working on with m.wikidata.org [10:00:30] and what the open tickets are complaining about :D [10:00:51] there are some hacks in the local css to hide broken things [10:00:58] but they're kinda essential [10:01:11] like references and ranks and so on [10:01:33] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-04-13T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203800 [10:02:09] yes, I've seen that [10:02:29] Lydia_WMDE: so https://phabricator.wikimedia.org/T78430 is only for read access, right? [10:02:31] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015-04-13T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203800 (owner: 10WikidataBuilder) [10:02:44] I'll create another ticket for editing then, ok? [10:02:50] sounds good :) [10:06:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: setting languages with Babel boxes does not work for global user page - https://phabricator.wikimedia.org/T95877#1202430 (10Lydia_Pintscher) 3NEW [10:07:04] (03PS1) 10Thiemo Mättig (WMDE): Replace deprecated Claims::hasClaimWithGuid method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203801 [10:07:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Make Wikidata editable on mobile web - https://phabricator.wikimedia.org/T95878#1202437 (10Bene) 3NEW [10:08:00] (03CR) 10Daniel Kinzler: [C: 04-1] Fix language fallback in value formatters (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203189 (https://phabricator.wikimedia.org/T94563) (owner: 10Daniel Kinzler) [10:08:28] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Getting Wikidata to render nicely on mobile web [Tracking] - https://phabricator.wikimedia.org/T78430#1202445 (10Bene) [10:08:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Make Wikidata editable on mobile web - https://phabricator.wikimedia.org/T95878#1202444 (10Bene) [10:08:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Make Wikidata editable on mobile web [Tracking] - https://phabricator.wikimedia.org/T95878#1202446 (10Bene) [10:10:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: inconsistent capitalization adaption between property and item selection - https://phabricator.wikimedia.org/T95879#1202450 (10Lydia_Pintscher) 3NEW [10:12:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202457 (10Bene) 3NEW [10:13:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202457 (10Bene) [10:15:43] 10Wikidata: get Wikidata browser tests running on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T95863#1202468 (10Lydia_Pintscher) p:5Triage>3Normal [10:18:09] (03PS4) 10Bene: Put the label into the .firstHeading element [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) [10:18:15] [13WikidataBrowserTests] 15thiemowmde comment on pull request #70 14011b3ca: Removing newlines at EOF is odd. 02http://git.io/vvOoY [10:18:17] (03CR) 10Andreasburmeister: [C: 032 V: 031] HtmlTable now supports spanned cells. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203320 (owner: 10Soeren.oldag) [10:23:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202480 (10Bene) [10:23:50] (03CR) 10Aude: "looks okay. just an observation and maybe we want to add a fixme in the code." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 (owner: 10Thiemo Mättig (WMDE)) [10:24:41] (03CR) 10Aude: Replace last remaining Claims::hasClaim call (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203795 (owner: 10Thiemo Mättig (WMDE)) [10:25:15] (03CR) 10Aude: "the changes look okay, except for saw a typo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203795 (owner: 10Thiemo Mättig (WMDE)) [10:29:24] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06rubocop_update: 02http://git.io/vvOin [10:29:24] 13WikidataBrowserTests/06rubocop_update 14ea8b8a4 15WMDE-Fisch: adding eof newlines [10:30:59] (03Merged) 10jenkins-bot: HtmlTable now supports spanned cells. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203320 (owner: 10Soeren.oldag) [10:33:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1202487 (10Bene) 3NEW [10:33:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1202487 (10Bene) [10:34:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1202487 (10Bene) [10:34:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Getting Wikidata to render nicely on mobile web [Tracking] - https://phabricator.wikimedia.org/T78430#1202496 (10Bene) [10:35:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Allow adding images as P18 using the upload image button - https://phabricator.wikimedia.org/T95881#1202487 (10Bene) [10:35:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7Tracking: Make Wikidata editable on mobile web [Tracking] - https://phabricator.wikimedia.org/T95878#1202498 (10Bene) [10:35:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1202500 (10Bene) [10:42:40] [13WikidataBrowserTests] 15thiemowmde pushed 2 new commits to 06master: 02http://git.io/vvO10 [10:42:40] 13WikidataBrowserTests/06master 14ba0892c 15WMDE-Fisch: adding brackets to fulfil coding conventions [10:42:40] 13WikidataBrowserTests/06master 14b029aa0 15Thiemo Mättig: Merge pull request #69 from wmde/brackets_rubocop... [10:46:48] (03CR) 10jenkins-bot: [V: 04-1] Replace deprecated Claims::hasClaimWithGuid method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203801 (owner: 10Thiemo Mättig (WMDE)) [10:47:45] (03PS2) 10Thiemo Mättig (WMDE): Replace last remaining Claims::hasClaim call [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203795 [10:48:08] jzerebecki: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/lib/config/WikibaseLib.default.php#L52 [10:48:13] so it's set there (used in repo) [10:48:17] and in client differently [10:48:41] (03CR) 10Thiemo Mättig (WMDE): "English is odd. ;-) Will need to prepare a patch for the remaining 32 instances of "can not" in our code base. ;-)" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203795 (owner: 10Thiemo Mättig (WMDE)) [10:48:44] (03CR) 10jenkins-bot: [V: 04-1] Put the label into the .firstHeading element [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203681 (https://phabricator.wikimedia.org/T93534) (owner: 10Bene) [11:05:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: add language fallback to entity search/suggester (wbsearchentities) - https://phabricator.wikimedia.org/T76150#1202553 (10daniel) [11:05:53] (03PS1) 10Daniel Kinzler: Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) [11:07:14] (03PS2) 10Daniel Kinzler: Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) [11:10:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: new formatter to format identifiers as URLs - https://phabricator.wikimedia.org/T95684#1202557 (10daniel) @Bugreporter: We would need to implement normalization (aka parsing) and validation based on patterns defined on-wiki (as regular expressions, perhaps... [11:11:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: add language fallback to entity search/suggester (wbsearchentities) - https://phabricator.wikimedia.org/T76150#1202558 (10daniel) [11:11:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: add language fallback to entity search/suggester (wbsearchentities) - https://phabricator.wikimedia.org/T76150#1202560 (10daniel) a:3daniel [11:13:08] (03CR) 10jenkins-bot: [V: 04-1] Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) (owner: 10Daniel Kinzler) [11:14:32] orr. [11:33:40] (03PS1) 10Tamslo: Implemented violations table [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203807 [11:54:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Use different/new diff view for entity diffs - https://phabricator.wikimedia.org/T95883#1202612 (10Bene) 3NEW [11:54:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Use different/new diff view for entity diffs on mobile - https://phabricator.wikimedia.org/T95883#1202612 (10Bene) [11:55:54] benestar: Nice screenshot. ;) [11:56:19] ;) [11:58:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 5Patch-For-Review, 7Tracking: Avoid having two h1 headings on Wikidata - https://phabricator.wikimedia.org/T93534#1202624 (10Bene) [11:59:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MediaWiki-Search, 6Mobile-Web: search for Wikidata should use entity selector on mobile as well - https://phabricator.wikimedia.org/T85368#1202628 (10Bene) [12:01:58] Lydia_WMDE: hey :) [12:02:39] what do you think about the sitelinks on mobile? Currently they are hidden per "I'm not sure what purpose it serves in a view mode on mobile" [12:04:38] benestar: wtf [12:05:28] (03CR) 10Thiemo Mättig (WMDE): Make stuff in SetClaimTest private (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 (owner: 10Thiemo Mättig (WMDE)) [12:05:34] Lydia_WMDE: https://phabricator.wikimedia.org/T85363#anchor-947473 [12:05:56] they are hidden via local css on m.wikidata.org [12:06:07] that part i knew [12:06:09] yeah [12:06:23] so I'm thinking if hiding them is what we want ;) [12:06:34] imho no [12:07:00] (03CR) 10Jonaskeutel: [C: 032 V: 032] "Very nice, but maybe have a look at my comments about the tests." (033 comments) [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203807 (owner: 10Tamslo) [12:07:35] (03Merged) 10jenkins-bot: Implemented violations table [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203807 (owner: 10Tamslo) [12:09:01] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06getIndexByGuid from 14fed62a4 to 14f60bb18: 02http://git.io/vv3kJ [12:09:01] 13WikibaseDataModel/06getIndexByGuid 14f60bb18 15jeroendedauw: Change StatementList::getIndexByGuid to take a guid rather than a Statement [12:12:57] Lydia_WMDE: We could adapt the "sections" feature from MobileFrontend [12:13:18] benestar: and then collapse? [12:13:19] benestar: expand and collapse sections? [12:13:43] yeah [12:13:55] makes sense to me [12:13:57] this would provide same user experience cross sites [12:14:04] yeah [12:14:14] the question is, which sections to collapse [12:14:16] and for mobile, it's a lot of stuff [12:14:45] we can a) use a section for statements and one for sitelinks or b) use one section for each property in the statements section and show sitelinks in another way [12:14:47] * aude thinks statements and site links [12:15:09] I tend to b) because for a) we only have two sections which are really large perhaps [12:15:10] yeah definitely nto for each statement [12:15:32] a subsection maybe, like h3? [12:15:34] Lydia_WMDE: I mean not for each statement but for each group of statements per property [12:15:42] i don't know if that is collapsable [12:15:46] only h2 will collapse on MobileFrontend [12:15:53] benestar: but most of the time that'd still be just one [12:16:04] and remember that we will move out identifiers [12:16:09] into their own section [12:16:13] Lydia_WMDE: I dont think so [12:16:45] [13WikibaseDataModel] 15thiemowmde created 06snakListConstructor (+1 new commit): 02http://git.io/vv3tG [12:16:45] 13WikibaseDataModel/06snakListConstructor 143a776c4 15Thiemo Mättig: Add SnakList constructor [12:17:00] every item where we have a problem of too many statements we can group them easily [12:19:34] wmde/WikibaseDataModel/snakListConstructor/3a776c4 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58261020 [12:20:42] [13WikibaseDataModel] 15thiemowmde opened pull request #439: Add SnakList constructor (06master...06snakListConstructor) 02http://git.io/vv3ml [12:20:55] Lydia_WMDE: do you understand what I mean? [12:21:48] benestar: i think i do but i still think we should start with one collapsible section for statements and see how it is behaving when used with real content [12:22:44] Lydia_WMDE: huh, only one section at all? [12:23:09] one for statements and one for sitelinks [12:23:12] if we only have one section we do not have to collapse it because there is nothing beyond it [12:23:16] and then later a 3rd one for identifiers [12:23:38] sorry ;-) [12:24:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Decide how to use table of contents on mobile Wikidata - https://phabricator.wikimedia.org/T95884#1202649 (10Bene) 3NEW [12:26:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web, 7JavaScript: sitelink section not shown on mobile - https://phabricator.wikimedia.org/T85363#1202659 (10Bene) @FriedhelmW Sitelinks are hidden in [[ https://www.wikidata.org/wiki/MediaWiki:Mobile.css | MediaWiki:Mobile.css ]] and thus they... [12:26:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: sitelink section not shown on mobile - https://phabricator.wikimedia.org/T85363#1202660 (10Bene) [12:28:55] [13WikibaseDataModel] 15thiemowmde created 06notNull (+1 new commit): 02http://git.io/vv3OW [12:28:55] 13WikibaseDataModel/06notNull 14ce1b925 15Thiemo Mättig: Do not allow null in Reference[List] constructors [12:30:04] [13WikibaseDataModel] 15thiemowmde opened pull request #440: Do not allow null in Reference[List] constructors (06master...06notNull) 02http://git.io/vv3OP [12:32:28] wmde/WikibaseDataModel/notNull/ce1b925 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58262395 [12:47:27] [13WikibaseDataModel] 15thiemowmde created 06refListFromObj (+1 new commit): 02http://git.io/vv3CO [12:47:27] 13WikibaseDataModel/06refListFromObj 141468210 15Thiemo Mättig: Add test to construct ReferenceList from ReferenceList [12:48:18] [13WikibaseDataModel] 15thiemowmde opened pull request #441: Add test to construct ReferenceList from ReferenceList (06master...06refListFromObj) 02http://git.io/vv3CS [12:53:34] wmde/WikibaseDataModel/refListFromObj/1468210 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58264700 [12:59:59] (03PS1) 10Daniel Kinzler: Isolate unit tests for wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203809 [13:00:17] [13WikibaseDataModel] 15thiemowmde created 06noEmptyRef (+1 new commit): 02http://git.io/vv3Rs [13:00:17] 13WikibaseDataModel/06noEmptyRef 147febace 15Thiemo Mättig: Throw exception when adding empty reference [13:02:30] [13WikibaseDataModel] 15thiemowmde opened pull request #442: Throw exception when adding empty reference (06master...06noEmptyRef) 02http://git.io/vv30Z [13:05:54] wmde/WikibaseDataModel/noEmptyRef/7febace : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/58266294 [13:08:30] (03PS1) 10Andreasburmeister: code cleanup [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203810 [13:13:30] (03CR) 10Jonaskeutel: [C: 032 V: 032] code cleanup [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203810 (owner: 10Andreasburmeister) [13:16:44] * hoo waves... at home again [13:16:53] hi :) [13:16:56] hoo :D [13:16:56] [13WikidataBuildResources] 15filbertkm created 06cachekey (+1 new commit): 02http://git.io/vv3Vc [13:16:56] 13WikidataBuildResources/06cachekey 147678daa 15aude: Fix order of including sharedCacheKeyPrefix setting overrides... [13:17:10] (03PS3) 10Daniel Kinzler: Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) [13:17:14] * aude figured out why beta broke [13:17:22] * aude is stupid :P [13:17:52] (03PS4) 10Daniel Kinzler: Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) [13:18:21] aude: lol [13:18:43] What happened to it? [13:19:20] wrong order of inclusion of files [13:19:33] setting overrides need to be after including wikibase :P [13:20:16] (03PS2) 10Aude: Changed default sharedCacheKeyPrefix setting to be string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 [13:20:31] and then jenkins never ran the little bit of tests we had for this in the build resources [13:21:48] (03Abandoned) 10JanZerebecki: New Wikidata Build - 2015-04-12T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203654 (owner: 10WikidataBuilder) [13:24:03] (03CR) 10Aude: [C: 04-1] Changed default sharedCacheKeyPrefix setting to be string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 (owner: 10Aude) [13:27:53] (03CR) 10jenkins-bot: [V: 04-1] Changed default sharedCacheKeyPrefix setting to be string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 (owner: 10Aude) [13:36:11] (03Abandoned) 10JanZerebecki: New Wikidata Build - 2015-04-13T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203800 (owner: 10WikidataBuilder) [13:36:33] (03CR) 10Andreasburmeister: Implemented violations table (031 comment) [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203807 (owner: 10Tamslo) [13:37:59] Thiemo_WMDE: https://integration.wikimedia.org/ci/job/mwext-testextension-zend/79/console [13:45:31] (03PS1) 10Daniel Kinzler: No user-specific fallback in wbgetentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203814 [13:46:08] Lydia_WMDE: ---^ [13:47:42] lydia is running away... [13:50:10] [13WikibaseSerializationJavaScript] 15thiemowmde created 06testNsDepends (+1 new commit): 02http://git.io/vv39f [13:50:10] 13WikibaseSerializationJavaScript/06testNsDepends 140ef5a75 15Thiemo Mättig: Remove not needed jQuery dependency from test [13:50:32] [13WikibaseSerializationJavaScript] 15thiemowmde opened pull request #17: Remove not needed jQuery dependency from test (06master...06testNsDepends) 02http://git.io/vv39q [13:51:51] (03PS3) 10Aude: Changed default sharedCacheKeyPrefix setting to be string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 [13:53:01] (03CR) 10Daniel Kinzler: "@thiemo as commented, this patch *does* fix the fallback behavior for labels. It doesn't change the behavior for number formatting, since " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203189 (https://phabricator.wikimedia.org/T94563) (owner: 10Daniel Kinzler) [14:03:39] legoktm: from extension-unittests to extension-unittests-generic for Wikidata.git (the build output) made it fail and only runs 1/10 of the tests. compare https://integration.wikimedia.org/ci/job/mwext-testextension-zend/75/console https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension-zend/175/consoleFull [14:06:35] (03PS3) 10Daniel Kinzler: Fix language fallback in value formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203189 (https://phabricator.wikimedia.org/T94563) [14:09:09] Lydia_WMDE: the way we display the section headlines in Wikibase does not work with mobile frontend [14:09:19] I investigated quite a time in that now ... [14:12:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Show collapisble sections for Statements and Sitelinks - https://phabricator.wikimedia.org/T95889#1202790 (10Bene) 3NEW [14:13:29] (03CR) 10Daniel Kinzler: "I'm confused... why do we need a separate copyright message for each special page? And are they already defined?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203669 (https://phabricator.wikimedia.org/T50983) (owner: 10Bene) [14:15:19] (03CR) 10jenkins-bot: [V: 04-1] Fix language fallback in value formatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203189 (https://phabricator.wikimedia.org/T94563) (owner: 10Daniel Kinzler) [14:15:35] (03CR) 10Bene: "We use the same copyright message, but the button's text changes from page to page. On Special:NewItem it is 'Create', on Special:SetSiteL" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203669 (https://phabricator.wikimedia.org/T50983) (owner: 10Bene) [14:16:47] (03CR) 10Bene: Show correct label in copyright message on special pages (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203669 (https://phabricator.wikimedia.org/T50983) (owner: 10Bene) [14:17:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Show collapisble sections for Statements and Sitelinks - https://phabricator.wikimedia.org/T95889#1202798 (10Bene) [14:21:20] (03CR) 10Daniel Kinzler: "What you describe makes sense, but it is hard to see if and why the code change would have that effect. Are there any tests for this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203540 (owner: 10Bene) [14:21:49] (03CR) 10Hoo man: Make use of EntityPrefetcher in dumps, wbgetentities (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203306 (owner: 10Hoo man) [14:22:08] (03CR) 10Bene: "I will write one ;)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203540 (owner: 10Bene) [14:22:55] (03PS3) 10Hoo man: Make use of EntityPrefetcher in dumps, wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203306 [14:23:26] whoops [14:24:06] (03PS4) 10Hoo man: Make use of EntityPrefetcher in dumps, wbgetentities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203306 [14:24:35] (03CR) 10Hoo man: "Addressed Daniel's comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203306 (owner: 10Hoo man) [14:27:01] (03CR) 10Daniel Kinzler: [C: 04-1] "I'd prefer getLabelConflicts to get a parameter controlling whether the label conflicts should be case sensitive. AS it is now, we silentl" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203531 (https://phabricator.wikimedia.org/T73785) (owner: 10Bene) [14:27:48] aude: Lydia_WMDE: Branch this week? [14:27:58] yes [14:28:26] (03CR) 10Bene: "Yeah, I also thought about making both case insensitive but was not sure if this belongs into this patch or a second one. Shall I prepare " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203531 (https://phabricator.wikimedia.org/T73785) (owner: 10Bene) [14:29:24] (03CR) 10Daniel Kinzler: [C: 04-1] Link to Special:ListProperties on Special:ListDatatypes (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203528 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [14:30:46] (03CR) 10Daniel Kinzler: Link to Special:ListProperties on Special:ListDatatypes (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203528 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [14:33:21] Json dump creation keeps getting slower and slower... [14:33:29] :( [14:33:53] I have a reminder to check the dumps each Monday... and I regularly have to move that back by half an hour [14:34:03] Maybe entity prefetching will help it [14:39:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Implement Unit Selector widget - https://phabricator.wikimedia.org/T77982#1202894 (10Snaterlicious) I agree that having such a widget is necessary as fall-back for entering units--using an entityselector derivative for that... [14:50:20] (03CR) 10Hoo man: [C: 04-1] "This changes our defaults more towards single wiki usage which is IMO ok. I have two nitpicks" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 (owner: 10Aude) [14:54:31] (03PS2) 10Bene: Show the value on Special:SetLabel etc if none is entered [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203540 [15:01:46] (03PS4) 10Bene: Fix removing sitelinks through Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) [15:04:30] Lydia_WMDE: https://phabricator.wikimedia.org/T95889 <-- would you prefer fixing that in MobileFrontend or Wikibase? [15:05:43] 10Wikidata, 10Continuous-Integration: the changed job configuration extension-unittests -> extension-unittests-generic for Wikidata.git makes it not run all tests and fail - https://phabricator.wikimedia.org/T95897#1203016 (10JanZerebecki) 3NEW [15:09:20] (03CR) 10Bene: Link to Special:ListProperties on Special:ListDatatypes (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203528 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [15:11:58] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "This seems to be an incomplete fragment of a much larger patch. The 3 special pages that are build on top of this abstract base class do n" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203540 (owner: 10Bene) [15:16:28] (03CR) 10Hoo man: [C: 04-1] "Had a quick look: Please consider expanding the tests." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [15:18:10] hmmm.... [15:18:16] in a unit test, if I put: [15:18:22] $this->assertFalse( true ); [15:18:23] and then [15:18:28] $this->assertTrue( false ); [15:18:34] only the first failure is reported as failure [15:18:41] in the same test case [15:18:55] how is that? [15:20:11] suppose i can split test case in a way to have only one assertion per test [15:20:39] Lydia_WMDE: Saw the Ant-Man trailer? [15:38:23] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06cachekey: 02http://git.io/vvsPi [15:38:23] 13WikidataBuildResources/06cachekey 144fdd94f 15aude: Add test cases for sharedCacheKeyPrefix setting... [15:41:25] [13WikidataBuildResources] 15filbertkm opened pull request #25: Fix override of sharedCacheKeyPrefix setting and add more tests (06master...06cachekey) 02http://git.io/vvs12 [15:50:56] (03PS4) 10Aude: Changed default sharedCacheKeyPrefix setting to be string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 [15:51:31] (03PS1) 10Tamslo: Implemented ViolationQuery [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203841 [15:51:46] (03PS5) 10Aude: Changed default sharedCacheKeyPrefix setting to be string [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 [15:51:54] (03CR) 10Aude: Changed default sharedCacheKeyPrefix setting to be string (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 (owner: 10Aude) [15:57:51] aude: assert stops the test when it fails [15:58:14] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06master: 02http://git.io/vvsFc [15:58:14] 13WikidataBrowserTests/06master 14040efcc 15WMDE-Fisch: minor when_visible additions [16:00:06] benestar: makes sense [16:00:28] * aude split up the tests to have one assert per test, which is probably good practice [16:01:09] (03CR) 10Bene: "The "second step" is when you enter an id and a language but no value. There is another form shown with the warning if you really want to " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203540 (owner: 10Bene) [16:05:40] (03CR) 10Bene: "Re" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [16:08:15] (03CR) 10Aude: Create a new special page to list properties by data type (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [16:10:44] [13WikidataBrowserTests] 15thiemowmde closed pull request #70: updated RuboCop and added base configuration (06master...06rubocop_update) 02http://git.io/vvOZQ [16:11:35] [13WikidataBrowserTests] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/vvsj4 [16:11:35] 13WikidataBrowserTests/06master 14bb6b9d6 15Thiemo Mättig: Merge pull request #66 from wmde/quantity_T88547... [16:13:00] (03PS3) 10Bene: Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) [16:18:42] (03PS4) 10Bene: Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) [16:22:26] Thiemo_WMDE: can I get some input from you on this patch? https://gerrit.wikimedia.org/r/#/c/203681/ [16:24:24] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06master: 02http://git.io/vvGIT [16:24:24] 13WikidataBrowserTests/06master 14e9d1eae 15WMDE-Fisch: added clicks to focus input fields [16:29:40] jzerebecki: I'm reverting it now, but that doesn't make any sense :/ [16:30:23] legoktm: yes it really makes no sense. [16:30:41] that is why I didn't propose a revert yet. [16:35:59] [13WikidataBrowserTests] 15WMDE-Fisch 04force-pushed 06new_references_T92249 from 145c6388a to 1478fcb9f: 02http://git.io/vvGOq [16:35:59] 13WikidataBrowserTests/06new_references_T92249 1419ed292 15WMDE-Fisch: refactored reference browser test to T87759 [16:35:59] 13WikidataBrowserTests/06new_references_T92249 14a1d30c6 15WMDE-Fisch: fixed removed step [16:35:59] 13WikidataBrowserTests/06new_references_T92249 146c2e45b 15WMDE-Fisch: to_not changed to not_to [16:48:01] jzerebecki: is it an urgent issue and blocking stuff? [16:48:49] legoktm: not right now [16:51:03] legoktm: it will probably be in a day or two [16:51:44] 10Wikidata, 10Continuous-Integration, 10Wikidata-Sprint-2015-04-07: the changed job configuration extension-unittests -> extension-unittests-generic for Wikidata.git makes it not run all tests and fail - https://phabricator.wikimedia.org/T95897#1203481 (10JanZerebecki) [16:58:05] jzerebecki: I'm reverting it now with https://gerrit.wikimedia.org/r/#/c/203858/ and added the generic ones as experimental so we can debug later on [17:02:42] 10Wikidata, 10Continuous-Integration, 10Wikidata-Sprint-2015-04-07: the changed job configuration extension-unittests -> extension-unittests-generic for Wikidata.git makes it not run all tests and fail - https://phabricator.wikimedia.org/T95897#1203533 (10Legoktm) [17:03:27] 10Wikidata, 10Continuous-Integration, 10Wikidata-Sprint-2015-04-07: the changed job configuration extension-unittests -> extension-unittests-generic for Wikidata.git makes it not run all tests and fail - https://phabricator.wikimedia.org/T95897#1203016 (10Legoktm) Reverted for now, the generic jobs are exper... [17:16:04] benestar: sorry - was out :) [17:16:06] [17:04:30] Lydia_WMDE: https://phabricator.wikimedia.org/T95889 <-- would you prefer fixing that in MobileFrontend or Wikibase? [17:16:22] i don't mind either way. what seems cleaner? [17:16:53] (03PS2) 10Thiemo Mättig (WMDE): Replace deprecated Claims::hasClaimWithGuid method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203801 [17:23:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Hovercards, 7Need-volunteer, 5Patch-For-Review: Make Hovercards work on Wikidata item links - https://phabricator.wikimedia.org/T69434#1203646 (10Quiddity) Nifty! It partially works in Q pages, eg {F112386} (at https://www.wikidata.org/wiki/Q14649... [17:23:56] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Fix removing sitelinks through Special:SetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [18:01:03] Thiemo_WMDE: hey, I'm here for discussion ;-) [18:01:04] Lydia_WMDE: perhaps a fix in both extension would be the cleanest way [18:01:05] We should move the sitelink

in front of the div container [18:01:05] *nod* [18:01:05] but allow headings which aren't direct children in MobileFrontend [18:01:06] I will note that on the bug page [18:01:06] ok :) [18:08:30] Lydia_WMDE: got a problem here :( [18:12:07] ? [18:12:07] to be semantically correct, we need obviously a "Sitelinks" heading [18:12:08] urgh [18:12:08] like we have the "Statements" headnig [18:12:08] this heading would be

and the Wikipedia, Wikiquote etc headings would become

[18:12:08] however, Vector styles these headings in a completely different way [18:12:09] i see the problem [18:12:09] :/ [18:12:10] Lydia_WMDE: we could just copy the styles Vector assigns to

headings to the

heading but that's obviously not flexible [18:12:28] we can also just ignore the semantics and add

s in to a

section [18:19:22] but that is not really nice either [18:19:22] right [18:19:23] ok i think this is something we need more input on from thiemo for example [18:19:23] can you put that into the bug? [18:19:24] Yes [18:19:27] Lydia_WMDE: shall I create a subtask for the wikidata heading part? [18:19:27] sounds good :) [18:19:27] Lydia_WMDE: actually the h3 does not look that bad http://snag.gy/mGlOl.jpg [18:21:05] benestar: but not really good either :/ and i wanted to get rid of that [18:21:05] Lydia_WMDE: why not really good? and what to get rid of? [18:21:11] sitelink heading [18:22:17] getting some food - back later [18:23:48] Lydia_WMDE [18:23:48] http://snag.gy/Ilvll.jpg [18:49:57] (03Merged) 10jenkins-bot: Use wfWaitForSlaves instead of our own thing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203362 (owner: 10Aude) [18:49:58] (03PS1) 10Bene: Add heading before sitelinks section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203874 (https://phabricator.wikimedia.org/T95889) [18:50:00] benestar: Did you read the CU? [18:50:00] multichill: CU? [18:50:00] For that guy i blocked [18:50:01] What was again the recommended url if you have a Q id? This is for some other database to link to us [18:50:01] ah that CU [18:50:01] yes, let's keep an eye on that thing [18:50:01] if the user comes back we can just block him for socking [18:50:01] multichill: the canonical url is https://www.wikidata.org/entity/Q123 [18:50:01] Hee keeps coming back every couple of weeks/months. Starts doing good stuff, some point runs into things/people, starts being very direct/abusive to some users [18:50:01] Lydia_WMDE had the joy of experiencing that a couple of months ago [18:50:01] Thanks benestar [18:50:01] Do you know if we have docs somewhere I can link to about https://www.wikidata.org/entity/Q123 ? [18:50:01] multichill: https://www.wikidata.org/wiki/Wikidata:Data_access [18:50:03] https://www.wikidata.org/wiki/Wikidata:Glossary#Entities.2C_items.2C_properties_and_queries [18:50:03] "Each entity has also a dereferenceable URI that follows the pattern http://www.wikidata.org/entity/ID with ID the entity ID." [18:55:18] 10Wikidata, 10Hovercards, 10TextExtracts: Popup/Hover on Wikidata Q pages shows plain /*>! In T78825#1200868, @Bene wrote: > I will prepare another patch set for the Popups extension but if it again takes 3 months to get a... [19:13:09] (03PS2) 10Bene: Add heading before sitelinks section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203874 (https://phabricator.wikimedia.org/T95889) [20:15:05] Lydia_WMDE: with all my patches combined, we have toggleable sections on mobile Wikibase \o/ [20:15:05] \o/ [20:15:05] I can review that... I have played with MF and wikibase in the past [20:15:09] (03CR) 10jenkins-bot: [V: 04-1] Add heading before sitelinks section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203874 (https://phabricator.wikimedia.org/T95889) (owner: 10Bene) [20:15:11] (03PS3) 10Bene: Add heading before sitelinks section [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203874 (https://phabricator.wikimedia.org/T95889) [20:15:11] hoo: I've added you as a reviewer [20:15:11] :) [20:15:12] Lydia_WMDE hoo it would be great if those things could already get merged till the hackathon so we can discuss there further and more significant things [20:15:12] That should be doable, if you can follow up int ime [20:15:17] (03PS1) 10Soeren.oldag: Made some database schema updates and bigger refactorings connected with it. Also refactored Serializer and CheckResults. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203883 [20:15:21] (03PS2) 10Soeren.oldag: Database schema updates and biggerrefactorings connected with it. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203883 [20:15:21] (03PS3) 10Soeren.oldag: Database schema updates and biggerrefactorings connected with it. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203883 [20:15:21] (03CR) 10Hoo man: [C: 031] "Let's give others a chance to see this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203811 (owner: 10Aude) [20:15:24] (03CR) 10Hoo man: [C: 04-1] "The "count( int )" call doesn't really matter as we convert to bool anyway, but still should be fixed IMO." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 (owner: 10Thiemo Mättig (WMDE)) [20:15:34] (03CR) 10Hoo man: [C: 04-1] "Looks good, I have some nit picks, though." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203809 (owner: 10Daniel Kinzler) [20:15:34] Can finally work with an open window again, without freezing :) [20:15:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Mobile-Web: Disable default mobile edit view for Wikibase items - https://phabricator.wikimedia.org/T95880#1204291 (10Florian) @Bene: +1 :) [20:17:59] (03PS2) 10Daniel Kinzler: Isolate unit tests for wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203809 [20:18:13] (03CR) 10Daniel Kinzler: Isolate unit tests for wbsearchentities. (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203809 (owner: 10Daniel Kinzler) [20:21:14] (03PS5) 10Daniel Kinzler: Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) [20:21:50] (03CR) 10Hoo man: [C: 031] "Looks good at a glance now, not manually verified. Tests could still be expanded. I would like someone else to have a look at the changes " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [20:23:57] DanielK_WMDE: Can you merge the remaining entity prefetcher changes? Would really like to have these in the branch [20:26:03] (03CR) 10Hoo man: [C: 032] Isolate unit tests for wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203809 (owner: 10Daniel Kinzler) [20:28:38] (03CR) 10Aude: [C: 04-1] "still have concerns..." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203793 (owner: 10Thiemo Mättig (WMDE)) [20:28:56] (03CR) 10Hoo man: Isolate unit tests for wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203809 (owner: 10Daniel Kinzler) [20:29:08] (03CR) 10Hoo man: [C: 032] "Re-trigger jenkins" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203809 (owner: 10Daniel Kinzler) [20:32:14] hmmm, i no longer have badges [20:32:58] On master? [20:34:28] i think it's my config [20:34:37] badges are back :) [20:34:42] Ok :) [20:35:12] i am trying to understand https://gerrit.wikimedia.org/r/#/c/203778/ [20:35:26] and what is expected behavior [20:37:41] ok, think i get it [20:37:47] (03Merged) 10jenkins-bot: Isolate unit tests for wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203809 (owner: 10Daniel Kinzler) [20:38:11] (03CR) 10Hoo man: "Haven't really looked at this yet, but I'm afraid of this change given this already is a huge performance problem :( Please be very carefu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) (owner: 10Daniel Kinzler) [20:38:19] wb_terms :( [21:03:56] (03PS6) 10Daniel Kinzler: Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) [21:06:16] hoo|away: maybe it needs a feature switch, so we can easily pull the plug. [21:06:26] converting this to elastic shouldn't be too hard... [21:07:44] (03PS4) 10Soeren.oldag: Database schema updates and bigger refactorings connected with it. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203883 [21:13:54] (03CR) 10jenkins-bot: [V: 04-1] Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) (owner: 10Daniel Kinzler) [21:16:31] orr, old phpunit version... [21:17:15] (03PS7) 10Daniel Kinzler: Enable language fallback in wbsearchentities. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203805 (https://phabricator.wikimedia.org/T76150) [21:20:15] (03CR) 10Aude: "I am sure there is an issue that this fixes, but have difficulty to see where / how the problem is for badges in the site link section." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203778 (owner: 10Ebrahim) [21:24:13] good night all :) [21:27:56] good night, benestar [21:30:53] night [22:00:45] aude: Around? [22:11:11] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, and 2 others: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1205067 (10hoo) Just for the record: I investigated a bit further yesterday and t... [22:19:16] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 10Wikidata-Sprint-2015-04-07: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1205117 (10hoo) 5Open>3Resolved [22:20:00] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 10Wikidata-Sprint-2015-04-07: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1120356 (10hoo) Will backport the fix with tonight's SWAT. Hope... [22:21:06] * hoo|away will be back for SWAT [23:01:54] SMalyshev: RE your mail: If that's a huge problem to you, I guess we could settle on another day, but the current date has its advantages [23:02:26] hoo: it's not *huge*, it's just not the most convenient etup [23:02:26] *setup [23:02:30] hoo: so why Monday? [23:03:14] Well, it's a) as far away from the deployment as possible (thus we can fix stuff in time) and b) it's on the same day with the json dumps, so that they end up in one folder [23:03:45] hoo: that implies somebody tests the dumps and fixes stuff, but does that really happen? [23:04:25] hoo: doesn't look like http://dumps.wikimedia.org/wikidatawiki/entities/20150413/ has anything - is it still running? [23:04:29] As long as there's active development on this component, I'll do a testwikidata dump after each Wikibase deploy (unless I forget about it) [23:04:35] by anything I mean TTL dump ofc :) [23:04:44] It only just started [23:04:48] at 23:00 utc [23:04:52] which is 4 minutes ago [23:04:56] * was [23:05:00] ahh ok, missed that part :) [23:05:46] ok then, where's testwikidata dump? I'd like to take a look on it too then periodically to see if the bugs are gone [23:06:10] I don't think we did a deploy since I created the last one [23:06:16] But I can create one, if you want [23:06:22] it takes me less than a minute [23:07:11] https://people.wikimedia.org/~hoo/tmp/testwikidata-2015-04-13-all-BETA.ttl.gz [23:07:21] Just created [23:10:50] hoo: ok, thanks [23:33:59] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 10Wikidata-Sprint-2015-04-07: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1205361 (10hoo) Works now: https://www.wikidata.org/w/index.php...