[00:11:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: separate identifiers from other statements - https://phabricator.wikimedia.org/T95287#1200397 (10Ricordisamoa) You **must** be able to migrate the existing properties without changing their IDs. Otherwise the whole think will BRRREEEEAAAAK seriously. [00:28:56] There's an error on Beta Labs that seems related to Wikibase. [00:28:58] When I run: [00:29:08] mwscript eval.php --wiki=enwiki [00:29:12] (or any mwscript command) [00:29:13] I get: [00:29:19] Catchable fatal error: Object of class Closure could not be converted to string in /mnt/srv/mediawiki-staging/wmf-config/Wikibase.php on line 184 [00:29:21] Known issue? [01:08:02] ^ https://phabricator.wikimedia.org/T95793 [02:31:01] 10Wikidata, 10Beta-Cluster, 10Wikidata.org: mwscript failing on Beta Cluster with Wikibase.php error - https://phabricator.wikimedia.org/T95793#1200601 (10greg) p:5Triage>3Unbreak! [02:38:28] 10Wikidata, 10Beta-Cluster, 10Wikidata.org: DB update and mwscript failing on Beta Cluster with Wikibase.php error - https://phabricator.wikimedia.org/T95793#1200604 (10greg) [02:40:01] 10Wikidata, 10Beta-Cluster, 10Wikidata.org: DB update and mwscript failing on Beta Cluster with Wikibase.php error - https://phabricator.wikimedia.org/T95793#1200559 (10greg) I don't see anything obvious in the commit log for mw-config: https://phabricator.wikimedia.org/diffusion/OMWC/history/master/ [04:40:14] 10Wikidata, 10Beta-Cluster, 10Wikidata.org: DB update and mwscript failing on Beta Cluster with Wikibase.php error - https://phabricator.wikimedia.org/T95793#1200701 (10aude) i am looking at this now. [05:13:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: new formatter to format identifiers as URLs - https://phabricator.wikimedia.org/T95684#1200718 (10Bugreporter) Note: Some properties need special formatting. For example, [[ https://www.wikidata.org/wiki/Property:P213 | ISNI]] needs removing spaces in stri... [05:23:38] (03PS1) 10Aude: Revert "New Wikidata Build - 2015-04-10T20:00:33+0000" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203517 (https://phabricator.wikimedia.org/T95793) [05:23:38] (03CR) 10Aude: [C: 032] Revert "New Wikidata Build - 2015-04-10T20:00:33+0000" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203517 (https://phabricator.wikimedia.org/T95793) (owner: 10Aude) [05:27:03] 10Wikidata, 10Beta-Cluster, 10Wikidata.org, 5Patch-For-Review: DB update and mwscript failing on Beta Cluster with Wikibase.php error - https://phabricator.wikimedia.org/T95793#1200725 (10aude) for now, I am trying https://gerrit.wikimedia.org/r/#/c/203517/ - revert of our latest build. shall investigate... [05:33:37] (03Merged) 10jenkins-bot: Revert "New Wikidata Build - 2015-04-10T20:00:33+0000" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203517 (https://phabricator.wikimedia.org/T95793) (owner: 10Aude) [05:56:48] 10Wikidata, 10Beta-Cluster, 10Wikidata.org, 5Patch-For-Review: DB update and mwscript failing on Beta Cluster with Wikibase.php error - https://phabricator.wikimedia.org/T95793#1200738 (10aude) I have reverted our latest build and appears fixe now. We shall investigate further and test this locally more b... [05:57:04] 10Wikidata, 10Beta-Cluster, 10Wikidata.org, 5Patch-For-Review: DB update and mwscript failing on Beta Cluster with Wikibase.php error - https://phabricator.wikimedia.org/T95793#1200739 (10aude) 5Open>3Resolved [07:54:58] 10Wikidata, 10MediaWiki-extensions-PageImages: PageImages should be able to pick Wikidata's P18 as chosen image - https://phabricator.wikimedia.org/T95026#1200811 (10MaxSem) PageImages does not return images of article subject, it returns images representing the article itself, so this must not override the im... [08:15:29] 10Wikidata, 10MediaWiki-extensions-PageImages: PageImages should be able to pick Wikidata's P18 as chosen image - https://phabricator.wikimedia.org/T95026#1200831 (10Nemo_bis) > PageImages does not return images of article subject, it returns images representing the article itself, True, in principle there i... [08:24:28] 10Wikidata, 10Hovercards, 10TextExtracts: Popup/Hover on Wikidata Q pages shows plain /*3Resolved a:3Bene Closed per https://www.wikidata.org/wiki/Wikidata:Project_chat#Popups_extension_now_also_working_on_items_and_prop... [08:32:42] 10Wikidata, 10Hovercards, 10TextExtracts: Popup/Hover on Wikidata Q pages shows plain /*3Open Should work without hacks. [08:52:14] 10Wikidata, 10MediaWiki-extensions-PageImages: PageImages should be able to pick Wikidata's P18 as chosen image - https://phabricator.wikimedia.org/T95026#1200860 (10aude) If the value of P18 is among one of the images in a Wikipedia article, then that might be a reasonable choice. Some wikipedias might want... [09:24:45] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #68 14e212c44: RuboCop should be checking for that. Is it set up for this repo? 02http://git.io/vvfGN [09:53:33] 10Wikidata, 10Hovercards, 10TextExtracts: Popup/Hover on Wikidata Q pages shows plain /* (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-04-11T10:00:02+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203526 [10:17:30] (03PS1) 10Bene: Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) [10:31:35] (03PS1) 10Bene: Link to Special:ListProperties on Special:ListDatatypes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203528 (https://phabricator.wikimedia.org/T55618) [10:37:29] (03PS2) 10Bene: Create a new special page to list properties by data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203527 (https://phabricator.wikimedia.org/T55618) [10:37:51] (03CR) 10jenkins-bot: [V: 04-1] Link to Special:ListProperties on Special:ListDatatypes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203528 (https://phabricator.wikimedia.org/T55618) (owner: 10Bene) [10:38:37] aude: https://integration.wikimedia.org/ci/job/mwext-Wikibase-npm/2180/console [10:38:39] wtf [10:39:40] (03PS2) 10Bene: Link to Special:ListProperties on Special:ListDatatypes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203528 (https://phabricator.wikimedia.org/T55618) [12:14:56] (03PS1) 10Bene: Dont allow properties with same label but different capitalization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203531 (https://phabricator.wikimedia.org/T73785) [12:18:57] (03PS2) 10Bene: Dont allow properties with same label but different capitalization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203531 (https://phabricator.wikimedia.org/T73785) [12:29:15] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "I'm not voting against this patch, but as the Phabricator ticket says, this needs discussion. Should not be merged before this happened." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203531 (https://phabricator.wikimedia.org/T73785) (owner: 10Bene) [13:24:35] dennyvrandecic: fyi I just gave you Rollbacker on Wikidata [13:42:21] Lydia_WMDE: does this really need discussion? https://phabricator.wikimedia.org/T73785 [13:43:54] benestar: nope not really ;-) [14:00:34] Lydia_WMDE: I removed the thingie from the Babel info [14:00:41] no difference [14:03:06] GerardM-: :( [14:03:06] ok [14:03:09] thanks for checking [14:05:34] Do we have reports of other users having this problem? [14:10:00] no but it might be because users don't realize this is broken for them [14:17:43] Hi everyone, I have a question about a propierty [14:19:01] the difference about P155/156 and P1536 [14:37:54] (03CR) 10Bene: "From irc:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203531 (https://phabricator.wikimedia.org/T73785) (owner: 10Bene) [14:39:50] Thiemo_WMDE1 --^ [14:50:46] (03Abandoned) 10Bene: Introduce EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158641 (owner: 10Bene) [15:02:19] (03Abandoned) 10Bene: Refactor EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/158877 (owner: 10Bene) [15:02:32] (03Abandoned) 10Bene: [WIP] Finish refactoring of EntityView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/160305 (owner: 10Bene) [15:03:15] (03Abandoned) 10Bene: Refactoring [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/165986 (owner: 10Bene) [15:04:49] (03Abandoned) 10Bene: Limit the usage of global state [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159784 (owner: 10Bene) [15:08:45] (03PS2) 10Bene: Fix removing sitelinks through Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) [15:42:13] (03PS3) 10Bene: Fix removing sitelinks through Special:SetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) [15:49:52] (03PS1) 10Bene: Show the value on Special:SetLabel etc if none is entered [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203540 [15:51:31] (03CR) 10Bene: "Btw this is also how it is done in the Special:SetLabelDescriptionAliases page." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203540 (owner: 10Bene) [15:53:13] (03CR) 10Bene: "Please take another look at this patch. I created new tests covering the removal of site links and added some comments inline to make the " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159096 (https://bugzilla.wikimedia.org/62707) (owner: 10Bene) [15:56:37] Lydia_WMDE: please tell the team to review my patches on monday, I did some bugfixing today :) [15:56:53] benestar: cool :) [15:56:55] will do [15:57:05] Lydia_WMDE: don't! make them ignore him :) [15:57:13] JohnLewis: hey >:( [15:57:32] JohnLewis: dont you want to have a special page to list properties by data type? [15:57:50] benestar: okay, review that one only :p [15:57:59] JohnLewis: and remove sitelinks on Special:SetSitelink [15:58:03] JohnLewis: :P can you add https://twitter.com/MagnusManske/status/586885847712190464 to the weekly summary still please? [15:58:12] benestar: never! [15:58:22] :P [15:58:48] * benestar prepares evil patch for JohnLewis [15:58:55] Lydia_WMDE: will do once I'm done killing stuff (figuratively ofc) [15:59:05] if ( $user->getName() === 'John F. Lewis' ) die ( ':P' ); [15:59:27] benestar: what about my other account? >:D [16:01:00] if ( preg_match( '/John(.*)Lewis/', $user->getName() ) ) die ( ':P' ); [16:02:02] or in javascript: if ( mw.config.get( 'wgUser' ).match( /John(.*)Lewis/ ) ) alert( ':P' ); [16:02:45] JeroenDeDauw: will you merge that patch? --^ [16:02:59] benestar@ we both know he will [16:03:04] \o/ [16:03:19] Lydia_WMDE: ^ guess that's going on the deploy calendar next week :P [16:03:38] :D [16:04:42] benestar: in a patch I'm doing, I might change wikidata's dns to go to wikimedia.de as a joke or something as well [16:05:17] Lydia_WMDE: the patches include: remove links on Special:SetSitelink, new Special:ListProperties by datatype page and that properties with different capitalization but same label are no longer allowed [16:05:33] \o/ [16:05:45] and lots of tests :D [16:05:56] benestar: if you have patches to review like that feel free to add the tickets to the current sprint and move it to the review column [16:06:04] wikidata-sprint-something [16:06:07] how that? :O [16:06:25] * benestar still doesn't get all that phabricator stuff -.- [16:06:36] https://phabricator.wikimedia.org/tag/wikidata-sprint-2015-04-07/ [16:06:40] that is the current sprint [16:06:51] is tag = project? [16:07:00] so just add the sprint name to the projects line of a ticket and then it will show up on this board [16:07:03] and you can move it [16:07:07] yeah kinda [16:07:18] Lydia_WMDE: you've really got to the point where you're naming the sprints 'wikidata-sprint-something' and 'wikidata-sprint-who-cares' :o [16:07:26] :P [16:07:53] Lydia_WMDE: in the week of Christmas, make wikidata-sprint-santa please [16:08:00] ai ai sir! [16:08:03] Lydia_WMDE: can you delete or hide old sprints? [16:08:10] benestar: they're archived [16:08:11] you archive them yes [16:08:12] it's a bit confusing if old ones appear in the tooltip [16:08:40] benestar: go file a bug then! [16:08:45] project: Phabricator :p [16:08:57] nah we just have to do it more consistently [16:09:03] we keep around the last 2 usually [16:09:09] because they might be relevant still [16:09:15] the rest should be archived [16:09:36] Lydia_WMDE: https://phabricator.wikimedia.org/tag/%C2%A7_wikidata-sprint-2015-03-11/ [16:10:00] ok, so this will be archived next week, right? [16:10:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: not possible to remove sitelinks using Special:SetSitelink - https://phabricator.wikimedia.org/T64707#1201094 (10Bene) [16:10:27] Lydia_WMDE: correct? --^ [16:10:51] yes :) [16:11:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Special page to sort properties by datatype - https://phabricator.wikimedia.org/T55618#1201095 (10Bene) [16:11:15] and then you can drag and drop them [16:11:19] on the board of the sprint [16:11:22] to the review column [16:11:31] ok [16:11:54] lol, that's nice :D [16:11:57] ;-) [16:12:14] so when I want to review something I'll just go to the review column and pick something? [16:12:22] or are there also patches not in that column? [16:12:31] * which have to be reviewed [16:12:52] there are more that might be stale or whatever [16:13:00] but those are the ones currently important and active [16:13:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Special page to sort properties by datatype - https://phabricator.wikimedia.org/T55618#1201098 (10Bene) a:3Bene [16:13:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: not possible to remove sitelinks using Special:SetSitelink - https://phabricator.wikimedia.org/T64707#1201099 (10Bene) a:3Bene [16:15:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: disallow properties with same name but different case - https://phabricator.wikimedia.org/T73785#1201100 (10Bene) [16:15:35] benestar: JohnLewis Lydia_WMDE yeah, clearly we need to take this JohnLewis security leak more seriously. That patch is definitly a good start [16:15:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: disallow properties with same name but different case - https://phabricator.wikimedia.org/T73785#1201102 (10Bene) a:3Bene [16:17:22] Lydia_WMDE: where should I move the tasks which are on the sprint on the wikidata workboard? [16:17:26] backlog? [16:17:58] benestar: consider for next sprint so in case we drop it from a sprint [16:18:09] ok [16:22:19] JeroenDeDauw: create a tracking task for it first [16:22:22] Lydia_WMDE: will code review also be moved to phabricator once? [16:22:33] yes [16:22:35] benestar: it will eventually [16:22:35] but no idea when [16:22:49] SVN has already been imported to phab [16:23:19] JohnLewis: titled "Take care of the JohnLewis menace once and for all"? [16:23:34] JeroenDeDauw: yeah but make it sound more urgent and scary [16:23:53] JeroenDeDauw: be careful what you wish for, I shop at JohnLewis! [16:24:02] JohnLewis: Wait, the inclusion of your name does not automatically do that? [16:24:15] JeroenDeDauw: nope [16:26:44] Lydia_WMDE: are there any applications in phabricator that are somehow useful? [16:27:56] benestar: it has a built in paste, mockup designs, bug tracker, code review [16:27:58] * JohnLewis looks for more [16:28:15] * benestar perhaps only needs the bug tracker [16:28:16] benestar: and everything else here https://phabricator.wikimedia.org/applications/ [16:28:44] can I somehow pin my subscribed bugs on the home page? [16:29:13] instead of that random activity window [16:29:37] benestar: not on that window but it is possible via dashboards [16:30:19] where can I edit the dashboard? [16:30:43] * benestar feels kinda stupid but perhaps phabricator is just not intuitive to use [16:30:53] always blame the software :P [16:40:38] aude's Wikidata panel does not work :( [16:46:53] Lydia_WMDE: can I subscribe a project without joining it? [16:47:13] benestar: to a ticket? yes [16:47:25] Lydia_WMDE: I mean a project [16:47:27] in particular [16:47:34] https://phabricator.wikimedia.org/project/profile/989/ ( Wikidata Quality) [16:47:52] I want to get news about that project but I'm obviously no member of it [16:48:05] ah you can just join [16:48:10] doesn't matter [16:48:13] * Lydia_WMDE needs to leave [16:48:16] hmm, strange [18:41:32] 10Wikidata, 10Beta-Cluster, 10Wikidata.org, 5Patch-For-Review: DB update and mwscript failing on Beta Cluster with Wikibase.php error - https://phabricator.wikimedia.org/T95793#1201153 (10greg) Thanks a ton for your quick response, @aude! [20:21:26] 10Wikidata, 10MediaWiki-extensions-PageImages: PageImages should be able to pick Wikidata's P18 as chosen image - https://phabricator.wikimedia.org/T95026#1201195 (10Smalyshev) If there are multiple P18, one can always make one of them preferred rank. [20:59:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: separate identifiers from other statements - https://phabricator.wikimedia.org/T95287#1201209 (10Lydia_Pintscher) Yes. In some rare cases we can change the datatype. This is one of them. That's what the maintenance script is for. [21:05:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: separate identifiers from other statements - https://phabricator.wikimedia.org/T95287#1201213 (10Legoktm) At least pywikibot assumes that the data type will never change for a property (https://github.com/wikimedia/pywikibot-core/blob/669ea31a4c7849c576e5f... [21:09:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: separate identifiers from other statements - https://phabricator.wikimedia.org/T95287#1201214 (10Lydia_Pintscher) For the value type it is a relatively safe assumption to make. This in this case is string. For the data type it is a safe assumption to make...