[00:19:35] (03PS1) 10Smalyshev: Make somevalue use bnode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202963 [00:20:16] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1192674 (10Smalyshev) 5Open>3Resolved [00:21:04] (03PS2) 10Smalyshev: T95441: Make somevalue use bnode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202963 [06:38:45] filbertkm/mediawiki-extensions-Wikibase/master/a101daa : aude The build was fixed. http://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase/builds/57759107 [06:39:59] (03PS1) 10Aude: Use phpunit via composer instead of phpunit.phar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202999 (https://phabricator.wikimedia.org/T95409) [06:42:50] (03CR) 10Aude: "i was never able to reproduce the string normalizer issues but that fix didn't result in travis being fixed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202999 (https://phabricator.wikimedia.org/T95409) (owner: 10Aude) [06:43:40] (03PS2) 10Aude: Use phpunit via composer instead of phpunit.phar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202999 (https://phabricator.wikimedia.org/T95409) [06:52:15] (03CR) 10Aude: [V: 031] "travis-ci> filbertkm/mediawiki-extensions-Wikibase/master/a101daa : aude The build was fixed. http://travis-ci.org/filbertkm/mediawiki-ext" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202999 (https://phabricator.wikimedia.org/T95409) (owner: 10Aude) [07:02:09] 10Wikidata, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release5, 7Design, 3LE-Sprint-85: When creating a new page, suggest doing a translation instead - https://phabricator.wikimedia.org/T88600#1193153 (10Pginer-WMF) a:5Pginer-WMF>3None [07:16:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Datasets-General-or-Unknown: provide "latest" link for JSON dumps - https://phabricator.wikimedia.org/T72247#1193178 (10Nemo_bis) p:5Normal>3Low [07:17:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Datasets-General-or-Unknown: provide incremental JSON dumps for Wikidata - https://phabricator.wikimedia.org/T72246#1193182 (10Nemo_bis) p:5Normal>3Low [07:22:43] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #68: initial tests for monolingual property T88546 (06master...06monolingual_T88546) 02http://git.io/ve9k2 [07:22:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Browsertests for monolingual text value input - https://phabricator.wikimedia.org/T88546#1193219 (10WMDE-Fisch) https://github.com/wmde/WikidataBrowserTests/pull/68 [07:23:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Browsertests for monolingual text value input - https://phabricator.wikimedia.org/T88546#1193220 (10WMDE-Fisch) [07:27:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Datasets-General-or-Unknown: provide "latest" link for JSON dumps - https://phabricator.wikimedia.org/T72247#1193229 (10hoo) p:5Low>3Normal [07:42:20] aude: You're at home still? [07:43:52] Nemo_bis: Sorry for overwriting you, but I think https://phabricator.wikimedia.org/T72247 is important especially given our new dump pattern [07:44:05] I'll probably work on that rather sooner than later [07:45:31] 10Wikidata, 10Datasets-General-or-Unknown: Allow custom dump types to be defined per-wiki - https://phabricator.wikimedia.org/T92964#1193277 (10Nemo_bis) Does this block T27602? If not, I'd set "Low" priority, as it would be only a nice to have which doesn't impact availability of content. [07:47:42] hoo: then assign it to yourself please :) [07:48:08] I'm just doing a mass retriage in the component, separing nice to have from blocking stuff [07:48:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Datasets-General-or-Unknown: provide "latest" link for JSON dumps - https://phabricator.wikimedia.org/T72247#1193285 (10hoo) a:3hoo [07:48:29] * Nemo_bis misses the severity field [07:48:31] Nemo_bis: Oh sure... done :) [07:49:41] Thanks [07:55:37] Does wb_property_info still exist? https://phabricator.wikimedia.org/T70024 [08:07:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Datasets-General-or-Unknown: provide incremental JSON dumps for Wikidata - https://phabricator.wikimedia.org/T72246#1193345 (10Magnus) I believe I originally asked for this, but current WDQ wouldn't use these anymore, and SPARQL replacements are on the... [08:19:35] Nemo_bis: it does though not sure it got added properly to the dumps :/ [08:20:12] aude: indeed I don't see it, no idea what else is needed though [08:20:35] * aude looks [08:21:15] mariushoch/mediawiki-extensions-Wikibase/defaultPhpUnit/dc63af7 : Marius Hoch The build has errored. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/57767979 [08:21:54] no idea [08:26:48] (03CR) 10Hoo man: [C: 032] "Travis still doesn't work with travis' default phpunit, just tested that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202999 (https://phabricator.wikimedia.org/T95409) (owner: 10Aude) [08:27:19] The first "Travis" should have been MediaWiki :P [08:28:06] hoo: that's what i thought [08:28:07] :/ [08:28:31] mariushoch/mediawiki-extensions-Wikibase/defaultPhpUnit/8ce323e : Marius Hoch The build passed. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/57768357 [08:28:53] https://travis-ci.org/filbertkm/mediawiki-extensions-Wikibase mostly seem to work actually [08:29:10] It passed because MediaWiki's phpunit.php exits with 0 if it can't find a phpunit... that's :S [08:29:21] oh :O [08:29:32] yeah [08:29:40] Couldn't find a usable PHPUnit. [08:30:01] * aude wants to get rid of phpunit.php [08:30:08] and have a bootstrap file instead [08:30:24] (03Merged) 10jenkins-bot: Use phpunit via composer instead of phpunit.phar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202999 (https://phabricator.wikimedia.org/T95409) (owner: 10Aude) [08:34:02] aude: yes [08:34:14] aude: https://gerrit.wikimedia.org/r/203006 fixes the exit code [08:37:18] [13WikidataBrowserTests] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/ve9Eq [08:37:18] 13WikidataBrowserTests/06master 14c8b141c 15Thiemo Mättig: Merge pull request #62 from wmde/statments_refactor... [08:37:25] Nemo_bis: https://github.com/wikimedia/operations-dumps/tree/ariel [08:37:36] apparently my change is the last one [08:37:43] * aude wonders if it never got deployed [08:40:59] hoo: you have access to snapshots and could see what code is there? [08:40:59] wikimedia/mediawiki-extensions-Wikibase/master/887ba63 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57769167 [08:41:15] yeah, I can poke at it [08:41:19] ok [08:41:32] * aude about to send a mail to ariel but would be nice if we can check first [08:48:17] 10Wikidata, 10Wikidata-Sprint-2015-04-07: Investigate travis hhvm failures for Wikibase - https://phabricator.wikimedia.org/T95409#1193415 (10aude) 5Open>3Resolved [08:48:19] 10Wikidata, 10Wikidata-Sprint-2015-04-07: Investigate travis hhvm failures for Wikibase - https://phabricator.wikimedia.org/T95409#1189086 (10aude) a:3aude [08:54:35] aude: Your change is not yet live on snapshoot1001 [08:54:44] PublicTable( "wb_items_per_site", "wbitemspersitetable","For each Wikidata item, this contains rows with the corresnponding page name on a given wiki project." )) [08:54:52] hoo: i see [08:54:56] that's what i suspected [08:55:18] i can send a mail to ariel and cc you [08:55:49] mail sent [08:57:31] :) [09:04:46] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: allow arbitrary data access on Wikidata (parser function) - https://phabricator.wikimedia.org/T70029#1193458 (10hoo) 5Open>3Resolved [09:04:49] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking, and 2 others: Allow accessing data from a Wikidata item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#1193459 (10hoo) [09:04:53] (03PS1) 10Tamslo: Baseline commit [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203008 [09:09:26] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikidata-Sprint-2015-04-07: allow arbitrary data access on Wikidata (parser function) - https://phabricator.wikimedia.org/T70029#1193471 (10hoo) [09:13:10] hoo: https://github.com/facebook/hhvm/wiki/Prebuilt-packages-on-Ubuntu-14.04 looks much easier than what i did [09:13:17] probably is what travis uses [09:13:30] Very likely, yes [09:13:32] in case anyone tries installing hhvm :) [09:13:54] only source when i want to make a patch to hhvm [09:13:55] Think there's (unofficial) packages for all major distros now [09:14:01] yeah [09:14:13] source is easy and works but just takes more time [09:14:34] Well, it doesn't build with cmake 3 [09:14:39] ooo [09:14:53] * aude has 3.6.1 now for ubuntu, when i want hhvm [09:16:20] (03CR) 10Jonaskeutel: [C: 032] Baseline commit [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203008 (owner: 10Tamslo) [09:16:39] (03CR) 10Jonaskeutel: [V: 032] Baseline commit [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203008 (owner: 10Tamslo) [09:17:28] (03PS3) 10Hoo man: Convert LabelLookup to LabelDescriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 [09:18:48] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #68 143b77f1a: There is no need for string interpolation here. `"#{value}"` can be just `value` 02http://git.io/ve9PS [09:19:38] (03CR) 10jenkins-bot: [V: 04-1] Convert LabelLookup to LabelDescriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [09:27:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: localize display of time values - https://phabricator.wikimedia.org/T50962#1193507 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher [09:27:06] 10Wikidata, 7Tracking: Bugs related to time datatype - https://phabricator.wikimedia.org/T87764#1193509 (10Lydia_Pintscher) [09:29:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: allow localized input of time values - https://phabricator.wikimedia.org/T95532#1193514 (10Lydia_Pintscher) 3NEW [09:38:38] 10Wikidata, 10Datasets-General-or-Unknown: Allow custom dump types to be defined per-wiki - https://phabricator.wikimedia.org/T92964#1193557 (10daniel) It doesn't block T27602 as far as I can tell. For wikidata, this is more than just nice to have - we need this to generate our primary kind of dumps, to enab... [09:46:20] Daily! ;-) [10:00:19] it's a tobi! [10:01:36] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06monolingual_T88546: 02http://git.io/ve9Ns [10:01:36] 13WikidataBrowserTests/06monolingual_T88546 14cce367d 15WMDE-Fisch: minor refactor [10:01:50] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-04-09T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/203015 [10:04:41] (03PS4) 10Hoo man: Convert LabelLookup to LabelDescriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 [10:12:19] (03CR) 10jenkins-bot: [V: 04-1] Convert LabelLookup to LabelDescriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [10:12:28] (03CR) 10Hoo man: "Manually rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [10:13:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: allow localized input of time values - https://phabricator.wikimedia.org/T95532#1193612 (10Ayack) Same problem in French with "1er juin" or "25/12/2014" for example . [10:15:35] (03PS5) 10Hoo man: Convert LabelLookup to LabelDescriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 [10:16:06] (03CR) 10Hoo man: "Fixed up the rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [10:20:03] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, and 2 others: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1193633 (10hoo) These are definitely getting abandoned, but I still have no clue... [10:30:42] (03CR) 10Aude: [C: 031] "in case daniel wants to look again..." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [10:31:11] 10Wikidata, 10Wikidata-Sprint-2015-04-07: Investigate travis hhvm failures for Wikibase - https://phabricator.wikimedia.org/T95409#1193639 (10aude) p:5Triage>3High [10:31:17] (03PS1) 10Thiemo Mättig (WMDE): Remove broken unlocalization from MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) [10:39:02] (03CR) 10Thiemo Mättig (WMDE): "> we'd have to check all code that accesses the revision ID from an EntityRevision object." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [10:40:07] (03CR) 10Daniel Kinzler: "Well, how about making this patch simpler by making LabelDescriptionLookup extending LabelLookup? That should avoid most of the fallout. A" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [10:41:16] (03CR) 10jenkins-bot: [V: 04-1] Remove broken unlocalization from MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) (owner: 10Thiemo Mättig (WMDE)) [10:41:23] (03CR) 10Hoo man: "Well, more interfaces that IMO aren't really needed, plus I would have to redo large parts of this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [10:43:51] (03CR) 10Thiemo Mättig (WMDE): "It's great to see this finally moving. Thanks guys. Will rebase." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [10:44:33] (03CR) 10Daniel Kinzler: [C: 031] "I suspect you could simply undo large parts of this..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [10:48:09] (03CR) 10Daniel Kinzler: Hook up subscription lookup based on settings. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202386 (https://phabricator.wikimedia.org/T66590) (owner: 10Daniel Kinzler) [10:48:38] (03PS3) 10Daniel Kinzler: Hook up subscription lookup based on settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202386 (https://phabricator.wikimedia.org/T66590) [10:50:13] (03PS4) 10Daniel Kinzler: Hook up subscription lookup based on settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202386 (https://phabricator.wikimedia.org/T66590) [10:52:17] (03PS15) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [10:57:52] (03PS1) 10Daniel Kinzler: Avoid static access to settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 [11:02:10] (03CR) 10jenkins-bot: [V: 04-1] Avoid static access to settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 (owner: 10Daniel Kinzler) [11:03:58] (03CR) 10Daniel Kinzler: "The question is whether this patch breaks assumptions. If we have code that assumes that EntityRevision::getRevisionId() will always retur" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [11:05:09] (03CR) 10Hoo man: [C: 031] "Some style nit picks still left/ found... manually tested, works well." (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [11:27:04] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #67 14b713431: I think `be ==` can be replaced with `eq`. 02http://git.io/veH8h [11:55:33] (03PS1) 10Dominic.sauer: add changes for tests from github repo [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203033 [12:07:56] (03PS5) 10Aude: Fix revision id used for EntityTermsView placeholder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) [12:14:05] (03CR) 10Hoo man: "Tests need to be adopted" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 (owner: 10Daniel Kinzler) [12:14:52] (03CR) 10Thiemo Mättig (WMDE): "> If we have code [...]" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [12:17:06] 10Wikidata, 10Wikidata-Query-Service: Make decision on RDF ontology prefix - https://phabricator.wikimedia.org/T94747#1193784 (10Lydia_Pintscher) Ok we discussed this some more. If there is no strong disagreement let's go with the following: * We will use http://www.wikidata.org/ontology-beta#rank now until w... [12:18:19] 10Wikidata, 7domains: Better namespace URI for the wikibase ontology - https://phabricator.wikimedia.org/T93207#1193786 (10daniel) Since T94747 has been decided now, I suppose we keep this ticket open to track the implementation of the decision. I'll adjust the title accordingly. [12:21:31] 10Wikidata, 7domains: Better namespace URI for the wikibase ontology - https://phabricator.wikimedia.org/T93207#1193793 (10daniel) Since T94747 has been decided now, I'll narrow the scope of this ticket to be just about the domain to use for the wikibase ontology. [12:23:08] 10Wikidata, 7domains: Decide which domain to use for the wikibase ontology URI - https://phabricator.wikimedia.org/T93207#1193796 (10daniel) [12:23:16] (03CR) 10Hoo man: "re to Daniel" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) (owner: 10Hoo man) [12:24:14] (03PS1) 10Thiemo Mättig (WMDE): Make deprecated Settings class final [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203037 [12:24:26] DanielK_WMDE_: Would be nice if you could look at my replies here: https://gerrit.wikimedia.org/r/181718 just to make sure we're going into the right direction here [12:26:11] Would like to get the entity prefetching stuff sorted this week [12:26:58] !kitten [12:27:04] https://gerrit.wikimedia.org/r/201496 [12:27:05] :P [12:28:26] :) [12:28:39] (03CR) 10Daniel Kinzler: Introduce EntityPrefetcher and PrefetchingWikiPageEntityMetaDataAccessor (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) (owner: 10Hoo man) [12:28:56] (03CR) 10Aude: [C: 032] Convert LabelLookup to LabelDescriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [12:31:53] (03CR) 10Aude: "maybe we can add the revision id for this during doEditUpdates or some place later in the save process. not sure that would work but can " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [12:33:09] (03Merged) 10jenkins-bot: Convert LabelLookup to LabelDescriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [12:43:38] (03CR) 10Daniel Kinzler: Refactoring dispatchChanges.php (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [12:43:58] (03PS17) 10Daniel Kinzler: Refactoring dispatchChanges.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) [12:47:28] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1193862 (10Manybubbles) OK! With my workarounds for those two fixes that dump processes fully! I've pushed the workarounds [ https://gerrit.wikimedia.org/r/#/c/202922 | here ]. [12:49:27] (03CR) 10Hoo man: [C: 04-1] "Jenkins dislikes :/" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) (owner: 10Thiemo Mättig (WMDE)) [12:52:35] (03PS1) 10Jonaskeutel: check in to gerrit from Jonas + change database schema [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203044 [12:54:14] (03PS1) 10Thiemo Mättig (WMDE): [DNM] Disallow EntityRevision to represent current revision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203045 (https://phabricator.wikimedia.org/T90893) [12:57:25] (03CR) 10jenkins-bot: [V: 04-1] [DNM] Disallow EntityRevision to represent current revision [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203045 (https://phabricator.wikimedia.org/T90893) (owner: 10Thiemo Mättig (WMDE)) [13:00:39] (03PS1) 10Daniel Kinzler: Do not skip non-item changes in ChangeDispatcher [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203049 [13:01:57] (03PS4) 10Daniel Kinzler: Introduce SqlSubscriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202372 (https://phabricator.wikimedia.org/T66590) [13:02:21] (03PS5) 10Daniel Kinzler: Hook up subscription lookup based on settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202386 (https://phabricator.wikimedia.org/T66590) [13:03:24] (03CR) 10Hoo man: Refactoring dispatchChanges.php (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [13:03:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Tag protected items with a padlock - https://phabricator.wikimedia.org/T64554#1193896 (10Lydia_Pintscher) No I'll mark it as a dupe of the other one. [13:04:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Tag protected items with a padlock - https://phabricator.wikimedia.org/T64554#1193897 (10Lydia_Pintscher) [13:04:15] (03PS2) 10Thiemo Mättig (WMDE): [WIP] Remove broken unlocalization from MwTimeIsoFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) [13:04:34] (03CR) 10Hoo man: [C: 032] "Manually tested PS16. Definitely an improvement over the status quo, although there are still some not so nice parts in the code, but that" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [13:04:39] 10Wikidata, 10MediaWiki-Interface: Add page indicator to show that the page being viewed is protected - https://phabricator.wikimedia.org/T12347#149923 (10Lydia_Pintscher) [13:04:41] (03CR) 10Thiemo Mättig (WMDE): [WIP] Remove broken unlocalization from MwTimeIsoFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) (owner: 10Thiemo Mättig (WMDE)) [13:05:03] (03PS2) 10Daniel Kinzler: Avoid static access to settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 [13:07:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Make label/description available for plain item/property links - https://phabricator.wikimedia.org/T95463#1193917 (10Lydia_Pintscher) This should be solved with T69434. [13:07:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Hovercards, 7Need-volunteer, 5Patch-For-Review: Make Hovercards work on Wikidata item links - https://phabricator.wikimedia.org/T69434#718006 (10Lydia_Pintscher) [13:07:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Make label/description available for plain item/property links - https://phabricator.wikimedia.org/T95463#1193924 (10Lydia_Pintscher) [13:09:42] (03PS3) 10Daniel Kinzler: Avoid static access to settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 [13:10:07] (03Merged) 10jenkins-bot: Refactoring dispatchChanges.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [13:33:20] (03CR) 10Hoo man: [C: 04-1] "This doesn't work for me, see comments." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203049 (owner: 10Daniel Kinzler) [13:41:35] (03CR) 10Aude: "think i have a solution to assign the revision id to wikibase-view-chunks later in the save process once it is assigned." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [14:05:59] (03PS1) 10Tamslo: Began to implement violations table [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203067 [14:06:01] (03CR) 10jenkins-bot: [V: 04-1] Began to implement violations table [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203067 (owner: 10Tamslo) [14:17:55] (03PS4) 10Daniel Kinzler: Avoid static access to settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 [14:20:25] (03PS5) 10Daniel Kinzler: Avoid static access to global settings object where possible. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 [14:21:45] (03PS2) 10Daniel Kinzler: Do not skip non-item changes in ChangeDispatcher [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203049 [14:21:59] (03PS5) 10Daniel Kinzler: Introduce SqlSubscriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202372 (https://phabricator.wikimedia.org/T66590) [14:22:20] (03PS6) 10Daniel Kinzler: Hook up subscription lookup based on settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202386 (https://phabricator.wikimedia.org/T66590) [14:22:25] (03PS6) 10Daniel Kinzler: Avoid static access to global settings object where possible. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 [14:22:36] hoo: i hope it's better now [14:24:53] 10Wikidata, 10MediaWiki-Interface, 7JavaScript: Add page indicator to show that the page being viewed is protected - https://phabricator.wikimedia.org/T12347#1194184 (10He7d3r) [14:28:43] (03CR) 10Daniel Kinzler: "@thiemo: my problem is that I see 43 places in our code calling EntityRevision::getRevisionId. I don't know how many of them rely on the r" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [14:29:40] (03CR) 10Daniel Kinzler: "@aude: we can somehow inject the revision id later, but we should only to that if it's really needed. If we can do without, we probably sh" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [14:30:22] (03CR) 10Daniel Kinzler: [C: 032] Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [14:32:08] (03CR) 10Daniel Kinzler: [C: 031] "The code is ok, but I have no idea if this is The Right Thing semantically. Seems rather odd to me." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202963 (owner: 10Smalyshev) [14:32:39] (03CR) 10Daniel Kinzler: "It's a lot of bloat..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202461 (owner: 10Smalyshev) [14:32:50] 10Wikidata, 10Wikidata-Quality: Insert an empty div (or something similar) in front of values as a placeholder on item pages - https://phabricator.wikimedia.org/T95403#1194203 (10Lydia_Pintscher) a:5Lydia_Pintscher>3None [14:33:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Quality: Insert an empty div (or something similar) in front of values as a placeholder on item pages - https://phabricator.wikimedia.org/T95403#1188971 (10Lydia_Pintscher) [14:33:29] (03CR) 10Daniel Kinzler: "Actually, we don't need any of this in truthy mode, right? This is needed only for reified statements, and expanded values?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202461 (owner: 10Smalyshev) [14:33:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Quality: Insert an empty div (or something similar) in front of values as a placeholder on item pages - https://phabricator.wikimedia.org/T95403#1188971 (10Lydia_Pintscher) p:5Triage>3Normal [14:34:16] (03PS1) 10Aude: Update revision id for termbox placeholder during doEditUpdates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203074 [14:34:23] (03Merged) 10jenkins-bot: Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [14:34:43] (03CR) 10Hoo man: [C: 032] Do not skip non-item changes in ChangeDispatcher (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203049 (owner: 10Daniel Kinzler) [14:34:54] (03CR) 10Daniel Kinzler: [C: 04-1] "As per https://phabricator.wikimedia.org/T94747 we should for now include "beta" in the URI, since at least at present we *are* breaking t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200274 (owner: 10Smalyshev) [14:34:56] (03PS2) 10Aude: Update revision id for termbox placeholder during doEditUpdates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203074 [14:35:17] 10Wikidata, 7domains: Decide which domain to use for the wikibase ontology URI - https://phabricator.wikimedia.org/T93207#1194222 (10daniel) [14:35:19] 10Wikidata, 10Wikidata-Query-Service, 5Patch-For-Review: Data format updates for RDF export - https://phabricator.wikimedia.org/T93451#1194223 (10daniel) [14:35:21] 10Wikidata, 10Wikidata-Query-Service: Make decision on RDF ontology prefix - https://phabricator.wikimedia.org/T94747#1194220 (10daniel) 5Open>3Resolved a:3daniel [14:36:26] (03CR) 10Aude: "@daniel Id082e563 is one possibly way that I see to add the revision id during save." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [14:36:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Quality: Insert an empty div (or something similar) in front of values as a placeholder on item pages - https://phabricator.wikimedia.org/T95403#1194242 (10Lydia_Pintscher) I think it would be better to place it after the statement since this... [14:37:09] (03CR) 10Daniel Kinzler: "Yes, the idea was for Markus and/or Denny to verify that the RDF now looks like what they envisioned." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 (owner: 10Smalyshev) [14:38:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Technical-Debt: Problematic inline script - https://phabricator.wikimedia.org/T95329#1187123 (10Lydia_Pintscher) [14:38:06] (03CR) 10Aude: "@daniel EntityRevision has revision id as optional (e.g. 0 = unknown) I don't see a way around this scenario, other than avoiding these o" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [14:38:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Technical-Debt: Problematic inline script - https://phabricator.wikimedia.org/T95329#1194257 (10Lydia_Pintscher) p:5Triage>3Normal [14:40:01] 10MediaWiki-extensions-WikibaseRepository: Put lastrevid of linked entities in mw.config.values.wbUsedEntities - https://phabricator.wikimedia.org/T94159#1194272 (10Lydia_Pintscher) 5Open>3declined a:3Lydia_Pintscher Since this seems solved I am going to close the ticket. [14:40:31] (03CR) 10Daniel Kinzler: [C: 032] Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [14:43:56] (03Merged) 10jenkins-bot: Do not skip non-item changes in ChangeDispatcher [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203049 (owner: 10Daniel Kinzler) [14:44:09] (03PS1) 10Jonaskeutel: change prefix of constraints table to wdqa [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203075 [14:44:32] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06EntityTermView_T95407: 02http://git.io/veQXG [14:44:32] 13WikidataBrowserTests/06EntityTermView_T95407 14924c64a 15WMDE-Fisch: replaced 'be ==' with 'eq' [14:44:40] The body size of Q183 shrunk by over 7% from us removing wbUsedEntities [14:44:44] \o/ [14:45:07] Also it probably loads quite a bit faster now, but I didn't measure that [14:45:28] (03CR) 10Daniel Kinzler: "Looks pretty good, some questions" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [14:45:30] (03Merged) 10jenkins-bot: Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [14:45:57] hoo: yay! [14:47:50] (03CR) 10Aude: [C: 032] Make deprecated Settings class final [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203037 (owner: 10Thiemo Mättig (WMDE)) [14:51:46] aude, hoo et al.: [14:51:50] hallo [14:51:52] hi [14:51:55] the message "$1. century" [14:52:04] * aude hides [14:52:10] :) [14:52:13] i think that's a question for hoo and Thiemo_WMDE [14:52:15] I suspect that the full stop there is not needed [14:52:32] it's used in some languages for numbers in some cases - German, Croatian and some others, [14:52:37] but probably not needed in English [14:52:44] in english, agree [14:52:51] but not sure the implications of changing it [14:53:03] since we need to be able to parse it when someone clicks edit [14:53:28] "German, Croation, ...." sounds like something we came up with :) [14:53:40] Croatian* [14:54:11] well... yeah :) [14:54:38] if i currently enter "1 millennium" [14:54:47] i get "time value is malformed" [14:54:54] (03Merged) 10jenkins-bot: Make deprecated Settings class final [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203037 (owner: 10Thiemo Mättig (WMDE)) [14:55:03] if we change the message, not sure it works then [14:56:27] It's very scary [14:56:56] * aude is afraid to touch it and at least would want backwards compatibility [14:57:10] (03CR) 10Hoo man: "Some style nit picks, some potential suggestio" (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202372 (https://phabricator.wikimedia.org/T66590) (owner: 10Daniel Kinzler) [14:57:50] We poked at it earlier today [14:58:08] Not sure how many patches Thiemo has up right now [14:58:25] http://www.deutschfigures.info/ - search for "full stop" [14:58:27] the number localizing concerns me [14:58:37] it was there for a reason and would prefer to fix that, if feasible [14:58:48] maybe you can put it in a ? [14:58:58] send the whole span as a $1 [14:59:07] the text will be a localized number, [14:59:20] and put the actual number in a data attribute [14:59:40] there are functions that convert back from localized digits, but TBH I don't like them very much [14:59:52] using real markup sounds more robust [14:59:55] (03CR) 10Aude: "number localizing was put there for a reason (i forget exactly what the issue was though)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) (owner: 10Thiemo Mättig (WMDE)) [15:00:19] aharoni: perhaps [15:00:52] sounds somewhat sane though don't know if it's that simple [15:01:51] aharoni: but then people will expect to be able to enter localized dates, is the problem [15:01:57] (03CR) 10Thiemo Mättig (WMDE): Make $entityType in TermSqlIndex optional (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [15:02:05] we want to be able to parse them somehow [15:02:22] I got that working hackish... but not sure what the full implications were [15:02:31] yeah and not sure it's that simple [15:02:35] (viewing and changing) [15:02:50] there are a lot of different localized date formats [15:02:53] 10Wikidata, 7I18n: Full stop in messages such as Wikibase-time-precision-century is not needed in English - https://phabricator.wikimedia.org/T95553#1194378 (10Amire80) 3NEW [15:03:06] $wgAmericanDates afaik [15:03:12] and such settings [15:04:38] (03CR) 10Thiemo Mättig (WMDE): "As far as I understand the code:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203018 (https://phabricator.wikimedia.org/T95532) (owner: 10Thiemo Mättig (WMDE)) [15:13:24] (03CR) 10Thiemo Mättig (WMDE): "> I see 43 places in our code calling EntityRevision::getRevisionId." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [15:13:31] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, and 2 others: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1194457 (10hoo) This seems to affect some wikis significantly more than others...... [15:17:50] (03CR) 10Daniel Kinzler: Make $entityType in TermSqlIndex optional (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [15:27:22] (03CR) 10Daniel Kinzler: [C: 032 V: 031] "seems to work :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200245 (owner: 10Hoo man) [15:29:06] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 7Performance, 10Wikidata-Sprint-2015-04-07: Caching sitelink lookup for client use - https://phabricator.wikimedia.org/T94168#1194525 (10hoo) 5Open>3Resolved [15:29:18] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance, 10Wikidata-Sprint-2015-04-07: Caching sitelink lookup for client use - https://phabricator.wikimedia.org/T94168#1156699 (10hoo) [15:30:27] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Implement hybrid mode for change dispatcher, which uses both wb_items_per_site and wb_changes_subscription. - https://phabricator.wikimedia.org/T90755#1194536 (10hoo) [15:30:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 10Wikidata-Sprint-2015-04-07, 3§ Wikidata-Sprint-2015-03-11: Factor dispatch logic out of maintenance script - https://phabricator.wikimedia.org/T70380#1194534 (10hoo) 5Open>3Resolved [15:30:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Dispatching via delayed jobs - https://phabricator.wikimedia.org/T48643#1194538 (10hoo) [15:30:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Usage Tracking: change dispatcher should use the wb_changes_subscription table - https://phabricator.wikimedia.org/T66590#1194537 (10hoo) [15:30:45] (03CR) 10Thiemo Mättig (WMDE): Make $entityType in TermSqlIndex optional (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [15:32:22] (03Merged) 10jenkins-bot: Move "onSpecialMovepageAfterMove" out of ClientHooks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200245 (owner: 10Hoo man) [15:40:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Store the badges of sitelinks in a queryable format - https://phabricator.wikimedia.org/T72229#1194581 (10daniel) I'll try to summarize: * adding a badge_id column to wb_items_per_site won't work because there may be more than one badge... [15:43:08] (03PS1) 10Thiemo Mättig (WMDE): Fix broken EntityViewFactoryTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203086 [15:45:27] (03PS1) 10Thiemo Mättig (WMDE): Do not fail hard if badgeItems setting is not set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203089 [15:54:19] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance: Preload sitelinks based on usage tracking data - https://phabricator.wikimedia.org/T95567#1194660 (10hoo) 3NEW [15:59:00] (03PS6) 10Hoo man: Rename SiteLinkLookup::getEntityIdForSiteLink to getItemIdForSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 [15:59:35] (03CR) 10Hoo man: "Manually rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [16:03:06] (03CR) 10JanZerebecki: [C: 032] "Each path for tests needs to be registered to be executed, otherwise there is no way to find it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203086 (owner: 10Thiemo Mättig (WMDE)) [16:05:51] (03PS1) 10Hoo man: Remove SiteLinkLookup member from TermValidatorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203094 [16:07:53] (03Merged) 10jenkins-bot: Fix broken EntityViewFactoryTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203086 (owner: 10Thiemo Mättig (WMDE)) [16:11:51] (03PS1) 10JanZerebecki: Register phpunit tests for view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 [16:14:19] (03CR) 10Aude: [C: 032] "even after looking at https://gerrit.wikimedia.org/r/#/c/124835/18/repo/includes/Validators/TermValidatorFactory.php where it was added, d" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203094 (owner: 10Hoo man) [16:15:22] (03CR) 10jenkins-bot: [V: 04-1] Register phpunit tests for view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:15:24] (03PS9) 10Thiemo Mättig (WMDE): Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 [16:17:14] (03Merged) 10jenkins-bot: Remove SiteLinkLookup member from TermValidatorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203094 (owner: 10Hoo man) [16:18:16] (03PS2) 10Aude: Register phpunit tests for view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:22:12] (03CR) 10jenkins-bot: [V: 04-1] Register phpunit tests for view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:22:49] is Thiemo_WMDE or someone fixing the view tests? [16:23:17] I'm not, but I guess I could [16:23:27] * aude thinks thiemo might be [16:23:31] else i could [16:24:03] (03PS3) 10Thiemo Mättig (WMDE): Register phpunit tests for view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:24:35] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I think this is trivial and you can +2 it, Jan. :-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:27:54] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1194817 (10NiharikaKohli) @Nicolas_Raoul you too need to sign up on Melange. :) [16:29:45] (03CR) 10Aude: [C: 032] Register phpunit tests for view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:33:29] (03CR) 10jenkins-bot: [V: 04-1] Register phpunit tests for view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:33:56] wtf [16:34:38] npm? [16:34:59] are jenkins slaves full again? [16:35:24] (03CR) 10Daniel Kinzler: Introduce SqlSubscriptionLookup (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202372 (https://phabricator.wikimedia.org/T66590) (owner: 10Daniel Kinzler) [16:35:44] (03PS6) 10Daniel Kinzler: Introduce SqlSubscriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202372 (https://phabricator.wikimedia.org/T66590) [16:35:47] hoo: --^ [16:37:06] looking [16:39:16] (03CR) 10Thiemo Mättig (WMDE): "Needs https://github.com/DataValues/Time/pull/27and a new release of the time component. Waiting for review for almost 3 months now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186791 (https://phabricator.wikimedia.org/T87574) (owner: 10Thiemo Mättig (WMDE)) [16:39:42] (03CR) 10Hoo man: [C: 032] "We should consider guaranteeing the array keys in the interface, but let's not block on that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202372 (https://phabricator.wikimedia.org/T66590) (owner: 10Daniel Kinzler) [16:42:55] [13WikidataBrowserTests] 15thiemowmde 04deleted 06EntityTermView_T95407 at 14924c64a: 02http://git.io/ve71V [16:43:39] (03Merged) 10jenkins-bot: Introduce SqlSubscriptionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202372 (https://phabricator.wikimedia.org/T66590) (owner: 10Daniel Kinzler) [16:44:45] [13WikidataBrowserTests] 15thiemowmde comment on pull request #68 14cce367d: Why do some of the `Then` lines do use brackets and others do not? 02http://git.io/ve7Ma [16:46:11] (03CR) 10Aude: [C: 04-1] "see comment and I'm not sure it's consistently adding labels for properties:" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [16:47:29] (03CR) 10Aude: Show labels in edit summaries on history/diff pages (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [16:47:41] (03CR) 10Thiemo Mättig (WMDE): "Erm, -1? This drastically decreases the performance of this regex. Did you tried to remove the not needed /u at the end?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 (owner: 10Hoo man) [16:48:14] (03CR) 10JanZerebecki: [C: 032] "Test error not fault of this patch. No idea how it happened. Retrying." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:48:48] (03CR) 10Hoo man: "@aude: Please make sure the revisions you test against haven't been saved while edit summaries were broken on master (they must not have a" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [16:49:19] aude: tried untaring that file on the jenkins slave. worked fine. [16:49:30] jzerebecki: ok [16:49:52] ui, a user just reported my terrible behaviour on-wiki. :( [16:50:36] (03CR) 10Daniel Kinzler: [C: 032] Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [16:51:41] (03CR) 10Daniel Kinzler: "Do we really want to hardwire the assumption that there will *never* be another type of entity that can have sitelinks? I don't really lik" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [16:51:50] (03CR) 10Hoo man: "Thiemo: Yes :( Can you come up with a better regex that work on HHVM 3.3.1? We could also do a defined( 'HHVM_VERSION' ) if we want and us" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 (owner: 10Hoo man) [16:51:55] (03CR) 10Aude: "@hoo it works now with new revisions, so think these were just broken summaries." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [16:53:32] (03Merged) 10jenkins-bot: Register phpunit tests for view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203096 (owner: 10JanZerebecki) [16:53:56] (03CR) 10Aude: "this hook is also called on recent changes and watchlist, so has potential to be thousands of times :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201077 (https://phabricator.wikimedia.org/T55247) (owner: 10Hoo man) [16:54:09] dennyvrandecic: please provide links for your readers :) [16:54:21] https://www.wikidata.org/wiki/Wikidata:Project_chat#Threatening_with_block_when_enforcing_P279.3Drdfs:subClassOf_and_P31.3Drdf:instanceOf_and_other_problematic_behavior_by_User_Denny [16:54:39] :( [16:56:16] I am more surprised by the overreaction than anything, though. I guess what the commenters indicate is that this is a known person [16:56:29] hoo: Lucie_WMDE https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Wikibase_API_changelog [16:56:29] *shrug* [16:56:43] someone want to reply [16:57:12] hoo? [16:57:22] https://en.wikipedia.org/wiki/Interstate_805 should have a map [16:57:40] (03CR) 10Daniel Kinzler: "@thiemo: The problem here is that EntityRevision's behavior wrt revision=0 is under-specified. This is my fault: I did not make it clear i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [16:58:03] https://en.wikipedia.org/wiki/Module:Infobox_road/map [16:58:16] aude: Looking [16:58:22] e.g. if that's what he/she is referring to, but is one of the places that should provide a map [16:59:38] aude: Fixed... can you verify? [16:59:52] https://en.wikipedia.org/wiki/Module:Location_map [16:59:57] ok [17:00:33] yay :) [17:01:46] https://en.wikipedia.org/w/index.php?title=Module%3ALocation_map&diff=655694523&oldid=645696597 [17:01:51] looks like he/she fixed it [17:02:01] but is confused how it worked before and what changed [17:03:12] dennyvrandecic: hm, whether "A" is an instance of letter, or a subclass of letter, is an interesting question :) [17:05:19] aude: Replied now [17:05:32] (03CR) 10Aude: "@daniel I can take a look, probably tomorrow, if we can avoid having EntityRevision here at all." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [17:05:34] same for "red". that kind of discussion is likely to be a regular occurrance. i wonder if the instance/class distinction is really useful... [17:05:35] hoo: thanks [17:05:35] (03Merged) 10jenkins-bot: Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [17:05:40] Seems those somehow fell through the cracks in our migration [17:05:55] :/ [17:06:08] * aude is trying to make a habit of reading village pump, at least on enwiki [17:06:42] Yeah, often helpful [17:06:47] * hoo does that on dewiki often [17:06:54] :) [17:07:13] * DanielK_WMDE__ long ago made a habit of ignorign the village pump [17:07:35] and that's how we get broken, ugly "edit links" stuck on the main page during easter [17:09:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Failed asserting that 'Could not find such an entity id (The serialization "noANid" is not recognized by the configured id builders)' contains "is not valid". - https://phabricator.wikimedia.org/T94672#1194973 (10aude) p:5T... [17:09:54] (03CR) 10Hoo man: "mh... I think Thiemo suggested that in some other change. We could IMO also make the interface just return EntityIds, if you prefer that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [17:10:01] Thiemo_WMDE: ^ fyi [17:11:50] (03CR) 10Daniel Kinzler: "@hoo: oh, right, the interface says it returns ItemIds. That should be changed, then. I wonder how much extra type check that causes... ho" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [17:17:46] (03PS3) 10Smalyshev: T93451: drop version from ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200274 [17:17:57] (03CR) 10jenkins-bot: [V: 04-1] T93451: drop version from ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200274 (owner: 10Smalyshev) [17:20:17] (03PS4) 10Smalyshev: T93451: drop version from ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200274 [17:21:16] (03PS1) 10Thiemo Mättig (WMDE): Simplify StringNormalizer regex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203112 [17:22:28] (03CR) 10Thiemo Mättig (WMDE): "Hm, the /u is needed. See I5be8220." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 (owner: 10Hoo man) [17:22:55] (03CR) 10Smalyshev: "That's what Markus suggested doing." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202963 (owner: 10Smalyshev) [17:27:31] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Not happy with the non-optional settings, but this issue is unrelated to this patch." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 (owner: 10Daniel Kinzler) [17:29:40] Lydia_WMDE: hey, around? [17:29:55] she went home, but might be around [17:30:58] k [17:31:06] i just made popups work on wikidata \o/ [17:39:53] benestar: yay :) [17:40:27] aude: would it be possible to include the url to the actual image file in the api for commons media values? [17:40:43] i refer to the wbgetentities module [17:41:00] also the revision of the result should be included [17:47:23] (03CR) 10Thiemo Mättig (WMDE): "> EntityRevision's behavior wrt revision=0 is under-specified." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [17:53:59] benestar: wohooooooooooooo :D [17:54:07] just working on including the images [17:54:38] its now a local javascript hack because the guy working on the extension did not respond to my gerrit patch for some months :/ [17:54:44] but works already :) [17:55:12] benestar: narf.... @ extension. let's see if we can poke someone hard at the hackathon [17:55:19] very cool [17:55:35] will make the hack a default gadget when ready [17:55:40] maybe hoo wants to review first [17:55:44] or aude [17:55:49] will ping you when it's ready [17:56:16] perfect [17:57:54] 10Wikidata, 7domains: Decide which domain to use for the wikibase ontology URI - https://phabricator.wikimedia.org/T93207#1195326 (10Dzahn) I would personally find wikibase.org more appropriate than wikiba.se. I know, it's cool that it's short etc but it will also cause confusion in the long run. After all it'... [18:03:53] Lydia_WMDE: images work now as well \ooo/ [18:04:03] \o/ [18:04:07] 10Wikidata, 7domains: Decide which domain to use for the wikibase ontology URI - https://phabricator.wikimedia.org/T93207#1195340 (10Smalyshev) I agree with the above - while wikiba.se is nice and clever, I feel .org URL would be more stable and appropriate for the task in the long run. [18:04:40] aude: maybe you can have a look? re.query.pages[-1] [18:04:46] ups, https://www.wikidata.org/wiki/User:Bene*/popupsfix.js * [18:05:09] Lydia_WMDE: you can also try this by including into your common.js [18:05:20] 10Wikidata, 7domains: Decide which domain to use for the wikibase ontology URI - https://phabricator.wikimedia.org/T93207#1195343 (10Lydia_Pintscher) wikiba.se is the domain we actually have and use and will continue to use as the main website for the software. [18:05:31] ok [18:07:49] benestar: perfect! [18:08:08] images work as well? [18:08:24] yes [18:09:14] great [18:10:42] Lydia_WMDE: language fallback works as well magically :O [18:10:47] didn't expect that xD [18:10:50] :D [18:25:24] Lydia_WMDE: now even documented and ready for review :D [18:25:35] \o/ [18:25:39] that was quick [18:26:15] maybe hoo comes later to review it ^^ [18:29:49] (03PS1) 10Daniel Kinzler: Fix language fallback in value formatters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203189 (https://bugzilla.wikimedia.org/94563) [18:34:10] (03PS1) 10Raimond Spekking: Consistency tweaks [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/203191 [18:41:23] (03PS7) 10Daniel Kinzler: Hook up subscription lookup based on settings. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202386 (https://phabricator.wikimedia.org/T66590) [18:41:32] (03PS7) 10Daniel Kinzler: Avoid static access to global settings object where possible. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/203025 [18:51:43] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service, 5Patch-For-Review: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1195561 (10Smalyshev) [19:36:22] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 7JavaScript, 10Wikidata-Sprint-2015-04-07, 3§ Wikidata-Sprint-2015-03-11: create gadget for showing padlock on protected item pages - https://phabricator.wikimedia.org/T92384#1195707 (10Ricordisamoa) [19:48:35] hi [19:48:53] I want to add something to https://www.wikidata.org/wiki/Q19783875 (labels and descriptions etc) [19:48:56] but for some reason I can't [19:49:00] what am I doing wrong? [19:53:55] !admin ^^ [19:54:10] I don't get why it's not working... [19:55:54] I use firefox, but I can't edit the labels and description in IE either... [19:56:04] maybe a bug? [19:58:15] Trijnstel: works for me [19:59:24] Trijnstel: you have to edit the labels in the "in more languages" section [20:00:13] I know that... [20:00:26] but when I type, nothing happens... [20:00:28] so what exactly does not work? [20:00:40] you mean nothing appears in the text field? [20:00:47] which firefox version? [20:00:50] I can't even click there [20:00:53] with IE the same [20:01:05] even though I'm not logged in there [20:01:48] where can't you click? [20:03:11] the labels and descriptions! [20:03:19] I can click on "more languages" [20:03:30] and then the languages with labels and descriptions appear [20:03:40] but when I try to click there and type in a label/description, nothing happens [20:03:52] I cleared up my cache, but it's not working either... [20:04:16] so you clicked on [edit], then on the label input field and nothing happens? [20:04:31] I've never had problems before... [20:04:43] oh ehm... [20:04:45] * Trijnstel feels stupid [20:04:51] I didn't click on [edit] :/ [20:05:30] (03PS3) 10Legoktm: jenkins job validation, do not submit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200175 [20:05:33] (03Abandoned) 10Legoktm: Testing, ignore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196144 (owner: 10Legoktm) [20:05:56] thanks for your patience, benestar ;) [20:06:46] Trijnstel: nevermind ;) [20:09:05] (03CR) 10jenkins-bot: [V: 04-1] jenkins job validation, do not submit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200175 (owner: 10Legoktm) [20:11:07] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200175 (owner: 10Legoktm) [20:11:21] Trijnstel, good job! :) [20:11:27] :D [20:41:45] addshore: thanks ;) [21:22:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Failed asserting that 'Could not find such an entity id (The serialization "noANid" is not recognized by the configured id builders)' contains "is not valid". - https://phabricator.wikimedia.org/T94672#1196088 (10aude) [22:11:25] * SamB_7 wishes wikidata would do a better job of fitting its UI to the screen width ... [22:11:55] er, actually, window width [23:26:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Failed asserting that 'Could not find such an entity id (The serialization "noANid" is not recognized by the configured id builders)' contains "is not valid". - https://phabricator.wikimedia.org/T94672#1196429 (10daniel) see... [23:28:59] (03CR) 10Daniel Kinzler: [C: 032] T93451: drop version from ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200274 (owner: 10Smalyshev) [23:35:44] (03Merged) 10jenkins-bot: T93451: drop version from ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200274 (owner: 10Smalyshev) [23:43:05] (03PS4) 10Smalyshev: Change names according to proposal in https://www.mediawiki.org/wiki/Wikibase/Indexing/RDF_Dump_Format/Proposal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 [23:49:20] (03PS5) 10Smalyshev: add links between property entity and predicates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202461 [23:52:35] (03PS3) 10Smalyshev: T95441: Make somevalue use bnode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202963