[01:33:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Tag protected items with a padlock - https://phabricator.wikimedia.org/T64554#1188283 (10Ricordisamoa) [01:33:42] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 10Wikidata-Sprint-2015-04-07, 3§ Wikidata-Sprint-2015-03-11: create gadget for showing padlock on protected item pages - https://phabricator.wikimedia.org/T92384#1188281 (10Ricordisamoa) 5Open>3Resolved Moved pages and [[ //www.wikidata.org/wiki/Wikidata:Proje... [01:37:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Tag protected items with a padlock - https://phabricator.wikimedia.org/T64554#1188288 (10Ricordisamoa) Any reason why this isn't a dup of T92384 or T12347? [05:31:13] 10Wikidata, 7Pywikibot-Wikidata: ItemPage.get() chokes on labels with a 'removed' value - https://phabricator.wikimedia.org/T56767#1188494 (10Ricordisamoa) [06:14:14] wikimedia/mediawiki-extensions-WikibaseQuery/REL1_25/77619de : Translation updater bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/57598219 [06:15:00] wikimedia/mediawiki-extensions-Wikibase/REL1_25/8d21687 : Translation updater bot The build failed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57598058 [06:18:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 7Documentation, and 2 others: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1188519 (10Tobi_WMDE_SW) [06:22:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: History and diff pages should show labels of properties and items in edit summaries - https://phabricator.wikimedia.org/T55247#1188521 (10Tobi_WMDE_SW) a:3hoo [06:26:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Add language fallback for badge labels - https://phabricator.wikimedia.org/T94552#1188524 (10Tobi_WMDE_SW) a:3hoo [06:26:29] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: allow arbitrary data access on Wikidata (parser function) - https://phabricator.wikimedia.org/T70029#1188526 (10Tobi_WMDE_SW) a:3hoo [06:28:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Allow simultaneous editing of mainsnak and references - https://phabricator.wikimedia.org/T87759#1188531 (10Tobi_WMDE_SW) a:3thiemowmde [06:30:59] 10Wikidata: Include redirects in RDF dumps - https://phabricator.wikimedia.org/T93767#1188536 (10Smalyshev) Isn't this one the same as T69033? [06:35:15] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 10Wikidata-Sprint-2015-04-07, 3§ Wikidata-Sprint-2015-03-11: create gadget for showing padlock on protected item pages - https://phabricator.wikimedia.org/T92384#1188542 (10Lydia_Pintscher) Thanks @ricordisamoa! [06:41:50] 10Wikidata: Include redirects in RDF dumps - https://phabricator.wikimedia.org/T93767#1188545 (10Smalyshev) [07:46:32] (03CR) 10Aude: [C: 04-1] "comments here and in WikibaseApiTestCase need to be updated accordingly" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202453 (https://phabricator.wikimedia.org/T78290) (owner: 10Thiemo Mättig (WMDE)) [08:09:46] (03PS1) 10Aude: Also check wbIsEditView before enabling editing js [extensions/Wikibase] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202691 [08:10:06] (03PS1) 10Aude: Also check wbIsEditView before enabling editing js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202692 [09:56:11] (03Abandoned) 10Tamslo: Updated to newest version from Github [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/201498 (owner: 10Tamslo) [10:01:12] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-04-08T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/202697 [10:08:18] 10Wikidata, 10Wikidata-Quality: Insert an empty div (or something similar) in front of values as a placeholder on item pages - https://phabricator.wikimedia.org/T95403#1188971 (10Tamslo) 3NEW a:3Lydia_Pintscher [10:11:32] (03CR) 10Aude: "with non-js, there are no edit links. this was an issue only with the js." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202692 (owner: 10Aude) [10:14:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: edit links are displayed on old revisions - https://phabricator.wikimedia.org/T95405#1188988 (10aude) 3NEW a:3aude [10:14:54] (03PS2) 10Aude: Also check wbIsEditView before enabling editing js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202692 (https://phabricator.wikimedia.org/T95405) [10:16:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: browser tests for old revisions of Wikibase item pages to check there are no edit links - https://phabricator.wikimedia.org/T95406#1188999 (10aude) 3NEW [10:17:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: create browser tests to check editing and display of terms in EntityTermView - https://phabricator.wikimedia.org/T95407#1189007 (10aude) 3NEW [10:18:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: create browser tests to check editing and display of terms in EntityTermView - https://phabricator.wikimedia.org/T95407#1189007 (10aude) [10:18:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: edit links are displayed on old revisions - https://phabricator.wikimedia.org/T95405#1189017 (10aude) [10:22:59] (03CR) 10Aude: [C: 032] New Wikidata Build - 2015-04-08T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/202697 (owner: 10WikidataBuilder) [10:24:00] (03CR) 10Aude: [C: 04-1] "small nitpick on code comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202456 (https://phabricator.wikimedia.org/T94404) (owner: 10Daniel Kinzler) [10:25:06] (03CR) 10Aude: Use max( |sitelinks|, |labels| ) for term weight. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202456 (https://phabricator.wikimedia.org/T94404) (owner: 10Daniel Kinzler) [10:26:02] (03CR) 10Hoo man: [C: 032] "Exactly what this variable is for (per ViewEntityAction)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202692 (https://phabricator.wikimedia.org/T95405) (owner: 10Aude) [10:26:50] (03PS2) 10Thiemo Mättig (WMDE): [DNM] Drop unused EntityTestHelper::getTestEntity() method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202453 (https://phabricator.wikimedia.org/T78290) [10:30:50] (03CR) 10Hoo man: "re" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [10:31:31] (03Merged) 10jenkins-bot: New Wikidata Build - 2015-04-08T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/202697 (owner: 10WikidataBuilder) [10:31:33] (03Merged) 10jenkins-bot: Also check wbIsEditView before enabling editing js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202692 (https://phabricator.wikimedia.org/T95405) (owner: 10Aude) [10:33:26] 10Wikidata, 7domains: Better namespace URI for the wikibase ontology - https://phabricator.wikimedia.org/T93207#1189031 (10daniel) @mkroetzsch: You say that changing the URIs does not solve the problem of breaking changes to an ontology. If I understand you correctly, you are saying that if I run a SPARQL quer... [10:34:19] hoo: want to merge https://gerrit.wikimedia.org/r/#/c/202691/ also? [10:34:39] Sure [10:34:42] thanks [10:34:50] no reason for self merge there [10:35:36] (03CR) 10Hoo man: [C: 032] "Value of this variable hasn't been altered recently" [extensions/Wikibase] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202691 (owner: 10Aude) [10:35:44] thanks :) [10:36:11] (03CR) 10Thiemo Mättig (WMDE): "I'm afraid I still don't get it." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [10:37:06] 10Wikidata, 10Wikidata-Query-Service: Make decision on RDF ontology prefix - https://phabricator.wikimedia.org/T94747#1189033 (10daniel) [10:37:08] 10Wikidata, 7domains: Better namespace URI for the wikibase ontology - https://phabricator.wikimedia.org/T93207#1189032 (10daniel) [10:37:24] (03CR) 10Aude: Narrow the SiteLinkLookup interface (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [10:37:26] (03CR) 10Hoo man: Narrow the SiteLinkLookup interface (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [10:39:02] wikimedia/mediawiki-extensions-Wikibase/master/1148b57 : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57624313 [10:39:07] aaaah, travis [10:39:09] (03CR) 10Thiemo Mättig (WMDE): Narrow the SiteLinkLookup interface (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [10:40:10] (03Merged) 10jenkins-bot: Also check wbIsEditView before enabling editing js [extensions/Wikibase] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202691 (owner: 10Aude) [10:41:59] * aude might look into travis in a bit [10:42:05] \o/ [10:42:23] * hoo will mangle the sitelink stuff more to fit the review [10:42:24] s [10:42:32] k [10:46:07] 10Wikidata, 10Wikidata-Query-Service: Make decision on RDF ontology prefix - https://phabricator.wikimedia.org/T94747#1189062 (10daniel) I agree that we should have the software version as well as the OWL schema URL in the dump, and that the base URI should redirect to the appropriate schema (the unversioned U... [10:48:06] (03PS1) 10Aude: Update Wikidata - fix problem with edit links on diff view, etc. [extensions/Wikidata] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202700 [10:48:26] * aude wants to deploy that soon [10:49:34] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf24/af0ad51 : aude The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57624895 [10:54:33] * aude getting more and more annoyed by travis [10:56:45] 10Wikidata: Investigate travis hhvm failures for Wikibase - https://phabricator.wikimedia.org/T95409#1189086 (10aude) 3NEW [10:56:58] 10Wikidata, 10Wikidata-Sprint-2015-04-07: Investigate travis hhvm failures for Wikibase - https://phabricator.wikimedia.org/T95409#1189093 (10aude) [10:57:53] (03CR) 10Aude: [C: 032] Update Wikidata - fix problem with edit links on diff view, etc. [extensions/Wikidata] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202700 (owner: 10Aude) [10:58:20] aude: what is travis doing? :P [10:58:51] addshore: no idea [10:59:03] something with hhvm-nightly and wikibase [11:00:31] also getting tired of "Failed asserting that 'Could not find such an entity id (The serialization "noANid" is not recognized by the configured id builders)' contains "is not valid"." [11:00:36] that i get locally [11:01:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Failed asserting that 'Could not find such an entity id (The serialization "noANid" is not recognized by the configured id builders)' contains "is not valid". - https://phabricator.wikimedia.org/T94672#1189104 (10aude) [11:05:09] (03CR) 10Aude: [C: 031] "think this is okay. will leave a +1 for now in case others want to look and then +2 later today" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [11:05:50] (03Merged) 10jenkins-bot: Update Wikidata - fix problem with edit links on diff view, etc. [extensions/Wikidata] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202700 (owner: 10Aude) [11:26:59] (03PS1) 10Thiemo Mättig (WMDE): Drop dead code and narrow interfaces in WikibaseApiTestCase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202704 [11:37:11] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [11:41:39] (03CR) 10jenkins-bot: [V: 04-1] Option parameter can be null/undefined in PHP [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [11:43:48] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "PS4 still has the issue that this new code path will always trigger a wfWarn() in WikiPageEntityRevisionLookup::getEntityRevision. I can m" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [11:43:54] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [11:44:27] (03PS2) 10Hoo man: Narrow the SiteLinkLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 [11:44:29] (03PS1) 10Hoo man: Remove the unused SiteLinkLookup::countLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202709 [11:45:45] (03CR) 10Hoo man: "Split of the removal of countLinks into https://gerrit.wikimedia.org/r/202709 and created a new SiteLinkConflictLookup interface." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [11:48:17] (03PS3) 10Hoo man: Narrow the SiteLinkLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 [11:48:39] (03CR) 10Hoo man: "Fixed an @return doc in a test." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [11:49:55] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Checked and confirmed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202709 (owner: 10Hoo man) [11:52:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: edit links are displayed on old revisions - https://phabricator.wikimedia.org/T95405#1189275 (10thiemowmde) @WMDE-Fisch, can you try to create a browser test for this? I suggest to leave this ticket open... [11:55:41] (03Merged) 10jenkins-bot: Remove the unused SiteLinkLookup::countLinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202709 (owner: 10Hoo man) [11:56:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: edit links are displayed on old revisions - https://phabricator.wikimedia.org/T95405#1189277 (10aude) 5Open>3Resolved [11:56:34] Tobi_WMDE_SW: https://phabricator.wikimedia.org/T87428 <- can you handle this one please? [11:56:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: edit links are displayed on old revisions - https://phabricator.wikimedia.org/T95405#1188988 (10aude) @thiemowmde T95406 [11:57:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: edit links are displayed on old revisions - https://phabricator.wikimedia.org/T95405#1189283 (10aude) obviously I would like T95406 in the sprint [11:58:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: browser tests for old revisions of Wikibase item pages to check there are no edit links - https://phabricator.wikimedia.org/T95406#1188999 (10aude) [11:59:16] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06addClaim at 14bf971ae: 02http://git.io/vePGi [11:59:40] Lydia_WMDE: I need https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#Description for this. Probably hoo or Thiemo_WMDE could provide one.. [12:00:04] then I could just go ahead and create the project [12:00:08] Tobi_WMDE_SW: what is *this* [12:00:09] ? [12:00:18] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/vePG7 [12:00:18] 13WikibaseInternalSerialization/06master 140613b7a 15Jeroen De Dauw: Merge pull request #49 from wmde/aude... [12:00:26] aude: MediaWiki-extensions-WikibaseView [12:00:30] ah [12:00:39] see https://phabricator.wikimedia.org/T87428 [12:00:39] yay, progress. thanks. ;) [12:00:51] andre__: :D [12:01:12] "stuff for rendering wikibase entities and pages" [12:01:17] replace "stuff" with something [12:01:24] Component [12:01:27] aude: ok [12:01:29] thx [12:01:32] k [12:01:38] anything that looks like a basic extension homepage would be cool already [12:01:52] cause there's an outside world that sometimes tries to understand what is what. like... me. :P [12:02:04] andre__: ok [12:02:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Browsertests for quantity value input - https://phabricator.wikimedia.org/T88547#1189307 (10WMDE-Fisch) a:3WMDE-Fisch [12:04:37] wikimedia/mediawiki-extensions-Wikibase/master/d116af8 : Marius Hoch The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57632553 [12:10:56] (03PS2) 10Daniel Kinzler: Use max( |sitelinks|, |labels| ) for term weight. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202456 (https://phabricator.wikimedia.org/T94404) [12:15:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Implement Unit Selector widget - https://phabricator.wikimedia.org/T77982#1189316 (10thiemowmde) * The widget **must** support "custom" values, similar to what currently happens with the globe coordinate precision. If there... [12:16:25] (03CR) 10Daniel Kinzler: [C: 04-1] Fix revision id used for EntityTermsView placeholder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [12:17:58] (03CR) 10Aude: Fix revision id used for EntityTermsView placeholder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [12:19:03] (03CR) 10Hoo man: Implement CachingSiteLinkLookup and make use in client (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [12:21:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Save button inactive when changing language on monolingual text statements - https://phabricator.wikimedia.org/T95419#1189326 (10WMDE-Fisch) 3NEW [12:22:02] (03PS2) 10Hoo man: Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) [12:22:34] (03CR) 10Hoo man: "Rebased on top of the rest of the chain, addressed the comments." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [12:23:40] (03CR) 10Aude: "@thiemo if one uses the CachingEntityRevisionLookup, then the revision id 0 is resolved to the constant before trying to lookup in WikiPag" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [12:24:49] Zuul is dead sorry :-( [12:24:55] oh noes :( [12:25:23] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:26:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Thin out scenario outlines on data value browsertest - https://phabricator.wikimedia.org/T95420#1189333 (10WMDE-Fisch) 3NEW [12:26:48] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/183213/ [12:26:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Thin out scenario outlines on data value browsertest - https://phabricator.wikimedia.org/T95420#1189333 (10WMDE-Fisch) p:5Triage>3Low [12:27:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Thin out scenario outlines on data value browsertest - https://phabricator.wikimedia.org/T95420#1189333 (10WMDE-Fisch) [12:27:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Browsertests for currently used datavalues (tracking) - https://phabricator.wikimedia.org/T55845#1189340 (10WMDE-Fisch) [12:28:52] (03PS1) 10Hoo man: Rename SiteLinkLookup::getEntityIdForSiteLink to getItemIdForSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 [12:29:30] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:29:49] (03PS2) 10JanZerebecki: Gate PHP entry point [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:33:12] [13WikidataBrowserTests] 15WMDE-Fisch created 06quantity_T88547 (+1 new commit): 02http://git.io/vePur [12:33:13] 13WikidataBrowserTests/06quantity_T88547 14dfc8415 15WMDE-Fisch: initial tests for quantity property [12:33:23] (03PS3) 10Thiemo Mättig (WMDE): Gate PHP entry point [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:33:54] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Gate PHP entry point [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:35:00] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #66: initial tests for quantity value input (06master...06quantity_T88547) 02http://git.io/vePzO [12:35:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Browsertests for quantity value input - https://phabricator.wikimedia.org/T88547#1189353 (10WMDE-Fisch) https://github.com/wmde/WikidataBrowserTests/pull/66 [12:35:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Browsertests for quantity value input - https://phabricator.wikimedia.org/T88547#1189354 (10WMDE-Fisch) [12:35:47] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:36:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Browsertests for monolingual text value input - https://phabricator.wikimedia.org/T88546#1189365 (10WMDE-Fisch) a:3WMDE-Fisch [12:44:03] (03CR) 10Hashar: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [12:44:20] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:47:38] (03CR) 10jenkins-bot: [V: 04-1] Gate PHP entry point [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:49:20] (03CR) 10Hashar: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [12:49:29] (03CR) 10Daniel Kinzler: Refactoring dispatchChanges.php (0327 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [12:49:33] (03CR) 10JanZerebecki: [C: 032 V: 032] Gate PHP entry point [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [12:49:57] (03PS15) 10Daniel Kinzler: Refactoring dispatchChanges.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) [12:50:38] (03PS16) 10Daniel Kinzler: Refactoring dispatchChanges.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) [12:51:02] (03CR) 10Daniel Kinzler: "PS15 addresses comments." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (https://phabricator.wikimedia.org/T70380) (owner: 10Daniel Kinzler) [12:51:07] hoo: --^ [12:51:48] (03PS1) 10Thiemo Mättig (WMDE): Un-deprecate $revisionId = 0 in EntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202723 (https://phabricator.wikimedia.org/T90893) [12:53:09] (03CR) 10Thiemo Mättig (WMDE): "Ok, removing my -1 per argument given by Aude. Also see my related patch Ia406fdd." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [12:54:11] (03CR) 10Aude: "the api response comes back like:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [12:54:21] (03PS2) 10JanZerebecki: Ignore vendor/ in jshint [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183444 (owner: 10Adrian Lang) [12:55:16] (03CR) 10Aude: [C: 031] "agree with the change and think it looks ok, but want to give others the chance to look" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202723 (https://phabricator.wikimedia.org/T90893) (owner: 10Thiemo Mättig (WMDE)) [12:56:35] (03CR) 10JanZerebecki: [V: 032] Ignore vendor/ in jshint [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183444 (owner: 10Adrian Lang) [12:57:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Implement Unit Selector widget - https://phabricator.wikimedia.org/T77982#1189408 (10daniel) >>! In T77982#1189316, @thiemowmde wrote: > * The widget **must** support "custom" values, similar to what currently happens with t... [12:57:10] (03CR) 10JanZerebecki: [V: 032] Ignore vendor/ in jshint [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183444 (owner: 10Adrian Lang) [12:58:56] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Fix revision id used for EntityTermsView placeholder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [12:59:35] (03PS2) 10JanZerebecki: Add expect calls to test cases [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183445 (owner: 10Adrian Lang) [13:01:28] (03CR) 10Daniel Kinzler: "Just because core has a lot of sloppy coding, that doesn't mean we should allow the same sloppy coding :P" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202723 (https://phabricator.wikimedia.org/T90893) (owner: 10Thiemo Mättig (WMDE)) [13:01:57] (03CR) 10jenkins-bot: [V: 04-1] Add expect calls to test cases [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183445 (owner: 10Adrian Lang) [13:02:02] (03CR) 10JanZerebecki: [V: 032] Add expect calls to test cases [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183445 (owner: 10Adrian Lang) [13:03:00] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [13:03:47] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [13:05:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Sprint-2015-04-07: Implement Unit Selector widget - https://phabricator.wikimedia.org/T77982#1189412 (10Snipre) @thiemowmde. The list will be very long: we have to think a way to avoid scrolling dozen of units to find the correct one. One poss... [13:09:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: create browser tests to check editing and display of terms in EntityTermView - https://phabricator.wikimedia.org/T95407#1189413 (10Tobi_WMDE_SW) p:5Triage>3High [13:09:54] (03CR) 10JanZerebecki: "The qunit failure here is not unrelated." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [13:09:59] [13WikidataBrowserTests] 15thiemowmde comment on pull request #66 14dfc8415: Whuuut? Is this a bug? Why is the user input manipulated? 02http://git.io/veP1a [13:10:58] 10Wikidata, 7Tracking: Wikidata Browsertests (tracking) - https://phabricator.wikimedia.org/T88541#1189415 (10Tobi_WMDE_SW) [13:11:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: browser tests for old revisions of Wikibase item pages to check there are no edit links - https://phabricator.wikimedia.org/T95406#1189417 (10Tobi_WMDE_SW) [13:11:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: create browser tests to check editing and display of terms in EntityTermView - https://phabricator.wikimedia.org/T95407#1189007 (10Tobi_WMDE_SW) [13:12:09] Lydia_WMDE: we have the project for the wikibase-view component now [13:12:10] https://phabricator.wikimedia.org/project/profile/1176/ [13:12:23] you might want to add it to your projects [13:12:43] \o/ [13:12:44] (03Abandoned) 10JanZerebecki: (WIP) Ship data-values directly in the repo (WIP) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183032 (owner: 10Hashar) [13:12:44] will do [13:18:23] 10Wikidata, 10DataValues: Quantity formatter rounding is sloppy and causes data loss - https://phabricator.wikimedia.org/T95425#1189432 (10thiemowmde) 3NEW [13:20:15] hoo: is https://phabricator.wikimedia.org/T89169 moving now? [13:20:33] [13WikidataBrowserTests] 15WMDE-Fisch comment on pull request #66 14dfc8415: Cause he entered a resolution of "1". Thats why his input gets rounded. +-1 is the term for the resolution.... 02http://git.io/vePS9 [13:20:50] Tobi_WMDE_SW: Not a bit :( [13:21:23] 10Wikibase-DataModel, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Remove deprecated claim methods from Entity - https://phabricator.wikimedia.org/T78290#1189441 (10JanZerebecki) [13:21:29] hoo: so https://gerrit.wikimedia.org/r/200338 did not improve the situation? [13:21:33] [13WikidataBrowserTests] 15thiemowmde comment on pull request #66 14dfc8415: Yes, this is a bug (see https://phabricator.wikimedia.org/T95425). Please use very, very simple examples in these "initial" tests. I suggest "1+-0" for the first test and "2.1+-0.1" for the second. 02http://git.io/veP9I [13:23:59] Tobi_WMDE_SW: I don't know why, but for some reason it didn't [13:24:08] hm [13:24:09] ok [13:24:09] only very few fatals from commons are in the logs [13:24:14] But the change is live for Wikdiata [13:24:35] are we doing something wrong then? [13:28:17] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Hoo, do you think this still needs discussion?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202456 (https://phabricator.wikimedia.org/T94404) (owner: 10Daniel Kinzler) [13:28:45] Our very first ttl dump: https://dumps.wikimedia.org/wikidatawiki/entities/20150407/ [13:28:55] Literally just completed [13:30:39] hoo: Cool! [13:33:51] hoo: hi [13:33:54] remember https://phabricator.wikimedia.org/T87410 ? [13:34:08] aharoni: Sure :) [13:34:14] It got delayed a bit, but I plan to work on it some time very soon, hopefully tomorrow. [13:34:47] hoo: So I was wondering: why do you suggest to run it in JavaScript and not in the backend, while publishing? [13:34:51] Lydia_WMDE: hey, got my last message yesterday? [13:35:17] benestar: jep :) got a sticky note on my desk for it :P [13:35:29] ;) [13:35:32] aharoni: Because we don't really have any stable public apis for extensions to use server side [13:35:40] ha :) [13:35:42] OK [13:35:48] Client side the situation is way better [13:35:52] will you be around on IRC tomorrow if I have questions? [13:36:18] I tried to deep-dive into the WikibaseClient code that does it and had a lot of puzzling points [13:36:28] Sure, I'm working all week usual office times this week [13:36:35] cool, expect pings [13:36:43] European office times, those are... and maybe not as early as usual office times :D [13:37:21] Europe rules [13:37:44] As one movie says, "Europe. The Europe." [13:57:54] aude: We went with 2300 (UTC) on Monday now [13:58:00] guess that's also fine with oyu [13:59:08] sounds good [13:59:42] Will also make both dumps appear in the same folder (json and ttl) [14:01:45] * aude cries... can't run update.php on a new install if you have Wikidata build and don't set MW_INSTALL_PATH [14:01:51] * aude will have to set install path [14:11:00] (03CR) 10Hoo man: [C: 031] "Personally I'm ok with this... would be nice to at least have a few people look at the change and then it should be fine." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202456 (https://phabricator.wikimedia.org/T94404) (owner: 10Daniel Kinzler) [14:12:18] (03CR) 10JanZerebecki: [C: 04-1] Add a from=… parameter to {{#property:…}} for arbitrary access (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202354 (https://phabricator.wikimedia.org/T70029) (owner: 10Hoo man) [14:15:46] (03CR) 10Tobias Gritschacher: [C: 032] "Follow-up looks good." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200848 (https://phabricator.wikimedia.org/T94552) (owner: 10Adrian Lang) [14:16:07] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: language fallback - https://phabricator.wikimedia.org/T76216#1189510 (10Tobi_WMDE_SW) [14:16:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: Add language fallback for badge labels - https://phabricator.wikimedia.org/T94552#1189508 (10Tobi_WMDE_SW) 5Open>3Resolved [14:20:40] (03Merged) 10jenkins-bot: Add language fallback for badge labels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200848 (https://phabricator.wikimedia.org/T94552) (owner: 10Adrian Lang) [14:25:58] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Link item error details in my repo language instead of client language - https://phabricator.wikimedia.org/T95427#1189535 (10aude) 3NEW [14:28:32] (03PS3) 10Hoo man: Allow wikibase-time-precision-* to be translated, expand Qqq [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202455 (https://phabricator.wikimedia.org/T50962) [14:28:48] (03CR) 10Hoo man: Allow wikibase-time-precision-* to be translated, expand Qqq (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202455 (https://phabricator.wikimedia.org/T50962) (owner: 10Hoo man) [14:29:25] (03CR) 10Hoo man: "Fixed up the thing pointed out by Thiemo, minor enhancements to Qqq." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202455 (https://phabricator.wikimedia.org/T50962) (owner: 10Hoo man) [14:31:20] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Link item error details in my repo language instead of client language - https://phabricator.wikimedia.org/T95427#1189553 (10aude) now the error is correctly displayed in english: {F110057} this might be a non-bug :) and was only caused by another bug (Wikib... [14:33:25] (03PS1) 10Aude: Enable WikibaseView on client, as client has some dependencies on it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202738 (https://phabricator.wikimedia.org/T95427) [14:33:58] aude: :'( [14:34:05] i am amending [14:34:22] I think Adrian wanted client to not depend on WBView [14:34:29] (03PS2) 10Aude: Enable WikibaseView on client, as client has some dependencies on it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202738 (https://phabricator.wikimedia.org/T95427) [14:34:29] :/ [14:35:00] then we need to figure out what things client needs and move them [14:35:10] I even tested the widget briefly when I merged the changes taht move stuff to View, I'm pretty sure [14:35:11] might be only a few things [14:35:25] the widget works but slightly strange [14:35:39] and unknown effets [14:35:42] effects* [14:35:59] if you want, we can put in the branch only and then fix nicely on master [14:37:21] wikimedia/mediawiki-extensions-Wikibase/master/7675f9c : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57651160 [14:38:43] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Not perfect, but improving qqq's is trivial and can be done in later patches." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202455 (https://phabricator.wikimedia.org/T50962) (owner: 10Hoo man) [14:41:42] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1189581 (10Bene) I'd really like to take this task and already have some ideas how this could be managed. How... [14:43:42] (03Merged) 10jenkins-bot: Allow wikibase-time-precision-* to be translated, expand Qqq [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202455 (https://phabricator.wikimedia.org/T50962) (owner: 10Hoo man) [14:53:24] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1189595 (10Qgil) @Bene, thank you for your interest in this task, but we cannot disclose any information abou... [15:04:30] [13WikidataBrowserTests] 15WMDE-Fisch created 06monolingual_T88546 (+1 new commit): 02http://git.io/veX6Q [15:04:30] 13WikidataBrowserTests/06monolingual_T88546 143b77f1a 15WMDE-Fisch: initial tests for monolingual property [15:09:31] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06quantity_T88547: 02http://git.io/veXXR [15:09:31] 13WikidataBrowserTests/06quantity_T88547 1482fbe1e 15WMDE-Fisch: changed to simpler test values [15:30:28] wikimedia/mediawiki-extensions-Wikibase/master/f9576d8 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57654636 [15:33:38] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Store the badges of sitelinks in a queryable format - https://phabricator.wikimedia.org/T72229#1189746 (10Bene) >>! In T72229#1143170, @Bene wrote: >>>! In T72229#1109613, @aude wrote: >> I don't think there is good solution to this othe... [15:37:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Determine list of available languages in a uniform way - https://phabricator.wikimedia.org/T78006#1189768 (10jeblad) [15:37:08] 10Wikidata: Monolingual text should support metalanguages - https://phabricator.wikimedia.org/T95286#1189767 (10jeblad) [15:42:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: create browser tests to check editing and display of terms in EntityTermView - https://phabricator.wikimedia.org/T95407#1189783 (10WMDE-Fisch) a:3WMDE-Fisch [15:42:12] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1189784 (10Jdlrobson) @Bene just make sure you subscribe to this phabricator task and I'll post any updates.... [15:48:59] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1189861 (10NiharikaKohli) @Jdlrobson, you need to sign up on http://www.google-melange.com/gsoc/homepage/goog... [15:53:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: I cannot edit or add statements - https://phabricator.wikimedia.org/T77904#1189882 (10Bene) 5stalled>3Invalid a:3Bene [[ https://www.wikidata.org/wiki/Special:Contributions/GerardM | Apperently ]] this user can edit again. If the bug appears again fe... [16:00:59] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Wow. I had a look at the old 1000+ lines class. Sorry to say that, but this *must* be split. The split done in this patch looks sane. It c" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200494 (https://phabricator.wikimedia.org/T92515) (owner: 10Daniel Kinzler) [16:06:27] (03Abandoned) 10Daniel Kinzler: Time validator should not accept years with less than four digits [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200210 (owner: 10Daniel Kinzler) [16:08:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Determine list of available languages in a uniform way - https://phabricator.wikimedia.org/T78006#1189946 (10Snipre) Just find this list for variation of metalanguage: http://www.iana.org/assignments/language-subtag-registry/language-subtag-re... [16:15:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: With uselang=ar, redirected to special page instead of edit mode for labels etc. - https://phabricator.wikimedia.org/T94686#1190034 (10aude) also seems fixed for me :) [16:15:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Store the badges of sitelinks in a queryable format - https://phabricator.wikimedia.org/T72229#1190040 (10Superyetkin) What else needs to be done to have this feature implemented? [16:18:16] (03CR) 10Daniel Kinzler: "EntityRevision objects that may or may not have their revision set to 0 seem very scary to me, we'd have to check all code that accesses t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [16:25:57] (03Abandoned) 10Aude: Enable WikibaseView on client, as client has some dependencies on it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202738 (https://phabricator.wikimedia.org/T95427) (owner: 10Aude) [16:31:37] (03CR) 10Daniel Kinzler: Implement CachingSiteLinkLookup and make use in client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [16:31:38] (03CR) 10Daniel Kinzler: [C: 032] Narrow the SiteLinkLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [16:33:48] [13WikidataBrowserTests] 15WMDE-Fisch created 06EntityTermView_T95407 (+1 new commit): 02http://git.io/ve1B1 [16:33:48] 13WikidataBrowserTests/06EntityTermView_T95407 14b713431 15WMDE-Fisch: bugfix test for EntityTermsViewer T95407 [16:36:16] (03Merged) 10jenkins-bot: Narrow the SiteLinkLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201916 (owner: 10Hoo man) [16:36:16] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #67: bugfix test for EntityTermsViewer issue T95407 (06master...06EntityTermView_T95407) 02http://git.io/ve1Rb [16:36:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: create browser tests to check editing and display of terms in EntityTermView - https://phabricator.wikimedia.org/T95407#1190355 (10WMDE-Fisch) https://github.com/wmde/WikidataBrowserTests/pull/67 [16:37:01] yay, test [16:37:11] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review: Link item error details in my repo language instead of client language - https://phabricator.wikimedia.org/T95427#1190360 (10aude) i can't reproduce this now, even in incognito mode. if it happens again, i'll reopen and investigate more. [16:37:15] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review: Link item error details in my repo language instead of client language - https://phabricator.wikimedia.org/T95427#1190362 (10aude) 5Open>3Invalid [16:37:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: create browser tests to check editing and display of terms in EntityTermView - https://phabricator.wikimedia.org/T95407#1190368 (10WMDE-Fisch) [16:37:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 10Wikidata-Sprint-2015-04-07: create browser tests to check editing and display of terms in EntityTermView - https://phabricator.wikimedia.org/T95407#1189007 (10WMDE-Fisch) [16:42:38] :-) [16:42:39] looks ok to me but prefer tobi review [16:51:38] I unpacked todays ttl dump... it has 39gb [16:54:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Diff of a qualifier shows the value of the new property instead of the old property - https://phabricator.wikimedia.org/T87096#1190435 (10Ricordisamoa) [16:55:37] (03CR) 10Daniel Kinzler: [C: 032] Shorten out in ParserAfterParseHookHandler if OutputType != Parser::OT_HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202423 (owner: 10Hoo man) [17:00:14] (03CR) 10Aude: "@daniel we don't know what the revision id is at this point." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [17:01:22] (03Merged) 10jenkins-bot: Shorten out in ParserAfterParseHookHandler if OutputType != Parser::OT_HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202423 (owner: 10Hoo man) [17:04:16] (03CR) 10Daniel Kinzler: "This should be fine, but the patch could be much smaller if it didn't insist to rename LabelLookup to LabelDescriptionLookup. With LabelDe" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201496 (owner: 10Hoo man) [17:10:37] 10Wikidata, 10Wikidata-Query-Service: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1190503 (10Smalyshev) 3NEW a:3Smalyshev [17:15:01] (03CR) 10Aude: [C: 04-1] "at a glance, generally looks reasonable, but some comments and nitpicks" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202386 (https://phabricator.wikimedia.org/T66590) (owner: 10Daniel Kinzler) [17:15:03] (03PS2) 10Hoo man: Rename SiteLinkLookup::getEntityIdForSiteLink to getItemIdForSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 [17:16:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: localize display of time values - https://phabricator.wikimedia.org/T50962#1190518 (10hoo) IMO this bug is solved, as these can be localized now... but we should probably create some bug about having a better (more flexible) localizati... [17:17:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Use JSON and n-triples files to test RdfBuilder. - https://phabricator.wikimedia.org/T90616#1190521 (10Smalyshev) 5Open>3Resolved a:3Smalyshev I think we are already doing it now. [17:17:40] (03CR) 10Aude: Hook up subscription lookup based on settings. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202386 (https://phabricator.wikimedia.org/T66590) (owner: 10Daniel Kinzler) [17:18:27] ah fuuuuu [17:18:32] * hoo amended the wrong change [17:19:14] (03CR) 10Daniel Kinzler: "EntityView::getHtmlForTermBox uses $entityRevision->getRevisionId() to (in theory) make sure the term box content is consistent with the (" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [17:19:50] (03CR) 10Hoo man: Implement CachingSiteLinkLookup and make use in client (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [17:20:15] where the data that is mounted on /public/dumps/public/wikidatawiki/ in labs comes from? [17:21:17] SMalyshev: I dunno [17:21:31] Do you need the dumps on labs? I have it unpacked in my home on tool labs [17:21:53] /home/hoo/wikidata-20150407-all-BETA.ttl [17:21:55] world readable [17:22:04] But be careful with copying [17:22:15] The unpacking already made the labstore go awry [17:23:13] hoo: thanks. Just was wondering if it was a copy or link and if it was possible to make a link so some current ones for experiments and such [17:23:26] I think .gz is actually fine, blazegraph can read .gz [17:24:36] (03PS3) 10Hoo man: Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) [17:25:17] (03CR) 10Hoo man: "Made the cache key prefix changable, per Daniel." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [17:26:50] (03PS3) 10Hoo man: Rename SiteLinkLookup::getEntityIdForSiteLink to getItemIdForSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 [17:26:56] 10Wikidata, 10Wikidata-Query-Service: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1190572 (10daniel) NOVALUE needs to be represented explicitly. People should be able to query for "kinds with no children" or "states with no capital". In particular, they should also be... [17:29:29] (03CR) 10Aude: "@daniel I don't think we have a way of knowing at this point, since the revision is not saved yet. :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202466 (https://phabricator.wikimedia.org/T90893) (owner: 10Aude) [17:29:32] (03CR) 10jenkins-bot: [V: 04-1] Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [17:30:20] hoo: less /home/hoo/wikidata-20150407-all-BETA.ttl [17:30:43] hoo: /home/hoo/wikidata-20150407-all-BETA.ttl: Permission denied [17:30:49] SMalyshev: uh [17:32:08] ah, I see [17:32:52] hm, we stopped putting things in the deployment google calendar [17:33:04] the wiki page is up-to-date but doesn't have future things yet [17:33:07] aude: Yeah, I never remember [17:33:16] and Tobi probably also doesn'T [17:33:25] * aude primarily uses the wiki page [17:35:16] and it's like new years.... i keep writing wmf/1.25wmf2 [17:35:21] instead of wmf/1.26wmf2 [17:35:28] SMalyshev: Copying it into /data/project/scratch/ now [17:37:20] (03CR) 10Legoktm: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [17:38:32] (03CR) 10Daniel Kinzler: [C: 04-1] "Minor issues, looks fine in general." (0316 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) (owner: 10Hoo man) [17:38:33] hoo: /data/scratch is better since I think it's more widely shared [17:39:40] (03PS4) 10Hoo man: Rename SiteLinkLookup::getEntityIdForSiteLink to getItemIdForSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 [17:39:42] (03PS4) 10Hoo man: Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) [17:40:54] 10Wikibase-JavaScript-Api, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Fix Job for running WBJSAPI QUnit tests on Jenkins - https://phabricator.wikimedia.org/T86176#1190633 (10Legoktm) 5Open>3Resolved [17:41:33] (03CR) 10Daniel Kinzler: [C: 031] "The code looks functional. I did not verify that it implements the proposal as agreed on. Please get a +1 from Markus and/or Denny, to ver" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 (owner: 10Smalyshev) [17:42:24] (03CR) 10Smalyshev: "Daniel, we've talked with Markus today on the meeting and he has no objections." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 (owner: 10Smalyshev) [17:43:01] (03CR) 10Daniel Kinzler: "About this patch specifically?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 (owner: 10Smalyshev) [17:43:29] * aude has managed to schedule my travels to mostly be around for deployments :) [17:43:30] (03CR) 10Smalyshev: "No, about the scheme described in https://www.mediawiki.org/wiki/Wikibase/Indexing/RDF_Dump_Format/Proposal" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 (owner: 10Smalyshev) [17:43:39] aude: Nice :) [17:43:52] except once in may, after hackathon [17:44:31] alright, going home so i am around in case any problems deploying to wikipedias [17:44:45] (03CR) 10Daniel Kinzler: "Then I'd need to verify that this patch implements that proposal. I can try to do that if need be, but I think he's better qualified to do" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 (owner: 10Smalyshev) [17:45:04] (03CR) 10jenkins-bot: [V: 04-1] Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [17:45:14] (03CR) 10Daniel Kinzler: [C: 032] Make types be nodes, not strings (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201868 (owner: 10Smalyshev) [17:45:23] (03CR) 10Smalyshev: "Not sure if it'd be easy for them to read what's going on in the actual patch. Tests should verify the patch matches the proposal though." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 (owner: 10Smalyshev) [17:53:18] (03CR) 10Daniel Kinzler: [C: 032] Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [17:54:24] (03PS5) 10Hoo man: Rename SiteLinkLookup::getEntityIdForSiteLink to getItemIdForSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 [17:54:26] (03PS5) 10Hoo man: Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) [17:55:23] (03CR) 10Daniel Kinzler: [V: 04-1] "Needs rebase!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186791 (https://phabricator.wikimedia.org/T87574) (owner: 10Thiemo Mättig (WMDE)) [17:55:31] (03CR) 10Hoo man: "Took me a couple of attempts, but I finally untangled this change from its follow up (I accidentally mixed stuff up earlier)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [17:58:28] (03CR) 10Daniel Kinzler: [C: 032] Find meaningfull names for all $repo variables and methods (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [18:03:18] (03Merged) 10jenkins-bot: Make types be nodes, not strings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201868 (owner: 10Smalyshev) [18:04:52] is there some place where the namespaces that wikidata.org uses are defined? [18:05:29] (03CR) 10Daniel Kinzler: [C: 032] "I'll merge this, since it'S consistent with the current behavior of the API and UI: dates tagged as julian will be saved as-is." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [18:06:06] SMalyshev: what do you mean exactly? [18:06:13] all namespaces? or entity namespaces? [18:06:19] DanielK_WMDE_: entity ones [18:06:31] DanielK_WMDE_: i.e. properties do not live in namespace 0, right? [18:06:55] no they don't. [18:07:04] let me check, i keep forgetting where that mapping lives :) [18:07:48] DanielK_WMDE_: I *think* they live in 120 but I'd like to know where it says so... in case there's more such things in the future [18:08:10] SMalyshev: yes, let me dig up the canonical way to get that info [18:08:31] SMalyshev: what info do you have? an entity type? or content model? or namespace id? [18:08:59] DanielK_WMDE_: I need it for recent changes API. so I just need a number for now, but I'd like to know where it comes from [18:09:13] (or list of numbers) [18:09:34] You need a list of all entity namespaces? [18:10:17] SMalyshev: WikibaseRepo::getDefaultInstance()->getEntityNamespaceLookup() [18:11:00] SMalyshev: note that that mapping is based on content model ids, not entity type ids. [18:11:07] it'S a bit messy :/ [18:11:38] it'S configured via $wgWBRepoSettings['entityNamespaces'] but that shouldn't be accessed directly. [18:11:49] I see, thanks [18:12:02] the mapping between entity type id and content model id is hardcoded in ItemContent and PropertyContent, I think [18:12:25] hmmm but default config doesn't set entityNamespaces so it's basically completely ad-hoc? [18:12:32] anyway, i'm off for now, will be back online in an hour or two, for the archcom meeting [18:14:31] i'm pretty sure it does set it [18:14:44] but don't ask me about wmf cluster settings, that stuff is really strange :) [18:15:22] SMalyshev: if you just need the number now, you can aqsk the api, or look into the JS vars in the HTML page [18:15:33] anyway, off for now. [18:16:35] 10Wikidata, 10Wikidata-Query-Service: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1190808 (10Smalyshev) I agree but I'm not sure how to do it in a way so that the query "all people who have children" would not return people with "no value" in children field. Making pe... [18:17:11] DanielK_WMDE_: I think I have the number now but I'm worried about it being hardcoded in non-obvious place [18:17:18] wikimedia/mediawiki-extensions-Wikibase/master/dd1133f : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57672497 [18:17:52] * aude waves [18:18:35] wb aude [18:22:19] aude: wikibase tests are failing under hhvm :/ [18:22:40] legoktm: Yeah, but we dunno why [18:22:46] my hhvm installation is borked :P [18:23:02] ok, jenkins is about to reject a bunch of patches [18:24:06] uhm, yay [18:24:20] Does it know what's broken? [18:24:51] wikimedia/mediawiki-extensions-Wikibase/master/f56fa40 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57676173 [18:24:59] legoktm: same as travi then [18:25:02] travis* [18:25:14] * aude is setting up to investigate already [18:25:20] I'll make them non-voting in a bit, jenkins is totally overloaded right now [18:25:25] ok [18:25:39] legoktm: and made a suggestion on https://gerrit.wikimedia.org/r/#/c/202289/, if it is feasible [18:29:24] (03CR) 10Hoo man: Add a from=… parameter to {{#property:…}} for arbitrary access (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202354 (https://phabricator.wikimedia.org/T70029) (owner: 10Hoo man) [18:30:07] (03PS2) 10Hoo man: Add a from=… parameter to {{#property:…}} for arbitrary access [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202354 (https://phabricator.wikimedia.org/T70029) [18:30:53] (03CR) 10Hoo man: "Added the test case Jan asked me about and fixed a bug discovered due to that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202354 (https://phabricator.wikimedia.org/T70029) (owner: 10Hoo man) [18:31:25] (03CR) 10jenkins-bot: [V: 04-1] Rename SiteLinkLookup::getEntityIdForSiteLink to getItemIdForSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [18:33:29] (03CR) 10jenkins-bot: [V: 04-1] Implement CachingSiteLinkLookup and make use in client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [18:33:37] * hoo rages [18:35:14] surprise [18:35:30] thought we fixed the hhvm issue before [18:35:44] Fatal error: Call to undefined function Wikibase\cal_days_in_month() [18:35:57] that again [18:36:14] i think wmf has a package for that for hhvm [18:36:18] zendcompat [18:36:29] not wmf-specific but something tim made for hhvm [18:36:30] Yeah, those are in zend compat [18:36:56] 10Wikidata, 10Wikidata-Query-Service: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1191057 (10Smalyshev) Also, I'm not sure what that would mean if we have both novalue and other value on the same property. [18:36:58] thought we solved it, like in the travis setup script [18:37:04] * aude will look [18:38:54] aude: Jan is looking [18:40:07] 10Wikidata, 10Wikidata-Sprint-2015-04-07: Investigate travis hhvm failures for Wikibase - https://phabricator.wikimedia.org/T95409#1191079 (10aude) very easy to reproduce on fresh hhvm install: Fatal error: Call to undefined function Wikibase\cal_days_in_month() in /var/www/filbertkm/wiki/mediawiki/extensions... [18:41:06] (03CR) 10jenkins-bot: [V: 04-1] Add a from=… parameter to {{#property:…}} for arbitrary access [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202354 (https://phabricator.wikimedia.org/T70029) (owner: 10Hoo man) [18:41:15] https://gerrit.wikimedia.org/r/#/c/198201/2/build/travis/install.sh [18:41:19] which somehow doesn't work now [18:41:27] it's brittle hack [18:42:57] 10Wikidata, 10Wikidata-Sprint-2015-04-07: Investigate travis hhvm failures for Wikibase - https://phabricator.wikimedia.org/T95409#1191085 (10aude) in the travis job linked in the description, it appears to be set still during install. 91.68s$ bash ./build/travis/install.sh ++phpenv version-name +PHPVERSION=h... [18:43:17] unless PHPINI=/etc/hhvm/php.ini is no longer the righ tlocation [18:43:42] aude: /etc/hhvm/php.ini:hhvm.enable_zend_compat = true [18:44:26] so it is enabled on the jenkins slaves [18:45:37] intereseting [18:45:44] i checked that afaik [18:46:04] is that somehow no longer the php.ini location? [18:48:02] actually, i don't have that myself [18:49:12] that is where puppet puts it for production and the jenkins slaves [18:49:24] (and fcgi.ini, but that also has the setting) [18:50:03] * aude installed from source [18:50:20] idk, if it's not created by default [18:51:56] * Nemo_bis loves Special:GoToLinkedPage [18:53:15] hphpd> p ini_get('hhvm.enable_zend_compat') [18:53:15] p ini_get('hhvm.enable_zend_compat') [18:53:15] "1" [18:53:44] hm [18:54:08] integration-slave1405:~$ php -r "echo ini_get('hhvm.enable_zend_compat');" [18:54:08] 1 [18:54:23] so whichever way i call hhvm it has it enabled [18:58:10] * aude tries enabling [19:01:29] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191184 (10Manybubbles) 3NEW [19:02:42] the issue could be something else [19:02:54] maybe it hits this for me, and then when i fix it [19:02:57] i hit another issue [19:03:10] cal_days_in_month [19:07:02] wikimedia/mediawiki-extensions-Wikibase/master/293a671 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57684342 [19:10:09] normalizer_normalize [19:10:55] Warning: normalizer_normalize() expects at least 1 parameter [19:11:00] oh noes [19:12:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Make label/description available for plain item/property links - https://phabricator.wikimedia.org/T95463#1191221 (10SamB) 3NEW [19:15:53] the tests pass for me now :/ [19:16:17] aude: On hhvm? [19:16:27] though think i have the build [19:16:35] let me checkout master [19:17:14] * aude did git submodule update --init --recursive to get skins and extensions (from the deployemnt build) [19:17:18] ok the whitespace p 'foo bar' === $a->trimWhitespace("\r \t\nfoo\r\t\t\tbar\n\n\n\r\r"); [19:17:21] true [19:17:47] so the test should work with my local hhvm version, now trying the wmf build... [19:18:33] yes it fails on the wmf build [19:18:42] i do have master [19:18:53] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191281 (10Manybubbles) p:5Triage>3High [19:19:03] * aude compiled hhvm from source master [19:19:07] maybe they fixed the issue? [19:19:38] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191288 (10Smalyshev) a:3Smalyshev [19:19:48] or the libpcre used in the wmf build does not have support for those character classes build in [19:19:59] and travis build? [19:20:09] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191293 (10Manybubbles) Looks like OpenRDF only allows \u and \U - though the spec looks to allow \\. [19:20:23] should not fail on that whitespace test, but i didn't check [19:20:34] (03CR) 10jenkins-bot: [V: 04-1] Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [19:20:42] (03CR) 10jenkins-bot: [V: 04-1] Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [19:20:48] (03CR) 10jenkins-bot: [V: 04-1] T92996: Add Julian Calendar support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [19:20:53] because it is not using the wmf hhvm build [19:21:58] wth is \m [19:22:23] (03PS17) 10Smalyshev: T92996: Add Julian Calendar support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 [19:22:45] (03CR) 10Smalyshev: "let's rebase and try again" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [19:22:59] SMalyshev: Jenkins is broken and we know it :/ [19:23:23] so what should we do? just manually verify it? [19:23:58] or wait until it's fixed? [19:24:22] ideally fix [19:25:36] it looks like some kind of hhvm/zend compat issue [19:26:25] Btw, I just started a travis build with hhvm non-nightly: https://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/57694727 [19:26:42] mariushoch/mediawiki-extensions-Wikibase/travisHHVM-NonNightly/3e84898 : Marius Hoch The build failed. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/57694727 [19:26:46] Fails exactly like nightly does [19:27:48] SMalyshev: the difference is in preg_replace(). it is either a bug fixed in newer hhvm versions or which is more likely the libpcre used in the wmf hhvm build is not compiled with suport for certain character classes [19:28:06] hoo: intersting [19:28:56] Let's try hhvm -m d [19:29:06] (03CR) 10jenkins-bot: [V: 04-1] T92996: Add Julian Calendar support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [19:29:25] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191430 (10Manybubbles) If you really really want to include the \ in the uri I think the best way to make it work with openrdf is to add \u0092 [19:30:02] argh crap [19:30:05] did that against master [19:30:28] ahh, hhvm test thing is new in jenkins [19:30:57] 10Wikidata, 10Wikidata-Sprint-2015-04-07: Investigate travis hhvm failures for Wikibase - https://phabricator.wikimedia.org/T95409#1191441 (10aude) problem was that I had to set enable_zend_compat = true locally on my fresh install of hhvm. now tests pass for me. :/ I build hhvm from source (master), accordi... [19:30:59] yes [19:31:16] i am not running scribunto tests since i don't have it enabled yet [19:31:23] doubt it makes a difference but can try enabling that [19:31:44] failures are only in ./lib/tests/phpunit/StringNormalizerTest.php [19:32:03] ah [19:32:17] which we haven't touched for ages afaik [19:33:00] https://github.com/facebook/hhvm/wiki/Building-and-installing-HHVM-on-Ubuntu-14.04#packages-installation is all the things i have [19:34:44] mariushoch/mediawiki-extensions-Wikibase/master/81e390f : Marius Hoch The build was canceled. http://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/builds/57695839 [19:35:58] suppose i can uninstall my hhvm and get wmf build [19:36:04] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191452 (10Smalyshev) \ is a valid char in the URL, and is accepted by the GUI, so we'll have to encode it I presume. [19:36:09] aude: if you have a mediawiki vagrant install it should fail in there [19:39:39] jzerebecki: might try that [19:40:03] * hoo still experiments on travis [19:40:16] although travis doesn't use wmf build of hhvm [19:40:19] obviously [19:40:27] Sure, but that's also a problem [19:40:30] related or not [19:40:44] i could try a tagged version of hhvm [19:41:26] probably would be easier and can see if some point in time it fails [19:41:31] ok it is line 93 in \Wikibase\StringNormalizer that behaves differently [19:44:10] hoo: 'foo bar' === $a->trimWhitespace("\r \t\nfoo\r\t\t\tbar\n\n\n\r\r"); [19:45:34] aude: https://travis-ci.org/mariushoch/mediawiki-extensions-Wikibase/jobs/57697599 Any idea? [19:46:23] wow [19:46:39] that helps to know a good point [19:48:48] * aude trying 3.6.0 [19:49:20] then there is 3.6.1 [19:50:04] works for me on 3.6.1 [19:50:30] oh [19:50:46] then i should try some point more recent [19:51:36] 10Wikidata, 10Wikidata-Query-Service: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1191492 (10daniel) >>! In T95441#1191057, @Smalyshev wrote: > Also, I'm not sure what that would mean if we have both novalue and other value on the same property. It would mean that t... [19:53:00] 10Wikidata, 10Wikidata-Query-Service: Fix representation of somevalue and novalue - https://phabricator.wikimedia.org/T95441#1191494 (10daniel) Btw: Such disagreements should not be a problem in truthy output either, because we don't define any semantics for the properties used as predicates, on the level of R... [19:59:16] building hhvm takes some time :/ [19:59:36] * aude trying hhvm from april 1 [20:01:39] works not on wmf build: '/^[\p{Z}\p{Cc}]+|[\p{Z}\p{Cc}]+$/u' works on both: /^[\p{Z}\p{Cc}]+||[\p{Z}\p{Cc}]+$/u [20:03:42] it's the "||" ? [20:03:49] if i see it correctly [20:03:56] wikimedia/mediawiki-extensions-WikibaseQuery/master/23861e0 : Translation updater bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-WikibaseQuery/builds/57697832 [20:04:18] (03PS1) 10Hoo man: Fix StringNormalizer on HHVM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 [20:06:59] aude: yes hoo found that out. surprising. [20:07:14] * aude wants to know when it broke [20:07:17] and unbroke [20:08:59] (03PS2) 10JanZerebecki: Fix StringNormalizer on HHVM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 (owner: 10Hoo man) [20:09:26] * SamB_7 mumbles something about representing gadgets in wikidata ... [20:10:12] aude: don't you mean when it was fixed? [20:11:00] it used to pass on travis [20:11:12] then broke and passes on master (for me at least) [20:13:48] what does "||" mean? is that just "or EMPTY or"? [20:14:15] yep [20:15:33] (03CR) 10jenkins-bot: [V: 04-1] Fix StringNormalizer on HHVM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 (owner: 10Hoo man) [20:17:30] hoo: well that'd explain why I didn't see || in the docs for either PCRE2 classic PCRE ;-) [20:25:22] hoo: /^(\p{Z}|\p{Cc})+|(\p{Z}|\p{Cc})+$/u [20:26:52] (03PS3) 10Hoo man: Fix StringNormalizer on HHVM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 [20:27:20] (03PS1) 10Smalyshev: T95461: fix URL escaping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 [20:27:26] (03PS4) 10JanZerebecki: Fix StringNormalizer on HHVM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 (owner: 10Hoo man) [20:27:27] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191656 (10Smalyshev) [20:31:17] what the regexp (\p{Z}|\p{Cc})+|(\p{Z}|\p{Cc})+ means? It looks like repeating the same thing twice [20:32:01] SMalyshev: First thing is for pre string ws and second part for post string ws [20:32:35] ahh, it's bound to ^ and $.. got it [20:40:00] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191672 (10Manybubbles) Also I just hit a URI containing a space - that blows us up too. [20:40:41] (03CR) 10jenkins-bot: [V: 04-1] T95461: fix URL escaping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 (owner: 10Smalyshev) [20:42:50] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1191675 (10Manybubbles) Here is the edit of me fixing the busted reference: https://www.wikidata.org/w/index.php?title=Q14559451&diff=209601610&oldid=202330554 We should export those... [20:47:27] hm... april 1 is good [20:47:43] seems broken since friday, so i need to pick something more recent [20:49:46] but strange that wmf build is also affected :/ [20:52:19] (03CR) 10JanZerebecki: [C: 032] Fix StringNormalizer on HHVM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 (owner: 10Hoo man) [20:53:32] yay [20:54:21] (03CR) 10JanZerebecki: [C: 032] "retriggering" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [20:54:56] whoohoo! [20:59:15] jzerebecki: \o/ [21:00:36] (03Merged) 10jenkins-bot: Fix StringNormalizer on HHVM [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202908 (owner: 10Hoo man) [21:01:35] (03CR) 10JanZerebecki: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 (owner: 10Smalyshev) [21:03:51] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201917 (https://phabricator.wikimedia.org/T94168) (owner: 10Hoo man) [21:04:03] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202715 (owner: 10Hoo man) [21:06:34] (03PS1) 10JanZerebecki: Fix StringNormalizer on HHVM [extensions/Wikibase] (wmf/1.25wmf24) - 10https://gerrit.wikimedia.org/r/202919 [21:07:52] (03Merged) 10jenkins-bot: T92996: Add Julian Calendar support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [21:08:46] (03CR) 10JanZerebecki: [C: 032] "retriggering" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [21:09:30] (03CR) 10JanZerebecki: [C: 032] "retriggering" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [21:09:44] wikimedia/mediawiki-extensions-Wikibase/master/f65633e : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57709971 [21:09:45] aude: hey, I cannot edit any statements on my local wikibase installation (master) :/ [21:09:55] any idea what's broken? [21:13:52] benestar: Do you have any more details? [21:14:14] hoo: apperently also editing sitelinks does not work [21:14:37] do you get any errors? Server side? cleint side? [21:14:57] in the statements section no input field appears at all... [21:15:14] Ok :S Any JS errors? [21:15:16] i enter a property and then there is the loading circle but nothing happens [21:15:20] everything worked earlier today for me [21:15:30] * aude has not updated to latest master [21:15:37] benestar: your on master + composer udpdated? [21:15:38] {"error":{"code":"param-missing","info":"A parameter that is required was missing (Either provide the item \"ids\" or pairs of \"sites\" and \"titles\" for corresponding pages)","messages":[{"name":"wikibase-api-param-missing","parameters":[],"html":{"*":"A parameter that is required was missing"}}]}} [21:15:40] y [21:15:47] for ttp://localhost/mediawiki/w/api.php?action=wbgetentities&format=json&ids=P21&languages=en [21:15:47] [21:15:56] (03CR) 10JanZerebecki: [C: 032] Add a from=… parameter to {{#property:…}} for arbitrary access [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202354 (https://phabricator.wikimedia.org/T70029) (owner: 10Hoo man) [21:16:02] did you update core? [21:16:42] {"error":{"code":"param-illegal","info":"An illegal set of parameters have been used (Either provide the item \"id\" or pairs of \"site\" and \"title\" for a corresponding page)","messages":[{"name":"wikibase-api-param-illegal","parameters":[],"html":{"*":"An illegal set of parameters have been used"}}]}} [21:16:47] that is when setting a sitelink [21:16:56] can do again [21:17:02] it is maybe some weeks old [21:17:04] wikimedia/mediawiki-extensions-Wikibase/master/69f2fd2 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57711009 [21:18:15] aude: what did you change in core with parameter handling? :O [21:18:57] benestar: nothing that i am aware of [21:18:59] just a guess [21:19:06] well, I'm trying [21:19:07] (03PS3) 10Smalyshev: Change names according to proposal in https://www.mediawiki.org/wiki/Wikibase/Indexing/RDF_Dump_Format/Proposal [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 [21:19:18] core people have been poking at the api code [21:19:23] seems so [21:19:30] checking out core takes a while... :/ [21:19:33] (03CR) 10Smalyshev: "rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/201881 (owner: 10Smalyshev) [21:19:40] * aude would hate for compatiblity to break like that [21:20:28] (03Merged) 10jenkins-bot: Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [21:20:30] (03CR) 10jenkins-bot: [V: 04-1] Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [21:20:40] ugh, now i cannot run the update script o.o [21:20:54] Fatal error: Interface 'Psr\Log\LoggerAwareInterface' not found in C:\xampp\htdocs\mediawiki\w\includes\profiler\TransactionProfiler.php on line 35 [21:22:00] benestar: You need composer update in core [21:22:07] yeah, saw it [21:22:15] perhaps my core version was older than I thought ^^ [21:23:13] great, works now again :D [21:23:30] * benestar looks forward to the moment we depend on a stable mediawiki version [21:24:25] (03Merged) 10jenkins-bot: Add a from=… parameter to {{#property:…}} for arbitrary access [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202354 (https://phabricator.wikimedia.org/T70029) (owner: 10Hoo man) [21:24:32] (03CR) 10JanZerebecki: [C: 04-1] "Manual rebase needed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [21:25:43] (03PS2) 10Smalyshev: T93451: drop version from ontology [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200274 [21:25:50] benestar: I didn't think WMF wikis were allowed to do that ;-) [21:30:26] (03CR) 10Smalyshev: "After talking with Markus, I am convinced we need to drop the version, for the following reason:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/200274 (owner: 10Smalyshev) [21:32:57] wikimedia/mediawiki-extensions-Wikibase/master/5cce15e : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57713277 [21:37:46] wikimedia/mediawiki-extensions-Wikibase/master/6df8148 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57713755 [21:55:32] (03PS3) 10Smalyshev: add links between property entity and predicates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202461 [22:05:36] DanielK_WMDE_: could you take a quick look on https://gerrit.wikimedia.org/r/#/c/202913/ ? this breaks dumps for blazegraph [22:06:51] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1192108 (10daniel) So, N3RdfWriterBase needs to have $this->trustIRIs = false, and it will need to escape a few additional characters, namely "\" and " ". Anything else? [22:10:21] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1192130 (10Smalyshev) > Do any others need escaping? Currently I don't think we need anything more than escaper already does, unless we discover some other dirty data. [22:12:39] (03CR) 10Daniel Kinzler: [C: 04-1] "missing a test" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 (owner: 10Smalyshev) [22:12:57] SMalyshev: i was still commenting on phabricator, you already made a patch :) [22:12:59] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service, 7Epic: Deploy a Wikidata complex query service into production - https://phabricator.wikimedia.org/T85159#1192148 (10bd808) [22:13:03] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: Write example queries in different query languages - https://phabricator.wikimedia.org/T86786#1192152 (10bd808) [22:13:09] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: Wikidata Query - make unit tests for domain specific language - https://phabricator.wikimedia.org/T86832#1192153 (10bd808) [22:13:21] DanielK_WMDE_: which test do you mean? the tests were modified to cover this case [22:13:48] (03CR) 10Daniel Kinzler: add links between property entity and predicates (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202461 (owner: 10Smalyshev) [22:14:11] SMalyshev: there's a programmatic unit test for N3Quoter. [22:14:16] it should cover the escaping machanism [22:14:21] ahh... forgot about that one [22:15:35] (03PS2) 10Smalyshev: T95461: fix URL escaping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 [22:17:11] 10Wikidata, 6Availability-Team, 10MediaWiki-Page-editing, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1192173 (10ksmith) [22:17:40] (03PS4) 10Smalyshev: add links between property entity and predicates [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202461 [22:22:07] SMalyshev: i'm not sure we can always trust the subject IRI. [22:22:29] we generate the subjects - so it's either p/q or ref or value [22:22:41] SMalyshev: actually, in the rare cases we use a full iri for the subject, we can't really trust it [22:22:48] page titles can contain backslashes, i believe [22:22:58] don't we encode them already? [22:23:17] $baseUrl = str_replace( '$1', rawurlencode($siteLink->getPageName()), $site->getLinkPath() ); [22:23:23] SMalyshev: probably. needs checking. also, while it may be true for our current data, this is not a good thing to hard-code [22:23:37] so we urlencode them [22:24:00] does that encode backslashes? probably, maybe... [22:24:29] php -r 'echo rawurlencode("\\");' [22:24:29] %5C [22:24:35] yes :) [22:24:39] SMalyshev: perhaps instead of removing the truestIRIs switch, we should have two now: one for subject and one for object [22:24:55] predicates can't be iris, RDF/XML doesn't support that. or at least my implementation of it doesn't. [22:25:06] I don't think we really need one for object... [22:25:27] hmm... for RDF/XML I'm not sure but XML doesn't even use that encoder AFAIK [22:25:40] XML uses different one [22:26:01] no it doesn't, but because iris can't be used as predicates there, i decided that say() simply wouldn't accept iris [22:26:08] the interface says so. [22:26:17] though i think we currently don't actually check [22:26:42] ah. so that means we don't have to encode predicates anyway [22:26:55] exactly [22:26:58] but for subjects I think we're safe too [22:27:07] with the current data, yes [22:27:15] since except articles we generate them and articles are safe as we encode them [22:27:18] for a general purpose rdf serializer, which purtle should be ,no [22:27:23] so there should be a switch [22:27:45] i don't want to hardwire assumptions about the data set into the rdf writer [22:27:51] that's asking for desaster [22:28:00] hmm... ok but I'm not sure what switch you want. So maybe merge the bugfix and then you make a patch that adds the switch as you want? [22:28:23] easier to simply not remove the sitch that was already there [22:28:54] but that switch is useless now... I mean, we can not have global switch as we need to know the context [22:29:20] make the switch apply only to subjects [22:29:23] we can have local parameter depending on the context but global switch can not be context-sensitive [22:29:34] writeIRI doesn't know if it's subject or not [22:29:50] keep the param on writeIRI. call it based on $this->trustIRIs for subjects, and with trust=false for objects [22:30:14] but that would work only for Turlte. N3 one calls writeRefs for both [22:30:14] (for type IRIs, you probably also want to follow the switch) [22:30:52] do we care? N3 is slow anyway [22:31:08] dammin... Warning: cal_days_in_month(): invalid date. in /srv/mediawiki/php-1.25wmf24/extensions/Wikidata/extensions/Wikibase/repo/includes/rdf/RdfBuilder.php on line 842 [22:31:18] lovely [22:31:18] Warning: Wikibase\RdfBuilder::addStatementValue: Unsupported data type: bad [Called from Wikibase\RdfBuilder::addStatementValue in /srv/mediawiki/php-1.25wmf24/extensions/Wikidata/extensions/Wikibase/repo/includes/rdf/RdfBuilder.php at line 703] in /srv/mediawiki/php-1.25wmf24/includes/debug/MWDebug.php on line 300 [22:31:29] we really need to do display_errors=0 when dumping [22:32:11] wfSuppressWarning [22:33:35] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1192280 (10Manybubbles) For the record here is a perfectly valid reference using a \: https://www.wikidata.org/wiki/Q15731682#P19 [22:34:07] where should we call that? [22:35:46] DanielK_WMDE_: ok, let me try it [22:36:26] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1192299 (10Manybubbles) Here's a new semi related issue: this appears in the dump: ``` Warning: cal_days_in_month(): invalid date. in /srv/mediawiki/php-1.25wmf24/extensions/Wikidata... [22:36:29] DanielK_WMDE_: then the trust switch should be in Turtle, not N3 [22:36:45] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1192300 (10Manybubbles) I can file that last one as a different bug if you'd like. [22:38:08] (03PS3) 10Smalyshev: T95461: fix URL escaping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 [22:40:19] SMalyshev: yea, makes sense [22:40:47] (03PS1) 10Smalyshev: suppress warnings for dumps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202936 [22:42:36] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1192304 (10Smalyshev) That's different issue. https://gerrit.wikimedia.org/r/#/c/202936/ should fix it hopefully. Also new datetime handling code should fix the cal_days_in_month one... [22:44:06] (03CR) 10Daniel Kinzler: suppress warnings for dumps (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202936 (owner: 10Smalyshev) [22:45:10] (03CR) 10Smalyshev: suppress warnings for dumps (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202936 (owner: 10Smalyshev) [22:45:53] (03CR) 10Daniel Kinzler: [C: 04-1] "The comments are no longer true, see inline. +2 otherwise" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 (owner: 10Smalyshev) [22:46:48] (03PS4) 10Smalyshev: T95461: fix URL escaping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 [22:47:38] SMalyshev: the cleaner solution for the issue with the warnings is to not use stdout for rdf. the dump script has an --output option for specifying an output file. [22:47:47] DanielK_WMDE_: I could move the warns calls to generateDump() if you want but it's the same thing [22:48:39] yes, tha twould be better. but i'd still like to keep them. the warnings are actually useful for indicating problems. [22:48:40] DanielK_WMDE_: that I think is not a bad idea too, but maybe we should do both? [22:48:56] supressing warnigns should really be an act of last resort [22:49:07] maybe around a very small bit of code, e.g. just the date call [22:49:09] DanielK_WMDE_: ahh, no if we use --output we can not chain gzip [22:49:22] ugh. bah. use a fifo :) [22:49:27] we can do php -ddisplay_errors=0 [22:49:52] hmhm. [22:49:54] oh, well [22:50:02] we do php $multiversionscript extensions/Wikidata/extensions/Wikibase/repo/maintenance/dumpRdf.php --wiki wikidatawiki --shard $i --sharding-factor $shards --format ttl 2>> /var/log/wikidatadump/dumpwikidatattl-$filename-$i.log | gzip > $tempDir/wikidataTTL.$i.gz [22:50:06] just do wfSuppressWarnings in DumpBuilder [22:50:13] so I wonder why 2>> didn't do the thing [22:50:18] that way, we still get warnings when generating RDF in other contexts [22:50:20] and in tests [22:51:11] you mean in dumpEntites script? [22:51:20] SMalyshev: display_errors puts errors *inline*, i think. that would be stdout. thinking in terms of cgi [22:51:50] should be stderr but depends on whether it's cgi or cli I guess... also if it's hhvm may be different [22:51:56] SMalyshev: there, or DumpGenerator [22:52:39] (03PS2) 10Smalyshev: suppress warnings for dumps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202936 [22:55:39] (03CR) 10Daniel Kinzler: [C: 032] suppress warnings for dumps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202936 (owner: 10Smalyshev) [22:56:23] * SamB_7 wonders why we have both phonograph (Q116434) and gramophone (Q7112808) [22:56:43] (03CR) 10Daniel Kinzler: [C: 032] T95461: fix URL escaping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 (owner: 10Smalyshev) [22:57:14] SamB_7: those are not the same thing [22:57:37] SMalyshev: enwiki seems confused on this matter [22:58:30] yeah that can happen... [22:59:00] DanielK_WMDE_: so, what about the ontology version thing? [22:59:02] I think most americans who've heard the word have some foggy notion that it's an old word for records [22:59:31] or rather, record players [23:01:37] so if someone could fix English Wikipedia that [23:01:43] ... would be great [23:02:01] (03CR) 10Daniel Kinzler: [C: 031] "the code looks ok, but i don't know if this is what we actually want to have in the output. who can verify that?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202461 (owner: 10Smalyshev) [23:02:44] SMalyshev: i'll try to discuss it with lydia tomorrow [23:02:57] i still don't get markus' point. perhaps i'm missing something [23:03:22] (03CR) 10Smalyshev: "We could ask Markus I guess... It's on https://www.mediawiki.org/wiki/Wikibase/Indexing/RDF_Dump_Format/Proposal. But I think if we think " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202461 (owner: 10Smalyshev) [23:03:27] one thing we could do now is replace the version number in the uri with "-beta", like in the file name [23:03:50] this makes it clear that this stuff should not be relied upon, and we are free to continue to mess with it, even after we publish (beta) dumps. [23:04:12] anyway, 1am here [23:04:18] i'm done for today :) [23:04:27] DanielK_WMDE_: well, that will make all the data in the dump right now useless, but it's not a huge deal I guess. I wonder though when we'll take the beta out [23:04:40] anyway talk with Lydia and we'll see what she thinks [23:05:35] 10Wikidata, 6Search-Team, 10Wikidata-Query-Service: ttl dump contains \m in an iri - https://phabricator.wikimedia.org/T95461#1192440 (10Smalyshev) That year 0 is btw another example of bad data. No way that guy was born in 1 BCE. [23:05:43] we'll take it out once we stop messing with the format :) [23:06:40] naturally that guy wasn't born in 1 BCE, there's no such thing as 1 BCE ;-P [23:08:30] (03Merged) 10jenkins-bot: suppress warnings for dumps [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202936 (owner: 10Smalyshev) [23:08:52] SamB_7: there isn't? [23:10:04] no, it's just euphemism [23:15:54] (03Merged) 10jenkins-bot: T95461: fix URL escaping [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/202913 (owner: 10Smalyshev) [23:45:01] wikimedia/mediawiki-extensions-Wikibase/master/d16ecd5 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/57728407