[01:09:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Remove wbUserCanEdit and wbUserIsBlocked config variables - https://phabricator.wikimedia.org/T93773#1151950 (10Ricordisamoa) I can't find any occurrences of either of the two variables in scripts/gadgets (they could use `wgRestrictionEdit`, `wgIsProbablyE... [03:40:41] 10Wikidata, 6MediaWiki-Core-Team, 10MediaWiki-Page-editing, 5Patch-For-Review: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1152084 (10aaron) a:3aaron [07:11:10] (03CR) 10Adrian Lang: "I think this is not the right thing to do. __toString is specified to be the human-readable representation of the EntityId, which might di" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199625 (https://phabricator.wikimedia.org/T93804) (owner: 10Thiemo Mättig (WMDE)) [07:21:06] (03PS4) 10Adrian Lang: Introduce Wikibase\View\HtmlSnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199327 [07:21:31] (03CR) 10Adrian Lang: Introduce Wikibase\View\HtmlSnakFormatterFactory (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199327 (owner: 10Adrian Lang) [08:06:26] Adrian_WMDE, kommst du heute ins Büro? [08:11:34] Hi [08:11:44] Eher nicht, bin immer noch nicht so richtig gesund [08:13:15] Morgen bin ich auf jeden Fall da [08:19:04] (03PS3) 10Adrian Lang: Use EntityIdPlainFormatter in badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199296 [08:19:06] (03PS2) 10Adrian Lang: Introduce wikibase.view.entityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199295 [08:22:52] Adrian_WMDE: mh... Vllt. zieh ich dann für heute auf deinen Platz [08:22:58] Jo, gerne [08:23:49] :) [08:28:41] (03PS4) 10Adrian Lang: Use EntityIdPlainFormatter in badgeselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199296 [08:28:43] (03PS3) 10Adrian Lang: Introduce wikibase.view.entityIdFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199295 [08:30:19] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Decide on and implement a limit for entities accessed via arbitrary access features - https://phabricator.wikimedia.org/T93885#1152437 (10Kersti) One thing, I want to use Wikidata for is translating species names on pages like this one ( https://commons.wikime... [08:42:12] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Can you please link to a reference where the keyword "ntriples" (without dash) is mentioned?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [08:43:48] (03CR) 10Thiemo Mättig (WMDE): "But this summary is formatted later, possibly including a label lookup. This needs the serialization." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199625 (https://phabricator.wikimedia.org/T93804) (owner: 10Thiemo Mättig (WMDE)) [08:48:13] (03CR) 10Thiemo Mättig (WMDE): "I had a chat with Adrian about this patch a few days ago. Problem with this patch is: It creates a dependency on the global "document" var" (031 comment) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/195276 (owner: 10Thiemo Mättig (WMDE)) [08:48:15] (03CR) 10Adrian Lang: "Ah, ok. Then the former was actually wrong." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199625 (https://phabricator.wikimedia.org/T93804) (owner: 10Thiemo Mättig (WMDE)) [08:48:55] (03CR) 10Adrian Lang: "Yeah, I guess it's alright since the whole file depends on a browser, currently." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/195276 (owner: 10Thiemo Mättig (WMDE)) [09:25:10] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Decide on and implement a limit for entities accessed via arbitrary access features - https://phabricator.wikimedia.org/T93885#1152472 (10hoo) >>! In T93885#1152437, @Kersti wrote: > One thing, I want to use Wikidata for, is translating species names on pages... [09:47:06] 10Wikidata, 10Wikidata-Query-Service: Data format updates for RDF export - https://phabricator.wikimedia.org/T93451#1152511 (10mkroetzsch) @Smalyshev Yes, using lower-case local names for properties is a widely used convention and we should definitely follow that for our ontology. However, I would rather not c... [09:51:53] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Decide on and implement a limit for entities accessed via arbitrary access features - https://phabricator.wikimedia.org/T93885#1152517 (10hoo) We talked about this and I think we will do both: Mark the functionality as expensive and have an upper limit within... [09:52:58] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Implement a limit for entities accessed via arbitrary access features and mark as expensive - https://phabricator.wikimedia.org/T93885#1152518 (10hoo) [10:01:07] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-03-26T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/199848 [10:02:13] 10Wikidata: Wikidata produces internal server error in Special:EntityData for redirect - https://phabricator.wikimedia.org/T93950#1152522 (10aude) this is being logged as an HttpError: 2015-03-26 09:58:44 mw1105 wikidatawiki: Failed to load entity Q3775964. (500) from /srv/mediawiki/php-1.25wmf22/extensions/Wik... [10:02:39] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1152523 (10mkroetzsch) @Smalyshev Yes, this is what I was saying. @hoo was proposing to create a special directory f... [10:03:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikidata produces internal server error in Special:EntityData for redirect - https://phabricator.wikimedia.org/T93950#1152525 (10aude) [10:06:06] GerardM-: The screenshot you just sent me: Can you point me to that item? [10:07:30] I added it to https://www.wikidata.org/wiki/Q5113091 using the qnumber ... that worked ok the title did not [10:08:59] (03CR) 10Hoo man: [C: 032] Introduce Wikibase\View\HtmlSnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199327 (owner: 10Adrian Lang) [10:09:18] Mh ok, I'll try to reproduce [10:11:30] GerardM-: Does this happen to you all the time you use that property [10:11:46] I used it twice [10:11:51] am done now [10:12:00] https://tools.wmflabs.org/reasonator/?&q=2346415 [10:12:07] Can you go on a random item and just look whether it happens again? [10:12:30] If so, please also test that logged out (in private browsing mode or so) [10:12:54] (03Merged) 10jenkins-bot: Introduce Wikibase\View\HtmlSnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199327 (owner: 10Adrian Lang) [10:13:22] it did not [10:13:44] Mh, weird [10:13:53] I can't reproduce it either [10:14:15] Yup ... I did not fake it [10:14:54] the languages are still wrong for me [10:15:00] so I do not do much label work [10:26:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: double bracket in redirect summary - https://phabricator.wikimedia.org/T93896#1152564 (10Tobi_WMDE_SW) [10:27:54] hoo: can https://phabricator.wikimedia.org/T92789 be closed? [10:28:30] Tobi_WMDE_SW: No, I only added debug logic to actually diagnose the problem, yet [10:28:40] Still no idea what the root cause is [10:28:54] hoo: ok, putting it on "doing" then [10:29:25] ok [10:31:22] Thiemo_WMDE: hoo: is this now fixed on master too? https://phabricator.wikimedia.org/T93804 [10:31:57] Tobi_WMDE_SW: not that i know [10:32:19] No, don't think so [10:33:05] * aude is not enthusiatic about reverting people's changes [10:33:20] if there can be alternative solution that doesn't require revert, i would like that but [10:33:36] since adrian is not here, maybe revert for now and then can unrevert/fix later [10:34:44] ok, I was just wondering because Thiemo_WMDE mentioned this bug in one of his changes that got merged [10:35:26] (03PS3) 10Aude: Revert "Use EntityIdFormatter in MessageParameterFormatter" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199586 (https://phabricator.wikimedia.org/T93804) [10:36:14] (03CR) 10Aude: "i don't have another solution. this might be the best option for now, so removing the -2 if someone wants to merge it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199586 (https://phabricator.wikimedia.org/T93804) (owner: 10Aude) [10:36:48] what i don't want is to forget about fixing something on master [10:36:54] and then bug reappear next deployment [10:38:23] aude: Adrian was working remote earlier on [10:38:30] and he uploaded a few changes related [10:38:36] We should review them first, IMO [10:38:38] i know [10:38:48] I already started with one, but that's only JS [10:38:55] (03CR) 10Thiemo Mättig (WMDE): T92996: Add Julian Calendar support (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [10:39:10] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See my comments in PS8." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [10:39:38] https://gerrit.wikimedia.org/r/#/c/199295/ has potential to cause problems with cherry picks [10:39:43] unless it magically fixes bugs [10:41:37] (03CR) 10Aude: "unless this somehow fixes some of the deployment bugs like https://phabricator.wikimedia.org/T93864, then I would like bug fixes first the" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199295 (owner: 10Adrian Lang) [10:43:24] Mh :/ [10:43:30] I already started reviewing it [10:43:38] will pause that [11:03:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 7Need-volunteer, and 2 others: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?) - https://phabricator.wikimedia.org/T66084#1152633 (10thiemowmde) https://github.com/DataValues/Time/pull/5... [11:09:21] [13Number] 15thiemowmde 04force-pushed 06getFormatterClass from 1421e8f9c to 14fb84d85: 02http://git.io/xdPF [11:09:21] 13Number/06getFormatterClass 14fb84d85 15Thiemo Mättig: Deprecate getFormatterClass in favor of getInstance [11:13:55] [13Geo] 15thiemowmde 04force-pushed 06getFormatterClass from 14aae4bc7 to 148cbf82b: 02http://git.io/pSNi [11:13:55] 13Geo/06getFormatterClass 148cbf82b 15Thiemo Mättig: Deprecate getFormatterClass in favor of getInstance [11:21:02] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Implement a limit for entities accessed via arbitrary access features and mark as expensive - https://phabricator.wikimedia.org/T93885#1152650 (10Kersti) hoo: improving page rendering speed is not within the scope of Wikidata I know. I simply wantet, that you... [11:21:49] [13Number] 15thiemowmde 04force-pushed 06getFormatterClass from 14fb84d85 to 14c85f595: 02http://git.io/xdPF [11:21:49] 13Number/06getFormatterClass 14c85f595 15Thiemo Mättig: Deprecate getFormatterClass in favor of getInstance [11:38:30] [13Geo] 15thiemowmde created 06optionsNull (+1 new commit): 02http://git.io/j3Zu [11:38:30] 13Geo/06optionsNull 144c31983 15Thiemo Mättig: Allow options to be null [11:38:31] DanielK_WMDE_: https://phabricator.wikimedia.org/T72385#1150442 [11:39:15] [13Geo] 15thiemowmde opened pull request #47: Allow options to be null (06master...06optionsNull) 02http://git.io/j3Zy [11:45:25] [13Time] 15thiemowmde 04force-pushed 06getFormatterClass from 1488e2588 to 141ed59dd: 02http://git.io/pSFc [11:45:25] 13Time/06getFormatterClass 141ed59dd 15Thiemo Mättig: Deprecate getFormatterClass in favor of getInstance [11:50:57] (03PS1) 10Thiemo Mättig (WMDE): Update data-values/interfaces to 0.1.5 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199858 (https://phabricator.wikimedia.org/T92280) [11:51:23] 10Wikidata, 10DataValues, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Make [Formatter|Parser]Options nullable/optional everywhere - https://phabricator.wikimedia.org/T92280#1152691 (10thiemowmde) More relevant patches to finally finish this: * https://github.com/DataV... [11:55:47] 10Wikidata, 10DataValues, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Make [Formatter|Parser]Options nullable/optional everywhere - https://phabricator.wikimedia.org/T92280#1152698 (10thiemowmde) [11:59:57] 10Wikidata, 10Continuous-Integration, 6Release-Engineering, 7Browser-Tests, 5Patch-For-Review: browsertest jobs should not be allowed to run for 10 hours - https://phabricator.wikimedia.org/T92275#1152702 (10zeljkofilipin) [12:04:17] 10Wikidata: Generate RDF from JSON - https://phabricator.wikimedia.org/T94019#1152708 (10daniel) 3NEW [12:05:23] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance: mw.wikibase: Use __index to lazy load entity contents - https://phabricator.wikimedia.org/T76156#1152715 (10hoo) p:5High>3Normal We talked about this and decided to go with T93885 first. If that doesn't suffice or we hit further problems, w... [12:10:59] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Code looks good in my opinion. Not sure about the consequences (performance-wise). Maybe Danial want's to have a final look? I will merge " (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190680 (https://phabricator.wikimedia.org/T78526) (owner: 10Hoo man) [13:26:40] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "A typo and several questions." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198223 (owner: 10Daniel Kinzler) [13:26:44] aude: https://www.wikidata.org/wiki/Q14171368 [13:33:35] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I agree with Daniel. Passing a field name around is weird and doesn't seem necessary. If a DBMS doesn't support altering a schema, that's " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/114490 (owner: 10Jeroen De Dauw) [13:39:31] (03CR) 10Daniel Kinzler: Provide documentation for usage tracking migration (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198223 (owner: 10Daniel Kinzler) [13:40:46] (03PS6) 10Daniel Kinzler: Provide documentation for usage tracking migration [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198223 [13:41:01] Thiemo_WMDE: --^ [13:44:34] Can I bribe someone for https://gerrit.wikimedia.org/r/198771 ? [13:57:29] hoo: chocolate cebras [13:58:31] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "My arguments:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194960 (https://phabricator.wikimedia.org/T92375) (owner: 10Daniel Kinzler) [13:58:49] (03CR) 10Daniel Kinzler: "@Luci: did you do the manual testing? you can indicate that by giving verified+1 in addition to CR+1" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198771 (https://phabricator.wikimedia.org/T93607) (owner: 10Hoo man) [14:00:21] (03PS12) 10Daniel Kinzler: Refactoring dispatchChanges.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 [14:00:30] hoo: --^ [14:04:40] (03CR) 10Daniel Kinzler: [C: 032] "Using EPP should be a lot faster than using an EntityLookup. So, good to go, thanks!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190680 (https://phabricator.wikimedia.org/T78526) (owner: 10Hoo man) [14:07:59] (03Merged) 10jenkins-bot: Supply edit token when testing special pages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194960 (https://phabricator.wikimedia.org/T92375) (owner: 10Daniel Kinzler) [14:08:02] (03Merged) 10jenkins-bot: Data provider for testing SpecialSetLabelDescritionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194524 (owner: 10Daniel Kinzler) [14:08:05] (03Merged) 10jenkins-bot: Make SpecialGoToLinkedPage support entity redirects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190680 (https://phabricator.wikimedia.org/T78526) (owner: 10Hoo man) [14:13:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Special:GoToLinkedPage should support redirects - https://phabricator.wikimedia.org/T78526#1152984 (10hoo) 5Open>3Resolved [14:13:20] (03CR) 10Lucie Kaffee: [V: 031] "Yes, did manual testing. Thanks for the hint :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198771 (https://phabricator.wikimedia.org/T93607) (owner: 10Hoo man) [14:14:01] hey, is meta's {{int:wm-license-cc-by-3.0-text}} something related to wikidata? [14:14:22] and if so, how can i get the text of CC0? [14:14:29] (03CR) 10Daniel Kinzler: "I don't understand the n-triples => ntriples move." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [14:14:35] (03CR) 10Daniel Kinzler: [C: 04-1] T93965: Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [14:15:07] aharoni, GerardM-, maybe you could help me [14:22:41] ah, evil google and facebook. because of them usefulness of irc for quick information has become around zero :P [14:24:41] wikimedia/mediawiki-extensions-Wikibase/master/91dc6e6 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/55953919 [14:25:54] (03CR) 10Daniel Kinzler: [C: 04-1] "See inline." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 (owner: 10Smalyshev) [14:31:12] millosh {{int:wm-license-cc-zero-text}} tttps://meta.wikimedia.org/wiki/MediaWiki:Wm-license-cc-zero-text [14:31:56] oh, MediaWiki... great! Alphos, thanks! [14:32:07] i was trying to find it under Template namespace [14:33:06] (03PS1) 10Hoo man: Make SpecialSetLabelDescriptionAliasesTest work on non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199905 [14:33:07] you know what ? i thought of that first, but when it didn't show up, i looked up "int" on mediawiki.org, and found it ^_^ [14:33:16] DanielK_WMDE_: aude: https://gerrit.wikimedia.org/r/199905 [14:33:18] Fixes travis [14:34:11] (03CR) 10Daniel Kinzler: [C: 04-1] "The handling of data types here is wrong (actually, it's also wrong in current master, it seems). The change to the data type handling is " (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [14:37:53] (03PS2) 10Hoo man: Make SpecialSetLabelDescriptionAliasesTest work on non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199905 [14:39:35] (03CR) 10JanZerebecki: [C: 032] Make SpecialSetLabelDescriptionAliasesTest work on non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199905 (owner: 10Hoo man) [14:43:38] (03CR) 10Daniel Kinzler: "I agree with thiemo: some parts of this are obvious improvements and could go in right away. other parse need discussion, or are suspiciou" (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [14:43:48] (03Merged) 10jenkins-bot: Make SpecialSetLabelDescriptionAliasesTest work on non-English wikis [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199905 (owner: 10Hoo man) [14:44:16] (03PS1) 10Aude: Set _focusToValueView on entityselectorselected event in snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199910 (https://phabricator.wikimedia.org/T93864) [14:46:32] (03PS1) 10Aude: Fix typo in TurtleRdfWriter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199912 [14:46:47] no can haz typos :) [14:47:01] (03CR) 10Daniel Kinzler: [C: 04-1] "naming issue" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 (owner: 10Thiemo Mättig (WMDE)) [14:47:48] (03CR) 10Daniel Kinzler: "@hoo I'm trying to avoid subclassing for tests. but it would be possible, if there is a good reason, of course." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 (owner: 10Thiemo Mättig (WMDE)) [14:48:03] (03CR) 10jenkins-bot: [V: 04-1] Set _focusToValueView on entityselectorselected event in snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199910 (https://phabricator.wikimedia.org/T93864) (owner: 10Aude) [14:54:33] (03PS2) 10Aude: Set _focusToValueView on entityselectorselected event in snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199910 (https://phabricator.wikimedia.org/T93864) [14:56:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6MediaWiki-Core-Team, 5Patch-For-Review: SpecialNewEntity needing the master on GET/HEAD? - https://phabricator.wikimedia.org/T94030#1153136 (10aude) [14:57:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6MediaWiki-Core-Team, 5Patch-For-Review: SpecialNewEntity needing the master on GET/HEAD? - https://phabricator.wikimedia.org/T94030#1153075 (10aude) is there a patch for review? [14:59:14] 10Wikidata: Python property suggester scripts need improved error handling - https://phabricator.wikimedia.org/T93872#1153147 (10aude) 5Open>3Resolved [14:59:40] (03CR) 10Daniel Kinzler: [C: 04-1] "I like the refactoring, it's a lot nicer this way." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197093 (owner: 10Thiemo Mättig (WMDE)) [14:59:53] 10Wikidata: Investigate using RESTBase for batched entity lookups - https://phabricator.wikimedia.org/T93913#1153150 (10aude) p:5Triage>3Normal [15:01:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6MediaWiki-Core-Team: SpecialNewEntity needing the master on GET/HEAD? - https://phabricator.wikimedia.org/T94030#1153151 (10aaron) [15:01:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6MediaWiki-Core-Team: SpecialNewEntity needing the master on GET/HEAD? - https://phabricator.wikimedia.org/T94030#1153075 (10aaron) No, that's just phab carrying over parent tags. [15:02:42] (03CR) 10Daniel Kinzler: Cleanup bits in SpecialSetLabelDescriptionAliasesTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199260 (owner: 10Thiemo Mättig (WMDE)) [15:07:41] (03PS1) 10Thiemo Mättig (WMDE): Split and refactor large SpecialPageTestBase method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199913 (https://phabricator.wikimedia.org/T92375) [15:10:04] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I will drop SpecialPageTestBase from this patch, see Ic708ed8 instead." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199260 (owner: 10Thiemo Mättig (WMDE)) [15:11:22] wikimedia/mediawiki-extensions-Wikibase/master/066431f : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/55959047 [15:11:30] (03CR) 10jenkins-bot: [V: 04-1] Split and refactor large SpecialPageTestBase method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199913 (https://phabricator.wikimedia.org/T92375) (owner: 10Thiemo Mättig (WMDE)) [15:18:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Focus not in main snak value after selecting a property with mouse - https://phabricator.wikimedia.org/T93864#1153220 (10aude) [15:27:11] 10Wikidata, 10MobileFrontend-Feature-requests, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1153267 (10Jdlrobson) If anyone takes on the microtask associated with that and completes it I have plenty more to add and it would certainl... [15:28:27] 10Wikidata, 10MobileFrontend-Feature-requests, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1153279 (10Jdlrobson) (microtask being T93127) [15:28:49] 10Wikidata, 10Continuous-Integration, 6Release-Engineering, 7Browser-Tests, 5Patch-For-Review: browsertest jobs should not be allowed to run for 10 hours - https://phabricator.wikimedia.org/T92275#1153284 (10zeljkofilipin) Oops, sorry about that. I am looking at [[ https://integration.wikimedia.org/ci/vi... [15:40:31] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1153339 (10hoo) I poked at this some more and I'm super clueless now: It s... [15:59:59] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Factor the Scribunto integration out of Wikidata Client - https://phabricator.wikimedia.org/T62427#1153396 (10hoo) 5Open>3Invalid This wont happen and I also don't really see the case for it right now. [16:00:04] 10Wikidata, 10Continuous-Integration, 6Release-Engineering, 7Browser-Tests, 5Patch-For-Review: browsertest jobs should not be allowed to run for 10 hours - https://phabricator.wikimedia.org/T92275#1153398 (10zeljkofilipin) 5Open>3Resolved [16:01:57] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Tracking: Reimplement Wikibase data structures in Lua - https://phabricator.wikimedia.org/T57920#1153400 (10hoo) 5Open>3Invalid a:3hoo This bug is way to generic to be useful. Also we wont re-generate all of data model in Lua. [16:03:43] 10Wikidata, 10Wikimedia-Site-requests: Convert all `sites` tables to use https URLs - https://phabricator.wikimedia.org/T85754#1153410 (10hoo) 5Open>3declined a:3hoo This will make https only URLs show up in the SiteLinksView and we don't want this. The real solution is to change sites to https whenever... [16:03:50] (03PS5) 10Thiemo Mättig (WMDE): Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 (owner: 10Daniel Kinzler) [16:05:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7Need-volunteer, 5Patch-For-Review: wbmergeitems adds alias when a duplicate label / alias already existed on target item - https://phabricator.wikimedia.org/T91327#1153413 (10hoo) 5Open>3declined a:3hoo I agree with the above statements... [16:06:02] (03CR) 10Hoo man: [C: 04-2] "Bug has been declined, sorry." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197909 (https://phabricator.wikimedia.org/T91327) (owner: 10Sumit) [16:06:23] (03PS3) 10Thiemo Mättig (WMDE): Cleanup bits in SpecialSetLabelDescriptionAliasesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199260 [16:07:58] (03PS4) 10Thiemo Mättig (WMDE): Cleanup bits in SpecialSetLabelDescriptionAliasesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199260 [16:08:07] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1153420 (10aaron) If a job is marked as active then it was popped and star... [16:09:46] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: purge does not update langlinks table - https://phabricator.wikimedia.org/T61961#1153424 (10hoo) 5Open>3Resolved a:3hoo This has been fixed in the mean time, see T89903. Purging without `forcelinkupdate` is not expected to purge any secondary data, so th... [16:09:58] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 (owner: 10Daniel Kinzler) [16:11:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: write script that touches every item and thereby updates database tables - https://phabricator.wikimedia.org/T66600#1153430 (10hoo) p:5High>3Normal No longer as important as it used to be. [16:13:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Query-Service, 7Tracking: Query by one property and one value ("simple queries") (tracking) - https://phabricator.wikimedia.org/T54385#1153435 (10hoo) [16:13:04] 10Wikidata, 10WikibaseDatabase: Revive WikibaseDatabase - https://phabricator.wikimedia.org/T73499#1153433 (10hoo) 5Open>3declined a:3hoo [16:15:54] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Need-volunteer: Introduce client specific novalue and somevalue SnakFormatters - https://phabricator.wikimedia.org/T66304#1153441 (10hoo) p:5High>3Normal [16:16:25] (03Merged) 10jenkins-bot: Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 (owner: 10Daniel Kinzler) [16:18:54] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Testme: Investigation: edit conflict for (almost) concurrently save-operations on the same entity - https://phabricator.wikimedia.org/T73555#1153452 (10hoo) 5Open>3Resolved a:3hoo Haven't personally seen this in a while, although changing a lot of... [16:20:11] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1153469 (10hoo) >>! In T92789#1153420, @aaron wrote: > If a job is marked... [16:25:59] (03Abandoned) 10Sumit: ChangeOpsMerge Case insensitive string check added [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197909 (https://phabricator.wikimedia.org/T91327) (owner: 10Sumit) [16:34:50] how are qualifier hashes created ? do they rely solely on the value, or also on the property of the qualifier ? [16:41:55] 10Wikidata, 10MobileFrontend-Feature-requests, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1153514 (10Sumit) I've setup the boilerplate extension on my userspace at github, now filling in a request at https://www.mediawiki.org/wiki... [16:42:57] 10Wikidata, 10MobileFrontend-Feature-requests: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1153515 (10Jdlrobson) a:3Sumit [16:48:04] 10Wikidata, 10Datasets-General-or-Unknown, 6operations, 3§ Wikidata-Sprint-2015-03-24: Wikidata dumps contain old-style serialization. - https://phabricator.wikimedia.org/T74348#1153537 (10hoo) [16:59:51] 10Wikidata, 10Wikidata-Query-Service: Data format updates for RDF export - https://phabricator.wikimedia.org/T93451#1153592 (10Smalyshev) I agree, I wouldn't change P1234 to lowercase, I was talking about other things like predicates wikibase:Rank or wikibase:Badge which probably should be wikibase:rank and wi... [17:05:06] (03PS2) 10Thiemo Mättig (WMDE): Split and refactor large SpecialPageTestBase method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199913 (https://phabricator.wikimedia.org/T92375) [17:12:01] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1153614 (10aaron) So the jobs have nowiki as a parameter? If not, shouldn'... [17:12:04] (03CR) 10Smalyshev: "Daniel, the wikibase config has types whitelist and it has 'ntriples' there. Anything not in whitelist is ignored. .nt in current code tra" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [17:13:22] (03CR) 10Smalyshev: "ntriples is in config/Wikibase.default.php" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [17:16:08] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1153628 (10hoo) >>! In T92789#1153614, @aaron wrote: > So the jobs have no... [17:17:11] (03CR) 10Smalyshev: T92996: Add Julian Calendar support (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [17:18:48] (03PS2) 10Daniel Kinzler: Make mw.wikibase.getEntity == mw.wikibase.getEntityObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198771 (https://phabricator.wikimedia.org/T93607) (owner: 10Hoo man) [17:19:03] (03CR) 10Daniel Kinzler: [C: 032] Make mw.wikibase.getEntity == mw.wikibase.getEntityObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198771 (https://phabricator.wikimedia.org/T93607) (owner: 10Hoo man) [17:21:21] (03CR) 10Smalyshev: Refactor prefixes to be output only once, eliminate need to clean prefixes on dump (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 (owner: 10Smalyshev) [17:22:44] DanielK_WMDE_: will you have time today to look at the patches? RDF output is broken right now and 3 other things are pending too [17:23:10] SMalyshev: i did a bunch of reviews of the rdf patches a few hours ago [17:23:18] i don't know whther i'll have time for another round [17:23:36] SMalyshev: what exactly is broken? [17:23:42] (03Merged) 10jenkins-bot: Make mw.wikibase.getEntity == mw.wikibase.getEntityObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198771 (https://phabricator.wikimedia.org/T93607) (owner: 10Hoo man) [17:24:59] DanielK_WMDE_: .nt doesn't work at all. .rdf produces broken XML [17:25:42] doesn't work == produces 415 when tried [17:26:57] SMalyshev: i saw the fix for the broken XML, but it's mixed together with a different patch. can you isolate it? [17:27:09] I'll look into the 415 issue [17:27:19] or do you have a patch for that, too? [17:27:25] is it the n-triples vs ntriples thing? [17:27:37] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking, 7notice: Allow accessing data from a Wikidata item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#1153686 (10hoo) [17:27:38] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 5Patch-For-Review: Make mw.wikibase.getEntity and mw.wikibase.getEntityObject the same function - https://phabricator.wikimedia.org/T93607#1153683 (10hoo) 5Open>3Resolved a:3hoo To be deployed April 7 (non-Wikipedias) and 8 (Wikipedias). [17:28:17] DanielK_WMDE_: yes, the patch fixes both things [17:28:30] DanielK_WMDE_: that's the ntriples thing, yes [17:28:50] hm... i want to understand in more detail what the problem is there [17:29:01] regarding ntriples [17:29:23] for the xml stuff, i wonder why the tests didn't show it. did you add a regre4ssion test when fixing the issue? [17:30:27] DanielK_WMDE_: apparently the tests never tested full document, just snippets [17:31:07] that happens only on full document using subdocuments [17:31:18] or subwriters as they are [17:32:24] (03CR) 10Smalyshev: Performance tweaks (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [17:32:51] SMalyshev: oh damn, fixes for sub-documents, and tests, didn't make it in the base patch. subdocument stuff is pretty much broken there. but i already have a patch fixing this. [17:32:53] let me find it [17:32:57] (03CR) 10Smalyshev: Performance tweaks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [17:33:23] (03PS4) 10Daniel Kinzler: RdfWriter: add RDR support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197302 [17:33:34] (03CR) 10jenkins-bot: [V: 04-1] RdfWriter: add RDR support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197302 (owner: 10Daniel Kinzler) [17:33:40] DanielK_WMDE_: ok, if you want to fix subdocument thing in your patch that's fine [17:33:52] SMalyshev: the rdr patch should fix it https://gerrit.wikimedia.org/r/#/c/197302/ [17:33:58] needs a rebase, but should otherwise be fine [17:33:59] will check later [17:34:11] i'm in the middle of debugging on another front... [17:38:02] DanielK_WMDE_: yeah but I think RDR is lower priority and 2 formats broken in master should be higher, no? [17:38:47] SMalyshev: sure. could try to split off the sub() fix from the rdr patch. maybe i will. or look into it and prefer yours. i'll look into it later [17:40:48] DanielK_WMDE_: ok. will you have time today to look into other patches too? [17:41:14] SMalyshev: i think i looked into all of them today. did i miss one? [17:41:49] DanielK_WMDE_: I think they need some more discussion [17:42:33] did you reply on the ticket? then i'll see it later [17:42:58] yes I did [17:43:29] but I'd rather discuss it online if possible otherwise we have a roundtrip time of a whole day which makes getting things done very slow [17:43:33] (03PS4) 10Thiemo Mättig (WMDE): Make SpecialSetLabelDescriptionAliases a 2-step process [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194105 (https://phabricator.wikimedia.org/T91387) [17:44:08] SMalyshev: of course. if we both have time, we can do that. i may actually finish this in ten minutes. or it takes another two hours, and i'll go home [17:44:16] with debugging, you never know [17:44:28] ok [17:44:43] please ping me when you're done then [18:00:04] (03CR) 10Ebrahim: "Hey guys, any thought on this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [18:01:12] Adrian Lange on IRC? [18:01:13] RE: https://gerrit.wikimedia.org/r/#/c/180418/25 [18:05:37] (03CR) 10Smalyshev: "Thiemo, please see latest patch, some of the algorithm was changed. The basic premise though is that for Julian, we can not convert "weird" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [18:06:16] (03CR) 10Thiemo Mättig (WMDE): Split individual tests in UsageAccumulatorContractTester (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 (owner: 10Thiemo Mättig (WMDE)) [18:08:28] (03PS3) 10Thiemo Mättig (WMDE): Split individual tests in UsageAccumulatorContractTester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 [18:16:45] (03CR) 10jenkins-bot: [V: 04-1] Split individual tests in UsageAccumulatorContractTester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 (owner: 10Thiemo Mättig (WMDE)) [18:22:09] Krinkle: not at the moment. he'll be in the office again tomorrow [18:24:40] (03CR) 10Thiemo Mättig (WMDE): Split MonthNameUnlocalizer into Base and MediaWiki part (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197093 (owner: 10Thiemo Mättig (WMDE)) [18:24:56] (03PS8) 10Thiemo Mättig (WMDE): Split MonthNameUnlocalizer into Base and MediaWiki part [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197093 [18:25:29] 10Wikidata: check existing Julian dates in json blobs and their calendar model - https://phabricator.wikimedia.org/T94058#1153888 (10Lydia_Pintscher) 3NEW a:3Lucie [18:25:42] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: check existing Julian dates in json blobs and their calendar model - https://phabricator.wikimedia.org/T94058#1153897 (10Lydia_Pintscher) [18:28:56] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Compile list of statements that contain time values marked as Julian - https://phabricator.wikimedia.org/T89247#1153909 (10Lydia_Pintscher) a:3Lucie [18:29:30] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Compile list of statements that contain time values marked as Julian - https://phabricator.wikimedia.org/T89247#1031139 (10Lydia_Pintscher) [18:29:32] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: check existing Julian dates in json blobs and their calendar model - https://phabricator.wikimedia.org/T94058#1153912 (10Lydia_Pintscher) [18:32:00] are people still at the office? [18:32:30] * aude wants bug number for qualifiers focus issue [18:32:47] * aude search phabricator [18:34:06] aude: got it or should i look? [18:34:20] got it [18:34:27] cool [18:35:00] and wow, https://gerrit.wikimedia.org/r/#/c/180174/ ... we had this problem before and this is almost the same fix again [18:35:07] wonder how/why it got removed [18:35:57] ack [18:36:34] (03CR) 10Ebrahim: "> Hey guys, any thought on this?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [18:36:50] at least my solution appears sane :) [18:37:45] :) [18:38:10] aude: spend half an hour trying to reproduce your dispatcher issue, and failed. works fine for me. [18:38:55] the refactored version of dispatchCHanges has hoo's fixes, and my fix for the filtering. i'd say we just review & deploy that, and see what happens. [18:39:32] aude: if you want to try again, try the refactored version https://gerrit.wikimedia.org/r/#/c/198427/ [18:39:44] DanielK_WMDE_: not today, but definitely interested [18:39:51] maybe tomorrow [18:39:55] yeah [18:40:54] Lydia_WMDE: i would like browser tests (not sure how to do in qunit) for these focus issues [18:41:10] suppose i can look again how to do them, or maybe someone else can help [18:41:36] aude: me too! i discussed this with fisch and Tobi_WMDE_SW_NA 2 weeks ago. focus testing is apparently really hard to do -.- [18:42:10] :( [18:42:28] (03PS2) 10Aude: Fix focus when clicking "add qualifier" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199962 (https://phabricator.wikimedia.org/T89300) [18:42:30] (03PS3) 10Aude: Set _focusToValueView on entityselectorselected event in snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199910 (https://phabricator.wikimedia.org/T93864) [18:42:45] 10Wikidata, 10MediaWiki-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Rollback diff causes error - https://phabricator.wikimedia.org/T93866#1153976 (10Umherirrender) [18:49:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: allow arbitrary data access on Wikidata (parser function) - https://phabricator.wikimedia.org/T70029#1153997 (10hoo) Note to whoever (probably me) will do this: Please keep in mind T93885 when doing this and implement it accordingly for this. [18:50:51] hmmm https://phabricator.wikimedia.org/T93864 seems to be on master only [18:50:54] and not on wikidata [18:52:46] but my screenshot in the bug is clearly from wikidata [18:53:34] hoo: you are the new Adrian? [18:53:38] 10Wikidata, 10Wikidata-Query-Service: date of +0000-01-01 is allowed in wikibase but has no meaning - https://phabricator.wikimedia.org/T94064#1154010 (10JanZerebecki) 3NEW [18:54:00] JeroenDeDauw: Yes, but tomorrow I'm going to be the new Lucie_WMDE ... prepare! :D [18:54:08] * aude was confused. bug is on wikidata and my patch will fix [18:54:14] aude: Bug? [18:54:21] oh, scrollback [18:55:40] hoo: the focus bugs [18:55:59] thought one was only on master, but was briefly confused :o [18:56:42] would be ideal for adrian to review, but then again, if i am awake in 4 hours from now then swat woudl be nice [18:57:10] I can have a quick look after I'm done with this patch [18:57:14] ok [18:58:00] Lydia_WMDE, aude: phantomjs doesn't support focus, but karma (in its firefox and chrome variant) is said to, so if we first switch our job to karma a qunit test might work. adrian started that in https://gerrit.wikimedia.org/r/#/c/198699/ [18:58:12] hoo: :0 [18:58:13] * aude had a nap so probably will be awake :) [18:58:29] jzerebecki: sounds promising [19:06:52] (03PS1) 10Hoo man: Mark accessing arbitrary items as expensive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199969 (https://phabricator.wikimedia.org/T93885) [19:08:37] i am trying the patches on the branch now [19:08:51] think there are some differences from master in how things are broken currently [19:09:06] [13Geo] 15JeroenDeDauw comment on pull request #47 144c31983: This change might not be doing what you wanted to achieve. What are you trying to do here? 02http://git.io/jZ6o [19:09:31] aude: Do they apply cleanly? [19:10:18] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06floo at 1492fe43e: 02http://git.io/jZiT [19:10:19] no [19:10:45] on wikidata, after choosing a property, focus goes to "add qualifier" [19:10:54] on master focus doesn't change at all [19:11:05] :S [19:11:11] So there's more brokeness here? [19:11:12] i think we can cherry pick da4a2d5ef4f7b5318b5d2c28b8c20a1b98848df1 also [19:11:21] *waves* :) hope everyone is well! [19:11:28] which is the conflict and then it probably is good [19:11:37] * aude waves! [19:11:40] addshore: Hey! We are :D [19:12:22] aude: Yeah, looks safe at a glance, but let me dig deeper [19:12:42] hoo: i am happy with the 3 patches together [19:12:54] apply cleanly and fix the issues, afaik [19:14:29] Ok, that looks safe to me (da4a2d5ef4f7b5318b5d2c28b8c20a1b98848df1) [19:14:48] (03PS1) 10Hoo man: Remove unused EntityStore::get call [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199971 [19:14:50] yeah [19:15:15] * aude is going to get food now [19:17:21] aude: Do you need all three changes or only those two? [19:18:10] all of them [19:18:30] 10Wikidata, 10Wikidata-Query-Service: date of +0000-01-01 is allowed in wikibase but has no meaning - https://phabricator.wikimedia.org/T94064#1154110 (10Smalyshev) OK, so that means we can not have year 0. The question is, what should we do with it? We have quite a lot of such items: http://milenio.dcc.uchil... [19:19:20] https://gerrit.wikimedia.org/r/#/c/199962/ and https://gerrit.wikimedia.org/r/#/c/199910/ [19:19:24] 10Wikidata, 10Wikidata-Query-Service: Date of +0000-01-01 is allowed in wikibase but has no meaning as xsd:dateTime - https://phabricator.wikimedia.org/T94064#1154120 (10Smalyshev) p:5Triage>3Normal [19:19:39] * aude really going to get food now :) [19:19:49] back in ~45 min [19:20:26] 10Wikidata, 10Wikidata-Query-Service: Date of +0000-01-01 is allowed in wikibase but has no meaning as xsd:dateTime - https://phabricator.wikimedia.org/T94064#1154010 (10Smalyshev) a:3Smalyshev [19:20:37] (03PS1) 10Daniel Kinzler: RdfWriter: fix sub-writers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199975 [19:20:49] SMalyshev: sub-writer fix --^ [19:21:03] somewhat similar to yours, but introduces infrastructures i need fro my rdr implementation. [19:21:30] (03PS2) 10Daniel Kinzler: RdfWriter: fix sub-writers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199975 [19:21:48] orr [19:21:57] DanielK_WMDE_: this looks like a pretty big change for a simple fix [19:22:45] DanielK_WMDE_: are you sure this is necessary to fix this problem? [19:22:51] SMalyshev: yes, because it overhauls the sub.-writer logic. [19:22:58] no, it's not all necessary [19:23:02] DanielK_WMDE_: Also, I don't understand what >>'s do in Turtle writer [19:23:03] but i don't want to do it twice [19:23:45] SMalyshev: left over from the rdr stuff. i split the patch, and forgot to remove this. [19:23:50] this seems to be something from RDR patch which I'm not even sure we want to do before we finish with proper rdf [19:23:56] sorry, my concentration is failing, and my mood is dropping. [19:24:38] i really wanted to get thsi in tonight (yours or mine, whatever), but i don't think i'll manage either [19:24:41] (03CR) 10jenkins-bot: [V: 04-1] RdfWriter: fix sub-writers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199975 (owner: 10Daniel Kinzler) [19:24:47] i'm hitting the ten hour mark [19:25:06] DanielK_WMDE_: so, you want to clean it up? or you want me to clean it up and commit when done? [19:25:44] DanielK_WMDE_: we have this immediate breakage and 4 other patches pending. we need to find some way to do it more efficient [19:26:09] if we take 3 days of back and forth for every small patch we'll never finish this [19:27:15] SMalyshev: I just asked hoo and he knows how to create a dump from beta. the downside would be that it is not the same database as in production. and the beta db mostly contains test nonsense. thus it is probably as useful as creating a dump on your own installation. [19:27:33] so if there is demand for it just ask him. [19:27:47] jzerebecki: no, then it's not good. I already have the nonsense dump :) [19:27:54] I wanted the real one [19:28:10] but we can prepare the infrastructure at leats - to see the scripts run etc. [19:28:26] maybe also for Nik's work so he could test the integrations [19:28:36] jzerebecki: so maybe it's still useful [19:31:23] DanielK_WMDE_: so, what can we do here? [19:32:34] (03CR) 10Hoo man: [C: 04-1] "Please test" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199910 (https://phabricator.wikimedia.org/T93864) (owner: 10Aude) [19:36:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Regression: Warn when trying to add two same aliases or an alias same as label or another alias - https://phabricator.wikimedia.org/T94072#1154173 (10matej_suchanek) 3NEW [19:37:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Regression: Warn when trying to add two same aliases or an alias same as label or another alias - https://phabricator.wikimedia.org/T94072#1154182 (10matej_suchanek) [19:37:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign header - https://phabricator.wikimedia.org/T75654#1154181 (10matej_suchanek) [19:44:29] SMalyshev: honestly, I don't like any of the short term options. All of them cause work down the road :/ [19:45:39] DanielK_WMDE_: right now we're wasting a lot of time. Do you want to set up daily 1-2 hr so we could discuss these things and make it faster? [19:46:16] the timezones are not in our favor but I think we can find some hour that can work [19:46:17] SMalyshev: it's not realistic. i'm doing the rdf stuff on top of my usual workload right now. [19:46:37] i'll merge your quick fix patch for now [19:46:37] DanielK_WMDE_: let's talk to Lydia then to find some solution for it [19:46:44] it's not doing any harm [19:47:57] (03CR) 10Daniel Kinzler: [C: 032] "This is the quickest path out of the current breakage, and it's not doing any harm. I'll have to rebase some stuff, but i'll manage." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [19:48:09] DanielK_WMDE_: ok, cool [19:48:47] but longer term - we need some solution for it at least until we get this on the road (then the time spent and urgency probably will be less) [19:49:30] aude: I will probably go away in a bit, but leave my stuff here and be back before the deployment to review your changes [19:49:35] DanielK_WMDE_: do you want me to start the discussion with Lydia on this? Maybe we can ask somebody else to help with something here [19:50:01] SMalyshev: Thiemo and Jan? [19:50:41] DanielK_WMDE_: maybe. I'm good with anything that makes it move without delaying multi-days and without causing you to work 12 hr days :) [19:50:43] (03Merged) 10jenkins-bot: T93965: Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [19:52:40] I'll write an email and see where it takes us then [19:53:12] 10Wikidata, 5Patch-For-Review: .rdf and .nt special page data exports broken in master - https://phabricator.wikimedia.org/T93965#1154287 (10Smalyshev) 5Open>3Resolved [19:59:06] Thiemo_WMDE: around? :P [20:01:20] SMalyshev: yea, I have too many half finished patches, for rdf and other stuff. i probably should just call it a day, before i scre something up. i hope with your patch merged, the most pressing issue is out of the way. [20:02:00] DanielK_WMDE_: yes, it is but we still have to move forward at least with performance angle... [20:11:51] Lydia_WMDE: hehe, trolled you guys a biut [20:11:54] *bit [20:12:31] "You completed the first application step successful and we like to invite you to our second application round." :p [20:23:05] sorry [20:25:28] Anyone with any idea if when dragging a text snippet from one tab to another (for example in chrome) you can get the URL for the page the snippet was dragged from from the JS drop event object? [20:27:12] 10Wikidata, 6Collaboration-Team, 6Editing, 6Engineering-Community, and 15 others: Create team projects for all teams participating in scrum of scrums - https://phabricator.wikimedia.org/T1211#1154422 (10Yurik) [20:27:59] 10Wikidata, 6Collaboration-Team, 6Editing, 6Engineering-Community, and 14 others: Create team projects for all teams participating in scrum of scrums - https://phabricator.wikimedia.org/T1211#20962 (10Yurik) [20:33:36] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Fix focus when clicking "add qualifier" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199962 (https://phabricator.wikimedia.org/T89300) (owner: 10Aude) [20:39:33] 10MediaWiki-extensions-WikibaseRepository, 6Security, 5Patch-For-Review, 7Verified: [WikibaseRepo] XSS: Labels shown in "In other languages" section of entity view are not escaped - https://phabricator.wikimedia.org/T55472#1154558 (10csteipp) [20:40:44] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "This patch (with the variable name fixed) does nothing for me. What is it supposed to do?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199910 (https://phabricator.wikimedia.org/T93864) (owner: 10Aude) [20:40:53] aude: After looking at that change with Thiemoe we decided it would be better to not deploy it tonight [20:40:58] to many open questions [20:41:03] to dangerous IMO [21:45:28] [13WikibaseDataModel] 15thiemowmde created 06revert-418-floo (+1 new commit): 02http://git.io/jnSn [21:45:28] 13WikibaseDataModel/06revert-418-floo 141b07021 15Thiemo Mättig: Revert "Add floobits config" [21:45:31] oh I have just made a lovely little tool to make referencing easier [21:45:39] [13WikibaseDataModel] 15thiemowmde opened pull request #420: Revert "Add floobits config" (06master...06revert-418-floo) 02http://git.io/jnSl [21:45:56] Lydia_WMDE: drag and drop referencing from web pages :P [21:48:05] [13Geo] 15thiemowmde comment on pull request #47 144c31983: Version number must be 0.1.5 or higher. 02http://git.io/jn9m [21:49:56] wmde/WikibaseDataModel/revert-418-floo/1b07021 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/56018886 [21:56:54] (03CR) 10Thiemo Mättig (WMDE): "I possibly get something totally wrong, but:" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [22:00:34] (03CR) 10Smalyshev: "Thiemo, code in julianDateValue converts julian date to gregorian one." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [22:03:06] (03CR) 10Smalyshev: T92996: Add Julian Calendar support (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [22:10:07] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking, and 2 others: Allow accessing data from a Wikidata item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#1155368 (10gpaumier) [22:14:26] (03CR) 10Thiemo Mättig (WMDE): T92996: Add Julian Calendar support (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [22:15:10] 10Wikidata, 10Wikidata-Query-Service: Support more fine-grained date fields that xsd:dateTime - https://phabricator.wikimedia.org/T92009#1155398 (10Smalyshev) We may also want to support [[ http://books.xmlschemata.org/relaxng/ch19-77119.html | xsd:gMonthDay ]] in order to serve queries such as "who was born o... [22:16:24] (03CR) 10Smalyshev: T92996: Add Julian Calendar support (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [22:21:52] (03CR) 10Smalyshev: T92996: Add Julian Calendar support (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [22:45:39] (03CR) 10Smalyshev: "I'm not sure which ones I should actually split out. The only one I found that you say is a problem is the try/catch, which I need for han" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [22:59:12] 10Wikidata, 10Wikidata-Query-Service: Data format updates for RDF export - https://phabricator.wikimedia.org/T93451#1155554 (10Smalyshev) >I would not add them to the dumps though (1000 x 300 x 5 is a lot of additional triples). Don't see why it would be this many. It'd be like 4 additional rows per property:... [23:00:59] 10Wikidata, 10Wikidata-Query-Service: Add property types to RDF dump - https://phabricator.wikimedia.org/T94115#1155557 (10Smalyshev) 3NEW a:3Smalyshev [23:02:55] 10Wikidata, 10Wikidata-Query-Service: Add property types to RDF dump - https://phabricator.wikimedia.org/T94115#1155579 (10Smalyshev) [23:35:28] (03PS24) 10Smalyshev: Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 [23:35:36] (03CR) 10jenkins-bot: [V: 04-1] Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [23:36:59] (03PS25) 10Smalyshev: Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 [23:40:10] (03CR) 10jenkins-bot: [V: 04-1] Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [23:41:13] (03CR) 10Smalyshev: Performance tweaks (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [23:48:09] (03PS26) 10Smalyshev: Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 [23:49:20] (03PS27) 10Smalyshev: Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 [23:51:59] (03CR) 10jenkins-bot: [V: 04-1] Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev)