[00:01:20] (03Merged) 10jenkins-bot: Revert "Fix filtering in change dispatcher." [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199539 (owner: 10Aude) [00:03:16] (03Merged) 10jenkins-bot: Revert "Fix prioritizing sort in dispatchChanges." [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199535 (owner: 10Aude) [00:07:42] 10Wikidata: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1147232 (10aude) [00:08:06] 10Wikidata: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1147204 (10aude) i meant this to be a paste, but whatever... it's a bug also [00:11:27] (03PS1) 10Aude: Revert change dispatcher patches [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199544 [00:15:11] (03CR) 10Aude: [C: 032] Revert change dispatcher patches [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199544 (owner: 10Aude) [00:20:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1147255 (10hoo) p:5Triage>3Unbreak! [00:25:45] (03PS2) 10Smalyshev: Refactor prefixes to be output only once, eliminate need to clean prefixes on dump [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 [00:26:00] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf22/ba3469b : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/55732611 [00:28:17] (03CR) 10Smalyshev: "Downside - you can no longer define prefixes anytime you want. Which I don't think is a big loss since we don't do it anyway." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 (owner: 10Smalyshev) [00:30:17] (03PS3) 10Smalyshev: Refactor prefixes to be output only once, eliminate need to clean prefixes on dump [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 [00:34:33] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf22/7d3a0b1 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/55732718 [00:53:40] (03PS2) 10Krinkle: Revert change dispatcher patches [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199544 (owner: 10Aude) [00:53:47] (03CR) 10Krinkle: [C: 032] Revert change dispatcher patches [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199544 (owner: 10Aude) [01:04:22] (03Merged) 10jenkins-bot: Revert change dispatcher patches [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199544 (owner: 10Aude) [01:17:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Undefined index: 1 in PhpDateTimeParser.php on line 180 (and sometimes line 179) - https://phabricator.wikimedia.org/T93836#1147396 (10aude) 3NEW [01:34:02] dispatcher seems to be working much better now [01:34:09] will take time for it to catch up though [04:16:15] RECOVERY - check if wikidata.org dispatch lag is higher than 2 minutes on wikidata is OK: HTTP OK: HTTP/1.1 200 OK - 1475 bytes in 0.214 second response time [04:16:46] do people talk in here or just listen to bots? [04:34:48] depends on the time of day, it seems [04:36:56] it *is* the middle of night in europe right now, after all [04:37:00] not that that's stopping me :) [04:37:48] see [04:38:16] some people fight those zombie bots and stop them taking over [04:48:52] my brain is fried [04:49:20] are you sure it wasn't actually eaten by the zombie bots? :P [04:50:02] probably. :( [06:12:07] hmmm, fried brains... BRRRAAAAAIIIINNNNSSSS !!! :p [07:16:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: After I undo a description in the "term" box, the item page shows version of description before undo - https://phabricator.wikimedia.org/T90893#1147851 (10aude) here I simply added a label for english: {F103942} the label does not show in the term box bu... [07:20:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page - https://phabricator.wikimedia.org/T93853#1147852 (10aude) 3NEW [08:44:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1147904 (10aude) 5Open>3Resolved [08:44:49] 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: Values in qualifiers and references not linked by AuthorityControl Gadget - https://phabricator.wikimedia.org/T91408#1147910 (10Tobi_WMDE_SW) 5Open>3Resolved [08:44:49] 10Wikidata, 7Tracking: Authority Control gadget tracking bug - https://phabricator.wikimedia.org/T93762#1147911 (10Tobi_WMDE_SW) [08:44:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1147204 (10aude) we reverted and deployed a couple changes, which fixes the issue for now. we still need to investigate why this happened. the changes were attempting to fix bugs an... [08:44:59] 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: Values in qualifiers and references not linked by AuthorityControl Gadget - https://phabricator.wikimedia.org/T91408#1082184 (10Tobi_WMDE_SW) [08:44:59] 10Wikidata, 10§ Wikidata-Sprint-2015-03-24, 3§ Wikidata-Sprint-2015-03-11: Investigate how to proper fix AC Gadget for qualifiers and references - https://phabricator.wikimedia.org/T92378#1147913 (10Tobi_WMDE_SW) 5Open>3Resolved [08:46:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I would love to do more profiling and (micro-) benchmarking on this, if needed. Please poke me if you think this could help." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197407 (owner: 10Daniel Kinzler) [08:49:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page - https://phabricator.wikimedia.org/T93853#1147930 (10aude) it looks like https://gerrit.wikimedia.org/r/#/c/191592/ might fix this but that patch is stuck in a... [08:49:43] (03Merged) 10jenkins-bot: Performance improvements for RdfWriter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197407 (owner: 10Daniel Kinzler) [08:56:38] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page - https://phabricator.wikimedia.org/T93853#1147943 (10aude) https://gerrit.wikimedia.org/r/#/c/194107/ will probably also help. While it would be great to get D... [08:57:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page - https://phabricator.wikimedia.org/T93853#1147944 (10aude) [09:10:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: edit summary doesn't show label of property when changing claims - https://phabricator.wikimedia.org/T93804#1147974 (10aude) the cause appears to be https://gerrit.wikimedia.org/r/#/c/192787/, as after reverting that chang... [09:12:18] (03PS1) 10Aude: Revert "Use EntityIdFormatter in MessageParameterFormatter" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199586 (https://phabricator.wikimedia.org/T93804) [09:12:29] (03PS2) 10Aude: Revert "Use EntityIdFormatter in MessageParameterFormatter" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199586 (https://phabricator.wikimedia.org/T93804) [09:13:18] (03PS1) 10Aude: Revert "Use EntityIdFormatter in MessageParameterFormatter" [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199587 (https://phabricator.wikimedia.org/T93804) [09:14:21] (03CR) 10Aude: [C: 04-2] Revert "Use EntityIdFormatter in MessageParameterFormatter" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199586 (https://phabricator.wikimedia.org/T93804) (owner: 10Aude) [09:20:18] (03PS1) 10Thiemo Mättig (WMDE): Split individual tests in UsageAccumulatorContractTester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 [09:21:45] (03CR) 10Thiemo Mättig (WMDE): "What's the -1 for? The added test is for all implementations of this class. You should know, you wrote it. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191335 (owner: 10Thiemo Mättig (WMDE)) [09:25:13] (03PS1) 10Hoo man: Revert "Fix filtering in change dispatcher." [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199589 [09:25:21] doh [09:25:23] wrong branch [09:25:40] (03Abandoned) 10Hoo man: Revert "Fix filtering in change dispatcher." [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199589 (owner: 10Hoo man) [09:26:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Write tests for Special:SetLabelDescriptionAliases - https://phabricator.wikimedia.org/T93860#1148023 (10Tobi_WMDE_SW) 3NEW [09:27:04] 10Wikidata, 10§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Test framework for special pages. - https://phabricator.wikimedia.org/T92375#1108970 (10Tobi_WMDE_SW) [09:27:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Write tests for Special:SetLabelDescriptionAliases - https://phabricator.wikimedia.org/T93860#1148033 (10Tobi_WMDE_SW) [09:29:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign header - https://phabricator.wikimedia.org/T75654#1148041 (10Lydia_Pintscher) [09:29:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page - https://phabricator.wikimedia.org/T93853#1148042 (10Lydia_Pintscher) [09:30:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page - https://phabricator.wikimedia.org/T93853#1148043 (10Lydia_Pintscher) p:5Triage>3High [09:30:31] Tobi_WMDE_SW: I'm rebasing the special page patches right now. ok? [09:32:49] (03PS2) 10Thiemo Mättig (WMDE): Use specific summary lines in SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194107 [09:32:51] (03PS4) 10Thiemo Mättig (WMDE): New auto-summary message for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191592 [09:32:53] (03PS2) 10Thiemo Mättig (WMDE): Make SpecialSetLabelDescriptionAliases a 2-step process [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194105 (https://phabricator.wikimedia.org/T91387) [09:32:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: After I remove a statement, the background of the property remains blue - https://phabricator.wikimedia.org/T93810#1148050 (10Lydia_Pintscher) p:5Triage>3High [09:35:44] Thiemo_WMDE: alright [09:35:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: description in other languages is not readable without clicking edit - https://phabricator.wikimedia.org/T93807#1148061 (10Lydia_Pintscher) p:5Normal>3High [09:38:17] (03CR) 10jenkins-bot: [V: 04-1] Make SpecialSetLabelDescriptionAliases a 2-step process [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194105 (https://phabricator.wikimedia.org/T91387) (owner: 10Thiemo Mättig (WMDE)) [09:40:40] 10Wikidata, 10§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: No property suggestions on empty items - https://phabricator.wikimedia.org/T92748#1148086 (10aude) When we deploy this, important to note there is a new setting that we probably want to change for Wikidata. The d... [09:41:32] Thiemo_WMDE: aude_ I'm testing https://gerrit.wikimedia.org/r/#/c/194107/ and https://gerrit.wikimedia.org/r/#/c/191592/ manually and if I find no issues I'm going to merge them [09:41:40] except one of you object [09:42:20] 10Wikidata: If a particular property is only used in a reference or qualifier, then the value does not get linked by authority control gadget - https://phabricator.wikimedia.org/T93764#1148089 (10Lydia_Pintscher) p:5Triage>3Normal [09:42:37] 10Wikidata: Provide Authority Control within an extension functionality instead of a gadget - https://phabricator.wikimedia.org/T93766#1148094 (10Lydia_Pintscher) p:5Triage>3High [09:43:05] Tobi_WMDE_SW: i don't object, although am not manually testing myself and trust you :) [09:43:17] 10Wikidata: Coordinates in references and qualifiers are not linked in authority control gadget - https://phabricator.wikimedia.org/T93763#1148098 (10Lydia_Pintscher) p:5Triage>3Normal [09:43:36] 10Wikidata, 7Tracking: Authority Control gadget tracking bug - https://phabricator.wikimedia.org/T93762#1148102 (10Lydia_Pintscher) p:5Triage>3Normal [09:44:34] 10Wikidata, 10Wikidata-Query-Service, 10§ Wikidata-Sprint-2015-03-24, 3§ Wikidata-Sprint-2015-03-11: cron job to create RDF dumps - https://phabricator.wikimedia.org/T93658#1148108 (10Lydia_Pintscher) p:5Triage>3High [09:45:32] (03PS5) 10Thiemo Mättig (WMDE): New auto-summary message for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191592 (https://phabricator.wikimedia.org/T93853) [09:46:23] 10Wikidata: On all items about living people, the first suggestions are often "date of death" and "place of death" - https://phabricator.wikimedia.org/T93799#1148114 (10Lydia_Pintscher) Opinions? :) [09:46:35] 10Wikidata: On all items about living people, the first suggestions are often "date of death" and "place of death" - https://phabricator.wikimedia.org/T93799#1148116 (10Lydia_Pintscher) p:5Triage>3Normal [09:47:37] (03PS1) 10Hoo man: dispatchChanges: Don't use FOR UPDATE for selecting a client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199592 [09:47:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page - https://phabricator.wikimedia.org/T93853#1148120 (10thiemowmde) Relevant patches: * https://gerrit.wikim... [09:48:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Remove wbUserCanEdit and wbUserIsBlocked config variables - https://phabricator.wikimedia.org/T93773#1148121 (10Lydia_Pintscher) Adding @Ricordisamoa to see if they see any issue with this from the gadget author side. [09:49:16] (03PS3) 10Thiemo Mättig (WMDE): Use specific summary lines in SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194107 (https://phabricator.wikimedia.org/T93853) [09:51:41] 10Wikidata, 10Datasets-General-or-Unknown, 10§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1148130 (10hoo) @mkroetzsch: What's you opinion on the above naming scheme? Is it ok for you? If so, I will impleme... [09:54:19] (03PS4) 10Tobias Gritschacher: Use specific summary lines in SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194107 (https://phabricator.wikimedia.org/T93853) (owner: 10Thiemo Mättig (WMDE)) [09:55:29] (03PS2) 10Hoo man: dispatchChanges: Don't use FOR UPDATE for selecting a client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199592 [09:59:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: order in other language box by order of babel boxes - https://phabricator.wikimedia.org/T93863#1148136 (10Lydia_Pintscher) 3NEW [10:00:20] (03CR) 10Tobias Gritschacher: [C: 032] "This should have been considered as a deployment blocker because the edit-summary of that special page is completely wrong. Let's not bloc" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191592 (https://phabricator.wikimedia.org/T93853) (owner: 10Thiemo Mättig (WMDE)) [10:01:07] Tobi_WMDE_SW: Y u steal my merges :P [10:01:35] hoo: :D Lydia_WMDE said you're working on something different [10:01:46] hoo: you can have the backports.. :P [10:01:47] [13WikibaseDataModel] 15thiemowmde comment on pull request #414 146f0380f: Now this will do odd things if the list contains statements with no GUID. Dang, I don't know what's the right thing to do. `indexOfGuid( string $guid )`?... 02http://git.io/jTS0 [10:02:27] hoo: Thiemo_WMDE aude also merging https://gerrit.wikimedia.org/r/#/c/194107 [10:02:48] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-03-25T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/199595 [10:03:01] (03CR) 10Hoo man: [C: 032] "Needed in production, right now" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194107 (https://phabricator.wikimedia.org/T93853) (owner: 10Thiemo Mättig (WMDE)) [10:03:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Focus not in main snak value after selecting a property with mouse - https://phabricator.wikimedia.org/T93864#1148146 (10aude) 3NEW [10:03:38] Tobi_WMDE_SW: thanks [10:03:46] (03CR) 10Tobias Gritschacher: [C: 032] "I've created bug T93860 to add tests once the testing framework for special pages is merged." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194107 (https://phabricator.wikimedia.org/T93853) (owner: 10Thiemo Mättig (WMDE)) [10:03:51] Lydia_WMDE: Vandalism? Wikidata got it: https://www.wikidata.org/w/index.php?title=Q363836&curid=346627&action=history [10:04:13] hoo: damn. you fast bastard! :P [10:04:45] (03Merged) 10jenkins-bot: New auto-summary message for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191592 (https://phabricator.wikimedia.org/T93853) (owner: 10Thiemo Mättig (WMDE)) [10:04:48] (03PS3) 10Tobias Gritschacher: Make SpecialSetLabelDescriptionAliases a 2-step process [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194105 (https://phabricator.wikimedia.org/T91387) (owner: 10Thiemo Mättig (WMDE)) [10:05:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Focus not in main snak value after selecting a property with mouse - https://phabricator.wikimedia.org/T93864#1148160 (10aude) if i select a property with down arrow and then enter, focus also does not move to the value field [10:05:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign header - https://phabricator.wikimedia.org/T75654#1148164 (10Tobi_WMDE_SW) [10:05:38] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: "Created a new item" edit summary when editing via new Special:SetLabelDescriptionAliases page - https://phabricator.wikimedia.org/T93853#1148162 (10Tobi_WMDE_SW) 5Open>3Resolved a:3Tobi_WMDE_SW [10:07:07] (03Merged) 10jenkins-bot: Use specific summary lines in SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194107 (https://phabricator.wikimedia.org/T93853) (owner: 10Thiemo Mättig (WMDE)) [10:07:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: rollback causes error - https://phabricator.wikimedia.org/T93866#1148180 (10Lydia_Pintscher) 3NEW [10:07:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Focus not in main snak value after selecting a property with mouse - https://phabricator.wikimedia.org/T93864#1148190 (10aude) on master, on my dev wiki, focus goes to the "add qualifier" link after I select a property. I am not sure this happens on wikid... [10:09:06] (03CR) 10jenkins-bot: [V: 04-1] Make SpecialSetLabelDescriptionAliases a 2-step process [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194105 (https://phabricator.wikimedia.org/T91387) (owner: 10Thiemo Mättig (WMDE)) [10:11:55] (03CR) 10Tobias Gritschacher: [C: 032] Cleanup bits in SpecialSetLabelDescriptionAliasesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199260 (owner: 10Thiemo Mättig (WMDE)) [10:14:20] Thiemo_WMDE: can you look at DanielK_WMDE's answer again: https://gerrit.wikimedia.org/r/#/c/194960 [10:14:39] 10Wikidata: Consolidate "Created a new item" summary line messages - https://phabricator.wikimedia.org/T93867#1148201 (10thiemowmde) 3NEW [10:15:18] 10Wikidata: Consolidate "Created a new item" summary line messages - https://phabricator.wikimedia.org/T93867#1148212 (10thiemowmde) [10:20:31] (03PS1) 10Hoo man: Add debug logging to client UpdateRepo code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199596 (https://phabricator.wikimedia.org/T92789) [10:21:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Getting multiple suggestions of the same item - https://phabricator.wikimedia.org/T93868#1148219 (10aude) 3NEW [10:24:08] (03PS2) 10Hoo man: Add debug logging to client UpdateRepo code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199596 (https://phabricator.wikimedia.org/T92789) [10:25:23] 10Wikidata, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release5, 7Design: When creating a new page, suggest doing a translation instead - https://phabricator.wikimedia.org/T88600#1148232 (10Arrbee) [10:32:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: order in other language box by order of babel boxes - https://phabricator.wikimedia.org/T93863#1148238 (10adrianheine) Afaik they are not cached, but injected afterwards with the TextInjector. So, no issue with caching. [10:35:08] (03PS3) 10Adrian Lang: Introduce Wikibase\View\HtmlSnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199327 [10:36:17] [13WikibaseDataModelSerialization] 15thiemowmde comment on commit 145b18aae: I would prefer `empty()`, but since "this is only a test"TM it doesn't matter much. 02http://git.io/jTAM [10:36:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1148239 (10Lydia_Pintscher) [10:37:14] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #115 145b18aae: I would prefer `empty()`, but since "this is only a test"TM it doesn't matter much. 02http://git.io/jTxJ [10:41:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: rollback causes error - https://phabricator.wikimedia.org/T93866#1148241 (10Tobi_WMDE_SW) a:3hoo [10:42:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: edit summary doesn't show label of property when changing claims - https://phabricator.wikimedia.org/T93804#1148243 (10Tobi_WMDE_SW) a:3aude [10:48:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10§ Wikidata-Sprint-2015-03-24: "Add qualifier" button should automatically focus text box - https://phabricator.wikimedia.org/T89300#1148249 (10Lydia_Pintscher) See also https://gerrit.wikimedia.org/r/#/c/180174/ [10:53:03] 10Wikidata, 7Regression: "CommonsMedia" gadget broken - https://phabricator.wikimedia.org/T93809#1148251 (10adrianheine) I suppose 00145a8dcbdb548216a39b69ccc713734d37bdfe introduced that. The ValueView appears to not be rendered anymore on snakview initialization. A maybe related issue is that the valueview n... [11:12:02] 10Wikidata, 10MediaWiki-General-or-Unknown, 10§ Wikidata-Sprint-2015-03-24: Rollback diff causes error - https://phabricator.wikimedia.org/T93866#1148288 (10hoo) [11:17:36] 10Wikidata: On all items about living people, the first suggestions are often "date of death" and "place of death" - https://phabricator.wikimedia.org/T93799#1148293 (10Sjoerddebruin) It could be. But place of death should show up when death date exists, vice versa. [11:24:54] 10Wikidata, 10Continuous-Integration: add HHVM versions of Jenkins jobs for Wikibase extension - https://phabricator.wikimedia.org/T93871#1148301 (10JanZerebecki) 3NEW [11:29:07] 10Wikidata: Python property suggester scripts need improved error handling - https://phabricator.wikimedia.org/T93872#1148317 (10aude) 3NEW [11:29:12] 10Wikidata: Python property suggester scripts need improved error handling - https://phabricator.wikimedia.org/T93872#1148324 (10aude) https://github.com/Wikidata-lib/PropertySuggester-Python/pull/19 [11:29:25] 10Wikidata, 5Patch-For-Review: Python property suggester scripts need improved error handling - https://phabricator.wikimedia.org/T93872#1148325 (10aude) [11:37:26] (03PS1) 10Thiemo Mättig (WMDE): Fix isset() check in PhpDateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199604 (https://phabricator.wikimedia.org/T93836) [11:39:26] Thiemo_WMDE: https://phabricator.wikimedia.org/T93871#1148301 [11:40:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Undefined index: 1 in PhpDateTimeParser.php on line 180 (and sometimes line 179) - https://phabricator.wikimedia.org/T93836#1148342 (10thiemowmde) Turns out, this is an HHVM-only thingy. There are even test cases that should have trigg... [11:42:05] (03PS1) 10Aude: New auto-summary message for SpecialSetLabelDescriptionAliases [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199607 (https://phabricator.wikimedia.org/T93853) [11:42:07] (03PS1) 10Aude: Use specific summary lines in SpecialSetLabelDescriptionAliases [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199608 (https://phabricator.wikimedia.org/T93853) [11:46:17] (03CR) 10Aude: [C: 032] Fix isset() check in PhpDateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199604 (https://phabricator.wikimedia.org/T93836) (owner: 10Thiemo Mättig (WMDE)) [11:48:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Undefined index: 1 in PhpDateTimeParser.php on line 180 (and sometimes line 179) - https://phabricator.wikimedia.org/T93836#1148362 (10Lydia_Pintscher) [11:49:34] (03Merged) 10jenkins-bot: Fix isset() check in PhpDateTimeParser [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199604 (https://phabricator.wikimedia.org/T93836) (owner: 10Thiemo Mättig (WMDE)) [12:46:50] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: UpdateRepo doesn't always propagate changes - https://phabricator.wikimedia.org/T92789#1148461 (10Lydia_Pintscher) [12:47:35] (03CR) 10Aude: [C: 032] "tested this manually" [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199607 (https://phabricator.wikimedia.org/T93853) (owner: 10Aude) [12:47:44] (03CR) 10Aude: [C: 032] Use specific summary lines in SpecialSetLabelDescriptionAliases [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199608 (https://phabricator.wikimedia.org/T93853) (owner: 10Aude) [12:50:37] (03PS1) 10Aude: Fix isset() check in PhpDateTimeParser [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199612 (https://phabricator.wikimedia.org/T93836) [12:51:49] (03Merged) 10jenkins-bot: New auto-summary message for SpecialSetLabelDescriptionAliases [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199607 (https://phabricator.wikimedia.org/T93853) (owner: 10Aude) [12:51:52] (03Merged) 10jenkins-bot: Use specific summary lines in SpecialSetLabelDescriptionAliases [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199608 (https://phabricator.wikimedia.org/T93853) (owner: 10Aude) [12:51:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Undefined index: 1 in PhpDateTimeParser.php on line 180 (and sometimes line 179) - https://phabricator.wikimedia.org/T93836#1148486 (10hoo) 5Open>3Resolved a:3hoo [12:57:36] (03CR) 10Aude: [C: 032] Fix isset() check in PhpDateTimeParser [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199612 (https://phabricator.wikimedia.org/T93836) (owner: 10Aude) [13:00:26] (03Merged) 10jenkins-bot: Fix isset() check in PhpDateTimeParser [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199612 (https://phabricator.wikimedia.org/T93836) (owner: 10Aude) [13:01:27] 10Wikidata: Property suggester broken on Wikidata - https://phabricator.wikimedia.org/T93878#1148501 (10aude) 3NEW [13:11:01] (03CR) 10Thiemo Mättig (WMDE): "The more important question is still unanswered. I find this code very suspicious. This is manipulating the request under test in code tha" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194960 (https://phabricator.wikimedia.org/T92375) (owner: 10Daniel Kinzler) [13:19:35] (03PS7) 10Thiemo Mättig (WMDE): Data provider for testing SpecialSetLabelDescritionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194524 (owner: 10Daniel Kinzler) [13:19:37] (03PS4) 10Thiemo Mättig (WMDE): Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 (owner: 10Daniel Kinzler) [13:19:39] (03PS5) 10Thiemo Mättig (WMDE): Supply edit token when testing special pages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194960 (https://phabricator.wikimedia.org/T92375) (owner: 10Daniel Kinzler) [13:19:41] (03PS2) 10Thiemo Mättig (WMDE): Cleanup bits in SpecialSetLabelDescriptionAliasesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199260 [13:20:38] 10Wikidata: Wikidata does not support language nod (Northern Thai) - https://phabricator.wikimedia.org/T93880#1148541 (10Ahoerstemeier) 3NEW [13:23:08] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 (owner: 10Daniel Kinzler) [13:25:11] (03CR) 10jenkins-bot: [V: 04-1] Cleanup bits in SpecialSetLabelDescriptionAliasesTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199260 (owner: 10Thiemo Mättig (WMDE)) [13:25:21] (03CR) 10jenkins-bot: [V: 04-1] Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 (owner: 10Daniel Kinzler) [13:25:33] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Data provider for testing SpecialSetLabelDescritionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194524 (owner: 10Daniel Kinzler) [13:28:01] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1148570 (10mkroetzsch) @hoo Thanks for the heads up! I do have comments. (1) I would remove the "full" and "truthy"... [13:35:13] (03PS7) 10Thiemo Mättig (WMDE): Split MonthNameUnlocalizer into Base and MediaWiki part [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197093 [13:35:23] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1148594 (10Lydia_Pintscher) About 2: We didn't add timestamped subdirectories because they would likely be confusing... [13:38:54] 10Wikidata, 7domains: Better namespace URI for the wikibase ontology - https://phabricator.wikimedia.org/T93207#1148595 (10mkroetzsch) @daniel Changing URIs of the ontology vocabulary is "silently producing wrong results" as well. I understand the problems you are trying to solve. I am just saying that changin... [13:40:33] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Increase width of the eu_aspect column to varbinary(37). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197504 (https://phabricator.wikimedia.org/T92288) (owner: 10Daniel Kinzler) [13:41:20] aude: review https://gerrit.wikimedia.org/r/199596 [13:41:22] Easy [13:42:13] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Add eu_touched field to wbc_entity_usage. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197940 (https://phabricator.wikimedia.org/T93057) (owner: 10Daniel Kinzler) [13:43:52] (03CR) 10Thiemo Mättig (WMDE): [C: 031] Drop eu_entity_type from wbc_entity_usage table. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197933 (owner: 10Daniel Kinzler) [13:45:05] (03CR) 10Aude: [C: 032] Add debug logging to client UpdateRepo code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199596 (https://phabricator.wikimedia.org/T92789) (owner: 10Hoo man) [13:45:48] (03PS1) 10Hoo man: Add debug logging to client UpdateRepo code [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199613 (https://phabricator.wikimedia.org/T92789) [13:46:35] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I wonder if all these lines should have FIXMEs, marking them as "remove me when not needed any more"." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199596 (https://phabricator.wikimedia.org/T92789) (owner: 10Hoo man) [13:48:56] (03Merged) 10jenkins-bot: Add debug logging to client UpdateRepo code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199596 (https://phabricator.wikimedia.org/T92789) (owner: 10Hoo man) [13:53:28] (03Merged) 10jenkins-bot: dispatchChanges: Don't use FOR UPDATE for selecting a client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199592 (owner: 10Hoo man) [14:03:24] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Nice, like it. But: This qualifies as a relevant breaking change. Do we know how this will affect existing Lua modules?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198771 (https://phabricator.wikimedia.org/T93607) (owner: 10Hoo man) [14:13:23] (03CR) 10Lucie Kaffee: "Thiemo, they will break. I changed most of the modules using the old function and left a message in the talk page of the modules, that I c" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198771 (https://phabricator.wikimedia.org/T93607) (owner: 10Hoo man) [14:16:39] Lydia_WMDE aude hoo Thiemo_WMDE jzerebecki: do you have anything that should be mentioned in today's "scrum of scrums"? [14:16:54] Tobi_WMDE_SW: The fatal log thing REALLY needs to get done [14:16:55] here's the document to put things into: https://docs.google.com/a/wikimedia.de/document/d/1sVRS4ISLJlnniUWJ5dUTOmEEVAJZbhZ5v4H7E_YdMrs/edit [14:21:11] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Tracking: Decide on and implement a limit for entities accessed via arbitrary access features - https://phabricator.wikimedia.org/T93885#1148849 (10hoo) 3NEW a:3hoo [14:21:44] (03CR) 10Lucie Kaffee: [C: 031] Make mw.wikibase.getEntity == mw.wikibase.getEntityObject [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198771 (https://phabricator.wikimedia.org/T93607) (owner: 10Hoo man) [14:23:37] !chocolate [14:23:45] boring bot [14:23:50] !nyan [14:23:50] ~=[,,_,,]:3 [14:23:55] :P [14:24:13] !chocolate is Merge a change and Earn some chocolate!!111 [14:24:14] You are not authorized to perform this, sorry [14:24:19] !chocolate is Merge a change and earn some chocolate!!111 [14:24:19] You are not authorized to perform this, sorry [14:24:25] meh [14:25:01] sorry, you are not authorized to offer some chocolate. try candy instead :D [14:25:24] aude: If you have a moment: https://gerrit.wikimedia.org/r/198771 Has 3 x +1 and the code change is rather trivial [14:26:35] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Detailed review done. Most are nitpicks and not that important, but I consider two issues relevant: The year should never be casted to int" (0316 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [14:40:16] (03CR) 10Aude: [C: 032] Add debug logging to client UpdateRepo code [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199613 (https://phabricator.wikimedia.org/T92789) (owner: 10Hoo man) [14:40:54] hoo: Tobi_WMDE_SW someone want to +1 or +2 https://gerrit.wikimedia.org/r/#/c/199587/ [14:40:58] or jzerebecki [14:41:03] prefer not to self merge that one [14:41:25] on it [14:41:30] thanks [14:41:38] manually verified that this fixes [14:42:01] and hope for a fix on master that doesn't require revert [14:44:19] (03CR) 10Thiemo Mättig (WMDE): "Whooo. Good job." (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [14:46:03] (03Merged) 10jenkins-bot: Add debug logging to client UpdateRepo code [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199613 (https://phabricator.wikimedia.org/T92789) (owner: 10Hoo man) [14:46:51] (03CR) 10JanZerebecki: [C: 031] Revert "Use EntityIdFormatter in MessageParameterFormatter" [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199587 (https://phabricator.wikimedia.org/T93804) (owner: 10Aude) [14:46:57] thanks [14:47:07] (03CR) 10Hoo man: [C: 032] Revert "Use EntityIdFormatter in MessageParameterFormatter" [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199587 (https://phabricator.wikimedia.org/T93804) (owner: 10Aude) [14:50:29] (03Merged) 10jenkins-bot: Revert "Use EntityIdFormatter in MessageParameterFormatter" [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199587 (https://phabricator.wikimedia.org/T93804) (owner: 10Aude) [14:55:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: edit summary doesn't show label of property when changing claims - https://phabricator.wikimedia.org/T93804#1148962 (10hoo) p:5Unbreak!>3High Fixed on the branch, lowering priority. [14:56:39] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Looks good overall. I do support and like the idea very much. But I do have some questions and wishes. The -1 is to get your attention." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 (owner: 10Smalyshev) [15:00:02] (03PS1) 10Aude: Update Wikidata - Fix recent changes formatting on wikidata [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199617 [15:06:43] (03CR) 10Aude: [C: 032] Update Wikidata - Fix recent changes formatting on wikidata [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199617 (owner: 10Aude) [15:08:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: double redirect in merge summary - https://phabricator.wikimedia.org/T93896#1149046 (10Lydia_Pintscher) 3NEW [15:10:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: double bracket in merge summary - https://phabricator.wikimedia.org/T93896#1149062 (10Lydia_Pintscher) [15:10:10] (03Merged) 10jenkins-bot: Update Wikidata - Fix recent changes formatting on wikidata [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199617 (owner: 10Aude) [15:16:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: double bracket in redirect summary - https://phabricator.wikimedia.org/T93896#1149089 (10hoo) [15:20:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: double bracket in redirect summary - https://phabricator.wikimedia.org/T93896#1149099 (10hoo) [15:20:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: edit summary doesn't show label of property when changing claims - https://phabricator.wikimedia.org/T93804#1149100 (10hoo) [15:32:35] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #414 146f0380f: The only reason I'm adding this is because we need it in Wikibase.git. So it does make sense to look at what is actually needed there. If we create something else, then we're not solving the lack of having this functionality in non-deprecated code. 02http://git.io/jI5T [15:33:45] (03CR) 10Hoo man: [C: 032] "Thanks for touching this :)" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191335 (owner: 10Thiemo Mättig (WMDE)) [15:34:06] 10Wikidata, 10MediaWiki-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Rollback diff causes error - https://phabricator.wikimedia.org/T93866#1149130 (10hoo) 5Open>3Resolved [15:37:48] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #115 145b18aae: I'd have done that if I was 100% sure that'd work correctly for `Claims` 02http://git.io/jIF9 [15:39:31] (03Merged) 10jenkins-bot: Move duplicate code to UsageAccumulator classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191335 (owner: 10Thiemo Mättig (WMDE)) [15:41:14] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1149156 (10mkroetzsch) @Lydia_Pintscher I understand this problem, but if you put different dumps for different time... [15:43:53] (03PS1) 10Thiemo Mättig (WMDE): Clean up RDF and Dumpers related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199622 [15:45:28] (03CR) 10Hoo man: [C: 04-1] "-1 to get your attention to the naming." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 (owner: 10Thiemo Mättig (WMDE)) [15:46:26] [13WikibaseDataModel] 15thiemowmde comment on pull request #414 146f0380f: Sorry, my comment was confusing. I suggest to rename this to `indexOfGuid` or `getIndexByGuid` or something like that, so `indexOf` is still free for your original implementation, if ever needed. 02http://git.io/jIpA [15:53:25] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1149217 (10JanZerebecki) All of these dumps will be generated by exporting from the DB. AFAIK currently the dumps ca... [15:53:26] (03PS2) 10Thiemo Mättig (WMDE): Split individual tests in UsageAccumulatorContractTester [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 [15:54:17] (03CR) 10Hoo man: "After https://gerrit.wikimedia.org/r/191336 it would IMO also be legit to have a base class like "UsageAccumulatorTestCase", that would pr" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199588 (owner: 10Thiemo Mättig (WMDE)) [15:55:32] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06indexof from 146f0380f to 1466d450c: 02http://git.io/jeEY [15:55:32] 13WikibaseDataModel/06indexof 1466d450c 15jeroendedauw: Add StatementList::indexOf... [15:55:44] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #414 1466d450c: Done 02http://git.io/jLvA [15:58:23] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf22/c42291f : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/55808590 [16:11:32] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I think the CSS can be simpler." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196011 (https://phabricator.wikimedia.org/T93193) (owner: 10Aude) [16:14:37] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Decide on and implement a limit for entities accessed via arbitrary access features - https://phabricator.wikimedia.org/T93885#1149313 (10hoo) [16:18:59] 10Wikidata: Fatal error: Argument 2 passed to Wikibase\Repo\Localizer\MessageParameterFormatter::__construct() must implement interface Wikibase\Lib\Store\EntityTitleLookup - https://phabricator.wikimedia.org/T93903#1149319 (10aude) 3NEW [16:19:02] hoo: https://phabricator.wikimedia.org/T93903 [16:19:08] do you see where this is wrong? [16:19:14] i have the branch checked out [16:19:22] it's not that frequesnt [16:19:31] only somewhat moderate [16:20:40] (03PS1) 10Thiemo Mättig (WMDE): Do not pass objects to Summary::addAutoCommentArgs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199625 (https://phabricator.wikimedia.org/T93804) [16:22:06] 10Wikidata: Fatal error: Argument 2 passed to Wikibase\Repo\Localizer\MessageParameterFormatter::__construct() must implement interface Wikibase\Lib\Store\EntityTitleLookup - https://phabricator.wikimedia.org/T93903#1149333 (10aude) not that frequent and looks like maybe a scap artifact and not a bug. i have th... [16:24:52] 10Wikidata: Fatal error: Argument 2 passed to Wikibase\Repo\Localizer\MessageParameterFormatter::__construct() must implement interface Wikibase\Lib\Store\EntityTitleLookup - https://phabricator.wikimedia.org/T93903#1149357 (10aude) 5Open>3Invalid [16:25:12] (03CR) 10Hoo man: [C: 032] "No-op given that EntityId::__toString === EntityId::getSerialization" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199625 (https://phabricator.wikimedia.org/T93804) (owner: 10Thiemo Mättig (WMDE)) [16:25:13] 10Wikidata: Fatal error: Argument 2 passed to Wikibase\Repo\Localizer\MessageParameterFormatter::__construct() must implement interface Wikibase\Lib\Store\EntityTitleLookup - https://phabricator.wikimedia.org/T93903#1149319 (10aude) not happening now. think it was just an intermittent issue and is not a bug in... [16:26:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Revision slave does not belong to entity Q139 - https://phabricator.wikimedia.org/T91517#1149370 (10aude) still happens [16:27:24] https://phabricator.wikimedia.org/T91517 should go into the sprint, imho [16:27:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Revision slave does not belong to entity Q139 - https://phabricator.wikimedia.org/T91517#1149377 (10aude) [16:29:04] (03Merged) 10jenkins-bot: Do not pass objects to Summary::addAutoCommentArgs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199625 (https://phabricator.wikimedia.org/T93804) (owner: 10Thiemo Mättig (WMDE)) [16:29:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: double bracket in redirect summary - https://phabricator.wikimedia.org/T93896#1149382 (10thiemowmde) 5duplicate>3Resolved [16:29:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: double bracket in redirect summary - https://phabricator.wikimedia.org/T93896#1149046 (10thiemowmde) [16:30:35] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06indexof at 1466d450c: 02http://git.io/jLl1 [16:35:59] [13WikibaseDataModel] 15JeroenDeDauw created 06indexofrm (+1 new commit): 02http://git.io/jLBX [16:35:59] 13WikibaseDataModel/06indexofrm 1402aacff 15jeroendedauw: Remove Claims::indexOf [16:36:34] Kerning: https://xkcd.com/1015/ [16:37:32] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #417 1402aacff: I'm aware this this test method is not asserting a lot any more now. Since the code is deprecated, I suggest we do not waste time on fixing its bad tests though. 02http://git.io/jLRw [16:38:08] http://www.sansbullshitsans.com/ [16:40:35] :) [16:46:14] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1149442 (10mkroetzsch) > All of these dumps will be generated by exporting from the DB. Why would one want to do t... [16:49:29] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/jL2V [16:49:29] 13WikibaseDataModel/06master 142cf86b4 15jeroendedauw: Update gitignore [16:53:57] (03PS1) 10Hoo man: Improve exception about an unexpected entity id in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199632 (https://phabricator.wikimedia.org/T91517) [16:54:09] [13WikibaseDataModel] 15JeroenDeDauw created 06floo (+1 new commit): 02http://git.io/jLVM [16:54:09] 13WikibaseDataModel/06floo 1492fe43e 15jeroendedauw: Add floobits config [16:54:18] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #418: Add floobits config (06master...06floo) 02http://git.io/jLVQ [16:55:11] (03PS2) 10Hoo man: Improve exception about an unexpected entity id in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199632 (https://phabricator.wikimedia.org/T91517) [17:01:27] (03CR) 10Ebrahim: "Hey guys, any news here?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [17:03:23] wmde/WikibaseDataModel/floo/92fe43e : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/55827144 [17:05:17] (03CR) 10Hoo man: [C: 031] "(Didn't test) Looks good... Some of your inline comments should probably be comments so that this code stays understandable even after thi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [17:06:07] (03CR) 10Hoo man: "* should probably be code comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [17:10:36] 10Wikidata, 10DataValues, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review, and 2 others: Remove wrong "Gregorian" display from diff views - https://phabricator.wikimedia.org/T92265#1149504 (10thiemowmde) 5Open>3Invalid I'm closing this for now. I will split the code not related to calendar models from... [17:10:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: User interface displays false birth and death dates - https://phabricator.wikimedia.org/T87312#1149507 (10thiemowmde) [17:10:38] 10Wikidata, 7Tracking: Bugs related to time datatype - https://phabricator.wikimedia.org/T87764#1149506 (10thiemowmde) [17:11:45] 10Wikidata: Consolidate "Created a new item" summary line messages - https://phabricator.wikimedia.org/T93867#1149511 (10matej_suchanek) Also mind T85560. [17:16:54] stop-and-start debugging is possibly the worst kind of debugging, but there ain't much of a choice for a js script on a wiki :-( [17:18:32] DanielK_WMDE_: Do you think it's sane to in process cache the latest revision id of an entitiy [17:18:34] * entity [17:18:52] (for client usage) [17:19:48] Ok, seems like that actually wouldn't help us taht much :S [17:20:07] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06indexofrm: 02http://git.io/jLH6 [17:20:07] 13WikibaseDataModel/06indexofrm 14bd441fa 15Thiemo Mättig: Re-add assertion [17:21:21] [13WikibaseDataModel] 15thiemowmde comment on pull request #417 14bd441fa: I added an other assertion that should be a sufficient replacement. 02http://git.io/jLQ8 [17:21:28] hoo : sorry to barge in, but isn't it somewhat better to have the last revid in case someone needs it to edit the entity using the api ? the baserevid "must be passed on shall the server be able to detect edit collisions" (from https://www.mediawiki.org/wiki/Wikibase/API#Module_parameterss ) [17:21:42] DanielK_WMDE_: aude: https://phabricator.wikimedia.org/T76156 If I implement this I always have to check whether the entity exists in case someone does mw.wikibase.getEntityObject( 'Q123' ) [17:21:43] would avoid performing a first request to the api to get it [17:22:01] [13WikibaseDataModel] 15thiemowmde comment on pull request #417 14bd441fa: Having a new method hidden in here is a bit odd. 02http://git.io/jLQM [17:22:02] If they then use that entity for real (and it gets unstubbed) I would need to do another DB query for meta data [17:22:06] to load the entity [17:22:13] any ideas on how to improve? [17:22:20] I don't want to make things worse [17:23:35] Alphos_: I'm not exactly sure what you're talking about... might be missing context [17:24:59] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #417 14bd441fa: Ok, I'll add a dedicated note in a follow up commit 02http://git.io/jL5k [17:26:06] hoo : still browsing through all the js data provided on entity pages, can't seem to find the baserevid in there, i assume one has to fetch it first, in order to provide it back to the api when performing edit requests [17:27:21] i'm just saying it would be nice to get rid of that fetching step and just get the baserevid stored as a js var, and go straight to the edit request. hope you were talking about that, awfully sorry if you weren't ^^° [17:27:57] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #417 14bd441fa: Yeah, that's good 02http://git.io/jLFL [17:32:12] 10Wikidata: Investigate using RESTBase for generating Wikidata dumps (e.g. rdf, json) - https://phabricator.wikimedia.org/T93913#1149579 (10aude) 3NEW [17:32:50] ok, never mind, that was just me being dumb as usueal : wgRevisionId ^^' [17:33:18] 10Wikidata: Investigate using RESTBase for generating Wikidata dumps (e.g. rdf, json) - https://phabricator.wikimedia.org/T93913#1149587 (10aude) [17:37:20] 10Wikidata: Investigate using RESTBase for batched entity lookups - https://phabricator.wikimedia.org/T93913#1149592 (10hoo) [17:39:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Performance, and 2 others: batch entity revision lookup for performance improvements - https://phabricator.wikimedia.org/T87238#1149602 (10hoo) See also https://phabricator.wikimedia.org/T93913 (which *could* be a better solution here) [17:39:15] 10Wikidata: Investigate using RESTBase for batched entity lookups - https://phabricator.wikimedia.org/T93913#1149604 (10JanZerebecki) Could this replace our use of memcache for entity revisions? [17:39:34] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance: mw.wikibase: Use __index to lazy load entity contents - https://phabricator.wikimedia.org/T76156#1149612 (10daniel) The only downside I see is the case that you first access the labels, which get fetched from the terms table, and later more of... [17:40:27] (03CR) 10Smalyshev: Refactor prefixes to be output only once, eliminate need to clean prefixes on dump (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 (owner: 10Smalyshev) [17:40:42] hoo: did you find out anything about the dispatcher issue? I'm at a loss... do you have logs to send me? [17:41:12] but then, I guess it can remain in the "old" state for a few more days, if it has been like this for years. [17:41:33] SMalyshev: i have about an hour to look into rdf stuff now [17:41:43] DanielK_WMDE_: I did a change regarding it locking up [17:41:57] But the other thing is just *so* screwed [17:42:32] DanielK_WMDE_: cool. maybe start with checking https://gerrit.wikimedia.org/r/#/c/196663/ and if it's ok we can merge it? [17:42:40] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance: mw.wikibase: Use __index to lazy load entity contents - https://phabricator.wikimedia.org/T76156#1149618 (10hoo) >>! In T76156#1149612, @daniel wrote: > The only downside I see is the case that you first access the labels, which get fetched fro... [17:42:41] makes a lot of other things easier to do [17:42:42] i'll have a look [17:42:57] 10Wikidata: Investigate using RESTBase for batched entity lookups - https://phabricator.wikimedia.org/T93913#1149619 (10aude) restbase is only for wikipedias currently and stores html versions of revisions in the future it could support other content types. We should think about and investigate our use cases w... [17:43:26] hoo: the isRelevantChange thing? screwed how?... [17:43:28] it's mostly your code, I just rebased it and made small tweak to fix tests [17:43:38] hoo: and what change?... [17:44:12] DanielK_WMDE_: https://gerrit.wikimedia.org/r/199592 that turned up the randomness and removed FOR UPDATE from the initial query [17:44:23] And yes, the isRelevantChange just looks wrong [17:44:31] it doesn't take any usage tracking into account or anything [17:46:06] hoo: it shouldn't. that is done by the query. it checks whether the *diff* makes the change relevant. maybe the name could be better [17:46:24] hoo: no support for usage tracking is implemented yet, that will happen after the refactoring [17:46:27] 10Wikidata, 10Wikidata-Query-Service: Determine which dump parts we want in which files - https://phabricator.wikimedia.org/T93488#1149630 (10Smalyshev) [17:46:38] hoo: right now, it's sitelinks table OR diff. [17:46:46] and i don't see where the code is wrong. [17:48:28] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1149637 (10Smalyshev) I would propose to discuss dump partitioning for RDF in T93488, since it becomes hard to track... [17:49:58] DanielK_WMDE_: It seems to just be false all the time [17:50:03] but I dunno really why [17:50:10] I checked all code paths and the all looked sane [17:50:21] although the diff stuff is really really badly documented [17:50:34] regarding the format of the data contained and things like that [17:50:37] hoo: it would be true only when modifying the sitelink to the client wiki we are currently dispatching to [17:50:48] it's intended to especially catch the case of removing the sitelink to that wiki [17:50:58] in that case, it would no longer be in the sitelinkstable [17:51:04] (03CR) 10Thiemo Mättig (WMDE): Refactor prefixes to be output only once, eliminate need to clean prefixes on dump (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 (owner: 10Smalyshev) [17:51:10] hoo: i'll debug into it [17:51:45] Ok [17:51:52] 10Wikidata: Property suggester broken on Wikidata - https://phabricator.wikimedia.org/T93878#1149655 (10aude) I don't completely understand what is broken and what the expected behavior is for various situations. I tried the wmf/1.25wmf19 branch that we had deployed previously, and tried the current version an... [17:52:00] EntityLookup is such a mess right now [17:52:02] :( [17:52:07] So many things blocked on that topic [17:52:12] (03PS11) 10Daniel Kinzler: Refactoring dispatchChanges.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 [17:52:14] just stumbled upon that as well [17:52:19] (03CR) 10jenkins-bot: [V: 04-1] Refactoring dispatchChanges.php [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (owner: 10Daniel Kinzler) [17:52:22] how the dispatcher is now is okay enough [17:52:22] * batched entity lookup, that is [17:52:23] [13WikibaseDataModel] 15thiemowmde pushed 3 new commits to 06master: 02http://git.io/jtUj [17:52:23] 13WikibaseDataModel/06master 1402aacff 15jeroendedauw: Remove Claims::indexOf [17:52:23] 13WikibaseDataModel/06master 14bd441fa 15Thiemo Mättig: Re-add assertion [17:52:23] 13WikibaseDataModel/06master 142539654 15Thiemo Mättig: Merge pull request #417 from wmde/indexofrm... [17:52:33] Yeah, it's good enough for now [17:52:40] hoo's patch is probably good to have, although want to double check it manually myself [17:52:48] Yeah [17:52:50] before deploy [17:52:59] also we should set the randomness to 15 or 20 in production [17:53:01] aude: ^ [17:53:02] (03CR) 10Daniel Kinzler: "PS11 applies Ie7d68953be5c6 to the refactored version of dispatchChanges" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198427 (owner: 10Daniel Kinzler) [17:53:07] (had i done that with the previous backports, we would have known and not make mistake) [17:53:23] hoo: sounds good [17:53:44] (03PS4) 10Smalyshev: Refactor prefixes to be output only once, eliminate need to clean prefixes on dump [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 [17:53:50] (03CR) 10jenkins-bot: [V: 04-1] Refactor prefixes to be output only once, eliminate need to clean prefixes on dump [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 (owner: 10Smalyshev) [17:54:26] hoo, aude: with the bad isrelevantChange check, all changes will be dispatched to all wikis. that sucks... [17:54:36] it is bad [17:54:45] but better than last night to have none dispatched [17:54:47] Indeed [17:54:50] but it works [17:54:59] yes. i'll try to understand why that is happening. [17:55:11] * aude is busy with other bugs [17:55:13] i'll file a ticket for now, and put it into the current sprint [17:55:30] i'll investigate tomorrow, i want to unblock SMalyshev wrt rdf now [17:57:20] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance: mw.wikibase: Use __index to lazy load entity contents - https://phabricator.wikimedia.org/T76156#1149683 (10hoo) A problem I came across while poking at this is that we would need to call out to `EntityLookup::hasEntity` on every `mw.wikibase.g... [17:57:50] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1149685 (10JanZerebecki) > Why would one want to do this? To be able to use the same code as is used for the linked... [17:58:17] DanielK_WMDE_: https://phabricator.wikimedia.org/T76156#1149683 I have some ideas how to solve that, but they are either not super nice or would require quite some work [17:59:31] (03CR) 10Smalyshev: [C: 031] "Whitespace and comment changes, have no objection to it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199622 (owner: 10Thiemo Mättig (WMDE)) [18:03:14] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I find the "$( document ).attr( 'dir')" calls odd. Other code we have uses "$( 'html' ).prop( 'dir' )", which is a little bit better becau" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [18:03:59] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/jtqb [18:03:59] 13WikibaseDataModel/06master 144a6add8 15Jeroen De Dauw: Update RELEASE-NOTES.md... [18:05:07] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Fix filtering of relevant changes in ChangeDispatcher - https://phabricator.wikimedia.org/T93918#1149706 (10daniel) 3NEW [18:08:14] (03CR) 10Smalyshev: T92996: Add Julian Calendar support (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 (owner: 10Smalyshev) [18:10:20] (03CR) 10Hoo man: [C: 032] Clean up RDF and Dumpers related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199622 (owner: 10Thiemo Mättig (WMDE)) [18:11:43] [13WikibaseDataModel] 15JeroenDeDauw created 06StatementByGuidMap (+1 new commit): 02http://git.io/jt3H [18:11:43] 13WikibaseDataModel/06StatementByGuidMap 14b383c72 15jeroendedauw: WIP - StatementByGuidMap [18:11:53] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #419: WIP - StatementByGuidMap (06master...06StatementByGuidMap) 02http://git.io/jt3F [18:12:42] Is it permissiable to input a corporation's information including officers now that google knowledge graph reads from wikidata? [18:13:50] (03Merged) 10jenkins-bot: Clean up RDF and Dumpers related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199622 (owner: 10Thiemo Mättig (WMDE)) [18:18:32] wmde/WikibaseDataModel/StatementByGuidMap/b383c72 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/55837731 [18:21:05] (03CR) 10Daniel Kinzler: [C: 031] "@Smalyshev +1 for your additions to the patch. Please +2 if you are find with it going in now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 (owner: 10Daniel Kinzler) [18:21:22] (03CR) 10Hoo man: [C: 032] Move EntityIdFormatterFactory to View, implementation to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199311 (owner: 10Adrian Lang) [18:22:01] dprophit: not generally. only if these people are relevant by wikipedia standards, or there is a structural need to have them on wikidata [18:22:33] dprophit: why would the fact that knowledge graph reads from wikidata mean that wikidata should have less strict standards for inclusion? [18:23:17] DanielK_WMDE_: ok. Assume a US corp is listed with the State of FL. The officers of the corporation are listed. Is that a notable source? [18:24:24] (03Merged) 10jenkins-bot: Move EntityIdFormatterFactory to View, implementation to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199311 (owner: 10Adrian Lang) [18:24:44] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Performance: mw.wikibase: Use __index to lazy load entity contents - https://phabricator.wikimedia.org/T76156#1149843 (10daniel) Batch lookup of entity metadata, based on usage tracking, sounds like a good idea. [18:25:33] dprophit: having a credible source is a necessary, but not a sufficient condition for notability. [18:25:54] that is, the recourd can probably be trusted, but being on there doesn't make someone notable [18:25:59] *record [18:27:07] DanielK_WMDE_: So I understand, wikidata isn't for common entries. Just famous people, places and things? [18:27:15] (03CR) 10JanZerebecki: [C: 04-1] Improve exception about an unexpected entity id in WikiPageEntityRevisionLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199632 (https://phabricator.wikimedia.org/T91517) (owner: 10Hoo man) [18:27:28] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: not possible to enter value of type property - https://phabricator.wikimedia.org/T93924#1149851 (10Lydia_Pintscher) 3NEW [18:27:40] dprophit: at the moment, the inclusion criteria are more or less the same as on wikipedia. but this is still in flux. [18:27:49] if you like, propose to import base data on all publically registered companies and their officers. see how it goes. [18:28:44] dprophit: wikidata does not aim to be a complete collection of all public data, not a random collection of public data. it aims to be a curated knowledge repository. [18:29:03] DanielK_WMDE_: Ok. My employer already has a google knowledgegraph card. They made an announcement that they were deprecating freebase and using wikidata. So, I'm here to learn. ;-) [18:29:07] for that, it needs to prioritize, so the scarcest resource, the attention of editors, is used wisely. [18:29:43] dprophit: knowledge graph reads from many sources. quite possibly, it reads from the public registries directly. [18:30:08] (03CR) 10Hoo man: [C: 04-1] "Nit picks" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199327 (owner: 10Adrian Lang) [18:30:21] (03PS21) 10Smalyshev: Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 (owner: 10Daniel Kinzler) [18:31:00] (03PS22) 10Smalyshev: Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 (owner: 10Daniel Kinzler) [18:31:22] DanielK_WMDE_: one would think. Our entry came about because we made a freebase entry. The logo came from microdata. But, I had assumed if we wanted more infomration about the corp to be included, we had to come here. I'll continue to learn. TY for ur time. [18:31:27] rebasing, rebasing... [18:31:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy: EntityIdValues should be serialized as strings, not type/number structures. - https://phabricator.wikimedia.org/T56085#1149876 (10Sumit) Does the serialization change need to be in EntitySerializer.php? Also what could possibly a new serialization... [18:31:54] (03CR) 10Hoo man: Improve exception about an unexpected entity id in WikiPageEntityRevisionLookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199632 (https://phabricator.wikimedia.org/T91517) (owner: 10Hoo man) [18:32:40] (03PS3) 10Hoo man: Improve exception about an unexpected entity id in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199632 (https://phabricator.wikimedia.org/T91517) [18:33:19] Is there a different channel for wikidata? The code development announcements are distracting. [18:34:43] dprophit: no there isn't. currently, development and community are sharing the channel [18:34:50] There should be something like #wikidata-devel for git commits. IMHO =) [18:34:51] we may split the channels at some point... [18:35:03] Ignore user, done :) [18:35:16] (03CR) 10Smalyshev: [C: 032] "OK, it's time!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 (owner: 10Daniel Kinzler) [18:35:21] /ignore, that is [18:35:24] ah duh lol ctcp ignore heh [18:35:53] jzerebecki: Eg. https://gerrit.wikimedia.org/r/#/admin/projects/wikimedia,access [18:36:12] SMalyshev: i'd like to show you how i envision splitting RdfBuilder should work. i'll base that on the patch you just merged, ok? [18:37:03] DanielK_WMDE_: ok I guess we have more pending but they are mostly in other classes so touching rdfbuilder should be ok [18:37:42] I still don't think we should spend time on it while we don't have working prototype yet [18:39:55] (03Merged) 10jenkins-bot: Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 (owner: 10Daniel Kinzler) [18:40:30] ^^ wohoo! [18:42:55] is there a possibility to get a list of all items using a property with the data in a second column or something? [18:44:23] (03PS22) 10Smalyshev: Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 [18:47:08] like I want to have all data added with property P717 where this property is used [18:47:51] (03CR) 10jenkins-bot: [V: 04-1] Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 (owner: 10Smalyshev) [18:48:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: not possible to enter value of type property - https://phabricator.wikimedia.org/T93924#1150033 (10Lydia_Pintscher) 5Open>3Invalid a:3Lydia_Pintscher [18:49:07] Lydia_WMDE: What was up with that bug? I couldn't reproduce it? [18:49:15] * ! [18:49:21] locally [18:49:25] hoo: see last post on contact dev team page [18:49:33] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Fix filtering of relevant changes in ChangeDispatcher - https://phabricator.wikimedia.org/T93918#1150041 (10daniel) [18:49:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1150040 (10daniel) [18:49:49] one can't switch over from "no value" to "custom value". [18:49:53] is that klnown? [18:49:55] * known [18:50:03] Romaine: wikidata query should be able to do what you want [18:50:14] hoo: no and i have tried to reproduce it and can't [18:50:26] might be dependent on the datatype? [18:50:33] needs more investigation [18:50:36] I think so yes, but how to do that remains a mystery for me with the info on the info pages about it [18:50:42] SMalyshev: i think we should spend time on it now, to make prototyping easier [18:51:02] also, we'll never spend tiem "when there is time for stuff like that", because there never is. [18:51:11] Romaine: ah there are a few people here who use it regularly. so maybe just ask which exact data you would want and one of them might be able to get you a link [18:51:15] DanielK_WMDE_: ok, show me what you mean and let's see [18:51:20] :) [18:51:34] Lydia_WMDE: TypeError: statement is null [18:51:34] i'm runnign a bit behind shedule today, will probably not happen before tomorrow [18:51:48] right now I have at least 2 patches to rebase and clean up but after that we can see it [18:52:00] i have an archcom session coming up in an hour, and need to get home and eat before that... [18:52:07] ok: all items with property 717, listed with what is filled in for that item for that property [18:52:36] Lydia_WMDE: the patch that SMalyshev just merged kills our dependency on EasyRdfLite [18:52:43] * hoo goes to investigate more [18:53:13] SMalyshev: DanielK_WMDE_: yay! :) [18:53:14] awesome [18:53:21] hoo: thank you! [18:53:30] awesome indeed. Also 3x faster :) [18:54:45] getting a list of the items I can have with https://wdq.wmflabs.org/api?q=claim[717] [18:55:03] but now with the data too... [18:55:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1150092 (10daniel) This fix by @hoo apparently fixes the most pressing issues: https://gerrit.wikimedia.org/r/#/c/199592/ However, T93918 still needs... [18:55:32] What's the best document on the data structure of Wikidata? Things like "items have unique ID", "the label, description pair must be unique", "a reference is attached to a statement" [18:55:45] * hoo wtfs hard [18:55:57] Lydia_WMDE: Does https://www.wikidata.org/wiki/Q845221?debug=true work for you? (Or justa random smallish item with debug=true) [18:56:04] Maybe https://www.wikidata.org/wiki/Help:Wikidata_datamodel [18:56:18] (Using Firefox) [18:56:29] hoo: works fine in chromium [18:56:40] Romaine: like this? https://wdq.wmflabs.org/api?q=claim[717]&prop=717 [18:56:53] * hoo goes to try Epiphany [18:57:02] Nemo_bis: https://www.mediawiki.org/wiki/Wikibase/DataModel more likely [18:57:05] Romaine: sorry, https://wdq.wmflabs.org/api?q=claim[717]&props=717 [18:57:22] Lydia_WMDE: Ok, works for me in epiphany :P [18:57:25] * Romaine looks [18:57:33] Lydia_WMDE: But click on add a new statement, please [18:57:49] seems fine too [18:57:53] Really? [18:57:53] yes DanielK_WMDE_: thanks! [18:58:06] For me it's asking me to add a qualifier right away [18:58:20] Seen that locally (with Firefox) and on Wikidata with epiphany [18:59:31] ahh [18:59:32] yes [18:59:34] same here [19:00:13] Probably load order dependent [19:00:26] https://www.mediawiki.org/wiki/Wikibase/DataModel is more similar to the glossary, in that it contains a bunch of definitions [19:05:29] (03CR) 10JanZerebecki: [C: 032] Improve exception about an unexpected entity id in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199632 (https://phabricator.wikimedia.org/T91517) (owner: 10Hoo man) [19:12:26] (03Merged) 10jenkins-bot: Improve exception about an unexpected entity id in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199632 (https://phabricator.wikimedia.org/T91517) (owner: 10Hoo man) [19:14:35] (03PS9) 10Smalyshev: T92996: Add Julian Calendar support [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198419 [19:17:47] (03PS23) 10Smalyshev: Performance tweaks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198115 [19:18:37] hoi does the Babel template no longer function for the languages that are shown ? [19:21:12] (03PS5) 10Smalyshev: Refactor prefixes to be output only once, eliminate need to clean prefixes on dump [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199543 [19:21:36] GerardM-: What exactly do you mean? [19:21:52] Using babel on your user page should still have the same effect it had before [19:22:10] But please notice that we redesigned the in other languages box [19:28:32] I used to have languages shown based on my Babel template [19:28:37] they no longer show [19:28:52] GerardM-: Did you expand the box? [19:29:29] In more languages [19:29:31] Configure [19:29:32] yes [19:31:57] * aude has kurdish, british english etc [19:32:02] from my babel boxes [19:32:31] my language includes Ottoman Turkish and it does not [19:32:45] and German, French, Indonesian [19:32:57] that might be related to being a special language [19:33:05] if it's just ottoman turkish not working [19:33:16] (e.g. a bug) [19:33:29] no it is all of them [19:33:31] missing [19:33:37] no, i have ota now [19:33:48] hoo has a screenshot [19:34:04] are there any javascript errors in your console? [19:34:34] I have the screenshot [19:34:38] mh :/ [19:34:43] or does it work w/o js? [19:37:21] > var_dump( Babel::getUserLanguages( User::newFromName( 'GerardM' ), 0 ) ); [19:37:27] that works correctly, so not hte issue [19:37:56] GerardM-: Do you know how to have a look at JavaScript errors in your browser? [19:38:11] no [19:38:22] What browser are you using? Firefox? [19:39:09] it is the same for chrome and FF [19:41:31] possibly it is related to a gadget or script [19:41:33] *the issue [19:41:48] * aude goes to enable more gadgets [19:42:37] GerardM-: Ok, so can you use Ctrl + K on an item view and reload the page? [19:44:14] still works for me [19:46:31] * aude has all gadgets [19:47:30] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1150398 (10Smalyshev) "Consistency" of dumps in different formats is a questionable thing. What would it mean to hav... [19:49:54] aude : hopefully before this weekend, you'll have one more :-p [19:53:51] Alphos_: :) [19:54:44] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1150426 (10mkroetzsch) @Smalyshev Re "what does consistent mean": to be based on the same input data. All dumps are... [19:54:51] getting to know the "new" resources (haven't tweaked MW in a few years), and having a lot of fun ^^ [19:57:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1150439 (10aude) [19:57:32] 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Fix filtering of relevant changes in ChangeDispatcher - https://phabricator.wikimedia.org/T93918#1150440 (10aude) [19:57:54] 10Wikidata, 10Datasets-General-or-Unknown, 3§ Wikidata-Sprint-2015-03-24: Wikidata JSON dump: file directory location should follow standard patterns - https://phabricator.wikimedia.org/T72385#1150442 (10Smalyshev) I don't think splitting full and truthy would be too useful, as most query engines, except for... [20:01:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24: Dispatcher broken on Wikidata - https://phabricator.wikimedia.org/T93831#1150450 (10aude) Though obviously related, T93918 is not really blocking task since the issue on Wikidata is already "fixed" with revert. We should d... [20:47:06] (03PS9) 10Ebrahim: Better handling of bidi content on entity terms table [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 [20:51:18] (03CR) 10Ebrahim: "Okay. Added one of them on two place as comment. Please take a look again :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/198228 (owner: 10Ebrahim) [21:01:59] kaldari: Did some friends from enwp tag along and are now giving you a hard time? :P [21:02:34] looks like it :P [21:03:18] Both don't really seem to edit Wikidata a lot [21:03:33] I just wish they would discuss the actual bot request [21:04:02] kaldari: I wish you would respond to my question, because that's about the actual bot request ;-) [21:04:29] (03PS3) 10Hoo man: Make SpecialGoToLinkedPage support entity redirects [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190680 (https://phabricator.wikimedia.org/T78526) [21:05:15] (03CR) 10Hoo man: "Re-did this change using EntityPerPage (which I extended slightly by a method the only subclass already implements)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190680 (https://phabricator.wikimedia.org/T78526) (owner: 10Hoo man) [21:05:59] multichill: I saw your comment and have set the wheels in motion to address it. It involves some delegation though, so I haven’t replied yet. (Don’t want to agree to something and then not deliver.) [21:06:33] multichill: I’ll reply to it today though [21:06:35] Ok. Take your time [21:06:43] Today is almost over for me anyway [21:08:04] kaldari: Meeting up with the Rijksmuseum tomorrow to talk about Wikidata. Meeting up at 07:45 so we can go to https://www.rijksmuseum.nl/en/late-rembrandt before the museum actually opens :-) [21:30:53] how I update Wikidata/Wikibase autoload files after checking out the new version from git? [21:31:20] SMalyshev: composer update [21:31:26] or composer dump-autoload [21:34:09] 10Wikidata: Wikidata produces internal server error in Special:EntityData for redirect - https://phabricator.wikimedia.org/T93950#1150911 (10Manybubbles) 3NEW [21:35:30] aha, update worked... dump-autoload didn't [21:36:19] Yeah, dump-autoload only recreates the class map, but doesn't update dependencies [21:36:25] sometimes that's enough [21:41:54] hoo: hi :) [21:42:10] hi benestar :) [21:42:19] I've updated the tours earlier today [21:42:25] Guess you saw that [21:42:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign Item UI for Wikidata repo - https://phabricator.wikimedia.org/T54136#1150983 (10FriedhelmW) [21:42:45] 10Wikidata, 10Wikidata.org: Wikidata: two-column layout problem (sitelinks UI) - https://phabricator.wikimedia.org/T86931#1150980 (10FriedhelmW) 5Open>3Resolved a:3FriedhelmW Seems to be resolved now. Thank you. [21:46:55] hoo: just tried it, works fine [21:47:25] some minor adjustments will be necessary but i will do that next week perhaps [21:48:00] Awesome :) [21:58:21] gn8 hoo ;) [21:58:32] Good night :) [22:20:46] (03CR) 10Hoo man: [C: 032] Use browsers native URL parser [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/195276 (owner: 10Thiemo Mättig (WMDE)) [22:24:30] (03CR) 10jenkins-bot: [V: 04-1] Use browsers native URL parser [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/195276 (owner: 10Thiemo Mättig (WMDE)) [22:30:29] (03CR) 10Hoo man: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/195276 (owner: 10Thiemo Mättig (WMDE)) [22:34:23] (03PS1) 10Smalyshev: Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 [22:36:50] (03CR) 10Smalyshev: "Fixed for RDF/XML and ntriple rendering. Right now, .nt does not render at all as a page (due to mismatch between config name and internal" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [22:38:00] (03CR) 10jenkins-bot: [V: 04-1] Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [22:50:06] (03CR) 10Hoo man: [V: 032] "Jenkins failures are unrelated." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/195276 (owner: 10Thiemo Mättig (WMDE)) [22:53:32] (03PS2) 10Smalyshev: Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 [22:56:45] (03CR) 10jenkins-bot: [V: 04-1] Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [22:58:25] (03PS3) 10Smalyshev: Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 [23:02:28] (03CR) 10jenkins-bot: [V: 04-1] Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 (owner: 10Smalyshev) [23:02:32] (03PS4) 10Smalyshev: Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 [23:09:38] (03Abandoned) 10Smalyshev: Add RDR serializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193547 (owner: 10Smalyshev) [23:13:13] 10Wikidata: .rdf and .nt special page data exports broken in master - https://phabricator.wikimedia.org/T93965#1151417 (10Smalyshev) 3NEW a:3daniel [23:13:32] (03PS5) 10Smalyshev: T93965: Fix RDF rendering [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/199770 [23:21:10] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: ChangeNotificationJob fails with MalformedTitleException - https://phabricator.wikimedia.org/T93970#1151488 (10hoo) 3NEW [23:22:48] (03PS1) 10Hoo man: Improve exception about an unexpected entity id in WikiPageEntityRevisionLookup [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199783 (https://phabricator.wikimedia.org/T91517) [23:24:20] (03CR) 10Hoo man: "This is happening quite often and I don't really have an idea why. Adding this change to the next set of backports wont harm." [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/199783 (https://phabricator.wikimedia.org/T91517) (owner: 10Hoo man) [23:25:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-24, 5Patch-For-Review: Revision slave does not belong to entity Q139 - https://phabricator.wikimedia.org/T91517#1151522 (10hoo) p:5Triage>3High Quite frequent in the log [23:36:40] 10Wikidata, 6MediaWiki-Core-Team, 10MediaWiki-Page-editing: WikiPage: "Could not find text for current revision" - https://phabricator.wikimedia.org/T93976#1151597 (10hoo) [23:40:36] 10Wikidata, 10Wikidata-Query-Service: Data format updates for RDF export - https://phabricator.wikimedia.org/T93451#1151627 (10Smalyshev) Looks like schema: uses capital case for objects - ` a schema:Article` but lowercase for predicates - ` schema:inLanguage "en"`. We should probably fol...