[03:17:31] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1127384 (10Nicolas_Raoul) [06:49:59] hiya people :) i seem to remember seeing a list of properties that have a "reverse" property (something like "Qx is member of Qy" vs "Qy has a member named Qx"), but i can't find it in my browser history. anyone know which one i'm talking about ? [06:51:08] never mind, it was simply the main list, i thought there was one specifically for those [07:23:44] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1127564 (10Qgil) @Nicolas_Raoul, @Jdlrobson, the microtasks listed in the description look like steps for implementing the actual project idea. We are talking abou... [07:50:34] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1127580 (10Nicolas_Raoul) If "Software development" is too broad, how about asking for PHP skills? Although I feel that anyone with software development skills can... [07:53:32] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1127592 (10Nicolas_Raoul) [08:21:29] 10Wikidata, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release4, 5ContentTranslation-Release5, 7Design: Red links in the article as entry points for translation - https://phabricator.wikimedia.org/T88580#1015313 (10Arrbee) [09:30:07] Привет. Есть русскоговорящие пользователи? [10:01:19] (03PS1) 10WikidataBuilder: New Wikidata Build - 2015-03-18T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/197492 [10:03:22] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015-03-18T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/197492 (owner: 10WikidataBuilder) [10:33:47] (03PS1) 10Daniel Kinzler: Increase width of the eu_aspect column to varbinary(37). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197504 (https://phabricator.wikimedia.org/T92288) [10:39:52] (03PS2) 10Daniel Kinzler: Increase width of the eu_aspect column to varbinary(37). [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197504 (https://phabricator.wikimedia.org/T92288) [10:40:44] (03PS2) 10Hoo man: Fix EditEntity::isNew for new entities with an Id set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190657 (https://phabricator.wikimedia.org/T85454) [10:41:46] (03CR) 10Hoo man: [C: 04-1] "Manully rebased, Thiemo's comments still apply." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190657 (https://phabricator.wikimedia.org/T85454) (owner: 10Hoo man) [11:09:42] (03CR) 10Hoo man: Fix EditEntity::isNew for new entities with an Id set (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190657 (https://phabricator.wikimedia.org/T85454) (owner: 10Hoo man) [11:13:21] (03PS3) 10Hoo man: Fix EditEntity::isNew for new entities with an Id set [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190657 (https://phabricator.wikimedia.org/T85454) [11:14:01] (03CR) 10Hoo man: "Addressed Thiemo's comments (thanks for the detailed review)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190657 (https://phabricator.wikimedia.org/T85454) (owner: 10Hoo man) [11:18:55] http://www.w3.org/TR/xmlschema-2/ vs. http://www.w3.org/TR/xmlschema11-2/ [11:55:47] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Implement tracking of label use per parser target language - https://phabricator.wikimedia.org/T93055#1128209 (10daniel) 3NEW [11:59:20] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Include fallback languages in label tracking. - https://phabricator.wikimedia.org/T93056#1128217 (10daniel) 3NEW [12:02:02] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: add eu_page_touched field to wbc_entity_usage_tracking - https://phabricator.wikimedia.org/T93057#1128225 (10daniel) 3NEW [12:02:39] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Track multi-lingual label usage - https://phabricator.wikimedia.org/T89002#1128232 (10daniel) Decision needed on T93057 [12:05:30] (03PS1) 10Lucie Kaffee: Add missing qqq messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) [13:04:04] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1128312 (10NiharikaKohli) [13:07:11] 10MediaWiki-extensions-WikibaseClient, 7Verified: Wikibase Client cause ULS cog hidden for anonymous users - https://phabricator.wikimedia.org/T51005#1128328 (10Nikerabbit) Just for the record, this was removed in https://gerrit.wikimedia.org/r/#/c/195077/1, but that didn't seem to cause any regressions. [13:38:46] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Investigate tracking update mechansim for "non-standard language" views. - https://phabricator.wikimedia.org/T93066#1128458 (10daniel) 3NEW [13:45:18] (03PS2) 10Lucie Kaffee: Add missing qqq messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) [13:45:21] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Investigate tracking update mechansim for "non-standard language" views. - https://phabricator.wikimedia.org/T93066#1128480 (10daniel) WikiPage::triggerOpportunisticLinksUpdate may be a good starting point [13:52:08] (03PS1) 10Aude: New deployment build - wmf/1.25wmf22 [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197518 [13:54:12] (03CR) 10jenkins-bot: [V: 04-1] New deployment build - wmf/1.25wmf22 [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197518 (owner: 10Aude) [13:55:32] 10Wikidata: AvailableRightsTest::testAvailableRights fails on Wikidata build - https://phabricator.wikimedia.org/T93067#1128486 (10aude) 3NEW [13:55:48] wtf [13:55:52] yeah [13:55:56] didn't I backport that fix? [13:56:05] this is a new build [13:56:06] Or is that a new right? [13:56:13] 10Wikidata, 10Wikimedia-Hackathon-2015: Wikidata activities at the Wikimedia Hackathon 2015 - https://phabricator.wikimedia.org/T92270#1128494 (10Lydia_Pintscher) [13:56:15] we get this on the daily builds also [14:03:24] repo/config/Wikibase.example.php: $wgGroupPermissions['wbeditor']['item-set'] = true; [14:03:59] wtf [14:04:40] I can fix that... but why is it even importing the example settings? [14:04:45] Those are *examples* [14:04:48] not defaults [14:05:09] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf22/769b57b : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54870143 [14:06:15] i think we use them also for travis, at least [14:06:24] maybe not necessary now [14:06:28] (03PS1) 10Hoo man: Don't set the "item-set" right in the repo example settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197524 [14:06:29] mh [14:06:34] patch ^ [14:06:43] and jenkins afaik [14:07:27] and that's why the tests don't fail locally [14:08:07] (03CR) 10Aude: [C: 032] Don't set the "item-set" right in the repo example settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197524 (owner: 10Hoo man) [14:08:44] (03PS1) 10Thiemo Mättig (WMDE): Fix and clean-up comments in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197525 [14:08:51] hoo: would the tests work without the namespace settings? [14:09:04] Probably not [14:09:32] 'entityNamespaces' => array(), [14:09:35] that's the default [14:09:40] yeah [14:09:59] (03PS2) 10Aude: Don't set the "item-set" right in the repo example settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197524 (https://phabricator.wikimedia.org/T93067) (owner: 10Hoo man) [14:10:12] Mh... maybe we should move the example namespace settings to default? [14:10:17] Think we have a bug for that [14:11:04] https://phabricator.wikimedia.org/T53051 [14:11:20] Something Lucie_WMDE looked at [14:11:23] suppose we can do that [14:11:39] that's just one of the settings [14:12:01] yeah, but I think the bug implies sane defaults for everything [14:13:36] i don't think it does [14:13:55] https://phabricator.wikimedia.org/T53051#806746 [14:13:58] there should be a task for "everything" [14:14:18] * hoo will edit it [14:15:18] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Set useful and consistent (in client/repo) default namespaces. - https://phabricator.wikimedia.org/T53051#1128579 (10hoo) [14:15:22] * aude conflicted what the defaults should be [14:15:42] (03PS1) 10Thiemo Mättig (WMDE): Inline trivial getters in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197528 [14:15:47] if you want wikibase to be like wikidata, on a fresh install [14:16:03] vs. existing install that has main ns for something else [14:16:07] I think the default should be more conservative and not use the NS= [14:16:09] * NS0 [14:16:11] yeah [14:18:11] (03CR) 10Aude: Don't set the "item-set" right in the repo example settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197524 (https://phabricator.wikimedia.org/T93067) (owner: 10Hoo man) [14:18:18] (03CR) 10Aude: [C: 032] Don't set the "item-set" right in the repo example settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197524 (https://phabricator.wikimedia.org/T93067) (owner: 10Hoo man) [14:19:09] 10Wikidata, 7Need-volunteer: framework for source checking - https://phabricator.wikimedia.org/T90881#1128593 (10JanZerebecki) [14:19:12] (03CR) 10jenkins-bot: [V: 04-1] Inline trivial getters in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197528 (owner: 10Thiemo Mättig (WMDE)) [14:20:22] (03PS1) 10Thiemo Mättig (WMDE): Refactor some methods in EditEntity for readability [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197529 [14:20:45] (03CR) 10Hoo man: [C: 032] "Nice" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197525 (owner: 10Thiemo Mättig (WMDE)) [14:21:03] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Set useful and consistent (in client/repo) default namespaces. - https://phabricator.wikimedia.org/T53051#1128598 (10Lucie) [14:21:16] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Set useful and consistent (in client/repo) default namespaces. - https://phabricator.wikimedia.org/T53051#577802 (10Lucie) [14:21:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7I18n, and 2 others: wikibase-setlabeldescriptionaliases-introfull needs GENDER support and qqq documentation - https://phabricator.wikimedia.org/T90431#1128602 (10Lucie) [14:22:25] (03Merged) 10jenkins-bot: Don't set the "item-set" right in the repo example settings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197524 (https://phabricator.wikimedia.org/T93067) (owner: 10Hoo man) [14:23:13] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Set useful and consistent (in client/repo) default namespaces. - https://phabricator.wikimedia.org/T53051#1128608 (10aude) this requires ensuring we don't break settings for Wikidata (and for va... [14:23:48] (03PS1) 10Thiemo Mättig (WMDE): Protected to private in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197530 [14:23:50] (03PS1) 10Aude: Don't set the "item-set" right in the repo example settings [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197531 (https://phabricator.wikimedia.org/T93067) [14:23:57] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: AvailableRightsTest::testAvailableRights fails on Wikidata build - https://phabricator.wikimedia.org/T93067#1128610 (10Lydia_Pintscher) [14:24:00] (03CR) 10jenkins-bot: [V: 04-1] Refactor some methods in EditEntity for readability [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197529 (owner: 10Thiemo Mättig (WMDE)) [14:24:16] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: AvailableRightsTest::testAvailableRights fails on Wikidata build - https://phabricator.wikimedia.org/T93067#1128613 (10Lydia_Pintscher) a:3aude [14:24:40] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #114 142545d19: This is a unit test for the ClaimSerializer, so it does not use the ReferenceSerializer. Instead, a simple fake is used. 02http://git.io/hCHC [14:27:23] (03CR) 10jenkins-bot: [V: 04-1] Protected to private in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197530 (owner: 10Thiemo Mättig (WMDE)) [14:28:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: When entering new statement + qualifier, the qualifier is not rendered on save - https://phabricator.wikimedia.org/T93073#1128619 (10aude) 3NEW [14:29:14] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: No javascript loaded on test.wikidata - https://phabricator.wikimedia.org/T92949#1128628 (10JanZerebecki) [14:40:56] (03PS1) 10Thiemo Mättig (WMDE): Drop unused methods from EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197539 [14:43:19] (03PS2) 10Thiemo Mättig (WMDE): Inline trivial getters in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197528 [14:45:51] (03PS2) 10Thiemo Mättig (WMDE): Refactor some methods in EditEntity for readability [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197529 [14:45:53] (03PS2) 10Thiemo Mättig (WMDE): Protected to private in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197530 [14:45:55] (03PS2) 10Thiemo Mättig (WMDE): Drop unused methods from EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197539 [14:46:40] 10Wikidata, 10Wikidata-Query-Service: Support more fine-grained date fields that xsd:dateTime - https://phabricator.wikimedia.org/T92009#1128689 (10JanZerebecki) [14:49:16] (03CR) 10Jeroen De Dauw: Introduce SpecialPageLinker (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197019 (owner: 10Adrian Lang) [14:50:11] (03CR) 10Jeroen De Dauw: [C: 031] Don't set the "item-set" right in the repo example settings [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197531 (https://phabricator.wikimedia.org/T93067) (owner: 10Aude) [14:51:05] (03CR) 10Aude: [C: 032] Don't set the "item-set" right in the repo example settings [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197531 (https://phabricator.wikimedia.org/T93067) (owner: 10Aude) [14:51:08] (03CR) 10Jeroen De Dauw: [C: 032] Inline trivial getters in EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197528 (owner: 10Thiemo Mättig (WMDE)) [14:52:06] aude: If you do backports, my 2s change from yesterday would be nice as well [14:52:12] if it's not already in there anyway [14:53:20] this is only for the new branch [14:53:26] (03CR) 10Tobias Gritschacher: [C: 031] "The labs instances do not exist anymore nor is our own CI instance. So if this isn't used by something else, I think it can be removed. @A" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188353 (owner: 10Thiemo Mättig (WMDE)) [14:53:31] (03CR) 10Jeroen De Dauw: [C: 032] "That 13 fields... ugh" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197530 (owner: 10Thiemo Mättig (WMDE)) [14:54:27] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Does somebody else wants to have a look? If not, please poke me and I will merge this tomorrow." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190657 (https://phabricator.wikimedia.org/T85454) (owner: 10Hoo man) [14:56:28] (03Merged) 10jenkins-bot: Don't set the "item-set" right in the repo example settings [extensions/Wikibase] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197531 (https://phabricator.wikimedia.org/T93067) (owner: 10Aude) [14:57:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7I18n, and 2 others: wikibase-setlabeldescriptionaliases-introfull needs GENDER support and qqq documentation - https://phabricator.wikimedia.org/T90431#1128731 (10Tobi_WMDE_SW) a:3Lucie [14:58:38] (03PS2) 10Aude: New deployment build - wmf/1.25wmf22 [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197518 [15:02:36] Thiemo_WMDE: upgrade your PhpStorm already! :) [15:02:37] JeroenDeDauw: There are only 5 (!) occurences of @internal in MediaWiki. Just replace them with @note. Done. Discussing this is pointless IMHO. [15:02:47] Thiemo_WMDE: agreed [15:02:59] Thiemo_WMDE: how about you make that change? Less change discussion will happen [15:03:13] I will do some patches. [15:03:29] weee \o/ [15:14:30] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197621 (owner: 10L10n-bot) [15:18:46] DanielK_WMDE_: you in the office tomorrow? [15:19:02] JeroenDeDauw: yes, why? [15:23:52] DanielK_WMDE_: got some time to discuss something now? [15:23:59] (03PS1) 10Aude: Render qualifiers in statementview after being save [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197631 (https://phabricator.wikimedia.org/T93073) [15:24:36] (03PS2) 10Aude: Render qualifiers in statementview after being saved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197631 (https://phabricator.wikimedia.org/T93073) [15:24:41] probably want to backport ^ [15:25:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: When entering new statement + qualifier, the qualifier is not rendered on save - https://phabricator.wikimedia.org/T93073#1128838 (10aude) [15:28:37] (03CR) 10Aude: [C: 032] New deployment build - wmf/1.25wmf22 [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197518 (owner: 10Aude) [15:30:28] [13DataValues] 15thiemowmde created 06internal (+1 new commit): 02http://git.io/hWWW [15:30:28] 13DataValues/06internal 148d87b2b 15Thiemo Mättig: Drop accidential @internal tag [15:30:38] [13DataValues] 15thiemowmde opened pull request #19: Drop accidential @internal tag (06master...06internal) 02http://git.io/hWWE [15:47:34] 10Wikidata: labels for coordinates (N, E, S, W in Property:P625) are not translatable in the various languages - https://phabricator.wikimedia.org/T93084#1128910 (10Romaine) 3NEW [15:48:06] (03CR) 10Aude: [C: 04-1] "think this adds some unnecessary css rules." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197121 (https://phabricator.wikimedia.org/T92431) (owner: 10Thiemo Mättig (WMDE)) [15:52:19] (03CR) 10Aude: [C: 04-1] "only nitpicks :/" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) (owner: 10Lucie Kaffee) [15:53:19] (03Merged) 10jenkins-bot: New deployment build - wmf/1.25wmf22 [extensions/Wikidata] (wmf/1.25wmf22) - 10https://gerrit.wikimedia.org/r/197518 (owner: 10Aude) [15:55:03] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Investigate tracking update mechansim for "non-standard language" views. - https://phabricator.wikimedia.org/T93066#1128940 (10daniel) [15:55:04] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: add eu_page_touched field to wbc_entity_usage_tracking - https://phabricator.wikimedia.org/T93057#1128939 (10daniel) [15:56:29] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/197622 (owner: 10L10n-bot) [16:02:05] (03PS3) 10Lucie Kaffee: Add missing qqq messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) [16:04:41] (03PS4) 10Lucie Kaffee: Add missing qqq messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) [16:15:52] JeroenDeDauw: tomorrow is better, send me an invite [16:19:29] (03PS5) 10Lucie Kaffee: Add missing qqq messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) [16:19:47] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Investigate tracking update mechansim for "non-standard language" views. - https://phabricator.wikimedia.org/T93066#1129122 (10daniel) WikiPage::triggerOpportunisticLinksUpdate is indeed called whenever a page is re-rendered for display with a specific set of... [16:24:09] (03PS1) 10Jeroen De Dauw: Use Diff 2.x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197645 [16:24:25] Derp. Almost git pushed to a branch on gerrit [16:25:04] (03CR) 10jenkins-bot: [V: 04-1] Use Diff 2.x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197645 (owner: 10Jeroen De Dauw) [16:25:06] (03CR) 10Jeroen De Dauw: Render qualifiers in statementview after being saved (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197631 (https://phabricator.wikimedia.org/T93073) (owner: 10Aude) [16:25:39] Jenkins broken? [16:25:46] (03PS2) 10Jeroen De Dauw: Use Diff 2.x. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197645 [16:26:27] (03PS6) 10Lucie Kaffee: Add missing qqq messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) [16:26:40] (03CR) 10jenkins-bot: [V: 04-1] Use Diff 2.x. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197645 (owner: 10Jeroen De Dauw) [16:26:51] (03PS3) 10Jeroen De Dauw: Render qualifiers in statementview after being saved [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197631 (https://phabricator.wikimedia.org/T93073) (owner: 10Aude) [16:28:42] JeroenDeDauw: I did patches that remove *ALL* @internal tags. Should I add you as a reviewer? [16:29:40] Thiemo_WMDE: sure, I'll -1 it to speed to the review process? [16:29:50] (03CR) 10Aude: Render qualifiers in statementview after being saved (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197631 (https://phabricator.wikimedia.org/T93073) (owner: 10Aude) [16:30:04] JeroenDeDauw: If you think that helps. ;-) [16:33:03] (03CR) 10Aude: "looks good overall" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) (owner: 10Lucie Kaffee) [16:38:27] 10Wikidata, 10Wikidata-Query-Service: Add date filtering to RDF export - https://phabricator.wikimedia.org/T92006#1129213 (10JanZerebecki) For the first example of only a year (check precision?) see T92009 . Another example Wikibase allows but XSD 1.1 does not is more than 60 seconds (I think Wikibase allows... [16:42:46] (03PS7) 10Lucie Kaffee: Add missing qqq messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) [16:43:54] 10Wikidata, 10Wikidata.org: create bug reports for problems reported in logstash - https://phabricator.wikimedia.org/T72550#1129223 (10JanZerebecki) 5Open>3declined [16:44:09] (03PS3) 10Jeroen De Dauw: Use Diff 2.x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197645 [16:44:13] (03CR) 10Aude: "looks good now :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197510 (https://phabricator.wikimedia.org/T90431) (owner: 10Lucie Kaffee) [16:44:42] (03Abandoned) 10Jeroen De Dauw: Use Diff 2.x [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197645 (owner: 10Jeroen De Dauw) [16:48:20] aude, Lydia_WMDE around? [16:48:36] matej_suchanek: going home soon, but yes [16:49:02] matej_suchanek: yeah [16:49:07] wasup? [16:49:11] hi [16:49:16] hey :) [16:49:30] I wanted to ask aude but pinged you too just in case [16:49:39] ok [16:50:01] is it possible that you have created the same bug report twice? T90400 and T93073? [16:50:10] very possible [16:50:18] * aude looks [16:50:40] suppose they are duplicates [16:51:23] * Lydia_WMDE hands matej_suchanek a cookie for keeping an eye on bugs [16:51:27] thanks! :) [16:52:05] if my fix for this issue is ok, then i think it can be deployed on tuesday [16:52:06] that is kinda related to my Wikidata work... I am quite trained on spotting duplicated items [16:52:14] thanks :) [16:52:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Qualifiers disappear when adding them together with creating a statement - https://phabricator.wikimedia.org/T90400#1129265 (10Lydia_Pintscher) [16:52:18] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: When entering new statement + qualifier, the qualifier is not rendered on save - https://phabricator.wikimedia.org/T93073#1129266 (10Lydia_Pintscher) [16:52:24] matej_suchanek: hehe [16:52:52] (03CR) 10Thiemo Mättig (WMDE): "I played around with alignment (that's where the misplaced text-align comes from) and decided to not change it. Right-aligned is not reall" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197121 (https://phabricator.wikimedia.org/T92431) (owner: 10Thiemo Mättig (WMDE)) [16:53:04] (03PS2) 10Thiemo Mättig (WMDE): Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197121 (https://phabricator.wikimedia.org/T92431) [16:54:11] JeroenDeDauw: Problem solved: https://gerrit.wikimedia.org/r/#/c/197647/ [16:58:02] (03PS2) 10Thiemo Mättig (WMDE): Drop rebuildAllData maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188353 [16:58:18] (03CR) 10Thiemo Mättig (WMDE): "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188353 (owner: 10Thiemo Mättig (WMDE)) [17:03:04] 10Wikidata: labels for coordinates (N, E, S, W in Property:P625) are not translatable in the various languages - https://phabricator.wikimedia.org/T93084#1129310 (10Lydia_Pintscher) [17:03:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7I18n: cardinal directions in geocoordinate datatype are not localized - https://phabricator.wikimedia.org/T51385#1129311 (10Lydia_Pintscher) [17:09:24] [13WikibaseDataModelSerialization] 15thiemowmde 04deleted 06tests at 142545d19: 02http://git.io/hl3Q [17:10:19] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06someDocs from 14d14569a to 14e40ea0f: 02http://git.io/hlsC [17:10:19] 13WikibaseDataModelSerialization/06someDocs 14e40ea0f 15Thiemo Mättig: Fix doc sections [17:11:32] [13WikibaseDataModelSerialization] 15thiemowmde closed pull request #111: Drop dead code from SnakDeserializerTest (06master...06deadCode2) 02http://git.io/NAmL [17:12:58] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Investigate tracking update mechansim for "non-standard language" views. - https://phabricator.wikimedia.org/T93066#1129339 (10daniel) Hooking into WikiPage::triggerOpportunisticLinksUpdate may not be sufficient when links updates are triggered via the job que... [17:13:58] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Investigate tracking update mechansim for "non-standard language" views. - https://phabricator.wikimedia.org/T93066#1129341 (10daniel) A simple scheme would be: * purge all tracking when the page is edited * add tracking on LinksUpdate, for the current languag... [17:28:27] (03PS1) 10Legoktm: jenkins job validation, do not submit [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/197666 [17:32:48] (03CR) 10jenkins-bot: [V: 04-1] jenkins job validation, do not submit [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/197666 (owner: 10Legoktm) [17:43:55] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1129435 (10Sushrutsg) Hi, I'm interested in working for this project idea. Could you please assign me to this... [17:46:43] (03PS1) 10JanZerebecki: Remove from example config a right that does not exist [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197673 [17:48:07] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Wikidata PageBanner extension - https://phabricator.wikimedia.org/T77925#1129464 (10NiharikaKohli) @Sushrutsg just jump in and start working on them. :) [17:51:28] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129487 (10Sumit) 3NEW [17:53:12] (03CR) 10Legoktm: "recheck" [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/197666 (owner: 10Legoktm) [17:53:21] 10Wikidata, 10MobileFrontend-Feature-requests, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129498 (10NiharikaKohli) p:5Triage>3Normal a:3Sumit [17:54:02] (03Abandoned) 10Legoktm: jenkins job validation, do not submit [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/197666 (owner: 10Legoktm) [17:54:42] [13WikibaseDataModelSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/hlXj [17:54:42] 13WikibaseDataModelSerialization/06master 14575ced2 15Jeroen De Dauw: Merge pull request #108 from wmde/deadCode... [17:56:17] 10Wikidata, 10MobileFrontend-Feature-requests, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129523 (10Sumit) [17:57:42] 10Wikidata, 10MobileFrontend-Feature-requests, 3Google-Summer-of-Code-2015: GSoC proposal for Wikivoyage PageBanner extension - https://phabricator.wikimedia.org/T93106#1129487 (10Sumit) please add your comments and feedbacks on the specifications, and help improve this :) [17:58:57] (03CR) 10Aude: "is this not fixed already in https://gerrit.wikimedia.org/r/#/c/197524/?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197673 (owner: 10JanZerebecki) [18:01:18] (03PS2) 10JanZerebecki: Remove from example config a right that does not exist [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197673 [18:01:45] (03Abandoned) 10JanZerebecki: Remove from example config a right that does not exist [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197673 (owner: 10JanZerebecki) [18:02:39] (03CR) 10Daniel Kinzler: [C: 032] "As far as I know, the standard XML import covers all we need." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188353 (owner: 10Thiemo Mättig (WMDE)) [18:02:54] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: AvailableRightsTest::testAvailableRights fails on Wikidata build - https://phabricator.wikimedia.org/T93067#1129543 (10aude) 5Open>3Resolved [18:03:19] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Investigate tracking update mechansim for "non-standard language" views. - https://phabricator.wikimedia.org/T93066#1129548 (10daniel) Make sure usage tracking works correctly when importing pages from an XML dump. [18:03:40] (03CR) 10JanZerebecki: [C: 031 V: 032] New Wikidata Build - 2015-03-18T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/197492 (owner: 10WikidataBuilder) [18:03:55] DanielK_WMDE_: do you want to +2 again on https://gerrit.wikimedia.org/r/#/c/188965/ [18:04:10] * aude got bit by php 5.3 (having $this inside closure) [18:04:10] (03CR) 10JanZerebecki: [C: 031 V: 032] New Wikidata Build - 2015-03-17T10:00:01+0000 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/197298 (owner: 10WikidataBuilder) [18:04:37] and zend tests were not run until now, for some reason [18:06:04] (03Merged) 10jenkins-bot: Drop rebuildAllData maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188353 (owner: 10Thiemo Mättig (WMDE)) [18:06:41] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Edit button in heading overlaps alias text - https://phabricator.wikimedia.org/T89956#1129562 (10aude) I think the white background is satisfactory enough as a solution to this. If we want to spend more time on my... [18:06:55] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Edit button in heading overlaps alias text - https://phabricator.wikimedia.org/T89956#1129563 (10aude) 5Open>3Resolved [18:06:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign header - https://phabricator.wikimedia.org/T75654#1129564 (10aude) [18:07:44] (03CR) 10Daniel Kinzler: [C: 031] "Looks good, but I remember the isNew logic to be a very tricky point with odd assumptions. Will check later (poke me if I don't)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190657 (https://phabricator.wikimedia.org/T85454) (owner: 10Hoo man) [18:08:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7I18n, and 2 others: wikibase-setlabeldescriptionaliases-introfull needs GENDER support and qqq documentation - https://phabricator.wikimedia.org/T90431#1129573 (10aude) 5Open>3Resolved [18:08:33] aude: linter fails :) [18:08:44] (03CR) 10Legoktm: [C: 032] Localisation updates from https://translatewiki.net. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/197622 (owner: 10L10n-bot) [18:08:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Easy, 7I18n, 3§ Wikidata-Sprint-2015-03-11: wikibase-setlabeldescriptionaliases-introfull needs GENDER support and qqq documentation - https://phabricator.wikimedia.org/T90431#1058667 (10aude) [18:09:12] (03Merged) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/197622 (owner: 10L10n-bot) [18:09:34] DanielK_WMDE_: what? [18:09:51] aude: https://integration.wikimedia.org/ci/job/mediawiki-core-phpcs-HEAD/13897/console [18:10:07] bah [18:10:07] i don't see what it's complining about. bah, whatever. [18:10:14] 10Wikidata, 10Wikidata-Query-Service: Add date filtering to RDF export - https://phabricator.wikimedia.org/T92006#1129596 (10Smalyshev) See also T92996. I think the solution for RDF would be to try and salvage dates that we can (like 1996-00-00T00:00:00Z), but just keep the ones that we can't make sense of as... [18:10:15] i'll fix it [18:10:26] (03PS2) 10Thiemo Mättig (WMDE): Split MonthNameUnlocalizer into Base and MediaWiki part [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197093 [18:12:38] is Lydia_WMDE still around? [18:12:50] aude: nope [18:13:00] ah [18:13:04] can wait until tomorrow [18:13:27] (03CR) 10jenkins-bot: [V: 04-1] Split MonthNameUnlocalizer into Base and MediaWiki part [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197093 (owner: 10Thiemo Mättig (WMDE)) [18:14:51] new [18:14:55] sites patch [18:15:36] (03CR) 10Daniel Kinzler: [C: 04-1] "Oops, I totally overlooked that $this->entityLookup is also used by resolvedMentionedEntities. Good thing you added a test for that just " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 (owner: 10Smalyshev) [18:16:37] DanielK_WMDE_: the PropertyDataTypeLookup is not ready yet, fails the tests. I'll fix it today [18:17:13] looks like I messed up something by moving it around, didn't have time yesterday to look into it [18:17:28] SMalyshev: scary that it didn't fail earlier, and i gave a +2... [18:17:54] DanielK_WMDE_: maybe something in fixme patch fixes that [18:17:55] SMalyshev: you replaced entityLookup with propertyLookup. But entityLookup is actually needed elsewhere in the class. [18:18:08] just add the propertyTypeLookup, and don't replace entityLookup. then it should work fine [18:18:18] DanielK_WMDE_: I didn't replace, I added. Unless I messed up the split and then it's wrong [18:18:52] before split it was an addition so maybe some git messup is there. I'll look into it soon [18:19:01] SMalyshev: diff says it was replaced: https://gerrit.wikimedia.org/r/#/c/197134/5/repo/includes/rdf/RdfBuilder.php [18:19:28] oops, def no what it should be :(... I'll fix it [18:20:00] ah, wait, it's in builder [18:20:18] builder accepts entityLookup from outside so in builder it's ok I think [18:20:26] no it [18:20:26] I thought it's in serializer [18:20:39] the builder needs an entityLookup [18:20:55] resolveMentionedEntities takes lookup as an arg [18:21:05] and that's the only place it needs it [18:21:08] or... well, maybe it doesn't. you could construct the stub using a PropertyTypeLookup and a LabelLookup, I guess [18:21:31] oh, you are right, i missed the arg! [18:21:47] yeah so that part is right but the test still fails I need to check why [18:21:51] though that *is* kind of strange [18:22:01] i'd prefer that to be injected [18:22:05] yeah I wondered about it too but one thing at a time [18:22:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: When entering new statement + qualifier, the qualifier is not rendered on save - https://phabricator.wikimedia.org/T93073#1129644 (10aude) p:5Triage>3High [18:22:11] sure [18:51:08] (03PS1) 10Daniel Kinzler: Introducing RdfWriterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197702 [18:52:23] (03PS2) 10Daniel Kinzler: RdfWriter: add RDR support (Turtle only) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197302 [18:54:07] (03CR) 10jenkins-bot: [V: 04-1] Introducing RdfWriterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197702 (owner: 10Daniel Kinzler) [18:55:20] (03CR) 10jenkins-bot: [V: 04-1] RdfWriter: add RDR support (Turtle only) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197302 (owner: 10Daniel Kinzler) [18:55:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7I18n: cardinal directions in geocoordinate datatype are not localized - https://phabricator.wikimedia.org/T51385#1129818 (10Romaine) >>! In T51385#577687, @bzimport wrote: > **neil** wrote: > Dutch: > > N Noord > Z Zuid > O Oost > W West This is not c... [18:56:53] Lydia_WMDE: I added info this bug ^^^ [18:57:23] thanks for merging, but pointing to the cardinal directions is not correct in at least Dutch [19:05:54] (03PS11) 10Daniel Kinzler: Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 [19:06:07] (03CR) 10jenkins-bot: [V: 04-1] Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 (owner: 10Daniel Kinzler) [19:20:27] Romaine: thanks! [19:20:35] :) [19:21:10] how do you say in German "on 30 degrees north"? [19:23:11] (03PS6) 10Smalyshev: Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 [19:26:11] japanese seems to be similar, at least the japanese wikipedia has "北緯52度22分05秒 東経4度54分01秒" (north latitude 52 degrees 22 minutes 05 seconds east longitude 4 degrees 54 minutes 01 seconds) for amsterdam [19:27:01] the problem is to be able to parse these (e.g. as input) [19:27:15] surely can be done but not as simple as just formatting these [19:27:54] (03CR) 10Smalyshev: "Daniel, seems to be OK now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 (owner: 10Smalyshev) [19:30:34] I was only thinking of having it as output, while the input is English only [19:32:06] maybe, but would be nice if when editing the format didn't change [20:04:37] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 3Google-Summer-of-Code-2015, 3Outreachy-Round-10: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1130019 (10Jdlrobson) 3NEW [20:04:49] 10Wikidata, 10MobileFrontend-Feature-requests, 10Possible-Tech-Projects, 7Easy, and 2 others: Setup WikidataPageBanner extension repository on Gerrit - https://phabricator.wikimedia.org/T93127#1130019 (10Jdlrobson) [20:35:41] (03PS9) 10Smalyshev: Addressed several FIXMEs in RDF related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 [20:39:54] 10Wikibase-JavaScript-Api, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Fix Job for running WBJSAPI QUnit tests on Jenkins - https://phabricator.wikimedia.org/T86176#1130182 (10JanZerebecki) a:5adrianheine>3JanZerebecki [20:52:33] 10Wikidata: Travis failure for mysql + hhvm due to DBConnectionError - https://phabricator.wikimedia.org/T90178#1130231 (10aude) I am not exactly sure what the problem was, but appears fixed now. https://travis-ci.org/Wikidata-lib/PropertySuggester/builds/54928122 (all passing) https://travis-ci.org/wikimedia/... [20:52:40] 10Wikidata: Travis failure for mysql + hhvm due to DBConnectionError - https://phabricator.wikimedia.org/T90178#1130232 (10aude) 5Open>3Resolved [20:53:29] sjoerddebruin: Enig idee hoe je op https://www.wikidata.org/wiki/Q2272827 aan het RKD nummertje komt? [20:54:24] Oh, ik zie het al, 40609 [21:09:41] (03PS10) 10Smalyshev: Addressed several FIXMEs in RDF related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 [21:12:27] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Investigate tracking update mechanism for "non-standard language" views. - https://phabricator.wikimedia.org/T93066#1130271 (10Rical) [21:12:54] (03PS28) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [21:13:46] (03PS2) 10Daniel Kinzler: Introducing RdfWriterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197702 [21:18:10] (03CR) 10jenkins-bot: [V: 04-1] Introducing RdfWriterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197702 (owner: 10Daniel Kinzler) [21:22:18] (03PS12) 10Daniel Kinzler: Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 [21:26:05] (03CR) 10jenkins-bot: [V: 04-1] Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 (owner: 10Daniel Kinzler) [21:26:11] orrrr. [21:26:38] (03PS11) 10Smalyshev: Addressed several FIXMEs in RDF related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 [21:27:59] (03PS3) 10Daniel Kinzler: Introducing RdfWriterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197702 [21:28:31] (03PS13) 10Daniel Kinzler: Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 [21:35:05] 10Wikidata: Look into Wikibase use of memcached to see what needs broadcasted purges - https://phabricator.wikimedia.org/T93142#1130313 (10aude) 3NEW [21:35:50] DanielK_WMDE_: https://gerrit.wikimedia.org/r/#/c/196712/ and https://gerrit.wikimedia.org/r/#/c/197134/ ready for your review [21:36:11] SMalyshev: already looking :) [21:37:19] if we merge PropertyDataTypeLookup first the second one will need small rebase but nothing drastic I imagine [21:38:45] (03CR) 10Daniel Kinzler: [C: 032] Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 (owner: 10Smalyshev) [21:38:53] we'll find out :) [21:38:58] ok [21:41:24] (03Merged) 10jenkins-bot: Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 (owner: 10Smalyshev) [21:43:10] (03PS12) 10Smalyshev: Addressed several FIXMEs in RDF related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 [21:43:33] ok, rebased [21:44:09] SMalyshev: regarding dates: can you try to find out if blasegraph conforms to xsd 1.0 or 1.1? The handling of negative years has changed between them. in xsd 1.0, the year -1 is the year 1 BCE (traditional numbering). in xsd 1.1 the year -1 is 2 BCE ("atronomical numbering"). https://en.wikipedia.org/wiki/0_%28year%29#ISO_8601 [21:44:30] DanielK_WMDE_: I can try [21:45:19] they use Java calendar I think so I assume whatever that does. But that doesn't matter too much as we'll have our own eventually [21:45:42] i.e. we will parse dates not blazegraph, and we can choose if we do 1.0 or 1.1 [21:46:06] we are currently using http://www.w3.org/2001/XMLSchema as the URI for CSD, which is xsd 1.0. [21:46:18] which matches the way wikibase handles years (-1 = !BCE) [21:46:26] err, -1 = 1 BCE [21:47:06] SMalyshev: we parse dates? in java, you mean? or how do we pass the parsed date to blazegraph? [21:47:12] final XMLGregorianCalendar c = XMLDatatypeUtil.parseCalendar(s); [21:47:31] we will have plugin that will parse dates. not right now but in the future [21:47:48] "Representation for W3C XML Schema 1.0 date/time datatypes" [21:47:51] http://docs.oracle.com/javase/7/docs/api/javax/xml/datatype/XMLGregorianCalendar.html [21:47:56] so it's all 1.0 [21:48:13] we should still be very careful about this issue, and very explicit in the docs about which convention we use [21:48:17] yes looks like it [21:48:48] but we won't use that one eventually (it can't represent -13bn BCE) so we can choose [21:49:25] i really wonder how they made such a massive breaking change in a minor revision [21:49:44] this must be causing no end of confusion [21:50:03] I guess they had some reasons, i.e. that year 0 doesn't mean anything which is weird [21:50:31] sure, the reason for the astronimical numberic in easier arithmetics [21:50:37] *numbering [21:50:48] http://www.w3.org/2001/05/xmlschema-errata#e2-63 [21:51:51] ahh, ISO-8601 changed to allow 0. so I guess that's where it comes from [21:52:52] but yeah it's a mess... [21:53:06] then again datetime handling is always a mess [21:53:14] yes, both xsd and iso changed this between 2000 and 2009. in a minor revision. [21:53:39] it's not just that they allowed 0000. they shifted the interpretation of all negative year numbers by one year! [21:53:57] better get your uris right, and make sure to verify them when importing... [21:55:04] SMalyshev: when calling addExpandedValue, shouldn [21:55:14] ...shouldn't 'time' => 'string' be 'time' => 'xsd:string'? [21:55:31] 10Wikidata, 10Analytics, 10MediaWiki-General-or-Unknown, 6Services, and 4 others: Reliable publish / subscribe event bus - https://phabricator.wikimedia.org/T84923#1130400 (10GWicke) See also: @aaron is working on a cache update service at https://github.com/AaronSchulz/python-m emcached-relay [21:56:53] DanielK_WMDE_: hmm... I just looked and it doesn't matter as addLiteral apparently doesn't accept type. For some reason I though it did [21:58:23] SMalyshev: i think it needs to go into the Literal object [21:58:25] however EasyRdf_Literal does... [21:58:28] yeah [21:58:50] well, it's fine with anything: } elseif (!is_object($value) or !$value instanceof EasyRdf_Literal) { [21:58:50] $value = EasyRdf_Literal::create($value, $lang); [21:58:50] } [21:59:04] but yeah probably better to create it [21:59:30] SMalyshev: maybe throw InvalidArgument exception there if an unknown type is passed. Looks like a good place for a hard to find bug... [22:00:12] SMalyshev: add ( spaces ) to the call, while you are at it :) [22:01:16] it will ignore unknown types and create non-typed literal [22:01:51] hmm... xsd:string does "+00000002012-02-29T00:00:00Z"^^ [22:01:58] I'm not sure that's what we want [22:06:58] (03PS13) 10Smalyshev: Addressed several FIXMEs in RDF related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 [22:09:25] huskyr: Vette dingen ben je aan het doen. :) [22:55:34] is there anything which can create a list of pages which aren't linked to wikidata for a particular language's wikipedia? [23:34:54] nikki: You might be able to get near that using autolist, but not exactly that, I guess [23:46:59] (03PS3) 10Daniel Kinzler: RdfWriter: add RDR support (Turtle only) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197302 [23:48:38] (03PS2) 10Daniel Kinzler: Performance improvements for RdfWriter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197407 [23:50:00] (03CR) 10jenkins-bot: [V: 04-1] RdfWriter: add RDR support (Turtle only) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197302 (owner: 10Daniel Kinzler)