[00:14:19] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: When I move a page in nowiki, the sitelink isn't updated automatically - https://phabricator.wikimedia.org/T92789#1120378 (10hoo) p:5Triage>3High a:3hoo [08:04:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: On Android, cannot scroll past title when other languages open - https://phabricator.wikimedia.org/T92763#1120718 (10aude) I'm sure this is indeed an issue (with position: fixed of the edit toolbar), but can't reproduced it. I have older android (4.0.4) a... [08:25:05] (03PS20) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [08:28:20] (03CR) 10jenkins-bot: [V: 04-1] Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [08:49:34] (03PS21) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [08:55:07] (03PS22) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [09:18:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: On Android, cannot scroll past title when other languages open - https://phabricator.wikimedia.org/T92763#1120768 (10Lydia_Pintscher) I can reproduce it on my phone. [09:20:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Uncaught TypeError: Cannot read property '0' of null - https://phabricator.wikimedia.org/T92737#1120770 (10Lydia_Pintscher) [09:20:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Uncaught TypeError: Cannot read property '0' of null - https://phabricator.wikimedia.org/T92737#1120773 (10Lydia_Pintscher) p:5Triage>3Normal [09:21:03] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: No property suggestions on empty items - https://phabricator.wikimedia.org/T92748#1120780 (10Lydia_Pintscher) a:3aude [09:21:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Uncaught TypeError: Cannot read property '0' of null - https://phabricator.wikimedia.org/T92737#1120784 (10Lydia_Pintscher) a:3aude [09:21:49] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Comparing Diff objects fails on certain environments - https://phabricator.wikimedia.org/T92487#1120785 (10Lydia_Pintscher) a:3thiemowmde [09:22:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Special:SetLabelDescriptionandAlias should support removing of labels, descriptions and aliases - https://phabricator.wikimedia.org/T91387#1120788 (10Lydia_Pintscher) a:3thiemowmde [09:23:43] Adrian_WMDE: Tobi_WMDE_SW: https://phabricator.wikimedia.org/T86182 is in review but i see no patch linked [09:23:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Allow list of available languages to be configurable - https://phabricator.wikimedia.org/T86182#1120797 (10Lydia_Pintscher) a:3adrianheine [09:24:22] Lydia_WMDE: Tobi_WMDE_SW asked me that question a while ago, too [09:24:27] :D [09:24:41] I'd say it's a tracking bug [09:24:44] It's not done [09:24:58] But the only thing currently in review is my proposal in the other task [09:25:31] ok then maybe we should put that in review [09:25:35] Tobi_WMDE_SW: ^ [09:25:36] ? [09:27:10] Adrian_WMDE: not sure if the proposal will recieve any more feedback. I would suggest continuing with the implementation [09:27:11] :) [09:27:26] Tobi_WMDE_SW: Thiemo_WMDE said he'd like to talk to me about it [09:27:57] Adrian_WMDE: ok, cool. I did only see jan's comment [09:28:15] (03PS1) 10Thiemo Mättig (WMDE): Introduce FormatterLabelLookupFactory::OPT_ constants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197011 [09:29:13] Lydia_WMDE: that is in review already [09:29:21] k [09:29:53] (03PS1) 10Thiemo Mättig (WMDE): Fix outdated comment in EntityIdHtmlLinkFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197012 [09:30:32] Tobi_WMDE_SW: https://phabricator.wikimedia.org/T92619 <- something we need to do or others? [09:31:04] same for https://phabricator.wikimedia.org/T92397 [09:31:34] Lydia_WMDE: first one is something to figure out for fisch and zeljko. [09:31:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Release-Engineering, 7Browser-Tests: investigate failing browsertests on jenkins - https://phabricator.wikimedia.org/T92619#1120820 (10Lydia_Pintscher) p:5Triage>3Normal [09:32:25] 10Wikidata: Browsertests for link-item widget on Wikidata-Clients - https://phabricator.wikimedia.org/T92281#1120822 (10Lydia_Pintscher) [09:32:54] since https://phabricator.wikimedia.org/T92397 seems to be a problem with our client job, it needs to be resolved by us I think [09:33:14] 10Wikidata, 10DataValues, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Make [Formatter|Parser]Options nullable/optional everywhere - https://phabricator.wikimedia.org/T92280#1120825 (10Lydia_Pintscher) p:5Unbreak!>3High [09:34:15] 10Wikidata: Port wikibase templates to Mustache - https://phabricator.wikimedia.org/T91067#1120828 (10Lydia_Pintscher) p:5Triage>3Normal [09:36:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: RdfBuilder error on trying to getLanguageCode() - https://phabricator.wikimedia.org/T90484#1120840 (10Lydia_Pintscher) 5Open>3declined a:3Lydia_Pintscher I am going to close this one. Let's figure out the rest in the other ticket. [09:37:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Upstream, 3§ Wikidata-Sprint-2015-03-11: N-Triples encoding for RDF output uses invalid escaping - https://phabricator.wikimedia.org/T76854#1120845 (10Lydia_Pintscher) Fixed? Both patches are merged. [09:38:16] (03PS1) 10Thiemo Mättig (WMDE): Make FormatterOptions nullable in lib classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197013 [09:41:17] 10Wikidata: wikidata-rdf wrong format. - https://phabricator.wikimedia.org/T88735#1120848 (10Lydia_Pintscher) Is this about the RDF dump provided by Markus Krötzsch? [09:42:04] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: Implement fast sequential RDF output generation - https://phabricator.wikimedia.org/T92523#1120851 (10Lydia_Pintscher) [09:42:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#1120850 (10Lydia_Pintscher) [09:42:36] 10Wikidata: Add test case for output of stubs for "mentioned" entities in RDF output - https://phabricator.wikimedia.org/T92522#1120853 (10Lydia_Pintscher) [09:43:02] [13DataValuesJavascript] 15thiemowmde created 06minorJsCs (+1 new commit): 02http://git.io/hJXQ [09:43:02] 13DataValuesJavascript/06minorJsCs 14125d0a0 15Thiemo Mättig: Fix minor JSCS issue [09:43:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#535638 (10Lydia_Pintscher) [09:43:35] 10Wikidata: Implement each "flavor" of RDF in a separate class. - https://phabricator.wikimedia.org/T92515#1120855 (10Lydia_Pintscher) [09:43:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#535638 (10Lydia_Pintscher) [09:43:58] 10Wikidata: Implement separate RDF generators for each value type - https://phabricator.wikimedia.org/T92517#1120857 (10Lydia_Pintscher) [09:44:18] 10Wikidata: Improve meta-data handling in RDF-Output - https://phabricator.wikimedia.org/T92521#1120860 (10Lydia_Pintscher) [09:45:54] 10Wikidata, 10Wikidata-Query-Service: Set proper decimal value precision in RDF exports - https://phabricator.wikimedia.org/T92660#1120863 (10Lydia_Pintscher) [09:45:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#535638 (10Lydia_Pintscher) [09:46:42] 10Wikidata: Add test case for output of stubs for "mentioned" entities in RDF output - https://phabricator.wikimedia.org/T92522#1120865 (10Lydia_Pintscher) p:5Triage>3Normal [09:47:11] 10Wikidata: Improve meta-data handling in RDF-Output - https://phabricator.wikimedia.org/T92521#1120869 (10Lydia_Pintscher) p:5Triage>3Normal [09:47:59] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06minorJsCs from 14125d0a0 to 145ecec87: 02http://git.io/hJMU [09:47:59] 13DataValuesJavascript/06minorJsCs 145ecec87 15Thiemo Mättig: Fix minor JSCS issue [09:48:19] [13DataValuesJavascript] 15thiemowmde opened pull request #74: Fix minor JSCS issue (06master...06minorJsCs) 02http://git.io/hJMq [09:49:39] 10Wikidata: Implement separate RDF generators for each value type - https://phabricator.wikimedia.org/T92517#1120877 (10Lydia_Pintscher) p:5Triage>3Normal [09:49:58] 10Wikidata: Implement each "flavor" of RDF in a separate class. - https://phabricator.wikimedia.org/T92515#1120879 (10Lydia_Pintscher) p:5Triage>3Normal [09:51:22] jzerebecki: https://phabricator.wikimedia.org/T76372 still relevant? [09:51:50] [13ValueView] 15adrianheine created 06bumpV (+1 new commit): 02http://git.io/hJDG [09:51:50] 13ValueView/06bumpV 14871eded 15Adrian Heine: Release 0.14.1 [09:52:17] [13ValueView] 15adrianheine opened pull request #166: Release 0.14.1 (06master...06bumpV) 02http://git.io/hJDW [09:52:21] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Make ValueView qunit tests independent of focus. - https://phabricator.wikimedia.org/T91376#1120884 (10adrianheine) https://github.com/wmde/ValueView/pull/166 [09:54:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Partial RDF dumps - https://phabricator.wikimedia.org/T46581#1120887 (10Lydia_Pintscher) I wonder if this is still worth pursuing. Is there demand for it? What are the concrete usecases it's serve? [09:58:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Tracking: Implement complete RDF mapping for entities (tracking) - https://phabricator.wikimedia.org/T50143#1120891 (10Lydia_Pintscher) [09:58:24] [13ValueView] 15tobijat 04force-pushed 06rmdisabled from 14da143c5 to 143dfc464: 02http://git.io/xMIR [09:58:24] 13ValueView/06rmdisabled 149e6217d 15snaterlicious: Removed inefficient mocking of native jQuery.Widget functionality... [09:58:24] 13ValueView/06rmdisabled 143dfc464 15Tobias Gritschacher: Updated README [09:59:27] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/hJSG [09:59:27] 13ValueView/06master 145c4ee84 15Tobi Gritschacher: Merge pull request #166 from wmde/bumpV... [09:59:37] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: split wikibase.git - https://phabricator.wikimedia.org/T75863#1120894 (10Lydia_Pintscher) a:5Wikidata-bugs>3None [10:00:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Support Redirects between Items (tracking) - https://phabricator.wikimedia.org/T68067#714755 (10Lydia_Pintscher) [10:01:38] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Usage Tracking: write API module that gives a list of pages that use a given item - https://phabricator.wikimedia.org/T66591#1120901 (10Lydia_Pintscher) p:5High>3Normal [10:02:57] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Specifiable Wikidata context for LUA debug console - https://phabricator.wikimedia.org/T65623#1120905 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher Linked ticket is fixed. I am going to assume this fixes the issue. If not please reopen. [10:03:07] [13ValueView] 15tobijat 04force-pushed 06rmdisabled from 143dfc464 to 1414a8daf: 02http://git.io/xMIR [10:03:07] 13ValueView/06rmdisabled 1431fdcdc 15snaterlicious: Removed inefficient mocking of native jQuery.Widget functionality... [10:03:07] 13ValueView/06rmdisabled 1414a8daf 15Tobias Gritschacher: Updated README [10:04:55] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3Roadmap, 7Tracking: track entity usage on client pages - https://phabricator.wikimedia.org/T49288#1120910 (10Lydia_Pintscher) [10:05:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 6Multimedia, 10Structured-Multimedia-Data, 7Tracking: user interface for structured data on Commons - https://phabricator.wikimedia.org/T76016#1120912 (10Lydia_Pintscher) [10:05:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Refactor EntityContent (tracking) - https://phabricator.wikimedia.org/T71752#1120914 (10Lydia_Pintscher) [10:06:23] (03CR) 10Tobias Gritschacher: [C: 032] Fix outdated comment in EntityIdHtmlLinkFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197012 (owner: 10Thiemo Mättig (WMDE)) [10:09:02] 10Wikidata, 10Wikidata-Quality: Check if references are missing - https://phabricator.wikimedia.org/T90136#1120918 (10Lydia_Pintscher) [10:09:12] 10Wikidata, 10Wikidata-Quality: error handling - https://phabricator.wikimedia.org/T88673#1120919 (10Lydia_Pintscher) [10:09:19] 10Wikidata, 10Wikidata-Quality: data types - https://phabricator.wikimedia.org/T88674#1120920 (10Lydia_Pintscher) [10:09:34] 10Wikidata, 10Wikidata-Quality: dumps - https://phabricator.wikimedia.org/T88677#1120921 (10Lydia_Pintscher) [10:09:51] [13ValueView] 15adrianheine tagged 060.14.1 at 06master: 02http://git.io/hJQ7 [10:09:58] (03Merged) 10jenkins-bot: Fix outdated comment in EntityIdHtmlLinkFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197012 (owner: 10Thiemo Mättig (WMDE)) [10:10:32] (03PS1) 10Adrian Lang: Also accept instances of String in mw.wbTemplate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197016 [10:12:26] (03Abandoned) 10Adrian Lang: Remove unused param from SiteLinksView::getHtmlForEditSection [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194304 (owner: 10Adrian Lang) [10:18:25] (03PS2) 10Adrian Lang: Try to set wgResourceLoaderMaxQueryLength for jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 [10:18:36] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06optionalTime from 14163d86b to 14619888b: 02http://git.io/hJ57 [10:18:36] 13DataValuesJavascript/06optionalTime 14619888b 15Thiemo Mättig: Optional hour:minute, second and timezone in TimeValue [10:19:31] wmde/DataValuesJavascript/optionalTime/619888b : Thiemo Mättig The build was broken. http://travis-ci.org/wmde/DataValuesJavascript/builds/54546680 [10:19:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Inject variationsFactory into snakview - https://phabricator.wikimedia.org/T75306#1120960 (10adrianheine) Still reasonable to do, but not holding us back in any way currently. [10:20:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Unify view-implementations in JS frontend - https://phabricator.wikimedia.org/T74666#1120961 (10adrianheine) Sorta. Henning did a great work leveling our widget implementations, but he didn't really do what I lined out here. I still think that would make s... [10:21:51] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06optionalTime from 14619888b to 146ca7c42: 02http://git.io/hJ57 [10:21:51] 13DataValuesJavascript/06optionalTime 146ca7c42 15Thiemo Mättig: Optional hour:minute, second and timezone in TimeValue [10:23:07] wmde/DataValuesJavascript/optionalTime/6ca7c42 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/DataValuesJavascript/builds/54547120 [10:24:30] (03PS3) 10Adrian Lang: Try to set wgResourceLoaderMaxQueryLength for jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 [10:24:32] (03PS1) 10Adrian Lang: Depend on ValueView 0.14.1 for QUnit via PhantomJS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197017 [10:24:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Inject variationsFactory into snakview - https://phabricator.wikimedia.org/T75306#1120970 (10Lydia_Pintscher) p:5Normal>3Low [10:31:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review: Time data-type inconsistently zero-pads year value (dates earlier than year 1000?) - https://phabricator.wikimedia.org/T66084#1120974 (10thiemowmde) ~~DataValuesJavascript/pull/59~~ is not applicable any more after h... [10:32:50] question, what is the category/{{subst:d|uject me [10:37:18] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06optionalTime from 146ca7c42 to 14c4e6ca5: 02http://git.io/hJ57 [10:37:19] 13DataValuesJavascript/06optionalTime 14c4e6ca5 15Thiemo Mättig: Optional hour:minute, second and timezone in TimeValue [10:38:06] wmde/DataValuesJavascript/optionalTime/c4e6ca5 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/DataValuesJavascript/builds/54549036 [10:38:54] [13DataValuesJavascript] 15thiemowmde 04deleted 06padding at 148186727: 02http://git.io/hJAm [10:39:04] 10Wikidata, 10Continuous-Integration, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1120994 (10adrianheine) QUnit tests passed for me for the first time in https://gerrit.wikimedia.org/r/#/c/19... [10:39:08] (03CR) 10Tobias Gritschacher: "\o/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 (owner: 10Adrian Lang) [10:39:12] 10Wikidata, 10Continuous-Integration, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1120996 (10adrianheine) [10:45:51] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06optionalTime from 14c4e6ca5 to 1489af5e5: 02http://git.io/hJ57 [10:45:51] 13DataValuesJavascript/06optionalTime 1489af5e5 15Thiemo Mättig: Optional hour:minute, second and timezone in TimeValue [11:02:15] 10Wikidata, 6Commons, 6Multimedia, 10Structured-Multimedia-Data, and 2 others: Store media information for files on Wikimedia Commons as structured data - https://phabricator.wikimedia.org/T68108#1121066 (10Steinsplitter) [11:09:11] JeroenDeDauw: http://status.pizza/420 [11:13:36] (03CR) 10Tobias Gritschacher: "I'm fine with this intermediate solution until https://gerrit.wikimedia.org/r/#/c/193130/ (https://phabricator.wikimedia.org/T90453) is re" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 (owner: 10Adrian Lang) [11:19:01] (03PS3) 10Thiemo Mättig (WMDE): Use HtmlTimeFormatter in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196635 (https://phabricator.wikimedia.org/T72086) [11:19:09] (03CR) 10jenkins-bot: [V: 04-1] Use HtmlTimeFormatter in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196635 (https://phabricator.wikimedia.org/T72086) (owner: 10Thiemo Mättig (WMDE)) [11:21:43] Adrian_WMDE: can you confirm this fix for the deployment-branch (the issue does not occur on master since the code was refactored there) https://gerrit.wikimedia.org/r/#/c/196786/ [11:22:54] Code looks very defensive. There can't really be anything wrong with it. [11:23:13] i tested it manually on the branch [11:24:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: date in claim diff formatted as timestamp - https://phabricator.wikimedia.org/T72086#1121116 (10thiemowmde) For reference (already merged): https://github.com/DataValues/Time/pull/40 [11:29:09] 10Wikidata, 10DataValues, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Remove wrong "Gregorian" display from diff views - https://phabricator.wikimedia.org/T92265#1121129 (10thiemowmde) https://github.com/DataValues/Time/pull/32 completely removes the "display calendar... [11:29:24] (03PS1) 10Adrian Lang: Introduce SpecialPageLinker [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197019 [11:29:40] [13Time] 15thiemowmde 04deleted 06gregorian at 145c2c0fd: 02http://git.io/hUtL [11:32:25] [13Time] 15adrianheine comment on pull request #49 14abfb175: What's the advantage of having this in the parser instead of the formatter? How about putting it in the value? 02http://git.io/hUt5 [11:37:09] Tobi_WMDE_SW: heh :) [11:37:37] Tobi_WMDE_SW: seen the status erros on my site yet? http://www.bn2vs.com/derpderpderp [11:39:17] [13Time] 15adrianheine comment on pull request #49 14abfb175: This code is so useless now it should just be removed. If you want to actually use another formatter, then just use it instead of constructing this formatter and passing the one you want to use in. 02http://git.io/hUmn [11:40:18] JeroenDeDauw: wheres the background music [11:43:12] [13Time] 15JeroenDeDauw closed pull request #50: Use self:: to address constants (06master...06rewrite1) 02http://git.io/p7tw [11:45:43] [13Time] 15JeroenDeDauw comment on pull request #53 143bb740e: Having named arguments is nice in that I can tell what those zero's above mean, while below it's a lot less clear. It also opens up the possibility of messing up the order. I personally prefer the current version better. 02http://git.io/hUYd [11:46:17] [13Time] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/hUYA [11:46:17] 13Time/06master 143c94fdc 15Jeroen De Dauw: Merge pull request #51 from DataValues/rewrite2... [11:51:30] [13Time] 15JeroenDeDauw comment on pull request #49 14abfb175: Good question. If the constant is needed in both, these two options seem equality arbitrary to me. It's also rather odd to have the formatter depend on the parser or the other way around. Also consider that it's not actually *the* time formatter or *the* time parser, rather *a* time formatter and *a* time parser.... 02http://git.io/hUOj [11:53:44] from an authority control, which property does one use to link back to the parent of the identifier? [12:04:38] (03CR) 10Adrian Lang: "Needs DataValues/Interfaces dependency bump to at least 1.0.5." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194112 (owner: 10Thiemo Mättig (WMDE)) [12:05:44] (03CR) 10Adrian Lang: [C: 031] Make options nullable/optional in all ValueFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194112 (owner: 10Thiemo Mättig (WMDE)) [12:07:17] 10Wikidata, 10Wikidata-Query-Service: Evaluate TinkerPop GraphSail frontend - https://phabricator.wikimedia.org/T76372#1121181 (10JanZerebecki) 5Open>3declined [12:07:40] Lydia_WMDE: no^^ [12:09:26] (03PS7) 10Adrian Lang: Deprecate getParserClass in favor of getInstance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194531 (owner: 10Thiemo Mättig (WMDE)) [12:11:10] Adrian_WMDE: https://phabricator.wikimedia.org/T92279#1113144 [12:11:35] (03CR) 10jenkins-bot: [V: 04-1] Deprecate getParserClass in favor of getInstance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194531 (owner: 10Thiemo Mättig (WMDE)) [12:32:00] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: create gadget for showing padlock on protected item pages - https://phabricator.wikimedia.org/T92384#1121226 (10Ricordisamoa) Community discussion started at https://www.wikidata.org/wiki/Wikidata:Project_chat#Protection_indicators. @aude: would you prefer that the sc... [12:35:07] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: create gadget for showing padlock on protected item pages - https://phabricator.wikimedia.org/T92384#1121227 (10aude) @Ricordisamoa I have no preference. one question with the script... It works for all namespaces. Do we want that or just for entity namespaces? I'm t... [12:55:13] Lydia_WMDE: wg Coding da Vinci: bin leider doch verhindert. [12:55:42] hoo: Suggester database update this week? :) [12:56:42] sjoerddebruin: I can start it later today, after the dump has completed... do we need to update the blacklist as well (any new deprecations I should be aware of?) [13:00:36] hoo: Yeah, that's what I mean. No blacklist changes. [13:00:42] it's a hoo :) [13:00:49] (I think) [13:01:07] \o/ [13:08:26] [13DataValuesJavascript] 15thiemowmde pushed 1 new commit to 06optionalTime: 02http://git.io/hUoz [13:08:26] 13DataValuesJavascript/06optionalTime 141b40ada 15Thiemo Mättig: Same order as everywhere [13:09:48] 10Wikidata, 10Tool-Labs: Make wbs_propertypairs table on wikidata available in tool labs - https://phabricator.wikimedia.org/T92825#1121255 (10aude) 3NEW [13:15:28] (03CR) 10Tobias Gritschacher: [C: 032] Also accept instances of String in mw.wbTemplate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197016 (owner: 10Adrian Lang) [13:18:08] (03Merged) 10jenkins-bot: Also accept instances of String in mw.wbTemplate [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197016 (owner: 10Adrian Lang) [13:21:10] (03CR) 10JanZerebecki: [C: 032] "The outcome after the next patch in the series looks good to me." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195883 (https://phabricator.wikimedia.org/T92265) (owner: 10Thiemo Mättig (WMDE)) [13:21:37] [13Time] 15thiemowmde comment on pull request #49 14abfb175: I'm fine with pretty much every solution, but this is unrelated to this patch. The two constants in TimeFormatter are not used any more in TimeFormatter with my patch. They need to be deprecated no matter what. 02http://git.io/hUPb [13:21:37] (03CR) 10JanZerebecki: "Next patch is I578e4ad33a32a68a5d35fe3a48259c5cd861755d." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195883 (https://phabricator.wikimedia.org/T92265) (owner: 10Thiemo Mättig (WMDE)) [13:21:39] 10Wikidata, 6Labs: Make wbs_propertypairs table on wikidata available in labs - https://phabricator.wikimedia.org/T92825#1121280 (10coren) p:5Triage>3Normal a:3coren [13:23:07] [13Time] 15thiemowmde comment on pull request #49 14abfb175: That's what https://gerrit.wikimedia.org/r/#/c/195883/ is about. Note that I reworked this patch completely, with that the class is useful again. 02http://git.io/hUXP [13:24:36] (03Merged) 10jenkins-bot: Drop pointless time formatter delegation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195883 (https://phabricator.wikimedia.org/T92265) (owner: 10Thiemo Mättig (WMDE)) [13:28:52] [13Time] 15thiemowmde comment on pull request #53 143bb740e: The parser tested here is not even capable of doing something with timezone, before and after other than setting it to 0. Repeating these three lines over and over again adds no information and makes the test cases very hard to read. Also note that this is only a base patch, #27 will remove the repeated zeros completely. 02http://git.io/hUDv [13:29:12] aude: Lydia_WMDE: Will we branch today / tomorrow? [13:29:54] https://www.mediawiki.org/wiki/Wikidata_deployment [13:29:56] so yes [13:30:33] Ah, nice [13:30:47] I'm going to be in the office next week, btw [13:30:51] the page needs to be filled out with what changed [13:30:52] :) [13:31:39] * aude would like review for https://gerrit.wikimedia.org/r/#/c/196786/ if it's something we care about [13:31:51] or can leave it broken for another ~week [13:33:03] aude: If you're making a new build... may I add my debug log changes for update repo? [13:33:14] sure [13:33:19] I really want that output :) [13:33:27] k [13:33:39] i'll be doing a build only if the fix is merged [13:33:51] (03CR) 10Tobias Gritschacher: [C: 031] "Hm, no rights to merge this." [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/196786 (https://phabricator.wikimedia.org/T92737) (owner: 10Aude) [13:33:56] aude: I already said that it's fine by me [13:34:00] ok [13:34:15] it's a deployment branch so apparently only me and hoo can [13:35:05] (03CR) 10Hoo man: [C: 032] Fix js error when adding new statements [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/196786 (https://phabricator.wikimedia.org/T92737) (owner: 10Aude) [13:35:09] thanks :) [13:35:34] (03PS1) 10Hoo man: Add more debug logging to UpdateRepoJob [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197036 [13:37:18] (03CR) 10Tobias Gritschacher: "That's not really needed, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197017 (owner: 10Adrian Lang) [13:37:44] Do we have (preferably localized) high level docs of WDQ? [13:38:04] * hoo knows http://wdq.wmflabs.org/api_documentation.html [13:38:45] (03CR) 10Aude: Add more debug logging to UpdateRepoJob (031 comment) [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197036 (owner: 10Hoo man) [13:38:49] (03Merged) 10jenkins-bot: Fix js error when adding new statements [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/196786 (https://phabricator.wikimedia.org/T92737) (owner: 10Aude) [13:39:03] http://wdq.wmflabs.org/api_documentation.html is best i know [13:39:10] (03CR) 10jenkins-bot: [V: 04-1] Add more debug logging to UpdateRepoJob [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197036 (owner: 10Hoo man) [13:39:11] or reading the source code [13:39:43] (03CR) 10Aude: "also should rebase on my change, where i pinned the branch to specific version of data model." [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197036 (owner: 10Hoo man) [13:39:52] (03CR) 10Tobias Gritschacher: "Can you add a comment why we add this and that it can be removed once this is done in core?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 (owner: 10Adrian Lang) [13:39:57] Oh, that's why it fails? [13:40:01] yeah [13:40:06] just rebase [13:40:06] (03PS2) 10Hoo man: Add more debug logging to UpdateRepoJob [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197036 [13:40:18] (03CR) 10Adrian Lang: "I don't think it is. I just checked the job for I7e467109532997593b3f30f82899ab781c038215 and it was already fetching 0.14.1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197017 (owner: 10Adrian Lang) [13:40:31] i don't care about the thing i commented on, but just general suggestions [13:41:02] yeah, not mixing quotes is nicer in general [13:41:40] Why does google primarily index the mobile site? [13:41:46] it does? [13:42:25] Search for wdq site:wikidata.org [13:42:36] the first two links I get are m.wikidata [13:42:38] * aude notes https://phabricator.wikimedia.org/T88475 is still an issue [13:42:53] (03PS5) 10Tobias Gritschacher: Addressed several FIXMEs in RDF related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 (owner: 10Smalyshev) [13:43:45] strange that mobile are the first results and indexed at all here [13:43:47] (03CR) 10Tobias Gritschacher: "Changed the commit message to be a bit more descriptive. Please try to use more meaningful commit messages in the future." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 (owner: 10Smalyshev) [13:44:22] (03PS4) 10Thiemo Mättig (WMDE): Use HtmlTimeFormatter in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196635 (https://phabricator.wikimedia.org/T72086) [13:45:04] (03CR) 10Aude: [C: 032] Add more debug logging to UpdateRepoJob [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197036 (owner: 10Hoo man) [13:45:35] We still don't have fatal logs :( [13:45:43] rage [13:45:54] Many update repo jobs are failing and I have no idea why [13:47:46] (03PS4) 10Adrian Lang: Set wgResourceLoaderMaxQueryLength for jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 [13:48:11] (03Merged) 10jenkins-bot: Add more debug logging to UpdateRepoJob [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197036 (owner: 10Hoo man) [13:51:02] (03Abandoned) 10Adrian Lang: Depend on ValueView 0.14.1 for QUnit via PhantomJS [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197017 (owner: 10Adrian Lang) [13:53:18] (03CR) 10Tobias Gritschacher: [C: 032] Set wgResourceLoaderMaxQueryLength for jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 (owner: 10Adrian Lang) [13:55:40] (03Merged) 10jenkins-bot: Set wgResourceLoaderMaxQueryLength for jenkins [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196241 (owner: 10Adrian Lang) [13:57:20] Lydia_WMDE: aude: hoo: regarding the fatal logs, might it help to bring this issue up in the next call? https://phabricator.wikimedia.org/T89169 [13:58:06] (03PS1) 10Thiemo Mättig (WMDE): Drop pointless time formatter delegation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197039 (https://phabricator.wikimedia.org/T92265) [13:58:18] (03CR) 10jenkins-bot: [V: 04-1] Drop pointless time formatter delegation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197039 (https://phabricator.wikimedia.org/T92265) (owner: 10Thiemo Mättig (WMDE)) [13:58:30] scrum of scrums? [13:58:47] Yes, give it a try, please [13:58:56] aude: it has been in the scrum of scrums for 3 times [13:59:04] :/ [13:59:17] seems it only works when poking people directly [13:59:45] why is wikidata not in https://www.mediawiki.org/wiki/Scrum_of_scrums/2015-03-11 ? [14:00:44] aude: we did not submit something last week.. we did the week before though it is not in the archive for some reason.. [14:00:55] hm, ok [14:01:05] i see it in https://www.mediawiki.org/wiki/Scrum_of_scrums/2015-02-25 [14:01:14] (03Abandoned) 10Thiemo Mättig (WMDE): Drop pointless time formatter delegation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197039 (https://phabricator.wikimedia.org/T92265) (owner: 10Thiemo Mättig (WMDE)) [14:01:25] If that's not resolved until Lyon, I'll bug people about it [14:01:34] like I already did in SF [14:02:23] It seems to me like scrum of scrums will actually make people not pick up something [14:02:54] :/ [14:04:06] Adrian_WMDE: I did not find this useful in the past, and we stopped attending. then people begged us to report again so we did. but my original opinion still stands [14:07:16] (03PS1) 10Thiemo Mättig (WMDE): Drop pointless time formatter delegation [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197040 (https://phabricator.wikimedia.org/T92265) [14:10:16] hmmm, there are 9 patches already for swat [14:10:45] Just add it... if they complain, we can do our own [14:10:50] yeah [14:11:03] hm... I keep noticing that when I save a statement, the value that gets saved occasionally gets cut off, I've seen it happen with both statements that are strings and statements that link to other items, and when it happens on ones which link to another item, it links to something with a shorter name, like it's saving something that was previously displayed, and I think it does actually display what I intended to save, so I [14:11:03] don't notice unless I refresh [14:12:08] is that something that anyone else has seen? :/ I've been trying to figure out when/why it happens but it just seems to happen when I'm least expecting it [14:15:59] [13Time] 15thiemowmde 04force-pushed 06redone from 148f36f27 to 141396b94: 02http://git.io/bKQt [14:15:59] 13Time/06redone 14b3f1963 15Thiemo Mättig: Major rewrite of TimeParser [14:15:59] 13Time/06redone 14b8155fd 15Thiemo Mättig: Basic range checks [14:15:59] 13Time/06redone 140c32c88 15Thiemo Mättig: More strict parsing for years <60 [14:21:24] (03CR) 10JanZerebecki: [C: 032] Use HtmlTimeFormatter in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196635 (https://phabricator.wikimedia.org/T72086) (owner: 10Thiemo Mättig (WMDE)) [14:21:52] nikki: i am not sure of your exact issue but have seen it with dates [14:23:02] going to make a bug report [14:27:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Date (and maybe other types) values cut off when saving - https://phabricator.wikimedia.org/T92831#1121390 (10aude) 3NEW [14:28:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Date (and maybe other types) values cut off when saving - https://phabricator.wikimedia.org/T92831#1121399 (10aude) in many cases, i might never reload the page or check the history, so the error could easily go unnoticed. [14:36:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Date (and maybe other types) values cut off when saving - https://phabricator.wikimedia.org/T92831#1121410 (10aude) on my dev wiki: {F95464} 5 out of 10 of these date edits got cut off. :( [14:36:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Date (and maybe other types) values cut off when saving - https://phabricator.wikimedia.org/T92831#1121411 (10aude) p:5Triage>3High [14:37:48] (03CR) 10Aude: [C: 032] Drop pointless time formatter delegation [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197040 (https://phabricator.wikimedia.org/T92265) (owner: 10Thiemo Mättig (WMDE)) [14:37:54] (03CR) 10Adrian Lang: [C: 032] snakview: Refactored drawing mechanism [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189018 (https://phabricator.wikimedia.org/T88425) (owner: 10Henning Snater) [14:41:51] (03Merged) 10jenkins-bot: Drop pointless time formatter delegation [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197040 (https://phabricator.wikimedia.org/T92265) (owner: 10Thiemo Mättig (WMDE)) [14:42:01] 10Wikidata: wikidata-rdf wrong format. - https://phabricator.wikimedia.org/T88735#1121425 (10mkroetzsch) Yes, this refers to the Wikidata Toolkit RDF exports. I have created an issue now: https://github.com/Wikidata/Wikidata-Toolkit/issues/128 As it turns out, the error is actually caused by the code that treats... [14:42:05] (03Merged) 10jenkins-bot: snakview: Refactored drawing mechanism [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189018 (https://phabricator.wikimedia.org/T88425) (owner: 10Henning Snater) [14:43:27] aude: thanks :) [14:43:50] [13WikidataBuilder] 15JanZerebecki created 06outdated (+1 new commit): 02http://git.io/hTY6 [14:43:50] 13WikidataBuilder/06outdated 140be0190 15Jan Zerebecki: Note that this repository is not used anymore [14:44:37] [13WikidataBuilder] 15JanZerebecki opened pull request #33: Note that this repository is not used anymore (06master...06outdated) 02http://git.io/hTYb [14:44:56] aude: https://github.com/wmde/WikidataBuilder/pull/33 [14:45:55] jzerebecki: thanks [14:49:24] wmde/WikidataBuilder/outdated/0be0190 : Jan Zerebecki The build passed. http://travis-ci.org/wmde/WikidataBuilder/builds/54578281 [14:52:55] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Automated Wikidata build process - https://phabricator.wikimedia.org/T90567#1121454 (10JanZerebecki) The gerrit patch now works with WikidataBuildResources instead. https://github.com/wmde/WikidataBuilder/pull/33 o... [14:53:00] [13WikidataBuilder] 15filbertkm 04deleted 06outdated at 140be0190: 02http://git.io/hTGe [14:54:33] (03PS1) 10Aude: Update Wikidata, fix js error and diff formatting [extensions/Wikidata] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197048 [14:54:42] must hurry [14:57:15] (03CR) 10JanZerebecki: [C: 031] Update Wikidata, fix js error and diff formatting [extensions/Wikidata] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197048 (owner: 10Aude) [14:57:18] now there are 10 patches [14:57:46] (03CR) 10Aude: [C: 032] Update Wikidata, fix js error and diff formatting [extensions/Wikidata] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197048 (owner: 10Aude) [14:59:03] hoo: i think i will just ask greg in a bit if we can deploy ourselves [15:00:10] (03Abandoned) 10JanZerebecki: Fix tests failing because of DataModel 2.6 [extensions/Wikibase] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/195273 (https://phabricator.wikimedia.org/T91964) (owner: 10JanZerebecki) [15:00:21] aude: Ok :) [15:04:20] (03Merged) 10jenkins-bot: Update Wikidata, fix js error and diff formatting [extensions/Wikidata] (wmf/1.25wmf19) - 10https://gerrit.wikimedia.org/r/197048 (owner: 10Aude) [15:04:40] 10Wikidata: When items are created automatically, the label from nowiki (& co) should be set in language 'nb', not 'no' - https://phabricator.wikimedia.org/T92836#1121479 (10jhsoby) 3NEW [15:04:53] (03CR) 10JanZerebecki: [C: 032] Use HtmlTimeFormatter in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196635 (https://phabricator.wikimedia.org/T72086) (owner: 10Thiemo Mättig (WMDE)) [15:06:29] 10Wikidata: wikidata-rdf wrong format. - https://phabricator.wikimedia.org/T88735#1121486 (10Lydia_Pintscher) 5Open>3declined a:3Lydia_Pintscher Thanks Markus. I am closing the ticket here then. No need to keep them both around. [15:10:27] (03Merged) 10jenkins-bot: Use HtmlTimeFormatter in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196635 (https://phabricator.wikimedia.org/T72086) (owner: 10Thiemo Mättig (WMDE)) [15:15:23] [13Time] 15thiemowmde 04force-pushed 06calParser from 14910d51e to 14cc73c35: 02http://git.io/pQgB [15:15:23] 13Time/06calParser 1495237a7 15Thiemo Mättig: Add more cases to the CalendarModelParser [15:15:23] 13Time/06calParser 14cc73c35 15Thiemo Mättig: Rewrite [15:22:58] [13DataValuesJavascript] 15thiemowmde 04force-pushed 06pad from 142c96e34 to 149bfaff2: 02http://git.io/pB4R [15:22:58] 13DataValuesJavascript/06pad 1415a1325 15Thiemo Mättig: Fix and test the TimeValue.pad() function [15:22:58] 13DataValuesJavascript/06pad 149bfaff2 15Thiemo Mättig: Test negative numbers [15:28:56] aude: I'm able to reliably reproduce it with items on https://test.wikidata.org/wiki/Q537 if I type "liberi", press down twice, then press enter twice in quick succession. that made it save it as liberi/q1020 but display it as liberia/q1021 every time I tried (the one time it picked liberia for p110 was the one time I pressed enter only once) [15:30:05] (the ones with p116 I tried typing the full name and pressing enter as soon as the result I wanted was the first in the list, it happened there too eventually on the fifth try, the first four displayed the same thing that it saved) [15:31:19] also can reproduce [15:32:45] 10Wikidata, 6Labs, 5Patch-For-Review: Make wbs_propertypairs table on wikidata available in labs - https://phabricator.wikimedia.org/T92825#1121582 (10coren) 5Open>3Resolved Done, and applied. [15:34:17] 10Wikidata, 6Labs: Make wbs_propertypairs table on wikidata available in labs - https://phabricator.wikimedia.org/T92825#1121589 (10coren) [15:35:42] not always [15:36:46] New dump is here... I'll prepare the suggester update now... will take a bit [15:37:32] ok [16:36:07] 10Wikidata, 6Labs: Make wbs_propertypairs table on wikidata available in labs - https://phabricator.wikimedia.org/T92825#1121801 (10aude) thanks @coren :) [16:44:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: allow editing of more languages in the in other languages box than the ones defined via babel boxes - https://phabricator.wikimedia.org/T92759#1121872 (10Denny) But maybe name it "More", "Even more", "All" ;) [16:50:02] (03PS23) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [16:51:25] (03Abandoned) 10Daniel Kinzler: [WIP] Implement sub-emitters for RDF output. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196591 (owner: 10Daniel Kinzler) [16:53:45] (03CR) 10jenkins-bot: [V: 04-1] Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [16:56:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: investigate solutions for items with a large number of aliases - https://phabricator.wikimedia.org/T87579#1121908 (10Denny) I am quite strongly against splitting the label and description by... [17:00:17] mhm, why do I always get "There seems to be a problem with your login session; this action has been canceled as a precaution against session hijacking. Go back to the previous page, reload that page and then try again. " message when I go to recent changes and try to open "revert edit" in a new tab... [17:01:43] probably not wd related, just wondering... [17:07:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: investigate solutions for items with a large number of aliases - https://phabricator.wikimedia.org/T87579#1121926 (10aude) I think something like traditional or traditional piped would be go... [17:08:09] Stryn: no idea... maybe legoktm knows? [17:08:11] or hoo [17:08:16] hello [17:08:26] huh? [17:08:34] is there a problem with sessions? [17:08:36] Stryn: example link? [17:08:39] not that I'm aware of... [17:08:44] hm [17:08:57] That shouldn't happen, simply put [17:09:06] https://www.wikidata.org/w/index.php?title=Special:RecentChanges&tagfilter=adding+latin+script+language+description+in+non-latin+script [17:09:18] "revert" in a new tab [17:09:33] I don't see a revert button... [17:09:42] "rollback"? [17:09:43] mhm, rollback [17:09:45] yeah [17:10:14] oh bleh, I don't have rollback anymore [17:10:19] :/ [17:10:41] I can give I think [17:11:48] Rollback only appears when you can actually rollback? :) [17:12:39] sure, in the link I gave there should be few, for example Jean Couturier (Q3171477)‎ [17:12:58] Ah yes, that one has rollback. [17:13:16] though it's not vandalism ;) [17:13:30] valid edits done by the ip [17:14:05] Mwah, Could also use "French politician" [17:14:19] (with 1813-1894 between brackets after it) [17:14:58] yeah, but if you use rollback, it will rollback few more edits too (https://www.wikidata.org/w/index.php?title=Q3171477&curid=3029427&action=history) [17:15:20] Who's that IP... [17:25:49] (03PS11) 10Smalyshev: Add RDR serializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193547 [17:27:04] DanielK_WMDE: please check out: https://gerrit.wikimedia.org/r/#/c/196712/ [17:35:02] sjoerddebruin: aude: Suggester updated :) [17:35:11] hoo: Will test it after meeting. [17:35:21] hoo: \o/ [17:46:27] what is the process for getting wikibase commits into production? How can I know when certian commit is in production? [17:47:23] SMalyshev: normally it's every 2 weeks [17:47:41] aude: when was the last one? [17:47:43] we cut a branch probably tomorrow [17:48:07] we've been somewhat stalled due to getting ui changes ready [17:48:07] so all commits up to tomorrow get into production tomorrow? [17:48:11] yes [17:48:24] cool, thanks. and the next one is in 2 weeks, right? [17:48:30] https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FWikibase [17:48:44] shows the last branches. [17:49:08] (03PS1) 10Thiemo Mättig (WMDE): Split MonthNameUnlocalizer into Base and MediaWiki part [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197093 [17:49:13] wmf19 only had select stuff (non ui) [17:49:45] SMalyshev: we make a branch tomororw, it goes to test.wikidata on wednesday [17:49:54] then to wikidata next tuesday and wikipedia next wednesday [17:50:09] aude: aha, cool, thanks. [17:50:15] and start over again the following week [17:50:16] sure [17:50:25] DanielK_WMDE: then it'd be nice to get https://gerrit.wikimedia.org/r/#/c/193547/ reviewed asap [17:50:49] if there is a critical bug, we can deploy fix anytime [17:50:52] even though it's a temp solution, at least we could test with it... [17:50:58] yeah [17:57:58] (03PS2) 10Thiemo Mättig (WMDE): Make special page input fields wide and responsive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195266 [17:58:20] (03CR) 10Thiemo Mättig (WMDE): "As discussed." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195266 (owner: 10Thiemo Mättig (WMDE)) [18:14:48] (03PS2) 10Thiemo Mättig (WMDE): Make TimeDetailsFormatter echo invalid values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194911 [18:14:50] (03PS2) 10Thiemo Mättig (WMDE): Optional +/- sign in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193811 [18:14:52] (03PS3) 10Thiemo Mättig (WMDE): Consolidate code/docs in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193806 [18:14:54] (03PS2) 10Thiemo Mättig (WMDE): Drop outdated TODO from TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194111 [18:16:28] (03PS12) 10Smalyshev: Add RDR serializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193547 [18:24:32] (03PS13) 10Smalyshev: Add RDR serializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193547 [18:28:14] (03CR) 10JanZerebecki: [C: 032] Make special page input fields wide and responsive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195266 (owner: 10Thiemo Mättig (WMDE)) [18:31:00] (03CR) 10Aude: [C: 032] Clean up ClaimDifferTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196544 (https://phabricator.wikimedia.org/T92487) (owner: 10Thiemo Mättig (WMDE)) [18:32:22] (03Merged) 10jenkins-bot: Make special page input fields wide and responsive [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195266 (owner: 10Thiemo Mättig (WMDE)) [18:37:17] (03Merged) 10jenkins-bot: Clean up ClaimDifferTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196544 (https://phabricator.wikimedia.org/T92487) (owner: 10Thiemo Mättig (WMDE)) [18:43:28] (03PS6) 10Smalyshev: FIXME fixes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 [18:44:05] (03CR) 10Smalyshev: "Tobias - sorry, I had better one but somehow it got dropped. I'll restore it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 (owner: 10Smalyshev) [18:46:02] (03PS7) 10Smalyshev: Addressed several FIXMEs in RDF related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712 [18:47:34] 10Wikidata, 10MediaWiki-Vagrant: vagrant git-update doesn't run composer update for WikidataBuildResources - https://phabricator.wikimedia.org/T92878#1122465 (10kaldari) 3NEW [18:50:58] 10Wikidata, 10MediaWiki-Vagrant: vagrant git-update doesn't run composer update for WikidataBuildResources - https://phabricator.wikimedia.org/T92878#1122475 (10aude) is this not fixed in https://phabricator.wikimedia.org/T90565 ? [18:52:00] 10Wikidata, 10MediaWiki-Vagrant: vagrant git-update doesn't run composer update for WikidataBuildResources - https://phabricator.wikimedia.org/T92878#1122481 (10kaldari) This might already be fixed by https://gerrit.wikimedia.org/r/#/c/196613/ [18:54:38] 10Wikidata, 10MediaWiki-Vagrant: vagrant git-update doesn't run composer update for WikidataBuildResources - https://phabricator.wikimedia.org/T92878#1122495 (10kaldari) 5Open>3Resolved a:3kaldari [19:16:02] (03PS1) 10Thiemo Mättig (WMDE): Use mocks in HtmlTimeFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197115 [19:18:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Rebased, restoring Daniels +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193806 (owner: 10Thiemo Mättig (WMDE)) [19:18:53] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Rebased, restoring Daniels +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193811 (owner: 10Thiemo Mättig (WMDE)) [19:19:03] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Rebased, restoring Daniels +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194111 (owner: 10Thiemo Mättig (WMDE)) [19:20:15] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Rebased, restoring Daniels +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194911 (owner: 10Thiemo Mättig (WMDE)) [19:21:50] (03Merged) 10jenkins-bot: Consolidate code/docs in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193806 (owner: 10Thiemo Mättig (WMDE)) [19:23:34] (03Merged) 10jenkins-bot: Optional +/- sign in TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193811 (owner: 10Thiemo Mättig (WMDE)) [19:24:11] (03Merged) 10jenkins-bot: Drop outdated TODO from TimeDetailsFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194111 (owner: 10Thiemo Mättig (WMDE)) [19:25:03] (03Merged) 10jenkins-bot: Make TimeDetailsFormatter echo invalid values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194911 (owner: 10Thiemo Mättig (WMDE)) [19:32:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: white gap next to wikibase-sitelinkgroupview-heading-container in site link edit mode - https://phabricator.wikimedia.org/T92431#1122655 (10thiemowmde) The removal of the `width: auto` property does that in my Fixefox: {F95538} Reason... [19:32:29] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See https://phabricator.wikimedia.org/T92431#1122655" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195986 (https://phabricator.wikimedia.org/T92431) (owner: 10Aude) [19:38:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: investigate solutions for items with a large number of aliases - https://phabricator.wikimedia.org/T87579#1122715 (10Denny) Since the top line is not directly editable anymore anyway, also a... [19:48:55] (03PS1) 10Thiemo Mättig (WMDE): Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197121 (https://phabricator.wikimedia.org/T92431) [19:49:34] (03CR) 10Thiemo Mättig (WMDE): "Alternative proposal at I92aa716." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195986 (https://phabricator.wikimedia.org/T92431) (owner: 10Aude) [20:31:51] (03PS14) 10Daniel Kinzler: Add RDR serializer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193547 (owner: 10Smalyshev) [20:32:50] (03CR) 10Daniel Kinzler: [C: 031] "Approach and implementation seem fine for a temporary hack. I want to test this manually before merging though, will do that tomorrow." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/193547 (owner: 10Smalyshev) [20:41:13] (03PS1) 10Smalyshev: Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 [20:43:58] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 (owner: 10Smalyshev) [20:44:01] (03PS2) 10Smalyshev: Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 [20:46:49] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 (owner: 10Smalyshev) [20:49:17] (03PS3) 10Smalyshev: Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 [20:52:18] (03CR) 10jenkins-bot: [V: 04-1] Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 (owner: 10Smalyshev) [20:59:33] (03PS4) 10Smalyshev: Use PropertyDataTypeLookup to look for properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 [21:05:35] (03CR) 10Smalyshev: "Daniel: I've made this patch for PropertyDataTypeLookup fixme, but it's pretty big and touches a lot, so I'm not sure if it's even worth h" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/197134 (owner: 10Smalyshev) [21:15:31] (03PS8) 10Daniel Kinzler: Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 [21:15:41] (03CR) 10jenkins-bot: [V: 04-1] Use our own RDF writer instead of EasyRdf. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196663 (owner: 10Daniel Kinzler) [21:16:46] (03PS24) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [21:17:08] 10Wikidata, 10Wikidata-Query-Service: Remove reference duplicates from RDF dump - https://phabricator.wikimedia.org/T92586#1123220 (10Smalyshev) I'll try full hash first and see how much memory it consumes. If it's anything substantial then I'll go with what @daniel proposed. [21:17:53] SMalyshev: --^^ two patches to make RdfBuilder work without EasyRdf, and hopefully a lot faster. I'd be interested in seeing how it performs in your benchmark. [21:18:29] DanielK_WMDE: are those two ready for review? [21:18:39] Needs a rebase though. And the base patch is failing due to php5.3 closures [21:19:06] SMalyshev: they are ready for a first review, they are not ready to be merged. the base patch needs more tests and documentation, and probably splitting up. [21:19:35] (03CR) 10jenkins-bot: [V: 04-1] Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [21:19:53] DanielK_WMDE: I've made a bunch of comments in earlier patch sets. [21:20:45] esp. around performance things [21:20:46] (03PS25) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [21:20:57] DanielK_WMDE: so I wonder if you wanted to address them before benchmarking [21:21:58] I have a feeling we do more quoting/checks than necessary there [21:22:15] e.g. in URLs - aren't the URLs we get from wikidata already urlencoded? [21:22:23] SMalyshev: i completely rewrote this. qnames are now always passed as two separate arguments. [21:22:33] no more string concattenation, parsing or splitting [21:22:49] aha, ok, I'll make another pass. What about encoding/quoting? [21:23:40] you mean, checking for < and > in urls, etc? [21:24:01] DanielK_WMDE: yes, and other stuff. Don't we already encode it? [21:24:02] < and > are legal in urls, arn't they? so there's no guarantee that they would not be quoted. [21:24:19] err, there is no guarantee that they would be encoded, i mean [21:24:50] SMalyshev: i omit a lot of checks, and we could omit the ones for the uris, too. optionally, perhaps [21:24:51] so wikidata doesn't encode it? Then we need a fix/test for it probably. [21:25:07] I didn't test it. Let me do a quick check [21:25:31] wikidata generates valid urls. by applying url encoding for (at least) characters that are not legal or have special meanings in urls [21:25:51] we probably do encode < and >. I don't know if we can guarantee that though [21:27:36] SMalyshev: if i read RFC 3986 correctly, URLs can contain < and > unencoded. So we need to check and escape them. [21:27:52] They are however not legal mediawiki title characters, so we are unlikely to encounter them, at least in pagelinks. [21:27:57] err, sitelinks [21:28:37] DanielK_WMDE: wikidata GUI rejects < and > in the URL value [21:29:56] also rejects < and > in title as "Bad title" [21:30:05] SMalyshev: yes. we can make the escaping optional. For a general purpose rdfwriter, it is needed, though [21:30:07] so I'm not sure if it's possible to sneak it in [21:30:15] into mediawiki, probably not. [21:30:30] but i do want the rdf writer to be re-usable. to the mechanism needs to be there [21:30:38] but we can have an optiuon to hot-wire it [21:36:53] SMalyshev: regarding utf-8 in n-triples: rdf 1.1 n-triples became a recommendation only last year. if we expose a n-triples dump, i bet several consumers will not be supporting utf8 yet. [21:37:16] n-triples dumps would be consumed by people who like to use grep and awk to process rdf dumps - that's why they prefer n-triples... [21:37:27] ok, I guess we can have an option to do it and see how costly it is [21:37:51] SMalyshev: there's a lot of loose ends and things to tune in there. [21:37:58] i first one to see whether this approach has any merrit. [21:38:32] btw, i have a pretty good idea of how to get rdr support in there nicely. shouldn't take more than a day. [21:38:58] DanielK_WMDE: ok, you can use the tests from the RDR patch :) [21:40:43] DanielK_WMDE: there's still a lot of checks in writers, e.g. in https://gerrit.wikimedia.org/r/#/c/195185/25/repo/includes/rdf/N3RdfWriterBase.php [21:40:48] do we really need them? [21:57:32] (03CR) 10Daniel Kinzler: Introduce fast RDF writer (0315 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [22:05:56] (03Draft6) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [22:06:04] (03CR) 10Daniel Kinzler: Introduce fast RDF writer (0310 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [22:06:16] (03Draft15) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [22:06:34] (03PS26) 10Daniel Kinzler: Introduce fast RDF writer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 [22:07:38] SMalyshev: we don't *really* need them, they are there for debugging the RdfWriter code itself. [22:07:47] i but them there while investigating issues [22:08:01] we can get by with nearly no checking, and just generate broken rdf. [22:08:23] i'm thinking about making a decorator that checks input, but that wouldn't replace the internal sanity checks. [22:08:56] SMalyshev: direct === comparisons should be fast enough though, right? [22:09:03] the isShorthand check is a bit annoying [22:09:16] especially the only shorthand the code currently supports is "a". [22:09:25] could just ditch that, there's the a() function after all. [22:25:33] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MediaWiki-Watchlist, 7Tracking: Wikidata watchlist integration (tracking) - https://phabricator.wikimedia.org/T90435#1123620 (10Quiddity) [22:30:55] DanielK_WMDE: === is fast. Faster than == even :) [22:31:42] DanielK_WMDE: ah, ok, for debugging is fine. We'd probably need to do a profiling pass on it and see which ones we'd need to remove [22:32:48] DanielK_WMDE: I'd just drop shorthands and have 'a' as a special case. Maybe a bit hacky but I don't think we need any other shortcuts (in fact, I'm not even sure we need 'a' that much... :) [23:02:43] (03CR) 10Smalyshev: Introduce fast RDF writer (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [23:04:15] (03CR) 10Smalyshev: Introduce fast RDF writer (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [23:16:31] (03CR) 10Smalyshev: Introduce fast RDF writer (0320 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195185 (owner: 10Daniel Kinzler) [23:28:35] (03PS8) 10Smalyshev: Addressed several FIXMEs in RDF related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196712