[01:10:30] Any dev using PhpStorm online? [04:54:12] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Track multi-lingual label usage - https://phabricator.wikimedia.org/T89002#1107278 (10Bugreporter) [04:54:13] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Schema-change: Add render_key field to wbc_entity_usage to enable per-language usage tracking - https://phabricator.wikimedia.org/T92288#1107279 (10Bugreporter) [07:00:21] [13ValueView] 15snaterlicious 04force-pushed 06rmdisabled from 14fad62c5 to 14da143c5: 02http://git.io/xMIR [07:00:21] 13ValueView/06rmdisabled 14da143c5 15snaterlicious: Removed inefficient mocking of native jQuery.Widget functionality... [07:25:25] 10Wikidata, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release4, 7Design, 3LE-Sprint-84: When creating a new page, suggest doing a translation instead - https://phabricator.wikimedia.org/T88600#1108604 (10santhosh) [07:28:27] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-DataModel, 10Wikibase-DataModel-JavaScript, and 5 others: Centralize Wikibase documentation process and assign responsibilities - https://phabricator.wikimedia.org/T92365#1108612 (10Snaterlicious) 3NEW [07:29:40] 10Wikibase-DataModel, 10Wikidata: create documentation of php data model - https://phabricator.wikimedia.org/T75604#1108628 (10Snaterlicious) I think T92365 should be solved on that. [07:35:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Documentation, 3§ Wikidata-Sprint-2015-02-25: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1108634 (10Snaterlicious) As I am not sure whether I should just go ahead an edit as to my perceptions, see also: T9... [07:43:07] YuviPanda: Wow, is WDQ autoupdating again? [07:43:15] I see 2015-03-11T07:36:49Z [07:43:20] nice [07:43:26] magnus did spend some time on it last week [07:43:28] so maybe it does? [07:43:30] <3 [07:50:21] 2015-03-11T07:47:38Z [07:50:22] <3 [08:04:36] !nyan | sjoerddebruin [08:04:36] sjoerddebruin: ~=[,,_,,]:3 [08:05:33] <3 [08:28:01] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-DataModel, 10Wikibase-DataModel-JavaScript, and 5 others: Centralize Wikibase documentation process and assign responsibilities - https://phabricator.wikimedia.org/T92365#1108679 (10Snaterlicious) [08:28:32] 10Wikibase-DataModel, 10Wikidata: RFC: Possible redesign of the EntityTermsProvider interface - https://phabricator.wikimedia.org/T87237#1108682 (10Snaterlicious) [08:30:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Create a Wikibase glossary - https://phabricator.wikimedia.org/T72763#1108685 (10Snaterlicious) [09:09:01] 10Wikidata, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release4, 7Design, 3LE-Sprint-84: When creating a new page, suggest doing a translation instead - https://phabricator.wikimedia.org/T88600#1108742 (10Arrbee) a:3Pginer-WMF [09:50:03] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #60 14baba2a2: Just a note, `to_not` can be replaced with `not_to`. I think it makes the code more readable, but it is optional. 02http://git.io/p28f [09:51:12] 10Wikidata, 10DataValues, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25: Get rid of get[Formatter|Parser]Class methods in tests - https://phabricator.wikimedia.org/T92268#1108837 (10Tobi_WMDE_SW) p:5Unbreak!>3Normal [09:54:56] Hey everyone, what's the current number of seconds you need to pause between making edits for a bot? [09:55:03] I now have it at 60 seconds per edit [10:01:18] huskyr: i would think 5 seconds per edit would be ok (some bots might go faster) [10:01:39] but keep an eye on dispatch stats (via api) and maxlag etc [10:01:46] aaah [10:02:24] overall we have ~250 edits per minute, generally [10:06:19] (03Abandoned) 10Aude: Add max-width: 65em to wikibase-statementgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195271 (owner: 10Aude) [10:14:05] (03PS1) 10Thiemo Mättig (WMDE): Rework MessageSnakFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195876 (https://phabricator.wikimedia.org/T63662) [10:17:40] (03CR) 10jenkins-bot: [V: 04-1] Rework MessageSnakFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195876 (https://phabricator.wikimedia.org/T63662) (owner: 10Thiemo Mättig (WMDE)) [10:17:46] (03PS1) 10Thiemo Mättig (WMDE): Make "unknown value" and "no value" snaks in diffs italic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195877 (https://phabricator.wikimedia.org/T63662) [10:20:18] (03CR) 10jenkins-bot: [V: 04-1] Make "unknown value" and "no value" snaks in diffs italic [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195877 (https://phabricator.wikimedia.org/T63662) (owner: 10Thiemo Mättig (WMDE)) [10:22:33] [13WikidataBrowserTests] 15WMDE-Fisch created 06ranksnak_refactor (+3 new commits): 02http://git.io/p2gQ [10:22:33] 13WikidataBrowserTests/06ranksnak_refactor 14bdf38b8 15WMDE-Fisch: refactored snaktype selector to use indexed_properties and when_visible [10:22:33] 13WikidataBrowserTests/06ranksnak_refactor 14417883e 15WMDE-Fisch: refactored rank selector to use indexed_properties and when_visible [10:22:33] 13WikidataBrowserTests/06ranksnak_refactor 14c3535aa 15WMDE-Fisch: to_not changed to not_to [10:24:56] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06new_references_T92249: 02http://git.io/p22G [10:24:56] 13WikidataBrowserTests/06new_references_T92249 14320b74b 15WMDE-Fisch: to_not changed to not_to [10:27:29] [13WikidataBrowserTests] 15WMDE-Fisch opened pull request #61: refactored snak and rank selector to wait for elements (06master...06ranksnak_refactor) 02http://git.io/p2aI [10:33:29] [13Time] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/p2Vy [10:33:29] 13Time/06master 14e0e0124 15snaterlicious: Merge pull request #40 from DataValues/timeIsoFormatter2... [10:42:32] Tobi_WMDE_SW: https://integration.wikimedia.org/ci/view/BrowserTests/view/Wikidata/job/browsertests-Wikidata-PerformanceTests-linux-firefox-sauce/performance/respondingTimeGraph?width=900&height=550&performanceReportPosition=TEST-features-performance_test.xml [10:42:38] this really doesn't look good [10:42:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Avoid formatting in italics - https://phabricator.wikimedia.org/T92370#1108879 (10aude) 3NEW [10:42:49] is this an issue with the machine or tan actual issue with the code? [10:42:56] :( [10:44:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review: "unknown value" and "no value" in diff should be italic - https://phabricator.wikimedia.org/T63662#1108887 (10aude) created T92370 for the issue of italics. (it's one of those super annoyances for me, and probably fo... [10:44:26] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06new_references_T92249: 02http://git.io/p2K8 [10:44:26] 13WikidataBrowserTests/06new_references_T92249 145c6388a 15WMDE-Fisch: refactored to wait for elements [10:44:36] Lydia_WMDE: if it stays at an high level over several builds it might indicate a problem with the code. if it's just single peaks, that's ok [10:44:58] doesn't look like a single peak anymore tbh [10:56:04] (03CR) 10Daniel Kinzler: "Please rebase on top of Ib8b74b6ec9d. That should make it easy to supply tests." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194105 (https://phabricator.wikimedia.org/T91387) (owner: 10Thiemo Mättig (WMDE)) [11:02:20] multichill: https://www.wikidata.org/w/index.php?title=Q2172922&diff=198850630&oldid=197504008 ... [11:09:37] [13Time] 15thiemowmde created 06timeFormatterCal2 (+1 new commit): 02http://git.io/p2SF [11:09:37] 13Time/06timeFormatterCal2 14b646f8c 15Thiemo Mättig: Fix outdated calendar logic in TimeFormatter [11:10:39] [13Time] 15thiemowmde opened pull request #49: Fix outdated calendar logic in TimeFormatter (06master...06timeFormatterCal2) 02http://git.io/p29o [11:17:48] (03PS1) 10Thiemo Mättig (WMDE): Stop using duplicate TimeFormatter constants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195882 [11:20:37] (03CR) 10jenkins-bot: [V: 04-1] Stop using duplicate TimeFormatter constants [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195882 (owner: 10Thiemo Mättig (WMDE)) [11:20:39] (03PS1) 10Thiemo Mättig (WMDE): Drop pointless time formatter delegation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195883 [11:23:21] (03CR) 10jenkins-bot: [V: 04-1] Drop pointless time formatter delegation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195883 (owner: 10Thiemo Mättig (WMDE)) [11:43:44] aude: thanks, i'll speed it up a little [11:44:17] aude: i thought Pywiki would automatically get the maxlag from the API, but i get errors when i don't run it with a manual timeout [11:45:20] huskyr: sure [12:01:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1108955 (10adrianheine) My proposal: # Move the existing formatting JS code into an EntityIdFormatter # Replace usage of the... [12:06:18] 10Wikidata: Write functionality tests for special pages - https://phabricator.wikimedia.org/T92374#1108956 (10daniel) 3NEW [12:08:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Dispatch via delayed job] Factor dispatch logic out of maintenance script - https://phabricator.wikimedia.org/T70380#1108964 (10Lydia_Pintscher) [12:08:10] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25: Implement hybrid mode for change dispatcher, which uses both wb_items_per_site and wb_changes_subscription. - https://phabricator.wikimedia.org/T90755#1108963 (10Lydia_Pintscher) [12:08:45] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: [Dispatch via delayed job] Factor dispatch logic out of maintenance script - https://phabricator.wikimedia.org/T70380#1108965 (10Tobi_WMDE_SW) [12:09:50] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MediaWiki-extensions-GeoData, 10Wikipedia-App-Android-App, and 4 others: GeoData should pull coordinates from Wikidata on sites with the Wikibase Client - https://phabricator.wikimedia.org/T35704#1108969 (10Tobi_WMDE_SW) [12:10:10] 10Wikidata, 3§ Wikidata-Sprint-2015-02-25: Test framework for special pages. - https://phabricator.wikimedia.org/T92375#1108970 (10daniel) 3NEW [12:10:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25: Allow list of available languages to be configurable - https://phabricator.wikimedia.org/T86182#1108979 (10Lydia_Pintscher) [12:10:27] (03PS3) 10Daniel Kinzler: Mock services for SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194516 (https://phabricator.wikimedia.org/T92375) [12:10:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Make language list injectable throughout backend - https://phabricator.wikimedia.org/T87761#1108977 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher [12:11:11] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25: Test framework for special pages. - https://phabricator.wikimedia.org/T92375#1108986 (10daniel) a:3daniel [12:12:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: UI should get list of supported languages from the backend, via dedicated resource loader module - https://phabricator.wikimedia.org/T78007#1108987 (10Tobi_WM... [12:14:17] (03CR) 10jenkins-bot: [V: 04-1] Mock services for SpecialWikibaseRepoPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194516 (https://phabricator.wikimedia.org/T92375) (owner: 10Daniel Kinzler) [12:14:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: UI should get list of supported languages from the backend, via dedicated resource loader module - https://phabricator.wikimedia.org/T78007#1108989 (10Tobi_WM... [12:18:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Feature switch for using subscription mechanism for change propagation. - https://phabricator.wikimedia.org/T88419#1108994 (10Tobi_WMDE_SW) [12:18:49] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25: Implement hybrid mode for change dispatcher, which uses both wb_items_per_site and wb_changes_subscription. - https://phabricator.wikimedia.org/T90755#1108995 (10Tobi_WMDE_SW) [12:20:07] 10Wikidata, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25: File based caching: Decide on file format - https://phabricator.wikimedia.org/T77991#1108997 (10Tobi_WMDE_SW) [12:20:08] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25: File based caching: Split of site lookup for readonly access - https://phabricator.wikimedia.org/T77990#1108998 (10Tobi_WMDE_SW) [12:20:59] (03PS2) 10Daniel Kinzler: Supply edit token when testing special pages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194960 (https://phabricator.wikimedia.org/T92375) [12:21:15] (03PS3) 10Daniel Kinzler: Supply edit token when testing special pages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194960 (https://phabricator.wikimedia.org/T92375) [12:21:31] (03PS5) 10Daniel Kinzler: Data provider for testing SpecialSetLabelDescritionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194524 [12:21:38] (03PS2) 10Daniel Kinzler: Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 [12:23:43] (03CR) 10Daniel Kinzler: "Please rebase on top of Ib8b74b6ec9d. If that passes, I'll +2." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191592 (owner: 10Thiemo Mättig (WMDE)) [12:24:22] 10Wikidata, 10Continuous-Integration, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1109009 (10Tobi_WMDE_SW) Needs release of ValueView and $wgResourceLoaderMaxQueryLength set. [12:24:41] 10Wikidata, 10Continuous-Integration, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: fix the qunit tests for wikidata: mwext-Wikibase-qunit - https://phabricator.wikimedia.org/T74184#1109011 (10Tobi_WMDE_SW) [12:24:49] (03CR) 10jenkins-bot: [V: 04-1] Supply edit token when testing special pages. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194960 (https://phabricator.wikimedia.org/T92375) (owner: 10Daniel Kinzler) [12:25:53] (03CR) 10jenkins-bot: [V: 04-1] Data provider for testing SpecialSetLabelDescritionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194524 (owner: 10Daniel Kinzler) [12:26:11] (03CR) 10jenkins-bot: [V: 04-1] Functionality test for SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194961 (owner: 10Daniel Kinzler) [12:26:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: Split entityViewInit into WikibaseRepo and WikibaseView part - https://phabricator.wikimedia.org/T87434#1109018 (10Tobi_WMDE_SW) [12:27:09] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Automated Wikidata build process - https://phabricator.wikimedia.org/T90567#1109020 (10Tobi_WMDE_SW) [12:28:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: investigate solutions for items with a large number of aliases - https://phabricator.wikimedia.org/T87579#1109024 (10Tobi_WMDE_SW) [12:29:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Implement RDF mapping for Data Types - https://phabricator.wikimedia.org/T53795#1109029 (10Tobi_WMDE_SW) [12:29:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Script for creating RDF dumps of all entities - https://phabricator.wikimedia.org/T46580#1109032 (10Tobi_WMDE_SW) [12:29:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Implement RDF mapping for Claims/Statements - https://phabricator.wikimedia.org/T50141#1109034 (10Tobi_WMDE_SW) [12:30:01] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Test framework for special pages. - https://phabricator.wikimedia.org/T92375#1109041 (10Tobi_WMDE_SW) [12:30:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Allow list of available languages to be configurable - https://phabricator.wikimedia.org/T86182#1109043 (10Tobi_WMDE_SW) [12:31:28] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25: StorageException in EditEntityActionTest::testActionForPage (edit-already-exists) and related failures - https://phabricator.wikimedia.org/T72710#1109049 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydi... [12:31:33] 10Wikidata, 10DataValues, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Remove wrong "Gregorian" display from diff views - https://phabricator.wikimedia.org/T92265#1109051 (10Tobi_WMDE_SW) [12:32:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Documentation, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1109054 (10Tobi_WMDE_SW) [12:36:05] 10Wikidata, 10Continuous-Integration, 10MediaWiki-ResourceLoader, 10MediaWiki-Vagrant, and 3 others: qunit test broken without explicitly setting $wgResourceLoaderMaxQueryLength - https://phabricator.wikimedia.org/T90453#1109063 (10Tobi_WMDE_SW) [12:36:15] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: File based caching: Split of site lookup for readonly access - https://phabricator.wikimedia.org/T77990#1109066 (10Tobi_WMDE_SW) [12:36:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Browsertests for geo value input - https://phabricator.wikimedia.org/T88543#1109067 (10Tobi_WMDE_SW) [12:36:26] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Browsertests for badge-selector - https://phabricator.wikimedia.org/T88795#1109068 (10Tobi_WMDE_SW) [12:36:31] 10Wikidata: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1109069 (10thiemowmde) I just wrote this as an email to wikimedia-de-tech. As a reference: GitHub does have two major problems: 1. It's not possible to add people for review. There is no rev... [12:36:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Smoke browsertests for statements on properties - https://phabricator.wikimedia.org/T74664#1109070 (10Tobi_WMDE_SW) [12:36:36] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Adjust browsertests for references - https://phabricator.wikimedia.org/T92249#1109071 (10Tobi_WMDE_SW) [12:38:51] 10Wikibase-JavaScript-Api, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: Fix Job for running WBJSAPI QUnit tests on Jenkins - https://phabricator.wikimedia.org/T86176#1109090 (10Tobi_WMDE_SW) [12:41:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: Special:GoToLinkedPage should support redirects - https://phabricator.wikimedia.org/T78526#1109095 (10Tobi_WMDE_SW) [12:42:39] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25: figure out and fix current state of time storage and display - https://phabricator.wikimedia.org/T88437#1109099 (10Tobi_WMDE_SW) [12:43:55] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: figure out and fix current state of time storage and display - https://phabricator.wikimedia.org/T88437#1011614 (10Tobi_WMDE_SW) [12:45:18] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See Daniels and my unanswered questions in PS1 and PS2. -1 to get your attention. Please fix or help us understand." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190680 (https://phabricator.wikimedia.org/T78526) (owner: 10Hoo man) [12:45:38] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Remove time conversion logic from JavaScript code - https://phabricator.wikimedia.org/T89243#1109106 (10Tobi_WMDE_SW) [12:46:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Performance, and 3 others: batch entity revision lookup for performance improvements - https://phabricator.wikimedia.org/T87238#1109109 (10Tobi_WMDE_SW) [12:47:19] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: Allow simultaneous editing of mainsnak and references - https://phabricator.wikimedia.org/T87759#1109114 (10Tobi_WMDE_SW) [12:47:34] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Edit button in heading overlaps alias text - https://phabricator.wikimedia.org/T89956#1109115 (10Tobi_WMDE_SW) [12:47:49] (03CR) 10JanZerebecki: [C: 04-1] "Don't merge unless we have a release branch of the state before this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190799 (https://phabricator.wikimedia.org/T87759) (owner: 10Henning Snater) [12:50:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: API function wbsetqualifier blocks frontend - https://phabricator.wikimedia.org/T89698#1109129 (10Tobi_WMDE_SW) [12:51:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: Non standard calandar model breaks JS UI - https://phabricator.wikimedia.org/T89698#1109145 (10Tobi_WMDE_SW) [12:51:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: Non standard calandar model breaks JS UI - https://phabricator.wikimedia.org/T89698#1042981 (10Tobi_WMDE_SW) p:5Unbreak!>3High [12:54:05] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 7Performance, and 2 others: Frontend JS should not re-render qualifiers and references upon load. - https://phabricator.wikimedia.org/T88425#1109170 (10Tobi_WMDE_SW) [12:59:11] 10Wikidata, 10DataValues, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: Get rid of get[Formatter|Parser]Class methods in tests - https://phabricator.wikimedia.org/T92268#1109221 (10Tobi_WMDE_SW) [13:01:15] 10Wikidata: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1109226 (10Qgil) Slightly related, we are discussing the use of Phabricator's Differential code review tool for repositories not requiring Gerrit + Jenkins' continuous integration. An ambitio... [13:07:05] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06nullIdParser from 14e96c023 to 14a5020a5: 02http://git.io/HlKjUA [13:07:06] 13WikibaseDataModel/06nullIdParser 14a5020a5 15Thiemo Mättig: More specific exception messages in DispatchingEntityIdParser [13:09:00] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06idParserExceptions from 1462ac7fd to 144a9407c: 02http://git.io/AnRG [13:09:00] 13WikibaseDataModel/06idParserExceptions 144a9407c 15Thiemo Mättig: More specific exception messages in DispatchingEntityIdParser [13:13:20] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: Investigate how to proper fix AC Gadget for qualifiers and references - https://phabricator.wikimedia.org/T92378#1109250 (10Tobi_WMDE_SW) 3NEW [13:14:15] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Schema-change, 3§ Wikidata-Sprint-2015-03-11: Add render_key field to wbc_entity_usage to enable per-language usage tracking - https://phabricator.wikimedia.org/T92288#1109257 (10Tobi_WMDE_SW) [13:15:33] [13WikibaseDataModel] 15thiemowmde created 06individualExceptions (+1 new commit): 02http://git.io/paaZ [13:15:33] 13WikibaseDataModel/06individualExceptions 140fe2b9a 15Thiemo Mättig: Individual exceptions messages in DispatchingEntityIdParser [13:15:50] 10Wikidata, 5Patch-For-Review: Values in qualifiers and references not linked by AuthorityControl Gadget - https://phabricator.wikimedia.org/T91408#1109259 (10Tobi_WMDE_SW) [13:15:51] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: Investigate how to proper fix AC Gadget for qualifiers and references - https://phabricator.wikimedia.org/T92378#1109260 (10Tobi_WMDE_SW) [13:16:26] [13WikibaseDataModel] 15thiemowmde opened pull request #404: Individual exceptions messages in DispatchingEntityIdParser (06master...06individualExceptions) 02http://git.io/paaP [13:18:37] wmde/WikibaseDataModel/individualExceptions/0fe2b9a : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/53941371 [13:22:03] just noticed that WDQ is updating from Wikidata again [13:22:03] :) [13:23:35] GerardM-: sjoerddebruin thank magnus :) [13:39:14] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06master: 02http://git.io/paX1 [13:39:14] 13WikidataBrowserTests/06master 1480b0f15 15WMDE-Fisch: minor refactoring of waiting for elements in header [13:39:37] 10Wikidata: Implement (dump) formatter for quantities with units based on URIs - https://phabricator.wikimedia.org/T92380#1109299 (10Tobi_WMDE_SW) 3NEW [13:39:49] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06constructors2 from 14b0f8447 to 14138e654: 02http://git.io/NCsR [13:39:49] 13WikibaseDataModel/06constructors2 14138e654 15Thiemo Mättig: [WIP] Rework ...List constructors [13:40:54] 10Wikidata: Implement (dump) formatter for globes based on URIs - https://phabricator.wikimedia.org/T92381#1109306 (10Tobi_WMDE_SW) 3NEW [13:41:44] Adrian_WMDE: https://phabricator.wikimedia.org/T65722 [13:41:52] 10Wikidata: Implement (dumb) formatter for globes based on URIs - https://phabricator.wikimedia.org/T92381#1109318 (10aude) [13:42:01] 10Wikidata: Implement (dumb) formatter for quantities with units based on URIs - https://phabricator.wikimedia.org/T92380#1109320 (10aude) [13:43:42] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06constructors2 from 14138e654 to 144b6cb7a: 02http://git.io/NCsR [13:43:42] 13WikibaseDataModel/06constructors2 144b6cb7a 15Thiemo Mättig: [WIP] Rework ...List constructors [13:45:43] 10Wikidata, 10Datasets-General-or-Unknown, 7Tracking: improve Wikidata dumps - https://phabricator.wikimedia.org/T88991#1109324 (10Tobi_WMDE_SW) [13:45:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Fix empty map serialization behaviour - https://phabricator.wikimedia.org/T73349#1109325 (10Tobi_WMDE_SW) [13:47:11] 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-DataModel-Serialization, 10Wikidata: Fix empty map serialization behaviour - https://phabricator.wikimedia.org/T73349#774997 (10Tobi_WMDE_SW) [13:48:16] 10Wikidata: Investigate why empty references get into Wikidata - https://phabricator.wikimedia.org/T92383#1109328 (10Tobi_WMDE_SW) 3NEW [13:48:59] [13WikibaseDataModel] 15thiemowmde opened pull request #405: Merge master into 3.0.x-dev (063.0.x-dev...06master) 02http://git.io/payL [13:52:17] [13WikibaseDataModelJavaScript] 15thiemowmde pushed 1 new commit to 06mwExt: 02http://git.io/pa9U [13:52:17] 13WikibaseDataModelJavaScript/06mwExt 141d468d4 15Thiemo Mättig: Like that? [13:57:20] 10Wikidata, 10DataValues: Namespace update - https://phabricator.wikimedia.org/T87750#1109349 (10Lucie) [13:57:23] Lydia_WMDE: task for the hackathon: show popup with URIs when clicking the item id next to the item label. [13:57:39] i think we had a ticket for this at some point, at least we discussed it a long time ago. [14:05:24] [13WikibaseDataModelJavaScript] 15thiemowmde 04deleted 06meta at 147e21206: 02http://git.io/paFC [14:08:17] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: create gadget for showing padlock on protected item pages - https://phabricator.wikimedia.org/T92384#1109405 (10Lydia_Pintscher) 3NEW a:3aude [14:08:50] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: create gadget for showing padlock on protected item pages - https://phabricator.wikimedia.org/T92384#1109405 (10Lydia_Pintscher) @aude: Can you add a link to your code? [14:09:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Tag protected items with a padlock - https://phabricator.wikimedia.org/T64554#1109415 (10Lydia_Pintscher) @Jdforrester-wmf: poke :) [14:09:40] Tobi_WMDE_SW: We didn't talk about https://phabricator.wikimedia.org/T88275 [14:09:53] Tobi_WMDE_SW: I don't know if it's realistic to tackle this before I leave [14:10:09] 10Wikidata, 3§ Wikidata-Sprint-2015-03-11: create gadget for showing padlock on protected item pages - https://phabricator.wikimedia.org/T92384#1109417 (10Lydia_Pintscher) [14:11:05] 10Wikidata: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1109418 (10thiemowmde) @Qgil, how will the "chain" aspect mentioned above work then? How to submit a patch to Phabricator that depends on an other patch that's still in review? [14:11:19] Adrian_WMDE: hm.. that was not on the list for some reason [14:11:36] I didn't put it in [14:11:46] 10Wikidata: Investigate why empty references get into Wikidata - https://phabricator.wikimedia.org/T92383#1109420 (10Lydia_Pintscher) Two recent edits that introduced empty references: * https://www.wikidata.org/w/index.php?title=Q2382164&diff=190607412&oldid=171428564 * https://www.wikidata.org/w/index.php?titl... [14:12:50] Adrian_WMDE: so, in the task, could the steps you are proposing be distinct subtasks? [14:13:21] and could it be realistic that you can finish at least some of them before you leave? [14:13:34] Yeah, sure, but it's just a rough sketch and they actually have to happen sequentially [14:13:52] I don't know, it's a lot of really great work [14:19:02] 10Wikidata: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1109434 (10Qgil) Clearly, there is no chain unless everything is either in Gerrit or in Phabricator. [14:25:10] 10Wikidata, 10MediaWiki-API: Update Wikidata for ApiResult rewrite - https://phabricator.wikimedia.org/T91073#1109461 (10Anomie) [14:30:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review: Make Wikibase Repo work with a custom File collection, not only Wikimedia Commons - https://phabricator.wikimedia.org/T90492#1109472 (10adrianheine) On a general note, I think it makes more sense to be much more flexible about this. I... [14:39:58] 10Wikidata: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1109504 (10thiemowmde) Erm, not what I meant. Will Phabricator support chains of patches and if it does, how? [14:42:28] 10Wikidata: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1109505 (10Qgil) ^^^^ @mmodell, @chasemp, please check the question above. [14:42:40] 10Wikidata, 10Code-Review: move git repositories that are dependencies of wikidata to gerrit - https://phabricator.wikimedia.org/T74907#1109507 (10Qgil) [15:08:42] Lydia_WMDE: https://phabricator.wikimedia.org/F81638 [15:11:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: misleading placeholder text in header - https://phabricator.wikimedia.org/T92386#1109579 (10Lydia_Pintscher) 3NEW [15:17:02] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Maintenance script to update a client wiki's subscriptions based on the usage tracking table. - https://phabricator.wikimedia.org/T90756#1109593 (10Tobi_WMDE_SW) [15:17:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: expand in other languages box by default - https://phabricator.wikimedia.org/T92387#1109594 (10Lydia_Pintscher) 3NEW [15:18:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Special:SetLabelDescriptionandAlias should support removing of labels, descriptions and aliases - https://phabricator.wikimedia.org/T91387#1109602 (10Tobi_WMDE_SW) [15:20:21] Lydia_WMDE: Forgot about https://phabricator.wikimedia.org/T89094? (regarding https://phabricator.wikimedia.org/T92383) [15:20:48] sjoerddebruin: uhhhh thanks. i did indeed! [15:21:02] let me look into it more and clean up [15:22:55] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer: Store the badges of sitelinks in a queryable format - https://phabricator.wikimedia.org/T72229#1109613 (10aude) I don't think there is good solution to this other than have the badges in a database table. We have two options: 1) schema... [15:23:04] 10Wikidata: Investigate why empty references get into Wikidata - https://phabricator.wikimedia.org/T92383#1109614 (10Lydia_Pintscher) @sjoerddebruin lists some possible steps in T89094. Please test those as a start. [15:24:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Specific workflow makes it possible to add empty references - https://phabricator.wikimedia.org/T89094#1027342 (10Lydia_Pintscher) [15:27:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Need-volunteer, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-03-11: Wikidata edits do not update "page watched" icon - https://phabricator.wikimedia.org/T87640#1109627 (10Lydia_Pintscher) [15:27:50] What's up with grrit? [15:28:37] Tobi_WMDE_SW: another one for the board: https://phabricator.wikimedia.org/T87640 [15:38:18] [13WikidataBrowserTests] 15thiemowmde comment on pull request #57 145482fca: "should be show" is no proper English, I think. 02http://git.io/pVPl [15:46:05] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06badges_T88795: 02http://git.io/pVDh [15:46:05] 13WikidataBrowserTests/06badges_T88795 14b17c7a6 15WMDE-Fisch: fixed grammar [15:47:53] [13WikidataBrowserTests] 15thiemowmde comment on pull request #58 146094b9b: Why do the last 2 tests need login but the others do not? 02http://git.io/pVyp [15:49:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: expand in other languages box by default - https://phabricator.wikimedia.org/T92387#1109668 (10Snaterlicious) The reason for opening this ticket is not specified in the sense of that the ticket would not have been opened unless there was not already an opi... [15:51:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: entitytermsview edit toolbar should not stick to the header-row of the "other languages" box - https://phabricator.wikimedia.org/T92390#1109670 (10aude) 3NEW [15:51:44] <64MACAS0A> [13WikidataBrowserTests] 15thiemowmde closed pull request #59: smoke tests for statements on properties T74664 (06master...06prop_statements_T74664) 02http://git.io/p4AQ [15:51:44] <16WAAFE41> [13WikidataBrowserTests] 15thiemowmde 04deleted 06prop_statements_T74664 at 14cf142e9: 02http://git.io/pVH3 [15:54:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: entitytermsview edit toolbar should not stick to the header-row of the "other languages" box - https://phabricator.wikimedia.org/T92390#1109683 (10aude) propose something like this: {F81872} [15:54:37] [13WikidataBrowserTests] 15thiemowmde comment on pull request #61 14c3535aa: This doesn't make much sense when reading it out aloud. "When it's not present it should not be present". This sounds like these lines will never do anything. 02http://git.io/pVFc [15:56:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: entitytermsview edit toolbar should not stick to the header-row of the "other languages" box - https://phabricator.wikimedia.org/T92390#1109684 (10aude) the edit toolbar for entitytermsview could also have a white or white / semi-transparent background, to... [15:57:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign header - https://phabricator.wikimedia.org/T75654#1109687 (10Lydia_Pintscher) [15:57:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: entitytermsview edit toolbar should not stick to the header-row of the "other languages" box - https://phabricator.wikimedia.org/T92390#1109688 (10Lydia_Pintscher) [15:57:43] [13WikidataBrowserTests] 15WMDE-Fisch comment on pull request #58 146094b9b: because changing a statement of that type is considered "harmfull" on beta 02http://git.io/pVAV [16:00:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: expand in other languages box by default - https://phabricator.wikimedia.org/T92387#1109693 (10thiemowmde) In general, nothing should be hidden by default. There will always be a major percentage of users that miss collapsed stuff, no matter how obvious th... [16:01:43] [13WikidataBrowserTests] 15thiemowmde comment on pull request #58 146094b9b: The spam protection going nuts? Ah dang... 02http://git.io/pVhe [16:02:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: expand in other languages box by default - https://phabricator.wikimedia.org/T92387#1109697 (10Lydia_Pintscher) Yes I do have an opinion but I want to get input before we make a final decision. That's why this ticket. [16:03:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: expand in other languages box by default - https://phabricator.wikimedia.org/T92387#1109700 (10Sjoerddebruin) Open by default, please. [16:05:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Documentation, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: update documentation of high-level data model - https://phabricator.wikimedia.org/T75603#1109704 (10JanZerebecki) Yes, please be bold! [16:06:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: allow statements on properties - https://phabricator.wikimedia.org/T51554#1109714 (10thiemowmde) [16:06:47] 10Wikidata, 7Tracking: Wikidata Browsertests (tracking) - https://phabricator.wikimedia.org/T88541#1109713 (10thiemowmde) [16:06:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Smoke browsertests for statements on properties - https://phabricator.wikimedia.org/T74664#1109711 (10thiemowmde) 5Open>3Resolved [16:06:50] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 7Tracking: Wikidata watchlist integration (tracking) - https://phabricator.wikimedia.org/T90435#1109716 (10Lydia_Pintscher) We're collecting input on this topic at https://www.wikidata.org/wiki/Wikidata:Watchlist_integration_improvement_input [16:07:22] 10Wikibase-JavaScript-Api, 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-03, and 2 others: Fix Job for running WBJSAPI QUnit tests on Jenkins - https://phabricator.wikimedia.org/T86176#1109722 (10Krinkle) [16:07:24] 10Wikibase-DataModel-JavaScript, 10Wikidata, 10Librarization, 10MediaWiki-Vendor: Add data-values/javascript 0.6.0 to mediawiki/vendor - https://phabricator.wikimedia.org/T88436#1109724 (10Krinkle) [16:09:08] [13WikidataBrowserTests] 15WMDE-Fisch comment on pull request #61 14c3535aa: Yeah you should not read it aloud. But that its definitely make clear what you assert at that point. You expect something to not be present.... 02http://git.io/pwfO [16:11:25] (03PS1) 10Aude: Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 [16:14:43] (03CR) 10jenkins-bot: [V: 04-1] Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [16:22:52] (03PS2) 10Aude: Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 [16:24:54] (03PS1) 10Thiemo Mättig (WMDE): Make "in more languages" box toggle faaast [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195944 [16:25:46] (03CR) 10jenkins-bot: [V: 04-1] Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [16:26:55] (03PS3) 10Aude: Width adjustments in entityview css [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 [16:27:02] [13WikidataBrowserTests] 15thiemowmde comment on pull request #61 14c3535aa: When explained that way it makes sense. Thanks. 02http://git.io/pwqV [16:28:09] (03CR) 10jenkins-bot: [V: 04-1] Make "in more languages" box toggle faaast [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195944 (owner: 10Thiemo Mättig (WMDE)) [16:29:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: expand in other languages box by default - https://phabricator.wikimedia.org/T92387#1109774 (10Snaterlicious) I do not have a strict opinion on that matter yet. But, hm, sorry guys, those two comments above are not really helpful to get one. :-/ [16:30:47] (03CR) 10jenkins-bot: [V: 04-1] Width adjustments in entityview css [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [16:33:16] (03PS4) 10Aude: Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 [16:34:39] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove width from .wikibase-sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194317 (https://phabricator.wikimedia.org/T91501) (owner: 10Aude) [16:36:05] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I don't think just adding a padding is a good solution. This makes the situation better in some but worse in other situations." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192459 (https://phabricator.wikimedia.org/T89956) (owner: 10Aude) [16:36:34] (03CR) 10jenkins-bot: [V: 04-1] Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [16:37:07] (03Abandoned) 10Aude: Fix overlap of edit button and aliases text [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192459 (https://phabricator.wikimedia.org/T89956) (owner: 10Aude) [16:37:55] (03CR) 10jenkins-bot: [V: 04-1] Remove width from .wikibase-sitelinkgrouplistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194317 (https://phabricator.wikimedia.org/T91501) (owner: 10Aude) [16:49:13] (03PS1) 10Thiemo Mättig (WMDE): Add white background to overlapping edit buttons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195951 (https://phabricator.wikimedia.org/T89956) [16:49:28] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Call to undefined method Mock_JobQueueRedis_d05ceecc::delayedJobsEnabled() - https://phabricator.wikimedia.org/T92395#1109841 (10aude) 3NEW [16:52:29] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "In conjunction with I1cfea11 I do like this very much." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [16:52:56] (03CR) 10jenkins-bot: [V: 04-1] Add white background to overlapping edit buttons [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195951 (https://phabricator.wikimedia.org/T89956) (owner: 10Thiemo Mättig (WMDE)) [16:54:51] (03CR) 10jenkins-bot: [V: 04-1] Width adjustments in entityview css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195939 (owner: 10Aude) [17:06:52] aude: https://gerrit.wikimedia.org/r/#/c/195773/1/includes/jobqueue/JobQueue.php [17:07:22] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Almost +2, but some questions. -1 to get your attention." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194533 (owner: 10Adrian Lang) [17:09:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: entitytermsview edit toolbar should not stick to the header-row of the "other languages" box - https://phabricator.wikimedia.org/T92390#1109934 (10thiemowmde) White background patch is at https://gerrit.wikimedia.org/r/#/c/195951/, tracked at T89956. [17:10:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: expand in other languages box by default - https://phabricator.wikimedia.org/T92387#1109944 (10thiemowmde) What are you missing in my comment? [17:15:13] DanielK_WMDE_: WikidataBuild/extensions/Wikibase/client/tests/phpunit/includes/UpdateRepo [17:15:20] UpdateRepoOnDeleteTest.phpUpdateRepoOnMoveTest.php [17:15:42] DanielK_WMDE_: ^ [17:15:47] those are in client [17:17:07] updateRepoOnDeleteJobTest vs updateRepoOnDeleteTest. yay [17:25:58] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Call to undefined method Mock_JobQueueRedis_d05ceecc::delayedJobsEnabled() - https://phabricator.wikimedia.org/T92395#1110065 (10aude) https://gerrit.wikimedia.org/r/#/c/195953/ (reverted the core change, at least for now) [17:26:06] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Call to undefined method Mock_JobQueueRedis_d05ceecc::delayedJobsEnabled() - https://phabricator.wikimedia.org/T92395#1110068 (10aude) 5Open>3Resolved [17:26:18] (03PS1) 10Daniel Kinzler: Don't call JobQueue::delayedJobsEnabled [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 [17:29:54] (03CR) 10Hoo man: "Core change has been reverted (https://gerrit.wikimedia.org/r/195953), thus this will break on MySQL job queues. Despite of that it looks " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 (owner: 10Daniel Kinzler) [17:30:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Call to undefined method Mock_JobQueueRedis_d05ceecc::delayedJobsEnabled() - https://phabricator.wikimedia.org/T92395#1110113 (10daniel) Patch fixing the issue on the Wikidata side, so the core patch can be re-applied: https://gerrit.wikimedia.org/r/#/c/195958/ [17:30:45] (03CR) 10JanZerebecki: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195914 (https://phabricator.wikimedia.org/T87640) (owner: 10Thiemo Mättig (WMDE)) [17:31:48] (03CR) 10Daniel Kinzler: "@hoo: break how? As far as I can tell, the delay param will just be ignored on MySQL, no harm done. Am I missing something?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 (owner: 10Daniel Kinzler) [17:33:58] (03CR) 10Hoo man: "No, an exception will be thrown, see includes/jobqueue/JobQueue.php:78 (on master) ... that's why we had this stupid check initially :(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 (owner: 10Daniel Kinzler) [17:35:22] (03CR) 10Daniel Kinzler: "Core patch that would allow us to again check if delayed jobs are supported: I4f49ebc60a58" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 (owner: 10Daniel Kinzler) [17:35:36] (03CR) 10Hoo man: "includes/jobqueue/JobQueue.php:331 is the point that will throw, sorry." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 (owner: 10Daniel Kinzler) [17:36:38] hello -- looking at https://en.wikipedia.org/wiki/United_States [17:36:50] DanielK_WMDE_: Can't we just remove the damn exception from master and remove the method later on? [17:37:07] and the currency link uses the #property syntax. {{#property:p38}} [17:37:17] What does the "p38" reference? [17:37:24] These changes are very disruptive, as we can only support one, not both (without using is_callable or weird stuff like that) [17:38:01] MediaWiki master, I mean [17:38:58] hoo|busy: we could, if i could find it... [17:39:22] are you sure core still thjrows an exception in the latest version? I see no access to the jobReleaseTimestamp param anywhere [17:39:50] https://gerrit.wikimedia.org/r/195953 [17:39:54] let me check out master myself [17:41:26] hoo|busy: ok, i see it now. ide doesn't find it because of a botched type hint [17:41:44] Receiving objects: 82% (1755/2133), 2.13 MiB | 54.00 KiB/s [17:42:01] connectivity is just awful :S [17:43:19] (03CR) 10Daniel Kinzler: [C: 04-2] "JobQueue::batchPush fails if jobReleaseTimestamp is set but delayed jobs are not supported. So we need I4f49ebc60a58 to fix this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 (owner: 10Daniel Kinzler) [17:43:52] hoo|busy: try aude's hack? https://www.mediawiki.org/wiki/Gerrit/Advanced_usage#ssh_proxy_to_gerrit [17:45:25] Yeah, that's something I should consider... could either use a production server in amsterdam for that (hooft, but evil) or my own vserver in Amsterdam which should be well connected [17:57:35] hsolbrig: it is the property id on wikidata: https://www.wikidata.org/wiki/Property:P36 [17:58:31] [[{{#property:p38}}]] [17:58:37] that's not how you're supposed to sue them [17:58:45] they return labels, not page titles [17:58:56] yeah [18:00:11] SMalyshev: hey. I'm just finishing up the review for the RDF patch. I'd prefer the dump script changes to be in a separate patch. [18:00:48] before messing with the dump script, I want to be sure we don't break the dump process. I don't see anything that would cause this, but still, it would be nice to be able to test this carefully, without blocking the rest of the üpatch [18:01:43] there are some things to discuss wrt the changes to the dump code anyway. [18:03:48] (03PS3) 10Daniel Kinzler: Fixmes and cleanup for the rdf-export patch. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195642 [18:04:12] Lydia_WMDE: Thanks. (P38, by the way, but not obvious). We're having problems pulling currency from dbpedia as that form isn't being rendered correctly. At least now we know where to go... [18:04:18] (03CR) 10JanZerebecki: [C: 032] Fix wrong parameter order in entityViewInit.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195914 (https://phabricator.wikimedia.org/T87640) (owner: 10Thiemo Mättig (WMDE)) [18:04:21] (03CR) 10Aaron Schulz: [C: 04-1] "The core method should be added back (as a wrapper) since it has callers, so this patch shouldn't be needed when that's done. That was jus" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 (owner: 10Daniel Kinzler) [18:04:53] DanielK_WMDE_: dumpJson.php --wiki wikidatawiki --shard $i --sharding-factor $shards --snippet 2>> /var/log/wikidatadump/dumpwikidatajson-$filename-$i.log | gzip > $tempDir/wikidataJson.$i.gz [18:04:57] (03CR) 10JanZerebecki: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195916 (https://phabricator.wikimedia.org/T87640) (owner: 10Thiemo Mättig (WMDE)) [18:05:06] that's the command line we use in production... it has to persist [18:05:38] $i is the shard number (0-3), $shards is 4 [18:05:53] (03CR) 10Aaron Schulz: "See https://gerrit.wikimedia.org/r/#/c/195966/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195958 (owner: 10Daniel Kinzler) [18:06:04] (03CR) 10Daniel Kinzler: "For reference, the command line we use to generate JSON dumps: dumpJson.php --wiki wikidatawiki --shard $i --sharding-factor $shards --sni" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (https://phabricator.wikimedia.org/T53795) (owner: 10Smalyshev) [18:09:33] (03Merged) 10jenkins-bot: Fix wrong parameter order in entityViewInit.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195914 (https://phabricator.wikimedia.org/T87640) (owner: 10Thiemo Mättig (WMDE)) [18:13:56] [13WikidataBrowserTests] 15tobijat 04deleted 06badges_T88795 at 14b17c7a6: 02http://git.io/prnU [18:14:17] 10Wikidata, 7Tracking: Wikidata Browsertests (tracking) - https://phabricator.wikimedia.org/T88541#1110325 (10Tobi_WMDE_SW) [18:14:18] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Browsertests for badge-selector - https://phabricator.wikimedia.org/T88795#1110324 (10Tobi_WMDE_SW) 5Open>3Resolved [18:14:18] (03CR) 10Daniel Kinzler: [C: 04-1] "Some small issues, see inline comments." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (https://phabricator.wikimedia.org/T53795) (owner: 10Smalyshev) [18:15:47] (03CR) 10Daniel Kinzler: "Looks fine, needs conversion to use data-driven test" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192504 (owner: 10Smalyshev) [18:16:13] (03CR) 10Daniel Kinzler: "Looks good, +2 once the base patch is in." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194750 (owner: 10Smalyshev) [18:17:41] (03CR) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 (https://phabricator.wikimedia.org/T53795) (owner: 10Smalyshev) [18:18:25] DanielK_WMDE_: I'll fix the phpdoc, as for flavor default we've explicitly wanted not to change the default until we're done with zeroing in on formats, to avoid confusing people [18:19:19] SMalyshev: yes, the default behavior should be the same. I just don't like to use "null" for the default. [18:19:52] it's not like there is no flavor. The default flavor should be the actual default in the method declaration. [18:19:57] and i thought the default is "simple". [18:20:02] DanielK_WMDE_: why not? what's wrong with null? it's an ideal default since it doesn't have any pre-attached meaning and literally means "no value", which is exactly what the default is [18:20:20] DanielK_WMDE_: no, simple is one of the formats - RdfProducer::PRODUCE_TRUTHY_STATEMENTS | RdfProducer::PRODUCE_SITELINKS | RdfProducer::PRODUCE_VERSION_INFO [18:20:40] is it? I'm confused. how woudl you explicitly request that flavor via a command line option or request param, then? [18:21:07] DanielK_WMDE_: you can't ask for flavor from command line, not yet. From web, it's ?flavor=simple [18:21:07] or is it that the default doesn't have a name you could use to explicitly request it? [18:21:22] SMalyshev: but you said simple!=default [18:21:36] so... the current default doesn't have a name? that seems odd and confusing. [18:21:39] all modes should have a name [18:21:39] DanielK_WMDE_: yes, the default doesn't have a name now, so it's what happens when no flavor is given [18:21:59] so what happens if you give no flavor? [18:22:44] it would use the default. which would be defined as a string. and it would be substituted for "nothing" close to request/cli handling [18:23:15] wikimedia/mediawiki-extensions-Wikibase/master/87fa276 : Thiemo Mättig The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/53985625 [18:23:42] note that $request->getVal("flavor") returns null when there's no flavor given. So instead of just using that, I'd have to invent some flavor I don't need and hardcode it in $request->getVal("flavor") call. I'm not sure it's a good option [18:24:03] (03CR) 10Daniel Kinzler: "Looks good, needs conversion to data driven tests" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/192879 (owner: 10Smalyshev) [18:24:41] I'm not sure I understand what's the problem with null and why "null" would be better [18:24:53] no, "null" wouldn't be better. [18:25:01] "default" or "simple" or somethign would be better than null [18:25:02] so why change it then? [18:25:12] simple is a *different* format [18:25:37] and I'm not sure why "default" is better still [18:26:02] except for adding more code, it doesn't actually change anything [18:26:55] we already have a perfect value meaning "no value given", our API is already returning it - why not just use it? [18:27:13] SMalyshev: because requiering a non-empty string everywhere is better than allowing "string or null" everywhere, and then special-casing null. [18:28:05] in the current code, the null-case is somewhat hidden. from looking at getFlavor(), it's not obvious it even exists. [18:28:11] DanielK_WMDE_: I'm not sure what you mean "everywhere", but we're not requiring it anywhere for $flavor and we're special-casing every known format anyway, that's kind of the point [18:28:19] each format is a different case. [18:28:31] except the current default [18:28:49] changing it to "default" won't change anything - you'd just have a special case for "default", how that's different? [18:28:55] that's not an explicit case, it's handled by the "whatever, somethign went wron" fall-through [18:29:06] it's not obvious if this is an expected option, or what [18:29:26] well, I can add a special case, but then I don't see what you'd do in all other cases [18:29:49] I'd prefer to return the same as default, at least for now [18:29:49] in what other cases? [18:29:56] ?flavor=hypopotamus [18:30:03] that should cause an error [18:30:13] fail fast, be safe. no guessing. [18:30:27] should it? it doesn't right now [18:30:45] true, because the parameter isn't known at all [18:30:56] and unsupported url params generally get ignored. [18:31:04] https://www.wikidata.org/wiki/Special:EntityData/Q30.json?flavor=hypopotamus try it [18:31:13] i know it's ignored :) [18:31:24] so if unsupported params are ignored, why don't we keep ignoring them? [18:31:57] because flavor has a known set of valid values. [18:32:23] yes, but we can also proceed without it, so one of the valid values is no value [18:33:29] it seems much nicer and easier to understand to have an explicitly named mode that acts as a default [18:34:24] I don't know it's much easier for me to understand that null means no value than that some arbitrary string means no value [18:34:34] after all, null exists for this sole reason [18:35:38] it doesn't mean no value [18:35:59] but it does. that's what getVal API returns [18:36:01] but "no mode" or "no flavor" doesn't make sense. the output is always in some mode/flavor. [18:36:21] yes, output is. But input data isn't [18:36:48] that's what getFlavor function is doing - converting input (which may or may not have flavor) into output mode (which always has value) [18:36:50] getVal has a second argument for this purpose... [18:37:29] DanielK_WMDE_: right. And if we put a value there we couple that code to the innards of the serializer which must react to that value [18:37:55] while null is universally accepted "no value" thing that creates very little coupling [18:38:20] SMalyshev: ok, now we are discussion who should control what the default behavior should be. [18:38:57] DanielK_WMDE_: well, if you have a call $request->getVal("flavor") either it returns null or you change it to return not null. there's no third way [18:39:14] so that string value has to be conjured from somewhere by some code [18:39:31] the only thing we can get for free from getVal is null [18:39:50] yes. i generally prefer this to be as far up the stack / close the the user as possible, since sensible defaults tend to depend on the use case. [18:40:04] #but you are right that this introduces a coupling in this case [18:40:07] so if we want to translate null->"default" it has to be done somewhere. which creates coupling [18:40:17] since the request handling is generic for all formats, but the flavors are not [18:40:58] (03PS29) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 [18:41:15] so I made a patch with fixed phpdoc and added exception for unknown flavor [18:41:36] SMalyshev: this is a relatively minor issue. It points to a bigger issue, though: are flavors specific to a generator/serializer, or are they generic? [18:42:25] DanielK_WMDE_: well, that's a pretty deep question. Let's say right now they are the same for all RDF formats, but JSON format doesn't have them [18:42:49] or XML. Or any of the other API-based formats. [18:43:10] SMalyshev: https://www.wikidata.org/wiki/Special:EntityData/Q42.xml [18:43:16] right. Fortunately the code in getSerializedData() has a branch between RDF and API formats [18:43:40] yea, not very pretty [18:43:42] see around line 365 in EntityDataSerializer.php [18:43:55] well, it's how it was before, I didn't change it [18:44:37] we could pass in the whole request object and let the serializers figure it out, but that'd probably be a bigger refactoring [18:45:06] i know, i wrote that code, and it's not very pretty :) [18:45:07] we may still have to do it if we'd have more options, but for now we only have one [18:45:49] no that would couple the serializer to user i/o handling. that would be very nasty [18:46:26] you'd have to use a FauxRequest for CLI mode, etc... ugh. [18:47:28] SMalyshev: as i said, it'S a pretty minor issue; i have come to avoid nullable and magic defaults, and try to have them in as few places as possible. [18:48:18] i'd liek the handling of the "default" case to be mroe visible. and disallowing illegal values would be nice to avoid confusion introduces by typos, etc [18:48:27] but it's nothing this patch needs to be blocked on [18:48:47] splitting off the changes to the dump logic is much more important [18:50:07] so what you want me to do with the dump? [18:50:42] In this patch? Nothing. Don't touch JsonGenerator or dumpJson. [18:50:42] just restore the old one? [18:50:49] yea. [18:50:55] ok, I can create a separate one for that I guess [18:50:59] just put the changes to the dump logic into a separate patch [18:51:10] I'm not sure how gerrit would stomach it [18:51:19] should be easy, since the changes are in different files [18:51:32] not a problem, i have done this kind of thing often [18:51:57] DanielK_WMDE_: yes, but sequence of patches may be disrupted [18:52:02] I'll try and see [18:52:43] changes further down the chain will just be marked as depending on an obsolete version of teh base change. can be fixed by clicking the "rebase" button [18:52:55] no need to add the patch with the dump stuff to the chain [18:53:00] can be stand-alone. [18:53:28] (03PS30) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 [18:53:48] if you want to splice it into the chain, you'd need to re-based the next one manually. [18:54:08] anyway, i have to leave now. will be back online in an hour or so. [18:55:24] (03PS1) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 [18:55:30] ok [18:56:19] (03PS31) 10Smalyshev: Implement RDF export for items and RDF dumps (Turtle only for now) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/191393 [18:56:57] (03CR) 10JanZerebecki: [C: 032] Add proper mediawiki.page.watch.ajax dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195916 (https://phabricator.wikimedia.org/T87640) (owner: 10Thiemo Mättig (WMDE)) [19:00:20] (03PS2) 10Smalyshev: Add dump implementation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195980 [19:00:24] (03Merged) 10jenkins-bot: Add proper mediawiki.page.watch.ajax dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195916 (https://phabricator.wikimedia.org/T87640) (owner: 10Thiemo Mättig (WMDE)) [19:00:36] DanielK_WMDE_: ok, dump is gone from that patch, now in https://gerrit.wikimedia.org/r/#/c/195980/ [19:06:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: white gap next to wikibase-sitelinkgroupview-heading-container in site link edit mode - https://phabricator.wikimedia.org/T92431#1110565 (10aude) 3NEW [19:07:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: white gap next to wikibase-sitelinkgroupview-heading-container in site link edit mode - https://phabricator.wikimedia.org/T92431#1110575 (10Lydia_Pintscher) [19:07:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 7Tracking: Redesign header - https://phabricator.wikimedia.org/T75654#1110574 (10Lydia_Pintscher) [19:08:44] (03PS1) 10Aude: Fix issue of white space in sitelinkgroupview heading [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195986 (https://phabricator.wikimedia.org/T92431) [19:12:06] (03PS1) 10Aude: Fix reset of _initialAttributes.width in jquery sticknode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195987 [19:17:56] wikimedia/mediawiki-extensions-Wikibase/master/d263742 : Thiemo Mättig The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/53992258 [19:31:35] (03CR) 10Aude: [C: 031] "think this is at least an improvement" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/195951 (https://phabricator.wikimedia.org/T89956) (owner: 10Thiemo Mättig (WMDE)) [19:52:45] Lydia_WMDE: Joy, the first big import of semi-useless data [19:52:59] multichill: :( [19:53:07] * Lydia_WMDE sobs a little [19:53:25] We knew this was going to happen, just amazed that it took so long! :S [19:53:32] hah [19:53:33] true that [19:54:12] Michiel did plenty of bot imports on the Dutch Wikipedia and most of them are high quality [19:55:21] multichill: Speaking about imports, when will you do the desa codes [19:55:55] Hmm? Didn't we have some clean up needing to be done there? [19:56:06] I did cleanup a few months ago. [19:56:34] You should ask on the bot request page, I'm a bit reluctant to commit to things atm [19:56:47] Maybe there is something still yet, but that is easier to track with them [19:57:08] Maybe you should ask Michiel, he did the import in the first place ;-) [19:57:13] Will ask huskyr after Parlement & Politiek.... [19:57:40] Put it on the bot request page and ping some people [19:57:49] I pick up requests I see there every once in a while [19:58:13] Should add one for the label cleanup too. [19:59:04] Speaking about labels, I saw that there are like 8 labels in nl-informal... Any idea how to track those? [19:59:16] 139* [19:59:30] 12 descriptions... [20:01:00] Database query? [20:06:56] No experience with that... [20:09:56] Hm, i got a list in autolist [20:10:52] I'm curious how this happend. https://www.wikidata.org/w/index.php?title=Q1072146&diff=133268870&oldid=131577452 [20:13:02] Huh [20:13:09] How was it found?? [20:13:58] This seemed to work... https://www.dropbox.com/s/su2rka5aytxs0un/Schermafdruk%202015-03-11%2021.13.50.png?dl=0 [20:18:58] Weird summary btw https://www.wikidata.org/w/index.php?title=Q14404794&diff=203351036&oldid=148716204 [20:25:33] wtf https://www.wikidata.org/w/index.php?title=Q1975054&diff=188856369&oldid=163859498 [20:25:38] Lydia_WMDE: What's causing that? ^ [20:26:35] sjoerddebruin: what's wrong? [20:26:36] sorry [20:26:38] not seeing it [20:26:42] nl-informal [20:27:33] it is an option in the universal language selector [20:27:37] so you can also add labels [20:27:53] probably doesn't make too much sense though [20:27:59] like de-formal [20:29:03] https://www.wikidata.org/w/index.php?title=Q2565847&action=history -_- [20:30:12] 10Wikidata: Investigate why empty references get into Wikidata - https://phabricator.wikimedia.org/T92383#1110862 (10JeroenDeDauw) Wikibase now ignores empty references, solving the problem this investigation is about. That does not answer how they got into the system in the first place, though likely does make... [20:47:31] 10Wikidata, 5Patch-For-Review, 3§ Wikidata-Sprint-2015-02-25, 3§ Wikidata-Sprint-2015-03-11: Edit button in heading overlaps alias text - https://phabricator.wikimedia.org/T89956#1110945 (10aude) In addition to Thiemo's change, I think the edit toolbar / links should not have auto width (for now) and be in... [20:50:27] (03PS1) 10Aude: Remove auto width from edit toolbar in entitytermsview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/196011 (https://phabricator.wikimedia.org/T89956) [20:59:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: In edit mode of entitytermsview, it's not always very obvious where focus is - https://phabricator.wikimedia.org/T92447#1111026 (10aude) 3NEW [21:33:01] wikimedia/mediawiki-extensions-Wikibase/master/f092a96 : Translation updater bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/54010459 [21:51:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: ClaimDifferTest::testDiffClaims failures on travis - https://phabricator.wikimedia.org/T92453#1111270 (10aude) 3NEW [21:52:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: ClaimDifferTest::testDiffClaims failures on travis - https://phabricator.wikimedia.org/T92453#1111282 (10aude) [21:56:38] (03PS4) 10Smalyshev: Refactor tests to be data-driven [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/194750 [22:01:15] DanielK_WMDE_: I've added a test for dump header [22:05:41] SMalyshev: thanks. it didn't seem to be used at all, did i miss something? [22:06:01] DanielK_WMDE_: it's used in RdfDumpGenerator [22:06:08] which now lives in different patch :) [22:06:14] ah [22:06:33] yea, smaller patches make it easier to see what is being changed, but harder to se why... [22:06:40] yep :) [22:06:49] but you can always ask [22:07:08] chains help. would be nice if gerrit could provide a combine diff view of a chain of changes. [22:07:27] sure :) [22:08:28] SMalyshev: you factored out the dump stuff, thanks! will do a final review tomorrow. i guess it can go in, then. [22:09:30] anyone know where the wikidata map interface page went? The only link i can find is http://tools.wmflabs.org/wikidata-analysis/map/map.html [22:11:01] ok, cool. I have 2 other patches then (badges & values refactoring), I'll prepare them too, and then there's performance refactoring for RDF generator... [22:23:12] SMalyshev: i would like to defer the performance patch a bit and work on my proposal. you are right that we can't emit everything sequentially. I'm now considerring having separate emitters for entities, statements, values, and references. all would be flushed after preocessing an entity. [22:23:39] if we want to improve performance, i'd like to get rid of EasyRDF completely. [22:24:03] SMalyshev: on a first glance, it seemed that your performance hack only works for turtle. is that correct? [22:24:19] DanielK_WMDE_: we can do flushing after entity, but that would make stuff like reference reusal more problematic and not sure what would happen with values [22:24:53] DanielK_WMDE_: it would work for anything, but right now it's for turtle only. I was thinking about actually integrating your emitter structure into it [22:25:00] SMalyshev: i'd like to spend half a day of exploratory hacking to try my ideas. i'm not sure of the outcome either. [22:25:32] i'm currently thinking to give each emitter a line buffer, similer to the one you proposed. [22:25:40] for ntriples we have a bit of an issue with generating full URLs (may be slow to parse each ID) but we don't really need ntriples dump that much [22:26:13] yes, but it's very convenient for testing [22:26:27] I was thinking more of constructing a buffer first (like easyrdf does basically but without all the overhead) and then giving it to the emitter to process [22:27:35] DanielK_WMDE_: true. but performance for tests is less important. it's not hard to make ntriples emitter, it's harder to make it as fast as turtle one (while keeping turtle one fast) because of how we generate IDs [22:27:38] hm... i want to try and skip that step. I#d really love a turtle-like fluent interface. [22:27:54] what you mean? [22:28:18] the kind of code i put in the xommit message as an example. [22:28:24] the php reads like turtle. [22:29:02] when we generate the data for entity, we work with 5 types of objects at least - entity, statement, value, reference, link [22:29:09] SMalyshev: you mean, splitting foo:bar, looking up foo, and generating http://foo.com/bla/bar, is going to be very expensive? [22:29:29] and they are not sequential - i.e. statements have values, also have qualifiers and refs which in turn have values [22:29:30] yea, one emitter for each kind of thing. [22:29:39] so you can generate them in parallel [22:30:16] yes, splitting and matching can be expensive since it's done millions of times (for each ID basically and we can have 3 of them per triple) [22:30:39] calling preg_match a million times becomes expensive unfortunately [22:30:41] we can pass prefix and suffix as separate arguments to the emitter [22:31:12] preg_match would be overhead. explode would do. [22:31:13] hmm... maybe. it's be rather ugly but may save us some time... [22:31:43] why is it ugly? it's like namespace and name in XML. [22:31:47] I'm not sure how it would look with separate emitters though, can you write an example? [22:32:29] yes, i'd love to actually, for some reason i like this prolem :) but i probably won't find time before next week. [22:32:37] monday, i hope. will block a few hours [22:32:44] DanielK_WMDE_: it's ugly because we can't have string anymore - we'd have to make array instead and deal with it and arrays are bigger, more expensive and we'd need to be careful to not use them as strings anywhere [22:33:21] ok, I'd just want to see how you envision it because I'm not sure I understand how 5 emitters would work together [22:33:53] SMalyshev: five separate buffers. at the end, you flush each. [22:34:21] order of the output is not relevant, but it would still be grouped by entity. [22:34:34] ...if you flush after each entity [22:35:09] DanielK_WMDE_: that means keeping them around in functions... not sure it's the best. And also doesn't solve the issue of refs reuse [22:35:28] though we probably have it anyway between entities [22:35:34] i'd make them members [22:36:15] the rdf generator would become stateful, but reusable. [22:36:30] you don't even need to flush between entities, it would still work [22:38:01] well, between entities nobody even promises the generator would persist, in theory... but I guess we could have some repo [22:39:26] you can just as well create a new one for each entity. would still work [22:39:30] and we'd also have to think about RDR potentially which has completely different model and actually wants context [22:39:57] the emitters would have to explicitly support that [22:40:15] doing RDR sequentlially would be even harder - you need to know where the statements are attaching to [22:40:49] yes, if you want nested structures, the best thing would be to have sub-emitters. [22:41:50] i have thought about this a bit for bnodes, but decided we don't need it. i'll have to look at rdr again and think about it a bit. [22:42:23] but basically, all you need to do is pass an emitter in the place you would normally pass a qname or uri. that gives you a nasted structure. [22:42:48] we can generate RDR from data structure, but sequentially - not sure... needs some thinking [22:43:33] since the form depends on whether it has child nodes... [22:44:39] i'm actually itching to try and implement this :) sadly, my plate is pretty full... [22:45:07] we'll see. poke me about it on tuesday :) [22:51:03] DanielK_WMDE_: sure, we have like 5 patches to clear before that anyway [22:51:24] or 6 [23:31:04] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/pK6l [23:31:04] 13WikibaseDataModel/06master 140c42bbc 15Jeroen De Dauw: Merge pull request #404 from wmde/individualExceptions... [23:32:32] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/pK6d [23:32:32] 13WikibaseDataModel/06master 147bf6c8b 15Jeroen De Dauw: Bump to 2.7 alpha... [23:33:00] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/pKiv [23:33:00] 13WikibaseDataModel/06master 14f4ced16 15Jeroen De Dauw: Update branch alias to 2.7 alpha... [23:44:00] 10Wikidata, 10DataValues: Move Wikibase components from GitHub to Gerrit - https://phabricator.wikimedia.org/T92279#1111632 (10JeroenDeDauw) Looking at the DataValues components, I'm not seeing any big issues with how they are split. Some of them contain crappy code, and others have boundary problems. The gene...