[00:10:28] I'm giving up for today... to tired [00:10:44] jzerebecki: Guess you'll stay around for the SWAT etc? [00:10:54] hoo: yes [00:40:12] 3§ Wikidata-Sprint-2015-02-03, Wikidata, MediaWiki-extensions-WikibaseRepository: JS error after removing qualifier, save greyed-out - https://phabricator.wikimedia.org/T89354#1035758 (10JanZerebecki) 5Open>3Resolved [00:41:23] Jhs: thx for reporting^^ should work now. [00:42:21] jzerebecki, sweet :D [00:43:05] thx [01:04:01] 3wikidata-query-service, Wikidata: Install Java 8 on a Jenkins node - https://phabricator.wikimedia.org/T85964#1035827 (10Smalyshev) openjdk-8-jdk seems to be running ok on einsteinium but not sure if we actually need it or not. [01:24:47] 3Wikidata.org, § Wikidata-Sprint-2015-02-03, Wikidata: Wrong info on Special:Version - https://phabricator.wikimedia.org/T74759#1035865 (10JanZerebecki) a:3aude [01:48:52] (03CR) 10Jeroen De Dauw: [C: 032] Private by default in all Repo API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189930 (owner: 10Thiemo Mättig (WMDE)) [01:49:49] (03CR) 10Jeroen De Dauw: [C: 032] Private by default in ChangeOpFactory based API modules [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189928 (owner: 10Thiemo Mättig (WMDE)) [01:50:07] (03CR) 10Jeroen De Dauw: [C: 032] Replace static Item::newEmpty() with new Item() constructor [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189918 (owner: 10Thiemo Mättig (WMDE)) [01:55:37] (03CR) 10Jeroen De Dauw: [C: 032] Move Validator builders out of WikibaseDataTypeBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189731 (owner: 10Adrian Lang) [01:56:51] (03CR) 10Jeroen De Dauw: [C: 032] Inline trivial ApiWikibase::formatSummary method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189932 (owner: 10Thiemo Mättig (WMDE)) [02:13:31] (03Merged) 10jenkins-bot: Move Validator builders out of WikibaseDataTypeBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189731 (owner: 10Adrian Lang) [08:05:02] 3Wikidata: Wikidata query data not updated anymore - https://phabricator.wikimedia.org/T89430#1036136 (10Lydia_Pintscher) [08:54:00] 3Wikidata, Datasets-General-or-Unknown: Some Wikidata XML dumps are failing - https://phabricator.wikimedia.org/T85970#1036213 (10ArielGlenn) Wikidata needs to be moved to the 'big wikis' queue at some point and there are other not so small wikis that should be moved over as well. A question for wikiata dumps us... [09:50:53] Are the entity suggester suggestions inversed? [09:54:41] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Allow creating items or properties without a label - https://phabricator.wikimedia.org/T89440#1036288 (10Bugreporter) 3NEW [09:57:38] 0.0 [09:59:01] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Allow creating items or properties without a label - https://phabricator.wikimedia.org/T89440#1036297 (10Sjoerddebruin) You could use the following urL: https://www.wikidata.org/wiki/Special:NewProperty?uselang=en [10:37:44] Tobi_WMDE_SW: around? :O [10:48:13] 3Wikidata, Datasets-General-or-Unknown: Some Wikidata XML dumps are failing - https://phabricator.wikimedia.org/T85970#1036350 (10ArielGlenn) I had a look at the previous failed runs to get a sense of what was going on. The causes are various: the dataset1001 host or the snapshot host being rebooted for securit... [10:48:43] it's a addshore! [10:50:24] ohia Tobi_WMDE_SW ! [10:51:32] just wondering why wmde and the foundation write selenium tests in ruby rather than php and writing them as phpunit tests? :P [10:52:15] addshore: mainly because the php bindings for selenium were pretty bad that days [10:52:21] not sure if it improved much [10:52:22] ahhh! [10:52:49] writing them in java and using junit would be the best option [10:52:57] at least with the best support [10:53:28] but water-webdriver and page-object are pretty nice too [10:58:22] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/NEze [10:58:22] 13WikibaseDataModel/06master 1458cca5b 15thiemowmde: Merge pull request #383 from wmde/credits... [11:07:05] 3Wikidata, § Wikidata-Sprint-2015-02-03, MediaWiki-extensions-WikibaseRepository: Allow simultaneous editing of mainsnak and references - https://phabricator.wikimedia.org/T87759#1036364 (10Tobi_WMDE_SW) [11:07:42] 3Wikidata, § Wikidata-Sprint-2015-01-21, MediaWiki-extensions-WikibaseRepository: Change statement layout to vertical layout - https://phabricator.wikimedia.org/T87321#1036367 (10Tobi_WMDE_SW) a:5Snaterlicious>3None [11:07:54] 3Wikidata, § Wikidata-Sprint-2015-02-03, MediaWiki-extensions-WikibaseRepository: Allow simultaneous editing of mainsnak and references - https://phabricator.wikimedia.org/T87759#1036369 (10Tobi_WMDE_SW) a:3Snaterlicious [11:11:45] 3Wikidata, § Wikidata-Sprint-2015-02-03, § Wikidata-Sprint-2015-01-21, Wikibase-DataModel: Remove Claim class - https://phabricator.wikimedia.org/T87388#1036371 (10Tobi_WMDE_SW) These PRs are all part of this task: https://github.com/wmde/WikibaseDataModel/pull/361 https://github.com/wmde/WikibaseDataModel/pull... [12:48:55] (03PS1) 10Henning Snater: referenceview: Fixed overridden event bindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190441 [12:48:58] (03PS1) 10Henning Snater: referenceview: Removed internal listview caching [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190442 [12:49:00] (03PS1) 10Henning Snater: referenceview: Using listview.value() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190443 [12:50:37] (03PS2) 10Henning Snater: referenceview: Removed internal listview caching [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190442 [12:51:51] Lydia traveling? [12:53:38] (03PS3) 10Henning Snater: referenceview: Removed internal listview caching [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190442 [12:53:50] (03PS2) 10Henning Snater: referenceview: Using listview.value() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190443 [13:11:18] Could someone please review my Lua changes in gerrit? [13:11:26] Would be nice to move on there [13:13:59] DanielK_WMDE_: Care to comment on https://gerrit.wikimedia.org/r/181718 ? [13:16:52] aude: Here? [13:29:23] (03CR) 10Hoo man: [C: 032] Avoid duplicate code in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189743 (owner: 10Thiemo Mättig (WMDE)) [13:32:30] (03Merged) 10jenkins-bot: Avoid duplicate code in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189743 (owner: 10Thiemo Mättig (WMDE)) [13:45:09] (03CR) 10Hoo man: [C: 04-1] "Looks good in general, but I'm not a fan of how you have both "monolingualTextLanguages" and "ContentLanguages"." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189937 (https://phabricator.wikimedia.org/T87762) (owner: 10Adrian Lang) [13:47:34] (03CR) 10Hoo man: [C: 032] "I should have looked at the follow ups before, sorry." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189937 (https://phabricator.wikimedia.org/T87762) (owner: 10Adrian Lang) [13:49:52] (03Merged) 10jenkins-bot: Introduce ContentLanguages concept [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189937 (https://phabricator.wikimedia.org/T87762) (owner: 10Adrian Lang) [13:55:33] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Make language list injectable throughout backend - https://phabricator.wikimedia.org/T87761#1036605 (10hoo) [13:55:35] 3§ Wikidata-Sprint-2015-02-03, Wikidata, MediaWiki-extensions-WikibaseRepository: Make language list injectable for monolingual text in backend - https://phabricator.wikimedia.org/T87762#1036603 (10hoo) 5Open>3Resolved [13:55:51] 3Wikidata, § Wikidata-Sprint-2015-02-03, MediaWiki-extensions-WikibaseRepository: Make language list injectable for monolingual text in backend - https://phabricator.wikimedia.org/T87762#998198 (10hoo) [14:00:36] (03PS1) 10Henning Snater: referenceview: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190452 [14:00:38] (03PS1) 10Henning Snater: referenceview: Refactored value() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190453 [14:12:17] (03CR) 10Hoo man: [C: 032] Don't support null as languages in getDescriptions and getLabels (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190171 (owner: 10Adrian Lang) [14:14:31] (03Merged) 10jenkins-bot: Don't support null as languages in getDescriptions and getLabels [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190171 (owner: 10Adrian Lang) [14:20:15] (03PS1) 10Hoo man: Remove superfluous $languages !== null checks in EntityRetrievingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190454 [14:27:53] (03PS1) 10Henning Snater: referenceview: Removed internal caching of initial values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190456 [14:31:04] (03PS2) 10Henning Snater: referenceview: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190452 [14:31:08] (03PS2) 10Henning Snater: referenceview: Refactored value() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190453 [14:31:14] (03PS2) 10Henning Snater: referenceview: Removed internal caching of initial values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190456 [14:33:25] (03PS3) 10Henning Snater: referenceview: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190452 [14:37:35] (03CR) 10Hoo man: [C: 032] "Yay :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190172 (https://phabricator.wikimedia.org/T87763) (owner: 10Adrian Lang) [14:39:54] (03Merged) 10jenkins-bot: Introduce ContentLanguages for terms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190172 (https://phabricator.wikimedia.org/T87763) (owner: 10Adrian Lang) [14:54:15] (03PS1) 10Hoo man: Introduce ContentLanguages::hasLanguage and make use of it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190459 [15:08:51] (03PS3) 10Henning Snater: referenceview: Removed internal caching of initial values [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190456 [15:10:45] dear colleagues, is there a way to configure the URL of the link from a regular wiki to the wikibase repo? it appears in the toolbox [15:11:17] Sure, give me a second [15:12:55] thnx! [15:13:31] [13WikidataBrowserTests] 15WMDE-Fisch pushed 1 new commit to 06rubocop_s01e01: 02http://git.io/NzJZ [15:13:31] 13WikidataBrowserTests/06rubocop_s01e01 141b566ba 15WMDE-Fisch: re-renamed get_aliases method to avoid confusion [15:13:53] d [15:13:55] meh [15:14:22] $wgWBClientSettings['repoUrl'] = ''; // For the domain part [15:14:38] $wgWBClientSettings['repoScriptPath'] // Where index.php and api.php reside [15:14:57] $wgWBClientSettings['repoArticlePath'] // article path - $1 will be replaced with the name of the article [15:15:22] but repos don't have articles i thought? [15:15:40] They can have [15:15:51] and in this case article just refers to any wiki page [15:15:57] ok [15:16:10] thank you, will try [15:16:11] '/wiki/$1' [15:16:19] that would be the article path for wikidata [15:16:25] -> https://www.wikidata.org/wiki/$1 [15:17:42] is there a list of config options for wikibase? [15:17:49] yeah [15:17:53] docs/config.options [15:18:05] docs/options.wiki [15:18:09] shouldn't trust my memory [15:19:27] oh indeed [15:19:51] good call, there is a docs dir ein extensions/Wikibase [15:23:08] ok, i figured it out, the article path needs to contain my namespace 'Item:' [15:23:12] thank you hoo! [15:23:17] no! [15:23:22] absolutely not [15:23:28] if you do that, property links will break [15:24:00] but if i don't include the namespace, thw repo link will be wrong [15:24:04] *the [15:24:45] repoNamespaces [15:24:52] Look for that, if you have the doc around [15:25:13] i have! thanks [15:28:35] i like the markup in the docs :) [15:31:57] ok, super-nice [15:32:46] it is really great that everything is configurable [15:34:43] grrrit-wm broken? [15:35:53] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/NzO1 [15:35:53] 13WikidataBrowserTests/06master 14d7fe19a 15Tobi Gritschacher: Merge pull request #41 from wmde/description_t50139... [15:37:10] i have noticed that some external identifiers in wikidata are converted to links. how does that work? [15:37:40] with this gadget: https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js [15:37:45] But that breaks *a lot* [15:37:55] ok :) [15:37:56] I doubt you want to use it locally :/ [15:38:50] and how does it work that for some statements, when adding qualifiers there are reasonable qualifiers suggested without needing to type a single letter? [15:40:53] That's an extension to wikibae: https://github.com/Wikidata-lib/PropertySuggester [15:40:59] [13WikidataBrowserTests] 15tobijat 04deleted 06rubocop_s01e01 at 141b566ba: 02http://git.io/NzGZ [15:41:36] Not super easy to use, but reasonable [15:41:57] oha [15:42:06] are there other extensions to wikibase? [15:43:04] Nothing we currently have deployed [15:43:56] ah i see, i would first need a significant amount of data so property suggester can understand what is required. it doesn't learn on the go. [15:44:17] No, it can't learn on the go [15:44:23] well, maybe it could for small wikis [15:44:30] but that doesn't scale to Wikidata [15:44:42] so every once in a while I manually re-create it's database [15:44:43] hoo: yes :) in paris [15:44:51] Last time I did that was a month ago or so [15:44:53] only online very irregularly [15:44:58] Lydia_WMDE: Ah, I see [15:45:09] Hope you have fun there :) [15:45:19] lots! [15:45:28] meeting with maxime in an hour [15:45:34] the guy behind inventaire.op [15:45:37] .io even [15:46:56] (03CR) 10Hoo man: "RE to Thiemo: Will follow-up and make use of the hash map." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190459 (owner: 10Hoo man) [15:46:59] Awesome [15:47:11] I looked at that site a couple of days ago [15:55:28] hoo: thanks for all the help [15:56:01] will try my luck with the suggester once i have more data [15:57:11] Speaking about the suggester, could we get a update next week with maybe a lower threshold for references? [16:00:43] sjoerddebruin: katie was traveling so i still don't know if we can independently adjust it. what we can do is lower the threshold for everything a bit definitely. think that would be ok? [16:01:04] Hm, maybe. [16:01:29] But not too much. [16:11:49] Lydia_WMDE: I can adjust all the things and rebuild the index [16:12:02] hoo: that'd be sweet [16:12:10] But you have to tell me what to modify as I don't have to much clue about that part [16:12:18] there is a setting [16:12:21] sjoerddebruin: Can you open a ticket [16:12:36] Yeah, those are managed in Wikibase.php in mediawiki-configuration [16:12:39] that defines the threshold for when suggestions are included [16:12:41] we can update those on Monday [16:12:45] perfect [16:12:54] those should be all for the config part [16:13:04] and then simply update the database with the correlations [16:13:41] So a task for a much lower threshold of references and a update of the database? [16:14:16] Just for the configuration change [16:14:21] or just tell me what exactly to change [16:14:35] What's the current threshold of everything? [16:14:52] $wgPropertySuggesterMinProbability = 0.071; [16:15:16] Maybe the half of that? [16:15:16] let's try 0.069? [16:15:35] Oh, I really don't understand it. :P [16:15:39] nah i think we had 0.06 and that gave lots of crappy suggestions [16:15:42] :D [16:15:45] don't worry [16:16:15] tbh lucie should ideally look into the actual correlations next week [16:16:22] and help us figure out the best value [16:16:25] Ok [16:16:29] i think i even assigned the ticket to her [16:16:36] But 0.069 is good for now? [16:16:41] i think so [16:16:55] sjoerddebruin: Shall we also blacklist new ids or so? [16:16:58] While I'm on it [16:17:09] Isn't it already script based? [16:17:21] lucie made a script for that yeah [16:17:25] but it needs to be run [16:17:32] Script? [16:17:50] Anyway, current properties should be here. https://www.wikidata.org/wiki/Special:WhatLinksHere/Q18644427 [16:18:32] * Lydia_WMDE goes through mailing list moderation queue and feels like doing horrible things to spammers [16:19:31] sjoerddebruin: Ok, will add these and remove the deleted ones also [16:19:55] :) [16:20:15] Oh yes, I've already asked but are the suggestions inversed? [16:20:46] P554 has a suggestion to use P553, but there are not much items that do that. [16:21:01] (it should always be P553 with 5444 as qualifier) [16:21:30] looking [16:22:00] I've cleaned up everything in the last few days, but I don't saw much with P553 as qualifier. [16:22:27] hmmm it looks fine for the things i just tested [16:22:38] * Lydia_WMDE looks at P553 [16:23:14] Oh yes and a property deleted in october showed up, including label. [16:23:33] https://www.wikidata.org/wiki/Property:P1572 [16:23:52] (search for "premi" in Dutch) [16:24:10] hmmmm website account works as intended for the cases i try [16:24:20] let's look how it goes after an update of the data [16:27:10] Can someone ask Thiemo to join IRC? :) [16:27:12] jzerebecki: ^ [16:27:36] Lydia_WMDE: Btw, will be in the office next week (from Tuesday on) [16:28:12] [13WikibaseDataModel] 15thiemowmde 04deleted 06derpp at 14f775d66: 02http://git.io/NBKu [16:28:41] hoo: \o/ [16:32:14] DanielK_WMDE_: Can you ask Thiemo to join IRC really quikc? [16:32:56] hoo: i don't think he is in the office [16:33:04] Who of them? :P [16:33:12] * hoo goes and checks the calenders [16:33:16] probably only fisch and jan? [16:33:21] maybe henning [16:36:18] (03CR) 10Hoo man: [C: 032] "I'm fine with this... can you merge my change now?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190468 (owner: 10Thiemo Mättig (WMDE)) [16:47:21] sjoerddebruin: https://gerrit.wikimedia.org/r/190477 In case you want to double check my blacklist changes ;) [16:47:37] Will only deploy that after the next list update [16:48:55] code-reviewed [16:49:14] :) [16:57:44] I'm (re)writing a Wikipedia-Article, and it takes forever... [16:57:51] but it is nice to see it grow [16:58:33] I have to admit I haven't written a Wikipedia article for far too long :P [17:00:00] In which language? [17:00:05] de [17:03:06] but I'm not done yet [17:04:23] (03PS3) 10Thiemo Mättig (WMDE): [WIP] Simplify SpecialSetLabelDescriptionAliases [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189734 [17:06:41] yay :) [17:14:26] is here a Windows expert? (or someone what could help me with a problem?) [17:15:13] matej_suchanek: Just ask, I guess... mostly works better [17:16:08] I use Windows Vista and yesterday I let install some updates [17:16:50] after coming home I started the laptop and in both Mozilla and Chrome the font seems quite broken for me [17:17:35] In what way? [17:18:05] I don't know how to describe it, but for instance I can't see '=' when editing a source code/wikitext [17:18:17] what is problem by headlines :) [17:52:43] matej_suchanek: Like this? https://commons.wikimedia.org/wiki/File:Strange_font.png [17:53:36] yeah, indeed [17:53:41] Okay, thanks [17:53:50] We've got someone on the Dutch helpdesk with the same problem. [17:53:54] Also Vista. [17:56:09] glad to here being not the only one :) [18:01:55] hoo: sorry my ssh connection was broken again, he already left. damn unstable uplink in the office. [18:02:17] Ok [18:02:26] Trying to kill Wikbase\Utils today [18:02:36] Two functions to go :P [18:12:20] * hoo kills git [18:22:10] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #360: Reduce number of setId calls (06master...06setid) 02http://git.io/NO2i [18:22:17] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06setid at 14bd8868f: 02http://git.io/NgPl [18:29:52] git rm hoo [18:30:32] hoo: ugh. How that thing still exists after 2.5 years of everyone agreeing it should go... [18:31:42] Is Jenkins broken or something? [18:31:49] nvm [18:32:04] No, but the bot reporting into this channel is [18:32:10] ah, here it comes [18:33:27] hoo: so you're totally https://dl.dropboxusercontent.com/u/7313450/entropy/andnowiwait.jpg [18:33:54] Damn, that pic has been in my entropy folder since 2010 [18:34:01] I'm in the future! [18:38:44] for fucks sake, git [18:39:11] fuuuu [18:39:18] it merged two commits, wtf [18:39:44] this is why I totally love having several dependent changes in gerrit. Totally. [18:40:40] :) [18:47:25] (03CR) 10Jeroen De Dauw: Introduce ContentLanguages::hasLanguage and make use of it (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190459 (owner: 10Hoo man) [18:49:31] (03CR) 10jenkins-bot: [V: 04-1] Remove Utils::getLanguageCodes, make Babel handling more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190485 (owner: 10Hoo man) [18:49:31] JeroenDeDauw: I think the idea is to remove the getName and keep the rest as an interface for either value objects or wrappers around MediaWiki or ULS or whatever [18:51:23] JeroenDeDauw: Can you remove that -1 [18:51:27] I want to move on [18:51:32] and I might even change that [18:51:35] hoo: I do not have a -1? [18:51:37] but not int hat commit, obviously [18:51:42] Oh [18:52:43] hoo: would wrappers really make sense? Would it not be better to interact with URL or whatever at a single point and construct your collection object? [18:53:40] Possibly also that [18:53:53] hoo: and if this is just to be a collection, with the getName thing moved elsewhere, then better to put a clear note at the top of the class [18:53:59] So it's cl;ear what the responsibilities are [18:54:09] Else it can easily regress back into ambiguity [18:54:41] ContentLanguageList is probably also a better name [18:54:52] It's the naming pattern we settled on for collections in DataModel [18:55:11] ContentLanguages looks a lot like ContentLanguage [18:55:12] Doesn't that imply that it's an ArrayObject? [18:55:19] Why would it? [18:55:34] Because most (all?) of our *List classes are [18:56:02] hoo: really? I think none of them are [18:56:13] Ah, SnakList is [18:56:17] StatementList is not [18:56:34] SiteLinkList is not [18:56:58] (03PS2) 10Hoo man: Introduce ContentLanguages::hasLanguage and make use of it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190459 [18:57:00] Anyway, it does not matter if they are or not. List does not imply ArrayObject at all [18:57:00] (03PS7) 10Hoo man: Remove Utils::getLanguageCodes, make Babel handling more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190485 [19:03:21] Hey multichill. [19:03:26] JeroenDeDauw: I think I'll just make the one function that's left in Utils a service [19:03:44] Although that needs to work with statis Language from MediaWiki :( [19:04:56] Woha, it takes forever to clone Wb.git [19:05:03] hey, wbcreateredirect doesn't accept summary, Is it intended? [19:05:10] related discussion: https://gerrit.wikimedia.org/r/#/c/190160/4/pywikibot/site.py [19:05:23] hoo: "statis Language from MediaWiki"? [19:05:35] JeroenDeDauw: The static Language class from MediaWiki [19:05:43] it has the data we need [19:06:15] but injecting the data is not on option (to much, that #languages ^ 2 ) [19:06:19] * that's [19:06:46] hi sjoerddebruin, how are you? [19:07:02] Good, how are you? Back in the Netherlands? :) [19:07:44] Yes, got back today [19:08:01] 3Wikidata.org, § Wikidata-Sprint-2015-02-03, Wikidata: Wrong info on Special:Version - https://phabricator.wikimedia.org/T74759#1037343 (10JanZerebecki) 5Open>3Resolved [19:08:14] hoo: yeah, the language class has so many different things in it... you need a pile of interefaces to make that sane [19:08:16] Yeah, saw a airport check-in... [19:10:37] hoo: and I'm not aware of a good library that provides feature parity either [19:10:51] Would be cool if the TWN people could create such a thing [19:15:51] woha, git still cloning... [19:16:23] sjoerddebruin: Did I miss anything? ;-) [19:16:54] multichill: Not really, done a lot of work. [19:17:54] (03CR) 10Jeroen De Dauw: [C: 032] Specific type hints in LabelDescriptionUniquenessValidatorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/189742 (owner: 10Thiemo Mättig (WMDE)) [19:18:02] JeroenDeDauw: Once someone merges the two other commits, I think I'll just create a "service" wrapper around the static Language mess [19:18:16] And then Utils is officially gone [19:18:31] also that service object would make ContentLanguages::getName obsolete [19:24:04] hoo: sounds good [19:24:15] hoo: something you think I should merge now? [19:25:01] You can merge the two changes, if you feel comfortable [19:25:17] One moves validation of data up in the Stack, but that is actually needed any (see commit message) [19:27:42] (03CR) 10Jeroen De Dauw: [C: 032] Remove Utils::getLanguageCodes, make Babel handling more flexible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190485 (owner: 10Hoo man) [19:28:09] (03CR) 10Jeroen De Dauw: [C: 032] Introduce ContentLanguages::hasLanguage and make use of it [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/190459 (owner: 10Hoo man) [19:33:43] hoo: did you fix it yet? [19:33:46] :D [19:34:17] doeswikibaseutilsstillexist.com [19:35:05] hoo: error 408: hoo is too slow [19:35:42] hoo: I made like 5 commits since I merged yours [19:36:13] :P [19:36:27] Trying to find whether we actually use localized language names [19:36:33] if we don't: \o/ [19:36:54] sjoerddebruin: Poeh, https://www.wikidata.org/wiki/Wikidata:Database_reports/Constraint_violations/P650#.22Single_value.22_violations is weer flink opgelopen [19:37:06] * multichill takes out the chainsaw [19:38:22] Ok, we do :( [19:38:51] where i could find the full list of ISO 639-3 codes? [19:39:05] JeroenDeDauw: Did you yet work on deferred entity deserialization? [19:40:26] hoo: I have not, nor was I planning to. What made you think I was? [19:40:42] I think you said that at some point when we had problems with Germany [19:40:50] The_Photographer: http://www-01.sil.org/iso639-3/codes.asp ? [19:41:30] hoo: but in jason or raw easy data read [19:41:30] hoo: I think that was Daniel [19:41:55] The_Photographer: Click on Download in the side bar [19:41:59] guess they have that [19:42:07] hoo: to be honest, I am still not sure where this would make a huge difference and be the most sensible approach [19:42:13] hoo: thanks [19:42:36] If you need a whole entity, then it does not matter much. And if you only need a small part, than getting the entire json is fail to begin with [19:43:55] hoo: thanks :D [19:45:07] JeroenDeDauw: True... I guess most of this is going to be solved when we have a way to get terms in a sensible way w/o loading entities [19:45:19] using the wb_terms table only is faster for batches [19:45:49] for singly entities it's usually faster to just get the full entity [19:46:41] Yuvi|Vacation: Are the updates for wdq also on holiday? ;-) [19:47:31] multichill: He's not going to respond [19:47:36] and he also shouldn't [19:47:50] because he has holidays and should enjoy them [19:48:18] When it's over he'll find it in his bnc [19:48:23] hoo: indeed. We might have places where we only want a part of an entity, such as a fingerprint, or list of statements. And for those, it is somewhat better to have a deserializer that takes the whole json and just constructs the Fingerprint or StatementList [19:48:39] If you end up neeing the nother stuff later on anyway, that makes no sense though [19:48:46] Yeah [19:48:51] So I'm thinking creating such stuff is rather down the prio list [19:49:06] but also in the Lua code I would like to be able to only load the statements of something [19:49:24] multichill: Ja, ik kom handen tekort. [19:49:25] Ah [19:49:34] If that is a common thing, we can look into it of course [19:49:50] Though I'm curious how much of a difference this would make to begin with [19:50:38] hoo: I guess you could test this by running the code, and then running it with the non statement stuff commented out in the deserializer [19:52:23] multichill: Ik ben hier al blij mee. https://www.wikidata.org/w/index.php?title=Wikidata%3ADatabase_reports%2FConstraint_violations%2FP553&diff=196055880&oldid=190772645 [19:53:23] Oh, we just need to delete Denny to make it zero? ;-) [19:54:07] Wikimedia-accounts are tricky... [19:55:19] JeroenDeDauw: At some point I'll need to evaluate this more. Being restrained by reality when it comes to memory/ cpu time just kills the fun sometimes :P [19:57:22] hoo: well, as long as you base your actions on actual data and don't make changes you think will "fix" the code you just assume is the problem, then it's not that bad [19:58:04] I know that lua is often running OOM with our code [19:58:36] But I don't really know how much we can gain with which step. Surely there's a trade of [19:58:44] but fact is: Right now stuff just doesn't scale [20:02:18] JeroenDeDauw: https://phabricator.wikimedia.org/T76156 maybe that's enough already [20:05:47] hoo: what data does the lua actually use? [20:06:03] only things from statements... but the whole statements, or just specific parts? [20:06:46] JeroenDeDauw: Depends on what the users do with it [20:06:52] and we can't know that beforehand [20:07:14] hoo: so they can access all parts of statements>? [20:07:34] Yep, they get the whole entity serialization [20:07:57] hoo: did you not say you only needed statements? [20:08:23] In many cases, yes [20:08:39] People will load the whole entity and then only read eg. the commons category from it [20:08:41] or so [20:15:35] hoo: you submitting a fix for the content languages thing in the next min? [20:15:51] got distracted :S [20:16:08] Ok, maybe I check the stuff again in a few hours [20:44:41] 3MediaWiki-extensions-WikibaseClient, § Wikidata-Sprint-2015-01-21, Wikidata: testwikidata entries not appearing in recent changes or watchlist on test.wikipedia - https://phabricator.wikimedia.org/T87026#1037604 (10Dzahn) >>! In T87026#989195, @aude wrote: > btw, https://gerrit.wikimedia.org/r/#/c/184360/ is st... [21:29:06] wikimedia/mediawiki-extensions-Wikibase/master/5a2fdad : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/50691395 [21:33:38] :S [21:33:51] :O [21:36:49] Travis is becoming sentient [21:38:17] Seems like it's actually a core bug [23:01:24] Where did the tree of life go? :'( [23:03:02] jzerebecki: ^ Are you on the tool labs project for that? [23:03:27] no i'm not [23:06:18] :/ [23:06:24] Who has? Probably only Lucie [23:09:15] Sent her an email [23:35:48] jzerebecki: Will tool labs roots hate me if I request them to do such things? [23:36:03] I +1 your point from that recent mail thread [23:39:01] hoo: no idea, but would say go for it [23:55:02] 3Wikidata, MediaWiki-extensions-Capiunto, Security-Reviews: security review for Capiunto - https://phabricator.wikimedia.org/T71541#1038168 (10csteipp) 5Open>3Resolved Looks sane, sorry for the delay on this! [23:55:53] 3Wikidata, MediaWiki-extensions-Capiunto, Security-Reviews: security review for Capiunto - https://phabricator.wikimedia.org/T71541#1038170 (10hoo) Thank you! :)