[00:00:20] [13Common] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/bkQD [00:00:20] 13Common/06master 1450b5be2 15Thiemo Mättig: Remove misleading return doc [00:00:20] 13Common/06master 14fbdf520 15Marius Hoch: Merge pull request #13 from DataValues/unserialize... [00:03:35] [13Common] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/bk50 [00:03:35] 13Common/06master 1497261d8 15Thiemo Mättig: Add missing @covers tags [00:03:35] 13Common/06master 147b314bc 15Marius Hoch: Merge pull request #12 from DataValues/covers... [00:07:10] [13WikibaseInternalSerialization] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/bkd6 [00:07:10] 13WikibaseInternalSerialization/06master 14dd22eff 15Thiemo Mättig: Reuse existing methods [00:07:10] 13WikibaseInternalSerialization/06master 14e6d184e 15Marius Hoch: Merge pull request #37 from wmde/reuse... [00:08:14] [13Geo] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/bkFt [00:08:14] 13Geo/06master 146003a4c 15Marius Hoch: Merge pull request #40 from DataValues/unserlialize... [00:10:21] [13Number] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/bkFM [00:10:21] 13Number/06master 14c4ee11c 15Thiemo Mättig: Remove misleading return doc [00:10:21] 13Number/06master 1492f8e39 15Marius Hoch: Merge pull request #17 from DataValues/unserlialize... [00:11:23] [13Number] 15mariushoch 04deleted 06docs at 1476ab5cf: 02http://git.io/bkbk [00:12:07] So much stuff that needs CR on github... [00:12:15] [13Time] 15mariushoch 04deleted 06unserlialize at 14c730420: 02http://git.io/bkb2 [00:13:35] [13Time] 15mariushoch 04deleted 06uses at 14b4c06f6: 02http://git.io/bkb7 [00:16:33] [13Serialization] 15mariushoch closed pull request #8: Drop duplicate catch (06master...06catch) 02http://git.io/bJVY [00:19:40] [13WikibaseDataModelJavaScript] 15mariushoch closed pull request #25: Untangle else if chain (06master...06elseif) 02http://git.io/bfV5 [00:32:56] (03CR) 10Hoo man: "Looks ok in general... resulting query is probably not going to be much worse than what we have now (selectivity via entityType already is" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [00:34:35] [13WikibaseDataModel] 15mariushoch closed pull request #353: Drop "constructor is a constructor" docs (06master...06constructors) 02http://git.io/FwWr [00:37:14] [13WikibaseDataModel] 15mariushoch closed pull request #324: Remove misleading return doc (06master...06unserlialize) 02http://git.io/5uA9Vg [00:38:44] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 063.0.x-dev: 02http://git.io/bIfi [00:38:44] 13WikibaseDataModel/063.0.x-dev 14298f3d0 15Marius Hoch: Merge pull request #352 from wmde/setIdParam... [00:59:47] * hoo calls it a day [01:01:08] :) [01:52:03] (03PS1) 10Aude: Add version constant for EntityContent for parser options [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188277 (https://phabricator.wikimedia.org/T86694) [01:54:05] 3Wikidata, MediaWiki-Parser: Add hook for extensions to bump or expire parser cache - https://phabricator.wikimedia.org/T86694#1010423 (10aude) PageRenderingHash doesn't know anything about content model / type. looks like the best way is ParserOptions::addExtraKey, which can be used for EntityContent while for... [01:55:38] (03CR) 10Aude: "i tried to add a test case but not sure if/how to access options from ParserOutput in order to check the extra key." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188277 (https://phabricator.wikimedia.org/T86694) (owner: 10Aude) [02:03:50] (03CR) 10Aude: [C: 04-1] "looks good and works fine. just a nitpick about variable naming, since the variable no longer represents an array of files." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 (owner: 10Hoo man) [02:13:46] (03Abandoned) 10Aude: Inject settings into DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179118 (owner: 10Aude) [02:16:25] (03CR) 10Aude: "not looked at the code in detail yet... just a nitpick about naming" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187423 (https://phabricator.wikimedia.org/T72174) (owner: 10Henning Snater) [02:18:04] (03Abandoned) 10Aude: [DO NOT MERGE OR REVIEW] Use LabelLookup in EntityIdLabelFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/169331 (owner: 10Aude) [04:49:02] 3Beta-Cluster, Wikidata: m.wikidata.beta.wmflabs.org/ redirects to a host that does not exist - https://phabricator.wikimedia.org/T87440#1010590 (10Glaisher) needs a labs override for wgMobileUrlTemplate, I guess [08:07:15] (03CR) 10Adrian Lang: [C: 04-1] Introduce TemplateFactory::getDefaultInstance (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187127 (owner: 10Thiemo Mättig (WMDE)) [08:15:52] (03PS5) 10Adrian Lang: Pass ContentLanguages instance using ULS to ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186229 (https://phabricator.wikimedia.org/T86653) [08:16:37] (03CR) 10Adrian Lang: Pass ContentLanguages instance using ULS to ValueView (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186229 (https://phabricator.wikimedia.org/T86653) (owner: 10Adrian Lang) [08:44:45] [13Common] 15thiemowmde created 06phpdocs (+1 new commit): 02http://git.io/bLxt [08:44:45] 13Common/06phpdocs 14a07beea 15Thiemo Mättig: Fix incomplete PHPDocs in StringValueParser [08:44:52] (03PS3) 10Adrian Lang: Move stuff around in entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187364 [08:44:54] (03PS3) 10Adrian Lang: Don't attach event handlers if they don't do anything [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187365 [08:44:55] [13Common] 15thiemowmde opened pull request #17: Fix incomplete PHPDocs in StringValueParser (06master...06phpdocs) 02http://git.io/bLx3 [08:45:07] (03CR) 10Adrian Lang: "Manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187364 (owner: 10Adrian Lang) [08:45:15] (03CR) 10Adrian Lang: "Manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187365 (owner: 10Adrian Lang) [08:48:41] [13Common] 15thiemowmde 04force-pushed 06private from 1401b974c to 14080c651: 02http://git.io/aMKv7g [08:48:41] 13Common/06private 14080c651 15Thiemo Mättig: Make class properties private [09:00:00] (03PS1) 10Thiemo Mättig (WMDE): Fix all incomplete PHPDoc tags in Client/Lib/Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188333 [09:02:56] [13ValueView] 15adrianheine comment on pull request #154 14490edb8: 1. I've used `Combining` for the entity stores as well. I'm open for another name, though :)... 02http://git.io/bteB [09:07:43] [13ValueView] 15adrianheine comment on pull request #154 14490edb8: Done. 02http://git.io/btva [09:08:43] [13ValueView] 15adrianheine comment on pull request #154 14490edb8: I guess it's better to make every global access explicit in the IIFE. 02http://git.io/btvN [09:08:57] [13ValueView] 15adrianheine 04force-pushed 06mwDep from 14490edb8 to 14ee7c3e2: 02http://git.io/FwHP [09:08:57] 13ValueView/06mwDep 14ee7c3e2 15Adrian Heine: Remove mediaWiki dependency [09:10:13] (03PS2) 10Thiemo Mättig (WMDE): Use Item constructor instead of newEmpty + setId in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188071 [09:10:33] (03PS2) 10Thiemo Mättig (WMDE): Use Item constructor instead of newEmpty + setId in maintenance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188073 [09:21:08] 3MediaWiki-extensions-WikibaseRepository, Wikidata: User interface displays false birth and death dates - https://phabricator.wikimedia.org/T87312#1010919 (10Candalua) Please fix this as soon as possible. Right now, ALL dates before 15 oct 1582 are displayed incorrectly and the users are getting a basically fa... [09:36:40] [13ValueView] 15adrianheine 04force-pushed 06mwDep from 14ee7c3e2 to 14b18690e: 02http://git.io/FwHP [09:36:40] 13ValueView/06mwDep 14b18690e 15Adrian Heine: Remove mediaWiki dependency [09:41:57] [13ValueView] 15snaterlicious created 06generaldoc (+1 new commit): 02http://git.io/btYm [09:41:57] 13ValueView/06generaldoc 147223b8a 15snaterlicious: Updated general documentation [09:42:39] [13ValueView] 15snaterlicious opened pull request #156: Updated general documentation (06master...06generaldoc) 02http://git.io/btYR [09:49:17] [13ValueView] 15adrianheine 04force-pushed 06mwDep from 14b18690e to 1420aa0b1: 02http://git.io/FwHP [09:49:17] 13ValueView/06mwDep 1420aa0b1 15Adrian Heine: Remove mediaWiki dependency [09:52:24] (03PS1) 10Thiemo Mättig (WMDE): Drop dead try-catch from populateInterwiki [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188337 [09:54:48] (03PS1) 10Thiemo Mättig (WMDE): Drop dead code from VariantsAwareRendererTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188338 [09:55:35] (03PS1) 10Thiemo Mättig (WMDE): Drop dead code from TermSqlIndexTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188339 [09:58:13] (03PS1) 10Thiemo Mättig (WMDE): Fix -> vs. > typo in DispatchStatsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188341 [10:01:46] (03PS1) 10Thiemo Mättig (WMDE): Drop dead code from MockTermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188342 [10:02:30] (03PS1) 10Thiemo Mättig (WMDE): Drop dead code from OtherProjectsSitesGeneratorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188343 [10:04:26] (03PS1) 10Thiemo Mättig (WMDE): Fix incomplete test in AffectedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188344 [10:08:48] (03CR) 10jenkins-bot: [V: 04-1] Fix incomplete test in AffectedPagesFinderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188344 (owner: 10Thiemo Mättig (WMDE)) [10:10:33] (03PS1) 10Thiemo Mättig (WMDE): Add/fix missing imports and type hints [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188345 [10:12:03] 3MediaWiki-extensions-WikibaseRepository, Wikidata: "other language" boxes overlaps with site links for long aliases - https://phabricator.wikimedia.org/T88293#1011016 (10Snaterlicious) Would be fixed with https://gerrit.wikimedia.org/r/#/c/183498/ See also T75656 and T75657. [10:17:30] 3Wikidata, dev.wikimedia.org: Document the Wikidata API in the Developer Hub - https://phabricator.wikimedia.org/T359#1011021 (10Lydia_Pintscher) [10:18:24] 3Wikidata, dev.wikimedia.org: Document the Wikidata API in the Developer Hub - https://phabricator.wikimedia.org/T359#4026 (10Lydia_Pintscher) I would argue this is not "low" as the API is one of the most important parts of Wikidata. [10:19:43] 3Wikidata, dev.wikimedia.org: Showcase/inspire: Mobile page description from Wikidata - https://phabricator.wikimedia.org/T88409#1011023 (10Lydia_Pintscher) [10:22:22] 3MediaWiki-extensions-WikibaseRepository, Wikidata: "other language" boxes overlaps with site links for long aliases - https://phabricator.wikimedia.org/T88293#1011026 (10Lydia_Pintscher) [10:25:14] 3Wikidata, dev.wikimedia.org: Document the Wikidata API in the Developer Hub - https://phabricator.wikimedia.org/T359#1011027 (10Qgil) I set the priority to Low when Sumana left and we had no technical writer to work on this. Now that we have @spage, things may change. In fact, he is committing to work on T88409... [10:29:43] (03CR) 10Adrian Lang: [C: 04-1] Fix all incomplete PHPDoc tags in Client/Lib/Repo (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188333 (owner: 10Thiemo Mättig (WMDE)) [10:35:28] Thiemo_WMDE: http://stackoverflow.com/a/5197655/55965 [10:39:13] 3Wikidata, dev.wikimedia.org: Document the Wikidata API in the Developer Hub - https://phabricator.wikimedia.org/T359#1011051 (10Lydia_Pintscher) Cool. @Lucie can hopefully help. Maybe also @addshore wants to be involved. [10:41:24] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Typing a property ID in entity-selector does not trigger "selected" event - https://phabricator.wikimedia.org/T87767#1011054 (10Lydia_Pintscher) [10:42:01] 3Wikidata, MediaWiki-extensions-WikibaseRepository: different styling for label/alias and description input - https://phabricator.wikimedia.org/T87576#1011056 (10Lydia_Pintscher) [11:14:42] (03CR) 10Hoo man: From MediaWiki 1.24 on UnitTestsList can handle directories (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 (owner: 10Hoo man) [11:14:57] (03PS4) 10Hoo man: From MediaWiki 1.24 on UnitTestsList can handle directories [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 [11:15:41] (03PS2) 10Hoo man: Let MediaWiki auto-discover tests [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/188229 [11:16:19] (03CR) 10Hoo man: "Renamed variable $file to $paths (per Aude in Wikibase)." [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/188229 (owner: 10Hoo man) [11:27:57] (03CR) 10Hoo man: [C: 032] Use Item constructor instead of newEmpty + setId in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188071 (owner: 10Thiemo Mättig (WMDE)) [11:29:41] (03CR) 10Hoo man: [C: 04-1] Use Item constructor instead of newEmpty + setId in maintenance (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188073 (owner: 10Thiemo Mättig (WMDE)) [11:30:41] (03Merged) 10jenkins-bot: Use Item constructor instead of newEmpty + setId in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188071 (owner: 10Thiemo Mättig (WMDE)) [11:31:18] [13Common] 15mariushoch pushed 2 new commits to 06master: 02http://git.io/btQu [11:31:18] 13Common/06master 14a07beea 15Thiemo Mättig: Fix incomplete PHPDocs in StringValueParser [11:31:18] 13Common/06master 1471ce36d 15Marius Hoch: Merge pull request #17 from DataValues/phpdocs... [11:45:35] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: Personally, I would prefer applying overrides with an inline comment in the file. 02http://git.io/btF5 [11:45:56] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: @since missing (other new constructors as well) 02http://git.io/btbe [11:46:27] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: Sorry, maybe it is just me who does not really like short variable names. Looking at the constructor arguments, I was wondering how both `MessageProvider`s "interact" as `a` and `b` did not really give me a hint. Maybe the parameters should be named `primaryMessageProvider` (or `preferredMessageProvider`) and `secondaryMessageProvider` (or `alternativeMessageProvider`) - just an i [11:46:53] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: Documentation is hard to understand. 02http://git.io/btbV [11:47:08] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: Maybe check if `messages` actually is a proper object? 02http://git.io/btbK [11:47:18] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: Importing @param and @return tags using @inheritdoc should work. 02http://git.io/btb5 [11:47:28] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: Description does not contain any useful information and may be removed. 02http://git.io/btNJ [11:47:44] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: Line is too long and please document error in the function-level documentation. 02http://git.io/btNs [11:47:53] [13ValueView] 15snaterlicious comment on pull request #154 1420aa0b1: Please add some option description. What is the option used for and/or why would it make sense to specify the option? 02http://git.io/btNn [11:49:09] [13Common] 15mariushoch closed pull request #15: Make class properties private (06master...06private) 02http://git.io/tNMYOg [12:03:18] (03CR) 10Hoo man: [C: 032] "This is going to do weird things if $this->source is empty... But that's not new." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188337 (owner: 10Thiemo Mättig (WMDE)) [12:06:50] (03Merged) 10jenkins-bot: Drop dead try-catch from populateInterwiki [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188337 (owner: 10Thiemo Mättig (WMDE)) [12:38:30] 3Wikidata, MediaWiki-extensions-WikibaseRepository: keyboard selector hiding site id input - https://phabricator.wikimedia.org/T88417#1011167 (10Lydia_Pintscher) 3NEW [12:47:51] Adrian_WMDE: https://www.wikidata.org/wiki/User:Duesentrieb [12:52:26] 3MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Wikidata: Figure what to do with MWException within Wikibase - https://phabricator.wikimedia.org/T88360#1011186 (10JanZerebecki) Just, please never ever throw a plain Exception. [12:52:43] 3MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Wikidata: Figure what to do with MWException within Wikibase - https://phabricator.wikimedia.org/T88360#1011188 (10JanZerebecki) [12:56:11] (03PS1) 10Thiemo Mättig (WMDE): Drop rebuildAllData maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188353 [12:59:06] (03PS1) 10Thiemo Mättig (WMDE): Avoid calling deprecated EntityFactory::singleton() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188354 [13:00:16] 3Wikidata, MediaWiki-extensions-WikibaseClient: Allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#1011207 (10adrianheine) [13:02:21] (03PS1) 10Adrian Lang: Pass a MessageProvider to ValueView instead of mw [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188355 [13:02:23] (03PS1) 10Adrian Lang: Add WikibaseView skeleton [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188356 [13:02:25] (03PS1) 10Adrian Lang: Introduce wikibase.view.ViewFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) [13:02:29] * aude waves [13:03:03] (03PS1) 10Thiemo Mättig (WMDE): Use proper EntityFactory methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188358 [13:03:32] Tobi_WMDE_SW_NA: Lydia_WMDE ping [13:03:50] (03CR) 10jenkins-bot: [V: 04-1] Pass a MessageProvider to ValueView instead of mw [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188355 (owner: 10Adrian Lang) [13:04:02] (03CR) 10jenkins-bot: [V: 04-1] Add WikibaseView skeleton [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188356 (owner: 10Adrian Lang) [13:04:04] (03CR) 10jenkins-bot: [V: 04-1] Introduce wikibase.view.ViewFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188357 (https://phabricator.wikimedia.org/T87434) (owner: 10Adrian Lang) [13:04:11] aude: hey [13:05:13] is there hangout? [13:05:48] aude: DanielK_WMDE will try to get you in [13:06:55] aude: invite in progress [13:07:02] ok [13:07:46] it's inviting me on my phone [13:08:05] but you didn't pick up, it seems... [13:08:08] i'll call again [13:08:19] should be on my computer [13:08:36] * aude is incapable with hangouts :( [13:08:51] got it [13:09:09] can you hear [13:11:43] (03PS1) 10Thiemo Mättig (WMDE): Inline type checks in ExceptionLocalizer classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188359 [13:17:29] (03PS1) 10Thiemo Mättig (WMDE): Fix/add PHPDoc tags to avoid unknown method warnings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188360 [13:19:00] (03PS1) 10Thiemo Mättig (WMDE): Inline trivial ItemSearchTextGenerator code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188361 [13:30:12] (03CR) 10Thiemo Mättig (WMDE): "I also suggest to use "SetEntityTerms". A special page with such a generic name can easily be reused for all kinds of entities later. The " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187423 (https://phabricator.wikimedia.org/T72174) (owner: 10Henning Snater) [13:44:19] (03CR) 10Hoo man: [C: 032] Drop dead code from OtherProjectsSitesGeneratorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188343 (owner: 10Thiemo Mättig (WMDE)) [13:48:01] 3Wikidata, MediaWiki-extensions-WikibaseClient: when i move a Wikibase client page, subscriptions are not updated - https://phabricator.wikimedia.org/T88357#1011271 (10aude) [13:48:37] (03Merged) 10jenkins-bot: Drop dead code from OtherProjectsSitesGeneratorTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188343 (owner: 10Thiemo Mättig (WMDE)) [13:49:40] 3Wikidata, MediaWiki-extensions-WikibaseClient: DatabaseBase::makeList: empty input for field cs_entity_id - https://phabricator.wikimedia.org/T88329#1011276 (10aude) 5Open>3Resolved [13:50:54] 3Wikidata, MediaWiki-extensions-WikibaseClient: SubscriptionManager is trying to query client database - https://phabricator.wikimedia.org/T88333#1011279 (10aude) 5Open>3Resolved [13:51:54] (03PS1) 10Aude: Fix repo connection for SqlSubscriptionManager [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188363 (https://phabricator.wikimedia.org/T88333) [13:52:11] (03PS1) 10Aude: Avoid empty list input for DatabaseBase::makeList in subscriptions [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188364 (https://phabricator.wikimedia.org/T88329) [13:52:25] (03PS1) 10Aude: Check for empty arrays in UsageUpdater [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188365 (https://phabricator.wikimedia.org/T88329) [13:52:35] (03PS1) 10Aude: Add test case for empty array in SqlSubscriptionManager [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188366 (https://phabricator.wikimedia.org/T88329) [13:56:03] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Unexpected non-MediaWiki exception encountered, of type "InvalidArgumentException", line 63 of TimeDetailsFormatter.php - https://phabricator.wikimedia.org/T65075#1011301 (10thiemowmde) Can you provide the API request you used to create the mismatch? [14:10:01] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Unexpected non-MediaWiki exception encountered, of type "InvalidArgumentException", line 63 of TimeDetailsFormatter.php - https://phabricator.wikimedia.org/T65075#1011338 (10Addshore) No api request. https://test.wikidata.org/wiki//index.php?title=Q4&diff=1328... [14:12:11] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Removed obsolete snakview.isDisabled() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188049 (owner: 10Henning Snater) [14:12:34] How can I find out how man Wikipedia articles have Wikidata items ? [14:12:36] s/man/many [14:15:27] 3Wikidata, MediaWiki-extensions-WikibaseRepository: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1011342 (10daniel) Adrian pointed out that even the labels of top-level properties are rendered incorrectly by JS, when they get r... [14:16:58] (03CR) 10Thiemo Mättig (WMDE): "Why delete the test? The remaining code is very easy to test. Better remove the tags, I don't think they are necessary any more." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 (owner: 10Hoo man) [14:18:59] Thiemo_WMDE: Testing those hooks makes hardly any sense [14:19:06] either they work and then the tests gets run [14:19:13] or they don't and the test wont run either [14:19:37] ok, that kind of makes sense. ;) [14:19:39] Also testing a function which only does $paths[] = 'foo'; return true; is a little pointelss [14:19:54] i dont like the odd suppress tags... [14:20:09] Jeroen introduced them AFAIR [14:20:21] I don't like them either, but I also don't really object them [14:20:22] why mark a method as not covered if it's so insanely easy to cover? [14:20:52] ok, i will +2 and do a follow up... [14:21:21] Ok :) [14:22:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Frontend JS should not re-render qualifiers and references upon load. - https://phabricator.wikimedia.org/T88425#1011359 (10daniel) 3NEW [14:23:41] But before you waste your time writing tests for that, rather write test that make sense [14:24:03] DanielK_WMDE: Can I haz review for Capiunto changes? [14:24:08] Do you have it installed, even? [14:24:29] xD [14:24:46] hey addshore :D [14:25:00] hey hoo! I dont think I have ever installed Capiunto :D [14:25:09] You should [14:27:55] (03CR) 10Aude: Fix -> vs. > typo in DispatchStatsTest (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188341 (owner: 10Thiemo Mättig (WMDE)) [14:30:22] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Server-side rendering for all property links in the JS UI - https://phabricator.wikimedia.org/T88426#1011367 (10daniel) 3NEW [14:31:03] (03CR) 10Aude: [C: 04-1] "test is still broken... would be nice to fix." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188341 (owner: 10Thiemo Mättig (WMDE)) [14:32:01] (03PS1) 10Thiemo Mättig (WMDE): Drop some @codeCoverageIgnore tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188371 [14:32:13] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Drop referenced entities from JS config - https://phabricator.wikimedia.org/T88428#1011386 (10daniel) 3NEW [14:32:15] (03CR) 10Thiemo Mättig (WMDE): [C: 032] From MediaWiki 1.24 on UnitTestsList can handle directories [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 (owner: 10Hoo man) [14:34:00] (03PS2) 10Thiemo Mättig (WMDE): Drop some @codeCoverageIgnore tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188371 [14:34:12] (03CR) 10Henning Snater: "Please do not discuss such things on the change set. https://phabricator.wikimedia.org/T72174" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187423 (https://phabricator.wikimedia.org/T72174) (owner: 10Henning Snater) [14:34:32] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Drop referenced entities from JS config - https://phabricator.wikimedia.org/T88428#1011404 (10daniel) [14:34:33] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Frontend JS should not re-render qualifiers and references upon load. - https://phabricator.wikimedia.org/T88425#1011405 (10daniel) [14:35:17] 3Wikidata, MediaWiki-extensions-WikibaseRepository: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1007968 (10daniel) Note: fixing T88425 would reduce the visibility of this issue to newly added resp edited statements. [14:35:35] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Frontend JS should not re-render qualifiers and references upon load. - https://phabricator.wikimedia.org/T88425#1011359 (10daniel) Note: fixing T88425 would reduce the visibility of this issue to newly added resp edited statements. [14:36:28] (03CR) 10Hoo man: [C: 04-1] Drop some @codeCoverageIgnore tags (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188371 (owner: 10Thiemo Mättig (WMDE)) [14:36:29] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Server-side rendering for all property links in the JS UI - https://phabricator.wikimedia.org/T88426#1011415 (10daniel) [14:36:31] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Drop referenced entities from JS config - https://phabricator.wikimedia.org/T88428#1011386 (10daniel) [14:36:51] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Drop referenced entities from JS config - https://phabricator.wikimedia.org/T88428#1011417 (10daniel) [14:37:51] Thiemo_WMDE: Or maybe just do the unit tests hooks in that patch [14:38:03] and leave the rest for another patch set [14:38:10] sorry? [14:38:23] (03Merged) 10jenkins-bot: From MediaWiki 1.24 on UnitTestsList can handle directories [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 (owner: 10Hoo man) [14:38:38] I mean it might be better to not touch the resource definitions in the same chagne [14:39:44] (03CR) 10Thiemo Mättig (WMDE): Drop some @codeCoverageIgnore tags (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188371 (owner: 10Thiemo Mättig (WMDE)) [14:40:16] Thiemo_WMDE: Oh, now I get it [14:40:40] this is unrelated but so trivial that i don#t want to split it. [14:41:06] Yeah, sorry I thought you also wanted to completely remove that from the ignore, but forgot about the start tag [14:41:15] maybe it is not so trivial. ;))) [14:41:51] (03CR) 10Adrian Lang: [C: 031] SnakTypeSelector: Removed unnecessary code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188040 (owner: 10Henning Snater) [14:42:03] (03CR) 10Hoo man: [C: 032] "Seems like I misunderstood Thiemo here." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188371 (owner: 10Thiemo Mättig (WMDE)) [14:43:40] (03CR) 10Adrian Lang: [C: 032] snakview.variations*: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188047 (owner: 10Henning Snater) [14:44:28] (03CR) 10Adrian Lang: [C: 032] snakview.ViewState: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188048 (owner: 10Henning Snater) [14:45:12] (03CR) 10Adrian Lang: "snaklistview tests use this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188049 (owner: 10Henning Snater) [14:45:18] (03CR) 10Adrian Lang: [C: 04-1] Removed obsolete snakview.isDisabled() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188049 (owner: 10Henning Snater) [14:45:23] (03Merged) 10jenkins-bot: Drop some @codeCoverageIgnore tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188371 (owner: 10Thiemo Mättig (WMDE)) [14:46:07] Lydia_WMDE: could you also bring up https://phabricator.wikimedia.org/T85913 in the scrum of scrums? [14:48:23] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Looks good, can't find any mistake. Not manually tested, though." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187365 (owner: 10Adrian Lang) [14:49:45] (03PS3) 10Hoo man: Let MediaWiki auto-discover tests [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/188229 [14:49:55] Thiemo_WMDE: ^ [14:50:01] very similar to what we just did [14:50:22] Adrian_WMDE: ok [14:51:57] hoo: array -> string[]. want to change? also: is the & in front of string[] &$paths useful in the @param tag? I'm not sure. [14:52:07] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Because that's what MessageProvider used to do. 02http://git.io/bmtF [14:52:48] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] Use Item constructor instead of newEmpty + setId in maintenance (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188073 (owner: 10Thiemo Mättig (WMDE)) [14:52:52] (03PS4) 10Hoo man: Let MediaWiki auto-discover tests [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/188229 [14:53:36] Thiemo_WMDE: Yeah, did both... guess it's useful to know about the reference [14:54:29] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Done. 02http://git.io/bmmC [14:55:17] (03PS3) 10Thiemo Mättig (WMDE): Use Item constructor instead of newEmpty + setId in maintenance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188073 [14:55:44] hashar: hey could you look into merging https://gerrit.wikimedia.org/r/#/c/180418/ [14:55:50] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Done. 02http://git.io/bmYT [14:56:32] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Let MediaWiki auto-discover tests [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/188229 (owner: 10Hoo man) [14:57:16] (03CR) 10Hoo man: [C: 032] Use Item constructor instead of newEmpty + setId in maintenance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188073 (owner: 10Thiemo Mättig (WMDE)) [14:57:54] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Done 02http://git.io/bmOC [14:58:53] (03Merged) 10jenkins-bot: Let MediaWiki auto-discover tests [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/188229 (owner: 10Hoo man) [14:59:06] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Done. 02http://git.io/bm3f [14:59:50] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Done. 02http://git.io/bm3R [15:00:22] (03Merged) 10jenkins-bot: Use Item constructor instead of newEmpty + setId in maintenance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188073 (owner: 10Thiemo Mättig (WMDE)) [15:00:54] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: We use ›hash‹ with that meaning in Wikibase, though. 02http://git.io/bmsm [15:01:50] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Done. 02http://git.io/bmsP [15:02:14] (03CR) 10Aude: [C: 032] Fix repo connection for SqlSubscriptionManager [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188363 (https://phabricator.wikimedia.org/T88333) (owner: 10Aude) [15:02:37] (03CR) 10Aude: [C: 032] Avoid empty list input for DatabaseBase::makeList in subscriptions [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188364 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [15:02:43] (03CR) 10Aude: [C: 032] Check for empty arrays in UsageUpdater [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188365 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [15:02:48] (03CR) 10Aude: [C: 032] Add test case for empty array in SqlSubscriptionManager [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188366 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [15:04:21] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Documented. We have longer lines in this repository, I don't know what the upper limit is. 02http://git.io/bmGN [15:05:50] [13ValueView] 15adrianheine comment on pull request #154 1420aa0b1: Done. 02http://git.io/bmZ6 [15:06:11] (03PS2) 10Thiemo Mättig (WMDE): Fix all incomplete PHPDoc tags in Client/Lib/Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188333 [15:06:13] (03CR) 10Thiemo Mättig (WMDE): Fix all incomplete PHPDoc tags in Client/Lib/Repo (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188333 (owner: 10Thiemo Mättig (WMDE)) [15:06:26] [13ValueView] 15adrianheine 04force-pushed 06mwDep from 1420aa0b1 to 144fe20c1: 02http://git.io/FwHP [15:06:26] 13ValueView/06mwDep 144fe20c1 15Adrian Heine: Remove mediaWiki dependency [15:08:41] (03CR) 10Adrian Lang: [C: 032] Fix all incomplete PHPDoc tags in Client/Lib/Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188333 (owner: 10Thiemo Mättig (WMDE)) [15:09:42] (03Merged) 10jenkins-bot: Fix repo connection for SqlSubscriptionManager [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188363 (https://phabricator.wikimedia.org/T88333) (owner: 10Aude) [15:09:48] (03PS2) 10Thiemo Mättig (WMDE): Introduce TemplateFactory::getDefaultInstance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187127 [15:09:50] (03Merged) 10jenkins-bot: Avoid empty list input for DatabaseBase::makeList in subscriptions [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188364 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [15:09:53] (03Merged) 10jenkins-bot: Check for empty arrays in UsageUpdater [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188365 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [15:09:56] (03Merged) 10jenkins-bot: Add test case for empty array in SqlSubscriptionManager [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/188366 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [15:10:18] 3Wikidata, MediaWiki-extensions-WikibaseRepository: jenkins job to generate wikibase.git coverage - https://phabricator.wikimedia.org/T88434#1011538 (10JanZerebecki) 3NEW [15:10:19] (03CR) 10Thiemo Mättig (WMDE): "Done. Also did a rebase." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187127 (owner: 10Thiemo Mättig (WMDE)) [15:10:40] 3Wikidata, MediaWiki-extensions-WikibaseRepository: jenkins job to generate wikibase.git coverage - https://phabricator.wikimedia.org/T88434#1011545 (10JanZerebecki) [15:10:41] 3Wikidata, MediaWiki-extensions-WikibaseClient: add possibility to generate proper phpunit coverage reports of Wikibase.git - https://phabricator.wikimedia.org/T74318#1011546 (10JanZerebecki) [15:11:10] 3Wikidata, MediaWiki-extensions-WikibaseRepository: jenkins job to generate wikibase.git coverage - https://phabricator.wikimedia.org/T88434#1011538 (10JanZerebecki) [15:11:59] 3Wikidata, Continuous-Integration, MediaWiki-extensions-WikibaseRepository: jenkins job to generate wikibase.git coverage - https://phabricator.wikimedia.org/T88434#1011538 (10JanZerebecki) [15:13:55] (03Merged) 10jenkins-bot: Fix all incomplete PHPDoc tags in Client/Lib/Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188333 (owner: 10Thiemo Mättig (WMDE)) [15:15:34] 3Wikidata, Continuous-Integration, MediaWiki-extensions-WikibaseRepository: generate patch code coverage on gerrit patch-set upload for wikibase.git - https://phabricator.wikimedia.org/T88435#1011564 (10JanZerebecki) 3NEW [15:16:05] (03PS2) 10Thiemo Mättig (WMDE): Make LangLinkHandlerTest::getLangLinkHandler parameter optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186770 [15:16:37] 3Wikidata, Continuous-Integration, MediaWiki-extensions-WikibaseRepository: generate patch code coverage on gerrit patch-set upload for wikibase.git - https://phabricator.wikimedia.org/T88435#1011564 (10JanZerebecki) [15:20:13] jzerebecki: I haven't followed up yet on data-values [15:20:36] I guess it is time for it :] [15:21:50] (03CR) 10Aude: [C: 032] Fix/add PHPDoc tags to avoid unknown method warnings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188360 (owner: 10Thiemo Mättig (WMDE)) [15:22:31] (03CR) 10Aude: [C: 032] Make LangLinkHandlerTest::getLangLinkHandler parameter optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186770 (owner: 10Thiemo Mättig (WMDE)) [15:26:43] (03Merged) 10jenkins-bot: Fix/add PHPDoc tags to avoid unknown method warnings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188360 (owner: 10Thiemo Mättig (WMDE)) [15:26:47] (03Merged) 10jenkins-bot: Make LangLinkHandlerTest::getLangLinkHandler parameter optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186770 (owner: 10Thiemo Mättig (WMDE)) [15:27:16] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf16/08140ec : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/49327473 [15:27:27] uh, what? [15:27:35] :O [15:28:44] aude: Ignore that [15:29:00] Seen that for various travis things [15:29:04] with hhvm [15:29:05] ah [15:29:13] composer download failing, I mean [15:29:22] :( [15:29:55] The command "bash ./build/travis/update-db.sh" failed and exited with 255 during . [15:30:08] MediaWiki requires the PSR-3 logging library to [15:30:10] the root problem is above that [15:30:26] [Composer\Downloader\TransportException] [15:30:34] aude: It tires to install them [15:30:35] i see [15:30:36] but fails downloading [15:31:02] :( [15:39:14] (03PS2) 10Thiemo Mättig (WMDE): Fix -> vs. > typo in DispatchStatsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188341 [15:44:26] (03CR) 10jenkins-bot: [V: 04-1] Fix -> vs. > typo in DispatchStatsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188341 (owner: 10Thiemo Mättig (WMDE)) [15:44:54] (03PS3) 10Thiemo Mättig (WMDE): Fix -> vs. > typo in DispatchStatsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188341 [15:49:31] jzerebecki: regarding data-values/javascript I have quickly talked about it last week with Librarization folks. I have filled https://phabricator.wikimedia.org/T88436 to have the library shipped in mediawiki/vendor [15:49:39] jzerebecki: lets follow up on the task [15:55:44] (03PS1) 10Aude: Control for namespace settings in NoLangLinkHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188379 [15:58:39] (03PS6) 10Thiemo Mättig (WMDE): Clean up introduction of usage tracking service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 [15:58:45] (03CR) 10Thiemo Mättig (WMDE): Clean up introduction of usage tracking service (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [15:59:41] (03CR) 10Aude: [C: 032] "works for me also, looks ok and actually hits the assertions now" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188341 (owner: 10Thiemo Mättig (WMDE)) [16:02:42] (03Merged) 10jenkins-bot: Fix -> vs. > typo in DispatchStatsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188341 (owner: 10Thiemo Mättig (WMDE)) [16:07:01] 3Wikidata: figure out current state of time storage and display - https://phabricator.wikimedia.org/T88437#1011614 (10Lydia_Pintscher) 3NEW [16:08:06] 3MediaWiki-extensions-WikibaseRepository, Wikidata: User interface displays false birth and death dates - https://phabricator.wikimedia.org/T87312#1011625 (10Lydia_Pintscher) Ok something is seriously wrong here obviously. I have filed T88437 for a thorough investigation and added it to the current development s... [16:43:40] [13WikibaseDataModel] 15thiemowmde created 06genericDiff (+1 new commit): 02http://git.io/bYZb [16:43:40] 13WikibaseDataModel/06genericDiff 14f28a0ec 15Thiemo Mättig: Introduce generic Item + Property differ [16:46:23] [13WikibaseDataModel] 15thiemowmde opened pull request #354: [RFC] Introduce generic Item + Property differ (06master...06genericDiff) 02http://git.io/bYcP [16:47:20] [13WikibaseDataModel] 15thiemowmde created 06self (+1 new commit): 02http://git.io/bYCB [16:47:20] 13WikibaseDataModel/06self 146a68c00 15Thiemo Mättig: Replace static with self [16:48:25] [13WikibaseDataModel] 15thiemowmde opened pull request #355: Replace static with self (06master...06self) 02http://git.io/bYWc [16:50:05] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Make language fallback indicators optional in EntityIdHtmlLinkFormatter - https://phabricator.wikimedia.org/T88422#1011712 (10Lydia_Pintscher) Where would you not want them? [16:50:30] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Make language fallback indicators optional in EntityIdHtmlLinkFormatter - https://phabricator.wikimedia.org/T88422#1011715 (10Lydia_Pintscher) [16:50:31] 3MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Wikidata: language fallback - https://phabricator.wikimedia.org/T76216#1011714 (10Lydia_Pintscher) [16:54:58] 3MediaWiki-extensions-WikibaseRepository, Wikidata: RDF output should contain license info about the concrete rendering, not only the abstract description document. - https://phabricator.wikimedia.org/T73991#1011721 (10Nevalicori) Looking at wikibase:repo/includes/rdf/RdfSerializer.php and friends, there are a f... [16:57:46] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Pass ContentLanguages instance using ULS to ValueView (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186229 (https://phabricator.wikimedia.org/T86653) (owner: 10Adrian Lang) [17:03:25] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Create a SpecialPage that allows to edit label, description and aliases together - https://phabricator.wikimedia.org/T72174#1011783 (10thiemowmde) Aude and I are suggesting to change the name to SetEntityTerms (which is pretty much a -1 for the patch). A generi... [17:07:46] Lydia_WMDE: TimeFormatter und MwTimeIsoFormatter [17:07:57] Any Spanish here? [17:08:19] https://www.wikidata.org/wiki/User:Licea_Formaci%C3%B3n - what is this? [17:11:13] It's about a training centre [17:11:16] I'll delete it [17:11:22] Ok thank you [17:11:23] It's spam, most likely [17:11:46] The talk page as well [17:11:52] wmde/WikibaseDataModel/genericDiff/f28a0ec : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/49340731 [17:11:57] * Jianhui67 is lazy :p [17:12:09] Should I block too? [17:12:52] I'm tempted [17:13:41] hi guys [17:13:44] Hi matej [17:13:48] I'll just block them [17:13:55] Their only contribs were advertising [17:13:59] I requested a lock [17:20:46] https://www.wikidata.org/w/index.php?title=Q11705469&curid=12841945&diff=193241452&oldid=184025667 Spanish again? [17:24:59] Me don't know spanish [17:25:42] I think I am going to learn Spanish [17:39:20] 3Wikidata, dev.wikimedia.org: Document the Wikidata API in the Developer Hub - https://phabricator.wikimedia.org/T359#1011916 (10Spage) p:5Low>3Normal a:3Spage [17:54:27] 3MediaWiki-extensions-WikibaseRepository, Wikidata: User interface displays false birth and death dates - https://phabricator.wikimedia.org/T87312#1011961 (10Accurimbono) Please fix ASAP. Thanks [18:08:17] (03PS1) 10Thiemo Mättig (WMDE): Fix HtmlTimeFormatter for negative years [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188397 [18:10:34] Lydia_WMDE: todo: redlink [18:12:01] hello, i have a question about data types! [18:12:27] i understand there is the basic 'string' and 'monolingual string' [18:12:57] then 'url' also seem like a subclass of string [18:19:57] despens: not a subclass. there is a distinction between the "value type" and the "data type". [18:20:10] despens: the data type "url" uses the value type "string". [18:20:18] ok! [18:20:36] is there an extension architecture for data types? [18:20:37] despens: the "monolingual text" data type uses a value type that is also called "monolingual text", because it has a special structure (text + language) [18:21:22] can i roll my own data type that does another kind of validation for example? [18:23:00] despens: yes and no - the code is designed to make this possible, but no registration machnism for new types is implemented yet [18:23:08] it's all hardcoded [18:23:14] it's one of the many loose ends [18:24:15] despens: https://phabricator.wikimedia.org/T77985 [18:24:59] despens: we are also considering a mechnism for specifying "type parameters" that would allow some kinds of constraints to be specified on-wiki [18:25:12] 3MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Wikidata: Figure what to do with MWException within Wikibase - https://phabricator.wikimedia.org/T88360#1012054 (10JanZerebecki) This ticket sounds like it was decided to move away from MWException for certain things. Could someone li... [18:25:14] (03PS1) 10Thiemo Mättig (WMDE): HtmlTimeFormatter should display unknown calendar models [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188400 [18:25:20] e.g. for the ISBN property, which has type "string", there xcould be a pattern specified on-wiki [18:25:30] i don't know whether this will ever happen, but i like the idea [18:25:56] despens: oh sorry, wrong bug... that one is for entity types, not data types. hm [18:26:37] DanielK_WMDE_: i would just like some strings that accept line breaks [18:27:16] yea. sadly, there is currently no easy way to add this. [18:27:23] i wonder if i could help with a gadget or if there is some deeper validation on the php level that would throw them out? [18:27:25] file a feature request :) [18:27:34] validation is all done in php [18:27:41] i see [18:27:46] ...and has to be [18:27:51] of course [18:27:55] otherwise, it would be easy to foo [18:27:58] *fool [18:28:19] monolingual text could support linebreaks maybe. [18:28:33] not sure, but sounds like a sensible request. if you can provide a good use case [18:28:38] file it on phabricator :) [18:28:41] yes that's what i thought [18:28:42] (03PS1) 10Thiemo Mättig (WMDE): Show calendar names instead of URIs in diffs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188403 [18:28:53] monolingual could use it [18:31:15] (03CR) 10jenkins-bot: [V: 04-1] Show calendar names instead of URIs in diffs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188403 (owner: 10Thiemo Mättig (WMDE)) [18:31:49] DanielK_WMDE_: thnx [18:34:09] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Provide a mechanism for registering new data types. - https://phabricator.wikimedia.org/T88451#1012074 (10daniel) 3NEW [18:34:19] despens: couldn't find the ticket, so i created one: https://phabricator.wikimedia.org/T88451 [18:34:34] for the extension mechanism, that is [18:34:46] please file the request fir linebreaks in monolingual text yourself :) [18:34:58] DanielK_WMDE_: thnx! just about to do it [18:35:05] [13Time] 15thiemowmde created 06bootstrap (+1 new commit): 02http://git.io/bOWA [18:35:05] 13Time/06bootstrap 14e9480bd 15Thiemo Mättig: Remove composer update from bootstrap [18:35:50] [13Time] 15thiemowmde opened pull request #31: Remove composer update from bootstrap (06master...06bootstrap) 02http://git.io/bOls [18:36:36] [13Time] 15thiemowmde created 06gregorian (+1 new commit): 02http://git.io/bOli [18:36:36] 13Time/06gregorian 140079ed3 15Thiemo Mättig: Do not always show "(Gregorian)" suffix [18:39:37] 3Wikidata: switch WikidataBuildResources composer sources from github to gerrit - https://phabricator.wikimedia.org/T88452#1012092 (10JanZerebecki) 3NEW [18:40:19] [13Time] 15thiemowmde opened pull request #32: [RFC] Do not always show "(Gregorian)" suffix (06master...06gregorian) 02http://git.io/bO42 [18:40:38] 3Wikidata: make building wikidata for deployment independent from external packagist.org - https://phabricator.wikimedia.org/T88453#1012101 (10JanZerebecki) 3NEW [18:41:16] 3Wikidata: switch WikidataBuildResources composer sources from github to gerrit - https://phabricator.wikimedia.org/T88452#1012107 (10JanZerebecki) Patch for wikibase.git : https://github.com/wmde/WikidataBuildResources/pull/19 [18:41:27] 3Wikidata: switch WikidataBuildResources composer sources from github to gerrit - https://phabricator.wikimedia.org/T88452#1012115 (10JanZerebecki) [18:42:35] 3Wikidata: make building wikidata for deployment independent from external packagist.org - https://phabricator.wikimedia.org/T88453#1012101 (10JanZerebecki) Possible solution is to only rely on full git repository URLs, like in https://github.com/wmde/WikidataBuildResources/pull/19 , see also T88452. [18:43:59] does anyone know if there is a property in wikibase that will allow multiline strings? [18:44:26] notconfusing: I think not [18:44:46] DanielK_WMDE_: https://phabricator.wikimedia.org/T88454?workflow=create [18:44:48] but see discussion above [18:45:03] dennyvrandecic, thanks [18:45:17] notconfusing: hi :) [18:45:25] hi despens [18:45:46] https://phabricator.wikimedia.org/T88454?workflow=create [18:48:05] i feel that there is no fundamental reason to disallow linebreaks, but per-property constraints would be really nice. [18:48:29] i think our current editing widgets don't support multi-line input, and it may not be trivial to introduce without breaking the layout. [18:48:42] let's see what happens to the bug report :) [18:49:06] I'd like to see the use case, really. Where does a linebreak really add to a motto, epigraph or slogan? [18:49:11] I can always just have them in one line [18:50:07] DanielK_WMDE_: Hitting enter on the keyboard saves the property, which is nice behaviour. Maybe Shift+Enter could be used to insert line breaks. In general it would be enough to be able to paste them. [18:53:18] despens: just have a little "multine" button that expands the input fields and changes the behavior of . [18:53:33] facebook does this for messages, no? [18:53:37] or was it twitter? [18:53:48] 3MediaWiki-extensions-WikibaseRepository, Wikidata: User interface displays false birth and death dates - https://phabricator.wikimedia.org/T87312#988640 (10thiemowmde) https://github.com/DataValues/Time/pull/32 See T88437#1012191 for mode details. [18:53:52] twitter doesn't [18:54:02] hey, before we talk about UI, let's first figure out if this is needed at all :) [18:54:29] dennyvrandecic: i think the button should be green :) [18:54:44] next thing is, we want italic text ... tsk [18:55:39] for certain types of text, line breaks are important, for example when a rhyme or alliteration is in place, or it was just authored like this [18:56:13] of course i could create single lines and connect them with 'before/after' :) [18:56:21] i do not disagree with that, but where in wikidata is it necessary to preserve that? [18:58:07] dennyvrandecic: maybe not for wikidata, but for EAGLE: http://www.eagle-network.eu/wiki/index.php/Main_Page [18:58:23] will try to add examples to the phab task, need to go now :) [18:58:23] then let EAGLE implement that :) [18:58:55] dennyvrandecic: but for that we at least need a decent extension point for adding data types [18:59:20] and it's easier to just allow line breaks than to code that :) [18:59:55] hmm, considering the effect on the UI that was discussed before, I am not sure about the long-term truth of your statement [19:00:20] yea, not sure about the ui issues. [19:00:39] anyway, enough for today. paxcking up & going home. [19:02:47] [13ValueView] 15thiemowmde comment on pull request #156 147223b8a: Is this gone? 02http://git.io/bOKb [19:03:17] [13ValueView] 15thiemowmde 04deleted 06generaldoc at 147223b8a: 02http://git.io/bO6L [19:06:11] Is there a way to query for references using WDQ, or some other tool? E.g. 'all subjects where the population data is from publisher X'? [19:06:35] valhallasw`cloud: definitively with the wikidata toolkit [19:08:20] 3Analytics, MediaWiki-General-or-Unknown, operations, Services, Wikidata, wikidata-query-service: Reliable publish / subscribe event bus - https://phabricator.wikimedia.org/T84923#1012242 (10GWicke) [19:12:27] dennyvrandecic: hm, okay. Unfortunately my java-fu is weak, so that would take me at least a week to get running. I'll take a look at the RDF dumps [19:25:40] 3MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Wikidata: Figure what to do with MWException within Wikibase - https://phabricator.wikimedia.org/T88360#1012312 (10Nemo_bis) [19:25:54] valhallasw`cloud: yes, they would include that too. If you have a strong enough SPARQL endpoint, you could just query that [19:30:27] dennyvrandecic: I'm just grepping wikidata-statements.nt.gz now on tool labs, which also seems to work :-) [19:31:04] valhallasw`cloud: sneaky. grep is awesome! like it's made for wikidata :) [19:34:59] valhallasw`cloud, dennyvrandecic: note that in our json dumps, each item is one line. that makes grepping awesome :) [19:35:07] DanielK_WMDE_: oooh. [19:35:27] yea, it's the little things... [19:35:30] * DanielK_WMDE_ is happy [19:35:31] I think those are also on tool labs somewhere, but a bit older. Let me check :-) [19:35:46] yeah, I quickly googled for incremental json parsers and decided 'meh, maybe not' [19:36:02] because the road to hell is paved with SAX parsers [19:36:34] [13ValueView] 15thiemowmde comment on pull request #154 144fe20c1: That space. 02http://git.io/bOxe [19:37:18] valhallasw`cloud: that's exactly why i wanted the dump to be that way! [19:37:38] ok, now for real. cu you tomorrow! [19:40:05] 'night DanielK_WMDE_ [20:22:52] ugh.... https://www.google.com/search?q=barack+obama+wikidata [20:22:59] "The president's symptoms are consistent with soft tissue inflammation related to acid reflux..." as the summary? [20:23:21] and not the description? [20:25:10] aude: it's the first complete sentence on the page [20:25:10] https://webcache.googleusercontent.com/search?q=cache:hdGz3PkNU08J:www.wikidata.org/wiki/Q76+&cd=1&hl=en&ct=clnk&gl=nl [20:25:35] hm [20:26:05] but there are ways to define the text, I think. I just found https://support.google.com/webmasters/answer/35624?hl=en [20:26:32] https://www.google.com/search?q=new+york+wikidata&ie=utf-8&oe=utf-8 is [20:26:33] Rich snippets would be great. [20:26:33] 7 days ago - largest city in New York and the United States of America [edit]. Also known as: NYC; New York; City of New York; New York, New York; The Big [20:26:42] [edit] [20:28:05] meta descriptions is something we could do [20:37:05] 3Wikidata: Add meta description in the header for Wikibase pages - https://phabricator.wikimedia.org/T88475#1012585 (10aude) 3NEW [20:37:36] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Add meta description in the header for Wikibase pages - https://phabricator.wikimedia.org/T88475#1012594 (10aude) [20:39:13] hmm, "wikidata bill clinton" does not give the president [20:44:46] "muse band wikidata" is also weird. [20:45:05] The first item is about the goddesses, but the title of it is "Muse (band)" [20:46:00] ah, i can't view any item of any president it seems (due to stupid chrome bug) [20:46:11] It's a feature. ;) [20:46:22] heh [20:46:32] german leaders, etc. not a problem [21:00:37] aaaaah, think i figured it out! [21:12:33] https://arc.wikipedia.org/wiki/%DC%A2%DC%9D%DC%98_%DC%9D%DC%98%DC%AA%DC%A9_%28%DC%A1%DC%95%DC%9D%DC%A2%DC%AC%DC%90%29 [21:12:37] completely broken :( [21:14:38] 3Language-Engineering, Wikidata: dvwiki link (font) causes page to crash in chrome 40.* and doesn't render in firefox - https://phabricator.wikimedia.org/T88478#1012701 (10aude) https://arc.wikipedia.org/wiki/%DC%A2%DC%9D%DC%98_%DC%9D%DC%98%DC%AA%DC%A9_%28%DC%A1%DC%95%DC%9D%DC%A2%DC%AC%DC%90%29 and https://dv... [21:15:53] chrome 42 is ok [21:15:59] good :) [21:16:15] or at least, it doesn't crash :P [21:16:16] probably nothing we can do and chrome people know [21:16:19] or working on it [21:16:38] at least if someone has the problem, they know why and can use firefox [21:16:38] FF 36 seems ok too [21:16:43] yeah [21:17:20] was embarrasing to have the item crash when showing on the projector at wmf :( [21:17:30] * aude will avoid those items or avoid chrome [21:19:59] 3Language-Engineering, Wikidata: dvwiki link (font) causes page to crash in chrome 40.* and doesn't render in firefox - https://phabricator.wikimedia.org/T88478#1012721 (10aude) 40.0.2214.94 was released as stable for osx on Jan 29: http://www.chromium.org/developers/calendar hopefully bug fix release is out s...