[00:12:36] 3Wikidata, MediaWiki-extensions-WikibaseClient: Wikipedia RSS feeds show Wikidata changes very confusingly. - https://phabricator.wikimedia.org/T88254#1007192 (10hoo) [02:33:54] Hello, can any answer me a question [02:33:56] ? [02:35:28] If I add some descriptions in any language, it is necesary that the article is on that wikipedia language? [02:37:17] BlackBeast: No, not at all [02:37:33] Wikidata is independent from Wikipedia and any other Wikimedia sites content-wise [02:37:44] We even support languages that don't (yet) have a Wikipedia [02:38:37] Oh my, so I can add in three languages I know then? [02:38:44] That's great.. [02:44:27] Yeah, if they're supported in Wikidata (which they're probably are) :) [02:59:19] <[q> any plan for phase 3 yet? [03:01:06] [q: We're no longer really planing in the phases, they were just a very basic overview of our roadmap [03:01:17] https://www.wikidata.org/wiki/Wikidata:Development_plan [03:01:23] Is way better as a reference these days :) [08:36:37] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Redirect loop on mobile diffs (wikidata) - https://phabricator.wikimedia.org/T88029#1007733 (10Lydia_Pintscher) [08:39:31] (03PS4) 10Thiemo Mättig (WMDE): Drop unused code from and clean up Api\EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186151 [08:42:22] (03CR) 10Thiemo Mättig (WMDE): Drop unused code from and clean up Api\EditEntity (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186151 (owner: 10Thiemo Mättig (WMDE)) [08:54:59] (03PS5) 10Thiemo Mättig (WMDE): Clean up introduction of usage tracking service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 [08:55:09] (03CR) 10Thiemo Mättig (WMDE): Clean up introduction of usage tracking service (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [09:02:31] (03CR) 10Thiemo Mättig (WMDE): Drop unused code from Special:NewEntity and subclasses (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187671 (owner: 10Thiemo Mättig (WMDE)) [09:03:08] (03PS2) 10Thiemo Mättig (WMDE): Drop unused code from Special:NewEntity and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187671 [09:40:26] (03PS13) 10Henning Snater: Using textarea for entering description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) [09:41:18] 3Wikidata, MediaWiki-extensions-WikibaseRepository: different styling for label/alias and description input - https://phabricator.wikimedia.org/T87576#1007909 (10Snaterlicious) Applied in patch set 13 of https://gerrit.wikimedia.org/r/#/c/183866/. [10:00:01] (03PS14) 10Henning Snater: Using textarea for entering description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) [10:00:37] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Please uppercase the "Formatters" and "Parsers" path names so we do not have to move the files twice." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181555 (owner: 10Daniel Kinzler) [10:07:24] (03CR) 10Thiemo Mättig (WMDE): Move data type code to separate directory. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181555 (owner: 10Daniel Kinzler) [10:15:29] Lydia_WMDE: I've read something about usage tracking. This will be deployed today huh? My question: was there a similar function and is that function already disabled? I need to manually purge every page with commonscat to get them out of my maintenance category. [10:16:05] https://nl.wikipedia.org/wiki/Categorie:Wikipedia:Commonscat_zonder_link_op_Wikidata The number of categories and pages doubled. [10:18:09] sjoerddebruin: Hey :) it should not be live anywhere yet. aude is working on getting it enabled on wikidata. i am not sure of the status of that because she is traveling and was away for the summit and i was at fosdem [10:18:29] after wikidata is working we plan to enable it on commons next [10:18:41] Yeah, but was there a similar function before? [10:18:53] there shouldn't have been no [10:19:34] A refresh would do before, now I need to purge or even null edit every page that i've added the commonscat from to Wikidata. [10:19:52] There are even false postives in the list. [10:22:45] hmmmm [10:23:05] nothing should have changed in that regard for all i know but maybe DanielK_WMDE can say more [10:27:30] Lydia_WMDE: hey! i'm at ur office, stealign ur cookies! [10:29:03] sjoerddebruin, Lydia_WMDE: usage trackign was previously done via the sitelinsk directly, since that is currently the only way to "use" an item. in the database, that would be wb_items_per_site [10:29:25] Have something changed in the last few weeks? [10:29:45] sjoerddebruin: the way we manage the sidebar links in the parser cache was changed, i think [10:29:48] to improve performance [10:30:00] i'm a bit out of the loop, just getting back into things today [10:30:14] aude knows better which changes were deplyoed when [10:30:48] sjoerddebruin: can you describe the problem in more details? what needs to be purged under which circumstance to achieve what? what is the expected behavior, and what happens instead? [10:32:34] Previous, when I added the commonscat of a page to Wikidata (by adding P373) the page would disappear from the maintenance category on Wikipedia after a normal refresh. Now I need to purge the page on Wikipedia to get it out of the list. [10:33:08] The category also lists some false positives: pages with a commonscat and P373... [10:38:23] (03PS2) 10Hashar: Correct wrong jshint config name [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [10:38:57] (03CR) 10Hashar: "There is a bunch of functions in src/RepoApi.js that would need to be fixed though." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [10:39:03] (03CR) 10Hashar: [C: 04-1] Correct wrong jshint config name [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [10:39:16] (03CR) 10jenkins-bot: [V: 04-1] Correct wrong jshint config name [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [10:39:45] DanielK_WMDE: whuuuut? [10:45:34] Lydia_WMDE: the office is empty without you, and i have tons to talk about ;) but it can wait until tomorrow, i'll be busy with my mail backlog anyway [10:55:23] 3Wikidata, MediaWiki-extensions-WikibaseRepository: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1007968 (10daniel) 3NEW [10:55:37] 3Wikidata, MediaWiki-extensions-WikibaseRepository: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1007976 (10daniel) p:5Triage>3Normal [10:56:49] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Typing a property ID in entity-selector does not trigger "selected" event - https://phabricator.wikimedia.org/T87767#1007981 (10Snaterlicious) Seems to work with https://gerrit.wikimedia.org/r/#/c/186963/. [10:56:53] Lydia_WMDE: Deploy *check* [10:57:19] Also deployed the configuration patch for ConfirmEdit, works like a charm for me (one can add URLs as anon again) [10:58:42] (03PS8) 10Henning Snater: Overhauled snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186963 [11:06:13] hoo: sweet [11:06:16] DanielK_WMDE: awwwww :D [11:06:20] DanielK_WMDE: yeah let's have a chat tomorrow then [11:12:29] (03CR) 10Hoo man: [C: 032] "Manually verified" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187671 (owner: 10Thiemo Mättig (WMDE)) [11:16:12] (03Merged) 10jenkins-bot: Drop unused code from Special:NewEntity and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187671 (owner: 10Thiemo Mättig (WMDE)) [11:18:15] 3Wikidata, MediaWiki-extensions-WikibaseRepository: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1007988 (10Lydia_Pintscher) p:5Normal>3High [11:18:53] 3Wikidata, MediaWiki-extensions-WikibaseRepository: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1007968 (10Lydia_Pintscher) [11:18:55] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository: language fallback - https://phabricator.wikimedia.org/T76216#1007991 (10Lydia_Pintscher) [11:20:25] (03CR) 10Hoo man: [C: 032] Drop unused code from and clean up Api\EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186151 (owner: 10Thiemo Mättig (WMDE)) [11:21:41] 3Wikidata, MediaWiki-extensions-WikibaseRepository: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1007994 (10Snaterlicious) Currently, at least regarding displaying the Property label, the `snakview` redraws its DOM on initializ... [11:23:13] * hoo leaving [11:23:55] 3Wikidata, MediaWiki-extensions-WikibaseClient: Wikipedia RSS feeds show Wikidata changes very confusingly. - https://phabricator.wikimedia.org/T88254#1007999 (10Lydia_Pintscher) p:5Triage>3Normal See also T78493. [11:24:09] (03Merged) 10jenkins-bot: Drop unused code from and clean up Api\EditEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186151 (owner: 10Thiemo Mättig (WMDE)) [11:24:29] 3Wikidata, MediaWiki-extensions-WikibaseClient: Convert WikibaseClient to use extension registration - https://phabricator.wikimedia.org/T88258#1008003 (10Lydia_Pintscher) [11:24:39] 3Wikidata, MediaWiki-extensions-WikibaseClient: Convert WikibaseClient to use extension registration - https://phabricator.wikimedia.org/T88258#1008005 (10Lydia_Pintscher) p:5Triage>3Normal [11:28:49] (03CR) 10Jeroen De Dauw: "Looks reasonable so far. The name is somewhat unfortunate considering we already have a repo called DataTypes. OTOH, that repo does not ju" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181555 (owner: 10Daniel Kinzler) [11:30:28] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Double escaping in restore failure message - https://phabricator.wikimedia.org/T59533#1008030 (10Lydia_Pintscher) [11:32:34] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Reduce snakview / snakview.variations.Value complexity - https://phabricator.wikimedia.org/T88271#1007886 (10Lydia_Pintscher) [11:48:16] (03CR) 10Jeroen De Dauw: [C: 04-1] "This does design wise code rot. Adding new methods to the interface is suspect, and so is adding new public methods the the implementation" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) (owner: 10Hoo man) [11:50:15] (03CR) 10Jeroen De Dauw: [C: 031] Replace usage of deprecated ApiResult::disableSizeCheck [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187938 (owner: 10Hoo man) [11:53:23] (03CR) 10Jeroen De Dauw: [C: 031] Clean up introduction of usage tracking service [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [11:56:48] (03CR) 10Hoo man: "Could you please be more specific here and show a way forward?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) (owner: 10Hoo man) [11:58:29] (03CR) 10Jeroen De Dauw: [C: 031] "What motivated the addition of behavior to this code? Where is it needed?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [12:07:54] (03CR) 10Daniel Kinzler: "@jeroen: yes, that was the idea. The patch as it is is really an experiment to see how well the split works. But I still need a good way t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181555 (owner: 10Daniel Kinzler) [12:20:56] (03PS1) 10Henning Snater: SnakTypeSelector: Updated code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188039 [12:20:58] (03PS1) 10Henning Snater: SnakTypeSelector: Removed unnecessary code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188040 [12:39:24] https://www.wikidata.org/wiki/Wikidata:Status_updates/Next <- anyone got anything to add to the weekly summary? [13:21:52] [13ValueView] 15thiemowmde created 06typehint (+1 new commit): 02http://git.io/bvSQ [13:21:52] 13ValueView/06typehint 14e532a15 15Thiemo Mättig: Fix wrong type in TimeInput [13:22:09] [13ValueView] 15thiemowmde opened pull request #155: Fix wrong type in TimeInput (06master...06typehint) 02http://git.io/bv9e [13:31:54] [13ValueView] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/bv7t [13:31:54] 13ValueView/06master 14bc50544 15Marius Hoch: Merge pull request #155 from wmde/typehint... [13:32:59] [13Diff] 15thiemowmde created 06deprecated (+1 new commit): 02http://git.io/bv74 [13:32:59] 13Diff/06deprecated 142b1835f 15Thiemo Mättig: Make @deprecated tags more descriptive [13:34:59] [13Diff] 15thiemowmde opened pull request #33: Make @deprecated tags more descriptive (06master...06deprecated) 02http://git.io/bv5t [13:35:03] wmde/Diff#129 (deprecated - 2b1835f : Thiemo Mättig): The build passed. [13:35:03] Change view : https://github.com/wmde/Diff/commit/2b1835f285cc [13:35:03] Build details : http://travis-ci.org/wmde/Diff/builds/49178309 [13:45:39] [13WikibaseSerializationJavaScript] 15thiemowmde created 06unusedJq (+1 new commit): 02http://git.io/bvb5 [13:45:39] 13WikibaseSerializationJavaScript/06unusedJq 14d99823d 15Thiemo Mättig: Drop unused jQuery global [14:00:02] Lydia_WMDE, Tobi_WMDE_SW_NA: fyi https://phabricator.wikimedia.org/T78639 [14:03:36] DanielK_WMDE: thx [14:10:26] [13WikibaseSerializationJavaScript] 15mariushoch closed pull request #14: Drop unused jQuery global (06master...06unusedJq) 02http://git.io/bvbb [14:10:33] [13WikibaseSerializationJavaScript] 15mariushoch 04deleted 06unusedJq at 14d99823d: 02http://git.io/bfJ8 [14:15:45] [13WikibaseInternalSerialization] 15thiemowmde created 06unused (+1 new commit): 02http://git.io/bfTz [14:15:45] 13WikibaseInternalSerialization/06unused 14a98fbbd 15Thiemo Mättig: Drop unused code from RealEntitiesTest [14:15:55] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #42: Drop unused code from RealEntitiesTest (06master...06unused) 02http://git.io/bfT6 [14:17:28] [13WikibaseInternalSerialization] 15thiemowmde created 06warnings (+1 new commit): 02http://git.io/bfkk [14:17:28] 13WikibaseInternalSerialization/06warnings 146ed58c4 15Thiemo Mättig: Fix code sniffer warnings [14:18:02] wmde/WikibaseInternalSerialization/unused/a98fbbd : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/49182651 [14:20:12] wmde/WikibaseInternalSerialization/warnings/6ed58c4 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/49182842 [14:21:38] (03PS1) 10Henning Snater: snakview.variations*: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188047 [14:21:40] (03PS1) 10Henning Snater: snakview.ViewState: Updated documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188048 [14:21:42] (03PS1) 10Henning Snater: Removed obsolete snakview.isDisabled() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188049 [14:22:39] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Use "assistant languages" from the Translate extension for the term box, etc. - https://phabricator.wikimedia.org/T88284#1008218 (10daniel) 3NEW [14:22:48] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #43: Fix code sniffer warnings (06master...06warnings) 02http://git.io/bfLu [14:23:38] [13WikibaseInternalSerialization] 15thiemowmde created 06entityDeserialize (+1 new commit): 02http://git.io/bftU [14:23:38] 13WikibaseInternalSerialization/06entityDeserialize 148c78098 15Thiemo Mättig: Refactor legacy Item/Property deserialization [14:25:48] [13WikibaseInternalSerialization] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/bfqq [14:25:48] 13WikibaseInternalSerialization/06master 1449305c0 15Marius Hoch: Merge pull request #43 from wmde/warnings... [14:25:55] [13WikibaseInternalSerialization] 15mariushoch 04deleted 06warnings at 146ed58c4: 02http://git.io/bfqm [14:26:47] wmde/WikibaseInternalSerialization/entityDeserialize/8c78098 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/49183495 [14:27:11] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #44: Refactor legacy Item/Property deserialization (06master...06entityDeserialize) 02http://git.io/bfmf [14:30:18] wmde/WikibaseInternalSerialization/master/49305c0 : Marius Hoch The build has errored. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/49183816 [14:31:48] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Use "assistant languages" from the Translate extension for the term box, etc. - https://phabricator.wikimedia.org/T88284#1008234 (10Lydia_Pintscher) Don't we do that already for the cases where the user has no babel box? [14:32:50] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Use "assistant languages" from the Translate extension for the term box, etc. - https://phabricator.wikimedia.org/T88284#1008236 (10Nemo_bis) Thanks for looking into this! This proposal makes sense in theory and as a stopgap solution for the users using this p... [14:34:22] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Use "assistant languages" from the Translate extension for the term box, etc. - https://phabricator.wikimedia.org/T88284#1008242 (10Nemo_bis) >>! In T88284#1008234, @Lydia_Pintscher wrote: > Don't we do that already for the cases where the user has no babel box... [14:37:51] [13WikibaseInternalSerialization] 15mariushoch comment on pull request #44 148c78098: This is going to silently return null if the array key doesn't exist, which is inconsistent with the old behaviour AFAIS. 02http://git.io/bf3A [14:52:48] [13WikibaseDataModelSerialization] 15thiemowmde created 06propType (+1 new commit): 02http://git.io/bfWi [14:52:49] 13WikibaseDataModelSerialization/06propType 1496cbd12 15Thiemo Mättig: Fix wrong type hint in PropertySerializer [14:55:30] [13WikibaseDataModelSerialization] 15thiemowmde created 06deprConsts (+1 new commit): 02http://git.io/bf83 [14:55:30] 13WikibaseDataModelSerialization/06deprConsts 14d54f96a 15Thiemo Mättig: Replace deprecated constants [14:55:40] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #106: Replace deprecated constants (06master...06deprConsts) 02http://git.io/bf8l [14:55:41] wmde/WikibaseDataModelSerialization/propType/96cbd12 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/49187269 [14:56:37] [13WikibaseDataModelSerialization] 15thiemowmde created 06deprPrefix (+1 new commit): 02http://git.io/bf8y [14:56:37] 13WikibaseDataModelSerialization/06deprPrefix 147a92b16 15Thiemo Mättig: Replace deprecated getPrefixedId [14:56:45] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #107: Replace deprecated getPrefixedId (06master...06deprPrefix) 02http://git.io/bf8H [14:57:52] [13WikibaseDataModelSerialization] 15thiemowmde created 06deadCode (+1 new commit): 02http://git.io/bf42 [14:57:52] 13WikibaseDataModelSerialization/06deadCode 148ee9c4d 15Thiemo Mättig: Drop dead code from SnakDeserializerTest [14:58:51] wmde/WikibaseDataModelSerialization/deprConsts/d54f96a : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/49187599 [14:58:52] [13WikibaseDataModelSerialization] 15thiemowmde created 06itemType (+1 new commit): 02http://git.io/bfB3 [14:58:52] 13WikibaseDataModelSerialization/06itemType 14b10f4c0 15Thiemo Mättig: Fix wrong type hint in ItemSerializer [14:58:55] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Language fallbacks not applied to qualifier properties - https://phabricator.wikimedia.org/T88286#1008258 (10matej_suchanek) 3NEW [14:59:27] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #109: Fix wrong type hint in ItemSerializer (06master...06itemType) 02http://git.io/bfBB [14:59:42] (03CR) 10Anomie: [C: 031] "Seems sane from a MediaWiki standpoint." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187938 (owner: 10Hoo man) [14:59:55] [13WikibaseDataModelSerialization] 15mariushoch closed pull request #105: Fix wrong type hint in PropertySerializer (06master...06propType) 02http://git.io/bfWD [15:00:02] [13WikibaseDataModelSerialization] 15mariushoch 04deleted 06propType at 1496cbd12: 02http://git.io/bfB9 [15:00:17] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Language fallbacks not applied to qualifier properties - https://phabricator.wikimedia.org/T88286#1008266 (10matej_suchanek) [15:00:19] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository: language fallback - https://phabricator.wikimedia.org/T76216#1008267 (10matej_suchanek) [15:00:20] 3Wikidata, MediaWiki-extensions-WikibaseRepository: redesign statement section - https://phabricator.wikimedia.org/T87316#1008268 (10matej_suchanek) [15:00:35] [13WikibaseDataModelSerialization] 15mariushoch closed pull request #106: Replace deprecated constants (06master...06deprConsts) 02http://git.io/bf8l [15:01:24] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Language fallbacks not applied to qualifier properties - https://phabricator.wikimedia.org/T88286#1008269 (10Lydia_Pintscher) [15:01:24] [13WikibaseDataModelSerialization] 15thiemowmde created 06newEmpty (+1 new commit): 02http://git.io/bfR9 [15:01:24] 13WikibaseDataModelSerialization/06newEmpty 1433ca0cc 15Thiemo Mättig: Favor constructors over newEmpty [15:01:27] 3Wikidata, MediaWiki-extensions-WikibaseRepository: No language fallback applied for property labels on qualifiers and references in JS UI. - https://phabricator.wikimedia.org/T88275#1008270 (10Lydia_Pintscher) [15:02:49] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #110: Favor constructors over newEmpty (06master...06newEmpty) 02http://git.io/bf0z [15:03:05] wmde/WikibaseDataModelSerialization/deprPrefix/7a92b16 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/49187792 [15:05:21] wmde/WikibaseDataModelSerialization/deadCode/8ee9c4d : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/49188100 [15:08:35] [13WikibaseDataModelSerialization] 15JeroenDeDauw 04deleted 06deprPrefix at 147a92b16: 02http://git.io/bfzS [15:10:01] wmde/WikibaseDataModelSerialization/itemType/b10f4c0 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/49188313 [15:13:07] [13WikibaseDataModelJavaScript] 15thiemowmde created 06unusedJq (+1 new commit): 02http://git.io/bfaY [15:13:07] 13WikibaseDataModelJavaScript/06unusedJq 14e62bfa9 15Thiemo Mättig: Drop unused jQuery global [15:13:22] [13WikibaseDataModelJavaScript] 15thiemowmde opened pull request #24: Drop unused jQuery global (06master...06unusedJq) 02http://git.io/bfau [15:14:02] [13WikibaseDataModelJavaScript] 15thiemowmde created 06elseif (+1 new commit): 02http://git.io/bfaN [15:14:02] 13WikibaseDataModelJavaScript/06elseif 14cd5de55 15Thiemo Mättig: Untangle else if chain [15:15:12] [13WikibaseDataModelJavaScript] 15thiemowmde opened pull request #25: Untangle else if chain (06master...06elseif) 02http://git.io/bfV5 [15:15:47] wmde/WikibaseDataModelSerialization/newEmpty/33ca0cc : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/49188645 [15:16:47] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Redirect loop on mobile diffs (wikidata) - https://phabricator.wikimedia.org/T88029#1008300 (10JanZerebecki) [15:19:14] [13WikibaseInternalSerialization] 15thiemowmde comment on pull request #44 148c78098: This does not change semantics as far as I can tell. Look how the old code was arranged:... 02http://git.io/bfoq [15:31:59] [13WikibaseInternalSerialization] 15mariushoch comment on pull request #44 148c78098: Ah I see... that makes sense. 02http://git.io/bf15 [15:33:14] [13WikibaseInternalSerialization] 15mariushoch closed pull request #44: Refactor legacy Item/Property deserialization (06master...06entityDeserialize) 02http://git.io/bfmf [15:35:28] [13WikibaseDataModelJavaScript] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/bfDV [15:35:28] 13WikibaseDataModelJavaScript/06master 144504b0a 15Marius Hoch: Merge pull request #24 from wmde/unusedJq... [15:36:08] wmde/WikibaseInternalSerialization/master/17c55b0 : Marius Hoch The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/49192479 [15:37:01] [13WikibaseDataModelSerialization] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/bfys [15:37:01] 13WikibaseDataModelSerialization/06master 14e0aa731 15Marius Hoch: Merge pull request #109 from wmde/itemType... [15:37:36] (03CR) 10Jeroen De Dauw: [C: 032] SnakTypeSelector: Updated code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188039 (owner: 10Henning Snater) [15:38:17] (03CR) 10Jeroen De Dauw: [C: 031] SnakTypeSelector: Removed unnecessary code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188040 (owner: 10Henning Snater) [15:39:00] (03CR) 10Aude: [C: 032] Replace usage of deprecated ApiResult::disableSizeCheck [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187938 (owner: 10Hoo man) [15:39:11] [13WikibaseDataModelSerialization] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/bfSz [15:39:11] 13WikibaseDataModelSerialization/06master 148874ae2 15Marius Hoch: Merge pull request #110 from wmde/newEmpty... [15:43:17] (03Merged) 10jenkins-bot: Replace usage of deprecated ApiResult::disableSizeCheck [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187938 (owner: 10Hoo man) [15:44:11] [13DataValues] 15thiemowmde created 06getCopy (+1 new commit): 02http://git.io/bf79 [15:44:11] 13DataValues/06getCopy 14f1addb0 15Thiemo Mättig: Correct type hint for DataValue::getCopy [15:45:31] [13DataValues] 15thiemowmde opened pull request #16: Correct type hint for DataValue::getCopy (06master...06getCopy) 02http://git.io/bf5E [15:51:26] [13DataValues] 15mariushoch closed pull request #16: Correct type hint for DataValue::getCopy (06master...06getCopy) 02http://git.io/bf5E [15:52:14] Mh even using @return self in Copyable::getCopy wouldn't work... at least Netbeans isn't smart enough for that [15:53:37] aude: Did you yet start the propagation? :) [15:54:18] [13DataValues] 15thiemowmde created 06unDesTest (+1 new commit): 02http://git.io/bfA4 [15:54:18] 13DataValues/06unDesTest 1421ce16e 15Thiemo Mättig: Clean up UnDeserializableValueTest [15:55:43] [13DataValues] 15thiemowmde opened pull request #17: Clean up UnDeserializableValueTest (06master...06unDesTest) 02http://git.io/bfxZ [16:01:35] [13DataValues] 15thiemowmde created 06copyable (+1 new commit): 02http://git.io/bfjj [16:01:35] 13DataValues/06copyable 147e90f85 15Thiemo Mättig: Drop unused Copyable interface [16:03:40] [13DataValues] 15thiemowmde opened pull request #18: Drop unused Copyable interface (06master...06copyable) 02http://git.io/bJej [16:04:23] hoo: doing [16:05:01] aude: Ok :) Keep me update [16:05:03] d [16:05:34] [13DataValues] 15thiemowmde 04force-pushed 06copyable from 147e90f85 to 1477ea8d7: 02http://git.io/bJfs [16:05:34] 13DataValues/06copyable 1477ea8d7 15Thiemo Mättig: Drop unused Copyable interface [16:07:00] ok [16:07:03] made the table :) [16:10:11] hoo: done :) [16:10:13] super quick [16:10:37] 1355 usages [16:11:20] which wiki? [16:12:03] ah wikidata :) [16:12:09] yes [16:12:35] i'll run the script when we enable, just in case something is edited [16:12:41] again* [16:13:52] Sounds good :) [16:14:15] [13DataValues] 15mariushoch 04deleted 06unDesTest at 1421ce16e: 02http://git.io/bJIC [16:29:18] [13DataValuesJavascript] 15thiemowmde created 06warnings (+1 new commit): 02http://git.io/bJsJ [16:29:18] 13DataValuesJavascript/06warnings 142ea6f37 15Thiemo Mättig: Fix some code style warnings [16:30:14] [13DataValuesJavascript] 15thiemowmde opened pull request #60: Fix some code style warnings (06master...06warnings) 02http://git.io/bJs2 [16:30:45] so, my chrome bug appears to be a rtl rendering issue [16:30:51] and is actually a bug :/ [16:31:36] :/ [16:31:47] So removing ar from your Babel would "fix" it? [16:31:51] i did [16:31:57] rtl still appears in site links [16:32:09] Oh right [16:32:09] and not every rtl is a problem [16:32:14] mh [16:32:21] Is it apple specific? [16:32:25] [13DataValues] 15thiemowmde 04force-pushed 06copyable from 1477ea8d7 to 148e53beb: 02http://git.io/bJfs [16:32:25] 13DataValues/06copyable 148e53beb 15Thiemo Mättig: Drop unused Copyable interface [16:32:29] if it really is *just* me, then i can use firefox [16:32:36] don't know, maybe [16:33:57] [13DataValues] 15mariushoch 04deleted 06equals at 144af83b2: 02http://git.io/bJZG [16:35:31] [13DataValues] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/bJZA [16:35:31] 13DataValues/06master 1477fa083 15Marius Hoch: Merge pull request #15 from DataValues/unserialize... [16:36:21] omg https://www.wikidata.org/wiki/Q1861 (such a long alias!) [16:36:29] for german [16:36:49] clicking edit is a bit odd [16:37:56] aude: That's apparently the transcript of the actual full Thai name... :P [16:38:05] And Germans just love long words/ names :D [16:39:12] heh [16:39:42] 3Wikidata, MediaWiki-extensions-WikibaseRepository: "other language" boxes overlaps with site links for long aliases - https://phabricator.wikimedia.org/T88293#1008460 (10aude) [16:40:09] [13Number] 15thiemowmde created 06docs (+1 new commit): 02http://git.io/bJC2 [16:40:09] 13Number/06docs 1476ab5cf 15Thiemo Mättig: Fix outdated PHPDoc tags [16:40:31] [13Number] 15thiemowmde opened pull request #18: Fix outdated PHPDoc tags (06master...06docs) 02http://git.io/bJCX [16:43:36] * Thiemo_WMDE sends a virtual muffin to hoo [16:43:52] :) [16:49:48] JeroenDeDauw: i think i saw you some minutes ago, is that possible? [16:50:15] hoo: https://twitter.com/maettig/status/561933996880572419 [16:50:56] Lecker :) [17:00:32] [13Serialization] 15thiemowmde created 06catch (+1 new commit): 02http://git.io/bJ2N [17:00:32] 13Serialization/06catch 14cf4a115 15Thiemo Mättig: Drop duplicate catch [17:02:30] [13Serialization] 15thiemowmde opened pull request #8: Drop duplicate catch (06master...06catch) 02http://git.io/bJVY [17:09:36] [13Time] 15thiemowmde created 06uses (+1 new commit): 02http://git.io/bJKm [17:09:36] 13Time/06uses 14b4c06f6 15Thiemo Mättig: Drop unused use clause [17:46:33] (03PS1) 10Thiemo Mättig (WMDE): Use Item constructor instead of newEmpty + setId in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188071 [17:47:42] (03PS1) 10Thiemo Mättig (WMDE): Use Item constructor instead of newEmpty + setId in maintenance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188073 [17:50:14] (03CR) 10jenkins-bot: [V: 04-1] Use Item constructor instead of newEmpty + setId in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188071 (owner: 10Thiemo Mättig (WMDE)) [17:51:20] (03CR) 10jenkins-bot: [V: 04-1] Use Item constructor instead of newEmpty + setId in maintenance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188073 (owner: 10Thiemo Mättig (WMDE)) [17:52:58] (03PS1) 10Aude: Fix typo in SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188077 [17:56:31] (03CR) 10jenkins-bot: [V: 04-1] Fix typo in SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188077 (owner: 10Aude) [18:00:19] (03CR) 10Daniel Kinzler: "This patch seems to do three things:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [18:05:00] bah, jenkins broken? [18:05:28] * aude screeeeeeeeeeam! [18:08:33] (03PS2) 10Aude: Fix typo in SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188077 [18:10:40] !admin [18:11:25] andrawaag: What's up? [18:11:31] Due to a bug in the bot, quite some dupes were added. I am currently adding them through the Requests_for_deletions page [18:12:07] GeorgeEdwardC: ^ [18:12:07] but is there a way to just revert all pages created since say yesterday? [18:12:16] nope [18:14:00] andrawaag: well, you can make a request for multiple pages, if they are all dupes. no reason to list them all individually. [18:16:54] (03CR) 10Daniel Kinzler: [C: 04-1] "Thanks for the cleanup! There are just a few things I disagree with." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [18:17:09] I nuked them, but if there's more... [18:17:15] Maybe a bot? [18:17:54] andrawaag: Kind of [18:28:19] (03CR) 10Daniel Kinzler: "Would be +2 if it wasn't for the documentation error." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) (owner: 10Hoo man) [18:35:14] (03CR) 10Daniel Kinzler: [C: 031 V: 04-1] "yea, looks fine, needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186770 (owner: 10Thiemo Mättig (WMDE)) [18:41:52] (03CR) 10Daniel Kinzler: [C: 04-1] "This patch introduces a bunch of new code pathes, but no new test cases." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187344 (https://phabricator.wikimedia.org/T87096) (owner: 10Adrian Lang) [19:12:38] enabled usage tracking on wikidata :) [19:12:53] AWESOME! [19:13:11] Anyway we can test it and see it in action? [19:16:30] well.... i tried https://www.wikidata.org/wiki/User:Aude [19:16:42] it's a known issue, we don't track yet for this label usage :/ [19:16:52] or maybe not for user pages [19:17:41] https://www.wikidata.org/wiki/Wikidata:Sandbox works [19:18:08] 2949 | item | Q42 | X | 707 [19:18:16] 2950 | item | Q5 | X | 707 [19:19:02] header makes them spaces. [19:20:13] aude: Might be that it's not working in NS_USER because that's not a wikibase client NS [19:21:26] hoo: probably [19:23:16] 3Wikidata, MediaWiki-extensions-WikibaseRepository: "other language" boxes overlaps with site links for long aliases - https://phabricator.wikimedia.org/T88293#1008984 (10Lydia_Pintscher) p:5Triage>3Normal [19:25:13] 3Wikidata, MediaWiki-extensions-WikibaseRepository: "other language" boxes overlaps with site links for long aliases - https://phabricator.wikimedia.org/T88293#1008453 (10Lydia_Pintscher) [19:25:18] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Redesign header - https://phabricator.wikimedia.org/T75654#1009034 (10Lydia_Pintscher) [19:27:08] 3Wikidata, MediaWiki-extensions-WikibaseRepository: "other language" boxes overlaps with site links for long aliases - https://phabricator.wikimedia.org/T88293#1009045 (10aude) ...or at least ensure this sort of alias is handled in a decent way in the new header and term box. :) [19:29:37] Will we branch this week? [19:30:22] wasn't planning on it [19:30:32] if the new ui stuff is ready, maybe we can [19:30:36] Lydia_WMDE: ^ [19:31:13] i think that's reason we branched a week ago [19:31:23] aude: not ready yet for all i can tell atm [19:31:48] (03CR) 10Hoo man: Make UpdateRepo more robust (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) (owner: 10Hoo man) [19:32:09] Lydia_WMDE: ok [19:32:23] (03PS7) 10Hoo man: Make UpdateRepo more robust [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) [19:32:25] Makes sense [19:32:28] if we branch next week, then i'm not around for deploys the week after [19:32:43] if we branch in 2 weeks, then can take care of it [19:32:45] aude: ok will discuss with tobi tomorrow [19:32:47] ok [19:33:49] (03CR) 10Hoo man: "Addressed Daniel's comment about documentation. Now merge :D" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) (owner: 10Hoo man) [19:36:06] (03CR) 10Hoo man: "re check" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188071 (owner: 10Thiemo Mättig (WMDE)) [19:38:40] TypeError: Cannot set property 'getDirectionality' of undefined TypeError: Cannot set property 'getDirectionality' of undefined [19:38:50] yikes [19:38:52] on Wikidata? [19:38:57] no [19:39:07] maybe i have to do compoer update again, though just did it [19:39:17] or update uls [19:39:44] debug=true works [19:50:58] Only me or is https://www.wikidata.org/wiki/User:Josve05a borked? I can see any meny's or headers or logos.... [19:51:00] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188071 (owner: 10Thiemo Mättig (WMDE)) [19:51:19] Hmm..nvm...had to purg 3 times... [19:51:23] purge* [19:51:28] off [19:51:40] :/ [19:52:20] (03CR) 10Hoo man: [C: 032] Fix typo in SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188077 (owner: 10Aude) [19:55:04] (03Merged) 10jenkins-bot: Fix typo in SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188077 (owner: 10Aude) [20:02:21] hoo: which documentation? [20:02:38] aude: release notes [20:03:14] ok [20:13:39] Thiemo_WMDE: if you where in Belgium... [20:33:49] (03PS1) 10Hoo man: From MediaWiki 1.24 on UnitTestsList can handle directories [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 [20:37:44] (03CR) 10jenkins-bot: [V: 04-1] From MediaWiki 1.24 on UnitTestsList can handle directories [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 (owner: 10Hoo man) [20:38:27] 3Wikidata, MediaWiki-extensions-WikibaseClient: RSS feed missing Wikidata edit summaries - https://phabricator.wikimedia.org/T78493#1009363 (10aude) I think it's better to exclude these changes from the feed, until we have better integration (e.g. support to filter them, and format much nicer). Once we have pro... [20:44:56] 3MediaWiki-Core-Team, wikidata-query-service, Wikidata: Deploy a Wikidata complex query service into production - https://phabricator.wikimedia.org/T85159#1009371 (10bd808) p:5Triage>3Normal [20:58:42] hi. is there a solution for adding statements based on a wikilist? e.g. add MoP statements for items mentioned in https://de.wikipedia.org/wiki/Liste_der_Mitglieder_des_Deutschen_Bundestages_%2818._Wahlperiode%29 [21:03:17] Wikipedia is not a source. [21:16:28] 20:36:23 1) Wikibase\Test\LibHooksTest::testRegisterPhpUnitTests [21:16:31] what the actual fuck [21:18:57] (03PS2) 10Hoo man: From MediaWiki 1.24 on UnitTestsList can handle directories [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 [21:28:42] 3Wikidata, MediaWiki-extensions-WikibaseClient: DatabaseBase::makeList: empty input for field cs_entity_id - https://phabricator.wikimedia.org/T88329#1009525 (10aude) 3NEW [21:33:29] buuuugs [21:34:13] bugs <3 [21:34:28] (03PS1) 10Aude: Fix repo connection for SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188202 [21:34:30] (03PS1) 10Aude: Avoid empty list input for DatabaseBase::makeList in subscriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188203 (https://phabricator.wikimedia.org/T88329) [21:34:48] * hoo fights with Scribunto trying to finally finish Capiunto :S [21:36:12] 3Wikidata, MediaWiki-extensions-WikibaseClient: SubscriptionManager is trying to query client database - https://phabricator.wikimedia.org/T88333#1009582 (10aude) 3NEW [21:36:23] (03CR) 10Hoo man: [C: 04-1] Fix repo connection for SqlSubscriptionManager (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188202 (owner: 10Aude) [21:36:45] aude: Yikes :S Backport? [21:38:13] don't think it's in the branch but should check [21:39:36] the issue means the page saves but then i get a database error (and seems it's not saved, but is) [21:39:51] (03PS2) 10Aude: Avoid empty list input for DatabaseBase::makeList in subscriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188203 (https://phabricator.wikimedia.org/T88329) [21:39:53] (03PS2) 10Aude: Fix repo connection for SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188202 (https://phabricator.wikimedia.org/T88333) [21:40:32] (03CR) 10Aude: Fix repo connection for SqlSubscriptionManager (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188202 (https://phabricator.wikimedia.org/T88333) (owner: 10Aude) [21:41:06] oh, it is :( [21:41:47] (03CR) 10Hoo man: [C: 032] Fix repo connection for SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188202 (https://phabricator.wikimedia.org/T88333) (owner: 10Aude) [21:43:11] i would like to test the other issue and add tests [21:44:03] (03CR) 10Hoo man: [C: 032] "Tests would be super awesome" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188203 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [21:44:19] Yes +1 for adding tests [21:45:49] 3Mobile-Web, Wikidata, MediaWiki-extensions-WikibaseRepository: Redirect loop on mobile diffs (wikidata) - https://phabricator.wikimedia.org/T88029#1009625 (10MaxSem) a:3MaxSem [21:48:00] (03Merged) 10jenkins-bot: Fix repo connection for SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188202 (https://phabricator.wikimedia.org/T88333) (owner: 10Aude) [21:48:03] (03Merged) 10jenkins-bot: Avoid empty list input for DatabaseBase::makeList in subscriptions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188203 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [22:03:13] 3Wikidata, MediaWiki-extensions-WikibaseClient: SubscriptionManager is trying to query client database - https://phabricator.wikimedia.org/T88333#1009667 (10aude) stacktrace for the record... Exception encountered, of type "Wikibase\Client\Usage\UsageTrackerException" [e345ddb7] /index.php?title=Gene&action=sub... [22:13:23] hoo: speaking of capiunto, i'd still really like to see preprocessing removed (and i think brad and tim would too) [22:14:05] jackmcbarn: Didn't we already do that? [22:14:10] no [22:14:24] https://gerrit.wikimedia.org/r/#/c/163325/ [22:14:26] doh [22:14:39] (03PS1) 10Aude: Remove unused private method in UsageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188212 [22:14:48] Ok, that will need a rebase afterwards anyway [22:14:53] not going to pause my work here [22:17:49] 3Project-Creators, Wikidata, Team-Practices: Create "time-bomb" tag - https://phabricator.wikimedia.org/T75893#1009752 (10Awjrichards) Personally, I feel ambivalent about this. Generally I would recommend proceeding with caution in creating tags in Phabricator, which it sounds like @Aklapper is already doing. In... [22:17:54] 3MediaWiki-Core-Team, wikidata-query-service, Wikidata: Figure out quantity representation - https://phabricator.wikimedia.org/T85298#1009753 (10Smalyshev) Also we probably need to get to implementing value ranges/precision eventually. [22:19:23] (03CR) 10jenkins-bot: [V: 04-1] Remove unused private method in UsageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188212 (owner: 10Aude) [22:22:55] (03PS2) 10Aude: Remove unused private method in UsageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188212 [22:28:54] (03PS6) 10Hoo man: Require users to load the "capiunto" module per hand [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163063 (https://bugzilla.wikimedia.org/69540) [22:28:57] jackmcbarn: ^ [22:29:08] (03CR) 10jenkins-bot: [V: 04-1] Require users to load the "capiunto" module per hand [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163063 (https://bugzilla.wikimedia.org/69540) (owner: 10Hoo man) [22:29:43] once that's fixed i'll review it [22:29:51] (03CR) 10Hoo man: [C: 032] "Indeed unused" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188212 (owner: 10Aude) [22:30:32] doh :D [22:31:05] (03PS7) 10Hoo man: Require users to load the "capiunto" module per hand [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163063 (https://bugzilla.wikimedia.org/69540) [22:31:14] Didn't plan to also commit that... but now it happened :/ [22:32:53] (03CR) 10Hoo man: [C: 04-1 V: 04-1] Use Item constructor instead of newEmpty + setId in tests (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188071 (owner: 10Thiemo Mättig (WMDE)) [22:37:00] 3Wikidata, MediaWiki-extensions-WikibaseClient: RSS feed missing Wikidata edit summaries - https://phabricator.wikimedia.org/T78493#1009845 (10Lydia_Pintscher) I am worried that we are getting less visibility for Wikidata changes there while we really really need more :/ [22:40:43] 3Wikidata, MediaWiki-extensions-WikibaseClient: RSS feed missing Wikidata edit summaries - https://phabricator.wikimedia.org/T78493#1009872 (10aude) we would need at least a bit more detail on what changed for these entries to be meaningful. right now, they appear as empty changes, can't filter them, etc.

<... [22:42:45] 3Wikidata, MediaWiki-extensions-WikibaseClient: RSS feed missing Wikidata edit summaries - https://phabricator.wikimedia.org/T78493#1009885 (10aude) also the diff link isn't really correct: http://wikidata-client/index.php?title=Maurice_Gibb&diff=9892&oldid=9892 (I think this should be a link to the diff in th... [22:43:21] (03Merged) 10jenkins-bot: Remove unused private method in UsageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188212 (owner: 10Aude) [22:43:40] hoo: do you remember the issue about how this will subtly break if substed? [22:44:06] jackmcbarn: What will break? [22:44:30] hoo: well not "now" it won't, but if you conditionally load the css, then it won't load if you subst it [22:44:54] what? why? [22:45:08] * jackmcbarn looks for the details [22:46:10] hoo: ah yes. were your other change https://gerrit.wikimedia.org/r/#/c/163065/ to be merged, once you substed it, parsing wouldn't call getHtml anymore, so addResourceLoaderModules wouldn't get ran [22:46:26] i'm bringing this up since conditional loading is the only reason for the php wrapper now [22:47:06] jackmcbarn: Subst what exactly? [22:47:11] Can you give me an example? [22:47:16] How should one subst a built in [22:47:43] if Module:Foo called capiunto to make an infobox, {{#invoke:foo|main}} would work normally, but {{subst:#invoke:foo|main}} would result in the css not working [22:48:29] Seriously? What will that result in? [22:48:59] the output html would be exactly the same, except for the .css resourceloader module not getting loaded, so the infobox won't be styled [22:49:23] i think we should put off conditional loading until we find a solution to that [22:49:31] mh... can we make invoke throw up in case someone is insane as that? [22:49:37] No [22:49:41] well, we could, but how is that insane? [22:50:04] in case i wasn't clear, by conditional loading, i mean of the RL module, not of the change you just asked me to review [22:50:17] Because it has no benefit (from the user perspective) but stuff starts acting weird on our side [22:50:26] yeah, obviousöy [22:50:51] users expect subst:x to be the same as x unless whatever x is changes [22:51:31] Yeah, but that doesn't make sense here [22:52:13] why not? [22:52:29] Because you can't subst an invoke [22:52:34] yes you can [22:52:53] Not in a meaningful way [22:53:11] what do you mean? [22:53:23] It just doesn't make sense to support that [22:53:27] we can document that, if you want [22:53:47] But I think we should rather do that at a Scribunto level [22:54:04] there are legitimate use cases for substing #invoke's, such as w:en:Module:RfD [22:54:32] otherwise, mw.isSubsting() wouldn't exist [22:55:28] Ok, then I'll use that to throw a meningful error, ok? [22:55:50] i'd rather just document that if you do that, styles won't work [22:55:57] Whatever [22:55:59] (i consider it a bug rather than a feature) [22:56:32] ok, everything else looks fine. i'm testing it now, and if it works, i'll +2 [22:56:39] Thansk [22:57:22] (03PS1) 10Aude: Check for empty arrays in UsageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188224 (https://phabricator.wikimedia.org/T88329) [23:04:24] (03CR) 10Hoo man: [C: 032] Check for empty arrays in UsageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188224 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [23:05:14] thanks [23:05:18] still working on tests [23:05:20] aude: Luckily we have until Wednesday before wmf16 hits any wiki :) [23:05:26] true [23:06:02] also, the schema update code has no tests :( [23:06:06] for the entity usage table [23:06:16] :/ [23:06:34] suppose jenkins would still fail though if broken [23:06:46] since it applies update [23:07:12] If it does in a proper way, yes [23:09:34] (03Merged) 10jenkins-bot: Check for empty arrays in UsageUpdater [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188224 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [23:11:22] hoo: one more thing i notice: can you document somewhere that user code shouldn't do require( 'CapiuntoInfoboxRender' ) ? [23:11:38] 3Wikidata, MediaWiki-extensions-WikibaseClient: when i move a Wikibase client page, subscriptions are not updated - https://phabricator.wikimedia.org/T88357#1009993 (10aude) 3NEW [23:12:02] jackmcbarn: Can add that to the docs, I guess [23:14:26] hoo: are you going to amend that patch, or should i merge it now and do that in a later one? [23:14:41] (03PS8) 10Hoo man: Require users to load the "capiunto" module per hand [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163063 (https://bugzilla.wikimedia.org/69540) [23:14:45] jackmcbarn: Amended [23:15:50] sorry, one thing i forgot i had a draft comment on: $directoryIterator = new RecursiveDirectoryIterator( __DIR__ . '/../tests/phpunit/' ); seems hacky [23:16:14] do we usually do __DIR__ . '../' anywhere? [23:16:38] jackmcbarn: Will kill that thing in a follow-up [23:16:45] Just didn't want to do that in the same commit [23:17:04] (03CR) 10Jackmcbarn: [C: 032] Require users to load the "capiunto" module per hand [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163063 (https://bugzilla.wikimedia.org/69540) (owner: 10Hoo man) [23:17:13] 3Wikidata, MediaWiki-extensions-WikibaseClient: entity usage is incorrectly updated when moving a page - https://phabricator.wikimedia.org/T88358#1010007 (10aude) 3NEW [23:18:05] wow, phabricator does lovely formatting of bugs [23:18:37] Nice indeed [23:19:13] (03Merged) 10jenkins-bot: Require users to load the "capiunto" module per hand [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163063 (https://bugzilla.wikimedia.org/69540) (owner: 10Hoo man) [23:20:52] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository: Figure what to do with MWException within Wikibase - https://phabricator.wikimedia.org/T88360#1010026 (10hoo) 3NEW [23:21:30] Can you run a Wikidata repository and Wikidata client on the same Mediawiki instance? Or is it recommended to put them on different instances? [23:21:41] warriorwiki: You can :) [23:21:51] In fact Wikidata is both a repo and its own client [23:24:48] Right. My question should have said Wikibase instead of Wikidata. So the Wikidata site itself runs both on the same instance? Why would you want to install just one or the other? For performance? Ease of managing a cluster? [23:25:05] Is there such a scenario? [23:26:57] warriorwiki: I'm not aware of a scenario where you would want a repo w/o a client on a wiki (and neither are other team members, we had this discussion) [23:27:05] but of course there are use cases for clients w/o repo [23:27:34] Right. [23:27:52] (03PS1) 10Hoo man: Let MediaWiki auto-discover tests [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/188229 [23:30:28] (03PS3) 10Hoo man: From MediaWiki 1.24 on UnitTestsList can handle directories [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188114 [23:33:04] (03PS3) 10Jackmcbarn: Revert "Preprocess text arguments" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163325 (https://bugzilla.wikimedia.org/69540) [23:33:10] Thanks for your help. I finally managed to get Wikidata installed yesterday (I tried 4 times before, with ~2 months in between each attempt. Your install instructions have gotten much better.). Looking forward to moving away from SMW. [23:33:22] Thanks for all your work on this project. [23:33:50] warriorwiki: Awesome! :) If you find any bugs which are specific to non-Wikimedia set ups, please file them [23:34:29] using software in new environments often makes bugs visible we wouldn't have found otherwise :) [23:34:33] Especially documentation wise [23:36:12] (03CR) 10Hoo man: [C: 032] "I by now agree that this is the right thing to do! Now finally get this extension unstuck :)" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163325 (https://bugzilla.wikimedia.org/69540) (owner: 10Jackmcbarn) [23:38:24] (03Merged) 10jenkins-bot: Revert "Preprocess text arguments" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163325 (https://bugzilla.wikimedia.org/69540) (owner: 10Jackmcbarn) [23:38:56] (03PS1) 10Aude: Add test case for empty array in SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188234 (https://phabricator.wikimedia.org/T88329) [23:39:10] (03Abandoned) 10Jackmcbarn: Convert Capiunto to a delayed-load module [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/164560 (owner: 10Jackmcbarn) [23:39:43] (03CR) 10Aude: "indeed catches the bug (running the tests without the bug fixes):" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188234 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [23:42:05] (03CR) 10Hoo man: [C: 032] "That's one easy to understand test :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188234 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [23:46:08] (03Merged) 10jenkins-bot: Add test case for empty array in SqlSubscriptionManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/188234 (https://phabricator.wikimedia.org/T88329) (owner: 10Aude) [23:49:40] (03PS4) 10Hoo man: Conditionally add the "capiunto.infobox.main" RL module [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163065 (https://bugzilla.wikimedia.org/69540) [23:50:20] (03CR) 10Hoo man: "Re-did this change on top of the new master" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/163065 (https://bugzilla.wikimedia.org/69540) (owner: 10Hoo man) [23:57:58] 3Wikidata, Security-Reviews, MediaWiki-extensions-Capiunto: security review for Capiunto - https://phabricator.wikimedia.org/T71541#1010131 (10hoo) @csteipp: Can we finally close this? The extension consists almost only of Lua code and some very simple PHP interfaces.