[01:39:18] (03CR) 10Hoo man: [C: 032] New Wikidata deployment build - wmf/1.25wmf16 [extensions/Wikidata] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/186355 (owner: 10Aude) [01:41:23] (03Merged) 10jenkins-bot: New Wikidata deployment build - wmf/1.25wmf16 [extensions/Wikidata] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/186355 (owner: 10Aude) [10:59:37] (03CR) 10Hoo man: [C: 032] "Current version of this change is nice and tiny :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [11:00:10] aude: Any reason you didn't also merge https://gerrit.wikimedia.org/r/187679 for the branch yesterday? [11:03:15] (03Merged) 10jenkins-bot: Fix random documentation bits in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [11:09:25] (03CR) 10Hoo man: [C: 032] "Manually verified, not used by any gadget/ user script." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187336 (https://phabricator.wikimedia.org/T87433) (owner: 10Adrian Lang) [11:12:55] (03Merged) 10jenkins-bot: Move buildErrorOutput out of wb.utilities.ui [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187336 (https://phabricator.wikimedia.org/T87433) (owner: 10Adrian Lang) [11:19:50] (03CR) 10Hoo man: [C: 032] ApiBase::getAllowedParams changed to protected [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187115 (owner: 10Thiemo Mättig (WMDE)) [11:22:47] (03Merged) 10jenkins-bot: ApiBase::getAllowedParams changed to protected [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187115 (owner: 10Thiemo Mättig (WMDE)) [11:27:53] (03CR) 10Hoo man: [C: 032] Rework importInterlang/Properties maintainance scripts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179915 (owner: 10Thiemo Mättig (WMDE)) [11:31:11] (03Merged) 10jenkins-bot: Rework importInterlang/Properties maintainance scripts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179915 (owner: 10Thiemo Mättig (WMDE)) [11:31:43] (03CR) 10Hoo man: [C: 032] Drop dead code from SidebarHookHandlersTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186769 (owner: 10Thiemo Mättig (WMDE)) [11:34:21] (03Merged) 10jenkins-bot: Drop dead code from SidebarHookHandlersTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186769 (owner: 10Thiemo Mättig (WMDE)) [11:35:15] (03CR) 10Hoo man: [C: 04-1] "Needs manual rebase, looks fine despite." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186770 (owner: 10Thiemo Mättig (WMDE)) [11:43:13] (03CR) 10Hoo man: [C: 04-1] Drop unused code from and clean up Api\EditEntity (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186151 (owner: 10Thiemo Mättig (WMDE)) [11:56:14] (03CR) 10Hoo man: "Found two things I find a little odd now... no deal breakers, though." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [12:27:46] yikes [12:27:48] aude: around? [12:43:58] jzerebecki: ping [12:46:53] (03PS1) 10Hoo man: Fix triggering of the anonymous edit warning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187899 [12:52:35] (03CR) 10Hoo man: [C: 04-1] "Needs to be adopted to https://gerrit.wikimedia.org/r/187899" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187364 (owner: 10Adrian Lang) [13:01:17] (03CR) 10Hoo man: [C: 031] "Didn't look at the html output, also I have two suggestions" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187671 (owner: 10Thiemo Mättig (WMDE)) [13:39:29] (03PS8) 10Hoo man: Add EntityRevisionLookup::getEntityRevisions/getLatestRevisionIds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) [14:52:16] hoo: pong [14:53:05] jzerebecki: See mailing list... not sure how urgent that stuff is, patch is linked [14:56:12] (03CR) 10JanZerebecki: [C: 032] Fix triggering of the anonymous edit warning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187899 (owner: 10Hoo man) [14:57:59] hoo: we can deploy on monday [14:58:05] hi aude :) [14:58:13] Ok, that's better [14:58:20] wikidata is broken for me :( [14:58:29] probably just me and only some items [14:58:30] Totally broken? [14:58:35] see my email [14:58:36] Define broken [14:58:38] Ok [14:58:43] can't view large items [14:58:48] You're still in the US on Monday= [14:58:54] i am :) [14:59:22] trying to understand chrome debug logs [14:59:27] Ok... I'll just take an early deploy Window then, probably... or do you want to do it later on with the other stuff? [14:59:49] early swat = 11am [15:00:03] we have several things to go out already [15:00:04] (03Merged) 10jenkins-bot: Fix triggering of the anonymous edit warning [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187899 (owner: 10Hoo man) [15:00:15] if you want to update the build, go ahead [15:00:19] Early swat is to late for me [15:00:22] :( [15:00:27] I'd go for 11am CET [15:00:34] if you want... [15:00:35] should be ok, european ops folks will be around [15:00:39] yeah [15:01:06] (03PS1) 10JanZerebecki: Fix triggering of the anonymous edit warning [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187908 [15:01:25] This as well https://gerrit.wikimedia.org/r/187679 ? [15:01:30] (03PS1) 10JanZerebecki: Fix triggering of the anonymous edit warning [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/187909 [15:02:21] (for making a new build wmf16 is not deployeD) [15:03:33] hoo: https://gerrit.wikimedia.org/r/187679 can be merged and build updated [15:03:42] no deploy since it's not deployed yet [15:05:00] Ok [15:05:31] noted down... will take care of that :) [15:06:53] k [15:22:19] hmmm, seems only Q60, Q61 and Q76 are broken :/ [15:23:38] Works for me with WebKit :/ [15:24:05] Try another chrome profile (w/o plug ins maybe) [15:24:07] ? [15:24:21] i did [15:24:27] i wiped my default profile [15:24:35] cleared local storage [15:24:50] these are items i probably visited before [15:25:11] can see them start to load... [15:25:14] (03CR) 10Hoo man: Add EntityRevisionLookup::getEntityRevisions/getLatestRevisionIds (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) (owner: 10Hoo man) [15:25:43] Does an actual sub process of Chrome crash? [15:25:52] If so... what does your OS say? [15:25:59] just the tab [15:26:03] guess you still use OS X... I'm clueless witht ath [15:26:11] a tab is a process in Chrome, right? [15:26:16] suppose so [15:26:51] (03PS9) 10Hoo man: Add EntityRevisionLookup::getEntityRevisions/getLatestRevisionIds [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) [15:27:13] i get a "crash report" [15:27:27] Ah [15:27:48] That *could* have hints on what part of the thing crashed (eg. V8 or Blink, ...) [15:28:15] (03CR) 10Hoo man: "Split up the functions in CachingEntityRevisionLookup, per Daniel" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (https://phabricator.wikimedia.org/T87238) (owner: 10Hoo man) [15:28:38] yeah [15:28:48] just need to find how to read it [15:37:00] (03PS4) 10Hoo man: Make UpdateRepo more robust [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) [15:53:59] (03PS5) 10Hoo man: Make UpdateRepo more robust [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) [15:55:53] (03PS6) 10Hoo man: Make UpdateRepo more robust [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) [15:57:51] (03CR) 10Hoo man: "Made the job delay depend on the max. replag now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181258 (https://phabricator.wikimedia.org/T76545) (owner: 10Hoo man) [20:09:08] hey, where is the script deleteAllData.php? [20:09:31] Mentioned here: https://www.mediawiki.org/wiki/Extension:Wikibase_Repository#deleteAllData.php [20:09:40] $ find -name deleteAllData.php [20:09:40] ./lib/maintenance/deleteAllData.php [20:10:04] thnx [20:10:20] :) [20:10:35] m) [20:25:11] is there a way to name sitelinks? mine appear with as on my item pages [20:26:18] Yeah, sure [20:26:23] just create that message :) [20:27:03] How do I do that? "Wikipedia" looks really nice [20:27:40] does this name need to be listen in the site_data column in the sites table? [20:29:45] Just create MediaWiki:wikibase-sitelinks-siteLinkGroup (where "siteLinkGroup" is the name of your site lin group) with the name of your sitelink group [20:29:59] MediaWiki message, ftw :D [20:31:23] Wooo [20:32:07] thank you, that worked [20:33:30] :) [20:34:42] is it always safe to upgrade the wikibase extension via git pull? [20:35:43] If you run composer update and the database updates afterwards it should be, yes [20:36:00] composer update, ok [20:36:02] thnx [20:36:05] but if you want to run it in production you should test larger updates within a test system first, I guess [22:10:14] does the item page make any server-side calls to the api when adding a site-link? [22:10:41] despens: Yeah, the UI uses the API to make its edits [22:10:59] Only Special:SetSiteLink does that all server side [22:11:31] hmm, what can this mean: The external client site 'RhizomeCatalog' did not provide page information for page 'Rhizome'.? [22:11:45] the page 'Rhizome' exists on my wiki [22:12:05] it looks like the urls the javascript is calling are fine [22:12:18] Check the urls in your site table [22:12:48] will these urls be used by the server and the browser? [22:13:02] Yeah, they both use them [22:13:08] although in slightly different ways [22:13:21] ok, i have a basic auth on my server [22:13:32] that's probably why it cannot work the urls [22:13:42] Very likely, yes [22:13:54] that's unfortunate :) [22:14:07] let me try to remove the basic auth [22:15:06] ok, doesn't help [22:15:34] do these urls in the site table need to be totally absolute, including protocol? i used '//my.server.com/$1' [22:15:50] If they're relative, MediaWiki will use http [22:15:58] and it wont follow redirects [22:16:15] thus if you have http redirecting to https, you need https URLs in there [22:16:33] so i will need to use 'https://my.server.com/$1'? [22:16:45] If your sever is https only, yes :) [22:16:49] it is [22:17:00] hmm, i think i need to file a report on this :) [22:17:38] How are you creating your sites table entries? [22:17:39] what is the right project in phabricator? [22:17:52] mediawiki-extension-WikibaseRepo [22:17:59] but you'll likely create a duplicate [22:18:05] we have a very similar thing [22:18:09] in WMF production [22:19:25] how 'site data' is made is pretty bad i think. first of all, it should not be a php serial but a json string. and then it should have clear key names and separate urls for client and server [22:19:48] it could direct the server to call the api on localhost and not have all these issued [22:19:50] I agree that json would be nice... but no, the URLs should work for both [22:19:54] *issues [22:20:03] you can still do that [22:20:09] just edit your etc hosts [22:20:33] but if the browser also used the same urls, i cannot use localhost [22:20:57] Yeah, so just use etc hosts on your webserver [22:21:05] if you really want to save the network roundtrip [22:21:22] shouldn't be very expensive, but I don't know about your setupt [22:21:28] but both file_path and page_path must work for browser and server [22:21:50] or not? [22:21:57] Yeah, of course [22:22:33] ah ok, so you mean to overwrite my.server.com on the web server via /etc/hosts [22:23:02] and have it point to 127.0.0.1 [22:23:05] If you need the extra perofrmance, yes [22:24:17] my setup still wouldn't allow this. mediawiki runs in a vm. the vm's host does the https and basic auth. [22:24:43] you can exempt localhost from basic auth [22:25:19] i don't think that is so uncommon :) so the protocol inside the vm is http and the outside protocol is https [22:25:20] Of course that opens a tiny attack vector [22:25:44] In that case you can, as a hack leave it protocol relative [22:25:45] or http [22:26:11] I think the ResourceLoader module that loads that for javascript makes everything protocol relative anyway [22:26:31] but javascript always sees https and the server always http ... [22:26:34] i will try [22:28:24] hoo: haha! that hack with /etc/hosts worked!! [22:28:51] congrats! [22:29:39] :) [22:34:00] ok, that was fun. i still think these urls should not be the same for server and browser. i like much better how one can set that up in parsoid [22:35:37] Feel free to open a bug about that [22:35:58] i will. [22:36:19] thank you! i'm happy i can still hide behin basic auth ;) [22:44:44] :D :) [22:44:55] (03CR) 10Hoo man: [C: 032] Introduce content language concept for SpecialNewEntity [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187679 (https://phabricator.wikimedia.org/T86929) (owner: 10JanZerebecki) [22:45:17] (03CR) 10Hoo man: [C: 032] Fix triggering of the anonymous edit warning [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187908 (owner: 10JanZerebecki) [22:45:23] (03CR) 10Hoo man: [C: 032] Fix triggering of the anonymous edit warning [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/187909 (owner: 10JanZerebecki) [22:47:39] (03Merged) 10jenkins-bot: Introduce content language concept for SpecialNewEntity [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187679 (https://phabricator.wikimedia.org/T86929) (owner: 10JanZerebecki) [22:50:26] (03Merged) 10jenkins-bot: Fix triggering of the anonymous edit warning [extensions/Wikibase] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187908 (owner: 10JanZerebecki) [22:50:28] (03Merged) 10jenkins-bot: Fix triggering of the anonymous edit warning [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/187909 (owner: 10JanZerebecki) [22:56:18] (03PS1) 10Hoo man: Update Wikibase: Fixes for UsageTracking and the anon edit warning [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/187931 [23:04:01] (03PS1) 10Hoo man: Update Wikibase: Fixes for SpecialNewEntity and the anon edit warning [extensions/Wikidata] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187934 [23:05:45] (03CR) 10Hoo man: "This undoes https://github.com/wmde/WikidataBuildResources/pull/19 (see my comment there)" [extensions/Wikidata] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187934 (owner: 10Hoo man) [23:06:07] (03CR) 10Hoo man: [C: 032] "Will schedule a deploy on early Monday" [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/187931 (owner: 10Hoo man) [23:07:57] (03Merged) 10jenkins-bot: Update Wikibase: Fixes for UsageTracking and the anon edit warning [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/187931 (owner: 10Hoo man) [23:08:39] (03CR) 10Hoo man: [C: 032] Update Wikibase: Fixes for SpecialNewEntity and the anon edit warning [extensions/Wikidata] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187934 (owner: 10Hoo man) [23:10:28] (03Merged) 10jenkins-bot: Update Wikibase: Fixes for SpecialNewEntity and the anon edit warning [extensions/Wikidata] (wmf/1.25wmf16) - 10https://gerrit.wikimedia.org/r/187934 (owner: 10Hoo man) [23:18:10] * hoo looks for aude [23:19:14] * hoo wtfs [23:27:57] * addshore wonders what hoo wtf'ed about [23:28:17] hoo: we probably need the oauth token if we use github [23:28:28] aude: mg [23:28:28] * aude has been taking it out since it was unused [23:28:29] * mh [23:28:47] aude: Why is the Wikidata version for wmf15 older than the one for wmf14? [23:28:55] Just a mistake over something gone awry? [23:28:55] ? [23:29:02] link? [23:29:23] Compare these: https://gerrit.wikimedia.org/r/187936 https://gerrit.wikimedia.org/r/187937 [23:29:36] both are supposed to be on Wikidata's wmf14 [23:29:50] but wmf15 core has a older check out version [23:29:57] ugh [23:30:28] http://git.wikimedia.org/summary/mediawiki%2Ftools%2Frelease.git [23:30:42] should have wmf14 [23:31:41] It has... but maybe we update wmf14 after, but forgot about wmf15 [23:32:14] * updated [23:32:15] i see [23:32:28] think we were going to do the noexternallanglinks later [23:32:36] but not this much later [23:32:46] should go on monday [23:33:00] I scheduled both for Monday morning [23:33:14] https://wikitech.wikimedia.org/wiki/Deployments#Monday.2C.C2.A0February.C2.A002 [23:33:29] ok [23:34:09] Ok, so that wasn't done on any purpose, but just got forgotten about [23:34:20] wmf15 is only on group0 yet, so not a problem [23:34:37] yep [23:35:03] then i can start with adding the table and populating ahead of our later deploy window [23:35:34] Sounds sensible, start small [23:35:49] no idea how long the script takes [23:36:55] Try it on a midsize wiki and extrapolate from that? Run time is only dependent on number of pages with a wikidata item, right (size of pages etc. doesn't matter) [23:37:13] we did it on test* [23:37:19] very quick there but those are small [23:37:26] test doesn't really count [23:37:37] wikidata doesn't have many pages with an item [23:37:51] if it uses the page props to find them [23:37:56] True [23:38:53] https://code.google.com/p/chromium/issues/detail?id=454129 [23:39:04] i am tired of debugging, maybe someone else has a clue [23:40:35] (03PS1) 10Hoo man: Replace usage of deprecated ApiResult::disableSizeCheck [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187938 [23:42:44] (03Abandoned) 10Hoo man: Updated to the new way of adding no-size-check results [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/152213 (owner: 10Yurik) [23:43:39] https://www.wikidata.org/wiki/Q23 no can view :( [23:44:43] WFM [23:45:14] aude: Still Chrome acting up? [23:46:01] (03Abandoned) 10Hoo man: Drop type hints from signatures of of RepoLinker::getEntityUrl and EntityHandler::getTitleForId [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161489 (owner: 10Ori.livneh) [23:46:24] no idea why it's broken :( [23:46:51] (03Abandoned) 10Hoo man: Drop additional type hints [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/161595 (owner: 10Ori.livneh) [23:47:10] aude: Tried running chrome as a different user, yet? [23:47:44] yes [23:47:59] without adblock etc [23:48:05] with a fresh profile [23:48:07] etc [23:48:42] it gets http://snag.gy/eM0F8.jpg far and i can quickly stop loading [23:48:44] aude: https://gerrit.wikimedia.org/r/184023 shall we apply that to Wikibase in some form? [23:48:49] then crashes [23:48:54] weird [23:49:06] captured logs and such that maybe make sense to chromium people [23:49:15] can you attach gdb to the chrome process (I know... attaching a deugger to a browser is not exactly fun...) [23:49:25] ah ok [23:49:45] i did but not sure it was totally correct [23:49:58] see my attachments https://code.google.com/p/chromium/issues/detail?id=454129 [23:50:21] No, I get a 403 :/ [23:50:28] https://gerrit.wikimedia.org/r/184023 ... needs to be split into smaller parts, imho [23:50:53] maybe it is private [23:51:10] yeah... also we probably actually want RuntimeException in many places... just Exception is very generic [23:52:20] * hoo goes to create a task [23:52:41] Shall I create one for all of Wikibase or do we task client/ repo individually now? [23:52:48] https://gist.github.com/filbertkm/202f9dfa966c18955a42 part 1 [23:53:51] Oh, you made that from the core dump? [23:54:22] https://gist.github.com/filbertkm/f946092ba21bf314f08f [23:54:29] got logs [23:54:47] first is a "minidump" [23:55:40] second is more detailed and captured elsewhere [23:56:30] seems similar to https://adblockplus.org/forum/viewtopic.php?t=27754 (but i removed adblock entirely and used new profile) [23:57:18] Disabling Js fixes it, right? [23:57:50] no [23:58:16] * aude will see if the chromium people reply [23:58:26] thought maybe it's related to the banner or something but don't know [23:58:44] mh [23:58:58] what does debug=true do [23:58:58] i removed cookies and have the banner now [23:59:04] doesn't help [23:59:14] * aude runs off to eat.... [23:59:35] Mh... thought changing the order in which stuff happens might help [23:59:48] would be nice if it was that easy