[00:46:15] Just curious if magnus comes on here? [01:38:39] emacsen: not that much [03:48:41] GerardM-: around? [07:38:26] (03PS6) 10Henning Snater: Consolidated snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186786 [07:39:52] 3Wikidata, MediaWiki-extensions-WikibaseRepository: rename language list to more languages or similar - https://phabricator.wikimedia.org/T87577#1000561 (10adrianheine) I'd prefer »in more languages«, since it's not a list of languages, but a list of terms in languages. [07:45:56] 3Wikidata, MediaWiki-extensions-WikibaseRepository: rename language list to more languages or similar - https://phabricator.wikimedia.org/T87577#1000562 (10Lydia_Pintscher) "In more languages" is pretty good actually. [07:47:59] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Group statements within statement group by ranks - https://phabricator.wikimedia.org/T87327#1000563 (10adrianheine) I'd say we would have three or two paragraphs. So, if we have statements of all ranks on a property, it would look like this: **Statements** pre... [07:49:39] 3Wikidata, MediaWiki-extensions-WikibaseRepository: add language fallback to entity search/suggester - https://phabricator.wikimedia.org/T76150#1000565 (10adrianheine) I meant the current state is a regression. We broke a use-case I consider somewhat reasonable. This task would fix that. [08:13:21] 3Wikidata, MediaWiki-extensions-WikibaseRepository: add language fallback to entity search/suggester - https://phabricator.wikimedia.org/T76150#1000580 (10Lydia_Pintscher) Ah ok. Yeah. [08:23:58] (03PS1) 10Adrian Lang: Move buildErrorOutput out of wb.utilities.ui [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187336 (https://phabricator.wikimedia.org/T87433) [08:25:13] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - https://phabricator.wikimedia.org/T73170#1000593 (10adrianheine) [08:25:14] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository: language fallback - https://phabricator.wikimedia.org/T76216#1000592 (10adrianheine) [08:28:06] (03CR) 10Henning Snater: [C: 032] Fix snak type selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187111 (owner: 10Adrian Lang) [08:30:22] (03Merged) 10jenkins-bot: Fix snak type selector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187111 (owner: 10Adrian Lang) [08:31:53] 3Wikidata: brainstorming for Wikimania 2015 talk ideas for Wikidata - https://phabricator.wikimedia.org/T87334#1000601 (10petr.matas) - Wikidata needs to pick some solution to the [[ //www.wikidata.org/wiki/Wikidata:Bonnie and Clyde | Bonnie and Clyde problem ]]. [09:08:10] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Apply language fallbacks in diffs - https://phabricator.wikimedia.org/T87850#1000632 (10adrianheine) 3NEW [09:08:39] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Apply language fallbacks in summaries - https://phabricator.wikimedia.org/T87851#1000638 (10adrianheine) 3NEW [09:09:23] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Apply language fallbacks in summaries - https://phabricator.wikimedia.org/T87851#1000645 (10adrianheine) [09:36:24] (03PS5) 10Henning Snater: Overhauled snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186963 [09:39:39] (03CR) 10jenkins-bot: [V: 04-1] Overhauled snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186963 (owner: 10Henning Snater) [09:46:48] (03PS1) 10Henning Snater: Fixed sitelinklistview QUnit test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187342 [09:47:59] (03PS6) 10Henning Snater: Overhauled snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186963 [09:50:15] (03PS1) 10Thiemo Mättig (WMDE): Merge TemplateRegistry into TemplateFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187343 [09:50:27] (03PS1) 10Adrian Lang: Fix main snak displaying in diffs of qualifiers, ranks and references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187344 (https://phabricator.wikimedia.org/T87096) [09:52:19] 3Wikidata, MediaWiki-extensions-WikibaseRepository: caching difference between current language in top header and current language in in other languages box - https://phabricator.wikimedia.org/T87580#1000694 (10Lydia_Pintscher) Yes purging the page fixes it. [09:57:47] (03CR) 10Adrian Lang: Introduce TemplateFactory::getDefaultInstance (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187127 (owner: 10Thiemo Mättig (WMDE)) [09:58:46] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Group statements within statement group by ranks - https://phabricator.wikimedia.org/T87327#1000700 (10Lydia_Pintscher) We need all 3 sections for drag and drop at least when editing. We probably don't want to show the sections that are not in use when not edit... [09:58:55] 3Wikidata, DataValues: Altitude support - https://phabricator.wikimedia.org/T87749#1000702 (10JeroenDeDauw) 5Open>3declined a:3JeroenDeDauw Closing as this is not relevant to the WD project and is already present on Phabrictaor: https://phabricator.wikimedia.org/T34698 [09:59:22] (03CR) 10Adrian Lang: [C: 031] "I squashed the whole chain and it looked ok to me in sum." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187343 (owner: 10Thiemo Mättig (WMDE)) [10:04:08] [13WikibaseDataModel] 15thiemowmde comment on pull request #352 142fd47c2: I think this does not belong here. This line should say since when a class exists. If a method signature changed, the since tag of this method should change, not the since tag of the class.... 02http://git.io/FVsK [10:07:32] [13WikibaseDataModel] 15thiemowmde comment on pull request #350 14046ca94: As I said, what's relevant here are the tests. If they cover everything, anybody can safely remove/refactor these checks. 02http://git.io/FVGl [10:10:17] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Group statements within statement group by ranks - https://phabricator.wikimedia.org/T87327#1000713 (10adrianheine) We use the concept of best statements everywhere except for editing. I can live with not using it for editing an entity, but I think we have to u... [10:11:23] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Group statements within statement group by ranks - https://phabricator.wikimedia.org/T87327#1000718 (10adrianheine) As for the captions, I don't really care about them. ›Wrong‹ should probably be ›Deprecated‹, since we already use that. ›Stale‹ could be ›Other‹... [10:12:33] 3wikidata-query-service, Wikidata: Implement sitelinks and badges - https://phabricator.wikimedia.org/T86331#1000720 (10Lydia_Pintscher) Can this be closed? Patch is merged. [10:13:30] [13ValueView] 15snaterlicious created 06contentlangdoc (+1 new commit): 02http://git.io/FVnT [10:13:30] 13ValueView/06contentlangdoc 14a510f25 15snaterlicious: Updated code documentation [10:13:40] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2015/01/29 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/187345 [10:14:14] [13ValueView] 15snaterlicious opened pull request #153: Updated code documentation (06master...06contentlangdoc) 02http://git.io/FVnC [10:15:40] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015/01/29 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/187345 (owner: 10Tobias Gritschacher) [10:15:58] 3Wikidata, MediaWiki-extensions-WikibaseRepository: show version number for Wikidata build on Special:Version - https://phabricator.wikimedia.org/T66549#1000726 (10Lydia_Pintscher) 5Open>3declined a:3Lydia_Pintscher As per Katie. [10:16:19] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06setIdParam: 02http://git.io/FVnF [10:16:19] 13WikibaseDataModel/06setIdParam 1405152a9 15Jeroen De Dauw: Update EntityDocument.php [10:16:23] 3Wikidata, Wikidata.org: Wrong info on Special:Version - https://phabricator.wikimedia.org/T74759#1000730 (10Lydia_Pintscher) What are we going to do about this based on Chad's comment in the review request? [10:17:31] [13WikibaseDataModel] 15thiemowmde comment on pull request #350 14046ca94: I suggest to write individual tests like this one, either alternatively or in addition to the test cases in the providers. I come up with the following relevant combinations:... 02http://git.io/FVcY [10:17:43] 3Wikidata, MediaWiki-extensions-WikibaseClient: Insert link item for adding language links in PHP - https://phabricator.wikimedia.org/T63391#1000732 (10Lydia_Pintscher) How are we going to move forward here after comments by Thiemo in review request? [10:21:00] 3Wikidata, MediaWiki-extensions-WikibaseClient: Wrong smart keyword on Wikidata - https://phabricator.wikimedia.org/T60467#1000735 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher [10:22:25] [13ValueView] 15adrianheine 04deleted 06contentlangdoc at 14a510f25: 02http://git.io/FVCL [10:29:18] (03CR) 10Tamslo: [C: 032 V: 032] delete initial clone from github since everything there is not used anymore; add helpers folder containing scripts to generate table for con [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/186095 (owner: 10Jonaskeutel) [10:41:41] (03PS2) 10Tobias Gritschacher: New Wikidata Build - 2015/01/29 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/187345 [10:44:05] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 2015/01/29 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/187345 (owner: 10Tobias Gritschacher) [10:44:13] (03PS1) 10Tamslo: Added special pages for constraint review and external validation and the importer for exernal data [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/187347 [10:44:53] (03CR) 10Soeren.oldag: [C: 032 V: 032] Added special pages for constraint review and external validation and the importer for exernal data [extensions/WikidataQuality] - 10https://gerrit.wikimedia.org/r/187347 (owner: 10Tamslo) [11:11:07] (03CR) 10Hoo man: [C: 032] "This script is being run on snapshot1003 which is still on Zend... So if this made it into the branch, please backport." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187284 (https://phabricator.wikimedia.org/T87823) (owner: 10Aude) [11:13:40] (03Merged) 10jenkins-bot: Make dumpJson::logMessage public, needed by callback [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187284 (https://phabricator.wikimedia.org/T87823) (owner: 10Aude) [11:17:23] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Warning: call_user_func() expects parameter 1 to be a valid callback, cannot access private method Wikibase\DumpJson::logMessage - https://phabricator.wikimedia.org/T87823#1000759 (10hoo) 5Open>3Resolved a:3hoo Needs backport if this is a problem on the b... [11:23:23] 3Wikidata, Wikidata.org: Wrong info on Special:Version - https://phabricator.wikimedia.org/T74759#1000765 (10JanZerebecki) Do what he suggested. :) [11:30:33] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #350 14046ca94: Looks like the `Invalid` should be dropped 02http://git.io/FVoE [11:31:27] (03PS9) 10Henning Snater: Implemented link to toggle language list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184340 (https://phabricator.wikimedia.org/T86193) [11:31:33] (03CR) 10jenkins-bot: [V: 04-1] Implemented link to toggle language list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184340 (https://phabricator.wikimedia.org/T86193) (owner: 10Henning Snater) [11:32:22] 3Wikidata, MediaWiki-extensions-WikibaseRepository: rename language list to more languages or similar - https://phabricator.wikimedia.org/T87577#1000770 (10Snaterlicious) Changed to "In more languages" in patch set 9 of https://gerrit.wikimedia.org/r/#/c/184340/. [11:33:55] [13WikibaseDataModel] 15thiemowmde comment on pull request #350 14046ca94: Agree, I find the wording (of the test method name) hard to read. 02http://git.io/FVKC [11:35:06] hey :) [11:35:06] 3Wikidata, MediaWiki-extensions-WikibaseRepository: not possible to remove sitelinks using Special:SetSitelink - https://phabricator.wikimedia.org/T64707#1000771 (10Lydia_Pintscher) Does anyone want to pick this up and fix the remaining issues in the review request? [11:36:47] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fixed sitelinklistview QUnit test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187342 (owner: 10Henning Snater) [11:37:45] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Have links to Special:SetDescription and Special:SetAliases on Special:SetLabel - https://phabricator.wikimedia.org/T87752#1000772 (10Snaterlicious) 5Open>3declined a:3Snaterlicious @Lydia_Pintscher decided that a Special page titled "SetLabelDescriptionA... [11:37:46] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Create a SpecialPage that allows to edit label, description and aliases together - https://phabricator.wikimedia.org/T72174#1000775 (10Snaterlicious) [11:37:58] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Have links to Special:SetDescription and Special:SetAliases on Special:SetLabel - https://phabricator.wikimedia.org/T87752#1000776 (10Snaterlicious) a:5Snaterlicious>3None [11:38:51] (03Merged) 10jenkins-bot: Fixed sitelinklistview QUnit test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187342 (owner: 10Henning Snater) [11:39:07] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Create a SpecialPage that allows to edit label, description and aliases together - https://phabricator.wikimedia.org/T72174#732963 (10Snaterlicious) @Lydia_Pintscher decided that a Special page titled "SetLabelDescriptionAliases" should be created: `Fingerprint... [11:39:57] (03PS17) 10Henning Snater: Rearranged entity view header [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183498 [11:40:08] (03PS12) 10Henning Snater: Using textarea for entering description [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183866 (https://phabricator.wikimedia.org/T86192) [11:40:15] (03PS10) 10Henning Snater: Implemented link to toggle language list [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184340 (https://phabricator.wikimedia.org/T86193) [11:40:34] (03PS12) 10Henning Snater: entitytermsview: Fix table header and toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184580 (https://phabricator.wikimedia.org/T86520) [11:40:40] (03PS8) 10Henning Snater: Removed table of content bar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184629 (https://phabricator.wikimedia.org/T84913) [11:42:41] 3Wikidata, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): allow showing captchas on Wikibase items and properties - https://phabricator.wikimedia.org/T87854#1000778 (10Lydia_Pintscher) 3NEW [11:43:40] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Slighty more readable fallback indicator generation (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186166 (owner: 10Adrian Lang) [11:44:00] 3Wikidata, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): allow showing captchas on Wikibase items and properties - https://phabricator.wikimedia.org/T87854#1000786 (10Lydia_Pintscher) [11:44:02] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository: data quality and trust - https://phabricator.wikimedia.org/T76230#1000785 (10Lydia_Pintscher) [11:44:43] 3Wikidata, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension), MediaWiki-extensions-WikibaseRepository: allow showing captchas on Wikibase items and properties - https://phabricator.wikimedia.org/T87854#1000778 (10Lydia_Pintscher) [11:46:02] (03Merged) 10jenkins-bot: Slighty more readable fallback indicator generation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186166 (owner: 10Adrian Lang) [11:46:04] (03PS7) 10Henning Snater: Renamed FingerprintView to EntityTermsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184856 [11:46:47] 3Wikidata, MediaWiki-extensions-WikibaseRepository: autonym shown for language fallback - https://phabricator.wikimedia.org/T87855#1000792 (10Lydia_Pintscher) 3NEW [11:48:09] (03PS13) 10Henning Snater: entitytermsview: Inject link to help page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 (https://phabricator.wikimedia.org/T86191) [11:49:27] 3Wikidata, MediaWiki-extensions-WikibaseRepository: autonym shown for language fallback - https://phabricator.wikimedia.org/T87855#1000801 (10Lydia_Pintscher) [11:49:29] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository: language fallback - https://phabricator.wikimedia.org/T76216#1000800 (10Lydia_Pintscher) [12:00:32] (03PS1) 10Thiemo Mättig (WMDE): Fix wrong variable name in EntityIdHtmlLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187353 [12:02:56] 3wikidata-query-service, Wikidata: Analyze indexes used for the engine - https://phabricator.wikimedia.org/T87307#1000806 (10Lydia_Pintscher) [12:05:25] (03CR) 10Adrian Lang: Fix wrong variable name in EntityIdHtmlLinkFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187353 (owner: 10Thiemo Mättig (WMDE)) [12:05:38] (03PS1) 10Adrian Lang: Introduce content language concept for SpecialNewEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187355 (https://phabricator.wikimedia.org/T86929) [12:06:52] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Replace $.merge with Array::concat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183238 (owner: 10Adrian Lang) [12:09:12] (03Merged) 10jenkins-bot: Replace $.merge with Array::concat [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183238 (owner: 10Adrian Lang) [12:22:11] (03CR) 10Adrian Lang: [C: 032] Consolidated snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186786 (owner: 10Henning Snater) [12:24:17] (03Merged) 10jenkins-bot: Consolidated snaklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186786 (owner: 10Henning Snater) [12:27:07] (03PS4) 10Adrian Lang: Added basic snakview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186955 (owner: 10Henning Snater) [12:27:19] (03PS3) 10Adrian Lang: Added snakview.value() QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186959 (owner: 10Henning Snater) [12:27:33] (03PS7) 10Adrian Lang: Overhauled snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186963 (owner: 10Henning Snater) [12:38:32] (03CR) 10Adrian Lang: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186955 (owner: 10Henning Snater) [12:47:29] (03PS1) 10Adrian Lang: Remove unused message reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187359 [12:51:42] (03CR) 10Jeroen De Dauw: [C: 032] Fix method signatures in all maintenance scripts [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187101 (owner: 10Thiemo Mättig (WMDE)) [13:02:35] (03CR) 10Thiemo Mättig (WMDE): Fix wrong variable name in EntityIdHtmlLinkFormatter (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187353 (owner: 10Thiemo Mättig (WMDE)) [13:08:17] (03CR) 10Adrian Lang: Added basic snakview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186955 (owner: 10Henning Snater) [13:08:22] (03CR) 10Adrian Lang: [C: 032] Added basic snakview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186955 (owner: 10Henning Snater) [13:09:34] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Redesign header - https://phabricator.wikimedia.org/T75654#1000840 (10Lucie) [13:11:15] (03Merged) 10jenkins-bot: Added basic snakview QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186955 (owner: 10Henning Snater) [13:11:18] (03Merged) 10jenkins-bot: Added snakview.value() QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186959 (owner: 10Henning Snater) [13:13:23] (03CR) 10Jeroen De Dauw: [C: 032] Fix wrong variable name in EntityIdHtmlLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187353 (owner: 10Thiemo Mättig (WMDE)) [13:13:55] 3Wikidata, MediaWiki-extensions-WikibaseRepository: UI freezes when trying to save an entity reference that does not exist - https://phabricator.wikimedia.org/T87363#1000841 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher [13:14:34] (03CR) 10Jeroen De Dauw: "6 fields -> 7 fields" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187355 (https://phabricator.wikimedia.org/T86929) (owner: 10Adrian Lang) [13:15:49] (03CR) 10Jeroen De Dauw: [C: 031] Remove _fetchItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 (owner: 10Adrian Lang) [13:16:29] (03CR) 10Jeroen De Dauw: [C: 032] Only allow QUnit and sinon in test files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180143 (owner: 10Adrian Lang) [13:17:28] (03CR) 10Jeroen De Dauw: "This was submitted against a wmf branch 13 days ago and then not merged. Something going wrong here?" [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185473 (https://phabricator.wikimedia.org/T87009) (owner: 10JanZerebecki) [13:17:37] (03CR) 10Jeroen De Dauw: "This was submitted against a wmf branch 13 days ago and then not merged. Something going wrong here?" [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185448 (https://phabricator.wikimedia.org/T86828) (owner: 10JanZerebecki) [13:18:20] (03CR) 10Jeroen De Dauw: "Abandon?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179118 (owner: 10Aude) [13:20:16] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove _fetchItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 (owner: 10Adrian Lang) [13:22:27] (03Merged) 10jenkins-bot: Remove _fetchItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 (owner: 10Adrian Lang) [13:22:38] (03CR) 10Jeroen De Dauw: [C: 032] "Doing the check like in the other places ought to work." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [13:23:00] (03CR) 10Thiemo Mättig (WMDE): [V: 04-1] "Needs rebase. Do you still want this in master?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 (owner: 10Adrian Lang) [13:23:37] (03CR) 10jenkins-bot: [V: 04-1] Gate PHP entry point [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183213 (owner: 10Adrian Lang) [13:23:39] (03CR) 10jenkins-bot: [V: 04-1] Ignore vendor/ in jshint [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183444 (owner: 10Adrian Lang) [13:23:41] (03CR) 10jenkins-bot: [V: 04-1] Add expect calls to test cases [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183445 (owner: 10Adrian Lang) [13:24:09] (03Abandoned) 10Adrian Lang: Move wikibase.css and jquery.wikibase from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 (owner: 10Adrian Lang) [13:24:28] (03CR) 10Jeroen De Dauw: [C: 032] "Agree with Thiemo on the check better being explicit" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180149 (owner: 10Adrian Lang) [13:24:32] 3Wikidata, MediaWiki-extensions-WikibaseRepository: rename language list to more languages or similar - https://phabricator.wikimedia.org/T87577#1000843 (10Lydia_Pintscher) [13:25:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove unused message reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187359 (owner: 10Adrian Lang) [13:27:15] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "-1 per I6876ff2, will probably abandon this patch chain. See the Ia55eb13 chain instead." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/186964 (owner: 10Thiemo Mättig (WMDE)) [13:29:39] (03Merged) 10jenkins-bot: Remove unused message reference [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187359 (owner: 10Adrian Lang) [13:35:44] (03PS1) 10Thiemo Mättig (WMDE): Drop dead code from snakview.variations.Value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187363 [13:37:56] (03PS2) 10Thiemo Mättig (WMDE): Drop dead code from snakview.variations.Value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187363 [13:38:01] (03CR) 10Adrian Lang: [C: 032] Drop dead code from snakview.variations.Value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187363 (owner: 10Thiemo Mättig (WMDE)) [13:39:00] (03CR) 10Adrian Lang: [C: 032] Drop dead code from snakview.variations.Value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187363 (owner: 10Thiemo Mättig (WMDE)) [13:39:14] (03PS1) 10Adrian Lang: Move stuff around in entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187364 [13:39:16] (03PS1) 10Adrian Lang: Don't attach event handlers if they don't do anything [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187365 [13:41:48] (03Merged) 10jenkins-bot: Drop dead code from snakview.variations.Value [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187363 (owner: 10Thiemo Mättig (WMDE)) [13:43:02] (03CR) 10jenkins-bot: [V: 04-1] Don't attach event handlers if they don't do anything [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187365 (owner: 10Adrian Lang) [13:43:16] (03CR) 10jenkins-bot: [V: 04-1] Move stuff around in entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187364 (owner: 10Adrian Lang) [13:50:12] [13WikibaseDataModel] 15thiemowmde created 06constructors (+1 new commit): 02http://git.io/FwWz [13:50:12] 13WikibaseDataModel/06constructors 1447bb167 15Thiemo Mättig: Drop "constructor is a constructor" docs [13:50:22] [13WikibaseDataModel] 15thiemowmde opened pull request #353: Drop "constructor is a constructor" docs (06master...06constructors) 02http://git.io/FwWr [13:50:29] (03PS2) 10Adrian Lang: Move stuff around in entityViewInit [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187364 [13:50:31] (03PS2) 10Adrian Lang: Don't attach event handlers if they don't do anything [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187365 [13:50:49] (03PS1) 10Thiemo Mättig (WMDE): Drop "constructor is a constructor" docs [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187368 [13:51:55] Reading Marku's wikidata game tools https://bitbucket.org/magnusmanske/wikidata-game/src/c55e19fecc52/tools/?at=master he assume the data is in a db. Anyone know what tool he uses to go from dump -> db? [13:52:14] wmde/WikibaseDataModel/constructors/47bb167 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/48760184 [14:09:12] https://img.pandawhale.com/post-10513-Code-Refactoring-Cat-in-Bathtu-U295.gif [14:10:48] Adrian_WMDE, heh [14:39:07] Adrian_WMDE: Henning_WMDE: has someone checked whether the wb-snakview renaming will break the AuthorityControl Gadget or the PropertySuggester? [14:40:51] Tobi_WMDE_SW: No, but AC gadget will break. [14:43:55] 3Wikidata: Adjust AuthorityControl Gadget to snakview name changes - https://phabricator.wikimedia.org/T87858#1000871 (10Tobi_WMDE_SW) 3NEW [14:45:56] [13ValueView] 15adrianheine created 06mwDep (+1 new commit): 02http://git.io/FwSE [14:45:56] 13ValueView/06mwDep 14ae763f0 15Adrian Heine: Remove mediaWiki dependency [14:48:39] wmde/ValueView/mwDep/ae763f0 : Adrian Heine The build failed. http://travis-ci.org/wmde/ValueView/builds/48766912 [14:49:48] [13ValueView] 15adrianheine 04force-pushed 06mwDep from 14ae763f0 to 14490edb8: 02http://git.io/FwHP [14:49:48] 13ValueView/06mwDep 14490edb8 15Adrian Heine: Remove mediaWiki dependency [14:50:18] [13ValueView] 15adrianheine opened pull request #154: Remove mediaWiki dependency (06master...06mwDep) 02http://git.io/FwHF [14:51:33] [13WikidataBuildResources] 15tobijat created 06update_propertysuggester (+1 new commit): 02http://git.io/FwQ4 [14:51:33] 13WikidataBuildResources/06update_propertysuggester 1423bb696 15Tobias Gritschacher: Use newest version of wikibase/property-suggester [14:51:49] [13WikidataBuildResources] 15tobijat opened pull request #20: Use newest version of wikibase/property-suggester (06master...06update_propertysuggester) 02http://git.io/FwQg [15:11:30] 3Wikidata, MediaWiki-extensions-WikibaseRepository: different styling for label/alias and description input - https://phabricator.wikimedia.org/T87576#1000890 (10Lydia_Pintscher) We basically have the following options, right? * border around label and aliases as well (I think that'd look horrible and add even m... [15:11:38] [13WikidataBrowserTests] 15tobijat 04deleted 06rnsnaklistview at 14801671a: 02http://git.io/FwhW [15:17:41] (03PS2) 10Thiemo Mättig (WMDE): Fix main snak displaying in diffs of qualifiers, ranks and references [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187344 (https://phabricator.wikimedia.org/T87096) (owner: 10Adrian Lang) [15:17:43] (03PS1) 10Thiemo Mättig (WMDE): Major refactoring of ClaimDifferenceVisualizer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187384 [15:21:43] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "PS2 is an (accidental) rebase. Found an actual issue, see comments. I did a follow-up. Please have a look and pick what you like, at least" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187344 (https://phabricator.wikimedia.org/T87096) (owner: 10Adrian Lang) [15:42:03] 3Wikidata, MediaWiki-extensions-WikibaseRepository: different styling for label/alias and description input - https://phabricator.wikimedia.org/T87576#1000898 (10Tobi_WMDE_SW) Fourth option: * keep it as it is (in line with the mockup). I think option 1 and 2 are out of discussion. For option 1 I guess @snaterl... [15:47:07] 3Wikidata, MediaWiki-extensions-WikibaseRepository: different styling for label/alias and description input - https://phabricator.wikimedia.org/T87576#1000900 (10Lydia_Pintscher) Ok great. Then let's try multiline without border and see if it is an improvement. [16:15:05] 3Wikidata, MediaWiki-extensions-WikibaseRepository: different styling for label/alias and description input - https://phabricator.wikimedia.org/T87576#1000944 (10Snaterlicious) Please clarify: No border is meant to be no border at all? How would you even guess there actually is an input element? [16:17:06] 3Wikidata, MediaWiki-extensions-WikibaseRepository: configure link for in other languages box should be a proper red link - https://phabricator.wikimedia.org/T87566#1000947 (10Snaterlicious) Status? [16:19:30] [13ValueView] 15thiemowmde comment on pull request #154 14490edb8: Why does GitHub highlight this comment in red? 02http://git.io/FroV [16:20:49] [13ValueView] 15thiemowmde comment on pull request #154 14490edb8: Half of this is dead code. `this.options.messageProvider` is checked to not be `false` in the line above. 02http://git.io/FrKq [16:21:24] [13ValueView] 15thiemowmde comment on pull request #154 14490edb8: The option is not guaranteed to be set. Probably a mistake in `_create`. 02http://git.io/FrKa [16:33:44] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06exception-on-nonsense-fallback from 14046ca94 to 14260d92d: 02http://git.io/Fmfn [16:33:44] 13WikibaseDataModel/06exception-on-nonsense-fallback 14260d92d 15Jan Zerebecki: [WIP] Throw exception on creation of nonsensical Fallbacks... [16:34:54] [13WikibaseDataModel] 15JanZerebecki comment on pull request #350 14260d92d: > ( 'requested', 'text', 'requested', 'source' ) => exception... 02http://git.io/Fryc [16:52:36] [13ValueView] 15adrianheine comment on pull request #154 14490edb8: Dunno, maybe because JSON is not allowed to have comments and GitHub thinks this is plain JSON? 02http://git.io/Frxq [16:53:21] [13ValueView] 15adrianheine comment on pull request #154 14490edb8: Right, the `if` statement is superfluos. 02http://git.io/Frxi [16:53:41] [13ValueView] 15adrianheine comment on pull request #154 14490edb8: yeah. 02http://git.io/FrxN [17:15:45] [13ValueView] 15thiemowmde comment on pull request #154 14490edb8: 1. I find the name a bit confusing. To me it sounds like it does some concatenation, but it's an alternative.... 02http://git.io/FotR [17:24:11] [13ValueView] 15thiemowmde comment on pull request #154 14490edb8: This ignores `params`. If intended (I think it is) then please describe this in the documentation. 02http://git.io/FoON [17:25:08] [13ValueView] 15thiemowmde comment on pull request #154 14490edb8: I would initialize this with `''`, but probably doesn't matter. 02http://git.io/Fo3G [17:26:28] [13ValueView] 15thiemowmde comment on pull request #154 14490edb8: Is it ok to access `util` here without it being mentioned in the list of dependencies (in the `( jQuery, jQuery.valueview.ExpertExtender )` line below)? 02http://git.io/FosI [17:32:55] 3Wikidata, Beta-Cluster: m.wikidata.beta.wmflabs.org/ redirects to a host that does not exist - https://phabricator.wikimedia.org/T87440#1001035 (10greg) p:5Triage>3Normal [17:36:35] hallo [17:36:37] is anybody in the SF office? [17:47:55] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Use existing $dateFormats to format dates on Wikidata - https://phabricator.wikimedia.org/T63958#1001082 (10He7d3r) [17:51:10] (03PS1) 10Henning Snater: Added Special page to set label, description and aliases at once [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187423 [17:56:48] (03PS2) 10Henning Snater: Added Special page to set label, description and aliases at once [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187423 [18:00:44] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Create a SpecialPage that allows to edit label, description and aliases together - https://phabricator.wikimedia.org/T72174#1001100 (10Snaterlicious) https://gerrit.wikimedia.org/r/#/c/187423/ [18:30:41] (03PS3) 10Lydia Pintscher: Added Special page to set label, description and aliases at once [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/187423 (https://phabricator.wikimedia.org/T72174) (owner: 10Henning Snater) [18:31:29] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Create a SpecialPage that allows to edit label, description and aliases together - https://phabricator.wikimedia.org/T72174#1001181 (10Lydia_Pintscher) [18:33:19] 3Wikidata, MediaWiki-extensions-WikibaseRepository: different styling for label/alias and description input - https://phabricator.wikimedia.org/T87576#1001184 (10Lydia_Pintscher) Sorry. No border except the underlining like for labels and aliases. [18:59:52] can someone have a look at https://www.wikidata.org/wiki/Special:Contributions/Mortier.Daniel please? [19:01:47] I have warned the user again... but what is the motivation? [23:22:37] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf16/b524cfa : Adrian Heine The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/48830807