[00:13:52] [13Diff] 15JeroenDeDauw 04force-pushed 06phpmd from 14cd8bb7f to 149522271: 02http://git.io/WgE76A [00:13:52] 13Diff/06phpmd 149522271 15jeroendedauw: Add initial PHPMD support and have the CI run it against src/ [01:37:22] (03PS1) 10Ricordisamoa: Fix 'license-name' to match SPDX conventions [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/185368 [01:42:19] (03CR) 10Ricordisamoa: "Should I change @license tags as well?" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/185368 (owner: 10Ricordisamoa) [03:33:23] (03CR) 10Krinkle: [C: 032] Fix 'license-name' to match SPDX conventions [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/185368 (owner: 10Ricordisamoa) [03:37:50] (03Merged) 10jenkins-bot: Fix 'license-name' to match SPDX conventions [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/185368 (owner: 10Ricordisamoa) [04:14:51] (03CR) 10Ricordisamoa: "What about @license annotations?" [extensions/Capiunto] - 10https://gerrit.wikimedia.org/r/185368 (owner: 10Ricordisamoa) [09:06:29] [13WikibaseDataModel] 15snaterlicious closed pull request #290: Make all Item constructor parameters optional (06master...06newEmpty) 02http://git.io/Uz_A2w [09:19:09] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 143e72385 to 14328a0cf: 02http://git.io/uH6jlQ [09:19:09] 13WikibaseDataModel/06emptyFingerprint 14328a0cf 15Thiemo Mättig: Allow constructing empty Fingerprint [09:25:53] Is there something funny here? Looks like this edit just added a badge and yet the diff size is +6,653! https://www.wikidata.org/w/index.php?title=Q186513&action=history [09:27:08] looks like it's Serbian, so the characters have to be escaped, perhaps that adds to the length... [09:27:55] [13WikibaseDataModel] 15snaterlicious 04deleted 06emptyFingerprint at 14328a0cf: 02http://git.io/McFVnA [09:45:09] [13WikibaseDataModel] 15thiemowmde created 06propertyFp (+1 new commit): 02http://git.io/LNISfg [09:45:09] 13WikibaseDataModel/06propertyFp 14b6ea356 15Thiemo Mättig: Optional fingerprint constructor parameter in Property [09:47:33] wmde/WikibaseDataModel/propertyFp/b6ea356 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/47223619 [09:49:28] [13WikibaseDataModel] 15thiemowmde opened pull request #342: Optional fingerprint constructor parameter in Property (06master...06propertyFp) 02http://git.io/5zLw4w [10:05:02] JeroenDeDauw: not sure what you mean with "in progress label" [10:05:06] (03PS1) 10Henning Snater: statementview toolbar definition: Updated naming [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185410 [10:05:08] (03PS1) 10Henning Snater: statementview: Not triggering "change" event [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185411 [10:05:27] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Don't trigger statementviewchange when starting editing - https://phabricator.wikimedia.org/T86895#981380 (10Snaterlicious) https://gerrit.wikimedia.org/r/#/c/185411/ [10:11:36] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Adds a more prominent display of entity URIs - https://phabricator.wikimedia.org/T85633#981411 (10Snaterlicious) Just an idea: That could be a chance to fill the skin template native

tag with meaningful information. [10:16:06] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06unserlialize from 14a2087d6 to 14541d1ed: 02http://git.io/5_4D9A [10:16:06] 13WikibaseDataModel/06unserlialize 14541d1ed 15Thiemo Mättig: Remove misleading return doc [10:17:13] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06fallBackDocs from 14fb8b54b to 1419ca116: 02http://git.io/4a1ZeA [10:17:13] 13WikibaseDataModel/06fallBackDocs 1419ca116 15Thiemo Mättig: More descriptive Term/AliasGroupFallback docs [10:18:29] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06diffdep from 14e997a81 to 146d38489: 02http://git.io/9nLfwQ [10:18:29] 13WikibaseDataModel/06diffdep 146d38489 15jeroendedauw: Stop using deprecated code in ItemDiffer and PropertyDiffer [10:21:17] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06release from 14707554a to 1416e7512: 02http://git.io/A2_fNg [10:21:17] 13WikibaseDataModel/06release 1416e7512 15jeroendedauw: 2.5 release [10:28:10] [13WikibaseDataModel] 15thiemowmde comment on pull request #334 1419ca116: @JeroenDeDauw I don't understand your answer, see above. How to proceed here? 02http://git.io/ifhKOA [10:29:20] 3Wikidata, Wikibase-Serialization-JavaScript: MediaWiki dependence - https://phabricator.wikimedia.org/T78273#981444 (10Snaterlicious) 5Open>3Resolved a:3Snaterlicious Yes, done with https://github.com/wmde/WikibaseSerializationJavaScript/pull/6. [10:29:57] 3Wikidata, Wikibase-Serialization-JavaScript: MediaWiki dependence - https://phabricator.wikimedia.org/T78273#981448 (10Snaterlicious) a:5Snaterlicious>3Wikidata-bugs [10:40:27] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Stopping edit mode in full sitelinklistview removes the table head - https://phabricator.wikimedia.org/T75310#981464 (10Snaterlicious) 5Open>3Resolved a:3Snaterlicious As the site links UI was rearranged with https://gerrit.wikimedia.org/r/#/c/173278/ and... [10:40:49] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Stopping edit mode in full sitelinklistview removes the table head - https://phabricator.wikimedia.org/T75310#981467 (10Snaterlicious) a:5Snaterlicious>3Wikidata-bugs [10:42:34] [13Diff] 15thiemowmde pushed 1 new commit to 06phpmd: 02http://git.io/cwkMbA [10:42:34] 13Diff/06phpmd 14b21c142 15thiemowmde: Drop last suppress tag [11:13:22] [13Diff] 15JanZerebecki closed pull request #30: Add initial PHPMD support and have the CI run it against src/ (06master...06phpmd) 02http://git.io/7jguwA [11:46:33] 3Wikidata, MediaWiki-extensions-WikibaseClient: StorageException from line 34 of TitleFactory.php: No page found for ID 1305 - https://phabricator.wikimedia.org/T87009#981577 (10aude) [11:55:24] 3Wikidata, MediaWiki-extensions-WikibaseClient: EntityUsage not cleaned up when deleting pages in client - https://phabricator.wikimedia.org/T87010#981586 (10aude) [12:02:26] [13Diff] 15thiemowmde created 06mdLimits (+1 new commit): 02http://git.io/EDP1PQ [12:02:26] 13Diff/06mdLimits 141dba1aa 15Thiemo Mättig: Re-enable disabled PHPMD rules [12:04:31] wmde/Diff#123 (mdLimits - 1dba1aa : Thiemo Mättig): The build passed. [12:04:31] Change view : https://github.com/wmde/Diff/commit/1dba1aa5403f [12:04:31] Build details : http://travis-ci.org/wmde/Diff/builds/47235476 [12:06:19] [13Diff] 15thiemowmde opened pull request #31: Re-enable disabled PHPMD rules (06master...06mdLimits) 02http://git.io/rUWeig [12:44:40] DanielK_WMDE_ / anyone that knows / once redirects are made can they be changed? [12:44:45] ie. in the case of double redirects? [12:46:22] (03PS2) 10Henning Snater: entitytermsview: Inject link to help page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 [13:17:54] addshore: yes, they can. [13:18:07] addshore: a redirect can be created on top of an empty entity, or an existing redirect [13:18:30] 3Wikidata, MediaWiki-extensions-WikibaseRepository: wikibase datetime parsers should be able to parse simple text - https://phabricator.wikimedia.org/T87018#981724 (10Lydia_Pintscher) p:5Triage>3Normal [13:21:18] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Number of "move" link increases when edit another site link - https://phabricator.wikimedia.org/T87015#981731 (10Lydia_Pintscher) p:5Triage>3Normal [13:21:46] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Do not show "move" link while adding a site link - https://phabricator.wikimedia.org/T87016#981734 (10Lydia_Pintscher) [13:22:06] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Do not show "move" link while adding a site link - https://phabricator.wikimedia.org/T87016#981737 (10Lydia_Pintscher) p:5Triage>3Normal [13:22:30] Lydia_WMDE: I think the move link should be converted to a icon. [13:22:53] sjoerddebruin: a lot of the text links should. (and will be as part of the redesign) [13:22:56] so yes. ack [13:23:13] 3Wikidata, MediaWiki-extensions-WikibaseClient: StorageException from line 34 of TitleFactory.php: No page found for ID 1305 - https://phabricator.wikimedia.org/T87009#981738 (10Lydia_Pintscher) p:5Triage>3High [13:23:28] DanielK_WMDE_: cheers! [13:23:33] It's also weird to have the badge link at the other side. All links should be at one place imo. [13:23:42] 3Wikidata, MediaWiki-extensions-WikibaseClient: EntityUsage not cleaned up when deleting pages in client - https://phabricator.wikimedia.org/T87010#981747 (10Lydia_Pintscher) p:5Triage>3High [13:27:40] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository: Create new item from client js does use no-lang tag - https://phabricator.wikimedia.org/T86439#981756 (10Lydia_Pintscher) p:5Normal>3High [13:28:53] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Special:NewItem uses wrong language when creating items - https://phabricator.wikimedia.org/T86929#981758 (10Lydia_Pintscher) p:5Triage>3High [13:30:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Adds a more prominent display of entity URIs - https://phabricator.wikimedia.org/T85633#981765 (10thiemowmde) A common solution for this is a tiny anchor/chain icon next to the headline with the "permalink" for the thing the headline describes. Additionally the... [13:30:37] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Number of "move" link increases when edit another site link - https://phabricator.wikimedia.org/T87015#981766 (10Raymond) >>! In T87015#981729, @Lydia_Pintscher wrote: > That is done by a gadget. Then it is time to add the functionality to the extension... [13:35:29] 3Wikidata, MediaWiki-extensions-WikibaseRepository: In Wikibase 31 07 2009 can be parsed but 31/07/2009 can not - https://phabricator.wikimedia.org/T87019#981773 (10Lydia_Pintscher) [13:36:05] hmmmmm [13:36:15] Lydia_WMDE: sorry for all these bugs I'm making ;p [13:36:29] addshore: ;-) don't be [13:37:08] when do you arrive in SF? [13:37:11] addshore: [13:37:33] 3Wikidata, MediaWiki-extensions-WikibaseRepository: In Wikibase 31 07 2009 can be parsed but 31/07/2009 can not - https://phabricator.wikimedia.org/T87019#981777 (10Lydia_Pintscher) p:5Triage>3Normal [13:38:55] 5:50pm ish on the 25th I think! [13:39:19] ah [13:39:23] * aude comes on saturday [13:40:02] * aude sees no snow predicted then on the east coast, so should be ok! [13:40:13] :) [13:40:26] the real question is when do you leave SF ? :P [13:40:35] wednesday afternoonish [13:41:14] so soon, im spending the week there :) [13:41:18] nice [13:41:45] i have to rage to my airline and then will be getting a different flight than what i have now [13:41:59] :D [13:42:04] they changed it w/o asking me to something i don't like :o [13:43:31] https://test.wikipedia.org/wiki/Kitten :P [13:43:37] it works :) [13:46:55] addshore: compare https://phabricator.wikimedia.org/T76859 and https://phabricator.wikimedia.org/T87018 [13:47:43] 3Wikidata, MediaWiki-extensions-WikibaseRepository: wikibase datetime parsers should be able to parse simple text - https://phabricator.wikimedia.org/T87018#981803 (10Addshore) [13:47:46] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Allows to input "today" in time edit widget - https://phabricator.wikimedia.org/T76859#981804 (10Addshore) [13:48:14] matej_suchanek: merged in! [13:49:48] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Allows to input of plain text such as "today" in time edit widget - https://phabricator.wikimedia.org/T76859#981810 (10Addshore) [13:52:48] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Special:NewItem uses wrong language when creating items - https://phabricator.wikimedia.org/T86929#981822 (10Thgoiter) Addendum: trigger for reporting this was here -> https://de.wikipedia.org/w/index.php?title=Portal%3ABahn%2FQualit%C3%A4tssicherung&diff=13780... [14:07:01] Does anyone have any idea where the deletion reasons for items are kept on WIkidata? [14:07:23] [[MediaWiki:Deletereason-dropdown]] [14:08:17] The ones for Items are not there :/ [14:08:36] *thinks gadget* [14:08:57] they are... in code [14:09:04] That. [14:09:12] oh! [14:15:14] 3Wikidata, MediaWiki-extensions-WikibaseClient: Number of changes loaded mismatches the number of change IDs provided - https://phabricator.wikimedia.org/T74333#981851 (10JanZerebecki) I did not find any occurrence of "number of change IDs provided" in logstash in the last 2 days (search over 7days never finishe... [14:24:00] 3Wikidata: wikibase diffs for datetime do not display the property label - https://phabricator.wikimedia.org/T87021#981867 (10Lydia_Pintscher) p:5Triage>3Low [14:31:39] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Make sitelink boxes collapsible - https://phabricator.wikimedia.org/T87024#981874 (10Lydia_Pintscher) 3NEW [14:35:40] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Show only the most relevant sitelinks initially - https://phabricator.wikimedia.org/T87025#981888 (10Lydia_Pintscher) 3NEW [14:38:27] https://test.wikipedia.org/wiki/Kitten_on_arbitrary_page :) [14:38:43] and no kitten https://test2.wikipedia.org/wiki/Arbitrary_kitten [14:41:02] https://phabricator.wikimedia.org/T87026 normal priority, probably config issue and we don't inject recent changes on wikidata [14:41:32] https://phabricator.wikimedia.org/T87010 - high priority, imho blocker to deploy [14:42:01] https://phabricator.wikimedia.org/T87009 is not nice but probably wouldn't occur often on wikidata alone [14:42:11] and probalby easy to fix [14:49:36] (03Abandoned) 10Aude: Use TermLookup in LinkBegin hook [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176804 (https://phabricator.wikimedia.org/T72767) (owner: 10Aude) [14:49:47] (03Abandoned) 10Aude: Refactor LinkBeginHookHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176805 (owner: 10Aude) [14:57:08] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Redirects - Ability to create a redirect over a deleted or empty entity - https://phabricator.wikimedia.org/T71166#981929 (10Addshore) 12:44 PM DanielK_WMDE_ / anyone that knows / once redirects are made can they be changed? 1:17 PM a... [15:21:33] 3Wikidata, Wikidata.org: Preview gadget no longer working in new sitelinks UI - https://phabricator.wikimedia.org/T86755#981951 (10Lydia_Pintscher) [15:21:34] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Implement new SiteLink UI - https://phabricator.wikimedia.org/T70903#981950 (10Lydia_Pintscher) [15:23:00] 3Wikidata, MediaWiki-extensions-WikibaseRepository: sorting sitelinks - https://phabricator.wikimedia.org/T86757#981955 (10Lydia_Pintscher) [15:24:10] 3Wikidata, MediaWiki-extensions-WikibaseRepository: sorting sitelinks - https://phabricator.wikimedia.org/T86757#975702 (10Lydia_Pintscher) Discussed use cases on-wiki. It is a power-user feature. Once the sitelink sections has "more" buttons for actions we can have an action there to sort by title. [15:35:31] (03PS4) 10Thiemo Mättig (WMDE): Move Repo Hooks classes to Hooks folder/namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176661 [15:37:16] (03CR) 10JanZerebecki: [C: 032] Move Repo Hooks classes to Hooks folder/namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176661 (owner: 10Thiemo Mättig (WMDE)) [15:39:53] (03Merged) 10jenkins-bot: Move Repo Hooks classes to Hooks folder/namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176661 (owner: 10Thiemo Mättig (WMDE)) [15:44:58] (03CR) 10JanZerebecki: [C: 031] "Looks good, waiting for answer from Daniel." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [15:45:15] (03PS4) 10Thiemo Mättig (WMDE): Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 [15:45:30] !merge DanielK_WMDE_ [15:45:30] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/DanielK_WMDE_/ [15:45:53] !merge 184996 [15:45:53] merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/184996/ [15:46:50] if someone is around on monday to backport it, would be nice [15:48:54] it's ~1 out of every 8 entries in the exception log [15:49:02] not horrible but not nice [15:56:52] [13Diff] 15JeroenDeDauw comment on pull request #31 141dba1aa: So if you got an associative array with a thousand elements, it'll now do a thousand iterations instead of one? Decreasing the quality of the code just to match a fault CS rule is the opposite of what these tools intend you to do. 02http://git.io/MPSUAg [15:58:23] [13Diff] 15JeroenDeDauw comment on pull request #31 141dba1aa: The cs command I added here is intended for all code checking. What tools are used for that is an implementation detail. 02http://git.io/Sdu77g [16:14:11] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #342 14b6ea356: Not very consistent 02http://git.io/QWvkmw [16:14:50] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06propertyFp at 14b6ea356: 02http://git.io/yyon4A [16:15:08] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/7Mq4jw [16:15:08] 13WikibaseDataModel/06master 141a9577f 15Jeroen De Dauw: Update RELEASE-NOTES.md [16:15:43] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/NtKpQw [16:15:43] 13WikibaseDataModel/06master 14a891649 15Jeroen De Dauw: Update RELEASE-NOTES.md [16:23:27] Hi [16:23:48] Hi George [16:24:45] (03PS3) 10Jeroen De Dauw: Address Adrians comment and remove not needed else-clause and local var [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184892 [16:24:57] Hi Matej :-) [16:25:09] (03CR) 10Jeroen De Dauw: Address Adrians comment and remove not needed else-clause and local var (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184892 (owner: 10Jeroen De Dauw) [16:26:05] (03CR) 10Daniel Kinzler: [C: 032] "o_O I gave a +2 this morning?..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [16:29:19] (03Merged) 10jenkins-bot: Handle Article ID of 0 in AffectedPagesFinder and usage lookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [16:31:00] (03PS3) 10Thiemo Mättig (WMDE): Clean up and refactor TemplateFactory introduction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180498 [16:33:38] (03CR) 10Daniel Kinzler: [C: 04-1] "Looks good in principle, but I find code harder to read than before. Please split the code into smaller methods (see comment)." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [16:35:41] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [16:37:36] [13WikibaseDataModel] 15thiemowmde comment on pull request #342 14b6ea356: Not sure what you mean. The property's type parameter can't be optional. 02http://git.io/B4uyVQ [16:45:10] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "There is not a single "style changes only" file in this patch." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [16:45:57] (03PS1) 10Daniel Kinzler: Fix handling of deleted pages in getAffectedUsagesByPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185446 (https://phabricator.wikimedia.org/T87009) [16:52:51] (03PS1) 10JanZerebecki: Handle Article ID of 0 in AffectedPagesFinder and usage lookup [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185448 (https://phabricator.wikimedia.org/T86828) [16:55:40] (03PS5) 10Thiemo Mättig (WMDE): Rework and clean up TermIndex interfaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 [16:56:59] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "Please review and merge Ibec48cffirst, I will rebase this later." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [16:57:46] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up TermIndex interfaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 (owner: 10Thiemo Mättig (WMDE)) [17:17:32] greg-g: if we enable usage tracking next week, the impact should be fairly low [17:17:51] [13Diff] 15thiemowmde comment on pull request #31 141dba1aa: Daniel would say something about premature optimization at this point. I even micro-benchmarked this. It's fine. 02http://git.io/_r-xkw [17:18:07] would affect pages like https://www.wikidata.org/wiki/Wikidata:List_of_properties [17:18:34] and yay, for no train :) [17:18:37] aude: if you can get everything merged/tested in time for Tuesday, that should be ok (some of my team will already be in SF, not all of Ops though) [17:18:52] it would be wednesday [17:18:57] would that be ok? [17:19:01] wed is no go, unfortunately [17:19:05] hm [17:19:06] ok [17:19:10] and thur (and fri) [17:19:19] let's wait then [17:19:23] wed/thur everyone will be device-that-can-debug-prod-less [17:19:30] :) [17:19:32] :) [17:19:49] first week of february [17:19:55] coolio [17:20:11] * aude is on holiday on monday and tuesday [17:20:24] thanks for understanding, and sorry for the late notice on that (I was procrastinating and doing lame quarterly review prep yesterday instead) [17:20:29] enjoy! [17:20:46] [13Diff] 15thiemowmde comment on pull request #31 141dba1aa: Which raises the question why we need two tools to do the same? Or the other way around, if they are not the same, why shouldn't it be possible to run them independently? 02http://git.io/AwZLBQ [17:20:51] not a problem [17:22:10] hmm, does anyone know of a property to say that a company has a branch in a given location? [17:22:10] february 2? (a monday) [17:23:24] addshore: i know there is one for headquarters location [17:23:26] but that doesn't help [17:24:10] :D [17:24:16] Unless I create an Item for the branch :/ [17:24:34] that still wouldnt quite work [17:26:14] (03CR) 10Thiemo Mättig (WMDE): [V: 032] "What is going on here? Why does a completely unrelated test constantly fail? Why does recheck not work?" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [17:26:15] :/ [17:37:20] Hoi, I did not say but I do ... I like the new UI for entering interlanguage links :) [17:42:06] (03CR) 10JanZerebecki: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [17:42:33] (03CR) 10jenkins-bot: [V: 04-1] Option parameter can be null/undefined in PHP [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [17:51:20] (03PS3) 10Thiemo Mättig (WMDE): Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 [17:54:40] (03CR) 10jenkins-bot: [V: 04-1] Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [17:54:43] (03PS6) 10Thiemo Mättig (WMDE): Rework and clean up TermIndex interfaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 [17:58:37] in 3min there is a wikidata office hour in #wikimedia-office [17:58:45] Cool [17:58:57] (03PS4) 10Thiemo Mättig (WMDE): Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 [18:00:34] GerardM-: \o/ [18:01:37] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "No test? :-(" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185446 (https://phabricator.wikimedia.org/T87009) (owner: 10Daniel Kinzler) [18:03:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I remember touching the same code (in an unmerged patch?) or at least very similar code. Well, ..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184892 (owner: 10Jeroen De Dauw) [18:04:03] (03Merged) 10jenkins-bot: Fix handling of deleted pages in getAffectedUsagesByPage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185446 (https://phabricator.wikimedia.org/T87009) (owner: 10Daniel Kinzler) [18:05:36] (03Merged) 10jenkins-bot: Address Adrians comment and remove not needed else-clause and local var [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184892 (owner: 10Jeroen De Dauw) [18:06:21] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Why does ":last" not do the same as calling last()? Can you explain that?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183502 (owner: 10Henning Snater) [18:07:08] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Altered initialization order in entityview widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183852 (owner: 10Henning Snater) [18:08:34] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Do not trigger "change" event when handling empty elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183456 (https://phabricator.wikimedia.org/T76849) (owner: 10Henning Snater) [18:08:56] (03PS1) 10JanZerebecki: Fix handling of deleted pages in getAffectedUsagesByPage [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185473 (https://phabricator.wikimedia.org/T87009) [18:09:19] (03Merged) 10jenkins-bot: tagadata: Fixed tag detection on blur [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183502 (owner: 10Henning Snater) [18:09:32] (03CR) 10Thiemo Mättig (WMDE): [C: 032] claimlistview: Removed obsolete _listItemWidget member [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185162 (owner: 10Henning Snater) [18:10:31] (03Merged) 10jenkins-bot: Altered initialization order in entityview widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183852 (owner: 10Henning Snater) [18:11:44] (03Merged) 10jenkins-bot: Do not trigger "change" event when handling empty elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183456 (https://phabricator.wikimedia.org/T76849) (owner: 10Henning Snater) [18:13:39] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "The global $wgLang; is very weird, but unrelated." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) (owner: 10Addshore) [18:15:58] (03Merged) 10jenkins-bot: Add language hint placeholders in SpecialNewEntity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184784 (https://phabricator.wikimedia.org/T86673) (owner: 10Addshore) [18:18:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Special:NewItem doesn't say in what language the label and description would be - https://phabricator.wikimedia.org/T86673#982327 (10Addshore) 5Open>3Resolved a:3Addshore merged [18:21:27] addshore: that was fast! [18:29:24] fixed it the day you made the issue I believe :) [18:46:17] 3Wikidata: disable compact personal bar beta feature from Wikidata - https://phabricator.wikimedia.org/T86831#982504 (10Jaredzimmerman-WMF) p:5High>3Volunteer? [19:09:52] for Java, is Wikidata-Toolkit the library to use for wikidata? [19:10:06] or are there other tools I should consider? [19:10:42] egonw: Totally depends on what you want to do (and also in what language) [19:11:12] hoo: english, maybe others though.... [19:11:18] Lydia_WMDE: https://meta.wikimedia.org/wiki/IRC_office_hours/Office_hours_2015-01-16 [19:11:33] hoo: but in wikidata lang doesn't matter, or... ? [19:11:40] aude: argh,,, did I miss the office hour? [19:11:49] aude: sweet [19:11:50] thanks [19:11:57] hoo: yeah :( [19:12:21] Meh, I should have set a reminder... hopefully there were no questions for me :P [19:12:32] :O [19:12:51] egonw: Oh, I thought about programming languages :P [19:13:14] yes! but I started with... "for Java, ..." [19:13:16] Sometimes even such terms can be ambiguous [19:13:24] Oh, doh [19:13:30] already though the question was weird :) [19:13:34] +t [19:13:58] But then still, what do you exactly plan to do? [19:14:26] (There aren't any other solutions in Java, so wikidata toolkit probably is the answer, but more context might still help) [19:14:31] well... play with wikidata... read stuff from it [19:14:37] egonw: pywikibot? [19:14:45] ah, yes, if no other, than that is the one :) [19:14:51] no, stuck with Java; here's why: [19:15:11] I worked on Bioclipse a lot, a Eclipse RCP based platform for chem/bioinformatics [19:15:13] then the toolkit is good [19:15:18] which has a plugin mechanism... [19:15:48] should be quite good and probably better for "playing" with wikidata (vs. bots with pywikibot) [19:15:54] and plugins extend JavaScript/Groovy/Python with "managers" that add domain specific functionaliyu... [19:16:07] we already have many, so can easily mix stuff... [19:16:18] egonw: sure [19:16:26] now, I am a chemist... and there are managers for ChemSpider/PubChem... [19:16:49] so, want to make a wikidata manager to do some data checking for chem compound identifiers [19:17:16] well, tonite that is... after that, who knows... [19:17:34] Yeah, Wikidata toolkit is totally the tool for that :) [19:17:47] cool, thanx [19:17:52] I never used it myself, but from what I saw it's pretty awesome [19:18:07] yeah, it looked quite powerful indeed [19:41:53] 3Mobile-Web, MediaWiki-Search, MediaWiki-extensions-WikibaseRepository, Wikidata: search for WIkidata should use entity selector on mobile as well - https://phabricator.wikimedia.org/T85368#982711 (10kaldari) Any thoughts on which team would be more appropriate to tackle this (mobile or wikidata)? [19:45:10] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982720 (10kaldari) Would it make more sense for the mobile team to fix this bug or the wikidata team? [19:50:37] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982746 (10Lydia_Pintscher) I think the next step is figuring out why they are not shown. And for that the mobile team is probably better. [19:52:59] 3Mobile-Web, MediaWiki-Search, MediaWiki-extensions-WikibaseRepository, Wikidata: search for WIkidata should use entity selector on mobile as well - https://phabricator.wikimedia.org/T85368#982758 (10Lydia_Pintscher) If you have spare cycles please do. I have no idea when we'll have them unfortunately. [19:54:19] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982770 (10Jdlrobson) They are not shown because we hid them.... (not showing them is better than showing them broken) http://wikidata.org/wiki/MediaWiki:Mobile.cs... [19:57:51] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982792 (10Jdlrobson) (.wb-snaklistview is display:none;} FWIW personally I think this show be hidden by default on mobile and revealable - the interface can look... [19:58:22] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982799 (10Lydia_Pintscher) Aha! Ok. Makes sense. And yes. Still the case. It really depends how much work this is going to be for you to fix. I don't want to make... [19:58:46] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: Unit Localization - https://phabricator.wikimedia.org/T86528#982803 (10JanZerebecki) >>! In T86528#970857, @Snaterlicious wrote: > Will we please convert label, description and aliases to statements then? Yes, good idea. Although that would be a quite inv... [20:02:46] 3Mobile-Web, MediaWiki-extensions-WikibaseRepository, Wikidata: Wikidata qualifiers are not shown on mobile - https://phabricator.wikimedia.org/T85366#982820 (10Lydia_Pintscher) >>! In T85366#982792, @Jdlrobson wrote: > (.wb-snaklistview is display:none;} > FWIW personally I think this show be hidden by default... [20:07:04] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #342 14b6ea356: Wording in the rel notes 02http://git.io/25OojA [20:10:21] jzerebecki: http://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [20:27:49] [13WikibaseQueryEngine] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/6kl_yg [20:27:49] 13WikibaseQueryEngine/06master 14e2867ed 15Jeroen De Dauw: Merge pull request #144 from wmde/travis_retry... [20:29:44] Lydia_WMDE: Do you already have a bug for duplicate label warnings and caching? [20:30:18] To https://www.wikidata.org/wiki/Q17817947 I tried to add "Portret van een man". This gave a duplicate label warning. I changed the description to "schilderij van Frans Hals, waarschijnlijk Johannes Saeckma" and tried to save [20:30:38] Got duplicate label warning: Bug1: It should set the description first and than try the label again. [20:31:00] It picks the previous value each time. [20:31:12] Refresh and it will save. But that's not how I would like it. :) [20:31:19] I removed the label, saved it and than tried the label again. Dupe warning. Had to reload the page before I good add it. (bug2) [20:36:14] multichill: no i don't think we have one for that. can you make one please? [20:36:29] Lydia_WMDE: both? [20:36:44] yes [20:38:31] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: Unit Localization - https://phabricator.wikimedia.org/T86528#982899 (10JanZerebecki) >>! In T86528#975324, @adrianheine wrote: > For example, we would not have to implement AuthorityControl in WikibaseRepo, instead, we could Wikibase flexible enough to all... [22:02:17] (03PS1) 10Daniel Kinzler: Show fallback language on item links. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185554 (https://phabricator.wikimedia.org/T85105) [22:02:45] (03PS1) 10Daniel Kinzler: Update wbc_entity_usage upon page deletion. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 [22:03:11] (03CR) 10Daniel Kinzler: "(not yet manually tested, since I broke my test install)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185554 (https://phabricator.wikimedia.org/T85105) (owner: 10Daniel Kinzler) [22:03:14] (03CR) 10Daniel Kinzler: "(not yet manually tested, since I broke my test install)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (owner: 10Daniel Kinzler) [22:08:18] (03PS2) 10Daniel Kinzler: Update wbc_entity_usage upon page deletion. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185555 (https://phabricator.wikimedia.org/T87010)