[00:04:36] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#977856 (10JeroenDeDauw) This generally seems fine to me. Definitely better than the current terms table. > Lookup by label/alias should be impleme... [01:02:46] (03CR) 10Hoo man: [C: 032] Optimized imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185086 (owner: 10Jeroen De Dauw) [01:06:12] (03Merged) 10jenkins-bot: Optimized imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185086 (owner: 10Jeroen De Dauw) [03:09:28] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Implement new SiteLink UI - https://phabricator.wikimedia.org/T70903#978571 (10Ricordisamoa) [03:09:29] 3Wikidata, Wikidata.org: create gadget to remove site id in language link list - https://phabricator.wikimedia.org/T85914#978567 (10Ricordisamoa) 5Open>3Resolved a:3Ricordisamoa Imported by @Sjoerddebruin as https://www.wikidata.org/wiki/MediaWiki:Gadget-SiteIdToInterwiki.js [03:09:49] 3Wikidata, Wikidata.org: create gadget to remove site id in language link list - https://phabricator.wikimedia.org/T85914#978572 (10Ricordisamoa) a:5Ricordisamoa>3None [07:05:46] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Automatically drop redundant sitelink to redirect when merging in wbmergeitems api module - https://phabricator.wikimedia.org/T85347#978790 (10petr.matas) It can happen the following way: - Create [[en:Bonnie Parker]], linked to a new item Q1 - Create [[en:Clyd... [08:14:23] [13Diff] 15adrianheine comment on pull request #30 14cd8bb7f: There is a fix for this issue in phpmd/phpmd#198 which will be in the next PMD release 2.2.0. I'm ok with merging this. I'd like to have a comment refering to the fix and explaining why it's currently present. 02http://git.io/8qAjwA [08:18:18] [13Diff] 15adrianheine comment on pull request #30 14cd8bb7f: Do you think we could get rid of this easily? If so, I'd like to have a task for that on phabricator. If not, I'd prefer to increase the respective limit to just enough for this class to pass. 02http://git.io/l7eR3A [08:30:55] question ... on a list of mayors, should the property "is a list of" be "human"/Q5, "mayor" or "people' ... most of them are the last one, but my gut feeling is that it is not the best value [08:32:58] hashar: Hi, I just made the failing test non-voting in https://gerrit.wikimedia.org/r/#/c/180418/, since I don't know how to pull in composer there. [08:33:34] ederoo [08:33:38] hashar: It's the testextension test which is in mwext-check-jobs. Not easily customizable, I guess [08:33:41] is a list of human [08:34:02] I think it should be list of people [08:34:04] and then you can add to that [08:34:11] Species does not matter there [08:34:13] it would be occupation held mayor [08:34:52] but they could be a group of people [08:34:58] or whatever [08:35:01] it does matters [08:35:02] :) [08:35:38] https://www.wikidata.org/wiki/Q8884558 for an example [08:43:46] I think the first thing to achieve is to be consequent ... most of them are "people" now, and "mayor " and "human" are the odd ones out there [08:44:15] hashar: did you get my message above? [08:44:32] good morning sjoerddebruin [08:47:10] Adrian_WMDE: nop I dont have a bouncer / IRC history [08:47:29] Adrian_WMDE: hashar: Hi, I just made the failing test non-voting in https://gerrit.wikimedia.org/r/#/c/180418/, since I don't know how to pull in composer there. [08:47:32] Adrian_WMDE: hashar: It's the testextension test which is in mwext-check-jobs. Not easily customizable, I guess [08:48:44] Adrian_WMDE: we would to either override it or craft a composer based one :-] [08:49:22] Adrian_WMDE: we need the testextension job, it runs mediawiki/core 'structure' tests which verify the autoloader and resourceloader are properly set [08:49:29] hashar: I'd like to defer that to get tests passing again for that repo [08:50:07] Mh, but the QUnit tests would fail, too, if there were an issue with the resource loader module definitions [08:50:19] Don't get me wrong, I love having a specific test for that [08:50:44] It's just that I want to continue working on that repository, and right now making the test non-voting seems to be the quickest way to get there [08:50:48] Adrian_WMDE: let me finish what I am doing and I will give it a try [08:51:31] Ok, that would be cool [08:52:05] Adrian_WMDE: what we could do is teach test extension jobs to run composer whenever it finds a package.json at the root of the extension repo [08:52:12] so we would reuse the same job template :-] [08:53:03] I thought about that, too, but I assumed you folks would have more reservations against that since it would possibly affect other extensions, too [08:55:56] Adrian_WMDE: yeah it will definitely affects other extensions [08:57:17] we would need a dedicated job that is solely composer based [08:57:29] i.e. clone a single extension, run composer to fetch dependencies then run the tests [08:57:58] i.e. assume the dependencies are all provided by composer, thus there should be no need to clone other extensions [08:58:17] * hashar hates dependencies management [08:58:42] Ok, so one with gerrit cloning and one with composer installing [08:59:40] yup [08:59:53] Sounds great [09:00:00] this way we ensure the extension works with the tip of branches from other repositories [09:00:16] which is great for development / continuous integration [09:00:21] and ensure as well that composer dependencies are properly set [09:00:35] that also mean adding moaaar jobs [09:15:00] There seems to be a problem with propagation of changes [09:15:07] are you aware of anything ? [09:16:35] GerardM-: I think we are [09:16:42] Let me search the ticket [09:16:54] https://phabricator.wikimedia.org/T86765 [09:17:05] not sure about the status of deployment [09:17:43] well things are broken [09:17:58] WDQ is so are my tools like who died in 2015 [09:18:32] aude knows the status [09:26:21] Does somebody speak Arabic here? https://www.wikidata.org/wiki/Talk:Q12187490 [09:26:52] It seems just content for a article. [09:30:55] (03PS1) 10Aude: Revert "Make NoLangLinkHandler testable." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185135 (https://phabricator.wikimedia.org/T86886) [09:32:30] (03PS1) 10Aude: Revert "Make NoLangLinkHandler testable." [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185136 (https://phabricator.wikimedia.org/T86886) [09:33:37] (03CR) 10Adrian Lang: "Reverted in Ibf6258dc86dc9d244871fbecac2bf41c3c569bcf." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159762 (owner: 10Daniel Kinzler) [09:39:55] * hoo waves [09:41:46] hoo: https://gerrit.wikimedia.org/r/#/c/185136/ (at least on the branch) [09:42:03] looking [09:42:18] not nice for the dewiki (and others) folks [09:43:06] maybe we can actually do a fix on master instead [09:43:24] (03CR) 10Hoo man: [C: 032] "Simple revert, ok for now" [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185136 (https://phabricator.wikimedia.org/T86886) (owner: 10Aude) [09:43:31] thanks [09:43:41] Will you deploy that now-ish? [09:44:10] if you think we should [09:44:28] * aude thinks so and there are ops folks around now [09:45:07] Should be ok, it's a simple revert after all [09:45:12] k [09:45:17] manually verified, of course [09:45:54] (03Merged) 10jenkins-bot: Revert "Make NoLangLinkHandler testable." [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185136 (https://phabricator.wikimedia.org/T86886) (owner: 10Aude) [09:49:53] (03PS1) 10Aude: Update Wikidata, fix noexternallanglinks [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185141 [09:50:41] aude: Did we branch this week, btw? I'm so busy with other stuff atm... :( [09:51:00] no [09:51:13] since i'm not around next tuesday, etc. [09:51:19] ah ok, thought I missed that [09:51:27] Oh, I could have done next week [09:51:46] should have more time by then [09:51:47] too many issues this week [09:51:53] that's true :( [09:52:05] we'll branch again after the summit [09:52:56] and the fact that we broke recentchanges on beta etc [09:54:08] :/ [09:54:39] What's the state of https://github.com/wmde/WikidataBuildResources/pull/17 btw? [09:54:51] I per hand applied it when I made the branch last time [09:54:58] my patch is not merged yet [09:55:11] afaik but can poke bd808 [09:55:37] (03CR) 10Aude: [C: 032] Update Wikidata, fix noexternallanglinks [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185141 (owner: 10Aude) [09:56:38] * aude notes we have to update wmf15 core too [09:56:55] probably will include that in swat later, along with the fix for change notifications [09:57:32] (03Merged) 10jenkins-bot: Update Wikidata, fix noexternallanglinks [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/185141 (owner: 10Aude) [09:57:37] Commented on the vagrant change [09:59:08] ok [10:04:35] aude: Do you think https://gerrit.wikimedia.org/r/181718 is worth reviewing? [10:04:49] I know it grew way more complicated than I wished for [10:06:38] i think it is but would be happier if daniel approved it [10:10:35] fixed, deployed [10:10:40] :) [10:10:43] * aude purged the main page on dewiki and enwiki [10:10:50] No log entry for the deploy? [10:11:01] ah nevermind [10:12:12] i will leave the task open and put in sprint [10:12:18] until it is fixed somehow on master [10:12:36] yeah [10:13:05] * aude back in ~30 min [10:13:21] I'll be back later on... or tomorrow [10:13:35] Hopefully I find time to work tomorrow... my backlog is huge [10:23:11] (03PS2) 10Adrian Lang: Do not trigger "change" event when handling empty elements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183456 (https://phabricator.wikimedia.org/T76849) (owner: 10Henning Snater) [10:28:57] (03CR) 10Adrian Lang: [C: 032] referenceview edit toolbar: Have "save" button disabled initially [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183451 (owner: 10Henning Snater) [10:31:31] (03Merged) 10jenkins-bot: referenceview edit toolbar: Have "save" button disabled initially [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183451 (owner: 10Henning Snater) [10:36:04] hé Romaine [10:40:05] [13WikibaseDataModel] 15thiemowmde comment on pull request #328 145b38a35: Please try to do the same.... 02http://git.io/yprTrw [10:48:35] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06getSerializations from 145b38a35 to 14c1432b5: 02http://git.io/iEQWgg [10:48:35] 13WikibaseDataModel/06getSerializations 14c1432b5 15Thiemo Mättig: Add ItemIdSet::getSerializations [10:59:57] [13WikibaseDataModel] 15thiemowmde comment on pull request #328 14c1432b5: What's the "less complex" alternative? Really, I was thinking about this but everything I can come up with is equally "complex" (probably depends on what "complex" means to you). Something like that?... 02http://git.io/NdXEYw [11:05:53] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06getSerializations from 14c1432b5 to 143d32b46: 02http://git.io/iEQWgg [11:05:53] 13WikibaseDataModel/06getSerializations 143d32b46 15Thiemo Mättig: Add ItemIdSet::getSerializations [11:06:44] [13WikibaseDataModel] 15adrianheine comment on pull request #328 143d32b46: I also tend to make tests too complex in order to be DRY. As @JeroenDeDauw wrote, this introduces the risk of reproducing mistakes you did in the production code, thereby masking these mistakes in the production code.... 02http://git.io/5lgAeQ [11:11:14] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 1405b2af9 to 145ba11bd: 02http://git.io/uH6jlQ [11:11:14] 13WikibaseDataModel/06emptyFingerprint 145ba11bd 15Thiemo Mättig: Allow constructing empty Fingerprint [11:21:04] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newEmpty from 14bfd9103 to 148d335b3: 02http://git.io/OcS3vw [11:21:04] 13WikibaseDataModel/06newEmpty 148d335b3 15Thiemo Mättig: Make all Item constructor parameters optional [11:23:41] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newEmpty from 148d335b3 to 14e36fec3: 02http://git.io/OcS3vw [11:23:41] 13WikibaseDataModel/06newEmpty 14e36fec3 15Thiemo Mättig: Make all Item constructor parameters optional [11:28:50] (03CR) 10Adrian Lang: "I think this change would only mask the underlying issue, which (in my opinion) is that the 'sitelinkgroupviewafterstartediting sitelinkgr" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183456 (https://phabricator.wikimedia.org/T76849) (owner: 10Henning Snater) [11:29:22] [13WikibaseDataModel] 15thiemowmde 04deleted 06AliasGroupListtta at 147e33abf: 02http://git.io/ZR5j_g [11:34:29] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06fallBackDocs from 146f21c3f to 14fb8b54b: 02http://git.io/4a1ZeA [11:34:29] 13WikibaseDataModel/06fallBackDocs 14fb8b54b 15Thiemo Mättig: More descriptive Term/AliasGroupFallback docs [11:36:42] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06unserlialize from 14feaa869 to 1468dee42: 02http://git.io/5_4D9A [11:36:42] 13WikibaseDataModel/06unserlialize 1468dee42 15Thiemo Mättig: Remove misleading return doc [11:37:19] 3Wikidata, MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Cannot add url values as an anonymous or unconfirmed user - https://phabricator.wikimedia.org/T86453#979193 (10Florian) The missing error message should be solved with this change, which adds an error message to the status object returned by Confir... [11:46:17] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newMethods from 141aa1ba1 to 14a124b58: 02http://git.io/6FMa1g [11:46:17] 13WikibaseDataModel/06newMethods 14a124b58 15Thiemo Mättig: Add GUID to constructors [11:50:40] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06statementList from 14655ef27 to 141cebacb: 02http://git.io/OhntxQ [11:50:40] 13WikibaseDataModel/06statementList 141cebacb 15Thiemo Mättig: StatementList constructor accepts Statement [11:57:57] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06statementList from 141cebacb to 14c1edeeb: 02http://git.io/OhntxQ [11:57:57] 13WikibaseDataModel/06statementList 14c1edeeb 15Thiemo Mättig: StatementList constructor accepts Statement [12:19:30] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Automatically drop redundant sitelink to redirect when merging in wbmergeitems api module - https://phabricator.wikimedia.org/T85347#979291 (10Addshore) But this is a sort of broken state which breaks things. There should only ever be one sitelink on one item (... [12:46:10] (03PS1) 10Adrian Lang: Fix typo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185160 [12:46:44] ^ jzerebecki Henning_WMDE aude: merge :) [12:47:27] (03CR) 10Henning Snater: [C: 032] Fix typo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185160 (owner: 10Adrian Lang) [12:47:32] (03CR) 10JanZerebecki: [V: 032] Fix typo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185160 (owner: 10Adrian Lang) [12:49:50] (03PS1) 10Aude: Fix passing arguments in NoLangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185161 (https://phabricator.wikimedia.org/T86886) [12:50:54] (03Merged) 10jenkins-bot: Fix typo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185160 (owner: 10Adrian Lang) [12:52:49] (03Abandoned) 10Aude: Revert "Make NoLangLinkHandler testable." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185135 (https://phabricator.wikimedia.org/T86886) (owner: 10Aude) [12:52:51] (03CR) 10Adrian Lang: [C: 031] Fix passing arguments in NoLangLinkHandler (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185161 (https://phabricator.wikimedia.org/T86886) (owner: 10Aude) [12:53:55] (03CR) 10Aude: Fix passing arguments in NoLangLinkHandler (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185161 (https://phabricator.wikimedia.org/T86886) (owner: 10Aude) [12:54:05] (03PS2) 10Aude: Fix passing arguments in NoLangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185161 (https://phabricator.wikimedia.org/T86886) [12:57:44] (03CR) 10Adrian Lang: Fix passing arguments in NoLangLinkHandler (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185161 (https://phabricator.wikimedia.org/T86886) (owner: 10Aude) [12:58:06] (03PS1) 10Henning Snater: claimlistview: Removed obsolete _listItemWidget member [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185162 [13:01:13] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979331 (10aude) I generally agree with Daniel's proposal and think Elastic is suitable for the lookup use cases. Elastic well works for both "sear... [13:06:50] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979333 (10daniel) @jeroen: the "lookup" may be an exact match, case insensitive, and/or a prefix match. The code that handles these cases for wb_te... [13:25:21] (03PS1) 10Henning Snater: Updated claimlistview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185166 [13:26:57] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Sitelink edit header doesn't fit Sitelink table - https://phabricator.wikimedia.org/T86884#979367 (10Lydia_Pintscher) p:5Low>3Normal [13:28:05] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Don't trigger statementviewchange when starting editing - https://phabricator.wikimedia.org/T86895#979371 (10Lydia_Pintscher) [13:28:31] (03PS2) 10Henning Snater: Updated claimlistview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185166 [13:29:19] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Sitelink edit header doesn't fit Sitelink table - https://phabricator.wikimedia.org/T86884#979376 (10Lydia_Pintscher) [13:29:22] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Implement new SiteLink UI - https://phabricator.wikimedia.org/T70903#979375 (10Lydia_Pintscher) [13:32:08] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Write example queries in different query languages - https://phabricator.wikimedia.org/T86786#979381 (10Lydia_Pintscher) [13:32:10] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Wikidata Query - make unit tests for domain specific language - https://phabricator.wikimedia.org/T86832#979379 (10Lydia_Pintscher) [13:32:11] 3Wikidata, MediaWiki-extensions-WikibaseClient: InvalidArgumentException from line 34 of PageEntityUsages.php: $pageId must be an integer > 0 - https://phabricator.wikimedia.org/T86828#979380 (10Lydia_Pintscher) [13:32:13] 3Wikidata, wikidata-query-service, operations: Wikidata Query Service hardware - https://phabricator.wikimedia.org/T86561#979383 (10Lydia_Pintscher) [13:36:19] 3Wikidata, MediaWiki-extensions-WikibaseClient: Number of changes loaded mismatches the number of change IDs provided - https://phabricator.wikimedia.org/T74333#979405 (10Lydia_Pintscher) Is this still an issue? [13:41:50] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979417 (10thiemowmde) > one of the largest tables FYI: currently 128,836,060 rows. > properties by language+description By language + label. [13:43:03] (03PS3) 10Henning Snater: Updated claimlistview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185166 [13:45:20] (03PS1) 10Henning Snater: Updated claimgrouplistview code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185168 [13:48:12] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979422 (10JanZerebecki) [13:48:54] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06getSerializations from 143d32b46 to 147fa132f: 02http://git.io/iEQWgg [13:48:54] 13WikibaseDataModel/06getSerializations 147fa132f 15Thiemo Mättig: Add ItemIdSet::getSerializations [13:50:00] [13WikibaseDataModel] 15thiemowmde comment on pull request #328 147fa132f: I'm still not sure how this should look like instead, in your opinion. Like I did it now? 02http://git.io/jQIWog [13:53:16] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979435 (10Tobi_WMDE_SW) Outcome of the meeting with @aude @janzerebecki @thiemowmde @daniel (1) uniqueness constraints: -> PROBLEM: currently done... [13:53:48] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979437 (10adrianheine) > (2) finding props by label: > -> PROBLEM: timeout for short search-stings > -> AGREEMENT: use elastic but keep current str... [13:55:18] Adrian_WMDE: how would you document the variadic argument? [13:55:36] @param mixed ... language codes or '*' [13:55:49] That looks good [13:55:52] ok [13:56:37] (03PS3) 10Aude: Fix passing arguments in NoLangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185161 (https://phabricator.wikimedia.org/T86886) [13:56:39] done ^ [13:57:01] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979438 (10daniel) @adrian: it's used for type-ahead in the entity selector, as you assumed. Type-ahead for short prefixes fails often enough to be... [14:00:12] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979440 (10adrianheine) Ok, thanks @daniel. Is this about substring, exact or prefix matches? I'd think exact and prefix matches is something we sho... [14:00:40] (03CR) 10Adrian Lang: [C: 032] Fix passing arguments in NoLangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185161 (https://phabricator.wikimedia.org/T86886) (owner: 10Aude) [14:00:40] [13WikibaseDataModel] 15adrianheine closed pull request #328: Add ItemIdSet::getSerializations (06master...06getSerializations) 02http://git.io/wHc2JA [14:04:07] (03Merged) 10jenkins-bot: Fix passing arguments in NoLangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185161 (https://phabricator.wikimedia.org/T86886) (owner: 10Aude) [14:04:53] 3Wikidata, wikidata-query-service, operations: Wikidata Query Service hardware - https://phabricator.wikimedia.org/T86561#979455 (10mark) Different rows for availability is one thing. We need to think about how to distribute the service to two different data centers as well, and should build this out in both fro... [14:11:46] [13WikibaseDataModel] 15thiemowmde comment on pull request #335 143f3609f: Doesn't matter much. The test cases are key here. A simple way of refactoring such code is to linearize it, ...... 02http://git.io/JzcmcQ [14:24:59] (03CR) 10Aude: [C: 032] Remove double doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185084 (owner: 10Jeroen De Dauw) [14:28:30] (03CR) 10jenkins-bot: [V: 04-1] Remove double doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185084 (owner: 10Jeroen De Dauw) [14:28:32] Lydia_WMDE: This is a strange behavior imo, the third option should be first. https://www.dropbox.com/s/7ai6qzko3ev0coc/Schermafdruk%202015-01-15%2015.28.11.png?dl=0 [14:31:25] curl 'https://git.wikimedia.org/zip/?r=mediawiki/core.git&format=gz&h=master' [14:31:55] * aude wish we didn't rely on gitblit for jenkins [14:36:04] sjoerddebruin: agreed [14:36:14] exact matches should be first [14:37:11] Should be great for power users. :) [14:38:22] Should I file a bug... ehm task? [14:39:22] sjoerddebruin: that'd be lovely [14:39:35] we might even have one already actually [14:39:40] sjoerddebruin: let me check first [14:39:42] What's the specific name of that user interface part? [14:40:14] just wikidata or wikidata repo [14:43:01] Yeah, but I want to be clear to your lovely devs. <3 [14:43:32] sjoerddebruin: that's the entity selector. just checked and can't find a bug for it already [14:43:47] Will make one, will cc you. [14:44:17] where's that javascript hack again (to show more than 5 on phab) [14:44:22] if i do something wrong in phabricator, it usually gets fixed :) [14:44:52] sjoerddebruin: https://phabricator.wikimedia.org/T76732 [14:45:03] and yeah as long as you add one of our components we'll figure it out [14:45:31] Filling a bug about broken sorting on a project with broken sorting. How ironic. [14:45:48] :D [14:45:50] kinda [14:49:36] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Entity selector should show the exact match as first result - https://phabricator.wikimedia.org/T86923#979533 (10Sjoerddebruin) 3NEW [14:50:04] Feel free to triage. [14:50:34] thx sjoerddebruin [14:51:52] And you can set the security on none. :D [14:59:21] \o/ [14:59:28] <3 doing that :P [15:00:25] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Entity selector should show the exact match as first result - https://phabricator.wikimedia.org/T86923#979551 (10Lydia_Pintscher) p:5Triage>3Normal [15:17:45] Lydia_WMDE: https://meta.wikimedia.org/wiki/Wikidata/Development/Queries ? [15:28:29] hehe [15:28:30] :) [15:52:37] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Entity selector should show the exact match as first result - https://phabricator.wikimedia.org/T86923#979596 (10Snaterlicious) Unable to reproduce (trying with "uselang=nl" on wikidata.org on that property name). Would be very surprised if that actually was a... [15:53:31] [13ValueView] 15thiemowmde comment on pull request #141 14581be93: Why do you use a named function here, but an inlined closure in all the other cases above? 02http://git.io/sKROzw [15:53:38] JeroenDeDauw: around? ;p [15:57:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Entity selector should show the exact match as first result - https://phabricator.wikimedia.org/T86923#979611 (10Sjoerddebruin) >>! In T86923#979596, @Snaterlicious wrote: > Unable to reproduce (trying with "uselang=nl" on wikidata.org on that property name). W... [16:02:05] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Entity selector should show the exact match as first result - https://phabricator.wikimedia.org/T86923#979640 (10Snaterlicious) OK, thanks! As supposed, the API result from the property suggester component appears to be the issue: See API response: https://www.... [16:02:29] (03PS6) 10Aude: Handle Article ID of 0 in AffectedPagesFinder and usage lookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) [16:02:31] (03PS1) 10Aude: Add regression tests for "$pageId must be an integer > 0" bug [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185192 (https://phabricator.wikimedia.org/T86828) [16:03:27] (03CR) 10Aude: Remove double doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185084 (owner: 10Jeroen De Dauw) [16:03:34] (03CR) 10Aude: [C: 032] Remove double doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185084 (owner: 10Jeroen De Dauw) [16:04:01] [13ValueView] 15thiemowmde 04deleted 06testExpertExtender at 14581be93: 02http://git.io/2WWssA [16:06:09] [13ValueView] 15thiemowmde created 06testExpertExtender2 (+1 new commit): 02http://git.io/MiZX_g [16:06:09] 13ValueView/06testExpertExtender2 149e85703 15Thiemo Mättig: Cleanup/simplify ExpertExtender tests [16:06:37] [13ValueView] 15thiemowmde opened pull request #146: Cleanup/simplify ExpertExtender tests (06master...06testExpertExtender2) 02http://git.io/5B-NBQ [16:07:03] (03CR) 10jenkins-bot: [V: 04-1] Add regression tests for "$pageId must be an integer > 0" bug [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185192 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [16:07:29] (03Merged) 10jenkins-bot: Remove double doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185084 (owner: 10Jeroen De Dauw) [16:07:59] tests do what they should do... [16:09:16] (03PS7) 10Aude: Handle Article ID of 0 in AffectedPagesFinder and usage lookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) [16:09:43] (03Abandoned) 10Aude: Add regression tests for "$pageId must be an integer > 0" bug [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185192 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [16:16:12] 3Wikidata, MediaWiki-extensions-WikibaseRepository: support statements on properties in changeops - https://phabricator.wikimedia.org/T74879#979661 (10aude) 5Open>3Resolved [16:16:14] 3Wikidata, MediaWiki-extensions-WikibaseRepository: allow statements on properties - https://phabricator.wikimedia.org/T51554#979663 (10aude) [16:17:15] Is anyone planning on reviving #cvn-wikidata? [16:17:51] 3Wikidata, MediaWiki-extensions-WikibaseRepository: support statements on properties in changeops - https://phabricator.wikimedia.org/T74879#771582 (10aude) resolved by having getClaims() etc implemented for properties and adding StatementListProvider in data model [16:18:21] ...and firefox isn't working. Perfect. [16:24:10] How is Firefox not working? [16:24:40] 3Wikidata, MediaWiki-extensions-WikibaseRepository: save button not activated when changing order of statements - https://phabricator.wikimedia.org/T75360#979665 (10aude) the move toolbar appears gone. While I understand the issues Henning describes, this is very much not nice. I especially need to be able to... [16:27:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: description edit button is misaligned - https://phabricator.wikimedia.org/T74375#979680 (10aude) 5Open>3Resolved [16:27:16] 3Wikidata, MediaWiki-extensions-WikibaseRepository: description edit button is misaligned - https://phabricator.wikimedia.org/T74375#771933 (10aude) appears resolved, doesn't happen now. [16:37:09] 3Wikidata, MediaWiki-extensions-WikibaseRepository: save button not activated when changing order of statements - https://phabricator.wikimedia.org/T75360#979712 (10Snaterlicious) The "move" toolbar was removed as of T58050 and is supposed to be re-implemented on top of T74297. Of course, I would like to have "m... [16:44:55] hoo: It just crashed for a bit [16:53:05] 3Wikidata, MediaWiki-Parser: Add hook for extensions to bump or expire parser cache - https://phabricator.wikimedia.org/T86694#979749 (10aude) looks like PageRenderingHash would work for this. [16:53:46] Item creator actually worked :D [16:55:43] duh [17:00:25] GeorgeEdwardC: I'm lazy to delete your RfDs :P [17:00:49] 3Wikidata, MediaWiki-extensions-WikibaseClient: The gadget for connecting pages from clients does not work on Commons - https://phabricator.wikimedia.org/T86766#979754 (10matej_suchanek) 5Open>3Resolved a:3matej_suchanek See T86142. It works now. [17:01:06] sjoer: Seems to be broken quite a lot [17:01:20] :( [17:01:20] Jianhui67: K XD [17:02:00] sjoer: I might batch-create enwiki disambig items [17:06:24] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Automatically drop redundant sitelink to redirect when merging in wbmergeitems api module - https://phabricator.wikimedia.org/T85347#979778 (10petr.matas) You're right. [17:10:04] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979787 (10daniel) @adrianheine: it'S about prefix matches, and yes, it could be done without elastic. Getting it right with SQL is a lot harder tho... [17:14:16] [13ValueView] 15adrianheine comment on pull request #141 14581be93: No reason :) 02http://git.io/f6_EXA [17:16:23] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#979796 (10aude) it would be nice if suggestions would consider normalized diacritic marks. (e.g. find Zúrich in Spanish if entering "Zurich" withou... [17:17:24] [13ValueView] 15adrianheine comment on pull request #146 149e85703: They all need their own instance. That's what the previous change was about :) 02http://git.io/Iwd6mA [17:17:34] [13ValueView] 15adrianheine comment on pull request #146 149e85703: Fine with me 02http://git.io/e3t8Bg [17:24:22] [13Diff] 15JeroenDeDauw comment on pull request #30 14cd8bb7f: Oh neat! I did not realize this was already fixed and was thinking about submitting a patch myself. When running this rule against some small chunk of fundraising code (~5kloc), we ran into this dozens of times. Which means that for most component the whole rule can currently not be enabled, which is too bad. 02http://git.io/dgHNZA [17:27:58] [13Diff] 15JeroenDeDauw comment on pull request #30 14cd8bb7f: I do not think it's easy to get rid of, not that it is worth doing so (considering cost-benefit). It's too bad we ended up with this class as such, but it's there now. Increasing the rule to allow for it then won't catch new such introductions, which should not happen. 02http://git.io/VG7UZQ [17:34:08] Tobi_WMDE_SW_NA: what is this "in progress" label about? [17:44:37] 3Wikidata: Special:NewItem uses wrong language when creating items - https://phabricator.wikimedia.org/T86929#979881 (10Aklapper) a:5Wikidata-bugs>3None [17:50:43] [13ValueView] 15thiemowmde comment on pull request #145 149010b48: Singular now. 02http://git.io/gREFpQ [17:54:08] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #328 147fa132f: "This change is rather unrelated no?"... 02http://git.io/-AGbng [17:56:46] How would I assign "no value" with Python? [17:57:03] Still thinking about that "independant politician" bot [17:59:51] GeorgeEdwardC: wouldn't an independent politician have a party classification of "independent" or "none" or what have you? [18:00:53] it would almost be better from a data perspective to list them as "independent", or some item that represents non-affiliation [18:15:51] Wait no another bot operator has already taken the task [18:15:53] I'll just look into the "creating a bot" page [18:15:57] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #338: Make all Item constructor parameters optional (06master...06itemopt) 02http://git.io/lb3VQg [18:15:57] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06itemopt at 14097dc32: 02http://git.io/v63z9w [18:20:56] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Write example queries in different query languages - https://phabricator.wikimedia.org/T86786#979959 (10JanZerebecki) [18:20:57] 3Wikidata, wikidata-query-service, MediaWiki-Core-Team: Write example queries in different query languages - https://phabricator.wikimedia.org/T86786#979960 (10Manybubbles) https://www.mediawiki.org/wiki/Wikibase/Indexing/Query_examples [18:21:21] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/eLA5Yw [18:21:21] 13WikibaseDataModel/06master 14122e797 15Jeroen De Dauw: Merge pull request #289 from wmde/statementList... [18:27:52] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #340: Enhance new StatementListTest test (06master...06testz) 02http://git.io/rQ24Iw [18:28:56] 3Wikidata, MediaWiki-extensions-WikibaseClient: allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#979981 (10matej_suchanek) [18:31:04] wmde/WikibaseDataModel/testz/ff3b81a : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/47150640 [18:31:46] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/nwf0nA [18:31:46] 13WikibaseDataModel/06master 14be2aac6 15Jeroen De Dauw: Update RELEASE-NOTES.md [18:38:10] [13WikibaseDataModel] 15thiemowmde comment on pull request #340 14ff3b81a: I find this test a bit to complicated, `new StatementList( $statement, array() )` would be enough. 02http://git.io/CxA7Nw [18:38:52] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#980009 (10JeroenDeDauw) Note sure if this has been considered: the existing terms table cannot deal with non numeric entity ids. Any new solution w... [18:39:01] [13WikibaseDataModel] 15thiemowmde comment on pull request #340 14ff3b81a: This name is a bit odd. Could mean `!( isTraversable || isArgList )` or `( !isTraversable ) || isArgList`. `GivenNull` would be better. 02http://git.io/LJsMJg [18:39:14] aude: ALL of the approvals! [18:39:23] Dat Phabricator avatar :) [18:40:57] Where did the 15% perf improvements in the previous weekly come from? [18:40:59] Lydia_WMDE: ^ [18:41:16] [13WikibaseDataModel] 15thiemowmde comment on pull request #340 14ff3b81a: Same here, 2 statements would be enough. 02http://git.io/p-kvSw [18:44:55] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #340 14ff3b81a: Probably yes 02http://git.io/8zhc5w [18:45:06] Thiemo_WMDE: follow up to the follow up? ;) [18:45:10] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #340: Enhance new StatementListTest test (06master...06testz) 02http://git.io/rQ24Iw [18:46:01] JeroenDeDauw: are you asking me to do that follow up? probably doesnt matter enough to be worth it. ;) [18:48:33] Thiemo_WMDE: I don't really care, but if you do, you should make the FU ofc [18:49:00] the what? [18:49:35] fu = follow up, ofc = ? [18:49:47] ofcourse [18:50:02] Thiemo_WMDE: people used to mark their MW commits with [FU] back in the SVN days [18:50:07] Then people got upset about it [18:50:20] because it can also mean F*ck You [19:02:55] [13ValueView] 15thiemowmde 04force-pushed 06testExpertExtender2 from 149e85703 to 1446956e7: 02http://git.io/5p9qLw [19:02:55] 13ValueView/06testExpertExtender2 1446956e7 15Thiemo Mättig: Cleanup/simplify ExpertExtender tests [19:03:21] [13ValueView] 15thiemowmde comment on pull request #146 1446956e7: Ahhh. Makes it even simpler. :-) 02http://git.io/lBz4ag [19:07:09] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newEmpty from 14e36fec3 to 14be69024: 02http://git.io/OcS3vw [19:07:10] 13WikibaseDataModel/06newEmpty 14be69024 15Thiemo Mättig: Make all Item constructor parameters optional [19:08:28] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 145ba11bd to 143e72385: 02http://git.io/uH6jlQ [19:08:28] 13WikibaseDataModel/06emptyFingerprint 143e72385 15Thiemo Mättig: Allow constructing empty Fingerprint [19:09:34] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06unserlialize from 1468dee42 to 14a2087d6: 02http://git.io/5_4D9A [19:09:34] 13WikibaseDataModel/06unserlialize 14a2087d6 15Thiemo Mättig: Remove misleading return doc [19:12:44] JeroenDeDauw: katie knows more [19:13:13] Lydia_WMDE: and she has a kitten avatar! You should totally promote her now [19:13:14] sjoerddebruin: thanks! :) [19:13:21] JeroenDeDauw: :D [19:13:22] For the reminder? :) [19:13:25] yeah [19:28:26] sjoerddebruin: https://commons.wikimedia.org/wiki/Commons:License_review/requests [19:28:35] Yes? [19:28:46] Have you seen the response? [19:28:54] Well, yes. [19:29:39] So, do you understand what FoP is? [19:30:16] Yes, some countries are stupid because you can't make photos of buildings and stuff. :) [19:30:41] Great answer :) [19:32:07] That's (one reason) why only flie reviewers (also called license reviewer) are allowed to use the flickr-tool, since that reviews the file automaticly (directly), without it ever passing a "review"-category. [19:32:19] flickr-tool in the UploadWIzard* [19:32:48] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Re-implement uniqueness constraint in a consistent and efficient way - https://phabricator.wikimedia.org/T74430#980095 (10daniel) [19:32:49] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#980093 (10daniel) [19:32:53] Hm, okay. [19:35:46] 3Wikidata, MediaWiki-extensions-WikibaseRepository: RFC: replace wb_terms table with more specialized mechanisms for terms - https://phabricator.wikimedia.org/T86530#980104 (10daniel) The ticket "T86950: Implement TermLookup directly on top of wb_terms table" does not technically block this, but should be addres... [19:41:51] hoi folks, question: would anyone mind if i created the "award shared with" property suggested here: https://www.wikidata.org/wiki/Wikidata:Property_proposal/Generic#award_shared_with_.28en.29_.E2.80.93_.28Please_translate_this_into_norsk_bokm.C3.A5l..29 ? [19:42:12] 2 supports + suggester, 1 misguided oppose [19:42:19] i'm one of the supports though [19:43:59] i really want to start working with that property, but you know... it needs to be created first [20:26:05] (03CR) 10Daniel Kinzler: Introducing changes subscription infrastructure. (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183839 (https://phabricator.wikimedia.org/T86184) (owner: 10Daniel Kinzler) [20:28:09] (03PS5) 10Daniel Kinzler: Introducing changes subscription infrastructure. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183839 (https://phabricator.wikimedia.org/T86184) [20:28:25] (03CR) 10Daniel Kinzler: "$pageId === 0 works fro deleted pages, but if you want to cover special pages (as indicated by the commit message), the check has to be <=" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [20:28:45] (03CR) 10Daniel Kinzler: [C: 04-1] "(as discussed)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [20:28:47] (03CR) 10Daniel Kinzler: [C: 032] Introduce EntityIdFormatter interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180431 (owner: 10Adrian Lang) [20:29:00] (03Merged) 10jenkins-bot: Introduce EntityIdFormatter interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180431 (owner: 10Adrian Lang) [21:35:43] hi [21:36:22] here is some confusion about P554 and P553: https://www.wikidata.org/wiki/MediaWiki_talk:Gadget-AuthorityControl.js#link_the_property_of_website_username_.28P554.29 [21:36:55] can somebody please tell me whats going on? ^^ [21:38:39] P554 should only be used as qualifier. [21:39:52] sjoerddebruin: like, the opposite of what Fomafix thinks? [21:40:13] Yes. [21:43:36] sjoerddebruin: great, so I'm not confused ^^ [21:44:08] There is still a lot to fix though. https://www.wikidata.org/wiki/Wikidata:Database_reports/Constraint_violations/P554 [21:45:14] sjoerddebruin: he thinks its semantically wrong [21:45:28] :/ [21:46:21] the logic is actually twisted [21:48:10] sorry, I'm out [21:48:22] cu ^^ [21:54:17] (03CR) 10Aude: "from the Title class:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [21:55:06] Official Wikipedia app now uses Wikidata descriptions \o/ https://blog.wikimedia.org/2015/01/15/immersive-mobile-experience/ More coming! [21:56:47] (03CR) 10Aude: Handle Article ID of 0 in AffectedPagesFinder and usage lookup (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [21:57:12] :) [22:43:32] sjoerddebruin, you're a smart person. do you have any input on my question from a few hours ago? [22:53:42] aude: I can haz a simple review? [23:28:29] Abraham_WMDE you in the office tomorrow? [23:28:59] sure