[00:09:36] *waves* a billion messages just came through :) [00:19:18] welcome back to the living addshore :D [00:19:23] :D [00:19:37] aude: when is the swat? [00:19:45] Lydia_WMDE: Now-ish [00:19:50] pondering if i should stay up until then or go to bed [00:19:53] ah cool [00:19:53] ok [00:19:56] will wait then [00:28:18] Lydia_WMDE: Should be synched out [00:28:32] looking [00:28:53] edit summaries are fixed [00:28:54] \o/ [00:29:44] thanks aude and hoo! [00:30:26] suggester is also working [00:30:27] \o/ [00:31:03] Lydia_WMDE: fixed :) [00:31:11] :) [00:34:29] alright. good night folks :) [00:34:57] Lydia_WMDE: night :p [06:22:04] do all wiki sites have 'wiki' in their names? [06:31:36] SMalyshev: not necessarily [06:31:59] harej: do you know any counterexamples per chance? [06:32:08] Uncyclopedia is a wiki [06:32:56] harej: oh, of course :) that's not what I meant [06:33:15] All the Wikimedia Foundation websites have "wiki" in the name, as far as I know. [06:33:20] I meant wikipedia sites (that can be listed as sitelinks in wikidata, more precisely) [06:33:33] aha, thanks [06:37:01] Wikipedia, Wiktionary, Wikimedia Commons, Wikisource, Wikinews, Wikivoyage, Wikiversity [06:37:07] Wikidata [06:37:11] Wikispecies [06:38:25] Wikibooks [06:38:49] wiktionary actually doesn't have 'wiki'! good example [06:39:43] It kind of does. The "i" is just dropped for elision. [06:40:12] yeah i know :) but the string "wiki" is not in the name [07:11:04] 3Wikidata, wikidata-query-service: Implement sitelinks and badges - https://phabricator.wikimedia.org/T86331#975286 (10Smalyshev) Implementation description: https://www.mediawiki.org/wiki/Wikibase/Indexing/Data_Model#Representing_sitelinks_and_badges [07:42:33] 3MediaWiki-extensions-WikibaseRepository, Wikidata: RFC: Unit Localization - https://phabricator.wikimedia.org/T86528#975324 (10adrianheine) >>! In T86528#973849, @Snaterlicious wrote: > In my opinion, specifically developing for Wikidata would be opening Pandora's box. We already have rather awkward Wikidata-sp... [07:58:47] SMalyshev: just looked at badges and sitelinks. just to make sure: edges can have several properties, right? so we can have several badges for one sitelink? if so that seems fine to me [08:02:17] The amount of broken gadgets is... [08:03:11] hoo: ack... we really need to move the authority control one into the main codebase at least [08:06:06] Finally moving that server side would be dream coming true :P [08:06:06] * a dream [08:06:20] :D [08:09:12] They should really have someone selling coffee during lectures... [08:09:15] I could really need another one [08:13:26] lol [08:40:32] 3Wikidata-Sprint-2015-01-08§, Wikidata: Mockup for indicating language fallbacks for labels of referenced entities - https://phabricator.wikimedia.org/T86178#975344 (10Snaterlicious) Adding the language name in superscript was proposed already and we even had some mock-up way back. It would tie in with what we d... [08:51:28] 3Wikidata-Sprint-2015-01-08§, Wikidata: Mockup for indicating language fallbacks for labels of referenced entities - https://phabricator.wikimedia.org/T86178#975355 (10Lydia_Pintscher) I agree that it should be handled similar to the calendar model. I worry that what we're doing there is not distinct enough from... [08:51:56] [13WikibaseSerializationJavaScript] 15adrianheine 04deleted 06remoteExtPath at 14f654ea0: 02http://git.io/Pd2UPg [08:55:15] 3MediaWiki-extensions-WikibaseRepository, Wikidata: remove table of content bar - https://phabricator.wikimedia.org/T84913#975360 (10Lydia_Pintscher) I think we should block this until the rest of the header design is done. It doesn't look too bad anymore with the short headings in the sitelink section and is us... [08:58:25] (03PS3) 10Adrian Lang: Separate EntityIdFormatter from ValueFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183233 [08:58:27] (03CR) 10Adrian Lang: Introduce EntityIdFormatter interface (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180431 (owner: 10Adrian Lang) [09:01:11] (03CR) 10jenkins-bot: [V: 04-1] Separate EntityIdFormatter from ValueFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183233 (owner: 10Adrian Lang) [09:12:33] (03PS1) 10Henning Snater: Renamed FingerprintView to EntityTermsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184856 [09:13:57] 3MediaWiki-extensions-WikibaseRepository, Wikidata: remove table of content bar - https://phabricator.wikimedia.org/T84913#975387 (10Snaterlicious) What is the rest of the header design? Change is submitted already: https://gerrit.wikimedia.org/r/#/c/184629/ [09:21:05] (03PS2) 10Lydia Pintscher: Removed table of content bar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184629 (https://phabricator.wikimedia.org/T84913) (owner: 10Henning Snater) [09:21:22] 3MediaWiki-extensions-WikibaseRepository, Wikidata: remove table of content bar - https://phabricator.wikimedia.org/T84913#975391 (10Lydia_Pintscher) Alright :) [09:21:34] [13WikibaseDataModel] 15thiemowmde comment on pull request #334 146f21c3f: > subset of all valid use cases.... 02http://git.io/R5eQZg [09:21:54] (03PS5) 10Lydia Pintscher: entitytermsview: Fix table header and toolbar [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184580 (https://phabricator.wikimedia.org/T86520) (owner: 10Henning Snater) [10:04:24] [13WikibaseDataModel] 15thiemowmde created 06fallBackDocs0 (+1 new commit): 02http://git.io/lu_aiQ [10:04:24] 13WikibaseDataModel/06fallBackDocs0 143f3609f 15Thiemo Mättig: More descriptive Term/AliasGroupFallback docs [10:06:12] wmde/WikibaseDataModel/fallBackDocs0/3f3609f : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/46964362 [10:08:39] [13WikibaseDataModel] 15thiemowmde opened pull request #335: More descriptive Term/AliasGroupFallback docs (06master...06fallBackDocs0) 02http://git.io/88OAmw [10:08:52] 3Wikidata, Wikidata-Sprint-2015-01-08§, MediaWiki-extensions-WikibaseRepository: Give user indication how to influence preferred language selection - https://phabricator.wikimedia.org/T86191#975466 (10Snaterlicious) Just wondering about the message content. As having a hint in non-JS is probably not that useful... [10:42:00] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Refactor onFormat autocomment handling code and add tests - https://phabricator.wikimedia.org/T86751#975534 (10aude) 3NEW [10:53:37] DanielK_WMDE: https://i.imgur.com/v4D8iON.jpg [11:07:05] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/2qudBw [11:07:05] 13ValueView/06master 148156475 15thiemowmde: Merge pull request #144 from wmde/uls... [11:10:26] Lydia_WMDE: https://www.wikidata.org/w/index.php?title=Wikidata:Project_chat&curid=394&diff=187997101&oldid=187995208 [11:11:03] sjoerddebruin: urgh -.- [11:11:04] looking [11:11:23] looks correct to me [11:12:37] [13WikibaseDataModel] 15thiemowmde created 06emptyLang (+1 new commit): 02http://git.io/X9RuWQ [11:12:37] 13WikibaseDataModel/06emptyLang 14bc89d8f 15Thiemo Mättig: Empty string isn't a language code [11:14:38] wmde/WikibaseDataModel/emptyLang/bc89d8f : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/46970535 [11:15:02] aude: I see this. https://www.dropbox.com/s/hsaga5zfzzy6ddq/Schermafdruk%202015-01-14%2012.14.55.png?dl=0 [11:17:42] [13WikibaseDataModel] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/0Hcapw [11:17:42] 13WikibaseDataModel/06master 1473f2e0b 15snaterlicious: Merge pull request #326 from wmde/numeric... [11:19:16] [13WikibaseDataModel] 15thiemowmde opened pull request #336: Empty string isn't a language code (06master...06emptyLang) 02http://git.io/GefM0w [11:26:52] Lydia_WMDE: AFAIK no edgdes can not have the same property more than once in titan, it is like a key. but each badge would be a new edge as far as i understand the indexing/datamodel page. [11:27:05] [13ValueView] 15adrianheine created 06uls (+1 new commit): 02http://git.io/6urYgg [11:27:05] 13ValueView/06uls 149010b48 15Adrian Heine: Remove inverted language map from LanguageSelector... [11:28:52] [13ValueView] 15adrianheine opened pull request #145: Remove inverted language map from LanguageSelector (06master...06uls) 02http://git.io/uhr4PQ [11:29:55] (03PS1) 10Aude: Adjust property page data type css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184874 (https://phabricator.wikimedia.org/T86618) [11:32:09] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newEmpty from 14ca3ed00 to 1444af84f: 02http://git.io/OcS3vw [11:32:09] 13WikibaseDataModel/06newEmpty 1444af84f 15Thiemo Mättig: Make all Item constructor parameters optional [11:33:23] (03CR) 10Aude: "tested this locally and with https://www.wikidata.org/wiki/User:Aude/common.css" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184874 (https://phabricator.wikimedia.org/T86618) (owner: 10Aude) [11:36:00] aaaah https://phabricator.wikimedia.org/T85541 [11:36:07] still not fixed :( [11:36:41] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newEmpty from 1444af84f to 1409e8a10: 02http://git.io/OcS3vw [11:36:41] 13WikibaseDataModel/06newEmpty 1409e8a10 15Thiemo Mättig: Make all Item constructor parameters optional [11:38:14] Lydia_WMDE: ^ [11:40:05] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 143770869 to 1405b2af9: 02http://git.io/uH6jlQ [11:40:05] 13WikibaseDataModel/06emptyFingerprint 1405b2af9 15Thiemo Mättig: Allow constructing empty Fingerprint [11:40:41] (03PS1) 10Daniel Kinzler: Fix SiteLinkUsageLookup::getPagesUsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184875 (https://phabricator.wikimedia.org/T86714) [11:40:45] aude: ---^ [11:41:11] Lydia_WMDE: DanielK_WMDE can you also look at https://gerrit.wikimedia.org/r/#/c/181258/ again [11:41:16] still appearing in the logs [11:42:37] ok [11:42:48] moving to consider for next sprint [11:42:50] aude: i understand the problem, but the solution sucks :( [11:43:06] got an idea how to get this right? [11:43:08] * aude doesn't want to wait until next sprint :( [11:48:54] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newEmpty from 1409e8a10 to 14bfd9103: 02http://git.io/OcS3vw [11:48:54] 13WikibaseDataModel/06newEmpty 14bfd9103 15Thiemo Mättig: Make all Item constructor parameters optional [11:49:35] Lydia_WMDE: I cannot reproduce https://phabricator.wikimedia.org/T85541 on wikidata.org, but maybe I misunderstand something. [11:50:29] aharoni: do you have the beta feature enabled? [11:50:32] aharoni: heh ok. enable the beta feature compact personal sidebar. go to any item. click the language selector in the top bar [11:50:34] "compact personal bar" [11:50:43] the flyout does not come up [11:50:45] I enabled it. [11:50:49] let me go to an item... [11:51:07] * aude using chrome [11:51:14] me too [11:52:32] oh, now I seem to be able to reproduce it. [11:52:56] cool [11:57:23] Oh. [11:57:32] Did the sitelinks editor change completely? [11:57:57] aharoni: ok wikidata? [11:58:01] on* [11:58:09] yes, on wikidata.org. [11:58:21] yes, completely :) [11:58:28] Wow, I just noticed it now. [11:58:32] Curious. [11:59:26] Anyway. Let's see that bug. [12:02:00] * aharoni hates debugging JavaScript. [12:04:49] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06testNamespace from 1421a7e84 to 140fce001: 02http://git.io/DnPTiA [12:04:49] 13WikibaseDataModel/06testNamespace 140fce001 15Thiemo Mättig: Normalize namespaces of all tests [12:05:27] thanks aharoni :) [12:06:48] (03CR) 10Aude: [C: 032] Fix SiteLinkUsageLookup::getPagesUsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184875 (https://phabricator.wikimedia.org/T86714) (owner: 10Daniel Kinzler) [12:09:34] (03Merged) 10jenkins-bot: Fix SiteLinkUsageLookup::getPagesUsing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184875 (https://phabricator.wikimedia.org/T86714) (owner: 10Daniel Kinzler) [12:10:41] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06snak from 14d60ce56 to 14c347b8c: 02http://git.io/9Q42Ow [12:10:41] 13WikibaseDataModel/06snak 14c347b8c 15jeroendedauw: Decrease inheritance and overloading for PropertyValueSnak [12:21:33] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06unserlialize from 140180f5c to 1413969aa: 02http://git.io/5_4D9A [12:21:33] 13WikibaseDataModel/06unserlialize 1413969aa 15Thiemo Mättig: Remove misleading return doc [12:28:29] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06unserlialize from 1413969aa to 14feaa869: 02http://git.io/5_4D9A [12:28:29] 13WikibaseDataModel/06unserlialize 14feaa869 15Thiemo Mättig: Remove misleading return doc [12:51:22] Lydia_WMDE: can you please try talking to CPB devs about https://phabricator.wikimedia.org/T85541 ? [12:56:50] aharoni: is there anyone actively maintaining CPB? [12:59:23] Poked Jared [12:59:24] * Poke [12:59:44] Lydia and the rest of the team are in a meeting atm [12:59:58] I'm not, because I'm not in Berlin [13:00:14] So probably wont reply [13:14:50] Jianhui67: Isn't more easy to keep your translation admin rights? [13:20:05] Well, I saw that some pages are not marked for translation. So I did them. I considered keeping them. But I don't use it frequently [13:20:36] Cough. https://www.wikidata.org/wiki/Special:UserRights/Jianhui67 [13:34:59] aharoni: who is maintaining it? [13:35:08] need to run back to meeting but will look again later [13:35:20] Lydia_WMDE: I can only think of Jared as the contact point. [13:35:34] ok [13:37:14] Lydia_WMDE: As for devs, possibly Jdlrobson and Prtksxna. JGonera used to, but he's gone :( [13:37:49] Lydia_WMDE: maybe krinkle will have a quick idea how to fix it well, but he's probably busy with a thousand other things. [13:37:53] So I'd say - ask Jared. [13:39:12] [13WikibaseDataModel] 15thiemowmde comment on pull request #328 145b38a35: "Mirror". Yes. That's exactly what a test should do. I don't understand why you want to "avoid" that. 02http://git.io/xBP4rQ [13:39:57] [13WikibaseDataModel] 15thiemowmde comment on pull request #328 145b38a35: What "questions" are you referring to? What "technique"? 02http://git.io/oahsnQ [13:47:38] 3Wikidata, MediaWiki-extensions-WikibaseRepository: InvalidArgumentException from line 45 SiteLink.php: $pageName must be a string; got boolean (from UpdateRepoOnMoveJob) - https://phabricator.wikimedia.org/T76545#975786 (10daniel) From looking at the code, it should actually be easy to avoid the fatal error wit... [14:02:17] 3Wikidata, MediaWiki-extensions-WikibaseClient, Wikidata-Sprint-2015-01-08§: Argument 1 passed to UsageAspectTransformer::transformPageEntityUsages() must be an instance of PageEntityUsages, integer given - https://phabricator.wikimedia.org/T86714#975818 (10aude) 5Open>3Resolved [14:02:35] 3Wikidata, MediaWiki-extensions-WikibaseClient, Wikidata-Sprint-2015-01-08§: Argument 1 passed to UsageAspectTransformer::transformPageEntityUsages() must be an instance of PageEntityUsages, integer given - https://phabricator.wikimedia.org/T86714#974733 (10aude) [14:05:09] [13WikibaseDataModel] 15thiemowmde comment on pull request #328 145b38a35: I fail to see an "honest" question. Why are you asking if the added `@author` is unrelated? You can see it is unrelated. It takes you seconds to look at the history and blame of this class and see that I'm a co-author of relevant parts of the code.... 02http://git.io/LchhSw [14:06:36] hashar: ping :) [14:07:00] 3Wikidata, MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2015-01-08§: Give user indication how to influence preferred language selection - https://phabricator.wikimedia.org/T86191#975824 (10Snaterlicious) OK, follow-up question: As the whole procedure of using Babel is kind of not how it should be, sh... [14:14:00] Adrian_WMDE: pong [14:15:04] Adrian_WMDE: hashar pang [14:15:28] hashar: About this composer thing [14:15:29] 3Wikidata, MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2015-01-08§: Give user indication how to influence preferred language selection - https://phabricator.wikimedia.org/T86191#975832 (10Lydia_Pintscher) I would just add a redlink to a page that any wikibase install can fill. For Wikidata that coul... [14:16:28] hashar: I addressed krinkle's comment [14:17:09] hashar: I'd still like to know if there are fundamental issues blocking this [14:18:23] Adrian_WMDE: this what? :] [14:18:30] hashar: https://gerrit.wikimedia.org/r/#/c/180418/ [14:18:44] WikibaseJavaScriptApi, qunit, composer on jenkins [14:23:39] (03CR) 10Adrian Lang: [C: 032] Adjust property page data type css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184874 (https://phabricator.wikimedia.org/T86618) (owner: 10Aude) [14:26:33] Adrian_WMDE: replied at https://gerrit.wikimedia.org/r/#/c/180418/14/jjb/mediawiki-extensions.yaml,unified [14:26:43] (03PS2) 10Adrian Lang: Return Term object from LabelLookup. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184727 (https://phabricator.wikimedia.org/T86180) (owner: 10Daniel Kinzler) [14:26:46] we can refresh the job and trigger it to see what happens [14:27:10] (03Merged) 10jenkins-bot: Adjust property page data type css [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184874 (https://phabricator.wikimedia.org/T86618) (owner: 10Aude) [14:27:35] hashar_: thanks [14:29:09] 3Wikidata: disable issues on github repos - https://phabricator.wikimedia.org/T86764#975849 (10JanZerebecki) 3NEW [14:30:20] hashar_: addressed [14:30:58] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #328 145b38a35: Two main reasons:... 02http://git.io/rfC9oA [14:31:19] Adrian_WMDE: lets try :] [14:31:27] Yeah [14:31:49] 3Wikidata, Wikidata-Sprint-2015-01-08§, MediaWiki-extensions-WikibaseRepository: Data type on Property page is formatted slightly strange on test.wikidata - https://phabricator.wikimedia.org/T86618#975865 (10adrianheine) [14:32:12] 3Wikidata, Wikidata-Sprint-2015-01-08§, MediaWiki-extensions-WikibaseRepository: Data type on Property page is formatted slightly strange on test.wikidata - https://phabricator.wikimedia.org/T86618#975868 (10adrianheine) 5Open>3Resolved a:3adrianheine [14:32:30] 3Wikidata, MediaWiki-extensions-WikibaseRepository, Wikidata-Sprint-2015-01-08§: Make language fallback visible in the output of LabelLookup - https://phabricator.wikimedia.org/T86180#975870 (10daniel) [14:32:32] * hashar_ whistles while jenkins job builder updates configuration [14:32:37] 3Wikidata, MediaWiki-extensions-WikibaseClient, Wikidata-Sprint-2015-01-08§: Argument 1 passed to UsageAspectTransformer::transformPageEntityUsages() must be an instance of PageEntityUsages, integer given - https://phabricator.wikimedia.org/T86714#975874 (10adrianheine) p:5Unbreak!>3Normal [14:33:03] 3Wikidata, MediaWiki-extensions-WikibaseClient: Changes not appearing in client correctly - https://phabricator.wikimedia.org/T86765#975875 (10aude) [14:33:56] this is getting annoying.... [14:34:31] aude: what is? [14:34:40] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #328 145b38a35: I did look at the git blame and did not see much done by you. I checked again now and getting a different impression. Perhaps I incorrectly checked ItemIdSet. My bad, I don't object to you adding your name here.... 02http://git.io/DEdwWQ [14:34:47] bugs in change notifications [14:34:59] pages never get updated, it seems [14:35:08] and only sometimes appear in recent changes [14:35:20] and was getting a fatal last night [14:35:42] which is probably happening for wikivoyage etc. but not being logged [14:36:06] i think this might be somwehat easy to fix for now though [14:37:29] Adrian_WMDE: is this resolved?: https://phabricator.wikimedia.org/T58050 (patch was merged) [14:37:55] jzerebecki: it is [14:38:22] 3Wikidata, DataValues-JavaScript: Remove "index" related options from claim related jQuery.wikibase.***view widgets - https://phabricator.wikimedia.org/T58050#975877 (10JanZerebecki) 5Open>3Resolved [14:38:24] thx [14:38:48] (03CR) 10Adrian Lang: [C: 031] "Looks good, also I'm not quite clear about how the various Lookups relate to each other in general. One nitpick, too." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184727 (https://phabricator.wikimedia.org/T86180) (owner: 10Daniel Kinzler) [14:39:42] (03CR) 10Adrian Lang: "›although‹" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184727 (https://phabricator.wikimedia.org/T86180) (owner: 10Daniel Kinzler) [14:40:07] Adrian_WMDE: I have fixed another issue (composer has to be run before qunit) [14:40:14] Adrian_WMDE: job updated. Can you give it a try? [14:40:16] saw that just now [14:40:51] 3Wikidata, Wikidata-Sprint-2015-01-08§, MediaWiki-extensions-WikibaseRepository: Create new fingerprint-widget to replace header and current fingerprintlist widgets - https://phabricator.wikimedia.org/T75656#975878 (10Snaterlicious) Except for the first point, I am unable to reproduce the erroneous behaviour in... [14:41:07] hashar_: How should I try it? [14:46:08] Adrian_WMDE: retrigger a patch ? :D [14:46:39] (03CR) 10Adrian Lang: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183445 (owner: 10Adrian Lang) [14:46:47] Ah, sure [14:48:29] [13WikibaseDataModel] 15snaterlicious 04deleted 06testNamespace at 140fce001: 02http://git.io/rqxjug [14:48:37] didn't work yet, I'll look at it tomorrow [14:49:03] the mediawiki extension phpunit test doesn't seem to find the data-values/javascript resource loader modules [14:49:09] Although qunit has them [14:49:14] anyway, thanks hash [14:49:16] ar [14:53:15] 3Wikidata, Wikidata-Sprint-2015-01-08§, MediaWiki-extensions-WikibaseRepository: Argument 1 passed to BufferingTermLookup::getBufferKey() must be an instance of Wikibase\DataModel\Entity\EntityId, null given - https://phabricator.wikimedia.org/T86522#975882 (10JanZerebecki) 5Open>3Resolved [14:53:46] 3Wikidata, MediaWiki-extensions-WikibaseClient: The gadget for connecting pages from clients does not work on Commons - https://phabricator.wikimedia.org/T86766#975885 (10matej_suchanek) 3NEW [14:54:09] 3Wikidata, MediaWiki-extensions-WikibaseClient: The gadget for connecting pages from clients does not work on Commons - https://phabricator.wikimedia.org/T86766#975885 (10matej_suchanek) [15:00:18] 3Wikidata, MediaWiki-extensions-WikibaseRepository: JavaScript Documentation: ValueView - https://phabricator.wikimedia.org/T75987#975901 (10Snaterlicious) The JavaScript code documentation of ValueView was updated extensively some time ago (by now) and is part of ValueView >= 0.9.0. The remaining part is genera... [15:00:41] 3Wikidata, MediaWiki-extensions-WikibaseRepository: update documentation of js data model - https://phabricator.wikimedia.org/T75606#764649 (10Snaterlicious) The code documentation is in place. Maybe the task of generating and deploying the documentation should be tracked on T42657. (see also T75987) [15:03:23] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #335 143f3609f: Cool you got rid of the double iteration. This is kinda nested a lot now though. Perhaps a next step would be to extract part into it's own function. 02http://git.io/D2366g [15:04:20] Phabricator is down? [15:07:48] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06snak at 14c347b8c: 02http://git.io/lbrTkA [15:07:57] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #105: Decrease inheritance and overloading for PropertyValueSnak (06master...06snak) 02http://git.io/q3ghtQ [15:10:29] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/N5d7LQ [15:10:30] 13WikibaseDataModel/06master 14a6f73a8 15Jeroen De Dauw: Merge pull request #336 from wmde/emptyLang... [15:11:59] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/EA0nRg [15:11:59] 13WikibaseDataModel/06master 147564075 15Jeroen De Dauw: Update RELEASE-NOTES.md [15:16:09] 3Wikidata, Wikibase-DataModel: correct namespace of tests - https://phabricator.wikimedia.org/T78293#975911 (10JeroenDeDauw) 5Open>3Resolved a:3JeroenDeDauw [15:18:43] [13WikibaseDataModel] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/FOrO1w [15:18:43] 13WikibaseDataModel/06master 143114251 15snaterlicious: Merge pull request #307 from wmde/claimTest... [15:18:55] can somebody update the authority control gadged to what is prepared on test according to https://phabricator.wikimedia.org/T85804 ? [15:22:41] (03CR) 10Jeroen De Dauw: Return Term object from LabelLookup. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184727 (https://phabricator.wikimedia.org/T86180) (owner: 10Daniel Kinzler) [15:25:09] (03PS1) 10Jeroen De Dauw: Address Adrians comment and remove not needed else-clause and local var [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184892 [15:25:53] (03PS2) 10Jeroen De Dauw: Address Adrians comment and remove not needed else-clause and local var [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184892 [15:26:28] (03CR) 10Jeroen De Dauw: [C: 032] "I addressed Adrians comment in a follow up" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184727 (https://phabricator.wikimedia.org/T86180) (owner: 10Daniel Kinzler) [15:28:35] addshore: what. You made a commit again! :) [15:28:42] :D [15:28:51] just 1, still no time :( [15:28:53] Without tests... Evil! [15:29:13] Not that you can sanely test that [15:30:22] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Auto-generated documentation for JavaScript code based on already existing doxygen comments - https://phabricator.wikimedia.org/T42657#975955 (10Snaterlicious) Would be nice to get that ticket back on track as, by now, there is complete code documentation in pl... [15:30:24] (03CR) 10Aude: Address Adrians comment and remove not needed else-clause and local var (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184892 (owner: 10Jeroen De Dauw) [15:36:44] (03CR) 10Jeroen De Dauw: Rework and cleanup ApiWikibase and subclasses (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [15:37:16] 3Wikidata: disable issues on github repos - https://phabricator.wikimedia.org/T86764#975976 (10Lydia_Pintscher) p:5Triage>3Normal [15:37:38] (03CR) 10Jeroen De Dauw: [C: 031] Rework and cleanup ApiWikibase and subclasses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [15:40:35] 3Wikidata, MediaWiki-extensions-WikibaseClient: The gadget for connecting pages from clients does not work on Commons - https://phabricator.wikimedia.org/T86766#975990 (10Lydia_Pintscher) p:5Triage>3High [15:41:52] 3Wikidata, MediaWiki-extensions-WikibaseClient: Changes not appearing in client correctly - https://phabricator.wikimedia.org/T86765#975993 (10Lydia_Pintscher) [15:42:04] 3Wikidata, MediaWiki-extensions-WikibaseClient: Changes not appearing in client correctly - https://phabricator.wikimedia.org/T86765#975994 (10Lydia_Pintscher) p:5Triage>3High [15:44:59] (03PS1) 10Aude: Fix change handling for site link changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184898 (https://phabricator.wikimedia.org/T86765) [15:46:15] !admin [16:18:55] can somebody update the authority control gadged to what is prepared on test according to https://phabricator.wikimedia.org/T85804 ? [15:46:27] =o [15:48:12] Lydia_WMDE: done [15:48:17] jzerebecki: done [15:48:22] addshore: sweet [15:48:23] thx [15:48:29] https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-AuthorityControl.js&diff=188038652&oldid=187820973 [15:48:34] addshore: thx [15:48:39] 3Wikidata, Wikidata.org: JS error: "unrecognized expression: unsupported pseudo: wikibase-statementview" on old revisions of items - https://phabricator.wikimedia.org/T85804#976006 (10Addshore) https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-AuthorityControl.js&diff=188038652&oldid=187820973 [15:50:29] addshore: can you also add jquery.wikibase.entityview as a dependency in the definition? [15:51:19] give me links and I will ;p [15:53:34] addshore: https://phabricator.wikimedia.org/T85804#972798 [15:54:09] i.e. then the line in https://www.wikidata.org/wiki/MediaWiki:Gadgets-definition being SiteIdToInterwiki[ResourceLoader|default|dependencies=jquery.wikibase.sitelinkview,jquery.wikibase.siteselector,jquery.wikibase.entityview]|SiteIdToInterwiki.js [15:55:23] done https://www.wikidata.org/w/index.php?title=MediaWiki:Gadgets-definition&diff=188039566&oldid=187899403 [15:55:34] oh wait, for SiteIdToInterwiki? :P [15:57:39] @jzerebecki ? :) [16:02:53] addshore: no my mistake, what you did was what i meant. thank you. [16:03:19] :) [16:03:30] (03PS1) 10Aude: Fix change handling for connected pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184901 (https://phabricator.wikimedia.org/T86765) [16:04:45] 3Wikidata, Wikidata.org: JS error: "unrecognized expression: unsupported pseudo: wikibase-statementview" on old revisions of items - https://phabricator.wikimedia.org/T85804#976067 (10JanZerebecki) 5Open>3Resolved a:3JanZerebecki Fixed by: https://www.wikidata.org/w/index.php?title=MediaWiki:Gadget-Authori... [16:36:24] Mixing concepts again... https://www.wikidata.org/w/index.php?title=Q1647880&oldid=188045842&diff=prev [16:44:47] (03PS1) 10Henning Snater: entitytermsview: Inject link to help page [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 [17:01:07] Hi [17:01:35] hey [17:01:48] Hey Sjoer [17:01:55] I see Petr's re-run for admin [17:02:03] Have someone voted yet? [17:02:41] Nope [17:02:50] Hm, that says something about him. [17:03:01] A month after the previous one is too soon imo [17:03:22] (03PS1) 10Aude: Use ArticleEditUpdates hook for usage tracking [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184913 (https://phabricator.wikimedia.org/T86308) [17:03:24] (03PS1) 10Aude: Fix SiteLinkUsageLookup::getPagesUsing [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184914 (https://phabricator.wikimedia.org/T86714) [17:03:24] Although I have no concerns, I agree [17:03:26] (03PS1) 10Aude: Adjust property page data type css [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184915 (https://phabricator.wikimedia.org/T86618) [17:04:47] I agree as well [17:09:13] (03CR) 10Aude: [C: 032] Use ArticleEditUpdates hook for usage tracking [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184913 (https://phabricator.wikimedia.org/T86308) (owner: 10Aude) [17:09:21] (03CR) 10Aude: [C: 032] Fix SiteLinkUsageLookup::getPagesUsing [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184914 (https://phabricator.wikimedia.org/T86714) (owner: 10Aude) [17:09:27] (03CR) 10Aude: [C: 032] Adjust property page data type css [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184915 (https://phabricator.wikimedia.org/T86618) (owner: 10Aude) [17:11:47] 3Wikidata, MediaWiki-extensions-WikibaseRepository: update documentation of js data model - https://phabricator.wikimedia.org/T75606#976347 (10JanZerebecki) 5Open>3Resolved [17:12:00] 3Wikidata, MediaWiki-extensions-WikibaseRepository: JavaScript Documentation: ValueView - https://phabricator.wikimedia.org/T75987#976348 (10JanZerebecki) 5Open>3Resolved [17:12:53] (03Merged) 10jenkins-bot: Use ArticleEditUpdates hook for usage tracking [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184913 (https://phabricator.wikimedia.org/T86308) (owner: 10Aude) [17:12:55] 3Wikidata, ValueView: [docs] Add documentation about events - https://phabricator.wikimedia.org/T78277#976359 (10Snaterlicious) Just noticed that bug. ValueView documentation has been updated via T75987. As to the documentation (see `jquery.valueview.valueview.js`), there is no generic `change` event. Applied to... [17:13:53] 3Wikidata: disable issues on github repos - https://phabricator.wikimedia.org/T86764#976367 (10JanZerebecki) What needs to be discussed here? [17:14:07] (03Merged) 10jenkins-bot: Fix SiteLinkUsageLookup::getPagesUsing [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184914 (https://phabricator.wikimedia.org/T86714) (owner: 10Aude) [17:14:13] (03Merged) 10jenkins-bot: Adjust property page data type css [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184915 (https://phabricator.wikimedia.org/T86618) (owner: 10Aude) [17:15:52] (03CR) 10Daniel Kinzler: [C: 032] Fix change handling for site link changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184898 (https://phabricator.wikimedia.org/T86765) (owner: 10Aude) [17:16:11] (03CR) 10Daniel Kinzler: [C: 032] Fix change handling for connected pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184901 (https://phabricator.wikimedia.org/T86765) (owner: 10Aude) [17:18:50] (03Merged) 10jenkins-bot: Fix change handling for site link changes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184898 (https://phabricator.wikimedia.org/T86765) (owner: 10Aude) [17:19:30] (03Merged) 10jenkins-bot: Fix change handling for connected pages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184901 (https://phabricator.wikimedia.org/T86765) (owner: 10Aude) [17:26:00] (03PS1) 10Aude: Fix change handling for site link changes [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184918 (https://phabricator.wikimedia.org/T86765) [17:26:07] (03PS1) 10Aude: Fix change handling for connected pages [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184919 (https://phabricator.wikimedia.org/T86765) [17:27:34] hi all [17:28:16] Hi Matej [17:31:37] (03CR) 10Aude: [C: 032] Fix change handling for site link changes [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184918 (https://phabricator.wikimedia.org/T86765) (owner: 10Aude) [17:31:42] (03CR) 10Aude: [C: 032] Fix change handling for connected pages [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184919 (https://phabricator.wikimedia.org/T86765) (owner: 10Aude) [17:31:48] How are you doing? [17:34:12] me? well quite bussy but not bad [17:35:24] (03Merged) 10jenkins-bot: Fix change handling for site link changes [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184918 (https://phabricator.wikimedia.org/T86765) (owner: 10Aude) [17:35:27] (03Merged) 10jenkins-bot: Fix change handling for connected pages [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184919 (https://phabricator.wikimedia.org/T86765) (owner: 10Aude) [17:38:37] (03PS1) 10Aude: Update Wikidata, fix client change handling [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184921 [17:39:44] That's good :-) [17:42:07] (03PS1) 10Aude: New Wikidata build - 2015/01/14 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/184922 [17:42:30] (03CR) 10Aude: [C: 032] Update Wikidata, fix client change handling [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184921 (owner: 10Aude) [17:44:30] (03Merged) 10jenkins-bot: Update Wikidata, fix client change handling [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184921 (owner: 10Aude) [17:47:28] (03CR) 10Aude: [C: 032] New Wikidata build - 2015/01/14 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/184922 (owner: 10Aude) [17:55:36] (03Merged) 10jenkins-bot: New Wikidata build - 2015/01/14 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/184922 (owner: 10Aude) [17:55:55] Oh the new sitelink GUI has been implemented [17:56:01] Only just noticed ;) [18:02:59] Ward Cunningham is doing a video call about federated wikis [18:03:02] https://t.co/ETaPTslQax [18:07:55] (03PS1) 10Aude: wikibase.utilities still needed in client, move back to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184931 (https://phabricator.wikimedia.org/T86790) [18:08:14] jzerebecki: hey there [18:08:20] hey [18:08:24] jzerebecki: contentless ping :P [18:08:36] jzerebecki: no, kidding, i wanna merge the change to wikidata logging [18:08:46] https://gerrit.wikimedia.org/r/#/c/182173/ [18:08:55] any reason not to do it right now? [18:09:08] asking you because hoo is away [18:09:27] https://gerrit.wikimedia.org/r/#/c/184931/ needs backport [18:09:30] review appreciated [18:11:32] mutante: i don't see any reason not to, but not that much my area of expertise. [18:11:47] aude: any concerns regarind what mutante said from you? [18:12:06] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 (owner: 10Henning Snater) [18:12:14] (03PS1) 10Aude: wikibase.utilities still needed in client, move back to lib [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184934 (https://phabricator.wikimedia.org/T86790) [18:12:17] jzerebecki: mutante seems good to me [18:12:40] thanks aude and jan, merging now, didnt want to slow it down more after we already asked for it to use find instead of a custom bash script [18:12:49] thanks [18:13:05] mutante: yea. don't forget to rm /etc/logrotate.d/dumpwikidatajson manually ;) [18:13:38] * jzerebecki hates that one still needs to clean up manually after puppet [18:13:39] * aude going home.... will self merge the js patch int he branch when i get home, if it is not already merged by then [18:13:42] jzerebecki: oh, right! yea [18:18:09] (03CR) 10JanZerebecki: [C: 032] wikibase.utilities still needed in client, move back to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184931 (https://phabricator.wikimedia.org/T86790) (owner: 10Aude) [18:18:10] the js appears to be also used by some "shared" stuff in lib [18:18:18] i don't understand why it was moved already [18:21:00] (03Merged) 10jenkins-bot: wikibase.utilities still needed in client, move back to lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184931 (https://phabricator.wikimedia.org/T86790) (owner: 10Aude) [18:22:47] Should someone design a icon for the move-option? https://www.dropbox.com/s/ts51q1qhn4siueo/Schermafdruk%202015-01-14%2019.22.33.png?dl=0 [18:23:23] mutante: https://gerrit.wikimedia.org/r/#/c/182173/ your comment said cron.d instead of logrotate.d which one did you actually do? [18:27:07] jzerebecki: logrotate.d, the error is the comment [18:27:18] mutante: thank you [18:32:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184856 (owner: 10Henning Snater) [18:35:07] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184907 (owner: 10Henning Snater) [18:49:37] could someone make this change on live, it fixes one problem with the SiteIdToInterwiki gadget: https://test.wikidata.org/w/index.php?title=MediaWiki%3AGadgets-definition&diff=9678&oldid=9640 [18:49:56] looking [18:50:46] jzerebecki: done [18:52:26] sjoerddebruin: thx [18:57:04] 3Wikidata, Wikidata.org: siteidtointerwiki gadget does not work on some pages - https://phabricator.wikimedia.org/T86795#976734 (10JanZerebecki) 3NEW [18:57:15] Lydia_WMDE: edges can have deveral properties, but in this case each edge expresses one badge. We still can have several badges since we can have several edges. [18:57:34] *several [18:57:45] 3Wikidata, MediaWiki-extensions-WikibaseClient: allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#976742 (10-jem-) [18:59:12] 3Wikidata, Wikidata.org: siteidtointerwiki gadget does not work on some pages - https://phabricator.wikimedia.org/T86795#976754 (10JanZerebecki) Thought this was the missing dependency on jquery.wikibase.entityview like in T85804#972798 but no. Still does not work after https://www.wikidata.org/w/index.php?title... [19:00:35] 3Wikidata, Wikidata.org: siteidtointerwiki gadget does not work on some pages - https://phabricator.wikimedia.org/T86795#976760 (10JanZerebecki) This: $( ':wikibase-sitelinklistview' ) Still gives me: Error: Syntax error, unrecognized expression: unsupported pseudo: wikibase-sitelinklistview On: https://www.wiki... [19:07:18] 3Wikidata: resource loader &debug=1 results in JavaScript error - https://phabricator.wikimedia.org/T86799#976786 (10JanZerebecki) 3NEW [19:11:14] (03CR) 10Aude: [C: 032] wikibase.utilities still needed in client, move back to lib [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184934 (https://phabricator.wikimedia.org/T86790) (owner: 10Aude) [19:14:21] (03Merged) 10jenkins-bot: wikibase.utilities still needed in client, move back to lib [extensions/Wikibase] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184934 (https://phabricator.wikimedia.org/T86790) (owner: 10Aude) [19:16:14] SMalyshev: cool :) [19:18:15] (03PS1) 10Aude: Update Wikidata, moving js needed by client back to lib [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184960 [19:22:41] (03CR) 10Aude: [C: 032] Update Wikidata, moving js needed by client back to lib [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184960 (owner: 10Aude) [19:24:38] (03Merged) 10jenkins-bot: Update Wikidata, moving js needed by client back to lib [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184960 (owner: 10Aude) [19:30:22] Lydia_WMDE: fyi, https://gerrit.wikimedia.org/r/#/c/182134/ [19:30:26] seems like something wikibase also deos [19:30:28] does* [19:30:51] could make sense either in core (probably) or a component that can be shared by multiple extensions [19:31:09] thx [19:31:38] not urgent at all, but would be nice not to duplicate and maintain multiple places [19:48:47] 3Wikidata, Language-Engineering, MediaWiki-extensions-UniversalLanguageSelector, MediaWiki-extensions-WikibaseClient: ULS on does not consistantly work when "compact personal bar" beta feature is enabled - https://phabricator.wikimedia.org/T85541#977000 (10Jaredzimmerman-WMF) [19:50:44] 3Wikidata, Language-Engineering, MediaWiki-extensions-UniversalLanguageSelector, MediaWiki-extensions-WikibaseClient: ULS on does not consistantly work when "compact personal bar" beta feature is enabled - https://phabricator.wikimedia.org/T85541#949210 (10Jaredzimmerman-WMF) This isn't specific to wikidata, and... [19:51:07] 3Wikidata, Language-Engineering, MediaWiki-extensions-UniversalLanguageSelector, MediaWiki-extensions-WikibaseClient: ULS on does not consistantly work when "compact personal bar" beta feature is enabled - https://phabricator.wikimedia.org/T85541#977017 (10Jaredzimmerman-WMF) p:5High>3Volunteer? [19:52:21] needs volunteer? [19:54:32] aude: Grrr... I slept in earlier on... :/ [19:54:39] Do you still need urgent reviews? [19:58:18] hoo: i think we are ok now [19:58:28] but sure had a bunch of issues [20:29:20] 3Wikidata, Wikidata.org: siteidtointerwiki gadget does not work on some pages - https://phabricator.wikimedia.org/T86795#977147 (10JanZerebecki) p:5Triage>3Low [20:45:40] omg... InvalidArgumentException: $pageId must be an integer > 0 [20:45:45] not that frequent but still [20:47:22] mh... do we forget to cast stuff from DB again? [20:49:52] patch coming [20:49:56] i dont' think so [20:50:09] but special pages can have site links and can reproduce with that [20:50:14] idk if there are other reasons [20:54:57] (03PS1) 10Aude: Handle Article ID of 0 in AffectedPagesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) [20:56:04] works for me locally [20:56:55] the error is infrequent enough that maybe that's the only case where that happens, though not sure 100% [20:57:02] aude: Mh [20:57:12] Will that affect site link change dispatching? [20:58:05] it does [20:58:12] maybe also if a page is deleted [20:58:16] when dispatching [20:59:08] * aude tries that [21:00:24] i do get the error if i run jobs [21:00:30] and the page in the client has been deleted [21:00:56] would definitely explain the frequency and is ok to skip the page in that case [21:04:25] 3Wikidata, MediaWiki-extensions-WikibaseRepository: Can't use tab while adding sitelinks - https://phabricator.wikimedia.org/T75642#977294 (10Nemo_bis) Thanks! [21:04:28] (03PS2) 10Aude: Handle Article ID of 0 in AffectedPagesFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) [21:05:15] (03CR) 10Hoo man: "Just an idea" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [21:11:33] this might not be enough [21:11:40] * aude looking more [21:17:18] (03PS3) 10Aude: Handle Article ID of 0 in AffectedPagesFinder and usage lookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) [21:18:14] (03CR) 10Aude: Handle Article ID of 0 in AffectedPagesFinder and usage lookup (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [21:19:10] aude: trailing spaces :D [21:19:19] ah [21:19:45] * aude was making the patch in the build, (at least can test there) but then aaaah [21:20:44] (03PS4) 10Aude: Handle Article ID of 0 in AffectedPagesFinder and usage lookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) [21:23:48] 3Wikidata: disable compact personal bar beta feature from Wikidata - https://phabricator.wikimedia.org/T86831#977313 (10Lydia_Pintscher) 3NEW [21:24:14] :( [21:24:26] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-UniversalLanguageSelector, Language-Engineering: ULS on does not consistantly work when "compact personal bar" beta feature is enabled - https://phabricator.wikimedia.org/T85541#949210 (10Lydia_Pintscher) Ok if no-one is going to fix this then... [21:25:32] and commons too, imho [21:27:11] :/ [21:27:43] aude: Wouldn't it be nice to ahve the both wfDebugLog in the same log group? [21:27:50] So that we can actually in a sane way log them [21:28:05] I guess we want that data actually right away from produciton [21:28:47] do we want to log it? [21:28:57] would be ok with me [21:29:07] If it breaks certain forms of change dispatching, yes [21:29:17] i don't think it does [21:29:39] if a page is deleted or a special page, then it doesn't get parsed [21:29:47] can't think of other reason for it to be 0 [21:30:02] (then the UpdateRepoOnDelete should handle it) [21:30:41] Yeah... it should [21:30:47] but there are still non-SUL admin accounts [21:30:54] could be similar bug, though, exists in the version of change handling with usage tracking [21:30:55] and maybe even people blocked on Wikidata [21:31:01] hm [21:31:15] i can change the log group [21:31:29] UpdateRepo* stuff should ignore Wikidata local blocks... I'll do that shortly [21:31:46] after taht and SUL we should see close to 0 inconsistencies [21:31:54] * SULF [21:31:55] what to call it? "wikibase-changes" ? [21:32:05] ChangeNotification [21:34:22] (03PS5) 10Aude: Handle Article ID of 0 in AffectedPagesFinder and usage lookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) [21:34:31] yeah, something like that [21:34:56] if this doesn't solve the issue, then we can log if we like [21:35:10] log ALL the st00f [21:35:14] many of the exception log entries are for commons [21:37:30] aude: hope you agree with disabling the beta feature in this case. and yeah :( @ no-one working on it [21:38:00] Lydia_WMDE: unfortuntaly seems necessary :( [21:38:06] yeah [21:38:18] Did you ping Jared, yet? [21:38:22] we can keep it on test.wikidata maybe and maybe someone can look [21:38:24] he is on the bug [21:38:30] and answered noone is working on it [21:38:32] * aude would but it's not highest priority vs. this stuff [21:38:41] ok [21:38:42] he marked it "needs volunteer" [21:38:47] yeah, kill it for now, then [21:43:14] 3Wikidata, MediaWiki-extensions-WikibaseRepository: API self-documentation should not be localized. - https://phabricator.wikimedia.org/T69732#977359 (10Legoktm) 5Open>3declined a:3Legoktm All API documentation is now intentionally localized. [21:43:50] for the record [21:43:51] 'betafeatures-vector-compact-personal-bar', // 2014-11-01 – Compact personal bar [21:43:56] it was supposed to be turned off in november [21:45:26] /* Display on top of page tabs - bugs 37158, 48078 */ [21:45:29] i see in the css [21:45:36] for z-index: 100 [21:45:47] Good job James_F [21:45:53] not sure it's related [21:46:06] marktraceur: Ask Jared. [21:46:10] marktraceur: And Jorm… oh. [21:47:36] Woot, aliases when merging is live. <3 https://www.wikidata.org/w/index.php?title=Q13637147&diff=188103725&oldid=152971405 [21:47:49] sjoerddebruin: ^5 [21:47:50] :) [21:48:01] ^5? [21:48:07] high five [21:48:09] :P [21:48:25] -_- [21:50:20] Full summary this weekend, lot of RfA-stuff... [21:51:45] sjoerddebruin: want to add it to the summary? [21:51:56] That's not my job!!! :O [21:52:01] :* [21:52:11] JohnFLewis: !!!! ^ [21:52:16] ;-) [21:52:36] Yes, he's the summaryslave®©™ [21:52:42] sjoerddebruin: it is now. You're hired! [21:52:45] :p [21:53:30] rofl [21:53:41] * sjoerddebruin hides in his nuclear bunker [21:53:49] sjoerddebruin: I think you'll find I do everything Lydia doesn't want to do but occasionally I make her still work because just because she's the manager doesn't mean she can do nothing ;) [21:53:56] guys my life would be sad without you ;-) [21:54:20] JohnFLewis: shush! :P [21:54:40] Lydia_WMDE: the trust must come out eventually! [21:54:45] *truth [21:54:51] true that [21:55:21] but not now! [21:55:26] it can wait inside for a few more days [21:56:18] cold outside anyway [22:00:34] Lydia_WMDE: I thought the pitchforks and torches would warm the area up though [22:00:47] :D [22:14:46] 3Wikidata, Wikidata.org, Wikimedia-Apache-configuration: Create "Main Page" for Wikidata - https://phabricator.wikimedia.org/T58258#977458 (10Nemo_bis) >>! In T58258#948897, @JanZerebecki wrote: > I couldn't actually find this URL in use. See https://www.google.ru/#q=%22wikidata.org%2Fwiki%2FMain_page%22+site:wi... [22:31:33] (03CR) 10Jeroen De Dauw: [C: 04-1] "-1 for class name ref capitalization" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183839 (https://phabricator.wikimedia.org/T86184) (owner: 10Daniel Kinzler) [22:34:40] (03CR) 10Jeroen De Dauw: Introducing changes subscription infrastructure. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183839 (https://phabricator.wikimedia.org/T86184) (owner: 10Daniel Kinzler) [22:35:00] (03CR) 10Jeroen De Dauw: "Generally looks good" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183839 (https://phabricator.wikimedia.org/T86184) (owner: 10Daniel Kinzler) [22:45:53] (03PS1) 10Jeroen De Dauw: Add missing @param doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185078 [22:54:45] (03CR) 10Hoo man: [C: 032] Add missing @param doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185078 (owner: 10Jeroen De Dauw) [22:56:24] [13WikibaseDataModel] 15JeroenDeDauw created 06AliasGroupListtta (+1 new commit): 02http://git.io/ugKmgA [22:56:24] 13WikibaseDataModel/06AliasGroupListtta 147e33abf 15jeroendedauw: Added AliasGroupList::toTextArray [22:56:52] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #337: Added AliasGroupList::toTextArray (06master...06AliasGroupListtta) 02http://git.io/NhFyig [22:58:48] wmde/WikibaseDataModel/AliasGroupListtta/7e33abf : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/47053652 [22:59:02] hoo: https://github.com/wmde/WikibaseDataModel/pull/337 [22:59:17] 1 away from being 1337 :) [23:01:34] 3Wikidata: disable compact personal bar beta feature from Wikidata - https://phabricator.wikimedia.org/T86831#977641 (10Lydia_Pintscher) Thanks @se4598! [23:02:50] * JeroenDeDauw throws a cookie at hoo [23:03:52] (03PS1) 10Jeroen De Dauw: Remove double doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185084 [23:04:24] (03CR) 10Jeroen De Dauw: "A regression test would be nice" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/184996 (https://phabricator.wikimedia.org/T86828) (owner: 10Aude) [23:12:40] (03PS1) 10Jeroen De Dauw: Optimized imports [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/185086 [23:16:52] (03PS6) 10Jeroen De Dauw: [WIP] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 [23:18:55] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 (owner: 10Jeroen De Dauw) [23:30:08] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06itemConstruct from 1459d62c1 to 14d4d942b: 02http://git.io/c7j2mQ [23:30:08] 13WikibaseDataModel/06itemConstruct 14d4d942b 15Thiemo Mättig: Optional Item constructor parameters [23:31:11] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/fLzqGQ [23:31:11] 13WikibaseDataModel/06master 1476d3534 15Jeroen De Dauw: Merge pull request #329 from wmde/itemConstruct... [23:31:51] wmde/WikibaseDataModel/itemConstruct/d4d942b : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/47057035 [23:33:29] [13WikibaseDataModel] 15JeroenDeDauw created 06itemopt (+1 new commit): 02http://git.io/lSjYhg [23:33:29] 13WikibaseDataModel/06itemopt 14467757c 15jeroendedauw: Make all Item constructor parameters optional... [23:33:36] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #338: Make all Item constructor parameters optional (06master...06itemopt) 02http://git.io/lb3VQg [23:35:41] wmde/WikibaseDataModel/itemopt/467757c : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/47057343 [23:37:44] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #325: Decrease inheritance in Statement (06master...06noParent) 02http://git.io/AY2u4Q [23:38:19] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-UniversalLanguageSelector, Language-Engineering: ULS on does not consistantly work when "compact personal bar" beta feature is enabled - https://phabricator.wikimedia.org/T85541#977749 (10Jaredzimmerman-WMF) can't users who are having an issue... [23:41:26] 3Wikidata, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-UniversalLanguageSelector, Language-Engineering: ULS on does not consistantly work when "compact personal bar" beta feature is enabled - https://phabricator.wikimedia.org/T85541#977778 (10Lydia_Pintscher) Everyone who has it enabled can't use U... [23:42:21] [13WikibaseDataModel] 15JeroenDeDauw created 06fpe (+1 new commit): 02http://git.io/dPGF_Q [23:42:21] 13WikibaseDataModel/06fpe 144c97716 15Thiemo Mättig: Allow constructing empty Fingerprint [23:43:23] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #339: Allow constructing empty Fingerprint (06master...06fpe) 02http://git.io/88Ybmg [23:44:20] wmde/WikibaseDataModel/fpe/4c97716 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/47058143 [23:46:34] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/3VGKww [23:46:34] 13WikibaseDataModel/06master 14da53a9f 15Jeroen De Dauw: Merge pull request #339 from wmde/fpe... [23:50:50] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06itemopt from 14467757c to 14097dc32: 02http://git.io/1rsrnQ [23:50:50] 13WikibaseDataModel/06itemopt 14097dc32 15jeroendedauw: Make all Item constructor parameters optional...