[00:12:22] 3Services, operations, Wikidata, MediaWiki-General-or-Unknown, wikidata-query-service: Reliable publish / subscribe event bus - https://phabricator.wikimedia.org/T84923#956732 (10GWicke) >>! In T84923#943464, @JanZerebecki wrote: > https://www.wikidata.org/w/api.php?action=help&modules=wbgetentities and recent... [01:29:46] (03PS4) 10Aude: Cache reference and rank messages when formatting statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182455 [01:38:44] (03CR) 10Aude: [C: 04-1] "generally look ok, but needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180450 (owner: 10Adrian Lang) [01:41:35] (03CR) 10Jeroen De Dauw: [C: 032] "This is not nice code quality wise, and it's also not tested. The bad design of the i18n system makes it hard to fix that though. So one i" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182455 (owner: 10Aude) [01:42:59] aude: please to review https://github.com/wmde/WikibaseInternalSerialization/pull/41 [01:44:42] there [01:44:44] ty [01:44:51] [13WikibaseInternalSerialization] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/nBAJgw [01:44:51] 13WikibaseInternalSerialization/06master 147cd04be 15Katie Filbert: Merge pull request #41 from wmde/geo... [01:48:54] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/n2cRww [01:48:54] 13WikibaseInternalSerialization/06master 147550be9 15Jeroen De Dauw: Update README.md [01:49:43] [13WikibaseInternalSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/QJoEvQ [01:49:43] 13WikibaseInternalSerialization/06master 1401e26e0 15Jeroen De Dauw: Update composer.json [01:50:51] [13WikibaseInternalSerialization] 15JeroenDeDauw tagged 061.3.1 at 06master: 02http://git.io/lbTotg [01:51:43] aude: have you looked at PHPCS in the past? [01:51:55] yes [01:52:17] * aude uses mediawiki cs rules [01:52:35] aude: Diff now runs it on TravisCI, and I'd like to refine the rules there some more before doing the same elsewhere [01:52:37] https://github.com/wmde/Diff/blob/master/phpcs.xml [01:52:43] They are based on the MW rules [01:52:48] * aude nods [01:52:49] Some additional stuff added though [01:53:02] I'm wondering if it's missing anything usefull [01:53:08] SO it'd be cool if you could have a look [01:53:33] wmde/WikibaseInternalSerialization/1.3.1/01e26e0 : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/46022941 [01:53:56] looks good at a glance [01:54:11] i'd have to look more closely to see what the additional stuff is, but probably is good [01:55:33] * aude sees stuff like [01:55:43] which mediawiki violates sometimes :( [01:55:49] but is a good rule [01:55:54] Yeah, MW cannot enable a lot of sensible rules [01:56:07] For instance the one that forces you to have method and field visibility [01:56:19] :/ [01:56:41] And we will also not be able to have all the sensible rules everyhere [01:56:59] No way we can limit cyclometic complexity to 10 in WB.git :) [01:57:49] https://scrutinizer-ci.com/g/wikimedia/mediawiki-extensions-Wikibase/code-structure/master?elementType=operation&orderField=conditional_complexity&order=desc&changesExpanded=0&page=1 [01:57:54] Only 38 with > 10 [01:58:04] That's good, I thought it was worse [01:58:17] at least have ones like that non-voting [01:58:50] yeah [02:01:55] (03PS1) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182987 [02:02:09] (03Abandoned) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [02:02:20] (03PS2) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182987 [03:30:59] (03CR) 10Jeroen De Dauw: [C: 031] "Wow - a 1600 line file, with multiple objects in it?! One object per file please. We have resource loader to stuff it all together." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179101 (owner: 10Henning Snater) [08:46:17] aude: zuul is back :) [09:00:04] hashar: yay, thanks! [09:01:11] how did you fix it? [09:14:08] (03PS2) 10Adrian Lang: Extract UserLanguageLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180450 [09:14:22] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180450 (owner: 10Adrian Lang) [09:15:30] aude: Zuul was stuck reporting a change to Gerrit [09:15:36] aude: that is a blocking operation with no timeout :-( [09:15:48] is it documented what you did? [09:15:50] aude: I asked ops to restart Gerrit which killed the stalled ssh connection and unleashed Zuul [09:15:54] ok [09:15:56] restarting Zuul would had the same effect [09:16:15] aude: I wrote an incident report on wiki and replied with two mails on qa and ops list :] [09:16:17] just so we know what to try in the future, when this happens [09:16:19] ok [09:16:22] aude: https://wikitech.wikimedia.org/wiki/Incident_documentation/20150106-Zuul [09:16:33] aude: also you should probably be sleeping since you wrote that mail at 2am ! :D [09:17:56] heh [09:20:42] * aude off for holiday now :) [09:48:09] (03PS7) 10Tobias Gritschacher: Removed movetoolbar definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179101 (owner: 10Henning Snater) [09:48:59] (03PS8) 10Tobias Gritschacher: Removed movetoolbar definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179101 (owner: 10Henning Snater) [09:49:43] Is WikiData available for the contents of pages also or only for the page itself? [09:50:25] For example on this page: https://en.wikipedia.org/wiki/List_of_cities_and_towns_in_Romania I see a Wikidata item for the name of the page but I'm interested in a Wikidata item for the list of cities [09:54:32] DrSkyLizard: https://www.wikidata.org/wiki/Q188448 is the item about the list of cities in Romania [09:54:43] then there is an item for each cities [09:55:47] yeah, I know that, what I want is an item that already contains all the cities mentioned on that page [09:56:42] DrSkyLizard: It doesn't exists [09:57:49] In the future we should be able to have "query" pages that would be able to display the list of all "instance of" "city" "located in" "Romania" [09:57:55] But is this where WikiData is going to get? as I see that now only individual entities are wikidatatized [09:57:56] right [10:01:08] http://tools.wmflabs.org/reasonator/?q=Q188448 displays all the cities now [10:18:07] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Sitelink edit mode is left when saving multiple sitelinks and one is invalid - https://phabricator.wikimedia.org/T85912#957165 (10Tobi_WMDE_SW) 3NEW [10:19:19] sjoerddebruin: awesome, Does reasonator parse the page and get the name/ID of each item from WikiData through the API? [10:19:25] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Sitelink edit mode is left when saving multiple sitelinks and one is invalid - https://phabricator.wikimedia.org/T85912#957165 (10Tobi_WMDE_SW) [10:20:02] DrSkyLizard: Reasonator is build upon https://wdq.wmflabs.org/ [10:20:18] I see it makes a request to https://wdq.wmflabs.org/api?callback=&q=claim[31:%28tree[515][][279,131]%29]%20and%20claim[17:%28tree[218][][279,131]%29] [10:21:12] 3MediaWiki-extensions-WikibaseRepository, Wikidata: remove "pages linked to this item" - https://phabricator.wikimedia.org/T84912#957176 (10Lydia_Pintscher) a:3Lucie [10:21:34] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Implement new SiteLink UI - https://phabricator.wikimedia.org/T70903#957177 (10Lydia_Pintscher) [10:21:50] interesting [10:28:08] 3Wikidata, Wikidata.org: create gadget to remove site id in language link list - https://phabricator.wikimedia.org/T85914#957184 (10Lydia_Pintscher) 3NEW [10:42:17] (03PS3) 10Adrian Lang: Move Template{,Registry} to Wikibase\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180731 [10:46:51] (03PS1) 10Lucie Kaffee: Remove "pages linked to this item" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183014 [10:48:09] (03CR) 10Hoo man: "Why is this still in Wikibase? Should probably be moved into WikimediaMessages?!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183014 (owner: 10Lucie Kaffee) [10:54:41] (03CR) 10Adrian Lang: [C: 032] "Per Thiemo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180731 (owner: 10Adrian Lang) [10:54:48] (03PS1) 10Henning Snater: sitelinklistview: No "afterstopediting" event for pending items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183015 [10:55:18] Tobi_WMDE_SW: ^ [10:58:47] (03Merged) 10jenkins-bot: Move Template{,Registry} to Wikibase\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180731 (owner: 10Adrian Lang) [11:24:57] Lydia_WMDE: https://gerrit.wikimedia.org/r/#/c/183014/ See my comment there... want to create a bug for that? [11:25:35] We probably should have one generic message in Wikibase which is "$1" (where $1 is the sitegroup) [11:25:42] (03CR) 10Lucie Kaffee: "Yes, but I don't want to mess up the translations, so someone, who knows more about it should probably have a look first!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183014 (owner: 10Lucie Kaffee) [11:25:46] and everything else (especially "Wikipedia" should not life there) [11:25:49] k [11:26:32] We would need to coordinate that with the twn folks, I guess [11:26:40] because of our non-standard deployment cycle :S [11:30:32] Henning_WMDE: this is the problematic spot in the propertysuggester: https://github.com/Wikidata-lib/PropertySuggester/blob/master/modules/ext.PropertySuggester.EntitySelector.js#L136 [11:31:11] think just removing the wikibase-claimview part would fix it, no? [11:31:48] 3MediaWiki-extensions-WikibaseRepository, Wikidata: remove "pages linked to this item" - https://phabricator.wikimedia.org/T84912#957238 (10Lucie) I didn't find "Pages on other sites linked to this item" yet. How come it's neither in WikimediaMessages nor in the Wikibase messages? [11:33:19] 3MediaWiki-extensions-WikibaseRepository, Wikidata: remove "pages linked to this item" - https://phabricator.wikimedia.org/T84912#957242 (10hoo) >>! In T84912#957238, @Lucie wrote: > I didn't find "Pages on other sites linked to this item" yet. How come it's neither in WikimediaMessages nor in the Wikibase messa... [11:43:48] (03PS2) 10Lucie Kaffee: Remove "pages linked to this item" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183014 [11:45:04] hoo whhyyy are all the translations on different places? Is this "historically grown" or is there a deeper sense to it I just don't get= [11:45:05] ? [11:46:21] Wikimedia specific stuff should live in WikimediaMessages [11:46:24] but beyond that it's historically grown [11:46:40] Ahh, so 'other sites' could stay where it is!? [11:46:41] Yes, it should [11:46:52] Tobi_WMDE_SW: https://github.com/Wikidata-lib/PropertySuggester/pull/111 is that a change that we need in order for stuff to not break at some point? [11:46:54] And if so, at which point? [11:46:55] Need to make sure we don't forget that for the deployment branch [11:46:55] hoo: yes, I'm just looking for the related task [11:46:56] one moment [11:47:07] hoo: this should be deployed whenever we deploy next [11:47:08] if fixes https://phabricator.wikimedia.org/T85804 [11:47:08] https://phabricator.wikimedia.org/T85720 can then be closed as well I think, looking at Lydia_WMDE [11:47:29] Tobi_WMDE_SW: Ok... probably next week we'll branch again [11:47:36] certainly not today/ this week [11:50:35] Henning_WMDE: https://www.wikidata.org/w/index.php?title=Q2748803&diff=186055537&oldid=185962675 gives a similar error for wikibase-statementview [11:50:36] any idea? [11:51:17] What's in the deploy today btw [11:52:11] hoo: so we do not make a branch today? [11:52:39] No, Lydia_WMDE said that the UI stuff probably isn't there yet [11:52:49] So we kind of decided that yesterday [11:53:04] hoo: think the last fixes for the sitelinks UI should be finished today.. [11:53:11] hope so [11:53:21] we'll see [11:53:43] hoo: there are two remaining issues then it should be good to go [11:54:02] So, next week, I guess? [11:54:24] branch? today imho if the remaining fixes are done [11:54:39] remaining: [11:54:48] * messages (lucie working on it) [11:54:55] Tobi_WMDE_SW: Does not seem to be related to having removed claimview. [11:55:01] * suggester issues (henning and tobi working on it) [11:55:10] Henning_WMDE: ok. [11:55:17] * gadget to remove site id (doesn't need to be in the branch) [11:55:19] DanielK_WMDE: https://gerrit.wikimedia.org/r/181258 reply would be nice [11:55:19] Keep up the good work then. :) [11:55:26] Henning_WMDE: I think the removal of claimview is not even deployed [11:56:23] Lydia_WMDE: Ok, if that's it, fine [11:56:32] i think so :) [11:57:25] Just ping me once stuff is ready and I'll create the branch/ build [11:57:30] unless Tobi or aude want to do that [11:57:41] 3Wikidata: Adjust property suggester to removal of claimview - https://phabricator.wikimedia.org/T85917#957250 (10Tobi_WMDE_SW) 3NEW [11:57:53] 3Wikidata: Adjust property suggester to removal of claimview - https://phabricator.wikimedia.org/T85917#957250 (10Tobi_WMDE_SW) p:5Triage>3High [11:59:07] 3Wikidata: Adjust property suggester to removal of claimview - https://phabricator.wikimedia.org/T85917#957250 (10Tobi_WMDE_SW) Fixed by: https://github.com/Wikidata-lib/PropertySuggester/pull/111 A new version of PropertySuggester needs to be released and included whenever we deploy Wikibase the next time. Othe... [12:00:12] hoo: https://phabricator.wikimedia.org/T85917 once the fix is merged we could create a new release and that should then be included in the branch. [12:00:20] Speaking about the property suggester, Lydia_WMDE do you have a update on it? I remember that you said that you're going to talk about it with someone... [12:00:29] (03PS5) 10Hoo man: Cache reference and rank messages when formatting statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182455 (owner: 10Aude) [12:00:36] hoo: would be good if you can create the branch. I'll poke you once the sitelinks fix is merged.. [12:00:47] Tobi_WMDE_SW: Ok, thanks [12:07:58] sjoerddebruin: on it :) [12:13:18] sjoerddebruin: on it :) [12:13:30] Two times? :O [12:13:53] yes! [12:14:41] (03CR) 10Tobias Gritschacher: [C: 032] sitelinklistview: No "afterstopediting" event for pending items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183015 (owner: 10Henning Snater) [12:14:50] (03CR) 10Tobias Gritschacher: sitelinklistview: No "afterstopediting" event for pending items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183015 (owner: 10Henning Snater) [12:15:42] (03PS2) 10Tobias Gritschacher: sitelinklistview: No "afterstopediting" event for pending items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183015 (owner: 10Henning Snater) [12:15:50] (03CR) 10Tobias Gritschacher: [C: 032] sitelinklistview: No "afterstopediting" event for pending items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183015 (owner: 10Henning Snater) [12:16:27] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Implement new SiteLink UI - https://phabricator.wikimedia.org/T70903#957279 (10Tobi_WMDE_SW) [12:16:30] 3MediaWiki-extensions-WikibaseRepository, Wikidata: Sitelink edit mode is left when saving multiple sitelinks and one is invalid - https://phabricator.wikimedia.org/T85912#957277 (10Tobi_WMDE_SW) 5Open>3Resolved a:3Tobi_WMDE_SW [12:21:35] (03Merged) 10jenkins-bot: sitelinklistview: No "afterstopediting" event for pending items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183015 (owner: 10Henning Snater) [12:27:13] (03Abandoned) 10Adrian Lang: Move var definition in statementview::_create [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180148 (owner: 10Adrian Lang) [12:42:13] [13ValueView] 15tobijat closed pull request #139: Remove undeclared variable (06master...06event) 02http://git.io/UweNtw [12:42:43] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/_BwWOA [12:42:43] 13ValueView/06master 141fe0f9a 15Tobi Gritschacher: Fix release data [12:43:18] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/4k5a_w [12:43:18] 13ValueView/06master 1495d5d4e 15Tobi Gritschacher: Bump version [12:43:33] [13ValueView] 15tobijat tagged 060.10.0 at 06master: 02http://git.io/d--V_g [12:44:46] (03PS1) 10Tobias Gritschacher: Include version 0.10.0 of data-values/value-view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183023 [12:44:51] Henning_WMDE: ^^ [12:59:06] hoo: you want to merge https://github.com/Wikidata-lib/PropertySuggester/pull/111 so we can release a new version? [13:00:16] Done :) [13:01:26] hoo: thx! do we need to adjust https://github.com/wmde/WikidataBuildResources/blob/master/composer.json#L17 to include the new version? [13:02:10] (03PS1) 10Adrian Lang: Add missing TemplateRegistry use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183025 [13:02:14] Should work w/o doing that [13:03:28] ok, new version released: https://github.com/Wikidata-lib/PropertySuggester/releases/tag/2.0.3 [13:03:38] Nice :) [13:03:46] Have Lucie's patches been merged? [13:06:17] (03CR) 10Tobias Gritschacher: [C: 032] Add missing TemplateRegistry use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183025 (owner: 10Adrian Lang) [13:07:04] someone wants to merge https://gerrit.wikimedia.org/r/183023? [13:07:17] avoids a firefox bug in new sitelinks ui [13:07:50] and is trivial.. :) [13:08:57] (03Merged) 10jenkins-bot: Add missing TemplateRegistry use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183025 (owner: 10Adrian Lang) [13:12:21] 3Wikidata: Adjust property suggester to removal of claimview - https://phabricator.wikimedia.org/T85917#957310 (10Lydia_Pintscher) [13:16:19] Tobi_WMDE_SW: closing the investigation of reference suggestions ticket https://phabricator.wikimedia.org/T85720 [13:16:32] 3MediaWiki-extensions-WikibaseRepository, Wikidata: investigate why suggestions for references don't seem to work - https://phabricator.wikimedia.org/T85720#957312 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher [13:16:51] Tobi_WMDE_SW: can https://phabricator.wikimedia.org/T85804 also be closed? [13:16:53] Lydia_WMDE: if you experienced it on beta, then yes [13:17:07] Lydia_WMDE: this is another thing [13:17:16] k [13:17:31] seems not related to the property suggester issues [13:17:49] as it is on diffs [13:19:36] hoo: think we are ready to branch as soon as https://gerrit.wikimedia.org/r/183023 is merged.. [13:29:58] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/WnU-8Q [13:29:58] 13WikidataBrowserTests/06master 14b029eb4 15Tobias Gritschacher: Adjust sitelinktests... [13:29:58] (03PS1) 10Henning Snater: siteselector: Factored out _considerSuggestion() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183027 [13:30:59] Tobi_WMDE_SW: http://wikidata.beta.wmflabs.org/wiki/User:SiteIdToInterwikiCode/common.js (not sure whether naming is correct). https://gerrit.wikimedia.org/r/183027 should be merged for that to work as expected. [13:32:01] (03PS2) 10Tobias Gritschacher: siteselector: Factored out _considerSuggestion() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183027 (owner: 10Henning Snater) [13:33:04] Henning_WMDE: will have a look [13:35:04] (03CR) 10Tobias Gritschacher: [C: 032] siteselector: Factored out _considerSuggestion() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183027 (owner: 10Henning Snater) [13:35:24] Henning_WMDE: want to merge https://gerrit.wikimedia.org/r/183023? [13:35:45] Yes, about to check. [13:36:55] 3Wikidata, Wikidata.org: create gadget to remove site id in language link list - https://phabricator.wikimedia.org/T85914#957324 (10Tobi_WMDE_SW) http://wikidata.beta.wmflabs.org/wiki/User:SiteIdToInterwikiCode/common.js [13:37:11] 3Wikidata, Wikidata.org: create gadget to remove site id in language link list - https://phabricator.wikimedia.org/T85914#957326 (10Tobi_WMDE_SW) [13:37:47] (03Merged) 10jenkins-bot: siteselector: Factored out _considerSuggestion() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183027 (owner: 10Henning Snater) [13:41:01] (03CR) 10Adrian Lang: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [13:41:10] [13WikidataBuildResources] 15tobijat created 06update_propertysuggester (+1 new commit): 02http://git.io/oB9JVA [13:41:10] 13WikidataBuildResources/06update_propertysuggester 142d48b36 15Tobias Gritschacher: Include newest version of propertysuggester/property-suggester [13:45:42] (03CR) 10Adrian Lang: Apply "lang" and "dir" attributes to aliases input boxes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 (owner: 10Henning Snater) [13:45:46] (03CR) 10Adrian Lang: [C: 032] Apply "lang" and "dir" attributes to aliases input boxes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 (owner: 10Henning Snater) [13:46:17] Adrian_WMDE: https://gerrit.wikimedia.org/r/#/c/178876/ [13:48:15] (03Merged) 10jenkins-bot: Apply "lang" and "dir" attributes to aliases input boxes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 (owner: 10Henning Snater) [13:50:20] (03CR) 10Daniel Kinzler: "This introduces quite a bit of code and complexity, and I'm dubious about the performance benefits. Considering that the actual entity dat" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (owner: 10Hoo man) [13:52:09] (03CR) 10Henning Snater: [C: 032] Include version 0.10.0 of data-values/value-view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183023 (owner: 10Tobias Gritschacher) [13:55:30] (03Merged) 10jenkins-bot: Include version 0.10.0 of data-values/value-view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183023 (owner: 10Tobias Gritschacher) [13:58:58] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2015/01/06 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/183030 [14:00:52] 3Wikidata, MediaWiki-General-or-Unknown, wikidata-query-service, Services, operations: Reliable publish / subscribe event bus - https://phabricator.wikimedia.org/T84923#957337 (10JanZerebecki) As in a diff? Not that I am aware of. The granularity of actual changes in the DB is one entitiy, smaller granularity mi... [14:01:40] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 2015/01/06 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/183030 (owner: 10Tobias Gritschacher) [14:01:58] hoo: from my side we're ready to branch [14:02:15] Lucie's patch merged yet? [14:02:20] I think Lydia wants it [14:03:17] hoo: I'm fine with merging.. [14:03:51] (03CR) 10Tobias Gritschacher: [C: 032] Remove "pages linked to this item" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183014 (owner: 10Lucie Kaffee) [14:04:32] (03PS1) 10Henning Snater: entityselector: Adjusted member name to changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183031 [14:04:35] Tobi_WMDE_SW: ^ [14:05:20] (03PS2) 10Henning Snater: entityselector: Adjusted member name to changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183031 [14:05:39] Henning_WMDE: Needed for the brnach? [14:06:11] hoo: it is causing results to show up twice in the search widget [14:06:18] :S [14:06:23] so, would be nice to have it [14:06:29] I mean, the change is the fix [14:06:33] :) [14:06:35] Would be nice, yes. [14:06:55] But not my decision whether it is necessary. [14:07:02] Henning_WMDE: any other places wher this needs to be adjusted? [14:07:09] (03Merged) 10jenkins-bot: Remove "pages linked to this item" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183014 (owner: 10Lucie Kaffee) [14:07:50] That seem to be all of them. [14:07:55] ok [14:08:37] (03CR) 10Tobias Gritschacher: [C: 032] entityselector: Adjusted member name to changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183031 (owner: 10Henning Snater) [14:10:44] [13WikidataBuildResources] 15mariushoch closed pull request #18: Include newest version of propertysuggester/property-suggester (06master...06update_propertysuggester) 02http://git.io/_RjIYA [14:11:16] (03Merged) 10jenkins-bot: entityselector: Adjusted member name to changes in ValueView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/183031 (owner: 10Henning Snater) [14:11:24] Ok, so that's it? [14:11:49] 3Wikidata: Adjust property suggester to removal of claimview - https://phabricator.wikimedia.org/T85917#957343 (10Tobi_WMDE_SW) 5Open>3Resolved a:3Tobi_WMDE_SW [14:12:01] hoo: I guess so [14:13:10] hoo: made a new build just a few minutes ago, that will be browser-tested on beta [14:13:18] hope them to succeed [14:14:20] [13ValueView] 15snaterlicious created 06suggestersearchingdoc (+1 new commit): 02http://git.io/hZCLFw [14:14:20] 13ValueView/06suggestersearchingdoc 14d57e82d 15snaterlicious: Fixed jQuery.ui.suggester._searching documentation [14:14:29] Wikibase branch created [14:14:34] yay [14:15:40] [13ValueView] 15snaterlicious opened pull request #140: Fixed jQuery.ui.suggester._searching documentation (06master...06suggestersearchingdoc) 02http://git.io/knj03w [14:17:24] Lydia_WMDE: can we close https://phabricator.wikimedia.org/T76244? [14:17:50] (03CR) 10Adrian Lang: [C: 032] Implementing prefetching on top of TermIndex. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [14:17:59] (03PS3) 10Adrian Lang: Factor out EntityTermLookupBase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180739 [14:20:51] (03Merged) 10jenkins-bot: Implementing prefetching on top of TermIndex. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [14:23:21] (03Abandoned) 10Adrian Lang: Merge of CachedTermLookup with EntityIdLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180544 (owner: 10Daniel Kinzler) [14:25:36] (03PS1) 10Hashar: (WIP) Ship data-values directly in the repo (WIP) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183032 [14:25:38] (03PS10) 10Adrian Lang: Batched term lookups for RC lists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180140 (owner: 10Daniel Kinzler) [14:25:48] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf14/ceb32e7 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/46074059 [14:26:23] (03CR) 10jenkins-bot: [V: 04-1] (WIP) Ship data-values directly in the repo (WIP) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183032 (owner: 10Hashar) [14:26:44] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180140 (owner: 10Daniel Kinzler) [14:34:10] (03Abandoned) 10Hashar: (WIP) Ship data-values directly in the repo (WIP) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183032 (owner: 10Hashar) [14:39:09] (03PS1) 10Hoo man: New deployment branch: wmf/1.25wmf13 [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183033 [14:39:15] doh [14:39:18] commit summary fail [14:40:25] (03PS2) 10Hoo man: New deployment branch: wmf/1.25wmf14 [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183033 [14:43:55] (03CR) 10Hoo man: [C: 032] New deployment branch: wmf/1.25wmf14 [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183033 (owner: 10Hoo man) [14:45:38] Tobi_WMDE_SW: ok [14:46:06] (03Merged) 10jenkins-bot: New deployment branch: wmf/1.25wmf14 [extensions/Wikidata] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/183033 (owner: 10Hoo man) [14:49:56] (03CR) 10Hoo man: "@Daniel: I stumbled upon this when profiling wbgetentities in production. It spends quite some time getting revision ids from the DB, if m" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (owner: 10Hoo man) [14:52:12] 11.24% 36.365 57 - Wikibase\Lib\Store\WikiPageEntityRevisionLookup::selectPageLatest [14:52:18] https://www.wikidata.org/w/api.php?action=wbgetentities&ids=P1566|P1448|P138|P1332|P463|P1151|P122|P37|P38|P41|P31|P47|P78|P85|P30|P94|P194|P237|P297|P298|P299|P242|P361|P150|P402|P373|P474|P163|P417|P209|P227|P244|P214|P395|P625|P35|P610|P6|P36|P832|P910|P948|P349|P984|P998|P421|P982|P646|P530|P901|P571|P155|P1082|P793|P1465|P1464|P17&props=claims&forceprofile=1 [14:52:20] DanielK_WMDE: ^ [14:52:35] (03PS1) 10Adrian Lang: Include the composer autoloader if it is present [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183036 [14:52:41] The actual percentage is higher, but we need to use pretty print to get the debug output, which in turn eats CPU time [14:52:52] (03CR) 10jenkins-bot: [V: 04-1] Include the composer autoloader if it is present [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183036 (owner: 10Adrian Lang) [14:56:07] hoo: can you post that on gerrit? thanks. [14:56:22] sure [14:58:23] (03CR) 10Hoo man: "Example:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181718 (owner: 10Hoo man) [15:01:47] (03Restored) 10Hashar: (WIP) Ship data-values directly in the repo (WIP) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183032 (owner: 10Hashar) [15:02:36] 3Wikidata: improve dump documentation - https://phabricator.wikimedia.org/T85407#957379 (10Lucie) There is no way of finding this page if you don't know what you are looking for (it's not linked anywhere). [15:02:44] (03PS2) 10Hashar: (WIP) Ship data-values directly in the repo (WIP) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183032 [15:03:32] Is there a JSON incremental dump in addition to the full dump anywhere? [15:03:45] (03CR) 10jenkins-bot: [V: 04-1] (WIP) Ship data-values directly in the repo (WIP) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183032 (owner: 10Hashar) [15:04:26] (03CR) 10Hashar: "Rebased on top of "Include the composer autoloader if it is present" https://gerrit.wikimedia.org/r/#/c/183036/1" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183032 (owner: 10Hashar) [15:04:59] (03CR) 10Hashar: "I have rebased the lame patch that embeds data-values in the WikibaseJavaScriptApi repo and it progress slightly: https://gerrit.wikimedia" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/183036 (owner: 10Adrian Lang) [15:08:31] 3MediaWiki-extensions-WikibaseRepository, Wikidata: provide incremental JSON dumps for Wikidata - https://phabricator.wikimedia.org/T72246#957385 (10hoo) This would probably be implemented like this: Have a script that dumps all entity ids that have been changed since the last incremental dump. Then just dump al... [15:31:34] Where are the P property values stored? I can't find them the SQL data dumps. I can see the links between items and properties in pagelinks, but there are no values anywhere... [15:32:13] TinoDidriksen: hi [15:32:30] You mean the values of the Statements on Items? [15:32:34] Yes [15:33:18] Are you talking about the data on tool labs or what specific dump? We don't have SQL dumps [15:33:39] http://dumps.wikimedia.org/wikidatawiki/ includes .sql.gz files... [15:33:57] And apart from the values, it's all there. [15:34:34] wikidatawiki-20141208-pagelinks.sql.gz 345.9 MB [15:34:36] that one? [15:34:44] That has the links, but no values. [15:35:05] Yeah, it's from core MediaWiki, thus it doesn't even know about Wikibase [15:35:17] so it only has links (a concept which MediaWiki knows about) [15:37:33] 3MediaWiki-extensions-WikibaseRepository, Multimedia, Wikidata, MediaWiki-extensions-MultimediaViewer: Use MediaViewer on commonsMedia properties on Wikibase repo - https://phabricator.wikimedia.org/T71456#957437 (10Gilles) [15:39:10] So, if one wants to make random offline queries on the data, I'd have to use Wikibase and what dumps? [15:39:41] TinoDidriksen: Those, preferable: https://dumps.wikimedia.org/other/wikidata/ [15:39:50] They contain all entities with complete data [15:40:21] I saw those, but seemed so silly to process them to tables when there are immediately usable tables... [15:40:56] I see, but there aren't any such tables :S [15:43:31] TinoDidriksen: properties are currently not represented as key/value paris in the database at all. that functionality is dubbed "simply queries" and has sadly been delayed for silly technical reasons several times. [15:48:37] 3Wikidata: improve dump documentation - https://phabricator.wikimedia.org/T85407#957471 (10Lucie) I edited both pages. If someone could read through it and improve it, we could close this bug. [15:54:31] 3Wikidata.org, Wikidata: JS error: unrecognized expression: unsupported pseudo: wikibase-statementview - https://phabricator.wikimedia.org/T85804#957478 (10Ricordisamoa) >>! In T85804#955166, @Ciencia_Al_Poder wrote: > This is caused by the [[ https://www.wikidata.org/wiki/MediaWiki:Gadget-AuthorityControl.js |... [16:02:25] DanielK_WMDE: :'( [17:44:08] (03CR) 10Multichill: "Thanks for the input Daniel. Doesn't the EntityTitleLookup service do a database lookup somewhere deep down?" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181902 (owner: 10Multichill) [19:15:26] 3wikidata-query-service, Wikidata, Services, operations, MediaWiki-General-or-Unknown: Reliable publish / subscribe event bus - https://phabricator.wikimedia.org/T84923#957905 (10JanZerebecki) While talking to @daniel he noticed that I missed that the actual serialized diff is saved in https://www.mediawiki.org/... [20:29:53] 3wikidata-query-service, Services, Wikidata: Investigate & design public API, possibly using MQL - https://phabricator.wikimedia.org/T85181#958066 (10Manybubbles) a:3GWicke [20:30:45] 3wikidata-query-service, Services, Wikidata: Investigate & design public API, possibly using MQL - https://phabricator.wikimedia.org/T85181#940838 (10Manybubbles) I think its probably worth implementing a copy of Wikidata Query Service's API as well. [20:31:18] 3wikidata-query-service, Services, Wikidata: Investigate & design public API, possibly using MQL - https://phabricator.wikimedia.org/T85181#958074 (10GWicke) [20:47:23] Shit. http://tools.wmflabs.org/autolist [21:25:17] YuviPanda: can you also restart autolist or only WDQ? [21:25:43] sjoerddebruin: autolist too [21:25:45] moment [21:25:50] Great. [21:26:31] hoo|away: are you around on thursday? [21:33:38] YuviPanda: how long is "a moment"? :) [21:33:44] Otherwise I would hit the shower. [21:34:01] sjoerddebruin: oh, I restarted it. [21:34:18] Ah, yes it's back. [21:34:53] So, updated Magnus on Twitter... Let's go. [21:36:54] Thanks anyway. Would send some bamboo over again. [21:37:32] hoo|away: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=139990&oldid=139951 [21:37:55] i can take care of it and gives us time in case there is any problem to fix [21:38:35] grrr, need to pick another time [21:48:12] aude: That time also works for me [21:48:29] just going to be out for dinner tomorrow evening, so can't be around then [21:49:04] i made it an hour later (3pm for us) [21:49:10] since we have a meeting earlier [21:49:49] should take less than an hour (need to scap), but gave us extra time in case we need [21:51:50] yeah