[00:25:49] <5EXAB2O9J> [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06depsetid at 14821446e: 02http://git.io/tUTzTQ [00:25:49] <17WAAS02P> [13WikibaseDataModel] 15JeroenDeDauw closed pull request #312: Deprecate Entity::setId (06master...06depsetid) 02http://git.io/aN8h4w [00:48:30] [13Common] 15JeroenDeDauw closed pull request #14: Fix broken tests (06master...06nonOptional) 02http://git.io/ZN0Uzg [01:01:47] [13WikibaseInternalSerialization] 15JeroenDeDauw opened pull request #41: Allow usage with latest version of DV Geo (06master...06geo) 02http://git.io/uyUt8g [01:03:02] wmde/WikibaseInternalSerialization/geo/ec65c19 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/45899130 [02:26:27] (03CR) 10Krinkle: "If this class was released in 1.24, the addition of a parameter between existing parameters is a breaking change. Is there a particular re" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [04:12:25] Change on 12mediawiki a page Extension:Wikibase Client was modified, changed by Liuxinyu970226 link https://www.mediawiki.org/w/index.php?diff=1342734 edit summary: [+21] [08:22:17] [13Common] 15thiemowmde 04force-pushed 06covers from 149b309ea to 1497261d8: 02http://git.io/s__fZQ [08:22:17] 13Common/06covers 1497261d8 15Thiemo Mättig: Add missing @covers tags [08:23:12] [13Common] 15thiemowmde 04force-pushed 06unserialize from 14da92cb3 to 1450b5be2: 02http://git.io/j0I_5w [08:23:12] 13Common/06unserialize 1450b5be2 15Thiemo Mättig: Remove misleading return doc [08:23:51] [13Common] 15thiemowmde 04force-pushed 06private from 148babbd0 to 1401b974c: 02http://git.io/aMKv7g [08:23:51] 13Common/06private 1401b974c 15Thiemo Mättig: Make class properties private [09:39:55] (03PS6) 10Henning Snater: Removed movetoolbar definitions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179101 [09:43:36] (03PS3) 10Henning Snater: Removed toolbarcontroller toolbar restrictions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180423 [10:24:20] hi, does anyone know what happened to icinga? http://nagios.wmflabs.org/icinga/ we try to set up our labs instance for the bachelor project kind of blind-folded atm [10:36:36] anjeve: i vaguely remember something like yuvipanda replaced it with shinken... no idea where the URL is... tell me when you find out, please :) [10:37:28] jzerebecki: can you help us set the labs instance with a test wikidata also without the monitoring tools ? ;) [10:38:07] jzerebecki: we try using the boxes provided by https://wikitech.wikimedia.org/wiki/Special:NovaInstance [10:39:34] * hoo waves [10:40:24] * sjoerddebruin waves back [10:46:09] (03CR) 10Hoo man: "@Krinkle: This is not in core, so no one cares and yes, it makes sense to have it with strip-protocol IMO" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [10:47:29] anjeve: what is your projects name? what is the actual problem? [10:48:02] jzerebecki: wikidata-quality-playground [10:48:29] jzerebecki: our instance is missing the regularly installed packages like php, apache etc [10:48:47] jzerebecki: There are two changes in gerrit that need review today :S [10:49:04] jzerebecki: which means we need to use the special page to set them up or do it manually [10:49:28] The sites stuff and exception from SpecialEntityData [10:49:34] * exceptions [10:49:37] but the special pages doesn't do anything - and we don't get access to icinga to see the monitoring stats [11:07:54] DanielK_WMDE: New year, new fun... I need reviews for https://gerrit.wikimedia.org/r/182750 today [11:08:16] want to backport it because we have that exception in the log several hundred times per minute and that's... well, bad :P [11:09:51] hey hoo! [11:09:56] happy new one! [11:10:00] will look in a minute [11:10:29] Oh, same to you of course ;) [11:11:02] uh... i'm not sure I like that hack... and i'm confused. [11:11:15] Confused about? [11:11:22] And I don't *really* like it myself [11:11:26] if I let an HttpError bubble up, it's logged when/where/how/why? [11:11:35] apache error log? [11:11:40] exception log [11:11:47] o_O [11:11:48] wtf? [11:11:49] because it's an MWException [11:12:11] public function isLoggable() { [11:12:11] return true; [11:12:15] would need to overwrite that [11:12:39] I thought about having a GracefulHttpError (or so) in Wikibase that makes that false [11:12:43] hm... that's not really the intended use of that method, is it? [11:12:44] but aude didn't like the idea [11:12:58] I'm not sure [11:13:07] * Show an error that looks like an HTTP server error. [11:13:23] so, to me, an HttpError is a way to signat an issue to the client. if would be sensible to log it in the web server error log (like any other http error). [11:13:24] That's what the doc says [11:13:36] it makes no sense to me to treat it like an uncaught exception, ever [11:13:47] i'd really like to address this in core, not with a nasty special case hack [11:14:11] By making HttpError not log at all? [11:14:21] Or by introducing a $log flag to it? [11:14:31] So that the thrower can decide [11:14:37] flag sounds horrible [11:14:58] I still like my idea of an UnloggedHttpError class [11:21:23] hoo: UnloggedHttpError would be reasonable, though I don't really see a purpose for a logged http error [11:21:33] i'll try and dig into the core logic a bit. [11:21:38] ok :) [11:28:16] (03CR) 10Daniel Kinzler: "From a first look, this should work, but I'd much prefer to handle this in core, properly." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [11:28:53] anjeve: that is to be expected, as the puppet classes selected for that instance do not pull in php nor apache. you need additional ones. [11:29:44] (03CR) 10Daniel Kinzler: Don't log HttpErrors targeted at SpecialEntityData (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [11:31:14] hoo: when and where is the exception written to the exception log? [11:31:31] DanielK_WMDE: Oh, not sure [11:31:36] Why does that matter? [11:32:02] ah, found it - MWExceptionHandler::logException [11:32:14] Yeah, something like that probably [11:33:51] overriding isLoggable sounds perfectly reasonabvle to me [11:34:00] at least for $code < 500 [11:34:15] Ok [11:34:24] In core or shall I create the new class in Wikibase? [11:34:41] Having it in core will make the deploy today a bit more tedious, but that's still managable [11:36:14] hoo: makign our own class is quicker and easier, but makes it less likely to be fixed in core. [11:36:33] you could do both. our "own" class would become obsolete when the core patch is merged. [11:37:44] That sounds reasonable [11:38:05] DanielK_WMDE: And... more fun: https://gerrit.wikimedia.org/r/182661 [11:38:12] We also want that today... [11:38:27] ruwikinews can't be linked due to that [11:38:30] jzerebecki: ^ [11:39:38] hoo: ...but then, http errors with code < 500 are not logged at all. they should really go into the apache error log. [11:40:03] Maybe the apache log does that based on the actual code send? [11:40:11] I have no idea :S [11:40:20] MyUnloggedHttpError :P [11:40:26] *MaybeUnlogged [11:40:51] (03CR) 10Daniel Kinzler: "From what I can see in MWExceptionHandler, HttpError::isLoggable should return false, at least if $code < 500." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [11:41:30] (03CR) 10Daniel Kinzler: "...i'll file a ticket about it." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [11:42:01] hoo: i don't think http errors generated by php go to the server's error log automatically. [11:45:01] DanielK_WMDE: Possible [11:45:26] But I think if someone throws an UnloggedHttpError they should know it's *not* logged :P [11:45:47] We can still catch -> debug log -> rethrow if we want them [11:50:37] DanielK_WMDE: Will you create any further tickets? If not, I'll start implementing [11:51:02] And I'll leave it upon the thrower to decide whether they want to have the logged or unlogged exception [11:51:12] if the exception says it's unlogged then it is [11:52:32] hoo: hm, ok. i'll file a bug askeing about the desired semantics [11:53:32] and for now I'll just implement the new exception in Wikibase [11:54:47] (03CR) 10JanZerebecki: "I don't think they should. Currently a not existing page returns a 404 which it seems doesn't get logged in the apache error log nor in th" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [12:03:04] jzerebecki: siehst du den direct chat? [12:03:52] hoo: gehe jetzt was essen, mach danach das ticket fertig. [12:04:32] anjeve: ja geantwortet. bis gleich. [12:05:41] DanielK_WMDE: ok [12:50:06] hoo: jzerebecki: any idea what happend to http://wikidata.beta.wmflabs.org/ ? [12:50:29] no :S [12:51:30] hoo: but are also not able to reach it, right? just to be sure it's not me.. [12:51:42] DNS looks broken, wtf [12:52:41] hoo: other beta-wikis seem to work [12:53:08] yeah [12:53:11] am poking people [12:56:13] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2015/01/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/182786 [12:56:17] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2015/01/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/182786 (owner: 10Tobias Gritschacher) [12:56:40] (03Abandoned) 10Tobias Gritschacher: New Wikidata Build - 2015/01/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/182786 (owner: 10Tobias Gritschacher) [13:01:11] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2015/01/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/182788 [13:14:29] hey Lydia_WMDE [13:14:38] did you accidentally remove MaxSem from cc or ? [13:14:58] YuviPanda: hey :) uhm where? [13:15:08] https://phabricator.wikimedia.org/T85793 [13:15:22] ehhhhh [13:15:23] nope [13:15:26] readding [13:16:41] Lydia_WMDE: cool. [13:19:57] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 2015/01/05 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/182788 (owner: 10Tobias Gritschacher) [13:29:36] anjeve: re. i see adding the puppet classes now worked. any more questions? [13:29:59] YuviPanda: hey do you know where the monitoring for labs is now? [13:30:21] jzerebecki: shinken ;) [13:30:29] http://shinken.wmflabs.org/ [13:30:37] login data is guest *2 [13:30:55] uggg :( [13:32:35] anjeve: ^^ there is the answer to your monitoring/icinga question [13:32:44] seen it [13:32:57] jzerebecki: private chat [13:46:08] DanielK_WMDE: If you're back... HttpError... :P [13:46:31] hoo: https://phabricator.wikimedia.org/T85795 [13:47:13] DanielK_WMDE: That's nice, but not what we actually want [13:47:22] In our specific use case [13:47:31] we don't want any wfLogWarning or so [13:47:42] We want it truly unlogged (probably) [13:49:57] DanielK_WMDE: ^ [13:53:54] hoo: why? what code/error are we seeing that often? [13:54:06] any plain olf 404 should go the the web server's error log, no? [13:54:45] to me, the problem seems to be that it's logged as an internal error, which it isn't [13:54:46] Only if it's a real 404 as in no such script [13:54:56] the fact that it's logged is not a problem as such, is it? [13:55:01] but if it's in a path handled by index.php (eg. a title that's not there), no [13:55:02] huh? [13:55:03] why? [13:55:16] Because we don't care [13:55:23] i mean, in general. not just for wikimedia [13:55:56] Oh, in general you probably log all non 200 or 30\d responses [13:56:16] well, i suppose EntityData should behave for non-existing items just like same as requesting a non-existing page [13:56:27] right, in general you would. [13:56:29] how? [13:56:29] DanielK_WMDE: not logging anything is also how 404 for not existing articles are currently handled [13:56:51] DanielK_WMDE: That's an apache issue, not our department at all [13:57:00] We just return a 404 and don't do any MediaWiki logging [13:57:07] jzerebecki: is that configurable? and: that's just 404, what about 413 or soemthing? [13:57:15] what people do or don't with their apaches is not up to us [13:57:29] 415, sorry [13:57:47] hoo: it's up to use to give them control over it. [13:57:54] DanielK_WMDE: no idea. and if we were to change that for 404s we have a new problem of how do discern those from actual errors in the apache error log [13:57:54] *us [13:58:08] jzerebecki: they are actual errors [13:58:22] just as much as any 404 [13:59:09] $wgSend404Code exists... would be interresting to know how that relates to logging [13:59:17] with actual i mean of interest to ops or devs [13:59:46] jzerebecki: simple: script path vs. article path [13:59:47] as opposed to expected return code for this user request [14:00:57] Let's forget about the proper way to do stuff(tm) [14:01:03] that's not the MediaWiki way anyway :P [14:01:08] jzerebecki: making a destinction between codes generated by apache and codes generated by php is kind of artificial. from the client's perspective, there is no difference. I feel that at least per default, there should be no difference in logging either. [14:01:08] What shall we do *now* [14:01:09] as in today [14:01:10] oh, well... [14:01:54] hoo: today we cannot change core. so we work around it, by subclassing HttpError, or using your original patch (fixed to use $exception->report()) [14:02:23] DanielK_WMDE: $exception->report uses php's header and not the one in WebRequest [14:02:26] thus breaking tests ;) [14:02:32] It sucks, I know [14:05:36] jzerebecki: Please, have a look at https://gerrit.wikimedia.org/r/182661 [14:11:06] hoo: if we are mucking around core, we could fix that too... maybe. [14:12:06] No, we don't have access to the context in the exception :/ [14:12:14] Could maybe use $wgRequest, though [14:12:49] yea :( [14:14:03] DanielK_WMDE: Is the change as is good enough for now? Or shall I do the subclass thing? [14:16:25] *sigh* [14:16:40] mh? [14:17:02] hoo: the exception handling should be in the request handler, not in the special page. [14:17:17] oh, yeah, true [14:17:23] And it should have a comment pointing to the ticket i filed, for general discussion [14:17:41] I think I'll subclass, that will make all exception handling superfluous [14:19:01] It also makes sense in a way. The thrower probably knows best which errors should be logged [14:19:04] (03CR) 10Krinkle: "OK" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [14:19:16] I'd actually suggest to only make 404s unlogged, and log everything else as before [14:20:05] DanielK_WMDE: User action should never lead to an exception bubbling up [14:20:20] We should always handle them more graceful [14:21:14] hoo: i agree in general, but HttpError is a special case. it already implements the graceful handling. [14:21:52] it's a way to signal a well defined and expected thing to the response, and that's what should happen if it bubbles up [14:21:58] otherwise it has no purpose and should be scrapped. [14:22:23] err, "well defined and expected response to the user". [14:25:55] DanielK_WMDE: True [14:26:08] but in that case we would never do the normal exception logging [14:26:21] (03CR) 10JanZerebecki: "Looks good. Would +2 after the comment from Krinkle is addressed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [14:26:46] hoo: the normal handling is calling $exception->report(), which is exactly what we want. [14:26:51] we just want better control over the logging [14:27:55] Which means we don't want the normal logging [14:30:32] hoo: at least not for 404s. [14:31:02] hoo: currently, i tend towards just using a different log channel, "http-errror" instead of "exception", for all instances of HttpError [14:32:08] +1 [14:34:20] (03CR) 10Daniel Kinzler: [C: 031 V: 031] "Works fine and makes sense. I don't care too much about the command line options, would be fine with merging this." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [15:32:45] (03PS3) 10Hoo man: Add --force-protocol to the populateSitesTable.php maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 [15:32:55] (03CR) 10Hoo man: Add --force-protocol to the populateSitesTable.php maintenance script (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [15:33:11] (03CR) 10Hoo man: "Addressed Krinkle's comment" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [15:34:28] (03PS4) 10Hoo man: Add --force-protocol to the populateSitesTable.php maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 [15:35:25] jzerebecki: Merge ^ :P [15:35:37] already on it :) [15:38:01] (03CR) 10JanZerebecki: [C: 032] Add --force-protocol to the populateSitesTable.php maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [15:38:20] thanks :) [15:40:48] (03Merged) 10jenkins-bot: Add --force-protocol to the populateSitesTable.php maintenance script [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182661 (owner: 10Hoo man) [15:45:03] (03PS1) 10Hoo man: Add --force-protocol to the populateSitesTable.php maintenance script [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182815 [15:45:18] (03PS1) 10Hoo man: Add --force-protocol to the populateSitesTable.php maintenance script [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182817 [15:47:03] (03PS2) 10Hoo man: Introduce an UnloggedHttpError [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 [15:47:26] DanielK_WMDE: ^ [15:47:31] am preparing a proper fix as well [15:47:34] but this one if for now [15:48:12] s/if/is/ [15:48:45] (03CR) 10Hoo man: "Taking an other approach now (per Daniel)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [15:54:09] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182817 (owner: 10Hoo man) [15:54:15] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182815 (owner: 10Hoo man) [15:54:34] jzerebecki: https://gerrit.wikimedia.org/r/182750 [15:59:18] (03Merged) 10jenkins-bot: Add --force-protocol to the populateSitesTable.php maintenance script [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182817 (owner: 10Hoo man) [15:59:32] (03Merged) 10jenkins-bot: Add --force-protocol to the populateSitesTable.php maintenance script [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182815 (owner: 10Hoo man) [16:00:37] anyone? [16:00:39] grumbl [16:00:44] * hoo would like to make the build [16:03:59] Error while "Merge with: Q13103980": failed-modify [16:04:03] Umm... [16:04:11] Anyone know the cause? [16:06:04] Nevermind [16:06:10] I think we've got a true duplicat [16:06:14] *duplicate [16:07:39] hoo: We've got 8 true duplicates at WD:RFDD [16:07:45] I think that's a record :P [16:07:54] GeorgeEdwardC: :P [16:08:04] Maybe some troll is just copying them from the list of duplicates [16:08:18] I should write a bot for that... so that people actually delete them :D [16:08:48] That's why it failed when I attempted a merge [16:09:25] Is it routine to delete? [16:09:46] in general, yes [16:11:16] Ah ok [16:11:47] (03CR) 10JanZerebecki: [C: 04-1] "Looks good, except we still want to log the 500 error." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [16:12:20] oh, true [16:14:01] (03PS3) 10Hoo man: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 [16:18:01] (03CR) 10JanZerebecki: [C: 032] Introduce an UnloggedHttpError and use it in EntityDataRequestHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [16:18:12] ah, thanks :) [16:21:18] (03PS1) 10Hoo man: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182822 [16:21:37] (03PS1) 10Hoo man: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182823 [16:21:58] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182823 (owner: 10Hoo man) [16:22:28] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182822 (owner: 10Hoo man) [16:35:31] (03Merged) 10jenkins-bot: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/182750 (owner: 10Hoo man) [16:35:51] (03Merged) 10jenkins-bot: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182823 (owner: 10Hoo man) [16:35:53] (03Merged) 10jenkins-bot: Introduce an UnloggedHttpError and use it in EntityDataRequestHandler [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182822 (owner: 10Hoo man) [16:55:43] composer is not my fan today -.- [17:11:23] (03PS1) 10Hoo man: Update Wikibase: Fix SpecialEntityData and enhance populateSitesTable [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182833 [17:14:55] (03PS1) 10Hoo man: Update Wikibase: Fix SpecialEntityData and enhance populateSitesTable [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182835 [17:18:47] [13WikidataBuildResources] 15mariushoch created 06preferDist (+1 new commit): 02http://git.io/FbJLRw [17:18:47] 13WikidataBuildResources/06preferDist 141ffdc79 15Marius Hoch: Make composer always use dist over source... [17:19:06] [13WikidataBuildResources] 15mariushoch opened pull request #17: Make composer always use dist over source (06master...06preferDist) 02http://git.io/n2C0yw [17:21:14] (03CR) 10Hoo man: [C: 032] Update Wikibase: Fix SpecialEntityData and enhance populateSitesTable [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182835 (owner: 10Hoo man) [17:21:21] (03CR) 10Hoo man: [C: 032] Update Wikibase: Fix SpecialEntityData and enhance populateSitesTable [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182833 (owner: 10Hoo man) [17:24:47] (03Merged) 10jenkins-bot: Update Wikibase: Fix SpecialEntityData and enhance populateSitesTable [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/182835 (owner: 10Hoo man) [17:24:49] (03Merged) 10jenkins-bot: Update Wikibase: Fix SpecialEntityData and enhance populateSitesTable [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/182833 (owner: 10Hoo man) [18:20:45] Tpt: aahhh :D [18:20:55] Please tell me about such dependencies [18:21:10] hoo: I've completly forgotten :-( [18:21:51] * Tpt should really have tought about it [18:23:04] as very few pages are affected it isn't urgent [18:35:20] * hoo eyes aude [18:36:09] :) [18:36:46] aude: Did you see the things that Tpt and I mentioned above [18:37:00] https://gerrit.wikimedia.org/r/#/q/I10890f906bafa45be452e9108bec2cb09997d144,n,z [18:40:27] no [18:40:55] i saw those mentioned in the config patch [18:41:28] Really? [18:42:16] or somewhere [18:42:41] I totally forgot about that :S [18:42:57] * aude can't remember where [18:43:08] mh [18:43:23] Will you be around during tonight's SWAT? [18:43:24] i assume we are doing swat again tonight [18:43:29] maybe [18:43:46] maybe not [18:43:49] :S [18:44:08] Would really like to spend the evening with friends... [18:44:20] :/ [18:44:29] Thus, have to leave at 8-something [18:44:46] But if you have other plans, I don't want to ruin that [18:45:08] like sleep? :) [18:45:15] idk, i might be around [18:45:17] Tpt: Do you plan to stay up long? [18:45:29] aude: What's that sleep thing and where can I buy it? :D [18:45:50] is it just https://gerrit.wikimedia.org/r/#/c/182850/ ? [18:45:59] aude: Oh, another fun thing: I changed testwikidata's and test2wiki's sites table to https [18:46:06] :) [18:46:12] Yep, and same for wmf12 [18:46:34] It works fine... except for one thing: Links in sitelinklist are https then [18:46:44] no longer proto-relative [18:46:47] where is the messages patch for wmf12? [18:46:48] not in Wikipedia or so [18:47:14] hoo: I think I'll deconnect in a few minutes [18:47:24] https://gerrit.wikimedia.org/r/#/c/182859/ [18:47:35] Tpt: Ok, just wanted to ask, that's fine ;) [18:47:46] aude: Seems like Tpt forgot that, [18:47:48] just created it [18:48:10] ok [18:48:41] aude: do you have any opinion on the https stuff? [18:49:01] aah https://en.wikipedia.org/wiki/Help:Contents [18:49:13] ok, will try to stay around until swat [18:51:01] hoo: not sure about the https stuff [18:51:13] yeah :/ [18:51:30] As an absolute workaround we could just patch the ruwikinews entry on wikidata's sites table [18:51:36] ruwikinews is purely https anyway [18:51:57] * aude nods [18:52:46] * aude forgets, are there some places where we don't redirect http to https? [18:52:49] e.g. china? [18:52:58] if i try http, i am redirected [18:53:03] China and Iran are the places where https (mihgt) not work [18:53:10] ok [18:54:29] aude: Away for food [18:54:56] I'll jsut copy the ruwikinews entry from tstwikidata's sites to the real wikidata's sites for now [18:55:02] but that's a very bad workaround [18:55:04] yikes [18:55:28] :/ [19:12:47] aude: Did that now [19:13:36] https://www.wikidata.org/w/index.php?title=Q4115189&diff=186184457&oldid=185871993 [19:18:47] aude: Lydia_WMDE: We could create a forceRelative option in SiteLinksView for this? [19:43:36] hoo|away: back [19:43:43] :) [19:43:47] hoo|away: if that is possible that sounds good [19:43:53] hey sjoerddebruin [19:43:57] Hai [20:20:24] [13Diff] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/pbFBaA [20:20:24] 13Diff/06master 14739bc5e 15Jeroen De Dauw: Update README.md [20:53:38] aude: Ok, we decided to stick with that workaround for now. So only Wikidata itself (I reverted the test wikis to the protocol relative stuff) [20:53:56] Keep that in mind when adding new wikis or something like that [20:54:10] The script overrides existing entries [21:01:00] hoo: ? [21:01:19] overriding is not good [21:01:40] But that's what the script does [21:01:44] make a bug for that? [21:02:23] For what? Not overriding entries? [21:02:32] yeah [21:02:47] we have the entries in 800+ places [21:03:05] suppose override is only for wikidata? [21:03:24] Yeah, I was to lazy to properly update all DBs [21:03:33] Not all wikis yet have sites tables [21:03:44] but I pinged Sean and he'll fix that soon [21:03:46] yeah [21:03:55] we can add sites table :) [21:04:04] if sean wants to, ok [21:04:05] I'd rather have a script that is smarter in some way [21:04:22] We could even have the script scrap information about the wiki by making http requests to it [21:04:36] would be slowwwwww [21:04:47] but could work [21:05:10] That's like 100s maybe (estimated on 200ms each for 1000 wikis) [21:05:13] totally bearable [21:05:20] for a one-off-script [21:05:23] sure [21:06:00] oh, that would be 200s, obviously... but still :P [21:07:42]

:O [21:07:49] We're aware :P [21:07:52] :P [21:07:59]

:O [21:18:06] * Lydia_WMDE hands sjoerddebruin a cookie [21:18:23] But, I have to give permission first!!!! [21:18:34] Stupid Dutch government rules. ;) [21:18:50] lol [21:18:57] * Lydia_WMDE takes the cookie back and eats it [21:19:00] nanananana [21:19:01] :P [21:19:29] But, why this randomness [21:19:42] because [21:19:51] a bit of randomness is good [21:20:23] That's how we write software ;) [21:20:46] lol [21:20:57] shush hoo! :D [21:21:06] don't give away all of the secrets [21:21:07] Oh, that's why it's still saving the previous displayed value every time... [21:21:23] (and the keyboard selecting thing again) [21:26:10] PHID-PROJ-7ocjej2gottz7cikkdc6 [21:26:19] we should put that into the topic for easy c&p [21:26:23] bloody phab... [21:30:53] Lydia_WMDE: hoo: regarding deployments, do you think we are ready to make a new branch this week? [21:31:05] aude: Taking about deployments: https://github.com/wmde/WikidataBuildResources/pull/17 [21:31:10] That hit me hard today [21:31:13] hoo: i see [21:31:21] $ mv .git .git1; rm -rf extensions/Wikibase/; composer update Wikibase/wikibase -o --prefer-dist; mv .git1 .git [21:31:28] that's what I needed to do to get it to work [21:31:33] :/ [21:32:12] Don't think much happened on the UI since last branch, did it? [21:32:26] hoo: new site links ui? [21:32:37] I mean for improving that [21:32:53] not sure [21:37:40] hoo: back now. went out for a brief demonstration against pegida :) [21:38:37] Oh, nice :) [21:38:58] easy enough in berlin... [21:39:09] Nothing like that going on here [21:39:23] We hacked around our sites problem for now [21:39:45]