[05:01:40] <Okki>	 hello
[05:01:50] <Okki>	 Lot of vandalisms from this IP, https://www.wikidata.org/wiki/Special:Contributions/66.87.121.14
[09:42:56] <gh-wmde>	 [13Diff] 15JeroenDeDauw 04deleted 06privateSince at 146567356: 02http://git.io/UKkonw
[10:07:23] <Amir1>	 Hey, is there any kind of log for merges? Abuse filter 32 haven't caught anything since October  
[11:29:11] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "SVG optimization is unrelated and should be done in an other patch, please." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181870 (owner: 10Tpt)
[11:38:56] <GeorgeEdwardC>	 Amir1: Sadly not
[12:53:19] <github-wmde>	 [13WikibaseQueryEngine] 15JeroenDeDauw comment on commit 145e80508: The type it deals with is called `Description`, as defined by the `Ask` library. 02http://git.io/LhK-NA
[12:53:29] <github-wmde>	 [13WikibaseQueryEngine] 15JeroenDeDauw comment on commit 145e80508: yes, good catch 02http://git.io/tipQ8Q
[12:54:48] <github-wmde>	 [13WikibaseQueryEngine] 15JeroenDeDauw comment on commit 141b66dfe: That depends on how you define setter. Do you think the current name is problematic? 02http://git.io/lKfGfg
[12:56:59] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #328 14ffd7a67: ```php... 02http://git.io/KMGQLg
[13:40:54] <multichill>	 Lydia_WMDE: Around? I'm playing around with adding a special page. What version of wikibase are we these days? 0.5?
[13:41:07] <Lydia_WMDE>	 multichill: hey :)
[13:41:12] <Lydia_WMDE>	 yes i think so
[13:42:51] <multichill>	 Made a special page for items with the most sitelinks
[13:43:19] <multichill>	 Based on the standard MediaWiki QueryPage so it should be cached etc...
[13:46:04] <Lydia_WMDE>	 sweet
[13:46:35] <multichill>	 Not looking forward to the rebase :P
[14:06:28] <github-wmde>	 [13WikibaseQueryEngine] 15thiemowmde comment on commit 141b66dfe: It's private, so it doesn't matter much. But it doesn't "add" additional settings, it changes existing ones. 02http://git.io/Az8U3A
[14:09:00] <github-wmde>	 [13WikibaseQueryEngine] 15JeroenDeDauw comment on commit 141b66dfe: Indeed. You can look at it differently as well though: this is the method that takes the options and adds them to the query builder. 02http://git.io/azdHpg
[14:12:31] <github-wmde>	 [13WikibaseQueryEngine] 15thiemowmde comment on commit 145e80508: I know that. `Description` is a horribly generic name for a class, but we can't rename Ask stuff (or can we?). I could live with something like `AskDescriptionMatchFinder`. 02http://git.io/QPRDQQ
[14:17:36] <github-wmde>	 [13WikibaseQueryEngine] 15thiemowmde comment on commit 141b66dfe: True. I would inline it anyway. ;-) Never mind. 02http://git.io/qdQuFQ
[14:38:24] <gh-wmde>	 [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06getSerializations: 02http://git.io/19A_lg
[14:38:24] <gh-wmde>	 13WikibaseDataModel/06getSerializations 14cbf3870 15Thiemo Mättig: Rewrote test
[14:39:35] <gh-wmde>	 [13WikibaseDataModel] 15thiemowmde comment on pull request #328 14cbf3870: Fascinating. Found an actual issue while playing around with this. Thanks. 02http://git.io/sQS5Hg
[14:58:36] <multichill>	 Lydia_WMDE: My wikibase instance is so old, it's still using the php i18n :P
[14:58:46] <Lydia_WMDE>	 multichill: outsch :D
[14:59:49] <github-wmde>	 [13WikibaseQueryEngine] 15JeroenDeDauw pushed 1 new commit to 06matchfinder: 02http://git.io/4so2WQ
[14:59:49] <github-wmde>	 13WikibaseQueryEngine/06matchfinder 146bbe91f 15jeroendedauw: Renamed QueryStoreWithDependencies::newQueryEngine to QueryStoreWithDependencies::newDescriptionMatchFinder
[15:01:33] <github-wmde>	 [13WikibaseQueryEngine] 15JeroenDeDauw comment on commit 145e80508: Could also be `QueryDescriptionMatchFiner`. Then again, I'm not sure this is really needed in this context.... 02http://git.io/BF4Xtg
[15:05:16] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #328 14cbf3870: I fully agree these conversations are making CR not fun at all. My impression is that this originates from you misinterpreting what I say and reaction hostile. For instance here I ask an honest question, to which I do not know the answer. If you think the answer is self evident, then perhaps I'm just being blind. 02http://git.io/HSCcNw
[15:08:25] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #328 14cbf3870: Please pay attention to the questions I asked here. It's a very useful technique to asses the quality of your tests. Even if you think the code is correct, which 'm guessing we both did in this case, it helps you see in which ways the code can regress in the future without the tests catching it. 02http://git.io/SeaX5A
[15:13:12] <gh-wmde>	 [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #328 14cbf3870: This test mirrors (the reverse of) the production code. Hence it is doing a map with a foreach loop. Generally it's better to avoid this. In this case it is not really problematic, though I still advise to use two simple test methods rather than a single more complex one together with a data provider. 02http://git.io/Pog-cw
[15:39:35] <grrrit-wm>	 (03PS4) 10Lydia Pintscher: Use SVG for icons of the other project sidebar beta feature [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181870 (owner: 10Tpt)
[16:14:00] <github-wmde>	 [13WikibaseQueryEngine] 15thiemowmde comment on commit 145e80508: I do. To me `DescriptionMatchFinder` sounds like a "match finder" based on entity descriptions. 02http://git.io/7luYgQ
[17:11:48] <multichill>	 aude: You around? Messing around registering a special page
[17:12:35] <multichill>	 Had an old version where you just put it in the classes. Now SpecialPageFactory is complaining it cant find the class
[17:13:53] <multichill>	 aude: hmm, that didn't work....
[17:19:11] <Reedy>	 multichill: You did add it to the autoloader?
[17:19:52] <multichill>	 Probably not. Where is that beast hiding these days?
[17:20:32] <multichill>	 It's in the @#!$#@$ composer
[17:22:16] <Reedy>	 lol
[17:22:30] <multichill>	 How the hell do I update that in a commit?
[17:26:49] <multichill>	 Reedy: At least now it works again :P
[17:35:20] <sjoerddebruin>	 Hi
[17:35:39] <GeorgeEdwardC>	 Hi
[17:40:35] <Jianhui67>	 Hey
[17:43:02] <GeorgeEdwardC>	 Hi Jianhui67
[17:58:01] <grrrit-wm>	 (03PS1) 10Multichill: Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181902 
[18:01:10] <multichill>	 Lydia_WMDE: Does phpunit also run somewhere automagically?
[18:02:07] <multichill>	 hoi sjoerddebruin, heb me maar eens aan de MediaWiki special pages gewaagd
[18:02:24] <sjoerddebruin>	 Ik zie het
[18:03:19] <multichill>	 Dat was een tijd geleden. Ik moest m'n hele MediaWiki + Wikibase install updaten
[18:03:56] <sjoerddebruin>	 Ik ben weer zoet met tools.wmflabs.org/wikidata-todo/random_item_without_instance.php?run=1&wiki=nlwiki
[18:04:00] <sjoerddebruin>	 Die doet het weer
[18:04:54] <multichill>	 Als dit een beetje lukt zal ik de komende tijd nog wel een paar special pages maken om de handmatige rapportjes te vervangen
[18:05:16] <multichill>	 Fijn dat die het weer doet
[18:48:09] <multichill>	 Lydia_WMDE: I hope the two geodata bugs are now clearer
[18:48:19] <Lydia_WMDE>	 multichill: thanks! :)
[18:48:23] <multichill>	 I would set the one for on wikidata.org to low
[18:48:40] <Lydia_WMDE>	 multichill: re phpunit: i think so but not entirely sure what the current status is. it's a bit of a mess
[18:48:58] <Lydia_WMDE>	 multichill: well people are rightfully complaining about it being hard on wikidata
[18:49:27] <multichill>	 It took me a lot of time to be able to submit this patchset...
[18:49:38] <Lydia_WMDE>	 yeah :/
[18:50:36] <Lydia_WMDE>	 multichill: oh wait. i am confusing this one with the other one i was working on today. ignore me. -.-
[18:50:38] <Lydia_WMDE>	 i should go have food :P
[18:50:46] * multichill just did that
[18:51:31] <Lydia_WMDE>	 laters
[18:51:32] <Lydia_WMDE>	 :)
[18:51:39] <multichill>	 Thanks for adding some people to code review. Didn't know who to add....
[19:02:45] <grrrit-wm>	 (03PS2) 10Multichill: Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181902 
[19:23:32] <grrrit-wm>	 (03PS3) 10Multichill: Implement a special page to show items with the most sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/181902 
[21:26:37] <Lydia_WMDE>	 hmmm uls isn't opening for me
[21:26:46] <Lydia_WMDE>	 can anyone reproduce?
[21:27:06] <Lydia_WMDE>	 (clicking the language at the top of a page does nothing)
[21:36:50] <JohnLewis>	 sjoerddebruin: adding unnecessary information :(
[21:37:08] <sjoerddebruin>	 Why?
[21:37:23] <sjoerddebruin>	 I've landed on a error page with no context.
[21:42:38] <sjoerddebruin>	 multichill: https://www.wikidata.org/w/index.php?title=Wikidata:Database_reports/List_of_properties/Top100&curid=4666752&diff=184147823&oldid=183901596
[21:43:10] <multichill>	 Boom!
[21:43:16] <multichill>	 Haha, dat gaat hard
[21:44:02] <sjoerddebruin>	 Nu de andere Franse nog. ;)
[21:44:21] <multichill>	 You mean BnF identifier (P268)?
[21:44:42] <sjoerddebruin>	 Ja.
[21:45:01] <multichill>	 Just updated https://www.wikidata.org/wiki/User:Multichill/Rijksmuseum_creators_RKD , it finally stopped throwing LUA errors
[21:48:21] <sjoerddebruin>	 Deze zat een week geleden nog in de 500. http://tools.wmflabs.org/autolist/autolist1.html?lang=nl&props=1006&q=claim%5B214%5D%20and%20claim%5B723%5D%20and%20noclaim%5B1006%5D
[21:52:21] <multichill>	 So VIAF and BNL, but not NTA?
[21:52:51] <multichill>	 List seems to be outdated sjoerddebruin
[21:52:58] <multichill>	 Props are showing up
[21:53:18] <sjoerddebruin>	 Yes, Magnus needs to get his shit together
[21:53:40] <multichill>	 The WDQ database seems to be somewhat out of sync
[21:53:52] <sjoerddebruin>	 Your list faults are still showing up in the gender game..
[21:53:53] <multichill>	 Be nice to Magnus! :-)
[21:54:04] <multichill>	 List faults?
[21:54:06] <multichill>	 Crap
[21:54:15] <multichill>	 I'll see if I can fix the remaining ones
[21:54:27] <sjoerddebruin>	 They are fixed.
[21:56:41] <multichill>	 Items I fixed a week ago are still showing up :-(