[00:58:36] (03PS1) 10Hoo man: Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 [07:48:33] (03CR) 10Adrian Lang: Fix minor issues in JSDoc tags (031 comment) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [08:04:20] (03CR) 10Adrian Lang: Replace wfTemplate with TemplateFactory (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 (owner: 10Adrian Lang) [08:04:25] (03PS2) 10Adrian Lang: Replace wfTemplate with TemplateFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 [08:05:00] (03PS3) 10Adrian Lang: Replace wfTemplate with TemplateFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 [08:15:17] (03CR) 10Adrian Lang: Properly validate site ids in SpecialSetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [08:18:02] (03PS10) 10Adrian Lang: Implementing prefetching on top of TermIndex. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [08:22:47] (03PS3) 10Henning Snater: Moved accessing mw config variable out of entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177209 [08:25:16] (03PS1) 10Adrian Lang: Move Template{,Registry} to Wikibase\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180731 [08:25:45] (03CR) 10Adrian Lang: [C: 032] Moved accessing mw config variable out of entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177209 (owner: 10Henning Snater) [08:27:05] (03CR) 10Adrian Lang: [C: 032] Implemented $.util.getDirectionality [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177213 (owner: 10Henning Snater) [08:30:23] (03CR) 10Adrian Lang: [V: 04-1] "Manual rebase needed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179473 (owner: 10Thiemo Mättig (WMDE)) [08:30:26] (03Merged) 10jenkins-bot: Moved accessing mw config variable out of entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177209 (owner: 10Henning Snater) [08:31:39] (03PS2) 10Adrian Lang: Renamed fingerprintview widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180438 (owner: 10Henning Snater) [08:33:04] (03CR) 10Henning Snater: "The module is created and applied to labelview and descriptionview in the preceding change and circumvents having to access ULS directly." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 (owner: 10Henning Snater) [08:35:09] (03CR) 10Adrian Lang: [C: 032] Apply "lang" and "dir" attributes to aliases input boxes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 (owner: 10Henning Snater) [08:36:40] (03CR) 10Adrian Lang: Renamed fingerprintview widgets (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180438 (owner: 10Henning Snater) [08:39:46] (03CR) 10Adrian Lang: Implementing prefetching on top of TermIndex. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [08:44:45] (03PS2) 10Hoo man: Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 [08:45:37] (03CR) 10Hoo man: Properly validate site ids in SpecialSetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [08:46:31] (03CR) 10Hoo man: "Moved into Wikibase\Repo, per Adrian." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [08:49:14] (03PS3) 10Henning Snater: Renamed fingerprintview widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180438 [08:49:18] Adrian_WMDE: Merging that would be appreciated [08:49:21] we want to backport ath today [08:49:24] * that [08:49:31] Yeah [08:50:38] (03CR) 10Adrian Lang: Properly validate site ids in SpecialSetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [08:50:42] :P [08:50:59] will amend [08:51:54] (03PS3) 10Hoo man: Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 [08:52:18] (03CR) 10Adrian Lang: [C: 032] Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [08:52:20] (03CR) 10Hoo man: Properly validate site ids in SpecialSetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [08:52:44] (03CR) 10Hoo man: "Fixed @covers (per Adrian)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [08:54:40] thanks :) [08:57:15] (03Merged) 10jenkins-bot: Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [09:00:38] (03CR) 10Adrian Lang: Implementing prefetching on top of TermIndex. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [09:01:45] (03PS3) 10Thiemo Mättig (WMDE): Implemented $.util.getDirectionality [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177213 (owner: 10Henning Snater) [09:08:16] (03PS3) 10Thiemo Mättig (WMDE): Apply "lang" and "dir" attributes to aliases input boxes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 (owner: 10Henning Snater) [09:12:54] (03PS1) 10Thiemo Mättig (WMDE): getDirectionality may return undefined [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180737 [09:18:10] (03CR) 10Adrian Lang: Implementing prefetching on top of TermIndex. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [09:20:54] (03CR) 10Adrian Lang: Implementing prefetching on top of TermIndex. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [09:23:37] (03PS1) 10Adrian Lang: Factor out EntityTermLookupBase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180739 [09:27:12] (03CR) 10jenkins-bot: [V: 04-1] Factor out EntityTermLookupBase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180739 (owner: 10Adrian Lang) [09:31:41] (03CR) 10Daniel Kinzler: Implementing prefetching on top of TermIndex. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [09:40:46] Lydia_WMDE: Hi Lydia, Andreas vom Wikidata Quality Team hier. Ich habe heute Nacht um 1:06 von Anja und dir Einladungen zu Hangouts bekommen, die ich schlafenderweise nicht mitbekommen habe. Wenn es wichtig war: Gerne jetzt jederzeit nochmal, ansonsten schöne Weihnachtsfeier :) [10:05:11] rhydon: moin! Ich nehme an, Lydia ist noch auf dem Weg ins Büro. Ich hab keine Einladung erhalten, und auch nix im Kalender... [10:10:50] rhydon: hey [10:10:56] sorry ich glaube das war ich. hab mich verklickt [10:11:01] war nicht wichtig [10:11:03] :) [10:11:07] keine sorge [10:14:28] Lydia_WMDE: na dann ist ja gut [10:15:26] (03PS4) 10Tobias Gritschacher: New Wikidata Build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 [10:15:48] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 (owner: 10Tobias Gritschacher) [10:20:33] :) [10:36:28] (03PS5) 10Tobias Gritschacher: New Wikidata Build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 [10:36:44] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 (owner: 10Tobias Gritschacher) [10:40:24] oh noes, we are failing in the structure tests? [10:40:48] or can't find files? [10:41:23] hey [10:41:29] hi [10:41:43] aude Tobi_WMDE_SW_NA I have enabled the mw/core 'structure' tests on all extensions [10:41:48] that checks for resource loader / autoloader [10:42:04] so bunch of extensions are broken / need fixing :-( [10:42:06] i assume that is why jenkins disapproves but not sure [10:42:21] (03PS6) 10Tobias Gritschacher: New Wikidata Build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 [10:42:31] yeah [10:42:38] locally, i see stuff about visual editor, secure poll and other extensions i have enabled [10:42:39] one of the structure test invokes the resourceloader [10:44:35] we have fixed MobileFrontend and Flow related extensions already [10:44:38] moaaar to come :-( [10:44:40] ok [10:44:49] * aude pulls all the extensions [10:45:38] just having wikidata yields: [10:45:39] The module 'wikibase' required by 'wikibase.datamodel.__namespace' must exist [10:45:39] Failed asserting that an array contains 'wikibase'. [10:59:04] [13WikibaseDataModel] 15thiemowmde created 06getSerializations (+1 new commit): 02http://git.io/BX2Maw [10:59:04] 13WikibaseDataModel/06getSerializations 14003fcd6 15Thiemo Mättig: Add ItemIdSet::getSerializations [10:59:27] [13WikibaseDataModel] 15thiemowmde opened pull request #328: Add ItemIdSet::getSerializations (06master...06getSerializations) 02http://git.io/wHc2JA [11:01:00] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06unserlialize from 14139993d to 140180f5c: 02http://git.io/5_4D9A [11:01:00] 13WikibaseDataModel/06unserlialize 140180f5c 15Thiemo Mättig: Remove misleading return doc [11:01:22] wmde/WikibaseDataModel/getSerializations/003fcd6 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/44440241 [11:03:39] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 142da9f94 to 143770869: 02http://git.io/uH6jlQ [11:03:39] 13WikibaseDataModel/06emptyFingerprint 143770869 15Thiemo Mättig: Allow constructing empty Fingerprint [11:07:56] DanielK_WMDE: hier hatte lydia das bild hochgeladen.. [11:07:57] https://phabricator.wikimedia.org/T75863 [11:08:07] I'll add the other part [11:09:40] (03PS3) 10Thiemo Mättig (WMDE): Make stuff in SpecialSetSiteLink private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178530 [11:11:32] (03PS1) 10Thiemo Mättig (WMDE): Rework and clean up badge related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180760 [11:12:31] (03PS1) 10Thiemo Mättig (WMDE): Refactoring of ChangeOpSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180762 [11:15:07] Tobi_WMDE_SW: i am trying to make a build [11:15:13] just see if the results are differnet [11:15:27] (03PS1) 10Aude: Wikidata build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180763 [11:15:37] locally, don't see wikibase failures for "resources" [11:15:43] only other stuff [11:15:54] aude: my last patchset worked [11:15:57] (03CR) 10jenkins-bot: [V: 04-1] Refactoring of ChangeOpSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180762 (owner: 10Thiemo Mättig (WMDE)) [11:15:59] oh ok [11:16:10] what did you do? [11:16:16] the problem was that I've copied the .gitignore from BuildResources which is wrong [11:16:19] oh [11:16:29] it leaves out /extensions/ and /vendor/ [11:16:37] so it did not include new resources files [11:16:46] i see [11:17:01] let's see, we can fix that [11:17:14] (03Abandoned) 10Aude: Wikidata build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180763 (owner: 10Aude) [11:18:27] https://github.com/wmde/WikidataBuildResources/pull/16 [11:18:27] [13WikidataBuildResources] 15filbertkm created 06gitignore (+1 new commit): 02http://git.io/qfpHWg [11:18:27] 13WikidataBuildResources/06gitignore 14a8164d3 15aude: Update gitignore, don't ignore extensions and vendor [11:18:37] [13WikidataBuildResources] 15filbertkm opened pull request #16: Update gitignore, don't ignore extensions and vendor (06master...06gitignore) 02http://git.io/lCWu2A [11:20:58] (03PS4) 10Thiemo Mättig (WMDE): Drop duplicate code in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178530 [11:31:22] (03PS6) 10Thiemo Mättig (WMDE): Rework WikibaseRepo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179473 [11:49:15] [13WikidataBuildResources] 15tobijat closed pull request #16: Update gitignore, don't ignore extensions and vendor (06master...06gitignore) 02http://git.io/lCWu2A [11:49:33] [13WikidataBuildResources] 15tobijat 04deleted 06gitignore at 14a8164d3: 02http://git.io/I9V3gA [11:56:39] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 (owner: 10Tobias Gritschacher) [11:58:41] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/12/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 (owner: 10Tobias Gritschacher) [12:02:26] (03PS1) 10Henning Snater: Added "encapsulate" option to TemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180769 [12:15:12] (03PS1) 10Thiemo Mättig (WMDE): Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 [12:27:37] (03PS2) 10Thiemo Mättig (WMDE): Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 [12:30:57] (03CR) 10jenkins-bot: [V: 04-1] Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 (owner: 10Thiemo Mättig (WMDE)) [12:31:55] Hi, I've been previously using Freebase and am now switching to Wikidata. [12:32:41] Is it right that the experimental WikidatQuery API is curently the only way to make complex queries? [12:35:33] brackcurly: yes [12:37:08] Is this completely independent or will this maybe implemented in future versions of the official API? [12:38:41] we are currently investigating options for the official querying functionality. the api might or might not be taken over. we don't know yet. Sorry [12:38:58] we should have clarity on that in january/february [12:39:55] Ok, but there will be something similar implemented in the offical API? [12:40:44] there will be query functionality, yes. if you want to stay up to date you can. let me get two links for you [12:41:05] That would be great, thanks [12:41:07] (03PS2) 10Thiemo Mättig (WMDE): Refactoring of ChangeOpSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180762 [12:41:18] https://www.mediawiki.org/wiki/Wikibase/Indexing and https://phabricator.wikimedia.org/tag/wikidata-query-service/ [12:43:31] (03CR) 10jenkins-bot: [V: 04-1] Refactoring of ChangeOpSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180762 (owner: 10Thiemo Mättig (WMDE)) [12:45:08] (03PS3) 10Thiemo Mättig (WMDE): Refactoring of ChangeOpSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180762 [12:47:13] (03CR) 10jenkins-bot: [V: 04-1] Refactoring of ChangeOpSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180762 (owner: 10Thiemo Mättig (WMDE)) [12:48:44] (03PS3) 10Thiemo Mättig (WMDE): Make $entityType in TermSqlIndex optional [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180770 [12:52:07] (03PS4) 10Thiemo Mättig (WMDE): Refactoring of ChangeOpSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180762 [14:33:54] aude: ping [15:29:57] hoo: pong [15:30:17] Guess you saw my mail etc. [15:30:21] yes [15:30:35] https://www.wikidata.org/wiki/Special:SetSiteLink/Q1035954/bnwiktionary [15:30:39] needs to be removed [15:30:40] would like to get patch for item / property creation in also [15:30:42] yeah [15:30:42] but not sure how [15:30:59] unsetting site links with the special page is still broken [15:31:03] will probably have a follow up to make it nicer but not in the next 30 minutes [15:31:12] I think the change for that is blocked on the missing tests [15:31:23] which? [15:31:25] ok... so late SWAT? [15:31:56] https://gerrit.wikimedia.org/r/#/c/159096/ [15:32:15] mh... I can find the change were that sitelink was added and undo maybe [15:32:16] oh [15:32:27] * where [15:33:10] i think get your patch in the swat, then [15:33:30] need bugs / put in sprint what else we need to do [15:33:33] for this [15:33:40] well, "for this" [15:33:48] for the invalid data stuff we're done [15:33:55] (despite of deploy) [15:35:36] Ok, fixed the item: https://www.wikidata.org/w/index.php?title=Q1035954&diff=182022905&oldid=172772670 [15:35:43] All links to invalid sites gone now :) [15:36:15] ok [15:36:20] (03PS6) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 [15:36:31] came up with a solution [15:36:38] idk if it's good enough [15:37:21] 12:20, December 18, 2014: 127.0.0.1 (Talk | block) triggered filter 1, performing the action "edit" on Special:NewItem. Actions taken: Disallow, Tag; Filter description: he sucks! (details | examine) [15:37:30] is what the entries look like [15:38:57] aude: Not a fan of how you assume "New" . $entityType == SpecialPageName [15:39:10] better idea? [15:39:40] We don't have a lookup service for that, do we? [15:39:48] entity types -> special pages [15:39:53] doubt it [15:39:56] 99.9% no [15:40:01] ok, then should be ok [15:40:02] would love it to be nicer [15:40:14] but not happening tonight [15:40:48] * aude needs to eat lunch / go home [15:41:50] aude: Mh... still yikes [15:41:57] ? [15:42:07] I'm not a fan of magic values [15:42:30] especially as NewFoo can be a valid entity id [15:42:31] better suggestion? [15:42:47] not for the entity types we have now [15:42:52] Can we do something that for sure does an invalid title [15:42:54] theoretically yes [15:43:09] it could be blacklist as a title? [15:43:15] i mean as an entity id [15:43:27] yeah [15:43:32] i think the blacklist got removed, but maybe we can have it [15:43:40] no, it didn't [15:43:43] oh [15:43:44] but I though about doing it [15:43:50] + t [15:44:19] * aude thinks this is better than "/" or "#" [15:44:27] not ideal though [15:44:35] having to do this at all is not ideal [15:45:11] (03CR) 10Hoo man: [C: 031] "Ok with this (untested). Could someone else have a look, please?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [15:45:18] would like a better solution for users of the hook [15:45:20] Would like Daniel to have a look [15:45:24] agree [15:45:33] not totally urgent [15:45:49] maybe by swat late would be nice [15:45:58] yeah [15:46:12] I can take that one, don't need to get up tomorrow [15:48:06] ok [15:48:17] * aude might be awake [15:48:59] (03CR) 10Adrian Lang: Implementing prefetching on top of TermIndex. (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [15:49:22] later [15:49:29] cu :) [15:52:23] (03CR) 10Adrian Lang: Implementing prefetching on top of TermIndex. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 (owner: 10Daniel Kinzler) [15:53:15] (03PS2) 10Adrian Lang: Factor out EntityTermLookupBase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180739 [15:58:40] (03CR) 10Adrian Lang: [C: 032] Renamed fingerprintview widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180438 (owner: 10Henning Snater) [16:01:25] (03Merged) 10jenkins-bot: Renamed fingerprintview widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180438 (owner: 10Henning Snater) [16:39:37] (03PS1) 10Henning Snater: Fixed $.ui.closeable QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180809 [16:39:39] (03PS1) 10Henning Snater: sitelinkview: Fixed assumption about rankselector being initialized [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180810 [17:31:50] (03PS5) 10Thiemo Mättig (WMDE): Refactoring of ChangeOpSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180762 [17:53:46] [13WikibaseDataModel] 15thiemowmde created 06itemConstruct (+1 new commit): 02http://git.io/yTg8jw [17:53:46] 13WikibaseDataModel/06itemConstruct 141854dc7 15Thiemo Mättig: Optional Item constructor parameters [17:56:10] Lydia_WMDE: we created https://www.wikidata.org/wiki/Wikidata_talk:WikiProject_Freebase for all question on Freebase => Wikidata. Can you give this lik on the google group? Thanks! [17:57:05] [13WikibaseDataModel] 15thiemowmde opened pull request #329: Optional Item constructor parameters (06master...06itemConstruct) 02http://git.io/mn3Xyg [17:57:20] wmde/WikibaseDataModel/itemConstruct/1854dc7 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/44485161 [18:02:34] Harmonia_Amanda: hey :) i wanted to give it one or two more days for people to start filling up the page before i do that [18:02:37] is that ok? [18:02:54] to let you all get organized a bit before the influx [18:03:02] otoh i can also do it now if you want [18:03:03] Lydia_WMDE: no problem, I just wented to be sure you saw that it existed:) [18:03:09] yeah i saw :) [18:03:10] thx [18:10:12] [13Diff] 15thiemowmde 04deleted 06killacat at 144c3b6c1: 02https://github.com/wmde/Diff/commit/4c3b6c1 [18:41:38] (03CR) 10Daniel Kinzler: [C: 032] "Took me a while to understand what's going on. Nice :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [18:45:00] thanks DanielK_WMDE [18:46:19] (03Merged) 10jenkins-bot: Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [18:53:17] wikimedia/mediawiki-extensions-Wikibase/master/60491b4 : jenkins-bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44491353 [18:53:45] uh [18:53:56] oh, I know why [18:54:08] will fix [18:54:22] (03PS1) 10Daniel Kinzler: Add comment explaining title hack for new items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180854 [18:55:30] (03PS2) 10Hoo man: Add comment explaining title hack for new items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180854 (owner: 10Daniel Kinzler) [18:55:37] (03CR) 10Hoo man: [C: 032] Add comment explaining title hack for new items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180854 (owner: 10Daniel Kinzler) [18:58:19] arg [18:58:28] that's why we have non-english tests on travis [18:58:35] yep :) [19:00:06] (03Merged) 10jenkins-bot: Add comment explaining title hack for new items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180854 (owner: 10Daniel Kinzler) [19:05:45] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fixed $.ui.closeable QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180809 (owner: 10Henning Snater) [19:07:14] (03PS2) 10Thiemo Mättig (WMDE): sitelinkview: Fixed assumption about badgeselector being initialized [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180810 (owner: 10Henning Snater) [19:07:20] (03CR) 10Thiemo Mättig (WMDE): [C: 032] sitelinkview: Fixed assumption about badgeselector being initialized [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180810 (owner: 10Henning Snater) [19:10:55] (03Merged) 10jenkins-bot: Fixed $.ui.closeable QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180809 (owner: 10Henning Snater) [19:12:15] (03Merged) 10jenkins-bot: sitelinkview: Fixed assumption about badgeselector being initialized [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180810 (owner: 10Henning Snater) [19:13:11] (03PS1) 10Hoo man: LinkBeginHookHandlerTest: Improve test for new entity special page links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180862 [19:13:20] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Discussed with Daniel. The idea is good and the two settings (length and duration) are fine. But currently this is a draft. It misses docu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179914 (owner: 10Daniel Kinzler) [19:13:23] became a bit of a lengthy change [19:13:29] but also improves coverage :) [19:13:30] wikimedia/mediawiki-extensions-Wikibase/master/c46507d : daniel The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44492681 [19:15:05] (03PS2) 10Hoo man: LinkBeginHookHandlerTest: Improve test for new entity special page links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180862 [19:17:43] (03CR) 10Aude: LinkBeginHookHandlerTest: Improve test for new entity special page links (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180862 (owner: 10Hoo man) [19:18:47] aude: How should that not work? [19:19:01] We always link NS_MAIN [19:19:15] which is defined as an entity namespace [19:19:27] and that's all LinkBeginHookHandler checks for [19:20:07] (03CR) 10Aude: LinkBeginHookHandlerTest: Improve test for new entity special page links (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180862 (owner: 10Hoo man) [19:20:41] hoo: if additional content mappings are defined? [19:20:45] e.g. with the hook [19:20:58] aude: I don't care for the mapping, I just take the array keys [19:21:05] which are entity types [19:21:16] hm [19:21:26] ah, i see [19:22:03] wikimedia/mediawiki-extensions-Wikibase/master/dc466aa : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44493947 [19:22:05] wow many people here [19:22:26] even more than on #swig [19:26:34] (03CR) 10Aude: [C: 04-1] "with arabic, still fails :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180862 (owner: 10Hoo man) [19:27:15] doh [19:28:03] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move Template{,Registry} to Wikibase\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180731 (owner: 10Adrian Lang) [19:28:45] works for other languages like hebrew though [19:28:57] yeah, not an rtl issue [19:29:04] just ar has spaces in the special page name [19:29:35] yep [19:30:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Replace wfTemplate with TemplateFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 (owner: 10Adrian Lang) [19:30:14] (03CR) 10jenkins-bot: [V: 04-1] Replace wfTemplate with TemplateFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 (owner: 10Adrian Lang) [19:30:29] (03PS2) 10Thiemo Mättig (WMDE): Move Template{,Registry} to Wikibase\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180731 (owner: 10Adrian Lang) [19:30:35] (03CR) 10jenkins-bot: [V: 04-1] Move Template{,Registry} to Wikibase\Template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180731 (owner: 10Adrian Lang) [19:32:10] wikimedia/mediawiki-extensions-Wikibase/master/7119587 : jenkins-bot The build is still failing. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44494095 [19:32:21] (03PS3) 10Hoo man: LinkBeginHookHandlerTest: Improve test for new entity special page links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180862 [19:32:29] aude: there you go ;) [19:32:51] ok [19:35:13] works for me [19:35:23] shall wait for jenkins [19:35:48] I tested ru and en for the old version [19:35:57] new one also works for ar (at least for me :D) [19:36:33] (03CR) 10Aude: [C: 032] LinkBeginHookHandlerTest: Improve test for new entity special page links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180862 (owner: 10Hoo man) [19:36:39] there [19:36:53] :) [19:36:56] shall prepare backports now [19:37:41] And I'm going for food [19:37:45] grrr [19:37:48] uh? [19:37:53] https://gerrit.wikimedia.org/r/#/c/180689/ is not a clean cherry pick :( [19:38:03] shall do manually [19:38:11] oh :/ [19:38:30] can review, when back [19:38:34] ok [19:38:41] it's probably just a use statement or such changed [19:40:12] (03Merged) 10jenkins-bot: LinkBeginHookHandlerTest: Improve test for new entity special page links [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180862 (owner: 10Hoo man) [19:56:50] (03CR) 10Aude: Properly validate site ids in SpecialSetSiteLink (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180689 (owner: 10Hoo man) [19:59:21] wikimedia/mediawiki-extensions-Wikibase/master/26e1f98 : jenkins-bot The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44497263 [19:59:41] aude: Oh, uh [19:59:50] will do a follow-up [20:00:06] (03PS1) 10Aude: Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180871 [20:00:14] hoo: already doing [20:00:18] oh, ok [20:00:58] (03PS1) 10Aude: Re-add null check in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180872 [20:01:00] will have to fix on master and the other branch also [20:01:26] (03PS1) 10Aude: Re-add null check in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180873 [20:02:00] (03CR) 10Hoo man: [C: 032] Re-add null check in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180873 (owner: 10Aude) [20:03:08] (03PS1) 10Aude: Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180874 [20:03:10] (03PS1) 10Aude: Re-add null check in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180875 [20:04:23] ugh, the LinkBegin patch is not a nice cherry pick [20:05:12] not surprised [20:06:38] the hook handler doesn't even exist int he branch :o [20:07:00] see what i can do to add it in anyway int he right spot [20:12:57] (03Merged) 10jenkins-bot: Re-add null check in SpecialSetSiteLink [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180873 (owner: 10Aude) [20:18:24] (03PS1) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180877 [20:21:17] (03PS1) 10Aude: Return short in LinkBeginHookHandler if not entity namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180878 [20:22:55] (03CR) 10Aude: Fix EditFilter bug with creating items and properties (031 comment) [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180877 (owner: 10Aude) [20:23:10] (03CR) 10Aude: "manually verified" [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180877 (owner: 10Aude) [20:24:04] (03CR) 10Hoo man: [C: 032] "Also saves resources :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180878 (owner: 10Aude) [20:29:57] sjoerddebruin: any news from magnus? [20:30:08] Didn't speak him. [20:38:34] (03Merged) 10jenkins-bot: Return short in LinkBeginHookHandler if not entity namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180878 (owner: 10Aude) [20:50:28] sjoerddebruin: it would be nice if you / others can help test http://wdq-lb.wmflabs.org/stats - specifically to see if the results are inconsitent request to request [20:50:32] since it doesn’t share a common database... [20:51:26] The content changes every time I do a refresh [20:51:36] sjoerddebruin: right, /stats changes, but actual queries? [20:51:38] 2014-12-18T20:50:20Z and 2014-11-03T00:00:00Z [20:52:00] Alos queries. [20:52:01] sjoerddebruin: I guess one of them is just catching up maybe. one insntance is new, I just added it (like 10min back) [20:52:06] Also*. [20:57:08] (03CR) 10Aude: [C: 032] Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180874 (owner: 10Aude) [20:57:18] (03CR) 10Aude: [C: 032] Re-add null check in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180875 (owner: 10Aude) [20:57:34] (03CR) 10Aude: [C: 032] Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180871 (owner: 10Aude) [20:57:39] (03CR) 10Aude: [C: 032] Re-add null check in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180872 (owner: 10Aude) [21:01:26] hoo: do we want to also put https://gerrit.wikimedia.org/r/#/c/180818/ in swat? [21:01:31] * aude would prefer monday [21:01:46] when i am around more to monitor memcached etc. [21:02:02] We didn't have any problem with ruwiki, yet [21:02:05] but as you prefer [21:02:06] yeah, true [21:02:11] * hoo ok with pushing today [21:02:18] (03Merged) 10jenkins-bot: Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180874 (owner: 10Aude) [21:02:33] today is ok then [21:05:01] (03Merged) 10jenkins-bot: Re-add null check in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180875 (owner: 10Aude) [21:05:03] (03Merged) 10jenkins-bot: Properly validate site ids in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180871 (owner: 10Aude) [21:05:06] (03Merged) 10jenkins-bot: Re-add null check in SpecialSetSiteLink [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180872 (owner: 10Aude) [21:28:39] (03PS1) 10Aude: Update Wikidata, fix for Special:SetSiteLink [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180893 [21:52:17] sjoerddebruin: fixed the big inconsistency :) [21:52:27] :D [21:52:38] Can you fix my acient tv? [21:52:50] sjoerddebruin: heh, probably not [21:53:05] sjoerddebruin: can you do a few queries and see if they do alright and consistently? [21:53:09] I’m considering switching them over [21:53:33] Looks good to me [21:53:37] multichill: ^ switching to wdq-lb.wmflabs.org (I’ll munge the DNS). load balanced across two hosts + autorestarted properly. [21:53:49] nice! [21:54:04] multichill: if you can do a few test queries, and repeat them 4-5 times to see if they generate expected and consistent results... [21:55:56] maybe I should do it tomorrow, during Europe ‘awakey’ hours [21:56:51] aude: need another hint about site table, can you help? [21:59:12] (03CR) 10Springle: "Does this somehow call wfWaitForSlaves() ? If not, it should, before we run it in production." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176373 (owner: 10Daniel Kinzler) [22:07:08] YuviPanda: Some random tests all seem to work and give the same results [22:08:25] multichill: alright. I’m running some httperf against it, and think I’ll switch it over when I wake up [22:08:53] Oh, I thought you just changed it already [22:09:02] Than I didn't test in the right location :S [22:09:20] multichill: haha, yeah, you didn’t. have to test wdq-lb.wmflabs.org [22:09:30] Some other day, time to sleep [22:09:37] multichill: night! [22:10:55] nn [22:16:31] channel, I am struggling to connect my local wb repo to my local wp client. anybody knows how to do that? [22:17:39] despens: What exactly is not working for you? [22:17:48] Did you yet add your site table entries? [22:18:03] hoo: i did put my own wiki into the sites table [22:18:54] hoo: but when i want to add a language link from the repo, it doesn't offer me to chose a site, and it doesn't react when i type in the language [22:18:57] So, can you yet add sitelinks to it? [22:19:27] Ok, did you put your local site into one of the sitelink groups you have configured for your repo to show? [22:19:59] hoo: no, how would i do that? [22:20:35] $wgWBRepoSettings['siteLinkGroups'] = array( 'wikipedia', 'wikivoyage', 'special' ); [22:20:51] whatever your site's group is, should be there [22:20:53] hoo: in LocalSettings.php? [22:20:59] yeah [22:22:04] or jsut make your site a "wikipedia" as that's the default [22:23:49] hoo: ok, now i see "(0 entries)" with an 'edit' link, but nothing happens when i click it. [22:24:01] despens: Ok [22:24:05] hoo: the box below says "Links to pages are already set for all known sites." [22:24:20] In that case, try purging your page + hard refreshing [22:24:28] if that doesn't work, double check your site group [22:25:48] hoo: great, the interface shows up! [22:26:49] hoo: now the 'page_path' in the serialized 'site_data' must point to something like //10.0.3.122/w/$1 [22:27:36] hoo: my mediawiki runs on this host, and articles would be http://10.0.3.122/w/Article [22:28:15] hoo: but the repo doesn't seem to find any of the pages that exist there [22:29:12] hoo: "The specified article could not be found on the corresponding site." [22:32:20] hoo: my sites table entry looks like this http://dpaste.com/3A7K9JS [22:44:08] despens: I'm back for you in ~15 minutes [22:44:10] sorry [22:44:21] hoo; thnx [23:23:53] (03CR) 10Aude: [C: 032] Update Wikidata, fix for Special:SetSiteLink [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180893 (owner: 10Aude) [23:27:14] (03Merged) 10jenkins-bot: Update Wikidata, fix for Special:SetSiteLink [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180893 (owner: 10Aude) [23:28:17] despens: Ok, is your API accessible under that path? [23:28:28] Wikibase only cares for api.php [23:29:38] hoo: my api is at http://10.0.3.122/api.php [23:29:48] yeah, that's the problem [23:29:58] wikibase will use /w/api.php [23:30:16] hoo: which of the two array elements point to the api.php? [23:30:35] file path AFAIR [23:31:12] hoo: should be api path probably ;) ok, so in my case that is just the base domain ... one sec ... [23:34:09] (03CR) 10Aude: [C: 032] "manually verified this again" [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180877 (owner: 10Aude) [23:34:35] hoo: my new sites table: http://dpaste.com/28D7NG1 [23:35:08] hoo: doesn't help though. is there a log anywhere showing the repo's attempt to connect? [23:37:03] uh, guess you could make that logging [23:37:18] give me a bit [23:37:22] despens: did you look at the javascript console? [23:37:29] aude: that's server side [23:37:35] ok [23:37:52] (03Merged) 10jenkins-bot: Fix EditFilter bug with creating items and properties [extensions/Wikibase] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180877 (owner: 10Aude) [23:38:37] wfDebugLog( "MediaWikiSite", [23:38:46] so "MediaWikiSite" is the debug log group [23:39:27] the js console shows successfull calls to api.php [23:40:04] but you can't save and it tells you something about the remote ... site [23:41:17] ? [23:42:24] hoo: the repo requests http://10.0.3.122/w/api.php?callback=jQuery111109235102639506397_1418945875356&search=Testor&action=opensearch&_=1418945875360 [23:43:02] hoo: and the reply is a 302 with the right location: Location:"http://10.0.3.122/w/Testor" [23:43:22] force reload [23:43:25] and maybe purge [23:43:31] hoo: that url returns a 304, not modified [23:43:43] and that's not the server side part [23:44:28] (03PS1) 10Aude: Update Wikidata, fixes for Special:NewItem, NewProperty, SetSiteLink [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180998 [23:45:03] hoo: the post request returns a 200: json object sainy "no-external-page" "The external client site 'artbase' did not provide page information for page 'Testor'." [23:45:51] Do you have an objectcache setup? [23:46:02] Possibly the old sites information is still there [23:46:15] like memcached [23:46:57] hoo: i use apcu [23:47:21] hoo: was recommended during install :) [23:47:27] can you restart/ flush that wihtout to much trouble? [23:47:41] hoo: i am not familiar with it, but will try, one sec [23:48:19] (03CR) 10Aude: [C: 032] Update Wikidata, fixes for Special:NewItem, NewProperty, SetSiteLink [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180998 (owner: 10Aude) [23:49:02] hoo: come on, that did it!! [23:49:17] hoo: thank you! [23:49:35] hoo: should i go without an object cache when using wikibase? [23:49:55] No, just when manually changing stuff restarting it might be a good idea [23:50:08] We use an objectcache as well, for Wikidata ;) [23:50:16] hoo: great [23:51:52] hoo: is there a link between visual editor and wikibase? if i want to embed a claim [23:52:20] no [23:52:45] You could create an own wrapper template and let VE know about that, I guess [23:52:52] but per default we ship nothing like that [23:55:54] (03Merged) 10jenkins-bot: Update Wikidata, fixes for Special:NewItem, NewProperty, SetSiteLink [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180998 (owner: 10Aude) [23:56:55] hoo: do i need the lua extension to embed claims? [23:57:18] You can use {{#property:...}} without it [23:57:31] but if you want to make use of the extended functionality Lua provides, yes [23:58:00] hoo: made it [23:58:04] hoo: nice [23:58:10] \o/ [23:58:37] hoo: \^u^/ [23:58:45] hoo: thank you so much [23:59:05] hoo: will have to look at the lua stuff [23:59:16] hoo: can lua scripts be embedded in a template? [23:59:31] You can use them from templates [23:59:40] but can't directly embed lua code in the templates [23:59:46] needs to go onto a special page