[00:00:09] (03Merged) 10jenkins-bot: Don't cache the TestUser instance in BotEditTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180323 (owner: 10Hoo man) [00:00:18] oh, that was fast [00:00:23] yay :) [00:00:27] oh no, master only :P [00:00:34] * aude is ready to update the build again [00:00:45] oh, but still fast [00:02:49] (03Merged) 10jenkins-bot: Don't cache the TestUser instance in BotEditTest [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180355 (owner: 10Aude) [00:03:15] (03PS3) 10Hoo man: Fix of property label formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 (owner: 10Aude) [00:03:39] (03CR) 10Hoo man: [C: 032] "Good enough as a stop-gap solution" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 (owner: 10Aude) [00:06:52] oh, travis has changed their UI [00:07:13] huh, they have [00:07:16] well, slightly [00:07:26] yeah [00:08:47] (03Merged) 10jenkins-bot: Fix of property label formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 (owner: 10Aude) [00:11:30] (03PS1) 10Aude: Update Wikidata, fix property label formatting and a test [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180359 [00:12:43] mwext-Wikidata-testextension-zend SUCCESS in 10s [00:12:44] what [00:13:13] 00:11:44 OK (15 tests, 30 assertions) [00:13:27] i think i see [00:13:46] wikimedia/mediawiki-extensions-Wikibase/master/8df8da2 : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44274923 [00:13:49] or not [00:14:37] mh :S [00:15:00] I think we can ignore for now, but should investigate [00:15:03] we had this before [00:15:12] somethign were the branch names weren't matching something [00:15:19] mh [00:15:26] this time , not sure [00:15:46] I see it [00:15:48] doh [00:16:00] will hot fix [00:17:37] (03PS1) 10Hoo man: Update Wikidata, fix property label formatting and a test [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180363 [00:17:39] there [00:17:40] no [00:17:43] fuuuuuu [00:17:49] (03CR) 10jenkins-bot: [V: 04-1] Update Wikidata, fix property label formatting and a test [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180363 (owner: 10Hoo man) [00:17:50] missing .gitreview strikes again [00:18:00] aaaah [00:18:38] (03PS2) 10Hoo man: Update Wikidata, fix property label formatting and a test [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180359 (owner: 10Aude) [00:18:56] (03CR) 10jenkins-bot: [V: 04-1] Update Wikidata, fix property label formatting and a test [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180359 (owner: 10Aude) [00:19:20] (03Abandoned) 10Hoo man: Update Wikidata, fix property label formatting and a test [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180363 (owner: 10Hoo man) [00:20:01] doh [00:20:05] we check for that twice [00:20:07] and again https://www.youtube.com/watch?v=_GP5_NQ_LEs [00:21:22] (03PS3) 10Hoo man: Update Wikidata, fix property label formatting and a test [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180359 (owner: 10Aude) [00:21:36] sorry, went offline. What's the mailing list I should subscribe to? [00:22:17] https://lists.wikimedia.org/mailman/listinfo/wikidata-l [00:23:08] there also is https://lists.wikimedia.org/mailman/listinfo/wikidata-tech but the former is better for the type of question you asked [00:23:29] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12c/50bc6d8 : Marius Hoch The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44275119 [00:24:08] hoo: want to +2? [00:25:13] oh, sure [00:25:20] [13WikidataBuildResources] 15mariushoch created 06fixJenkins (+1 new commit): 02http://git.io/P2YXhQ [00:25:20] 13WikidataBuildResources/06fixJenkins 143849539 15Marius Hoch: Fix jenkins job name matching... [00:25:20] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12c/c0d3b19 : aude The build was fixed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44275689 [00:25:29] (03CR) 10Hoo man: [C: 032] Update Wikidata, fix property label formatting and a test [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180359 (owner: 10Aude) [00:26:01] [13WikidataBuildResources] 15mariushoch opened pull request #14: Fix jenkins job name matching (06master...06fixJenkins) 02http://git.io/28aVZQ [00:28:39] [13WikidataBuildResources] 15filbertkm closed pull request #14: Fix jenkins job name matching (06master...06fixJenkins) 02http://git.io/28aVZQ [00:28:47] [13WikidataBuildResources] 15filbertkm 04deleted 06fixJenkins at 143849539: 02http://git.io/BEqnEw [00:31:47] (03Merged) 10jenkins-bot: Update Wikidata, fix property label formatting and a test [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180359 (owner: 10Aude) [00:34:26] * Lydia_WMDE standing by with finger on announcement :P [00:35:43] Lydia_WMDE: Do we have a nice doc. about the json dumps we can point people to? [00:36:22] hoo: https://www.wikidata.org/wiki/Wikidata:Database_download is closest but not great [00:37:00] Oh, mh :/ [00:37:58] Lydia_WMDE: as said, we'll have to fix language fallback for property labels tomorrow [00:38:14] aude: what's broken still there? [00:38:34] it will display in the user's language now [00:38:42] all in the same language [00:38:56] at least on my wiki, i got a mixture of english and german [00:39:18] even when they all had german and my language was german [00:39:33] -.- [00:39:34] ok [00:39:43] let me check on live site quickly [00:39:52] deploying now [00:40:05] probably will be couple more minutes [00:40:08] k [00:40:14] waiting then [00:40:34] just don't want people to have more expectations for language fallback than what is for real [00:41:14] we will backport daniel's patches tomorrow that allow it to work better [00:41:18] yeah totally [00:44:17] hi wikidatans [00:44:33] is there an official demonym yet? [00:45:16] Pharos: all we had so far were horrible ;-) so "wikidata heroes" will do :P [00:45:27] :) [00:49:56] Wikidataniks [00:50:14] Wikid'Artagnans [00:53:25] Lydia_WMDE, maybe you can point me to the right list/ [00:53:46] https://lists.wikimedia.org/mailman/listinfo/wikidata-l [00:53:53] Lydia_WMDE, thank you [00:57:37] Lydia_WMDE: will you be at the mediawiki developer summit? [00:57:53] harej: in SF? no [00:58:04] aude, Daniel and I will be [00:58:10] Excellent. I would like to meet you all. [00:58:28] * aude would like to meet harej ;) [00:59:36] * hoo up for that :) [01:01:42] I'll probably be attending the Tuesday after-party but I'm happy to do another meeting [01:01:58] Lydia_WMDE: deployed [01:02:05] I am interested in meeting the people who do Wikidata itself. I'm interested in developing programs around it. I really think it's the future. [01:02:06] please check (looks good to me) [01:02:14] aude: sweet. looking [01:02:32] aude: Do we need to bump cache epoch? [01:02:35] If not, then broken [01:02:46] * hoo purges [01:02:49] hoo: i don't think so [01:03:11] people just need to purge (should be small number affected) [01:03:14] We need to [01:03:17] ok [01:03:24] after purge stuff looked fine [01:03:24] if you want / think so [01:03:35] Well, not sure [01:04:06] Lydia_WMDE: Do you have an opinion? [01:04:36] considering cache is split by language and all [01:04:39] hoo: dunno. looks fine so far for me [01:04:48] aude: looks as it should \o/ [01:05:00] Ok [01:05:02] * aude clicking random [01:05:05] looks fine [01:05:06] if anyone has problem, let them purge [01:05:11] will send out announcement and ask for feedback on language fallbacks in it [01:05:12] might be the odd item, can be purged [01:05:13] I was checking high traffic items [01:05:18] * aude too [01:05:23] * aude is using spanish now [01:05:26] :D [01:05:30] i used latin [01:05:33] heh [01:05:38] suprisingly much done there [01:05:59] Do we have interface translations into latin? [01:06:23] yeah [01:06:32] :) [01:06:47] Lydia_WMDE: sorry to keep you awake so late [01:07:05] nah [01:07:13] * aude will stick around a little longer, in case more problems [01:07:15] thanks for staying up and fixing things so quickly [01:07:16] :) [01:07:50] sure :) [01:07:58] better than having to revert entirely [01:08:13] harej: If you want to properly set something up, probably best to write us emails to coordinate [01:08:23] I'll need email addresses! [01:09:05] You can find them on https://www.wikimedia.de/wiki/Mitarbeiter [01:09:17] you can also use hoo at online dot de for me [01:10:35] Google Translate translates some of your surnames literally :P [01:10:46] Probably mine :P [01:11:05] But we don't have an English version of that page [01:11:08] at least I'm not aware of one [01:11:32] I'm not sure who you are on this page? [01:11:43] Marius Hoch [01:11:50] the guy at the end of the list w/o image :D [01:11:59] at the end of the list our dept. [01:12:29] Yes, you are now "Marius High" :P [01:12:45] My surname is also a word. [01:14:44] Jacob Hare, my earliest ancestor in America, was from Germany, weirdly enough. I didn't think Hare was a German name? [01:15:22] Not aware of such a German word/ name [01:15:24] but who knows [01:15:31] * hoo doesn't :D [01:17:55] (I say "Germany" but I don't believe it existed as such at the time he left.) [01:18:16] Quite possible [01:18:19] maybe his name was "Herr" or something? [01:18:24] depending on when he emigrated [01:18:33] Sometime in the 17th century. [01:19:00] Pharos: It's entirely possible but we have no evidence of him changing his name. [01:19:08] https://en.wikipedia.org/wiki/Herr_(surname) [01:19:28] Jacob Hare was a Jamestown settler. [01:20:12] if he's Jamestown, I'm sure someone has written a mini-biography of him atleast [01:20:26] There are documents about him, alright. That's why we know he exists! [01:20:40] He made the mistake of being loyal to King George at a time when that was a bad idea. [01:22:07] I don't think back then Herr -> Hare would have even been considered a name change, spelling was a lot more flexible then [01:29:30] Pharos, my dad doesn't know of any documents about him other than in America, where he signed his name Hare. He suggests "Heyer" as an option. [01:31:43] certainly could be [01:32:37] if he had issues with George II, must have been 18th century, not 17th [01:32:58] and so more like an immigrant to Jamestown than a settler [01:33:32] *III [01:34:52] harej: http://www.fgs-project.com/ohio/groups/h/hare-jacob.html ? [01:35:28] Yup [01:35:33] Hares Valley, named for us [01:37:48] was about to mention that :) [02:28:16] Pharos: https://www.houseofnames.com/hare-family-crest/German [02:30:07] #wikidata has become #harechat [02:34:52] as it should! [02:35:20] you have to take those family crest things with a big grain of salt [02:36:01] there are many families with any given surname, and usually only one that is part of nobility with have arms [02:36:35] Right. Probably not the crest of *my* family per se but does give some insight on the origin of the name. [02:38:02] yeah [02:40:02] I guess your father'sfamily hasn't spoken German for like 200 years [02:40:30] that makes them honorary WASPs by this point [02:40:45] We *are* WASPs. [02:41:13] My mother's family is Sicilian but they assimilated something fierce, as was the case with many Italian Americans. [07:53:07] [13WikibaseSerializationJavaScript] 15snaterlicious 04force-pushed 06undeserializablevalue from 14b14964a to 14a8494b3: 02http://git.io/kZYTxQ [07:53:07] 13WikibaseSerializationJavaScript/06undeserializablevalue 14a8494b3 15snaterlicious: Fixed parameter order when instantiating UnUnserializableValue [08:04:55] aude: Y u no merge https://github.com/Wikidata-lib/PropertySuggester-Python/pull/15 ? [08:07:56] (03PS7) 10Henning Snater: Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 [08:08:09] (03PS8) 10Henning Snater: Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 [08:08:12] (03CR) 10jenkins-bot: [V: 04-1] Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [08:16:01] (03CR) 10Adrian Lang: Fix minor issues in JSDoc tags (031 comment) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [08:59:26] (03CR) 10Adrian Lang: [V: 04-1] "Manual rebase needed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178530 (owner: 10Thiemo Mättig (WMDE)) [09:01:26] (03PS1) 10Adrian Lang: Reduce dependency on Title from View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180421 [09:06:05] wow, good news with freebase ! [09:07:29] (03PS1) 10Henning Snater: Removed toolbarcontroller toolbar restrictions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180423 [09:16:38] (03CR) 10Adrian Lang: "Currently, EntityIdFormatters deeply depend on ValueFormatters:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180163 (owner: 10Thiemo Mättig (WMDE)) [09:18:38] DanielK_WMDE: If you're interested ( EntityIdFormatters ): https://gerrit.wikimedia.org/r/180163 [09:21:41] (03PS2) 10Henning Snater: Removed toolbarcontroller toolbar restrictions [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180423 [09:24:02] (03CR) 10Adrian Lang: "Daniel just said that EntityIdFormatter is able to format EntityIdValues, and is also used for that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180163 (owner: 10Thiemo Mättig (WMDE)) [09:26:11] (03PS1) 10Adrian Lang: Fix class documentation for EntityIdHtmlLinkFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180425 [09:50:51] (03CR) 10Daniel Kinzler: "Note that the current EntityIdFormatter is a hybrid that can handle both EntityIds and EntityIdValues. If we want to disentangle this, it " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180163 (owner: 10Thiemo Mättig (WMDE)) [10:16:03] (03PS1) 10Adrian Lang: Introduce EntityIdFormatter interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180431 [10:42:09] (03PS3) 10Aude: Remove unused method param in PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179890 [10:46:02] (03PS1) 10Henning Snater: Renamed fingerprintview widgets [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180438 [11:08:20] Adrian_WMDE: could you also take a look at https://github.com/wmde/ValueView/pull/137 and https://github.com/wmde/ValueView/pull/138? [11:21:56] (03PS1) 10Henning Snater: Removed obsolete caseInsensitive option from highlightSubstring calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180445 [11:34:29] [13ValueView] 15adrianlang comment on pull request #137 146d46f46: I think this should be moved to `search`. `search` has to clear the timeout anyway. 02http://git.io/M3UVbw [11:35:04] [13ValueView] 15adrianlang comment on pull request #137 146d46f46: Would make sense to introduce a `_clearTimeout` which is called from `search`, `_triggerSearch` and `destroy`. 02http://git.io/a_0KtA [11:37:48] [13ValueView] 15adrianlang comment on pull request #137 146d46f46: `this._search === false`, maybe the id can be 0, who knows. 02http://git.io/8P40JQ [11:38:10] [13ValueView] 15adrianlang comment on pull request #137 146d46f46: init to `false`. 02http://git.io/Ugrscg [11:39:57] here comes the gerrit spam... [11:41:32] Looks like you're causing hhvm segfaults since monday [11:42:33] Reedy: Can you point us to a ticket? [11:42:35] Or log? [11:43:04] Its being talked about in #mediawiki-core [11:44:52] thanks [11:49:15] [13ValueView] 15snaterlicious 04force-pushed 06suggesterissearching from 146d46f46 to 147b52b43: 02http://git.io/-g6kVQ [11:49:15] 13ValueView/06suggesterissearching 147b52b43 15snaterlicious: $.ui.suggester: Added isSearching()... [11:49:33] We're the headline on heise now :P [11:51:11] [13ValueView] 15snaterlicious 04force-pushed 06suggesterissearching from 147b52b43 to 144da5759: 02http://git.io/-g6kVQ [11:51:11] 13ValueView/06suggesterissearching 144da5759 15snaterlicious: $.ui.suggester: Added isSearching()... [11:56:15] [13ValueView] 15adrianlang closed pull request #137: $.ui.suggester: Added isSearching() (06master...06suggesterissearching) 02http://git.io/RqSqYw [11:57:41] [13ValueView] 15snaterlicious 04force-pushed 06inputautoexpandforce from 145166b4e to 1444ec6d0: 02http://git.io/0ED90A [11:57:41] 13ValueView/06inputautoexpandforce 1444ec6d0 15snaterlicious: Added force parameter to $.AutoInputExpand.prototype.expand() [12:03:22] (03PS1) 10Adrian Lang: Simplify UserLanguageLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180449 [12:03:40] [13ValueView] 15adrianlang closed pull request #138: Added force parameter to $.AutoInputExpand.prototype.expand() (06master...06inputautoexpandforce) 02http://git.io/rMhyXg [12:31:09] multichill: hey [12:33:05] (03PS1) 10Adrian Lang: Extract UserLanguageLookup interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180450 [12:40:51] Is it possible to mark language fallbacks with CSS? [12:41:03] Would like to know if there is a label in my language. [12:43:51] sjoerddebruin: does this work? https://www.wikidata.org/w/index.php?title=Property_talk:P276&curid=16614571&diff=181768298&oldid=180124202 [12:44:23] Harmonia_Amanda: I hope. [12:44:51] sjoerddebruin: as the template doesn't recognize it, I seriously doubt [12:45:09] According to the template page it should work. [12:45:23] sjoerddebruin: well, we'll see:) [12:46:06] sjoerddebruin: do you know how we can say constraint:type:Qid|relation instance OR subclass ? [12:46:22] Not really [12:46:43] ok, thanks [12:47:47] I use queries for now but it doesn't show on the constraint page (obviously) [13:09:21] aude: You'll be around for the train tonight, right? [13:09:26] yeah [13:09:31] I'll probably as well, but might be that I fall asleep [13:09:34] ok [13:09:57] should be ok, although we have problem again with the edit filter hook [13:10:01] :S [13:10:07] i know what the problem is but [13:10:12] Tomorrow is deadline for the university stuffs [13:10:16] after that I have time again! [13:10:19] not sure the best (least evil) solution [13:10:20] :) [13:10:30] Link? [13:10:52] https://phabricator.wikimedia.org/T78645 [13:10:58] caused by patch in ConfirmEdit [13:11:06] https://gerrit.wikimedia.org/r/#/c/177746/ [13:11:26] it's taking title from request context [13:11:32] assumes it's the target page [13:11:36] tries to get the namespace [13:11:50] when in our case, it's the Special:NewItem [13:12:11] somehow overriding the title to something else (fake or something) seems very evil [13:12:14] and bug prone [13:12:31] seems the wrong thing to do [13:12:48] That again, argh [13:13:15] i am commenting on the patch [13:15:28] at least we have a month to fix this time [13:15:38] Or 3 weeks :P [13:16:12] it goes on test.wikidata tonight [13:16:13] i think [13:16:19] yeah [13:16:22] Will it? [13:16:26] we could revert on the branch [13:16:27] yes [13:16:38] wmf13 goes tonight and then nothing until after new years [13:16:45] Oh, I thought we woudln't branch at all tdoay [13:16:49] we do [13:16:52] according to the schedule [13:17:05] better ask again, the schedule is not really reliable [13:17:08] but still that's awry [13:17:11] i am quite sure [13:17:13] like last year [13:17:34] Reedy: do you know? [13:17:44] do we make a new core branch tonight for test2 / test.wikidata? [13:18:04] if we revert on the branch, i am concerned we will forget about it [13:19:01] oh lovely, gerrit does not like phabricator urls in comments [13:19:23] https://gerrit.wikimedia.org/r/#/c/177746/ [13:19:54] I need to head off... [13:20:06] I guess I'm going to be back later on [13:20:09] Hm, someone is doing a botrun I think. :P http://gyazo.com/02782abe00d720ac3e3492baabab6da9 [13:20:20] hoo: ok [13:22:28] (03PS1) 10Aude: Revert "Fix of property label formatting" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180459 [13:25:35] here comes the spam [13:26:00] (03PS1) 10Aude: Sanitize wikibase-item html formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180461 [13:26:02] (03PS1) 10Aude: Remove unused imports from Lib [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180462 [13:26:04] (03PS1) 10Aude: Extract FormatterLabelLookupFactory [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180463 [13:26:06] (03PS1) 10Aude: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180464 [13:26:08] (03PS1) 10Aude: Inject siteLinkGroups into ItemView [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180465 [13:26:10] (03PS1) 10Aude: Rewrite completely broken EntityView tests [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180466 [13:26:12] (03PS1) 10Aude: Remove the displayStatementsOnProperties setting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180467 [13:26:13] all these needed for the property label patch to go in clean [13:26:14] (03PS1) 10Aude: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180468 [13:33:23] aude: was wondering why Jenkins took time to proceed my patches :-] [13:44:06] heh [13:45:51] (03CR) 10Aude: [C: 032] "have manually verified that this chain of patches is ok" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180459 (owner: 10Aude) [13:49:02] (03Merged) 10jenkins-bot: Revert "Fix of property label formatting" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180459 (owner: 10Aude) [13:53:28] [13WikidataBrowserTests] 15tobijat 04force-pushed 06removeclaimview from 1479a1c7a to 14e1c1997: 02http://git.io/lsS07g [13:53:28] 13WikidataBrowserTests/06removeclaimview 14ba8b647 15snaterlicious: Adjusted selectors as to removal of jQuery.wikibase.claimview [13:53:28] 13WikidataBrowserTests/06removeclaimview 14e1c1997 15Tobias Gritschacher: Adjust rankselector accessors [13:55:52] (03CR) 10Aude: [C: 032] Sanitize wikibase-item html formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180461 (owner: 10Aude) [13:56:07] (03CR) 10Aude: [C: 032] Remove unused imports from Lib [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180462 (owner: 10Aude) [13:56:18] (03CR) 10Aude: [C: 032] Extract FormatterLabelLookupFactory [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180463 (owner: 10Aude) [13:56:29] (03CR) 10Aude: [C: 032] Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180464 (owner: 10Aude) [13:56:39] (03CR) 10Aude: [C: 032] Inject siteLinkGroups into ItemView [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180465 (owner: 10Aude) [13:56:53] (03CR) 10Aude: [C: 032] Rewrite completely broken EntityView tests [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180466 (owner: 10Aude) [13:57:04] (03CR) 10Aude: [C: 032] Remove the displayStatementsOnProperties setting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180467 (owner: 10Aude) [13:57:12] (03CR) 10Aude: [C: 032] Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180468 (owner: 10Aude) [13:57:15] done [13:59:30] (03Merged) 10jenkins-bot: Sanitize wikibase-item html formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180461 (owner: 10Aude) [14:02:45] (03Merged) 10jenkins-bot: Remove unused imports from Lib [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180462 (owner: 10Aude) [14:02:48] (03Merged) 10jenkins-bot: Extract FormatterLabelLookupFactory [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180463 (owner: 10Aude) [14:02:50] (03Merged) 10jenkins-bot: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180464 (owner: 10Aude) [14:03:17] [13WikidataBrowserTests] 15tobijat 04force-pushed 06removeclaimview from 14e1c1997 to 1432e5630: 02http://git.io/lsS07g [14:03:17] 13WikidataBrowserTests/06removeclaimview 1432e5630 15Tobias Gritschacher: Adjust rankselector accessors [14:04:03] (03Merged) 10jenkins-bot: Inject siteLinkGroups into ItemView [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180465 (owner: 10Aude) [14:05:23] (03Merged) 10jenkins-bot: Rewrite completely broken EntityView tests [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180466 (owner: 10Aude) [14:05:45] (03Merged) 10jenkins-bot: Remove the displayStatementsOnProperties setting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180467 (owner: 10Aude) [14:07:57] (03Merged) 10jenkins-bot: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180468 (owner: 10Aude) [14:09:49] (03CR) 10Tobias Gritschacher: [V: 032] "Browsertests are fine with https://github.com/wmde/WikidataBrowserTests/pull/35" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178869 (owner: 10Henning Snater) [14:12:43] [13WikidataBrowserTests] 15tobijat 04force-pushed 06removeclaimview from 1432e5630 to 14cb97e12: 02http://git.io/lsS07g [14:12:43] 13WikidataBrowserTests/06removeclaimview 14cb97e12 15Tobias Gritschacher: Adjust rankselector accessors [14:13:19] [13WikibaseSerializationJavaScript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/NihAVw [14:13:19] 13WikibaseSerializationJavaScript/06master 1418676fd 15Tobi Gritschacher: Merge pull request #12 from wmde/undeserializablevalue... [14:25:09] (03PS1) 10Adrian Lang: Replace wfTemplate with TemplateFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 [14:25:43] [13WikibaseSerializationJavaScript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/o_vrMw [14:25:43] 13WikibaseSerializationJavaScript/06master 1456d4b47 15Tobi Gritschacher: Update README.md [14:26:00] [13WikibaseSerializationJavaScript] 15tobijat pushed 1 new commit to 06master: 02http://git.io/XwuuBQ [14:26:00] 13WikibaseSerializationJavaScript/06master 144104a21 15Tobi Gritschacher: Update init.php [14:26:20] [13WikibaseSerializationJavaScript] 15tobijat tagged 062.0.2 at 06master: 02http://git.io/S18fXQ [14:27:19] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/2jle7g [14:27:19] 13ValueView/06master 14c4bd7dd 15Tobi Gritschacher: Update ValueView.php [14:27:39] [13ValueView] 15tobijat pushed 1 new commit to 06master: 02http://git.io/pY0dpw [14:27:39] 13ValueView/06master 14b0b228f 15Tobi Gritschacher: Update README.md [14:27:54] [13ValueView] 15tobijat tagged 060.9.1 at 06master: 02http://git.io/3-Gjbg [14:34:45] (03PS5) 10Tobias Gritschacher: sitelinkview: Moved badges to the end of the line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [14:35:03] (03PS2) 10Tobias Gritschacher: sitelinkview: Improved pagesuggester performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180128 (owner: 10Henning Snater) [14:37:06] (03CR) 10Tobias Gritschacher: [C: 032] sitelinkview: Moved badges to the end of the line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [14:40:33] (03Merged) 10jenkins-bot: sitelinkview: Moved badges to the end of the line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [14:40:53] (03PS3) 10Tobias Gritschacher: sitelinkview: Improved pagesuggester performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180128 (owner: 10Henning Snater) [14:41:03] (03CR) 10Tobias Gritschacher: [C: 032] sitelinkview: Improved pagesuggester performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180128 (owner: 10Henning Snater) [14:46:08] (03Merged) 10jenkins-bot: sitelinkview: Improved pagesuggester performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180128 (owner: 10Henning Snater) [14:49:20] (03PS1) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 [14:50:33] review please ^ [14:54:22] (03PS1) 10Aude: Update Wikidata - proper fix for property label formatting [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180480 [14:54:25] (03CR) 10Thiemo Mättig (WMDE): Fix minor issues in JSDoc tags (031 comment) [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [14:55:50] (03PS1) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180481 [14:58:14] anyone want to update the news section on the frontpage with freebase news and new feature deployments? [15:00:49] (03CR) 10Aude: [C: 032] Update Wikidata - proper fix for property label formatting [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180480 (owner: 10Aude) [15:02:50] (03Merged) 10jenkins-bot: Update Wikidata - proper fix for property label formatting [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180480 (owner: 10Aude) [15:05:06] (03PS1) 10Aude: Update Wikidata - pull in latest backports from last branch [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180483 [15:05:33] arg [15:05:35] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/12/17 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 [15:05:54] Tobi_WMDE_SW: did you update your build resources before making the build? [15:06:17] aude: not sure [15:06:32] else, jenkins will very quickly approve but only run ~15 tests [15:06:44] we had to update the entry point [15:06:54] aude: ok [15:07:40] aude: so how do I update them? [15:09:36] just clone https://github.com/wmde/WikidataBuildResources [15:10:09] make a new build there and copy the contents to the Wikidata directory [15:10:36] (03PS2) 10Aude: Update Wikidata - pull in latest backports from last branch [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180483 [15:11:36] (03CR) 10Aude: "wow, 5 seconds for tests :o" [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 (owner: 10Tobias Gritschacher) [15:15:27] aude: copy all of the contents? [15:15:45] yes [15:15:47] what i do [15:16:03] ok [15:16:36] if you like to use the grunt commands, then npm install [15:16:45] they might be unnecessary though for this [15:16:51] composer install .... works [15:17:39] grunt does some stuff for making deployment branches [15:19:05] (03PS2) 10Tobias Gritschacher: New Wikidata Build - 2014/12/17 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 [15:19:28] aude: not sure if that was right [15:19:32] but let's see [15:19:33] looking [15:20:29] at a glance, looks good [15:20:40] is pulling in some recent changes like https://gerrit.wikimedia.org/r/#/c/180484/2/src/WikidataSettingsBuilder.php [15:20:49] yeah [15:20:57] and taking jenkins more than 5 seconds [15:21:08] that's good :) [15:21:10] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2014/12/17 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 (owner: 10Tobias Gritschacher) [15:21:14] oh noes [15:21:20] disapproves [15:21:34] i see [15:21:47] think we were aware, property suggester needs to be fixed [15:21:49] hm.. property suggester [15:21:53] to work with term index change [15:21:59] thiemo mentioned that [15:22:09] i can take a look now [15:22:19] ok [15:22:28] idn't hoo fix something there as well? [15:22:34] not that [15:22:35] or was that just the python script? [15:22:39] yeah [15:22:41] ok [15:27:31] sjoerddebruin: hoi! [15:28:06] multichill: Hai. :) [15:28:43] Any idea why I had 9 new memo's? Geo's new game? [15:28:55] Nope. [15:35:18] Lydia_WMDE: http://www.jimmyr.com/blog/Bunny_Suicide_Comic_Pics_226_2007.php [15:38:22] Tobi_WMDE_SW: https://github.com/Wikidata-lib/PropertySuggester/pull/110 [15:39:02] (03CR) 10Aude: [C: 032] Update Wikidata - pull in latest backports from last branch [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180483 (owner: 10Aude) [15:40:48] aude: are we currently using version 2.0.1 of property suggester? [15:40:56] yes [15:41:06] (03Merged) 10jenkins-bot: Update Wikidata - pull in latest backports from last branch [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180483 (owner: 10Aude) [15:41:20] if we made a 2.0.2 tag (right number?) then think composer would pull the changes into the build [15:41:39] that woudl be dangerous though, as we don't want the changes in the current deployment [15:42:10] we would have to just be careful to not pull them in there [15:42:25] ok [15:42:30] I'll test the PR [15:42:37] ok [15:44:41] DanielK_WMDE: http://www.dirksbigbunnies.com/shop/prints/515/ [15:45:04] lol [15:50:13] Lydia_WMDE: Good afternoon. I have two questions for you [15:50:29] shoot [15:50:31] :D [15:51:05] https://www.wikidata.org/wiki/User_talk:Magnus_Manske#Fuck.3F <- looks like caching bug, known or new one? [15:51:30] * aude click [15:51:30] Is it permitted/appropriate to add #Wikidata project to Pywikibot tasks? If it is, https://phabricator.wikimedia.org/project/view/71/ should mention #pywikibot-wikidata [15:51:50] try purging [15:52:08] multichill: yeah ver ylikely caching [15:52:15] diffs are cached [15:52:22] pretty heavily [15:52:44] aude: Purge what? ;-) At least we have a good nickname for this bug [15:53:11] multichill: we're using the wikidata project to pull together all tasks that affect wikidata. we could add pywikibot tasks. but it seems to be they're being worked on by different groups? [15:53:15] don't care much either way [15:54:19] It's already a catchall project. Would be nice to have the pywikibot stuff in there too [15:54:24] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Uh, injection hell. I'm not very happy with this but it's the best we can do. The global function needs to die, that's for sure. Can't spo" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 (owner: 10Adrian Lang) [15:54:28] aude: what's with the other failure in https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension-zend/20/console? [15:54:36] SettingsFileGeneratorTest [15:54:45] And maybe other tools in the future. [15:54:52] multichill: i am not totally sure what the issue is [15:55:09] * multichill files a bug [15:55:15] task* ;) [15:55:21] except that maybe magnus pulled in the label of "English" [15:55:32] semi-automatic and it was vandalized at the time [15:55:40] i don't see how it is caching [15:56:02] except the diff is cached and has old label (from at the time of the edit) [15:56:15] https://www.wikidata.org/w/index.php?title=Q135595&diff=next&oldid=158097185 <- this shows "fuck" for me [15:56:37] I can imagine that this is intended behavior [15:56:50] https://www.wikidata.org/w/index.php?title=Q135595&diff=next&oldid=158097185&uselang=es [15:57:00] cache is split by language [15:57:12] think it cached for a week afaik [15:57:53] think it pulls the label at the time the diff was first viewed [15:58:02] then cached for a week [16:00:33] Tobi_WMDE_SW: will look at https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension-zend/20/console? [16:00:52] aude: did I something wrong? [16:01:01] when pulling in new resources? [16:01:04] i don't know [16:01:13] hm [16:03:21] not exactly sure what this test does [16:03:55] that the settings are proper [16:07:12] Travis is not set up for https://github.com/wmde/WikidataBuildResources [16:07:24] so it could be that the test is already broken there [16:07:27] not sure [16:07:50] I need to leave, so cannot investigate more until tomorrow [16:08:13] Lydia_WMDE / jayvdb : Added #Pywikibot-Wikidata to https://phabricator.wikimedia.org/project/view/71/ [16:08:14] will merge the property suggester fix and release the new version [16:08:21] ok [16:09:06] multichill: ok cool [16:10:23] https://phabricator.wikimedia.org/T67990 <- awesome, merging improved and you can like a bug in phab :-D [16:11:09] (03CR) 10Anomie: Fix EditFilter bug with creating items and properties (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [16:11:42] (03PS3) 10Tobias Gritschacher: New Wikidata Build - 2014/12/17 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 [16:12:38] Lydia_WMDE: Is https://phabricator.wikimedia.org/rEWBA80f161f91fc221ef4af828aac75a9c8e10868406 something you guys can see? I get an access denied [16:13:45] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2014/12/17 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180484 (owner: 10Tobias Gritschacher) [16:13:57] (03CR) 10Aude: Fix EditFilter bug with creating items and properties (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [16:14:08] (03PS2) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 [16:15:35] multichill: that is code review i believe - locked down - not in use yet [16:18:07] * sjoerddebruin should make some food [16:19:04] *waves* [16:22:04] * aude waves :) [16:22:07] [13WikidataBuildResources] 15filbertkm created 06settings (+1 new commit): 02http://git.io/FqaecA [16:22:07] 13WikidataBuildResources/06settings 1464ef562 15aude: Fix settings builder, autoloader-suffix is always there with default = null... [16:23:47] [13WikidataBuildResources] 15filbertkm opened pull request #15: Fix settings builder, autoloader-suffix is always there and null by default (06master...06settings) 02http://git.io/hwUQyg [16:33:05] (03PS1) 10Thiemo Mättig (WMDE): Clean up and refactor TemplateFactory introduction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180498 [16:34:26] (03CR) 10Thiemo Mättig (WMDE): "I made a follow up, see Id47127f. Pick what you like into this patch, I will rebase mine later." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 (owner: 10Adrian Lang) [16:36:00] (03CR) 10jenkins-bot: [V: 04-1] Clean up and refactor TemplateFactory introduction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180498 (owner: 10Thiemo Mättig (WMDE)) [16:38:54] [13WikidataBuildResources] 15thiemowmde pushed 2 new commits to 06master: 02http://git.io/xV-_lw [16:38:54] 13WikidataBuildResources/06master 1464ef562 15aude: Fix settings builder, autoloader-suffix is always there with default = null... [16:38:54] 13WikidataBuildResources/06master 14397d9c6 15thiemowmde: Merge pull request #15 from wmde/settings... [16:45:12] anyone want to update the news section on the frontpage with freebase news and new feature deployments? [16:45:45] (03PS2) 10Thiemo Mättig (WMDE): Clean up and refactor TemplateFactory introduction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180498 [16:53:07] (03PS5) 10Thiemo Mättig (WMDE): Rework WikibaseRepo tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179473 [16:57:13] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Restoring my +2." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [16:58:44] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Removed obsolete caseInsensitive option from highlightSubstring calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180445 (owner: 10Henning Snater) [17:01:21] (03Merged) 10jenkins-bot: Removed obsolete caseInsensitive option from highlightSubstring calls [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180445 (owner: 10Henning Snater) [17:06:55] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks good, just some suggestions, see comments." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177209 (owner: 10Henning Snater) [17:10:04] (03CR) 10Thiemo Mättig (WMDE): "Looks good, but I wonder why the new dependency is needed?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 (owner: 10Henning Snater) [17:18:01] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Trim redundant code from TermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 (owner: 10Daniel Kinzler) [17:21:37] (03Merged) 10jenkins-bot: Trim redundant code from TermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 (owner: 10Daniel Kinzler) [17:30:59] (03CR) 10Daniel Kinzler: [C: 04-1] "Definitely a good thing, but found some issues." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180478 (owner: 10Adrian Lang) [17:35:32] (03CR) 10Daniel Kinzler: "I kind of hate to burn through more IDs... can we just set a fake ID title, we do that in other places I think. E.g. Title::makeTitle( $en" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [17:38:04] aude: https://www.wikidata.org/wiki/Wikidata:Project_chat#new_code_deployed_-_language_fallbacks_and_property_datatype and https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Can.27t_edit_.22Wikipedia_pages_linked_to_this_item.22 [17:38:10] i assume this is still caching? [17:38:27] bumping cache version after all? [17:38:53] Lydia_WMDE: looking [17:39:01] thx [17:40:11] i do recall an issue from before (e.g. last week) where if i added ?uselang=bn or such [17:40:21] sometimes clicking the edit link took me to the special page [17:40:35] but it was solved on master and really didn't hear any other reports of it [17:40:52] could be still that and we should investigate more [17:41:07] also happened with editing aliases [17:42:03] Lydia_WMDE: https://www.wikidata.org/wiki/Q2085623?uselang=bn [17:42:11] if i click [edit] for aliases [17:42:33] for site links, it still does it [17:42:42] starts the javascript, in edit mode then takes me to the special page [17:43:35] Lydia_WMDE: ^ [17:43:54] hmmmm let me look [17:44:05] otherwise, might be caching of javascripts [17:44:12] if they say "no reaction" when clicking [17:44:27] * aude gets reaction, but then gets redirected anyway to the special page [17:44:34] aude: aliases are also fine for me [17:44:45] i would bet caching [17:44:49] strange [17:45:04] this happened last week or before for me [17:45:23] hmmmm [17:45:57] with farsi also [17:46:06] didn't happen with all languages [17:46:32] i am logged out btw [17:47:54] logged in, it works [17:51:48] Lydia_WMDE: for https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Recent_interface_changes [17:52:10] we can probably handle in somewhat less disruptive manner when we split the view code into a component [17:52:20] aude: right [17:52:23] good point [17:55:39] Lydia_WMDE: what i can try, don't know if it will work for site links editing [17:55:50] is 'touch' all the javascript and css files [17:55:55] *nod* [17:55:59] worth a try i guess [17:56:01] then when we deploy tonight, these will get synced [17:56:12] and maybe invalidate anything stuck in caches [17:56:30] sounds good :) [17:56:35] need to run [17:56:39] back late tonight i think [17:56:40] ok [17:56:42] :) [17:56:43] have fun :) [18:01:14] (03CR) 10Aude: "fake title might work here. though i tried with "Q0" / "P0" and "0" as an ID was somewhat problematic." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [18:07:50] (03CR) 10Daniel Kinzler: "Q0 etc will fail when you try to parse them as an entity ID, but anything should work as a title, really. But it should have the correct n" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [18:17:02] Hello [18:23:27] (03PS1) 10Daniel Kinzler: Consolidate EntityIdLookup with PageEntityIdLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180535 [18:24:00] How do I edit a page on wikidata or add a page? [18:24:22] bigb: you edit by clickign one ofthe many "edit" or "add" links on the page [18:24:45] bigb: you create a new (item) page using https://www.wikidata.org/wiki/Special:NewItem [18:24:53] but make sure you are not creating a duplicate. search first [18:25:19] Can we private chat please. [18:25:21] bigb: note that there is no page source / wikitext. [18:25:22] I did do that [18:25:34] private chats are for private things [18:25:38] I used Freebase before [18:25:53] awesome :) [18:26:03] welcome to wikidata, then [18:26:23] I am lost is why I would like to speak in privete with you. [18:26:26] Maybe it's a good idea to take a tour. https://www.wikidata.org/wiki/Wikidata:Tours [18:26:30] bigb: you'll find that wikidata is still missing a lot of "obvious" things in the software. we are working on it... [18:27:08] bigb: but being lost is no shame... if it's not a big issue for you, let's talk in opublic, so others can chime in and/or benefit. [18:27:09] Can we talk please in private [18:27:12] bigb: if you are lost than the many people in this room can help you much better than one person [18:27:28] bigb: you can pm me, but i may just vanish [18:27:28] and if there's nothing secret to discuss, private does not make sense. [18:27:43] bigb: then you'd have to start anew with the next persone [18:29:28] (03CR) 10jenkins-bot: [V: 04-1] Consolidate EntityIdLookup with PageEntityIdLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180535 (owner: 10Daniel Kinzler) [18:40:19] (03PS1) 10Daniel Kinzler: Merge of CachedTermLookup with EntityIdLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180544 [18:40:42] Is it just me or is WDQ slow? [18:41:09] as soon as people start using it in earnest, it's going to fall over an die :/ [18:42:26] (03CR) 10jenkins-bot: [V: 04-1] Merge of CachedTermLookup with EntityIdLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180544 (owner: 10Daniel Kinzler) [18:44:12] DanielK_WMDE: :( sad but true. YuviPanda has been applying some bandaids but I fear they will not hold for long [18:44:34] I never experienced it so slow like this. [18:45:05] sjoerddebruin: very temporary thing to do is wdq-1.wmflabs.org [18:45:10] Will go away at some point [18:45:19] By just opening that page? [18:45:30] I mean [18:45:39] It is another machine running wdq [18:45:42] (03PS3) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 [18:45:54] Yeah, but I'm using autolist etc. [18:45:59] Ah heh [18:46:05] So I can't force a other server [18:46:20] I'm waiting for magnus to come back before switching WDQ.wmflabs.org to the new set up [18:46:29] Still hospital? [18:46:56] Think so [18:46:59] DanielK_WMDE: ^ [18:47:01] please review [18:51:14] (03PS4) 10Daniel Kinzler: Batched term lookups for RC lists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180140 [18:55:47] (03CR) 10Daniel Kinzler: [C: 04-1] "The code itself seems fine, but there's an issue with the test." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [18:56:08] aude: can look again around 10pm (during the RFC chat) [18:56:31] (03CR) 10Daniel Kinzler: [C: 04-1] "work in progress" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180140 (owner: 10Daniel Kinzler) [18:56:37] (03CR) 10jenkins-bot: [V: 04-1] Batched term lookups for RC lists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180140 (owner: 10Daniel Kinzler) [18:57:34] (03CR) 10jenkins-bot: [V: 04-1] Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [18:57:43] o_O Jenkins sais no? [18:58:07] oh noes [18:58:09] DanielK_WMDE: sure [18:58:23] creating items will be broken on test.wikidata but don't think it's critical [19:10:15] (03PS4) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 [19:13:42] (03Abandoned) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180481 (owner: 10Aude) [19:14:15] (03CR) 10jenkins-bot: [V: 04-1] Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [19:15:44] aude: DanielK_WMDE thought you could help me with the 'sites' table so i can connect my repo and client [19:16:05] aude: could you? :) [19:16:47] despens: maybe [19:17:01] i use the populateSitesTable script in wikibase lib [19:17:24] this script gives me an error, that it cannot download json off wikimedia [19:17:52] hmm [19:18:08] might not like the https default maybe [19:18:37] you can use the --load-from option in the script [19:18:48] to change the default [19:18:53] aude: i would like to connect just my repo and client, not ready yet for the big sites :) [19:19:10] hmmm [19:19:15] * aude sets $wgWBClientSettings['siteGlobalID'] = "enwiki"; [19:19:20] so i call my wiki 'enwiki' [19:19:49] otherwise, i think you have to manually add your site to the sites table [19:20:01] in the same format as the others [19:20:19] aude: ok, what is the format of the sites table? my table is empty because the script didn't run [19:20:59] http://dpaste.com/3MK1HRX [19:21:13] test [19:21:57] aude: thnx!! can i use any numerical id i want, or is that a serial? [19:22:11] it is serial [19:22:23] aude: great. tausend dank! [19:22:30] aude: 1024 dank [19:22:33] sure :) [19:23:04] aude: https://phabricator.wikimedia.org/T78693 ;) [19:24:19] definitely need that [19:26:53] aude: another q? i'd like to enable the 'entity' urls, do i need url rewriting for that? to where do i need to rewrite? [19:27:24] aude: is there anywhere an example of a rewriting config? [19:32:49] we do that in our apache config [19:35:07] https://github.com/wikimedia/operations-apache-config/blob/8f3a7639a5163cb37b256b4beff8ad3d75147a2f/main.conf#L113 [19:36:48] aude: thanks! [19:38:04] sure [19:46:22] Hello there [19:46:40] How do i remove a site form your spam filter? [19:46:54] Can someone help? [19:47:14] What website? [19:47:34] There is probably a good reason why the site is on our spam filter. [19:48:56] Anyone? [19:51:15] 20:47:14 (sjoerddebruin) What website? [19:51:15] 20:47:34 (sjoerddebruin) There is probably a good reason why the site is on our spam filter. [19:51:20] Hello anyone know how to remove a site from the spam filter? [19:54:31] sjoerddebruin: You're invisible! [19:54:38] It seems. [19:54:55] Jeff___: what is the site URL and which filter is being triggered? [19:55:21] In wiki data [19:56:12] Are you thre? [19:56:50] Is it so hard to give the url what is triggering the spam filter? [20:02:08] ;) [20:02:50] sjoerddebruin: I think Jeff___ here is new to irc [20:05:02] multichill: Yeah, but my questions are not hard. [20:06:19] sjoerddebruin: who are you again? [20:12:42] aude: https://www.mediawiki.org/wiki/Requests_for_comment/Rewrite_enhanced_recent_changes [20:12:56] DanielK_WMDE: i saw [20:12:57] :) [20:14:23] sjoerddebruin: is wdq still slow for you? [20:14:46] Hm... Yes. [20:15:10] YuviPanda: more complaints; see Wikidata's project chat [20:16:56] JohnFLewis: oh, what… is that? [20:17:12] * YuviPanda is wikidata noob [20:17:40] YuviPanda: of course you are https://www.wikidata.org/wiki/Wikidata:Project_chat#WDQ_not_updating_.3F [20:17:45] :p [20:18:29] hmm, that’s loading so slow [20:18:43] http://tools.wmflabs.org/mix-n-match/ is not loading at all. [20:23:06] sjoerddebruin: is wdq-lb.wmflabs.org any better? [20:23:32] Yeah. [20:28:17] sjoerddebruin: I wonder if I should just switch it over. [20:28:26] Can you? [20:28:34] sjoerddebruin: I can... [20:28:53] YuviPanda can do everything! [20:28:59] what could possibly go wrong [20:29:10] sjoerddebruin: well, it’s already running, etc... [20:31:00] YuviPanda: Would be nice if you would be able to restore https://tools.wmflabs.org/mix-n-match/ ;-) [20:31:18] multichill: I could reboot it. [20:32:38] multichill: seems ok now? [20:32:41] Did you do anything YuviPanda? Now it suddenly works [20:32:42] I restarted it [20:32:56] I was just firing up the debugger to see where it stalle [20:32:57] <3 [20:33:01] *stalled [20:33:56] multichill: just a webservice restart [20:34:48] multichill: I should make bigbrother die, and then use monit instead. much more flexible - you can do things like ‘if this string is not in the http response, then restart' [20:35:39] Do we have a proper load balancer available? One with custom checks etc? [20:38:38] multichill: for wikidata-lb? [20:38:44] multichill: yeah, it does health checks and fails over appropriately [20:39:18] multichill: just nginx upstream based ones, but should be good enough [20:39:30] multichill: is reasonator dead too? [20:41:24] nope [20:51:43] YuviPanda: Did you happen to have a look at the wikidataquery code? [20:52:01] multichill: not really. I debugged issues I ran into with strace and then filed bugs :) [20:52:02] It's at https://bitbucket.org/magnusmanske/wikidataquery . It's ... ehm.... interesting [20:52:37] multichill: yeah, I’ve a few patches to it, but mostly for the debianization. [20:52:50] multichill: I decided early on that my C++ skills aren’t remotely good enough at this point for me to look at it :) [20:53:02] multichill: maxsem did look at it and pointed out issues on a page on mediawiki.org I believe [20:53:43] What's the footprint of one instance? I think it's still relatively small, right? [20:53:52] sjoerddebruin: multichill I feel weird switching it to the loadbalancer without magnus around [20:56:02] multichill: uh, about 6G of RAM of some sort required, I think? [20:56:40] So we could easily deploy 10 instances without even using more than one blade YuviPanda ? [20:57:00] multichill: oh totally, but there are other problems [20:57:53] multichill: like it keeps hitting the API from each instance, for example [20:58:16] For keeping in sync? [20:58:51] So you would have to make a cluster design with read and write nodes that sync with eachother? [20:59:18] Or isn't there a feed for that already? We've been playing with that in pywikibot [21:00:28] YuviPanda: ? [21:02:17] multichill: yeah, you will need a canonical source of data [21:02:27] multichill: and have a locked way of writing to it [21:22:58] (03PS5) 10Aude: Fix EditFilter bug with creating items and properties [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 [22:00:03] DanielK_WMDE_: if you want to still look at it tonight https://gerrit.wikimedia.org/r/#/c/180479/ [22:01:50] otherwise, think it can wait until tomorrow [22:02:15] Guess I can have a look [22:02:18] ok [22:02:24] * hoo mad at university -.- [22:02:27] :( [22:02:55] Not going to be in the office anytime soon [22:03:05] They make drama... [22:03:08] sjoerddebruin: Mocht je nog zin hebben om twee personen uit elkaar te pulken, zie https://www.wikidata.org/wiki/Q943256 [22:03:24] Daar ben ik ook niet echt dol op. [22:03:59] aude: can't wrap my head around the TitleLookup change right now. will look tomorrow [22:04:31] DanielK_WMDE_: ok [22:04:39] i would be ok with having it in swat tomorrow [22:04:51] * aude doesn't want to stay awake for 3rd night in a row [22:04:55] Ik doe het morgen wel [22:05:04] aude: :( [22:05:06] the issue with title lookup though, is [22:05:27] the edit filter test is more integration and uses actual EntityContentFactory etc. [22:05:37] the mock hard-codes stuff and doesn't work here [22:06:07] so we specify it when we ask for an EditEntity object int he tests [22:06:31] * aude welcome someone else to further clean up stuff there and do better :) [22:06:41] but just wants to fix the bug and have a test for this [22:07:27] aude: it seemed fins at a glance, but i don't feeld confident to +2 right now. my head is kind of mushy, it was an intense day for me [22:07:33] DanielK_WMDE_: ok with me [22:07:56] as said, i don't see anything in the logs for this [22:08:04] I didn't sleep tonight... but went to sleep 4 to 8p then :S [22:08:25] people don't create that many new items on test.wikidata [22:08:48] and can wait [22:10:12] Title::makeTitle( $namespace, '/' ); [22:10:23] That's like just "/" for NS0 on WD? [22:10:30] hoo: yes [22:10:35] weird thing, but ok [22:10:52] * aude tried "Q0" / "P0" [22:10:58] 0 does not work a san id [22:11:01] as* [22:11:11] yeah, but would as a pseudo title [22:11:11] hoo: was my suggestion. the idea is to have a title that's useful for abusefiler & co, but is unlikely to conflict with anything, and is obviously not actually an item [22:11:13] a non-title [22:11:19] ok [22:11:23] we use it elsewhere for a simmilar purpose, iirc [22:11:37] hoo: it didn't [22:11:53] aude: uh, that's weird [22:11:58] why not? [22:12:01] i was just going to say that :) [22:12:28] Don't say there's anything constructing entity ids from those titels... [22:12:52] we don't have a canonical way to construct such titles without constructing an entityid first [22:12:58] and *that* doesn't work [22:13:03] * titles [22:13:24] Ah, I see [22:13:35] hoo: Item::setId() [22:13:39] takes strings, integers etc. [22:13:47] but non-null [22:13:49] but is_integer( 0 ) or such seemed to fail [22:13:50] I presume [22:13:53] yeah [22:14:09] yea, but you don't have to set an id, you just need a Title... [22:14:26] DanielK_WMDE_: i know, but we only have the enitty [22:14:34] It's ok as is, I guess [22:14:38] with what's in my patch now, it works [22:14:45] especially for supporting non-numerical ids [22:14:46] X0 would work too [22:14:49] to set a valid 'Q#' or whatever, it depends on the type of entity [22:14:53] DanielK_WMDE_: oh, maybe [22:14:54] i just kinda like / [22:15:01] having a canonical invalid title is good [22:15:15] might be weird in spam / abuse logs [22:15:22] It will be [22:15:25] :/ [22:15:32] Q0 will be just as strange [22:15:40] yeah [22:15:41] (new) would work, and be more clear, perhaps [22:16:22] * aude might take another look in the morning [22:16:33] try it with spam / abuse filter [22:21:03] aude: Is assertTrue public or protected? [22:21:09] I guess it's public, but not sure [22:21:15] did you test that with PHP 5.3 [22:22:29] public [22:22:33] yes, with 5.3 [22:22:34] ..and static, actually [22:22:42] comes in handy in some cases [22:22:43] Yeah ok [22:22:44] if 5.4, i wouldn't have to do use() [22:22:57] DanielK_WMDE_ makes that mistake sometimes [22:22:59] Yeah... but I saw people doing that and then using protected [22:23:07] that actually broke MW core on PHP 5.3 at some point [22:23:09] hm [22:23:13] aude: oh yea... [22:23:15] and no one noticed (as no one was watching travis) [22:23:28] (03CR) 10Hoo man: "Also those fake titles will be weird in logs." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [22:23:34] :/ [22:23:59] https://gerrit.wikimedia.org/r/#/c/177671/ [22:24:07] No one is watching WMFs travis it seems :P [22:24:31] hoo: "real" titles of items that never got created would be worse, i think [22:24:51] Probably [22:25:23] What about makeTitle( $namespace, "canonicalName of the speical page" ) [22:25:31] like Property:NewProperty [22:25:36] NewItem [22:25:38] ... [22:25:38] (03CR) 10Aude: "i'll take another look when i'm awake more at maybe a better title than "/" for appearing in spam / abuse logs" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180479 (owner: 10Aude) [22:25:41] Just an idea [22:25:55] hoo: kind of what i was thinking [22:30:19] or just # [22:30:24] i think that's valid now. [22:30:44] it'S a valid link target, but you can't save a page with tsuch a title [22:30:51] There ahve been many discussion about valid titles/ sections [22:30:56] it it'S a title without text [22:31:24] DanielK_WMDE_: would be weird in the logs [22:31:57] aude: not weirder than the name of the special page, / [22:32:11] it's actually no title. which is kind of what it's actually supposed to mean [22:32:17] there realls *is* no title. [22:32:40] i like it semantically. not sure if it's prectical [22:35:04] DanielK_WMDE_: can take look tomorrow [22:35:20] I can see your point, but htink it will make a horrible user experience [22:36:29] maybe we can hook into SpecialLog and customize the display... [22:37:33] We could have a custom log formatter [22:37:34] oh wait no [22:37:39] not our logs [22:37:49] Would need messing with linkbegin hook stuff [22:40:55] not very cherrypickable then [22:41:34] need to be something we can backport, although follow up for master with linkbegin might work [22:45:06] anyone around? I'm trying to use Wikidata on vagrant and associate my local wiki with the wikidata instance [22:49:36] jdlrobson: yeaj [22:49:39] * yeah [22:50:00] hoo: yey! [22:50:11] hoo: so I am on the page http://wikidata.wiki.local.wmftest.net:8080/wiki/Q2 [22:50:18] and I'm in Wikipedia pages linked to this item [22:50:30] i'm trying to link to a page http://localhost:8080/wiki/Albert_Einstein [22:50:43] ok [22:50:44] but the only wiki available seems to be http://en.wiki.local.wmftest.net:8080/ [22:50:52] How do i register another site there? [22:51:05] You need to propagate your sites table [22:51:17] How did you initially do that? [22:51:27] it comes with the one by default [22:51:34] ah ok [22:51:47] i don't think it's really setup to have multiple clients yet (in vagrant) [22:52:02] but could be... works like multiversion stuff in production [22:52:59] I thought Max was poking at that? [22:53:13] bd808: apparently Max has too much of a headache [22:53:19] specifically for a wikigrok role [22:53:19] he said he needed help from people that understood it :( [22:53:35] ah. That's my problem with setting up wikidata too [22:53:52] i see [22:53:55] aude: any ideas what needs to happen? [22:54:05] I can make mw-vagrant's puppet and multiverison sing and dance but I don't know the tune [22:54:17] i don't know without looking / trying wikigrok role [22:54:30] (also need to see what to do to make structured data /commosn work with wikidata role) [22:55:07] which is probably not happening tonight, unfortunetly [22:55:20] aude: :-( [22:55:23] since too tired [22:55:34] tired of deploying stuff at 2-3am (as the past days) [22:55:42] not tonight [22:55:43] aude: if you could look tomorrow when you are all re-energised i'd be super appreciative [22:55:48] sure [22:56:03] i've got an experimental editing interface for mobile english wikipedia which would allow editing in wikidata [22:56:04] would be cool to try out wikigrok [22:56:12] * aude tried to set it up manually and got confused [22:56:24] So you can basically edit wikidata from within the article you are trying to disect [22:56:25] cool :) [23:31:19] Whut? https://www.wikidata.org/w/index.php?title=User:Agruwie&curid=18833279&diff=181925566&oldid=138446791