[00:02:17] (03PS1) 10Aude: Focus value input box when adding a statement to an existing statement group [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180077 [00:02:19] (03PS1) 10Aude: Focus property input box when adding a statement via "global" "add" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180078 [00:02:46] (03CR) 10Aude: [C: 032] Show an error if ViewEntityAction is used with non-Entity content [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180060 (owner: 10Aude) [00:02:54] (03CR) 10Aude: [C: 032] No language fallback when serializing wbEntity. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180061 (owner: 10Aude) [00:03:07] (03CR) 10Aude: [C: 032] Introduce DataType for refs to Properties. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180062 (owner: 10Aude) [00:08:06] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12c/9eec6f8 : Marius Hoch The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44152935 [00:09:08] * aude waits for jenkins to catch up [00:12:09] (03Merged) 10jenkins-bot: Reduce other projects sidebar initialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180056 (owner: 10Aude) [00:12:55] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12c/0821802 : Marius Hoch The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44153075 [00:14:55] (03Merged) 10jenkins-bot: Clone cached tables before returning them to users in mw.wikibase [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180057 (owner: 10Aude) [00:14:58] (03Merged) 10jenkins-bot: Cache the "otherProjectsLinks" setting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180058 (owner: 10Aude) [00:15:44] (03CR) 10Aude: [C: 032] Defer entity deserialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180064 (owner: 10Aude) [00:15:51] (03CR) 10Aude: [C: 032] Use same SidebarHookHandlers instance during request [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180065 (owner: 10Aude) [00:16:06] (03CR) 10Aude: [C: 032] Use one instance of SerializationOptions in WikibaseLuaBindings [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180066 (owner: 10Aude) [00:16:12] (03CR) 10Aude: [C: 032] Avoid fatal in ParserAfterParser hook handling [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180067 (owner: 10Aude) [00:16:21] (03CR) 10Aude: [C: 032] Don't use (or need) Content (again) in ViewEntityAction [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180068 (owner: 10Aude) [00:17:26] (03Merged) 10jenkins-bot: USE INDEX(wb_epp_entity) in EntityPerPageTable::listEntities [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180059 (owner: 10Aude) [00:17:38] (03CR) 10Aude: [C: 032] Apply LanguageFallback (variants) for getLabel in lua [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180069 (owner: 10Aude) [00:17:49] (03CR) 10Aude: [C: 032] Don't instantiate ParserAfterParseHookHandler for interface msg parse [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180063 (owner: 10Aude) [00:18:16] (03Merged) 10jenkins-bot: Show an error if ViewEntityAction is used with non-Entity content [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180060 (owner: 10Aude) [00:19:58] (03Merged) 10jenkins-bot: No language fallback when serializing wbEntity. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180061 (owner: 10Aude) [00:21:18] (03Merged) 10jenkins-bot: Introduce DataType for refs to Properties. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180062 (owner: 10Aude) [00:23:25] (03CR) 10Aude: [C: 032] Focus value input box when adding a statement to an existing statement group [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180077 (owner: 10Aude) [00:23:45] (03Merged) 10jenkins-bot: Don't instantiate ParserAfterParseHookHandler for interface msg parse [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180063 (owner: 10Aude) [00:23:48] (03CR) 10Aude: [C: 032] Focus property input box when adding a statement via "global" "add" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180078 (owner: 10Aude) [00:25:03] (03Merged) 10jenkins-bot: Defer entity deserialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180064 (owner: 10Aude) [00:25:07] (03Merged) 10jenkins-bot: Use same SidebarHookHandlers instance during request [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180065 (owner: 10Aude) [00:26:56] (03Merged) 10jenkins-bot: Use one instance of SerializationOptions in WikibaseLuaBindings [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180066 (owner: 10Aude) [00:27:03] (03Merged) 10jenkins-bot: Avoid fatal in ParserAfterParser hook handling [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180067 (owner: 10Aude) [00:30:04] (03Merged) 10jenkins-bot: Don't use (or need) Content (again) in ViewEntityAction [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180068 (owner: 10Aude) [00:30:09] (03Merged) 10jenkins-bot: Apply LanguageFallback (variants) for getLabel in lua [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180069 (owner: 10Aude) [00:31:47] almost done for tonight [00:31:55] yay :) [00:32:09] might try to get a few more of the focus patches in (for referneces etc.) but they are not clean cherry picks [00:32:18] henning / adrian / tobi can take a look [00:32:26] and the direct sql store patch [00:33:16] from manual testing, this all seems ok to me [00:33:29] Would like to have it on test tonight [00:33:37] +9000 [00:33:46] ready to make the build [00:34:09] 2 changes still in gerrit [00:34:10] AFAIS [00:34:29] yes [00:35:37] (03Merged) 10jenkins-bot: Focus value input box when adding a statement to an existing statement group [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180077 (owner: 10Aude) [00:35:41] (03Merged) 10jenkins-bot: Focus property input box when adding a statement via "global" "add" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180078 (owner: 10Aude) [00:35:55] there :) [00:36:22] also have tim's change to our composer file in [00:36:36] ah [00:39:50] (03PS1) 10Aude: New / updated deployment build [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180093 [00:40:26] +2979, -1679 [00:40:30] mostly backports :P [00:41:12] mostly and a lot of these patches are already deployed [00:41:30] I wonder why https://gerrit.wikimedia.org/r/#/c/180093/1/extensions/Wikibase/client/includes/hooks/UpdateRepoHookHandlers.php is in there [00:42:07] that was a purely stylistic change [00:42:09] but whatever [00:42:39] it was in before the cutoff [00:42:44] probably [00:43:09] Oh right... you didn't exactly use wmf11 but a slightly newer point to cut? [00:43:43] yes, to get the EntityInfoTermLookup changes in [00:43:53] make sense [00:44:18] * aude hopes not to have to do this again [00:44:27] but this shall work [00:44:33] hopefully [00:44:39] but still rather error prone [00:44:54] yeah :/ [00:45:10] travis is still processing them [00:45:27] more worried about UI, though [00:46:03] it's pretty close to the last branch point, in terms of ui [00:46:26] so has focus issues still (qualifiers, etc) [00:47:39] (03CR) 10Aude: [C: 032] "manually tried various things, seems ok" [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180093 (owner: 10Aude) [00:48:01] (03Merged) 10jenkins-bot: New / updated deployment build [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180093 (owner: 10Aude) [00:48:11] aude: https://gerrit.wikimedia.org/r/178700 [00:48:40] that can go in [00:48:58] Not sure how relevant for normal site operation it is, but for in the json dumps that class eats up to 15-20% of the time [00:49:00] (03PS1) 10Aude: Only select fields we need in WikiPageEntityRevisionLookup [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180097 [00:49:25] probably will have a few other patches tomorrow (for focus issue) [00:49:33] can get that one in then [00:49:48] yeah, sure :) [00:50:20] to get this on test, probably needs a scap :/ [00:51:25] it adds messages, so yes [00:55:55] (03CR) 10Aude: [C: 032] Only select fields we need in WikiPageEntityRevisionLookup [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180097 (owner: 10Aude) [00:59:28] (03Merged) 10jenkins-bot: Only select fields we need in WikiPageEntityRevisionLookup [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180097 (owner: 10Aude) [02:11:33] https://test.wikidata.org/wiki/Q22 (updated, please test) [02:11:39] in case anyone is awake... [02:11:52] * hoo is awake... although probably shouldn't :D [02:12:29] heh [02:13:28] focus in the site links section is slightly weird, although not sure it's a new issue [02:14:17] same as wikidata [02:15:13] broken autofocus for qualifiers and references is known? [02:15:44] My (extremely nasty) patch which Henning rejected fixed that as well [02:16:49] hoo: are those the patches cherrypicked to wmf12 on friday? [02:17:00] they are not clean cherry pick here but can try tomorrow [02:17:51] ok [02:17:56] https://gerrit.wikimedia.org/r/178821 for references [02:18:18] ok [02:18:18] those are very tiny, so probably easy to manually backport [02:18:38] no, there is a patch on top of it [02:19:00] still should be possible but might need henning / adrian to help [02:19:01] https://gerrit.wikimedia.org/r/178820 is the root [02:19:05] largest one AFAIR [02:19:13] yeah [02:19:23] i was seeing js errors when i tried it [02:19:33] ok :/ [02:19:41] need to try again and be careful [02:19:56] sure we can sort this out [02:19:57] Yeah... not that important if they aren't backported [02:20:07] got the statement / snak focus ones [02:20:17] which is far more important [02:20:20] yep [02:20:31] alright, shall sleep soon [02:20:45] will stick around a little longer just in case there is a problem [02:21:06] also going to be around for a bit longer [02:21:19] k [08:24:24] (03PS1) 10Henning Snater: sitelinkview: Improved pagesuggester performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180128 [08:25:30] (03CR) 10jenkins-bot: [V: 04-1] sitelinkview: Improved pagesuggester performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180128 (owner: 10Henning Snater) [08:35:32] (03PS1) 10Adrian Lang: Rename init.php -> WikibaseJavaScriptApi.php [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180131 [08:58:35] (03PS1) 10Adrian Lang: Inject SiteLinksView into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180132 [09:00:38] (03CR) 10jenkins-bot: [V: 04-1] Inject SiteLinksView into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180132 (owner: 10Adrian Lang) [09:02:34] (03CR) 10Adrian Lang: "Mh, I don't get it either. I probably had a reason. Or not. I can't reproduce it now, anyway." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [09:05:16] (03PS2) 10Adrian Lang: Inject SiteLinksView into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180132 [09:08:29] (03CR) 10jenkins-bot: [V: 04-1] Inject SiteLinksView into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180132 (owner: 10Adrian Lang) [09:23:41] (03PS3) 10Adrian Lang: Inject SiteLinksView into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180132 [09:38:45] DanielK_WMDE: https://gerrit.wikimedia.org/r/180132 [10:02:19] (03CR) 10Daniel Kinzler: [C: 032] Inject SiteLinksView into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180132 (owner: 10Adrian Lang) [10:05:28] (03Merged) 10jenkins-bot: Inject SiteLinksView into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180132 (owner: 10Adrian Lang) [10:22:18] (03PS1) 10Henning Snater: badgselector: Suppress badges that refer to deleted items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180133 [10:27:37] (03PS1) 10Adrian Lang: Inject settings into SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180134 [10:27:39] (03PS1) 10Adrian Lang: Inject DataTypeFactory into PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180135 [10:33:21] (03CR) 10Daniel Kinzler: [C: 04-1] "Mostly agree, but found an issue or two." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [10:33:52] (03CR) 10Daniel Kinzler: [C: 032] Drop useless docs from Store interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179937 (owner: 10Thiemo Mättig (WMDE)) [10:37:45] (03Merged) 10jenkins-bot: Drop useless docs from Store interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179937 (owner: 10Thiemo Mättig (WMDE)) [10:39:38] (03PS1) 10Adrian Lang: Make some protected properties in EntityView private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180137 [10:41:15] (03CR) 10Adrian Lang: [C: 032] Evaluated entityViewInit ResourceLoader module dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179111 (owner: 10Henning Snater) [10:42:04] (03PS2) 10Adrian Lang: badgselector: Suppress badges that refer to deleted items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180133 (owner: 10Henning Snater) [10:42:17] (03PS3) 10Adrian Lang: badgselector: Suppress badges that refer to deleted items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180133 (owner: 10Henning Snater) [10:43:02] (03CR) 10Daniel Kinzler: [C: 04-1] "needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167596 (owner: 10Thiemo Mättig (WMDE)) [10:44:01] (03Merged) 10jenkins-bot: Evaluated entityViewInit ResourceLoader module dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179111 (owner: 10Henning Snater) [10:45:57] (03CR) 10Daniel Kinzler: [C: 032] Check if property exists in PropertyIdResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [10:46:43] (03CR) 10Adrian Lang: "Looks good." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177209 (owner: 10Henning Snater) [10:48:53] (03CR) 10jenkins-bot: [V: 04-1] Check if property exists in PropertyIdResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [10:49:47] (03CR) 10Adrian Lang: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [11:01:15] (03PS3) 10Adrian Lang: Check if property exists in PropertyIdResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [11:01:57] (03CR) 10Adrian Lang: [C: 032] "Rebased with semantic merge conflict fix." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [11:05:31] (03Merged) 10jenkins-bot: Check if property exists in PropertyIdResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171009 (owner: 10Aude) [11:20:04] (03PS4) 10Adrian Lang: Remove _fetchItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 [11:20:41] (03CR) 10Adrian Lang: "Hoo: Fixed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 (owner: 10Adrian Lang) [11:22:39] (03CR) 10Adrian Lang: [C: 032] Removed visible white space from sitelinkview template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179910 (owner: 10Henning Snater) [11:25:05] (03PS1) 10Aude: Language fallback for labels of referenced items. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180142 [11:25:06] (03Merged) 10jenkins-bot: Removed visible white space from sitelinkview template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179910 (owner: 10Henning Snater) [11:33:40] [13DataTypes] 15thiemowmde created 06dataTypeFactory (+1 new commit): 02http://git.io/0IiwIg [11:33:40] 13DataTypes/06dataTypeFactory 1491dee9e 15Thiemo Mättig: Clean up DataTypeFactory [11:34:37] [13DataTypes] 15thiemowmde opened pull request #28: Clean up DataTypeFactory (06master...06dataTypeFactory) 02http://git.io/tjZ0tA [11:35:39] wmde/DataTypes/dataTypeFactory/91dee9e : Thiemo Mättig The build passed. http://travis-ci.org/wmde/DataTypes/builds/44196850 [11:46:32] Adrian_WMDE: Henning_WMDE only on master, the data type "Item" is misplaced on the property page http://snag.gy/JaY1d.jpg [11:46:36] fyi [12:04:47] (03PS1) 10Adrian Lang: Only allow QUnit and sinon in test files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180143 [12:05:57] (03PS1) 10Aude: Renamed wb.experts.EntityIdInput to wb.experts.Entity [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180144 [12:05:59] (03PS1) 10Aude: Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180145 [12:06:01] (03PS1) 10Aude: Implemented wb.experts.Property [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180146 [12:06:03] (03PS1) 10Aude: Slimmed down Expert store initialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180147 [12:09:56] (03PS1) 10Adrian Lang: Move var definition in statementview::_create [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180148 [12:11:17] (03PS1) 10Adrian Lang: Init nullable with null instead of false [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180149 [12:11:21] (03PS1) 10Henning Snater: Not passing Message object into template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180150 [12:13:38] (03CR) 10jenkins-bot: [V: 04-1] Move var definition in statementview::_create [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180148 (owner: 10Adrian Lang) [12:21:48] (03PS2) 10Adrian Lang: Move var definition in statementview::_create [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180148 [12:28:11] (03PS5) 10Adrian Lang: Move wikibase.css and jquery.wikibase from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 [12:31:54] [13DataValuesJavascript] 15snaterlicious created 06undeserializablevalue (+1 new commit): 02http://git.io/137XQg [12:31:54] 13DataValuesJavascript/06undeserializablevalue 144a6cabf 15snaterlicious: Updated UnDeserializableValue [12:35:04] (03CR) 10Adrian Lang: "Howto review:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 (owner: 10Adrian Lang) [12:37:25] [13DataValuesJavascript] 15snaterlicious opened pull request #58: Updated UnDeserializableValue (06master...06undeserializablevalue) 02http://git.io/90o_LA [12:58:26] (03PS2) 10Adrian Lang: Make some protected properties in EntityView private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180137 [12:58:28] (03PS1) 10Adrian Lang: Remove DispatchingSnakFormatter usage from View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180154 [13:04:35] (03CR) 10Aude: [C: 032] "manually verified" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180144 (owner: 10Aude) [13:04:53] (03CR) 10Aude: [C: 032] Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180145 (owner: 10Aude) [13:05:11] (03CR) 10Aude: [C: 032] Implemented wb.experts.Property [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180146 (owner: 10Aude) [13:05:26] (03CR) 10Aude: [C: 032] Slimmed down Expert store initialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180147 (owner: 10Aude) [13:09:51] (03Merged) 10jenkins-bot: Renamed wb.experts.EntityIdInput to wb.experts.Entity [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180144 (owner: 10Aude) [13:09:57] (03Merged) 10jenkins-bot: Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180145 (owner: 10Aude) [13:10:00] (03Merged) 10jenkins-bot: Implemented wb.experts.Property [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180146 (owner: 10Aude) [13:12:05] (03PS1) 10Thiemo Mättig (WMDE): Stop EntityIdFormatter extending ValueFormatterBase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180163 [13:12:13] (03Merged) 10jenkins-bot: Slimmed down Expert store initialization [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180147 (owner: 10Aude) [13:15:10] (03CR) 10jenkins-bot: [V: 04-1] Stop EntityIdFormatter extending ValueFormatterBase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180163 (owner: 10Thiemo Mättig (WMDE)) [13:20:19] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/12/16 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180164 [13:20:29] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/12/16 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180164 (owner: 10Tobias Gritschacher) [13:21:40] (03PS2) 10Thiemo Mättig (WMDE): Stop EntityIdFormatter extending ValueFormatterBase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180163 [13:24:49] (03CR) 10jenkins-bot: [V: 04-1] Stop EntityIdFormatter extending ValueFormatterBase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180163 (owner: 10Thiemo Mättig (WMDE)) [13:25:17] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/12/16 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/180164 (owner: 10Tobias Gritschacher) [13:26:23] (03PS1) 10Aude: Don't load sites for DirectSqlStore [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180165 [13:33:47] (03PS1) 10Adrian Lang: View: Don't depend on EntityIdHtmlLinkFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180166 [13:33:49] (03PS1) 10Adrian Lang: View: Don't depend on EntityInfoTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180167 [13:33:51] (03PS1) 10Adrian Lang: Remove unused use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180168 [13:39:16] (03CR) 10Aude: [C: 032] Don't load sites for DirectSqlStore [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180165 (owner: 10Aude) [13:41:18] [13WikibaseDataModelSerialization] 15frimelle pushed 1 new commit to 06master: 02http://git.io/AM980g [13:41:18] 13WikibaseDataModelSerialization/06master 146f5a3ac 15Lucie-Aimée Kaffee: Update README.md [13:42:48] (03Merged) 10jenkins-bot: Don't load sites for DirectSqlStore [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180165 (owner: 10Aude) [13:43:37] wmde/WikibaseDataModelSerialization/master/6f5a3ac : Lucie-Aimée Kaffee The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/44207161 [13:46:23] (03PS2) 10Adrian Lang: Not passing Message object into template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180150 (owner: 10Henning Snater) [13:48:55] (03CR) 10Daniel Kinzler: [C: 032] Inject settings into SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180134 (owner: 10Adrian Lang) [13:49:21] [13WikibaseSerializationJavaScript] 15snaterlicious created 06undeserializablevalue (+1 new commit): 02http://git.io/o4rnCw [13:49:21] 13WikibaseSerializationJavaScript/06undeserializablevalue 1439030a7 15snaterlicious: Adapt to DataValuesJavaScript 0.7.0 [13:50:10] [13WikibaseSerializationJavaScript] 15snaterlicious 04force-pushed 06undeserializablevalue from 1439030a7 to 14b14964a: 02http://git.io/kZYTxQ [13:50:10] 13WikibaseSerializationJavaScript/06undeserializablevalue 14b14964a 15snaterlicious: Adapt to DataValuesJavaScript 0.7.0 [13:50:23] wmde/WikibaseSerializationJavaScript/undeserializablevalue/39030a7 : snaterlicious The build has errored. http://travis-ci.org/wmde/WikibaseSerializationJavaScript/builds/44208027 [13:50:30] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Nothing wrong here, see comments." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179881 (owner: 10Thiemo Mättig (WMDE)) [13:50:48] [13WikibaseSerializationJavaScript] 15snaterlicious opened pull request #12: Adapt to DataValuesJavaScript 0.7.0 (06master...06undeserializablevalue) 02http://git.io/ZBjJDw [13:51:38] (03CR) 10Daniel Kinzler: [C: 032] Inject DataTypeFactory into PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180135 (owner: 10Adrian Lang) [13:51:43] (03Merged) 10jenkins-bot: Inject settings into SiteLinksView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180134 (owner: 10Adrian Lang) [13:54:23] (03Merged) 10jenkins-bot: Inject DataTypeFactory into PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180135 (owner: 10Adrian Lang) [13:54:26] (03CR) 10Daniel Kinzler: "Not sure about this. EntityView is desigend to be extended by subclassing, and subclasses should probably have access to, and the ability " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180137 (owner: 10Adrian Lang) [13:56:45] [13ValueView] 15snaterlicious created 06inputautoexpandforce (+1 new commit): 02http://git.io/32VQhQ [13:56:45] 13ValueView/06inputautoexpandforce 145166b4e 15snaterlicious: Added force parameter to $.AutoInputExpand.prototype.expand() [13:56:49] (03CR) 10Daniel Kinzler: [C: 032] Remove DispatchingSnakFormatter usage from View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180154 (owner: 10Adrian Lang) [13:57:01] Adrian_WMDE: why a chain? most of these changes seem to be unrelated [13:57:02] (03CR) 10Adrian Lang: [C: 032] "Maybe Template should not inherit from Message …" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180150 (owner: 10Henning Snater) [13:57:27] ugh. "Maybe Template should not inherit from Message"?... hmhm :) [13:57:36] DanielK_WMDE: Yep, laziness, but I'll shift the one you don't like [13:57:40] [13ValueView] 15snaterlicious opened pull request #138: Added force parameter to $.AutoInputExpand.prototype.expand() (06master...06inputautoexpandforce) 02http://git.io/rMhyXg [13:58:01] (03PS2) 10Adrian Lang: Remove unused use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180168 [13:58:03] (03PS2) 10Adrian Lang: Remove DispatchingSnakFormatter usage from View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180154 [13:58:05] (03PS2) 10Adrian Lang: View: Don't depend on EntityIdHtmlLinkFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180166 [13:58:07] (03PS2) 10Adrian Lang: View: Don't depend on EntityInfoTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180167 [13:58:26] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Make some protected properties in EntityView private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180137 (owner: 10Adrian Lang) [13:58:28] (03PS4) 10Henning Snater: sitelinkview: Moved badges to the end of the line [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 [13:59:20] (03CR) 10Thiemo Mättig (WMDE): "These are exactly the properties and methods that should be private. I would probably have changed a lot more to private. ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180137 (owner: 10Adrian Lang) [14:00:58] (03Merged) 10jenkins-bot: Not passing Message object into template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180150 (owner: 10Henning Snater) [14:03:22] (03PS1) 10Aude: Returning promise in $.wikibase.listview.enterNewItem() [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180171 [14:03:24] (03PS1) 10Aude: Focus referenceview when adding a new referenceview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180172 [14:03:26] (03PS1) 10Aude: Focus snakview when adding a new snakview to a referenceview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180173 [14:03:28] (03PS1) 10Aude: Focus new snakview when adding a qualifier [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180174 [14:04:52] (03Merged) 10jenkins-bot: Make some protected properties in EntityView private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180137 (owner: 10Adrian Lang) [14:06:56] (03CR) 10Aude: [C: 032] Returning promise in $.wikibase.listview.enterNewItem() [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180171 (owner: 10Aude) [14:07:04] (03CR) 10Aude: [C: 032] Focus referenceview when adding a new referenceview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180172 (owner: 10Aude) [14:07:14] (03CR) 10Aude: [C: 032] Focus snakview when adding a new snakview to a referenceview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180173 (owner: 10Aude) [14:07:21] (03CR) 10Aude: [C: 032] Focus new snakview when adding a qualifier [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180174 (owner: 10Aude) [14:07:25] done :) [14:08:32] (03CR) 10Daniel Kinzler: [C: 032] View: Don't depend on EntityIdHtmlLinkFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180166 (owner: 10Adrian Lang) [14:08:40] (03CR) 10Daniel Kinzler: View: Don't depend on EntityIdHtmlLinkFormatterFactory (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180166 (owner: 10Adrian Lang) [14:11:46] (03CR) 10Daniel Kinzler: [C: 032] View: Don't depend on EntityInfoTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180167 (owner: 10Adrian Lang) [14:12:11] (03CR) 10Daniel Kinzler: [C: 032] Remove unused use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180168 (owner: 10Adrian Lang) [14:13:06] (03CR) 10jenkins-bot: [V: 04-1] Returning promise in $.wikibase.listview.enterNewItem() [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180171 (owner: 10Aude) [14:13:08] (03CR) 10jenkins-bot: [V: 04-1] Focus referenceview when adding a new referenceview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180172 (owner: 10Aude) [14:13:10] (03CR) 10jenkins-bot: [V: 04-1] Focus snakview when adding a new snakview to a referenceview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180173 (owner: 10Aude) [14:13:12] (03CR) 10jenkins-bot: [V: 04-1] Focus new snakview when adding a qualifier [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180174 (owner: 10Aude) [14:13:28] oh noes [14:13:31] hehe [14:13:53] maybe someone force merged a patch [14:13:57] error: unable to write sha1 filename [14:14:20] is jenkins misbehaving? [14:14:23] Zuul might still merge them though [14:14:28] it relaunched all the jobs [14:14:29] yeah [14:15:13] (03CR) 10Aude: Returning promise in $.wikibase.listview.enterNewItem() [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180171 (owner: 10Aude) [14:15:23] (03CR) 10Aude: [C: 032] Returning promise in $.wikibase.listview.enterNewItem() [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180171 (owner: 10Aude) [14:19:20] Lucie_WMDE: can you give me a list of component-github-repositories that have no issues at all? I'm going to disable the github issue-tracker in those completely. [14:19:22] (03Merged) 10jenkins-bot: Remove DispatchingSnakFormatter usage from View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180154 (owner: 10Adrian Lang) [14:19:27] (03Merged) 10jenkins-bot: View: Don't depend on EntityIdHtmlLinkFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180166 (owner: 10Adrian Lang) [14:19:30] (03Merged) 10jenkins-bot: View: Don't depend on EntityInfoTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180167 (owner: 10Adrian Lang) [14:20:21] (03CR) 10Hashar: "Jenkins seems happy about this https://integration.wikimedia.org/ci/job/mwext-WikibaseJavaScriptApi-testextension/4/console :)" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180131 (owner: 10Adrian Lang) [14:20:23] Tobi_WMDE_SW Will the links still work then? In many bugs I opened, I didn't copy the whole discussion from github but just linked it. [14:20:30] (03CR) 10Hashar: [C: 031] Rename init.php -> WikibaseJavaScriptApi.php [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180131 (owner: 10Adrian Lang) [14:21:02] Lucie_WMDE: no, the links won't work. that's why I only want to disable it for the repositories that have no issues listed [14:23:56] (03CR) 10Adrian Lang: [C: 032] Rename init.php -> WikibaseJavaScriptApi.php [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180131 (owner: 10Adrian Lang) [14:24:32] [13WikibaseQueryEngine] 15frimelle pushed 1 new commit to 06master: 02http://git.io/jVK1Jg [14:24:32] 13WikibaseQueryEngine/06master 14b853484 15Lucie-Aimée Kaffee: Update README.md [14:24:59] (03CR) 10Adrian Lang: [V: 032] Rename init.php -> WikibaseJavaScriptApi.php [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180131 (owner: 10Adrian Lang) [14:27:45] (03Merged) 10jenkins-bot: Remove unused use clauses [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180168 (owner: 10Adrian Lang) [14:27:48] (03Merged) 10jenkins-bot: Returning promise in $.wikibase.listview.enterNewItem() [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180171 (owner: 10Aude) [14:27:52] (03Merged) 10jenkins-bot: Focus referenceview when adding a new referenceview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180172 (owner: 10Aude) [14:27:56] (03Merged) 10jenkins-bot: Focus snakview when adding a new snakview to a referenceview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180173 (owner: 10Aude) [14:28:51] (03CR) 10Daniel Kinzler: [C: 031] Language fallback for labels of referenced items. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180142 (owner: 10Aude) [14:29:27] (03CR) 10Aude: [C: 032] Language fallback for labels of referenced items. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180142 (owner: 10Aude) [14:29:58] https://phabricator.wikimedia.org/T75020 in my comment, there is a list titled 'bogus'. You might want to look into these, maybe we need interfaces for some of them ( DanielK_WMDE: aude: Thiemo_WMDE: ) [14:30:15] (03CR) 10Tobias Gritschacher: "Removing my -1 as the mentioned issues will be fixed by the depending change in wikibase/value-view (as mentioned in the commit message no" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179911 (owner: 10Henning Snater) [14:30:51] omg, Utils? [14:33:40] (03PS4) 10Tobias Gritschacher: badgeselector: Suppress badges that refer to deleted items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180133 (owner: 10Henning Snater) [14:33:44] (03Merged) 10jenkins-bot: Focus new snakview when adding a qualifier [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180174 (owner: 10Aude) [14:38:44] (03CR) 10Tobias Gritschacher: [C: 032] Updated sitelinkview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179913 (owner: 10Henning Snater) [14:39:19] (03Merged) 10jenkins-bot: Language fallback for labels of referenced items. [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180142 (owner: 10Aude) [14:41:29] (03Merged) 10jenkins-bot: Updated sitelinkview styling [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179913 (owner: 10Henning Snater) [14:41:53] (03PS1) 10Aude: Update Wikidata, fix focus when editing [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180184 [14:45:12] If I have another dataset and I want to make a semantic link to wikidata, what's the right way to do that? [14:46:17] (03PS6) 10Thiemo Mättig (WMDE): Updated code documentation [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176337 (owner: 10Henning Snater) [14:46:19] (03PS1) 10Thiemo Mättig (WMDE): Fix minor issues in JSDoc tags [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 [14:47:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Updated code documentation [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176337 (owner: 10Henning Snater) [14:49:00] (03CR) 10Aude: [C: 032] Update Wikidata, fix focus when editing [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180184 (owner: 10Aude) [14:49:17] (03Merged) 10jenkins-bot: Update Wikidata, fix focus when editing [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180184 (owner: 10Aude) [14:49:21] (03PS6) 10Thiemo Mättig (WMDE): Fixed creating an empty entity [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177502 (owner: 10Henning Snater) [14:49:31] (03PS6) 10Thiemo Mättig (WMDE): Rewrote RepoApi tests [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177503 (owner: 10Henning Snater) [14:50:04] (03CR) 10Thiemo Mättig (WMDE): [V: 032] Updated code documentation [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176337 (owner: 10Henning Snater) [14:50:31] (03CR) 10Thiemo Mättig (WMDE): [V: 032] Fixed creating an empty entity [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177502 (owner: 10Henning Snater) [14:52:14] (03CR) 10Hashar: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [14:52:35] (03PS3) 10Daniel Kinzler: Allow filtering by term type in getTermsOfEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179527 [14:52:43] Thiemo_WMDE: --^ [14:52:55] (03CR) 10Daniel Kinzler: Allow filtering by term type in getTermsOfEntities (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179527 (owner: 10Daniel Kinzler) [14:54:15] (03CR) 10Daniel Kinzler: [C: 04-1] "needs rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 (owner: 10Thiemo Mättig (WMDE)) [14:54:38] (03PS8) 10Daniel Kinzler: Implementing prefetching on top of TermIndex. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 [14:58:30] (03CR) 10jenkins-bot: [V: 04-1] Correct wrong jshint config name [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [14:59:35] (03PS4) 10Henning Snater: Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 [14:59:47] (03CR) 10jenkins-bot: [V: 04-1] Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [15:01:00] (03PS4) 10Henning Snater: getEntitiesByPage: Always submit "normalize" parameter if specified [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177508 [15:01:10] (03PS5) 10Henning Snater: Added RepoApi tests for functions not yet tested [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177509 [15:01:15] (03PS5) 10Henning Snater: Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 [15:02:19] bah mwext-WikibaseJavaScriptApi-qunit is failling [15:02:20] (03CR) 10jenkins-bot: [V: 04-1] getEntitiesByPage: Always submit "normalize" parameter if specified [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177508 (owner: 10Henning Snater) [15:02:23] I am going to disable it [15:02:29] :( [15:02:53] (03CR) 10Thiemo Mättig (WMDE): [C: 032 V: 032] Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [15:06:48] (03CR) 10jenkins-bot: [V: 04-1] Added RepoApi tests for functions not yet tested [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177509 (owner: 10Henning Snater) [15:07:02] (03PS4) 10Daniel Kinzler: Trim redundant code from TermIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 [15:07:35] (03CR) 10jenkins-bot: [V: 04-1] Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [15:11:14] (03CR) 10Hashar: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177503 (owner: 10Henning Snater) [15:12:06] mwext-WikibaseJavaScriptApi-qunit is no more blocking changes on the extensions/WikibaseJavaScriptApi repo [15:15:38] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See comments." (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179905 (owner: 10Daniel Kinzler) [15:21:56] Henning_WMDE_: https://gerrit.wikimedia.org/r/#/c/167206/ [15:26:09] (03CR) 10Hashar: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [15:27:49] (03CR) 10Hashar: [C: 032] Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [15:28:07] (03CR) 10Hashar: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177509 (owner: 10Henning Snater) [15:28:18] (03CR) 10Hashar: "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177508 (owner: 10Henning Snater) [15:29:24] (03PS6) 10Henning Snater: Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 [15:29:28] (03CR) 10jenkins-bot: [V: 04-1] Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 (owner: 10Henning Snater) [15:32:00] * hoo|lecture waves to aude [15:32:20] hi [15:33:28] aude: early swat for the changes? [15:33:45] or during train? [15:36:10] [13Wikidata.org] 15tobijat pushed 1 new commit to 06master: 02http://git.io/RVjurQ [15:36:10] 13Wikidata.org/06master 14cf0faf6 15Tobi Gritschacher: Update README.md [15:38:12] hoo|lecture: already prepared for swat [15:38:22] Awesome [15:38:34] I'll try to fix up the property suggester python stuff [15:38:41] so that we can merge later on and maybe rebuild today [15:39:00] ok [16:16:53] hi! [16:16:53] i could use some help please [16:16:53] totally new to wikidata and wiktionary, have browsed as much as i could though :) [16:16:53] i would like to have/create a list of words in various languages [16:16:53] or maybe different lists for different languages [16:16:54] the focus is not on the meanings initially, but rather for spellings [16:16:54] could you please tell/guide me how might wikidata be useful in this regard? [16:16:55] or if i could somehow make use of wiktionary? [16:29:08] ankita_: while this would definitly be good to have, this is currently out of scoep of the wikidata project. to represent words (or rather "lexical entities" or "expressions") correctly, we'd need more structure (language is complex...) [16:30:20] ankita_: there is a proposal for this, but it will be a while until it is implemented: https://www.wikidata.org/wiki/Wikidata:Comparison_of_Projects_and_Proposals_for_Wiktionary [16:30:29] ankita_: have a look at https://www.wikidata.org/wiki/Wikidata:Wiktionary [16:30:44] perhaps that gives you an idea what can or can't be done with wikidata and wiktionary right now [16:30:54] at least, you'll find people with similar interrests :) [16:32:22] (03PS1) 10Aude: New deployment branch: wmf/1.25wmf13 [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180202 [16:32:40] ^ nothing new there, in case anyone wonders [16:37:12] DanielK_WMDE_: thanks! I had looked at the second link while i was browsing through the various options google presented me with :) [16:39:16] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf13/a27c944 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44225879 [16:41:07] DanielK_WMDE_: actually, i am an intern in the outreach program, and have a need for a structure where i could store words with correct spellings [16:42:38] ankita_: how many, what kinds of words, which languages, and what information do you need to store about each word? [16:45:40] (03PS9) 10Daniel Kinzler: Implementing prefetching on top of TermIndex. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178876 [16:49:23] (03CR) 10Tobias Gritschacher: [C: 032] badgeselector: Suppress badges that refer to deleted items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180133 (owner: 10Henning Snater) [16:51:59] (03Merged) 10jenkins-bot: badgeselector: Suppress badges that refer to deleted items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180133 (owner: 10Henning Snater) [16:56:54] hello, i have a configuration issue with an installation i want to be both a repo and a client [16:58:41] despens_: hi [16:59:34] DanielK_WMDE: hi! i am not sure what i am doing wrong and what the instructions are saying [17:00:00] despens_: can you post your config to pastebin or some such? [17:00:05] if possible, also a link to your site [17:00:09] what's going wrong? [17:01:27] DanielK_WMDE_: http://pastebin.com/S0jBjgSE [17:01:52] DanielK_WMDE_: sorry the site is just an LXC on my machine [17:01:57] DanielK_WMDE_: i wonder if wiktionary might be helpful but since wiktionary is more popular with the more popular languages, therefore he purpose (of having a list with correct spellings to ensure spellcheck for the lesser popular languages) gets lost somewhere [17:04:49] ankita_: helpful for what purpose? please provide some context, i have no idea what you are trying to achieve [17:07:44] DanielK_WMDE_: okay, as we know that most of the popular languages (English, French etc) have spelling dictionaries developed for them, but the lesser popular ones dont have the same. So the project aims at creating a spelling dictionary for the lesser popular languages, and thus I have the need to create a word list [17:09:10] ankita_: do those words include things you wouldn't find a dedicated page on the english wikipedia for? [17:10:05] (e.g. "tired" doesn't have a wikipedia page, Fatigue does) [17:10:34] most of the times, for the lesser popular languages, i probably would not and thus the requirement for the project [17:10:37] ankita_: in any case, if you want lists, wikidata isn't a good tool. [17:11:12] wikidata is intended to describe concepts and their relationships. desribing words and their relationships is more complex, and not yet covered. [17:11:24] making lists is yet another can of worms. [17:11:40] in case of tired and fatigue, i'll aim at adding both those words to a list of english words so that both of them are assessed correctly as correct spellings [17:13:24] DanielK_WMDE_: IMHO a spelling dictionary should not really be concerned with relationships among words (At least that's what i saw in most of the existing spelling dictionaries, the most common being that of hunspell) [17:13:54] in fact, all i need is a simple list of words for any laguage [17:14:18] right. which is rather hard and awkward to do with wikidata, and doesn't fit the scope. sorry [17:14:30] the easiest way is probably to simply create wiki pages with lists of words. [17:14:46] depends on what functionality you want to provide based on these dictionaries, though [17:15:18] (03PS3) 10Daniel Kinzler: Batched term lookups for RC lists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180140 [17:15:26] (03CR) 10jenkins-bot: [V: 04-1] Batched term lookups for RC lists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180140 (owner: 10Daniel Kinzler) [17:16:06] okay, i'll discuss further with my mentors about the lessons learnt here :) [17:16:32] i'll get back if I could make use of wikidata somehow [17:16:44] DanielK_WMDE_: thanks a lot! :) [17:21:21] ankita_: good luck! and: too bad we don't have structured data for lexical entities yet. ask back in a year or two... [18:03:25] hello [18:03:47] so what is this place? [18:04:52] hello...? [18:05:04] google_: hi! [18:05:18] so what is this place? [18:05:22] welcome to the fun world of irc. [18:05:28] no one is chatting [18:05:37] whats it for? [18:05:42] (03CR) 10Aude: [C: 032] New deployment branch: wmf/1.25wmf13 [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180202 (owner: 10Aude) [18:06:10] (03Merged) 10jenkins-bot: New deployment branch: wmf/1.25wmf13 [extensions/Wikidata] (wmf/1.25wmf13) - 10https://gerrit.wikimedia.org/r/180202 (owner: 10Aude) [18:06:14] google_: it'S the virtual office hallway. it'S mostly quiet. but it'sa good place to find out ho's around, or ask a quick question [18:06:27] sometimes, there are big discussions, or people having fun [18:06:31] then it's quiet again [18:06:46] right... okay [18:07:17] so JD|Cloud he remains logged in [18:07:23] waiting for a discussion [18:07:24] ? [18:07:25] also, the german office is getting empty (7pm), and the california office is only just getting started (10am) [18:07:49] right so this is why its quiet... bad hours [18:08:19] that's one factor [18:08:26] but it's often quiet [18:08:36] * JD|cloud wonders why google_ pings him [18:08:49] so.... how are you daniel? [18:08:59] no reason JD [18:09:01] "waiting for a discussion" isn't quite it. it'S called "lurking" :) [18:09:06] i was using you as an example [18:09:06] or "being around". [18:09:09] sorry [18:09:41] what if nothing happens tonight? [18:10:11] google_: so, why do you call yourself google? or are you the search engine's own mind, becoming sentient? [18:10:21] if nothing happens, nothign happens [18:10:26] nobody is staring at the chat [18:10:36] it's just a channel to have open in the background. or several [18:10:46] * DanielK_WMDE as 7 irc channels open [18:11:06] what other chat places are you on? [18:11:31] i call my self google as im busy indexing everything i learn [18:11:43] mroe channels on freenode. there are hundreds. a lot of them aer about wikimedia-related stuff [18:11:53] a lot are about software projects [18:11:55] *shrug* [18:12:05] read up about freenode and irc in general [18:12:17] so programmers over that chat interface? [18:12:27] *chat over [18:12:38] *this interface? [18:12:42] programmers, wikipedia admins, gamers, whatever [18:12:45] depends on the channel [18:12:57] is this private... [18:13:01] no [18:13:18] what if yuo created a room? [18:13:38] sorry, end of irc 101. back to work. [18:13:43] its like being in limbo... lol [18:14:37] ok... i think i get the gist... [18:14:41] thanks dan [18:38:09] Lydia_WMDE: https://phabricator.wikimedia.org/T70029 [19:18:24] is anyone here that can help me with javascript? [19:18:34] otherwise, i'll figure it out myself [19:24:43] * aude thinks authority control gadget will need to be fixed [19:35:16] why the "add links" link on the left panel doesn't recognize pages in "Module" namespace? [19:36:35] e.g. here: https://fi.wikipedia.org/wiki/Moduuli:ValidateInfobox if you click "add links" and choose enwiki and start typing... "module:..." it doesn't give any suggestions [19:39:07] Stryn: uh [19:39:11] thank you for your report [19:39:21] sure [19:40:42] actually the problem seems to be with the search engine? [19:41:34] if you try to search something on en-wiki and type "module:..." no suggestions either [19:41:42] Yep, the opensearch api is broken [19:41:47] eg. https://en.wikipedia.org/w/api.php?callback=jQuery111109750149530017929_1418758663872&search=module%3Aw&action=opensearch&_=1418758663879 [19:46:01] uh... [19:46:36] why are the statements in English at https://www.wikidata.org/wiki/Q889 ? [19:46:50] (though my language is Finnish and those are translated) [19:47:16] they are translated? [19:47:17] yikes [19:47:30] Properties are English. [19:47:43] yes, properties I mean [19:48:50] wtf [19:49:47] question: if some statement has many values, like in Q889: "head of state", how do I make it to show only the one with the preferred rank on Wikipedia? if it's possible... [19:49:48] mh, fallbacks look good to me at a glance [19:50:02] Stryn: That's done per default [19:50:51] okay [19:51:08] fallbacks are new for referenced items / properties on an item page [19:51:24] But there are localized labels for them. [19:51:27] so instead of Q64, it would say Berlin if there is no label in your language [19:51:29] oh [19:51:43] There are English instead of Dutch here. [19:51:48] They* [19:52:46] WOW, we've beated Freebase. :O [19:53:42] So, the knowledge graph is Wikidata-based later? [19:55:31] Stryn: https://www.wikidata.org/wiki/Q889 is in german for me [19:55:53] what am i looking for / at [19:56:12] possible it is a hiccup from deployment [19:56:29] still English for me, when should be Finnish [19:56:38] hm [19:56:41] * aude tries finnish [19:56:53] aude: Loading a new dump and am going to try my updated PS on that [19:57:02] if that works, you can merge the PS [19:57:05] * PR [19:57:42] why putting a {{#invoke:PropertyLink|property|p36}} to https://fi.wikipedia.org/wiki/Afganistan gives "Burhanuddin Rabbani" when it should be "Ashraf Ghani" (preferred rank) [19:57:54] can reproduce :/ [19:58:07] I mean {{#invoke:PropertyLink|property|p35}} [19:58:08] the label issue [19:58:48] Stryn: https://fi.wikipedia.org/wiki/Moduuli:PropertyLink [19:58:51] that's a custom module [19:58:54] no idea what it does [19:59:03] property = property[0] [19:59:09] it probably just takes the first one [19:59:38] ah, ok, now I understand [19:59:56] if you were to use {{#property:P123}} it would work [20:00:04] but you wont have a link, then [20:09:06] "INFO:root:processed 3670.50MB" <3 [20:09:17] Something actually works :D [20:12:16] (03CR) 10Thiemo Mättig (WMDE): Allow filtering by term type in getTermsOfEntities (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179527 (owner: 10Daniel Kinzler) [20:12:59] oh wow, this sounds exciting! https://plus.google.com/109936836907132434202/posts/bu3z2wVqcQc [20:13:32] Yeah, it's super awesome. [20:13:43] woooowwwww [20:14:49] ;-) [20:14:53] \o/ also [20:15:18] they should have linked the way more awesome json dumps :P [20:15:24] dennyvrandecic: ^ [20:15:56] or both [20:16:05] true that [20:16:09] Lydia_WMDE: How long did you know this, before we heard it? :) [20:16:27] sjoerddebruin: only very short [20:16:35] :O [20:16:35] aude: hoo: deployment ok to announce? [20:16:47] There were troubles with language fallback [20:16:57] it looked fine to me, but aude said she found something [20:16:58] so not sure [20:17:05] ok waiting for aude then [20:17:09] somethign wrong with property labels on https://www.wikidata.org/wiki/Q889 [20:17:13] * Lydia_WMDE looks [20:17:16] when viewing in non-english [20:17:38] displayed in english, even if your language is finnish and there are finnish labels [20:17:55] otherwise, ok but would be nice to fix quickly [20:18:04] it looks fine in german for me [20:18:09] trying finish [20:18:52] https://www.wikidata.org/wiki/Q889?uselang=ru [20:18:57] all in English :( [20:19:03] hmmmmmm [20:19:11] yeah finish looks wrong [20:19:19] is it only that item? [20:19:27] * Lydia_WMDE checks [20:19:39] nope [20:19:44] just checked a random one [20:19:47] hmmmm [20:19:50] me too [20:20:35] but German looks fine [20:20:37] strange. [20:20:42] very [20:20:47] they were ok like one hour ago or so [20:21:24] hoo, aude: maybe finish is missing from the terms table for some reason?... [20:21:39] and Russian? [20:21:39] would be strange too, but would explain what we see [20:21:42] DanielK_WMDE: and russian? [20:21:47] i dunno [20:21:53] Dutch also shows English. ;) [20:21:53] * aude wonders if parser cache issue [20:22:06] action=purge doesn't help [20:22:07] trying to investigate [20:22:20] editing the item should fix any parser cache issue. [20:22:22] hm... [20:23:28] aude, hoo, Lydia_WMDE: the property names of qualifiers look fine [20:23:35] now *that's* strange [20:23:41] Oo [20:23:47] they should be using the same EntityIdFormatter thingy [20:24:42] it seems that only English and German are showing with their language [20:24:48] ah, wait [20:24:53] racism :O [20:24:58] xD [20:24:59] sjoerddebruin: psst [20:25:04] aude, hoo: turn off JS [20:25:20] then it's always english [20:25:37] wtf [20:25:51] no [20:25:57] german still works... [20:26:06] but without JS, qualifierers are in english too [20:26:16] oh, qualifiers [20:26:30] wth [20:26:35] referenced items work though [20:27:10] the fact that German works makes this really strange. [20:27:30] i am on the branch locally [20:27:33] otherwise my guess would be that the formatter for the property ids gets the wrong language [20:27:43] changing language to language, seems to work ok [20:28:05] it's not a parser cache issue. otherwise, all text on the page would be affected [20:29:12] all languages that fallback on German seem to work [20:29:23] it's *something* about the $propertyIdFormatter the SnakHtmlGenerator gets [20:29:39] cannot reproduce [20:29:54] o_O [20:30:13] this is using EntityInfo now. no caching. that hits the database when generating html [20:31:11] (03PS3) 10Thiemo Mättig (WMDE): Rework and clean up TermIndex interfaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179931 [20:33:08] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "No strong reason left to block this patch, thanks for the latest patch set. However, I would love to see my follow up merged (not strictly" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179527 (owner: 10Daniel Kinzler) [20:34:17] the labels are in the wb_terms table too. [20:34:20] i don't get it. [20:34:30] Yeah, checked that as well [20:34:37] that would have been a catastrophe [20:34:59] so... a bug in LanguageFallbackChain? [20:35:14] but that would be reproducible locally... [20:35:54] (03Merged) 10jenkins-bot: Allow filtering by term type in getTermsOfEntities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179527 (owner: 10Daniel Kinzler) [20:35:55] uls doesn't open on the contact the dev team page for me [20:35:57] related maybe? [20:36:26] DanielK_WMDE: but that wouldn't explain the difference between properties in statements and qualifiers? [20:36:35] ULS screw up could explain that, if it interfers with Language::factory [20:36:51] Lydia_WMDE: not really, no. [20:37:32] purge doesn't fix it either on contact the dev team [20:37:34] hmmm [20:41:06] i probably haven't updated my uls in a while [20:41:47] Date: Sun Nov 9 21:54:43 2014 +0100 [20:42:02] plausible to explain difference in what i see locally [20:45:14] it's using EntityInfo [20:45:23] $this->languageCode gets passed to it [20:46:23] which seems to come from $options->getUserLang(); [20:47:19] [13ValueView] 15thiemowmde comment on pull request #137 146d46f46: I'm not happy with how this variable is used for two very different things. My main problem is: I don't think it can be guaranteed all implementations of `setTimeout` are returning a value of type `number`. Could be a resource type or something. I suggest to set the default to `false` and switch all `typeof this._searching === 'number'` checks to `typeof this._searching !== 'boolean' [20:51:48] adding sitelinks is broken [20:52:10] (clicking on [edit] doesn't do anyting) [20:52:14] yes, clicking on edit doesn't do anuthing [20:52:14] anything* [20:53:37] Lydia_WMDE: ^ [20:53:55] waaaaaaah [20:53:57] looking [20:54:01] TypeError: this._refreshTablesorter is not a function [20:54:03] ah crap [20:54:09] ugh [20:54:55] :( [20:55:17] only sitelink sections seems affected though? [20:55:27] in other languages box looks fine here [20:55:37] and statements too [20:55:45] Sitelinks only. [20:55:55] can we for no go back to the old branch and fix later on, tomorrow? Might be the way to go here [20:56:03] * or tomorrow [20:56:42] *nod* [20:56:44] I'll be back later on [20:56:45] think i see the problem [21:00:49] hoo|away: refreshTablesorter is not in our code base any more, probably a cache/purge issue? [21:01:50] no, it is still needed in the branch [21:09:45] (03PS1) 10Aude: Re-add _refreshTablesorter and _refreshTableHeader sitelinklistview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 [21:11:17] (03CR) 10Aude: "see https://gerrit.wikimedia.org/r/#/c/180171/1/lib/resources/jquery.wikibase/jquery.wikibase.sitelinklistview.js" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 (owner: 10Aude) [21:11:58] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I wonder what strange backport that was, but yea, this is a possible solution. I came to the same conclusion." [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 (owner: 10Aude) [21:12:58] hi? [21:13:10] hi [21:14:29] aude, I'm thinking about this data I have. I have some of the predicates worked out (though not all) and now I'm wondering if there's value in linking abstract classes from my dataset to Wikidata. And if there is value- how do to that? [21:14:40] aude, these are thing like "apple" or "carrot" [21:16:22] wikimedia/mediawiki-extensions-Wikibase/master/b14d672 : Translation updater bot The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44255284 [21:18:26] emacsen: aude is busy with fixing a bug in production. will have to wait a bit probably :) [21:18:38] Lydia_WMDE, well she answered :) [21:18:49] Lydia_WMDE, I asked the question earlier and no one answered [21:19:15] emacsen: probably are many people here who could answer [21:19:30] or ask on project chat or mailing list [21:19:54] aude, I'm happy to ask in the right place, URL for mailing list? [21:20:37] (03CR) 10Aude: [C: 032] Re-add _refreshTablesorter and _refreshTableHeader sitelinklistview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 (owner: 10Aude) [21:20:50] Lydia_WMDE: i'll get that deployed [21:20:56] \o/ [21:20:59] thanks so much aude [21:21:09] then give self another 30 min or so to look at the other bug [21:21:18] https://lists.wikimedia.org/mailman/listinfo/wikidata-l [21:21:29] aude: cool [21:21:41] aude: i will hold of sending announcement until you give green light [21:21:43] then decide whether we still should revert for tonight [21:21:51] k [21:23:21] (03CR) 10jenkins-bot: [V: 04-1] Re-add _refreshTablesorter and _refreshTableHeader sitelinklistview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 (owner: 10Aude) [21:23:30] grrr [21:26:18] (03PS2) 10Aude: Remove unused method param in PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179890 [21:26:43] looks like maybe an incompatibility with some core change [21:27:04] because of the odd branch name, it's master core + this branch being tested [21:27:23] https://gerrit.wikimedia.org/r/#/c/178601/ looks suspicious [21:27:54] (03CR) 10Aude: Re-add _refreshTablesorter and _refreshTableHeader sitelinklistview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 (owner: 10Aude) [21:28:02] (03CR) 10Aude: [C: 032] Re-add _refreshTablesorter and _refreshTableHeader sitelinklistview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 (owner: 10Aude) [21:30:18] (03CR) 10jenkins-bot: [V: 04-1] Remove unused method param in PropertyView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/179890 (owner: 10Aude) [21:30:53] Lydia_WMDE: Are you going to send something about the Freebase thing on the mailing list? [21:31:02] (03CR) 10jenkins-bot: [V: 04-1] Re-add _refreshTablesorter and _refreshTableHeader sitelinklistview [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 (owner: 10Aude) [21:31:33] sjoerddebruin: in addition to what denny sent? i didn't plan to besides a sentence in the announcement for the deployment later today [21:31:41] sjoerddebruin: anything you think should come from me? [21:32:17] Okay, that's also good. :P [21:32:26] You're the messenger. :) [21:32:35] heh well in this case i am not really [21:32:57] mostly uninvolved really besides answering questions by community (wd and fb) and press [21:33:11] but so far things are looking good to me :) [21:34:08] not so happy about people saying we will import all freebase data into wikidata [21:34:09] but oh well [21:34:16] not much we can do there [21:35:17] aude: Any progress? [21:37:37] Lydia_WMDE: explain or links pls [21:37:41] jenkins says "no" but it's unrelated [21:37:47] and think incompatibility or issue with core [21:37:53] https://gerrit.wikimedia.org/r/#/c/180299/ [21:37:54] JohnFLewis: hmm? [21:38:05] looking at the other issue [21:38:14] Lydia_WMDE: I saw chat about db and wd with he the word press :p [21:38:15] we coiuld go ahead and get https://gerrit.wikimedia.org/r/#/c/180299/ out [21:38:22] *fb [21:38:48] JohnFLewis: https://groups.google.com/forum/#!topic/freebase-discuss/s_BPoL92edc [21:38:57] merge https://github.com/Wikidata-lib/PropertySuggester-Python/pull/15 :D [21:40:12] (03CR) 10Thiemo Mättig (WMDE): "recheck" [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/180185 (owner: 10Thiemo Mättig (WMDE)) [21:41:26] Lydia_WMDE: ah. Wikidata FTW? :p [21:41:40] JohnFLewis: that's an acceptable summary ;-) [21:42:04] * Lydia_WMDE curses spammers [21:42:11] so many spam mails in moderation [21:42:23] Lydia_WMDE: oh and don't worry about the summary this week - :p [21:42:30] hehe [21:42:38] <3 [21:43:10] Hm, which mail list moderation? [21:46:39] wikidata-l atm - nearly through [21:47:29] I'll see what I can do to the filters tomorrow then [21:47:39] Bugs and tech are fine though? [21:48:24] nah same :( [21:48:28] but much less on tech [21:48:36] generally getting less crap [21:48:50] if you could have a look at the filter that'd be awesome [21:49:22] Does bugs get any? Can we just deny all non phab mail to that actually (or if we do already :p) [21:49:51] rsync -r wikidata-suggester.eqiad.wmflabs:/data/project/property-suggester/wbs_propertypairs wikimedia-git-repos/ [21:50:01] that's like /slow/ [21:50:15] JohnFLewis: nothing useful besides phabricator there so that might actually be a good solution for that [21:50:37] I'll redo the lists tomorrow then [21:51:15] \o/ [21:53:55] huh, i have no submit button for https://gerrit.wikimedia.org/r/#/c/180299/ [21:54:18] i am convinced the failure must be related to https://gerrit.wikimedia.org/r/#/c/180299/, which was merged after i uploaded my patch [21:54:33] jenkins initially approved my patch [21:54:38] aude: You need to remove jenkins and V+2 yourself [21:55:05] ah [21:55:37] shall investigate the jenkins issues obviously asap as it probably will affect master wikibase [21:57:46] (03CR) 10Aude: [V: 032] "jenkins initially approved, and now is complaining about unrelated api tests. this is likely due to some change merged recently in core (e" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180299 (owner: 10Aude) [21:57:50] there [21:58:32] jenkins disapproves of https://gerrit.wikimedia.org/r/#/c/179890/ also which i just rebased [21:59:10] Lydia_WMDE: or someone, if you want to make a phabricator task for that, would be appreciated [21:59:28] aude: for what exactly? happy to put it in [21:59:35] see https://gerrit.wikimedia.org/r/#/c/179890/ [21:59:37] k [21:59:59] probalby our BotEditTest depends on some evil global setting [22:14:40] aude: bug found and fixed [22:15:15] do we have a ticket, yet? [22:16:07] no [22:18:53] hoo: for what aude asked me to file? [22:18:54] i did [22:19:01] oh, link? [22:19:06] or I only need the number [22:19:06] sec [22:19:06] * aude hopes hoo fixed the other bug [22:19:16] labels? [22:19:22] No :/ [22:19:25] I fixed the test thing [22:19:30] pretty obvious one [22:19:32] ah [22:19:32] https://phabricator.wikimedia.org/T78712 [22:19:36] well, that helps [22:19:44] i'm trying to reproduce [22:20:13] (03PS1) 10Hoo man: Don't cache the TestUser instance in BotEditTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180323 [22:20:26] aude: ^ [22:20:35] That was one of the test run time things you did back then [22:20:47] not really that important given my optimization of TestUser itself [22:24:53] going home now. i'll be back online in 30ish minutes i think [22:27:50] (03PS1) 10Aude: Update Wikidata, fix issue with editing site links [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180326 [22:27:58] Lydia_WMDE: not home yet? [22:28:16] please go home [22:29:23] aude: I'm about to update the property suggester [22:29:27] anything blockignt aht [22:29:36] I have the new data in git: u [22:29:42] * https://github.com/wmde/wbs_propertypairs/commit/669376495d0e6689f23c07103ecea70298032666 [22:29:59] woah [22:30:02] bye bye freebase [22:30:18] search function - selection of other namespaces does not work... [22:30:40] Romaine: What search function? [22:30:58] Romaine: there's a patch awaiting deployment [22:31:20] ok [22:31:50] thanks, legoktm :) [22:31:55] hoo: go ahead [22:32:08] hoo: Entity suggester? :D [22:32:12] Romaine: known issue [22:32:16] ok, thanks [22:32:40] the suggester in the search box only works for entities [22:32:51] different than default mediawiki one [22:33:06] we need to somehow combine them [22:33:36] yet, we have items for stuff like "Help:Contents" as well as a local page for that [22:33:41] sjoerddebruin: Yes! [22:33:44] <3 [22:40:46] hoo: Oh, it's already updated? [22:41:01] just did that, yes [22:41:21] Let me finish my item and take a look. :) [22:41:52] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12c/e492c50 : aude The build was broken. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/44262807 [22:43:59] (03CR) 10Aude: [C: 032] Update Wikidata, fix issue with editing site links [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180326 (owner: 10Aude) [22:44:18] (03Merged) 10jenkins-bot: Update Wikidata, fix issue with editing site links [extensions/Wikidata] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180326 (owner: 10Aude) [22:44:28] aude: Y u no merge my test fix? [22:45:05] sjoerddebruin: Scheduled the configuration update for the late SWAT today (in 1:15h) [22:45:11] so then everything should be set [22:45:19] Oh, it's not live yet. [22:45:19] hoo: can't look right now [22:45:26] sorry :S [22:45:48] I hope my work in the last few months helped. :D [22:47:25] ok, i can sort of reproduce the issue [22:47:29] it's strange [22:47:41] Anyway, going to bed. Hope to see some nice results tomorrow. :D [22:48:35] my properties are imported from wikidata so have all the languages [22:48:43] some display in english, some in german [22:48:55] despite having labels in both [22:49:05] * hoo wishes he had time to poke :( [22:49:23] i can probably figure it out nowe [22:49:35] really hard to debug on terbium [22:57:17] re :) [22:57:54] think i got it [22:58:29] \o/ [22:58:45] Nice [23:01:44] the code seemed to assuem there was just one label in the EntityInfo array (for property) [23:01:56] i now have more than one, and it's random which order they are [23:02:09] but selects the first one it seems [23:02:26] on master, we do it a better way entirely [23:03:33] Can we backport? [23:04:52] not trivial [23:05:00] but looking, maybe [23:21:23] Lydia_WMDE: language fallback for property labels won't be perfect with my fix [23:21:38] we might be able to fix that tomorrow [23:21:40] (03PS1) 10Aude: Fix of property label formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 [23:22:10] we'd have to look more carefully / closely if we can get the stuff on master in for this [23:25:16] aude: will cod ereivew [23:25:37] (03CR) 10jenkins-bot: [V: 04-1] Fix of property label formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 (owner: 10Aude) [23:25:39] ok [23:25:45] oh [23:25:48] aude: ok :) so no revert? what's still not good? then i will send announcement and can mention that [23:25:48] am looking at your test patch [23:25:58] aude: this should be fixed on master [23:26:06] DanielK_WMDE: doesn't exist on master [23:26:19] exactly :) [23:26:27] ah, i see [23:26:45] aude: Think you forgot to update some SnakHtmlGenerator usages [23:26:59] yeah [23:27:01] will do [23:27:17] give me one more second before uploading a new PS [23:28:12] (03CR) 10Hoo man: Fix of property label formatting (032 comments) [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 (owner: 10Aude) [23:28:18] ah [23:28:18] Might be a non-issue [23:28:33] new ps for what? [23:28:44] for fixing the usages [23:28:47] ok [23:28:51] not sure stuff I commented needs fixing [23:29:26] comemnting [23:30:43] (03CR) 10Aude: Fix of property label formatting (032 comments) [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 (owner: 10Aude) [23:31:02] although i get P31 and whatnot [23:31:10] even though it hasan english label [23:31:28] can't remember how it worked before on wikidata (maybe like that?) [23:31:34] aude: mh... relying on LinkBegin is not a problem perofrmance wise? [23:31:36] would be nice to have the fallback [23:32:04] ok, let's see [23:32:11] or are you making a patch? [23:32:23] No, go ahead [23:32:59] ok [23:54:45] (03CR) 10Aude: [C: 032] Don't cache the TestUser instance in BotEditTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/180323 (owner: 10Hoo man) [23:55:09] (03PS2) 10Aude: Fix of property label formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 [23:55:19] i think the best thing to do is see about backporting what is on master for this (tomorrow) [23:55:44] but merge that hotfix tonight (and revert tomorrow) [23:55:45] for now, i think this might have to do for now [23:55:49] yes [23:56:18] ok, and it isn't totally killing stuff performance wise? [23:56:19] i tried making language fallback work better but too non-trivial [23:56:32] i doubt it [23:56:53] I don't want to see us hammer down external storage or something like that [23:57:03] after all, we were loading entities before for all the other labels [23:57:06] if LinkBegin is using a cached LabelLookup or so that shouldn't be an issue [23:57:13] true also [23:57:36] Let's just wait for jenkins [23:57:38] it loads them still from memcached (whatever is used for revisions) with link begin [23:57:54] Backport the test fix? [23:58:04] i htink so [23:58:21] (03PS1) 10Aude: Don't cache the TestUser instance in BotEditTest [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180355 [23:58:23] would like jenkins to approve [23:59:01] (03CR) 10jenkins-bot: [V: 04-1] Fix of property label formatting [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180348 (owner: 10Aude) [23:59:20] (03CR) 10Hoo man: [C: 032] "test only, per master" [extensions/Wikibase] (wmf/1.25wmf12c) - 10https://gerrit.wikimedia.org/r/180355 (owner: 10Aude)