[02:01:48] is the wikidata json dump format documented somewhere? [02:01:50] * YuviPanda is just curious [06:40:45] not sure if this is the right place to ask or if anybody's here at this time, but what is the right thing to do if I see some data in wikidata.org that looks weird? [06:41:52] i.e. Q3090993 is declared subclass of profession (via handicraft->craft->profession) which I suspect is wrong [07:21:39] SMalyshev: use [[Wikidata:Project chat]] if you don't know what to do [07:22:13] If the error is not urgent, just comment on talk page and eventually™ someone will see it [07:23:21] Nemo_bis: thanks, I'll add it to the chat. [09:13:54] [13ValueView] 15snaterlicious 04force-pushed 06suggesterissearching from 1489b87a2 to 14f2d07eb: 02http://git.io/-g6kVQ [09:13:54] 13ValueView/06suggesterissearching 14f2d07eb 15snaterlicious: $.ui.suggester: Added isSearching()... [10:19:59] (03CR) 10Daniel Kinzler: [C: 032] Only select fields we need in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178700 (owner: 10Hoo man) [10:24:00] (03Merged) 10jenkins-bot: Only select fields we need in WikiPageEntityRevisionLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178700 (owner: 10Hoo man) [10:35:09] (03CR) 10Daniel Kinzler: [C: 04-1] "I do not quite see the point of this. We will always have to load the full content object for the entity we are showing. Why try so hard t" (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [10:37:05] (03CR) 10Daniel Kinzler: [C: 032] Fix warnings and general clean up in ChangeHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171569 (owner: 10Thiemo Mättig (WMDE)) [10:37:47] (03CR) 10Aude: "something seems possibly not right here. it's making things somewhat slower for me with a large item. it seems logical thing to do to def" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167224 (owner: 10Daniel Kinzler) [10:40:46] (03Merged) 10jenkins-bot: Fix warnings and general clean up in ChangeHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171569 (owner: 10Thiemo Mättig (WMDE)) [10:50:53] (03PS1) 10Ricordisamoa: Replace deprecated configuration variable $wgSpecialPageGroups [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178804 [11:11:41] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf12/8ee18cb : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/43582019 [11:16:25] aude: Not sure you saw earlier on, but the dump we created overnight was incomplete (again) [11:16:37] So I added logging of stderr to the script that creates the dumps [11:16:46] :( [11:16:58] rage to the ops bazillion times [11:17:00] And had the process re-restarted [11:17:14] Yeah :/ [11:17:30] I hope that we catch the problem this time [11:17:37] now that the slow query has been fixed [11:17:40] hope so [11:17:55] dump from tonight was 3.1gb, so way bigger than the failed one from Monday [11:18:05] but it only had 13M entities [11:18:12] so still a lot missing [11:18:21] strange [11:18:37] No php errors logged [11:18:49] but with the new stderr logging we should be able to find the cause [11:18:50] I hope [11:26:22] (03PS1) 10Aude: New Wikidata build - 2014/12/10 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/178813 [11:39:30] aude: Did you branch yesterday, btw? [11:41:38] was hoping to get daniel's deferred entity deserializaiton thing in, so not yet [11:41:42] but am making branch now [11:41:46] (03PS1) 10Henning Snater: Returning promise in $.wikibase.listview.enterNewItem() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178820 [11:41:48] (03PS1) 10Henning Snater: Focus referenceview when adding a new referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178821 [11:41:48] aude: Ok [11:41:50] (03PS1) 10Henning Snater: Focus snakview when adding a new snakview to a referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178822 [11:42:02] Without it, I guess? [11:42:05] yes [11:42:08] :/ [11:42:25] i think we already have good improvements with reusing EntityInfo [11:42:26] Is my WikiPageEntityRevisionStore thing in? [11:42:39] if someone merged it [11:42:48] Daniel did earlier on [11:43:03] I have no metrics, but I think we spend quite a bit of time there [11:43:17] especially in maint. scripts and so that load a lot of entitie [11:43:17] s [11:51:09] (03PS1) 10Henning Snater: Focus new snakview when adding a qualifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178823 [11:53:36] (03PS1) 10Daniel Kinzler: Add FOR_UPDATE flag to getLatestRevisionId. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178825 [11:54:05] (03PS1) 10Aude: New deployment branch - wmf/1.25wmf12 [extensions/Wikidata] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178826 [11:54:51] (03CR) 10Aude: [C: 032] New Wikidata build - 2014/12/10 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/178813 (owner: 10Aude) [11:56:47] (03CR) 10Daniel Kinzler: [C: 031] "Seems like the right thing to do. Didn't verify." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178422 (owner: 10Aude) [11:56:56] (03Merged) 10jenkins-bot: New Wikidata build - 2014/12/10 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/178813 (owner: 10Aude) [11:57:11] (03CR) 10jenkins-bot: [V: 04-1] Focus new snakview when adding a qualifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178823 (owner: 10Henning Snater) [12:01:32] (03CR) 10jenkins-bot: [V: 04-1] Add FOR_UPDATE flag to getLatestRevisionId. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178825 (owner: 10Daniel Kinzler) [12:02:01] (03PS2) 10Henning Snater: Returning promise in $.wikibase.listview.enterNewItem() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178820 [12:02:26] DanielK_WMDE_: Why did you choose FOR_UPDATE for the constant? Sounds like you would use SELECT ... FOR UPDATE [12:02:47] which would take us into deadlock land :P [12:47:05] be back later [13:01:25] (03CR) 10JanZerebecki: [C: 04-1] "Missing tests for the new arguments in lib/tests/phpunit/store/CachingEntityRevisionLookupTest.php" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178825 (owner: 10Daniel Kinzler) [13:04:05] [13WikidataBrowserTests] 15tobijat created 06adjust_sitelink_tests (+1 new commit): 02http://git.io/G0-y7Q [13:04:05] 13WikidataBrowserTests/06adjust_sitelink_tests 149aca1e1 15Tobias Gritschacher: Adjust sitelink tests to sticky-notifications [13:04:49] aude: can I already merge in changes to the sitelink UI? [13:05:03] has the branch been made? [13:05:03] yes [13:05:05] yes [13:05:06] ok [13:05:15] do selenium tests approve? [13:05:16] jzerebecki: not easy to test. i was thinking about that, but couldn't come up with a good way. [13:05:25] i could test that the flag is passed through, but that's abotu it [13:11:01] aude: approve what? [13:11:05] the branch? [13:11:09] or the sitelinks? [13:11:33] all of it :) ... most important what is on beta today [13:11:41] which is same as the branch [13:11:59] aude: did not make a new build yet, so think on beta is what was there yesterday. but making one now. [13:12:03] i made one [13:12:08] yesterday was approved [13:12:14] good [13:12:16] ah, ok [13:12:32] there were few changes since yesterday [13:12:49] so if yesterday was ok, today should be also [13:14:21] aude: regular schedule for the tests is in one hour [13:14:26] ok [13:14:43] so, we'll have a result around 17 or 18 [13:14:48] :) [13:14:54] the full test set runs 2,5h [13:15:36] DanielK_WMDE_: what else would there be to test for a unit test? a unit test for WikiPageEntityRevisionLookup would then test that it makes the apropriate request on the correct db connection (master instead of slave). running our db integration tests on a cluster with simulated replication lag is an interesting idea though :) , probably worthwile, but i think we have more important tests we need to add before, out of scope for this patch anyway. [13:16:15] jzerebecki: yea, but i don't even see how i'd check that the query goes to the right db connection. [13:16:24] would have to moch the global load balancer, or some evil trick like that [13:16:25] aude: could trigger them now [13:16:37] if you want [13:19:35] (03PS2) 10Daniel Kinzler: Add FOR_UPDATE flag to getLatestRevisionId. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178825 [13:20:17] (03CR) 10Tobias Gritschacher: [C: 032] Optimized sticknode mechanisms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174085 (owner: 10Henning Snater) [13:21:57] (03PS1) 10Daniel Kinzler: EntityRevisionLookupTest must use mock databases. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178832 [13:22:12] jzerebecki: --^ [13:22:54] (03CR) 10Tobias Gritschacher: [C: 032] Implemented sticky notification for site link sections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174719 (owner: 10Henning Snater) [13:23:49] [13WikidataBrowserTests] 15tobijat opened pull request #33: Adjust sitelink tests to sticky-notifications (06master...06adjust_sitelink_tests) 02http://git.io/qQF7Kg [13:24:50] (03Merged) 10jenkins-bot: Optimized sticknode mechanisms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174085 (owner: 10Henning Snater) [13:25:08] (03Merged) 10jenkins-bot: Factored out error output generation from wbtooltip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174089 (owner: 10Henning Snater) [13:29:27] DanielK_WMDE_: yea there are currently no unit tests for WikiPageEntityRevisionLookup. one would mock $this->getConnection() and see if it requests the correct one. but as we do that nowhere we probably do not need to do that for this patch. [13:30:09] (03Merged) 10jenkins-bot: Implemented sticky notification for site link sections [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174719 (owner: 10Henning Snater) [13:39:58] (03PS6) 10Aude: Don't use (or need) Content (again) in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 [13:40:26] (03CR) 10Aude: ""Why try so hard to avoid accessing it?"" (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [13:46:44] (03CR) 10Aude: "interestingly, getContent is called 3 times on master:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [13:51:44] [13ValueView] 15thiemowmde comment on pull request #137 14f2d07eb: Please add `delete this.__searching`. 02http://git.io/0aL82Q [13:53:07] [13ValueView] 15thiemowmde comment on pull request #137 14f2d07eb: I find this odd. Does this mean you are reusing the same variable for two different things? Wouldn't it be better to use two variables? 02http://git.io/djQzzA [13:54:17] [13ValueView] 15thiemowmde comment on pull request #137 14f2d07eb: `this`? Not `self`? 02http://git.io/3XH06g [13:56:28] (03CR) 10Aude: "looked more... the 1x call to getContent appears to be to check if redirect." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [13:58:41] (03PS2) 10Tobias Gritschacher: Focus referenceview when adding a new referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178821 (owner: 10Henning Snater) [13:59:12] (03PS3) 10Tobias Gritschacher: Focus referenceview when adding a new referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178821 (owner: 10Henning Snater) [13:59:31] (03PS2) 10Tobias Gritschacher: Focus snakview when adding a new snakview to a referenceview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178822 (owner: 10Henning Snater) [13:59:48] (03PS2) 10Tobias Gritschacher: Focus new snakview when adding a qualifier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178823 (owner: 10Henning Snater) [14:08:26] (03PS6) 10Tobias Gritschacher: sitelinkview: Implemented "remove" toolbar with icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176658 (owner: 10Henning Snater) [14:16:30] (03CR) 10Aude: "with both this patch and deferred deserialization, when viewing my test item:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [14:18:14] [13WikibaseDataModel] 15thiemowmde created 06var (+1 new commit): 02http://git.io/h7hTWg [14:18:14] 13WikibaseDataModel/06var 14502cd9b 15Thiemo Mättig: Remove redundant var name from doc [14:24:31] aude: Tobi_WMDE_SW: https://phabricator.wikimedia.org/T76860 <- is that in the next deployment? if not worth considering for a backport imho [14:25:09] i think we want to backport all of th epatches [14:25:16] some might already be in [14:25:20] Lydia_WMDE: asked during daily if it is worth a backport but team was not sure.. :) [14:25:32] lydia says yes [14:25:35] :D [14:25:41] wmde/WikibaseDataModel/var/502cd9b : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/43601380 [14:25:45] personally I think we should backport, but the patches for references and qualifiers are still in review [14:25:50] ok [14:25:50] ok [14:26:09] those are a bit tricky [14:26:30] but fixing it for statements would be an improvement already [14:26:35] agreed [14:27:24] would be https://gerrit.wikimedia.org/r/#/c/178477/ and https://gerrit.wikimedia.org/r/#/c/178476/ then [14:28:43] Henning_WMDE: https://github.com/wmde/WikidataBrowserTests/pull/33 [14:30:34] (03PS7) 10Tobias Gritschacher: sitelinkview: Implemented "remove" toolbar with icon [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176658 (owner: 10Henning Snater) [14:33:02] [13DataValues] 15thiemowmde created 06unserialize (+1 new commit): 02http://git.io/vuQfAA [14:33:02] 13DataValues/06unserialize 144d9ebc9 15Thiemo Mättig: Remove misleading return doc [14:35:06] [13DataValues] 15thiemowmde opened pull request #15: Remove misleading return doc (06master...06unserialize) 02http://git.io/zU4eQA [14:37:20] [13WikidataBrowserTests] 15snaterlicious closed pull request #33: Adjust sitelink tests to sticky-notifications (06master...06adjust_sitelink_tests) 02http://git.io/qQF7Kg [14:37:57] [13Common] 15thiemowmde created 06unserialize (+1 new commit): 02http://git.io/p-bhqA [14:37:57] 13Common/06unserialize 14da92cb3 15Thiemo Mättig: Remove misleading return doc [14:38:25] [13Common] 15thiemowmde opened pull request #13: Remove misleading return doc (06master...06unserialize) 02http://git.io/LMXDMA [14:39:42] [13Geo] 15thiemowmde created 06unserlialize (+1 new commit): 02http://git.io/-WSxGw [14:39:42] 13Geo/06unserlialize 1441d4ab4 15Thiemo Mättig: Remove misleading return doc [14:39:58] [13Geo] 15thiemowmde opened pull request #40: Remove misleading return doc (06master...06unserlialize) 02http://git.io/wr79rg [14:41:04] [13Number] 15thiemowmde created 06unserlialize (+1 new commit): 02http://git.io/dj2i5Q [14:41:04] 13Number/06unserlialize 14c4ee11c 15Thiemo Mättig: Remove misleading return doc [14:41:29] [13Number] 15thiemowmde opened pull request #17: Remove misleading return doc (06master...06unserlialize) 02http://git.io/aR2fuw [14:43:32] [13Time] 15thiemowmde created 06unserlialize (+1 new commit): 02http://git.io/9Brg5A [14:43:32] 13Time/06unserlialize 14c730420 15Thiemo Mättig: Remove misleading return doc [14:43:57] [13Time] 15thiemowmde opened pull request #26: Remove misleading return doc (06master...06unserlialize) 02http://git.io/4IhATA [14:45:15] (03CR) 10Aude: [C: 031] "I think this will provide overall benefit and is needed and looks okay to me." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167224 (owner: 10Daniel Kinzler) [14:45:19] (03PS1) 10Daniel Kinzler: Filter labels by languages earlier. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 [14:46:43] (03CR) 10Daniel Kinzler: [C: 04-1] "Needs benchmark, see comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [14:46:45] [13WikibaseDataModel] 15thiemowmde created 06unserlialize (+1 new commit): 02http://git.io/1dlDmA [14:46:45] 13WikibaseDataModel/06unserlialize 14139993d 15Thiemo Mättig: Remove misleading return doc [14:48:15] (03PS2) 10Daniel Kinzler: Filter labels by languages earlier. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 [14:48:33] (03CR) 10Daniel Kinzler: [C: 04-1] "Needs benchmark, see comment on PS1" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [14:48:54] [13WikibaseDataModel] 15thiemowmde opened pull request #324: Remove misleading return doc (06master...06unserlialize) 02http://git.io/5uA9Vg [14:49:25] (03CR) 10JanZerebecki: [C: 032] EntityRevisionLookupTest must use mock databases. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178832 (owner: 10Daniel Kinzler) [14:51:17] (03CR) 10Aude: "already benchmarked when implementing this. deferring such filtering until here was better." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [14:51:17] Thiemo_WMDE: merge?! https://gerrit.wikimedia.org/r/#/c/172796/16 [14:51:22] the chain is growin longer... [14:51:46] (03CR) 10Aude: [C: 04-1] Filter labels by languages earlier. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [14:52:40] jzerebecki: Thiemo_WMDE: can one of you take a look at https://gerrit.wikimedia.org/r/#/c/167224/ as aude wanted a second person having a look. [14:52:58] (03CR) 10jenkins-bot: [V: 04-1] Filter labels by languages earlier. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [14:53:06] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newMethods from 14b8306f1 to 141aa1ba1: 02http://git.io/6FMa1g [14:53:06] 13WikibaseDataModel/06newMethods 141aa1ba1 15Thiemo Mättig: Add GUID to constructors [14:53:29] Tobi_WMDE_SW: or i look later [14:53:40] (03Merged) 10jenkins-bot: EntityRevisionLookupTest must use mock databases. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178832 (owner: 10Daniel Kinzler) [14:53:59] (03CR) 10Aude: "maybe we can do some benchmarking on terbium or somewhere." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [14:55:26] wmde/WikibaseDataModel/unserlialize/139993d : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/43605201 [14:55:27] (03CR) 10Aude: Defer entity deserialization (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167224 (owner: 10Daniel Kinzler) [14:58:25] [13Common] 15thiemowmde 04force-pushed 06covers from 143889d97 to 149b309ea: 02http://git.io/s__fZQ [14:58:25] 13Common/06covers 149b309ea 15Thiemo Mättig: Add missing @covers tags [14:58:45] (03CR) 10Daniel Kinzler: "14:50:19 There were 3 failures:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [15:03:00] is this the planned phabricator down-time? [15:03:06] i guess so.. [15:10:00] Tobi_WMDE_SW: Henning_WMDE: has one of you looked into https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Scroll_bar_issue already? [15:12:03] [13Common] 15thiemowmde created 06nonOptional (+1 new commit): 02http://git.io/ln6bQw [15:12:03] 13Common/06nonOptional 14518beb7 15Thiemo Mättig: Fix broken tests [15:14:20] [13Common] 15thiemowmde opened pull request #14: Fix broken tests (06master...06nonOptional) 02http://git.io/ZN0Uzg [15:20:55] [13Common] 15thiemowmde created 06private (+1 new commit): 02http://git.io/ORf_sw [15:20:55] 13Common/06private 148babbd0 15Thiemo Mättig: Make class properties private [15:22:09] [13Common] 15thiemowmde opened pull request #15: Make class properties private (06master...06private) 02http://git.io/tNMYOg [15:24:27] jzerebecki: https://gerrit.wikimedia.org/r/#/c/178844/2/lib/includes/store/sql/TermSqlIndex.php [15:39:11] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 142c33b14 to 142da9f94: 02http://git.io/uH6jlQ [15:39:11] 13WikibaseDataModel/06emptyFingerprint 142da9f94 15Thiemo Mättig: Allow constructing empty Fingerprint [15:41:24] [13WikibaseDataModel] 15thiemowmde closed pull request #293: Simplify setStatements( new StatementList() ) (06master...06dropStatements) 02http://git.io/FLFowQ [15:43:34] Lydia_WMDE: not exactly sure what he means.. [15:43:45] is that on wikidata.org? [15:43:57] yeah [15:44:19] I do not know what he menas by "floating sitelink section sidebar" [15:44:31] is that a gadget or something? [15:44:37] hmmm wait [15:44:39] right [15:44:50] ok i will ask some more [15:45:21] Lydia_WMDE: for me it works fine when scrolling around the sitelinks on any item on wikidata.org [15:45:27] also with webkit browser [15:45:42] k [15:45:43] thx [15:50:52] [13ValueView] 15thiemowmde 04force-pushed 06termtrim from 14cda3eb8 to 146a82536: 02http://git.io/Vkh5Ww [15:50:52] 13ValueView/06termtrim 146a82536 15Thiemo Mättig: Trim term in suggester [15:54:15] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06assertion from 144190275 to 147e5c1bd: 02http://git.io/u8mx9g [15:54:15] 13WikibaseQueryEngine/06assertion 147e5c1bd 15Thiemo Mättig: Revert misleading assertion name [15:58:03] [13WikibaseInternalSerialization] 15thiemowmde 04force-pushed 06deserializers from 14fcec74d to 1450ea4de: 02http://git.io/mpoMOg [15:58:03] 13WikibaseInternalSerialization/06deserializers 14ad17ce2 15Thiemo Mättig: Reuse existing methods [15:58:03] 13WikibaseInternalSerialization/06deserializers 141777f04 15Thiemo Mättig: Try current first [15:58:03] 13WikibaseInternalSerialization/06deserializers 14b11e4d8 15Thiemo Mättig: Don't store serialization [16:02:26] [13WikibaseQuery] 15thiemowmde 04force-pushed 06protected from 14076f280 to 14d9b67cb: 02http://git.io/4eruJA [16:02:26] 13WikibaseQuery/06protected 14d9b67cb 15Thiemo Mättig: Fix visibility level of properties and methods [16:29:19] [13WikibaseDataModel] 15thiemowmde created 06noParent (+1 new commit): 02http://git.io/z5_7vQ [16:29:19] 13WikibaseDataModel/06noParent 147ceb675 15Thiemo Mättig: Decrease inheritance in Statement [16:32:47] [13WikibaseDataModel] 15thiemowmde opened pull request #325: Decrease inheritance in Statement (06master...06noParent) 02http://git.io/AY2u4Q [16:37:00] [13WikibaseDataModel] 15thiemowmde 04deleted 06remdup at 147199392: 02http://git.io/nrtNKA [16:38:11] [13WikidataBrowserTests] 15tobijat created 06add_conditional_wait (+1 new commit): 02http://git.io/PtwJCg [16:38:11] 13WikidataBrowserTests/06add_conditional_wait 14fe2f4e7 15Tobias Gritschacher: Add a condidional wait for save button when adding statements [16:38:21] [13WikidataBrowserTests] 15tobijat opened pull request #34: Add a condidional wait for save button when adding statements (06master...06add_conditional_wait) 02http://git.io/sbE_eQ [16:40:11] [13WikidataBrowserTests] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/fKuRqQ [16:40:11] 13WikidataBrowserTests/06master 140603c54 15snaterlicious: Merge pull request #34 from wmde/add_conditional_wait... [16:41:34] wmde/WikibaseInternalSerialization/deserializers/50ea4de : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseInternalSerialization/builds/43613491 [16:45:39] seems like beta is down [16:46:58] ok, working again.. but caused some failing browsertests [16:47:00] :( [16:48:06] [13WikibaseInternalSerialization] 15thiemowmde 04force-pushed 06reuse from 141006fb3 to 14dd22eff: 02http://git.io/oWB8Sg [16:48:06] 13WikibaseInternalSerialization/06reuse 14dd22eff 15Thiemo Mättig: Reuse existing methods [16:52:51] (03CR) 10JanZerebecki: "$ mysql -h s5-analytics-slave.eqiad.wmnet -A wikidatawiki" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [16:56:30] [13WikibaseDataModelSerialization] 15thiemowmde pushed 1 new commit to 06typednska: 02http://git.io/Lmz7eg [16:56:30] 13WikibaseDataModelSerialization/06typednska 14e55ea06 15thiemowmde: Since 1.3 [16:58:37] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #84 14e55ea06: Why are the return types of all these methods so generic? (No reason to block this patch since it was like this before, just asking.) Nothing bad should happen if we use the correct types here. 02http://git.io/jHIwXw [17:08:17] wmde/WikibaseQuery/protected/d9b67cb : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseQuery/builds/43614001 [17:08:45] [13WikibaseDataModelSerialization] 15thiemowmde created 06factoryTypes (+1 new commit): 02http://git.io/xDXmnw [17:08:45] 13WikibaseDataModelSerialization/06factoryTypes 149fec4f4 15Thiemo Mättig: Precise type hints in SerializerFactory [17:09:45] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #101: Precise type hints in SerializerFactory (06master...06factoryTypes) 02http://git.io/Bs0qyg [17:11:19] [13WikibaseDataModelSerialization] 15thiemowmde created 06options (+1 new commit): 02http://git.io/U_2rVg [17:11:19] 13WikibaseDataModelSerialization/06options 14e4f6ce1 15Thiemo Mättig: Clean up SerializerFactory options handling [17:14:00] (03PS1) 10Henning Snater: Removed jQuery.wikibase.claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178869 [17:14:01] [13WikibaseDataModelSerialization] 15thiemowmde opened pull request #102: Clean up SerializerFactory options handling (06master...06options) 02http://git.io/mXlG4g [17:14:43] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06options from 14e4f6ce1 to 140633cdb: 02http://git.io/2XYm1w [17:14:43] 13WikibaseDataModelSerialization/06options 140633cdb 15Thiemo Mättig: Clean up SerializerFactory options handling [17:16:08] (03CR) 10Henning Snater: "Please be aware that 400 of the 600 lines added to jquery.wikibase.statementview.js are toolbar definitions. These should be moved to a se" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178869 (owner: 10Henning Snater) [17:18:00] (03CR) 10jenkins-bot: [V: 04-1] Removed jQuery.wikibase.claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178869 (owner: 10Henning Snater) [17:18:35] aude: If the json dump stuff fails once more I want my WikiPageEntityRevisionLookup patch backported [17:18:40] stuff is just so slow right now [17:18:48] and that query is the bottleneck [17:18:51] that's fine with me [17:19:08] * hoo annoyed by dump stuff right now [17:19:09] it will be until after new years when we deploy again [17:19:21] [13WikidataBrowserTests] 15snaterlicious created 06removeclaimview (+1 new commit): 02http://git.io/8foMng [17:19:21] 13WikidataBrowserTests/06removeclaimview 147d725ec 15snaterlicious: Adjusted selectors as to removal of jQuery.wikibase.claimview [17:19:23] so anything urgent should go in before, imho [17:19:24] yikes [17:19:39] It's not urgent... but it has the potential to make such stuff quite a bit faster [17:19:46] * aude means after next/this week [17:19:53] yeah [17:19:56] [13WikidataBrowserTests] 15snaterlicious opened pull request #35: Adjusted selectors as to removal of jQuery.wikibase.claimview (06master...06removeclaimview) 02http://git.io/alpopw [17:24:23] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06snak from 143b5f52d to 14d60ce56: 02http://git.io/9Q42Ow [17:24:23] 13WikibaseDataModel/06snak 14d60ce56 15jeroendedauw: Decrease inheritance and overloading for PropertyValueSnak [17:30:10] (03PS2) 10Henning Snater: Removed jQuery.wikibase.claimview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178869 [17:31:53] [13WikibaseDataModel] 15thiemowmde comment on pull request #105 14d60ce56: Oh, is `instanceof Snak` a mistake? 02http://git.io/kJHiDQ [17:37:33] [13WikibaseDataModel] 15thiemowmde created 06numeric (+1 new commit): 02http://git.io/MWEnCw [17:37:33] 13WikibaseDataModel/06numeric 140906637 15Thiemo Mättig: Simplify PropertyValueSnak::unserialize [17:37:53] [13WikibaseDataModel] 15thiemowmde opened pull request #326: Simplify PropertyValueSnak::unserialize (06master...06numeric) 02http://git.io/7nKWqA [17:41:49] wmde/WikibaseDataModel/noParent/7ceb675 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/43616808 [17:58:38] (03PS17) 10Daniel Kinzler: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [17:58:47] (03PS4) 10Daniel Kinzler: TermLookup should not know about entity existance. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177592 [17:58:56] (03PS3) 10Daniel Kinzler: Filter labels by languages earlier. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 [18:07:11] (03CR) 10jenkins-bot: [V: 04-1] Filter labels by languages earlier. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [18:10:07] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06options from 140633cdb to 14122a6d6: 02http://git.io/2XYm1w [18:10:07] 13WikibaseDataModelSerialization/06options 14122a6d6 15Thiemo Mättig: Clean up SerializerFactory options handling [18:10:44] (03PS4) 10Daniel Kinzler: Filter labels by languages earlier. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 [18:13:16] [13WikibaseDataModelSerialization] 15thiemowmde 04force-pushed 06typednska from 14e55ea06 to 140d6faaf: 02http://git.io/tE-iSQ [18:13:16] 13WikibaseDataModelSerialization/06typednska 140d6faaf 15jeroendedauw: Added `newTypedSnakSerializer` to `SerializerFactory` [18:23:49] wmde/WikibaseDataModelSerialization/typednska/e55ea06 : thiemowmde The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/43619855 [18:32:27] [13ValueView] 15snaterlicious 04force-pushed 06suggesterissearching from 14f2d07eb to 14fc634b9: 02http://git.io/-g6kVQ [18:32:27] 13ValueView/06suggesterissearching 14fc634b9 15snaterlicious: $.ui.suggester: Added isSearching()... [18:47:23] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Looks very good overall, but found a mistake and have some suggestions." (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [18:52:29] (03CR) 10Thiemo Mättig (WMDE): "I'm not sure how to proceed here. The implementation is somewhat incomplete (see my follow up). But on the other hand these edge cases are" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [18:58:41] wmde/WikibaseDataModelSerialization/factoryTypes/9fec4f4 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/43621486 [19:01:12] wmde/WikibaseDataModelSerialization/factoryTypes/9fec4f4 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/43621486 [19:07:22] (03CR) 10Aude: [C: 032] New deployment branch - wmf/1.25wmf12 [extensions/Wikidata] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178826 (owner: 10Aude) [19:09:13] oO last minute work [19:09:47] heh [19:10:11] wanted to see how selenium did then forgot :P [19:10:33] ideally should make the branch on tuesdays [19:10:53] wmde/WikibaseDataModelSerialization/options/e4f6ce1 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/43621701 [19:13:10] (03Merged) 10jenkins-bot: New deployment branch - wmf/1.25wmf12 [extensions/Wikidata] (wmf/1.25wmf12) - 10https://gerrit.wikimedia.org/r/178826 (owner: 10Aude) [19:20:57] (03PS3) 10Thiemo Mättig (WMDE): Catch more edge cases in EntityInfo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177772 [19:46:57] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "See comments." (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [19:56:42] wmde/WikibaseDataModel/numeric/0906637 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/43624336 [20:01:56] on wikidata.org, what controls which languages I see in "In other languages" box? [20:06:41] wmde/WikibaseDataModelSerialization/options/122a6d6 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/43627587 [20:09:04] wmde/WikibaseDataModelSerialization/options/122a6d6 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/43627587 [20:12:35] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Found some actual mistakes, see comments." (039 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178825 (owner: 10Daniel Kinzler) [20:13:14] Hm, still old results in the autolist. [20:19:14] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks really, really good. No +2 because I just looked at the code but did not tested it yet." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178820 (owner: 10Henning Snater) [20:19:40] (03Abandoned) 10Hoo man: Focus in snakview after start editing [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178384 (owner: 10Hoo man) [20:19:41] SMalyshev: babel https://meta.wikimedia.org/wiki/User_language [20:20:43] uh... why I'm all the time getting "WiDaR error: You haven't authorized this application yet! Go here to do that, then reload this page." when I'm using autolist... [20:20:59] Stryn: thanks. is it separate on each wiki or there's a common one? [20:22:06] Stryn: Still, we need something about babel in the welcome message. [20:24:18] SMalyshev: it's the thing starting with "{{#babel:" everywhere, just add the languages you know, and you could see those languages in "in other languages" box [20:26:07] if it was what you meant, anyway, night [20:36:48] Stryn: thanks! [20:36:51] JeroenDeDauw: hey, are you still interested in https://www.mediawiki.org/wiki/Requests_for_comment/Distribution_and_deployment ? [20:37:28] if it's filled out a bit, it could be discussed at an RFC meeting in January or so [21:03:19] (03CR) 10Aude: "done some benchmarking on terbium with wikidata..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178844 (owner: 10Daniel Kinzler) [21:04:35] (03PS1) 10Thiemo Mättig (WMDE): Avoid RegexValidator if possible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178922 [21:05:27] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Not 100% sure if that's the way we should go, but the code looks mergable so far." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177814 (owner: 10Daniel Kinzler) [21:09:15] (03CR) 10jenkins-bot: [V: 04-1] Avoid RegexValidator if possible [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178922 (owner: 10Thiemo Mättig (WMDE)) [21:17:14] (03PS1) 10Thiemo Mättig (WMDE): Reduce non-functional validator nesting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178967 [21:22:03] (03CR) 10jenkins-bot: [V: 04-1] Reduce non-functional validator nesting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178967 (owner: 10Thiemo Mättig (WMDE)) [21:51:46] (03CR) 10Aude: Don't use (or need) Content (again) in ViewEntityAction (037 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [21:52:29] (03PS7) 10Aude: Don't use (or need) Content (again) in ViewEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 [21:55:17] (03CR) 10Daniel Kinzler: "I'm surprised that calling getContent() multiple times should make much of a difference. It should always just return the same Content obj" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [21:58:20] (03CR) 10Aude: "@daniel we don't have content at all in ViewEntityAction (except that it is accessed on startup in MediaWiki.php to check if it is a redir" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [22:00:40] (03CR) 10Daniel Kinzler: "Oh right, if we are hitting the parser cache, we shouldn't need to deserialize the entity at all. good point, i totally missed that." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [22:02:42] (03CR) 10Aude: "@daniel: https://www.wikidata.org/wiki/Q60?forceprofile=1&randomstring (look at the page source)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178542 (owner: 10Aude) [22:23:04] Hmmm http://tools.wmflabs.org/widar/index.php?action=authorize [22:23:13] That doesn't seem goed. [22:23:15] good* [22:40:06] (03PS1) 10Hoo man: Don't instantiate ParserAfterParseHookHandler for interface msg parse [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178987 [22:41:01] aude: ^ I found that to be rather heavy on special pages (found by using forceprofile in produciton) [22:42:00] that's a good one [22:44:04] 0.78% 3.249 396 - Wikibase\Client\WikibaseClient::getStore [22:44:11] why for a page view on wikipedia? [22:44:49] aude: Probably also dependency injection thing for a hook [22:44:58] :/ [22:48:31] we call SidebarHookHandlers::newFromGlobalState 11 timex [22:48:52] * aude will review your patch and hunts for these [22:53:58] :) [22:56:43] (03PS1) 10Aude: Use same SidebarHookHandlers instance throught request [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178993 [22:59:02] (03CR) 10Aude: Use same SidebarHookHandlers instance throught request (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178993 (owner: 10Aude) [22:59:09] (03CR) 10Hoo man: [C: 04-1] Use same SidebarHookHandlers instance throught request (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178993 (owner: 10Aude) [22:59:34] good point [23:05:56] (03CR) 10Aude: [C: 032] "looks reasonable and shouldn't cause any issue" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178987 (owner: 10Hoo man) [23:08:52] (03CR) 10Aude: Use same SidebarHookHandlers instance throught request (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178993 (owner: 10Aude) [23:09:10] (03PS2) 10Aude: Use same SidebarHookHandlers instance throught request [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178993 [23:09:50] (03PS3) 10Aude: Use same SidebarHookHandlers instance during request [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178993 [23:10:24] (03Merged) 10jenkins-bot: Don't instantiate ParserAfterParseHookHandler for interface msg parse [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178987 (owner: 10Hoo man) [23:12:51] found another sitelist lead [23:12:53] * leak [23:12:56] :/ [23:13:04] https://gerrit.wikimedia.org/r/#/c/178990/ will make multichill happy [23:13:05] It's rather easy to fix [23:18:17] (03PS1) 10Hoo man: Don't load sites for DirectSqlStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/178999 [23:20:34] wtf [23:21:35] huh? [23:47:02] aude: hah! Found something nice [23:47:59] mh, maybe not that nice :S [23:49:37] ? [23:50:00] see -operations [23:52:47] aude: Depending on how often we actually access that setting the impact might be big... or nothing [23:54:13] looks reasonable [23:55:37] Want to +1?