[00:25:12] hello, i am a gci student and im tackling https://www.google-melange.com/gci/task/view/google/gci2014/6372452271652864 [04:55:44] hey [04:55:51] can someone explain a gci task for me [04:56:26] https://www.google-melange.com/gci/task/view/google/gci2014/6372452271652864 [04:56:30] im not sure how to start on it [09:43:25] can someone please point me towards the local help page for "article status" or "assign a badge" [10:25:28] sDrewth: Getting redirected to https://www.wikidata.org/wiki/Wikidata:Glossary#Badge [10:27:13] k, thx [10:37:41] Lydia_WMDE: Can you put https://phabricator.wikimedia.org/T76860 high on your list for this week? It's extremely irritating [10:38:42] yes [10:39:17] Probably a minor fix in the .js [10:39:33] Thanks [10:54:45] benestar: we probably need more than https://www.wikidata.org/wiki/Wikidata:Glossary#Badge "Badges is a kind of marker attached to a sitelink, which could identify, for example, that the article is a "featured article" on a specific site. They do not describe the external entity but the page on the specific site." to help the sites know what to do to set up their badges [10:55:21] otherwise it is just becomes a pointer, and not a feature [10:57:37] sDrewth: I don't think it was updated after the feature was actually implemented [11:09:14] Well, this looks promising now https://youtrack.jetbrains.com/issue/WI-21737 [12:28:37] hi Amir1, nice milestone ;-) [12:28:46] :) [12:28:49] thank you :) [12:29:07] I hope you are well [12:29:22] multichill: ^ [12:29:28] Working on some scripts [12:35:00] I am, first day of holiday. Going to New York in a couple of days :-D [12:35:15] how are you doing Amir1? [12:35:24] bon voyage :) [12:35:53] I finished my last mid-term exam today I'm free to code :) [12:35:59] at least for a while [12:36:10] the OPW will start soon and I'm mentor for the first time :) [12:41:04] Nice [12:45:03] I hope we can finish compat this time forever [12:47:44] it would allow for more focus [13:01:26] maybe I have lost the plot, however, I thought that when clicking the add button that the cursor was active in the property field [13:10:28] hi wikidataniks [13:21:38] can anyone recommend some good wikignome activities for a newbie? [13:21:50] we're going to have an in-person workshop [13:26:14] sDrewth: yeah - bug - we're working on a fix :) [13:26:22] Pharos: constraint violation reports [13:26:29] you can find links to them on the property talk pages [13:26:43] someone else will have to explain it to you i fear. need to run [13:26:58] no problem, thanka Lydia_WMDE ! [13:27:55] Pharos: or start them on the wikidata game [13:29:01] the game looks fun :) [13:29:43] awesome, thanks folks! [13:42:15] sDrewth: Bug, see https://phabricator.wikimedia.org/T76860 [13:42:41] Pharos: What is your audience? [13:43:42] Sebastiaan and me did a Wikidata workshop for GLAMs a couple of weeks ago [14:54:42] hey, is aude online? [14:56:22] hi [14:56:44] GEOFBOT: you want to work on our api modules? [14:58:42] yea, my task is to do some i18n work on them [14:58:47] great [15:00:19] i would start with https://www.mediawiki.org/wiki/API/Architecture_work/i18n for general background [15:00:29] ok [15:00:37] then we have the option of converting these by hand (probably easiest) [15:01:00] or script, but i can't find AnomieBOT's code in git anywhere (we could ask him) [15:02:01] if by hand, i see two options [15:02:41] 1) clone Wikibase directly from git: https://git.wikimedia.org/summary/mediawiki%2Fextensions%2FWikibase [15:03:07] 2) use vagrant to obtain Wikibase ("wikidata" role) https://www.mediawiki.org/wiki/MediaWiki-Vagrant [15:03:34] where you can actually verify the changes in your own setup [15:04:03] yesterday i was fiddling around [15:04:06] ok [15:04:08] and i couldnt seem to get vagrant to work [15:04:11] but i have a mediawiki installation [15:04:14] also, do you have an account on gerrit yet? [15:04:17] yes [15:04:34] if you have mediawiki installed, then that might be good enough [15:05:16] https://www.mediawiki.org/wiki/Wikibase/Installation [15:05:29] with the composer option [15:06:04] and enable just the repository for now [15:06:31] ok [15:08:04] for git clone, i would use "git clone ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase.git" [15:08:23] so it's setup to submit changes to gerrit [15:12:11] Ok, Wikibase is installed [15:12:51] My windows pc had another gpu crash :/ [15:13:12] oh no [15:13:24] is it ok now? [15:13:32] aude: Saw my question about Graphite yesterday? [15:13:44] Its ok, everything is on the linux box [15:13:53] hoo: yes but don't know [15:13:58] ok [15:14:02] :S [15:14:05] My old gpu is on the brink of dying :P [15:14:14] you should be able to create an item with Special:NewItem [15:14:17] to see that it works [15:14:36] Guess we'll see the impact of the stuff after deploying then :P [15:14:51] jan is better with graphite [15:19:05] aude: Did you notice how MediaWiki was broken for PHP 5.3 for a few days... and no one noticed (except for our travis) [15:19:28] (I remember you saying that you still run 5.3) [15:19:29] no [15:19:47] * aude has been jetlagged for a few days [15:20:04] Yeah, that's awful :/ [15:20:05] recovering from not sleeping for 2 days [15:20:54] and then neighbors had loud party all last night, until daylight this morning :( [15:21:10] * aude rage :P [15:21:49] You could have called the police :P [15:24:11] we'll see... probably the neighbors will at some point [15:24:31] other neighbors, also annoyed [15:25:12] aude: And they didn't invite you? That sucks [15:25:20] You need old and grumpy neighbours for that :P I've been to birthday parties where someone called the police only minutes after 10pm (Which is the time you have to stop being loud) [15:25:30] That's like rule one of throwing a big noisy party: Invite the neighbours [15:25:41] heh [15:27:17] Newitem returns an error [15:27:23] Database query [15:27:54] GEOFBOT_mobile: did you run the update.php maintenance script after enabling wikibase? [15:28:15] Ooh derp [15:28:29] then hopefully it (should) work [15:28:49] Yes bingo [15:29:20] good :) [15:29:22] Ok item created [15:30:14] all wikibase modules (with a few exceptions, not to worry about yet) are in repo/includes/api [15:30:20] and the i18n files are in repo/i18n [15:30:49] examples of what/how to change in another extension: https://gerrit.wikimedia.org/r/#/c/169814/ [15:31:22] and others https://gerrit.wikimedia.org/r/#/q/status:merged+owner:%22Anomie+%253Cbjorsch%2540wikimedia.org%253E%22,n,z ('add i18n...') [15:32:38] and you can see api module help: https://www.wikidata.org/w/api.php?action=help [15:33:09] wbavailablebadges might be easy one to start [15:33:40] Ok, thanks for the help [15:33:51] sure [15:34:15] i should be around for a while if you get stuck or have more questions [15:34:28] * hoo is also around for a few more hours [15:34:37] feel free to ping me [15:34:44] ok, ttyl [15:34:46] i would start with converting wbavailablebadges since that's a more simple module [15:34:49] ok [15:34:53] i will most likely screw up something so i will need help :P [15:35:03] thanks [15:35:11] hope not, but we're here anyway :) [15:42:29] # atop [15:42:29] Floating point exception (core dumped) [15:42:31] uh [15:44:20] :( [15:49:29] TypeError: wb.datamodel.Fingerprint is not a constructor FingerprintDeserializer.js:26 [15:49:37] How can that possibly happen [15:50:15] AFAIS that could only happen if RL screwed up [16:02:19] if( precision > Time.PRECISION.DAY ) { [16:02:19] throw new Error( 'Precision higher than "DAY" is not yet supported' ); [16:02:19] } [16:02:45] *rages* [16:03:48] why? [16:03:56] https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#see_Wikidata:Forum.23bei_Lucretia_Lucretia_.28Q229432.29_fehlt_Bearbeiten_und_Liste_der_Bezeichnungen [16:03:58] oh, yes [16:04:07] [16:04:26] oh, Lydia_WMDE is pinging me [16:04:37] We shouldn't allow values that break the UI :P [16:04:39] * aude does not see those [16:04:49] do we allow them in the api? [16:04:53] Apparently [16:05:00] well, maybe we no longer do [16:05:37] other parts of the item should still be editable though [16:06:25] yeah, but that would require more changes to UI stuff [16:06:54] Think I'm just going to remove that reference for now to make it editable [16:06:55] we had "invalid" globes and geo precisions [16:07:05] but the items were still editable afaik then\ [16:08:58] * aude gets "Uncaught Error: The un-unserializable structure has to be a plain object" on that item [16:10:29] aude: Yeah [16:10:40] but do action=debug and fire up your debugger ;) [16:11:06] fixed, btw: https://www.wikidata.org/w/index.php?title=Q229432&diff=179224331&oldid=179019687 [16:11:21] Lydia_WMDE: ^ [16:11:33] In case you are around... want to file a bug? [16:11:51] debug=true ? [16:11:55] * aude did that [16:12:25] Yeah... but I only saw that error with WebKit and the debugger enabled myself [16:12:38] but I was right, removing the reference fixed it for me [16:12:45] yeah [16:12:58] debugging JS is a mess [16:13:19] oh noes, my preview script is broken again :( [16:13:29] hey, i have a question that might be kinda stupid [16:13:39] sure ? [16:13:42] const PRECISION_SECOND = 14; [16:13:47] meh [16:13:49] but in anomie's changes he marks the old i18n functions as deprecated [16:13:54] but what replaces them? [16:14:14] GEOFBOT_: Just plain localization messages ;) [16:14:34] So we no longer need to override methods, but just set some messages [16:14:39] oh, so if you add the messages to the jsons [16:14:43] then it will automagically work? [16:14:47] Yeah [16:14:52] oooh thats cool thanks [16:14:55] and i think protected function getExamplesMessages() [16:14:59] gets added [16:15:15] ok [16:15:36] like https://gerrit.wikimedia.org/r/#/c/169801/1/api/ApiAbuseFilterEvalExpression.php [16:22:50] Replied on wiki regarding the precision stuff [16:28:49] (03PS3) 10Hoo man: Clean up MockClientStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177197 (owner: 10Thiemo Mättig (WMDE)) [17:01:10] (03PS3) 10Hoo man: Clean up MockPropertyLabelResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177198 (owner: 10Thiemo Mättig (WMDE)) [17:05:59] aude: If you're around, please see internal channel [17:08:23] i got api help i18n to work for availablebadges :D [17:08:27] should be smooth sailing for the rest [17:08:44] GEOFBOT: Nice one :) [17:08:58] Want to make a patch and share what you got so far with us? [17:09:28] sure [17:09:43] yay :) [17:13:41] hoo aude: http://pastebin.com/RFrxCpD4 [17:14:52] Looks good [17:15:12] do you know how to upload commits into our gerrit? [17:15:23] yes [17:15:37] i didn't want to start a new gerrit with a half-baked commit :P [17:16:00] looks good [17:16:12] You can always amend gerrit changes [17:16:12] even though we only have one example, i would name it something like apihelp-wbavailablebadges-example-1 [17:16:39] ok [17:17:00] in api modules with multiple examples, then that allow for apihelp***-example-2 etc [17:17:06] i tried that but the api help was looking for apihelp-wbavailablebadges instead of -examples-1 [17:17:14] so maybe there is something deeper in teh code that needs changing? [17:17:28] you need to change getExamplesMessages accordintly [17:17:33] accordingly* [17:17:45] apihelp-wbavailablebadges => apihelp-wbavailablebadges-example-1 [17:17:54] i think [17:18:24] ah, it works now must've been a typo [17:18:25] thanks [17:19:04] good :) [17:30:47] GEOFBOT_ If you have a commit that we don't want people to formally review yet, you can put [WIP] in the title- stands for Work in Progress. i.e. https://gerrit.wikimedia.org/r/#/c/176356/ [17:38:46] aude: Please see channel again :P [17:41:18] (03PS3) 10Hoo man: Rename ambiguous $repo to $wikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177200 (owner: 10Thiemo Mättig (WMDE)) [17:42:12] ok, thanks mvolz [17:42:40] (03CR) 10Hoo man: [C: 032] Rename ambiguous $repo to $wikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177200 (owner: 10Thiemo Mättig (WMDE)) [17:46:17] (03Merged) 10jenkins-bot: Rename ambiguous $repo to $wikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177200 (owner: 10Thiemo Mättig (WMDE)) [17:49:40] (03PS1) 10Sn1per: [WIP] Convert API help to use i18n [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177990 [17:49:47] there ^ :D [17:51:46] GEOFBOT: Any reason to keep the deprecated methods in the class? [17:53:01] looking at anomie's work [17:53:05] he kept the deprecated methods [17:53:13] until mediawiki 1.25 was [17:53:16] no longer supported [17:53:20] with wikibase, we don't care as mucha bout backwards compatibility [17:53:20] Yeah, but for Wikibase we don't care for backwards compatibility that much [17:53:27] ok [17:53:54] good bye deprecated functions [17:54:14] since we make changes often enough that depend on something new in master version of core [17:56:05] GEOFBOT: also if https://gerrit.wikimedia.org/r/#/c/177516/ looks okay to you I will commit it now [17:56:35] for stuff like that you can +1 if you don't have changes [17:58:53] HI GEOFBOT [17:59:30] Hi Nemo_bis :P [17:59:36] hi :) [18:00:08] Now that you're here we can go really off topic and convert #wikidata to #citoid [18:00:53] I'd like to talk about i18n things at some point, I am pretty clueless there. [18:02:36] That's fine :) [18:02:52] Main issue for citoid will be the template mapping [18:03:03] There isn't really a solution for that [18:03:23] hello Nemo_bis [18:03:30] But [[Content translation]] devs claim they know one at least ofr citation templates, so perhaps you can ask them [18:03:42] mvolz: the contributors thing is fine, thanks [18:03:47] ok :) [18:04:40] Nemo_bis: template mapping is mediawiki namespace json message so far. I was more thinking along the lines of the text of the citations/source information themselves [18:05:03] at this point we're stuck to pretty much the language its written in but if we ever have a database.. [18:05:13] (03PS2) 10Sn1per: [WIP] Convert API help to use i18n [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177990 [18:05:23] ^ added CreateClaim.php, hope i did it right [18:06:11] I guess the way wikidata does it is just have most metadata in english [18:06:43] or I guess with the value being an item, if that item has linked pages you sort of have translations there... [18:06:45] but not all do. [18:07:10] GEOFBOT: I think you forgot the message qqq [18:08:03] oh and also please don't change to many API modules in one cahnge... gigantic changes are way harder to review than several medium sized ones [18:08:09] ok [18:08:14] I think up to 5 should be ok [18:10:12] mvolz: there is no english-only metadata at all in Wikidata, AFAICS [18:15:57] (03CR) 10Aude: "i find the naming somewhat confusing and initially thought i saw a bug" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177735 (owner: 10Hoo man) [18:17:12] hoo: althoguh he may have merge conflicts if split in too many patches [18:17:43] Yeah, true [18:17:51] the json files are nasty in those regards [18:21:29] omg, found a bug in secure poll [18:21:40] nothing critical though [18:25:27] Pizzzaaa [18:25:30] :D [18:26:24] (03PS3) 10Sn1per: [WIP] Convert API help to use i18n [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177990 [18:26:32] :O [18:27:22] and spammed with deprecation notices when i install secure poll :P [18:37:44] Dammit, wikidataquery is down again [18:39:16] -_- [19:03:54] (03PS4) 10Sn1per: [WIP] Convert API help to use i18n [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177990 [19:50:39] aude: if a class gets their param descriptoin from their parent [19:50:48] should i duplicate that description [19:50:53] for the child class? [19:51:58] looked at some other i18n work, and i think i should [20:16:13] GEOFBOT: yeah, that's usually the case [20:16:26] In general, you shouldn't reuse translations [20:21:17] (03PS5) 10Sn1per: Convert API help to use i18n pt.1 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177990 [20:21:47] ok Reedy, thanks for the advice [22:36:21] multichill: Ik merk dat sommige pagina's op nlwiki wel een VIAF-sjabloon dragen maar nog geen property op Wikidata. Zou je ook dat sjabloon willen overzetten? :) [22:36:41] is vaak gekopieerd van en-wiki denk ik [22:37:03] Dat kan best ja, ik denk dat Romaine gelijk heeft. Is er veel spul wat nog niet op wikidata zit? [22:37:24] Ik ben er een stuk of vijf tegengekomen. [22:37:37] Ben alle DBNL zonder VIAF aan het langslopen. :) [22:38:21] Maar blijkbaar heeft iemand structueel wat artikelen langsgelopen en het viafsjabloon geplaatst. [22:39:24] Ok. Weet niet wanneer ik eraan toekom [22:39:37] Gooi anders een berichtje op m'n talk page als ik het volgende week nog niet gedaan heb [22:39:54] Ik kijk wel, maak binnenkort sowieso even een botlijstje. [22:41:00] Mochten jullie nog zin hebben om te helpen, op https://www.wikidata.org/wiki/User:Multichill/Rijksmuseum_creators_RKD staat een leuk lijstje :-) [22:41:44] Ik ga verder met mijn eigen lijstje. :P [22:41:55] En moet morgen de schade weer opnemen bij de commonscats. :/ [22:53:01] multichill: Is het ook mogelijk om items te filteren op grootte in bytes? [22:54:38] Weet ik niet [22:55:52] Hm, zou wel prettig zijn gezien ik dan kan zien welke items nog een beurt nodig hebben van mij. :P