[00:00:50] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Don't load all sites for LangLinkHandler (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177429 (owner: 10Hoo man)
[00:02:09] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "a test case would be nice, if that isn't too hard. that context is a fake, right?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[00:02:33] <grrrit-wm>	 (03PS1) 10Hoo man: Don't access sites on WikibaseClient::getEntityIdForTitle [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177434 
[00:02:42] <hoo>	 DanielK_WMDE: ^ that one is low haning
[00:03:57] <DanielK_WMDE>	 nice
[00:04:07] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Don't access sites on WikibaseClient::getEntityIdForTitle [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177434 (owner: 10Hoo man)
[00:04:21] <hoo>	 Let me just finish up that lsat patch
[00:04:55] <hoo>	 what kind of test do you want to see?
[00:04:59] <hoo>	 And yes, the context is fake
[00:05:13] <DanielK_WMDE>	 a test for action !== view
[00:05:22] <DanielK_WMDE>	 on an enabled namespace
[00:06:15] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't load all sites for LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177429 (owner: 10Hoo man)
[00:07:09] <hoo>	 on it
[00:07:33] <DanielK_WMDE>	 but anyway - non-view requests are < 1%, right?
[00:07:37] <DanielK_WMDE>	 so not such a big deal..
[00:07:46] <hoo>	 No idea, honestly
[00:08:16] <DanielK_WMDE>	 this will disable the sidebar for action=edit and action=submit.
[00:08:34] <hoo>	 action=history
[00:08:34] <DanielK_WMDE>	 we could omit it on action=history too.
[00:08:47] <DanielK_WMDE>	 yea, but why? it doesn't seem logical to me
[00:09:10] <DanielK_WMDE>	 is there a need to drop the sidebar in these rare cases, while we show it for the common case?
[00:09:10] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/8c91cfb : Marius Hoch The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42928950
[00:09:54] <hoo>	 Oh, I wasn't aware that we show the other projects on action=history
[00:10:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't access sites on WikibaseClient::getEntityIdForTitle [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177434 (owner: 10Hoo man)
[00:10:08] <grrrit-wm>	 (03Abandoned) 10Hoo man: Only initialize other projects sidebar on action == view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[00:10:14] <hoo>	 In that case that's not needed, indeed
[00:10:39] <hoo>	 travis failures are unrelated (not even our fault)
[00:10:49] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "Maybe I'm missing something, but this seems pointless. Removing the sidebar from the rare cases of action=edit, action=history, etc, is no" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[00:11:32] <DanielK_WMDE>	 hoo: got another quick one? otherwise i'm off to bed.
[00:11:46] <hoo>	 No, those are it
[00:11:55] <DanielK_WMDE>	 these two should already help a lot, unless there's another big one
[00:12:07] <DanielK_WMDE>	 i merged two. they should do it, right?
[00:12:52] <hoo>	 DanielK_WMDE: I guess so, yes
[00:13:58] <DanielK_WMDE>	 hoo: phew. thanks for spotting this, and sorry - i guess this was at least partly my fault.
[00:14:14] <DanielK_WMDE>	 gotta keep thinking when pushing for more DI :)
[00:14:38] <hoo>	 heh.
[00:15:08] <DanielK_WMDE>	 anyway, g'night
[00:15:15] <grrrit-wm>	 (03PS1) 10Hoo man: Don't load all sites for LangLinkHandler [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177438 
[00:15:26] <grrrit-wm>	 (03PS1) 10Hoo man: Don't access sites on WikibaseClient::getEntityIdForTitle [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177439 
[00:17:54] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177438 (owner: 10Hoo man)
[00:17:58] <grrrit-wm>	 (03CR) 10Hoo man: "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177439 (owner: 10Hoo man)
[00:18:11] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177439 (owner: 10Hoo man)
[00:21:14] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Don't load all sites for LangLinkHandler [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177438 (owner: 10Hoo man)
[00:21:59] <grrrit-wm>	 (03CR) 10Hoo man: "recheck" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177438 (owner: 10Hoo man)
[00:25:20] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't load all sites for LangLinkHandler [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177438 (owner: 10Hoo man)
[00:25:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Don't access sites on WikibaseClient::getEntityIdForTitle [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177439 (owner: 10Hoo man)
[00:25:26] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/c4937c7 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42929335
[00:28:53] <grrrit-wm>	 (03PS1) 10Hoo man: Update Wikibase to minimize SiteList loading [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177443 
[00:29:31] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Update Wikibase to minimize SiteList loading [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177443 (owner: 10Hoo man)
[00:31:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Wikibase to minimize SiteList loading [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177443 (owner: 10Hoo man)
[00:55:12] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf10/c4c59c4 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42930762
[01:05:20] <grrrit-wm>	 (03Restored) 10Hoo man: Only initialize other projects sidebar on action == view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[01:09:25] <grrrit-wm>	 (03PS4) 10Hoo man: Reduce other projects sidebar initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 
[07:59:19] <grrrit-wm>	 (03PS1) 10Henning Snater: Fixed creating an empty entity [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177502 
[07:59:21] <grrrit-wm>	 (03PS1) 10Henning Snater: Rewrote RepoApi tests [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177503 
[08:01:06] <grrrit-wm>	 (03PS2) 10Henning Snater: Fixed creating an empty entity [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177502 
[08:01:15] <grrrit-wm>	 (03PS2) 10Henning Snater: Rewrote RepoApi tests [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177503 
[08:47:00] <grrrit-wm>	 (03PS4) 10Henning Snater: Updated code documentation [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176337 
[08:47:19] <grrrit-wm>	 (03PS3) 10Henning Snater: Fixed creating an empty entity [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177502 
[08:47:25] <grrrit-wm>	 (03PS3) 10Henning Snater: Rewrote RepoApi tests [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177503 
[09:01:42] <grrrit-wm>	 (03PS1) 10Henning Snater: getEntitiesByPage: Always submit "normalize" parameter if specified [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177508 
[09:01:44] <grrrit-wm>	 (03PS1) 10Henning Snater: Added RepoApi tests for functions not yet tested [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177509 
[09:03:09] <grrrit-wm>	 (03PS5) 10Henning Snater: Updated code documentation [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176337 
[09:08:44] <grrrit-wm>	 (03PS4) 10Henning Snater: Fixed creating an empty entity [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177502 
[09:09:23] <grrrit-wm>	 (03PS5) 10Henning Snater: Fixed creating an empty entity [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177502 
[09:09:28] <grrrit-wm>	 (03PS4) 10Henning Snater: Rewrote RepoApi tests [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177503 
[09:10:49] <grrrit-wm>	 (03PS5) 10Henning Snater: Rewrote RepoApi tests [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177503 
[09:10:57] <grrrit-wm>	 (03PS2) 10Henning Snater: getEntitiesByPage: Always submit "normalize" parameter if specified [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177508 
[09:13:24] <grrrit-wm>	 (03PS3) 10Henning Snater: getEntitiesByPage: Always submit "normalize" parameter if specified [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177508 
[09:13:30] <grrrit-wm>	 (03PS2) 10Henning Snater: Added RepoApi tests for functions not yet tested [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177509 
[09:14:50] <grrrit-wm>	 (03PS3) 10Henning Snater: Added RepoApi tests for functions not yet tested [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177509 
[09:53:49] <gh-wmde>	 [13ValueView] 15thiemowmde comment on pull request #133 145568366: Why are you using backquotes here? 02http://git.io/vH98aQ
[10:33:14] <gh-wmde>	 [13ValueView] 15thiemowmde comment on pull request #133 145568366: Please note that this change (from `AutoExpandInput` to `$.AutoExpandInput`) does make the class public. It was private before. 02http://git.io/f-s1Bg
[10:36:07] <gh-wmde>	 [13ValueView] 15thiemowmde comment on pull request #133 145568366: `[args]` 02http://git.io/ijtqDA
[10:36:29] <gh-wmde>	 [13ValueView] 15snaterlicious pushed 1 new commit to 06documentation: 02http://git.io/nUh0IA
[10:36:29] <gh-wmde>	 13ValueView/06documentation 1476ac647 15snaterlicious: Added @private to $.AutoExpandInput
[10:37:50] <grrrit-wm>	 (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/12/04 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/177515 
[10:43:34] <gh-wmde>	 [13ValueView] 15thiemowmde comment on pull request #133 1476ac647: `{Function|Object}` 02http://git.io/qtjiJg
[11:02:52] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 2014/12/04 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/177515 (owner: 10Tobias Gritschacher)
[11:06:56] <gh-wmde>	 [13ValueView] 15thiemowmde comment on pull request #133 1476ac647: `[eventSystem='']` and `[supportsCustomResults=false]` defaults missing. 02http://git.io/mWPnHQ
[11:08:09] <gh-wmde>	 [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/T2UpBA
[11:08:09] <gh-wmde>	 13ValueView/06master 145bbeba0 15thiemowmde: Merge pull request #133 from wmde/documentation...
[11:08:33] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Delete unused TermMatchScoreCalculator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177215 (owner: 10Thiemo Mättig (WMDE))
[11:12:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Delete unused TermMatchScoreCalculator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177215 (owner: 10Thiemo Mättig (WMDE))
[11:12:28] <Tobi_WMDE_SW>	 Henning_WMDE: https://phabricator.wikimedia.org/T76704
[11:12:37] <Tobi_WMDE_SW>	 for the wikibase-property datatype support
[11:12:45] <grrrit-wm>	 (03PS4) 10Henning Snater: Added RepoApi tests for functions not yet tested [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177509 
[11:13:24] <gh-wmde>	 [13ValueView] 15thiemowmde created 06docBits (+1 new commit): 02http://git.io/wy3sJA
[11:13:24] <gh-wmde>	 13ValueView/06docBits 1466e7f11 15Thiemo Mättig: Fix minor documentation issues
[11:13:35] <gh-wmde>	 [13ValueView] 15thiemowmde opened pull request #135: Fix minor documentation issues (06master...06docBits) 02http://git.io/EwY_Tg
[11:13:59] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/d400752 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42969444
[11:29:33] <gh-wmde>	 [13ValueView] 15thiemowmde 04force-pushed 06mintermlength from 148942850 to 1419afbad: 02http://git.io/erCoDQ
[11:29:33] <gh-wmde>	 13ValueView/06mintermlength 147d9fd13 15snaterlicious: $.ui.suggester: Moved protected _minTermLength member to options
[11:29:33] <gh-wmde>	 13ValueView/06mintermlength 14c5303ea 15snaterlicious: $.ui.suggester: Checking for menu when trying to update suggestions
[11:29:33] <gh-wmde>	 13ValueView/06mintermlength 1419afbad 15snaterlicious: Removed obsolete code
[11:30:09] <gh-wmde>	 [13ValueView] 15thiemowmde pushed 1 new commit to 06mintermlength: 02http://git.io/VE1djg
[11:30:09] <gh-wmde>	 13ValueView/06mintermlength 148a2baf4 15thiemowmde: Added missing `options.`
[11:37:36] <gh-wmde>	 [13ValueView] 15thiemowmde pushed 5 new commits to 06master: 02http://git.io/uGJ4RQ
[11:37:36] <gh-wmde>	 13ValueView/06master 147d9fd13 15snaterlicious: $.ui.suggester: Moved protected _minTermLength member to options
[11:37:36] <gh-wmde>	 13ValueView/06master 14c5303ea 15snaterlicious: $.ui.suggester: Checking for menu when trying to update suggestions
[11:37:36] <gh-wmde>	 13ValueView/06master 1419afbad 15snaterlicious: Removed obsolete code
[11:38:44] <gh-wmde>	 [13ValueView] 15thiemowmde pushed 1 new commit to 06docBits: 02http://git.io/ShC_ag
[11:38:44] <gh-wmde>	 13ValueView/06docBits 146c8a40a 15thiemowmde: Revert constructor change
[11:39:35] <gh-wmde>	 [13ValueView] 15snaterlicious 04deleted 06docBits at 146c8a40a: 02http://git.io/D6M1BA
[12:00:50] <grrrit-wm>	 (03PS1) 10Henning Snater: Added type checks to wikibase.api.RepoApi functions [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/177517 
[12:04:11] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "A question. Not enough information for a vote." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[12:07:32] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): [C: 032] Set normalizeItemByTitlePageNames to true per default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177184 (owner: 10Hoo man)
[12:10:40] <grrrit-wm>	 (03Merged) 10jenkins-bot: Set normalizeItemByTitlePageNames to true per default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177184 (owner: 10Hoo man)
[12:12:52] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/b8fc8fb : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42973964
[12:13:37] <gh-wmde>	 [13WikidataBrowserTests] 15tobijat created 06adjust_datatype_class (+1 new commit): 02http://git.io/xF2c2g
[12:13:37] <gh-wmde>	 13WikidataBrowserTests/06adjust_datatype_class 14407f20b 15Tobias Gritschacher: Adjustment after classname changed...
[12:13:52] <gh-wmde>	 [13WikidataBrowserTests] 15tobijat opened pull request #32: Adjustment after classname changed (06master...06adjust_datatype_class) 02http://git.io/2v-Yog
[12:15:50] <grrrit-wm>	 (03PS5) 10Tobias Gritschacher: Split off itemview and propertyview from entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177203 (owner: 10Henning Snater)
[12:16:10] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: "Needs https://github.com/wmde/WikidataBrowserTests/pull/32 to not break tests!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177203 (owner: 10Henning Snater)
[12:25:57] <grrrit-wm>	 (03PS6) 10Henning Snater: Split off itemview and propertyview from entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177203 
[12:50:07] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 04-1] "This change does more than just removing indentation and updating documentation. And I'm sorry but it is almost impossible to review it. C" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176367 (owner: 10Henning Snater)
[13:23:31] <gh-wmde>	 [13DataTypes] 15tobijat pushed 1 new commit to 06master: 02http://git.io/ZnMe1A
[13:23:31] <gh-wmde>	 13DataTypes/06master 14bf240ec 15Tobi Gritschacher: Update README.md
[13:25:24] <grrrit-wm>	 (03PS3) 10Thiemo Mättig (WMDE): Move Client Hooks classes to Hooks folder/namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176660 
[13:36:42] <grrrit-wm>	 (03PS8) 10Thiemo Mättig (WMDE): Optimize use sections and docs in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 
[13:39:43] <grrrit-wm>	 (03PS1) 10Lucie Kaffee: added Item to wikibase-item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177526 
[13:40:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Optimize use sections and docs in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE))
[13:41:26] <grrrit-wm>	 (03PS2) 10Lucie Kaffee: added Item to wikibase-item [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177526 
[13:44:01] <grrrit-wm>	 (03PS2) 10Thiemo Mättig (WMDE): [WIP] Clean up UsageTablePrimer and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176356 
[13:45:31] <grrrit-wm>	 (03PS15) 10Daniel Kinzler: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 
[13:46:03] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Fix wrong SqlUsageTrackerSchemaUpdater filename [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177532 
[13:46:21] <DanielK_WMDE>	 Thiemo_WMDE: another one: https://gerrit.wikimedia.org/r/#/c/172796/
[13:48:32] <grrrit-wm>	 (03Draft2) 10Henning Snater: Renamed wb.experts.EntityIdInput to wb.experts.EntityId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177527 
[13:48:36] <grrrit-wm>	 (03Draft3) 10Henning Snater: Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177528 
[13:48:40] <grrrit-wm>	 (03Draft3) 10Henning Snater: Implemented wb.experts.Property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177529 
[13:48:45] <grrrit-wm>	 (03Draft2) 10Henning Snater: Slimmed down Expert store initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177530 
[13:49:32] <grrrit-wm>	 (03PS3) 10Henning Snater: Renamed wb.experts.EntityIdInput to wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177527 
[13:51:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Clean up UsageTablePrimer and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176356 (owner: 10Thiemo Mättig (WMDE))
[13:54:04] <grrrit-wm>	 (03PS1) 10Thiemo Mättig (WMDE): Fix doc tags in EntityUsageTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177537 
[13:54:21] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177528 (owner: 10Henning Snater)
[13:54:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implemented wb.experts.Property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177529 (owner: 10Henning Snater)
[13:55:39] <grrrit-wm>	 (03PS4) 10Daniel Kinzler: Implemented wb.experts.Property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177529 (owner: 10Henning Snater)
[13:56:25] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Slimmed down Expert store initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177530 (owner: 10Henning Snater)
[13:56:56] <grrrit-wm>	 (03PS3) 10Thiemo Mättig (WMDE): [WIP] Clean up UsageTablePrimer and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176356 
[13:57:23] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Renamed wb.experts.EntityIdInput to wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177527 (owner: 10Henning Snater)
[13:58:05] <grrrit-wm>	 (03PS3) 10Henning Snater: Remove unnecessary indentation level in $.wikibase.entityselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176367 
[13:58:07] <grrrit-wm>	 (03PS1) 10Henning Snater: $.wikibase.entityselector: Updated code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177540 
[13:58:09] <grrrit-wm>	 (03PS1) 10Henning Snater: $.wikibase.entityselector: Factored out _termMatchesLabel() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177541 
[14:01:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implemented wb.experts.Property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177529 (owner: 10Henning Snater)
[14:03:12] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Clean up UsageTablePrimer and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176356 (owner: 10Thiemo Mättig (WMDE))
[14:10:04] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "None of my concerns is a good reason to block this patch. But I would like to see my comments tackled in a follow up. I will create one la" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler)
[14:13:26] <gh-wmde>	 [13WikibaseSerializationJavaScript] 15tobijat created 06jshint (+1 new commit): 02http://git.io/g2Etaw
[14:13:26] <gh-wmde>	 13WikibaseSerializationJavaScript/06jshint 1480e3236 15Tobias Gritschacher: Run JSHINT on TravisCI
[14:13:36] <gh-wmde>	 [13WikibaseSerializationJavaScript] 15tobijat opened pull request #11: Run JSHINT on TravisCI (06master...06jshint) 02http://git.io/qjTVeA
[14:13:46] <grrrit-wm>	 (03CR) 10Thiemo Mättig (WMDE): "-1 because of the removed backwards compatibility, see comments." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler)
[14:14:59] <gh-wmde>	 [13WikibaseSerializationJavaScript] 15tobijat 04force-pushed 06jshint from 1480e3236 to 148772ccb: 02http://git.io/0VFLTQ
[14:14:59] <gh-wmde>	 13WikibaseSerializationJavaScript/06jshint 148772ccb 15Tobias Gritschacher: Run JSHINT on TravisCI
[14:17:38] <gh-wmde>	 [13WikibaseSerializationJavaScript] 15tobijat 04force-pushed 06jshint from 148772ccb to 14e0d9003: 02http://git.io/0VFLTQ
[14:17:38] <gh-wmde>	 13WikibaseSerializationJavaScript/06jshint 14e0d9003 15Tobias Gritschacher: Run JSHINT on TravisCI
[14:17:41] <grrrit-wm>	 (03PS1) 10Gerrit Patch Uploader: Use hasOwnProperty to check for existence of a property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177543 
[14:17:43] <grrrit-wm>	 (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177543 (owner: 10Gerrit Patch Uploader)
[14:18:58] <Tobi_WMDE_SW>	 Henning_WMDE: https://github.com/wmde/WikibaseSerializationJavaScript/pull/11
[14:19:02] <Tobi_WMDE_SW>	 adds jshint
[14:21:26] <gh-wmde>	 [13WikibaseSerializationJavaScript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/FV88_Q
[14:21:26] <gh-wmde>	 13WikibaseSerializationJavaScript/06master 14d0cf22c 15snaterlicious: Merge pull request #11 from wmde/jshint...
[14:21:39] <gh-wmde>	 [13WikibaseDataModelJavaScript] 15tobijat created 06jshint (+1 new commit): 02http://git.io/WxUU7g
[14:21:39] <gh-wmde>	 13WikibaseDataModelJavaScript/06jshint 141305bf8 15Tobias Gritschacher: Run JSHINT on TravisCI
[14:21:49] <gh-wmde>	 [13WikibaseDataModelJavaScript] 15tobijat opened pull request #21: Run JSHINT on TravisCI (06master...06jshint) 02http://git.io/B-9FSg
[14:23:05] <Tobi_WMDE_SW>	 Henning_WMDE: same here: https://github.com/wmde/WikibaseDataModelJavaScript/pull/21
[14:23:56] <gh-wmde>	 [13WikibaseDataModelJavaScript] 15snaterlicious pushed 1 new commit to 06master: 02http://git.io/wUduSg
[14:23:56] <gh-wmde>	 13WikibaseDataModelJavaScript/06master 143518176 15snaterlicious: Merge pull request #21 from wmde/jshint...
[14:44:14] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "@thiemo: please remove the -1 as discussed. Since EntityInfoBuilder guarantees the new structure, there is no B/C issue." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler)
[14:47:45] <grrrit-wm>	 (03PS4) 10Daniel Kinzler: Introduce DataType for refs to Properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 
[14:49:09] <DanielK_WMDE>	 jzerebecki: --^
[14:58:50] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Remove unnecessary indentation level in $.wikibase.entityselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176367 (owner: 10Henning Snater)
[15:01:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: Remove unnecessary indentation level in $.wikibase.entityselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176367 (owner: 10Henning Snater)
[15:02:09] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] $.wikibase.entityselector: Updated code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177540 (owner: 10Henning Snater)
[15:05:00] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/2dc2788 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42989637
[15:05:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: $.wikibase.entityselector: Updated code documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177540 (owner: 10Henning Snater)
[15:07:42] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] $.wikibase.entityselector: Factored out _termMatchesLabel() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177541 (owner: 10Henning Snater)
[15:07:47] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/f15f50a : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42989860
[15:10:14] <grrrit-wm>	 (03CR) 10Tobias Gritschacher: [C: 032] Use switch in EntityIdTitleFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177234 (owner: 10Thiemo Mättig (WMDE))
[15:10:39] <grrrit-wm>	 (03Merged) 10jenkins-bot: $.wikibase.entityselector: Factored out _termMatchesLabel() [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177541 (owner: 10Henning Snater)
[15:13:09] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/cceb811 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42990711
[15:13:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Use switch in EntityIdTitleFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177234 (owner: 10Thiemo Mättig (WMDE))
[15:17:23] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/19bd2f0 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42991081
[15:20:39] <Tobi_WMDE_SW>	 what happened to the tests on travis? the build for client (on mysql) is failing since last night with a database-error
[15:21:10] <Tobi_WMDE_SW>	 DB connection error: Access denied for user 'wikiuser'@'localhost' (using password: NO) (localhost)
[15:26:21] <addshore>	 =o
[15:28:01] <DanielK_WMDE>	 ho! i spotted an addshore! 
[15:28:21] <addshore>	 Oh hi DanielK_WMDE! (and all)
[15:29:46] <grrrit-wm>	 (03PS4) 10Henning Snater: Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177528 
[15:30:00] <grrrit-wm>	 (03PS5) 10Henning Snater: Implemented wb.experts.Property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177529 
[15:32:14] <grrrit-wm>	 (03PS6) 10Henning Snater: Implemented wb.experts.Property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177529 
[15:32:39] <grrrit-wm>	 (03PS4) 10Henning Snater: Renamed wb.experts.EntityIdInput to wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177527 
[15:32:46] <grrrit-wm>	 (03PS5) 10Henning Snater: Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177528 
[15:33:53] <grrrit-wm>	 (03PS6) 10Henning Snater: Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177528 
[15:33:57] <grrrit-wm>	 (03PS7) 10Henning Snater: Implemented wb.experts.Property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177529 
[15:34:03] <grrrit-wm>	 (03PS3) 10Henning Snater: Slimmed down Expert store initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177530 
[15:38:32] <hoo|lecture>	 Lydia_WMDE: Saw my mailing list post from tonight?
[15:39:33] <grrrit-wm>	 (03PS7) 10Henning Snater: Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177528 
[15:41:19] <grrrit-wm>	 (03PS8) 10Henning Snater: Spin off wb.experts.Item from wb.experts.Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177528 
[15:43:06] <grrrit-wm>	 (03PS8) 10Henning Snater: Implemented wb.experts.Property [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177529 
[15:44:04] * hoo|lecture would like people to comment on https://gerrit.wikimedia.org/r/177416
[15:46:09] <DanielK_WMDE>	 Henning_WMDE: if you like, add your oppinion https://phabricator.wikimedia.org/T54843
[15:46:23] <hoo|lecture>	 DanielK_WMDE: Saw that new patch set with my comment?
[15:46:33] <DanielK_WMDE>	 hoo|lecture: no
[15:46:37] <DanielK_WMDE>	 which one?
[15:46:40] <hoo|lecture>	 https://gerrit.wikimedia.org/r/177416
[15:48:31] <hoo|lecture>	 I agree with Thiemo's comment, we should probably also show it on action=submit, but I think that's all
[15:49:04] <DanielK_WMDE>	 hoo|lecture: i think we shoudl always show them
[15:49:11] <DanielK_WMDE>	 i see no point in special-casing
[15:49:16] <hoo|lecture>	 mh, ok
[15:49:29] <DanielK_WMDE>	 the overall impact of anything but action=view should be negligible
[15:49:49] <hoo|lecture>	 well, special pages and pages without items always hit mc
[15:49:49] <DanielK_WMDE>	 we should take care to handle language links and sister links consistently though
[15:49:52] <hoo|lecture>	 that's the problem
[15:50:13] <DanielK_WMDE>	 yes, we can try to check that early
[15:50:22] <hoo|lecture>	 Well, then we only want them on view or submit, becuase langlink work like that as well
[15:50:25] <DanielK_WMDE>	 the namespace checker should explcide special pages, always
[15:50:42] <DanielK_WMDE>	 $outputPage->getProperty( 'wikibase_item' ) might actually be a good criterion
[15:50:55] <hoo|lecture>	 But that only works on action=view, I think
[15:50:59] <DanielK_WMDE>	 why?
[15:51:12] <DanielK_WMDE>	 it should always work
[15:51:25] <hoo|lecture>	 could be
[15:52:45] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 04-1] "Whether we show sitelinks and sister links should not depend on the action at all. We should try to bail out early if the namespace isn't " (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[15:54:45] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Fix wrong SqlUsageTrackerSchemaUpdater filename [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177532 (owner: 10Thiemo Mättig (WMDE))
[15:56:34] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Clean up ItemsPerSiteBuilderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177195 (owner: 10Thiemo Mättig (WMDE))
[15:58:12] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix wrong SqlUsageTrackerSchemaUpdater filename [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177532 (owner: 10Thiemo Mättig (WMDE))
[15:58:16] <grrrit-wm>	 (03PS5) 10Hoo man: Reduce other projects sidebar initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 
[15:58:18] <Lydia_WMDE>	 ohi addshore! :)
[15:58:21] <Lydia_WMDE>	 DanielK_WMDE: thx re emails about statements on properties. was wondering the same for the last email
[15:58:23] <addshore>	 oh hi Lydia_WMDE !
[15:58:34] <Lydia_WMDE>	 hoo|lecture: saw it. thanks for writing that down.
[15:58:50] <grrrit-wm>	 (03CR) 10Hoo man: "Amended to only check for wikibase_item, per Daniel." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[15:58:50] <Lydia_WMDE>	 and investigating and fixing :)
[15:58:57] <Lydia_WMDE>	 addshore: we miss you!
[15:59:05] <hoo|lecture>	 DanielK_WMDE: Amended, testing would be awesome.
[15:59:12] <addshore>	 :D I was planning a trip back in December but I have no time :/
[15:59:12] <hoo|lecture>	 Lydia_WMDE: There's still a bit we can do
[15:59:21] <Lydia_WMDE>	 awww
[15:59:26] <Lydia_WMDE>	 hoo|lecture: cool
[16:00:36] <hoo|lecture>	 Can't really test here... don't have any content on my Wikibase install on this netbook thing
[16:01:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clean up ItemsPerSiteBuilderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177195 (owner: 10Thiemo Mättig (WMDE))
[16:09:50] <Lydia_WMDE>	 Tobi_WMDE_SW_NA: DanielK_WMDE: both of you reported bugs with the wikidata bugs mailinglist in CC today. did you add it accidentally or is there some setting adding it automatically?
[16:10:17] <Lydia_WMDE>	 if there is some setting still i'd like to get rid of it
[16:10:26] <andre__>	 Lydia_WMDE, that's something I have to sort out :)
[16:10:35] <Lydia_WMDE>	 andre__: oh?
[16:10:38] <DanielK_WMDE_>	 Lydia_WMDE: it happened automatically
[16:10:39] <andre__>	 Lydia_WMDE, currently the rules were adapted from Bugzilla
[16:10:46] <Lydia_WMDE>	 ah i see
[16:10:47] <Lydia_WMDE>	 ok
[16:10:58] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/2c8915c : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42997106
[16:11:01] <DanielK_WMDE_>	 andre__, Lydia_WMDE: by the way, it's impossible for me to add the "wikidata" project, or search for it
[16:11:06] <andre__>	 so wherever the default CC or default assignee was the mailing list in Bugzilla AND that component got converted into a project in Phab, it is automatically added.
[16:11:19] <DanielK_WMDE_>	 if I type in "wikidata", I get 5 hits, but none of them is "wikidata".
[16:11:30] <Lydia_WMDE>	 andre__: ok makes sense. for wikidata we can get rid of it. all converted to the wikidata-bugs user now
[16:11:36] <Lydia_WMDE>	 DanielK_WMDE: Oo
[16:11:40] <DanielK_WMDE_>	 interrestingly, if jan types in "wikidata", it *is* one of the five choices.
[16:11:50] <Lydia_WMDE>	 strange
[16:11:51] <andre__>	 Lydia_WMDE, could you file a ticket against "Project-creators" in Phab and tell me what's exactly wanted? that would help
[16:12:01] <Lydia_WMDE>	 DanielK_WMDE_: maybe join the project?
[16:12:03] <Lydia_WMDE>	 if you have not
[16:12:05] <andre__>	 DanielK_WMDE_, what are steps to reproduce?
[16:12:15] <Lydia_WMDE>	 andre__: ok will do
[16:12:18] <andre__>	 thanks
[16:12:52] <DanielK_WMDE_>	 it seems like the autocompletion/suggestion has strange ranking, and doesn't pull exact matches to the top
[16:13:30] <DanielK_WMDE_>	 andre__: go to any place where you can enter projects or tags, e.g. "edit ticket". type in "wikidata", observe "wikidata" not showing up in the 5 matches
[16:13:40] <DanielK_WMDE_>	 but i have no idea whether you'll be able to reproduce this
[16:13:45] <DanielK_WMDE_>	 as i said, jan can't reproduce it
[16:14:08] <DanielK_WMDE_>	 maybe because i'm a member of some additional projects, that get ranked higher because of that?
[16:14:11] <andre__>	 Lydia_WMDE: For your info, currently Phab is set to this rule:
[16:14:11] <andre__>	 1) When "Projects" include any of: Wikidata.org, Wikimedia-Labs-wikidata, MediaWiki-extensions-Ask, DataTypes, DataValues, MediaWiki-extensions-Diff, MediaWiki-extensions-ValueFormatters, MediaWiki-extensions-ValueParsers, MediaWiki-extensions-ValueValidators, WikibaseDatabase, MediaWiki-extensions-WikibaseQuery, WikibaseQueryEngine, MediaWiki-extensions-WikibaseClient, MediaWiki-extensions-WikibaseRepository
[16:14:12] <andre__>	 2) then add wikidata-bugs@ to CC the  *first* time this rule matches (not every time = can be removed)
[16:14:18] <DanielK_WMDE_>	 maybe for me, wikidata.org pushes out wikidata?
[16:14:28] <Lydia_WMDE>	 andre__: thx
[16:14:30] <andre__>	 Lydia_WMDE, but I guess projects have now changed anyway, so feel free to tell what you want in a ticket :)
[16:14:34] <andre__>	 *project names
[16:14:54] <DanielK_WMDE_>	 Lydia_WMDE, andre__: i still think we should have a wikidata-team, by the way. but that's a different discussion
[16:15:44] <andre__>	 DanielK_WMDE_: "Wikidata" shows as the 4th out of 5 entries for me... weird.
[16:16:16] <DanielK_WMDE_>	 andre__: yes. but i see "wikidata.org" in slot 4 instead.
[16:16:22] <DanielK_WMDE_>	 and have no way to get to wikidata
[16:16:33] <DanielK_WMDE_>	 in ancy case, an exact match should *always* be on top
[16:16:48] <Lydia_WMDE>	 DanielK_WMDE_: we'll be renaming a few anyway to wikibase where appropriate. that should help hopefully
[16:16:50] <DanielK_WMDE_>	 andre__: i just left the wikidata.org team. problem persists. 
[16:17:03] <DanielK_WMDE_>	 Lydia_WMDE: yes, but this bug is REALLY nasty
[16:17:09] <andre__>	 DanielK_WMDE_: I agree that exact match should win. Want to file a ticket against the "Phabricator.org" project (if you can reach that) in our Phab? :P
[16:17:54] <andre__>	 Lydia_WMDE: you probably are aware of https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects but I highly appreciate if people read that first before renaming, though I expect you to be one of the better citizens. :D
[16:18:35] <Lydia_WMDE>	 andre__: Tobi_WMDE_SW_NA is taking care of that and he did read it :)
[16:19:05] <andre__>	 I like, I like!
[16:19:13] <Lydia_WMDE>	 :P
[16:23:42] <Lydia_WMDE>	 legoktm: did your bot updating the weekly summary page die or were there no new properties in the last days?
[16:24:05] <Lydia_WMDE>	 andre__: thanks!
[16:24:51] <DanielK_WMDE_>	 andre__: https://phabricator.wikimedia.org/T76732
[16:25:01] <andre__>	 dank u well
[16:29:56] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 032] Introduce DataType for refs to Properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 (owner: 10Daniel Kinzler)
[16:31:09] <DanielK_WMDE_>	 jzerebecki: the JS stuff should also go in then soon, because otherwise, editing property statements is broken on master
[16:31:27] <jzerebecki>	 crap
[16:32:00] <hoo|lecture>	 I can CR js when at home or tomorrow
[16:32:03] * legoktm checks
[16:32:37] <legoktm>	 https://www.wikidata.org/wiki/Special:NewPages?namespace=120&tagfilter=&username=
[16:33:49] <jzerebecki>	 DanielK_WMDE_: oh but not for statements that refer to items, so not as bad as i thought, right?
[16:34:02] <grrrit-wm>	 (03Merged) 10jenkins-bot: Introduce DataType for refs to Properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 (owner: 10Daniel Kinzler)
[16:34:10] <DanielK_WMDE_>	 jzerebecki: yes
[16:34:32] <hoo|lecture>	 !merge 177416
[16:34:32] <wm-bot>	 merge merge merge MERGEEEEEEEEEEEEE https://gerrit.wikimedia.org/r/#/c/177416/
[16:34:37] <hoo|lecture>	 hehe
[16:35:45] <DanielK_WMDE_>	 hoo|lecture: hm... if we skip the hook handler if there is no item connected, will that kill the "add language" widget?
[16:36:01] <hoo|lecture>	 good question
[16:36:20] <grrrit-wm>	 (03CR) 10Daniel Kinzler: "if we skip the hook handler if there is no item connected, will that kill the "add language" widget?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[16:36:22] <grrrit-wm>	 (03CR) 10JanZerebecki: [C: 032] Reduce other projects sidebar initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[16:36:33] <hoo|lecture>	 I'll test
[16:39:31] <hoo|lecture>	 DanielK_WMDE_: Widget still appears
[16:39:56] <legoktm>	 UnicodeEncodeError: 'ascii' codec can't encode character u'\u2013' in position 7: ordinal not in range(128)
[16:39:58] <legoktm>	 yeeeeeeeeeeee
[16:40:02] <legoktm>	 I hate you python2
[16:40:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reduce other projects sidebar initialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[16:40:58] <legoktm>	 Lydia_WMDE: bot's fault, now fixed: https://www.wikidata.org/w/index.php?title=Wikidata:Status_updates/Next&diff=prev&oldid=179019027
[16:41:28] <Lydia_WMDE>	 legoktm: \o/
[16:41:32] <grrrit-wm>	 (03CR) 10Hoo man: "@Daniel: linkItem widget still appears as that is being handled at another point." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man)
[16:42:11] <hoo|lecture>	 Lydia_WMDE: Do we also want to backport that? Not sure how urgent that is to WMF
[16:42:25] <hoo|lecture>	 but I don't want them to use the evil json caching stuff
[16:42:52] <Lydia_WMDE>	 hoo|lecture: do you think it's safe to backport?
[16:42:56] <Lydia_WMDE>	 if so feel free to
[16:43:22] <grrrit-wm>	 (03CR) 10Daniel Kinzler: [C: 032] Fix doc tags in EntityUsageTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177537 (owner: 10Thiemo Mättig (WMDE))
[16:43:27] <hoo|lecture>	 I can play with it a bit more when back at home, but I think it is
[16:43:39] <Lydia_WMDE>	 ok cool
[16:44:14] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/065b06b : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/43000816
[16:44:15] <DanielK_WMDE_>	 hoo|lecture, Lydia_WMDE, aude: https://phabricator.wikimedia.org/T76706
[16:44:16] <hoo|lecture>	 Will also save accesses to the wb_items_per_site table, which is nice
[16:44:47] <Lydia_WMDE>	 DanielK_WMDE_: thx
[16:45:18] <hoo|lecture>	 DanielK_WMDE_: Nice... but would be even nicer to not need that at all
[16:45:20] <Lydia_WMDE>	 https://en.wikipedia.org/wiki/USS_Will_Rogers_(SSBN-659) <- weeee @ infobox showing wikidata icon :D
[16:45:25] <hoo|lecture>	 IMO
[16:46:47] <DanielK_WMDE_>	 hoo|lecture: well, we do need siteinfo when we actually want to show links, right?
[16:46:58] <hoo|lecture>	 yeah, but that's pretty rare
[16:47:12] <DanielK_WMDE_>	 and pulling several k of sites across the network for every page view kind of sucks
[16:47:30] <hoo|lecture>	 no, we only need that when rendering
[16:47:36] <hoo|lecture>	 then the stuff is cached
[16:47:39] <DanielK_WMDE_>	 hoo|lecture: page views of pages with language links is rare?
[16:48:00] <hoo|lecture>	 no, but they shouldn't hit the sitestore
[16:48:02] <DanielK_WMDE_>	 well yes - but even with caching, it's far more frequent than the cases we covered now
[16:48:15] <DanielK_WMDE_>	 hoo|lecture: they shouldn't? why not?
[16:48:35] <hoo|lecture>	 Because we should cache langlinks in parser output
[16:48:37] <DanielK_WMDE_>	 hoo|lecture: this is a *skin* hook. it *always* runs.
[16:48:41] <hoo|lecture>	 like we do with the otherprojects sidebar
[16:49:01] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix doc tags in EntityUsageTableBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177537 (owner: 10Thiemo Mättig (WMDE))
[16:49:03] <DanielK_WMDE_>	 we do, but not the finished links, i think
[16:49:07] <DanielK_WMDE_>	 i guess we could also do that
[16:49:15] <DanielK_WMDE_>	 want to file a ticket?
[16:49:26] <hoo|lecture>	 Not now
[16:49:47] <hoo|lecture>	 can do when at home, if I don't forget
[17:07:27] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/6545f36 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/43002224
[17:24:16] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177567 
[18:14:28] <grrrit-wm>	 (03CR) 10Aude: [C: 04-1] "see comment and i would leave out the changes to itembysite from this patch, since it still uses the entire SiteList to get just the one s" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177567 (owner: 10Daniel Kinzler)
[18:19:50] <grrrit-wm>	 (03CR) 10Aude: [C: 04-1] "this is a big breaking change... one that will break wikidata (and perhaps also vagrant setups) unless a big bold deployment note is provi" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177526 (owner: 10Lucie Kaffee)
[18:23:55] <grrrit-wm>	 (03CR) 10Daniel Kinzler: Avoid calling SiteStore::getSites to boost performance (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177567 (owner: 10Daniel Kinzler)
[19:00:07] <grrrit-wm>	 (03PS1) 10Daniel Kinzler: TermLookup should not know about entity existance. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177592 
[19:49:09] <multichill>	 Did something change in the interface or is my browser acting up? Add statement doesn't move focus to the property field....
[20:31:09] <Nemo_bis>	 multichill: could it be related to my issue? https://phabricator.wikimedia.org/T75844
[21:22:49] <multichill>	 Nemo_bis: I doubt it
[21:37:22] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/843e68b : Translation updater bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/43030447
[22:22:54] * hoo fixed travis
[23:04:53] <grrrit-wm>	 (03PS2) 10Hoo man: Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177567 (owner: 10Daniel Kinzler)
[23:05:38] <grrrit-wm>	 (03CR) 10Hoo man: "Removed the change in SpecialItemByTitle (per Katie) and one minor documentation fix." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177567 (owner: 10Daniel Kinzler)
[23:06:47] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177567 (owner: 10Daniel Kinzler)
[23:09:53] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177567 (owner: 10Daniel Kinzler)
[23:20:06] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/master/6f1e209 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/43042008
[23:22:37] <grrrit-wm>	 (03PS1) 10Hoo man: Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177690 
[23:22:47] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177690 (owner: 10Hoo man)
[23:23:21] <grrrit-wm>	 (03PS1) 10Hoo man: Reduce other projects sidebar initialization [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177691 
[23:23:39] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177691 (owner: 10Hoo man)
[23:29:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid calling SiteStore::getSites to boost performance [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177690 (owner: 10Hoo man)
[23:30:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Reduce other projects sidebar initialization [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177691 (owner: 10Hoo man)
[23:33:58] <grrrit-wm>	 (03PS1) 10Hoo man: Update Wikibase for SiteList loading improvements [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177693 
[23:38:20] <grrrit-wm>	 (03CR) 10Hoo man: [C: 032] Update Wikibase for SiteList loading improvements [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177693 (owner: 10Hoo man)
[23:39:01] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf10/2051bcd : daniel The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/43043936
[23:40:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update Wikibase for SiteList loading improvements [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177693 (owner: 10Hoo man)
[23:49:21] <travis-ci>	 wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf10/e329a1b : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/43044035