[02:32:23] Hm.. got another content handler issue I'm not sure how to handle. With the JavaScriptContent, validation was trivial. Just implement isValid, and prepareSave does the rest. [02:33:03] But with JsonContent, there is beautifying going on and I think I'm hitting a design flaw hitting the wall where we still make the underlying wikitext-ish assumption that there's no such thing as invalid content. [02:34:54] Making a syntax error in a json page will initiate preSaveTransform (which does prettify) *before* it does prepareSave (which validates), this is done by WikiPage::doEditContent, which calls this->prepareContentForEdit before content->prepareSave. [02:35:22] That makes sense conceptually but that means we either need Json beautify to fallback to returning the invalid syntax (which would be ignored later), or re-arrange this somehow [03:00:24] Nevermind, this class is broken in so many different ways. I tried fixing 3 different bugs and each time get a different fetal. [03:00:31] I'm gonna rewrite this thing. [03:00:40] [] being converted to {} isn't even a real bug [03:16:49] Krinkle: JSON validation (and blocking save if it's invalid) is already done, I'm pretty sure. [03:17:06] James_F: Only in EventLogging, in a rather hacky way. [03:17:08] Krinkle: As in, legoktm did it on my request and I merged it some months ago. Unless I'm missing something. [03:17:19] Krinkle: No no, we moved it from EL to MW core. [03:17:28] * James_F hunts. [03:17:32] James_F: Look for yourself. All validation is in EL still. [03:17:36] I'm not making this up :P [03:17:44] James_F: It's horribly broken. A giant soup of wikitext-like calls still. [03:17:58] It works in EL due to a very early hook that reinitialises the content and validates it again. [03:18:10] Krinkle: https://gerrit.wikimedia.org/r/#/c/152933/ [03:18:25] Yes, I was there an hour ago [03:18:29] Doesn't do any validation. [03:18:36] Oh. Interesting. [03:18:38] isValid is effectively discarded and unused. [03:18:50] My commit message will be self-explanatory as usual. [03:18:51] So the validation is magically done by EL riding in to the rescue? [03:18:58] Only barely yeah [03:19:06] You say "self-explanatory", I hear "epic". :-) [03:19:08] In the form of a

with "Invalid JSON" injected [05:44:37] Krinkle: Hmm, yeah I remember the validation being kind of broken. [05:45:05] Krinkle: which class is broken? JsonContent? [05:52:49] just found that https://www.wikidata.org/wiki/Q3545001 is the president of the USA. wikidata is awesome :) [05:53:23] legoktm: Yes [05:53:36] legoktm: https://gerrit.wikimedia.org/r/#/c/177171/ [05:54:13] legoktm: When I enabled plain mediawiki to have a page with content model json, submitting a syntax error made it throw a php warning [05:54:37] and unlike other, temporary presidents, this one has no date qualifiers, i.e. permanent president [05:56:20] legoktm: Those issues become obvious if you apply the next patch (json content model for .json pages in user space) and create/edit such a space. If you like, cherry-pick that commit without the jsoncontent refactor. [05:56:48] wow, super long commit message [05:57:33] I really hate how PHP converts {} --> [] [05:57:35] legoktm: Also note how beautifyJSON was doing validation by silently discarding non-array values! [05:58:00] legoktm: I initially changed it to not pass assoc=true to FormatJson, but there are getJsonData callers that depend on it being an array. [05:58:24] PHP is perfectly capable of keeping arrays and objects separate, but it was explicitly made not to :( [05:58:32] in contenthandler [06:00:21] legoktm: Ideally someone from wikidata or contenthandler maintainers would -1/-2 my commit and instead refactor WikiPage to use the Content methods more intuitively (one shouldn't have to call isValid multiple times, and PST shouldn't happen on invalid content) [06:00:30] oh right, if you pass true to json_decode. [06:02:08] There's Content::isValid(), but no way to get an error message when validating [06:03:15] Krinkle: https://gerrit.wikimedia.org/r/#/c/160575/ might also be relevant [06:04:09] legoktm: error message is provided by function prepareSave, which return Status based on isValid [06:04:31] legoktm: See also https://gerrit.wikimedia.org/r/#/c/176853/, where I validate javascript including accurate parser erorr with line number [06:04:35] (instead of just boolean) [06:06:00] ah [06:06:03] ok [06:06:28] so shouldn't JsonContent implement prepareSave? [06:07:45] > WikiPage::doEditContent invokes chain WikiPage::prepareContentForEdit -> Content::preSaveTransform, before validation. <-- that seems like the right place to fix it [06:08:01] but I haven't looked at this in a while [07:27:36] (03PS1) 10Hoo man: Set normalizeItemByTitlePageNames to true per default [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177184 [07:33:31] (03PS4) 10Henning Snater: Optimized sticknode mechanisms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174085 [07:34:14] (03PS1) 10Hoo man: Remove the displayStatementsOnProperties setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177185 [08:19:07] (03PS1) 10Henning Snater: sitelinkview: Applied inputautoexpand to page name input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177186 [08:19:22] (03CR) 10jenkins-bot: [V: 04-1] sitelinkview: Applied inputautoexpand to page name input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177186 (owner: 10Henning Snater) [08:36:30] (03PS2) 10Henning Snater: sitelinkview: Applied inputautoexpand to page name input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177186 [08:36:40] (03CR) 10jenkins-bot: [V: 04-1] sitelinkview: Applied inputautoexpand to page name input [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177186 (owner: 10Henning Snater) [09:13:30] [13ValueView] 15snaterlicious created 06inputautoexpandref (+1 new commit): 02http://git.io/tG2psQ [09:13:30] 13ValueView/06inputautoexpandref 14de1762c 15snaterlicious: Updated inputautoexpand... [09:35:55] (03CR) 10Daniel Kinzler: [C: 032] Remove the displayStatementsOnProperties setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177185 (owner: 10Hoo man) [09:36:48] (03CR) 10Daniel Kinzler: [C: 031] "Perhaps we should just drop the setting, and just always normalize? Is there any reason not to?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177184 (owner: 10Hoo man) [09:40:15] (03Merged) 10jenkins-bot: Remove the displayStatementsOnProperties setting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177185 (owner: 10Hoo man) [09:40:20] (03CR) 10Hoo man: "I can't think of any... I guess we were worried about API load when we introduced that setting." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177184 (owner: 10Hoo man) [10:01:15] (03CR) 10Daniel Kinzler: "Seems like PS9 was a rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [10:02:05] (03CR) 10Daniel Kinzler: "@aude: Does this mean you are fine with merging this, and addressing your concerns in the follow-up? I don't care much about the split, it" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [10:07:59] (03PS12) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [10:08:12] (03CR) 10jenkins-bot: [V: 04-1] Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [10:11:15] (03PS13) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [10:11:17] (03PS10) 10Daniel Kinzler: Extract FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 [10:11:38] (03CR) 10Daniel Kinzler: "PS10 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [10:11:45] (03CR) 10Daniel Kinzler: "PS10 is a rebase" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [10:12:02] (03CR) 10Daniel Kinzler: "err, PS13 is a rebase, sorry." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [10:12:23] (03PS4) 10Daniel Kinzler: Split getLabelLookup method in FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 (owner: 10Aude) [10:12:57] (03CR) 10Daniel Kinzler: [C: 031] "I don't care much either way, let someone else decide :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 (owner: 10Aude) [10:14:10] (03CR) 10Daniel Kinzler: Split getLabelLookup method in FormatterLabelLookupFactory (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 (owner: 10Aude) [10:17:25] (03CR) 10jenkins-bot: [V: 04-1] Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [10:19:04] (03PS1) 10Thiemo Mättig (WMDE): Remove repeated var name from @var doc tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177193 [10:21:11] Lydia_WMDE: jzerebecki should we add the wikibase logo as project-pictures to all wikibase-components on phabricator? see e.g. https://phabricator.wikimedia.org/project/view/113/ [10:21:42] Tobi_WMDE_SW_NA: for repo and client definitely [10:21:49] the others: maybe [10:21:50] :D [10:22:12] Lydia_WMDE: probably better without the font? [10:22:19] Tobi_WMDE_SW_NA: was about to say that ;-) [10:22:27] (03PS14) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [10:22:29] there should be a version without online [10:22:29] then it would be square [10:22:36] yeah [10:23:09] Lydia_WMDE: do you know where? [10:23:18] let me check [10:25:42] Tobi_WMDE_SW_NA: https://www.mediawiki.org/wiki/File:WIKIBASE_RGB_PLAIN.svg [10:27:54] thx [10:29:36] (03PS1) 10Thiemo Mättig (WMDE): Rename getSiteLinkTable to getSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177194 [10:30:52] (03CR) 10Daniel Kinzler: Filter page purged by usage aspect. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [10:31:05] Lydia_WMDE: like that? [10:31:21] yes! :) [10:33:47] (03PS1) 10Thiemo Mättig (WMDE): Clean up ItemsPerSiteBuilderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177195 [10:34:06] Lydia_WMDE: I have some issieus regarding saving edits. It saves the previous displayed value every time, just like that timebug then. [10:34:25] sjoerddebruin: Oo [10:34:26] whut [10:34:53] can you tell me what exactly you do? i'll try to reproduce [10:35:10] When I want to say like "Wikimedia-doorverwijspagina", it saves Wikimedia. [10:35:54] * Lydia_WMDE goes and tests [10:37:55] sjoerddebruin: which browser? are you selecting by keyboard or mouse? how much do you type of the word? [10:38:08] so far my tries are not successful [10:38:16] And the keyboardselectionbug is back, Lydia_WMDE. (When you select a result with your keyboard, it always saves the first one.) [10:39:04] i just tried that in chrome and it worked fine -.- [10:39:59] are you on firefox? [10:40:30] No, also Chrome. [10:40:38] Also happening at home with Safari. [10:40:56] wtf [10:40:56] (03CR) 10Daniel Kinzler: [C: 032] Rename getSiteLinkTable to getSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177194 (owner: 10Thiemo Mättig (WMDE)) [10:41:08] ok i will try more [10:44:21] It seems to happen when you edit on a specific speed... :/ [10:44:56] very quick or slow? [10:46:16] Well, a combination I think. Writing Wikimedia, stop until the suggestions appear, write -doorverwijspagina and quick select the first result. [11:06:21] ok will try that [11:08:40] mpfh [11:09:48] ok i can't reproduce it :( [11:09:54] i assume it is a race condition somewhere [11:10:00] but... [11:10:31] can anyone else here reproduce it? [11:14:14] (03PS1) 10Thiemo Mättig (WMDE): Clean up MockClientStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177197 [11:18:00] (03CR) 10jenkins-bot: [V: 04-1] Clean up MockClientStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177197 (owner: 10Thiemo Mättig (WMDE)) [11:21:05] (03PS1) 10Thiemo Mättig (WMDE): Clean up MockPropertyLabelResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177198 [11:24:23] (03CR) 10jenkins-bot: [V: 04-1] Clean up MockPropertyLabelResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177198 (owner: 10Thiemo Mättig (WMDE)) [11:31:38] (03PS1) 10Thiemo Mättig (WMDE): Rename ambiguous $repo to $wikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177200 [11:35:19] (03CR) 10jenkins-bot: [V: 04-1] Rename ambiguous $repo to $wikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177200 (owner: 10Thiemo Mättig (WMDE)) [11:35:38] (03CR) 10Daniel Kinzler: Defer entity deserialization (0313 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167224 (owner: 10Daniel Kinzler) [11:36:00] (03PS6) 10Daniel Kinzler: Defer entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167224 [11:36:11] (03CR) 10jenkins-bot: [V: 04-1] Defer entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167224 (owner: 10Daniel Kinzler) [11:36:43] (03PS7) 10Daniel Kinzler: Defer entity deserialization [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167224 [11:43:55] (03PS2) 10Thiemo Mättig (WMDE): Clean up MockClientStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177197 [11:49:57] (03PS2) 10Thiemo Mättig (WMDE): Clean up MockPropertyLabelResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177198 [11:50:05] (03PS2) 10Thiemo Mättig (WMDE): Rename ambiguous $repo to $wikibaseRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177200 [12:22:16] 2013 Lost connection to MySQL server during query (10.64.16.144) [12:22:19] https://www.wikidata.org/wiki/Special:EntitiesWithoutLabel?title=Special%3AEntitiesWithoutLabel&language=nl&type=property&submit=Zoeken [12:36:32] (03PS1) 10Henning Snater: Split off itemview and propertyview from entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177203 [12:36:34] (03PS1) 10Henning Snater: sitelinkgroupview: Added missing template parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177204 [12:38:00] (03PS2) 10Henning Snater: Split off itemview and propertyview from entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177203 [12:38:27] (03PS2) 10Henning Snater: sitelinkgroupview: Added missing template parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177204 [12:42:46] (03CR) 10jenkins-bot: [V: 04-1] Split off itemview and propertyview from entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177203 (owner: 10Henning Snater) [12:42:57] (03CR) 10jenkins-bot: [V: 04-1] sitelinkgroupview: Added missing template parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177204 (owner: 10Henning Snater) [12:51:12] (03PS3) 10Henning Snater: Split off itemview and propertyview from entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177203 [12:51:20] (03PS3) 10Henning Snater: sitelinkgroupview: Added missing template parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177204 [12:52:23] (03PS1) 10Henning Snater: Updated entityview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177205 [12:58:51] (03CR) 10Daniel Kinzler: [C: 032] Clean up MockPropertyLabelResolver [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177198 (owner: 10Thiemo Mättig (WMDE)) [13:00:08] (03CR) 10Daniel Kinzler: [C: 032] Clean up MockClientStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177197 (owner: 10Thiemo Mättig (WMDE)) [13:05:14] (03PS2) 10Henning Snater: Updated entityview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177205 [13:05:52] (03PS1) 10Thiemo Mättig (WMDE): Fix mistakes in AffectedPagesFinder and UsageAspectTransformer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177206 [13:06:17] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [13:11:44] (03CR) 10Daniel Kinzler: [C: 04-1] Remove repeated var name from @var doc tags (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177193 (owner: 10Thiemo Mättig (WMDE)) [13:12:08] (03CR) 10jenkins-bot: [V: 04-1] Fix mistakes in AffectedPagesFinder and UsageAspectTransformer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177206 (owner: 10Thiemo Mättig (WMDE)) [13:12:26] (03Merged) 10jenkins-bot: Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [13:22:46] (03PS1) 10Henning Snater: Moved accessing mw config variable out of entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177209 [13:49:38] Anyone from wikibase devs able to see https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=7996496 and file it a bug? It does make sense IMO but of course the user should be guided to use phab instead [14:00:03] ebraminio: can't access, no [14:00:05] :/ [14:02:48] Lydia_WMDE: I've PMed it for you. If you filed a bug for it, you can give me the link and I can close it for you for now [14:03:21] (closing the the OTRS ticket I mean) [14:15:26] (03CR) 10Aude: Split getLabelLookup method in FormatterLabelLookupFactory (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 (owner: 10Aude) [14:17:45] (03CR) 10Aude: [C: 031] "alright, the patch looks ok, with concerns addressed in a follow up Idf6b3eaa" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [14:19:39] (03CR) 10Aude: [C: 032] "would be nice if the code was in such way that we didn't have to duplicate messages for each entity type, but this solves the immediate is" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177008 (owner: 10Hoo man) [14:20:36] (03PS5) 10Aude: Split getLabelLookup method in FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 [14:24:20] (03Merged) 10jenkins-bot: Add messages for Statement on Property related edit summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177008 (owner: 10Hoo man) [14:29:37] (03PS1) 10Henning Snater: Implemented $.util.getDirectionality [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177213 [14:31:28] (03PS1) 10Thiemo Mättig (WMDE): Remove redundant variable names from @return tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177214 [14:32:20] (03PS1) 10Thiemo Mättig (WMDE): Delete unused TermMatchScoreCalculator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177215 [14:39:20] (03PS2) 10Thiemo Mättig (WMDE): Fix mistakes in AffectedPagesFinder and UsageAspectTransformer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177206 [14:44:37] (03PS1) 10Aude: Add messages for Statement on Property related edit summaries [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177219 [15:02:17] (03PS1) 10Henning Snater: Apply "lang" and "dir" attributes to aliases input boxes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177230 [15:06:59] (03PS2) 10Thiemo Mättig (WMDE): Remove repeated var name from @var doc tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177193 [15:07:04] (03CR) 10Thiemo Mättig (WMDE): Remove repeated var name from @var doc tags (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177193 (owner: 10Thiemo Mättig (WMDE)) [15:07:30] (03PS4) 10Henning Snater: Split off itemview and propertyview from entityview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177203 [15:10:10] (03PS4) 10Henning Snater: sitelinkgroupview: Added missing template parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177204 [15:10:15] (03PS3) 10Henning Snater: Updated entityview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177205 [15:15:13] (03CR) 10Thiemo Mättig (WMDE): Extract FormatterLabelLookupFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [15:15:57] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Extract FormatterLabelLookupFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [15:19:56] (03Merged) 10jenkins-bot: Extract FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [15:20:24] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I was fine with a big elseif block. Sure, the private methods add structure to the code but at the same time make it much more complex. I " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 (owner: 10Aude) [15:23:22] (03Merged) 10jenkins-bot: Split getLabelLookup method in FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 (owner: 10Aude) [15:32:57] (03CR) 10Daniel Kinzler: [C: 032] Remove redundant variable names from @return tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177214 (owner: 10Thiemo Mättig (WMDE)) [15:36:44] (03CR) 10Daniel Kinzler: [C: 032] Fix mistakes in AffectedPagesFinder and UsageAspectTransformer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177206 (owner: 10Thiemo Mättig (WMDE)) [15:36:53] (03Merged) 10jenkins-bot: Remove redundant variable names from @return tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177214 (owner: 10Thiemo Mättig (WMDE)) [15:39:40] (03Merged) 10jenkins-bot: Fix mistakes in AffectedPagesFinder and UsageAspectTransformer [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177206 (owner: 10Thiemo Mättig (WMDE)) [15:40:44] (03CR) 10Daniel Kinzler: Remove repeated var name from @var doc tags (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177193 (owner: 10Thiemo Mättig (WMDE)) [15:41:51] (03CR) 10Daniel Kinzler: [C: 032] Remove repeated var name from @var doc tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177193 (owner: 10Thiemo Mättig (WMDE)) [15:44:31] (03Merged) 10jenkins-bot: Remove repeated var name from @var doc tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177193 (owner: 10Thiemo Mättig (WMDE)) [15:46:42] (03CR) 10Thiemo Mättig (WMDE): "I like how the class is constructed. It makes a very smooth transition possible. However, I found mistakes in the documentation and have s" (0315 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [15:54:35] Well, the time of checking the number of edits is over. http://tools.wmflabs.org/supercount/index.php?project=wikidata&user=Sjoerddebruin [15:57:28] sjoerddebruin: lol [15:57:31] too many edits? [15:58:03] I've passed the 180.000, is the limit of that tool I think... [16:00:26] oh, also broken for me :/ [16:01:35] I have only 70k edits per "number of edits" on my preferences [16:12:39] (03CR) 10Daniel Kinzler: Introduce EntityInfo class (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [16:12:50] Thiemo_WMDE: --^ [16:13:11] (03PS14) 10Daniel Kinzler: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [16:13:26] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [16:14:59] (03CR) 10Daniel Kinzler: "will rebase once the base patch is merged. Otherwise i'll do it five times." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [16:15:55] (03PS1) 10Thiemo Mättig (WMDE): Use switch in EntityIdTitleFormatters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177234 [16:21:56] (03PS1) 10Thiemo Mättig (WMDE): Use 'property' string constant to avoid dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177237 [16:29:55] (03PS1) 10Thiemo Mättig (WMDE): Use 'item' string constant to avoid dependencies [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177239 [17:10:02] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Bug in ClaimsView and some questions." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:12:16] (03CR) 10Thiemo Mättig (WMDE): [C: 032] sitelinkgroupview: Added missing template parameter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177204 (owner: 10Henning Snater) [17:13:41] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Updated entityview documentation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177205 (owner: 10Henning Snater) [17:28:30] (03CR) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:28:37] Thiemo_WMDE: --^ [17:30:04] (03CR) 10Aude: "i would have thought this patch would make a significant improvement on performance, with not using LinkBegin hook and fetching the entity" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:30:40] (03PS15) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [17:34:19] (03CR) 10Daniel Kinzler: "@aude: we were already using the EntityInfo array for generating the property links, but in a very awkward way. This patch does not improv" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:35:12] (03CR) 10Thiemo Mättig (WMDE): Use an EntityIdFormatter for statement's properties. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:36:02] (03PS2) 10Thiemo Mättig (WMDE): Rename getSiteLinkTable to getSiteLinkLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177194 [17:45:18] (03PS1) 10Thiemo Mättig (WMDE): Formatters for JSON? [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177258 [17:45:37] (03PS16) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [17:45:50] (03CR) 10Daniel Kinzler: [C: 032] Formatters for JSON? [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177258 (owner: 10Thiemo Mättig (WMDE)) [17:45:53] (03CR) 10JanZerebecki: [C: 032] Add array_key_exists check for language in EditEntity api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177090 (owner: 10Aude) [17:47:11] DanielK_WMDE: please clarify https://gerrit.wikimedia.org/r/#/c/172703/ [17:48:08] (03CR) 10Daniel Kinzler: "@jan: a matter of taste. i don't feel like merging it, since there is no need, and i disagree about the taste issue. if you want to merge " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 (owner: 10Thiemo Mättig (WMDE)) [17:48:12] jzerebecki: --^ [17:50:21] (03CR) 10Aude: Use an EntityIdFormatter for statement's properties. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:50:53] (03CR) 10Aude: Use an EntityIdFormatter for statement's properties. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:52:35] (03Merged) 10jenkins-bot: Formatters for JSON? [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177258 (owner: 10Thiemo Mättig (WMDE)) [17:52:39] (03Merged) 10jenkins-bot: Add array_key_exists check for language in EditEntity api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177090 (owner: 10Aude) [17:52:44] (03CR) 10Aude: Use an EntityIdFormatter for statement's properties. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:54:30] aude: i'm confused about your comments [17:55:11] oh, you think we were hitting the LinkBegin hook. We were, I guess, but... [17:55:17] wait, i'll comment on gerrit, for the record [17:55:47] office hour in 5 minutes in #wikimedia-office :) [17:58:05] DanielK_WMDE: we were [17:58:07] definitely [17:58:22] (03CR) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [17:58:26] aude: --^ [17:58:47] if ( $html !== null && $target->getFullText() !== $html ) { return; } [17:59:49] aude: i never expected performance improvements from this patch. only the one for the SnakFormatter [18:00:23] (03CR) 10Aude: Use an EntityIdFormatter for statement's properties. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [18:00:37] see comment [18:00:49] maybe shouldn't expect so much then, as you are right [18:01:06] degradation is odd, though [18:01:18] but if it's marginal, may just be a coincidence [18:01:24] might be something else [18:01:53] yes, especially since even random re-arranging of equivalent code can lead to better or worse apc performance, etc [18:01:58] could be anything, really [18:01:59] * aude wants better cachegrind reports to show a diff between them [18:02:05] :) [18:02:18] i always purge a few times, to control for apc etc [18:02:44] would love a chart or report that tells me what got better and what got worse [18:02:54] oh yes [18:02:55] could be done, i'm sure [18:03:00] CI should do that :) [18:03:03] yes [18:03:21] "your patch degraded overall performance by 28.7 percent" [18:03:31] orrrrr [18:06:19] (03CR) 10JanZerebecki: [C: 032] "*sigh* I don't like having patches lying around in the Review:0 state after they were reviewed. I'm indifferent regarding the style of the" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 (owner: 10Thiemo Mättig (WMDE)) [18:06:29] (03CR) 10jenkins-bot: [V: 04-1] Unify top factory getter implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 (owner: 10Thiemo Mättig (WMDE)) [18:07:00] aude: We're going to backport the message? [18:07:03] * messages [18:07:10] hoo: yes [18:07:16] i think it needs approval and a new build [18:07:23] want to take care of that? [18:07:35] In a bit, yes [18:07:41] We will need to scap that [18:07:46] yes [18:07:54] * aude needs to eat and get ready for the airport [18:08:04] so not really around in the afternoon [18:08:09] I see [18:08:12] JeroenDeDauw: jzerebecki: Ordering food today? [18:08:14] Snowy where you are? [18:08:36] not today [18:08:51] btw, hi hoo, hi aude. :) [18:08:54] We had the first snow today over here [18:08:57] hey Thiemo_WMDE :) [18:09:33] we had record weather though while i was here! record cold (-10) for one day and record hot (26) another :) [18:10:14] 36 degree difference in 12 hours? ouch. [18:10:15] anyway.... DanielK_WMDE comparing master from yesterday and today, seems things are somewhat slower now [18:10:24] Thiemo_WMDE: not in 24 hours but within a few days [18:10:33] oh. ok. [18:10:39] not that unusual though [18:10:47] and had snow last week [18:11:17] no food for me thx [18:11:58] ClaimHtmlGenerator->getHtmlForClaim is somewhat slower (13.4 seconds inclusive yesterday, 14.1 seconds today... this is with full profiling and memory tracing enabled) [18:12:09] w/o profiling, it's not that bad [18:12:10] (03PS2) 10Thiemo Mättig (WMDE): Clean up ItemsPerSiteBuilderTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177195 [18:13:39] (03CR) 10Aude: [C: 031] "it appears most, if not all, of the performance differences that i saw also occur on master. so, it's a change (seems not for the better," [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [18:15:58] we are doing EntityIdValue->serialize and EntityIdValue->getNumericId significantly more now (both with some performance cost) [18:16:49] not sure what else yet [18:18:51] it looks easy enough to parse the callgrind files and maybe make such report that i want :) [18:19:12] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177219 (owner: 10Aude) [18:23:21] (03Merged) 10jenkins-bot: Add messages for Statement on Property related edit summaries [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177219 (owner: 10Aude) [18:25:06] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Manually tested, can't see a difference in the HTML." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [18:28:30] (03Merged) 10jenkins-bot: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [18:29:01] (03PS1) 10Hoo man: Update Wikibase to add messages for property edit summaries [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/177266 [18:29:09] (03CR) 10jenkins-bot: [V: 04-1] Update Wikibase to add messages for property edit summaries [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/177266 (owner: 10Hoo man) [18:29:49] doh [18:29:53] I keep forgetting that [18:30:00] our .gitreview points to master all the time [18:30:19] We should fix that with grunt [18:30:39] (03Abandoned) 10Hoo man: Update Wikibase to add messages for property edit summaries [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/177266 (owner: 10Hoo man) [18:31:10] (03PS1) 10Hoo man: Update Wikibase to add messages for property edit summaries [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177267 [18:32:17] hoo: would be easy [18:32:37] I make that mistake quite often... would be nice to hav [18:32:53] i always specify the branch explicity in this case [18:32:58] but would be convenient [18:33:03] https://gerrit.wikimedia.org/r/#/q/status:abandoned+owner:%22Hoo+man+%253Choo%2540online.de%253E%22+project:mediawiki/extensions/Wikidata+branch:master,n,z [18:33:07] :( [18:33:08] Yeah, so do [18:33:09] I [18:33:15] but only after failing, often [18:38:43] (03CR) 10Hoo man: [C: 032] Update Wikibase to add messages for property edit summaries [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177267 (owner: 10Hoo man) [18:40:45] (03Merged) 10jenkins-bot: Update Wikibase to add messages for property edit summaries [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177267 (owner: 10Hoo man) [18:53:23] hoo: so the deployment branches get even updated outside of SWATs? [18:54:17] Yeah... I guess Reedy will scap them in a bit during the usual MediaWiki deploy [19:00:54] People asking why I delete items, maybe because one label with a description is not notable? [19:02:02] perhaps the question was only regarding deletion after merging the item [19:02:57] No, it was a single item. [20:00:01] when I click edit for a new statement, the cursor does not positition itself on the property... can this be fixed [20:00:05] it is annoying [20:05:04] (03PS1) 10Hoo man: Add getApiBasedValueFormatterConstructor dependency on wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177299 [20:05:09] easy peasy CR [20:05:59] oh no, what is broken? [20:06:07] aude: Saw that on Wikidata [20:06:10] oh [20:06:13] I clicked on Special:Random [20:06:26] and got an error that wikibase is undefined in that module [20:06:35] can no longer reproduce (timing issues -.-) [20:06:52] looks sane but will take a glance at the module that needs wikibase [20:07:05] repo/resources/parsers/getApiBasedValueParserConstructor.js [20:08:42] (03CR) 10Aude: [C: 032] "indeed is needed and suppose because of timing (e.g. on wikidata), should explicitly list as a dependency here." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177299 (owner: 10Hoo man) [20:08:46] yep [20:09:31] backport worth? [20:09:35] * worthy [20:09:42] up to you [20:09:55] * aude doesn't have time to look and see if it occurs for me [20:10:05] I'll ask Lydia_WMDE [20:10:09] ok [20:10:19] hmm? [20:10:46] Lydia_WMDE: I just clicked on Random item on Wikidata (in Firefox) and Js didn't work for me (UI was totally broken) [20:10:55] Oo [20:11:04] because of timing issues (dependency not explicitely declared, thus bad timing can break things) [20:11:05] that sounds bad! [20:11:09] the above patch will fix that [20:11:09] i see [20:11:29] patch is trivial [20:11:33] I can no longer reproduce... maybe it's one in a thousand and I just had very bad luck [20:11:54] if the patch is trivial and the consequences are that bad... [20:11:59] i'd say backport if you are fine with it [20:12:05] btw, i won't be at the daily tomorrow but might stop by the office sometime [20:12:10] or not if i am too tired [20:12:20] aude: yay! and ohnoes :( i won't be there. see you next week? [20:12:42] you won't be there? :( [20:12:48] * aude cries [20:13:00] (03Merged) 10jenkins-bot: Add getApiBasedValueFormatterConstructor dependency on wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177299 (owner: 10Hoo man) [20:13:07] no working from home tomorrow and meeting with kde's accountant for a few hours. and then off to barcelona for 6 days for kde board meeting [20:13:14] but! i will come back :) [20:13:20] (03PS1) 10Hoo man: Add getApiBasedValueFormatterConstructor dependency on wikibase [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177301 [20:13:41] i see [20:13:41] flying back on wednesday. not sure if i'll come to the office then or only thursday [20:13:43] I'll backport it... patch is very trivial and can't break anything, but might be disruptive [20:13:48] * aude bringing chocolates [20:13:55] hoo: thanks! [20:13:56] I mean the thing might be disruptive :P [20:14:01] aude: ohhhhhhhh :P [20:14:07] hoo: hehe yeah i figured [20:14:24] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177301 (owner: 10Hoo man) [20:14:28] ok i am going to take care of laundry and then write announcement for statements on properties [20:15:01] Lydia_WMDE: Also deletions are going to be propagated, might be worth a note [20:15:11] oh [20:15:12] yeah [20:15:14] ok [20:15:22] Probably mostly relevant to people on Wikipedias... and those don't really follow :/ [20:20:16] (03Merged) 10jenkins-bot: Add getApiBasedValueFormatterConstructor dependency on wikibase [extensions/Wikibase] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177301 (owner: 10Hoo man) [20:24:32] (03PS1) 10Hoo man: Update Wikibase to fix a RL dependency [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/177303 [20:24:39] (03CR) 10jenkins-bot: [V: 04-1] Update Wikibase to fix a RL dependency [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/177303 (owner: 10Hoo man) [20:25:02] not again -.- [20:25:09] (03Abandoned) 10Hoo man: Update Wikibase to fix a RL dependency [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/177303 (owner: 10Hoo man) [20:25:37] (03PS1) 10Hoo man: Update Wikibase to fix a RL dependency [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177304 [20:27:58] * aude off... probably back again from the airport [20:28:05] Ok, cu :) [20:29:31] (03CR) 10Hoo man: [C: 032] "Will try to sneak that into the train as well." [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177304 (owner: 10Hoo man) [20:29:37] I'm a horrible person :D [20:31:40] (03Merged) 10jenkins-bot: Update Wikibase to fix a RL dependency [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/177304 (owner: 10Hoo man) [20:38:11] hoo [20:38:35] a question, how often do you import content of categories that are deleted ? [20:38:37] yes? [20:39:43] What exactly do you mean? [20:40:34] I was told that when Wikipedia categories are deleted, you import their data in Wikidata [20:41:36] My bot unlinks deleted pages (also categories), but that's it [20:42:55] ok so I was lied to [20:43:05] good to know [21:04:09] hoo, aude: is wikidata-builder3 still used by anyone? do we have definitive plans to use it in the future? if not i'd like to delete it and the whole wikidata-build project. -> https://phabricator.wikimedia.org/T76333 [21:04:40] jzerebecki: I'm not aware of any users [21:13:06] hoo: i am ready with the announcement. good to go or are you still working on it? [21:13:57] Haven't verified myself [21:14:04] give me 5 more minutes [21:14:07] sure [21:16:35] Lydia_WMDE: Ok, looks good [21:16:42] sweet :) [21:16:47] I purged all property pages so anything should work out of the box [21:16:54] \o/ [21:17:02] * Lydia_WMDE hi5s hoo [21:17:26] * hoo hi5s back :) [21:18:53] pushed [21:19:18] good week - lots of new stuff :) [21:19:21] <3 [21:31:51] Away for food (for a bit) [21:34:44] ooohhh, statements on properties! I can haz "Dublic Core ID" property? [21:34:51] err Dublin Core, of course [21:52:42] sjoerddebruin: Gezien, de merge RFC is gesloten [21:52:52] Ja, ik zag het [21:53:12] Ik hoop dat de resterende verwijderende mods zich aan de consensus gaan houden. [21:53:56] Scheelt in ieder geval een hoop werk [21:54:04] Zie ook m'n todo lijstje op https://www.wikidata.org/wiki/Wikidata:Administrators%27_noticeboard#Close_a_RFC [21:54:13] Jup. :) [21:54:46] Uh, nice https://www.wikidata.org/wiki/Property:P1630 [21:54:58] De rapportage van de dbnl-property stond er ook al op vanochtend, een hele boel artikelen op nl gecorrigeerd. (volledige url in plaats van alleen het id) [21:55:09] hoo: that was quick! :) [21:57:20] hoo: Yeah, noticed that one. Is useful [21:57:40] totally! [21:57:41] We just need someone who is extremely bored to work on https://meta.wikimedia.org/wiki/Reasonator/stringprops [21:57:59] oh wow [21:58:17] multichill: that seems like something for a bot? [21:58:25] Not long enough [21:58:31] hmmm ok [21:58:34] multichill: De rkd-url is verouderd op die pagina. Is nu https. [21:59:32] sjoerddebruin: https://www.wikidata.org/wiki/Property:P650 ? [21:59:44] Wel jammer dat we niet de taal code mee kunnen geven :-( [21:59:45] Jup, daar staat ie goed. [22:00:14] Lydia_WMDE: Feature request, we want to use the language code of the user at https://www.wikidata.org/wiki/Property:P650 ;-) [22:00:32] oh my [22:00:33] :D [22:02:51] * multichill wonders what qualifier to use to indicate the language [22:03:25] p407? [22:04:23] Better, Lydia_WMDE what page does https://rkd.nl/artists/1200 redirect you to? [22:04:48] https://rkd.nl/en/artists/1200 [22:04:53] yah [22:08:38] sjoerddebruin: https://www.wikidata.org/wiki/Property:P650 much better right? :-) [22:08:45] :D [22:16:24] sjoerddebruin: Did you also fix some of the RKD imports? [22:17:00] Nope. [22:17:29] I was on school, page is slow there. ;) [22:17:39] https://en.wikipedia.org/wiki/Joseph_Geefs vs https://en.wikipedia.org/wiki/Guillaume_Geefs is a nice mess to solve [22:20:25] I don't see mess. [22:20:50] Both link to https://rkd.nl/en/explore/artists/30578 [22:21:02] Looks like the RKD merged the brothers into one person [22:21:34] Oh? I see two different items. [22:22:52] Oh nee, https://rkd.nl/en/artists/30577 [22:22:58] ;) [22:23:59] https://www.wikidata.org/w/index.php?title=Q728635&diff=178901726&oldid=178525881 [22:45:22] multichill: wikibase doesn't interpret P1630, that would be done by the authoritycontrol gadget, i guess. adding a placeholder for the user language ($2 or so) would be easy enough, right? [22:45:44] Hello I can't merge, nor create an english version for a spanish article. I've tried all things. [22:46:21] Drendon: can you give us a link or two? [22:46:30] also, what do you mean by "create an english version"? [22:46:42] of course a moment pls [22:47:07] this is the original article in spanish already edited and updated https://es.wikipedia.org/wiki/Daniel_Hajj_Aboumrad [22:47:29] I need to create the english version of it [22:48:20] Drendon: https://en.wikipedia.org/w/index.php?title=Daniel_Hajj_Aboumrad&action=edit ? [22:48:22] Drendon: so, just go to https://en.wikipedia.org/wiki/Daniel_Hajj_Aboumrad and write it [22:48:35] Oh, new users can't create articles on the enwp [22:48:47] ah! whut?! [22:49:57] DanielK_WMDE: Turns out the lang shouldn't be in the url for RKD :P Placeholder would probably be $lang [22:50:05] I remember running into that at the enwp [22:50:22] Drendon: if what multichill sais is true, this is an issue with policies on the English Wikipedipa. Take it to https://en.wikipedia.org/wiki/Wikipedia:Help_desk maybe [22:50:25] aude: Around? [22:51:20] everytime i want to link a en post to it a notification of invalid token appears. [22:51:21] Drendon: anyway, once you created the page, you should see an "add language" link on the left that lets you connect it to the spanish version (and automatically link it to the wikidata item) [22:51:30] Right, logged out I can't create the article [22:51:44] Drendon: oh, there already is an english page? where? [22:52:23] if it doesn't work with the "add language" widget, just add the link directly on https://www.wikidata.org/wiki/Q5798429 [22:52:28] https://en.wikipedia.org/wiki/Special:ListGroupRights Create pages (which are not discussion pages) (createpage) is assigned to users [22:52:32] not all.... [22:52:44] so new users can, anons can't [22:53:24] Drendon: do you have a global account? does SUL work for you? are you logged in when you go to en.wikipedia.org or www.wikidata.org? [22:57:54] Lydia_WMDE: found a bug. in the "in other languages" box, $1 is being replaced with "In other languages". Or template mechanism is too dumb :) [22:58:32] I have opened accounts everywhere on wikipedia, wikidata, among others, but not a global account. [22:58:54] We're stupid(tm) [22:59:06] then you can't use the "add language" widget. also, you can't link a page on en wikipedia if it doesn't exist yet. [23:01:31] Lydia_WMDE: https://phabricator.wikimedia.org/T76673 [23:05:24] so you are telling me that I need to create it in english first, and then link it to the spanish one? [23:12:45] oh god [23:12:57] I found why we're causing so much memcached traffic [23:16:01] DanielK_WMDE: How evil is it to give classes a SettingsArray instead of the resolved setting? [23:16:16] Cause that way we can defer certain heavy actions and only do them if needed [23:16:54] hoo: uh, heavy actions like what? [23:17:04] DanielK_WMDE: Like loading all sites [23:17:08] from memcached [23:17:10] all the time [23:17:15] o_O [23:17:25] because that's what we do [23:17:41] omg [23:17:47] aude: yeah [23:17:50] but I found the leak now [23:17:54] * leaks [23:17:57] i think i saw that [23:17:58] errr.... when determining default settings via a callback? [23:18:08] DanielK_WMDE: Yep [23:18:13] but that setting should be overwritten for production [23:18:22] DanielK_WMDE: It can't [23:18:22] if it isn't, doing that should fix the issue [23:18:28] mh [23:18:36] hoo: why can't it? [23:18:41] DanielK_WMDE: Well, it can [23:18:45] but that will only fix one leak [23:19:11] what other leaks are there? [23:19:22] DanielK_WMDE: Let me put up a patch in a bit [23:19:26] I'm messing around atm [23:19:58] to answer your original question: passing a SettingsArray sucks design-wise, but is fine as a quick fix. put it on the branch if you must. [23:20:38] hoo: is this a new issue? would be surprising [23:21:13] i have the beta feature enabled on my dev wiki [23:21:28] i am setting it to throw an exception if it tries to access 'SiteList' memcached key [23:21:45] aude: Same here [23:21:54] if the page is in parser cache and i refresh (with a random string), it does not access memcached for me [23:22:09] if other-projects is not in parser cache it does [23:22:16] but only if i have the beta feature [23:22:24] * aude checks my settings [23:22:37] pretty sure i looked at this [23:23:03] it means that it would be accessed for all page views if we made the beta feature default (we do for some wikipedias, just a few) [23:23:06] which is bad [23:24:15] i am using the default ofr otherProjectsLinks [23:24:40] (03PS1) 10Hoo man: Only initialize other projects sidebar on action == view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 [23:24:55] whoops [23:24:58] unrelated stuff in there [23:25:09] we also have all this stuff enabled on special pages [23:25:19] do they actually use the parser cache? [23:25:29] * aude noticed when visiting special preferences [23:25:44] aude: Don't think so [23:25:51] but my patch fixes the biggest whole [23:26:05] (03PS2) 10Hoo man: Only initialize other projects sidebar on action == view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 [23:26:08] action=history and such [23:26:26] DanielK_WMDE: ^ [23:26:28] that helps [23:27:19] i'm confused. what exactly triggers this? what's the code path, roughly? [23:28:20] Action::getActionName( $skin ) <--- this gets the action name from the *skin*, of all things? [23:28:30] why does that even exist [23:29:02] oh, from any IContextSource. hm [23:29:03] crap [23:29:06] that was the wrong bit [23:29:36] what setting is causing this, anyway? [23:29:50] Wikibase\Client\WikibaseClient->getLangLinkHandler() [23:29:52] is the problem [23:29:57] -.- [23:30:18] $wgWBClientSettings['siteGroup'] = $wmgWikibaseSiteGroup; [23:30:21] we have that enabled [23:30:26] (03CR) 10jenkins-bot: [V: 04-1] Only initialize other projects sidebar on action == view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man) [23:30:32] oh yea. DI is nice, but makes us init stuff early, so the settings get evaluated [23:30:33] aude: But not for langlinksitegroup [23:30:42] can we use that also as a default for langlinksitegroup ? [23:30:54] aude: Yes [23:30:56] should work for most sites [23:31:04] it's the same except for that wikis where we overwrite anyway [23:31:07] commons and wikidata [23:31:08] Commons needs an exception [23:31:10] i can make a patch for that, although dont' know how much it helps [23:31:15] and maybe some others (wikidata?) [23:31:16] aude: Please [23:31:16] we have it set already for commons and wikidata [23:31:18] k [23:31:20] will push immediately [23:31:30] * aude is on crappy airport wifi [23:31:33] that should just fix it [23:31:41] DanielK_WMDE: what about Wikibase\Client\WikibaseClient->getLangLinkHandler() ? [23:31:42] i thought we had that [23:31:42] but can do the patch as i logged in again for another 45 minutes [23:31:46] That's a different problem [23:32:06] aude: No, can do it [23:32:06] getLangLinkHandler, that's why we split it from the sidebar hook handler [23:32:09] hoo: doesn't that just hit the same option? if it's set explicitly, nothing happens [23:32:11] hoo: ok [23:32:29] DanielK_WMDE: only supposed to be acessed with the parser after parser hook [23:32:40] idk if we missed something though [23:32:57] i would disable the other projects feature for now for special pages, perhaps [23:33:12] not sure they work well with these output page properties [23:33:13] i still don't quite see the problem [23:33:14] $this->settings->getSetting( 'siteGlobalID' ) [23:33:20] that shouldn't cause trouble, right? [23:33:32] hoo: what exactly is the problem with getLangLinkHandler()? [23:33:34] shouldn't [23:34:02] the default callback for siteGlobalID doesn't use Sites [23:34:09] all it does is return $GLOBALS['wgDBname']; [23:34:25] DanielK_WMDE: Wikibase\Client\Hooks\ParserAfterParseHookHandler::newFromGlobalState() calls it [23:34:30] on action=history and such [23:34:40] ugh [23:35:35] hoo: yes, but so what? i don't see where it accesses memcached [23:37:03] if accessing that key causes an exception, can you post a backtrace? [23:37:24] one sec [23:37:40] http://fpaste.org/156403/41764982/ [23:39:06] :( [23:39:37] err, getLangLinkHandler calls $this->getSiteStore()->getSites() [23:39:42] eek. [23:39:42] yep [23:39:44] fix on the way [23:39:52] (03Abandoned) 10Hoo man: Only initialize other projects sidebar on action == view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man) [23:39:55] the real solution is to have a deferred Sites object [23:40:06] which we can pass around, but which will only initialize itself when needed [23:41:26] oh ffs [23:41:44] http://fpaste.org/156404/65010514/ [23:41:47] after applying my fix [23:42:15] (03Restored) 10Hoo man: Only initialize other projects sidebar on action == view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 (owner: 10Hoo man) [23:42:31] DanielK_WMDE: that's what my patches will do (i have a bunch of drafts) [23:42:43] plus not use memcached entirely [23:43:15] and there are places we only want 1 or maybe 5 sites but currently initialize all site objects hte way SiteList works now to get the 5 sites [23:43:37] best solution now is to give it a SiteSQLStore object [23:43:49] and from there, request sites only when needed [23:44:15] yea, sounds good. [23:44:33] A SiteListStub may not be needed. passing around the store isn't that great, but not horrible either [23:45:03] * DanielK_WMDE is about to drop off [23:45:06] it's nasty to initialize 888 sites for 1 [23:45:15] we can avoid that in those cases [23:45:27] yes. database queries are nice in that they can be selective [23:45:49] *sigh* we need a smarter solution for this [23:45:53] yeah [23:45:59] we can chat when i get back [23:46:50] the SiteStore interface doesn't work for the cache [23:47:00] file cache since we don't want the write parts together [23:47:54] only populate sites or rebuild cache script needs to write [23:48:40] (03PS1) 10Hoo man: Don't load all sites for LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177429 [23:49:54] (03CR) 10Aude: Don't load all sites for LangLinkHandler (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177429 (owner: 10Hoo man) [23:50:19] aude: Yeah, good idea [23:50:32] (03CR) 10Aude: [C: 04-1] "oops" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177429 (owner: 10Hoo man) [23:50:52] aude: Production ready :D [23:50:55] heh [23:52:26] (03PS2) 10Hoo man: Don't load all sites for LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177429 [23:52:36] gotta go [23:52:44] (03CR) 10Hoo man: "Addressed Aude's comments." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177429 (owner: 10Hoo man) [23:52:48] ok, cu :) [23:53:14] (03PS3) 10Hoo man: Don't load all sites for LangLinkHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177429 [23:56:38] hoo: this still hits memcached, but no longer always. [23:56:54] DanielK_WMDE: Yep, I'm preparing a bunch of follow-ups [23:56:55] should fix it for most cases [23:58:12] (03PS3) 10Hoo man: Only initialize other projects sidebar on action == view [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177416 [23:58:16] DanielK_WMDE: ^ that