[00:00:02] ready :) [00:00:50] yay \o/ [00:01:21] and just checking, the train deploy is tomorrow in the evening berlin time? [00:01:33] Yep, but I'll be around [00:01:35] * aude would regret sleeping through it, if it was early [00:01:37] ok [00:01:40] and also on Wednesday, it seems [00:01:43] ok [00:02:03] i'll probably be around also, but if there are problems then might have to leave and neglect them [00:02:08] on wednesday [00:02:49] Jan is also going to be around [00:02:53] so we're well covered :) [00:02:59] yay [00:07:22] https://test.wikidata.org/wiki/Property:P141 :) [00:08:25] Hm.. could someone help me out with ContentHandler? [00:08:35] Trying to implement JavaScriptContent::isValid. [00:08:44] Seems making it return false results in an uncaught exception [00:08:55] MWException from line 1836 of /Users/krinkle/Development/mediawiki/core/includes/page/WikiPage.php: New content failed validity check! [00:09:21] On meta.wikimedia.org, Schema JsonContent is handled more elegantly (edit is properly prevented and message "Invalid JSON" is displayed on top of the edit screen) [00:09:29] probably daniel is best to answer but he might be too tired [00:09:36] I thought this was part of core, but is acually in the EventLogging extension. [00:09:52] Core does have some form of handling for that [00:09:52] Using the EditFilterMerged hook. [00:09:53] i think there is a separate extension for JsonContent [00:10:01] afaik so the code is shared [00:10:07] and might be some of it is in core now [00:10:34] ApiEditPage eg. validates wikibase changes, if you use it to do them (but we disallow that for sanity reasons) [00:10:43] EventLogging uses core's JsonContent and extends it with a method validate(), https://github.com/wikimedia/mediawiki-extensions-EventLogging/blob/e063899e1/includes/JsonSchemaHooks.php#L55-L65 [00:11:41] when I only implement isValid(), it isn't checked until WikiPage:: doEditContent at which point the exception takes over EditPage entirely with a stack trace. [00:11:50] There is no place to put a message either. [00:12:02] Advice on how to proceed would be appreciated :) [00:14:07] Krinkle: In Wikibase we override Content::prepareSave [00:14:15] it returns a status [00:14:24] in there you can check isValid() and other things [00:14:40] hoo: That's what AbstractContent does in core already [00:14:45] hoo: but mediawiki doesn't use that [00:15:28] hoo: try it. Change JavaScriptContent and add function isValid() { return false; }, then edit User:Name/foo.js and observe an "Internal error" page. [00:15:30] i can reproduce the issue if i add isValid to JavaScriptContent and return false [00:15:38] when i try to save [00:15:47] Thanks :) [00:15:56] with a new page, it gave me a warning like it should [00:16:54] well, I haven't tested that recently, might be that it's broken [00:17:05] but it clearly worked at some point (for api edits at least) [00:19:33] just indicates behavior is different if it's a new page vs existing [00:19:40] not sure why exactly or what/how [00:20:15] Pretty sure it's supposed to fail gracefully [00:21:19] if ( $changed ) { [00:21:27] in WikiPage::doEditContent [00:21:38] that's where the offending code is (inside there) [00:21:57] should probably return a status [00:22:14] or do something with status [00:22:48] for my own sanity: I'm not going to look into classes ending on Page today [00:23:22] for a new article [00:23:26] i see catch for the exception [00:24:04] does a rollback and maybe doesn't check isValid? [00:24:16] rollbacks don't check AFAIR [00:24:27] that's why you can restore invalid sitelinks using rollback [00:24:40] we have a bug for that [00:24:56] i mean transaction rollback [00:25:15] i think a proper status should be returned in doEditContent [00:25:24] * aude runs away for food.... [00:27:25] aude: It doesn't even get the status, it calls isValid directly, and then throws [00:27:32] In WikiPage::doEditContent [00:27:55] After that code path, it gets to prepareSave() [00:28:02] Seems contradictory [00:29:01] If I remove the if ( !isvalid) { throw} code, it actually reports the error properly [00:29:07] Invalid content error Nice :) [00:36:04] hoo: aude: https://gerrit.wikimedia.org/r/176845 [00:45:34] Krenair: You could check isValid as a last resort, if you want to guard against erroneous Content implementations [00:45:42] just an idea [00:45:44] Krinkle, ^ [00:45:54] doh [00:52:55] Krinkle: yes, it seems to be handled elsewhere since i got an error message for a new page [00:53:24] though would prefer DanielK to +2 if he agrees [00:54:14] aude: hoo: https://phabricator.wikimedia.org/T76204 https://gerrit.wikimedia.org/r/176853 [00:54:58] and https://gerrit.wikimedia.org/r/#/c/176845/1 [00:55:52] Krinkle: I literally love that... seeing broken commons.js etc. on various wikis for years... [00:56:29] :) [01:00:10] hoo: Can you check out the phpunit failure? I'm not sure I understand how I managed to upset that [01:00:18] https://integration.wikimedia.org/ci/job/mediawiki-phpunit/864/console [01:01:32] Krinkle: That's to stupid to be true [01:01:39] $this->makeRevision( array( 'text' => 'hello hello.', [01:01:39] 'content_model' => CONTENT_MODEL_JAVASCRIPT ) ); [01:02:00] of course that's not valid JS... :P [01:02:12] but having an actual unit tests for the new behaviour would be nice [01:03:05] hoo: Hm.. OK. I get that now [01:03:13] hoo: Why expected: ajvascript, actual: wikitext though [01:06:09] uh, that... weird [01:06:32] You forgot about WikiPageTest AFAIS [01:07:29] * WikiPageTest [01:07:50] * RevisionStorageTest [01:08:00] for some reason I can't c&p from netbeans anymore -.- [01:35:54] Also known as: "Barry Obama" [01:35:56] well... :P [01:36:42] Oh, they actually called him that... thought it was vandalism [01:37:43] heh [02:39:05] (03CR) 10Aude: [C: 032] "looks good now and allows us to proceed with investigating and implementing batch lookups for code that uses this hook." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176664 (owner: 10Daniel Kinzler) [02:43:12] (03Merged) 10jenkins-bot: Use TermLookup in LinkBegin hook. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176664 (owner: 10Daniel Kinzler) [02:47:52] (03PS1) 10Aude: Don't use Html methods in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 [02:52:55] (03PS1) 10Aude: Remove unused import in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176870 [03:02:18] 3Wikidata, MediaWiki-extensions-WikidataRepo: Use EntityInfoTermLookup / label lookup in ClaimsView and SnakHtmlGenerator for formatting property ids - https://phabricator.wikimedia.org/T75744#800256 (10aude) https://gerrit.wikimedia.org/r/#/c/176246/ [03:03:49] 3Wikidata, MediaWiki-extensions-WikidataRepo: Use EntityIdFormatter for PropertyLabels in ClaimHtmlFormatter - https://phabricator.wikimedia.org/T75888#800257 (10aude) [03:04:00] 3Wikidata, MediaWiki-extensions-WikidataRepo: Use EntityIdFormatter for PropertyLabels in ClaimHtmlFormatter - https://phabricator.wikimedia.org/T75888#784398 (10aude) [03:04:15] 3Wikidata, MediaWiki-extensions-WikidataRepo: Do not load full entities when invoking LinkBegin hook - https://phabricator.wikimedia.org/T72767#800259 (10aude) [04:04:26] 3MediaWiki-extensions-WikidataRepo, Wikidata: Special:ItemDisambiguation should support case-insensitive matches. - https://phabricator.wikimedia.org/T44686#800302 (10Mattflaschen) [04:06:32] 3MediaWiki-extensions-WikidataRepo, Wikidata: Ability to filter recent changes and watchlist on Wikidata - https://phabricator.wikimedia.org/T43686#800304 (10Mattflaschen) [04:08:35] 3MediaWiki-extensions-WikidataClient, Wikidata: inverse properties - https://phabricator.wikimedia.org/T51165#800305 (10Mattflaschen) [05:16:52] (03PS1) 10Krinkle: Fix Jenkins condition in entry file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176882 [05:17:13] (03CR) 10Krinkle: "This change significantly changes the behaviour for regular installs" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176882 (owner: 10Krinkle) [05:17:26] (03CR) 10Krinkle: "Fixed in I29d7929aa82d5635c75bb7ea74144." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/89707 (owner: 10Addshore) [06:33:50] [13WikidataBuilder] 15tstarling opened pull request #32: Use "prepend-autoloader": false (06master...06prepend-autoloader) 02http://git.io/LmtpVg [07:01:18] [13WikidataBuilder] 15JeroenDeDauw pushed 2 new commits to 06master: 02http://git.io/3XvSFA [07:01:18] 13WikidataBuilder/06master 14ab5183a 15Tim Starling: Use "prepend-autoloader": false... [07:01:19] 13WikidataBuilder/06master 141ff475a 15Jeroen De Dauw: Merge pull request #32 from tstarling/prepend-autoloader... [07:52:17] (03CR) 10Jeroen De Dauw: [C: 032] Fix Jenkins condition in entry file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176882 (owner: 10Krinkle) [07:53:59] (03CR) 10Jeroen De Dauw: Do not type hint against Entity in EntityContentFactory. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175738 (owner: 10Jeroen De Dauw) [07:54:06] (03Abandoned) 10Jeroen De Dauw: Do not type hint against Entity in EntityContentFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175738 (owner: 10Jeroen De Dauw) [07:56:00] (03Merged) 10jenkins-bot: Fix Jenkins condition in entry file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176882 (owner: 10Krinkle) [08:46:54] multichill|work: hey [08:49:50] hee sjoerddebruin [08:56:59] 3Multimedia, MediaWiki-extensions-WikidataRepo, Structured-Data: basic support for structured data on mediawiki files - https://phabricator.wikimedia.org/T66288#800681 (10Gilles) [09:24:37] (03PS1) 10Thiemo Mättig (WMDE): Remove unused imports from Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176903 [09:25:27] (03PS1) 10Thiemo Mättig (WMDE): Remove unused imports from Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176904 [09:31:00] hey :) [09:33:01] hi [09:37:07] (03PS1) 10Thiemo Mättig (WMDE): Remove unused imports from Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176905 [09:43:07] (03PS6) 10Thiemo Mättig (WMDE): Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [09:52:05] * Lydia_WMDE waves [10:07:23] (03PS7) 10Thiemo Mättig (WMDE): Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [10:20:06] (03PS3) 10Thiemo Mättig (WMDE): Clean up SiteLinkLookup and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176652 [10:20:18] (03CR) 10Thiemo Mättig (WMDE): Clean up SiteLinkLookup and related (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176652 (owner: 10Thiemo Mättig (WMDE)) [10:20:24] (03CR) 10JanZerebecki: [C: 032] Drop unused code from SpecialEntityDataTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175976 (owner: 10Thiemo Mättig (WMDE)) [10:24:58] (03CR) 10jenkins-bot: [V: 04-1] Clean up SiteLinkLookup and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176652 (owner: 10Thiemo Mättig (WMDE)) [10:26:10] (03Merged) 10jenkins-bot: Drop unused code from SpecialEntityDataTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175976 (owner: 10Thiemo Mättig (WMDE)) [10:27:24] [13WikibaseDatabase] 15JeroenDeDauw created 06wrappper (+1 new commit): 02http://git.io/9J1fvQ [10:27:24] 13WikibaseDatabase/06wrappper 14d09490c 15jeroendedauw: WIP [10:27:35] (03PS4) 10Thiemo Mättig (WMDE): Clean up MockRepository, SiteLinkLookup and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176652 [10:30:34] wmde/WikibaseDatabase/wrappper/d09490c : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDatabase/builds/42721845 [10:35:38] 3Wikidata, MediaWiki-extensions-WikidataRepo: Investigate how prefetching labels would work for watchlist and recent changes - https://phabricator.wikimedia.org/T74309#800949 (10daniel) @aude: thanks for the benchmark! I'm surprised that loading the full entities does not have a bigger impact on memory usage. Ho... [10:38:32] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/HxHF0Q [10:38:32] 13WikibaseDatabase/06master 14daa3336 15Jeroen De Dauw: Update script.sh [10:38:36] 3Wikimedia-Wikidata, Wikidata: Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on) - https://phabricator.wikimedia.org/T73519#800960 (10daniel) [10:40:16] (03PS6) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [10:40:31] 3MediaWiki-extensions-WikidataRepo: Use terms-lookup service in EntityID formatters - https://phabricator.wikimedia.org/T74036#800968 (10daniel) [10:40:33] 3Wikidata, MediaWiki-extensions-WikidataRepo: Inject term lookup into formatters - https://phabricator.wikimedia.org/T74308#800969 (10daniel) [10:45:36] 3Wikidata, MediaWiki-extensions-WikidataRepo: Inject term lookup into formatters - https://phabricator.wikimedia.org/T74308#800984 (10daniel) [10:49:10] (03PS1) 10Thiemo Mättig (WMDE): Make EntityPerPageBuilderTest fields/methods private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176913 [10:58:07] 3Wikidata, MediaWiki-extensions-WikidataRepo: Inject term lookup into formatters - https://phabricator.wikimedia.org/T74308#801014 (10daniel) [10:58:58] 3Wikidata, MediaWiki-extensions-WikidataRepo: Make formatter for referenced Items use pre-fetched labels. - https://phabricator.wikimedia.org/T70022#801015 (10daniel) [10:59:55] 3Wikidata, MediaWiki-extensions-WikidataRepo: disallow adding sitelinks to File namespace on Commons - https://phabricator.wikimedia.org/T76155#801017 (10Lydia_Pintscher) p:5High>3Unbreak! [11:00:08] 3Wikidata, MediaWiki-extensions-WikidataRepo: disallow adding sitelinks to File namespace on Commons - https://phabricator.wikimedia.org/T76155#792023 (10Lydia_Pintscher) [11:01:18] hiya, question for Lydia_WMDE and other skilled folk: is there already, or are there plans to make, a way to find an element (Q####) by an ID used in a property? e.g. a property that uses a unique ID, and you can search for that ID and find the Q number? [11:01:48] Jhs: yes :) [11:01:50] that's simple queries [11:01:53] until then: https://tools.wmflabs.org/wikidata-todo/resolver.php [11:04:23] (03PS1) 10Thiemo Mättig (WMDE): Avoid getDefaultInstance method name in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176915 [11:06:55] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] "Please merge my other (smaller) patches first, I will rebase this later." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [11:09:55] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I just did the same in Ia1cd608." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176870 (owner: 10Aude) [11:11:12] Lydia_WMDE: When will the entity suggester database get a update? Every two weeks? [11:13:14] (03Merged) 10jenkins-bot: Remove unused import in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176870 (owner: 10Aude) [11:15:22] probably a bit more [11:16:09] Still manually? [11:16:15] yeah [11:16:26] Any plans to make it automatic? [11:16:43] yes :) [11:16:50] there is a ticket on phabricator for it [11:16:55] but not happened yet :( [11:16:59] Ok. [11:18:16] 3Wikidata, MediaWiki-extensions-WikidataRepo: Automate Entity Suggester Data Updates - https://phabricator.wikimedia.org/T72037#801056 (10Sjoerddebruin) [11:18:23] That one. ;) [11:19:22] Do we have a bug ehm task for the blacklist yet? [11:58:55] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/JW5Hfw [11:58:55] 13WikibaseDatabase/06master 14195fd58 15Jeroen De Dauw: Update script.sh [12:01:58] wmde/WikibaseDatabase/master/195fd58 : Jeroen De Dauw The build was broken. http://travis-ci.org/wmde/WikibaseDatabase/builds/42729356 [12:05:23] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/oqMIqQ [12:05:23] 13WikibaseDatabase/06master 14c8d9177 15Jeroen De Dauw: Update script.sh [12:07:01] wmde/WikibaseDatabase/master/c8d9177 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wmde/WikibaseDatabase/builds/42729701 [12:07:26] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/gTF7tg [12:07:26] 13WikibaseDatabase/06master 1409550f6 15Jeroen De Dauw: Update script.sh [12:09:07] wmde/WikibaseDatabase/master/09550f6 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wmde/WikibaseDatabase/builds/42729895 [12:10:21] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/iRtddA [12:10:21] 13WikibaseDatabase/06master 14fc11b0f 15Jeroen De Dauw: Update script.sh [12:12:34] wmde/WikibaseDatabase/master/fc11b0f : Jeroen De Dauw The build is still failing. http://travis-ci.org/wmde/WikibaseDatabase/builds/42730050 [12:16:53] [13WikibaseDatabase] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/kdJHKg [12:16:53] 13WikibaseDatabase/06master 1468b2669 15Jeroen De Dauw: Update script.sh [12:22:27] wmde/WikibaseDatabase/master/68b2669 : Jeroen De Dauw The build is still failing. http://travis-ci.org/wmde/WikibaseDatabase/builds/42730566 [12:35:40] I'm masspatrolling new pages created by 10.68.17.174 (logged out oauth) [12:37:59] 3Wikidata, MediaWiki-extensions-WikidataRepo: item not found exception from Special:EnitityData should not be logged - https://phabricator.wikimedia.org/T76458 (10JanZerebecki) 3NEW p:3High a:3Wikidata-bugs [12:41:14] (03CR) 10Daniel Kinzler: "For reference: Katie collected some stats at T74309#798908" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176650 (owner: 10Daniel Kinzler) [12:47:05] 3Wikidata, MediaWiki-extensions-WikidataRepo: item not found / invalid id exception from Special:EnitityData should not be logged - https://phabricator.wikimedia.org/T76458#801199 (10JanZerebecki) [12:54:55] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "This seems odd. Why do you think this is a bottleneck? These methods look like they are very cheap, but I did not benchmarked them. Howeve" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 (owner: 10Aude) [12:57:39] (03CR) 10Jeroen De Dauw: "concur with Thiemo" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 (owner: 10Aude) [12:57:58] 3Wikidata, MediaWiki-extensions-WikidataRepo: create filter by language that can be applied to objects before passing to serialization - https://phabricator.wikimedia.org/T73512#801227 (10daniel) Related task: T73992 "JSON should (optionally) contain full URIs for referenced external entities" [13:06:51] 3MediaWiki-extensions-WikidataRepo, Wikidata: Sort statement: Up arrow and question mark nearly melted into each other - https://phabricator.wikimedia.org/T61951#801234 (10Lucie) [13:09:00] (03CR) 10Thiemo Mättig (WMDE): "I did an actual benchmark. Calling this piece of code 10,000 times takes:" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 (owner: 10Aude) [13:15:19] 3MediaWiki-extensions-WikidataRepo, Wikidata: Sort statement: Up arrow and question mark nearly melted into each other - https://phabricator.wikimedia.org/T61951#801256 (10Tobi_WMDE_SW) [13:19:02] 3MediaWiki-extensions-WikidataRepo, Wikidata: Sort statement: Up arrow and question mark nearly melted into each other - https://phabricator.wikimedia.org/T61951#801280 (10Lucie) Well, that's indeed still a problem. Looks like a even worse mess. {F17937} [13:22:34] 3MediaWiki-extensions-WikidataRepo, Wikidata: Sort statement: Up arrow and question mark nearly melted into each other - https://phabricator.wikimedia.org/T61951#801284 (10Lucie) [13:48:20] 3Wikidata, MediaWiki-extensions-WikidataRepo: create filter by language that can be applied to objects before passing to serialization - https://phabricator.wikimedia.org/T73512#801337 (10JanZerebecki) Consider using LanguageFallbackChain as is instead of proposed AcceptLanguageSet and Tranliterator. [13:50:25] 3Wikidata, MediaWiki-extensions-WikidataRepo: create filter by language that can be applied to objects before passing to serialization - https://phabricator.wikimedia.org/T73512#801338 (10daniel) I suggest an EntityLocalizer service as follows: ``` interface EntityLocalizer { /** ** @return Entity... [13:51:34] 3Wikidata, MediaWiki-extensions-WikidataRepo: Links in "In other languages" broken when language is an alias or out of use - https://phabricator.wikimedia.org/T47820#801339 (10Lucie) [13:51:47] 3Wikidata, MediaWiki-extensions-WikidataRepo: Links in "In other languages" broken when language is an alias or out of use - https://phabricator.wikimedia.org/T47820#801341 (10Lucie) 5Open>3Resolved [13:59:00] (03CR) 10Thiemo Mättig (WMDE): "More benchmarking: No, there is no bottleneck in the Html functions. It's possible to speed them up by about 10% but that's not worth the " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 (owner: 10Aude) [14:04:45] 3Wikidata, MediaWiki-extensions-WikidataRepo: create filter by language that can be applied to objects before passing to serialization - https://phabricator.wikimedia.org/T73512#801353 (10JanZerebecki) That interface and its implementation would reside in WikibaseRepo. [14:05:19] (03CR) 10Daniel Kinzler: [C: 032] Avoid getDefaultInstance method name in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176915 (owner: 10Thiemo Mättig (WMDE)) [14:05:56] (03CR) 10Daniel Kinzler: [C: 032] Make EntityPerPageBuilderTest fields/methods private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176913 (owner: 10Thiemo Mättig (WMDE)) [14:09:27] 3MediaWiki-extensions-WikidataClient, Wikidata, MediaWiki-extensions-WikidataRepo: split wikibase.git - https://phabricator.wikimedia.org/T75863#801360 (10Lydia_Pintscher) Result of today's discussion is that the next step in the split will be: {F17944} [14:10:13] (03Merged) 10jenkins-bot: Avoid getDefaultInstance method name in tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176915 (owner: 10Thiemo Mättig (WMDE)) [14:10:29] (03Merged) 10jenkins-bot: Make EntityPerPageBuilderTest fields/methods private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176913 (owner: 10Thiemo Mättig (WMDE)) [14:11:32] (03PS2) 10Aude: Don't use Html methods in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 [14:11:53] 3Wikidata, MediaWiki-extensions-WikidataRepo: move parsers and validators into own directory - https://phabricator.wikimedia.org/T76468 (10Lydia_Pintscher) 3NEW p:3Triage [14:12:19] 3Wikidata, MediaWiki-extensions-WikidataRepo: move wikibase parsers and validators into a separate repository - https://phabricator.wikimedia.org/T75879#801371 (10Lydia_Pintscher) [14:13:03] 3Wikidata, MediaWiki-extensions-WikidataRepo: move formatters into their own repository - https://phabricator.wikimedia.org/T75871#801372 (10Lydia_Pintscher) [14:13:53] (03CR) 10Aude: "this method is called over and over again for each time an item or property is used in recent changes, so thousands of times." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 (owner: 10Aude) [14:13:59] 3Wikidata, MediaWiki-extensions-WikidataRepo: move formatters into own directory - https://phabricator.wikimedia.org/T76469#801374 (10Lydia_Pintscher) [14:15:02] 3Wikidata, MediaWiki-extensions-WikidataRepo: move storage into storage implementation and storage interface repositories - https://phabricator.wikimedia.org/T75877#801383 (10Lydia_Pintscher) [14:15:07] 3Wikimedia-Wikidata, Wikidata: have one testwiki (client) on test-wikidata-branch (repo) - 1 - https://phabricator.wikimedia.org/T76470 (10JanZerebecki) 3NEW p:3Normal [14:15:52] 3Wikidata, MediaWiki-extensions-WikidataRepo: move storage into storage implementation and storage interface directories - https://phabricator.wikimedia.org/T76471 (10Lydia_Pintscher) 3NEW p:3Triage [14:16:04] (03CR) 10Daniel Kinzler: [C: 032] Clean up MockRepository, SiteLinkLookup and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176652 (owner: 10Thiemo Mättig (WMDE)) [14:18:25] (03CR) 10Daniel Kinzler: "I'm rather dubious about going back to concatenating strings for a 10% speedup (well, if it was 10% of the overall round trip time, fine, " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 (owner: 10Aude) [14:19:29] (03Merged) 10jenkins-bot: Clean up MockRepository, SiteLinkLookup and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176652 (owner: 10Thiemo Mättig (WMDE)) [14:20:47] 3Wikidata, MediaWiki-extensions-WikidataRepo: Non-English letters aren't linked - https://phabricator.wikimedia.org/T47126#801413 (10Lucie) [14:29:32] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "If this is called thousands of times we are talking about seconds." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 (owner: 10Aude) [14:33:16] (03Merged) 10jenkins-bot: Don't use Html methods in LinkBeginHookHandler [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176869 (owner: 10Aude) [14:37:59] (03PS2) 10Thiemo Mättig (WMDE): Move Repo Hooks classes to Hooks folder/namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176661 [14:49:35] (03CR) 10JanZerebecki: [C: 032] Remove unused imports from Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176903 (owner: 10Thiemo Mättig (WMDE)) [14:50:49] (03CR) 10JanZerebecki: [C: 032] Remove unused imports from Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176904 (owner: 10Thiemo Mättig (WMDE)) [14:53:06] 3Wikidata, MediaWiki-extensions-WikidataRepo: Chillu letters in Wikidata API - https://phabricator.wikimedia.org/T53326#801459 (10Lucie) [14:53:18] 3Wikidata, MediaWiki-extensions-WikidataRepo: Chillu letters in Wikidata API - https://phabricator.wikimedia.org/T53326#801461 (10Lucie) [14:53:49] (03Merged) 10jenkins-bot: Remove unused imports from Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176903 (owner: 10Thiemo Mättig (WMDE)) [14:55:03] (03Merged) 10jenkins-bot: Remove unused imports from Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176904 (owner: 10Thiemo Mättig (WMDE)) [14:56:34] Internet slowwwwneessss [14:57:44] Cloning at 9KiB/s, yay [15:03:01] (03CR) 10Aude: "willing to remove -1." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176650 (owner: 10Daniel Kinzler) [15:05:23] 3MediaWiki-extensions-WikidataRepo, Wikidata: Double escaping in restore failure message - https://phabricator.wikimedia.org/T59533#801466 (10Lucie) Still the same. {F17958} [15:05:42] 3MediaWiki-extensions-WikidataRepo, Wikidata: Double escaping in restore failure message - https://phabricator.wikimedia.org/T59533#801469 (10Lucie) [15:06:55] Lydia_WMDE: Do we have a bug for phase 2 on commons? [15:07:04] Preparing the change now [15:07:46] hoo: don't think we do. only https://phabricator.wikimedia.org/T76155 [15:08:28] Lydia_WMDE: Yeah... will take care of that one later on [15:08:59] cool :) [15:09:01] Am in a lecture right now... boring one, but still not the best environment to concentrate [15:09:12] hehe [15:09:14] ok [15:14:00] Yeah... it's an introduction to Java... after having worked with PHP, C++ (and other similar languages) there's nothing much new for me [15:19:48] 3MediaWiki-extensions-WikidataRepo, Wikidata: Translated language names should be used in $1 in - https://phabricator.wikimedia.org/T57352#801476 (10Lucie) 5Open>3Resolved [15:25:58] (03Abandoned) 10Thiemo Mättig (WMDE): Rework and clean up MockRepository and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175968 (owner: 10Thiemo Mättig (WMDE)) [15:26:27] 3MediaWiki-extensions-WikidataRepo, Wikidata: no-external-page error should provide machine readable error info - https://phabricator.wikimedia.org/T56366#801479 (10Lucie) The error message is more detailed now: { "servedby": "mw1017", "error": { "code": "no-external-page", "info": "T... [15:26:41] 3MediaWiki-extensions-WikidataRepo, Wikidata: no-external-page error should provide machine readable error info - https://phabricator.wikimedia.org/T56366#801481 (10Lucie) [15:26:42] 3Wikidata, MediaWiki-extensions-WikidataRepo: Wikidata repo MW API (tracking) - https://phabricator.wikimedia.org/T41174#801483 (10Lucie) [15:37:00] (03PS1) 10Daniel Kinzler: Introduce DataType for refs to Properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 [15:39:09] (03CR) 10Lydia Pintscher: [C: 04-1] "Missing UI support" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 (owner: 10Daniel Kinzler) [15:39:33] (03CR) 10JanZerebecki: "Also should prevent adding properties as item references like on https://test.wikidata.org/wiki/Q624" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 (owner: 10Daniel Kinzler) [15:44:24] (03PS2) 10Daniel Kinzler: Introduce DataType for refs to Properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 [15:45:17] (03CR) 10Daniel Kinzler: [C: 04-1] "missing test case" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 (owner: 10Daniel Kinzler) [15:48:31] (03PS3) 10Daniel Kinzler: Introduce DataType for refs to Properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 [15:50:07] (03CR) 10JanZerebecki: [C: 032] Remove unused imports from Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176905 (owner: 10Thiemo Mättig (WMDE)) [15:52:00] (03CR) 10jenkins-bot: [V: 04-1] Introduce DataType for refs to Properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 (owner: 10Daniel Kinzler) [15:53:36] (03Merged) 10jenkins-bot: Remove unused imports from Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176905 (owner: 10Thiemo Mättig (WMDE)) [16:05:27] (03PS7) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [16:06:58] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "See question." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [16:13:58] jzerebecki: Lydia_WMDE can you please describe https://phabricator.wikimedia.org/T76470 more in the task? [16:14:21] * aude really doesn't understand it [16:57:14] Every time I want to save a value quick it chooses the suggestion before that showed up before I've entered the whole word. [17:02:09] (03CR) 10Aude: [C: 04-1] "some questions and suggestions, and also needs a manual rebase." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [17:28:18] (03CR) 10JanZerebecki: [C: 04-1] "Missing test for new functionality of EntityExistsValidator." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176933 (owner: 10Daniel Kinzler) [17:37:30] aude: better now? [17:37:52] (03CR) 10Daniel Kinzler: Extract FormatterLabelLookupFactory (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [17:38:58] (03PS7) 10Daniel Kinzler: Extract FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 [17:39:46] aude, jzerebecki: merge? --^ [17:50:41] (03PS8) 10Daniel Kinzler: Extract FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 [17:50:44] there are screens with 2560x1440 out there... I so need that :D [17:53:15] (03PS15) 10Daniel Kinzler: Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) [18:01:14] (03PS12) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) [18:13:04] (03CR) 10Daniel Kinzler: [C: 04-1] Filter page purged by usage aspect. (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [18:15:08] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/12/02 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/176968 [18:19:37] hoo: ping [18:19:42] hey [18:19:43] :) [18:20:47] hoo: so, did you turn off statements on properties also for setups that have WB_EXPERIMENTAL_FEATURES=true? [18:21:09] Tobi_WMDE_SW: No, the setting is true per default [18:21:22] so unless you changed that, you should be able to set properties [18:21:34] hoo: see http://wikidata.beta.wmflabs.org/wiki/Property:P694 [18:21:45] no UI for adding statements [18:22:00] and AFAIK experimental is set to true on beta [18:22:19] It no longer has anything to do with experimental [18:22:23] but that's interesting [18:22:27] no wait, it's not [18:22:49] That wiki things it's wikidatawiki, so it uses Wikidata's settings [18:22:54] which have the feature turned of [18:23:00] * thinks [18:23:24] testwikidata has the right setting [18:23:55] do Anybody know how to add a Source as "Imported as" in wikidata by a bot? I have tried but It doesn't work. http://pastebin.com/UKC4FBQK [18:24:30] hoo: I think aude turned on experimental for beta [18:24:30] and it used to work a few days ago [18:24:48] Yeah, but that setting no longer has anything to do with experimental [18:24:54] I made it an own setting [18:25:14] and that is false for Wikidata (obviously)... and beta acts like wikidata (not testwikidata) [18:25:18] which is awry [18:25:25] hoo: can we change that please? [18:25:30] Let me think [18:25:42] like it was possible to change it for the experimental setting [18:26:12] why would the experimental setting be handled differently from the new setting? [18:26:56] Well, we don't want the experimental stuff on testwikidata, it should be (almost) like wikidata [18:27:40] but we definitely want it on beta [18:28:26] we can have different settings for beta [18:28:36] Wikibase-labs.php i think [18:29:02] make that and then get realm specific file (whatever) in CommonSettings.php [18:29:08] * aude makes patch [18:29:26] aude: I'm on it [18:29:37] aude: hoo: that's what I think. it was possible to have a different setting for experimental_features. so it should be possible to have different settings for the new one. [18:29:42] hoo: ok [18:29:48] aude: Not going to create a file [18:29:55] we will remove that setting soon anyway [18:29:56] hm [18:29:58] ok [18:29:58] hopefully this week [18:30:43] ok [18:31:32] aude: https://gerrit.wikimedia.org/r/176973 ok with you? [18:32:36] what is the default setting? [18:33:28] aude: true [18:33:55] ok for now [18:34:16] aude: We will deploy it to Wikidata tomorrow, so the setting can die then [18:34:25] fooood [18:34:29] will be back for the deploy [18:34:38] generally, idk if it makes it clearer but think we could combine some of the if ( .... testwikidatawiki) blocks [18:34:51] we enable statements on properties tomorrow? [18:34:55] Yep [18:34:58] hmm [18:35:04] Concerns? [18:35:13] no, but surprised [18:35:27] heh [18:35:41] https://www.mediawiki.org/wiki/Wikidata_deployment is outdated [18:35:42] away now [18:35:50] we should have this stuff on the calendar [18:58:34] aude: Yeah, agreed [19:03:20] hoo: anything important missing https://www.mediawiki.org/wiki/Wikidata_deployment#wmf.2F1.25wmf10 ? [19:03:33] * aude assumes we need to bump cache epoch again [19:03:43] No [19:03:54] Are you sure about bumping the cache epoch? [19:06:56] the edit button for the label was weird on test.wikidata [19:06:59] for one thing [19:07:05] until i purged [19:07:30] ok [19:07:50] ReferenceError: wikibase is not defined ReferenceError: wikibase is not defined [19:07:53] also seeing on test.wikidata [19:08:00] let's see if a purge fixes it [19:08:26] i assume until we are done with the redesign, we always need to bump cache epoch (evil as that is to do) [19:08:37] purge fixed the js error [19:09:08] http://snag.gy/AiYNL.jpg omg [19:09:20] ewk [19:09:23] very much needed [19:09:25] purge fixes it [19:09:33] *vomits* [19:10:19] do we need to fix authority gadget again? [19:11:37] maybe [19:11:43] what version does testwikidata have? [19:11:51] s/what/which [19:12:13] Probably it hasn't got the patches I applied on Wikidata last week [19:12:36] it was just my copy of the gadget [19:12:43] was updated last week [19:12:55] special:random.... now things look fine on wikidata [19:14:49] https://www.wikidata.org/w/index.php?title=Q183&oldid=143201634&omgitworks! :) [19:15:07] random string to break the caches [19:16:30] oh, i have hhvm [19:16:34] let me try again [19:17:54] hoo: i am getting hhvm it seems regardless of my preferences [19:18:11] preferences etc. have been disabled [19:18:14] stuff is random now [19:18:27] * aude sees the beta feature [19:20:46] hmmm still times out [19:21:33] what? [19:21:37] Germany? [19:23:48] yes [19:23:53] if i get zend [19:25:00] aude: Do we have a list of automated edit summaries which are no longer being used? [19:25:42] ah, it's in the qqq [19:25:44] no idea [19:25:57] meh [19:26:13] am trying to get edit summaries for statement stuff on Properties right [19:30:27] still see Warning: Division by zero in /srv/mediawiki/php-1.25wmf10/extensions/Wikidata/vendor/data-values/geo/src/Formatters/GeoCoordinateFormatter.php on line 217 [19:32:28] ewk [19:32:32] Only for wmf10? [19:33:20] we have 1.1.3 in the build deployed [19:33:26] fix is in 1.1.4 [19:33:32] what [19:33:43] https://phabricator.wikimedia.org/T75601#787664 [19:33:49] did it pull in the old version for wmf10? [19:33:58] apparently [19:34:07] or didn't backport it there [19:35:15] :S [19:35:26] got it [19:35:28] aude: Will you fix, or shall I? [19:35:30] we can swat it [19:35:33] patch coming [19:35:36] ok :) [19:35:38] Thanks [19:36:26] (03PS1) 10Aude: Update data values geo for Wikidata [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176998 [19:36:44] will see if ree.dy can deploy it once the submodule change is ready [19:40:21] hmm, what do you think of https://phabricator.wikimedia.org/T76470 ? [19:40:43] keep test2 on the old branch until "group 1" ? [19:42:49] aude: Don't really see a need right now [19:43:14] * aude nods [19:43:21] commented in the task [19:44:30] (03CR) 10Aude: [C: 032] Update data values geo for Wikidata [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176998 (owner: 10Aude) [19:47:40] (03Merged) 10jenkins-bot: Update data values geo for Wikidata [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/176998 (owner: 10Aude) [19:56:25] aude: thinking about it: Do we want the edit summary localization for property stuff also backported? [19:56:36] Sadly Lydia is not around to decide [19:59:21] (03PS1) 10Hoo man: Add messages for Statement on Property related edit summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177008 [19:59:27] hoo: i think so [19:59:33] if it's what i think it is and small enough [19:59:48] it is: https://gerrit.wikimedia.org/r/177008 [19:59:49] * aude as seeing message keys and not summaries [19:59:53] was* [20:00:10] Took me a bit to get that right (especially qqq) [20:00:17] ok [20:00:44] Added {{identical|wikibase-item-summary-...}} [20:00:48] to all new messages [20:00:51] as they all are [20:01:20] looks evil generally (given how the summary formatting works) [20:01:26] can't be avoided now though [20:01:37] Yeah [20:01:40] duplicate messages [20:01:43] it's a mess [20:01:52] horrible untested code in Wikibase.hooks.php [20:03:13] i won't backport right now but before tomorrow deploy [20:03:33] in case siebrand etc. wants to review [20:04:23] Raymond_: Want to take a quick look at https://gerrit.wikimedia.org/r/177008 ? [20:04:39] Mostly duplicated the messages and noted that they're identical with {{identical [20:05:48] Only really touched the QQQ, rest is copied [20:06:27] yeah [20:06:39] i'll merge later or tomorrow if no one else does [20:07:11] would like second opinion, that qqq is all correct [20:07:44] (03CR) 10Aude: [C: 031] "looks ok to me, but wouldn't mind a second opinion, especially on the qqq part." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177008 (owner: 10Hoo man) [20:09:17] re [20:09:19] sorry folks [20:09:24] it's a Lydia_WMDE ! :) [20:09:25] was grocery shopping [20:09:28] it is! [20:09:29] :D [20:09:31] always more important [20:09:54] everything is ok, only minor stuff that we are taking care of [20:10:03] you rock [20:10:25] i will eat something and then write announcement for commons [20:10:36] Lydia_WMDE: Yeah, awesome [20:10:37] anything else to announce that i forgot? [20:10:48] Statements on Properties tomorrow? [20:10:52] yeah [20:10:56] Seems like that's not clear to everyone, yet [20:11:00] right [20:11:02] ok [20:12:35] Hm? https://www.wikidata.org/w/index.php?title=Q328&diff=178734166&oldid=178733465 [20:13:23] * aude was surprised [20:13:25] Aren't people deleting pages? [20:13:34] On non-Wikipedias [20:13:36] though after close reading of your email from last week, i see that it was announced [20:13:37] * hoo waits [20:14:28] (03PS2) 10Hoo man: Add messages for Statement on Property related edit summaries [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177008 [20:15:59] sjoerddebruin: that does indeed look strange [20:17:38] why does phabricator allow me to enter tasks with no project selected? [20:18:09] might take a while to get into the habit [20:19:29] Lydia_WMDE: should i always choose 'Wikidata' + 'MediaWiki-extensions-WikibaseRepository' ? [20:19:32] or just MediaWiki-extensions-WikibaseRepository [20:19:50] aude: I guess it's so people who don't know can at least file tasks, rather than guessing and getting it wrong [20:20:04] ok, suppose so [20:20:10] bugzilla always required me to choose [20:20:13] People y u no delete things :P [20:20:16] yeah [20:20:21] * Reedy deletes hoo [20:20:24] I think they get tagged for triage that way too [20:20:30] sure [20:21:19] aude: always wikidata plus something ideally [20:23:03] wikidata is the one we'll be using to point people to to see all our bugs and so on [20:27:03] Lydia_WMDE: ok, that's what i did [20:27:35] :) [20:45:16] hoo: aude: starting to write announcement now [20:45:51] :) [20:46:54] \o/ [20:47:19] as long as hoo and jzerebecki are around to deal with any potential problems, ok with me [20:47:24] * aude sure there will be no problems though [20:47:38] cool [20:48:26] * aude eats.... [20:49:46] Incredible how few pages apparently get deleted in non-Wikipedias [20:49:57] at least pages that are linked to WD [21:07:28] hoo: want me to delete the sandbox? :P [21:07:41] * aude looks at afd [21:08:09] if there's anything on commons to delete [21:08:55] Would be nice to get something [21:10:54] https://www.wikidata.org/wiki/Q5759068 [21:10:56] there you go [21:11:23] it worked! [21:11:27] Yay :) [21:11:27] https://www.wikidata.org/w/index.php?title=Q5759068&action=history [21:11:33] \o/ [21:13:31] it now automatically deletes the link on Wikidata? :O [21:13:37] yes [21:13:40] cool! [21:15:07] We still need lazy admins to delete empty items. :) [21:16:54] nah, I'm too lazy xD [21:19:16] bot! [21:19:22] lazy bots [21:24:22] (03Draft1) 10Aude: Split getLabelLookup method in FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 [21:26:42] (03CR) 10Aude: "don't necessarily want to block this chain and the dependencies, but i would change the structure of the factory class to have one method " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [21:27:22] (03CR) 10jenkins-bot: [V: 04-1] Split getLabelLookup method in FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 (owner: 10Aude) [21:32:28] https://twitter.com/wikidata/status/539891914922008577 [21:32:41] * Lydia_WMDE was really impressed with the students today [21:33:25] Wow :) [21:34:33] So we can really communicate with other api's soon? [21:35:15] sjoerddebruin: depends on your definition but yes [21:35:34] :D [21:40:35] (03CR) 10Aude: "might just be matter of taste but i don't find the code so nice in how it generalizes the option validation. see comment and also comment" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [21:40:44] (03CR) 10Aude: Extract FormatterLabelLookupFactory (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [21:40:52] (03CR) 10Aude: [C: 04-1] Extract FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [21:41:14] (03PS2) 10Aude: Split getLabelLookup method in FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 [21:41:16] (03PS9) 10Aude: Extract FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 (owner: 10Daniel Kinzler) [21:42:21] yay students! [21:46:45] (03CR) 10jenkins-bot: [V: 04-1] Split getLabelLookup method in FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 (owner: 10Aude) [21:47:00] indeed! :) [21:47:35] aaah, unstaged changes [21:47:42] * aude already fixed the patch [21:47:55] (03PS3) 10Aude: Split getLabelLookup method in FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177077 [21:48:38] * Lydia_WMDE hi5s the room [21:48:41] today was a good day :) [21:55:09] Love the quick statements tool. :) https://www.wikidata.org/w/index.php?title=User%3APasleim%2Fprojectmerge%2Fnlwiki-idwiki&diff=178753489&oldid=178744678 [22:19:44] (03PS1) 10Aude: Add array_key_exists check for language in EditEntity api module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/177090 [22:25:40] Lydia_WMDE: Those broken redirects get broken because the item where they redirect to get merged with another item and get deleted. :( [22:26:00] oh [22:26:02] i see [22:26:07] ok [22:26:27] need to talk about that with daniel [22:27:00] There are also some double redirects... https://www.wikidata.org/wiki/Special:DoubleRedirects [23:08:33] (03CR) 10Aude: [C: 032] New Wikidata Build - 2014/12/02 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/176968 (owner: 10Tobias Gritschacher) [23:10:31] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/12/02 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/176968 (owner: 10Tobias Gritschacher) [23:58:36] [13WikidataBuildResources] 15filbertkm pushed 1 new commit to 06master: 02http://git.io/WKPKJg [23:58:36] 13WikidataBuildResources/06master 143120e14 15Katie Filbert: set "prepend-autoloader": false config in composer.json