[00:07:22] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #314: Make the test bootstrap work when included from another project (06master...06bootstrap) 02http://git.io/SvpIfw [00:31:14] (03PS9) 10Jeroen De Dauw: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [00:31:27] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [00:40:45] (03PS8) 10Jeroen De Dauw: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 [00:41:18] (03CR) 10Jeroen De Dauw: "Just dropped most of the change. Did not see what was wrong and this test method is just to horrible to understand" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [00:42:43] (03PS8) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [00:42:49] (03PS7) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [00:42:55] (03PS7) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [00:54:15] (03PS1) 10Jeroen De Dauw: Remove usages of deprecated setSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176313 [00:54:47] hoo: easy 2 line review is easy https://gerrit.wikimedia.org/r/#/c/175766/ [00:56:23] JeroenDeDauw: Is that really the right thing to do? [00:57:14] mh [00:57:24] hoo: you could also just thow an exception... [00:57:29] Yeah [00:57:46] The caller could check that... but for that it would need to fetch the entity first, which is stupid [00:58:00] (03CR) 10Hoo man: [C: 032] Remove assumption that all entities have a fingerprint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175766 (owner: 10Jeroen De Dauw) [00:58:46] or we make id interfaces like FingerprintProvidingEntityId [00:58:50] :D [00:59:25] err. no [01:00:02] IdentifierForAnObjectThatMaybeHasAFingerprint [01:00:03] Idea insanity level over 9000 [01:00:15] If you use a proper name like that, we can consider it [01:01:57] (03CR) 10jenkins-bot: [V: 04-1] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [01:02:22] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [01:02:32] (03PS1) 10Jeroen De Dauw: Stop using deprecated Item::removeSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176314 [01:03:15] (03CR) 10jenkins-bot: [V: 04-1] Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [01:03:42] hoo: is this rename correct? https://gerrit.wikimedia.org/r/#/c/175760/8 [01:04:41] (03PS9) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [01:05:35] (03PS8) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [01:05:46] (03PS8) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [01:06:09] JeroenDeDauw: Yeah, should be fine [01:06:31] (03CR) 10Hoo man: [C: 031] "Name sounds fine, didn't look at the actual diff" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [01:09:03] (03Abandoned) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [01:09:05] (03CR) 10jenkins-bot: [V: 04-1] Remove usages of deprecated setSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176313 (owner: 10Jeroen De Dauw) [01:09:24] (03Restored) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [01:11:42] (03PS1) 10Jeroen De Dauw: Remove usages of deprecated setLabel method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176315 [01:13:09] (03Merged) 10jenkins-bot: Remove assumption that all entities have a fingerprint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175766 (owner: 10Jeroen De Dauw) [01:14:23] (03PS2) 10Jeroen De Dauw: Remove usages of deprecated setSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176313 [01:14:45] hoo: another easy to review one: https://gerrit.wikimedia.org/r/#/c/176313/ [01:14:53] That is just a single regex applied [01:16:25] (03CR) 10Hoo man: [C: 032] "Let's hope jenkins is going to approve" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176313 (owner: 10Jeroen De Dauw) [01:17:03] hoo: same story here https://gerrit.wikimedia.org/r/#/c/176315/ [01:17:15] Should have done this months ago >_> [01:18:45] (03CR) 10Hoo man: Remove usages of deprecated setLabel method (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176315 (owner: 10Jeroen De Dauw) [01:18:48] JeroenDeDauw: ^ [01:18:52] check your regexp [01:21:43] muh [01:21:54] [a-zA-Z] :) [01:22:00] :P [01:22:14] Want to amend? [01:22:18] am now [01:22:22] :) [01:23:14] (03PS2) 10Jeroen De Dauw: Remove usages of deprecated setLabel method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176315 [01:25:02] (03PS3) 10Jeroen De Dauw: Remove usages of deprecated setLabel method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176315 [01:26:20] (03CR) 10Hoo man: [C: 032] "Nice one" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176315 (owner: 10Jeroen De Dauw) [01:28:49] [13WikibaseDataModel] 15JeroenDeDauw created 06ssl (+1 new commit): 02http://git.io/s1wDow [01:28:49] 13WikibaseDataModel/06ssl 14b8aa69a 15jeroendedauw: Add extra convience methods to SiteLinkList [01:28:58] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #318: Add extra convience methods to SiteLinkList (06master...06ssl) 02http://git.io/fEFipw [01:29:07] hoo: ^^ [01:30:26] yeah, those make sense [01:30:41] was surpsied they where not there yet [01:30:52] Is needed to do sane replaces of some deprecated code [01:30:58] *usages of deprecated code [01:31:47] hoo: another regex: https://gerrit.wikimedia.org/r/#/c/176314/1 [01:33:43] (03CR) 10Hoo man: [C: 032] Stop using deprecated Item::removeSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176314 (owner: 10Jeroen De Dauw) [01:34:04] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/-eMmlw [01:34:04] 13WikibaseDataModel/06master 140378abb 15Marius Hoch: Merge pull request #318 from wmde/ssl... [01:35:35] lolwat [01:35:41] mh? [01:35:45] AliasGroup::isEmpty [01:36:06] ah, typo in rel notes [01:36:19] (03Merged) 10jenkins-bot: Remove usages of deprecated setSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176313 (owner: 10Jeroen De Dauw) [01:36:27] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ngVFdg [01:36:27] 13WikibaseDataModel/06master 14c9e4d41 15Jeroen De Dauw: Update RELEASE-NOTES.md [01:37:51] (03PS9) 10Jeroen De Dauw: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 [01:38:07] (03PS9) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [01:38:14] (03PS9) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [01:38:30] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated Item::removeSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176314 (owner: 10Jeroen De Dauw) [01:38:52] (03CR) 10Jeroen De Dauw: [C: 032] Fix broken @see in Number(Un)Localizer doc [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176230 (owner: 10Thiemo Mättig (WMDE)) [01:39:13] Rebase needed, meh [01:39:26] doing [01:39:33] badge unlocked: conflict with self [01:40:49] hoo: we really have a lot of places that can be updated to just use a SiteLinkList, StatamentList or Fingerprint instead of a whole entity... [01:41:03] rebased [01:41:04] (03PS2) 10Jeroen De Dauw: Stop using deprecated Item::removeSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176314 [01:41:16] (03CR) 10Hoo man: [C: 032] Stop using deprecated Item::removeSiteLink method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176314 (owner: 10Jeroen De Dauw) [01:42:04] (03PS10) 10Jeroen De Dauw: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 [01:43:20] hoo: https://gerrit.wikimedia.org/r/#/c/175770/ [01:44:37] (03CR) 10Hoo man: [C: 032] Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [01:45:41] (03PS1) 10Jeroen De Dauw: Fix broken CreatedBlacklistedItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176316 [01:46:55] (03PS1) 10Jeroen De Dauw: Stop using deprecated methods in importInterlang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176317 [01:47:00] dat broken code... [01:48:24] JeroenDeDauw: Yikes [01:48:35] why is it called Created if it only creates them? [01:48:45] huh? [01:48:46] and do we even need to support that blacklist stuff anymore? [01:49:01] CreatedBlacklistedItems [01:49:07] hoo: well, if we want to blacklist items on a new repo... [01:49:15] haha, typo I guess [01:49:16] but the name is still weird [01:49:24] possible [01:49:55] (03PS1) 10Jeroen De Dauw: Remove no longer used class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176318 [01:50:42] (03PS1) 10Jeroen De Dauw: Fix typo in classname [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176319 [01:50:42] hoo: there you go [01:53:34] (03CR) 10Hoo man: [C: 032] Remove no longer used class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176318 (owner: 10Jeroen De Dauw) [01:54:10] (03CR) 10Hoo man: [C: 04-1] "almost" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176319 (owner: 10Jeroen De Dauw) [01:58:27] leaving now [01:59:19] (03CR) 10Jeroen De Dauw: Fix typo in classname (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176319 (owner: 10Jeroen De Dauw) [02:00:39] [13WikibaseDataModel] 15JeroenDeDauw created 06diffdep (+1 new commit): 02http://git.io/xudraw [02:00:39] 13WikibaseDataModel/06diffdep 14e997a81 15jeroendedauw: Stop using deprecated code in ItemDiffer and PropertyDiffer [02:01:00] (03PS2) 10Jeroen De Dauw: Fix typo in classname [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176319 [02:02:46] wmde/WikibaseDataModel/diffdep/e997a81 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42361099 [02:03:10] (03CR) 10Jeroen De Dauw: [C: 032] "Rebase needed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175973 (owner: 10Thiemo Mättig (WMDE)) [02:04:14] (03CR) 10Jeroen De Dauw: [C: 032] Move UpdateRepo hook handlers into a dedicated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [02:05:01] (03CR) 10Jeroen De Dauw: [C: 032] Also propagate moves/deletions from non-Wikibase enabled namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176290 (owner: 10Hoo man) [02:06:35] (03CR) 10Jeroen De Dauw: [C: 032] More consistent variable naming, e.g. $languageCode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 (owner: 10Thiemo Mättig (WMDE)) [02:07:22] (03PS10) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [02:07:27] (03PS10) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [02:12:22] (03PS1) 10Jeroen De Dauw: Use Statement rank enum [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176320 [02:13:21] (03PS1) 10Jeroen De Dauw: Use Statement rank enum [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176321 [02:16:47] [13WikibaseDataModel] 15JeroenDeDauw created 06getprefixedid (+1 new commit): 02http://git.io/mrZpqw [02:16:47] 13WikibaseDataModel/06getprefixedid 1446921b0 15jeroendedauw: Remove deprecated EntityId::getPrefixedId [02:18:44] wmde/WikibaseDataModel/getprefixedid/46921b0 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42361772 [02:22:32] (03PS1) 10Jeroen De Dauw: Construct properties with a data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176322 [02:24:26] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #319: Remove deprecated EntityId::getPrefixedId (06master...06getprefixedid) 02http://git.io/SxXUmQ [02:25:01] [13WikibaseDataModel] 15JeroenDeDauw created 06entityidr (+1 new commit): 02http://git.io/LBLvCA [02:25:01] 13WikibaseDataModel/06entityidr 143ed4226 15jeroendedauw: Remove deprecated EntityId::getPrefixedId [02:25:16] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #320: Remove deprecated EntityId::getPrefixedId (063.0.x-dev...06entityidr) 02http://git.io/z8e7Rw [02:25:26] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #321: Stop using deprecated code in ItemDiffer and PropertyDiffer (06master...06diffdep) 02http://git.io/QDXPdA [02:25:45] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 060.9.x at 14ee8c720: 02http://git.io/INNwTg [02:27:11] wmde/WikibaseDataModel/entityidr/3ed4226 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42362092 [02:59:21] (03Merged) 10jenkins-bot: Remove no longer used class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176318 (owner: 10Jeroen De Dauw) [02:59:25] (03CR) 10jenkins-bot: [V: 04-1] Drop unused code from EntityViewTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175973 (owner: 10Thiemo Mättig (WMDE)) [03:29:30] (03Merged) 10jenkins-bot: More consistent variable naming, e.g. $languageCode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 (owner: 10Thiemo Mättig (WMDE)) [08:44:17] (03PS5) 10Adrian Lang: Inject siteLinkGroups into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 [08:44:19] (03PS4) 10Adrian Lang: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 [08:44:21] (03PS2) 10Adrian Lang: Rewrite completely broken EntityView tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176268 [08:44:38] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [08:44:55] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 (owner: 10Adrian Lang) [08:45:05] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176268 (owner: 10Adrian Lang) [08:46:25] (03CR) 10Adrian Lang: "@Daniel: Since this does not have any tests at all currently I consider this change to be a huge improvement as it is. Expect more tests t" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176268 (owner: 10Adrian Lang) [08:49:38] (03PS1) 10Adrian Lang: Bump version [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176328 [08:49:49] Henning_WMDE: ^ merrrge [08:51:36] (03PS4) 10Adrian Lang: Move wikibase.css and jquery.wikibase from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 [08:52:04] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174690 (owner: 10Adrian Lang) [08:53:09] (03CR) 10Henning Snater: [C: 032] Bump version [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176328 (owner: 10Adrian Lang) [08:54:02] (03CR) 10Henning Snater: [V: 032] Bump version [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176328 (owner: 10Adrian Lang) [08:55:18] (03PS3) 10Adrian Lang: move wikibase.api into own module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175987 [09:02:38] [13DataTypes] 15snaterlicious created 06paladox2015-patch-1 (+4 new commits): 02http://git.io/7SVTjA [09:02:38] 13DataTypes/06paladox2015-patch-1 1478e137c 15paladox2015: Update .js files... [09:02:38] 13DataTypes/06paladox2015-patch-1 1414c1760 15paladox2015: Update qunit.css [09:02:38] 13DataTypes/06paladox2015-patch-1 140d10ebb 15paladox2015: Update jquery.js [09:20:30] (03PS9) 10Henning Snater: Rearranged site link views [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 [09:20:48] https://gerrit.wikimedia.org/r/#/c/175987/ [09:25:24] (03CR) 10Hoo man: [C: 032] Remove @todo in phpunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175981 (owner: 10Adrian Lang) [09:30:50] (03CR) 10Henning Snater: [C: 032] move wikibase.api into own module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175987 (owner: 10Adrian Lang) [09:35:10] (03CR) 10Adrian Lang: [C: 04-1] Extract onLinkBegin hook handling into separate class (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 (owner: 10Aude) [09:36:04] (03CR) 10Adrian Lang: [C: 032] Rearranged site link views [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 (owner: 10Henning Snater) [09:37:11] (03Merged) 10jenkins-bot: Remove @todo in phpunit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175981 (owner: 10Adrian Lang) [09:40:35] (03CR) 10Adrian Lang: [C: 032] Construct properties with a data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176322 (owner: 10Jeroen De Dauw) [09:41:17] (03CR) 10Adrian Lang: [C: 032] Use Statement rank enum [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176321 (owner: 10Jeroen De Dauw) [09:41:37] (03CR) 10Adrian Lang: [C: 032] Use Statement rank enum [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176320 (owner: 10Jeroen De Dauw) [09:42:15] wmde/DataTypes/paladox2015-patch-1/fcefee5 : paladox2015 The build passed. http://travis-ci.org/wmde/DataTypes/builds/42374577 [09:42:31] (03CR) 10Adrian Lang: "Probably obsoleted by Ibc373a9017c25cc2bdacbabeea2b97d283e31b00." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175973 (owner: 10Thiemo Mättig (WMDE)) [09:42:54] (03Merged) 10jenkins-bot: move wikibase.api into own module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175987 (owner: 10Adrian Lang) [09:44:50] (03CR) 10Adrian Lang: [C: 032] "Tests would be useful." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176316 (owner: 10Jeroen De Dauw) [09:45:08] (03CR) 10Adrian Lang: [C: 032] Fix typo in classname [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176319 (owner: 10Jeroen De Dauw) [09:53:02] (03Merged) 10jenkins-bot: Rearranged site link views [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 (owner: 10Henning Snater) [09:54:40] (03Merged) 10jenkins-bot: Construct properties with a data type [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176322 (owner: 10Jeroen De Dauw) [09:56:28] (03Merged) 10jenkins-bot: Use Statement rank enum [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176321 (owner: 10Jeroen De Dauw) [10:02:35] (03Merged) 10jenkins-bot: Use Statement rank enum [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176320 (owner: 10Jeroen De Dauw) [10:07:13] (03Merged) 10jenkins-bot: Fix broken CreatedBlacklistedItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176316 (owner: 10Jeroen De Dauw) [10:07:16] (03Merged) 10jenkins-bot: Fix typo in classname [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176319 (owner: 10Jeroen De Dauw) [10:24:51] (03CR) 10Hoo man: "Both options exist, I don't really see why you changed it as the commit message is anything but revealing." [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/175997 (owner: 10Adrian Lang) [10:27:06] (03PS3) 10Hoo man: Remove _fetchItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 (owner: 10Adrian Lang) [10:30:47] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/28 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/176332 [10:44:50] Does anybody know how the language fallback will decide which language to fall back to? [10:46:08] Lydia_WMDE: ^ [10:57:57] (03CR) 10Hoo man: [C: 04-1] "All badges appear as deleted items for me with this patch applied." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 (owner: 10Adrian Lang) [10:58:35] a930913: The logic for that is a bit scary... basically it's the same as the MediaWiki system message fallbacjk [10:59:57] (03PS5) 10Hoo man: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [11:02:23] (03CR) 10Hoo man: [C: 032] Inject siteLinkGroups into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 (owner: 10Adrian Lang) [11:04:02] (03CR) 10Hoo man: [C: 032] Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [11:07:06] hoo: I have a tool that is currently waiting on a bugfix for that type of problem, what should I do? Just pick the first/random language or try copy the MW? [11:08:46] Can you please elaborate more? [11:09:04] Is your tool using labels from Wikidata? [11:09:34] hoo: Yeah. [11:10:03] hoo: Currently uses only "en", but that fails when it doesn't exist. [11:10:28] en is not falling back on anything anyway [11:10:52] (03CR) 10Hoo man: [C: 032] "Very basic tests, yet... but certainly something to start with." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176268 (owner: 10Adrian Lang) [11:11:06] For item name, I just show all, with the language prefix, but because there are many properties, I can't do that for labels. [11:12:16] (03Merged) 10jenkins-bot: Move {Entity,Property,Item}View to Wikibase\Repo\View [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176234 (owner: 10Adrian Lang) [11:19:09] [13Number] 15thiemowmde pushed 2 new commits to 06master: 02http://git.io/57lByw [11:19:09] 13Number/06master 14324b777 15jeroendedauw: Update PHPUnit bootstrap [11:19:09] 13Number/06master 14437afc6 15thiemowmde: Merge pull request #15 from DataValues/bootstrap... [11:20:07] (03CR) 10Tobias Gritschacher: [C: 032 V: 032] New Wikidata Build - 2014/11/28 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/176332 (owner: 10Tobias Gritschacher) [11:21:57] (03PS3) 10Hoo man: Language fallback for labels of referenced items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176008 (owner: 10Daniel Kinzler) [11:31:24] [13Number] 15thiemowmde 04force-pushed 06optUses from 14cfeeec3 to 145acd7e7: 02http://git.io/fpcmCw [11:31:24] 13Number/06optUses 145acd7e7 15Thiemo Mättig: Optimize all use clauses [11:34:15] 3Phabricator, MediaWiki-extensions-WikidataRepo: Decide on "Priority" field values for Maniphest tasks - https://phabricator.wikimedia.org/T268#793082 (10Qgil) I kept thinking about this. There is one subtle change that we might have made by moving to kanban-inspired Phabricator, simplifying Priority levels, get... [11:35:48] [13Number] 15thiemowmde closed pull request #8: Don't repeat user input in error message (06master...06quantity-exception) 02http://git.io/mL34ZA [11:36:34] [13Number] 15thiemowmde 04deleted 06quantity-exception at 145272a3f: 02http://git.io/KMt1Yg [11:40:07] 3MediaWiki-extensions-WikidataRepo: don't show fallback label when editing labels - https://phabricator.wikimedia.org/T76210#793105 (10Lydia_Pintscher) [11:42:55] 3MediaWiki-extensions-WikidataRepo: use icons for remove links in sitelink section - https://phabricator.wikimedia.org/T76212 (10Lydia_Pintscher) 3NEW p:3Normal [11:44:28] 3MediaWiki-extensions-WikidataClient: Lua: Create a mw.wikibase.renderSnak method for rendering arbitrary Snaks - https://phabricator.wikimedia.org/T76213#793129 (10hoo) [11:45:27] (03CR) 10Hoo man: [C: 032] Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [11:45:46] 3MediaWiki-extensions-WikidataRepo: improvements for the input box in sitelink section - https://phabricator.wikimedia.org/T76214#793136 (10Lydia_Pintscher) [11:46:06] 3Wikimedia-Wikidata, Community-Engagement: Phabricator projects for Wikimedia sister projects - https://phabricator.wikimedia.org/T802#793143 (10Qgil) [11:46:30] [13WikibaseDataModel] 15thiemowmde comment on pull request #312 147435f96: There was no documentation here? Should be `EntityId|int|null`. 02http://git.io/0nr_nA [11:47:38] (03CR) 10Hoo man: [C: 032] Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [11:48:26] (03CR) 10Hoo man: [C: 032] Language fallback for labels of referenced items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176008 (owner: 10Daniel Kinzler) [11:49:16] 3MediaWiki-extensions-WikidataRepo: find the right order for the elements in the sitelink section - https://phabricator.wikimedia.org/T76215 (10Lydia_Pintscher) 3NEW p:3Normal [11:50:27] (03PS6) 10Hoo man: Inject siteLinkGroups into ItemView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176237 (owner: 10Adrian Lang) [11:50:46] (03PS3) 10Hoo man: Rewrite completely broken EntityView tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176268 (owner: 10Adrian Lang) [11:52:04] (03PS5) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [11:52:15] (03CR) 10jenkins-bot: [V: 04-1] Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [11:52:19] (03PS10) 10Daniel Kinzler: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [11:52:30] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [11:55:12] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo: language fallback - https://phabricator.wikimedia.org/T76216 (10Lydia_Pintscher) 3NEW p:3Normal [11:59:27] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo: language fallback - https://phabricator.wikimedia.org/T76216#793163 (10Lydia_Pintscher) [12:02:19] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: language fallback for the property parser function - https://phabricator.wikimedia.org/T76217 (10Lydia_Pintscher) 3NEW p:3Normal [12:05:21] 3MediaWiki-extensions-WikidataClient: language fallback for Lua - https://phabricator.wikimedia.org/T76218 (10Lydia_Pintscher) 3NEW p:3Normal [12:05:47] 3MediaWiki-extensions-WikidataClient: language fallback for the property parser function - https://phabricator.wikimedia.org/T76217#793193 (10Lydia_Pintscher) [12:09:55] (03Merged) 10jenkins-bot: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [12:10:00] (03Merged) 10jenkins-bot: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [12:10:06] (03Merged) 10jenkins-bot: Language fallback for labels of referenced items. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176008 (owner: 10Daniel Kinzler) [12:10:35] (03CR) 10Hoo man: Show an error if ViewEntityAction is used with non-Entity content (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 (https://bugzilla.wikimedia.org/71546) (owner: 10Hoo man) [12:12:09] (03PS3) 10Hoo man: Show an error if ViewEntityAction is used with non-Entity content [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 [12:13:15] (03CR) 10Hoo man: "Addressed Adrian's and Daniel's comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 (owner: 10Hoo man) [12:13:17] (03PS6) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [12:14:16] (03PS4) 10Hoo man: Show an error if ViewEntityAction is used with non-Entity content [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 [12:21:32] (03PS1) 10Henning Snater: Updated code documentation [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176337 [12:24:38] (03CR) 10jenkins-bot: [V: 04-1] Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [12:27:43] (03PS2) 10Henning Snater: Updated code documentation [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176337 [13:13:33] [13ValueView] 15snaterlicious 04force-pushed 06documentation from 14be4e68e to 14cfe35f4: 02http://git.io/jDqopQ [13:13:33] 13ValueView/06documentation 14cfe35f4 15snaterlicious: Updated code documentation [13:30:46] [13ValueView] 15snaterlicious created 06mintermlength (+1 new commit): 02http://git.io/y0fKxw [13:30:46] 13ValueView/06mintermlength 14a34ced4 15snaterlicious: $.ui.suggester: Moved protected _minTermLength member to options [13:35:53] 3MediaWiki-extensions-WikidataRepo: don't show fallback label when editing labels - https://phabricator.wikimedia.org/T76210#793336 (10daniel) Technically, wbEntity should only contain labels and other terms that were explicitly defined; no language fallback should apply when generating wbEntity. [13:35:54] (03PS1) 10Hoo man: Revert "Rearranged site link views" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176352 [13:36:41] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] Priming the entity_usage table based on page-props. (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172517 (https://bugzilla.wikimedia.org/73220) (owner: 10Daniel Kinzler) [13:36:49] Henning_WMDE: https://gerrit.wikimedia.org/r/176352 [13:45:00] (03Abandoned) 10Hoo man: Revert "Rearranged site link views" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176352 (owner: 10Hoo man) [13:45:16] (03CR) 10Daniel Kinzler: Priming the entity_usage table based on page-props. (0311 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172517 (https://bugzilla.wikimedia.org/73220) (owner: 10Daniel Kinzler) [13:45:20] Thiemo_WMDE1: --^ [13:50:01] 3MediaWiki-extensions-WikidataRepo: Put SiteLink section into separate column - https://phabricator.wikimedia.org/T70910#793350 (10Lydia_Pintscher) 5Open>3Resolved a:3Lydia_Pintscher [13:50:02] 3MediaWiki-extensions-WikidataRepo: Implement new SiteLink UI - https://phabricator.wikimedia.org/T70903#793352 (10Lydia_Pintscher) [13:51:02] 3MediaWiki-extensions-WikidataRepo: Redesign Item UI for Wikidata repo - https://phabricator.wikimedia.org/T54136#793356 (10Lydia_Pintscher) [13:51:03] 3MediaWiki-extensions-WikidataRepo: Make headings in toc shorter - https://phabricator.wikimedia.org/T65692#793353 (10Lydia_Pintscher) [13:53:12] 3MediaWiki-extensions-WikidataRepo: Re-enable quick editing in Wikidata - https://phabricator.wikimedia.org/T73845#793357 (10Lydia_Pintscher) [13:56:32] (03PS7) 10Thiemo Mättig (WMDE): Priming the entity_usage table based on page-props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172517 (https://bugzilla.wikimedia.org/73220) (owner: 10Daniel Kinzler) [13:56:34] (03PS1) 10Thiemo Mättig (WMDE): [WIP] Clean up UsageTablePrimer and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176356 [13:59:44] (03CR) 10Thiemo Mättig (WMDE): "My upload here was an accidental rebase when uploading my follow up. Sorry. Nothing changed." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172517 (https://bugzilla.wikimedia.org/73220) (owner: 10Daniel Kinzler) [14:06:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Clean up UsageTablePrimer and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176356 (owner: 10Thiemo Mättig (WMDE)) [14:07:23] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I'm ok with the code, but please try to make the error message more user friendly. See my suggestion." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 (owner: 10Hoo man) [14:10:30] [13ValueView] 15snaterlicious 04force-pushed 06documentation from 14cfe35f4 to 1440bd041: 02http://git.io/jDqopQ [14:10:30] 13ValueView/06documentation 1440bd041 15snaterlicious: Updated code documentation [14:13:10] [13ValueView] 15snaterlicious 04force-pushed 06mintermlength from 14a34ced4 to 14a948118: 02http://git.io/erCoDQ [14:13:10] 13ValueView/06mintermlength 14a948118 15snaterlicious: $.ui.suggester: Moved protected _minTermLength member to options [14:14:26] [13ValueView] 15snaterlicious 04force-pushed 06mintermlength from 14a948118 to 14eb16c62: 02http://git.io/erCoDQ [14:14:26] 13ValueView/06mintermlength 14eb16c62 15snaterlicious: $.ui.suggester: Moved protected _minTermLength member to options [14:17:02] Hi everybody [14:17:29] I want to add 3d models for buildings in OpenStreetMap [14:17:49] [13ValueView] 15snaterlicious opened pull request #134: $.ui.suggester: Moved protected _minTermLength member to options (06master...06mintermlength) 02http://git.io/tG1dFA [14:18:02] Does such data, as 3d models fits wikidata? [14:19:45] (03PS1) 10Hoo man: Initialize claims on entities whenever a claimlistview exists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176360 [14:19:57] Lydia_WMDE: https://gerrit.wikimedia.org/r/176360 [14:19:59] Henning_WMDE: ^ [14:20:06] meeeeeeerrrrrrrgeee [14:23:05] wmde/ValueView/mintermlength/a948118 : snaterlicious The build has errored. http://travis-ci.org/wmde/ValueView/builds/42396621 [14:23:41] (03CR) 10Henning Snater: "This would apply the assumption that the entityview is always initialized on static HTML." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176360 (owner: 10Hoo man) [14:32:10] (03CR) 10Henning Snater: [C: 032] Initialize claims on entities whenever a claimlistview exists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176360 (owner: 10Hoo man) [14:32:21] (03PS4) 10Daniel Kinzler: Extract FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 [14:37:26] (03PS5) 10Hoo man: Show an error if ViewEntityAction is used with non-Entity content [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 [14:37:56] (03CR) 10Hoo man: "Improved the error messages according to Thiemo's suggestions." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 (owner: 10Hoo man) [14:38:37] (03PS7) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [14:38:47] (03CR) 10jenkins-bot: [V: 04-1] Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 (owner: 10Daniel Kinzler) [14:38:52] oh ffs+ [14:38:56] (03PS10) 10Thiemo Mättig (WMDE): Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [14:39:15] i just rebased half an hour ago... [14:39:30] (03PS5) 10Daniel Kinzler: Extract FormatterLabelLookupFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174198 [14:40:05] (03PS3) 10Henning Snater: Updated code documentation [extensions/WikibaseJavaScriptApi] - 10https://gerrit.wikimedia.org/r/176337 [14:40:08] (03PS3) 10Thiemo Mättig (WMDE): Rework and clean up MockRepository and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175968 [14:43:31] 3MediaWiki-extensions-WikidataClient: create demo infoboxes - https://phabricator.wikimedia.org/T76229 (10Lydia_Pintscher) 3NEW p:3Normal [14:44:39] 3MediaWiki-extensions-WikidataClient: data quality and trust - https://phabricator.wikimedia.org/T76230 (10Lydia_Pintscher) 3NEW p:3Normal [14:45:03] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo: data quality and trust - https://phabricator.wikimedia.org/T76230#793393 (10Lydia_Pintscher) [14:45:20] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo: data quality and trust - https://phabricator.wikimedia.org/T76230#793393 (10Lydia_Pintscher) [14:46:36] (03Merged) 10jenkins-bot: Initialize claims on entities whenever a claimlistview exists [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176360 (owner: 10Hoo man) [14:46:39] (03PS5) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [14:49:20] (03PS8) 10Daniel Kinzler: Use an EntityIdFormatter for statement's properties. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176246 [14:49:34] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo: data quality and trust - https://phabricator.wikimedia.org/T76230#793403 (10Lydia_Pintscher) [14:49:50] (03PS11) 10Daniel Kinzler: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [14:50:47] 3MediaWiki-extensions-WikidataRepo: nudge editors to add a reference when adding a new claim - https://phabricator.wikimedia.org/T76231 (10Lydia_Pintscher) 3NEW p:3Normal [14:52:11] 3MediaWiki-extensions-WikidataRepo: nudge when editing a statement to check reference - https://phabricator.wikimedia.org/T76232 (10Lydia_Pintscher) 3NEW p:3Normal [14:52:42] (03PS5) 10Thiemo Mättig (WMDE): Narrow EntityParserOutputGeneratorFactory interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 [14:56:36] 3MediaWiki-extensions-WikidataRepo: make it possible to easily clone an existing reference from the same item - https://phabricator.wikimedia.org/T76233 (10Lydia_Pintscher) 3NEW p:3Normal [14:56:37] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [14:58:25] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo: data quality and trust - https://phabricator.wikimedia.org/T76230#793427 (10Lydia_Pintscher) [14:59:35] (03PS8) 10Daniel Kinzler: Priming the entity_usage table based on page-props. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172517 (https://bugzilla.wikimedia.org/73220) [14:59:58] (03PS5) 10Thiemo Mättig (WMDE): Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [15:00:51] 3MediaWiki-extensions-WikidataRepo: nudge when editing a statement to check reference - https://phabricator.wikimedia.org/T76232#793433 (10Lydia_Pintscher) [15:01:22] 3MediaWiki-extensions-WikidataRepo: nudge editors to add a reference when adding a new claim - https://phabricator.wikimedia.org/T76231#793435 (10Lydia_Pintscher) [15:02:32] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up MockRepository and related [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175968 (owner: 10Thiemo Mättig (WMDE)) [15:02:42] (03CR) 10jenkins-bot: [V: 04-1] Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [15:03:05] 3MediaWiki-extensions-WikidataRepo: Redesign Item UI for Wikidata repo - https://phabricator.wikimedia.org/T54136#793436 (10Lydia_Pintscher) [15:10:50] [13WikibaseDataModel] 15thiemowmde created 06toArray (+1 new commit): 02http://git.io/fyc74w [15:10:50] 13WikibaseDataModel/06toArray 1456db5bd 15Thiemo Mättig: Clarify contracts of toArray methods [15:14:27] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [15:14:37] [13WikibaseDataModel] 15thiemowmde opened pull request #322: Clarify contracts of toArray methods (06master...06toArray) 02http://git.io/H7M-Cg [15:16:26] [13WikibaseDataModel] 15thiemowmde 04deleted 06entityidr at 143ed4226: 02http://git.io/-KFvqQ [15:22:33] (03PS1) 10Daniel Kinzler: Add test for EntityIdHtmlLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176361 [15:23:54] (03PS2) 10Daniel Kinzler: Add test for EntityIdHtmlLinkFormatter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176361 [15:26:24] (03PS12) 10Daniel Kinzler: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [15:29:18] [13ValueView] 15snaterlicious pushed 1 new commit to 06mintermlength: 02http://git.io/K2Qkzg [15:29:18] 13ValueView/06mintermlength 14a33ef63 15snaterlicious: $.ui.suggester: Checking for menu when trying to update suggestions [15:29:42] (03PS4) 10Daniel Kinzler: Make NoLangLinkHandler testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159762 [15:30:40] [13ValueView] 15snaterlicious 04force-pushed 06documentation from 1440bd041 to 14437a7ea: 02http://git.io/jDqopQ [15:30:40] 13ValueView/06documentation 14437a7ea 15snaterlicious: Updated code documentation [15:31:45] [13ValueView] 15snaterlicious 04force-pushed 06mintermlength from 14a33ef63 to 14dc66ca1: 02http://git.io/erCoDQ [15:31:45] 13ValueView/06mintermlength 14b4c4102 15snaterlicious: $.ui.suggester: Moved protected _minTermLength member to options [15:31:45] 13ValueView/06mintermlength 14dc66ca1 15snaterlicious: $.ui.suggester: Checking for menu when trying to update suggestions [15:32:11] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Not sure how I should vote here. My concerns are about the readability of the code. What it does looks fine." (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [15:32:47] [13ValueView] 15snaterlicious 04force-pushed 06documentation from 14437a7ea to 1442b1f0e: 02http://git.io/jDqopQ [15:32:47] 13ValueView/06documentation 1442b1f0e 15snaterlicious: Updated code documentation [15:33:22] [13ValueView] 15snaterlicious 04force-pushed 06mintermlength from 14dc66ca1 to 14f0834bc: 02http://git.io/erCoDQ [15:33:22] 13ValueView/06mintermlength 14fa1bb3f 15snaterlicious: $.ui.suggester: Moved protected _minTermLength member to options [15:33:22] 13ValueView/06mintermlength 14f0834bc 15snaterlicious: $.ui.suggester: Checking for menu when trying to update suggestions [15:42:15] JeroenDeDauw: around for cinema planning? [15:43:22] (03PS5) 10Daniel Kinzler: Make NoLangLinkHandler testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159762 [15:45:44] Lydia_WMDE: You should have an annual cinema planning meeting [15:45:48] wmde/WikibaseDataModel/toArray/56db5bd : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42401412 [15:46:05] hoo: annual???? weekly! :P [15:46:40] It just sounded to similar to the other annual planning stuffs we had this week [15:46:53] :P [15:47:55] $title = Title::newFromText( $entityId->getSerialization() ); [15:47:56] wow [15:47:57] wtf [15:49:00] (03CR) 10Daniel Kinzler: [C: 032] Show an error if ViewEntityAction is used with non-Entity content [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 (owner: 10Hoo man) [15:49:59] no, just no [15:50:01] argghghg [15:50:46] Factories which only sometimes really produce objects that work are... a little less awesome [15:50:47] -.- [15:56:16] (03Merged) 10jenkins-bot: Show an error if ViewEntityAction is used with non-Entity content [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170506 (owner: 10Hoo man) [15:57:03] hoo: that code path is hit when thre is no EntityTitleLookup, which would be the case on the client... [15:57:17] hoo: we are not currently using EntityIdHtmlLinkFormatter on the client though [15:57:17] [13ValueView] 15snaterlicious pushed 1 new commit to 06mintermlength: 02http://git.io/tRs5xQ [15:57:17] 13ValueView/06mintermlength 148942850 15snaterlicious: Removed obsolete code [15:57:29] it'S a bit silly - it's unclear what the semantics of this should be one the client side [15:57:48] Yeah... I'm trying to find a way to make that sane right now [15:57:48] but can't really think of anything [15:58:06] we should probably just never instantiate that formatter if we don't have a title lookup. the respective factory function could just fail. [15:59:09] hoo: make the constructor parameter required in the formatter. in the xxxxBuilders class, throw an exception if we try to instantiate that formatter when the title lookup is null [15:59:13] that should be sane [16:01:13] Yeah, that sounds sane [16:01:13] if we want it to work, we should probably abstract the title logic away and then plug RepoLinker into it on client instead [16:01:16] Yeah, that should be good for now. But I'm not 100% happy [16:01:30] DanielK_WMDE__: OutOfRangeException ? [16:04:19] hoo: RuntimeException. It's not a value being out of range. [16:05:56] Yeah, true... but it's not a runtime error, rather a compile time one [16:06:23] then throw Exception or MWException... i really don't care much :) [16:06:42] actually, you could also just return an HTML-Escaped version of EntityIdLabelFormatter [16:06:51] that's even nicer [16:07:02] Exception sounds good to me [16:07:16] :P [16:07:20] but but but ;) [16:08:00] new EscapingValueFormatter( new EntityIdLabelFormatter( $options, $labelLookup ), 'htmlspecialchars' ); [16:08:03] hoo: ---^ [16:08:05] simple enough [16:08:19] yay :) [16:08:19] and semantically correct [16:08:48] you'll get plain text, no link. because there is no lookup to determin the link target [16:09:12] I don't have a label formatter, argh :P [16:09:33] (03PS11) 10Daniel Kinzler: Extract onLinkBegin hook handling into separate class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 (owner: 10Aude) [16:09:47] hoo: hm? just create it. [16:09:53] see the code snippet [16:10:08] hoo: or call newEntityIdFormatter [16:10:22] can interfaces extend? [16:10:28] sure [16:10:42] one interface can extend any number of other interfaces [16:11:18] ...as long as there are no conflicting method signatures, i guess [16:12:11] (03CR) 10Daniel Kinzler: [V: 032] "addressed adrian's concerns, and verified manually that the LinkBegin hook handling still works." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 (owner: 10Aude) [16:15:07] (03PS1) 10Henning Snater: Refactored $.wikibase.entityselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176367 [16:15:55] (03CR) 10Daniel Kinzler: "Passing in a callback is a viable alternative to using the FormatterOptions as a vehicle for making the LabelLookup available to any forma" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [16:18:59] (03PS2) 10Henning Snater: Refactored $.wikibase.entityselector [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176367 [16:20:59] wmde/ValueView/mintermlength/a33ef63 : snaterlicious The build has errored. http://travis-ci.org/wmde/ValueView/builds/42403122 [16:25:59] Lydia_WMDE: https://phabricator.wikimedia.org/T73050 <-- should go into this sprint [16:30:15] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo: language fallback - https://phabricator.wikimedia.org/T76216#793485 (10Lydia_Pintscher) [16:39:23] (03PS1) 10Hoo man: Sanitize wikibase-item html formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176369 [16:39:47] wmde/ValueView/documentation/437a7ea : snaterlicious The build has errored. http://travis-ci.org/wmde/ValueView/builds/42403212 [16:40:54] wmde/ValueView/mintermlength/dc66ca1 : snaterlicious The build has errored. http://travis-ci.org/wmde/ValueView/builds/42403311 [16:48:15] (03PS1) 10Daniel Kinzler: No language fallback when serializing wbEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176370 [17:06:24] hi [17:06:34] does anyone ever heard of user called " w930913"? [17:06:56] (03PS1) 10Daniel Kinzler: Maintenance script for populating wbc_entity_usage [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176373 [17:07:01] a930913: do you happen to be him? :P [17:41:16] (03CR) 10Aklapper: "Please fix the incorrect bug number reference in the commit message." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176370 (owner: 10Daniel Kinzler) [17:44:37] (03PS1) 10Hoo man: Add EntityIdHtmlLinkFormatterTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176375 [17:47:07] (03PS2) 10Hoo man: No language fallback when serializing wbEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176370 (owner: 10Daniel Kinzler) [17:55:39] 3MediaWiki-extensions-WikidataRepo: useful empty state of item and property - https://phabricator.wikimedia.org/T76243#793551 (10Lydia_Pintscher) [17:57:18] (03CR) 10Hoo man: [C: 032] "Manually verified" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176370 (owner: 10Daniel Kinzler) [18:00:16] (03Merged) 10jenkins-bot: No language fallback when serializing wbEntity. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176370 (owner: 10Daniel Kinzler) [18:13:28] 3MediaWiki-extensions-WikidataRepo: don't show fallback label when editing labels - https://phabricator.wikimedia.org/T76210#793569 (10hoo) [18:13:30] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo: language fallback - https://phabricator.wikimedia.org/T76216#793571 (10hoo) [18:14:33] (03PS4) 10Hoo man: Remove broken detection of multiple empty listitems in sitelinklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172510 (owner: 10Adrian Lang) [18:19:54] 3MediaWiki-extensions-WikidataRepo: Don't allow removing the sitelink-input for adding a new sitelink - https://phabricator.wikimedia.org/T76244 (10hoo) 3NEW p:3Normal [18:35:59] (03CR) 10Daniel Kinzler: Determine update actions based on usage aspects. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [18:39:47] (03CR) 10Hoo man: [C: 031] "Patch looks good and doesn't seem to have any negative side effects. But also I wasn't able to find any change in behaviour." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172510 (owner: 10Adrian Lang) [18:58:26] Is it possible to write a tool with one time imports like giving professional basketball teams a venue? [18:59:17] zlce: sure it's possible [18:59:48] DanielK_WMDE__: is there any documentation or tooling than I can use to extract data from wikipedia info boxes and then add to wikidata? [19:03:17] (03PS10) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) [19:03:41] 3MediaWiki-extensions-WikidataRepo: Implement new SiteLink UI - https://phabricator.wikimedia.org/T70903#793648 (10Lydia_Pintscher) [19:03:48] zlce: the most popular tool for pushing things into wikidata is the pywikibot framework. but i'm not an expert on any of that. [19:04:03] the tools and frameworks are rather new and in flux, and often written for single purpose projects [19:04:24] zlce: i recommend to have a look at https://www.wikidata.org/wiki/Wikidata:Bots [19:04:41] great, thanks a lot DanielK_WMDE__ [19:04:43] check out which bots are active, and ask their owners [19:04:58] ideally, find a bot that does somethign similar to what you want to do [19:11:50] DanielK_WMDE__: Regarding your mail to wikitech... do you still think it's useful to persuade batch loading in various places? [19:12:26] Because if we come up with something which acts per item anyway, this might not have any advantage to us [19:13:06] btw, 100 million small-ish strings shouldn't really be a problem for a memcached instance... that's what they're made for [19:17:20] hoo: but 100 round trips would suck [19:17:39] 30 referenced items, 4 languages for fallback... [19:17:48] per item doesn't help :( [19:18:02] batched db queries may actually be our best hope [19:18:31] (and then inject the prefetched data into the default/global instance) [19:25:43] DanielK_WMDE__: Yikes... we only use the index on the numeric entity id, AFAIS [19:25:43] also we load all terms and the filter in PHP [19:25:43] :S [19:26:32] Selectivity could be ok, but it's not totally ideal (especially term_language) [19:27:19] DanielK_WMDE__: ^ [19:27:38] We might want to check that more (maybe also with Sean) [19:28:54] yes. my mail was intended as a starting point for that conversation [19:29:46] hoo: hm, memcached implements getMulti. That would help a lot with the round trips. [19:31:36] Doubt we can use that given how the WMF splits caching across various instances [19:32:01] it's not transparent to MW which memcached it is even talking to (it contacts a local proxy basically) [19:32:39] But it's something that at least should be checked [19:36:03] hoo: Deprecated: Use of SpecialRecentChangesFilters hook (used in \Wikibase\ClientHooks::onSpecialRecentChangesFilters) was deprecated in MediaWiki 1.23. [19:36:24] on RecentCHanges and Watchlist. Is this new? [19:36:54] Never saw it myself, but also I don't look such things (so would only see it in tests) [19:37:07] btw, it looks like tewmproxy actually supports get multi [19:37:35] so if it's also implemented in memcached pecl which is being used we should be good to use that :) [19:37:36] \o/ [19:38:28] yep, MemcachedPeclBagOStuff does implement it [19:40:20] DanielK_WMDE__: Hmm, I see you added me as cc to some of your patchsets.... [19:40:43] It got completely burried in the bugzilla -> phabricator switch emails [19:40:45] I'm going to switch trains in a bit, but probably wont come back online after [19:40:51] cu [19:43:44] multichill: i did? recently? i don't recall doing that intentionally... [19:43:50] which ticket, for instance? [19:44:20] https://gerrit.wikimedia.org/r/#/c/170961/ [19:45:18] DanielK_WMDE__: ^ [19:45:27] yea... i wonder why i did that :) [19:45:31] or if it was actually me [19:45:38] Maybe Lydia [19:45:46] Not sure how to see who added who [19:45:46] yea, don't know [19:45:50] right [19:45:54] i don't think you can [19:46:59] multichill: did we discuss optimized purging of clinet pages at the hackathon? i vaguely recall something like that. [19:47:10] that'S what this patch does, essentially. [19:47:27] We discussed purging and vandalism [19:47:42] though the one it depends on is more relevant to that: https://gerrit.wikimedia.org/r/#/c/167856/10 [19:47:43] And the templates on steriods thing so you need to see it in your watchlist [19:47:44] yea [19:48:02] Guess what, I'm in that one too ;-) [19:48:05] this is the code that makes sure that if you use the english label of Q123, your page gets purged when that label changes. and only then. [19:48:19] Oh, that's much better [19:48:20] i guess this is why i added you [19:49:58] multichill: i tried to strike a balance between granularity and simplicity. there are several "aspects" that a client page may use: the sitelinks (in the sidebar), an entity's label (in the local content language), an entity's local title (page on this wiki), or "anything else". [19:50:12] so we have optimized caching for the most common cases. [19:50:21] s/caching/purging/ [19:50:33] If you have clear code you can always tweak and improve it over time [19:55:38] 3MediaWiki-extensions-WikidataRepo: Investigate how prefetching labels would work for watchlist and recent changes - https://phabricator.wikimedia.org/T74309#793697 (10daniel) [19:59:38] (03CR) 10Daniel Kinzler: "Oh no, I also wrote one: I8f8239bfaa558e5" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176375 (owner: 10Hoo man) [19:59:55] (03CR) 10Daniel Kinzler: "Hoo's version: Ie760640593" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176361 (owner: 10Daniel Kinzler) [20:01:05] (03CR) 10Daniel Kinzler: [C: 032] Sanitize wikibase-item html formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176369 (owner: 10Hoo man) [20:01:54] multichill: ChangeHandler is not what I'd call "clear code", but this batch of patches does improve it. [20:04:12] (03Merged) 10jenkins-bot: Sanitize wikibase-item html formatting [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176369 (owner: 10Hoo man) [20:10:19] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06depsetid: 02http://git.io/DCh95A [20:10:19] 13WikibaseDataModel/06depsetid 14821446e 15Jeroen De Dauw: Update Entity.php [20:24:03] (03PS10) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [20:24:03] (03PS2) 10Jeroen De Dauw: Stop using deprecated methods in importInterlang [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/176317 [20:24:11] (03PS4) 10Jeroen De Dauw: Do not type hint against Entity in EntityContentFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175738 [20:29:34] 3MediaWiki-extensions-WikidataRepo: create filter by language that can be applied to objects before passing to serialization - https://phabricator.wikimedia.org/T73512#793763 (10JanZerebecki) [20:30:38] 3MediaWiki-extensions-WikidataRepo: create filter by language that can be applied to objects before passing to serialization - https://phabricator.wikimedia.org/T73512#764359 (10JanZerebecki) [20:40:45] 3MediaWiki-extensions-WikidataRepo: find or create Transliterator - https://phabricator.wikimedia.org/T76251 (10JanZerebecki) 3NEW p:3Normal [20:48:32] 3MediaWiki-extensions-WikidataRepo: create filter by language that can be applied to objects before passing to serialization - https://phabricator.wikimedia.org/T73512#793783 (10JanZerebecki) Do we try to transliterate for each fall back language in the chains if that language is not present? Do we for the poss... [20:56:24] 3MediaWiki-extensions-WikidataRepo: create AcceptLanguageSet that is usable in DataModel - https://phabricator.wikimedia.org/T76252 (10JanZerebecki) 3NEW p:3Normal [21:50:45] (03CR) 10Aude: "are we ever going to need to rebuild the usage tracking table? (like we do with entity per page, etc.)?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172517 (https://bugzilla.wikimedia.org/73220) (owner: 10Daniel Kinzler) [22:33:36] (03CR) 10JanZerebecki: [C: 032] Make NoLangLinkHandler testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159762 (owner: 10Daniel Kinzler) [22:37:00] (03Merged) 10jenkins-bot: Make NoLangLinkHandler testable. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/159762 (owner: 10Daniel Kinzler)