[02:23:36] gi11es: What does Wiktionary/Wikidata have to do with Multimedia? [05:01:05] GPHemsley: the structured data stuff? [05:05:02] good daytime [06:29:12] Yay, using WDQ and the API means inconsistancies before WDQ is recached D: [08:59:24] GPHemsley: for wikidata, the structured data on commons project [08:59:56] wiktionary I don't know, other than extensions the multimedia team is responsible for that might be installed on it [09:04:00] [13WikibaseDataModel] 15thiemowmde created 06newMethods (+1 new commit): 02http://git.io/7gsRXw [09:04:00] 13WikibaseDataModel/06newMethods 14903b165 15Thiemo Mättig: Add GUID to constructors [09:06:43] wmde/WikibaseDataModel/newMethods/903b165 : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42055178 [09:06:45] [13WikibaseDataModel] 15thiemowmde opened pull request #306: Add GUID to constructors (06master...06newMethods) 02http://git.io/D6fTKg [09:11:56] (03CR) 10Adrian Lang: "Just to be sure, you propose the passed Closure to be of type LabelLookup -> $outputFormat -> FormatterOptions -> SnakFormatter?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [09:18:08] (03CR) 10Adrian Lang: "The current code tries to check if there are multiple empty sitelinkviews (see old line 310). That check was obviously broken. I can also " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172510 (owner: 10Adrian Lang) [09:19:04] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newMethods from 14903b165 to 14b8306f1: 02http://git.io/6FMa1g [09:19:04] 13WikibaseDataModel/06newMethods 14b8306f1 15Thiemo Mättig: Add GUID to constructors [09:21:18] wmde/WikibaseDataModel/newMethods/b8306f1 : Thiemo Mättig The build was fixed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42056335 [09:27:48] (03CR) 10Adrian Lang: [C: 032] Add test coverage for property id formatting in ClaimsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174710 (owner: 10Aude) [09:27:58] [13WikibaseDataModel] 15thiemowmde created 06claimTest (+1 new commit): 02http://git.io/8EpDzw [09:27:58] 13WikibaseDataModel/06claimTest 14f46a148 15Thiemo Mättig: Clean up Claim/Statement Test [09:28:45] [13WikibaseDataModel] 15thiemowmde opened pull request #307: Clean up Claim/Statement Test (06master...06claimTest) 02http://git.io/ZTs1kw [09:30:06] wmde/WikibaseDataModel/claimTest/f46a148 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42056892 [09:31:06] (03CR) 10Daniel Kinzler: Introduce PageTerms API module (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [09:31:58] DanielK_WMDE: https://gerrit.wikimedia.org/r/#/q/has:draft,n,z [09:37:10] (03Merged) 10jenkins-bot: Add test coverage for property id formatting in ClaimsView [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174710 (owner: 10Aude) [09:38:03] Adrian_WMDE: api.php?action=query&generator=search&gsrsearch=Kohlenstoff&prop=pageprops|pageterms&ppprop=wikibase_item&ptterms=label|description&uselang=en [09:41:40] [13Geo] 15thiemowmde created 06globeTest (+1 new commit): 02http://git.io/Nv7z_Q [09:41:40] 13Geo/06globeTest 141e2403e 15Thiemo Mättig: Add missing GlobeCoordinateFormatterTest [09:43:02] [13Geo] 15thiemowmde opened pull request #36: Add missing GlobeCoordinateFormatterTest (06master...06globeTest) 02http://git.io/IGGv-w [09:43:33] (03CR) 10Adrian Lang: [V: 04-1] Introduce PageTerms API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [09:45:28] [13Interfaces] 15thiemowmde created 06options (+1 new commit): 02http://git.io/-yv5Iw [09:45:28] 13Interfaces/06options 140d37402 15Thiemo Mättig: Optional options constructor parameter [09:45:53] (03CR) 10Adrian Lang: Introduce PageTerms API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [09:45:55] [13Interfaces] 15thiemowmde opened pull request #7: Optional options constructor parameter (06master...06options) 02http://git.io/VWK3_A [09:53:24] (03CR) 10Adrian Lang: Introduce PageTerms API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [09:54:14] (03PS6) 10Thiemo Mättig (WMDE): Unify top factory getter implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 [09:58:48] (03CR) 10Thiemo Mättig (WMDE): "Rebased mainly to retrigger the tests. Looks like Jenkins is broken again." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 (owner: 10Thiemo Mättig (WMDE)) [10:00:42] 3MediaWiki-extensions-WikidataClient: Usage Tracking: changes should trigger an appropriate update of pages that use the corresponding aspect of the change item - https://phabricator.wikimedia.org/T73352#783798 (10daniel) [10:01:25] (03CR) 10Hoo man: Introduce PageTerms API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [10:07:44] [13DataValuesJavascript] 15snaterlicious pushed 3 new commits to 06documentation: 02http://git.io/1-heeQ [10:07:44] 13DataValuesJavascript/06documentation 14684ada0 15snaterlicious: Fixed mw.ext.dataValue initialization [10:07:44] 13DataValuesJavascript/06documentation 14a6c1f10 15snaterlicious: Updated globeCoordinate code documentation [10:07:45] 13DataValuesJavascript/06documentation 1422e98c4 15snaterlicious: Consolidated time singleton [10:08:55] wmde/DataValuesJavascript/documentation/22e98c4 : snaterlicious The build was broken. http://travis-ci.org/wmde/DataValuesJavascript/builds/42060052 [10:11:13] [13DataValuesJavascript] 15snaterlicious 04force-pushed 06documentation from 1422e98c4 to 14d9d973b: 02http://git.io/bHQ75A [10:11:13] 13DataValuesJavascript/06documentation 14d9d973b 15snaterlicious: Consolidated time singleton [10:16:49] [13DataValuesJavascript] 15snaterlicious pushed 1 new commit to 06documentation: 02http://git.io/yHhZ8Q [10:16:49] 13DataValuesJavascript/06documentation 149c49128 15snaterlicious: Updated version/release notes [10:17:46] [13DataValuesJavascript] 15snaterlicious opened pull request #56: Consolidated code and documentation (06master...06documentation) 02http://git.io/5LkHow [10:28:41] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06emptyFingerprint from 14a230769 to 142c33b14: 02http://git.io/uH6jlQ [10:28:41] 13WikibaseDataModel/06emptyFingerprint 142c33b14 15Thiemo Mättig: Allow constructing empty Fingerprint [10:39:02] Lydia_WMDE: https://etherpad.wikimedia.org/p/bugscratchpad [10:42:56] 3MediaWiki-extensions-WikidataRepo: Can't use tab while adding sitelinks - https://phabricator.wikimedia.org/T75642#783904 (10Tobi_WMDE_SW) Needs a release of ValueView. [10:45:02] 3MediaWiki-extensions-WikidataClient: allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#783906 (10Liuxinyu970226) [10:55:59] [13WikibaseDataModel] 15thiemowmde 04force-pushed 06newEmpty from 147ea2285 to 14ca3ed00: 02http://git.io/OcS3vw [10:55:59] 13WikibaseDataModel/06newEmpty 14ca3ed00 15Thiemo Mättig: Deprecate Item::newEmpty [10:56:54] [13WikibaseDataModelJavaScript] 15snaterlicious pushed 1 new commit to 06documentation: 02http://git.io/_tcxaA [10:56:54] 13WikibaseDataModelJavaScript/06documentation 141ccd2dc 15snaterlicious: Added default param values [10:59:36] [13WikibaseDataModelJavaScript] 15snaterlicious 04force-pushed 06documentation from 141ccd2dc to 14d8a3026: 02http://git.io/l1xnqA [10:59:36] 13WikibaseDataModelJavaScript/06documentation 14d8a3026 15snaterlicious: Added default param values [11:00:22] [13WikibaseDataModel] 15thiemowmde created 06isOptional (+1 new commit): 02http://git.io/_LAl5w [11:00:22] 13WikibaseDataModel/06isOptional 141536982 15Thiemo Mättig: Simplify null checks with PHP 5.3 syntax [11:00:33] [13WikibaseDataModel] 15thiemowmde opened pull request #308: Simplify null checks with PHP 5.3 syntax (06master...06isOptional) 02http://git.io/t2j8RA [11:03:40] wmde/WikibaseDataModel/isOptional/1536982 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42064155 [11:05:01] [13WikibaseDataModel] 15thiemowmde created 06slOptional (+1 new commit): 02http://git.io/QL5wDw [11:05:01] 13WikibaseDataModel/06slOptional 14ba354a0 15Thiemo Mättig: Property constructor parameter is optional [11:05:11] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/wQWmYQ [11:05:11] 13WikibaseDataModel/06master 1426a227f 15Marius Hoch: Merge pull request #308 from wmde/isOptional... [11:07:10] wmde/WikibaseDataModel/slOptional/ba354a0 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/42064435 [11:08:39] [13DataValuesJavascript] 15snaterlicious pushed 1 new commit to 06documentation: 02http://git.io/g-xRBA [11:08:39] 13DataValuesJavascript/06documentation 14d5f3ce4 15snaterlicious: Added default values [11:30:07] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "+2 for the bugfix, -1 for the unrelated change. See comment." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172510 (owner: 10Adrian Lang) [11:33:55] [13DataValuesJavascript] 15snaterlicious pushed 1 new commit to 06documentation: 02http://git.io/ZE4q7Q [11:33:55] 13DataValuesJavascript/06documentation 1483c258e 15snaterlicious: Updated util.inherit in regard to documentation [11:56:47] 3MediaWiki-extensions-WikidataRepo: cannot save badges on Q183 (Germany) - https://phabricator.wikimedia.org/T72716#783975 (10JanZerebecki) [11:56:51] 3Wikimedia-Wikidata: Wikimedia Error page on the item for Germany (Q183) - https://phabricator.wikimedia.org/T73519#783976 (10JanZerebecki) [12:03:21] [13DataValuesJavascript] 15snaterlicious 04force-pushed 06documentation from 1483c258e to 141bc5695: 02http://git.io/bHQ75A [12:03:21] 13DataValuesJavascript/06documentation 141bc5695 15snaterlicious: Updated util.inherit in regard to documentation [12:04:47] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14d8a3026: http://usejsdoc.org/tags-namespace.html 02http://git.io/AEFaww [12:08:15] [13WikibaseDataModelJavaScript] 15thiemowmde comment on commit 14c5e9c9b: `{string|wikibase.datamodel.MultiTerm|wikibase.datamodel.MultiTermMap}` 02http://git.io/WCYvUQ [12:11:44] [13WikibaseDataModelJavaScript] 15thiemowmde comment on commit 14d8a3026: This is not wrong but not necessary in my opinion, the square brackets mean "defaults to null", right? 02http://git.io/_vUQlw [12:13:34] (03PS4) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [12:13:36] (03PS1) 10Adrian Lang: Use the same EntityInfo for JS and PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 [12:14:10] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: split wikibase.git - https://phabricator.wikimedia.org/T75863 (10Lydia_Pintscher) 3NEW p:3High a:3Wikidata-bugs [12:15:13] DanielK_WMDE: jzerebecki: ^ [12:15:23] wikibugs: <3 :D [12:17:04] (03CR) 10Adrian Lang: "Addressed Daniel's comment. Also added I8d315d039cd1145b430cc3bc108f5b9b6e1c5533, because without that, this patch won't work." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [12:19:11] [13DataTypes] 15thiemowmde comment on pull request #26 14a4252ff: Usually without a dash, but doesn't really matter, I think. 02http://git.io/g9UI3A [12:21:12] [13DataTypes] 15thiemowmde comment on pull request #26 14a4252ff: Now there are 3 modules exporting `'dataTypes'`. Are you sure this is still correct? 02http://git.io/SG3TdQ [12:24:02] hoo! [12:24:03] :D [12:27:14] how do i transclude wikidata coordinates on enwiki? the documentation suggests this should work {{coord|display=title}} but i get this error "Invalid arguments have been passed to the {{#coordinates:}} function" [12:27:46] [13WikibaseSerializationJavaScript] 15thiemowmde comment on pull request #10 1463a0d6a: Usually without dash, but shouldn't matter. 02http://git.io/1S-0Yw [12:29:58] gi11es: I ask because you tagged the Wiktionary-related bugs as belonging to the Multimedia project. [12:33:57] gi11es: Oh, maybe it was because I had tagged them as Structured Data? That makes sense... [12:34:40] Now to find the right project for them... [12:43:18] 3MediaWiki-extensions-WikidataRepo: split formatters into a new component - https://phabricator.wikimedia.org/T75871 (10JanZerebecki) 3NEW p:3Normal a:3Wikidata-bugs [12:44:41] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: split wikibase.git - https://phabricator.wikimedia.org/T75863#784110 (10JanZerebecki) [12:46:54] [13WikibaseSerializationJavaScript] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/VMD3PA [12:46:54] 13WikibaseSerializationJavaScript/06master 14de1a2a5 15thiemowmde: Merge pull request #10 from wmde/documentation... [12:48:27] (03CR) 10Hoo man: "Test nitpicks" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [12:48:36] (03PS6) 10Hoo man: Lazy initialize OtherProjectsSidebarGenerator in hook handlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [12:57:50] [13DataValuesJavascript] 15thiemowmde comment on pull request #56 141bc5695: That dash again. But doesn't matter. 02http://git.io/5EnIwQ [12:58:05] [13Interfaces] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/ZDBisQ [12:58:05] 13Interfaces/06master 14c457713 15Jeroen De Dauw: Merge pull request #7 from DataValues/options... [12:59:00] (03CR) 10Hoo man: Lazy initialize OtherProjectsSidebarGenerator in hook handlers (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [12:59:59] (03PS7) 10Hoo man: Lazy initialize OtherProjectsSidebarGenerator in hook handlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [13:00:30] (03CR) 10Hoo man: "Adjusted the tests according to my comments on the earlier PS" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [13:00:43] (03CR) 10Hoo man: [C: 032] Lazy initialize OtherProjectsSidebarGenerator in hook handlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [13:01:17] (03CR) 10Aude: "thanks hoo! :)" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [13:08:21] JeroenDeDauw: yes it would be not annoying if on github tags were automatically releases [13:10:09] [13WikibaseQuery] 15thiemowmde 04force-pushed 06protected from 14ee4a7f9 to 14acab05f: 02http://git.io/4eruJA [13:10:09] 13WikibaseQuery/06protected 14acab05f 15Thiemo Mättig: Fix visibility level of properties and methods [13:12:04] wmde/WikibaseQuery/protected/acab05f : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseQuery/builds/42075105 [13:13:29] (03Merged) 10jenkins-bot: Lazy initialize OtherProjectsSidebarGenerator in hook handlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [13:18:15] 3MediaWiki-extensions-WikidataClient, MediaWiki-Core-Team, Scrum-of-Scrums, Wikidata: Set languageLinkSiteGroup in $wgWBClientSettings to avoid fetching SiteList object from memcached - https://phabricator.wikimedia.org/T58602#784131 (10hoo) 5Open>3Resolved a:3hoo [13:18:56] aude: https://phabricator.wikimedia.org/T58602 is that actually resolved? [13:19:23] * hoo hates overly broad bugs [13:20:35] hoo: could you login on old-bugzilla? [13:21:21] yes [13:21:25] thx [13:22:17] hoo: we need to really watch the graphs linked in that bug after deployment to see that the memcache traffic is fine [13:22:48] yeah [13:23:24] should probably add that to the deployment page [13:38:13] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06dvintegration from 14d467367 to 149d629b2: 02http://git.io/bcVHHg [13:38:13] 13WikibaseQueryEngine/06dvintegration 149d629b2 15Thiemo Mättig: BooleanHandlerIntegrationTest [13:42:59] wmde/WikibaseQueryEngine/dvintegration/9d629b2 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/42077585 [13:43:13] 3MediaWiki-extensions-WikidataClient: allow accessing data from an item not connected to the current page - arbitrary access (tracking) - https://phabricator.wikimedia.org/T49930#784176 (10HenkvD) [13:43:43] [13WikibaseQueryEngine] 15thiemowmde 04force-pushed 06dvintegration2 from 1422d476a to 141619238: 02http://git.io/Oy-WnQ [13:43:43] 13WikibaseQueryEngine/06dvintegration2 14f0c32bb 15Thiemo Mättig: BooleanHandlerIntegrationTest [13:43:43] 13WikibaseQueryEngine/06dvintegration2 141619238 15Thiemo Mättig: Add all DVHandler integration tests [13:47:13] 3MediaWiki-extensions-WikidataClient, MediaWiki-extensions-WikidataRepo, Wikimedia-Wikidata: log data about cpu time and memory usage - https://phabricator.wikimedia.org/T75873 (10JanZerebecki) 3NEW p:3High [13:51:09] 3Wikimedia-Wikidata: Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on) - https://phabricator.wikimedia.org/T73519#784194 (10JanZerebecki) [13:51:16] wmde/WikibaseQueryEngine/dvintegration2/1619238 : Thiemo Mättig The build is still failing. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/42078268 [13:51:42] 3Wikimedia-Wikidata: Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on) - https://phabricator.wikimedia.org/T73519#765044 (10JanZerebecki) [13:57:02] [13Geo] 15thiemowmde 04force-pushed 06globeTest from 141e2403e to 14f87f157: 02http://git.io/s3XopQ [13:57:02] 13Geo/06globeTest 14f87f157 15Thiemo Mättig: Add missing GlobeCoordinateFormatterTest [13:58:53] 3MediaWiki-extensions-WikidataRepo: Move wikibase formatters into separate component - https://phabricator.wikimedia.org/T75875 (10daniel) 3NEW p:3Triage [14:00:17] 3MediaWiki-extensions-WikidataRepo: Move wikibase formatters into separate component - https://phabricator.wikimedia.org/T75875#784215 (10daniel) [14:00:42] 3MediaWiki-extensions-WikidataRepo: Move wikibase formatters into separate component - https://phabricator.wikimedia.org/T75875#784215 (10daniel) [14:01:20] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: split wikibase.git - https://phabricator.wikimedia.org/T75863#784230 (10daniel) [14:03:33] 3MediaWiki-extensions-WikidataRepo: Find a home for EntityChange and friends - https://phabricator.wikimedia.org/T75875#784244 (10daniel) [14:05:28] 3MediaWiki-extensions-WikidataRepo: Split lib/storage into a separate component - https://phabricator.wikimedia.org/T75877#784247 (10daniel) [14:06:51] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: split wikibase.git - https://phabricator.wikimedia.org/T75863#784255 (10daniel) [14:09:20] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: split wikibase.git - https://phabricator.wikimedia.org/T75863#784257 (10daniel) [14:11:04] 3MediaWiki-extensions-WikidataRepo: move wikibase parsers and validators (to repo, or a separate component) - https://phabricator.wikimedia.org/T75879#784272 (10daniel) [14:13:21] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: split wikibase.git - https://phabricator.wikimedia.org/T75863#784289 (10daniel) [14:25:19] (03PS1) 10Hoo man: Fix adding multiple qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175701 [14:25:23] Adrian_WMDE: ^ [14:27:07] 3MediaWiki-extensions-WikidataRepo: Fix Wikibase Serialization Tests - https://phabricator.wikimedia.org/T75886 (10Tobi_WMDE_SW) 3NEW p:3Normal [14:28:02] 3MediaWiki-extensions-WikidataRepo: Find a home for shared utilities like reporters, sites, etc. - https://phabricator.wikimedia.org/T75887 (10daniel) 3NEW p:3Triage [14:28:18] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: split wikibase.git - https://phabricator.wikimedia.org/T75863#784377 (10daniel) [14:30:22] 3MediaWiki-extensions-WikidataRepo: New serialization code needs to support language fallback - https://phabricator.wikimedia.org/T74183#784381 (10Tobi_WMDE_SW) [14:32:27] DanielK_WMDE_: Adrian_WMDE: ähm, https://phabricator.wikimedia.org/T75264 can be closed? [14:33:13] Yesso [14:33:59] 3Wikimedia-Wikidata: Unblock editing the item for Germany (Q183) (Was: Wikimedia Error page on) - https://phabricator.wikimedia.org/T73519#784388 (10Tobi_WMDE_SW) [14:34:26] Adrian_WMDE: I think your comments address another task then? [14:34:34] confused [14:34:48] Yr [14:34:53] es [14:35:18] Probably rather https://phabricator.wikimedia.org/T64724 [14:37:33] 3MediaWiki-extensions-WikidataRepo: Use EntityIdFormatter for PropertyLabels in ClaimHtmlFormatter - https://phabricator.wikimedia.org/T75888 (10Tobi_WMDE_SW) 3NEW p:3Triage a:3Wikidata-bugs [14:40:39] 3MediaWiki-extensions-WikidataRepo: [HHVM] Get rid of class aliases - https://phabricator.wikimedia.org/T73295#784421 (10hashar) [14:49:39] (03PS5) 10Adrian Lang: Inject EntityInfoTermLookup into WikibaseValueFormattersBuilders [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 [14:50:02] (03PS2) 10Adrian Lang: Use the same EntityInfo for JS and PHP [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 [14:52:08] Adrian_WMDE: Still waiting for a +2 ... ;) [14:52:23] Did jenkins +2? [14:52:54] yep [14:54:38] hoo: we can't reproduce the terms mixup [14:54:43] (03CR) 10Adrian Lang: [C: 032] Fix adding multiple qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175701 (owner: 10Hoo man) [14:55:02] (03PS19) 10Hoo man: Introduce PageTerms API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [14:55:05] uhm... awesome [14:55:24] (03CR) 10Hoo man: Introduce PageTerms API module (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [14:56:10] (03CR) 10Adrian Lang: "Per Daniel's request, I removed the LabelLookupFactory and instead injected the TermLookup." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [14:56:31] (03CR) 10Hoo man: "Addressed Adrian's (and my) comments, added a test case for that. Also simplified tests." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [14:58:52] hoo: yes resolved [14:59:32] yay :) [14:59:43] my patch wasn't even for that specific issue, but rather a different but related cause / problem [14:59:50] [13Geo] 15JanZerebecki pushed 1 new commit to 06master: 02http://git.io/npeiqA [14:59:50] 13Geo/06master 14f6991a1 15Jan Zerebecki: Merge pull request #36 from DataValues/globeTest... [15:04:02] 3MediaWiki-extensions-WikidataClient, MediaWiki-Core-Team, Scrum-of-Scrums, Wikidata: Set languageLinkSiteGroup in $wgWBClientSettings to avoid fetching SiteList object from memcached - https://phabricator.wikimedia.org/T58602#784502 (10aude) [15:06:03] (03CR) 10Daniel Kinzler: [C: 031] "Approving Hoo Man's changes. Somebody please +2 :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [15:06:16] hoo: --^ [15:06:40] ok, let me have another quick look [15:07:04] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #309: Property constructor parameter is optional (06master...06slOptional) 02http://git.io/t4YuEw [15:07:51] (03CR) 10Daniel Kinzler: Introduce PageTerms API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [15:08:05] (03Merged) 10jenkins-bot: Fix adding multiple qualifiers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175701 (owner: 10Hoo man) [15:09:12] DanielK_WMDE_: there's one more issue I'd like to talk about with you [15:09:16] usability vise [15:10:57] did we make a branch yet? [15:12:26] no, I want to have the API in [15:12:37] will probably do it tonight [15:12:41] but certainly today [15:13:33] yeah [15:21:03] (03PS1) 10Henning Snater: Scrape languages of "in other languages" section from HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175705 [15:22:00] [13AskSerialization] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/rKGF6w [15:22:00] 13AskSerialization/06master 14ebac995 15Jeroen De Dauw: Update composer.json [15:22:12] (03CR) 10Hoo man: [C: 032] Introduce PageTerms API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [15:22:23] [13WikibaseQuery] 15JeroenDeDauw created 06deps (+1 new commit): 02http://git.io/0TFDyw [15:22:23] 13WikibaseQuery/06deps 1435c644f 15jeroendedauw: Update compatible DataValues versions [15:25:00] [13AskSerialization] 15JeroenDeDauw created 06103 (+1 new commit): 02http://git.io/5ytIMA [15:25:00] 13AskSerialization/06103 14aeea9ba 15jeroendedauw: Update release notes for 1.0.3 [15:25:18] [13AskSerialization] 15JeroenDeDauw opened pull request #8: Update release notes for 1.0.3 (06master...06103) 02http://git.io/EG2WzQ [15:29:30] (03PS2) 10Henning Snater: Scrape languages of "in other languages" section from HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175705 [15:29:41] (03Merged) 10jenkins-bot: Introduce PageTerms API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [15:30:21] wmde/WikibaseQuery/deps/35c644f : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQuery/builds/42089382 [15:32:03] 3MediaWiki-extensions-WikidataRepo: When the client extension is active on the repo, treat Item pages as "linked" with themselves. - https://phabricator.wikimedia.org/T75895#784584 (10daniel) [15:36:09] (03CR) 10Hoo man: [C: 032] Scrape languages of "in other languages" section from HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175705 (owner: 10Henning Snater) [15:36:47] (03PS3) 10Hoo man: Scrape languages of "in other languages" section from HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175705 (owner: 10Henning Snater) [15:37:00] wmde/AskSerialization#55 (103 - aeea9ba : jeroendedauw): The build passed. [15:37:00] Change view : https://github.com/wmde/AskSerialization/commit/aeea9ba236fd [15:37:00] Build details : http://travis-ci.org/wmde/AskSerialization/builds/42089699 [15:38:11] [13AskSerialization] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/VVeXWg [15:38:11] 13AskSerialization/06master 14133f148 15Marius Hoch: Merge pull request #8 from wmde/103... [15:39:58] [13AskSerialization] 15JeroenDeDauw tagged 061.0.3 at 06master: 02http://git.io/dFGOJQ [15:41:40] jzerebecki: https://www.wikidata.org/wiki/Wikidata:Contact_the_development_team#Rendering_of_coordinates [15:44:17] 3MediaWiki-extensions-WikidataRepo: Coordinates in old revision shown as 0°0'NFF"N, 0°0'NFF"E - https://phabricator.wikimedia.org/T75897 (10Raymond) 3NEW p:3Triage [15:45:45] jzerebecki: https://phabricator.wikimedia.org/T75897 [15:45:47] wmde/AskSerialization#58 (1.0.3 - 133f148 : Marius Hoch): The build passed. [15:45:47] Change view : https://github.com/wmde/AskSerialization/compare/1.0.3 [15:45:47] Build details : http://travis-ci.org/wmde/AskSerialization/builds/42091432 [15:45:48] GEO bug [15:47:28] 3MediaWiki-extensions-WikidataRepo: Coordinates in old revision shown as 0°0'NFF"N, 0°0'NFF"E - https://phabricator.wikimedia.org/T75897#784615 (10hoo) p:5Triage>3High a:3JanZerebecki [15:57:07] 3MediaWiki-extensions-WikidataRepo: languages mixed up in "other languages" box when using uselang param - https://phabricator.wikimedia.org/T75749#784625 (10hoo) 5Open>3Resolved a:3hoo [16:00:36] DanielK_WMDE_: T74314 soll in https://phabricator.wikimedia.org/T74314 [16:01:55] 3MediaWiki-extensions-WikidataRepo: Rollout of statements on properties with old serialization code - https://phabricator.wikimedia.org/T74314#784634 (10Lydia_Pintscher) [16:04:23] 3MediaWiki-extensions-WikidataRepo: Rollout of statements on properties with old serialization code - https://phabricator.wikimedia.org/T74314#784635 (10daniel) [16:05:11] 3MediaWiki-extensions-WikidataRepo: Rollout of statements on properties with old serialization code - https://phabricator.wikimedia.org/T74314#784640 (10hoo) [16:12:22] Hi [16:14:51] aude: We had a discussion about the caching file store stuffs earlier today over here [16:15:41] ? [16:16:00] want to do anything different than what my patch does? [16:17:31] aude: Well... mh... [16:17:48] Daniel would like to have completely file based, maybe [16:17:53] + this [16:18:07] a read only store would be a different interface [16:18:12] yeah [16:18:26] but the current thing with configuration variables is a bit of a mess IMO [16:18:32] others might disagree, thus no -1 [16:18:52] not that it's nice (agree) but it's how localisation cache works for this [16:19:27] i would like to factor out the caching stuff and mayce can share some code [16:19:28] localization cache is only centrally created and changed, right? [16:19:36] not only [16:19:39] depends on config [16:19:44] yikes [16:19:57] only wmf does manual recache (e.g.) [16:25:49] i can certainly split up the cache and cache builder parts [16:31:58] Thiemo_WMDE: DanielK_WMDE_: I'm about to create ResultWrapperWrapper. Panic? :) [16:36:15] JeroenDeDauw: it's called toilet paper programming. or mummification. layers upon layers... [16:37:42] aude: The error logs are full of "PHP Warning: Division by zero in /srv/mediawiki/php-1.25wmf8/extensions/Wikidata/vendor/data-values/geo/src/Formatters/GeoCoordinateFormatter.php on line 217" right now [16:37:55] Was there a backport for that? [16:38:20] bd808: No, but we will fix that with the next branch [16:38:26] *nod* [16:38:26] literally just talked about that [16:38:41] (03CR) 10Jeroen De Dauw: "Does this not require matching changes in some JS or so?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175684 (owner: 10Adrian Lang) [16:38:51] the fix is there, just needs a release in the DataValues/Geo component [16:39:56] hoo: There is a PR by Thiemo_WMDE. And Thiemo_WMDE might or might not want to have something reverted - I don't quite understand what hes saying [16:40:14] JeroenDeDauw: Link? [16:41:17] bd808: Do you think that's backport worthy? [16:41:32] We can probably also take it live this week, if needed [16:41:53] hoo: 171 errors in the last hour. Seems like a lot [16:42:34] bd808: Ok, we will backport that, then [16:42:49] The logs thank you. :) [16:43:14] (03CR) 10Daniel Kinzler: [C: 031] "This looks pretty good on a first glance. Needs more poking, and I'd love a second opinion." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [16:43:20] hoo: oh, nvm, was merged 2h ago [16:43:36] [13Geo] 15JanZerebecki created 06release (+1 new commit): 02http://git.io/hMWkyw [16:43:36] 13Geo/06release 14025ec3e 15Jan Zerebecki: Release 1.1.4 [16:43:55] [13Geo] 15JanZerebecki opened pull request #37: Release 1.1.4 (06master...06release) 02http://git.io/5Mk3Qg [16:44:05] [13Geo] 15JanZerebecki 04deleted 06release at 14025ec3e: 02http://git.io/FSidCw [16:44:16] jzerebecki: dont tag yet [16:44:21] you forgot to up the version number [16:44:31] [13Geo] 15JanZerebecki tagged 061.1.4 at 06master: 02http://git.io/tH90Rg [16:44:34] >_> [16:44:43] https://github.com/DataValues/Geo/blob/master/Geo.php#L18 [16:44:45] sorry [16:45:09] jzerebecki: that is why it is good to have someone else merge your release commit before creating the tag [16:45:22] JeroenDeDauw: should i remove and add the same tag again or update one version number more? [16:46:25] jzerebecki: re-release 1.1.4 [16:46:47] We had cases where we re-tagged on release 4 times (ValueView, ftw) [16:47:12] hoo: and this did not cause any issues? [16:47:27] nope, github and packagist can handle that [16:47:33] even composer can handle it AFAIK [16:47:51] works when we delete from gerrit too [16:47:56] "even composer" :) [16:47:59] [13Geo] 15JanZerebecki created 06release (+1 new commit): 02http://git.io/c4TbnQ [16:47:59] 13Geo/06release 1453a19ad 15Jan Zerebecki: Release 1.1.4... [16:48:29] [13Geo] 15JanZerebecki opened pull request #38: Release 1.1.4 (06master...06release) 02http://git.io/Zk-wKw [16:48:37] JeroenDeDauw: https://github.com/DataValues/Geo/pull/38 [16:48:42] JeroenDeDauw: Well, some may think that a release is something stable, so no need to check whether the actual release changed :P [16:49:15] [13Geo] 15mariushoch 04deleted 06release at 1453a19ad: 02http://git.io/BDC7Ig [16:49:49] Lydia_WMDE: where is scrumbugs now? :) [16:49:54] nowhere, yet [16:49:59] ah [16:50:01] Lydia's in a meeting, btw [16:50:04] ok [16:50:11] oh, I don't expect it to update to 1.1.4 (2nd version) if you already have 1.1.4 [16:50:16] yeah... will take a few week until scrumbugz works as a phab. extension [16:50:28] JeroenDeDauw: But it doies, I htink [16:50:57] hoo: really? I'd be quite surprised... [16:51:07] mh... test it?! [16:53:23] (03PS1) 10Jeroen De Dauw: Do not typehint against Entity in WikibaseLuaEntityBindingsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175734 [16:55:54] (03PS1) 10Jeroen De Dauw: Remove seemingly unused code from EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 [16:59:02] (03CR) 10Hoo man: [C: 04-1] Remove seemingly unused code from EntityChange (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 (owner: 10Jeroen De Dauw) [17:02:39] (03CR) 10jenkins-bot: [V: 04-1] Remove seemingly unused code from EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 (owner: 10Jeroen De Dauw) [17:03:03] hoo: what. evil lying comment! [17:03:48] Good ol' jenkins shares my view :D [17:04:46] I'm guessing the call can then simply be removed? [17:04:54] Or am I missing a way this info is used? [17:05:30] (03PS2) 10Jeroen De Dauw: Remove seemingly unused code from EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 [17:06:05] JeroenDeDauw: Seems unused [17:06:14] see also EntityChange::serializeInfo [17:07:10] in that case serializeInfo can also die [17:07:34] (03PS1) 10Jeroen De Dauw: Do not type hint against Entity in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175738 [17:08:03] (03CR) 10Hoo man: [C: 032] Do not typehint against Entity in WikibaseLuaEntityBindingsTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175734 (owner: 10Jeroen De Dauw) [17:08:26] (03PS3) 10Jeroen De Dauw: Remove seemingly unused code from EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 [17:08:27] hoo: there you go [17:08:46] hoo: you are now complicit in the slaughter of dead code [17:10:53] yay :D [17:11:20] (03PS1) 10Jeroen De Dauw: Make fields in EntityRevision private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175740 [17:11:22] (03PS1) 10Jeroen De Dauw: Add TODO [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175741 [17:12:19] (03PS1) 10Jeroen De Dauw: Act on TODO: rename getRevision to getRevisionId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 [17:14:39] (03PS1) 10Jeroen De Dauw: Stop type hinting against Entity in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175747 [17:18:45] [13Geo] 15mariushoch 04deleted 061.1.4 at 143c358a8: 02http://git.io/JYZbTA [17:19:17] [13Geo] 15mariushoch tagged 061.1.4 at 06master: 02http://git.io/tH90Rg [17:20:15] nomnomnom? [17:20:22] Thiemo_WMDE: jzerebecki DanielK_WMDE_ ^ [17:20:26] Abraham_WMDE: ^ :) [17:20:42] JeroenDeDauw: no thx [17:20:52] http://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [17:21:11] JeroenDeDauw: no thx [17:26:26] (03PS1) 10Hoo man: Fix adding multiple qualifiers [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175752 [17:26:43] [13ValueView] 15snaterlicious created 06documentation (+6 new commits): 02http://git.io/7iZwVg [17:26:43] 13ValueView/06documentation 14c4fa8bc 15snaterlicious: Updated documentation of lib/jquery modules [17:26:43] 13ValueView/06documentation 1460f9bfa 15snaterlicious: Updated documentation of lib/jquery.event modules [17:26:43] 13ValueView/06documentation 14c267853 15snaterlicious: Moved file level documentation to class/constructor level... [17:29:50] Thiemo_WMDE: https://gerrit.wikimedia.org/r/175701 [17:35:09] (03PS1) 10Hoo man: Fix claimview nextListItemIsPending condition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175754 [17:38:32] (03CR) 10jenkins-bot: [V: 04-1] Do not type hint against Entity in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175738 (owner: 10Jeroen De Dauw) [17:39:06] (03CR) 10jenkins-bot: [V: 04-1] Remove seemingly unused code from EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 (owner: 10Jeroen De Dauw) [17:42:16] (03PS1) 10Jeroen De Dauw: Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 [17:42:53] (03PS4) 10Jeroen De Dauw: Remove seemingly unused code from EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 [17:43:01] (03PS2) 10Jeroen De Dauw: Do not type hint against Entity in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175738 [17:43:35] hoo: https://gerrit.wikimedia.org/r/#/c/175752/1/lib/resources/jquery.wikibase/jquery.wikibase.claimview.js [17:43:37] wow, dat indenting [17:43:45] it's so screwed [17:43:52] » » » » » » » » » » » || !claimvie [17:44:01] That is the first line :D [17:44:06] . [17:44:14] wow, this broke the formatting of my IRC client [17:44:28] . [17:44:34] (03CR) 10jenkins-bot: [V: 04-1] Make fields in EntityRevision private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175740 (owner: 10Jeroen De Dauw) [17:45:42] (03CR) 10Jeroen De Dauw: [C: 031] Fix adding multiple qualifiers [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175752 (owner: 10Hoo man) [17:46:04] (03CR) 10Jeroen De Dauw: [C: 031] Fix claimview nextListItemIsPending condition [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175754 (owner: 10Hoo man) [17:46:27] (03PS2) 10Jeroen De Dauw: Make fields in EntityRevision private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175740 [17:46:33] (03PS2) 10Jeroen De Dauw: Add TODO [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175741 [17:46:36] (03PS2) 10Jeroen De Dauw: Act on TODO: rename getRevision to getRevisionId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 [17:47:47] (03PS2) 10Hoo man: Fix claimview nextListItemIsPending [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175754 [17:49:10] http://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [17:49:16] 3MediaWiki-extensions-WikidataClient, MediaWiki-Core-Team, Scrum-of-Scrums, Wikidata: Set languageLinkSiteGroup in $wgWBClientSettings to avoid fetching SiteList object from memcached - https://phabricator.wikimedia.org/T58602#784922 (10bd808) [17:49:39] (03PS1) 10Jeroen De Dauw: Thiemo should get a food? [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175757 [17:49:41] Thiemo_WMDE: ^ [17:50:05] (03CR) 10Hoo man: [C: 032] "Of course!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175757 (owner: 10Jeroen De Dauw) [17:50:12] (03CR) 10Hoo man: Thiemo should get a food? [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175757 (owner: 10Jeroen De Dauw) [17:50:30] Thiemo_WMDE: http://www.lieferando.de/lieferservice-world-of-pizza-berlin#! [17:50:36] hoo: if you want something, send [17:50:44] looking now [17:50:55] JeroenDeDauw: thanks, Salat Nebraska please. [17:51:45] JeroenDeDauw: Just some "Country Potatoes", plesae [17:51:50] (under Fingerfood) [17:52:14] (03PS3) 10Hoo man: Fix claimview nextListItemIsPending [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175754 [17:52:32] hoo: mayo, ketchup? [17:52:46] ketchup [17:53:47] (03Abandoned) 10Jeroen De Dauw: Thiemo should get a food? [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175757 (owner: 10Jeroen De Dauw) [17:53:56] Thiemo_WMDE: bitcoinz! [17:54:01] hoo: do you have real moneys? [17:54:10] Yeah, manual coins :P [17:54:46] hoo: you mean this fake fiat currency thing> [17:54:48] ? [17:55:01] Abraham_WMDE: very descriptive... "WMDE stuff" :) [17:55:28] Yeah :P They even pay me in that... [17:57:53] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "This reverts I0e0d020 and fixes it properly." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175754 (owner: 10Hoo man) [17:58:01] :) [17:58:24] (03PS1) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [17:59:12] (03CR) 10Jeroen De Dauw: [C: 031] Fix claimview nextListItemIsPending [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175754 (owner: 10Hoo man) [18:01:43] (03PS1) 10Thiemo Mättig (WMDE): Fix call on undefined in entityselector.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175761 [18:02:18] (03PS1) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [18:02:20] (03PS1) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [18:03:42] (03PS2) 10Thiemo Mättig (WMDE): Fix call on undefined in entityselector.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175761 [18:04:25] (03PS2) 10Hoo man: Fix claimview nextListItemIsPending [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175752 [18:04:50] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175752 (owner: 10Hoo man) [18:07:12] (03PS1) 10Jeroen De Dauw: Fix typo in use statement in EntityRetrievingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175764 [18:07:36] 3MediaWiki-extensions-WikidataRepo: Coordinates shown as 0°0'NFF"N, 0°0'NFF"E caused by php warning: division by zero in GeoCoordinateFormatter - https://phabricator.wikimedia.org/T75601#784986 (10JanZerebecki) [18:08:07] 3MediaWiki-extensions-WikidataRepo: Coordinates in old revision shown as 0°0'NFF"N, 0°0'NFF"E - https://phabricator.wikimedia.org/T75897#784987 (10JanZerebecki) [18:08:09] 3MediaWiki-extensions-WikidataRepo: Coordinates shown as 0°0'NFF"N, 0°0'NFF"E caused by php warning: division by zero in GeoCoordinateFormatter - https://phabricator.wikimedia.org/T75601#764137 (10JanZerebecki) [18:08:29] (03PS1) 10Jeroen De Dauw: Improve variable naming [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175765 [18:10:05] (03PS1) 10Jeroen De Dauw: Remove assmuption that all entities have a fingerprint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175766 [18:10:40] I feel like a denial of service bot now :D [18:11:56] aude: https://phabricator.wikimedia.org/T72883 "since it is installed there via composer, doing fresh clone" if you point composer to github it'll download zipballs instead of doing git clones [18:14:37] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 (owner: 10Jeroen De Dauw) [18:15:49] (03CR) 10jenkins-bot: [V: 04-1] Remove seemingly unused code from EntityChange [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 (owner: 10Jeroen De Dauw) [18:16:16] (03PS1) 10Jeroen De Dauw: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 [18:18:51] (03CR) 10jenkins-bot: [V: 04-1] Do not type hint against Entity in EntityContentFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175738 (owner: 10Jeroen De Dauw) [18:21:16] (03PS2) 10Jeroen De Dauw: Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 [18:21:55] (03PS5) 10Jeroen De Dauw: Remove seemingly unused code from EntityChange. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 [18:22:23] (03PS3) 10Jeroen De Dauw: Do not type hint against Entity in EntityContentFactory. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175738 [18:23:00] Thiemo_WMDE: https://github.com/wmde/WikimediaBadges/pull/16 [18:23:02] [13WikimediaBadges] 15mariushoch created 06recommendedarticle (+1 new commit): 02http://git.io/uAV2Gw [18:23:02] 13WikimediaBadges/06recommendedarticle 14279a3bd 15Marius Hoch: Use the silver-star for recommended articles [18:23:12] [13WikimediaBadges] 15mariushoch opened pull request #16: Use the silver-star for recommended articles (06master...06recommendedarticle) 02http://git.io/Q7R-5Q [18:23:23] Why the fuck do we have a hook in a "config" file? [18:23:36] do we? [18:23:45] Wikibase.searchindex.php [18:24:41] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: re-add sitelink when undeleting article - https://phabricator.wikimedia.org/T75908 (10Lydia_Pintscher) 3NEW p:3Triage a:3Wikidata-bugs [18:25:40] [13WikimediaBadges] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/39gTzQ [18:25:40] 13WikimediaBadges/06master 14bb5baa8 15thiemowmde: Merge pull request #16 from wmde/recommendedarticle... [18:27:30] Anyone knows if the stuff there is just supposed to work for Items, or should it be all Entities with statements? [18:27:37] hoo: aude ^ [18:27:42] 3MediaWiki-extensions-WikidataRepo: Coordinates shown as 0°0'NFF"N, 0°0'NFF"E caused by php warning: division by zero in GeoCoordinateFormatter - https://phabricator.wikimedia.org/T75601#785035 (10JanZerebecki) More occurances: https://www.wikidata.org/w/index.php?title=Q940689&diff=51491769&oldid=41217013 https... [18:27:58] https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/config/Wikibase.searchindex.php#L31 [18:28:06] [13Wikidata.org] 15mariushoch created 06recommendedarticle (+1 new commit): 02http://git.io/FaoJog [18:28:06] 13Wikidata.org/06recommendedarticle 14558038f 15Marius Hoch: Use the silver-star for recommended articles [18:28:41] JeroenDeDauw: I guess item only [18:28:49] but it's only an example and it's messy [18:29:01] https://github.com/wmde/Wikidata.org/pull/18 [18:29:10] Oh... example... missed that word [18:29:12] [13Wikidata.org] 15mariushoch opened pull request #18: Use the silver-star for recommended articles (06master...06recommendedarticle) 02http://git.io/fVAZ9A [18:29:18] Why is it in the config folder then? [18:30:31] no idea [18:30:44] should probably be in docs [18:32:29] (03CR) 10jenkins-bot: [V: 04-1] Fix claimview nextListItemIsPending [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175754 (owner: 10Hoo man) [18:32:30] [13Wikidata.org] 15thiemowmde pushed 2 new commits to 06master: 02http://git.io/dkP0FA [18:32:30] 13Wikidata.org/06master 14558038f 15Marius Hoch: Use the silver-star for recommended articles [18:32:30] 13Wikidata.org/06master 14bf5acbd 15thiemowmde: Merge pull request #18 from wmde/recommendedarticle... [18:33:09] (03CR) 10Hoo man: [V: 032] Fix claimview nextListItemIsPending [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175754 (owner: 10Hoo man) [18:36:05] (03PS1) 10Jeroen De Dauw: Stop using deprecated method in EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175774 [18:36:21] 3MediaWiki-extensions-WikidataRepo: Remove incorrect Entity assumptions from EntityParserOutputGenerator - https://phabricator.wikimedia.org/T75495#785110 (10JeroenDeDauw) The concrete issue pointed out is fixed by https://gerrit.wikimedia.org/r/#/c/175774/ However, there is still an OCP violation. [18:43:00] (03CR) 10jenkins-bot: [V: 04-1] Act on TODO: rename getRevision to getRevisionId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [18:45:16] (03CR) 10jenkins-bot: [V: 04-1] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [18:46:26] [13WikibaseQuery] 15thiemowmde comment on pull request #59 1435c644f: Do you remember why this was here if it's not needed? 02http://git.io/lbsT6g [18:47:10] (03PS2) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [18:47:22] evil jenkinnnnnz [18:47:24] (03PS3) 10Jeroen De Dauw: Act on TODO: rename getRevision to getRevisionId. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 [18:50:18] (03CR) 10Hoo man: [V: 032] Fix claimview nextListItemIsPending [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175752 (owner: 10Hoo man) [18:50:50] [13WikibaseQuery] 15thiemowmde 04deleted 06deps at 1435c644f: 02http://git.io/ImNG7g [18:54:31] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [19:00:45] (03PS1) 10Hoo man: Update Wikibase, data-values/geo et al. [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175778 [19:01:31] (03CR) 10jenkins-bot: [V: 04-1] Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [19:02:53] (03CR) 10jenkins-bot: [V: 04-1] Fix call on undefined in entityselector.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175761 (owner: 10Thiemo Mättig (WMDE)) [19:04:26] (03CR) 10Hoo man: [C: 032] Update Wikibase, data-values/geo et al. [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175778 (owner: 10Hoo man) [19:08:52] (03Merged) 10jenkins-bot: Update Wikibase, data-values/geo et al. [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/175778 (owner: 10Hoo man) [19:10:22] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175761 (owner: 10Thiemo Mättig (WMDE)) [19:11:05] (03CR) 10Hoo man: [C: 032] Fix call on undefined in entityselector.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175761 (owner: 10Thiemo Mättig (WMDE)) [19:21:32] (03CR) 10jenkins-bot: [V: 04-1] Improve variable naming [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175765 (owner: 10Jeroen De Dauw) [19:23:45] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [19:25:06] (03CR) 10jenkins-bot: [V: 04-1] Remove assmuption that all entities have a fingerprint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175766 (owner: 10Jeroen De Dauw) [19:30:54] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 (owner: 10Jeroen De Dauw) [19:41:17] (03Merged) 10jenkins-bot: Fix call on undefined in entityselector.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175761 (owner: 10Thiemo Mättig (WMDE)) [19:41:35] (03CR) 10jenkins-bot: [V: 04-1] Act on TODO: rename getRevision to getRevisionId. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [19:42:59] (03CR) 10jenkins-bot: [V: 04-1] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [20:00:22] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf9/6388f3c : Marius Hoch The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42118862 [20:02:28] 3MediaWiki-extensions-WikidataRepo, MediaWiki-extensions-WikidataClient: re-add sitelink when undeleting article - https://phabricator.wikimedia.org/T75908#785563 (10hoo) 5Open>3declined I think this is to much work, for to little benefit. What we could possible do is to delay the execution of the jobs that... [20:02:55] https://www.wikidata.org/w/index.php?title=Q777&diff=0&oldid=175339935 <- hmmmm [20:03:17] * Lydia_WMDE doesn't currently have time to look for proper sources [20:03:20] anyone else? [20:03:36] Nope :P But I think Chrome has proprietary parts [20:05:01] Yes, Chromium is the completely open source version. [20:06:19] https://code.google.com/p/chromium/wiki/ChromiumBrowserVsGoogleChrome [20:07:29] andre__: why is needs volunteer a priority in phabricator? [20:07:43] Geo stuff still borken it seems [20:07:46] arghghgahghghghghghgh [20:07:51] hoo: :/ [20:08:00] There is a lot broken, I thought. [20:08:32] Lydia_WMDE, because "Lowest" sounds even more insulting :) [20:08:41] = if nobody volunteers to work on it, nobody will do it. [20:08:54] https://phabricator.wikimedia.org/T268 [20:08:59] andre__: but a high prio task can need volunteers just as much [20:09:05] Yep [20:09:11] those are distinct concepts [20:09:18] that sounds like volunteers are for the work that nobody cares about [20:09:30] "Must have a volunteer otherwise definitely nothing will happen" didn't feed in the field. [20:09:32] *fit [20:09:37] other way around... [20:09:47] staff are things for no one cares to volunteer to do [20:09:49] if somebody sets high priority than that person might also want to take care that something will happen. [20:09:58] no, volunteer does not imply non-staff. [20:10:07] also staff can do volunteer things. [20:10:26] hoo: that might in some cases even be realistic. [20:11:08] * Lydia_WMDE comments on ticket [20:14:18] Lydia_WMDE: I only pushed to wmf8 because I somehow thought Wikidata has been updated earlier today, thus would already be on the new branch [20:14:21] I was wrong [20:14:32] ah :D [20:18:08] Lydia_WMDE: Ok, now everything is fine again [20:18:14] \o/ [20:18:17] and one can even add qualifiers :D [20:18:20] thanks hoo! [20:21:47] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Stop using deprecated method in EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175774 (owner: 10Jeroen De Dauw) [20:22:34] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Fix typo in use statement in EntityRetrievingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175764 (owner: 10Jeroen De Dauw) [20:25:00] (03CR) 10Thiemo Mättig (WMDE): "Changing the return type of the getter alone is probably not exactly what you want. What about the constructor parameter? And change the n" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175741 (owner: 10Jeroen De Dauw) [20:31:46] (03Merged) 10jenkins-bot: Stop using deprecated method in EntityParserOutputGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175774 (owner: 10Jeroen De Dauw) [20:31:51] (03Merged) 10jenkins-bot: Fix typo in use statement in EntityRetrievingTermLookup [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175764 (owner: 10Jeroen De Dauw) [20:32:50] (03PS1) 10Hoo man: New deployment build: wmf/1.25wmf10 [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/175802 [20:34:49] (03PS1) 10Thiemo Mättig (WMDE): Narrow TermSqlIndex interface to EntityId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175803 [20:34:57] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf10/e8d0219 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/42122724 [20:35:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Stop type hinting against Entity in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175747 (owner: 10Jeroen De Dauw) [20:36:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Make fields in EntityRevision private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175740 (owner: 10Jeroen De Dauw) [20:38:40] (03CR) 10Hoo man: [C: 032] Remove seemingly unused code from EntityChange. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 (owner: 10Jeroen De Dauw) [20:38:44] (03PS3) 10Jeroen De Dauw: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 [20:38:49] (03PS2) 10Jeroen De Dauw: Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 [20:38:59] (03PS2) 10Jeroen De Dauw: Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 [20:39:41] (03CR) 10Hoo man: [C: 032] New deployment build: wmf/1.25wmf10 [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/175802 (owner: 10Hoo man) [20:39:48] aude: ^ [20:39:58] You might want to have a look, as I'm not usually doing these [20:40:00] (03CR) 10Jeroen De Dauw: "Call to undefined method Wikibase\EntityRevision::getRevision() in /mnt/jenkins-workspace/workspace/mwext-Wikibase-repo-tests/extensions/W" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [20:40:06] but I think I did ok [20:47:16] (03CR) 10Jeroen De Dauw: [C: 04-1] Stop using deprecated methods in GenericEntityInfoBuilder (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 (owner: 10Jeroen De Dauw) [20:47:28] (03PS3) 10Jeroen De Dauw: [WIP] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 [20:48:13] (03PS4) 10Thiemo Mättig (WMDE): Act on TODO: rename getRevision to getRevisionId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [20:48:57] (03PS2) 10Jeroen De Dauw: Remove assmuption that all entities have a fingerprint [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175766 [20:48:58] hoo: looks ok to me [20:49:29] (03PS1) 10Thiemo Mättig (WMDE): Make stuff in CachingEntityRevisionLookup private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175823 [20:50:01] as long as we can see the diff, for sanity check and allow jenkins to run [20:53:59] hoo: Lydia_WMDE who is going to be around for deployment next wednesday? [20:55:56] not me, probably [20:56:01] but I said trhat [20:59:18] (03Merged) 10jenkins-bot: Stop type hinting against Entity in TermSqlIndex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175747 (owner: 10Jeroen De Dauw) [20:59:21] (03Merged) 10jenkins-bot: Make fields in EntityRevision private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175740 (owner: 10Jeroen De Dauw) [21:02:17] [13WikibaseDataModelSerialization] 15JeroenDeDauw comment on pull request #97 1477a3794: spaces! `(foo)` vs `( foo )` 02http://git.io/EmJjtg [21:02:57] (03Merged) 10jenkins-bot: Remove seemingly unused code from EntityChange. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175736 (owner: 10Jeroen De Dauw) [21:02:59] (03Merged) 10jenkins-bot: New deployment build: wmf/1.25wmf10 [extensions/Wikidata] (wmf/1.25wmf10) - 10https://gerrit.wikimedia.org/r/175802 (owner: 10Hoo man) [21:04:02] hoo: ok [21:05:33] (03PS2) 10Jeroen De Dauw: Improve variable naming [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175765 [21:05:40] Maybe Jan will do it [21:07:34] k [21:07:59] (03PS2) 10Jeroen De Dauw: Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 [21:08:46] (03CR) 10Jeroen De Dauw: [C: 032] Make stuff in CachingEntityRevisionLookup private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175823 (owner: 10Thiemo Mättig (WMDE)) [21:10:28] 3MediaWiki-extensions-WikidataClient, MediaWiki-Core-Team, Scrum-of-Scrums, Wikidata: Set languageLinkSiteGroup in $wgWBClientSettings to avoid fetching SiteList object from memcached - https://phabricator.wikimedia.org/T58602#785966 (10JanZerebecki) [21:10:34] (03CR) 10Jeroen De Dauw: [C: 031] "+2 to the change thiemo made" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [21:12:24] (03CR) 10Hoo man: "I'm torn apart here... but the more I think about it, the more I think that Daniel's solution also has a point. Maybe I can make up my min" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174678 (owner: 10Adrian Lang) [21:13:50] (03CR) 10Jeroen De Dauw: [C: 032] Narrow TermSqlIndex interface to EntityId (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175803 (owner: 10Thiemo Mättig (WMDE)) [21:14:36] git shortlog -sn [21:14:38] 1610 jenkins-bot [21:14:40] 1595 jeroendedauw [21:14:43] damn you jenkins-bot! [21:15:44] (03CR) 10Jeroen De Dauw: "Rebase needed" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174992 (owner: 10Aude) [21:16:32] (03CR) 10jenkins-bot: [V: 04-1] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175760 (owner: 10Jeroen De Dauw) [21:17:22] [13WikibaseQuery] 15JeroenDeDauw comment on pull request #59 1435c644f: We needed this when we had the query entity type. Back when we thought that could happen in 2013. How wrong we where. 02http://git.io/3Jtv5A [21:18:33] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated Entity method in updateMockRepo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175762 (owner: 10Jeroen De Dauw) [21:25:44] (03CR) 10jenkins-bot: [V: 04-1] Remove broken conditional branch using a non-existing object [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175763 (owner: 10Jeroen De Dauw) [21:26:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Stop using deprecated methods in GenericEntityInfoBuilder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175756 (owner: 10Jeroen De Dauw) [21:29:54] (03CR) 10jenkins-bot: [V: 04-1] Act on TODO: rename getRevision to getRevisionId [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175744 (owner: 10Jeroen De Dauw) [21:31:07] kaldari|2: pong! ;-) [21:31:34] howdy :) [21:32:39] More specific is good if it's correct [21:32:55] So for example from landform -> mountain, building -> church, etc [21:33:20] (03CR) 10jenkins-bot: [V: 04-1] Make stuff in CachingEntityRevisionLookup private [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175823 (owner: 10Thiemo Mättig (WMDE)) [21:33:49] kaldari|2: So yes, good thing, just be careful not to make it too specific [21:34:01] And make sure proper subclass relationships are set [21:34:44] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecateds method in TestChanges [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175770 (owner: 10Jeroen De Dauw) [21:35:05] multichill: and you think it's generally OK to have both 'actor' and 'television actor' on one item? [21:35:28] If someone is only a television actor, I would probably remove actor [21:35:42] If I wouldn't be sure, I would just leave it [21:36:03] I seem to be focusing more on old buildings and art. Not so much movement in there ;-) [21:36:22] OK, cool. Would you mind leaving a breif comment to that effect in the thread? [21:37:08] multichill: In most cases, it's hard to determine if someone is 'only' a TV actor, so I would generally leave 'actor' as well I think [21:38:49] multichill: Yes, I heard about some of your efforts. Weren't you going to try to get Wikidata items created for all artworks? Did anything happen with that? [21:39:19] kaldari|2: https://www.wikidata.org/wiki/Wikidata:WikiProject_sum_of_all_paintings [21:39:44] Stuff is happening alright. Already got several museums in the Netherlands complete. Also Tate is being imported, some stuff from Sweden. [21:39:50] Sarah is working on some museums in the USA [21:40:06] awesome! [21:40:12] The Rijksmuseum was so kind to send me their list of painters todo, so I'm playing around at https://www.wikidata.org/wiki/User:Multichill/Rijksmuseum_creators [21:42:21] kaldari|2: Something else, did you figure out how to filter out Phabricator emails? [21:42:34] For some reason my rule doesn't seem to work [21:45:35] multichill: Not yet, my inbox is full of them. You could probably filter on [Maniphest] in the subject for most of them [21:45:59] hey [21:46:02] anybody knows a good way to find out how many entities is in wikibase? [21:46:10] I now switched to if $header_Return-path: contains "no-reply@phabricator.wikimedia.org" [21:46:27] SMalyshev: Database query? [21:46:55] multichill: which database and how I could access it? [21:47:12] Your Wikibase instance [21:47:23] Or are you talking about Wikidata? [21:47:27] Wikibase != wikidata [21:48:50] no, I mean the one in wikidata.org [21:50:59] SMalyshev: I think https://tools.wmflabs.org/wikidata-todo/stats.php will answer your question [21:51:37] multichill: thanks [22:09:00] 3Wikimedia-Wikidata: ota language displays as ltr on Wikidata - https://phabricator.wikimedia.org/T75317#786171 (10Amire80) 5Open>3Resolved a:3Amire80 Added ota to ULS. [23:27:37] 3MediaWiki-extensions-WikidataClient, Wikidata, Scrum-of-Scrums, MediaWiki-Core-Team: Set languageLinkSiteGroup in $wgWBClientSettings to avoid fetching SiteList object from memcached - https://phabricator.wikimedia.org/T58602#786525 (10bd808)