[00:04:31] alright, phabricator appears open again [00:07:25] aude: wouldn't rely on it that much right now tbh [00:07:48] aaaa [00:07:53] it was only up temp for some testing [00:07:58] :D [00:08:52] the "similar task" thing is nice :) [00:12:19] aude: https://etherpad.wikimedia.org/p/bugscratchpad [00:12:28] phab doesn't work for me [00:17:33] Now phab works for me [00:20:41] it's on and off [00:21:03] andre says we should not use it, yet :/ [00:21:28] when it's ready there'll be an announcement. :) [00:22:55] sorry. things are a bit messy currently. still more cleanup work to do. [00:23:06] but generally looks good. [00:24:37] yay :) [00:24:58] How do I reference phab in commits, btw? :P [00:25:18] how do i mark a task as a blocker for another? :) [00:25:36] hoo: Bug: T### [00:25:56] Makes sense [00:26:03] * GPHemsley glances questioningly at Vogone [00:26:26] !nyan [00:26:26] ~=[,,_,,]:3 [00:26:35] hoo: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Auto-linking_and_cross-referencing [00:27:00] aude, "Blocked by" in the task being blocked. Only works in one direction, cannot be expressed in the "blocking" task :-/ [00:27:10] andre__: ok [00:28:23] and I'm being redirected to MW.o again [00:30:34] hoo, yes, that is intended :D [00:30:40] we were testing some redirects [00:31:04] from old BZ, was harder to do in labs [00:31:09] but still smaller stuff in Phab to sort out [00:31:32] and we don't want to open completely yet and get flooded by questions because we're all pretty tired and need some rest IMO. [00:31:47] * andre__ probably way too open and honest on the interwebs, his old problem [00:32:17] that makes sense to me... but also blocks my work a little [00:32:21] hoo: you have still not pointed me to the Statement code in WB.git that needs the change in DM [00:32:43] you're all too active on a late Sat night :) [00:32:52] Gerrit being down earlier today didn't block you? :D [00:33:07] andre__: No, I was procrastinating back then :D [00:33:11] haha [00:33:21] JeroenDeDauw: You mean the Claim stuffs? [00:33:26] I can only offer http://etherpad.wikimedia.org/p/bugscratchpad for the time being for random dumps of potential bug updates [00:34:47] (03CR) 10Jeroen De Dauw: Remove usage of deprecated Entity methods (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 (owner: 10Jeroen De Dauw) [00:34:49] hoo: ye [00:34:57] hoo: also, mergee https://gerrit.wikimedia.org/r/#/c/173840/ [00:35:08] JeroenDeDauw: Well, basically everything that use these methods [00:35:16] (03PS9) 10Jeroen De Dauw: Add package definitions for each component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 [00:35:16] all that just wont work with non-Items [00:35:24] (03CR) 10Jeroen De Dauw: [C: 032] Add package definitions for each component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [00:36:53] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06propertyClaims at 146e55da4: 02http://git.io/INskcQ [00:37:15] (03PS1) 10Jeroen De Dauw: Stop using deprecated method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175314 [00:37:57] (03PS2) 10Jeroen De Dauw: Stop using deprecated method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175314 [00:42:03] JeroenDeDauw: Are you working on clearing out the Entity assumptions? Because I was looking into what it would take to create new Entities today [00:42:25] GPHemsley: I am, as I have been for months [00:42:29] Will still take some time [00:43:06] JeroenDeDauw: Wouldn't it go faster if we started implementing new Entity types and seeing what broke? ;) [00:43:16] JeroenDeDauw: Do you plan to remove all usages of these deprecated functions in a timely manner? [00:43:28] I want to have Statements on Properties soon-ish [00:46:58] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/zZ5B0g [00:46:58] 13WikibaseDataModel/06master 14fbf4f40 15Jeroen De Dauw: Update RELEASE-NOTES.md [00:47:57] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/WVbf0A [00:47:57] 13WikibaseDataModel/06master 14bb58e49 15jeroendedauw: Fix version numbers [00:48:42] hoo: unfortunately I cannot fix all design problems in our codebase, esp not if new ones get introduces all the time [00:48:54] hoo: you did see I actually merged the PR right? [00:49:11] GPHemsley: I'm not sure how that would speed things up [00:49:27] GPHemsley: it is very clear that the stuff I am fixing will be problematic [00:49:32] JeroenDeDauw: Didn't see that, thanks a lot :) [00:49:50] There will presumably be more things that break though, so at some point we'll indeed want to do taht [00:50:14] Yeah, of course [00:50:27] we mostly deferred the problem until we want more entity types [00:50:37] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #271: Implement much needed unification of interfaces (06master...06InterfaceInterface) 02http://git.io/aoPK_w [00:50:43] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06InterfaceInterface at 1431dd540: 02http://git.io/Tw7MxA [00:50:58] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #93: [WIP] Make Statement composite Claim (06master...06claim) 02http://git.io/hk1dnA [00:53:48] hoo: https://github.com/wmde/WikibaseDataModel/pull/305 [00:53:56] [13WikibaseDataModel] 15JeroenDeDauw created 06relz (+1 new commit): 02http://git.io/inFsQA [00:53:56] 13WikibaseDataModel/06relz 142ead18b 15jeroendedauw: 2.4.0 rel [00:54:43] yeah, let's do that :) [00:54:51] [13WikibaseDataModel] 15mariushoch closed pull request #305: 2.4.0 rel (06master...06relz) 02http://git.io/If4UPA [00:55:31] wmde/WikibaseDataModel/relz/2ead18b : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/41843708 [00:56:04] [13WikibaseDataModel] 15JeroenDeDauw comment on commit 14f17107b: ![fuck-your-shit](https://cloud.githubusercontent.com/assets/146040/5156226/ba379346-72b3-11e4-922d-26f598e70fba.gif)... 02http://git.io/0BafLg [00:57:03] [13WikibaseDataModel] 15JeroenDeDauw tagged 062.4.0 at 06master: 02http://git.io/LFGsUA [00:57:14] JeroenDeDauw: I don't understand. Why would the stuff you change break stuff? [00:57:59] GPHemsley: No. It will break if it is not changed [00:58:13] JeroenDeDauw: Oh, right. I know that. [00:58:58] JeroenDeDauw: I'm just saying, if you're only fixing stuff as you come across it, it'd be faster to fix things as you implement new entity types because you'd come across things faster. :) [00:59:08] wmde/WikibaseDataModel/2.4.0/66de8e0 : Marius Hoch The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41843925 [01:00:16] JeroenDeDauw: Also, I'm still trying to determine where I can help without stepping on your toes or duplicating work. :) [01:00:40] GPHemsley: Just do small changes and upload them immediately ;) [01:02:18] (03PS1) 10Jeroen De Dauw: Simplify SnakFiner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 [01:02:28] hoo: ^ :) [01:03:08] GPHemsley: I am not fixing things as I come accross them... [01:03:21] I'm not really touching the WB.git repo much ATM [01:03:24] Just to fix these issues [01:03:35] (03CR) 10jenkins-bot: [V: 04-1] Add package definitions for each component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [01:03:37] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated method [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175314 (owner: 10Jeroen De Dauw) [01:03:45] wtf jenkins? [01:04:16] GPHemsley: you can take one of the instances for which I created bugs [01:04:22] And comment there you will tackle it [01:04:29] ok [01:04:34] Process leaked file descriptors. See http://wiki.jenkins-ci.org/display/JENKINS/Spawning+processes+from+build for more information [01:04:37] uhm... what? [01:05:13] Probably random temp thing [01:05:36] (03CR) 10Jeroen De Dauw: Add package definitions for each component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [01:05:42] (03PS10) 10Jeroen De Dauw: Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 [01:05:57] (03PS3) 10Jeroen De Dauw: Stop using deprecated method. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175314 [01:07:11] (03PS6) 10Jeroen De Dauw: Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 [01:08:05] hoo: after my changes have been merged, can you have a look at not duplicating silly stuff between SnaksFinder and the lua code? [01:08:19] Also, I'm not sure there is a point in having this SnakFinder [01:08:38] Oh nvm - it has a lookup [01:08:50] Still very simple class... [01:09:05] Just looks up an entity, does an if with a 1 line body [01:09:08] 3 ELOC [01:09:35] So even with the lookup it probably does not justify itself [01:09:51] Esp since this is not polymorphically used anyway [01:10:37] * JeroenDeDauw is off for today [01:10:40] Ok [01:10:51] IMO the parser functions stuffs should be a wrapper around Lua [01:11:22] sharing code between them is kind of hard... because of the lua api [01:21:38] hoo: do we have anything to look up an EntityId for a title, w/o assumptions that title text = entityid? [01:21:57] Sure [01:22:21] WikiPageEntityStore [01:22:30] ah, ok [01:23:32] errr, don't see where [01:23:48] i have a title and want to know if it is entity content [01:24:00] if so get the entityid without loading entire content / entity [01:24:12] WikibaseRepo::getEntityTitleLookup [01:24:26] oh, I'm stupid [01:24:33] hmm, isn't that where we know the entity? [01:24:42] * aude wants the opposite [01:24:47] Yeah, just realized [01:25:15] for onLinkBegin, if we have to access entitycontent just to find out what type and the id [01:25:38] then we have the entire entity already and don't see the point of "don't load the entity" for this hook [01:26:21] maybe loading the entity can use memcached (already?) and minimize using the hook [01:27:48] aude: But the hook already checks the content model [01:28:33] that would give us the type... but not the id [01:29:44] hmm [01:30:44] (03PS6) 10Aude: Extract onLinkBegin hook handling into separate class [WIP] [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175300 [01:30:54] that's what i got so far [01:31:10] needs tests at least at this point, and then can see what next to do here [01:32:40] aude: mh... even if you were to not load the full entity to get the id... you would probably use the entity retrieving label lookup, right? [01:32:50] Because you can't batch lookup AFAIS [01:33:30] i think or maybe elastic-based something if it is efficient enough [01:34:07] or somethign [01:34:09] mh... but binding against elastic wont be pretty [01:34:14] yeah [01:34:21] (03CR) 10jenkins-bot: [V: 04-1] Simplify SnakFiner [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [01:35:27] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated method. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175314 (owner: 10Jeroen De Dauw) [01:35:31] ewk [01:35:33] master broken? [01:36:41] wfMemcKey( 'revisiontext', 'textid', $textId ); [01:36:53] so basically already using memcached in Revision? [01:36:59] (03CR) 10jenkins-bot: [V: 04-1] Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [01:37:05] not all the time, I think [01:37:27] hm [01:39:07] (03CR) 10jenkins-bot: [V: 04-1] Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [01:39:44] looks like that is actually enabled in production [01:39:46] woot [01:40:06] 'wgRevisionCacheExpiry' => array( [01:40:06] 'default' => 86400 * 7, // set back to 0 if this breaks [01:40:32] ah [01:41:30] so, i'm not sure about trying to optimize this hook too much [01:41:41] other than avoid using it, and making our code nicer + tests [01:42:00] If that code is in revision, and it's active in production... why do we cache ourselves? [01:42:07] Surely there's a reason... [01:42:08] no idea :/ [01:42:18] ask daniel [01:42:31] maybe we didn't realize? [01:42:38] Oh, that would be bad [01:42:42] yeah [01:42:50] or wouldn't work in the client? [01:42:57] unless we had the text id [01:43:20] right... so it saves us one round-trip to the repo DB in client [01:43:21] maybe [01:43:25] yeah [01:43:58] no, it doesn't [01:44:03] we do that anyway [01:45:23] (03CR) 10Aude: "looks ok at a glance" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [01:46:58] Ok, we actually do save roundtrips that way [01:47:39] All this code could be generalized to be in core [01:47:43] but that would be a lot of work [01:47:51] * aude nods [01:53:18] (03PS2) 10Hoo man: Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 [01:53:50] aude: ^ that's a follow-up to a change of yours from last year :P [01:54:24] (03CR) 10Hoo man: "Manually rebased" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [01:55:49] (03CR) 10Hoo man: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [01:56:43] - Updating wikibase/data-model (2.3.0 => 2.4.0) [01:56:45] :) [01:57:25] wow [01:57:38] That has getClaims etc. on Property :) [01:58:58] aude: Are there any other blockers from statements on properties? [01:59:20] meh, can't even look that up in BZ now [01:59:20] setClaims? [01:59:29] aude: That's in there [01:59:29] think we got most, afaik [01:59:39] no idea [01:59:52] \o/ [02:00:07] Property has all the *Claims methods Item has now [02:00:14] all deprecated, of course... but they work [02:00:16] yay [02:00:47] * aude see if my property has statements now [02:00:54] Mine has :) [02:02:33] don't see them (but have 2.4.0) [02:03:01] action=wbgetclaims&entity=P2 empty [02:03:29] index.php?title=Property%3AP2&diff=5620&oldid=4455 not empty [02:04:24] yeah, that's weird [02:04:31] the API is broken for me as well [02:04:34] but entityview works [02:04:48] not for me [02:04:56] tried purging [02:05:11] I'm an idiot [02:05:14] both works fine for me [02:05:21] I just had the wrong property id [02:05:44] /wiki/repowiki/api.php?action=wbgetclaims&entity=P13 [02:05:47] just like that [02:13:28] * aude delete vendor and clone again [02:13:40] sometimes that's needed... [02:15:42] (03CR) 10Hoo man: [C: 032] Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 (owner: 10Jeroen De Dauw) [02:16:23] (03CR) 10jenkins-bot: [V: 04-1] Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [02:16:29] meh [02:16:33] works now :) [02:17:06] Awesome :) [02:17:30] problem is i had data model as a dependency of my elastic search thing [02:17:51] suppose i can put it in my "build" instead [02:18:47] (03PS3) 10Hoo man: Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 [02:19:58] (03CR) 10Hoo man: "Fixed double use of DeletePageNoticeCreator (crept in through the rebase)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [02:23:09] aude: CachingFileSiteStore [02:23:14] shouldn't that be read only? [02:23:40] Seems more sane... and you can't write to the file anyway (at least in wMF production) [02:23:46] it's going to be owned by mwdeploy [02:24:22] ewk, SiteStore demands you to have these methods, I see [02:27:55] we could extract into another caching layer [02:28:32] i don't like the write methods, although i use them in the script [02:30:18] so we can have a SiteLookup? [02:30:42] SitesLookup or so, yeah [02:30:49] way better than ReadOnlySitesStore [02:30:53] * hoo bad at naming [02:30:56] sure :) [02:31:37] i would also like to defer deserialization of all the sites in sitelist [02:31:39] but not in this patch [02:31:52] when we only need, say 5 of the 888 [02:32:05] or whatever number [02:32:15] you could do that for lookups by global id, I guess [02:32:18] yes [02:33:47] alright, left a -1 to fix these [02:35:35] i'll probably have some time tomorrow and monday morning to work on it more [02:35:46] or if someone else wants to amend, ok with me [02:36:01] Not today... 3:30 :S [02:36:04] ok [02:36:07] (03Merged) 10jenkins-bot: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 (owner: 10Jeroen De Dauw) [02:36:07] But I'll do some more code review [02:36:11] great [02:36:23] * aude still jet lagged, so is tired [02:37:53] I have to get up early on Monday to go to Berlin... will be painful :P [02:39:43] :/ [02:44:53] (03CR) 10Hoo man: [C: 032] Set "wpUndidRevision" hidden field in EntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174283 (https://bugzilla.wikimedia.org/73562) (owner: 10Legoktm) [02:44:59] (03CR) 10Aude: Rename MovePageNotice to MovePageNoticeCreator (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [02:45:02] :o [02:45:13] (03CR) 10Hoo man: [C: 032] "Looks sane, manually tested" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174836 (owner: 10Thiemo Mättig (WMDE)) [02:45:31] hoo: thanks :D [02:45:41] You're welcome :) [02:45:44] hoo: shouldn't you be sleeping? [02:45:44] Order all the things? [02:45:56] legoktm: ehmm... maybe ... [02:46:17] hoo: else thiemo will :P [02:46:22] That's true :D [02:46:26] Let me quickly amend [02:46:30] ok [02:46:34] otherwise looks good [02:48:17] (03PS4) 10Hoo man: Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 [02:48:26] (03CR) 10Hoo man: Rename MovePageNotice to MovePageNoticeCreator (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [02:49:19] (03CR) 10Hoo man: "https://upload.wikimedia.org/wikipedia/commons/6/6a/Sorting_quicksort_anim.gif sort all the things :D" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [02:49:32] gerrit should really allow inline images... [02:49:38] :D [02:49:53] those gifs just look very satisfying :D [02:50:15] (03CR) 10Aude: [C: 032] "looks good :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [02:52:00] (03PS2) 10Hoo man: Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [02:53:03] (03CR) 10Hoo man: [C: 032] "Hope jenkins approves" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [02:53:47] (03PS11) 10Hoo man: Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [02:53:58] (03CR) 10Hoo man: [C: 032] "Per Jeroen" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [02:54:43] poor jenkins [02:54:58] (03PS7) 10Hoo man: Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [02:57:36] (03CR) 10Hoo man: [C: 04-1] "This patch would break formatting statements on properties for no apparent reason." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [02:57:56] and that's why i put a lot of drafts on gerrit.... rm -Rf of vendor seems to wipe out git history wikibase also [02:58:10] no worries [02:58:33] so you check out wikibase via composer as well? [02:58:41] Guess I need to do that as well, next week [02:58:45] prefer-source [02:58:48] using the buidl [02:58:50] build* [02:58:51] yeah :/ [02:58:57] but not a fan of that for main development [02:59:02] ok for testing the build, though [02:59:12] build resources thing (what vagrant does) [02:59:37] how else do you work with the property suggester etc? [02:59:59] on this wiki? I simply don't [03:00:11] ah [03:00:31] * aude probably the only one that has it enabled [03:00:36] my testing setup is to complex... it always gets worse after some time [03:00:41] :/ [03:00:59] Guess I need to get myself one or two hours this week to straighten up stuff [03:01:17] when we split everything, yes [03:01:31] for me, it's update build resources and then done [03:01:49] and resubmit drafts if i care [03:02:13] Wikibase]$ git branch | wc -l [03:02:13] 356 [03:02:22] wow... most of them are probably garbage [03:03:58] (03PS2) 10Hoo man: Make wikibase-labelview block level direction aware [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174296 (owner: 10Ebrahim) [03:04:12] for such pages, I wish to know an RTL language... [03:04:16] * patches [03:04:30] Such mistakes are signs of me being tired... [03:14:41] (03CR) 10jenkins-bot: [V: 04-1] Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [03:14:43] (03CR) 10jenkins-bot: [V: 04-1] Set "wpUndidRevision" hidden field in EntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174283 (https://bugzilla.wikimedia.org/73562) (owner: 10Legoktm) [03:14:45] (03CR) 10jenkins-bot: [V: 04-1] Rework and drop unused code from EditEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174836 (owner: 10Thiemo Mättig (WMDE)) [03:14:49] oh ffs [03:14:51] aww [03:16:03] * aude thinks there is a bug in the "other languages" editing [03:16:22] can you be more specific? [03:16:41] i have "iiii" as my en label, "gggg" as german, and something arabic for arabic [03:16:45] now.... [03:16:56] Q677?uselang=de [03:17:17] "gggg" is german? [03:17:23] "iiii" is en [03:17:29] click edigt [03:17:37] english becomes arabic [03:17:45] arabic become "iiii" [03:17:57] uh, bad [03:18:06] yeah [03:18:24] today or yesterday I had a case on Wikidata where an old label was showing up in the box (until I purged) [03:18:28] i hope it's only on master but please investigate (if i don't) before makign a branch [03:18:35] we couldn't find more examples, though [03:18:47] it's getting confusing trying to edit these [03:18:54] right now the box is acting very weird for me [03:19:04] it uses data from ULS, but not the babels from my user page [03:19:28] (locally) [03:19:44] i have babels [03:19:57] now it works [03:20:09] after a zero edit to my user page [03:20:14] caching on some layer, I guess [03:24:28] (03CR) 10Hoo man: [C: 032] Make wikibase-labelview block level direction aware [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174296 (owner: 10Ebrahim) [03:24:38] Let's hope at least that merges... [03:24:52] I think the jenkins failures occur if there are to many job running in parallel [03:26:59] aude: Can't reproduce your thing offhand... does it still occur after a page purge? [03:27:00] noted the issue in the etherpad [03:27:04] it does [03:27:16] other items also [03:28:08] bam [03:28:09] clearly happens [03:28:11] saw it [03:28:35] http://snag.gy/gsaCK.jpg [03:28:51] I was able to reproduce it just now [03:29:09] ok [03:31:57] argh [03:32:13] can we reboot the wikidata jenkins or abort all jobs? [03:32:32] we control wikidata jenkins instances [03:32:45] still all workers busy [03:32:59] i don't like to touch but if needed [03:33:14] I would like to have the changes merged which I reviewed today [03:33:19] yeah [03:33:21] don't want to spent the time again [03:33:29] * spend [03:34:44] ok, rebooting one [03:34:50] see what happens [03:36:43] (03CR) 10jenkins-bot: [V: 04-1] Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [03:37:58] still seems stuck [03:38:30] which one did oyu reboot? [03:38:49] wikidata-jenkins2 [03:39:09] and tried cancelling a couple jobs [03:39:17] they don't get removed from the queue [03:39:19] I think I have shell on them now [03:39:23] let me try smth. [03:39:34] ok [03:40:22] channel 0: open failed: connect failed: No route to host [03:41:08] hoo@bastion1:~$ ping wikidata-jenkins2 [03:41:08] PING wikidata-jenkins2.eqiad.wmflabs (10.68.17.206) 56(84) bytes of data. [03:41:08] From bastion1.eqiad.wmflabs (10.68.16.5) icmp_seq=1 Destination Host Unreachable [03:42:11] is it really up? [03:42:17] maybe slow reboot? [03:42:17] (03CR) 10Aude: Stop using Claims and Entity in WikibaseLuaEntityBindings (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [03:43:11] no, you're not blind [03:43:11] wow [03:43:25] did I mess up that badly... or maybe it went missing during a rebase [03:43:39] maybe [03:44:29] hoo@wikidata-jenkins3:~$ uptime [03:44:29] 03:44:23 up 85 days, 12:47, 1 user, load average: 11.98, 11.84, 10.80 [03:44:47] i can't get into wikidata-jenkins2 (still rebooting or stuck?) [03:44:48] so rather obvious why they're acting up [03:44:55] probably totally hung [03:45:10] nfs acting up? [03:45:15] maybe [03:45:40] waiting for atop to start [03:46:05] yep, that's it [03:46:12] local storage is busy [03:46:23] "busy" [03:46:26] not really doing much [03:46:37] reboot will take ages that way [03:48:21] (03CR) 10Hoo man: Stop using Claims and Entity in WikibaseLuaEntityBindings (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [03:51:53] aude: https://ganglia.wikimedia.org/latest/graph_all_periods.php?c=Virtualization%20cluster%20eqiad&h=virt1009.eqiad.wmnet&r=custom&z=default&jr=&js=&st=1416714678&cs=11%2F23%2F2014%203%3A20&ce=11%2F23%2F2014%203%3A21&v=183.13&m=load_fifteen&vl=%20&ti=Fifteen%20Minute%20Load%20Average&z=large that's why, I guess [03:51:56] so nothing we can do [03:52:13] :/ [03:52:25] * aude not doing more today anyway [03:52:35] same here [03:52:41] will try to clean up after the mess tomorrow [03:52:54] ok [03:53:24] shall we open some sort of ticket or will they notice themselves? [03:53:47] where? [03:53:54] is rt usable? [03:54:04] bugzilla would be the place, I know [03:54:04] no idea [03:56:26] 5am... bed time [03:56:33] good night [03:56:44] :) [04:29:30] (03CR) 10jenkins-bot: [V: 04-1] Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [04:32:34] (03CR) 10jenkins-bot: [V: 04-1] Make wikibase-labelview block level direction aware [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174296 (owner: 10Ebrahim) [04:36:49] (03CR) 10jenkins-bot: [V: 04-1] Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [04:43:46] (03Merged) 10jenkins-bot: Make wikibase-labelview block level direction aware [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174296 (owner: 10Ebrahim) [06:44:48] * GPHemsley grumbles something about bug tracker migration [10:44:57] Q612 and Q613 are both Dubai, both "instance of: City" [12:39:25] edward: Q613 was incorrect, thanks to a "stupid girl". https://www.wikidata.org/w/index.php?title=Q613&diff=161925837&oldid=161672204 [12:42:56] Anyway, fiwiki article says that "Dubai is one of the emirates of the United Arab Emirates and at the same time the biggest city" [12:43:09] this is quite tricky, Q613 points to https://en.wikipedia.org/wiki/Dubai, which is about both Dubai both as a city and as an emirate [12:44:29] so the two concepts, emirate and city, have a single article on enwiki, but two items on wikidata [12:52:43] The emirate is a little bit bigger than the city. [12:55:15] (03CR) 10Aude: [C: 032] Set "wpUndidRevision" hidden field in EntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174283 (https://bugzilla.wikimedia.org/73562) (owner: 10Legoktm) [13:13:23] (03Merged) 10jenkins-bot: Set "wpUndidRevision" hidden field in EntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174283 (https://bugzilla.wikimedia.org/73562) (owner: 10Legoktm) [13:17:20] (03Merged) 10jenkins-bot: Rework and drop unused code from EditEntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174836 (owner: 10Thiemo Mättig (WMDE)) [13:59:40] Do we have a help page on Wikidata describing how to use {{#babel....}}? The only thing I find is a soft redirect to meta :-( [14:01:42] multichill: There is also something about it on https://www.wikidata.org/wiki/Wikidata:Userboxes [14:05:33] ty sjoerddebruin, but that page also needs a big of work.... [14:05:53] Yeah, documentation is a hell on Wikidata. [14:06:20] Sebastiaan made some nice documentation with me about #babel [14:06:24] We can probably reuse that [14:06:34] I've learned about the feature thanks to a personal message on my talk page: https://www.wikidata.org/wiki/User_talk:Sjoerddebruin#Babel [14:07:24] It's not very widely advertised. I think most of our users don't know abou tit [14:07:27] *about it [14:07:41] It's one of the best features. [14:08:21] * multichill agrees [14:09:29] First, let me finish the main page translation. ;) [14:18:09] Lydia_WMDE et al: Morn. To avoid potential confusion, there will be no VERIFIED status in Phabricator like there was in Bugzilla. Instead there is a "verified" project/tag that can be added to a task and also queried for (or excluded from queries). [14:25:10] sjoerddebruin: Hmm, ik zie dat https://www.wikidata.org/wiki/Wikidata:Database_reports/Constraint_violations/P359#.22Unique_value.22_violations langzaam is volgelopen met duplicaten [14:25:21] Dan zijn mensen aan het schrijven :-) [14:25:41] Jup, ik heb al wat samengevoegd de afgelopen dagen [14:26:04] Die zijn overzichtelijk en weinig kans op fouten. [14:26:17] Ik heb er net eentje ongedaan gemaakt waarbij twee verschillende rijksmonumenten waren samengevoegd [14:26:26] Was ik toch niet? :O [14:26:57] Dit is nog zo fijn.. :( https://nl.wikipedia.org/wiki/Standbeelden_van_Willem_van_Oranje_in_Den_Haag [14:27:32] sjoerddebruin: Nee, jij was het niet. Die standbeelden had ik toch opgelost? [14:27:43] Ja, maar ik zit nog met de commonscats. [14:27:51] haha [14:28:56] Ik moet maar eens de complexen gaan importeren Sjoerd, dat geeft een hoop meer structuur [14:29:04] Yes. :) [14:29:59] http://monumentenregister.cultureelerfgoed.nl/php/main.php?cAction=search&cOffset=1&cLimit=25&oOrder=ASC&cSubmit=1&sCompMonNr=521044 dit werk [15:15:52] (03CR) 10Aude: Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [15:15:59] (03CR) 10Aude: [C: 032] Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [15:16:26] (03CR) 10Aude: [C: 032] Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [15:16:58] aude: You evil merge thief :D [15:17:08] Anyway, I see someone fixed virt1009 [15:17:23] (03CR) 10Aude: [C: 032] Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [15:17:27] :) [15:20:07] So, I shall switch from windows xp to ubuntu-server for my bot work. [15:20:23] A decision that is... hmm... 5 years late. [15:24:26] ToAruShiroiNeko: Windows Xp... what the ... :P [15:24:45] I guess you were out of NT 4.0 installation disks? [15:25:08] XP [15:25:10] :D [15:27:57] hoo oh not really [15:28:05] It was strictly virtual [15:28:49] Since I hope to be more active with deving wikimedia tools, I need more resources :) [15:35:19] geez... ubuntu update takes forever [15:35:24] almost reminds me of windows :p [15:48:13] (03CR) 10jenkins-bot: [V: 04-1] Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [15:58:35] (03CR) 10jenkins-bot: [V: 04-1] Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [16:02:57] (03CR) 10jenkins-bot: [V: 04-1] Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [16:05:01] (03CR) 10Hoo man: [C: 032] Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [16:05:30] (03CR) 10Hoo man: [C: 032] Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [16:05:45] (03CR) 10Hoo man: [C: 032] "Per aude" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [16:36:57] (03CR) 10jenkins-bot: [V: 04-1] Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [16:56:31] (03CR) 10jenkins-bot: [V: 04-1] Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [16:57:01] =o [16:57:14] addshore: see -operations [17:19:09] (03Merged) 10jenkins-bot: Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [19:26:58] [13WikibaseQueryEngine] 15JeroenDeDauw created 06todo (+1 new commit): 02http://git.io/mgleGQ [19:26:58] 13WikibaseQueryEngine/06todo 14e6d7b1b 15jeroendedauw: Tackle exception type TODOs [19:30:25] wmde/WikibaseQueryEngine/todo/e6d7b1b : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseQueryEngine/builds/41894049 [19:32:25] [13WikibaseQueryEngine] 15JeroenDeDauw opened pull request #138: Tackle exception type TODOs (06master...06todo) 02http://git.io/ROP2DA [19:37:32] JeroenDeDauw: Is there a standardized way of checking for entity types yet? [19:37:45] JeroenDeDauw: I.e., what's the best way to fix OCP violations? [19:39:31] GPHemsley: this is explained on the bug if I;m not mistaken [19:39:51] JeroenDeDauw: It's hard to navigate bugs atm, but I don't think so. [19:40:02] JeroenDeDauw: e.g. https://old-bugzilla.wikimedia.org/show_bug.cgi?id=73559 [19:41:16] https://old-bugzilla.wikimedia.org/show_bug.cgi?id=73496 [19:41:36] JeroenDeDauw: Right, but that doesn't explain how to fix them, specifically. [19:42:01] JeroenDeDauw: Is there a standard extension point? [19:43:08] JeroenDeDauw: Like, for the bug I linked to, is there an existing way to say "What entities are available? " [19:44:00] JeroenDeDauw: "What class is their view? What arguments does it need?" etc. [19:45:47] What entities are available depends on the context [19:46:07] Also, having a list of types that has information more than simply what those types are is highly suspicious [19:46:38] GPHemsley: are you familiar with the SpecialPage system in MediaWiki? Or perhaps how API modules are registered? [19:47:02] JeroenDeDauw: Tangentially, yes. [19:47:25] JeroenDeDauw: Is that available yet? Or is it blocking all the rest of this work? [19:47:50] GPHemsley: in there you have list of types and names of classes that handle those types - but this does not work well, since it prevents control over object lifecycle by extensions, leading to dependency inversion issues [19:48:17] All we can really do is have a list of available handlers for different types of entities [19:48:39] We could have a map that has entity types as keys poiting to accociated handlers [19:49:02] Thought it's more flexible to delegate the association job to the handlers themselves [19:49:13] ie, give them a amITheRightHandler method [19:49:35] Ah, like MediaWiki already has [19:49:36] ? [19:50:14] No, MediaWiki generally uses the type => name of handling class approach [19:50:36] GPHemsley: also note how there does not need to be a general system for this [19:50:44] We need different handling for entities on dozens of places [19:50:46] I saw something that looped through all available handlers and asked whether it supported handling a particular type [19:50:50] maybe that was WB code [19:51:04] For instance for diffing, for patching, for storing into the QueryEngine, etc. You cannot have one big handler [19:51:38] GPHemsley: https://lists.wikimedia.org/pipermail/wikidata-tech/2014-August/000546.html [19:52:39] (03PS4) 10Jeroen De Dauw: Stop using deprecated method. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175314 [19:53:00] (03PS3) 10Jeroen De Dauw: Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 [19:53:21] JeroenDeDauw: So a separate handler for View, History, Move, ...? [19:55:23] GPHemsley: generally for each of such things you will have a class that has a list of handlers, though there can of course be exceptions [19:55:38] Also not how you do not nececerilly need a handler per entity type [19:55:51] If all existing ones are treated in the same way, you can have one handler [19:57:03] (03PS8) 10Jeroen De Dauw: Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 [19:57:49] JeroenDeDauw: So, would the first place to start for this be Wikibase.hooks.php? [19:58:27] GPHemsley: to start with what exactly? [19:58:49] JeroenDeDauw: Implementing a mechanism for supporting arbitrary entity types. [19:59:26] JeroenDeDauw: I was having trouble figuring out the first place Wikibase is informed of what types it could look at. [19:59:33] Not sure how this is related to the Wikibase.hooks.php code [19:59:47] GPHemsley: ah, ... [20:00:00] GPHemsley: we do not have a good public registration mechanism yet [20:00:08] There is no point in making this already [20:00:28] JeroenDeDauw: Even privately. It's easy to find all the classes that do this stuff, but I couldn't find where they were first instantiated. [20:00:55] GPHemsley: This is done in the top lebel factories of the respective applications [20:00:59] RepoHooks::onContentHandlerForModelID() seemed a possible candidate [20:01:05] In WikibaseRepository we have a WikibaseRepo class [20:02:04] GPHemsley: have a look in WikibaseRepo [20:02:08] Method getEntityIdParser [20:02:22] The EntityIdParser should be able to handle all types of entity ids [20:02:33] So extensions might need to add a new handler for it [20:03:00] So if we have code that constructs an ID parser itself, we likely have an OCP violation [20:03:36] If the code instead requires an id parser in its constructor, and the class in question gets constructed via the factory, then the "issue" gets pushed to the factory [20:03:46] Where we can then eventually add a regsiteration system [20:04:29] So once these issues are generally fixed, we'll have a way to provide EntityId builders that the getEntityIdParser method can use [20:06:25] OK, a few questions: [20:06:44] Is getEntityIdParser() currently constructing an ID parser itself? [20:07:06] (03PS12) 10Jeroen De Dauw: Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 [20:07:11] Does getEntityIdParser() know what kind of IdParser it's looking for? [20:07:24] Which factory are we talking about here? [20:08:34] JeroenDeDauw: ^ [20:11:53] GPHemsley: getEntityIdParser is supposed to return an implementation of the EntityIdParser interface that can handle IDs for all types of entities the system knows about [20:13:25] JeroenDeDauw: So if there was a method called registerIdParser(), where would it live? [20:14:03] (03PS9) 10Jeroen De Dauw: Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 [20:14:36] GPHemsley: the factory (WikibaseRepo) [20:14:40] Or something near it [20:15:00] Something near the application entry point and part of the dependency graph construction [20:15:25] Adding a ton of registration methods and extra state to the factory is going to be a mess [20:15:34] So it will probably be reworked in some form [20:15:42] I have not rally thought about how yet [20:15:55] Since it does not affect fixing the core of the problem we have [20:16:47] JeroenDeDauw: So what we need first is a method for an entity to say "This is my EntityId parser"? [20:17:34] No... [20:18:01] I pointed to the getEntityIdParser method as an example of a place where we fixed the problem as far as it makes sense for now [20:18:55] ah, so this is the Current Right Way™? [20:19:57] Yes [20:20:24] GPHemsley: you will probably need to do something like this https://github.com/wmde/WikibaseDataModel/commit/c5f2f1942036c4412c3962b6c82afd7908ea7eaf [20:20:34] Which is esentially what was described in the email linked earlier [20:21:44] (03PS10) 10Jeroen De Dauw: Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 [20:21:52] JeroenDeDauw: So is EntityView a candidate for this? [20:23:31] (03CR) 10jenkins-bot: [V: 04-1] Stop using deprecated method. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175314 (owner: 10Jeroen De Dauw) [20:25:52] JeroenDeDauw: Maybe you can answer my question from here? https://old-bugzilla.wikimedia.org/show_bug.cgi?id=67238 [20:26:29] two separate things [20:26:50] (03CR) 10jenkins-bot: [V: 04-1] Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 (owner: 10Jeroen De Dauw) [20:28:25] Tobi_WMDE_SW_NA: Lydia_WMDE: Jenkins appears to be broken :<0 [20:29:01] GPHemsley: I got to run now. Can you send an email to the wikidata tech list? [20:29:06] Sure [20:36:22] (03CR) 10jenkins-bot: [V: 04-1] Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [21:03:17] Not sure if that was the expected contents of the e-mail, but e-mail sent. [21:31:30] GPHemsley: I don't see any pictures in your email... so in case you wanted to address JeroenDeDauw, you failed :D [23:51:17] (03PS13) 10Jeroen De Dauw: Add package definitions for each component. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 [23:51:18] (03PS4) 10Jeroen De Dauw: Simplify SnakFinder [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175316 [23:51:21] (03PS5) 10Jeroen De Dauw: Stop using deprecated method. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/175314 [23:51:23] (03PS11) 10Jeroen De Dauw: Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 [23:59:56] hoo: I didn't think the mailing list would accept pictures