[01:11:19] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06languageFallBack from 148de82c1 to 1463c2cd6: 02http://git.io/0KqFLw [01:11:19] 13WikibaseDataModelSerialization/06languageFallBack 1463c2cd6 15Jan Zerebecki: Support TermFallback and AliasGroupFallback. [01:12:15] wmde/WikibaseDataModelSerialization/languageFallBack/63c2cd6 : Jan Zerebecki The build is still failing. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/41669183 [01:49:27] (03CR) 10Addshore: Optimize all use sections in Repo (0313 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [01:57:20] (03CR) 10Addshore: [C: 032] Remove unused use clauses and fix typo in a class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174842 (owner: 10Thiemo Mättig (WMDE)) [01:57:55] and there's my merge conflict :D [01:59:21] (03CR) 10Addshore: [C: 032] Small clean ups in Changes related code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174848 (owner: 10Thiemo Mättig (WMDE)) [02:13:13] (03Merged) 10jenkins-bot: Remove unused use clauses and fix typo in a class name [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174842 (owner: 10Thiemo Mättig (WMDE)) [02:15:19] (03Merged) 10jenkins-bot: Small clean ups in Changes related code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174848 (owner: 10Thiemo Mättig (WMDE)) [02:18:17] (03PS3) 10Aude: Factor out property link formatting from view code [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174750 [08:42:38] Hi, for my own Wikidata repository to work on my third party wiki, do I need to set site_source in sites table to local on the repository database and to the database name of the repository in the client databases? [08:45:08] (03CR) 10Henning Snater: [V: 04-1] "I am not sure whether that is an actual bug since the behviour was actually intended (there should always be an empty input at the end). Y" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172510 (owner: 10Adrian Lang) [11:46:06] (03PS15) 10Daniel Kinzler: Introduce PageTerms API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [11:46:26] (03CR) 10Daniel Kinzler: Introduce PageTerms API module (038 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [11:55:18] Greeting, I've been unable to login to wikidata for two days, the page returns an error 503 after waiting for a while, i've got confirmations that other users are able to login (in this room) ... [11:55:41] I'm not sure what i can do ... [11:58:39] (03CR) 10jenkins-bot: [V: 04-1] Introduce PageTerms API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [12:00:48] (03PS5) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) [12:00:54] (03PS7) 10Daniel Kinzler: Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) [12:00:59] (03CR) 10jenkins-bot: [V: 04-1] Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [12:01:07] (03CR) 10jenkins-bot: [V: 04-1] Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [12:13:51] (03CR) 10Daniel Kinzler: "I'm unable to reproduce the test failure locally. Can anyone tell me what the problem is?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [12:33:24] (03PS8) 10Daniel Kinzler: Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) [12:47:40] (03CR) 10jenkins-bot: [V: 04-1] Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) (owner: 10Daniel Kinzler) [12:51:00] (03PS6) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) [12:57:14] (03PS7) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) [12:59:00] (03PS9) 10Daniel Kinzler: Filter page purged by usage aspect. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167856 (https://bugzilla.wikimedia.org/71352) [12:59:15] (03PS8) 10Daniel Kinzler: Determine update actions based on usage aspects. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170961 (https://bugzilla.wikimedia.org/71352) [14:34:30] (03CR) 10Anomie: Introduce PageTerms API module (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [14:34:54] (03CR) 10Anomie: "API code seems sane now, haven't tested." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [14:49:50] [13WikibaseDataModel] 15thiemowmde comment on pull request #272 146bc3f07: Add the `= null` at the end? 02http://git.io/T46sng [14:51:00] [13WikibaseDataModel] 15JanZerebecki 04force-pushed 06languageFallBack from 146bc3f07 to 147a384c8: 02http://git.io/Fm47wA [14:51:00] 13WikibaseDataModel/06languageFallBack 14ae74a5a 15Jan Zerebecki: Add TermFallBack. [14:51:00] 13WikibaseDataModel/06languageFallBack 147a384c8 15Jan Zerebecki: Add AliasGroupFallback. [14:52:01] [13WikibaseDataModel] 15thiemowmde comment on pull request #272 147a384c8: Is it worth checking for empty strings? Out of scope of this patch, just asking. 02http://git.io/FM-CMw [14:52:56] [13WikibaseDataModel] 15thiemowmde comment on pull request #272 147a384c8: `= null`, as below. 02http://git.io/p_lVaw [14:53:37] [13WikibaseDataModel] 15thiemowmde comment on pull request #272 147a384c8: Not a problem, just wondering why the coding style in this class (private setters) is so different from the other (no private setters). 02http://git.io/d1LdCg [14:57:36] [13WikibaseDataModel] 15addshore pushed 1 new commit to 06master: 02http://git.io/CGutWA [14:57:36] 13WikibaseDataModel/06master 140cc99c4 15addshore: Merge pull request #303 from wmde/optimize... [14:59:22] [13WikibaseDataModel] 15addshore 04deleted 06scrutIssues at 1408f9d52: 02http://git.io/LJ1E_A [15:00:01] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 147a384c8: For the language codes I would say we should either fully validate them (against a list of codes we support) or not. 02http://git.io/GDU7Uw [15:01:03] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 147a384c8: No functional difference. 02http://git.io/sEIpVw [15:02:08] [13WikibaseDataModel] 15JanZerebecki comment on pull request #272 147a384c8: The intention was to make it explicit when you have no source, instead of being accidental. 02http://git.io/mDBWIQ [15:05:51] [13WikibaseDataModel] 15thiemowmde 04deleted 06sl at 14ed7c166: 02http://git.io/l0UWOg [15:07:08] [13WikibaseDataModel] 15thiemowmde comment on pull request #272 147a384c8: I see. Agreed. 02http://git.io/rhufbQ [15:15:12] (03CR) 10Thiemo Mättig (WMDE): Small clean ups in Changes related code (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174848 (owner: 10Thiemo Mättig (WMDE)) [15:23:09] (03CR) 10Thiemo Mättig (WMDE): "Addshore, every single change you are complaining about is made on purpose as described in the commit message." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [15:40:45] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #97 1463c2cd6: Spaces missing. 02http://git.io/kteFdg [15:41:25] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #97 1463c2cd6: I miss a test for this exception. 02http://git.io/5r3voQ [15:43:04] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #97 1463c2cd6: A lot of these changes are from the DataModel 2 switch and should have been done in an other pull request. Would be much easier to review then. 02http://git.io/g3MTaw [15:43:50] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #97 1463c2cd6: This seems wrong. Don't we need to serialize all 3 language codes, not just 2? 02http://git.io/QptG-Q [15:44:04] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #97 1463c2cd6: Same here. 02http://git.io/Xnfy5g [15:45:09] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #97 1463c2cd6: Is there a test with numeric array keys? Should not fail. 02http://git.io/z1gqDQ [15:46:04] [13WikibaseDataModelSerialization] 15thiemowmde comment on pull request #97 1463c2cd6: Same here. 02http://git.io/SBrHHQ [15:52:53] (03CR) 10Addshore: [C: 04-1] "I dont know what version you are using but on 8.0.1 I see no problem with the way it currently is." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [15:55:41] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Disable remove button when entered site link is invalid [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173281 (owner: 10Henning Snater) [16:03:19] (03PS8) 10Henning Snater: Rearranged site link views [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 [16:13:52] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 1463c2cd6: No that worked just fine and was not deprecated. I just can't get to the actual object with the previous version. 02http://git.io/kwG0Kw [16:15:03] [13WikibaseDataModelJavaScript] 15snaterlicious created 06documentation (+1 new commit): 02http://git.io/RmwcfQ [16:15:03] 13WikibaseDataModelJavaScript/06documentation 14eb3ae1a 15snaterlicious: Updated code documentation... [16:16:22] [13WikibaseDataModelJavaScript] 15snaterlicious opened pull request #20: Updated code documentation (06master...06documentation) 02http://git.io/TdMZ0A [16:16:42] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 1463c2cd6: There are 3: The key (requested), 'language' (actual) and 'source'. This serialization format matches the current serialization done in Wikibase.git . 02http://git.io/fkaP7A [16:21:49] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 1463c2cd6: The tests for this are named '* fallback language term', one for each of label, description, alias. 02http://git.io/pK9-5A [16:39:42] [13WikibaseDataModelSerialization] 15JanZerebecki 04force-pushed 06languageFallBack from 1463c2cd6 to 1477a3794: 02http://git.io/0KqFLw [16:39:42] 13WikibaseDataModelSerialization/06languageFallBack 14e5f9c16 15Jan Zerebecki: Require new data-model version for language fallback. [16:39:42] 13WikibaseDataModelSerialization/06languageFallBack 1477a3794 15Jan Zerebecki: Support TermFallback and AliasGroupFallback. [16:39:54] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 1477a3794: Done. 02http://git.io/WSAx-Q [16:40:17] [13WikibaseDataModelSerialization] 15JanZerebecki comment on pull request #97 1477a3794: Done. 02http://git.io/DowLqw [16:45:40] wmde/WikibaseDataModelSerialization/languageFallBack/77a3794 : Jan Zerebecki The build has errored. http://travis-ci.org/wmde/WikibaseDataModelSerialization/builds/41733015 [17:37:41] (03CR) 10JanZerebecki: [C: 04-1] "Looks good. Needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 (owner: 10Thiemo Mättig (WMDE)) [17:47:18] Lydia_WMDE: The "select statement with keyboard"-bug is back. [17:54:36] Lydia_WMDE: Ok, who broke coordinate formatting? :-( [17:54:37] https://www.wikidata.org/w/index.php?title=Q1065414&diff=51320492&oldid=50107170 [17:54:49] 0°0'NFF"N, 0°0'NFF"E [17:55:17] Does anyone else see the same output for ^^ ? [17:55:24] Yes. [17:56:10] Nice, can't file bugs [17:56:22] all the rage [17:56:23] I have two bugs atm... [17:56:36] multichill: file a bug about it? [17:56:41] https://bugzilla.wikimedia.org/show_bug.cgi?id=68443 is also happening again. [17:57:27] "is not quite down computing the latest value." [17:57:34] I shouldn't be allowed to use Language... [18:00:14] But anyway, the other bug is much more annoying but I can't find the bug report from the last time anymore. [18:53:32] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14eb3ae1a: That's odd. In the subclasses this is a string. I think this must be `{string|null}`. 02http://git.io/NDe1iw [18:56:31] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14eb3ae1a: I don't think the bit about a `MultiTermMap ` is correct. 02http://git.io/a0oi_g [18:56:49] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14eb3ae1a: `aliases` is not optional as far as I can see. The `languageCode` is. 02http://git.io/rBO1zg [18:58:29] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14eb3ae1a: Why not keep the `@see`? 02http://git.io/2nleAA [18:58:59] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14eb3ae1a: As above. 02http://git.io/s-b1wg [19:01:19] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14eb3ae1a: As above. 02http://git.io/osoPdg [19:03:44] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14eb3ae1a: As before, why not `{string}`? Null may be the initialization, but the type is always string when using this. 02http://git.io/xGgjHg [19:05:18] [13WikibaseDataModelJavaScript] 15thiemowmde comment on pull request #20 14eb3ae1a: I think there are tags to mark a `@namespace` or something. 02http://git.io/vOoMpg [19:14:32] (03PS5) 10Thiemo Mättig (WMDE): Unify top factory getter implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 [19:17:08] (03PS8) 10Thiemo Mättig (WMDE): Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [19:42:06] (03CR) 10jenkins-bot: [V: 04-1] Unify top factory getter implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 (owner: 10Thiemo Mättig (WMDE)) [19:47:44] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [20:18:38] (03CR) 10Daniel Kinzler: Introduce PageTerms API module (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [20:19:51] (03CR) 10Daniel Kinzler: Introduce PageTerms API module (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [20:31:07] (03CR) 10Daniel Kinzler: "Thanks for doing all the cleanup!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 (owner: 10Thiemo Mättig (WMDE)) [20:31:34] (03PS7) 10Daniel Kinzler: Introduce EntityInfo class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [22:33:43] where do I send a merge request? [22:33:56] I can't find that page... [22:35:23] Q18374762 and Q3171056 should be merged [22:36:13] dennyvrandecic: Special:MergeItems [22:36:56] thanks [22:37:05] and thanks for not making snarky comments [22:41:26] (03CR) 10MaxSem: Introduce PageTerms API module (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [22:47:58] Can we do something about this? When people link pages (when no item exists yet) with a category on Commons the label gets "Category:" in front of it. https://www.wikidata.org/w/index.php?title=Q18043213&oldid=157526792