[00:30:50] 3MediaWiki extensions / 3WikidataClient: Set languageLinkSiteGroup in $wgWBClientSettings to avoid fetching SiteList object from memcached - 10https://bugzilla.wikimedia.org/56602#c17 (10Aaron Schulz) Can we just have a current version hash stored in memcached and used to validate server-local CDB caches (ma... [00:37:20] Can I, and if so, what do I do in order to make a bot that puts the USGS earthquakes into wikidata? (Socially, not technically.) [00:48:54] hoo: You seem to know these things :) [00:49:24] That data is PD? [00:49:32] Given it's from the US gov. it probably is [00:50:20] but beyond that, I'm not sure such an even would automatically be notable (well, it would probably be, because our Notability is a bit awry atm) [00:50:46] but I'm not sure people would like having such items all the time (for every earthquake... or even for every earthquake with a threshold above n) [00:51:09] Just some thoughts... hope I understood your proposal [00:52:56] Oh, there's still the concept of notable on wikidata? [00:53:15] It would be nice if wikidata was the place to go for $data. [00:53:55] well, data needs maintenance [00:54:37] hoo: Yes, but data about the earthquakes in this example are unlikely to change. [00:55:10] Well, yeah... earthquake-data doesn't change after maybe a few days [00:55:48] " [00:55:48] It refers to an instance of a clearly identifiable conceptual or material entity. The entity must be notable, in the sense that it can be described using serious and publicly available references. If there is no item about you yet, you are probably not notable. [00:55:48] " [00:55:57] that would make that notable, probably [00:56:18] but you should really have a discussion (you need that for the bot request anyway) [00:56:33] and I doubt people will like it much... eg. I don't really see the benefit [00:59:24] hoo: EdSaperia___ has an idea for a news feed using wikidata, but there are only a couple of deaths per day at the moment. [00:59:40] I see [00:59:51] is that related to the thing about replacing main pages? [00:59:52] hoo: So if we can get more newsy stuff into wikidata... [00:59:57] yeah [01:00:12] Replacing the main page? :o [01:00:43] It could replace the news on the main page I suppose. [01:00:57] well, or be an alternative like Wikimedia entry point [01:01:13] I'm someone who likes to just read random stuff for hours, so I like such stuffs :P [01:09:42] hoo: Well, his idea is for it to be not so random. At the moment though, due to lack of data, you can't pull anything newsworthy out, because there is nothing newsworthy in :( [01:10:43] that's true... item's about recent events will only pop up after there has been a Wikipedia article [01:11:16] maybe stuff coming from Wikinews is better [01:11:25] no idea how active Wikinews is [01:12:21] hoo: https://tools.wmflabs.org/cluestuff/wdt/onthisday.cgi?date=2014-11-17 [01:13:47] hoo: If news agencies can use bots to write articles, there's no reason why we shouldn't be able to use their sources to push the data directly into wikidata. [01:14:21] Surely wikidata should be mostly bots, not humans? [01:14:56] Problem is that these things tend to create data that is going to bit rot [01:17:24] Facts that have happened don't change too much, do they? [01:17:56] they usually don't [01:18:37] Current affairs might be a different story, but I don't see a reason why not to import the aforementioned. [01:20:23] but when is stuff finished? Who is going to maintain that for ongoing events, ... [01:20:45] I'm not saying we can't do that... just saying that this needs a careful discussion [01:21:02] Anyway... I should really go to bed now. [01:40:22] (03CR) 10Hoo man: Apply page deletions to the repo (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [01:42:00] (03PS5) 10Hoo man: Apply page deletions to the repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) [01:42:34] (03CR) 10Hoo man: "Addressed Jeroen's comment." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [01:47:33] (03PS6) 10Hoo man: Apply page deletions to the repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) [01:49:37] (03PS7) 10Hoo man: Apply page deletions to the repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) [01:51:17] (03CR) 10Hoo man: "Fixed... I forgot to git add all my changes and then wont on doing over things, so it took me a bit to clean up the mess." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [01:55:59] (03PS1) 10Hoo man: Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 [01:56:08] (03CR) 10jenkins-bot: [V: 04-1] Rename MovePageNotice to MovePageNoticeCreator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [01:56:49] (03CR) 10Hoo man: "See also https://gerrit.wikimedia.org/r/174052" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [01:57:54] (03CR) 10Hoo man: "Will rebase this after the dependency has been merged." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174052 (owner: 10Hoo man) [03:11:15] JeroenDeDauw: Thanks. I'll be investigating various items over the coming days. It can be difficult, though, we all the interconnected code. [03:11:20] s/we/with/ [08:13:50] (03CR) 10Henning Snater: [C: 032] Only start first sitelinkview's edit mode if no other is in viewport [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173774 (owner: 10Adrian Lang) [08:19:07] (03Merged) 10jenkins-bot: Only start first sitelinkview's edit mode if no other is in viewport [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173774 (owner: 10Adrian Lang) [08:37:23] (03CR) 10Henning Snater: [C: 031] "Just wondering whether that should be in the wikibase.utilities scope." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172968 (owner: 10Adrian Lang) [08:45:38] (03CR) 10Adrian Lang: "Sounds plausible. I can do that in a follow-up :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172968 (owner: 10Adrian Lang) [09:11:08] (03PS1) 10Adrian Lang: Add missing inclusion of resource definition file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174073 [09:11:13] Henning_WMDE: ^ [09:12:32] (03CR) 10Henning Snater: [C: 032] Add missing inclusion of resource definition file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174073 (owner: 10Adrian Lang) [09:12:34] (03CR) 10Adrian Lang: "Broke stuff; fixed it in Icb8ae5550d08f1528adab95fa7e9dbc5a7559ac3." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172736 (owner: 10Adrian Lang) [09:18:11] (03CR) 10Adrian Lang: [C: 032] Apply page deletions to the repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [09:19:45] Adrian_WMDE: https://github.com/wmde/WikidataBrowserTests/pull/30 [09:19:49] merge? [09:19:51] :D [09:20:00] Reviewing that currently [09:20:26] \o/ very similar to what was done for the rank selector [09:20:31] (03Merged) 10jenkins-bot: Add missing inclusion of resource definition file [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174073 (owner: 10Adrian Lang) [09:24:17] (03Merged) 10jenkins-bot: Apply page deletions to the repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [09:28:36] (03PS13) 10Adrian Lang: Introduce PageTerms API module [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [09:29:47] (03PS3) 10Adrian Lang: Move UpdateRepo hook handlers into a dedicated class [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [09:30:51] (03CR) 10Adrian Lang: [C: 032] Remove not needed variable assignment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173816 (owner: 10Jeroen De Dauw) [09:31:25] (03CR) 10Adrian Lang: [C: 032] Update type hint in interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173815 (owner: 10Jeroen De Dauw) [09:31:40] (03CR) 10Adrian Lang: [C: 032] Remove dead ref in comment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173814 (owner: 10Jeroen De Dauw) [09:35:11] (03PS1) 10Adrian Lang: Fix editing of empty sitelinklistviews [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174077 [09:41:56] (03CR) 10Henning Snater: [C: 032] Fix editing of empty sitelinklistviews [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174077 (owner: 10Adrian Lang) [09:47:41] (03Merged) 10jenkins-bot: Remove not needed variable assignment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173816 (owner: 10Jeroen De Dauw) [09:47:44] (03Merged) 10jenkins-bot: Update type hint in interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173815 (owner: 10Jeroen De Dauw) [09:49:23] (03Merged) 10jenkins-bot: Remove dead ref in comment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173814 (owner: 10Jeroen De Dauw) [09:50:22] (03Merged) 10jenkins-bot: Fix editing of empty sitelinklistviews [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174077 (owner: 10Adrian Lang) [10:15:30] (03PS1) 10Adrian Lang: Move tipsy images to jquery.wikibase-shared [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174084 [10:16:12] (03PS1) 10Henning Snater: Optimized sticknode mechanisms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174085 [10:24:16] Hello, I tried to install Wikibase and I have the error JS : Refused to execute script from 'https://en.io.datascience-paris-saclay.fr/w/api.php?callback=jQuery111107420199392363429_1416306133780&search=M&action=opensearch&_=1416306133781' because its MIME type ('text/html') is not executable, and strict MIME type checking is enabled. [10:24:37] An idea ? [10:47:37] Karima: if you load that URL in your browser, you can see the underlying cause: [10:48:02] "code": "readapidenied", [10:48:03] "info": "You need read permission to use this module", [10:48:24] hm... or maybe it's just me who gets this error, because the wiki is private and i'm not logged in. in that case, i can't really help [10:49:02] DanielK_WMDE_ : I have also this error [10:49:20] Problem between json or jsonp ? [10:49:27] Karima: then I suppose the wiki is private and you are not logged in [10:50:18] jsonp just causes the subsequent error about the mime type, because the error isn't json, it's json-as-html. [10:50:39] (not sure why that is... but that's another issue) [10:50:51] try to resolve the permission/login problenm, then see whether the jsonp call works [10:51:13] DanielK_WMDE_ : I use the a config of wikifamily I am logging [10:52:54] I use $wgCookieDomain and $wgSharedDB [11:00:21] Wikibase works/tests with the private family wiki ? [11:34:37] (03PS1) 10Henning Snater: Factored out error output generation from wbtooltip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174089 [11:34:47] (03CR) 10jenkins-bot: [V: 04-1] Factored out error output generation from wbtooltip [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174089 (owner: 10Henning Snater) [12:18:03] Lydia_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=49100#c14 :) [12:18:05] 3MediaWiki extensions / 3WikidataClient: When page is deleted, sitelink should be removed - 10https://bugzilla.wikimedia.org/49100#c14 (10Marius Hoch) 5PATC>3RESO/FIX All patches needed to make this work have been merged. I'll try to get this announced and deployed next week. [12:18:23] Guess we can do that next week in a dedicated backport deploy [12:38:12] (03CR) 10Daniel Kinzler: "please rebase on top of I457552b5017. should be simple." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [12:39:01] (03CR) 10Hoo man: [C: 04-1] "Probably needs tests." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [12:41:08] DanielK_WMDE_: JeroenDeDauw: https://github.com/wmde/WikibaseDataModel/pull/280 [12:41:16] Would like to see that in the next DM release [12:42:03] That would probably make Statements on Properties work, so that we could push that out sometime soon-ish [12:45:12] [13WikidataBrowserTests] 15adrianlang comment on pull request #30 141118c02: Needs to be `> span > span` for me. 02http://git.io/7hYssg [12:45:36] [13WikidataBrowserTests] 15adrianlang comment on pull request #30 141118c02: `li.wb-snaktypeselector-menuitem-#{snaktype} a` seems to be more correct, but both works. 02http://git.io/vXW8gg [12:48:52] (03PS11) 10Adrian Lang: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [12:49:01] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [12:49:19] (03CR) 10Adrian Lang: "Rebased on I457552b5017948d246becac6677c2e01464edc43." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [12:52:04] (03PS12) 10Adrian Lang: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [12:52:05] (03PS2) 10Adrian Lang: Introduce EntityViewFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173843 (owner: 10Daniel Kinzler) [12:52:26] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [12:52:36] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173843 (owner: 10Daniel Kinzler) [13:05:20] hoo: \o/ [13:05:25] hoo: will add to weekly summary [13:05:50] :) [13:07:56] hoo: What about https://gerrit.wikimedia.org/r/164297/, btw? [13:08:59] Adrian_WMDE: If you can do the user contacting gadget fixing that's needed, I can +2 [13:09:06] * and gadget fixing [13:09:18] Can you give me a fresh grep? [13:13:13] oh sure [13:14:33] https://people.wikimedia.org/~hoo/tmp/grep-RepoApi-2014-11-18.txt [13:14:43] https://people.wikimedia.org/~hoo/tmp/grep-RepoApi-user-2014-11-18.txt [13:14:58] grepped for "RepoApi" [13:15:03] second one has user scripts [13:15:08] THanks [13:17:36] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06snaktype_tests: 02http://git.io/r2aVDA [13:17:36] 13WikidataBrowserTests/06snaktype_tests 14f43b6c5 15Tobias Gritschacher: Workaround inconsistancy with element.click and element.fire_event('onClick')... [13:18:36] Adrian_WMDE: can you check again? ^^ [13:24:36] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Lydia Pintscher) p:5Unprio>3High s:5normal>3major [13:24:39] 3MediaWiki extensions / 3WikidataRepo: support for complex queries - 10https://bugzilla.wikimedia.org/65626 (10Lydia Pintscher) [13:24:39] 3MediaWiki extensions / 3WikidataRepo: Wikiquote support - 10https://bugzilla.wikimedia.org/69753 (10Lydia Pintscher) [13:24:41] (03PS1) 10Thiemo Mättig (WMDE): Replace some deprecated setClaims with getStatements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174109 [13:25:40] (03PS1) 10Thiemo Mättig (WMDE): Reduce inheritance in EntityContentTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174110 [13:27:23] GPHemsley: that'd be awesome. You are right, the remaining issues are in the more tangled code [13:28:23] hoo|away: why not fix the issues in WB.git? If you point me to them I will have a look [13:30:39] (03PS1) 10Thiemo Mättig (WMDE): Drop optional empty array() constructor parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174112 [13:37:37] hoo|away: Lydia_WMDE ping [13:37:45] Tobi_WMDE_SW: [13:37:52] hey aude [13:38:09] the deployment build needs to be updated with some things we backported the past days [13:38:23] composer update -o (e.g.) [13:38:43] else ranks will be broken etc. [13:39:09] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Did you forgot to move the images in I988cc63?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174084 (owner: 10Adrian Lang) [13:41:42] (03PS1) 10Aude: Lazy initialize OtherProjectsSidebarGenerator in hook handlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) [13:41:53] Lydia_WMDE: ^ [13:42:06] jenkins will say no, but think it's easyish to fix [13:42:12] if someone wants to do [13:42:23] and backport to make ori, aaron, etc. happier [13:42:55] thx aude [13:42:59] Thiemo_WMDE: ^ you maybe? [13:43:22] i want to make initialization a closure, basically [13:43:27] only initialize when we need [13:43:38] that's the problem [13:43:51] * aude off (and don't forget to update the build) [13:45:10] (03CR) 10Adrian Lang: "I did." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174084 (owner: 10Adrian Lang) [13:47:41] (03Merged) 10jenkins-bot: Move tipsy images to jquery.wikibase-shared [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174084 (owner: 10Adrian Lang) [13:47:56] (03CR) 10jenkins-bot: [V: 04-1] Lazy initialize OtherProjectsSidebarGenerator in hook handlers [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [13:47:59] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Will you do the namespace change?" (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172968 (owner: 10Adrian Lang) [13:49:41] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Looks good for me, but Hoo does have a lot more experience with API related stuff. Wonder what his -1 meant?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [13:52:19] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "There is a good chance there is an error hidden in this patch ;-) but I can't find any. :-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 (owner: 10Adrian Lang) [13:53:22] (03PS3) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [13:53:45] (03Merged) 10jenkins-bot: Move getLanguageNameByCode out of wikibase.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172968 (owner: 10Adrian Lang) [13:56:46] (03CR) 10Hoo man: "Sorry for the confusion, my -1 was because this needed rebasing (to get Adrian's attention)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [13:58:28] (03PS2) 10Thiemo Mättig (WMDE): Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [14:01:52] (03PS4) 10Thiemo Mättig (WMDE): Unify top factory getter implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 [14:10:01] (03PS4) 10Thiemo Mättig (WMDE): More consistent variable naming, e.g. $languageCode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 [14:12:41] (03CR) 10Thiemo Mättig (WMDE): More consistent variable naming, e.g. $languageCode (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 (owner: 10Thiemo Mättig (WMDE)) [14:16:33] (03PS5) 10Thiemo Mättig (WMDE): More consistent variable naming, e.g. $languageCode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 [14:22:55] (03PS7) 10Thiemo Mättig (WMDE): Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [14:27:48] (03PS1) 10Thiemo Mättig (WMDE): More descriptive names for $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174123 [14:29:27] (03PS2) 10Adrian Lang: Fix detection of multiple empty listitems in sitelinklistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172510 [14:31:16] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/18 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/174124 [14:32:49] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [14:34:31] (03PS4) 10Adrian Lang: Move RepoApi files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 [14:37:09] (03CR) 10Adrian Lang: "Just wanted to point out that at least the idea of this change is trivial: It's just moving files to where the resource loader modules log" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [14:37:36] [13WikidataBrowserTests] 15adrianlang closed pull request #30: Add browsertests for snaktypes (06master...06snaktype_tests) 02http://git.io/CMn_eQ [14:46:04] hoo|away: https://ru.wikipedia.org/wiki/MediaWiki:Gadget-wefinfobox.js will totally break as soon as repo's JS is not available on the clients anymore [14:46:37] hewiki is fixed [14:47:15] wikidatawiki too [14:47:22] i. e. they both don't use get/post [14:48:07] https://test.wikidata.org/wiki/MediaWiki:Guidedtour-tour-wikidatabasics.js is broken; is it used? [14:54:53] spellcheck(er)?.js are already broken [14:55:35] ru:User:Vlsergey/common.js has RepoApi usage commented out [14:56:17] https://test.wikidata.org/wiki/User:Leitoxx/MediaWiki:Gadget-Move.js is already broken and uses post/get [14:57:40] https://www.wikidata.org/wiki/User:Fomafix/MediaWiki:Gadget-Move.js is already broken and uses post/get [14:58:01] https://www.wikidata.org/wiki/User:Fomafix/MediaWiki:Gadget-FindRedirectsForAliases.js is already broken and does not use post/get [14:58:32] https://www.wikidata.org/wiki/User:Fomafix/MediaWiki:Gadget-autoEdit.js is already broken and uses get/post [14:59:13] https://www.wikidata.org/wiki/User:Ivan_A._Krestinin/Gadget-MoveClaim.jshttps://www.wikidata.org/wiki/User:Ivan_A._Krestinin/Gadget-MoveClaim.js [14:59:27] is already broken and does not use post/get [14:59:59] https://www.wikidata.org/wiki/User:XXN/Move.js is fine [15:01:55] (03CR) 10Adrian Lang: "There is nobody using get or post on RepoApi who does not already try to construct RepoApi without passing an mw.Api instance. I. e. no cu" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164297 (owner: 10Adrian Lang) [15:20:38] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [15:20:40] 3MediaWiki extensions / 3WikidataRepo: Update the wb_terms table so it does not have a numeric entity id - 10https://bugzilla.wikimedia.org/56711 (10Jeroen De Dauw) [15:21:19] (03PS7) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 [15:25:40] [13WikibaseDataModel] 15thiemowmde created 06dropStatements (+1 new commit): 02http://git.io/y9pFFA [15:25:40] 13WikibaseDataModel/06dropStatements 141d643c9 15Thiemo Mättig: Simplify setStatements( new StatementList() ) [15:26:32] [13WikibaseDataModel] 15thiemowmde opened pull request #293: Simplify setStatements( new StatementList() ) (06master...06dropStatements) 02http://git.io/FLFowQ [15:29:47] (03CR) 10Jeroen De Dauw: [C: 032] More descriptive names for $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174123 (owner: 10Thiemo Mättig (WMDE)) [15:30:44] Thiemo_WMDE: I can haz review? https://gerrit.wikimedia.org/r/#/c/173821/ [15:30:59] hoo|away: ping [15:31:14] (03PS6) 10Jeroen De Dauw: More consistent variable naming, e.g. $languageCode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 (owner: 10Thiemo Mättig (WMDE)) [15:31:38] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06dropStatements: 02http://git.io/hnlA9A [15:31:38] 13WikibaseDataModel/06dropStatements 143e5544d 15Thiemo Mättig: Add tests [15:32:24] Lydia_WMDE: huhu schon da? [15:32:35] curious_reader: hey [15:32:50] query? [15:33:06] 3MediaWiki extensions / 3WikidataRepo: write browser tests for snak type changes - 10https://bugzilla.wikimedia.org/67364 (10tobias.gritschacher) 5PATC>3RESO/FIX [15:33:07] Lydia_WMDE: ja ist besser dann spammen wir hier nicht so [15:33:50] Thiemo_WMDE: JeroenDeDauw: any objections against making a new (minor) release of data-values/geo to finally fix the precision issue(s)? [15:34:35] Tobi_WMDE_SW: nope. Shall I do that? [15:34:39] Also need one for DT anyway [15:34:42] JeroenDeDauw: ok [15:34:46] please [15:36:27] (03CR) 10Thiemo Mättig (WMDE): "Quite some things going on in this patch. I'm not sure if it's small and non-disruptive enough for a backport. Why do the tests fail? Did " (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174113 (https://bugzilla.wikimedia.org/56602) (owner: 10Aude) [15:36:39] wmde/WikibaseDataModel/dropStatements/1d643c9 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41372363 [15:36:47] aude: Online? [15:37:43] Tobi_WMDE_SW: no open PR in Geo, please release. [15:37:44] [13Geo] 15JeroenDeDauw created 06r (+1 new commit): 02http://git.io/oZHdhw [15:37:44] 13Geo/06r 140cfce73 15jeroendedauw: 1.1.2 release [15:37:46] Thiemo_WMDE: I guess hse is not here.. I also think the change is too big and complex to just be merged and backported to production. it should be carefully reviewed. [15:37:52] *she [15:38:04] [13Geo] 15JeroenDeDauw opened pull request #31: 1.1.2 release (06master...06r) 02http://git.io/qmghWg [15:38:39] [13DataTypes] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/HNXbug [15:38:39] 13DataTypes/06master 14036bc3c 15Jeroen De Dauw: Merge pull request #24 from wmde/remoteExtPath... [15:38:45] Tobi_WMDE_SW: ok. I'm thinking about amending Audes change and reverting some unrelated changes but I'm not sure if it was intentional or not. [15:39:05] [13DataTypes] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/XzICLw [15:39:05] 13DataTypes/06master 143601eb0 15Jeroen De Dauw: Update .scrutinizer.yml [15:39:17] Thiemo_WMDE: ok. [15:40:35] there is no need to get that change in at all costs. we can wait until next deployment to resolve that issue (as it is there already a long time) [15:43:17] [13DataTypes] 15JeroenDeDauw created 06rel (+1 new commit): 02http://git.io/5x1xkQ [15:43:17] 13DataTypes/06rel 143a1deb0 15jeroendedauw: 0.4.1 release [15:43:32] [13DataTypes] 15JeroenDeDauw opened pull request #25: 0.4.1 release (06master...06rel) 02http://git.io/l-c3Cg [15:43:52] [13DataTypes] 15JeroenDeDauw 04force-pushed 06rel from 143a1deb0 to 14ca86aeb: 02http://git.io/QUKWFQ [15:43:52] 13DataTypes/06rel 14ca86aeb 15jeroendedauw: 0.4.1 release [15:43:58] Tobi_WMDE_SW: if you merge https://github.com/DataValues/Geo/pull/31 I'll create the tag [15:44:05] Same goes for https://github.com/wmde/DataTypes/pull/25 [15:44:29] The DT rel is needed for the git split (includes a fix for the JS path issue) [15:46:37] Thiemo_WMDE: can you undo or revert the following edit please? (testing revert notification) [15:46:56] wmde/WikibaseDataModel/dropStatements/3e5544d : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41373026 [15:51:16] (03CR) 10Jeroen De Dauw: [C: 031] "What is the intention here? I see a new field being added in two places, but it is used in neither." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 (owner: 10Adrian Lang) [15:51:28] [13Geo] 15tobijat pushed 1 new commit to 06master: 02http://git.io/mqG-2A [15:51:28] 13Geo/06master 140c89b02 15Tobi Gritschacher: Merge pull request #31 from DataValues/r... [15:51:36] [13Geo] 15tobijat 04deleted 06r at 140cfce73: 02http://git.io/ErxOOQ [15:51:55] [13DataTypes] 15tobijat closed pull request #25: 0.4.1 release (06master...06rel) 02http://git.io/l-c3Cg [15:53:11] (03CR) 10Jeroen De Dauw: "Oh, forgot the other point :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 (owner: 10Adrian Lang) [15:54:42] [13Geo] 15JeroenDeDauw tagged 061.1.2 at 06master: 02http://git.io/CFhhAQ [15:54:52] [13DataTypes] 15JeroenDeDauw tagged 060.4.1 at 06master: 02http://git.io/Ai0dMA [15:56:19] (03CR) 10Jeroen De Dauw: [C: 032] Replace some deprecated setClaims with getStatements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174109 (owner: 10Thiemo Mättig (WMDE)) [15:58:04] (03CR) 10Jeroen De Dauw: [C: 032] Reduce inheritance in EntityContentTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174110 (owner: 10Thiemo Mättig (WMDE)) [15:59:07] (03CR) 10Jeroen De Dauw: [C: 032] Drop optional empty array() constructor parameters [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174112 (owner: 10Thiemo Mättig (WMDE)) [16:01:42] wmde/DataTypes/master/036bc3c : Jeroen De Dauw The build has errored. http://travis-ci.org/wmde/DataTypes/builds/41373898 [16:05:46] [13WikibaseDataModel] 15JeroenDeDauw created 06rel (+1 new commit): 02http://git.io/8o2GjQ [16:05:46] 13WikibaseDataModel/06rel 1451049b0 15jeroendedauw: 2.3.0 release [16:05:51] Tobi_WMDE_SW: another one https://github.com/wmde/WikibaseDataModel/pull/294 [16:15:24] 3MediaWiki extensions / 3WikidataRepo: EntityViewFactory only supports items and properties - 10https://bugzilla.wikimedia.org/73559 (10Jeroen De Dauw) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Class introduced in https://gerrit.wikimedia.org/r/#/c/173843/2/repo/includes/View/EntityViewFactory.php wi... [16:15:35] 3MediaWiki extensions / 3WikidataRepo: EntityViewFactory only supports items and properties - 10https://bugzilla.wikimedia.org/73559 (10Jeroen De Dauw) [16:15:51] 3MediaWiki extensions / 3WikidataRepo: Support new Entity types - 10https://bugzilla.wikimedia.org/73496 (10Jeroen De Dauw) [16:19:58] tard bot [16:23:59] Wow ^^^ [16:24:30] wmde/DataTypes/rel/3a1deb0 : jeroendedauw The build has errored. http://travis-ci.org/wmde/DataTypes/builds/41374497 [16:29:26] [13WikibaseDataModel] 15tobijat pushed 1 new commit to 06master: 02http://git.io/MLY34g [16:29:26] 13WikibaseDataModel/06master 146a0bd5d 15Tobi Gritschacher: Merge pull request #294 from wmde/rel... [16:30:46] [13WikibaseDataModel] 15JeroenDeDauw tagged 062.3.0 at 06master: 02http://git.io/jKGmIw [16:33:49] Tobi_WMDE_SW: ugh... https://gerrit.wikimedia.org/r/#/c/174140/ [16:39:49] Hm.. can someone help investigate this error on ur.wikipedia.org? Seems like it;s caused by Wikdata code using mw.Api [16:39:51] Ibae5bfca6f5d3b72257a5a97ecaf19b01ed42a15 [16:39:56] https://gerrit.wikimedia.org/r/#/c/145281/ [16:40:05] https://ur.wikipedia.org/wiki/Sandbox?debug=1 [16:40:11] "Required parameters not specified properly" [16:40:34] Adrian already ran away for today [16:41:43] You merged it? [16:41:50] Anyway, it seems like a code regression. [16:41:54] The new parameter isn't being passed [16:42:13] happening on every request [16:42:54] Sigh. So far for our JS tests... [16:43:08] wmde/DataTypes/rel/ca86aeb : jeroendedauw The build has errored. http://travis-ci.org/wmde/DataTypes/builds/41374609 [16:43:09] 3MediaWiki extensions / 3WikidataRepo: add Dinka as a supported language - 10https://bugzilla.wikimedia.org/73563 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Dinka was approved as a language to enter data in on Wikidata. The language code is din. [16:50:07] 3MediaWiki extensions / 3WikidataRepo: add Dinka as a supported language - 10https://bugzilla.wikimedia.org/73563 (10Lydia Pintscher) [16:50:20] 3MediaWiki extensions / 3WikidataRepo: add Dinka as a supported language - 10https://bugzilla.wikimedia.org/73563 (10Lydia Pintscher) p:5Unprio>3Normal [16:50:58] Lydia_WMDE: looks like you had a lot of points about the sitelink stuff? :D [16:58:39] JeroenDeDauw: heh no just didn't get around to adding my stuff yet [16:58:40] ;-) [16:59:20] 3MediaWiki extensions / 3WikidataRepo: EntityViewFactory only supports items and properties - 10https://bugzilla.wikimedia.org/73559 (10Lydia Pintscher) p:5Unprio>3High [17:00:24] (03Merged) 10jenkins-bot: Consistent SiteLink naming and dead code removed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172541 (owner: 10Thiemo Mättig (WMDE)) [17:00:32] (03CR) 10Jeroen De Dauw: Add package definitions for each component (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 (owner: 10Jeroen De Dauw) [17:00:32] Lydia_WMDE: Lazy_Lydia [17:00:34] (03PS4) 10Jeroen De Dauw: Add package definitions for each component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 [17:02:18] always [17:03:05] 3Wikimedia / 3Wikidata: extensions/Wikidata's composer.json doesn't validate - 10https://bugzilla.wikimedia.org/73523 (10Lydia Pintscher) p:5Unprio>3Normal [17:04:20] 3MediaWiki extensions / 3WikidataRepo: Fix OCP violation in ChangeOps - 10https://bugzilla.wikimedia.org/73500 (10Lydia Pintscher) p:5Unprio>3High [17:07:20] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in RdfBuilder - 10https://bugzilla.wikimedia.org/73497 (10Lydia Pintscher) p:5Unprio>3Normal [17:08:05] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in EntityView - 10https://bugzilla.wikimedia.org/73499 (10Lydia Pintscher) p:5Unprio>3High [17:08:35] 3MediaWiki extensions / 3WikidataRepo: Entity related issues in EntitySearchTextGenerator - 10https://bugzilla.wikimedia.org/73498 (10Lydia Pintscher) p:5Unprio>3High [17:10:35] 3MediaWiki extensions / 3WikidataRepo: Remove incorrect Entity assumptions from EntityParserOutputGenerator - 10https://bugzilla.wikimedia.org/73495 (10Lydia Pintscher) p:5Unprio>3High [17:11:20] 3MediaWiki extensions / 3WikidataRepo: Make Wikibase add coordinates to GeoData - 10https://bugzilla.wikimedia.org/73482 (10Lydia Pintscher) p:5Unprio>3Normal [17:13:35] 3MediaWiki extensions / 3WikidataRepo: item page should be purged after reverting an edit to display the current version - 10https://bugzilla.wikimedia.org/73475 (10Lydia Pintscher) p:5Unprio>3Normal [17:14:20] 3MediaWiki extensions / 3WikidataClient: Sane Lua label access in non-content languages - 10https://bugzilla.wikimedia.org/73460 (10Lydia Pintscher) p:5Unprio>3Normal [17:14:50] aude: https://bugzilla.wikimedia.org/73482 is what we were talking about this weekend [17:15:05] 3MediaWiki extensions / 3WikidataRepo: DatabaseBase::deadlockLoop: Transaction already in progress (from RefreshLinks::fixLinksFromArticle) - 10https://bugzilla.wikimedia.org/73456 (10Lydia Pintscher) p:5Unprio>3Normal [17:16:23] wmde/DataTypes/0.4.1/68675f3 : Tobi Gritschacher The build passed. http://travis-ci.org/wmde/DataTypes/builds/41376090 [17:25:42] wmde/WikibaseDataModel/rel/51049b0 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/41377123 [17:55:34] wmde/WikibaseDataModel/2.3.0/6a0bd5d : Tobi Gritschacher The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41379890 [18:11:01] (03PS1) 10Umherirrender: Use Parser::SFH_NO_HASH class const [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174164 [18:11:32] (03CR) 10Umherirrender: "Untested" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174164 (owner: 10Umherirrender) [19:39:23] (03Draft2) 10Daniel Kinzler: Inject LabelLookup got use by Formatters. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173848 [19:50:18] TypeError: wb.datamodel.Fingerprint is not a constructor [19:50:20] oh [19:53:15] Lydia_WMDE: https://www.wikidata.org/wiki/Q42?debug=true [19:53:18] does that work for you? [19:53:26] looking [19:53:53] "waiting for bits.wikimedia.org" [19:54:07] ah [19:54:08] now [19:54:20] yes looks fin [19:54:22] fine [19:54:26] anything specific? [19:55:00] hoo: ^ [19:55:23] ok, that's weird [19:55:28] for me JS is totally broken [19:55:46] it looks fine here [19:55:50] also looking at other items [19:57:23] stuff loads incredibly slow for me right now... is it only me? [19:57:51] seems ok for me [19:58:02] anyone else who can give it a try? [19:58:03] :S [20:00:05] Lydia_WMDE: it works for me on WebKit... but my firefox is acting up (logged out and logged in) [20:00:17] ah i was using chromium [20:00:21] let me try firefox [20:01:28] hoo: firefox also looks fine [20:01:31] mh [20:01:37] just restarted my private mode instance [20:01:42] k [20:01:43] maybe cache wasn't clean when I first tried [20:01:53] still [20:02:05] the only thing that is weird for me in both is the floating toolbar that is positioned wrong when floating [20:02:10] slightly moved to the left [20:02:13] will file bug [20:02:21] ok [20:02:46] TypeError: wb.datamodel.Fingerprint is not a constructor [20:02:52] I keep getting that in Firefox [20:03:29] anyone else around who can try? [20:03:45] ok, works in non-debug mode [20:04:22] 3MediaWiki extensions / 3WikidataRepo: sitelink toolbar slightly missaligned - 10https://bugzilla.wikimedia.org/73572 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The sitelink toolbar is slightly moved to the left when it floats and doesn't align with the table below it. [20:04:28] Lydia_WMDE: Did you try Q42 in debug mode on Firefox? [20:04:35] yes [20:05:07] 3MediaWiki extensions / 3WikidataRepo: sitelink toolbar slightly missaligned - 10https://bugzilla.wikimedia.org/73572 (10Lydia Pintscher) p:5Unprio>3Normal [20:06:54] brb - need to get some food and take care of laundry [20:07:07] I have a suspicion [20:07:09] ok [20:23:03] hoo: https://www.wikidata.org/w/index.php?title=Wikidata:Contact_the_development_team&diff=0&oldid=175082548 [20:23:29] ok [20:23:50] regarding the things I see... taht totally should never happen... all RC dependencies are set right and all that is deployed now [20:24:00] no idea (offhand) why it happens though [20:24:07] * RL [20:24:22] strange [20:29:08] ok, these items have a wb_entity_per_page entry [20:29:17] will investigate more [20:29:42] thx! [20:31:54] ok, am seeing the deleted item stuff locally as well [20:38:06] hah, found the bug [20:38:09] that's the good new [20:38:09] s [20:39:50] Lydia_WMDE: In a nuthsell: If an item does not have a label we assume it doesn't exist [20:39:56] which is obviously flawed :P [20:40:02] outsch [20:40:09] that's bad [20:40:37] not easy to fix though [20:40:42] at least a simple revert wont do [20:41:55] @fixme check if the entity is deleted and format differently? [20:42:14] hoo: Is there a parser function to test if a wikidata item is connected to some page? [20:42:35] multichill: nope [20:42:37] No, but (on Wikidata itself) you can use Lua for that [20:42:53] Is {{#property:bla}} disabled on Commons? [20:43:37] yep [20:43:43] multichill: yes no data access yet as discussed in amsterdam :) [20:43:44] why? :-( [20:43:54] Connected pages.... [20:43:58] that's what i asked you about :D [20:44:08] if we should allow it without arbitrary access [20:44:21] But this is not arbitrary [20:44:28] It's a gallery connected with a Wikidata item [20:44:54] 1. No access, 2. Access to the connected item. 3. Access to random item [20:45:00] yes [20:45:02] 1. Commons 2. Wikipedia 3. Future [20:45:25] Commons could be at 2, but I think we didn't do that because we were afraid people would create items for files [20:45:26] we can do2 for commons but as you said you think it is not useful without 3... [20:45:48] seems we talked past each other ;-) [20:46:28] hoo: filing bug about deleted item links now [20:46:42] Lydia_WMDE: I think I can come up with a fix soonish... is there anyone around to review so that we can get it deployed ASAP? [20:47:15] JeroenDeDauw: around to review an important hotfix? [20:47:20] DanielK_WMDE_: or you? [20:47:26] The bug is so stupid... and I even partly noticed taht something is awry when reviewing Katie's change [20:47:37] but I thought it was just a small code smell [20:47:45] and not such an "edge case" [20:47:51] happens [20:48:02] https://gerrit.wikimedia.org/r/#/c/171530/21/lib/includes/formatters/EntityIdLabelFormatter.php [20:48:06] see my comment [20:49:02] heh [20:51:38] 3MediaWiki extensions / 3WikidataRepo: linked items shown as deleted if they don't have a label - 10https://bugzilla.wikimedia.org/73580 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs In statements linking to items the item is shown as deleted even if it is not when no label exists in... [20:52:20] hoo: ^ [20:52:35] 3MediaWiki extensions / 3WikidataRepo: linked items shown as deleted if they don't have a label - 10https://bugzilla.wikimedia.org/73580 (10Lydia Pintscher) p:5Unprio>3Immedi s:5normal>3critic [20:53:21] thanks [20:54:28] EntityIdHtmlLinkFormatter doesn't have any tests, nice [20:54:29] :P [20:54:43] -.- [20:56:25] (03PS1) 10Hoo man: Fix EntityIdLabelFormatter::lookupEntityLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174271 (https://bugzilla.wikimedia.org/73580) [20:56:31] there we go [20:57:31] (03PS2) 10Hoo man: Fix EntityIdLabelFormatter::lookupEntityLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174271 (https://bugzilla.wikimedia.org/73580) [20:57:49] Lydia_WMDE: Can you grab someone and make them CR that? :P [20:58:02] trying... [20:58:15] JeroenDeDauw: poke poke poke [20:58:22] DanielK_WMDE_: meep? [20:58:35] Tobi_WMDE_SW_NA: poke? [20:59:16] (03CR) 10Hoo man: "Just for the record" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171530 (owner: 10Aude) [20:59:18] GPHemsley: you maybe? [20:59:42] or jzerebecki [21:01:55] hoo: hmmm doesn't look good :( [21:02:26] (03CR) 10Tobias Gritschacher: [C: 032] Fix EntityIdLabelFormatter::lookupEntityLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174271 (https://bugzilla.wikimedia.org/73580) (owner: 10Hoo man) [21:02:29] ah [21:02:36] Thanks, Tobi_WMDE_SW_NA! \o/ [21:03:02] \o/ [21:03:27] Lydia_WMDE has merge rights too.. :P [21:03:35] heh sure [21:03:38] (03PS1) 10Hoo man: Fix EntityIdLabelFormatter::lookupEntityLabel [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174277 (https://bugzilla.wikimedia.org/73580) [21:03:47] would probably only make it worse -.- [21:03:54] Lydia_WMDE: There's candy! :D [21:03:57] thanks Tobi_WMDE_SW_NA! [21:04:05] hoo: ;-) [21:04:29] (03CR) 10Hoo man: [C: 032] "Per master" [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174277 (https://bugzilla.wikimedia.org/73580) (owner: 10Hoo man) [21:06:26] multichill: re allowing data access for commons only for the item connected to the current page: if you waive your concerns you raised in amsterdam i am happy to get that done [21:08:56] PANIC! [21:09:36] JeroenDeDauw: Nope, we're beyond that... switched into "Waiting for jenkins" mode now :D [21:09:44] lol [21:11:23] Lydia_WMDE: I think we had a misunderstanding what we were talking about [21:11:36] I thought 3 without the underlying software being complete [21:12:05] multichill: ahhhh no. misunderstanding indeed then [21:12:14] multichill: so yay for 2 soonish? [21:12:44] (03Merged) 10jenkins-bot: Fix EntityIdLabelFormatter::lookupEntityLabel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174271 (https://bugzilla.wikimedia.org/73580) (owner: 10Hoo man) [21:13:38] yes [21:14:32] (03Merged) 10jenkins-bot: Fix EntityIdLabelFormatter::lookupEntityLabel [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174277 (https://bugzilla.wikimedia.org/73580) (owner: 10Hoo man) [21:14:36] Lydia_WMDE: So than I can access the properties on a directly connected item. Are all the labels available for the items in the statements? [21:14:45] That would be quite interesting for Commons already [21:14:46] yes [21:15:20] cool [21:15:24] i will get that prepared then [21:15:53] So on https://commons.wikimedia.org/wiki/Category:Amsterdam I could access P301 (category's main topic) and get all the labels from https://www.wikidata.org/wiki/Q727 ? [21:17:18] ah you want the label for amsterdam in all languages wikidata knows? i think that works but i need to try and make sure [21:17:34] I always forget what is included and not on connected items. [21:17:40] I'm pretty sure sitelinks are not [21:17:40] If it's only linked via the commons category property that wont work [21:17:56] if it's the sitelink of the Amsterdam item taht would work (if we enable Phase 2 on commons) [21:17:57] What would it be hoo? [21:18:02] The .git directory is missing from extensions/Wikibase/, see http://getcomposer.org/commit-deps for more information [21:18:08] :S [21:18:37] multichill: In the case it's linked via the property you might not have any connected item [21:18:56] hoo: what multichill means is the item for the commons category is connected to the item about the topic [21:19:18] https://commons.wikimedia.org/wiki/Category:Amsterdam -> https://www.wikidata.org/wiki/Q4495 [21:19:21] If that's done via sitelinks you can access all labels via Lua, yes [21:19:21] can he get all labels for that topic's item on the category page? [21:19:26] ok [21:19:31] good [21:19:55] hoo: So labels? Anything else? Maybe descriptions? Not sitelinks, right? [21:19:59] if we do what I discussed with Daniel on the weekend you will get even more options regarding labels [21:20:07] especially for multilingual wikis (like commons) [21:20:58] multichill: You can get everything from the item about the category (which is less interesting, I guess) and labels and sitelinks from the categories main subject [21:21:09] (and essentially any Item, if oyu know the id) [21:21:38] So both labels and sitelinks are always accessible? No descriptions? [21:21:47] Yes [21:21:55] ok [21:22:04] But not yet on commons as taht's not enabled yet [21:22:08] please keep that in mind [21:22:31] I understand. Would make https://commons.wikimedia.org/wiki/Template:Amsterdam a lot easier ;-) [21:22:50] Yeah [21:24:23] looks like I hit github's rate limit over here oO [21:24:41] but got that sorted now, branch will be up in a bit [21:25:16] multichill: We talked about such things on the weekend and decided to introduce an mw.wikibase.getLabelInUserlanguage( 'Q42' ) [21:25:19] for such cases [21:25:35] name is not final... it sucks :P But I guess you see where we're going [21:25:37] (03PS5) 10Jeroen De Dauw: Add package definitions for each component [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171481 [21:25:41] Oh, that sure beats the int:lang crap in lua [21:25:42] (03PS1) 10Legoktm: Set "wpUndidRevision" hidden field in EntityAction [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174283 (https://bugzilla.wikimedia.org/73562) [21:25:52] Yep, we want to get rid of that [21:25:57] (03PS6) 10Jeroen De Dauw: Remove usage of deprecated Claims and Entity classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 [21:25:59] (03PS2) 10Jeroen De Dauw: Update used version of DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174140 [21:26:01] (03PS2) 10Jeroen De Dauw: Update min version of DataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174139 [21:26:03] (03PS8) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 [21:26:12] legoktm: thanks! :) [21:26:15] Lydia_WMDE: Has there been another backport? [21:26:23] hoo: don't think so [21:26:31] (03PS3) 10Jeroen De Dauw: Remove usage of deprecated code in EntitySearchTextGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173821 [21:26:36] I have some unrelated JS changes in my diff [21:26:39] oh [21:26:45] that is the rank changes probably [21:26:46] ? [21:26:50] those should go on [21:26:55] 3MediaWiki extensions / 3WikidataRepo: Wikibase's undo edit form does not add the hidden wpUndidRevision field - 10https://bugzilla.wikimedia.org/73562 (10Kunal Mehta (Legoktm)) a:3Wikidata bugs [21:26:56] that is what katie was talking about earlier [21:26:58] go on as in go live? [21:27:02] yeah [21:27:13] go in even :D [21:27:21] https://gerrit.wikimedia.org/r/173500 and this [21:27:27] all good? [21:27:43] Lydia_WMDE: np :) [21:27:52] 3MediaWiki extensions / 3WikidataRepo: Wikibase's undo edit form does not add the hidden wpUndidRevision field - 10https://bugzilla.wikimedia.org/73562 (10Kunal Mehta (Legoktm)) a:5Wikidata bugs>3Kunal Mehta (Legoktm) [21:28:21] hoo: hmm i don't know this one but seems fine? i was thinking about what katie mentioned - without that patch chaning rank isn't possible. but that might already be in [21:28:34] Lydia_WMDE: It's not [21:28:39] ok [21:28:39] I hit that on the train on Sunday [21:28:46] that's why I tried to poke you [21:28:52] but you were at diner then, I think [21:28:54] gotcha [21:30:18] (03PS1) 10Hoo man: Update Wikibase to fix EntityIdLabelFormatter et al. [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174284 [21:31:03] * hoo switches back into waiting for jenkins mode [21:32:08] * Lydia_WMDE hands jenkins some coca cola to make it go faster [21:32:22] 3MediaWiki extensions / 3WikidataRepo: linked items shown as deleted if they don't have a label - 10https://bugzilla.wikimedia.org/73580#c5 (10Marius Hoch) 5PATC>3RESO/FIX Fixed on master... will get that deployed in a bit. [21:33:33] (03CR) 10Hoo man: [C: 032] Update Wikibase to fix EntityIdLabelFormatter et al. [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174284 (owner: 10Hoo man) [21:35:43] (03Merged) 10jenkins-bot: Update Wikibase to fix EntityIdLabelFormatter et al. [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174284 (owner: 10Hoo man) [21:36:47] (03Abandoned) 10Jeroen De Dauw: Empty the default ID blacklist [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172504 (owner: 10Jeroen De Dauw) [21:37:21] hoo: I can haz reviews? https://gerrit.wikimedia.org/r/#/q/owner:%22Jeroen+De+Dauw%22+status:open+project:mediawiki/extensions/Wikibase,n,z [21:37:26] These are all very easy to do [21:37:32] JeroenDeDauw: Maybe after deploying [21:37:55] * hoo also still has to arrange stuffs for my stay next week [21:46:53] (03CR) 10Jeroen De Dauw: [C: 032] Update min version of DataModel [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174139 (owner: 10Jeroen De Dauw) [21:46:55] (03CR) 10Jeroen De Dauw: [C: 032] Update used version of DataValues [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174140 (owner: 10Jeroen De Dauw) [21:48:44] if ( !( $siteLinks instanceof Entity ) ) { [21:48:45] wat [21:49:29] You're in weird.git, aren't you? :D [21:51:17] Lydia_WMDE: https://www.wikidata.org/wiki/Q17460016 looks good again [21:51:31] \o/ [21:51:32] sweet [21:51:49] will answer on contact the dev team [21:51:54] hoo: that is a good suggestion for renaming Wikibase.git to yes [21:51:59] hoo: https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/6eeeff88f1a8bc6ce2efe0331119043200a7c2d8/client/tests/phpunit/includes/Changes/ChangeHandlerTest.php#L602 [21:52:27] That code in general... sigh [21:53:21] Oh that... it's one of the oldest bits and that's very visible [21:53:25] (03PS1) 10Jeroen De Dauw: Use EntityDocument in WikibaseLuaBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174292 [21:54:23] * hoo calls it a day... Wikidata-wise [21:54:27] other stuffs to do :S [21:55:28] :D [21:55:37] Oh wait [21:55:43] thanks a lot hoo for doing the deployment and fixing things [21:55:44] should we purge the parser cache again [21:56:09] those things could have caught up in it, as I purged it immediately after the first deploy [21:56:35] *nod* [21:56:50] probably not a high impact but... [21:56:57] yeah, could be very confusing [21:57:25] or even lead to people removing thins in error... which would be bad [21:57:45] yeah [21:59:36] (03PS1) 10Ebrahim: Make wikibase-labelview block level direction aware [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174296 [22:01:06] All done for now :) [22:09:31] Fricking timeouts every time. [22:15:03] (03PS1) 10Jeroen De Dauw: Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 [22:15:45] (03CR) 10Hoo man: [C: 032] Use EntityDocument in WikibaseLuaBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174292 (owner: 10Jeroen De Dauw) [22:16:32] (03CR) 10Hoo man: "Would be nice to have this rebased on https://gerrit.wikimedia.org/r/170504" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [22:23:05] (03Merged) 10jenkins-bot: Use EntityDocument in WikibaseLuaBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174292 (owner: 10Jeroen De Dauw) [22:23:41] meh, already created a rebase conflict [22:23:49] which is awry as I want to push on that code a lot this week [22:23:56] (03CR) 10jenkins-bot: [V: 04-1] Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [22:27:54] Great, I can't save images. [22:28:11] Lydia_WMDE: ^ [22:28:50] whut? [22:28:58] The save button stays inactive. [22:29:09] sjoerddebruin: will try to reproduce [22:30:38] (03PS7) 10Hoo man: Make mw.wikibase.entity.formatPropertyValues work for non-items [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170504 (https://bugzilla.wikimedia.org/72124) [22:31:19] sjoerddebruin: bah. confirmed. filing bug [22:31:19] (03CR) 10Hoo man: "Manually rebased. Would be nice if we could get this merged soon, so that we can push for not using Claims here etc." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170504 (https://bugzilla.wikimedia.org/72124) (owner: 10Hoo man) [22:31:23] thanks [22:31:29] grrrr [22:31:32] Lydia_WMDE: Urgent? [22:31:43] This looks very urgent to me... :/ [22:31:45] hoo: well this is pretty sucky yeah [22:32:05] not possible to save statements with links to commons [22:32:13] That sucks big time [22:32:15] I see [22:32:29] will try to come up with a fix fast [22:32:45] thanks! [22:36:25] 3MediaWiki extensions / 3WikidataRepo: not possible to save new statements linking to images on Commons - 10https://bugzilla.wikimedia.org/73582 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When adding a new statement linking to an image on Commons the save link stays grayed out. It... [22:36:35] 3MediaWiki extensions / 3WikidataRepo: not possible to save new statements linking to images on Commons - 10https://bugzilla.wikimedia.org/73582 (10Lydia Pintscher) p:5Unprio>3Highes s:5normal>3critic [22:36:37] ok bug filed [22:36:43] Thanks for cc-ing. [22:36:48] i don't get why this was not caught by tests [22:36:51] sjoerddebruin: np [22:38:06] 3MediaWiki extensions / 3WikidataRepo: not possible to save new statements linking to images on Commons - 10https://bugzilla.wikimedia.org/73582 (10Lydia Pintscher) [22:40:36] Anybody around? [22:40:43] Josve05a: hi [22:41:15] [[Q17496609]] has a notable twitter account (@evleaks), but it is suspended. SHould it be included on wikidata+ [22:41:17] ?* [22:41:38] (read the enwp to understand context) [22:41:53] Hm, I don't think so. [22:42:06] That's like linking to a dead page. [22:43:27] [13WikibaseDataModel] 15JeroenDeDauw created 06sl (+1 new commit): 02http://git.io/Y_qpsA [22:43:27] 13WikibaseDataModel/06sl 14c42558b 15jeroendedauw: Add two more filter methods to StatementList [22:43:37] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #295: Add two more filter methods to StatementList (06master...06sl) 02http://git.io/oUy_jw [22:43:45] Yeah, but in (say 50 yrs) twitter might be dead compleatly. Should we then remove all twitterlinks? [22:44:01] (03PS2) 10Jeroen De Dauw: Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 [22:44:19] Wikidata can also be dead then. ;) [22:47:46] Josve05a: perhaps you can use a qualifier for it [22:47:51] hoo: can you look at this when you start working again? https://gerrit.wikimedia.org/r/#/c/174299/ I do not see what I did wrong [22:48:14] And I don't have WB or Lua installed, so testing is hard :D [22:48:15] Lydia_WMDE: URL's are also broken. [22:48:30] sjoerddebruin killed Wikidata ;) [22:48:30] sjoerddebruin: Ah, that's a starting point, thanks for letting us know [22:48:34] :0 [22:48:48] JeroenDeDauw: No, I only find broken stuff every time. :( [22:48:49] JeroenDeDauw: Sure, I will... plan to work on Lua mostly on Friday [22:48:53] This place is haunted! [22:49:15] Josve05a: https://www.wikidata.org/wiki/Property:P582 [22:49:44] (03CR) 10jenkins-bot: [V: 04-1] Stop using Claims and Entity in WikibaseLuaEntityBindings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [22:49:48] ebraminio: smart [22:51:02] (03CR) 10Jeroen De Dauw: "I'd much appreciate someone looking at what is going wrong here and fixing it. I don't see the issue just by looking at the code, and have" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/174299 (owner: 10Jeroen De Dauw) [22:52:24] sjoerddebruin: we should hire you as the breaker of all things D [22:52:25] :D [22:52:57] * sjoerddebruin spoils the coffee [22:53:54] 3MediaWiki extensions / 3WikidataRepo: not possible to save new URL statements or statements linking to images on Commons - 10https://bugzilla.wikimedia.org/73582 (10Lydia Pintscher) p:5Highes>3Immedi [22:53:54] 3MediaWiki extensions / 3WikidataRepo: not possible to save new URL statements or statements linking to images on Commons - 10https://bugzilla.wikimedia.org/73582#c1 (10Lydia Pintscher) URL is apparently also broken. [22:54:21] Is that the highest importance? :O [22:54:33] yes [22:54:55] Lydia_WMDE: a commons breaker being an immediate issue, Ha :p [22:55:17] JohnFLewis: immediate now that it is commons and url ;-) [22:55:49] It breaks Wikidata too, it must be fixed ASAP! :p [22:55:54] wmde/WikibaseDataModel/sl/c42558b : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41419948 [22:56:21] I encountered the URL-thing when I wanted to add a website for "locating, rating, and posting instances of female nudity in television and film" [22:56:28] JeroenDeDauw: fix stuff pls :p [22:56:46] sjoerddebruin: interesting. :p [22:56:50] sjoerddebruin: lol [22:56:58] I love the random button. [22:57:07] <3 [22:57:44] The weird thing is: there is no clickable link in the article. [23:00:55] Why is our JS so damn complicated :S [23:04:27] Because we tried to not think about desining, since that would supposdely result into something very complicated? [23:04:59] And because we did not split things, since then we'd have too many things to manage [23:05:38] I'm not even entirely sure in which component the problem is :P [23:45:57] hi [23:52:41] !nyan [23:52:42] ~=[,,_,,]:3