[00:02:50] 3MediaWiki extensions / 3WikidataRepo: Chillu letters in Wikidata API - 10https://bugzilla.wikimedia.org/51326#c7 (10emaus) Andre Klapper: the second link of my initial post is not working yet. The Wikipedia API processes both representations of chillu letters and Wikidata API processes the only one that doe... [00:25:10] JeroenDeDauw: Are all those bugs blocking 73496 available? [00:26:42] What do you mean "available"? [00:30:15] hoo: Not assigned. [00:30:40] (formally or informally) [00:31:56] If they're not in the current sprint they're not assigned [00:32:21] Unless a volunteer claimed one, but that's rather rare [00:32:37] And where do I find information about the current sprint? [00:32:48] http://sb.wmflabs.org/t/wikidata-developers/ [00:35:26] danke [00:37:23] 3MediaWiki extensions / 3WikidataRepo: Factor diff logic out of EntityContent - 10https://bugzilla.wikimedia.org/67238#c1 (10Gordon P. Hemsley) How does this relate to EntityContentDiff, EntityContentDiffView, EntityDiffVisualizer, and other classes? And, if this isn't what EntityContentDiff does, where sho... [07:27:53] could someone get me started on doing a wikidata api "query", say I know an entry id (Q34201) and I want to get property P18 (image), how would I start constructing an api string? http://wikidata.org/w/api.php? <--- can't find any documentation on adding here to select entry and get property [07:33:29] binni: https://www.wikidata.org/w/api.php?action=help&modules=wbgetentities [08:01:56] (03PS4) 10Henning Snater: Rearranged site link views [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 [08:02:06] (03CR) 10jenkins-bot: [V: 04-1] Rearranged site link views [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 (owner: 10Henning Snater) [08:03:16] (03PS3) 10Henning Snater: Deferred sitelinkviews switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173005 (https://bugzilla.wikimedia.org/73300) [08:04:56] (03PS5) 10Henning Snater: Rearranged site link views [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 [08:12:36] going to upgrade Jenkins in a few minutes, it will be unavailable for a few. [08:16:21] (03PS1) 10Henning Snater: Added basic entitysearch widget tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173757 [08:39:15] hi [08:54:03] hi [08:54:26] can someone please merge Q2877600 with Q18546065? [09:02:23] Shmias: done [09:02:29] sjoerddebruin: danke [09:02:37] sjoerddebruin: than you ^^ [09:02:40] *k [09:37:35] 3MediaWiki extensions / 3WikidataClient: Set languageLinkSiteGroup in $wgWBClientSettings to avoid fetching SiteList object from memcached - 10https://bugzilla.wikimedia.org/56602#c15 (10Ori Livneh) 5RESO/FIX>3REOP This wasn't fixed, so I'm not sure why the bug was closed. [09:46:35] 3MediaWiki extensions / 3WikidataClient: Set languageLinkSiteGroup in $wgWBClientSettings to avoid fetching SiteList object from memcached - 10https://bugzilla.wikimedia.org/56602#c16 (10Faidon Liambotis) This causes: https://ganglia.wikimedia.org/latest/graph.php?r=year&z=xlarge&h=mc1005.eqiad.wmnet&m=netwo... [09:48:45] (03PS3) 10Adrian Lang: Move RepoApi files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 [09:49:59] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [09:52:29] (03PS2) 10Adrian Lang: Move getLanguageNameByCode out of wikibase.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172968 [09:52:48] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172968 (owner: 10Adrian Lang) [09:54:24] (03PS2) 10Adrian Lang: Move shared stuff in jquery.wikibase to jquery.wikibase-shared [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172736 [09:54:50] (03PS5) 10Adrian Lang: Inject dataTypeStore into snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 [09:54:57] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172736 (owner: 10Adrian Lang) [09:56:59] (03PS4) 10Adrian Lang: Move wikibase.dataTypes from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 [09:57:10] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 (owner: 10Adrian Lang) [09:59:30] Henning_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=73380 [09:59:59] hashar: good morning! :) jenkis is nof flat and shiny? [10:00:45] Tobi_WMDE_SW: what do you mean? [10:00:57] hashar: new UX [10:00:59] :) [10:01:02] oh yeah [10:01:09] Tobi_WMDE_SW: I have upgraded Jenkins a couple hours ago [10:01:17] saw that. :) [10:01:22] looks neat [10:01:30] the UI is indeed slightly nicer [10:01:58] still looks like a mess [10:02:12] Adrian_WMDE: thats because it's jenkins [10:02:33] (03PS3) 10Adrian Lang: Fix editing of ranks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) [10:02:43] (03CR) 10Adrian Lang: "Rebased, ignore." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) (owner: 10Adrian Lang) [10:06:12] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Code looks good. Manually tested, works." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172951 (owner: 10Adrian Lang) [10:13:57] (03Merged) 10jenkins-bot: Remove global state, the entity store caches results [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172951 (owner: 10Adrian Lang) [10:15:43] (03PS4) 10Adrian Lang: Fix editing of ranks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) [10:15:45] (03PS1) 10Adrian Lang: Removed dead and broken code in statementview save [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173771 [10:16:16] (03CR) 10Adrian Lang: Fix editing of ranks (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) (owner: 10Adrian Lang) [10:17:10] wikimedia/mediawiki-extensions-Wikibase/master/ec9aaed : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41228749 [10:18:47] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Not sure if this is a problem. -1 to raise your attention. Bene?" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 (owner: 10Adrian Lang) [10:19:47] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove styles dependency from resource loader module wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172963 (owner: 10Adrian Lang) [10:20:20] (03PS4) 10Adrian Lang: Defer sitelinkview's switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173005 (https://bugzilla.wikimedia.org/73300) (owner: 10Henning Snater) [10:22:20] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Rebase failed somehow, obviously. This reintroduces stuff in lib?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 (owner: 10Adrian Lang) [10:25:37] (03PS5) 10Adrian Lang: Move wikibase.dataTypes from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 [10:31:33] (03PS1) 10Thiemo Mättig (WMDE): Rename dataTypes to dataTypeStore [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173773 [10:31:48] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06rank_tests: 02http://git.io/QIE17w [10:31:48] 13WikidataBrowserTests/06rank_tests 142f1ac8e 15Tobias Gritschacher: Use predicate matchers in steps file [10:33:38] (03CR) 10Adrian Lang: "Mergeable except one thing." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173005 (https://bugzilla.wikimedia.org/73300) (owner: 10Henning Snater) [10:33:53] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move wikibase.dataTypes from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 (owner: 10Adrian Lang) [10:34:36] (03PS5) 10Henning Snater: Defer sitelinkview's switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173005 (https://bugzilla.wikimedia.org/73300) [10:35:01] (03Merged) 10jenkins-bot: Remove styles dependency from resource loader module wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172963 (owner: 10Adrian Lang) [10:38:50] wikimedia/mediawiki-extensions-Wikibase/master/6240634 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41230399 [10:39:32] (03PS1) 10Adrian Lang: Only start first sitelinkview's edit mode if no other is in viewport [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173774 [10:44:43] (03CR) 10Adrian Lang: [C: 032] Defer sitelinkview's switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173005 (https://bugzilla.wikimedia.org/73300) (owner: 10Henning Snater) [10:50:08] (03PS2) 10Thiemo Mättig (WMDE): Use $this->settings instead of $this->getSettings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173262 [10:51:37] (03Merged) 10jenkins-bot: Defer sitelinkview's switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173005 (https://bugzilla.wikimedia.org/73300) (owner: 10Henning Snater) [10:53:21] 3MediaWiki extensions / 3WikidataRepo: Implement deferred switch to edit mode - 10https://bugzilla.wikimedia.org/73300 (10Adrian Lang) 5PATC>3RESO/FIX [10:56:58] <7YUAACKHH> [13WikidataBrowserTests] 15adrianlang closed pull request #28: Add browsertests for statement ranks (06master...06rank_tests) 02http://git.io/MtGkVA [10:56:58] <7JTABH88P> [13WikidataBrowserTests] 15adrianlang pushed 1 new commit to 06master: 02http://git.io/-Vp5ZA [10:56:58] <7JTABH88P> 13WikidataBrowserTests/06master 148f2332c 15Adrian Lang: Merge pull request #28 from wmde/rank_tests... [10:57:03] [13WikidataBrowserTests] 15adrianlang 04deleted 06rank_tests at 142f1ac8e: 02http://git.io/sxq7XA [10:58:22] (03CR) 10Jeroen De Dauw: Make mw.wikibase.entity.formatPropertyValues work for non-items (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170504 (https://bugzilla.wikimedia.org/72124) (owner: 10Hoo man) [10:59:06] 3MediaWiki extensions / 3WikidataRepo: write browser tests for rank change - 10https://bugzilla.wikimedia.org/67363 (10Adrian Lang) 5PATC>3RESO/FIX [11:00:14] (03PS6) 10Adrian Lang: Rearranged site link views [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 (owner: 10Henning Snater) [11:01:00] (03CR) 10Jeroen De Dauw: "Looks like Claims is still used a lot in this class, that could be updated (just saying, not part of this commit)." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170504 (https://bugzilla.wikimedia.org/72124) (owner: 10Hoo man) [11:01:41] (03PS3) 10Thiemo Mättig (WMDE): Unify top factory getter implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 [11:08:13] (03PS5) 10Thiemo Mättig (WMDE): Move all client tests to Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [11:09:18] (03PS10) 10Adrian Lang: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [11:09:52] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [11:10:25] The rebuildItemsPerSite script which I started ~23h ago didn't even finish have the entities, yet [11:10:46] it used to run over all of Wikidata in about ~24h [11:11:10] Sadly I don't have concrete numbers from before, so that wont do it as a benchmark at all [11:17:30] (03CR) 10jenkins-bot: [V: 04-1] Move all client tests to Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [11:18:28] hoo: can you think of a way to do this more quickly? problems in that table should only happen when a save gets interrupted. [11:18:46] maybe we can mark items as "dirty" at the beginning of the save process?.... [11:19:17] Where would you do that? page_props? [11:20:15] But this also happens when people submit the same item twice... and I'm not sure how we actually react to that (probably graceful without dying) [11:24:08] yea, we should really cover that case mroe nicely [11:24:45] Once we have the result I'll probably pull a list of bots that do such things and will then contact their owners [11:26:28] I have to leave for now [11:26:56] DanielK_WMDE_: Would be nice if we could get the UpdateRepo stuff merged so that we can schedule the deployment of it [11:29:41] (03CR) 10Henning Snater: "After having an additional look: The change appears to be a work-around for a problem that should be solved differently." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172918 (https://bugzilla.wikimedia.org/73172) (owner: 10Aude) [11:31:45] (03CR) 10Adrian Lang: Rearranged site link views (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173278 (owner: 10Henning Snater) [11:34:38] (03PS1) 10Thiemo Mättig (WMDE): Move Client tests to namespace Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173786 [11:35:40] (03CR) 10Adrian Lang: Remove _fetchItems (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 (owner: 10Adrian Lang) [11:35:55] (03PS1) 10Thiemo Mättig (WMDE): Fix namespace of all Wikibase\Client\DataAccess tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173787 [11:36:46] (03PS1) 10Thiemo Mättig (WMDE): Move all remaining client tests to specific namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173788 [11:38:58] [13scrumbugz] 15christopher-johnson pushed 1 new commit to 06master: 02http://git.io/1kh3Og [11:38:58] 13scrumbugz/06master 140886728 15Christopher Johnson: Update models.py [11:39:23] [13scrumbugz] 15christopher-johnson pushed 1 new commit to 06master: 02http://git.io/7urvlA [11:39:23] 13scrumbugz/06master 14fff2ffd 15Christopher Johnson: Update models.py [11:53:22] (03CR) 10Henning Snater: [C: 032] Fix editing of ranks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) (owner: 10Adrian Lang) [11:59:46] (03CR) 10Adrian Lang: [C: 032] Move Client tests to namespace Wikibase\Client\Tests (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173786 (owner: 10Thiemo Mättig (WMDE)) [12:00:09] (03Merged) 10jenkins-bot: Fix editing of ranks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) (owner: 10Adrian Lang) [12:00:50] (03CR) 10Adrian Lang: [C: 032] Fix namespace of all Wikibase\Client\DataAccess tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173787 (owner: 10Thiemo Mättig (WMDE)) [12:03:10] (03CR) 10Adrian Lang: Move all remaining client tests to specific namespaces (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173788 (owner: 10Thiemo Mättig (WMDE)) [12:05:25] (03PS3) 10Adrian Lang: Use $this->settings instead of $this->getSettings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173262 (owner: 10Thiemo Mättig (WMDE)) [12:10:11] (03Merged) 10jenkins-bot: Move Client tests to namespace Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173786 (owner: 10Thiemo Mättig (WMDE)) [12:10:55] (03CR) 10Adrian Lang: [C: 032] Added basic entitysearch widget tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173757 (owner: 10Henning Snater) [12:11:17] (03Merged) 10jenkins-bot: Fix namespace of all Wikibase\Client\DataAccess tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173787 (owner: 10Thiemo Mättig (WMDE)) [12:14:30] (03CR) 10Adrian Lang: [C: 032] Update type hints to not use Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173701 (owner: 10Jeroen De Dauw) [12:15:05] (03CR) 10Adrian Lang: [C: 032] Do not pass whole Entity when not needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173676 (owner: 10Jeroen De Dauw) [12:21:01] [13WikidataBrowserTests] 15adrianlang created 06rankSelector (+1 new commit): 02http://git.io/2pjIlw [12:21:01] 13WikidataBrowserTests/06rankSelector 144cb0e4a 15Adrian Lang: Fix rank selector not present step [12:21:08] Henning_WMDE: ^ [12:21:24] (03Merged) 10jenkins-bot: Added basic entitysearch widget tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173757 (owner: 10Henning Snater) [12:23:53] (03Merged) 10jenkins-bot: Update type hints to not use Entity [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173701 (owner: 10Jeroen De Dauw) [12:23:55] (03Merged) 10jenkins-bot: Do not pass whole Entity when not needed [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173676 (owner: 10Jeroen De Dauw) [12:27:15] wikimedia/mediawiki-extensions-Wikibase/master/0833559 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41237059 [12:28:07] (03PS6) 10Thiemo Mättig (WMDE): Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [12:33:47] (03CR) 10jenkins-bot: [V: 04-1] Rework and clean up ChangeHandler and ChangeHandlerTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [12:34:38] [13WikidataBrowserTests] 15adrianlang opened pull request #29: Fix rank selector not present step (06master...06rankSelector) 02http://git.io/U_tk2g [12:35:17] (03PS2) 10Thiemo Mättig (WMDE): Move all remaining client tests to specific namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173788 [12:36:02] (03CR) 10Aude: [C: 032] Use $this->settings instead of $this->getSettings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173262 (owner: 10Thiemo Mättig (WMDE)) [12:37:08] 3MediaWiki extensions / 3WikidataRepo: After editing a claim's rank, the UI is left in an inconsistent state. - 10https://bugzilla.wikimedia.org/73307 (10Henning) 5PATC>3RESO/FIX [12:37:51] wikimedia/mediawiki-extensions-Wikibase/master/f24ec73 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41237939 [12:41:36] wikimedia/mediawiki-extensions-Wikibase/master/cca1ff3 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41238872 [12:41:55] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/17 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/173795 [12:43:07] (03PS1) 10Aude: Fix editing of ranks [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173796 (https://bugzilla.wikimedia.org/73307) [12:44:52] (03PS1) 10Thiemo Mättig (WMDE): Change namespace of all Client Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173797 [12:45:19] Broken for you, too? https://gerrit.wikimedia.org/r/#/c/173788/1..2/client/tests/phpunit/includes/scribunto/Scribunto_LuaWikibaseEntityLibraryTest.php,cm [12:47:00] (03CR) 10Adrian Lang: [C: 032] Move all remaining client tests to specific namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173788 (owner: 10Thiemo Mättig (WMDE)) [12:47:06] wikimedia/mediawiki-extensions-Wikibase/master/bd054b7 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41239087 [12:48:23] (03Merged) 10jenkins-bot: Use $this->settings instead of $this->getSettings [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173262 (owner: 10Thiemo Mättig (WMDE)) [12:50:52] (03CR) 10Aude: [C: 032] Follow-up fix for extra (dashed) border in non-js claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172918 (https://bugzilla.wikimedia.org/73172) (owner: 10Aude) [12:57:50] [13WikidataBrowserTests] 15tobijat 04deleted 06rankSelector at 144cb0e4a: 02http://git.io/z-b17w [12:58:02] (03Merged) 10jenkins-bot: Move all remaining client tests to specific namespaces [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173788 (owner: 10Thiemo Mättig (WMDE)) [12:58:30] (03CR) 10Tobias Gritschacher: [C: 032] New Wikidata Build - 2014/11/17 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/173795 (owner: 10Tobias Gritschacher) [12:58:42] (03Merged) 10jenkins-bot: Follow-up fix for extra (dashed) border in non-js claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172918 (https://bugzilla.wikimedia.org/73172) (owner: 10Aude) [12:59:13] Lydia_WMDE: Does the entity suggester database had a update already? [12:59:50] (03CR) 10Adrian Lang: [C: 032] "Wikibase\Client\Tests\ makes sense to me." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173797 (owner: 10Thiemo Mättig (WMDE)) [12:59:55] sjoerddebruin: hey :) we updated it like 3 weeks ago? new code being rolled out this week and including new data [13:00:17] Oh, so I should see a difference tomorrow? [13:00:20] probably on wednesday or thursday [13:00:38] (03Merged) 10jenkins-bot: New Wikidata Build - 2014/11/17 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/173795 (owner: 10Tobias Gritschacher) [13:01:25] wikimedia/mediawiki-extensions-Wikibase/master/967e7e0 : jenkins-bot The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41241658 [13:01:51] 3MediaWiki extensions / 3WikidataRepo: After editing a claim's rank, the UI is left in an inconsistent state. - 10https://bugzilla.wikimedia.org/73307 (10tobias.gritschacher) 5PATC>3RESO/FIX [13:02:38] aude: Henning_WMDE what's with this one? https://gerrit.wikimedia.org/r/#/c/172918/ [13:02:54] was the merge a mistake? [13:03:34] what? [13:03:43] omg [13:03:57] (03PS1) 10Aude: Revert "Follow-up fix for extra (dashed) border in non-js claimlistview" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173801 [13:04:43] https://gerrit.wikimedia.org/r/#/c/173500/ is what i meant [13:05:02] (03CR) 10Aude: [C: 032] "mistake" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173801 (owner: 10Aude) [13:05:23] (03CR) 10Aude: [C: 032] Fix editing of ranks [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173796 (https://bugzilla.wikimedia.org/73307) (owner: 10Aude) [13:08:07] (03PS1) 10Henning Snater: Delay entitysearch request [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173803 [13:12:09] (03Merged) 10jenkins-bot: Change namespace of all Client Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173797 (owner: 10Thiemo Mättig (WMDE)) [13:19:02] (03Merged) 10jenkins-bot: Revert "Follow-up fix for extra (dashed) border in non-js claimlistview" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173801 (owner: 10Aude) [13:19:04] (03Merged) 10jenkins-bot: Fix editing of ranks [extensions/Wikibase] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/173796 (https://bugzilla.wikimedia.org/73307) (owner: 10Aude) [13:22:07] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf8/c238223 : Adrian Lang The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41243392 [13:27:14] GPHemsley: I've gone ahead and listed several of the occurances of the issue we discussed: https://bugzilla.wikimedia.org/show_bug.cgi?id=73496 [13:43:22] (03PS1) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [13:44:29] (03PS1) 10Jeroen De Dauw: Remove usage of deprecated Claims and Entity classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 [13:49:49] (03PS2) 10Jeroen De Dauw: Remove usage of deprecated Claims and Entity classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 [13:55:14] (03CR) 10jenkins-bot: [V: 04-1] Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [13:56:14] (03CR) 10jenkins-bot: [V: 04-1] Remove usage of deprecated Claims and Entity classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 (owner: 10Jeroen De Dauw) [13:57:36] 3MediaWiki extensions / 3WikidataRepo: UI: Create specifications for sticky notification bar - 10https://bugzilla.wikimedia.org/72614#c2 (10Henning) Technical specification Intention: The notification bar is supposed to display "section-wide" notifications. At the moment, these may be the copyright informat... [13:59:05] 3MediaWiki extensions / 3WikidataRepo: UI: Create specifications for sticky notification bar - 10https://bugzilla.wikimedia.org/72614#c3 (10Henning) Created attachment 17147 --> https://bugzilla.wikimedia.org/attachment.cgi?id=17147&action=edit Basic technical concept visualization [14:00:43] [13WikibaseDataModel] 15JeroenDeDauw created 06getMainSnaks (+2 new commits): 02http://git.io/oYmjKA [14:00:43] 13WikibaseDataModel/06getMainSnaks 145bcc22f 15jeroendedauw: Add Statement::newFromMainSnak... [14:00:43] 13WikibaseDataModel/06getMainSnaks 147aa05a4 15jeroendedauw: Add StatementList::getMainSnaks [14:01:03] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #285: Add StatementList::getMainSnaks (06master...06getMainSnaks) 02http://git.io/eU3vPQ [14:01:38] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06getMainSnaks: 02http://git.io/0JBr4A [14:01:38] 13WikibaseDataModel/06getMainSnaks 1451bfda4 15Jeroen De Dauw: Update Statement.php [14:03:47] hey, isn't it possible to create a list of contents which will be public domain next year? could be usefull for the commons [14:03:51] wmde/WikibaseDataModel/getMainSnaks/7aa05a4 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41246858 [14:09:21] wmde/WikibaseDataModel/getMainSnaks/51bfda4 : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41246925 [14:10:11] (03PS3) 10Jeroen De Dauw: Remove usage of deprecated Claims and Entity classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 [14:12:53] (03PS1) 10Jeroen De Dauw: Remove dead ref in comment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173814 [14:15:18] (03PS1) 10Jeroen De Dauw: Update type hint in interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173815 [14:15:52] (03PS1) 10Jeroen De Dauw: Remove not needed variable assignment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173816 [14:22:54] (03PS2) 10Thiemo Mättig (WMDE): Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 [14:26:37] (03PS1) 10Thiemo Mättig (WMDE): Fix covers tag in WikibaseClientTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173819 [14:26:58] [13WikibaseDataModel] 15JeroenDeDauw created 06agta (+1 new commit): 02http://git.io/ytzGHA [14:26:58] 13WikibaseDataModel/06agta 14bd87083 15jeroendedauw: Added AliasGroupList::toArray [14:27:13] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #286: Added AliasGroupList::toArray (06master...06agta) 02http://git.io/lLZR8g [14:27:43] (03CR) 10Jeroen De Dauw: [C: 032] Fix covers tag in WikibaseClientTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173819 (owner: 10Thiemo Mättig (WMDE)) [14:28:48] (03CR) 10jenkins-bot: [V: 04-1] Remove usage of deprecated Claims and Entity classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 (owner: 10Jeroen De Dauw) [14:29:16] wmde/WikibaseDataModel/agta/bd87083 : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41249248 [14:29:33] [13WikibaseDataModel] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/6mRkkg [14:29:33] 13WikibaseDataModel/06master 141b48428 15thiemowmde: Merge pull request #286 from wmde/agta... [14:29:39] [13WikibaseDataModel] 15thiemowmde 04deleted 06agta at 14bd87083: 02http://git.io/QwRBPw [14:30:34] (03CR) 10jenkins-bot: [V: 04-1] Find meaningfull names for all $repo variables and methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173809 (owner: 10Thiemo Mättig (WMDE)) [14:31:49] (03CR) 10Jeroen De Dauw: "Heh, that is a bug in DM..." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 (owner: 10Jeroen De Dauw) [14:32:42] benestar|cloud: you created a bug! :) [14:33:06] (03PS4) 10Jeroen De Dauw: Remove usage of deprecated Claims and Entity classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 [14:36:41] (03PS1) 10Jeroen De Dauw: Fix various issues in EntitySearchTextGenerator and its test [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173821 [14:41:13] [13WikibaseDataModel] 15JeroenDeDauw created 06BestStatementsFinder (+1 new commit): 02http://git.io/ZYCp8Q [14:41:13] 13WikibaseDataModel/06BestStatementsFinder 14d02c92a 15jeroendedauw: Fix border condition bug in BestStatementsFinder [14:41:43] [13WikibaseDatabase] 15thiemowmde comment on pull request #62 144cd8770: This needs to check for both `false` and `MWException` no matter what. An alternative implementation could be:... 02http://git.io/HJUFjg [14:42:13] [13WikibaseDataModel] 15JeroenDeDauw opened pull request #287: Fix border condition bug in BestStatementsFinder (06master...06BestStatementsFinder) 02http://git.io/ZkhWTA [14:42:31] hello, someone understand swedish here? [14:42:34] (03CR) 10Jeroen De Dauw: "This ought to work when using https://github.com/wmde/WikibaseDataModel/pull/287" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 (owner: 10Jeroen De Dauw) [14:43:24] (03Merged) 10jenkins-bot: Fix covers tag in WikibaseClientTest [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173819 (owner: 10Thiemo Mättig (WMDE)) [14:44:20] (03CR) 10jenkins-bot: [V: 04-1] Remove usage of deprecated Claims and Entity classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173810 (owner: 10Jeroen De Dauw) [14:45:06] [13WikibaseDataModel] 15thiemowmde created 06protected (+1 new commit): 02http://git.io/Yl18iQ [14:45:06] 13WikibaseDataModel/06protected 14d5d0138 15Thiemo Mättig: Fix visibility of PHPUnit method [14:45:16] [13WikibaseDataModel] 15thiemowmde opened pull request #288: Fix visibility of PHPUnit method (06master...06protected) 02http://git.io/pQajnw [14:47:25] wmde/WikibaseDataModel/BestStatementsFinder/d02c92a : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41250818 [14:48:30] (03PS11) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [14:50:07] [13WikibaseDatabase] 15thiemowmde pushed 1 new commit to 06redododo: 02http://git.io/mNStcQ [14:50:07] 13WikibaseDatabase/06redododo 1484fc3aa 15Thiemo Mättig: Keep MWException in throw [14:50:42] [13WikibaseDatabase] 15thiemowmde comment on pull request #62 1484fc3aa: Understood. Did it. 02http://git.io/TWJm5w [14:51:28] wmde/WikibaseDataModel/protected/d5d0138 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/41251278 [14:53:10] [13WikidataBrowserTests] 15tobijat created 06snaktype_tests (+1 new commit): 02http://git.io/d162_A [14:53:10] 13WikidataBrowserTests/06snaktype_tests 144ef8507 15Tobias Gritschacher: Add browsertests for snaktypes... [14:53:56] (03CR) 10jenkins-bot: [V: 04-1] API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [14:54:08] [13WikibaseDataModel] 15JeroenDeDauw closed pull request #288: Fix visibility of PHPUnit method (06master...06protected) 02http://git.io/pQajnw [14:54:43] [13WikidataBrowserTests] 15tobijat 04force-pushed 06snaktype_tests from 144ef8507 to 14e96b09f: 02http://git.io/BnS3cw [14:54:43] 13WikidataBrowserTests/06snaktype_tests 14e96b09f 15Tobias Gritschacher: Add browsertests for snaktypes... [14:54:58] [13WikidataBrowserTests] 15tobijat opened pull request #30: Add browsertests for snaktypes (06master...06snaktype_tests) 02http://git.io/CMn_eQ [14:56:01] [13WikibaseDatabase] 15JeroenDeDauw closed pull request #62: Rework QueryInterface implementations and docs (06master...06redododo) 02http://git.io/4LpFlg [14:56:06] 3MediaWiki extensions / 3WikidataRepo: write browser tests for snak type changes - 10https://bugzilla.wikimedia.org/67364#c1 (10tobias.gritschacher) 5ASSI>3PATC https://github.com/wmde/WikidataBrowserTests/pull/30 [14:57:08] Meh, looks like ScrutinizerCI is having a fit [14:59:37] [13WikidataBrowserTests] 15zeljkofilipin comment on pull request #30 14e96b09f: I think it is more readable if "And" steps are more indented than the parent Given/When/Then steps. 02http://git.io/a4KexQ [15:03:39] [13WikidataBrowserTests] 15tobijat 04force-pushed 06snaktype_tests from 14e96b09f to 141118c02: 02http://git.io/BnS3cw [15:03:39] 13WikidataBrowserTests/06snaktype_tests 141118c02 15Tobias Gritschacher: Add browsertests for snaktypes... [15:06:07] Thiemo_WMDE: I can haz review of https://github.com/wmde/WikibaseDataModel/pull/287 ? This bug is bugging me [15:08:27] JeroenDeDauw: Error — Scrutinizer: Errored — Tests: errored? [15:09:03] is scrutenizer broken? [15:10:11] DanielK_WMDE_: look at my one but last message [15:10:30] yes, i saw that ci passed [15:10:40] 15:57:08 JeroenDeDauw | Meh, looks like ScrutinizerCI is having a fit [15:10:41] i was just curious about scrutenizer [15:10:47] hm? [15:10:50] didn't see that one [15:10:57] Here on IRC [15:11:19] It's a Tpt [15:11:19] ah, right [15:11:21] anyway [15:11:43] JeroenDeDauw: Hi! [15:11:47] JeroenDeDauw: is there any description of what this change is actually supposed to do? [15:11:57] besides "fix bug" [15:12:34] JeroenDeDauw: it basically makes it so the code ignores unknown properties, instead of erroring out... right? [15:13:06] sometimes i have to squint very hard to see the purpose of things when granularity is so high [15:13:12] gets hard to see the big picture [15:14:03] JeroenDeDauw: byPropertyIdGrouper->getByPropertyId returns a Statement? Not a group of Statements? [15:14:38] No [15:15:20] hey werdna [15:15:27] hey DanielK_WMDE_ [15:15:29] what's up? [15:15:50] JeroenDeDauw: no, it doesn't return a Statement? [15:16:18] werdna: just got back from the Amsterdam hackathon. Went directly to the office, for func discusstion about CI and factory factories :) [15:16:45] werdna: i was hoping to see you there! [15:16:56] DanielK_WMDE_: yeah, I was going to be there [15:17:00] but my stomach had other ideas [15:17:08] JeroenDeDauw: $this->getByPropertyId( $propertyId ) as $statement <--- I'm confused [15:17:23] spent all of last week reteaching my digestive tract how to be a digestive tract [15:17:34] werdna: ugh :( [15:17:40] was just on the mend on Saturday but I guess going up North would have made it get worse again. [15:17:50] DanielK_WMDE_: err. It's a loop? If the first part is a single statement, it would fail? [15:18:17] benestar|cloud: please to have a look at https://github.com/wmde/WikibaseDataModel/pull/287 [15:18:21] JeroenDeDauw: indeed, but: * @return Statement [15:18:35] DanielK_WMDE_: where? [15:18:39] i guess the documentation is just wrong [15:18:47] (03PS1) 10Thiemo Mättig (WMDE): Replace some Claims with StatementList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173828 [15:18:51] JeroenDeDauw: getByPropertyId [15:19:09] yea, it's just wrong, should be PropertyIdProvider[] I uess. [15:19:17] Or Statement[], of there's a guarantee for that [15:19:30] DanielK_WMDE_: can you please look at master and not some random old version? [15:20:03] JeroenDeDauw: https://github.com/wmde/WikibaseDataModel/pull/287/files [15:20:12] that's what the pull request shows me [15:20:24] other than that, it seems fine [15:20:29] just a doc error [15:21:03] DanielK_WMDE_: right... I thought you where talking about getByPropertyId in ByPropertyIdGrouper [15:21:13] no, the new private function [15:23:50] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06getMainSnaks from 1451bfda4 to 1484d99bc: 02http://git.io/46ulqA [15:23:50] 13WikibaseDataModel/06getMainSnaks 14be7d5c0 15jeroendedauw: Add Statement::newFromMainSnak... [15:23:50] 13WikibaseDataModel/06getMainSnaks 14184dd91 15jeroendedauw: Add StatementList::getMainSnaks [15:23:50] 13WikibaseDataModel/06getMainSnaks 14ba5776e 15jeroendedauw: Add StatementList::getWithPropertyId [15:23:54] DanielK_WMDE_: good catch [15:24:53] JeroenDeDauw: I'd propose to rename that private function to getStatementGroup. "byPropertyId" doesn't tell me more than the parameter list already tells me. I want to know *what* it gets. [15:26:32] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06BestStatementsFinder from 14d02c92a to 144003392: 02http://git.io/21zbtQ [15:26:32] 13WikibaseDataModel/06BestStatementsFinder 144003392 15jeroendedauw: Fix border condition bug in BestStatementsFinder [15:26:34] Renamed [15:26:36] Now [15:26:38] $this->getStatementsBy( $propertyId ) [15:27:37] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06getMainSnaks: 02https://github.com/wmde/WikibaseDataModel/commit/8513618b4be9cc18b647d763ead90db925d75d25 [15:27:37] 13WikibaseDataModel/06getMainSnaks 148513618 15Jeroen De Dauw: Update RELEASE-NOTES.md [15:27:50] still kond of strange ("by P1234"), but now i can see what it returns. thanks. [15:28:16] Ugh [15:28:17] waiting for ci [15:28:18] Dat grammar [15:28:25] Should be getStatementsWith [15:28:39] getStatementsForProperty [15:28:49] getStatementsAboutProperty [15:29:14] Did you not say the property part was redundant? [15:29:44] sure, which is why I proposed getStatementsGroup [15:29:56] i don't care that much as long as I can see what it returns. it's private [15:30:01] waiting for CI now [15:33:23] [13WikibaseDataModel] 15thiemowmde created 06statementList (+1 new commit): 02http://git.io/J-180Q [15:33:23] 13WikibaseDataModel/06statementList 14655ef27 15Thiemo Mättig: StatementList constructor accepts Statement [15:33:33] [13WikibaseDataModel] 15thiemowmde opened pull request #289: StatementList constructor accepts Statement (06master...06statementList) 02http://git.io/H12eKA [15:33:44] bah, whatever [15:34:01] [13WikibaseDataModel] 15brightbyte closed pull request #287: Fix border condition bug in BestStatementsFinder (06master...06BestStatementsFinder) 02http://git.io/ZkhWTA [15:34:13] [13WikibaseDataModel] 15brightbyte 04deleted 06BestStatementsFinder at 144003392: 02http://git.io/FnpFcw [15:36:11] (03CR) 10Jeroen De Dauw: Replace some Claims with StatementList (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173828 (owner: 10Thiemo Mättig (WMDE)) [15:39:57] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06master: 02http://git.io/fWut-Q [15:39:57] 13WikibaseDataModel/06master 14639c2f9 15Jeroen De Dauw: Update RELEASE-NOTES.md [15:40:41] (03PS1) 10Henning Snater: Updated documentation in snakview.variations.Variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173832 [15:40:43] (03PS1) 10Henning Snater: Fixed value caching in snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173833 [15:40:52] Tobi_WMDE_SW: ^ [15:41:34] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06getMainSnaks from 148513618 to 14b39cd77: 02http://git.io/46ulqA [15:41:34] 13WikibaseDataModel/06getMainSnaks 145ee007d 15jeroendedauw: Add Statement::newFromMainSnak... [15:41:34] 13WikibaseDataModel/06getMainSnaks 14fee0841 15jeroendedauw: Add StatementList::getMainSnaks [15:41:34] 13WikibaseDataModel/06getMainSnaks 142d91acd 15jeroendedauw: Add StatementList::getWithPropertyId [15:43:08] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06getMainSnaks from 14b39cd77 to 1447554fb: 02http://git.io/46ulqA [15:43:08] 13WikibaseDataModel/06getMainSnaks 1447554fb 15jeroendedauw: Optimize StatementList construction from array [15:43:43] DanielK_WMDE_: \Wikibase\Test\MovePageNoticeTest::setUp <- either that or wgContLang [15:45:17] (03PS12) 10Daniel Kinzler: API PageTerms [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) [15:45:51] (03CR) 10Jeroen De Dauw: [C: 031] Fixed value caching in snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173833 (owner: 10Henning Snater) [15:46:28] Thiemo_WMDE: did you? [15:46:36] (03CR) 10Tobias Gritschacher: [C: 032] Updated documentation in snakview.variations.Variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173832 (owner: 10Henning Snater) [15:47:05] (03CR) 10Jeroen De Dauw: [C: 032] Replace some Claims with StatementList [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173828 (owner: 10Thiemo Mättig (WMDE)) [15:49:13] (03CR) 10Thiemo Mättig (WMDE): Replace some Claims with StatementList (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173828 (owner: 10Thiemo Mättig (WMDE)) [15:52:21] (03CR) 10Jeroen De Dauw: Replace some Claims with StatementList (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173828 (owner: 10Thiemo Mättig (WMDE)) [15:56:26] (03CR) 10Tobias Gritschacher: [C: 032] Fixed value caching in snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173833 (owner: 10Henning Snater) [15:57:17] (03Merged) 10jenkins-bot: Updated documentation in snakview.variations.Variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173832 (owner: 10Henning Snater) [16:00:24] Thiemo_WMDE: https://gerrit.wikimedia.org/r/#/c/173828/ [16:00:26] [13WikibaseDataModel] 15thiemowmde comment on pull request #285 1447554fb: Not needed if #268 is merged. Also a duplicate of #265. 02http://git.io/1muheA [16:01:22] wmde/WikibaseDataModel/BestStatementsFinder/4003392 : jeroendedauw The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/41255543 [16:02:56] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #285 1447554fb: Ugh. This is actually not needed here. Now how do I get rid of it :|... 02http://git.io/B0QNeg [16:03:27] Thiemo_WMDE: https://etherpad.wikimedia.org/p/glamdata [16:04:07] Thiemo_WMDE: http://sum.bykr.org/work/219831 [16:04:27] (03Merged) 10jenkins-bot: Fixed value caching in snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173833 (owner: 10Henning Snater) [16:06:47] [13WikibaseDataModel] 15JeroenDeDauw pushed 1 new commit to 06getMainSnaks: 02http://git.io/scgD9g [16:06:47] 13WikibaseDataModel/06getMainSnaks 14ab4823c 15jeroendedauw: Remove Statement::newFromMainSnak [16:07:52] Thiemo_WMDE: https://de.wikipedia.org/wiki/Chaos_Computer_Club#Btx-Hack [16:11:03] (03PS2) 10Jeroen De Dauw: Remove usage of deprecated code in EntitySearchTextGenerator [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173821 [16:11:17] aude: ^ [16:13:17] (03CR) 10Jeroen De Dauw: [C: 032] Removed dead and broken code in statementview save [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173771 (owner: 10Adrian Lang) [16:14:07] (03CR) 10Jeroen De Dauw: [C: 032] Move shared stuff in jquery.wikibase to jquery.wikibase-shared [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172736 (owner: 10Adrian Lang) [16:20:39] (03CR) 10Jeroen De Dauw: [C: 04-1] "The class name is really not good" (034 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [16:21:08] (03CR) 10Jeroen De Dauw: "The rest looks fine to me, though I only did a quick review" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170570 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [16:23:11] (03CR) 10Jeroen De Dauw: Move UpdateRepo hook handlers into a dedicated class (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173668 (owner: 10Hoo man) [16:27:09] (03Abandoned) 10Jeroen De Dauw: Update comment [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173724 (owner: 10Jeroen De Dauw) [16:32:12] (03PS1) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 [16:36:02] (03PS2) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 [16:40:21] (03CR) 10jenkins-bot: [V: 04-1] Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 (owner: 10Jeroen De Dauw) [16:42:29] (03PS2) 10Jeroen De Dauw: Empty the default ID blacklist [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172504 [16:43:38] [13WikibaseDataModel] 15thiemowmde created 06newEmpty (+1 new commit): 02http://git.io/BSydLQ [16:43:38] 13WikibaseDataModel/06newEmpty 147ea2285 15Thiemo Mättig: Deprecate newEmpty methods [16:44:32] [13WikibaseDataModel] 15thiemowmde opened pull request #290: Deprecate newEmpty methods (06master...06newEmpty) 02http://git.io/Uz_A2w [16:44:39] (03CR) 10Jeroen De Dauw: "WHAAAAT. We have tests that rely on the blacklist?! Uggghh!" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172504 (owner: 10Jeroen De Dauw) [16:45:02] Why can I not attach an epic-facepalm.gif to https://gerrit.wikimedia.org/r/#/c/172504/ ? [16:45:12] Will this be possible in phabricator? [16:45:18] Lydia_WMDE: ^ [16:45:24] I can has images in the new thing?? [16:45:33] i think so, try it out :) [16:45:57] DanielK_WMDE_: do you have a random commit there that I can troll a bit? [16:45:58] JeroenDeDauw: https://phabricator.wikimedia.org/tag/bugzilla-preview/ [16:46:27] JeroenDeDauw: code review via phabricator is still far away, but bugs in phabricator are supposed to happen next week [16:46:27] DanielK_WMDE_: You guys managed to not miss the flight? ;-) [16:46:34] multichill: bah! [16:46:37] yea, all went well :) [16:47:05] * multichill ended up in a very very long meeting [16:47:16] the europeana thing?... [16:47:20] yeah [16:47:26] what was your role there? [16:47:54] (03CR) 10jenkins-bot: [V: 04-1] Empty the default ID blacklist [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172504 (owner: 10Jeroen De Dauw) [16:51:08] [13WikibaseDataModel] 15thiemowmde created 06termArray (+1 new commit): 02http://git.io/kV_3jQ [16:51:08] 13WikibaseDataModel/06termArray 146ab9dd7 15Thiemo Mättig: Drop optional Term array() parameter [16:51:16] (03PS1) 10Daniel Kinzler: Introduce EntityViewFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173843 [16:51:23] [13WikibaseDataModel] 15thiemowmde opened pull request #291: Drop optional Term array() parameter (06master...06termArray) 02http://git.io/pHFHSA [16:51:37] DanielK_WMDE_: meh, logging in requires me to go read stuff somewhere I guess [16:52:52] JeroenDeDauw: you need to do that anyway if you want your bugzilla activity to be associated with your new account on phabricator [16:53:08] you need to set up a phab account and link it with the email you use on bugzilla *before* the move [16:53:16] see the 50 or so emails about that on various lists [16:53:48] well, mayve after the mocve works too, now. not sure. but you'll have to do it soon. bugzilla will go read only this month. or so they say [16:55:33] JeroenDeDauw: go to https://phabricator.wikimedia.org/login/ ; click the "Login or Register / MediaWiki" button underneath the LDAP login form ; profit [16:56:49] [13WikibaseDataModel] 15thiemowmde created 06aliasGroupNull (+1 new commit): 02http://git.io/QqykBQ [16:56:49] 13WikibaseDataModel/06aliasGroupNull 14349db0b 15Thiemo Mättig: [DNM] Make AliasGroup constructor parameter optional [16:57:21] bd808: nice stealthy button [16:57:29] Now I remember I've used it before [16:57:42] yeah. The upstream UI is not the greatest at this point :( [16:57:53] And even so I did not see it while I filled in the form half a dozen times trying to find the correct credentials [16:57:54] [13WikibaseDataModel] 15thiemowmde opened pull request #292: [DNM] Make AliasGroup constructor parameter optional (06master...06aliasGroupNull) 02http://git.io/oGJ0YA [17:01:21] DanielK_WMDE_: Provide input [17:01:45] multichill: do you think it was productive?... [17:01:56] Yeah, just a bit long [17:02:00] hmhm :) [17:02:09] And after three days of workshop/hackathon I wasn't that fresh anymore [17:04:04] pfffft, gifs dont work https://phabricator.wikimedia.org/T1293 [17:04:14] wmde/WikibaseDataModel/master/81e40ab : Daniel Kinzler The build was canceled. http://travis-ci.org/wmde/WikibaseDataModel/builds/41256183 [17:04:26] o_O [17:04:53] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06termArray at 146ab9dd7: 02http://git.io/ed9Gmg [17:20:16] wikimedia/mediawiki-extensions-Wikibase/master/ccf476d : Jeroen De Dauw The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41261253 [17:35:45] (03PS3) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 [17:39:55] (03CR) 10jenkins-bot: [V: 04-1] Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 (owner: 10Jeroen De Dauw) [17:50:13] (03CR) 10Anomie: [C: 04-1] ""Crashes hard" sounds scary. I also don't see the i18n messages for the new module being added anywhere in here." (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173543 (https://bugzilla.wikimedia.org/72729) (owner: 10Daniel Kinzler) [18:07:36] wmde/WikibaseDataModel/getMainSnaks/ab4823c : jeroendedauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41260461 [18:39:47] wmde/WikibaseDataModel/newEmpty/7ea2285 : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41264663 [19:03:32] wmde/WikibaseDataModel/termArray/6ab9dd7 : Thiemo Mättig The build has errored. http://travis-ci.org/wmde/WikibaseDataModel/builds/41265342 [19:23:32] (03PS1) 10Legoktm: Use a valid spdx license idenfitier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173880 [19:24:18] aude: the Wikidata extension doesn't pass composer validate :| [19:29:31] =o [19:30:29] (03CR) 10Addshore: [C: 032] Use a valid spdx license idenfitier [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173880 (owner: 10Legoktm) [19:30:54] wmde/WikibaseDataModel/aliasGroupNull/349db0b : Thiemo Mättig The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41265906 [19:31:29] (03PS4) 10Addshore: Fix visibility issues in Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172709 (owner: 10Thiemo Mättig (WMDE)) [19:31:35] (03CR) 10Addshore: [C: 032] Fix visibility issues in Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172709 (owner: 10Thiemo Mättig (WMDE)) [19:41:07] 3MediaWiki extensions / 3WikidataClient: Add Wikibase API module that is usable from client wikis and available as a generator & prop module - 10https://bugzilla.wikimedia.org/72729#c9 (10Bernd Sitzmann) Daniel, the apps currently use both prefixsearch and search generators. I can't speak for mobile web, but... [19:46:15] (03Merged) 10jenkins-bot: Fix visibility issues in Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172709 (owner: 10Thiemo Mättig (WMDE)) [19:53:17] wikimedia/mediawiki-extensions-Wikibase/master/e3a4081 : Kunal Mehta The build has errored. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/41281925 [19:53:23] uhoh. [19:53:43] > /home/travis/build.sh: line 41: phpenv: command not found [19:55:52] 3Wikimedia / 3Wikidata: extensions/Wikidata's composer.json doesn't validate - 10https://bugzilla.wikimedia.org/73523 (10Kunal Mehta (Legoktm)) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Not sure if this is the right component but... km-mpb:Wikidata km$ composer validate ./composer.json is valid for... [19:59:00] wmde/WikibaseDataModel/master/779b3a8 : Jeroen De Dauw The build passed. http://travis-ci.org/wmde/WikibaseDataModel/builds/41266729 [20:14:28] legoktm: broke it! [21:22:41] What Wikidata search engines do we have? Could we add "contains an item in Wikipedia" clause to a Wikidata search? Would be nice to see something like https://www.wikidata.org/w/index.php?title=Special:Search&search=dog&fulltext=Search&profile=advanced but with such clause, without the ugly Qnumbers and with pictures (and potentially short snippets describing the subject). [21:24:09] Svetlana: I don't think we have anything that does exactly that (yet). [21:24:18] Are you aware of Magnus's WDQ [21:24:27] which apparently doesn't load right now :S [21:24:47] I'm not aware but if you throw an URL at me then I'll try it in a couple hours [21:25:49] https://wdq.wmflabs.org/ but I'm not sure it lets you do clauses based on sitelinks (although it has that informat) [21:25:53] * information [21:26:24] and it's down right now... probably because labs is being awry [21:31:22] 3MediaWiki extensions / 3WikidataRepo: new datatype for linking to properties - 10https://bugzilla.wikimedia.org/73302#c1 (10filceolaire) When we get queriws it will probably make sense for 'Range' and 'Domain' properties to link to queries instead of items. [21:32:49] Svetlana: What do you mean by "contains an item in Wikipedia"? [21:33:32] Probably that it's linked to an article on a given wiki or any Wikipedia at all [21:33:35] I guess [21:34:17] w930913: has a wikipedia article in at least one language. [21:35:08] Svetlana: I think that should be possible with the tools we have at this stage. [21:36:02] Has anybody notified Magnus yet? [21:36:32] * hoo hasn't [21:40:49] {{Done}} [21:44:19] Svetlana: Yeah, I can pull that info, even without WDQ. [21:45:26] Svetlana: Are you in labs, or do you want an API? [21:50:23] I'd rather have something end users can already use but if there's only an API then I can hack a quick search engine-like thing on labs too [21:51:14] if you can do the "find items related to searchterm which have an article at sisterprojectlikewikipedia" using an API then I should be able to make a pretty javascriptless thing for it [21:58:21] 3MediaWiki extensions / 3WikidataRepo: Displaying (and editing) the calendar model of time values is confusing - 10https://bugzilla.wikimedia.org/70395#c8 (10Gerry Ashton) (In reply to denny vrandecic from comment #4) > Here is how the UI should work as long as we support only proleptic > Gregorian (G) and p... [22:02:21] 3MediaWiki extensions / 3WikidataRepo: Displaying (and editing) the calendar model of time values is confusing - 10https://bugzilla.wikimedia.org/70395#c9 (10Gerry Ashton) It is best to display "Julian" next to all dates in that calendar, since many users only have a vague notion of when the Gregorian calend... [22:05:58] w930913: in other words, either db thing available at labs or an API thing would do it, and labs thing would probably be preferred for performance reasons [22:06:14] unless, as I mentioned, someone already did this [22:08:38] hey, Qnumbers are not ugly! [22:08:50] 3MediaWiki extensions / 3WikidataRepo: Displaying (and editing) the calendar model of time values is confusing - 10https://bugzilla.wikimedia.org/70395#c10 (10denny vrandecic) Aye. It would be great if all bot requests adding dates before 1920 would be required to demonstrate that they understand the two dif... [22:09:06] when I'm writing a search engines for the fools, they are a little :p [22:10:44] yeah, they definitively should not be user facing, I agree with that :) [22:11:07] but they are a beautiful piece of infrastructure [22:13:15] :) [22:14:21] wikidata.org is not "user-friendly" due to it exposing too much of the architecture, that's why people complain that we need to write more docs :p (they're lazy to learn it) [22:14:40] I am not disagreeing with that [22:15:20] I am actually surprised by how many people access Wikidata - I always thought it would be a quite small number of dedicated unusual people [22:16:11] either I am completely off about my estimate of how many dedicated unusual people there are in the world, or the site is actually much more interesting for reasonably normal people than i expected [22:16:36] one way or the other, what I am trying to say is "yay!" :) and also yes to more docs and more tools [22:17:10] yes to making Lydia_WMDE push for the UI development too :p [22:20:00] <3 [22:20:44] the number is a bit like a pageid in the wikipedia api and others - it can be in info page about an article, but an article has to have a name imo [22:21:21] agreed [22:21:38] initally, we didn't display the number on the page [22:21:39] It's a dennyvrandecic_ [22:21:47] but there was such strong demand for that, we put it in [22:21:52] !evil JeroenDeDauw [22:21:53] JeroenDeDauw is eeeeeevil >:( [22:21:55] it's a JeroenDeDauw [22:22:03] !evil evil [22:22:03] evil is eeeeeevil >:( [22:22:18] !good evil [22:22:24] i thought so [22:24:04] !good is not JohnFLewis [22:24:04] Key was added [22:24:40] :'( [22:25:21] JeroenDeDauw, respect tha communitah! [22:25:24] It's not the lack of docs, it's the lack of function and feature. [22:26:07] dennyvrandecic_: don't tell me I need to include JohnFLewis into that o_O he's always bullying me, the evil person! [22:26:29] JohnFLewis: promise to respect tha developahs? [22:26:36] Svetlana: Sorry for taking so long. There was a network problem that was unusual in that it was caused by another family member than my brother. [22:26:53] JeroenDeDauw: while I have access to your cabal documents, you respect me :p [22:26:57] dennyvrandecic_: ok :( [22:27:01] it's ok [22:27:45] JeroenDeDauw: as long as JohnFLewis is behaving, he's part of the community. the cabal does not exist (shhh) [22:28:08] :p [22:28:38] dennyvrandecic_: have you seen the amazing new WMDE internet meme yet? [22:28:44] Svetlana: SELECT * FROM wb_items_per_site WHERE ips_item_id= [22:28:53] JeroenDeDauw: no, but I am curious [22:31:12] (03PS4) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 [22:31:33] dennyvrandecic_: https://dl.dropboxusercontent.com/u/7313450/entropy/abraham-meme.png [22:31:48] :D [22:32:00] are we dropping the not-for-profit tax exemption? [22:32:21] ??? [22:32:47] looks like abraham is going for profit :) [22:34:11] Ah. I hijacked the image from somewhere [22:34:36] Svetlana: Also https://tools.wmflabs.org/cluestuff/wd/sitelinks.py?ids=42|76 [22:34:49] (03CR) 10jenkins-bot: [V: 04-1] Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 (owner: 10Jeroen De Dauw) [22:35:01] thanks [22:37:40] oh ffs evil php 5.3 [22:37:57] !evil php 5.3 [22:37:57] php is eeeeeevil >:( [22:38:11] !evil "php 5.3" [22:38:11] "php is eeeeeevil >:( [22:38:14] JeroenDeDauw: You make it sound as if it's the version that's evil. At least wm-bot knows better. [22:38:14] ugh [22:38:15] Bad command not have wild carded inputs [22:38:22] hahaha [22:38:42] (03PS5) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 [22:40:34] WDQ looks fixed now. [22:41:09] Is a site link a special kind of property? [22:43:59] (03CR) 10jenkins-bot: [V: 04-1] Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 (owner: 10Jeroen De Dauw) [22:48:49] Mom tells to me to buy advocados. I send back link http://www.amazon.de/Bio-Avocados-Fuerte-1-St%C3%BCck/dp/B003QY73RK/ref=sr_1_2?ie=UTF8&qid=1416264361&sr=8-2&keywords=avocado [22:48:52] Am I doing it right? [22:49:52] hoo: revieeeeeeeeeeeeew https://github.com/wmde/WikibaseDataModel/pull/285 :) [22:50:10] Then we can simply some things in WB.git [22:50:50] Yeah, I think I wanted such code only recently for something [22:52:05] yeah, would be useful for migrating the Lua stuffs away from using Claims for example [22:52:09] hoo: the SnaksFinder class, and the similar thing in the Lua code both are doing sich stuff [22:52:14] Indeed [22:52:27] hoo: https://gerrit.wikimedia.org/r/#/c/173810/ [22:52:35] That one is also blocked on a fix to DM [22:52:40] So I want a rel soon [22:55:02] [13WikibaseDataModel] 15mariushoch comment on pull request #285 14ab4823c: This is overwriting the current statements, which is probably okay given the current usage of the function (in this class)... but it looks a bit odd given the function name. 02http://git.io/jYSX_A [22:56:14] (03PS6) 10Jeroen De Dauw: Remove usage of deprecated Entity methods [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173840 [22:58:53] [13WikibaseDataModel] 15JeroenDeDauw 04force-pushed 06getMainSnaks from 14ab4823c to 145b4a1c6: 02http://git.io/46ulqA [22:58:53] 13WikibaseDataModel/06getMainSnaks 145b4a1c6 15jeroendedauw: Remove Statement::newFromMainSnak [22:59:09] hoo: merge :) [22:59:18] [13WikibaseDataModel] 15JeroenDeDauw comment on pull request #285 145b4a1c6: Good point. There was little reason for the method anyway, so inlined now. 02http://git.io/lXNsHw [23:00:42] Ok :) Waiting for travis [23:03:13] w930913: no, sitelinks are just a special thing. [23:12:03] Lol, Q946184 P569. [23:12:26] We really need an IRC term lookup :D [23:12:30] Someone open a bug!!11 [23:14:22] hoo: Ps or Qs? [23:14:47] w930913: both :D [23:14:58] Using Hexchat plugins that would probably be possible [23:15:20] Maybe I'll do that if my procrastination level is over 9000 [23:15:52] How do you create a new property on Wikidata? [23:15:59] kaldari|2: hi [23:16:05] do you actually want to create one? [23:16:10] Becuase that requires a discussion [23:16:10] hoo: What's the bot rule for the channel? [23:16:14] and you need a special user right [23:16:31] hoo: Yes, I want to add an "aspect ratio" property for images. [23:16:41] where do I propose that? [23:16:43] My wikidata library does most of that, except using an IRC bot :p [23:17:16] kaldari|2: You mean like articles about paintings and such... and not actual images as stored on commons, I guess? [23:17:24] Found it: https://www.wikidata.org/wiki/Wikidata:Property_proposal [23:17:28] https://www.wikidata.org/wiki/Wikidata:Property_proposal [23:18:16] hoo: Actually it's for qualifiers on image statements [23:18:52] Oh... that's the part where commons metadata should actually hit in [23:19:15] For example, if we have 5 image statements for New York City, it would be good to be able to programmatically determine which ones are panoramas and which are landscape or portrait (or something else) for different contexts. [23:19:32] Yeah, I see [23:19:50] But still that's probably out of scope [23:20:13] maybe a "image type" like thing which would point to the item for panorama and such *could* be ok [23:20:20] but anything beyond that is very awry [23:20:30] and I already tend to say to not do that (personal opinion) [23:21:08] hoo: I seems somewhat useless for us to provide image of Wikidata items without giving consumers any idea how or if they can properly display the images. [23:21:16] I = it [23:21:51] hoo: but I guess it's possible to get that data after the fact [23:22:27] well... I guess the things that need to be in Wikidata should be part of the property (like having a "panorama" property) and the rest can then be fetched from commons if you need further details [23:22:43] that's how I think it should be done semantically correct [23:22:58] The data there would surely be redundant? [23:23:14] Yeah, probably [23:23:22] Image metadata belongs to commons [23:23:54] (It should be with the image) [23:24:16] hoo: Well, there is also the use of adding the aspect ratio of famous paintings and photographs, for example the aspect ratio of famous Ansel Adams photos. [23:24:35] Sure, but that would be another property, I guess [23:24:42] but that would be totally legit [23:24:46] also for movies [23:24:50] true [23:26:00] [13WikibaseDataModel] 15mariushoch pushed 1 new commit to 06master: 02http://git.io/LnBlhg [23:26:00] 13WikibaseDataModel/06master 14c6946d0 15Marius Hoch: Merge pull request #285 from wmde/getMainSnaks... [23:27:38] JeroenDeDauw: We're at 2^10 data model commits \o/ [23:28:09] https://xkcd.com/1000/ [23:37:32] hoo: Do you know what the status of having units for numerical properties is? [23:38:08] well, as good as anyone else, I guess :P We will probably push for that soonish [23:38:15] but without conversion [23:38:24] that will be added at some point, but not right away [23:39:04] hoo: So I guess it's pointless to propose properties like elevation at this point? [23:39:23] at this point, yes [23:39:39] but I guess people will come up with such things extremely fast if we have a definite date [23:39:52] * once [23:44:01] Force SI! [23:46:01] Empirical units are so much more fun!11 [23:46:02] https://en.wikipedia.org/wiki/Gill_%28unit%29 [23:46:53] imperial, not empirical :) [23:46:56] well, presumably also imperical [23:47:01] *empirical [23:47:45] Oh wow... didn't even notice that [23:47:46] :D [23:48:50] I think I should maybe go to bed... but meh