[00:00:51] (03PS1) 10Aude: Follow-up fix for extra (dashed) border in non-js claimlistview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172918 (https://bugzilla.wikimedia.org/73172) [00:08:56] 3MediaWiki extensions / 3WikidataRepo: After editing a claim's rank, the UI is left in an inconsistent state. - 10https://bugzilla.wikimedia.org/73307#c1 (10Aude) this also sometimes happens when i try to change the order of a statement. and sometimes the save button does not activate when changing order. [01:14:19] How do I cite this: Bradley, David (2007). "Language Endangerment in China and Mainland Southeast Asia". In Matthias Brenzinger, ed. Language diversity endangered. New York: Mouton de Gruyter. [01:14:21] ? [01:15:09] http://sealang.net/sala/cite.pl?id=bradley2007language [01:15:47] http://glottolog.org/resource/reference/id/40339 [02:14:50] Anyone??? [07:28:10] dennyvrandecic: I'd not mind having such a "limitation" in your average OOP language [07:49:12] (03PS2) 10Adrian Lang: Remove singleton pattern from TemplateRegistry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172681 [07:49:22] (03CR) 10Adrian Lang: Remove singleton pattern from TemplateRegistry (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172681 (owner: 10Adrian Lang) [07:51:49] (03CR) 10Adrian Lang: Create add links link in PHP (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [07:55:28] (03CR) 10Adrian Lang: Simplify remoteExtPath regex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172289 (owner: 10Thiemo Mättig (WMDE)) [07:56:01] (03CR) 10Adrian Lang: "Needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (owner: 10Aude) [08:08:03] (03CR) 10Adrian Lang: [C: 04-1] "Cosmetic issues." (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [08:11:53] (03CR) 10Adrian Lang: [C: 031] Extract change coalescing logic from ChangeHandler. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 (owner: 10Daniel Kinzler) [08:13:27] (03CR) 10Adrian Lang: [C: 032] Add missing method visibility in all Lib/Repo classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172678 (owner: 10Thiemo Mättig (WMDE)) [08:16:48] (03PS3) 10Adrian Lang: Inject dataTypeStore into snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 [08:16:50] (03PS2) 10Adrian Lang: Move wikibase.dataTypes from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 [08:19:00] (03CR) 10Adrian Lang: [C: 032] Throw StorageException in EntityTermLookup for non-existing entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172652 (owner: 10Aude) [08:19:20] aaaah manual rebase again :( [08:20:02] Sorry :/ [08:20:18] it's alright, probably easy [08:20:41] (03CR) 10Adrian Lang: "Needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 (owner: 10Thiemo Mättig (WMDE)) [08:22:32] (03PS7) 10Aude: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 [08:22:45] (03CR) 10Jeroen De Dauw: [C: 031] Move RepoApi files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [08:23:46] (03CR) 10Jeroen De Dauw: [C: 032] "\o/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172697 (owner: 10Adrian Lang) [08:24:26] benestar|cloud: could you confirm whether https://bugzilla.wikimedia.org/show_bug.cgi?id=67791#c5 is a regression, or due to some other cause? [08:24:46] (03CR) 10Jeroen De Dauw: [C: 031] Introduce wikibase.experts.__namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172698 (owner: 10Adrian Lang) [08:25:43] (03CR) 10Jeroen De Dauw: [C: 032] Rename wikibase.experts.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172699 (owner: 10Adrian Lang) [08:30:48] (03Merged) 10jenkins-bot: Add missing method visibility in all Lib/Repo classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172678 (owner: 10Thiemo Mättig (WMDE)) [08:32:19] "living part-time" dat WP article [08:35:24] (03CR) 10Adrian Lang: "Needs manual rebase." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172679 (owner: 10Thiemo Mättig (WMDE)) [08:40:00] (03Merged) 10jenkins-bot: Throw StorageException in EntityTermLookup for non-existing entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172652 (owner: 10Aude) [08:40:02] (03Merged) 10jenkins-bot: Move wikibase.utilities from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172697 (owner: 10Adrian Lang) [08:44:44] (03PS8) 10Aude: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) [08:52:30] (03PS1) 10Adrian Lang: Remove global state, the entity store caches results [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172951 [08:52:32] (03PS1) 10Adrian Lang: Remove _fetchItems [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172952 [08:55:10] (03PS4) 10Adrian Lang: Remove wb.RepoApi.{get,post} [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/164297 [08:57:31] (03PS2) 10Adrian Lang: Move RepoApi files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 [08:57:44] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 (owner: 10Adrian Lang) [09:05:08] (03PS1) 10Adrian Lang: Move entityChangers from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172955 [09:11:12] (03PS1) 10Adrian Lang: Move RevisionStore and ValueViewBuilder to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172956 [09:16:46] (03PS1) 10Adrian Lang: Move store from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172959 [09:43:28] (03PS1) 10Adrian Lang: Remove dead styles and dead template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172961 [09:48:45] (03PS1) 10Adrian Lang: Remove styles dependency from resource loader module wikibase [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172963 [09:59:14] (03PS1) 10Adrian Lang: Move jquery.ui.tagadata from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172964 [09:59:16] (03PS1) 10Adrian Lang: Move formatters from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172965 [09:59:18] (03PS1) 10Adrian Lang: Move parsers from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172966 [10:07:05] (03PS4) 10Adrian Lang: Use localized (in the UI language) language names in messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [10:07:42] (03CR) 10Adrian Lang: [C: 032] "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [10:16:20] (03Merged) 10jenkins-bot: Use localized (in the UI language) language names in messages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [10:26:02] (03PS1) 10Adrian Lang: Move getLanguageNameByCode out of wikibase.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172968 [10:41:34] Tobi_WMDE_SW: aude: 392d0b6ad20b9d8c7655ed8e30755d26a122413c is the first bad commit, reverting it fixes the issue for me. Henning_WMDE investigates [10:43:46] gerrit doesn't find it [10:44:07] Ah, no. aea4c79a56541b7f75361b7509e8662efde24212 [10:44:19] ok [10:44:55] must be smart about focus [10:45:36] :D [10:48:30] (03PS1) 10Henning Snater: snakview: Trigger startEditing event even when there is no variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172973 [10:48:45] Tobi_WMDE_SW: Adrian_WMDE ^^ [10:50:08] (03CR) 10Adrian Lang: [C: 032] snakview: Trigger startEditing event even when there is no variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172973 (owner: 10Henning Snater) [10:56:48] (03Merged) 10jenkins-bot: snakview: Trigger startEditing event even when there is no variation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172973 (owner: 10Henning Snater) [11:12:53] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06adjust_tests: 02http://git.io/eu_STA [11:12:53] 13WikidataBrowserTests/06adjust_tests 14cffc9f4 15Tobias Gritschacher: Adjust statement tests to removal of exclusive edit-mode [11:13:16] [13WikidataBrowserTests] 15tobijat opened pull request #24: Adjust tests to removal of exclusive edit-mode (06master...06adjust_tests) 02http://git.io/o7yIcg [11:16:26] DanielK_WMDE_: https://github.com/wmde/WikibaseDataModelSerialization/issues/88 [11:17:07] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/898E1Q [11:17:07] 13WikidataBrowserTests/06master 142dcc49d 15Tobias Gritschacher: Fix ruby code and update rubocop config [11:17:47] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06adjust_tests: 02http://git.io/CphaKw [11:17:47] 13WikidataBrowserTests/06adjust_tests 14d56cddb 15Tobias Gritschacher: Merge branch 'master' into adjust_tests [11:19:24] Tobi_WMDE_SW: I did aliases [11:19:37] Adrian_WMDE: ? [11:19:42] tests [11:19:43] the tests adjustments? [11:19:46] ok [11:19:50] where? [11:20:34] [13WikidataBrowserTests] 15adrianlang created 06editMode (+1 new commit): 02http://git.io/nJ30gQ [11:20:34] 13WikidataBrowserTests/06editMode 145ad7ab9 15Adrian Lang: Adjust aliases tests to removal of exclusive edit-mode [11:20:59] [13WikidataBrowserTests] 15adrianlang 04deleted 06adjust_tests at 14d56cddb: 02http://git.io/o5-Q0w [11:21:47] [13WikidataBrowserTests] 15adrianlang opened pull request #25: Adjust aliases tests to removal of exclusive edit-mode (06master...06editMode) 02http://git.io/wSwkWg [11:21:54] Tobi_WMDE_SW: ^ [11:22:11] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183 (10Jan Zerebecki) [11:22:13] 3MediaWiki extensions / 3WikidataRepo: wbgetentities language fallback inconsistencies - 10https://bugzilla.wikimedia.org/72038 (10Jan Zerebecki) [11:22:17] Adrian_WMDE: which is the change that fixes the issue with ranks? [11:23:12] https://bugzilla.wikimedia.org/show_bug.cgi?id=73307 [11:24:22] thx Adrian_WMDE ! [11:24:22] [13WikidataBrowserTests] 15tobijat closed pull request #25: Adjust aliases tests to removal of exclusive edit-mode (06master...06editMode) 02http://git.io/wSwkWg [11:24:26] 3MediaWiki extensions / 3WikidataRepo: After editing a claim's rank, the UI is left in an inconsistent state. - 10https://bugzilla.wikimedia.org/73307 (10Aude) [11:25:25] 3MediaWiki extensions / 3WikidataRepo: make actual language (for-language in xml) explicit in json serialization (wbgetentities) for language fallback - 10https://bugzilla.wikimedia.org/72038 (10Jan Zerebecki) [11:27:35] also, on master when i click edit for aliases, it now correctly does focus [11:27:41] but not on test.wikidata [11:27:46] which change fixed that? [11:29:40] 3MediaWiki extensions / 3WikidataRepo: make actual and source language explicit in serialization (wbgetentities) for language fallback - 10https://bugzilla.wikimedia.org/72038#c2 (10Jan Zerebecki) Perhaps also make sure the naming in xml and json is the same. [11:29:55] 3MediaWiki extensions / 3WikidataRepo: Rollout of statements on properties with old serialization code - 10https://bugzilla.wikimedia.org/72314#c1 (10Daniel Kinzler) Things that the old serializer supported (or should have supported), and need to be possible using the new model and serializer too: * Filteri... [11:30:40] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170#c2 (10Daniel Kinzler) Things that the old serializer supported (or should have supported), and need to be possible using the new model and serializer too: * F... [11:31:12] 3MediaWiki extensions / 3WikidataRepo: Rollout of statements on properties with old serialization code - 10https://bugzilla.wikimedia.org/72314#c2 (10Daniel Kinzler) Never mind #1, that was meant for bug 71170. [11:31:22] https://bugzilla.wikimedia.org/show_bug.cgi?id=73330 only on master [11:31:27] at least last night [11:31:55] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183 (10Daniel Kinzler) [11:31:56] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10Daniel Kinzler) [11:31:58] still happening (and also see my patch to fix the css ) [11:32:10] 3MediaWiki extensions / 3WikidataRepo: create filter by language that can be applied to objects before passing to serialization - 10https://bugzilla.wikimedia.org/71512 (10Daniel Kinzler) [11:32:13] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170 (10Daniel Kinzler) [11:32:13] 3MediaWiki extensions / 3WikidataRepo: Replace old serialization code in lib with datamodel serialization - 10https://bugzilla.wikimedia.org/62188 (10Daniel Kinzler) [11:32:13] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170 (10Daniel Kinzler) [11:32:25] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170 (10Daniel Kinzler) [11:32:55] 3MediaWiki extensions / 3WikidataRepo: Query by one property and one value (tracking) - 10https://bugzilla.wikimedia.org/52385#c7 (10Lydia Pintscher) bug 67533, bug 67534, bug 67535, bug 67536, bug 71499, bug 71500, bug 71501, bug 71505 are the remaining blockers I know but more might pop up. [11:50:57] (03PS1) 10Adrian Lang: Fix editing of ranks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) [11:53:42] 3MediaWiki extensions / 3WikidataRepo: Save-Button not disabled when adding a statement - 10https://bugzilla.wikimedia.org/73358 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs The save-button is enabled right after clicking on "add statement". [11:53:57] Henning_WMDE: ^^ [11:54:11] 3MediaWiki extensions / 3WikidataRepo: Save-Button not disabled when adding a statement - 10https://bugzilla.wikimedia.org/73358#c1 (10tobias.gritschacher) p:5Unprio>3High s:5normal>3major browsertests catch this [11:54:12] (03PS1) 10Thiemo Mättig (WMDE): Change @throw to @throws [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172977 [11:55:41] [13WikibaseDatabase] 15thiemowmde pushed 1 new commit to 06DBALQueryInterface: 02http://git.io/bqjk2g [11:55:41] 13WikibaseDatabase/06DBALQueryInterface 143ce0098 15Thiemo Mättig: Revert phpunit rename [11:59:18] (03PS1) 10Henning Snater: Trigger claimview "change" event when starting snakview edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172978 [11:59:51] (03CR) 10jenkins-bot: [V: 04-1] Fix editing of ranks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) (owner: 10Adrian Lang) [12:00:12] 3MediaWiki extensions / 3WikidataRepo: Save-Button not disabled when adding a statement - 10https://bugzilla.wikimedia.org/73358#c2 (10Henning) 5NEW>3PATC https://gerrit.wikimedia.org/r/#/c/172978/ [12:00:23] Tobi_WMDE_SW: Have you tried something like api.php?action=wbgetentities&format=json&ids=P4144&languages=en today? [12:00:48] Henning_WMDE: no. [12:01:23] Adding statments (selecting a property) seems to fail due to that call returning a stack trace. [12:02:32] api.php?action=wbgetentities&ids=P5&format=json&languages=en works forme [12:02:42] Did you do composer update? [12:02:51] i did but shall try again [12:03:29] still works [12:03:47] Henning_WMDE: what does the stacktrace say? [12:03:59] I receive an internal_api_error_InvalidArgumentException "Every element in $statements must be an instance of Statement" [12:04:11] Henning_WMDE: did you do composer dump-autoload? [12:04:13] ugh [12:04:15] hmm [12:04:30] sounds familiar [12:04:34] I shall try again [12:04:40] like something is getting $claims [12:04:52] Henning_WMDE: could it be that that particular property on your machine has statements? [12:04:53] nope, error still there [12:04:53] and then passing it to where StatementList is expected [12:05:05] ah, maybe [12:05:07] and that it is broken because of that? [12:05:12] * aude has no statements on properties [12:05:15] Tobi_WMDE_SW: Yes, that may be. [12:05:25] Henning_WMDE: can you try with another property? [12:05:33] annd see if it fails too [12:05:35] i can't save statmenets on properties [12:05:52] i can enter them [12:05:57] Ah, okay, other properties work [12:05:58] get no save button [12:06:31] I have save button [12:07:20] Probably broken before change If6fc327424733a8acae32b875ad935ff9abca9ef [12:07:22] I'm having a save-button too [12:07:32] i click "add" [12:07:42] then can enter but have an [edit] button [12:07:43] and no save [12:07:47] on properties [12:07:55] aude: pull master [12:07:59] i did [12:08:02] that was fixed a few minutes ago [12:08:10] maybe packagist is slow [12:08:10] like 20 or so [12:08:49] Henning_WMDE: aude: I just added a statement to a property and saved.. [12:09:00] getting the property with wbgetentities works for me [12:09:07] but not sure if it got added at all [12:09:11] probably caching [12:09:20] The statement I have is kind of old - probably, it was just a claim back then... [12:09:42] ah, that could be [12:10:01] the fingerprint box looks somewhat odd, btw http://snag.gy/xBmZH.jpg [12:10:12] where it has empty label [12:10:29] I guess I need to find a way to get that out... [12:10:46] save works now [12:11:00] in private mode [12:12:00] aude: There should be placeholder texts. Wondering why those should be item specific... [12:12:03] huh api.php?action=wbgetentities&ids=P571&format=json&language=en works after "adding" a property [12:12:16] but the property is not there [12:12:18] aude: as I said [12:12:24] probably because it uses getClaims [12:12:29] Tobi_WMDE_SW: yeah :) [12:12:45] the property is added according to history [12:12:56] * aude notes i see wbsetclaim-create:2||1: as the summary in the diff [12:14:50] (03PS2) 10Henning Snater: Trigger claimview "change" event when starting snakview edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172978 [12:17:42] 3MediaWiki extensions / 3WikidataRepo: Uncaught TypeError: Cannot read property 'toLowerCase' of undefined - 10https://bugzilla.wikimedia.org/73359 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs when adding a statement on test.wikidata (after purging the page and with or without debug=true) Unca... [12:18:13] (03PS2) 10Adrian Lang: Fix editing of ranks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) [12:21:26] !nyan [12:21:27] ~=[,,_,,]:3 [12:21:32] (03CR) 10Aude: [C: 031] "appears to work for me" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172976 (https://bugzilla.wikimedia.org/73307) (owner: 10Adrian Lang) [12:23:57] 3MediaWiki extensions / 3WikidataRepo: save button not activated when changing order of statements - 10https://bugzilla.wikimedia.org/73360 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs 1) I click edit and then the arrow to change order. 2) save button is not activated 3) I click cancel 4) I cli... [12:24:36] (03CR) 10Aude: [C: 032] Change @throw to @throws [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172977 (owner: 10Thiemo Mättig (WMDE)) [12:29:48] (03Merged) 10jenkins-bot: Change @throw to @throws [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172977 (owner: 10Thiemo Mättig (WMDE)) [12:53:45] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Almost +2. I will rework my follow up and fix all the small things myself. Please ignore most of my comments (especially the ones about na" (0313 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 (owner: 10Daniel Kinzler) [12:57:03] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move entityChangers from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172955 (owner: 10Adrian Lang) [13:02:30] (03Merged) 10jenkins-bot: Move entityChangers from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172955 (owner: 10Adrian Lang) [13:03:37] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move RevisionStore and ValueViewBuilder to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172956 (owner: 10Adrian Lang) [13:09:21] (03Merged) 10jenkins-bot: Move RevisionStore and ValueViewBuilder to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172956 (owner: 10Adrian Lang) [13:24:49] (03PS3) 10Adrian Lang: Trigger claimview "change" event when starting snakview edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172978 (https://bugzilla.wikimedia.org/73358) (owner: 10Henning Snater) [13:28:20] (03CR) 10Adrian Lang: [C: 032] "Browsertests pass." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172978 (https://bugzilla.wikimedia.org/73358) (owner: 10Henning Snater) [13:33:58] (03Merged) 10jenkins-bot: Trigger claimview "change" event when starting snakview edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172978 (https://bugzilla.wikimedia.org/73358) (owner: 10Henning Snater) [13:37:57] 3MediaWiki extensions / 3WikidataRepo: run browsertests for wikidata from gerrit - 10https://bugzilla.wikimedia.org/73364 (10Jan Zerebecki) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Run browsertests for wikidata from gerrit. Because they take too long it may be needed to be able to run some of it in... [13:38:25] 3MediaWiki extensions / 3WikidataRepo: run browsertests for wikidata from gerrit - 10https://bugzilla.wikimedia.org/73364 (10Jan Zerebecki) [13:38:56] 3MediaWiki extensions / 3WikidataRepo: save button not activated when changing order of statements - 10https://bugzilla.wikimedia.org/73360 (10Lydia Pintscher) p:5Unprio>3Normal [13:39:56] 3MediaWiki extensions / 3WikidataRepo: run browsertests for wikidata from gerrit - 10https://bugzilla.wikimedia.org/73364 (10Lydia Pintscher) p:5Unprio>3Normal [13:41:10] 3MediaWiki extensions / 3WikidataRepo: Uncaught TypeError: Cannot read property 'toLowerCase' of undefined - 10https://bugzilla.wikimedia.org/73359 (10Lydia Pintscher) p:5Unprio>3Normal [13:41:47] Adrian_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=73358 can be closed? [13:42:29] (03PS1) 10Adrian Lang: Move $.removeClassByRegex and $.sticknode to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172986 [13:43:58] Lydia_WMDE: Probably [13:44:11] Snowcat! [13:44:40] 3MediaWiki extensions / 3WikidataRepo: Redesign Item UI for Wikidata repo - 10https://bugzilla.wikimedia.org/52136 (10Lydia Pintscher) [13:44:41] 3MediaWiki extensions / 3WikidataRepo: Batch multiple entity-changes in one request - 10https://bugzilla.wikimedia.org/73319 (10Lydia Pintscher) [13:45:41] 3MediaWiki extensions / 3WikidataRepo: Save-Button not disabled when adding a statement - 10https://bugzilla.wikimedia.org/73358 (10Lydia Pintscher) 5PATC>3RESO/FIX [13:46:41] 3MediaWiki extensions / 3WikidataRepo: can keep clicking "add" for new statements to "add" multiple at the same time - 10https://bugzilla.wikimedia.org/73330 (10Lydia Pintscher) p:5Unprio>3High [13:46:47] (03PS4) 10Adrian Lang: Inject dataTypeStore into snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 [13:46:49] (03PS3) 10Adrian Lang: Move wikibase.dataTypes from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 [13:47:18] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 (owner: 10Adrian Lang) [13:47:25] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 (owner: 10Adrian Lang) [13:47:40] 3Wikimedia / 3Wikidata: ota language displays as ltr on Wikidata - 10https://bugzilla.wikimedia.org/73317 (10Lydia Pintscher) p:5Unprio>3Normal [13:47:57] * hoo kicks his netbook for being dead dog slow [13:48:09] or maybe it's google docs being slow... or both [13:48:55] 3MediaWiki extensions / 3WikidataRepo: can keep clicking "add" for new statements to "add" multiple at the same time - 10https://bugzilla.wikimedia.org/73330#c2 (10Adrian Lang) Seems reasonable as long as we don't have automagical empty statements. [13:52:40] 3MediaWiki extensions / 3WikidataRepo: Uncaught TypeError: Cannot read property 'toLowerCase' of undefined - 10https://bugzilla.wikimedia.org/73359#c1 (10Adrian Lang) Cannot reproduce. Can you give more detailed steps or the API response? [13:52:46] DanielK_WMDE_: https://bugzilla.wikimedia.org/show_bug.cgi?id=45925 [13:52:46] Lydia_WMDE: Is my stuff understandable? [13:52:55] hoo: yes :D [13:52:57] thank you [13:54:33] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I think you want to rename store.js to __namespace in a later patch. *duck* ;-)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172959 (owner: 10Adrian Lang) [13:59:27] 3MediaWiki extensions / 3WikidataRepo: Uncaught TypeError: Cannot read property 'toLowerCase' of undefined - 10https://bugzilla.wikimedia.org/73359#c2 (10Aude) seems to also work for me now. if no one can reproduce, then maybe it was caching weirdness or such and not a problem. [13:59:58] (03Merged) 10jenkins-bot: Move store from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172959 (owner: 10Adrian Lang) [14:00:26] 3MediaWiki extensions / 3WikidataRepo: Uncaught TypeError: Cannot read property 'toLowerCase' of undefined - 10https://bugzilla.wikimedia.org/73359 (10Lydia Pintscher) 5NEW>3RESO/WOR [14:00:46] hoo: spam prevention idea: require that everyone add ~=[,,_,,]:3 to the end of their message. It will take some time for spam bots to catch on, so no spam for some time [14:00:52] I know, brilliant idea [14:00:55] You are welcome [14:01:18] How could we not have that idea before :D [14:03:05] [13WikidataBrowserTests] 15tobijat created 06switch_to_singlequotes (+1 new commit): 02http://git.io/POTsOg [14:03:05] 13WikidataBrowserTests/06switch_to_singlequotes 14e5d2516 15Tobias Gritschacher: Prefer single quotes over double quotes [14:04:10] 3MediaWiki extensions / 3WikidataRepo: can keep clicking "add" for new statements to "add" multiple at the same time - 10https://bugzilla.wikimedia.org/73330#c3 (10Aude) when i saved the second and third one (while first one is still in edit mode) then they disappear from the page. they are there on reload [14:04:11] 3MediaWiki extensions / 3WikidataRepo: Trim spaces around statements of string type - 10https://bugzilla.wikimedia.org/45925#c6 (10Daniel Kinzler) I said that? Hm, then I have to disagree with myself there... The parsevalue API module (resp. StringValueParser) should trim input (and apply utf8 normalization). [14:04:38] [13WikidataBrowserTests] 15tobijat opened pull request #26: Prefer single quotes over double quotes (06master...06switch_to_singlequotes) 02http://git.io/pQitdw [14:06:32] Lydia_WMDE: http://xaxor.com/wp-content/uploads/2013/05/Your-argument-is-invalid-memes23.jpg [14:07:02] (03PS1) 10Henning Snater: Implemented EventSingletonManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172987 [14:07:28] Lydia_WMDE: http://xaxor.com/wp-content/uploads/2013/05/Your-argument-is-invalid-memes19.jpg [14:09:18] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Thanks." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172681 (owner: 10Adrian Lang) [14:09:21] WTF :D [14:09:55] 3MediaWiki extensions / 3WikidataRepo: Trim spaces around statements of string type - 10https://bugzilla.wikimedia.org/45925 (10Lydia Pintscher) [14:10:25] hoo: don't ask :P [14:10:35] we're having one of those days... [14:10:36] ;-) [14:10:51] They're called Fridays... well, early Fridays [14:10:55] haha [14:12:07] (03PS3) 10Thiemo Mättig (WMDE): Fix visibility of setUp/tearDown [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172679 [14:14:57] [13WikidataBrowserTests] 15tobijat 04force-pushed 06switch_to_singlequotes from 14e5d2516 to 14b3bdaac: 02http://git.io/QTTLoA [14:14:57] 13WikidataBrowserTests/06switch_to_singlequotes 14b3bdaac 15Tobias Gritschacher: Prefer single quotes over double quotes [14:16:52] (03PS2) 10Thiemo Mättig (WMDE): Simplify remoteExtPath regex [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172289 [14:18:25] 3MediaWiki extensions / 3WikidataRepo: Trim spaces around statements of string type - 10https://bugzilla.wikimedia.org/45925#c7 (10Daniel Kinzler) Hm... apparently, StringValueParser does not create StringValues from strings. We seem to use the NullParser for this, which returns an UnknownValue. Whatever. S... [14:19:46] (03Merged) 10jenkins-bot: Remove singleton pattern from TemplateRegistry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172681 (owner: 10Adrian Lang) [14:21:08] who is around on tuesday? [14:21:16] yeah [14:21:24] Adrian_WMDE: you? [14:21:31] It's great to have hoo around on tuesdays [14:21:38] * aude needs help with deployment.... e.g. fix bugs if they happen [14:21:50] help with the gadgets [14:22:01] When on Tuesday= [14:22:16] 2pm(ish) [14:22:30] https://www.mediawiki.org/wiki/Wikidata_deployment [14:22:57] and for people to poke around more on test.wikidata (e.g. at things not covered in selenium tests) [14:23:06] you need to purge pages there [14:23:20] yikes... I have kind of an optional supplementary math lecture at that time [14:23:30] oh noes [14:23:35] I'm not missing out on content if I don't attend [14:23:39] * aude expects other folks to be around [14:23:42] but they explain stuffs better than in the other ones [14:23:56] also need to bump $wgCacheEpoch but i can prepare that in advance [14:24:02] yeah [14:24:05] university is more important [14:24:10] * hoo would like a Friday deploy [14:24:15] because that's my spare day [14:24:17] omg :) [14:24:47] also folks around on wednesday would be great [14:24:56] * aude is around but jetlagged [14:25:03] I'm around on Wednesdays at least biweekly [14:25:18] I'll be around both days [14:25:26] The old deploy times fitted me way better [14:25:30] at least with my current schedule [14:25:32] probably will be no issues, but since we changed so much stuff in the client, htere is more potential for an issue [14:25:37] :/ [14:26:12] we can see how the new time works [14:26:45] (03PS3) 10Thiemo Mättig (WMDE): Narrow EntityParserOutputGeneratorFactory interface [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172275 [14:29:17] I have a friend who I can only meet on Wednesday evenings... that sucks [14:29:38] :( [14:30:28] * aude likes wednesday deploy since we have time to fix things on thursday [14:30:38] yeah, certainly [14:30:54] They're a good idea in general... just my schedule sucks [14:31:17] I have a lot of spare over here, but it's all kind of at the wrong time(tm) [14:31:23] * spare time [14:31:23] tuesday deploy will be 8am for me for the next weeks [14:31:28] and again in january / february :( [14:31:39] Where'll you be? [14:31:43] East coast? [14:31:44] home home [14:32:05] :) [14:32:18] 8am is absolute earliest possible [14:32:21] at least you have a lot of time for follow ups, then :D [14:32:25] yeah [14:32:48] I hate early stuffs as well... have to be here at 8am once a week, and it's terrible [14:32:54] 2pm was not nice, if there was problem and then i wanted to go out in the evening (like be somewhere at 6pm) [14:34:35] Avoid unused parameters such as '$unused'. [14:34:39] * aude loves Linker [14:35:10] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170#c3 (10Daniel Kinzler) After some discussion with Jan and Adrian, some points became clear: * We want to implement language fallback and filtering on the model... [14:35:16] Adrian_WMDE, jzerebecki: --^ [14:35:20] (03CR) 10Adrian Lang: [C: 031] "Two small issues. I'm not too happy about the EventSingletonManager managing different events, imho it should only manage one event, but I" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172987 (owner: 10Henning Snater) [14:36:02] (03CR) 10Adrian Lang: "Will conflict with I6b0865ace791d9b3991f83c724f2d7caa3592282." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172987 (owner: 10Henning Snater) [14:37:46] [13WikibaseDataModelJavaScript] 15snaterlicious created 06fingerprintemptyterm (+1 new commit): 02http://git.io/_J1vRQ [14:37:46] 13WikibaseDataModelJavaScript/06fingerprintemptyterm 1477a9fd2 15snaterlicious: Fixed documentation [14:37:52] If university had stable Wlan, I'd be so happy [14:38:00] * hoo_ lost connection after " 2pm was not nice,[...]" [14:38:08] mh... maybe we should have a calender or something to point out who is available when [14:38:08] crazy [14:38:10] so that we can solve it on a case by case basis [14:38:12] I mean for every deploy date [14:38:19] +1 [14:38:26] I pinned myself to one access point now, maybe that's more stable [14:39:27] [13WikibaseDataModelJavaScript] 15snaterlicious opened pull request #19: Fixed documentation (06master...06fingerprintemptyterm) 02http://git.io/s8J0Lw [14:39:46] aude: Could that be done as google calendar meetings? [14:40:00] * aude is challenged when it comes to google calendar [14:40:01] So that people can be invited and the accept/ decline [14:40:09] Lydia_WMDE: ^ [14:41:29] when a method is documented to "serves a few purposes".... [14:41:37] obviously is waaaay to big and doing too much [14:41:50] Only a few... what could possibly go wrong? [14:41:56] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170#c4 (10Adrian Lang) » we use in the database will often not be exactly the same as the one we use in the database.«? I agree that we have to consider users whi... [14:44:58] (03PS2) 10Henning Snater: Implemented EventSingletonManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172987 [14:45:08] (03CR) 10jenkins-bot: [V: 04-1] Implemented EventSingletonManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172987 (owner: 10Henning Snater) [14:45:47] (03PS1) 10Thiemo Mättig (WMDE): Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 [14:45:57] (03CR) 10jenkins-bot: [V: 04-1] Optimize all use sections in Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172997 (owner: 10Thiemo Mättig (WMDE)) [14:47:17] (03CR) 10Adrian Lang: [C: 032] Implemented EventSingletonManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172987 (owner: 10Henning Snater) [14:47:30] (03PS1) 10Thiemo Mättig (WMDE): Optimize all use sections in Lib [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172998 [14:47:34] (03CR) 10Adrian Lang: [C: 032] Implemented EditableTemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172507 (owner: 10Henning Snater) [14:47:53] aude: Shall I write an email about the deployment attendance stuff? [14:47:58] To the internal ml [14:48:10] sure [14:50:23] (03PS1) 10Thiemo Mättig (WMDE): Optimize all use sections in Client [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172999 [14:54:30] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "I'm not happy that these patches leave such strange dependencies from Lib to Repo. But if you think this is the best way to move forward, " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172964 (owner: 10Adrian Lang) [14:57:26] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Simple, even if this is a bit confusing because we have lots of different methods that are all called "getStore"." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172965 (owner: 10Adrian Lang) [14:58:21] (03CR) 10Thiemo Mättig (WMDE): "By the way, is this stuff not covered by any test?" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172965 (owner: 10Adrian Lang) [14:59:08] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Again, no tests???" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172966 (owner: 10Adrian Lang) [14:59:10] (03CR) 10Adrian Lang: "Nope." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172965 (owner: 10Adrian Lang) [14:59:25] aude: Did my mail make it, cause I didn't get it myself [14:59:33] yes [14:59:40] Ah fine, then [14:59:53] leaving for now, might be back online during the lecture [14:59:56] cu# [15:00:47] (03Merged) 10jenkins-bot: Implemented EditableTemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172507 (owner: 10Henning Snater) [15:00:49] (03Merged) 10jenkins-bot: Implemented EventSingletonManager [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172987 (owner: 10Henning Snater) [15:00:51] (03CR) 10jenkins-bot: [V: 04-1] Move jquery.ui.tagadata from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172964 (owner: 10Adrian Lang) [15:00:53] (03CR) 10jenkins-bot: [V: 04-1] Move formatters from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172965 (owner: 10Adrian Lang) [15:00:55] (03CR) 10jenkins-bot: [V: 04-1] Move parsers from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172966 (owner: 10Adrian Lang) [15:05:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "jquery.removeClassByRegex is only used by jquery.wikibase.referenceview." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172986 (owner: 10Adrian Lang) [15:05:21] (03CR) 10jenkins-bot: [V: 04-1] Move jquery.ui.tagadata from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172964 (owner: 10Adrian Lang) [15:05:23] (03CR) 10jenkins-bot: [V: 04-1] Move formatters from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172965 (owner: 10Adrian Lang) [15:05:25] (03CR) 10jenkins-bot: [V: 04-1] Move parsers from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172966 (owner: 10Adrian Lang) [15:05:27] (03CR) 10jenkins-bot: [V: 04-1] Move $.removeClassByRegex and $.sticknode to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172986 (owner: 10Adrian Lang) [15:11:48] (03PS1) 10Henning Snater: Deferred sitelinkviews switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173005 [15:12:40] 3MediaWiki extensions / 3WikidataRepo: Implement deferred switch to edit mode - 10https://bugzilla.wikimedia.org/73300#c1 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/173005/ [15:13:42] (03PS2) 10Thiemo Mättig (WMDE): Move jquery.ui.tagadata from Lib to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172964 (owner: 10Adrian Lang) [15:15:40] 3MediaWiki extensions / 3WikidataRepo: Implement deferred switch to edit mode - 10https://bugzilla.wikimedia.org/73300 (10Henning) [15:20:01] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Still don't like the __ naming convention." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172698 (owner: 10Adrian Lang) [15:27:55] (03Merged) 10jenkins-bot: Introduce wikibase.experts.__namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172698 (owner: 10Adrian Lang) [15:27:57] (03Merged) 10jenkins-bot: Rename wikibase.experts.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172699 (owner: 10Adrian Lang) [15:41:28] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Confirmed by searching the code and a manual test." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172961 (owner: 10Adrian Lang) [15:44:04] omg, we used to have class "Skin extends Linker" :o [15:45:27] (03PS1) 10Thiemo Mättig (WMDE): Increase selector precedence for aliasesview in fingerprintview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173017 [15:45:27] aude: Well... when Article and EditPage were one ... [15:45:34] both are messy... imagine that in one class [15:45:36] ooooomg [15:47:02] hoo|lecture: we have the deployment calendar yeah. we can use that for anything we want really ;-) [15:47:19] Would be nice [15:47:30] if you or Tobi can arrange that [15:48:20] (03Merged) 10jenkins-bot: Remove dead styles and dead template [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172961 (owner: 10Adrian Lang) [15:51:32] JeroenDeDauw: :D true! but won't that mean everyone will just create an argument object for every method? [15:58:26] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/EmkJlw [15:58:26] 13WikidataBrowserTests/06master 147aaad9e 15Tobi Gritschacher: Merge pull request #26 from wmde/switch_to_singlequotes... [15:59:16] dennyvrandecic: people could hack around it by passing in maps or uncohesive objects yes. Though it at least nudges people away from primitive obsession and creation functions that do too many things [15:59:55] JeroenDeDauw: agreed :) [16:00:32] (03PS2) 10Thiemo Mättig (WMDE): Move formatters from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172965 (owner: 10Adrian Lang) [16:00:38] (03PS2) 10Thiemo Mättig (WMDE): Move parsers from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172966 (owner: 10Adrian Lang) [16:01:06] Lydia_WMDE: So will you (or Tobi) do that from next week on? Would be nice [16:01:10] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move jquery.ui.tagadata from Lib to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172964 (owner: 10Adrian Lang) [16:01:30] if people actually state their attendance [16:02:01] * aude doesn't want the entire team in evil meetings at deploy time [16:02:07] hoo|lecture: ok we need to put the deployments in the calendar again in the first place -.- [16:02:24] That's something to sart [16:02:26] will try to do that tomorrow [16:02:26] * start [16:02:27] then what is the point of early deploy time [16:02:33] and needs proper times (not just the days) [16:03:01] dennyvrandecic: you doing anything with functional languages? Writing just GO now? :) [16:03:11] at least that would be nice to set up reminders [16:03:23] * aude can ask who wants to skip evil meeting [16:03:33] maybe we'll find volunteers :P [16:03:55] Skip all the evil meetings [16:04:04] no idea what you're talking about, though [16:04:17] hoo|lecture: our meetings are usually 2pm on tuesdays [16:04:25] Oh, those, yeah [16:04:32] [13WikibaseDataModelJavaScript] 15thiemowmde 04deleted 06fingerprintemptyterm at 1477a9fd2: 02http://git.io/KqH5Sw [16:04:40] I have all the stuff in my calender and always not attending :D [16:04:48] :/ [16:04:51] * almost always [16:09:11] 3MediaWiki extensions / 3WikidataRepo: Ensure WikibaseDataModelSerialization feature parity with WikibaseLib - 10https://bugzilla.wikimedia.org/71170#c5 (10Daniel Kinzler) Of course i meant "the serialization we use in the database will often not be exactly the same as the one we use in the API". I agree wi... [16:09:32] How would I go about fetching all items that relate to a certain date? [16:10:26] Or if I can't search everything, a given property such as P585. [16:11:42] 3MediaWiki extensions / 3WikidataRepo: Saving a statement does not wait for the most recent parser API request - 10https://bugzilla.wikimedia.org/73373 (10Henning) 3NEW p:3Unprio s:3normal a:3Wikidata bugs When trying to save a statement while the parser request is still in the loop, the value valida... [16:11:45] w930913: we don't have any query capability yet. the external wdq tool may do what you want, though i'm not sure it supports date ranges [16:13:47] (03Merged) 10jenkins-bot: Move jquery.ui.tagadata from Lib to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172964 (owner: 10Adrian Lang) [16:13:58] (03Merged) 10jenkins-bot: Move formatters from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172965 (owner: 10Adrian Lang) [16:14:23] DanielK_WMDE_: So wikidata is a black hole at the moment? Lots of data goes in, but the only things to come out is the stuff on the horizon? :/ [16:15:16] w930913: you can get data out. data about items. it's no good at finding items yes. and yes, it's very sad, and we urgently need want to change that. [16:16:30] so, no, it's not a black hole, but it doesn't add that much value yet. wdq bridges that gab to some degree [16:16:34] https://wdq.wmflabs.org/ [16:17:21] Yeah, most/all of the stuff I've done so far has used the db and wdq, instead of the API :/ [16:18:19] I have code to do item["wife"]["died on"].year, but to get "item"... [16:21:55] [13WikidataBrowserTests] 15tobijat created 06switch_to_singlequotes (+1 new commit): 02http://git.io/JSAx-w [16:21:55] 13WikidataBrowserTests/06switch_to_singlequotes 14545db2c 15Tobias Gritschacher: Enforce single quotes [16:22:10] [13WikidataBrowserTests] 15tobijat opened pull request #27: Enforce single quotes (06master...06switch_to_singlequotes) 02http://git.io/Rm69zA [16:32:35] [13WikidataBrowserTests] 15tobijat 04force-pushed 06myMail from 1462ad91a to 14af83b9a: 02http://git.io/tjsRkQ [16:32:35] 13WikidataBrowserTests/06myMail 14af83b9a 15Thiemo Mättig: Remove my email address [16:33:19] How do I make P570 a subclass of P585? [16:33:34] you don't (yet) [16:33:45] when we have statements on properties [16:33:48] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06myMail: 02http://git.io/14y4jw [16:33:48] 13WikidataBrowserTests/06myMail 141d5984f 15Tobias Gritschacher: Allow non-ASCII characters in comments [16:33:50] statements on properties aren't there yet [16:33:54] maybe a few more weeks [16:33:56] will be possible but not yet unfortunately [16:34:18] [13WikidataBrowserTests] 15tobijat pushed 1 new commit to 06master: 02http://git.io/C8KoSA [16:34:18] 13WikidataBrowserTests/06master 14e37b3aa 15Tobi Gritschacher: Merge pull request #27 from wmde/switch_to_singlequotes... [16:35:46] (03PS2) 10Thiemo Mättig (WMDE): Move $.removeClassByRegex and $.sticknode to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172986 (owner: 10Adrian Lang) [16:36:19] [13WikidataBrowserTests] 15tobijat 04force-pushed 06myMail from 141d5984f to 142099599: 02http://git.io/tjsRkQ [16:36:19] 13WikidataBrowserTests/06myMail 149fcbc0d 15Thiemo Mättig: Remove my email address [16:36:19] 13WikidataBrowserTests/06myMail 142099599 15Tobias Gritschacher: Allow non-ASCII characters in comments [16:38:08] (03PS3) 10Thiemo Mättig (WMDE): Move $.removeClassByRegex and $.sticknode to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172986 (owner: 10Adrian Lang) [16:38:33] Hmm, item "instance of" item2 "subclass of" item 3. But not property "subclass of" x. [16:39:04] So why are some properties classed effectively as items? [16:41:00] (03PS4) 10Thiemo Mättig (WMDE): Move $.removeClassByRegex and $.sticknode to Repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172986 (owner: 10Adrian Lang) [16:42:02] w930913: that's the datatype of the property [16:42:08] some are of type wikibase items [16:42:11] those take items [16:42:15] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "I think I resolved the merge conflict. But because jquery.sticknode now depends on the new module jquery.util.EventSingletonManager (which" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172986 (owner: 10Adrian Lang) [17:04:22] [13WikidataBrowserTests] 15tobijat closed pull request #22: Remove my email address (06master...06myMail) 02http://git.io/NsQ8vw [17:04:28] [13WikidataBrowserTests] 15tobijat 04deleted 06myMail at 142099599: 02http://git.io/W6fQeg [17:04:58] <14WAAM463> [13WikidataBrowserTests] 15tobijat closed pull request #12: Add tags for testing on test.wikidata.org (06master...06add_tags) 02http://git.io/D7Um6g [17:04:58] <1JTAAZBMI> [13WikidataBrowserTests] 15tobijat 04deleted 06add_tags at 14c0ec063: 02http://git.io/1uHlSg [17:06:11] (03PS3) 10Thiemo Mättig (WMDE): Move all client tests to Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [17:08:01] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Turns out it was a very, very good idea to start a follow up that fixes the issues I found. I found so many more! See If6c96e0." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 (owner: 10Daniel Kinzler) [17:11:20] (03CR) 10jenkins-bot: [V: 04-1] Move all client tests to Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [17:19:18] (03PS1) 10Tobias Gritschacher: New Wikidata Build - 2014/11/13 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/173043 [17:21:31] (03CR) 10jenkins-bot: [V: 04-1] New Wikidata Build - 2014/11/13 [extensions/Wikidata] - 10https://gerrit.wikimedia.org/r/173043 (owner: 10Tobias Gritschacher) [17:21:55] oh noes [17:22:19] hmmmm [17:22:28] [13WikibaseDatabase] 15thiemowmde comment on pull request #60 143ce0098: How do you know it's an int? Just wondering. 02http://git.io/lmmZuQ [17:22:31] (03PS2) 10Tobias Gritschacher: Deferred sitelinkviews switching to edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173005 (https://bugzilla.wikimedia.org/73300) (owner: 10Henning Snater) [17:24:04] aude: DanielK_WMDE_ jzerebecki seems there are language-fallback related phpunit errors on the build: https://integration.wikimedia.org/ci/job/mwext-Wikidata-testextension/148/console [17:24:17] label lookup [17:24:36] no idea why these don't happen in wikibase tests alone [17:24:46] [13WikibaseDatabase] 15thiemowmde comment on pull request #60 143ce0098: `string[] $fieldNames` in the interface. 02http://git.io/ACD7hg [17:25:08] strange [17:25:21] aaaaaaaaaa [17:25:23] i see [17:25:26] fixing [17:25:33] ok :) [17:26:11] hurray for the build to catch these [17:30:28] [13WikibaseDatabase] 15thiemowmde comment on pull request #60 143ce0098: The alias is not optional? Uh, strange DBAL. 02http://git.io/ka4ntA [17:33:47] [13WikibaseDatabase] 15thiemowmde comment on pull request #60 143ce0098: You can use `andWhere` here. We did this in the DVHandlers. 02http://git.io/3E68zg [17:37:32] [13WikibaseDatabase] 15thiemowmde 04deleted 06DBALQueryInterface at 143ce0098: 02http://git.io/NZRbLA [17:57:43] Hi [18:04:22] (03PS1) 10Aude: Update label lookup tests, to check for exceptions and add @group tags [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/173056 [19:07:38] (03CR) 10Daniel Kinzler: [C: 032] Fix visibility of setUp/tearDown [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172679 (owner: 10Thiemo Mättig (WMDE)) [19:07:50] (03PS2) 10Daniel Kinzler: Fix visibility issues in Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172709 (owner: 10Thiemo Mättig (WMDE)) [19:16:38] (03Merged) 10jenkins-bot: Fix visibility of setUp/tearDown [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172679 (owner: 10Thiemo Mättig (WMDE)) [19:16:42] (03CR) 10jenkins-bot: [V: 04-1] Fix visibility issues in Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172709 (owner: 10Thiemo Mättig (WMDE)) [19:28:29] 3MediaWiki extensions / 3WikidataRepo: Introduce factory for JS views - 10https://bugzilla.wikimedia.org/73380 (10Adrian Lang) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Currently, all views (jquery.wikibase widgets) are immediately constructed wherever needed. This has several implications: * They a... [20:09:09] (03PS2) 10Daniel Kinzler: Introduce EntityInfo class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [20:09:19] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityInfo class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [20:09:47] (03PS3) 10Daniel Kinzler: Introduce EntityInfo class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [20:10:13] (03PS9) 10Daniel Kinzler: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (https://bugzilla.wikimedia.org/73264) (owner: 10Aude) [20:10:23] (03PS4) 10Daniel Kinzler: Introduce EntityInfo class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 [20:17:51] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityInfo class. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172796 (owner: 10Daniel Kinzler) [21:13:40] (03PS2) 10Addshore: More consistent variable naming, e.g. $languageCode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 (owner: 10Thiemo Mättig (WMDE)) [21:15:38] (03CR) 10Addshore: [C: 04-1] More consistent variable naming, e.g. $languageCode (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172572 (owner: 10Thiemo Mättig (WMDE)) [23:56:55] DanielK_WMDE_: Cracked it. https://tools.wmflabs.org/cluestuff/wdt/onthisday.cgi