[02:06:14] Anybody around? [02:07:40] ? [02:07:46] Do you need any help? [02:08:29] Sakurako: Yeah. [02:09:00] I'm trying to work out how to get Q463035 from "Douglas". [02:10:48] Sakurako: Can you help? [02:12:29] Are you using the API? Do you have DB access? Are you using WDQ? [02:12:54] or do you just want a solution using special pages? [02:13:28] huh: API/pywikibot/WQD/anything that can be accessed out of labs. [02:18:11] huh: I'm trying to get Q42, knowing only that his name is "Douglas Adams". [02:18:52] w930913: by label? [02:19:07] or using other name properties and alias? [02:19:08] So if I can find Q463035 from "Douglas" and likewise for "Adams", then I can WDQ to Q42. [02:19:14] just label: SELECT DISTINCT term_entity_id FROM wb_terms WHERE term_type='label' AND term_text='Douglas'; [02:19:34] huh: That's using the repdb though. [02:19:58] Oh, I thought by "out of labs" you meant "from labs" [02:20:07] :p [02:20:25] Is label the right way btw? [02:20:43] depends on the kind of entity [02:20:43] I couldn't see anything else linking Q463035 to "Douglas". [02:23:00] currently the API for Wikidata is not great [02:23:09] at all [02:24:59] Hmm, ok. I guess I'll hack a search by label API in labs. [02:25:07] huh: Thanks. [02:25:33] w930913: can't find any other way :/ [03:13:08] What's the difference between Q463035 and Q2677358? [03:13:27] huh: ^ [03:14:10] w930913: one is for surname, one is for given name [03:14:28] Q463035 is given name [03:14:36] huh: So why are they both instances of both given and surname? [03:14:46] they shouldn't be [03:15:03] and the description for Q2677358 should be changed to "surname" [03:15:05] IMO [03:27:17] w930913: is that a satisfactory answer? [03:57:25] huh: Yes, I fixed it. [03:57:48] huh: Is Q217431 also wrongly an instance of family name? [03:58:24] that's a disambiguation page if the English description is correct [03:58:47] huh: Is the family name part correct? [03:58:52] but I think it might also double as a surname page on some wikis [03:58:58] I'm not sure [03:59:27] Because if it is, then we have two "Adams" surname pages. [04:00:10] w930913: I think surname=Q351735, Q217431=disambig [04:00:25] but there may be some overlapping sitelinks [04:01:45] huh: Sure, but can both be "Adams" instanceOf "family name"? [04:03:47] I don't think the disambig should have it, but you should ask on WD:PC or perhaps https://www.wikidata.org/wiki/Property_talk:P31 [06:21:55] 3MediaWiki extensions / 3WikidataRepo: Query by one property and one value (tracking) - 10https://bugzilla.wikimedia.org/52385#c4 (10jeblad) What is the present status on this? [06:57:17] Was wiri ever ported to labs? [06:57:26] https://twitter.com/MagnusManske/status/316629168450310144 links to the TS, which is dead :( [07:45:02] [13ValueView] 15snaterlicious created 06highlightsubstringcase (+1 new commit): 02http://git.io/MXs3MA [07:45:02] 13ValueView/06highlightsubstringcase 14531601e 15snaterlicious: util.highlightSubstring: Replaced "caseInsensitive" option... [07:45:32] [13ValueView] 15snaterlicious opened pull request #131: util.highlightSubstring: Replaced "caseInsensitive" option (06master...06highlightsubstringcase) 02http://git.io/7PvJ5w [07:59:59] legoktm: http://tools.wmflabs.org/magnus-toolserver/thetalkpage/ [08:00:12] meh [08:00:16] at least that is where it was [08:00:20] :/ [08:00:28] thanks though :) [08:01:10] legoktm: might be another one of magnus webservers being killed [08:01:12] not sure [08:53:45] Lydia_WMDE: I notice that there are MANY issues with the continuity in Widar jobs [08:54:27] Magnus has it now auto-re-start at the client side but it still crashes with bad API responses [08:54:45] hmmmm [08:54:48] are you aware that this is not stable ? [08:54:51] do you know what these responses are? [08:54:55] no [08:55:10] Bad API responsie [1] Null [08:55:42] we'll need the call and the exact response to debug this i fear :( [08:56:34] I cannot help you with that [08:57:13] ok [08:57:16] [13ValueView] 15thiemowmde comment on pull request #131 14531601e: Could save a `!` by turning into `options.caseSensitive ? '' : 'i'`. ;-) 02http://git.io/yZRMQQ [08:57:19] i will ping magnus [08:57:30] thanks [08:57:45] [13ValueView] 15thiemowmde comment on pull request #131 14531601e: `false`? 02http://git.io/0sWjVw [08:57:59] someone else is annotating categories I found [08:58:38] 1544 do now include statements that enable queries for the content [08:58:46] http://tools.wmflabs.org/autolist/autolist1.html?q=CLAIM%5B31%3A4167836%5D%20AND%20CLAIM%5B360%3A5%5D# [08:59:44] [13ValueView] 15thiemowmde pushed 1 new commit to 06highlightsubstringcase: 02http://git.io/Jy6xZg [08:59:44] 13ValueView/06highlightsubstringcase 14b26b953 15thiemowmde: Update util.highlightSubstring.js... [09:01:45] [13ValueView] 15thiemowmde 04deleted 06highlightsubstringcase at 14b26b953: 02http://git.io/Q6N-WQ [09:02:06] [13ValueView] 15thiemowmde comment on pull request #131 14b26b953: Damn, missed that. 02http://git.io/JCHhfw [09:04:57] Henning_WMDE: Y u no review https://gerrit.wikimedia.org/r/171868 and https://gerrit.wikimedia.org/r/171862 [09:07:29] 3MediaWiki extensions / 3WikidataRepo: Implement deferred switch to edit mode - 10https://bugzilla.wikimedia.org/73300 (10Henning) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Due to the amount of widgets involved, toggling edit mode has quite a big performance footprint. While bug #73221 will resolve q... [09:07:35] [13ValueView] 15thiemowmde pushed 1 new commit to 06master: 02http://git.io/YRgRbA [09:07:35] 13ValueView/06master 1439ab922 15thiemowmde: Fix mistake from #131 [09:10:24] (03PS1) 10Thiemo Mättig (WMDE): Replaced "caseInsensitive" option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172675 [09:15:42] (03CR) 10Henning Snater: [C: 032] Allow submitting linkItem form with enter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171868 (https://bugzilla.wikimedia.org/72712) (owner: 10Hoo man) [09:16:48] (03CR) 10Henning Snater: [C: 032] Move the linkItem dialog to the top [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171862 (https://bugzilla.wikimedia.org/72687) (owner: 10Hoo man) [09:17:20] thanks :) [09:18:28] hoo|lecture: You're welcome. [09:19:23] (03CR) 10Aude: [C: 04-1] "minor / easy to fix issues" (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) (owner: 10Hoo man) [09:20:31] Emtpy :P [09:20:48] (03PS2) 10Aude: Remove dashed bottom-border from last child of .wb-statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172027 (https://bugzilla.wikimedia.org/73172) [09:21:10] (03Draft1) 10Aude: Throw StorageException in EntityTermLookup for non-existing entities [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172652 [09:21:32] (03Draft3) 10Aude: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 [09:24:00] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Move templates from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172547 (owner: 10Adrian Lang) [09:27:52] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Remove dashed bottom-border from last child of .wb-statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172027 (https://bugzilla.wikimedia.org/73172) (owner: 10Aude) [09:28:33] (03Merged) 10jenkins-bot: Allow submitting linkItem form with enter [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171868 (https://bugzilla.wikimedia.org/72712) (owner: 10Hoo man) [09:28:43] (03Merged) 10jenkins-bot: Move the linkItem dialog to the top [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171862 (https://bugzilla.wikimedia.org/72687) (owner: 10Hoo man) [09:29:55] 3MediaWiki extensions / 3WikidataClient: Popup is poorly positioned, causing unnecessary scrolling - 10https://bugzilla.wikimedia.org/72687 (10Marius Hoch) 5PATC>3RESO/FIX [09:30:26] 3MediaWiki extensions / 3WikidataRepo: write browser tests for rank change - 10https://bugzilla.wikimedia.org/67363 (10tobias.gritschacher) 5NEW>3ASSI [09:30:42] 3MediaWiki extensions / 3WikidataRepo: write browser tests for snak type changes - 10https://bugzilla.wikimedia.org/67364 (10tobias.gritschacher) 5NEW>3ASSI [09:31:11] 3MediaWiki extensions / 3WikidataClient: ENTER should submit the "Link with page" popup when adding a new site links from client - 10https://bugzilla.wikimedia.org/72712 (10Marius Hoch) 5PATC>3RESO/FIX [09:31:37] Lydia_WMDE: WONTFIX https://bugzilla.wikimedia.org/show_bug.cgi?id=72807 ? [09:32:28] (03Merged) 10jenkins-bot: Move templates from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172547 (owner: 10Adrian Lang) [09:33:24] (03Merged) 10jenkins-bot: Remove dashed bottom-border from last child of .wb-statementview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172027 (https://bugzilla.wikimedia.org/73172) (owner: 10Aude) [09:33:42] [13WikibaseDatabase] 15thiemowmde comment on pull request #60 1466d4178: As said, this is completely unrelated to this pull request (you are not even introducing the "integration" directory here, it was there before). Please do this in a separate patch. 02http://git.io/S_45Fg [09:36:42] [13WikibaseDatabase] 15thiemowmde comment on pull request #60 1466d4178: `Statement` is not used in this file. 02http://git.io/9zci4w [09:37:25] 3MediaWiki extensions / 3WikidataRepo: extra (dashed) border at bottom of statement view in non-js - 10https://bugzilla.wikimedia.org/73172 (10Aude) 5PATC>3RESO/FIX [09:38:58] 3MediaWiki extensions / 3WikidataRepo: Stop using Property::getClaims in PropertyView - 10https://bugzilla.wikimedia.org/73278 (10Aude) [09:38:58] 3MediaWiki extensions / 3WikidataRepo: Rollout of statements on properties with old serialization code - 10https://bugzilla.wikimedia.org/72314 (10Aude) [09:39:17] Tobi_WMDE_SW: is https://bugzilla.wikimedia.org/show_bug.cgi?id=73279 blocker for statement on properties? [09:39:25] * aude thinks so [09:39:25] 3MediaWiki extensions / 3WikidataRepo: Implement deferred switch to edit mode - 10https://bugzilla.wikimedia.org/73300 (10tobias.gritschacher) 5NEW>3ASSI p:5Unprio>3Normal [09:41:14] (03PS4) 10Hoo man: Don't load the full entity into Lua to get labels/ sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) [09:42:09] (03CR) 10Hoo man: Don't load the full entity into Lua to get labels/ sitelinks (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) (owner: 10Hoo man) [09:42:10] 3MediaWiki extensions / 3WikidataRepo: Exception from line 202 of ClaimSerializer.php: Invalid claim type specified - 10https://bugzilla.wikimedia.org/71641#c3 (10Aude) 5NEW>3RESO/WOR don't think this happens anymore [09:42:44] (03CR) 10Hoo man: "Addressed Katie's comments" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) (owner: 10Hoo man) [09:42:49] aude: Now merge!!111 [09:45:08] when i come to the office, yes [09:45:11] 3MediaWiki extensions / 3WikidataRepo: Split EntityIdFormatter from EntityIdValueFormatter - 10https://bugzilla.wikimedia.org/63308 (10Aude) 5ASSI>3NEW [09:45:19] and before making the branch :) [09:45:25] You're at home? [09:45:29] yes [09:45:33] having it in the new branch woulod be awesome [09:45:43] +9000 [09:57:31] JeroenDeDauw: https://www.mediawiki.org/wiki/Phabricator#Migration_timeline [09:58:03] aude: might be [10:02:13] (03PS1) 10Thiemo Mättig (WMDE): Add missing method visibility everywhere [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172678 [10:07:17] (03PS1) 10Thiemo Mättig (WMDE): Fix visibility of setUp/tearDown [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172679 [10:08:16] (03CR) 10Adrian Lang: "Great change except for one small thing." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 (owner: 10Henning Snater) [10:09:29] (03PS1) 10Henning Snater: Removed exclusive edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172680 [10:10:10] 3MediaWiki extensions / 3WikidataRepo: remove the exclusive edit mode behaviour - 10https://bugzilla.wikimedia.org/73221#c1 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/172680/ [10:10:49] (03PS1) 10Adrian Lang: Remove singleton pattern from TemplateRegistry [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172681 [10:12:56] [13WikibaseInternalSerialization] 15thiemowmde created 06protected (+1 new commit): 02http://git.io/5FGmhw [10:12:56] 13WikibaseInternalSerialization/06protected 14fe2ae7f 15Thiemo Mättig: Fix Fix visibility of setUp/tearDown [10:13:11] [13WikibaseInternalSerialization] 15thiemowmde opened pull request #40: Fix Fix visibility of setUp/tearDown (06master...06protected) 02http://git.io/p6ZSuA [10:14:37] (03CR) 10jenkins-bot: [V: 04-1] Add missing method visibility everywhere [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172678 (owner: 10Thiemo Mättig (WMDE)) [10:14:53] (03PS5) 10Henning Snater: Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 [10:16:04] (03CR) 10Adrian Lang: "wikibase-error-ui-no-external-page is still used in SpecialSetSiteLink.php. wikibase-api-no-external-page is not marked as DO NOT TRANSLAT" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171247 (owner: 10Adrian Lang) [10:20:00] (03CR) 10jenkins-bot: [V: 04-1] Fix visibility of setUp/tearDown [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172679 (owner: 10Thiemo Mättig (WMDE)) [10:22:22] (03CR) 10Adrian Lang: [C: 032] Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 (owner: 10Henning Snater) [10:22:55] 3MediaWiki extensions / 3WikidataRepo: remove the exclusive edit mode behaviour - 10https://bugzilla.wikimedia.org/73221#c2 (10Henning) This significantly speeds up toggling edit mode, especially switching to edit mode. [10:23:13] [13WikibaseDataModel] 15JeroenDeDauw 04deleted 06coverage at 14a46ef81: 02http://git.io/ayJzSw [10:27:49] (03Merged) 10jenkins-bot: Use wb.datamodel.MultiTerm in aliasesview/AliasesChanger [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171841 (owner: 10Henning Snater) [10:27:58] (03PS5) 10Adrian Lang: Use wb.datamodel.Term in labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171860 (owner: 10Henning Snater) [10:30:37] (03PS4) 10Adrian Lang: Use wb.datamodel.Term in descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171878 (owner: 10Henning Snater) [10:30:44] (03PS2) 10Adrian Lang: Added TemplatedWidget QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172506 (owner: 10Henning Snater) [10:30:49] (03PS6) 10Adrian Lang: Implemented EditableTemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172507 (owner: 10Henning Snater) [10:34:04] * hoo|lecture leaves [10:35:13] 3MediaWiki extensions / 3WikidataRepo: allow statements on properties - 10https://bugzilla.wikimedia.org/49554 (10Lydia Pintscher) 5VERI>3REOP [10:35:54] (03PS1) 10Henning Snater: Always display calendar name for dates not Gregorian > 1581 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172683 [10:36:39] 3MediaWiki extensions / 3WikidataRepo: Always display calendar name for dates that are not Gregorian after year 1581 - 10https://bugzilla.wikimedia.org/73270#c1 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/172683/ [10:38:27] [13WikibaseQuery] 15thiemowmde created 06protected (+1 new commit): 02http://git.io/gvC9sQ [10:38:27] 13WikibaseQuery/06protected 14ee4a7f9 15Thiemo Mättig: Fix visibility level of properties and methods [10:39:06] [13WikibaseQuery] 15thiemowmde opened pull request #57: Fix visibility level of properties and methods (06master...06protected) 02http://git.io/BNhM0w [10:41:59] wmde/WikibaseQuery/protected/ee4a7f9 : Thiemo Mättig The build failed. http://travis-ci.org/wmde/WikibaseQuery/builds/40759802 [10:43:11] 3MediaWiki extensions / 3WikidataRepo: allow statements on properties - 10https://bugzilla.wikimedia.org/49554 (10Lydia Pintscher) [10:43:15] 3MediaWiki extensions / 3WikidataRepo: new datatype for linking to properties - 10https://bugzilla.wikimedia.org/73302 (10Lydia Pintscher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We need a way to refer to other properties when we roll out statements on properties. This will be used to indicate thin... [10:43:39] (03CR) 10Adrian Lang: [C: 032] Use wb.datamodel.Term in labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171860 (owner: 10Henning Snater) [10:49:12] (03Merged) 10jenkins-bot: Use wb.datamodel.Term in labelview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171860 (owner: 10Henning Snater) [11:05:40] 3MediaWiki extensions / 3WikidataRepo: populate entity usage table during database schema update - 10https://bugzilla.wikimedia.org/73220 (10Daniel Kinzler) [11:05:42] 3MediaWiki extensions / 3WikidataClient: Maintenance scripts for populating the entity_usage table from the item_per_site table. - 10https://bugzilla.wikimedia.org/71050 (10Daniel Kinzler) [11:05:47] Tobi_WMDE_SW: https://bugzilla.wikimedia.org/show_bug.cgi?id=73220 (possibly followed by 71050) [11:06:07] Tobi_WMDE_SW: will you put it on the board, too? [11:06:41] 3MediaWiki extensions / 3WikidataRepo: new datatype for linking to properties - 10https://bugzilla.wikimedia.org/73302 (10Lydia Pintscher) p:5Unprio>3High [11:06:46] (03PS1) 10Adrian Lang: Inject dataTypes into expert store creation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172685 [11:07:37] DanielK_WMDE: https://bugzilla.wikimedia.org/show_bug.cgi?id=45925 <- can you have a look please? [11:07:52] Tobi_WMDE_SW: i can put it on the board if you want [11:09:01] (03PS1) 10Adrian Lang: Remove unused module dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172686 [11:09:18] Lydia_WMDE: yes, please [11:09:33] k [11:09:39] Adrian_WMDE: Henning_WMDE running tests now [11:09:44] Yeah [11:09:53] label, description, aliases, statements fine already [11:12:10] 3MediaWiki extensions / 3WikidataRepo: populate entity usage table during database schema update - 10https://bugzilla.wikimedia.org/73220 (10Lydia Pintscher) [11:13:55] 3MediaWiki extensions / 3WikidataRepo: Query by one property and one value (tracking) - 10https://bugzilla.wikimedia.org/52385#c5 (10Lydia Pintscher) There are remaining bugs that need to be worked on. See the blockers. Then it needs to go through review at the Wikimedia Foundation again. I hope we have the... [11:16:50] 3MediaWiki extensions / 3WikidataRepo: populate entity usage table during database schema update - 10https://bugzilla.wikimedia.org/73220 (10Lydia Pintscher) 5NEW>3ASSI [11:16:51] 3MediaWiki extensions / 3WikidataRepo: Use terms-lookup service in EntityID formatters - 10https://bugzilla.wikimedia.org/72036 (10tobias.gritschacher) [11:16:51] 3MediaWiki extensions / 3WikidataRepo: Use terms-lookup service in EntityID formatters - 10https://bugzilla.wikimedia.org/72036 (10tobias.gritschacher) [11:18:26] 3MediaWiki extensions / 3WikidataRepo: Reuse EntityInfoBuilder arrays when generating html - 10https://bugzilla.wikimedia.org/62724 (10tobias.gritschacher) [11:19:13] 3MediaWiki extensions / 3WikidataRepo: Reuse EntityInfoBuilder arrays when generating html - 10https://bugzilla.wikimedia.org/62724 (10tobias.gritschacher) [11:21:30] (03PS1) 10Henning Snater: Split off site links HTML structure from main entity HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172687 [11:22:25] 3MediaWiki extensions / 3WikidataRepo: Sitelink UI: wrap everything except sitelinks in separate div - 10https://bugzilla.wikimedia.org/73276#c1 (10Henning) 5ASSI>3PATC https://gerrit.wikimedia.org/r/#/c/172687/ [11:24:36] (03CR) 10Aude: [C: 032] "tested manually, etc. and looks good :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) (owner: 10Hoo man) [11:25:05] (03PS2) 10Henning Snater: Split off site links HTML structure from main entity HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172687 [11:30:41] 3MediaWiki extensions / 3WikidataRepo: Make SqlStore::rebuildPropertyInfo non-static - 10https://bugzilla.wikimedia.org/73261 (10Lydia Pintscher) p:5Unprio>3Normal [11:33:10] 3MediaWiki extensions / 3WikidataRepo: Time-Parser should detect most likely calendar - 10https://bugzilla.wikimedia.org/73272 (10Lydia Pintscher) p:5Normal>3High [11:33:57] 3MediaWiki extensions / 3WikidataRepo: Stop using Property::getClaims in PropertyView - 10https://bugzilla.wikimedia.org/73278 (10Lydia Pintscher) p:5Unprio>3High [11:33:57] (03Merged) 10jenkins-bot: Don't load the full entity into Lua to get labels/ sitelinks [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171992 (https://bugzilla.wikimedia.org/71743) (owner: 10Hoo man) [11:34:40] 3MediaWiki extensions / 3WikidataRepo: Refactor ClaimsView and related php View code to work more nicely with statements - 10https://bugzilla.wikimedia.org/73279 (10Lydia Pintscher) p:5Unprio>3Normal [11:35:28] 3MediaWiki extensions / 3WikidataRepo: Inject variationsFactory into snakview - 10https://bugzilla.wikimedia.org/73306 (10Adrian Lang) 3NEW p:3Unprio s:3normal a:3Wikidata bugs This would allow us to not have to pass entityStore, valueViewBuilder and dataTypeStore to all our widgets, but just the var... [11:37:41] 3MediaWiki extensions / 3WikidataClient: LUA functions mw.wikibase.label and mw.wikibase.sitelink should not load the whole entity into memory - 10https://bugzilla.wikimedia.org/71743 (10Lydia Pintscher) 5PATC>3RESO/FIX [11:38:10] 3MediaWiki extensions / 3WikidataRepo: Efficient entity label lookup (tracking) - 10https://bugzilla.wikimedia.org/73087 (10Lydia Pintscher) s:5normal>3major [11:47:06] (03PS1) 10Adrian Lang: Inject dataTypeStore into snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 [11:49:06] wikimedia/mediawiki-extensions-Wikibase/wmf/1.25wmf8/9e85767 : jenkins-bot The build passed. http://travis-ci.org/wikimedia/mediawiki-extensions-Wikibase/builds/40764688 [11:51:54] (03CR) 10Adrian Lang: [C: 032] "Great change except for one cosmetic issue I found." (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171878 (owner: 10Henning Snater) [11:53:06] (03CR) 10Tobias Gritschacher: [V: 032] "Browsertests successful." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172523 (owner: 10Adrian Lang) [11:53:20] Adrian_WMDE: verified https://gerrit.wikimedia.org/r/#/c/172523/ [11:53:42] (03CR) 10Henning Snater: [C: 032] Move wikibase.RepoApi{,Error} to wikibase.api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172522 (owner: 10Adrian Lang) [11:53:53] (03CR) 10Henning Snater: [C: 032] Move RepoApi{,Error} usages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172523 (owner: 10Adrian Lang) [11:54:12] (03CR) 10Adrian Lang: [C: 032] Added TemplatedWidget QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172506 (owner: 10Henning Snater) [11:54:41] (03CR) 10Adrian Lang: "TemplatedWidget was moved to repo/, sorry." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172506 (owner: 10Henning Snater) [11:57:26] (03CR) 10Henning Snater: [C: 032] Replaced "caseInsensitive" option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172675 (owner: 10Thiemo Mättig (WMDE)) [12:04:47] (03CR) 10Adrian Lang: [C: 032] Always display calendar name for dates not Gregorian > 1581 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172683 (owner: 10Henning Snater) [12:05:26] (03Merged) 10jenkins-bot: Use wb.datamodel.Term in descriptionview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171878 (owner: 10Henning Snater) [12:08:03] (03CR) 10Adrian Lang: [C: 032] "Needs parser cache bump." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172687 (owner: 10Henning Snater) [12:09:06] (03PS3) 10Henning Snater: Added TemplatedWidget QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172506 [12:09:57] (03CR) 10Adrian Lang: [C: 032] Removed exclusive edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172680 (owner: 10Henning Snater) [12:12:15] (03PS4) 10Henning Snater: Added TemplatedWidget QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172506 [12:14:08] (03Merged) 10jenkins-bot: Move wikibase.RepoApi{,Error} to wikibase.api [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172522 (owner: 10Adrian Lang) [12:14:10] (03Merged) 10jenkins-bot: Move RepoApi{,Error} usages [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172523 (owner: 10Adrian Lang) [12:15:26] (03PS1) 10Adrian Lang: Move RepoApi files [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172696 [12:15:40] 3Wikimedia / 3Wikidata: Add irc schema to urlSchemes configuration - 10https://bugzilla.wikimedia.org/73091 (10Christopher Johnson) 5RESO/FIX>3REOP [12:17:41] 3Wikimedia / 3Wikidata: Add irc schema to urlSchemes configuration - 10https://bugzilla.wikimedia.org/73091 (10Christopher Johnson) 5REOP>3RESO/FIX [12:18:41] 3MediaWiki extensions / 3WikidataRepo: Highlighting is completely missing - 10https://bugzilla.wikimedia.org/66433 (10Henning) 5PATC>3RESO/FIX [12:21:11] 3MediaWiki extensions / 3WikidataRepo: write browser tests for rank change - 10https://bugzilla.wikimedia.org/67363 (10tobias.gritschacher) 5ASSI>3PATC [12:26:30] (03Merged) 10jenkins-bot: Replaced "caseInsensitive" option [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172675 (owner: 10Thiemo Mättig (WMDE)) [12:26:32] (03Merged) 10jenkins-bot: Always display calendar name for dates not Gregorian > 1581 [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172683 (owner: 10Henning Snater) [12:26:34] (03Merged) 10jenkins-bot: Split off site links HTML structure from main entity HTML [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172687 (owner: 10Henning Snater) [12:27:12] 3MediaWiki extensions / 3WikidataRepo: Always display calendar name for dates that are not Gregorian after year 1581 - 10https://bugzilla.wikimedia.org/73270 (10Henning) 5PATC>3RESO/FIX [12:27:25] (03PS1) 10Adrian Lang: Move wikibase.utilities from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172697 [12:27:25] 3MediaWiki extensions / 3WikidataRepo: Sitelink UI: wrap everything except sitelinks in separate div - 10https://bugzilla.wikimedia.org/73276 (10Henning) 5PATC>3RESO/FIX [12:27:54] (03Merged) 10jenkins-bot: Removed exclusive edit mode [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172680 (owner: 10Henning Snater) [12:28:28] 3MediaWiki extensions / 3WikidataRepo: remove the exclusive edit mode behaviour - 10https://bugzilla.wikimedia.org/73221 (10Henning) 5PATC>3RESO/FIX [12:29:11] 3MediaWiki extensions / 3WikidataRepo: IE11: Empty label/description input box loses focus after typing first character - 10https://bugzilla.wikimedia.org/72027#c1 (10Henning) 5NEW>3RESO/FIX Implicitly fixed by https://gerrit.wikimedia.org/r/#/c/172680/. [12:29:40] 3MediaWiki extensions / 3WikidataRepo: click edit for aliases (there are none yet) and it doesn't auto-focus on the input box - 10https://bugzilla.wikimedia.org/72691#c4 (10Henning) 5NEW>3RESO/FIX Implicitly fixed by https://gerrit.wikimedia.org/r/#/c/172680/. [12:29:55] (03PS5) 10Henning Snater: Added TemplatedWidget QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172506 [12:30:03] (03PS7) 10Henning Snater: Implemented EditableTemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172507 [12:33:19] (03CR) 10Henning Snater: [C: 032] Inject dataTypes into expert store creation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172685 (owner: 10Adrian Lang) [12:34:16] (03CR) 10Henning Snater: [C: 032] Remove unused module dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172686 (owner: 10Adrian Lang) [12:37:01] Henning_WMDE: https://bugzilla.wikimedia.org/73306 [12:38:04] getting a lot of timeouts today [12:42:45] (03CR) 10Adrian Lang: [C: 032] Added TemplatedWidget QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172506 (owner: 10Henning Snater) [12:44:55] (03CR) 10Adrian Lang: "Does not need parser cache bump, since the JS is still compatible with the old HTML." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172687 (owner: 10Henning Snater) [12:45:54] (03Merged) 10jenkins-bot: Inject dataTypes into expert store creation [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172685 (owner: 10Adrian Lang) [12:45:56] (03Merged) 10jenkins-bot: Remove unused module dependency [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172686 (owner: 10Adrian Lang) [12:46:27] (03PS1) 10Adrian Lang: Introduce wikibase.experts.__namespace [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172698 [12:46:29] (03PS1) 10Adrian Lang: Rename wikibase.experts.js [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172699 [12:48:15] Hello, what is the easiest way to get a Q from a wikipedia page title ? I have page titles from French articles and would like to get the wikidata Q for each, using openrefine where I can easilly request json, is there a request in the mediawiki API that could fulfill my need ? [12:51:40] (03Merged) 10jenkins-bot: Added TemplatedWidget QUnit tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172506 (owner: 10Henning Snater) [13:02:22] (03PS1) 10Aude: New deployment build: wmf/1.25wmf8 [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/172701 [13:04:51] wow, +24622, -10455 since last deployment [13:06:47] don't know that this includes delete files [13:08:26] (03CR) 10Aude: [C: 032] New deployment build: wmf/1.25wmf8 [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/172701 (owner: 10Aude) [13:09:38] (03PS1) 10Thiemo Mättig (WMDE): Unify top factory getter implementations [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172703 [13:10:56] (03Merged) 10jenkins-bot: New deployment build: wmf/1.25wmf8 [extensions/Wikidata] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/172701 (owner: 10Aude) [13:12:18] (03PS2) 10Thiemo Mättig (WMDE): Add missing method visibility in all Lib/Repo classes [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172678 [13:13:25] (03PS2) 10Adrian Lang: Inject dataTypeStore into snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172692 [13:13:27] (03PS1) 10Adrian Lang: Move wikibase.dataTypes from lib to repo [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172704 [13:14:32] (03PS2) 10Thiemo Mättig (WMDE): Fix visibility of setUp/tearDown [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172679 [13:15:21] (03CR) 10Adrian Lang: "Needs manual rebase :/" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/167799 (owner: 10Thiemo Mättig (WMDE)) [13:18:51] (03CR) 10Adrian Lang: Move ChangeHandler and friends to new namespace. (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170967 (owner: 10Daniel Kinzler) [13:19:47] (03PS1) 10Thiemo Mättig (WMDE): Fix visibility issues in Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172709 [13:22:41] (03CR) 10Adrian Lang: [C: 04-1] "The indentation style in the preg_match call does not look like we do it to me. Otherwise good change." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172289 (owner: 10Thiemo Mättig (WMDE)) [13:23:32] (03CR) 10Adrian Lang: "I think the EditableTemplatedWidget should be implemented in repo/." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172507 (owner: 10Henning Snater) [13:25:25] (03PS4) 10Aude: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 [13:25:33] (03CR) 10jenkins-bot: [V: 04-1] Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (owner: 10Aude) [13:26:30] aaaaah, who changed EntityView? :P [13:26:51] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "I'm afraid I'm a bit nitpicky about stuff that can be changed/fixed later but I think it's easier to stuff it in this patch." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172681 (owner: 10Adrian Lang) [13:27:16] aude: Henning did and I merged it :D [13:27:46] doesn't look too bad of a merge conflict [13:28:23] (03CR) 10jenkins-bot: [V: 04-1] Fix visibility issues in Scribunto tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172709 (owner: 10Thiemo Mättig (WMDE)) [13:29:53] (03CR) 10Adrian Lang: Remove singleton pattern from TemplateRegistry (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172681 (owner: 10Adrian Lang) [13:34:23] (03PS5) 10Aude: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 [13:34:25] (03PS13) 10Aude: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 [13:36:55] 3MediaWiki extensions / 3WikidataRepo: populate entity usage table during database schema update - 10https://bugzilla.wikimedia.org/73220#c1 (10Daniel Kinzler) We can use the info in page_props to populate untity_usage [13:39:11] untity? [13:42:22] symac: does this help?: https://www.wikidata.org/wiki/Special:ItemByTitle [13:43:49] untity again? that negation of entity seems to be pretty resistant :) [13:44:01] not an entity [13:44:04] usage [13:45:51] (03PS1) 10Thiemo Mättig (WMDE): Move all client tests to Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [13:46:00] (03CR) 10jenkins-bot: [V: 04-1] Move all client tests to Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [13:51:59] (03CR) 10Thiemo Mättig (WMDE): [C: 032] "Let's move. See my follow up If6c96e0 for the namespace mistake. Please create a bug for ChangeNotificationJob which uses Lib in Client (v" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170967 (owner: 10Daniel Kinzler) [13:54:14] Adrian_WMDE: https://gerrit.wikimedia.org/r/#/c/168632/ [13:54:39] jzerebecki, it redirects me to the correct page but I can't easily use it in openrefine. What I would like is something where I could construct a GET url like wikidata.org/api.php?q=&action...&format=json where the result would contain something I can parse that contains the Q# [13:56:42] 3MediaWiki extensions / 3WikidataRepo: After editing a claim's rank, the UI is left in an inconsistent state. - 10https://bugzilla.wikimedia.org/73307 (10Daniel Kinzler) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Reproduce: change the rank of a claim, click edit. Expected: UI exist edit mode after su... [13:58:29] (03Merged) 10jenkins-bot: Move ChangeHandler and friends to new namespace. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170967 (owner: 10Daniel Kinzler) [13:58:40] 3MediaWiki extensions / 3WikidataClient: Maintenance scripts for populating the entity_usage table from the item_per_site table. - 10https://bugzilla.wikimedia.org/71050#c1 (10Daniel Kinzler) removed "based on items_per_site" from description, since we'll probably use page_props instead. [13:59:39] (03PS8) 10Henning Snater: Implemented EditableTemplatedWidget [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172507 [14:00:27] 3MediaWiki extensions / 3WikidataRepo: After editing a claim's rank, the UI is left in an inconsistent state. - 10https://bugzilla.wikimedia.org/73307 (10Daniel Kinzler) s:5normal>3critic [14:00:37] Lydia_WMDE: --^ [14:00:40] 3MediaWiki extensions / 3WikidataRepo: After editing a claim's rank, the UI is left in an inconsistent state. - 10https://bugzilla.wikimedia.org/73307 (10Daniel Kinzler) s:5critic>3blocke [14:01:04] (03PS2) 10Thiemo Mättig (WMDE): Move all client tests to Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 [14:01:06] Adrian_WMDE: hoo's patch doesn't appear to be for non-js [14:01:11] (03CR) 10jenkins-bot: [V: 04-1] Move all client tests to Wikibase\Client\Tests [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172711 (owner: 10Thiemo Mättig (WMDE)) [14:01:21] it's only using php to add the link but not for non-js [14:03:57] 3MediaWiki extensions / 3WikidataRepo: test what happen when putting a TermFallback or AliasGroupFallback into wbeditentity - 10https://bugzilla.wikimedia.org/73308 (10Jan Zerebecki) 3NEW p:3Unprio s:3major a:3Wikidata bugs Test what happen when putting a TermFallback or AliasGroupFallback into wbedi... [14:05:24] 3MediaWiki extensions / 3WikidataRepo: New serialization code needs to support language fallback - 10https://bugzilla.wikimedia.org/72183 (10Jan Zerebecki) [14:05:39] (03CR) 10Aude: [C: 031] "if no one else wants to review this, then i shall merge later" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [14:05:40] 3MediaWiki extensions / 3WikidataRepo: test what happen when putting a TermFallback or AliasGroupFallback into wbeditentity - 10https://bugzilla.wikimedia.org/73308 (10Jan Zerebecki) [14:06:04] aude: Do we have a special page for creating an item with a sitelink? [14:06:35] special:new item? [14:07:20] Ah, right [14:08:10] (03CR) 10Adrian Lang: [C: 04-1] Create add links link in PHP (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [14:08:15] e.g. Special:NewItem?site=enwiki&page=Berlin [14:08:28] it's magic but think we link to it some places [14:08:33] like Special:ItemByTitle [14:10:26] (03PS3) 10Adrian Lang: Removed obsolete $.TemplatedWidget alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171567 (owner: 10Henning Snater) [14:10:34] (03CR) 10jenkins-bot: [V: 04-1] Removed obsolete $.TemplatedWidget alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171567 (owner: 10Henning Snater) [14:10:50] Henning_WMDE: aude: can you go to http://wikidata.beta.wmflabs.org/wiki/Q35748 and click on "add reference"? do you get a n JS error? [14:11:16] I'm getting one when I do it in an incognito tab [14:11:25] 3MediaWiki extensions / 3WikidataRepo: Inject variationsFactory into snakview - 10https://bugzilla.wikimedia.org/73306 (10Lydia Pintscher) p:5Unprio>3Normal [14:11:28] looking [14:11:39] seems still related to the new JS datamodel [14:11:51] i get error simply when loading the page [14:11:55] (03CR) 10Daniel Kinzler: "No objections, the code looks fine. No idea whether it works :)" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [14:12:01] might be authority gadget [14:12:03] works for me [14:12:05] aude: which errors? [14:12:32] now it's gone :/ [14:13:18] Uncaught TypeError: undefined is not a function when clicking add reference [14:13:59] with debug=true, no error [14:14:42] 3MediaWiki extensions / 3WikidataClient: Wikidata's JS tool at Wikipedia doesn't recognize Template:category redirect - 10https://bugzilla.wikimedia.org/73254#c1 (10Lydia Pintscher) Can you explain further what you mean? I don't understand it unfortunately. [14:15:05] symac: perhaps this one then: https://www.wikidata.org/w/api.php?action=help&modules=wbgetentities [14:18:25] jzerebecki, exactly ! Thanks for the pointer [14:18:34] you're welcome [14:20:35] Nov 11 11:44 ext.PropertySuggester.EntitySelector.js [14:21:10] 3MediaWiki extensions / 3WikidataRepo: localize display of time values - 10https://bugzilla.wikimedia.org/48962#c12 (10JulesWinnfield-hu) Date format for Hungarian is broken. Instead of "1970. január 1." it is "1 január 1970" This is also valid for the {{#property}} parser function on huwiki. It was fine in... [14:23:32] Tobi_WMDE_SW: it's probably an issue in the code itself [14:24:52] (03PS3) 10Daniel Kinzler: Extract change coalescing logic from ChangeHandler. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 [14:25:26] Uncaught Error: For creating a new claim, at least a Main Snak is required [14:28:28] (03CR) 10jenkins-bot: [V: 04-1] Extract change coalescing logic from ChangeHandler. [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 (owner: 10Daniel Kinzler) [14:29:43] (03CR) 10Daniel Kinzler: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 (owner: 10Daniel Kinzler) [14:30:20] (03CR) 10Aude: "don't think we need all the since tags. some are wrong." (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 (owner: 10Daniel Kinzler) [14:31:27] 3MediaWiki extensions / 3WikidataRepo: Stopping edit mode in full sitelinklistview removes the table head - 10https://bugzilla.wikimedia.org/73310 (10Adrian Lang) 3NEW p:3Unprio s:3normal a:3Wikidata bugs Steps: * click edit on a full sitelinklist * click cancel table header is gone. [14:34:08] (03PS1) 10Adrian Lang: Use Xml::encodeJsCall [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172725 [14:36:07] curl 'https://git.wikimedia.org/zip/?r=mediawiki/core.git&format=gz&h=master' [14:36:09] no can haz [14:36:53] aude: works for me [14:37:12] ah [14:48:27] (03CR) 10Daniel Kinzler: [C: 032] "Unhappy about the global state usage in EntityContent, but since this patch doesn't introduce that, it's fine for now." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [14:48:49] * aude not happy also [14:51:14] (03PS1) 10Adrian Lang: Move shared stuff in jquery.wikibase to jquery.wikibase-shared [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172736 [14:52:25] 3MediaWiki extensions / 3WikidataRepo: Time formatting incorrect for some languages - 10https://bugzilla.wikimedia.org/63723#c18 (10JulesWinnfield-hu) 5VERI>3REOP Date format for Hungarian is broken. Instead of "1970. január 1." it is "1 január 1970" This is also valid for the {{#property}} parser functi... [14:55:25] 3MediaWiki extensions / 3WikidataRepo: Unify view-implementations in JS frontend - 10https://bugzilla.wikimedia.org/72666#c4 (10Adrian Lang) Another step I forgot: Write tests for all interfaces, run the tests against the widgets implementing an interface. [14:55:27] (03CR) 10Adrian Lang: "recheck" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170995 (owner: 10Daniel Kinzler) [14:58:00] (03Merged) 10jenkins-bot: Implement EntityParserOutputGeneratorFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171528 (owner: 10Aude) [15:00:44] (03PS4) 10Adrian Lang: Track usage via Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:00:58] (03CR) 10Adrian Lang: "Rebased." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:04:40] 3MediaWiki extensions / 3WikidataRepo: Time formatting incorrect for some languages - 10https://bugzilla.wikimedia.org/63723 (10Lydia Pintscher) p:5Immedi>3Highes s:5critic>3major [15:04:55] 3MediaWiki extensions / 3WikidataClient: Wikidata's JS tool at Wikipedia doesn't recognize Template:category redirect - 10https://bugzilla.wikimedia.org/73254#c2 (10reza1615) For example a category has Template:category_redirect like https://en.wikipedia.org/wiki/Category:1936_in_Indonesia when at local wi... [15:05:15] (03CR) 10Adrian Lang: Track usage via Lua (033 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:06:08] (03CR) 10jenkins-bot: [V: 04-1] Track usage via Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) (owner: 10Daniel Kinzler) [15:07:26] 3MediaWiki extensions / 3WikidataRepo: write browser tests for rank change - 10https://bugzilla.wikimedia.org/67363#c1 (10Adrian Lang) where the patch at huh? Also, does it catch 73307? [15:09:12] 3MediaWiki extensions / 3WikidataRepo: write browser tests for rank change - 10https://bugzilla.wikimedia.org/67363 (10tobias.gritschacher) 5PATC>3ASSI [15:11:47] (03PS5) 10Daniel Kinzler: Track usage via Lua [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172248 (https://bugzilla.wikimedia.org/71288) [15:12:52] Adrian_WMDE: http://wikidata.beta.wmflabs.org/wiki/Q35748 [15:13:05] just click on "add reference" [15:13:43] 3MediaWiki extensions / 3WikidataRepo: After editing a claim's rank, the UI is left in an inconsistent state. - 10https://bugzilla.wikimedia.org/73307 (10Lydia Pintscher) p:5Unprio>3High [15:14:25] 3MediaWiki extensions / 3WikidataRepo: Stopping edit mode in full sitelinklistview removes the table head - 10https://bugzilla.wikimedia.org/73310 (10Lydia Pintscher) p:5Unprio>3Normal [15:14:27] 3MediaWiki extensions / 3WikidataRepo: Stopping edit mode in full sitelinklistview removes the table head - 10https://bugzilla.wikimedia.org/73310 (10Lydia Pintscher) [15:15:47] jzerebecki: https://bugzilla.wikimedia.org/show_bug.cgi?id=73308 <- could you link this to the related bug? [15:23:04] haha, Clojure simply does not support having more than 4 parameters [15:24:54] Tobi_WMDE_SW: https://github.com/Wikidata-lib/PropertySuggester/blob/7b41785af4718d54f4a3bd59e3378683c9589712/modules/ext.PropertySuggester.EntitySelector.js#L108 dunno, I get an old version of that [15:24:55] 3MediaWiki extensions / 3WikidataRepo: Use terms-lookup service in EntityID formatters - 10https://bugzilla.wikimedia.org/72036 (10Christopher Johnson) [15:25:42] aude: ^^ [15:25:59] what Adrian_WMDE says [15:26:14] where does this old JS come from? [15:26:18] Tobi_WMDE_SW: no idea [15:27:34] then let's be surprised how it will look like on test [15:27:49] or in production [15:28:05] the tests on bet will just keep failing [15:28:13] not sure if we want to deploy like that [15:28:42] Lydia_WMDE: i did, as "see also", because i don't think its a blocker [15:29:24] ah missed that [15:31:56] [13WikidataBrowserTests] 15tobijat created 06property_smoke (+1 new commit): 02http://git.io/y5tnuA [15:31:56] 13WikidataBrowserTests/06property_smoke 14279a06d 15Tobias Gritschacher: Adjust property smoke tests... [15:32:16] Henning_WMDE: ^^ [15:32:17] [13WikidataBrowserTests] 15tobijat opened pull request #23: Adjust property smoke tests (06master...06property_smoke) 02http://git.io/-zDaaw [15:32:18] https://github.com/wmde/WikidataBrowserTests/pull/23 [15:32:31] trivial [15:33:57] [13WikidataBrowserTests] 15snaterlicious 04deleted 06property_smoke at 14279a06d: 02http://git.io/9maT3A [15:35:40] 3MediaWiki extensions / 3WikidataRepo: Use terms-lookup service in EntityID formatters - 10https://bugzilla.wikimedia.org/72036 (10Christopher Johnson) [15:39:25] 3MediaWiki extensions / 3WikidataRepo: Use terms-lookup service in EntityID formatters - 10https://bugzilla.wikimedia.org/72036 (10Christopher Johnson) [15:41:41] 3MediaWiki extensions / 3WikidataRepo: Use terms-lookup service in EntityID formatters - 10https://bugzilla.wikimedia.org/72036 (10Christopher Johnson) [15:42:42] (03CR) 10Hoo man: "RE to Adrian. Please reconsider your -1" (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [16:03:19] (03CR) 10Daniel Kinzler: "There seem to be quite a few loose ends that should be marked with a @todo, and I have trouble following the information flow in all detai" (036 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (owner: 10Aude) [16:04:10] 3Wikimedia / 3Wikidata: Add featured portal badge - 10https://bugzilla.wikimedia.org/73193#c4 (10Marius Hoch) 5PATC>3RESO/FIX Change has been deployed, the CSS for the icon will follow with the next Wikidata deploy (should be next week). [16:28:25] 3MediaWiki extensions / 3WikidataRepo: language direction conflicts when ltr and rtl text is displayed in parallel - 10https://bugzilla.wikimedia.org/36635#c8 (10Nemo) Some of the test cases were deleted, but https://www.wikidata.org/wiki/Q1765794?uselang=ar#sitelinks-wikipedia looks ok to me. Can this be cl... [16:28:37] (03PS6) 10Aude: Introduce EntityViewFactory and adjust SnakFormatterFactory [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 [16:29:19] (03CR) 10Aude: "already thought of all the todos and agree with them. plan to get them done in follow up patches. (help with these is welcome)" (035 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172590 (owner: 10Aude) [16:35:50] the timelinks on https://meta.wikimedia.org/wiki/IRC_office_hours time out [16:36:24] not anymore, sorry, it was temporary [16:36:33] * aude panics :P [16:37:23] take your time, breath, breath... [16:37:57] :) [16:42:45] 3Wikimedia / 3Wikidata: ota language displays as ltr on Wikidata - 10https://bugzilla.wikimedia.org/73317 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs ota is a special language added for wikidata. (see bug 57342) it is a rtl language but is treated as ltr. it's probably lacking direction infor... [16:42:55] 3Wikimedia / 3Wikidata: ota language displays as ltr on Wikidata - 10https://bugzilla.wikimedia.org/73317#c1 (10Aude) ota = Ottoman Turkish [16:47:10] 3Wikimedia / 3Wikidata: ota language displays as ltr on Wikidata - 10https://bugzilla.wikimedia.org/73317 (10Dereckson) [16:55:03] " To enjoy this site you'll need to update your Flash Player. It's easy, painless and will take [16:55:03] just a moment... " [16:55:06] JeroenDeDauw: A true functional language only ever needs to support only one parameter :) 4 is a luxury [16:55:07] uhm... how about no [17:11:59] 3Wikimedia / 3Wikidata: ota language displays as ltr on Wikidata - 10https://bugzilla.wikimedia.org/73317 (10Andre Klapper) [17:21:26] * hoo just added the first two featured portal badges https://www.wikidata.org/w/index.php?title=Q3802786&diff=173401392&oldid=167973831 [17:21:43] I wondered whether they're broken because no one did yet :P [17:24:06] no icons, but cool [17:24:10] yet* [17:30:25] (03CR) 10Aude: [C: 032] Use Xml::encodeJsCall [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172725 (owner: 10Adrian Lang) [17:30:55] (03PS2) 10Aude: Use Xml::encodeJsCall in SitesModule [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172725 (owner: 10Adrian Lang) [17:31:14] wonder if it submits the first patch still? [17:31:18] (03CR) 10Aude: Use Xml::encodeJsCall in SitesModule [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172725 (owner: 10Adrian Lang) [17:31:40] (03CR) 10Aude: [C: 032] "updated the commit message to be more specific" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172725 (owner: 10Adrian Lang) [17:39:04] (03Merged) 10jenkins-bot: Use Xml::encodeJsCall in SitesModule [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172725 (owner: 10Adrian Lang) [17:56:40] [13WikidataBrowserTests] 15tobijat created 06adjust_tests (+1 new commit): 02http://git.io/snf7fw [17:56:40] 13WikidataBrowserTests/06adjust_tests 14b4d0c16 15Tobias Gritschacher: Adjust reference tests to removal of exclusive edit-mode [18:19:15] 3MediaWiki extensions / 3WikidataRepo: Batch multiple entity-changes in one request - 10https://bugzilla.wikimedia.org/73319 (10tobias.gritschacher) 3NEW p:3Unprio s:3normal a:3Wikidata bugs We need a possibility to make multiple changes to an entity with one request that results in several "smaller"... [18:19:26] 3MediaWiki extensions / 3WikidataRepo: Batch multiple entity-changes in one request - 10https://bugzilla.wikimedia.org/73319 (10tobias.gritschacher) p:5Unprio>3High [18:19:56] 3MediaWiki extensions / 3WikidataRepo: Investigation: edit conflict for (almost) concurrently save-operations on the same entity - 10https://bugzilla.wikimedia.org/71555 (10tobias.gritschacher) s:5normal>3major [18:30:10] how do i render a wiki page the way it would if it were transcluded? [18:30:27] i.e. https://en.wikipedia.org/wiki/Template:In_the_news?action=render but without the docs [18:30:46] action=parse in the api? [18:30:55] hmm, that's not a full wikipage though [18:32:56] no such action [18:33:00] (03CR) 10Daniel Kinzler: [C: 032] Add UpdateRepoOnDeleteJob (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [18:33:06] ah, i can transclude it and then render that [18:33:08] https://en.wikipedia.org/wiki/User:Denny/In_the_news?action=render [18:33:40] there's a user factory? [18:33:48] DanielK_WMDE_: ^ [18:33:56] hoo: no. make one [18:34:01] trivial [18:34:50] I see :/ So much stuff I'd *like* to do [18:34:54] the wmf has been looking for years and spent millions to make new users [18:35:04] * hoo needs a real life TimeFactory :P [18:35:05] and you say it's trivial to simply make a UserFactory! [18:35:14] hoo: compare the TitleFactory class. The implementation is trivial. SiteLinkUsageLookup uses it. [18:35:36] hoo: its only purpose is to be mocked, so i tests i have control over the page ID as well as the title text [18:35:47] totally makes sense [18:35:51] but should be in core [18:35:54] and yea, I agree with TimeFactory [18:36:00] and yea, that too [18:37:26] dennyvrandecic: yea... why didn't they think of that? [18:38:08] dennyvrandecic: action=parse is not in the api, it's a top level action. i think the corresponding api action is called "render". [18:38:26] other way round [18:38:28] if you look at what they actually do, the names should be the other way around... [18:38:41] hoo: is it? now i confused myself :P [18:39:05] DanielK_WMDE_: ah. that didn't work, it renders like a not-transcluded page, which is fine, but i wonder how to make it look like it is transcluded [18:39:07] Yeah, it is :D [18:39:13] (03Merged) 10jenkins-bot: Add UpdateRepoOnDeleteJob [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/170528 (https://bugzilla.wikimedia.org/49100) (owner: 10Hoo man) [18:39:18] Reedy: can you tell the API to treat / as if the thing was included? how does parsoid deal with this? [18:39:32] aude: ^ can we backport that into the branch (now that it's painless) [18:39:43] dennyvrandecic: ask the parsoid people, they should have the same problem, i think [18:39:44] So that it's around when we make use of it [18:40:03] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Removed focus smartness from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171555 (https://bugzilla.wikimedia.org/54019) (owner: 10Henning Snater) [18:40:12] DanielK_WMDE_: You can use action=parse and have it parse {{:YourTitle}} [18:40:28] api action [18:40:31] hoo: ha, so simple :) [18:40:34] dennyvrandecic: --^ [18:40:52] api.php?action=parse&text={{PAGENAME}}&title=Foo [18:40:55] like that [18:41:08] title is the context (like the page which would include your page) [18:41:49] hoo: ok wiht me [18:42:08] aude: did you create the Wikidata branch as well [18:42:08] might be too much stuff (e.g. not a bug fix) though [18:42:10] or only Wikibase [18:42:11] i did [18:42:19] otherwise we'd be running out of time [18:42:20] mh [18:42:37] We can also delay it, but that'll make the actual deploy much more painful [18:42:38] we'll have to discuss when we branch again after this [18:42:51] so either wait a whole more week for the next patch [18:42:54] ok to backport imho [18:42:55] or backport that job [18:43:10] hoo: yeah, that returns me the result wrapped. the browser doesn't simply display the html [18:43:13] s/week/branch lifetime/ [18:43:23] dennyvrandecic: Oh, I see what you want [18:43:34] but you wont get that, the API is supposed to prevent that from happening [18:43:38] * aude is on holiday in 2 weeks, so doing a branch depends if someone else wants to take care of it [18:43:39] :D [18:43:45] e.g. be around for deployuments [18:43:45] I made it like this: https://en.wikipedia.org/wiki/User:Denny/In_the_news?action=render [18:44:08] aude: Wait... in the week of the 24th? [18:44:13] yes, sadly [18:44:19] you can have my desk [18:44:19] oh :/ [18:44:24] It's something [18:44:26] sit next to daniel :) [18:44:35] But it only has one external screen :P [18:44:45] * hoo is a screen space addict [18:44:50] steal one from somewhere [18:45:01] hehe :) [18:45:15] (03Merged) 10jenkins-bot: Removed focus smartness from snakview [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171555 (https://bugzilla.wikimedia.org/54019) (owner: 10Henning Snater) [18:45:18] but if it's that week, I can take care of the branch [18:45:19] (03CR) 10jenkins-bot: [V: 04-1] Removed obsolete $.TemplatedWidget alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171567 (owner: 10Henning Snater) [18:45:21] it's the best news page of the world :) no sensationalism, not too much stuff, you get all the important things... [18:45:29] 3MediaWiki extensions / 3WikidataRepo: language direction conflicts when ltr and rtl text is displayed in parallel - 10https://bugzilla.wikimedia.org/36635#c9 (10reza1615) 5NEW>3RESO/WOR https://www.wikidata.org/w/index.php?diff=131600143 and fa:علی‌آباد (بستان‌آباد) at https://www.wikidata.org/wiki/Q48... [18:45:42] and wikipedia deployment the following week also [18:45:51] * aude would be available the tuesday [18:46:46] mh, not sure I can be around for the Wednesday deploy [18:46:52] hmmm [18:47:00] then we'll have to discuss with tobi and lydia [18:47:16] * aude will be on an airplane, so unless they have wifi and power... [18:47:44] but the airplane is usually an old one [18:48:07] dennyvrandecic: neat! when the news items can be represented in a language neutral way, using wikidata as a vocabulary, then the world will be a better place :)( [18:48:09] Might be that I'm around... might be that I'm not, can't really tell [18:48:17] maybe I can in two weeks [18:48:23] thinking about it, probably not [18:48:27] ok [18:48:57] DanielK_WMDE_: sweet idea! i might steal it [18:49:01] (03CR) 10Thiemo Mättig (WMDE): [C: 04-1] "Just a few days ago I removed all dead href="#" links. They don't do anything and are just pointless and confusing. Why are they needed? W" [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [18:49:15] don't have to decide now [18:50:02] (03CR) 10Hoo man: "The idea is to minimize DOM changes by JS." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [18:50:24] Thiemo_WMDE: also that's sounds like a -2 if I get you right [18:50:27] * that [18:50:31] dennyvrandecic: should already work pretty well for the nouns, but for expressing relationships and interactions, more specialized vocab may be needed. [18:50:45] (03CR) 10Thiemo Mättig (WMDE): "Also this patch seems to contain a lot of unrelated changes to code that's not or barely involved in "creating add links". Can you please " [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [18:51:15] (03CR) 10Hoo man: "All changes were needed to make this work." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [18:51:18] hoo: If you replace the href="#" with an actual URL it's not a -2. [18:51:27] ask Amir Aharoni about this [18:51:28] Otherwise it is, thats true. [18:51:33] he knows how to do this [18:52:04] the technology is for a large part in the translate tool [18:52:22] also Wikidata needs lexicological functionality [18:52:41] GerardM-: yeah, that's the one major piece missing [18:52:55] do you hear Lydia_WMDE? [18:53:02] it is not hard not really [18:53:28] I disagree with the idea that "minimizing DOM changes" is worth it. If you hide the elements it doesn't matter performance-wise if they are just hidden or not there at all. It's a reflow anyway. [18:53:40] 3MediaWiki extensions / 3WikidataClient: When page is deleted, sitelink should be removed - 10https://bugzilla.wikimedia.org/49100#c12 (10Marius Hoch) Just to keep you updated: The first steep to make this work has been merged today. But it will take at least 3 more weeks to get this to actually work. [18:54:04] it starts with an experiment [18:54:07] GerardM-: the hard part is the consensus on what exactly needs to be done ;) [18:54:08] Thiemo_WMDE: They'll only be hidden on non-CSS views [18:54:10] * JS [18:54:17] and Magnus does it for quite some time already [18:54:18] and only unless we have no-JS links figured out [18:54:26] 3Wikimedia / 3Wikidata: Add featured portal badge - 10https://bugzilla.wikimedia.org/73193#c5 (10orlodrim) Thanks Marius! [18:54:33] no [18:54:42] forget about consensus [18:54:45] but in the past the fallback links were controversial, taht's why we don't yet have them [18:54:48] build things that work now [18:54:53] and build up on that [18:54:57] What's the problem with readding these links if we have no-JS URLs for them? [18:55:16] GerardM-: i hear ya :) I never was a huge fan of consensus, but rather of getting **it done [18:55:24] consensus is all too often an excuse for doing nothing [18:55:31] Again, whats the benefit? [18:55:45] Performance-wise it changes nothing. [18:55:51] to not redraw on document.ready [18:55:53] All it does is adding dead code. [18:55:59] well, amount of dom changes reduced [18:56:15] but true, the CSS rule needs to die for that to have a bigger effect [18:56:21] It will redraw no matter what if you hiode the elements with CSS and make them visible with JS. [18:56:35] DOM-changes are no performance bottleneck. [18:56:55] I only hide it in CSS if .client-nojs is set [18:57:03] or however that class is called [18:57:07] I keep forgetting it [18:57:27] Well... ori wouldn't have made that bug if it weren't noticable somehow [18:57:30] Then the user may see dead links and accidentially click them before they are replaced. [18:57:49] the CSS is loaded in head, so that wont happen [18:58:04] oh, I see what you mean [18:58:05] sorry [18:58:12] yeah, that *can* actually happen [18:58:36] but I tested that and it never happened for me [18:58:48] Just one of many arguments why I really don't want a single href="#" or void() in our code. Just no. [18:58:51] the onclick is always set before I can click something [19:00:10] Your patch is doing a JS-job in PHP and I don't get what the benefit of that should be. [19:00:16] I'm totally fine with having nojs links in there (for logged in users only that is) [19:00:25] if you are willing to +2 that, I'll amend the patch sometime [19:00:30] If it's a JS-only link then create it in JS. That's it. [19:01:19] dennyvrandecic: Can you remember why we decided to not have links to Wikidata Special:CreateItem in the sidebar of articles without sitelinks? [19:01:27] (for non JS users) [19:01:27] I'm just thinking about a -2, not a +2. [19:01:40] I don't want it to be JS only [19:01:44] but it is :/ [19:02:12] Early 2013 we decided that, back then linkItem got introduced [19:02:25] but I can't remember why we didn't do fallback links [19:02:38] hoo: the storyboards back then where able to create a new item if no matching was found [19:02:52] aude was working on the storyboards with me [19:03:15] Yeah... I remember that... but I also remember we decided to not have any link there for non-JS users [19:03:26] but I have no idea why? [19:03:28] ah, for non-JS, missed that [19:03:33] Diverging user experience? [19:04:06] * hoo would still like to have non-JS links there [19:04:10] Special:CreateItem I think at first wasn't able to be preloaded per URI [19:04:14] for logged in users only, like the widget [19:04:14] per get URL [19:04:23] mh, that might have been the case [19:04:29] in that case the UX would be too broken [19:04:39] but that's all fixed now [19:04:52] Yeah, so that reason is gone and the decision was not revisited [19:05:16] I guess the decision can be revisited now [19:05:24] IMO we should do that [19:05:31] * aude agrees with dennyvrandecic [19:05:49] Thiemo_WMDE: In that case you would be ok with the rest of the patch (in general, no implementation details)? [19:08:46] hoo: what case? [19:09:28] Thiemo_WMDE: In the case we add non-JS links [19:09:36] * a non-Js link [19:10:05] (03CR) 10Thiemo Mättig (WMDE): [C: 04-2] Create add links link in PHP (032 comments) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/168632 (https://bugzilla.wikimedia.org/61391) (owner: 10Hoo man) [19:10:48] I already said that. If there is a a static link to put into the href="...", sure. [19:11:41] :S That tiny change already blew up beyond what's reasonable [19:11:49] I didn't even think the change would need to be so big [19:11:58] Split it. [19:13:22] As I said, I just recently removed a whole lot of these annoying href="#" fakes. But if I remember correctly only dead "edit" links, "add" link were never created in PHP. [19:26:30] (03CR) 10Thiemo Mättig (WMDE): Remove singleton pattern from TemplateRegistry (031 comment) [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172681 (owner: 10Adrian Lang) [19:34:45] (03CR) 10Thiemo Mättig (WMDE): "It's indented by one tab just like everything we do. What do you mean? I did not put the function parameters on separate lines on purpose." [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172289 (owner: 10Thiemo Mättig (WMDE)) [19:35:15] (03PS4) 10Thiemo Mättig (WMDE): Removed obsolete $.TemplatedWidget alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171567 (owner: 10Henning Snater) [19:36:37] (03CR) 10Thiemo Mättig (WMDE): [C: 032] Removed obsolete $.TemplatedWidget alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171567 (owner: 10Henning Snater) [19:44:53] (03Merged) 10jenkins-bot: Removed obsolete $.TemplatedWidget alias [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/171567 (owner: 10Henning Snater) [19:48:26] /window 10 [19:48:42] /doh [19:50:32] aaaa [19:50:39] :D [20:16:27] Guys, what you done with "Also known as" editing? =( [20:17:13] putnik: what about it? what is the issue? [20:17:42] there is a bug that when clicking edit, it doesn't auto focus on the input box [20:18:16] appears fixed for next deploy next week [20:18:28] aude, this bug is also VERY annoying. But now I can't save them at all. [20:18:54] can't save? [20:19:05] * aude looks [20:31:49] aude, it works for second language, but not for first =( [20:33:16] mh [20:33:22] oh, within the "other languages" section ? [20:33:23] I only used it today and it worked fine [20:33:33] but that was before the MW train [20:33:48] oh wait, it's Wednesday, so the deploy doesn't matter [20:34:00] yeah [20:35:06] hoo, it didn't work today morning too. [20:35:18] Did you get any JS error? [20:38:47] hoo, yes. [20:40:15] Can you paste it? [20:41:13] http://pastebin.com/bjiDYZiB [20:41:48] This one when I try to edit label. [20:42:45] Looks like the same when edit alias. [20:42:55] I see [20:43:01] might be a gadget [20:43:12] It's when I click "edit", not when try to save. [20:43:39] hoo, I tried to disable all gadgets, but it not helped. [20:44:02] does it happen on all items? [20:44:15] with debug=true ? [20:44:20] logged out? [20:45:24] aude, with debug=true it works. [20:45:55] :/ [20:45:59] Might be some kind of caching [20:46:13] I don't personally cache beyond browser sessions, so I can't reproduce it [20:46:24] (tried with both debug true/false, several items) [20:46:44] i can't reproduce either [20:49:17] I can't see anything obvious... the template library changes aren't applied on Wikidata at all [20:49:48] yeah and we backported the change to fix the naming conflict [20:50:11] my guess is caching and maybe somethign is confused about that [20:50:31] yeah, probably [20:50:43] putnik: Did you try clearing your cache, yet? [20:52:40] 3MediaWiki extensions / 3WikidataRepo: jQuery.wikibase.***view widgets "startEditing" should not be smart about focus - 10https://bugzilla.wikimedia.org/54019 (10Lydia Pintscher) 5PATC>3RESO/FIX [22:10:08] (03PS1) 10Aude: don't show top dashed border on wikibase-toolbar-wrapper for new statements [extensions/Wikibase] - 10https://gerrit.wikimedia.org/r/172897 [22:10:44] 3MediaWiki extensions / 3WikidataRepo: can keep clicking "add" for new statements to "add" multiple at the same time - 10https://bugzilla.wikimedia.org/73330 (10Aude) 3NEW p:3Unprio s:3normal a:3Wikidata bugs click to "add" a new statement and then the "add" new statement button is still enabled, so... [22:12:13] 3MediaWiki extensions / 3WikidataRepo: can keep clicking "add" for new statements to "add" multiple at the same time - 10https://bugzilla.wikimedia.org/73330#c1 (10Aude) this issue does not occur for me on test.wikidata [23:39:54] ds [23:39:58] HELLO [23:58:25] 3MediaWiki extensions / 3WikidataRepo: Query by one property and one value (tracking) - 10https://bugzilla.wikimedia.org/52385#c6 (10Ryan Kaldari) Thanks for the update Lydia. Can you specify which of the "depends on" bugs are actual blockers? That will make it easier for external folks to get an idea of the...